From owner-cvs-all Sun Aug 20 0:39:38 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 7823F37B422; Sun, 20 Aug 2000 00:39:31 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id RAA10489; Sun, 20 Aug 2000 17:39:25 +1000 Date: Sun, 20 Aug 2000 17:39:20 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Brian Fundakowski Feldman Cc: "Andrey A. Chernov" , Marcel Moolenaar , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile config.h job.c main.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 19 Aug 2000, Brian Fundakowski Feldman wrote: > On Sun, 20 Aug 2000, Andrey A. Chernov wrote: > > > On Sun, Aug 20, 2000 at 07:55:20AM +1000, Bruce Evans wrote: > > > They seem to be remarkably broken. A POSIX.2 draft specifies that make > > > shall support the SHELL variable, but our make doesn't. (SHELL has the > > > [deleted] The "[deleted]" part was mostly wrong. The SHELL environment variable is required not to affect the shell used by `make'. Only definitions of SHELL in makefiles and on the command line affect the shell used by make. SHELL must be set to a default by `make'. > > > I'm not sure if .SHELL has any advantages over SHELL. Anyway, SHELL should > > > be fixed first since it is standard. The fix may be as simple as setting > > > > Thanks, Bruce, it is what I try to say from the very beginning of this > > thread. > > So we should make pmake support ${SHELL}? This would allow me to > change it on all compiles easily, but it would break things all over > the place because things set SHELL without expecting make(1) to be > using that shell. No problem, since make is not permitted to use these. There is a minor problem with implementing the default setting of SHELL in sys.mk. The current "SHELL ?= sh" usually gives the environment value. > The only functionality I really need is the ability > to override the default shell value. Even the variable ${SHELL} does > not provide that. I think .SHELL: path=ksh in /etc/make.conf.local is supposed to do this, but it currently gives core dumps for freeing of a bad pointer. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message