Date: Sat, 29 Apr 2000 14:10:39 +0100 From: Joe Karthauser <joe@pavilion.net> To: Mike Heffner <spock@techfour.net> Cc: FreeBSD-audit <FreeBSD-audit@freebsd.org> Subject: Re: three small patches - oflows Message-ID: <20000429141039.A48739@pavilion.net> In-Reply-To: <XFMail.20000320021242.mheffner@mailandnews.com>; from mheffner@mailandnews.com on Mon, Mar 20, 2000 at 02:12:42AM -0500 References: <XFMail.20000320021242.mheffner@mailandnews.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 20, 2000 at 02:12:42AM -0500, Mike Heffner wrote: > > Index: bin/ed/main.c I'll commit this when I next get connected. I've changed the second patch slightly to: REALLOC(file, filesz, MAXPATHLEN + 1, NULL); - /* assert: no trailing escape */ - while ((file[i++] = (*s == '\\') ? *++s : *s)) + while (i < filesz - 1 /* Worry about a possible trailing escape */ + && (file[i++] = (*s == '\\') ? *++s : *s)) s++; return file; > - natd patch, fixes "natd -w [17000] blah" overflow > Index: sbin/natd/natd.c This too looks good. > - startslip patch, fixes "startslip -d [8192] -c [8192]" overflow > Index: sbin/startslip/startslip.c This too. I'll commit them all on Sunday or Monday. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000429141039.A48739>