From owner-freebsd-audit Sun Dec 10 4:42:43 2000 From owner-freebsd-audit@FreeBSD.ORG Sun Dec 10 04:42:40 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from genius.tao.org.uk (genesis.tao.org.uk [194.242.131.94]) by hub.freebsd.org (Postfix) with ESMTP id 84CBB37B402; Sun, 10 Dec 2000 04:42:36 -0800 (PST) Received: by genius.tao.org.uk (Postfix, from userid 100) id 090809B05; Sun, 10 Dec 2000 12:48:33 +0000 (GMT) Date: Sun, 10 Dec 2000 12:48:33 +0000 From: Josef Karthauser To: Chris Faulhaber Cc: imp@freebsd.org, freebsd-audit@FreeBSD.ORG Subject: Re: crunchgen(8) patch (again) Message-ID: <20001210124833.B84921@bsdi.com> References: <20001203072512.A86744@earth.causticlabs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001203072512.A86744@earth.causticlabs.com>; from jedgar@fxp.org on Sun, Dec 03, 2000 at 07:25:12AM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I'll take this one - I've got local patches to crunchgen in my tree that I'm going to commit pending review on freebsd-small. After that I'm going to style(9) it and will incorporate these patches during that process. Warner, did you say that you also had patches to crunchgen? Joe On Sun, Dec 03, 2000 at 07:25:12AM -0500, Chris Faulhaber wrote: > The following patch fixes: > > o check strdup() return values > o strcpy() -> strlcpy() > o sprintf() -> snprintf() > o mktemp() -> mkstemp() > o use err() instead of errx() in out_of_memory() function since > errno will probably be set > > Also, I have quite a few small patches for review at: > http://www.fxp.org/~jedgar/FreeBSD/diffs/ > > -- > Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org > -------------------------------------------------------- > FreeBSD: The Power To Serve - http://www.FreeBSD.org -- Josef Karthauser [joe@FreeBSD.org, joe@tao.org.uk] ......... FreeBSD: The power to change the world ........ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Dec 10 4:45:47 2000 From owner-freebsd-audit@FreeBSD.ORG Sun Dec 10 04:45:42 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from genius.tao.org.uk (genesis.tao.org.uk [194.242.131.94]) by hub.freebsd.org (Postfix) with ESMTP id 1A51937B400; Sun, 10 Dec 2000 04:45:42 -0800 (PST) Received: by genius.tao.org.uk (Postfix, from userid 100) id E3E319B05; Sun, 10 Dec 2000 12:51:43 +0000 (GMT) Date: Sun, 10 Dec 2000 12:51:43 +0000 From: Josef Karthauser To: Robert Watson Cc: markm@freebsd.org, audit@FreeBSD.ORG Subject: Re: Solicitation for auditing process announcement Message-ID: <20001210125143.C84921@bsdi.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from rwatson@FreeBSD.ORG on Thu, Nov 30, 2000 at 11:46:08PM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Nov 30, 2000 at 11:46:08PM -0500, Robert Watson wrote: > > On Thu, 30 Nov 2000, Matthew Jacob wrote: > > > >indicating that audit@ is willing to do review-on-demand and should be > > > > What does 'review on demand' mean? > > It means that we're too laid back to have figured out rigorous, pro-active > re-auditing of the source tree, and instead we sit there and wait until > someone e-mails audit@ saying, ``I'm going to make the following stupid > changes to the following setuid binaries, could you take a look and OK > them before I drive-by commit them twenty minutes before the release?'' Mark Murray was talking about the possiblity of having an audit database to allow us to check what's been audited down to a granularity of a line of source code. How useful is this? Joe -- Josef Karthauser [joe@FreeBSD.org, joe@tao.org.uk] ......... FreeBSD: The power to change the world ........ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Dec 10 7: 6: 1 2000 From owner-freebsd-audit@FreeBSD.ORG Sun Dec 10 07:06:00 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 9F80037B400 for ; Sun, 10 Dec 2000 07:05:59 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eBAF5vs62991; Sun, 10 Dec 2000 08:05:58 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id IAA28781; Sun, 10 Dec 2000 08:05:57 -0700 (MST) Message-Id: <200012101505.IAA28781@harmony.village.org> To: Josef Karthauser Subject: Re: crunchgen(8) patch (again) Cc: Chris Faulhaber , freebsd-audit@freebsd.org In-reply-to: Your message of "Sun, 10 Dec 2000 12:48:33 GMT." <20001210124833.B84921@bsdi.com> References: <20001210124833.B84921@bsdi.com> <20001203072512.A86744@earth.causticlabs.com> Date: Sun, 10 Dec 2000 08:05:57 -0700 From: Warner Losh Sender: imp@harmony.village.org Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20001210124833.B84921@bsdi.com> Josef Karthauser writes: : Warner, did you say that you also had patches to crunchgen? No. Not crunchgen. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Dec 10 8:17:34 2000 From owner-freebsd-audit@FreeBSD.ORG Sun Dec 10 08:17:33 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 293BD37B400; Sun, 10 Dec 2000 08:17:28 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id eBAGH2I29698; Sun, 10 Dec 2000 18:17:10 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200012101617.eBAGH2I29698@gratis.grondar.za> To: Josef Karthauser Cc: Robert Watson , markm@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: Solicitation for auditing process announcement References: <20001210125143.C84921@bsdi.com> In-Reply-To: <20001210125143.C84921@bsdi.com> ; from Josef Karthauser "Sun, 10 Dec 2000 12:51:43 GMT." Date: Sun, 10 Dec 2000 18:16:49 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Mark Murray was talking about the possiblity of having an audit > database to allow us to check what's been audited down to a > granularity of a line of source code. Actually, the easiest to code by far (and I'm going to see if I can doo this in my Christmas vacation) is on a per-revision-Id basis. I'm hoping to borg cvsweb to do this with some kind of backend. M -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Dec 12 12:54:10 2000 From owner-freebsd-audit@FreeBSD.ORG Tue Dec 12 12:54:07 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 9148E37B400 for ; Tue, 12 Dec 2000 12:54:06 -0800 (PST) Received: from earth.causticlabs.com (oca-c1s6-34.mfi.net [209.26.31.27]) by peitho.fxp.org (Postfix) with ESMTP id E45E81360E; Tue, 12 Dec 2000 15:54:05 -0500 (EST) Received: by earth.causticlabs.com (Postfix, from userid 1000) id 235151F23; Tue, 12 Dec 2000 15:54:48 -0500 (EST) Date: Tue, 12 Dec 2000 15:54:48 -0500 From: Chris Faulhaber To: Warner Losh Cc: freebsd-audit@FreeBSD.ORG Subject: Re: mktemp(1) usage Message-ID: <20001212155447.A21073@earth.causticlabs.com> Mail-Followup-To: Chris Faulhaber , Warner Losh , freebsd-audit@FreeBSD.ORG References: <20001209150853.A57045@peitho.fxp.org> <200012100526.WAA26396@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200012100526.WAA26396@harmony.village.org>; from imp@village.org on Sat, Dec 09, 2000 at 10:26:06PM -0700 Sender: jedgar@earth.causticlabs.com Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Dec 09, 2000 at 10:26:06PM -0700, Warner Losh wrote: > In message <20001209150853.A57045@peitho.fxp.org> Chris Faulhaber writes: > : Would it be more appropriate for scripts such as periodic(8) to > : call mktemp(1) using the -t flag. In addition to using TMPDIR, > : this allows the use of the system's _PATH_TMP instead of > : hardcoding /tmp. > > I think so. > The following takes care of the few mktemp(1) uses in the tree. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: etc/rc =================================================================== RCS file: /home/ncvs/src/etc/rc,v retrieving revision 1.240 diff -u -r1.240 rc --- etc/rc 2000/11/21 04:21:54 1.240 +++ etc/rc 2000/12/12 20:53:06 @@ -589,7 +589,7 @@ [Nn][Oo] | '') ;; *) - if T=`mktemp /tmp/_motd.XXXXXX`; then + if T=`mktemp -t _motd`; then uname -v | sed -e 's,^\([^#]*\) #\(.* [1-2][0-9][0-9][0-9]\).*/\([^\]*\) $,\1 (\3) #\2,' > ${T} awk '{if (NR == 1) {if ($1 == "FreeBSD") {next} else {print "\n"$0}} else {print}}' < /etc/motd >> ${T} cmp -s ${T} /etc/motd || { Index: usr.bin/locate/locate/concatdb.sh =================================================================== RCS file: /home/ncvs/src/usr.bin/locate/locate/concatdb.sh,v retrieving revision 1.10 diff -u -r1.10 concatdb.sh --- usr.bin/locate/locate/concatdb.sh 2000/01/12 08:01:00 1.10 +++ usr.bin/locate/locate/concatdb.sh 2000/12/12 20:53:06 @@ -56,7 +56,7 @@ esac -bigrams=`mktemp ${TMPDIR=/tmp}/_bigrams.XXXXXXXXXX` || exit 1 +bigrams=`mktemp -t _bigrams` || exit 1 trap 'rm -f $bigrams' 0 1 2 3 5 10 15 for db Index: usr.bin/locate/locate/mklocatedb.sh =================================================================== RCS file: /home/ncvs/src/usr.bin/locate/locate/mklocatedb.sh,v retrieving revision 1.10 diff -u -r1.10 mklocatedb.sh --- usr.bin/locate/locate/mklocatedb.sh 2000/01/12 08:01:00 1.10 +++ usr.bin/locate/locate/mklocatedb.sh 2000/12/12 20:53:06 @@ -39,7 +39,7 @@ : ${TMPDIR:=/tmp}; export TMPDIR test -d "$TMPDIR" || TMPDIR=/tmp -if ! TMPDIR=`mktemp -d $TMPDIR/mklocateXXXXXXXXXX`; then +if ! TMPDIR=`mktemp -d -t mklocate`; then exit 1 fi Index: usr.bin/locate/locate/updatedb.sh =================================================================== RCS file: /home/ncvs/src/usr.bin/locate/locate/updatedb.sh,v retrieving revision 1.17 diff -u -r1.17 updatedb.sh --- usr.bin/locate/locate/updatedb.sh 2000/01/12 08:01:01 1.17 +++ usr.bin/locate/locate/updatedb.sh 2000/12/12 20:53:06 @@ -36,7 +36,7 @@ # The directory containing locate subprograms : ${LIBEXECDIR:=/usr/libexec}; export LIBEXECDIR : ${TMPDIR:=/tmp}; export TMPDIR -if ! TMPDIR=`mktemp -d $TMPDIR/locateXXXXXXXXXX`; then +if ! TMPDIR=`mktemp -d -t locate`; then exit 1 fi Index: usr.sbin/periodic/periodic.sh =================================================================== RCS file: /home/ncvs/src/usr.sbin/periodic/periodic.sh,v retrieving revision 1.19 diff -u -r1.19 periodic.sh --- usr.sbin/periodic/periodic.sh 2000/11/26 03:37:34 1.19 +++ usr.sbin/periodic/periodic.sh 2000/12/12 20:53:06 @@ -27,7 +27,7 @@ host=`hostname` export host -tmp_output=`mktemp ${TMPDIR:-/tmp}/periodic.XXXXXXXXXX` +tmp_output=`mktemp -t periodic` # Execute each executable file in the directory list. If the x bit is not # set, assume the user didn't really want us to muck with it (it's a To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Dec 12 18: 6:56 2000 From owner-freebsd-audit@FreeBSD.ORG Tue Dec 12 18:06:53 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123]) by hub.freebsd.org (Postfix) with ESMTP id 2D1B437B400 for ; Tue, 12 Dec 2000 18:06:53 -0800 (PST) Received: (from kris@localhost) by citusc.usc.edu (8.9.3/8.9.3) id SAA10996; Tue, 12 Dec 2000 18:08:05 -0800 Date: Tue, 12 Dec 2000 18:08:05 -0800 From: Kris Kennaway To: Warner Losh Cc: Will Andrews , Chris Faulhaber , freebsd-audit@FreeBSD.ORG Subject: Re: mktemp(1) usage Message-ID: <20001212180805.B10901@citusc.usc.edu> References: <20001209171334.J671@puck.firepipe.net> <20001209150853.A57045@peitho.fxp.org> <20001209171334.J671@puck.firepipe.net> <200012100529.WAA26442@harmony.village.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200012100529.WAA26442@harmony.village.org>; from imp@village.org on Sat, Dec 09, 2000 at 10:29:50PM -0700 Sender: kris@citusc.usc.edu Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 09, 2000 at 10:29:50PM -0700, Warner Losh wrote: > In message <20001209171334.J671@puck.firepipe.net> Will Andrews writes: > : On Sat, Dec 09, 2000 at 03:08:54PM -0500, Chris Faulhaber wrote: > : > Would it be more appropriate for scripts such as periodic(8) to > : > call mktemp(1) using the -t flag. In addition to using TMPDIR, > : > this allows the use of the system's _PATH_TMP instead of > : > hardcoding /tmp. > :=20 > : Maybe that method doesn't use a random enough number to avoid file > : races? >=20 > If it doesn't, then maybe it should, don't you think. But I think it > does. We're looking at 8 X's. It would also be a good place to bump > it to 10 if we needed to, say. No need - with the old method of mktemp() encoding you needed more than 6 X's to be secure, but with the new dense encoding even 6 is fine. Moreover, mktemp(1) is actually mkstemp(1), so there was never any problem with it unless you use -u. Kris --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6NtoFWry0BWjoQKURAuEqAKDrLKeDObu85IrOabkRumKaNwQ3/wCg4QY6 1pBI6GbbtK5hGZeEb1f89pk= =MYnl -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Dec 12 18:12: 7 2000 From owner-freebsd-audit@FreeBSD.ORG Tue Dec 12 18:12:05 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123]) by hub.freebsd.org (Postfix) with ESMTP id 0D7B637B402; Tue, 12 Dec 2000 18:12:05 -0800 (PST) Received: (from kris@localhost) by citusc.usc.edu (8.9.3/8.9.3) id SAA11088; Tue, 12 Dec 2000 18:13:22 -0800 Date: Tue, 12 Dec 2000 18:13:22 -0800 From: Kris Kennaway To: Kris Kennaway Cc: Warner Losh , Will Andrews , Chris Faulhaber , freebsd-audit@FreeBSD.ORG Subject: Re: mktemp(1) usage Message-ID: <20001212181322.C10901@citusc.usc.edu> References: <20001209171334.J671@puck.firepipe.net> <20001209150853.A57045@peitho.fxp.org> <20001209171334.J671@puck.firepipe.net> <200012100529.WAA26442@harmony.village.org> <20001212180805.B10901@citusc.usc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f" Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20001212180805.B10901@citusc.usc.edu>; from kris@FreeBSD.ORG on Tue, Dec 12, 2000 at 06:08:05PM -0800 Sender: kris@citusc.usc.edu Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2000 at 06:08:05PM -0800, Kris Kennaway wrote: > On Sat, Dec 09, 2000 at 10:29:50PM -0700, Warner Losh wrote: > > In message <20001209171334.J671@puck.firepipe.net> Will Andrews writes: > > : On Sat, Dec 09, 2000 at 03:08:54PM -0500, Chris Faulhaber wrote: > > : > Would it be more appropriate for scripts such as periodic(8) to > > : > call mktemp(1) using the -t flag. In addition to using TMPDIR, > > : > this allows the use of the system's _PATH_TMP instead of > > : > hardcoding /tmp. > > :=20 > > : Maybe that method doesn't use a random enough number to avoid file > > : races? > >=20 > > If it doesn't, then maybe it should, don't you think. But I think it > > does. We're looking at 8 X's. It would also be a good place to bump > > it to 10 if we needed to, say. >=20 > No need - with the old method of mktemp() encoding you needed more > than 6 X's to be secure, but with the new dense encoding even 6 is > fine. Moreover, mktemp(1) is actually mkstemp(1), so there was never > any problem with it unless you use -u. Forgot to mention that the new mktemp() hasn't yet been MFC'ed - it's in my merge folder but I didn't get time to do it before I left the US. That should be done before merging any patches which reduce the number of X's in use. Kris --aVD9QWMuhilNxW9f Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6NttCWry0BWjoQKURAhV+AJ4g1V1tsbPbEwnbKhJSgdTtMu9GNwCglMcv IYuGr9qzG9t7+l46SHLCrCQ= =MZDr -----END PGP SIGNATURE----- --aVD9QWMuhilNxW9f-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Dec 13 7:32:57 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 13 07:32:52 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id D550C37B400 for ; Wed, 13 Dec 2000 07:32:50 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1000) id 49DEF1360E; Wed, 13 Dec 2000 10:32:56 -0500 (EST) Date: Wed, 13 Dec 2000 10:32:56 -0500 From: Chris Faulhaber To: freebsd-audit@FreeBSD.org Subject: cron(8) fixes Message-ID: <20001213103256.A78152@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , freebsd-audit@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG There appear to be a few instances where buffers could be potentially overflowed. In addition, the mkprints() return value is not checked before using/free()'ing, and a warn() call appears to use an incorrect format operator (-Wall fix). Most of the sprintf() -> snprintf() changes are recommended, the other few are for consistency. -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org Index: cron/do_command.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/cron/cron/do_command.c,v retrieving revision 1.19 diff -u -r1.19 do_command.c --- cron/do_command.c 2000/07/02 04:15:15 1.19 +++ cron/do_command.c 2000/12/13 15:21:27 @@ -178,6 +178,8 @@ */ /*local*/{ char *x = mkprints((u_char *)e->cmd, strlen(e->cmd)); + if (x == NULL) + err(ERROR_EXIT, "mkprints"); log_it(usernm, getpid(), "CMD", x); free(x); Index: lib/entry.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/cron/lib/entry.c,v retrieving revision 1.11 diff -u -r1.11 entry.c --- lib/entry.c 2000/05/23 13:44:00 1.11 +++ lib/entry.c 2000/12/13 15:21:27 @@ -333,7 +333,7 @@ } if (!env_get("SHELL", e->envp)) { prev_env = e->envp; - sprintf(envstr, "SHELL=%s", _PATH_BSHELL); + snprintf(envstr, sizeof(envstr), "SHELL=%s", _PATH_BSHELL); e->envp = env_set(e->envp, envstr); if (e->envp == NULL) { warn("env_set(%s)", envstr); @@ -343,7 +343,7 @@ } } prev_env = e->envp; - sprintf(envstr, "HOME=%s", pw->pw_dir); + snprintf(envstr, sizeof(envstr), "HOME=%s", pw->pw_dir); e->envp = env_set(e->envp, envstr); if (e->envp == NULL) { warn("env_set(%s)", envstr); @@ -353,7 +353,7 @@ } if (!env_get("PATH", e->envp)) { prev_env = e->envp; - sprintf(envstr, "PATH=%s", _PATH_DEFPATH); + snprintf(envstr, sizeof(envstr), "PATH=%s", _PATH_DEFPATH); e->envp = env_set(e->envp, envstr); if (e->envp == NULL) { warn("env_set(%s)", envstr); @@ -363,7 +363,7 @@ } } prev_env = e->envp; - sprintf(envstr, "%s=%s", "LOGNAME", pw->pw_name); + snprintf(envstr, sizeof(envstr), "%s=%s", "LOGNAME", pw->pw_name); e->envp = env_set(e->envp, envstr); if (e->envp == NULL) { warn("env_set(%s)", envstr); @@ -373,7 +373,7 @@ } #if defined(BSD) prev_env = e->envp; - sprintf(envstr, "%s=%s", "USER", pw->pw_name); + snprintf(envstr, sizeof(envstr), "%s=%s", "USER", pw->pw_name); e->envp = env_set(e->envp, envstr); if (e->envp == NULL) { warn("env_set(%s)", envstr); @@ -404,7 +404,7 @@ */ e->cmd = strdup(cmd); if (e->cmd == NULL) { - warn("strdup(\"%d\")", cmd); + warn("strdup(\"%s\")", cmd); env_free(e->envp); ecode = e_mem; goto eof; Index: lib/misc.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/cron/lib/misc.c,v retrieving revision 1.9 diff -u -r1.9 misc.c --- lib/misc.c 2000/05/23 13:44:00 1.9 +++ lib/misc.c 2000/12/13 15:21:27 @@ -248,11 +248,12 @@ char buf[MAX_TEMPSTR]; int fd, otherpid; - (void) sprintf(pidfile, PIDFILE, PIDDIR); + (void) snprintf(pidfile, sizeof(pidfile), PIDFILE, PIDDIR); if ((-1 == (fd = open(pidfile, O_RDWR|O_CREAT, 0644))) || (NULL == (fp = fdopen(fd, "r+"))) ) { - sprintf(buf, "can't open or create %s: %s", + snprintf(buf, sizeof(buf), + "can't open or create %s: %s", pidfile, strerror(errno)); log_it("CRON", getpid(), "DEATH", buf); errx(ERROR_EXIT, "%s", buf); @@ -262,7 +263,8 @@ int save_errno = errno; fscanf(fp, "%d", &otherpid); - sprintf(buf, "can't lock %s, otherpid may be %d: %s", + snprintf(buf, sizeof(buf), + "can't lock %s, otherpid may be %d: %s", pidfile, otherpid, strerror(save_errno)); log_it("CRON", getpid(), "DEATH", buf); errx(ERROR_EXIT, "%s", buf); @@ -454,14 +456,14 @@ #if defined(SYSLOG) static int syslog_open = 0; #endif + int msglen; #if defined(LOG_FILE) /* we assume that MAX_TEMPSTR will hold the date, time, &punctuation. */ - msg = malloc(strlen(username) - + strlen(event) - + strlen(detail) - + MAX_TEMPSTR); + msglen = strlen(username) + strlen(event) + strlen(detail) + + MAX_TEMPSTR); + msg = malloc(msglen); if (msg == NULL) warnx("failed to allocate memory for log message"); @@ -475,11 +477,11 @@ } } - /* we have to sprintf() it because fprintf() doesn't always + /* we have to snprintf() it because fprintf() doesn't always * write everything out in one chunk and this has to be * atomically appended to the log file. */ - sprintf(msg, "%s (%02d/%02d-%02d:%02d:%02d-%d) %s (%s)\n", + snprintf(msg, msglen, "%s (%02d/%02d-%02d:%02d:%02d-%d) %s (%s)\n", username, t->tm_mon+1, t->tm_mday, t->tm_hour, t->tm_min, t->tm_sec, pid, event, detail); @@ -590,7 +592,7 @@ *dst++ = '^'; *dst++ = '?'; } else { /* parity character */ - sprintf(dst, "\\%03o", ch); + snprintf(dst, 5, "\\%03o", ch); dst += 4; } } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Dec 13 9:38:16 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 13 09:38:12 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 9E9B037B400 for ; Wed, 13 Dec 2000 09:38:11 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id eBDHcAv39021; Wed, 13 Dec 2000 12:38:10 -0500 (EST) Received: from muriel.penguinpowered.com ([198.82.100.195]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G5I00F2TOZLG0@gkar.cc.vt.edu>; Wed, 13 Dec 2000 12:38:09 -0500 (EST) Date: Wed, 13 Dec 2000 12:38:09 -0500 (EST) From: Mike Heffner Subject: RE: cron(8) fixes In-reply-to: <20001213103256.A78152@peitho.fxp.org> Sender: spock@muriel.penguinpowered.com To: Chris Faulhaber Cc: freebsd-audit@FreeBSD.org Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.4 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 13-Dec-2000 Chris Faulhaber wrote: | There appear to be a few instances where buffers could be potentially | overflowed. In addition, the mkprints() return value is not checked | before using/free()'ing, and a warn() call appears to use an incorrect | format operator (-Wall fix). | | Most of the sprintf() -> snprintf() changes are recommended, the other | few are for consistency. | Thanks good to me. -- Mike Heffner Blacksburg, VA ICQ# 882073 http://my.ispchannel.com/~mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Dec 13 9:39:28 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 13 09:39:27 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 6C10737B400 for ; Wed, 13 Dec 2000 09:39:26 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id eBDHdPv41690; Wed, 13 Dec 2000 12:39:25 -0500 (EST) Received: from muriel.penguinpowered.com ([198.82.100.195]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G5I00FAFP1NIQ@gkar.cc.vt.edu>; Wed, 13 Dec 2000 12:39:23 -0500 (EST) Date: Wed, 13 Dec 2000 12:39:23 -0500 (EST) From: Mike Heffner Subject: RE: cron(8) fixes In-reply-to: Sender: spock@muriel.penguinpowered.com To: Mike Heffner Cc: freebsd-audit@FreeBSD.org, Chris Faulhaber Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.4 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 13-Dec-2000 Mike Heffner wrote: | | On 13-Dec-2000 Chris Faulhaber wrote: | | There appear to be a few instances where buffers could be potentially | | overflowed. In addition, the mkprints() return value is not checked | | before using/free()'ing, and a warn() call appears to use an incorrect | | format operator (-Wall fix). | | | | Most of the sprintf() -> snprintf() changes are recommended, the other | | few are for consistency. | | | | Thanks good to me. | Doh... Thanks --> Looks -- Mike Heffner Blacksburg, VA ICQ# 882073 http://my.ispchannel.com/~mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Dec 13 14:36:32 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 13 14:36:27 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id 6434637B404 for ; Wed, 13 Dec 2000 14:36:25 -0800 (PST) Received: by peorth.iteration.net (Postfix, from userid 1001) id 254C957443; Wed, 13 Dec 2000 16:36:39 -0600 (CST) Date: Wed, 13 Dec 2000 16:36:38 -0600 From: "Michael C . Wu" To: freebsd-audit@freebsd.org Subject: libintl audit. Message-ID: <20001213163638.A17119@peorth.iteration.net> Reply-To: "Michael C . Wu" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline User-Agent: Mutt/1.2.5i X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: keichii@peorth.iteration.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello guys, Will someone audit the attached tarball for me? :) Thanks, Michael -- +------------------------------------------------------------------+ | keichii@peorth.iteration.net | keichii@bsdconspiracy.net | | http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. | +------------------------------------------------------------------+ --GvXjxJ+pjyke8COw Content-Type: application/x-tar-gz Content-Disposition: attachment; filename="libintl_freebsd.tgz" Content-Transfer-Encoding: base64 H4sIAInuLToAA+w7a3fbxrH5KvyKNW8TkwrCl2Q5keI0NAnJ7KFIXT78uGkOCwJLETUI0AAo WU383+/M7C6wAClKTmT3nNY8iU0uZmfnvTODse/NvCDxa199wg87rD998oR9xVjj6ZMG/g2f uvxb/mBPm42Dg6Ojp0dNAGscPGl+xZ58SqLUZx0ndsTYV2+55yw871a46wXn/ucg6PN+fKn/ 9svRJ7OB++v/4Kj5tI76f/r08Iv+P8dH1/8wDJNPcUajXj86PNyh/6PDTP9HBwAGVtD4itU/ BTHFz3+5/o9XMY+ueHRsB2HgXMU/O14SrePqLHYdfz2rhtHlcU0+q4lnxr+b5i+fh/vk/J+v wthLwujmYc+40/8PDgr+f9g4+OL/n+XzfnV56Pq104jz56NODcyhJk3ii5v/N3x0/7eCJPJ4 /OBn3OX/h0+bhfzv4LBR/+L/n+NTu+RJwt8n1YNao/q0Nl5zNnASdtBgjaPjRuO4/gNr1uv1 Ws1IIR2AbDYhZHisH15B9IZ4fdw8OoY9BdCpu14ub2hDozZerAV8kzXqx83GMZQECl5aYXWB qAkzEtGss8YPgPb44Ici5NQPHVvA/7CTkpWdLAJ7yWOCbeRwPzluHBwfZriRZDdc2l5AJH+/ C3HnPyQ8Kv9PzeATnLHb/5uN5lED/B9qvidHTw8PnqD/N7H+/+L/n/5T/Xtp7y99nsDl/xcD fuD/rB2ubiLvcpGwslMhi2dtSv3ZRRT+kzuJSWAt32cEFrOIUxnhVlMcQ+56Mdwns3XihQGz A5etY868gMXhOnI4rYDt2dENm4fRMjbZtZcsWBjR3+E6ITTL0PXmnmMjEpPZEWcrHi09MFaX raLwynPhS7KwE/iDAyLfD6+94JI5YeB6uCkmNLhxyZNj+tGoFqiLWThXZDmhC6BgFcBTAqGA 8Nqz8AofSbEQFvgEYeI53AQQL2Y+IEQ82cnEYp4sONXxbW/JI5IUa26SAkdqYlGkAK/uGsj7 RNQwwahC5YbOesmDxFa6q4FaQgCI2NJOeOTZfpyJn/SGmHVGMksYv+iO2GhwOn7VGloMvl8M By+7HavDnr+BhxZrTcYvBkPW6ndYe9AfD7vPJ+PBcMT+8Y/WCOAfP8ZHwuL6b5j1+mJojUYM dnTPL3pdwAOIh63+uGuNTNbtt3uTTrd/ZjJAw/qDMet1z7tjABsPTDyPMG1uZYNTdm4N2y/g Z+t5t9cdvyGSTrvjPp53iiSyi9Zw3G1Peq0hu5gMLwYjgQ4563RH7V6re251qgzIgKOZ9dLq j9noRavX0zmF/3KMPreAxtbznsBFBwGjne7Qao+Ro+xbG+QG5PVMNrqw2l38Yr22gJfW8I0p 8Y6s/50AEDwkdJ3WeesM2CvfIRnQSnsytM6RYhDFaPJ8NO6OJ2OLnQ0GnRHhggNG1vBlt22N TlhvMCKhTUaWCaeMW0QAoAGJwWP4/nwy6pLsuv2xNRxOLsbdQb9CmF4MXoFwgN4WbO+QoAd9 YhvkNBi+QcQoE9KDyV69sGB9iGIlybVQHCOQYHtM6DRQOBeEOtb4ZX3rrNc9s/ptC58OENOr 7siqgNq6IwToiqNftd4INickAtQYUCe+ajZskl5Z95S1Oi+7SL4EBnMYdaXpDE4J1WjSfiFV ID2i42ICEs7Al5p1k6IrLCbszBqPrddjdmBUBxC0RgvWb52DRfSXTF7OzKRfbv5nUHha+J0l NXIBgou7dXGarU4xCsY8xekUznDUIfDThcAax/YlZwsIFD7Glfk6cGTsBTZ63edDME9D1ZW4 NnrTH1yMumBVpy77Hy9w/DWE3R/TPPAneJAwZwFX8z58DVIRlCCgxerJMr703FIR1N0KKxjD VLB0HyTBH0HCSusg9i4DiIl+CHIAXliwSd8fwd3Ytti854maum87srilYCX3o9T1oluRbbOu +2GV0KVdtpJ7gKUB32JDmRl/nFJRqJCB8MswutnUpvPJ1blBAThQxxq1h10KqMYYL27NR8y8 G5gG+GVeAEbqocyGheUK0qcQEx6o/yG1sA3IiQGU4XUOZMzsGCgKRS4Ur7gDKRlHlDYjwg2A pnyBUgGZMwF7dDwkIbYhNzlM2pPKRZx1FOE+qTNkhfk8uMREcC6Px+wyWUcolNnNPRid64xC KrQOXJ5g0ogY1kHi+SINkiJgXmzA4T4mr0KSG1wBEpsFa9//TuCxMfsUxEFQv1ilGggKlKVh MtNAsEUFkJzyd2vvCkQQoCZ2MLmpSwCA7Bvkm3hX3L8xGX/vcFAoZI/EZxqVw7mx8teR7Yt8 u/qHqI65HTkLHiv0hgr+0lTWMf6Z6HJsZIK0YyLpLQcyU0imHtOWwAD+U4XRc43qqtGdQ6Kb XjngFLYfXgoZzkNQtakf7GW2Y3hzgZ/1PPbsGWsAt5TRXnuxRmxT36Mpt3PFeq3+2QTucYMH V14UBsTRlQ3J8MznaCP8vS2MbO5FMXlUng9JtJESDRAzjmWRMD1A5q85Gn5y3yNtSvQN2CI8 iFGvg8V8ZUdkpbMbcESIJax8XKFYYzsJFh/d3YcY+iEunyNbYFm2s9APwocYMlxZPmSxAco4 FxIcdHMP/b+gLwoOEAeUBURg/jxGehWgF0t16pJDV810cwcLbAsLDGoTNrc9H4vGkFhJuGEX zcnMG7Ahbfvag4J3xgvm8TFkQImWSlPsaE+xNkh/vH//XnidxLYVk4wYytpSRnKiSlnJyj0k EwR/Bbgw7qHdoX0Q9a8jMJpE6vYgDU6pBzDVSBPbdp6Jaqpe2EymAzWBtaYusFp2NVaXoWlc gxNyBUwmRaVkBBENoDWbAlq35SamIckW/qCZpxb3BZ9C+FQPo5ttFa4IIIpYA3kRujmHSgYr KYgkbEuELkZRFTEhThbCanrhmEyLQJkBCIEgubpEYvwuA6hkUhFJcEZOUMqAUz7SGBxK6rM7 MqUwS2WqtDlTlCGJIIJEgFJX+aZ+Mt0Y8pIoINuk5ZYbSP2+g1Qw0VP1RLu7WFEvGtVkxR5G ykTZhm/HaAa+5zJUj7qHNUujmGPnYTZYXtjCz2ecB2xpu9xUlmev/cSQqMrCApTrxBUkRtwE OXbuLZmUX0002zjebiZblJNlQ9s0h9ddlrIA2/ENRPT3FPGX3BaRPdyp/E3ZAcEyeVEdPcg3 fO4of9W4gfOFGsLAv0lzHRcSBR34zxpXGgdJ21kwvFv2WnqHlxtEM2a7ohMHqUwu40ldFLmQ OTiKr5BZzdMWHAgn2AhKCkvVaF3BBUc3jsgn5poTboYDuEoUrvb4zYWV3UXtQa/XGmsL6ixt ZdC3xlDbZyv9ybk17LazS6w9HXfPLSYSHPKZcF6sxnK1kqq6tANLRt7cpGe6OxFUjX5I95Od aFetQf1U4Z+av6lUWPPjVPUQImJsS0OKgq9HN+KgqmGkZcr0zaZ8fENNhch9p5PZxva6Q3iI YwcqlRKOQPSoLA9249Uv0jOfX9q+MYfUR7wO09i+9XDEtg48YDxl2E7ZlBnfDaRtS5WMRbgf 2+d+4q3QAIEI1V9P77AMQRgoBKZIXFc2deB9SGqpfYT8gZ7sq5AazRCwqGrYlgUgCUUVyoxL Xba2IYOwFkREfFEJOKg6EaWSAsEAfssFYWxcEJCc4l8qNNlOFMZwxHoWY34bCEpiMt98vqXV 6Plr7S7rWK18T6RjmiWCHQjryzmtKrFVDFNmq/GsxVcpeWHzrnolw+z5HMOxTNslCsiPMRPM I8DCA7hV2tKEhLiKTOE1LJlAe2er0AuoTmnfjgP0uSOvEAW78hb0Yf0ylGfl7QFE8y69kFk+ MOStLQsOuC4cBRNktoq461FejFE3KyzUAXl6JRUiTEs/Ft4qs2Fp1MVMDHgLg++wbXOjahO8 gnKZxwyrJ6TnygvXsX9jbmODqC8ekOlHpuSqztlNCStQcn8qIr7ywfGFGEOfXgu6ouACkaai GC+yKiG9QFWECJg9i0N/nWiVyowjkojD+hXa8IIH98/b78oWsH0QFS99DH6ql3SbvDTzxlsF KNfFd4uAsOCMC64h410BthDzvCXE4fRV3neqDk4NPy2zcumnbvVbGrd6WhSoixR9SuSWIlpC uFitZYajtgG/G50bXNzqHiy7HBWC1MHxFjdQ7yoey44y7bteeM4iR1qaAkHY9bAEnoYrsM5i natK+W0nqgJIU4G5U0ZKafnArO6bDblowSl9n0pWsyGUbsK2GQQ2WoIwhxfd8IbLgJDddH9Y wzGHCx3S18SjDALERcvpdU/rZkZ/vEl/KlBRm/j4NlmmhYA7gms+lnk/3Upx7gLmdgTXXYR5 w0dyoQRmp9ICa7VVyMq6UUYxudumL0Zv8rALXxpa48mwz162ehNMU+Wy9bp1ftGDbI9edVkW a/VGg40eiwQejVv9TmvYEdAvuqPxYPiGgl2+Q5x6skiE5EDGSg1k5Hr0uff3wsXO+hMV+Kp0 0vPJ2YiOoWh2DaYSeasV4pjP2TwKl6wVBPw9a1PC3nnHet3G9/3JazEPcuaHM/C8f4lyayTb ++LXS5H1sUa1Lu+OXTpyQy5C1nUYvWVU9oGvLUNRH8GNbPvX9k1MbTtA9+8emPkP+xTnv5xP cMbu+a+Dw6N69u+/Do+e4vzXQfPwy/zX5/jU9tPxr739mmHU9r8z2P59JsAAausAGNvHRw8w /gVYHmD6C7Ckw1/w/c/PfgGSPz36BTgeZPLrz9OiBr8EpgeZ+xIG8EBTX2hlDzL0BYgecOYL yXqgkS9A9YATX4DtoQa+ANXDzHsBogcc9wJsDzfthTw+zLAXYMrNejERTZn8lzXsvAVCgf+t 4TN51fzsgUeRp1UDSCoRPhtiiW/imgNVWoxzLPnl5GbFtyzjG9/l5jL2ZjZXl0s72FxdeyEu aqtzR47YaICJK8ByS5BH5NfWAQQFtwhHIxO0Nmd1HTrxxDEcotbc2Drls23CJ10rFf5hQEl7 pP0bgJJBzSrPwdR/7UAhGdJ8BE+/nKQQ+nyOH4Zv16tp+sJtOr0ol+G8SuVkG3i88r1kKjN9 gtWf3rJJnrEMsUkrd9EDk8Xev/g0MXPgprGnHueW2S1HradA70FzmrC5760E/nTNzB5rW7xA 9juxoUUbsBGbw4ogS3vlJTvZRKh1oMEhnt1igNp18bGim4nplI/cth0cfBd9Ol6EUeLg1IAq xiDS0ztvaiDnuiuYBFEB6+lNoXJFBAM5M6ZW6S1FBXRYnAI7MX4zjD1RsOpo+pMexH4CMZn4 0ZjAH1qPF8j+YKiDVCOrnBXfcnvh1Oz5yUeQs4H1fkQ5O/Yr7/pI+vb06bg/Rm56sk5rkFNV Q+5rmizYprbGNuKasLhlou8eKtaP2yHO2/nbQe9ugT4EIzup2cKO8DXdZxiVIdJBqWMT2OLl KYTCbEwInA6Ck43ND3b7mAmiKvveW87+aU//dlHla+dvFzWNCg2WvJV6afjG0abXNQzIv50G NRaExOKE4Yr6LYJtQpYOeZj32dNUBIhBDxIA9j5iMz+2SCik6MVhLEWBcyJerFJx64pjkh+u Lxdy2oo2YR6Bbc2S0HPJFE3jCGPe2nepJxPx68gTUz6IKeKXeLTooVHHV3bmJErxJqMsEQB/ uSFXOAHnrxw7eEylC6wGONQlZhWdcAkXNdzicHXeyGKQKo98kI0rii04WrWxy95c75E+e0bO XTH1RWzg2m9BEtTbyt67YA9KYMuaUxCzGdSroH7/JtcOpBduss0lLKrkx6V0eAPkToacDTix bEiHYARKzfQUN2Jk1kVR2i5dIfvVZcgwF4jZJQ94Os+nd/KYgKI3C4swTshrMIfC1woB4nMJ BQDOQJrykWgoxuvVCi43gMAXt6aaLRInUscxQGy1dRzVYlCgGuR6xMpYpXNlJ0usScG8YrUX jCMU2yApQ/esiGx4yw1sFBKrsnYHbIb1GKwCrvcMiP0GsQp9PxtXOFbhqJStlU40MBxyON7L QeGSDqPGGnK41KIOKKcdcnByTQfDCYj8kbiSO1FaQ/5ENf4AgB/SMIuWrQXN1xdnTMzeHDMf /GkN4eWXaYK9dHyv80tV9ll//fWXn0U7hUe/0sbXr8XrOWw4OAvuvMVoWoIcBjyqhCbl285b 7Imj8rbpTs9yyz4Fz/zV4Ys75jeZqc7W81+eT05H3f/7FWLZcqV+nKhM1jfZPqSi+w78v4RV dSg+FHRlW4y9JV8CX2XxwGR1kSaHc7lCSdweBIYypPo+DySF7FvWYD8pUCCpglaEAfbYSFUk CQepIxGR76xuENQUD8zcbgBbsmdYT0DqGQmwxz8/xnU8fAky2dtffvstwDz+e/0xMrsBXk3B HQJ3dPBkA3yagicEnujgPnwFsJM87xUMinWEvgzBO5FfdSL75hv2KCk8UsSjh8mT6KskUnzf i4MVVHTJvAzaTKUC3yHylr6Op1/H1a/jn7+OSyZBY4cJVIx1DNyElRMmcKB87UyPOqpMk9sg S8el7ZAfjPvQRoRJghQ19ybmvrQgKbspScmQNNyXhHtS8MHQ1adr7z7KSwXkfFIBPTjLRUh/ a3CQ3i6WKKbuuKJEXS7DAIcs1vUi+IbNhayA0DOOigprwhtFDY9bCwk24MkiIKI72avtp31c EV7VvxUQ0/YQj3MYslvy1jz/N5IJdjyQRfgjPRJEvf8OpfEOAoc439i7XmAPotwQprISESjm q/I370jspA40pkcrDBx7M8ha3qZr+2IRX6t6wRpbKnvIkhtC4kcpsJzskNmbYhHZUkHLWa7K QFmpXRKRi/3+O9OWLwaj7utSFtTyl6M4Lu1cpAMhuQMgmgKmx7XHFYUbVjI94oMCF9i0agDm vxbx6OXOtn3U1IKNNJBI6SfC07RPdMzG2LYXF3D6LpS/R/VDEqgle5hCaV6bGSJ4a039B9lg SZrmCqMuxtytxnmSsgBuQri+iSFI/CjlmVEvwACuGifgBJChfsNG0+7p+bjCHj2jr0PrbFPh dH9gx4euyQ1NCaf4YGzmNcV+lYH9qvIVBEj70sP7MetkXZ3ov+i5yBTF4fATzz0fTM9bZ912 JbvgcSP38YXUNsDp6FXr4sLqCOu/Ausvl6/YTz+x5mEFuK+/nwNDv6vF79VavQ6rUub47Mcf 9Wf0VK1niOr0IXVotH1gRB0eb88gSS8TAFjQYDy0Wu0XVgdt8IMmLo/+0Y6w+LIdXQKzolkH 37MUbH+FukF/lr3FCj0mea1A+WpVdUOrtutG4B8GMbWCxGk7xLdp/7QKJqkJui4Fna00SMlI rrAO9M5C3iiC0G+iBJi7J7fGLqz7N03AZDhvhiMI2c5lCAUkJLr7YYKj0Zho0pcNiOmChJSt QioaauFb9pu8lIarNFnKSQSSKhWv6IZInxK/qTukYgLl2j7WfjcMZ5O4S+4um6aoftkzF07L nXXEp4hKyA89sZjdyV565uWCEN3Ni7ngXV4uIiWCoDjAGuQ/Wp+en7cuwHdeF5HOXTA15Ece PpgOO4N+743KX+H5LaSgKOAx0Ct1Ku9vEQSIqNxKaqTSnR9l7oy62FhMfVw4ueND/QrnkZ/p tHwokqNsS8soxEKOqHQxpYuiWLZZUi0oGlovuyN8V3YnLXkje8aWYB+yb1gWJlrJFETv+MaA vdUxBRGoptNuz4JIhF9HL1pDq2MyZKwczuewu65U8yh31N2U6c/0YICxZoOyk6yuyjmGycSf SrU5p6GcjVp9z1iOODqRzsmctlKAMDAloDcfogdSxbfddNfSorCPYL2c8ej/2zvSnjaS7Gf4 FT3sKthgsAEbJvaS1WySnSBlDk0yWq0yUctHG3piu1vuxhmE8t/3XXX1YZsZNsmHKkUKrq73 6q56d31DhIKGnyfwL5RLAnAfPVM/B6VSan6hIM23lC5OexlwIaZoLpzkGrBdh7Dhs6zNJxk1 mnOcoZBzr9mgkTt08KvDUDYVMpsPQ5CXENDS0RcRV0AUlsl8wrnvqofgvexI6+ir3JEGX15Z Sf4XK6GhRgcKMud+l+Tvpa9oTkFulEuyWV8ky/nQWGGiwUaUKWnlMc0KsuSyoouXTZOsXKqa WF4jdZOLV1ZzTk0FRr+0fW3gzUNbAKtbD1vVmW9ZZ2pvaLu5eIMky6ARQ4HOIIjhsqgZrCA+ PBRm5V38Xs4dWqmy2DjT2oBcEI0dLwN7ZZvy8M3eeYVVp8AL605jPQx0Sw6DE1lv7jA444AD UT0W+aONRf7Asci/6FjQDrxeDkfBD1c/vDy6gStYfMqR8kJD3GkczSZVp7WUvRQFSmNvT8vj qgo2hcxHJjdfVpdpsaIEqr0kZELVIhizLoR+xX0rYFDtpRom0J4VjMO31G+pFtnIaiBgKX9b 7Gt+bUVM1MHKCPx4oOB+Z5kuc5IaeBmhuR4qWQD6Y0SC/dsFbWo02GcdgPYbQ2UIItKmXcUA HfgRlyF6n6d4GlpYKaBDdDs++j1VHso4WfIZZ4L8Q7gGrd3QeorRHQF/WDKPgQPNv5stS9vA /SEU2D6DZphhqfFwgXe66lecU5OpuOG+lU2OzYX/B62PgeFOl8k1HOAZ66oA4xIaP7sjDMqT kwztlCKOFCe3GbrbKfUOUNt3Qcz+bUomT+1oG3YXGCMldZaco5NBgZ/TG4R4WtgMlCG6wWW0 jw5+zDJANppui34ON0SJI8F1MycEbn7LZd0GZRpTlrdDjL3rvDcrsGJfyXUDdU5hsGu+VoPm a0HzdaCybupg1eeBVh48sUrYKgQrm6gaM2nrhYRotbLJtMPaq7Kmkb4aotPUDWnXSeXLOjlc gxhHBHZqQrtgEZHelTBgSVgnaHNCe+H7n1/vo3TweEz7bhkdadXp8fG2+4CkUdbyJhKZdJvJ NI8WsozrhDZVYyJWOeuHhZjqPElbqKfMkzmsyngywQMm4T+E717g7QPl6BIEboAKl69MQ0MJ OBTB/VUQbJJkPEGxBiNyZZkaksocqjJBOzhlaQw7pgLpl2UxRfhYUHQJOuugJ+hwxvaxw3yo wn9krHLVIkTdvkvpcVmeKiX+wVJQ+fWsrs82PPy5kPtlnjbE7qVyL75jtHyLq4oXJamdayZV uTVtTIhIi9kWWrhoZk1NrbpNZWpNvpk+nbdGZlix/DYsOzuXJDkrTTTYm1nf7o6YTrejcqW7 dk/b2sb8KSOoh9nslDTrlVZV9IuO+p+/e/sKhTvvB65Kdrb2a1L+7NreIYFQzJTLspA9ruj3 SgvgkjEbfah7SnJtexD1SXgY/qS8TA8mI1InY79xs9OqhwPin8qsph+o8RQ2x9Hx7DgVhaGg PXZnTD7XmjsMSqiJlB6rShzVrBomQAirKlqsGnsq9BCRpkJ8XRp3s4ZlTsCWb02UOMIdpGgF LodVGWhHv8/fpZ26BU+eCKlnDlSlcpYiqHFXWVLyMDg1KvgZy3ZKLIBWdMwckRAXJ6VHn/WT Uk8rME0U8bnd0rXtO9miOSKuktaYWl24QuU1Q6PH4U9UTLC11RaXCrGMk5GzMhdwDA0CWPUB fZiMjp5hVtPVvmG2fVZZi95cC+qe4rU7ou2AOJ/o2kRmxbq/EVt0KVYAmJJbRc6yNRYbHulQ EWpx2pvZCNbt1iXF5kE5FnnK8WDAxgIxdgqrrzLMfHoVrSbQXEY6hDQbZkEv0SpsmcBqJb// GGeHyKu/q00ZmE1mq5KddS3LGkddJlo0y9Ra7kqhj7SNixPe3kzgRbA684+J5V9K7B6i2c+o JpyE0XDC9GeMMSKAXFYq6Bv0rM/QZfSOA2VwOAj01j1mFqcwZZocT1z9o3tEC2fsFiFMYxfJ WMOPXVD1wciWk5kzljLUid40uzSjffvWL174tHeRZNf8NTorkxN5oylUOq7g5XCRzchEj/xp MWAN87UMOYmn00h8wGlqtEv4kXIxZgAcTHVAHDMs0fnDPHiOETUX+REZboqEw7YTbJF7HcuR kxEHk2AMwFor8mNvT9C2d62OfR+vhFYdzmFIyPKAj98j9EVDrRuqnNAyM86yW/TyjlHbdif4 0RP/OkkmAfAiQ1woWkYtuztZxtcxhj7ia1Zc0hjaGjtlH6sqFf/s4XJ5Z04FaRiaXzICKQ11 L3IycMu4i/x1C34Hti9QrnNWu2cMRnvCUr9DrxJr5BS5sGKKVFj5Njon/YgeVkKrYMgYi1/S 2lMmsj59cXfmgv+verHjUevY8P7L2cVF8f3Hbu/Uv//0WZL3//X+v97/1/v/ev/fr9j/F/H8 EqGfxSTgwxrIKvi4nxEBqqqibUcx+eajZBZQIGsiOsesXVFOI/Nu0Bje5gkcEdMAfswxUB1Q SMNrirlCmhUkvm7iNCuRQcCjAHnHSiag7YR+wMqwEJN5eIrDoUTn3BvoUqR0QMA0SWDQeTyP xzZe1vHcpqlEMZRO/H5LkbTpMhh+iOw+3ADbdaeOmytSQ4lFh5xQfCAyItLSDMXUF89Hg6jF FLS4ZJHzFZBuHJ7VcWVpK94b6yi5xeAJkJsgz1m8RGmoat9/kWS+olj0S0BOJzIL2inOGtDV N8PxB8BhdRDjVhNzlSVwfd2wKwbGVLwLPi5RnkeTj7iuABouhkUih/X4JoEbgRchCvvCxSwE khPlTuF4kS8Hmu5U9J/2s/4/0Bgb6L/uSfdc03+9s1N+/6vn6b/PkTz95+k/T/95+s/Tf18H /TcFAmEahOFrQP3j29fhq/DFy38D1Isw3P0bR++s+VpLPAI1ES0XojZTwqzKmBdOyUlt0XKI ERdwvCUkOdWXwBdbQ5eUm+WmbI+sEFplC9zjx0OuR8KtwgpvvXm+CvGwHzprdW90bYFHPA2C 9kHlyoSF/aWpHJ/qUoH+V+GTHrWODfR/7/yiZ+j/i3OU/3a7F57+/xzJ0/+e/vf0v6f/Pf3/ VdD/QuErJ8Wdnc4fT3ud7snpJCp9VB6MUGYSnZx2uk97dhnlUwg4DOKiv+ZO47yLp2LntNvU 9mC6NJBw3/36+m344idsPT5HvLOn3sfYo94Z83vRwVOoGOWEd++45iqnOTIHUi+zZSpaESrJ ncLah5cc96wq1Ic+0BAlKGX4S3YwfXHos98SLUGIpxEC/NQ3dgqs8ic/iWQ6zXiCXMjcQL7t lyxA1sPekBckgr7pk10KthENTkk+rv35XBhGRlCv+gp1FdwnINuHOZ/JURg2GmGYDscfokkY EsFe8O1z5gkDVJBxsxirwX/NFtyQyrlAhy5jZ55CM9Hol6BN637rVDxftEUjKQiGaBc4+NqM LakrlprySbt34mw8tBtiOfqALthjydV/lQu+7Lv30IVfieGBG8CxMlZuVdpg1/hnDNxxlQCt 93UmyRLmAL18adrQJXrfdYZxYq/YEzZPGIbn5Aid3tCPRh1qYmTlzrRrPXxfZ1VMVpbSZmPU 5tpDV/Xnk5ECVCK2LCsfgf5X/J8VI/cRsLppA/93en5xBvzfyUW3c97p9nqo/4E/PP/3OZLh //qBtQZaK+CUzoKTp0977c5p+/QCSIT+ybf97lkwvp4EL/9IA88ven7R84ueX/T84uPxi8J4 7YREDyCnxqzXzl7J3GTvcYTq6v43kv/HfwJow/1/3u0Z+4/z3hnKfzsdb//7WZKX//r73N/n /j739/lXIP+tff5nGsjDrY3XV/96Hr55/vxNk8I2q+wZ2g/shuEvz99cvWjsqSMdvYG1cj7Q sHQioJkqglUYHm96YWjTa0DmlZ91LwRVPe3zkGd81slGgsvgXh74KAuxW0GRvgo+mQdforzi aWhyNKSXau03KnAYp8sYBjhz3nixHhJwwwHXBudlv01or44jdh2vIufxWP1Qt3ImLbihi4dZ tQM64XeeaaZX7c0rCKPh+EPxVWxd0YHteHpv+SRXVVY54hIVVRwwq8Bs1+nNVVh/b4t6d/0I mVgNriGN42Usz09vG5tBitvRlwtCwnRQMfUYXsmeKvV4LRWiSxcNvVM5PKrWA8UOOKhcHypC suWOrnrl+qOn7IjcLMGSODvOMPbbR2jbbEhPzdPz56opghGDBH1zSSGR1zfAWl7FNtjTWEbS 1m/EqCF131LWYZ/JDz6tcINP4R9kp5U+8OlDXeBTEzC7UT3jKmie9PAgbRZjabuDrSIVpXZ4 IgUlrS53C765OdjFgfugQao8zWW2WqWZHziFa/ZfzVzJ7GzlDVu/Dyss0pwNKXnbbkgprk9c fBybvdonGKvryHlruCLM0Zfm1nzyySeffPLJJ5988sknn3zyySeffPLJJ5988sknn3zyaX36 H6AwoC4AyAAA --GvXjxJ+pjyke8COw-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Dec 13 15: 9:53 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 13 15:09:50 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 6CD9E37B69F for ; Wed, 13 Dec 2000 15:09:42 -0800 (PST) Received: by peitho.fxp.org (Postfix, from userid 1501) id 2EC3713612; Wed, 13 Dec 2000 18:09:45 -0500 (EST) Date: Wed, 13 Dec 2000 18:09:45 -0500 From: Chris Faulhaber To: "Michael C . Wu" Cc: freebsd-audit@freebsd.org Subject: Re: libintl audit. Message-ID: <20001213180945.A79894@peitho.fxp.org> Mail-Followup-To: Chris Faulhaber , "Michael C . Wu" , freebsd-audit@freebsd.org References: <20001213163638.A17119@peorth.iteration.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001213163638.A17119@peorth.iteration.net>; from keichii@iteration.net on Wed, Dec 13, 2000 at 04:36:38PM -0600 Sender: cdf.lists@fxp.org Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Dec 13, 2000 at 04:36:38PM -0600, Michael C . Wu wrote: > Hello guys, > > Will someone audit the attached tarball for me? :) > So far: you should probably check the return values of strdup(3) calls. I will take a closer look at the code when I get a chance this evening :) -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org --- gettext.c.orig Wed Dec 6 02:39:35 2000 +++ gettext.c Wed Dec 13 18:01:11 2000 @@ -405,6 +405,8 @@ v = NULL; if (v) { mohandle.mo.mo_charset = strdup(v + 8); + if (!mohandle.mo.mo_charset) + goto fail; v = strchr(mohandle.mo.mo_charset, '\n'); if (v) *v = '\0'; @@ -575,9 +577,13 @@ if (odomainname) free(odomainname); odomainname = strdup(domainname); + if (!odomainname) + goto fail; if (ocname) free(ocname); ocname = strdup(cname); + if (!ocname) + goto fail; strlcpy(olpath, lpath, sizeof(olpath)); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 15:35:50 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 15:35:48 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 9D2D437B402 for ; Thu, 14 Dec 2000 15:35:48 -0800 (PST) Received: from earth.causticlabs.com (oca-c1s5-22.mfi.net [209.26.94.207]) by peitho.fxp.org (Postfix) with ESMTP id 871D71360E; Thu, 14 Dec 2000 18:35:50 -0500 (EST) Received: by earth.causticlabs.com (Postfix, from userid 1000) id 1E6011F23; Thu, 14 Dec 2000 18:36:32 -0500 (EST) Date: Thu, 14 Dec 2000 18:36:31 -0500 From: Chris Faulhaber To: "Michael C . Wu" Cc: freebsd-audit@freebsd.org Subject: Re: libintl audit. Message-ID: <20001214183631.A30242@earth.causticlabs.com> Mail-Followup-To: Chris Faulhaber , "Michael C . Wu" , freebsd-audit@freebsd.org References: <20001213163638.A17119@peorth.iteration.net> <20001213180945.A79894@peitho.fxp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001213180945.A79894@peitho.fxp.org>; from jedgar@fxp.org on Wed, Dec 13, 2000 at 06:09:45PM -0500 Sender: jedgar@earth.causticlabs.com Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Dec 13, 2000 at 06:09:45PM -0500, Chris Faulhaber wrote: > On Wed, Dec 13, 2000 at 04:36:38PM -0600, Michael C . Wu wrote: > > Hello guys, > > > > Will someone audit the attached tarball for me? :) > > > > So far: you should probably check the return values of strdup(3) calls. > > I will take a closer look at the code when I get a chance this evening :) > One other nit: --- gettext.c.orig Wed Dec 6 02:39:35 2000 +++ gettext.c Thu Dec 14 18:17:34 2000 @@ -336,7 +336,7 @@ } mohandle.addr = mmap(NULL, (size_t)st.st_size, PROT_READ, MAP_FILE | MAP_SHARED, fd, (off_t)0); - if (!mohandle.addr) { + if (mohandle.addr == MAP_FAILED) { close(fd); goto fail; } -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 16:15:14 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 16:15:12 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (poynting.physics.purdue.edu [128.210.146.58]) by hub.freebsd.org (Postfix) with ESMTP id 11B5D37B404; Thu, 14 Dec 2000 16:15:12 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id 5B6341924; Thu, 14 Dec 2000 19:15:11 -0500 (EST) Date: Thu, 14 Dec 2000 19:15:11 -0500 From: Will Andrews To: security-officer@FreeBSD.org Cc: audit@FreeBSD.org Subject: audit patches need reviewing/committing Message-ID: <20001214191511.Z1873@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , security-officer@FreeBSD.org, audit@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: will@puck.firepipe.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Dear Security Officer team, For those of you on -audit, you might have noticed lately that a large number of people have been going through the FreeBSD src code and auditing it for things such as buffer overflows or improper use of APIs like mmap(), strdup(), et al. It would be nice if someone with credibility currently in the Security Officer team could step up to the plate and do some reviewing.. since not that many of us are experienced in doing this job, and so not that many of us have credibility in this area. If there's nobody who's assigned to do that, that kind of makes it pointless for non-SO people to be auditing the code, since their patches will just rot and require some merging into the tree. And if people keep auditing it but nobody looks at their diffs, who knows what mistakes might propagate in the diffs and need to be fixed? So, I guess my question is this: is auditing a priority of the SO team at all? If so, someone should be appointed to the team that can be relied on for proper reviews/commits & such, or someone should be picked from the current time to perform this "duty". :-) I don't feel safe (and I am sure many other committers) committing my auditing diffs because I have no idea if there's any problems with them. If someone who had credibility could review them.. that'd be excellent. I know that if I had credibility I'd review and commit patches to take the load off the SO team. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 22:20:45 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 22:20:42 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123]) by hub.freebsd.org (Postfix) with ESMTP id 67A9737B400; Thu, 14 Dec 2000 22:20:42 -0800 (PST) Received: (from kris@localhost) by citusc.usc.edu (8.9.3/8.9.3) id WAA02087; Thu, 14 Dec 2000 22:21:59 -0800 Date: Thu, 14 Dec 2000 22:21:59 -0800 From: Kris Kennaway To: Will Andrews , security-officer@FreeBSD.org, audit@FreeBSD.org Subject: Re: audit patches need reviewing/committing Message-ID: <20001214222159.B2040@citusc.usc.edu> References: <20001214191511.Z1873@puck.firepipe.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wq9mPyueHGvFACwf" Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20001214191511.Z1873@puck.firepipe.net>; from will@physics.purdue.edu on Thu, Dec 14, 2000 at 07:15:11PM -0500 Sender: kris@citusc.usc.edu Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --wq9mPyueHGvFACwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 14, 2000 at 07:15:11PM -0500, Will Andrews wrote: > Dear Security Officer team, >=20 > For those of you on -audit, you might have noticed lately that a large > number of people have been going through the FreeBSD src code and > auditing it for things such as buffer overflows or improper use of APIs > like mmap(), strdup(), et al. >=20 > It would be nice if someone with credibility currently in the Security > Officer team could step up to the plate and do some reviewing.. since > not that many of us are experienced in doing this job, and so not that > many of us have credibility in this area. If there's nobody who's > assigned to do that, that kind of makes it pointless for non-SO people > to be auditing the code, since their patches will just rot and require > some merging into the tree. And if people keep auditing it but nobody > looks at their diffs, who knows what mistakes might propagate in the > diffs and need to be fixed? >=20 > So, I guess my question is this: is auditing a priority of the SO team > at all? If so, someone should be appointed to the team that can be > relied on for proper reviews/commits & such, or someone should be picked > from the current time to perform this "duty". :-) You raise a valid point - we need to make sure we don't lose the new-found momentum on audit, and that the older hands amongst the audit group give appropriate sign-offs on acceptable patches (or not). I wish I could be doing this myself right now, but it's difficult to even keep up with the regular security officer workload since I'm on vacation. So I'd like to echo Will's call for people to make the effort to review some of the patches posted here and to give any comments that occur, positive or negative. Kris --wq9mPyueHGvFACwf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6ObiHWry0BWjoQKURAn/9AKDswiXP6p7PNCEYsWd/uYjusraKCgCfSht7 nQFsh6sT4TN8eDeQmuiH3mY= =l6KS -----END PGP SIGNATURE----- --wq9mPyueHGvFACwf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 23:10:40 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 23:10:36 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id D7E8C37B402; Thu, 14 Dec 2000 23:10:35 -0800 (PST) Received: by peorth.iteration.net (Postfix, from userid 1001) id 443A757454; Fri, 15 Dec 2000 01:10:55 -0600 (CST) Date: Fri, 15 Dec 2000 01:10:55 -0600 From: "Michael C . Wu" To: kris@freebsd.org, audit@freebsd.org, doc@freebsd.org Subject: www/en/auditors.sgml update Message-ID: <20001215011055.C35769@peorth.iteration.net> Reply-To: "Michael C . Wu" Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline User-Agent: Mutt/1.2.5i X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: keichii@peorth.iteration.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Guys, I have updated auditors.sgml to reflect current conditions. The list of auditors is removed, since most of those people have either become committers or do less auditing now. In any case, everything should be sent to audit@freebsd.org anyway. Please review. :) Michael --=20 +------------------------------------------------------------------+ | keichii@peorth.iteration.net | keichii@bsdconspiracy.net | | http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. | +------------------------------------------------------------------+ --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: PGPfreeware 5.0i for non-commercial use MessageID: 1ZTHsFb3UgWHJRh7ZsOvt9RdpC4Ol21U iQA/AwUBOjm17nfOKcWPoS4gEQIkTACdG6ZGytEZ5xfk7zN7I0URymanicgAnjTE dmYuHfB9CInUJKnNB6ShfNzF =AJCD -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 23:12:59 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 23:12:55 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id 0E2E637B402; Thu, 14 Dec 2000 23:12:55 -0800 (PST) Received: by peorth.iteration.net (Postfix, from userid 1001) id 7DD7157454; Fri, 15 Dec 2000 01:13:14 -0600 (CST) Date: Fri, 15 Dec 2000 01:13:14 -0600 From: "Michael C . Wu" Cc: kris@freebsd.org, audit@freebsd.org, doc@freebsd.org Subject: Re: www/en/auditors.sgml update Message-ID: <20001215011314.D35769@peorth.iteration.net> Reply-To: "Michael C . Wu" References: <20001215011055.C35769@peorth.iteration.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001215011055.C35769@peorth.iteration.net>; from keichii@iteration.net on Fri, Dec 15, 2000 at 01:10:55AM -0600 X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: keichii@peorth.iteration.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Dec 15, 2000 at 01:10:55AM -0600, Michael C . Wu scribbled: | Hello Guys, | | I have updated auditors.sgml to reflect current conditions. | | The list of auditors is removed, since most of those people | have either become committers or do less auditing now. | In any case, everything should be sent to audit@freebsd.org anyway. | | Please review. :) | | Michael I've done it again, the diff is at http://iteration.net/~keichii/auditors.sgml.diff -- +------------------------------------------------------------------+ | keichii@peorth.iteration.net | keichii@bsdconspiracy.net | | http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. | +------------------------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Dec 14 23:48:51 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 23:48:48 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id 449F137B402; Thu, 14 Dec 2000 23:48:48 -0800 (PST) Received: by peorth.iteration.net (Postfix, from userid 1001) id 0BD4457455; Fri, 15 Dec 2000 01:49:06 -0600 (CST) Date: Fri, 15 Dec 2000 01:49:06 -0600 From: "Michael C . Wu" Cc: kris@freebsd.org, audit@freebsd.org, doc@freebsd.org Subject: Re: www/en/auditors.sgml update Message-ID: <20001215014906.A36962@peorth.iteration.net> Reply-To: "Michael C . Wu" References: <20001215011055.C35769@peorth.iteration.net> <20001215011314.D35769@peorth.iteration.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001215011314.D35769@peorth.iteration.net>; from keichii@iteration.net on Fri, Dec 15, 2000 at 01:13:14AM -0600 X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: keichii@peorth.iteration.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Dec 15, 2000 at 01:13:14AM -0600, Michael C . Wu scribbled: | On Fri, Dec 15, 2000 at 01:10:55AM -0600, Michael C . Wu scribbled: | | I have updated auditors.sgml to reflect current conditions. | http://iteration.net/~keichii/auditors.sgml.diff After Kris' comments, I have put up the latest changes. Kris asked me to put some coding tips on there, but I decided that this would be already described in security.sgml. Whoever that commits this(if this gets committed), please change the last updated line to Last Updated: keichii@iteration.net -- +------------------------------------------------------------------+ | keichii@peorth.iteration.net | keichii@bsdconspiracy.net | | http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. | +------------------------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Dec 15 2: 0:33 2000 From owner-freebsd-audit@FreeBSD.ORG Fri Dec 15 02:00:31 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from lists01.iafrica.com (lists01.iafrica.com [196.7.0.141]) by hub.freebsd.org (Postfix) with ESMTP id E916B37B400; Fri, 15 Dec 2000 02:00:27 -0800 (PST) Received: from nwl.fw.uunet.co.za ([196.31.2.162]) by lists01.iafrica.com with esmtp (Exim 3.12 #2) id 146rf2-0007gQ-00; Fri, 15 Dec 2000 12:00:20 +0200 Received: (from nobody@localhost) by nwl.fw.uunet.co.za (8.8.8/8.6.9) id MAA24275; Fri, 15 Dec 2000 12:00:18 +0200 (SAST) Received: by nwl.fw.uunet.co.za via recvmail id 24181; Fri Dec 15 11:59:48 2000 Received: from sheldonh (helo=axl.fw.uunet.co.za) by axl.fw.uunet.co.za with local-esmtp (Exim 3.16 #1) id 146reW-000OHx-00; Fri, 15 Dec 2000 11:59:48 +0200 From: Sheldon Hearn To: Will Andrews Cc: security-officer@freebsd.org, audit@freebsd.org Subject: Re: audit patches need reviewing/committing In-reply-to: Your message of "Thu, 14 Dec 2000 19:15:11 EST." <20001214191511.Z1873@puck.firepipe.net> Date: Fri, 15 Dec 2000 11:59:48 +0200 Message-ID: <93368.976874388@axl.fw.uunet.co.za> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 14 Dec 2000 19:15:11 EST, Will Andrews wrote: > So, I guess my question is this: is auditing a priority of the SO team > at all? If so, someone should be appointed to the team that can be > relied on for proper reviews/commits & such, or someone should be picked > from the current time to perform this "duty". :-) One thing that this group has going for it is enthusiasm. The downside is that not every individual has the clue to match his or her enthusiasm. I don't see this as a problem. I would suggest that the primarily enthusiastic folks send patches to this list for comment. I think that the primarily clueful folks should, when pressed for time, limit themselves to commentary on those patches. In this way, the clue is disseminated and the primarily enthusiastic develop clue. It's an organic process, but one that I think will be very successful. It's already happening to some degree, in fact. Please don't take my comments as any kind of insult. I put myself squarely in the "mostly enthusiastic and only marginally clueful" category, so I'm certainly not "talking down" at anyone. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Dec 15 5:42:47 2000 From owner-freebsd-audit@FreeBSD.ORG Fri Dec 15 05:42:45 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (poynting.physics.purdue.edu [128.210.146.58]) by hub.freebsd.org (Postfix) with ESMTP id 039FC37B400; Fri, 15 Dec 2000 05:42:45 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id B39C21924; Fri, 15 Dec 2000 08:42:44 -0500 (EST) Date: Fri, 15 Dec 2000 08:42:44 -0500 From: Will Andrews To: Kris Kennaway Cc: Will Andrews , security-officer@FreeBSD.org, audit@FreeBSD.org Subject: Re: audit patches need reviewing/committing Message-ID: <20001215084244.K1873@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , Kris Kennaway , security-officer@FreeBSD.org, audit@FreeBSD.org References: <20001214191511.Z1873@puck.firepipe.net> <20001214222159.B2040@citusc.usc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001214222159.B2040@citusc.usc.edu>; from kris@FreeBSD.org on Thu, Dec 14, 2000 at 10:21:59PM -0800 X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: will@puck.firepipe.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Dec 14, 2000 at 10:21:59PM -0800, Kris Kennaway wrote: > You raise a valid point - we need to make sure we don't lose the > new-found momentum on audit, and that the older hands amongst the > audit group give appropriate sign-offs on acceptable patches (or > not). I wish I could be doing this myself right now, but it's > difficult to even keep up with the regular security officer workload > since I'm on vacation. It was certainly _not_ an attack on your (or anyone else's) current situation.. I am aware that some people (especially on the SO team) are particularly starved for time at the moment. However, I'm also sure that at some point something will need to be done. You are the current head of the SO team, and if you know someone who has free time that you trust to review people's audit diffs I'd advise appointing them. :-) > So I'd like to echo Will's call for people to make the effort to > review some of the patches posted here and to give any comments that > occur, positive or negative. Indeed.. what we have are a lot of people interested in auditing but not so many who understand all the implications. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Dec 15 11:46:45 2000 From owner-freebsd-audit@FreeBSD.ORG Fri Dec 15 11:46:43 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (poynting.physics.purdue.edu [128.210.146.58]) by hub.freebsd.org (Postfix) with ESMTP id 9CFCE37B400; Fri, 15 Dec 2000 11:46:43 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id 14B2018D4; Fri, 15 Dec 2000 14:46:43 -0500 (EST) Date: Fri, 15 Dec 2000 14:46:43 -0500 From: Will Andrews To: Sheldon Hearn Cc: Will Andrews , security-officer@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: audit patches need reviewing/committing Message-ID: <20001215144643.D357@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , Sheldon Hearn , security-officer@FreeBSD.ORG, audit@FreeBSD.ORG References: <20001214191511.Z1873@puck.firepipe.net> <93368.976874388@axl.fw.uunet.co.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <93368.976874388@axl.fw.uunet.co.za>; from sheldonh@uunet.co.za on Fri, Dec 15, 2000 at 11:59:48AM +0200 X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: will@puck.firepipe.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Dec 15, 2000 at 11:59:48AM +0200, Sheldon Hearn wrote: > I would suggest that the primarily enthusiastic folks send patches to > this list for comment. I think that the primarily clueful folks should, > when pressed for time, limit themselves to commentary on those patches. This is exactly what I said. I'm on your side of the clue boat too. ;) -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Dec 15 19:49:35 2000 From owner-freebsd-audit@FreeBSD.ORG Fri Dec 15 19:49:33 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123]) by hub.freebsd.org (Postfix) with ESMTP id 6197437B404; Fri, 15 Dec 2000 19:49:33 -0800 (PST) Received: (from kris@localhost) by citusc.usc.edu (8.9.3/8.9.3) id TAA09979; Fri, 15 Dec 2000 19:50:49 -0800 Date: Fri, 15 Dec 2000 19:50:49 -0800 From: Kris Kennaway To: Will Andrews , Kris Kennaway , security-officer@FreeBSD.org, audit@FreeBSD.org Subject: Re: audit patches need reviewing/committing Message-ID: <20001215195049.D9777@citusc.usc.edu> References: <20001214191511.Z1873@puck.firepipe.net> <20001214222159.B2040@citusc.usc.edu> <20001215084244.K1873@puck.firepipe.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="F8dlzb82+Fcn6AgP" Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20001215084244.K1873@puck.firepipe.net>; from will@physics.purdue.edu on Fri, Dec 15, 2000 at 08:42:44AM -0500 Sender: kris@citusc.usc.edu Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --F8dlzb82+Fcn6AgP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 15, 2000 at 08:42:44AM -0500, Will Andrews wrote: > On Thu, Dec 14, 2000 at 10:21:59PM -0800, Kris Kennaway wrote: > > You raise a valid point - we need to make sure we don't lose the > > new-found momentum on audit, and that the older hands amongst the > > audit group give appropriate sign-offs on acceptable patches (or > > not). I wish I could be doing this myself right now, but it's > > difficult to even keep up with the regular security officer workload > > since I'm on vacation. >=20 > It was certainly _not_ an attack on your (or anyone else's) current > situation.. I am aware that some people (especially on the SO team) are > particularly starved for time at the moment. However, I'm also sure > that at some point something will need to be done. You are the current > head of the SO team, and if you know someone who has free time that you > trust to review people's audit diffs I'd advise appointing them. :-) There's not really much I can do to "appoint" someone to the position unless they want to do it. So all I can do is ask loudly for the existing crowd to do this. Kris --F8dlzb82+Fcn6AgP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6OuaZWry0BWjoQKURAqSwAJ4z1uglP4Oq51PTFV1g+PeMtWQ1YACg++Os 7cr46aHHEGqX5MngfS+Qqc8= =/K+I -----END PGP SIGNATURE----- --F8dlzb82+Fcn6AgP-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Dec 15 19:58: 0 2000 From owner-freebsd-audit@FreeBSD.ORG Fri Dec 15 19:57:58 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (poynting.physics.purdue.edu [128.210.146.58]) by hub.freebsd.org (Postfix) with ESMTP id 29DC637B400; Fri, 15 Dec 2000 19:57:58 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id 3379218D4; Fri, 15 Dec 2000 22:57:57 -0500 (EST) Date: Fri, 15 Dec 2000 22:57:57 -0500 From: Will Andrews To: Kris Kennaway Cc: Will Andrews , security-officer@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: audit patches need reviewing/committing Message-ID: <20001215225757.J21327@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , Kris Kennaway , security-officer@FreeBSD.ORG, audit@FreeBSD.ORG References: <20001214191511.Z1873@puck.firepipe.net> <20001214222159.B2040@citusc.usc.edu> <20001215084244.K1873@puck.firepipe.net> <20001215195049.D9777@citusc.usc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001215195049.D9777@citusc.usc.edu>; from kris@FreeBSD.ORG on Fri, Dec 15, 2000 at 07:50:49PM -0800 X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: will@puck.firepipe.net Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Dec 15, 2000 at 07:50:49PM -0800, Kris Kennaway wrote: > There's not really much I can do to "appoint" someone to the position > unless they want to do it. So all I can do is ask loudly for the > existing crowd to do this. Of course. I'm just saying you should make some attempt to find someone who is willing to be a victim^W^W^Whelp review / stamp a seal of approval on some diffs. :-) -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message