From owner-freebsd-audit Tue Jan 23 6:23:50 2001 Delivered-To: freebsd-audit@freebsd.org Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18]) by hub.freebsd.org (Postfix) with ESMTP id A84D937B6A4; Tue, 23 Jan 2001 06:23:11 -0800 (PST) Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112]) by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f0NEN6U01974; Tue, 23 Jan 2001 16:23:08 +0200 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.1/8.9.3) with ESMTP id f0NE07Q37210; Tue, 23 Jan 2001 16:00:07 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3A6D8E67.8ED56EE5@FreeBSD.org> Date: Tue, 23 Jan 2001 16:00:09 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.76 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: yokota@FreeBSD.org, sos@FreeBSD.org Cc: current@FreeBSD.org, audit@FreeBSD.org Subject: [RFC] Configurable text geometry in VESA_800x600 raster text mode Content-Type: multipart/mixed; boundary="------------53C3D4175924CB963590EC2D" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This is a multi-part message in MIME format. --------------53C3D4175924CB963590EC2D Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Hi, With this message I'm attaching a patch for vidcontrol(1) and vgl(3) to allow a user select his own text geometry (i.e. number of rows and number of columns) in a raster text modes (currently only VESA_800x600 is supported). This should make VESA_800x600 more usable, as the 80x25, which is currently default geometry for this mode, covers only 50% (80 * 16 * 25 * 8 / (800 * 600)) of the usable screen area in this mode. Furthermore, there also should be a possibility to use with raster modes configurable font sizes other than default 16, but unfortunately existing set of console ioctl's doesn't allow to get font size being used currently, so there is no way to restore text console properly after it was switched into a graphics mode. Therefore this feature may be provided later after console ioctl's set has been properly adjusted. -Maxim --------------53C3D4175924CB963590EC2D Content-Type: text/plain; charset=koi8-r; name="vidcontrol.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vidcontrol.diff" Index: libvgl/main.c =================================================================== RCS file: /home/ncvs/src/lib/libvgl/main.c,v retrieving revision 1.8 diff -d -u -r1.8 main.c --- libvgl/main.c 2001/01/13 11:30:16 1.8 +++ libvgl/main.c 2001/01/23 13:09:41 @@ -57,6 +57,7 @@ static int VGLOnDisplay; static unsigned int VGLCurWindow; static int VGLInitDone = 0; +static struct winsize VGLOldWSize; void VGLEnd() @@ -79,8 +80,8 @@ ioctl(0, _IO('V', VGLOldMode - M_VESA_BASE), 0); if (VGLOldMode == M_VESA_800x600) { int size[3]; - size[0] = 80; - size[1] = 25; + size[0] = VGLOldWSize.ws_col; + size[1] = VGLOldWSize.ws_row; size[2] = 16; ioctl(0, KDRASTER, size); } @@ -143,6 +144,11 @@ VGLModeInfo.vi_mode = mode & 0x0ff; if (ioctl(0, CONS_MODEINFO, &VGLModeInfo)) /* FBIO_MODEINFO */ return -1; + + /* If current mode is VESA_800x600 then save its geometry to restore later */ + if ((VGLOldMode >= M_VESA_BASE) && (VGLOldMode == M_VESA_800x600)) + if (ioctl(0, TIOCGWINSZ, &VGLOldWSize)) + return -1; VGLDisplay = (VGLBitmap *)malloc(sizeof(VGLBitmap)); if (VGLDisplay == NULL) Index: vidcontrol/vidcontrol.1 =================================================================== RCS file: /home/ncvs/src/usr.sbin/vidcontrol/vidcontrol.1,v retrieving revision 1.27 diff -d -u -r1.27 vidcontrol.1 --- vidcontrol/vidcontrol.1 2000/11/17 11:44:16 1.27 +++ vidcontrol/vidcontrol.1 2001/01/23 13:09:41 @@ -25,6 +25,7 @@ .Op Fl c Ar appearance .Op Fl d .Op Fl f Ar size Ar file +.Op Fl g Ar geometry .Op Fl i Cm adapter | mode .Op Fl l Ar screen_map .Op Fl L @@ -159,6 +160,18 @@ .Sx EXAMPLES below and the man page for .Xr syscons 4 . +.It Fl g Ar geometry +Set the +.Ar geometry +of the text mode for the modes with selectable +geometry. Currently only raster modes, such as +.Ar VESA_800x600 , +support this option. +See also +.Sx Video Mode Support +and +.Sx EXAMPLES +below. .It Fl s Ar number Set the current vty to .Ar number . @@ -283,6 +296,11 @@ .Pp The above command will load .Pa /usr/share/syscons/scrnmaps/iso-8859-1_to_cp437.scm . +.Pp +The following command will set-up a 100x37 raster text mode (useful for +some LCD models): +.Pp +.Dl vidcontrol -g 100x37 VESA_800x600 .Sh SEE ALSO .Xr kbdcontrol 1 , .Xr vidfont 1 , Index: vidcontrol/vidcontrol.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/vidcontrol/vidcontrol.c,v retrieving revision 1.33 diff -d -u -r1.33 vidcontrol.c --- vidcontrol/vidcontrol.c 2000/10/08 21:34:00 1.33 +++ vidcontrol/vidcontrol.c 2001/01/23 13:09:42 @@ -44,6 +44,10 @@ #include "path.h" #include "decode.h" +#define _VESA_800x600_DFL_COLS 80 +#define _VESA_800x600_DFL_ROWS 25 +#define _VESA_800x600_DFL_FNSZ 16 + char legal_colors[16][16] = { "black", "blue", "green", "cyan", "red", "magenta", "brown", "white", @@ -52,6 +56,8 @@ }; int hex = 0; int number; +int vesa_cols = _VESA_800x600_DFL_COLS; +int vesa_rows = _VESA_800x600_DFL_ROWS; char letter; struct vid_info info; @@ -62,8 +68,8 @@ fprintf(stderr, "%s\n%s\n%s\n%s\n", "usage: vidcontrol [-r fg bg] [-b color] [-c appearance] [-d] [-l scrmap]", " [-i adapter | mode] [-L] [-M char] [-m on|off]", -" [-f size file] [-s number] [-t N|off] [-x] [mode]", -" [fgcol [bgcol]] [show]"); +" [-f size file] [-s number] [-t N|off] [-x] [-g geometry]", +" [mode] [fgcol [bgcol]] [show]"); exit(1); } @@ -318,9 +324,25 @@ if (ioctl(0, mode, NULL) < 0) warn("cannot set videomode"); if (mode == SW_VESA_800x600) { - size[0] = 80; /* columns */ - size[1] = 25; /* rows */ - size[2] = 16; /* font size */ + /* columns */ + if ((vesa_cols * 8 > 800) || (vesa_cols <= 0)) { + warnx("incorrect number of columns: %d", + vesa_cols); + size[0] = _VESA_800x600_DFL_COLS; + } else { + size[0] = vesa_cols; + } + /* rows */ + if ((vesa_rows * _VESA_800x600_DFL_FNSZ > 600) || + (vesa_rows <=0)) { + warnx("incorrect number of rows: %d", + vesa_rows); + size[1] = _VESA_800x600_DFL_ROWS; + } else { + size[1] = vesa_rows; + } + /* font size */ + size[2] = _VESA_800x600_DFL_FNSZ; if (ioctl(0, KDRASTER, size)) { ioerr = errno; if (cur_mode >= M_VESA_BASE) @@ -574,7 +596,7 @@ info.size = sizeof(info); if (ioctl(0, CONS_GETINFO, &info) < 0) err(1, "must be on a virtual console"); - while((opt = getopt(argc, argv, "b:c:df:i:l:LM:m:r:s:t:x")) != -1) + while((opt = getopt(argc, argv, "b:c:df:g:i:l:LM:m:r:s:t:x")) != -1) switch(opt) { case 'b': set_border_color(optarg); @@ -588,6 +610,13 @@ case 'f': load_font(optarg, nextarg(argc, argv, &optind, 'f')); + break; + case 'g': + if (sscanf(optarg, "%dx%d", &vesa_cols, + &vesa_rows) != 2) { + warnx("incorrect geometry: %s", optarg); + usage(); + } break; case 'i': show_info(optarg); --------------53C3D4175924CB963590EC2D-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Jan 24 18:58:57 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail2.iadfw.net (mail2.iadfw.net [206.66.12.234]) by hub.freebsd.org (Postfix) with SMTP id 91FEE37B698 for ; Wed, 24 Jan 2001 18:58:40 -0800 (PST) Received: from jason from [64.31.207.237] by mail2.iadfw.net (/\##/\ Smail3.1.30.16 #30.47) with smtp for sender: id ; Wed, 24 Jan 2001 20:58:40 -0600 (CST) Message-ID: <003701c0867b$7488ddc0$edcf1f40@pdq.net> From: "Jason Smethers" To: Subject: patch to sys/sbin/dump Date: Wed, 24 Jan 2001 21:03:55 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I am submitting the following patch and would appreciate a review http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch It is a simple patch to modified sys/sbin/dump to use SLIST_* macros from instead of semi-rolling it's own. Thanks - Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jan 25 21:59: 2 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 6B3A437B400 for ; Thu, 25 Jan 2001 21:58:40 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f0Q5wcu191535 for ; Fri, 26 Jan 2001 00:58:38 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G7R0091D9XPEV@gkar.cc.vt.edu> for FreeBSD-audit@freebsd.org; Fri, 26 Jan 2001 00:58:37 -0500 (EST) Date: Fri, 26 Jan 2001 00:58:36 -0500 (EST) From: Mike Heffner Subject: lam(1) patch To: FreeBSD-audit Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.6-3 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG The following patch fixes the following: - sprintf() -> snprintf() - manual (unbounded) while() loop string copying -> strlcpy() - use tolower() rather than bit or'ing - sanity check the user specified printf() format - prevent walking off end of inputfile array - some other string bounds issues Reviews please? Also available from: http://filebox.vt.edu/users/mheffner/patches/lam.patch Index: lam.c =================================================================== RCS file: /home/ncvs/src/usr.bin/lam/lam.c,v retrieving revision 1.4 diff -u -r1.4 lam.c --- lam.c 2000/07/10 09:14:15 1.4 +++ lam.c 2001/01/26 05:48:20 @@ -50,6 +50,7 @@ * Author: John Kunze, UCB */ +#include #include #include #include @@ -114,7 +115,8 @@ P = S = F = T = 0; /* capitalized options */ while ((p = *++av) != NULL) { if (*p != '-' || !p[1]) { - morefiles++; + if (++morefiles >= MAXOFILES) + errx(1, "too many input files"); if (*p == '-') ip->fp = stdin; else if ((ip->fp = fopen(p, "r")) == NULL) { @@ -130,7 +132,7 @@ ip++; continue; } - switch (*(c = ++p) | 040) { + switch (tolower(*(c = ++p))) { case 's': if (*++p || (p = *++av)) ip->sepstring = p; @@ -149,13 +151,19 @@ case 'p': ip->pad = 1; P = (*c == 'P' ? 1 : 0); + /* FALLTHROUGH */ case 'f': F = (*c == 'F' ? 1 : 0); if (*++p || (p = *++av)) { fmtp += strlen(fmtp) + 1; - if (fmtp > fmtbuf + BUFSIZ) + if (fmtp >= fmtbuf + sizeof(fmtbuf)) errx(1, "no more format space"); - sprintf(fmtp, "%%%ss", p); + /* restrict format string to only valid width formatters */ + if (strspn(p, "-.0123456789") != strlen(p)) + errx(1, "invalid format string `%s'", p); + if (snprintf(fmtp, fmtbuf + sizeof(fmtbuf) - fmtp, "%%%ss", p) + >= fmtbuf + sizeof(fmtbuf) - fmtp) + errx(1, "no more format space"); ip->format = fmtp; } else @@ -175,13 +183,12 @@ pad(ip) struct openfile *ip; { - register char *p = ip->sepstring; register char *lp = linep; - while (*p) - *lp++ = *p++; + strlcpy(lp, ip->sepstring, line + sizeof(line) - lp); + lp += strlen(lp); if (ip->pad) { - sprintf(lp, ip->format, ""); + snprintf(lp, line + sizeof(line) - lp, ip->format, ""); lp += strlen(lp); } return (lp); @@ -199,7 +206,7 @@ if (ip->eof) return (pad(ip)); - for (p = s; (c = fgetc(ip->fp)) != EOF && p < end; p++) + for (p = s; (c = fgetc(ip->fp)) != EOF && p < end - 1; p++) if ((*p = c) == ip->eol) break; *p = '\0'; @@ -210,10 +217,9 @@ morefiles--; return (pad(ip)); } - p = ip->sepstring; - while (*p) - *lp++ = *p++; - sprintf(lp, ip->format, s); + strlcpy(lp, ip->sepstring, line + sizeof(line) - lp); + lp += strlen(lp); + snprintf(lp, line + sizeof(line) - lp, ip->format, s); lp += strlen(lp); return (lp); } -- Mike Heffner Blacksburg, VA ICQ# 882073 http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jan 25 22:10:40 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 3189037B69D for ; Thu, 25 Jan 2001 22:10:21 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0Q6A5W05074; Fri, 26 Jan 2001 08:10:07 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101260610.f0Q6A5W05074@gratis.grondar.za> To: "Jason Smethers" Cc: freebsd-audit@FreeBSD.ORG Subject: Re: patch to sys/sbin/dump References: <003701c0867b$7488ddc0$edcf1f40@pdq.net> In-Reply-To: <003701c0867b$7488ddc0$edcf1f40@pdq.net> ; from "Jason Smethers" "Wed, 24 Jan 2001 21:03:55 CST." Date: Fri, 26 Jan 2001 08:10:17 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I am submitting the following patch and would appreciate a review > http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch > > It is a simple patch to modified sys/sbin/dump to use SLIST_* macros > from instead of semi-rolling it's own. Looks good to me! Please commit the \7 --> \a part as a separate commit. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jan 25 22:24:45 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id A8D5137B69B for ; Thu, 25 Jan 2001 22:24:24 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0Q6NZW05123; Fri, 26 Jan 2001 08:24:08 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101260624.f0Q6NZW05123@gratis.grondar.za> To: Mike Heffner Cc: FreeBSD-audit Subject: Re: lam(1) patch References: In-Reply-To: ; from Mike Heffner "Fri, 26 Jan 2001 00:58:36 EST." Date: Fri, 26 Jan 2001 08:23:47 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > The following patch fixes the following: > > - sprintf() -> snprintf() > - manual (unbounded) while() loop string copying -> strlcpy() > - use tolower() rather than bit or'ing > - sanity check the user specified printf() format > - prevent walking off end of inputfile array > - some other string bounds issues > > Reviews please? Looks cool to me. While you are in there, you probably also want to blow away the "register" keyword(s) on the lines you are messing with. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Jan 25 22:32:44 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 67B7437B402 for ; Thu, 25 Jan 2001 22:32:26 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f0Q6WLu193437; Fri, 26 Jan 2001 01:32:21 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G7R005PUBHVQ2@gkar.cc.vt.edu>; Fri, 26 Jan 2001 01:32:20 -0500 (EST) Date: Fri, 26 Jan 2001 01:32:19 -0500 (EST) From: Mike Heffner Subject: Re: lam(1) patch In-reply-to: <200101260624.f0Q6NZW05123@gratis.grondar.za> To: Mark Murray Cc: FreeBSD-audit Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.6-3 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 26-Jan-2001 Mark Murray wrote: |> The following patch fixes the following: |> |> - sprintf() -> snprintf() |> - manual (unbounded) while() loop string copying -> strlcpy() |> - use tolower() rather than bit or'ing |> - sanity check the user specified printf() format |> - prevent walking off end of inputfile array |> - some other string bounds issues |> |> Reviews please? | | Looks cool to me. | | While you are in there, you probably also want to blow away the "register" | keyword(s) on the lines you are messing with. | Well I removed one register variable completely because it was no longer needed, but I hadn't touched any other variables. Should I remove "register" from some of the other variables? -- Mike Heffner Blacksburg, VA ICQ# 882073 http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 2:18:57 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 48FE537B400 for ; Fri, 26 Jan 2001 02:18:29 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0QAHPW05767; Fri, 26 Jan 2001 12:17:50 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101261017.f0QAHPW05767@gratis.grondar.za> To: Mike Heffner Cc: FreeBSD-audit Subject: Re: lam(1) patch References: In-Reply-To: ; from Mike Heffner "Fri, 26 Jan 2001 01:32:19 EST." Date: Fri, 26 Jan 2001 12:17:41 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > | While you are in there, you probably also want to blow away the "register" > | keyword(s) on the lines you are messing with. > | > > Well I removed one register variable completely because it was no longer > needed, but I hadn't touched any other variables. Should I remove "register" > from some of the other variables? Yeah. Why not? :-) M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 10: 0:32 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 81F2B37B402 for ; Fri, 26 Jan 2001 10:00:14 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f0QI0Cu267895; Fri, 26 Jan 2001 13:00:12 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G7S00DQS7CBMU@gkar.cc.vt.edu>; Fri, 26 Jan 2001 13:00:11 -0500 (EST) Date: Fri, 26 Jan 2001 13:00:11 -0500 (EST) From: Mike Heffner Subject: RE: patch to sys/sbin/dump In-reply-to: <003701c0867b$7488ddc0$edcf1f40@pdq.net> To: Jason Smethers Cc: FreeBSD-audit Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.6-3 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 25-Jan-2001 Jason Smethers wrote: | I am submitting the following patch and would appreciate a review | http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch | | It is a simple patch to modified sys/sbin/dump to use SLIST_* macros | from instead of semi-rolling it's own. | Would it be better to move dthead to itime.c since it's the only file that uses the list? That way queue.h doesn't need to be included in all the other files that don't use the list. IMO -- Mike Heffner Blacksburg, VA ICQ# 882073 http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 11:54:35 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id 315AC37B400 for ; Fri, 26 Jan 2001 11:54:18 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f0QJsFu289034; Fri, 26 Jan 2001 14:54:15 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G7S003LXCMDVN@gkar.cc.vt.edu>; Fri, 26 Jan 2001 14:54:13 -0500 (EST) Date: Fri, 26 Jan 2001 14:54:13 -0500 (EST) From: Mike Heffner Subject: Re: lam(1) patch In-reply-to: <200101261017.f0QAHPW05767@gratis.grondar.za> To: Mark Murray Cc: FreeBSD-audit Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.6-3 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 26-Jan-2001 Mark Murray wrote: |> | While you are in there, you probably also want to blow away the "register" |> | keyword(s) on the lines you are messing with. |> | |> |> Well I removed one register variable completely because it was no longer |> needed, but I hadn't touched any other variables. Should I remove "register" |> from some of the other variables? | | Yeah. Why not? :-) | Alright, I took `register' off several variables that I don't think really need it. I uploaded the new one, so I won't spam the list with it again. http://filebox.vt.edu/users/mheffner/patches/lam.patch -- Mike Heffner Blacksburg, VA ICQ# 882073 http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 15:19:13 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id F0F4F37B401 for ; Fri, 26 Jan 2001 15:18:53 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0QNIYW08509; Sat, 27 Jan 2001 01:18:39 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101262318.f0QNIYW08509@gratis.grondar.za> To: Mike Heffner Cc: FreeBSD-audit Subject: Re: lam(1) patch References: In-Reply-To: ; from Mike Heffner "Fri, 26 Jan 2001 14:54:13 EST." Date: Sat, 27 Jan 2001 01:18:50 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On 26-Jan-2001 Mark Murray wrote: > |> | While you are in there, you probably also want to blow away the "register" > |> | keyword(s) on the lines you are messing with. > |> | > |> > |> Well I removed one register variable completely because it was no longer > |> needed, but I hadn't touched any other variables. Should I remove "register" > |> from some of the other variables? > | > | Yeah. Why not? :-) OK! Looks good! I'd say "commit", and while your are about it, nuke _all_ of the "registers". M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 15:59:58 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail2.iadfw.net (mail2.iadfw.net [206.66.12.234]) by hub.freebsd.org (Postfix) with SMTP id D310937B69B for ; Fri, 26 Jan 2001 15:59:41 -0800 (PST) Received: from jason from [64.31.207.237] by mail2.iadfw.net (/\##/\ Smail3.1.30.16 #30.47) with smtp for sender: id ; Fri, 26 Jan 2001 17:59:38 -0600 (CST) Message-ID: <002401c087f4$baa63a80$edcf1f40@pdq.net> From: "Jason Smethers" To: "Mike Heffner" , "Mark Murray" Cc: "FreeBSD-audit" References: Subject: Re: patch to sys/sbin/dump Date: Fri, 26 Jan 2001 18:04:33 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG From: "Mark Murray" > Looks good to me! > > Please commit the \7 --> \a part as a separate commit. From: "Mike Heffner" > Would it be better to move dthead to itime.c since it's the only file that > uses the list? That way queue.h doesn't need to be included in all the other > files that don't use the list. > > IMO Yep, done. SLIST_* changes http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch1 '\7' -> '\a' changes http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch2 Thanks - Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 23: 5:45 2001 Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (mcut-b-167.resnet.purdue.edu [128.211.209.167]) by hub.freebsd.org (Postfix) with ESMTP id C43E937B402 for ; Fri, 26 Jan 2001 23:05:28 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id 2E52519EA; Sat, 27 Jan 2001 02:05:28 -0500 (EST) Date: Sat, 27 Jan 2001 02:05:28 -0500 From: Will Andrews To: audit@FreeBSD.org Subject: cut(1) patch Message-ID: <20010127020528.N2071@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , audit@FreeBSD.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="Ie5iOtK4e9kgqh2F" Content-Disposition: inline User-Agent: Mutt/1.2.5i X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --Ie5iOtK4e9kgqh2F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Just a simple patch to cleanup cut.c for BDECFLAGS (constify, de-__P()). http://www.physics.purdue.edu/~will/cut.c.diff --=20 wca --Ie5iOtK4e9kgqh2F Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6cnM3F47idPgWcsURAiOYAKCTC034BOZFBRBJV0MwzOYPMmYHwwCfTIJ8 nPnN0GLlkbxYeiJjUk+hiSE= =6dRS -----END PGP SIGNATURE----- --Ie5iOtK4e9kgqh2F-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 23:36:56 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 6A7C637B400 for ; Fri, 26 Jan 2001 23:36:36 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0R7aBW12909; Sat, 27 Jan 2001 09:36:15 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101270736.f0R7aBW12909@gratis.grondar.za> To: "Jason Smethers" Cc: "Mike Heffner" , "FreeBSD-audit" Subject: Re: patch to sys/sbin/dump References: <002401c087f4$baa63a80$edcf1f40@pdq.net> In-Reply-To: <002401c087f4$baa63a80$edcf1f40@pdq.net> ; from "Jason Smethers" "Fri, 26 Jan 2001 18:04:33 CST." Date: Sat, 27 Jan 2001 09:36:24 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > SLIST_* changes > http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch1 > > '\7' -> '\a' changes > http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch2 Es bueno! Go for it! M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Jan 26 23:53: 3 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 00D5337B400 for ; Fri, 26 Jan 2001 23:52:43 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0R7qKW12971; Sat, 27 Jan 2001 09:52:24 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101270752.f0R7qKW12971@gratis.grondar.za> To: Will Andrews Cc: audit@FreeBSD.ORG Subject: Re: cut(1) patch References: <20010127020528.N2071@puck.firepipe.net> In-Reply-To: <20010127020528.N2071@puck.firepipe.net> ; from Will Andrews "Sat, 27 Jan 2001 02:05:28 EST." Date: Sat, 27 Jan 2001 09:52:34 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Just a simple patch to cleanup cut.c for BDECFLAGS (constify, de-__P()). Looks OK - I'd commit the __P() stuff in a separate commit. > http://www.physics.purdue.edu/~will/cut.c.diff What is + if (fname) {} for?? M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 1:25:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from puck.firepipe.net (mcut-b-167.resnet.purdue.edu [128.211.209.167]) by hub.freebsd.org (Postfix) with ESMTP id 6AF9B37B6A1 for ; Sat, 27 Jan 2001 01:25:19 -0800 (PST) Received: by puck.firepipe.net (Postfix, from userid 1000) id 5E5891AAB; Sat, 27 Jan 2001 04:25:18 -0500 (EST) Date: Sat, 27 Jan 2001 04:25:18 -0500 From: Will Andrews To: Mark Murray Cc: Will Andrews , audit@FreeBSD.ORG Subject: Re: cut(1) patch Message-ID: <20010127042518.A39246@puck.firepipe.net> Reply-To: Will Andrews Mail-Followup-To: Will Andrews , Mark Murray , audit@FreeBSD.ORG References: <20010127020528.N2071@puck.firepipe.net> <200101270752.f0R7qKW12971@gratis.grondar.za> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101270752.f0R7qKW12971@gratis.grondar.za>; from mark@grondar.za on Sat, Jan 27, 2001 at 09:52:34AM +0200 X-Operating-System: FreeBSD 4.2-STABLE i386 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 27, 2001 at 09:52:34AM +0200, Mark Murray wrote: > What is=20 >=20 > + if (fname) {} >=20 > for?? Best way I could think of to eliminate "fname not used" issued by BDECFLAGS. Probably a tad lame though.. --=20 wca --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6cpP9F47idPgWcsURAip0AJ913yFzT/aOgDsvSAJJk8a8Qeq/mACeNrUc NwZgNUG/7y5VqFjTcWWFiEg= =+rr/ -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 2:24:46 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id A348237B400 for ; Sat, 27 Jan 2001 02:24:26 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0RAO5W13514; Sat, 27 Jan 2001 12:24:08 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101271024.f0RAO5W13514@gratis.grondar.za> To: Will Andrews Cc: audit@FreeBSD.ORG Subject: Re: cut(1) patch References: <20010127042518.A39246@puck.firepipe.net> In-Reply-To: <20010127042518.A39246@puck.firepipe.net> ; from Will Andrews "Sat, 27 Jan 2001 04:25:18 EST." Date: Sat, 27 Jan 2001 12:24:19 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Sat, Jan 27, 2001 at 09:52:34AM +0200, Mark Murray wrote: > > What is > > > > + if (fname) {} > > > > for?? > > Best way I could think of to eliminate "fname not used" issued by > BDECFLAGS. Probably a tad lame though.. /* ARGUSED */ - that is as far as you will get it. _Please_ lose the do-nothing crap :-). M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 3:46:40 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (pool212-tch-1.Sofia.0rbitel.net [212.95.170.212]) by hub.freebsd.org (Postfix) with SMTP id 2C53237B400 for ; Sat, 27 Jan 2001 03:46:02 -0800 (PST) Received: (qmail 1847 invoked by uid 1000); 27 Jan 2001 11:43:42 -0000 Date: Sat, 27 Jan 2001 13:43:41 +0200 From: Peter Pentchev To: Will Andrews Cc: Mark Murray , audit@FreeBSD.ORG Subject: Re: cut(1) patch Message-ID: <20010127134341.A328@ringworld.oblivion.bg> Mail-Followup-To: Will Andrews , Mark Murray , audit@FreeBSD.ORG References: <20010127020528.N2071@puck.firepipe.net> <200101270752.f0R7qKW12971@gratis.grondar.za> <20010127042518.A39246@puck.firepipe.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010127042518.A39246@puck.firepipe.net>; from will@physics.purdue.edu on Sat, Jan 27, 2001 at 04:25:18AM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 27, 2001 at 04:25:18AM -0500, Will Andrews wrote: > On Sat, Jan 27, 2001 at 09:52:34AM +0200, Mark Murray wrote: > > What is > > > > + if (fname) {} > > > > for?? > > Best way I could think of to eliminate "fname not used" issued by > BDECFLAGS. Probably a tad lame though.. I usually eliminate such warnings by.. #ifdef __GNUC__ #define __UNUS __attribute__((unused)) #else #define __UNUS #endif int func(int foo, char *bar __UNUS) { ... } G'luck, Peter -- This sentence would be seven words long if it were six words shorter. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 4:34: 7 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail.gmx.net (pop.gmx.net [194.221.183.20]) by hub.freebsd.org (Postfix) with SMTP id 3BB0A37B400 for ; Sat, 27 Jan 2001 04:33:50 -0800 (PST) Received: (qmail 1445 invoked by uid 0); 27 Jan 2001 12:33:03 -0000 Received: from pc19ebf3d.dip.t-dialin.net (HELO forge.local) (193.158.191.61) by mail.gmx.net (mail05) with SMTP; 27 Jan 2001 12:33:03 -0000 Received: from thomas by forge.local with local (Exim 3.16 #1 (Debian)) id 14MUcy-00010w-00 for ; Sat, 27 Jan 2001 13:38:48 +0100 Date: Sat, 27 Jan 2001 13:38:48 +0100 To: audit@freebsd.org Subject: Re: cut(1) patch Message-ID: <20010127133848.A3876@crow.dom2ip.de> Mail-Followup-To: tmoestl@gmx.net, audit@freebsd.org References: <20010127020528.N2071@puck.firepipe.net> <200101270752.f0R7qKW12971@gratis.grondar.za> <20010127042518.A39246@puck.firepipe.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010127042518.A39246@puck.firepipe.net>; from will@physics.purdue.edu on Sat, Jan 27, 2001 at 04:25:18AM -0500 From: Thomas Moestl Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Jan 27, 2001 at 04:25:18AM -0500, Will Andrews wrote: > On Sat, Jan 27, 2001 at 09:52:34AM +0200, Mark Murray wrote: > > What is > > > > + if (fname) {} > > > > for?? > > Best way I could think of to eliminate "fname not used" issued by > BDECFLAGS. Probably a tad lame though.. Won't (void)fname; do? This usually silences these warnings for me, plus I'm relatvely sure that gcc will not generate any code from it ;-) - thomas To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 6: 7:56 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 82D9A37B400 for ; Sat, 27 Jan 2001 06:07:36 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0RE6wW14099; Sat, 27 Jan 2001 16:07:01 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101271407.f0RE6wW14099@gratis.grondar.za> To: Peter Pentchev Cc: Will Andrews , audit@FreeBSD.ORG Subject: Re: cut(1) patch References: <20010127134341.A328@ringworld.oblivion.bg> In-Reply-To: <20010127134341.A328@ringworld.oblivion.bg> ; from Peter Pentchev "Sat, 27 Jan 2001 13:43:41 +0200." Date: Sat, 27 Jan 2001 16:07:10 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I usually eliminate such warnings by.. > > #ifdef __GNUC__ > #define __UNUS __attribute__((unused)) > #else > #define __UNUS > #endif > > int func(int foo, char *bar __UNUS) { ... } I really like this! I'm not sure I like the macro (but I can live with it). Next question - I'd like to put this somewhere where you don't have to keep redefining it. Same header that currently has __P()? sys/cdefs.h seems to be a good one. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 9:17:51 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id C2D0537B404 for ; Sat, 27 Jan 2001 09:17:33 -0800 (PST) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f0RHHVu363188; Sat, 27 Jan 2001 12:17:31 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0G7U00DDQ015FY@gkar.cc.vt.edu>; Sat, 27 Jan 2001 12:17:29 -0500 (EST) Date: Sat, 27 Jan 2001 12:17:29 -0500 (EST) From: Mike Heffner Subject: Re: patch to sys/sbin/dump In-reply-to: <002401c087f4$baa63a80$edcf1f40@pdq.net> To: Jason Smethers Cc: FreeBSD-audit , Mark Murray Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.6-3 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 27-Jan-2001 Jason Smethers wrote: | Yep, done. | | SLIST_* changes | http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch1 | Make sure you move the dumptime structure definition to itime.c too (since it has SLIST_ENTRY(...) in it), then it's a go =) -- Mike Heffner Blacksburg, VA ICQ# 882073 http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 17: 1:33 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mail2.iadfw.net (mail2.iadfw.net [206.66.12.234]) by hub.freebsd.org (Postfix) with SMTP id 6D01037B404 for ; Sat, 27 Jan 2001 17:01:16 -0800 (PST) Received: from jason from [64.31.207.237] by mail2.iadfw.net (/\##/\ Smail3.1.30.16 #30.47) with smtp for sender: id ; Sat, 27 Jan 2001 19:01:17 -0600 (CST) Message-ID: <00b601c088c6$86338780$edcf1f40@pdq.net> From: "Jason Smethers" To: "Mike Heffner" Cc: "FreeBSD-audit" References: Subject: Re: patch to sys/sbin/dump Date: Sat, 27 Jan 2001 19:06:19 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG From: "Mike Heffner" > On 27-Jan-2001 Jason Smethers wrote: > | Yep, done. > | > | SLIST_* changes > | http://64.31.203.118/~jason/FreeBSD-other/queue/patches/dump.patch1 > | > > Make sure you move the dumptime structure definition to itime.c too (since it > has SLIST_ENTRY(...) in it), then it's a go =) That's a definite DUH. Sorry, my box running -current had its disk holding its /usr/obj die so I hadn't tested it yet. - Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Jan 27 23:48:21 2001 Delivered-To: freebsd-audit@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id B827F37B400 for ; Sat, 27 Jan 2001 23:48:01 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0S7lfW18462; Sun, 28 Jan 2001 09:47:46 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101280747.f0S7lfW18462@gratis.grondar.za> To: "Jason Smethers" Cc: "FreeBSD-audit" Subject: Re: patch to sys/sbin/dump References: <00b601c088c6$86338780$edcf1f40@pdq.net> In-Reply-To: <00b601c088c6$86338780$edcf1f40@pdq.net> ; from "Jason Smethers" "Sat, 27 Jan 2001 19:06:19 CST." Date: Sun, 28 Jan 2001 09:47:46 +0200 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > Make sure you move the dumptime structure definition to itime.c too > (since it > > has SLIST_ENTRY(...) in it), then it's a go =) > > That's a definite DUH. Sorry, my box running -current had its disk > holding its /usr/obj die so I hadn't tested it yet. Guys - PLEASE - before sending stuff here for review, the minimum requirement is that it is tested and been proven to work on at least your own development setup. If you haven't done that, there is no point in asking for a review. M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message