From owner-freebsd-qa Mon Apr 2 10:37:27 2001 Delivered-To: freebsd-qa@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 88B4D37B724; Mon, 2 Apr 2001 10:37:21 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f32HarG69399; Mon, 2 Apr 2001 10:36:57 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200103310450.f2V4ofO08270@harmony.village.org> Date: Mon, 02 Apr 2001 10:36:25 -0800 (PDT) From: John Baldwin To: Warner Losh Subject: Re: followup to problems with 4.3-RC1 for laptops Cc: Mike Smith , John Reynolds , mobile@FreeBSD.org, qa@FreeBSD.org Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 31-Mar-01 Warner Losh wrote: > In message John Baldwin writes: >: That is easy enough to work around, just have the cardbus code mask out >: INTR_FAST in its bus_setup_intr and bus_teardown_intr and it will work fine. >: This will hurt sio(4) performance some however, but if fast interrupts are a >: problem for cardbus you can always turn them off. > > The problem isn't FAST interrupts with cardbus. The problem is that > fast interrupts can't be shared. I don't think sio does anything that > requires a fast interrupt, except for the latency issues for the 16550 > uarts. They can't tolerate the latency we have in non-fast interrupts > in current :-(. I realize that fast interrupts can't be shared, so they are problematic in that regard, and you can still mask out INTR_FAST and INTR_EXCL if you wish in the bus layer so that the attaching device doesn't have to special case its code but can instead basically say what its desires are and let the bus decide if all of them can be satisified or not. > Warner -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 10:44:27 2001 Delivered-To: freebsd-qa@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 746C637B71A; Mon, 2 Apr 2001 10:44:19 -0700 (PDT) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f32HiJY29625; Mon, 2 Apr 2001 10:44:19 -0700 (PDT) Date: Mon, 2 Apr 2001 10:44:19 -0700 From: Alfred Perlstein To: John Baldwin Cc: Warner Losh , Mike Smith , John Reynolds , mobile@FreeBSD.ORG, qa@FreeBSD.ORG Subject: Re: followup to problems with 4.3-RC1 for laptops Message-ID: <20010402104419.U813@fw.wintelcom.net> References: <200103310450.f2V4ofO08270@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.ORG on Mon, Apr 02, 2001 at 10:36:25AM -0800 X-all-your-base: are belong to us. Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010402 10:37] wrote: > > On 31-Mar-01 Warner Losh wrote: > > In message John Baldwin writes: > >: That is easy enough to work around, just have the cardbus code mask out > >: INTR_FAST in its bus_setup_intr and bus_teardown_intr and it will work fine. > >: This will hurt sio(4) performance some however, but if fast interrupts are a > >: problem for cardbus you can always turn them off. > > > > The problem isn't FAST interrupts with cardbus. The problem is that > > fast interrupts can't be shared. I don't think sio does anything that > > requires a fast interrupt, except for the latency issues for the 16550 > > uarts. They can't tolerate the latency we have in non-fast interrupts > > in current :-(. > > I realize that fast interrupts can't be shared, so they are problematic in that > regard, and you can still mask out INTR_FAST and INTR_EXCL if you wish in the > bus layer so that the attaching device doesn't have to special case its code > but can instead basically say what its desires are and let the bus decide if > all of them can be satisified or not. Shouldn't the device be able to specify an all-or-nothing request? Perhaps something that needs fast interrupts will cause much hair pulling if it doesn't get one becasue of latency issues messing up the hardware. If the bus didn't grant a fast interrupt it could then declien to attach, perhaps spitting out a meaningful error message at the same time. My apologies if this has already been brought up. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 11:34:56 2001 Delivered-To: freebsd-qa@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 6C74637B71F; Mon, 2 Apr 2001 11:34:38 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f32IYRG70883; Mon, 2 Apr 2001 11:34:27 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010402104419.U813@fw.wintelcom.net> Date: Mon, 02 Apr 2001 11:33:58 -0800 (PDT) From: John Baldwin To: Alfred Perlstein Subject: Re: followup to problems with 4.3-RC1 for laptops Cc: qa@FreeBSD.org, mobile@FreeBSD.org, John Reynolds , Mike Smith , Warner Losh Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 02-Apr-01 Alfred Perlstein wrote: > * John Baldwin [010402 10:37] wrote: >> >> On 31-Mar-01 Warner Losh wrote: >> > In message John Baldwin writes: >> >: That is easy enough to work around, just have the cardbus code mask out >> >: INTR_FAST in its bus_setup_intr and bus_teardown_intr and it will work >> >: fine. >> >: This will hurt sio(4) performance some however, but if fast interrupts >> >: are a >> >: problem for cardbus you can always turn them off. >> > >> > The problem isn't FAST interrupts with cardbus. The problem is that >> > fast interrupts can't be shared. I don't think sio does anything that >> > requires a fast interrupt, except for the latency issues for the 16550 >> > uarts. They can't tolerate the latency we have in non-fast interrupts >> > in current :-(. >> >> I realize that fast interrupts can't be shared, so they are problematic in >> that >> regard, and you can still mask out INTR_FAST and INTR_EXCL if you wish in >> the >> bus layer so that the attaching device doesn't have to special case its code >> but can instead basically say what its desires are and let the bus decide if >> all of them can be satisified or not. > > Shouldn't the device be able to specify an all-or-nothing request? > > Perhaps something that needs fast interrupts will cause much hair > pulling if it doesn't get one becasue of latency issues messing up > the hardware. If the bus didn't grant a fast interrupt it could then > declien to attach, perhaps spitting out a meaningful error message > at the same time. True, no need for an error message, but I suppose one could do something like this then: if (BUS_SETUP_INTR(..., INTR_FOO | INTR_FAST, ...) != 0) { error = BUS_SETUP_INTR(..., INTR_FOO, ...); if (error) return (error); } > My apologies if this has already been brought up. No, it was also something kicking around in my head, but I didn't mention it. Wasn't sure if that was an implied condition of bus_setup_intr(). -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 12:20:39 2001 Delivered-To: freebsd-qa@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 811B937B725; Mon, 2 Apr 2001 12:20:34 -0700 (PDT) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f32JKYg02571; Mon, 2 Apr 2001 12:20:34 -0700 (PDT) Date: Mon, 2 Apr 2001 12:20:34 -0700 From: Alfred Perlstein To: John Baldwin Cc: qa@FreeBSD.org, mobile@FreeBSD.org, John Reynolds , Mike Smith , Warner Losh Subject: Re: followup to problems with 4.3-RC1 for laptops Message-ID: <20010402122034.V813@fw.wintelcom.net> References: <20010402104419.U813@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Apr 02, 2001 at 11:33:58AM -0800 X-all-your-base: are belong to us. Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010402 11:34] wrote: > > On 02-Apr-01 Alfred Perlstein wrote: > > Shouldn't the device be able to specify an all-or-nothing request? > > > > Perhaps something that needs fast interrupts will cause much hair > > pulling if it doesn't get one becasue of latency issues messing up > > the hardware. If the bus didn't grant a fast interrupt it could then > > declien to attach, perhaps spitting out a meaningful error message > > at the same time. > > True, no need for an error message, but I suppose one could do something like > this then: Of course there's no need for an error message, everyone installing FreeBSD should be able to look at the kernel sources for his driver and figure out what's wrong with it. *gulps down another 2 sarcasm pills* -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 15:17:53 2001 Delivered-To: freebsd-qa@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 9D59E37B773; Mon, 2 Apr 2001 15:17:36 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f32MHFG77490; Mon, 2 Apr 2001 15:17:15 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010402122034.V813@fw.wintelcom.net> Date: Mon, 02 Apr 2001 15:16:50 -0800 (PDT) From: John Baldwin To: Alfred Perlstein Subject: Re: followup to problems with 4.3-RC1 for laptops Cc: Warner Losh , Mike Smith , John Reynolds , mobile@FreeBSD.org, qa@FreeBSD.org Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 02-Apr-01 Alfred Perlstein wrote: > * John Baldwin [010402 11:34] wrote: >> >> On 02-Apr-01 Alfred Perlstein wrote: >> > Shouldn't the device be able to specify an all-or-nothing request? >> > >> > Perhaps something that needs fast interrupts will cause much hair >> > pulling if it doesn't get one becasue of latency issues messing up >> > the hardware. If the bus didn't grant a fast interrupt it could then >> > declien to attach, perhaps spitting out a meaningful error message >> > at the same time. >> >> True, no need for an error message, but I suppose one could do something >> like >> this then: > > Of course there's no need for an error message, everyone installing > FreeBSD should be able to look at the kernel sources for his driver > and figure out what's wrong with it. If you get an error in attach(), you will return it back up the chain and device_probe_and_attach() will output a message such as: foo0: attach failed - returned 6 or some such. > *gulps down another 2 sarcasm pills* *thwap* -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 15:30:27 2001 Delivered-To: freebsd-qa@freebsd.org Received: from web13203.mail.yahoo.com (web13203.mail.yahoo.com [216.136.174.188]) by hub.freebsd.org (Postfix) with SMTP id 2291837B729 for ; Mon, 2 Apr 2001 15:30:20 -0700 (PDT) (envelope-from lipshitz909@yahoo.com) Message-ID: <20010402223019.98737.qmail@web13203.mail.yahoo.com> Received: from [63.120.199.34] by web13203.mail.yahoo.com; Mon, 02 Apr 2001 15:30:19 PDT Date: Mon, 2 Apr 2001 15:30:19 -0700 (PDT) From: Larry Librettez Subject: Re: 4.3-BETA won't su to root in X terminal - UPDATE To: Robert Watson Cc: freebsd-qa@freebsd.org, freebsd-questions@freebsd.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I've done a fresh install off a 4.3rc2 iso on a reformatted FreeBSD partition. Unfortunately, I still cannot su to root in an rxvt xterminal. I can however with xterm, gnome-terminal, or kterm in Gnome or KDE. And I can su to root from a plain console outside X. To recap, this problem did not exist with the 4.2-STABLE kernel/world. And yes, the regular user is a member of the wheel group. Has anyone had this problem aside from me (cannot su to root in rxvt within X, but no such problem with xterm, gnome-terminal, kterm), with 4.3-RC? Any ideas on how to fix it? --- Robert Watson wrote: > > Larry, > > Did you have any luck resolving the problem? > Haven't heard from you in a > week, and the 4.3-RELEASE deadline is rapidly > approaching. If this is a > reproduceable problem, would be nice to get it fixed > before the release. > > Robert N M Watson FreeBSD Core Team, > TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport > Network Services > > On Fri, 23 Mar 2001, Robert Watson wrote: > > > On Thu, 22 Mar 2001, Larry Librettez wrote: > > > > > Here are the outputs, appropriately named. I > concatenated the output > > > for an rxvt window to the 'xterm' file. I hope > this is helpful. > > > > Unfortunately, it was helpful in the sense that it > eliminated a few > > sources of potential problems, but didn't identify > the actual problem. > > The next step may be to instrument su to generate > more debugging output as > > it proceeds. Is that something you feel > comfortable doing, or would you > > like me to send you patches? > > > > Also, can you e-mail me (privately) the output of > running 'nm' on your su > > binary, as well as the contents of your > /etc/pam.conf and /etc/auth.conf? > > This will provide me with more information about > your system > > configuration, as well as determine what features > of su were enabled in > > the version installed on your system (whether it > ended up being a > > kerberized version due to the sysinstall bug, > etc). Thanks, and hopefully > > we can resolve this soon. > > > > Robert N M Watson FreeBSD Core Team, > TrustedBSD Project > > robert@fledge.watson.org NAI Labs, Safeport > Network Services > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-qa" in the body of the > message > > > __________________________________________________ Do You Yahoo!? Get email at your own domain with Yahoo! Mail. http://personal.mail.yahoo.com/?.refer=text To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Mon Apr 2 23:33:35 2001 Delivered-To: freebsd-qa@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 9D3D237B71B; Mon, 2 Apr 2001 23:33:28 -0700 (PDT) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f336XSm20119; Mon, 2 Apr 2001 23:33:28 -0700 (PDT) Date: Mon, 2 Apr 2001 23:33:28 -0700 From: Alfred Perlstein To: John Baldwin Cc: Warner Losh , Mike Smith , John Reynolds , mobile@FreeBSD.org, qa@FreeBSD.org Subject: Re: followup to problems with 4.3-RC1 for laptops Message-ID: <20010402233328.B813@fw.wintelcom.net> References: <20010402122034.V813@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Apr 02, 2001 at 03:16:50PM -0800 X-all-your-base: are belong to us. Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010402 15:17] wrote: > > On 02-Apr-01 Alfred Perlstein wrote: > > * John Baldwin [010402 11:34] wrote: > >> > >> On 02-Apr-01 Alfred Perlstein wrote: > >> > Shouldn't the device be able to specify an all-or-nothing request? > >> > > >> > Perhaps something that needs fast interrupts will cause much hair > >> > pulling if it doesn't get one becasue of latency issues messing up > >> > the hardware. If the bus didn't grant a fast interrupt it could then > >> > declien to attach, perhaps spitting out a meaningful error message > >> > at the same time. > >> > >> True, no need for an error message, but I suppose one could do something > >> like > >> this then: > > > > Of course there's no need for an error message, everyone installing > > FreeBSD should be able to look at the kernel sources for his driver > > and figure out what's wrong with it. > > If you get an error in attach(), you will return it back up the chain and > device_probe_and_attach() will output a message such as: > > foo0: attach failed - returned 6 > > or some such. How about we just output this: ___ |__ \ / / |_| (_) I'm sure the experienced user will usually know what's wrong. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message From owner-freebsd-qa Wed Apr 4 8:27: 6 2001 Delivered-To: freebsd-qa@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 7B9E837B76D; Wed, 4 Apr 2001 08:26:45 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id BAA11353; Thu, 5 Apr 2001 01:26:31 +1000 Date: Thu, 5 Apr 2001 01:25:16 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Peter Pentchev Cc: freebsd-qa@FreeBSD.ORG, freebsd-audit@FreeBSD.ORG Subject: Re: [Fwd: Re: bin/25243: ftp crashes in remotemodtime ().] In-Reply-To: <20010330153503.B33524@ringworld.oblivion.bg> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 30 Mar 2001, Peter Pentchev wrote: > Uhm. I think this should be fixed in time for 4.3 :) I committed a fix for -current in rev.1.14 of ftp/util.c (since I helped break it :-(). Fixing it in 4.3 doesn't seem as urgent as when I started to fix it. There is only a problem for the broken servers that send the time in a form not understood by ftp. Prior to rev.1.10, ftp converted time strings that it didn't understand into garbage timestamps. > ----- Forwarded message from Peter Pentchev ----- > > Date: Tue, 20 Feb 2001 23:00:04 -0800 (PST) > To: freebsd-bugs@FreeBSD.org > Cc: > From: Peter Pentchev > Subject: Re: bin/25243: ftp crashes in remotemodtime (). > Reply-To: Peter Pentchev > > The following reply was made to PR bin/25243; it has been noted by GNATS. > > From: Peter Pentchev > To: fumis@bigfoot.com > Cc: freebsd-gnats-submit@FreeBSD.org > Subject: Re: bin/25243: ftp crashes in remotemodtime (). > Date: Wed, 21 Feb 2001 08:55:45 +0200 > > On Tue, Feb 20, 2001 at 09:35:01PM -0800, fumis@bigfoot.com wrote: > > > > >Number: 25243 > > >Category: bin > > >Synopsis: ftp crashes in remotemodtime (). > > >Originator: SHIMIZU Fumiyuki > > >Release: 4.2-STABLE > > >Organization: > > >Environment: > > FreeBSD ***snip*** 4.2-STABLE FreeBSD 4.2-STABLE #1: Tue Feb 20 14:01:10 JST 2001 ***snip*** > > >Description: > > /usr/bin/ftp crashes after getting a file. > > > > ftp> get foobar > > local: foobar remote: foobar > > 227 Entering Passive Mode (***snip***) > > 150 Opening data connection for foobar (696075740 bytes). > > 100% |**************************************************| 663 MB 00:00 ETA > > 226 Transfer complete. > > 696075740 bytes received in 11999.42 seconds (56.65 KB/s) > > Segmentation fault - core dumped > > > > >How-To-Repeat: > > Connect to ftpd which answers with less than 14 or more than 15 characters against `MDTM' request, and get some files. > > > > >Fix: > > Braces required just after `if (fmt != NULL)' in remotemodtime (). > > /usr/src/usr.bin/ftp/util.c, line 533 > > And the patch itself (trivial, yet needed indeed).. > > G'luck, > Peter > > -- > "yields falsehood, when appended to its quotation." yields falsehood, when appended to its quotation. > > Index: src/usr.bin/ftp/util.c > =================================================================== > RCS file: /home/ncvs/src/usr.bin/ftp/util.c,v > retrieving revision 1.13 > diff -u -r1.13 util.c > --- src/usr.bin/ftp/util.c 2000/05/22 17:18:38 1.13 > +++ src/usr.bin/ftp/util.c 2001/02/21 06:52:52 > @@ -529,7 +529,7 @@ > y2kbug = 1; > } else if (len == 14) > fmt = "%04d%02d%02d%02d%02d%02d"; > - if (fmt != NULL) > + if (fmt != NULL) { > memset(&timebuf, 0, sizeof(timebuf)); > if (sscanf(mtbuf, fmt, &year, &month, > &timebuf.tm_mday, &timebuf.tm_hour, > @@ -542,6 +542,7 @@ > timebuf.tm_year = year - 1900; > rtime = mktime(&timebuf); > } > + } > } > if (rtime == -1 && (noisy || debug != 0)) > printf("Can't convert %s to a time.\n", mtbuf); > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-bugs" in the body of the message > > > ----- End forwarded message ----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message