From owner-freebsd-audit Mon Oct 14 11: 0:29 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0156737B4E6 for ; Mon, 14 Oct 2002 11:00:28 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC77143EB7 for ; Mon, 14 Oct 2002 11:00:26 -0700 (PDT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9EI0QCo090316 for ; Mon, 14 Oct 2002 11:00:26 -0700 (PDT) (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9EI0Qbl090298 for audit@freebsd.org; Mon, 14 Oct 2002 11:00:26 -0700 (PDT) Date: Mon, 14 Oct 2002 11:00:26 -0700 (PDT) Message-Id: <200210141800.g9EI0Qbl090298@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: audit@FreeBSD.org Subject: Current problem reports assigned to you Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Current FreeBSD problem reports Critical problems Serious problems Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- a [1999/01/28] bin/9770 audit An openpty(3) auxiliary program 1 problem total. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Oct 15 19:38:26 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCE9437B401; Tue, 15 Oct 2002 19:38:23 -0700 (PDT) Received: from phalanx.trit.org (phalanx.trit.org [63.198.170.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5359443E6E; Tue, 15 Oct 2002 19:38:23 -0700 (PDT) (envelope-from dima@trit.org) Received: from sparkie.trit.org (sparkie.trit.org [192.168.4.16]) by phalanx.trit.org (Postfix) with ESMTP id 0CEE91A1BC; Wed, 16 Oct 2002 02:38:23 +0000 (UTC) Received: (from dima@localhost) by sparkie.trit.org (8.10.2+Sun/8.10.2) id g9G2cMV05497; Wed, 16 Oct 2002 02:38:22 GMT X-Authentication-Warning: sparkie.trit.org: dima set sender to dima@trit.org using -f Date: Wed, 16 Oct 2002 02:38:21 +0000 From: Dima Dorfman To: joe@freebsd.org, nik@freebsd.org Cc: audit@freebsd.org Subject: ls -h precision Message-ID: <20021016023821.GC27804@trit.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG When the -h option was added to ls(1), the unit_adjust() routine, which was borrowed from du(1), was changed from taking a double to an off_t. Is there a reason for this change that I'm missing? Changing it back and making the appropriate changes to the caller greatly improves the usefulness of -h. E.g., this file: -rw-r--r-- 1 dima wheel 3070535680 Jan 25 2002 lambda-a.20001129 is reported like this with -h as it is right now: -rw-r--r-- 1 dima wheel 2G Jan 25 2002 lambda-a.20001129 which is somewhat less than useful, since this file is much closer to 3G than 2G. With the attached patch, it is reported like this: -rw-r--r-- 1 dima wheel 2.9G Jan 25 2002 lambda-a.20001129 Any reason this shouldn't be implemented? Other comments? Thanks in advance, Dima. Index: print.c =================================================================== RCS file: /ref/cvsf/src/bin/ls/print.c,v retrieving revision 1.57 diff -u -r1.57 print.c --- print.c 29 Aug 2002 14:29:09 -0000 1.57 +++ print.c 16 Oct 2002 02:37:09 -0000 @@ -93,7 +93,7 @@ typedef enum { NONE, KILO, MEGA, GIGA, TERA, PETA, UNIT_MAX } unit_t; -static unit_t unit_adjust(off_t *); +static unit_t unit_adjust(double *); static int unitp[] = {NONE, KILO, MEGA, GIGA, TERA, PETA}; @@ -602,16 +602,18 @@ static void printsize(size_t width, off_t bytes) { + double dbytes; unit_t unit; if (f_humanval) { - unit = unit_adjust(&bytes); + dbytes = bytes; + unit = unit_adjust(&dbytes); - if (bytes == 0) + if (dbytes == 0) (void)printf("%*s ", width, "0B"); else - (void)printf("%*lld%c ", width - 1, bytes, - "BKMGTPE"[unit]); + (void)printf("%*.*f%c ", width - 1, dbytes > 10 ? 0 : 1, + dbytes, "BKMGTPE"[unit]); } else (void)printf("%*lld ", width, bytes); } @@ -623,13 +625,13 @@ * */ unit_t -unit_adjust(off_t *val) +unit_adjust(double *val) { double abval; unit_t unit; unsigned int unit_sz; - abval = fabs((double)*val); + abval = fabs(*val); unit_sz = abval ? ilogb(abval) / 10 : 0; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Oct 17 3:41:30 2002 Delivered-To: freebsd-audit@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id AF8DE37B401; Thu, 17 Oct 2002 03:41:28 -0700 (PDT) Date: Thu, 17 Oct 2002 03:41:28 -0700 From: Juli Mallett To: audit@FreeBSD.org Cc: current@FreeBSD.org Subject: I often have orphaned FDs in threaded programs... Message-ID: <20021017034126.A45732@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I have a program which shares a lot of (orphaned) FDs between threads, and requesting a dump (SIGINFO) results in a core, because the FD owner si NULL. Here's a diff from my local tree, for review: %%% Index: uthread_info.c =================================================================== RCS file: /home/ncvs/src/lib/libc_r/uthread/uthread_info.c,v retrieving revision 1.21 diff -d -u -r1.21 uthread_info.c --- uthread_info.c 13 Oct 2002 11:23:31 -0000 1.21 +++ uthread_info.c 17 Oct 2002 10:38:49 -0000 @@ -252,10 +252,16 @@ pthread->data.fd.fname, pthread->data.fd.branch); __sys_write(fd, s, strlen(s)); - snprintf(s, sizeof(s), "owner %pr/%pw\n", - _thread_fd_table[pthread->data.fd.fd]->r_owner, - _thread_fd_table[pthread->data.fd.fd]->w_owner); - __sys_write(fd, s, strlen(s)); + /* + * XXX _thread_fd_table[pthread->data.fd.fd] often comes + * up as NULL for me, bandaid it. Is this right? + */ + if (_thread_fd_table[pthread->data.fd.fd] != NULL) { + snprintf(s, sizeof(s), "owner %pr/%pw\n", + _thread_fd_table[pthread->data.fd.fd]->r_owner, + _thread_fd_table[pthread->data.fd.fd]->w_owner); + __sys_write(fd, s, strlen(s)); + } break; case PS_SIGWAIT: snprintf(s, sizeof(s), "sigmask (hi)"); %%% I think it's right to just print no owner, or possibly a no owner message, in these cases. Comments? -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Oct 17 11:12:43 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 154ED37B404 for ; Thu, 17 Oct 2002 11:12:42 -0700 (PDT) Received: from south.nanolink.com (south.nanolink.com [217.75.134.10]) by mx1.FreeBSD.org (Postfix) with SMTP id B526F43E88 for ; Thu, 17 Oct 2002 11:12:40 -0700 (PDT) (envelope-from roam@straylight.ringlet.net) Received: (qmail 58182 invoked by uid 85); 17 Oct 2002 18:21:38 -0000 Received: from office.sbnd.net (HELO straylight.ringlet.net) (217.75.140.130) by south.nanolink.com with SMTP; 17 Oct 2002 18:21:37 -0000 Received: (qmail 16791 invoked by uid 1000); 17 Oct 2002 18:12:25 -0000 Date: Thu, 17 Oct 2002 21:12:25 +0300 From: Peter Pentchev To: audit@FreeBSD.org Subject: [CFR] 4.x-STABLE ftp client signedness patch Message-ID: <20021017181225.GH369@straylight.oblivion.bg> Mail-Followup-To: audit@FreeBSD.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3ecMC0kzqsE2ddMN" Content-Disposition: inline User-Agent: Mutt/1.5.1i X-Virus-Scanned: by Nik's Monitoring Daemon (AMaViS perl-11d ) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --3ecMC0kzqsE2ddMN Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, The "old" FTP client in -STABLE has a little problem when retrieving files via HTTP: a variable that holds the read() return value is unsigned, which leads to misinterpreted failures when the connection is closed by the remote side and read() returns -1. Yes, I know it has never really been ftp(1)'s job to fetch via HTTP; still, this is what a friend of mine has been using until today, when he reported the failure and I tracked down the bug. I taught him about fetch(1), but there is no reason for the bug to stay unfixed :) The trivial patch is attached; it only applies to -STABLE, because -CURRENT uses lukemftp now. I took a look through the lukemftp source with a quick grep for 'size_t' and 'unsigned', and there do not seem to be any similar problems there. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence contains exactly threee erors. Index: src/usr.bin/ftp/fetch.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/usr.bin/ftp/Attic/fetch.c,v retrieving revision 1.12.2.5 diff -u -r1.12.2.5 fetch.c --- src/usr.bin/ftp/fetch.c 25 Jul 2002 15:29:18 -0000 1.12.2.5 +++ src/usr.bin/ftp/fetch.c 17 Oct 2002 07:31:36 -0000 @@ -98,7 +98,7 @@ int i, out, isftpurl; char *port; volatile int s; - size_t len; + ssize_t len; char c, *cp, *ep, *http_buffer, *portnum, *path, buf[4096]; const char *savefile; char *line, *proxy, *host; --3ecMC0kzqsE2ddMN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE9rv2J7Ri2jRYZRVMRAk1oAKDGtcCXFBEl2drpB3mHzTIfsTC0IQCfeuua yVg3J229Ha009rqc6027aZ8= =yirz -----END PGP SIGNATURE----- --3ecMC0kzqsE2ddMN-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Oct 17 13: 3:23 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 065E437B401; Thu, 17 Oct 2002 13:03:23 -0700 (PDT) Received: from mail.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B5BB43E65; Thu, 17 Oct 2002 13:03:22 -0700 (PDT) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g9HK3LKu019197; Thu, 17 Oct 2002 16:03:21 -0400 (EDT) Date: Thu, 17 Oct 2002 16:03:21 -0400 (EDT) From: Daniel Eischen To: Juli Mallett Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG, Daniel Eischen Subject: Re: I often have orphaned FDs in threaded programs... In-Reply-To: <20021017034126.A45732@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 17 Oct 2002, Juli Mallett wrote: > I have a program which shares a lot of (orphaned) FDs between threads, > and requesting a dump (SIGINFO) results in a core, because the FD owner > si NULL. Here's a diff from my local tree, for review: Actually, fd locking is not enabled anymore so that's why the table has null entries. I would recommend just deleting the printing of the owner altogether. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Oct 18 12:12:57 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84FDE37B401 for ; Fri, 18 Oct 2002 12:12:55 -0700 (PDT) Received: from mail.ozemail.com.au (1cust81.tnt3.bne1.da.uu.net [210.84.85.81]) by mx1.FreeBSD.org (Postfix) with SMTP id 3C5DD43E9E for ; Fri, 18 Oct 2002 12:12:49 -0700 (PDT) (envelope-from service@artofservice.com.au) To: "'audit@freebsd.org'" From: service@artofservice.com.au Subject: ITIL in Government and Major Corporations - Has it worked? - BREAKFAST SEMINAR Thu 28/11/02 Date: Fri, 18 Oct 2002 22:02:43 +1000 Message-Id: <37547.918556215277900.1113679@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ITIL in Government and Major Corporations - Has it worked? Speaker: Gerard Blokdijk, Managing Director The Art of Service When: Thursday 28 November - 7.30am to 9.30am Venue: Italo-Australian Club, 78 Franklin Street, Forrest ACT Cost: $45 including GST Features: Breakfast, Networking. Already over 40 participants - CIO's / (IT) Managers. Register: http://www.artofservicedirect.com click on Enrol, Canberra Events Sydney, Brisbane and Melbourne sessions are nearly booked full - Few seats available in Sydney 19/11, Melbourne 29/10 and Brisbane 24/10. About this Event -------------------------- ITIL is more than a simple set of best practices guidelines to optimise a few service management processes. ITIL is a set of non-proprietary, comprehensive, well-documented and fully integrated set of management procedures and best practices that optimises service management and IT/business alignment. With over 20,000 businesses, governments and non-profit organisations using it, ITIL is the most widely accepted process management framework in the world. But has it worked? Many IT organisations suffer from poor perceptions of value and feel powerless to improve the situation. IT's top challenge right now is to build and demonstrate value to the rest of the organisation - be that commerce, government or academia. How are CIO's and their Service Managers to leverage ITIL and ITSM to meet that challenge head on and win? Several ACT and federal governments have started looking at how Service Management can help increase service levels and efficiency. This briefing illustrates the current challenges for government and where ITIL fits into the IT-strategy. Do not be content with prepared remarks alone. Go one-on-one with Gerard, asking the tough questions, eliciting the most revealing replies. Trends are confirmed. Illusions shattered. News is broken. Live on the breakfast briefing stage. Summary ----------------- You are cordially invited to attend an IT Service Management breakfast session presented by The Art of Service. Gerard Blokdijk is Managing Director and co-founder of The Art of Service. Prior to The Art of Service Gerard has successfully set up and managed another IT Service Management education and research firm. He is the author of "IT Management becomes Service", a frequent publisher and public speaker. Gerard has an active duty in IT Management since the late 80's. He has held positions as Capacity Manager, Security Manager, Disaster Recovery Manager, overall IT Manager and CIO for large organisations like ING Bank, ABN AMRO and Philips. Gerard holds the Managers Certificate in IT Service Management. What You'll Get -------------------------- - Insight into the pressing, urgent issues of today and tomorrow, distilled into a brief overview. - Interaction with thought leaders by networking with your peers during question-and-answer sessions with The Art of Service specialists. - Accessibility and convenience. These Briefings are designed to deliver the most critical information without taking too much time from your busy schedule. Registration is on a first-come first-served basis, places are strictly limited, so we encourage early registration. To join, please register at http://www.artofservicedirect.com If you have questions or concerns about the breakfast session email service@artofservice.com.au or call 1300 13 44 99 To change your contact details, reply to this email. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Oct 19 5:53:18 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 405C237B401 for ; Sat, 19 Oct 2002 05:53:17 -0700 (PDT) Received: from straylight.ringlet.net (office.sbnd.net [217.75.140.130]) by mx1.FreeBSD.org (Postfix) with SMTP id 4A76C43E7B for ; Sat, 19 Oct 2002 05:53:14 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 12337 invoked by uid 1000); 19 Oct 2002 12:52:54 -0000 Date: Sat, 19 Oct 2002 15:52:54 +0300 From: Peter Pentchev To: audit@FreeBSD.org Subject: Re: [CFR] 4.x-STABLE ftp client signedness patch Message-ID: <20021019125254.GD363@straylight.oblivion.bg> Mail-Followup-To: audit@FreeBSD.org References: <20021017181225.GH369@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <20021017181225.GH369@straylight.oblivion.bg> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 17, 2002 at 09:12:25PM +0300, Peter Pentchev wrote: > Hi, >=20 > The "old" FTP client in -STABLE has a little problem when retrieving > files via HTTP: a variable that holds the read() return value is > unsigned, which leads to misinterpreted failures when the connection is > closed by the remote side and read() returns -1. >=20 > Yes, I know it has never really been ftp(1)'s job to fetch via HTTP; > still, this is what a friend of mine has been using until today, when he > reported the failure and I tracked down the bug. I taught him about > fetch(1), but there is no reason for the bug to stay unfixed :) >=20 > The trivial patch is attached; it only applies to -STABLE, because > -CURRENT uses lukemftp now. I took a look through the lukemftp source > with a quick grep for 'size_t' and 'unsigned', and there do not seem to > be any similar problems there. Just for the record, I just committed this to -STABLE. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 Thit sentence is not self-referential because "thit" is not a word. --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE9sVWm7Ri2jRYZRVMRAiAuAJ9ln8G7xTvbwO0fKsOoxEPRAlRe1QCgqfaX Ha/GV5IBMhtaXfZqhZMm6iQ= =s+th -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message