From owner-freebsd-isdn Sun Sep 1 23:43:14 2002 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C04AA37B400 for ; Sun, 1 Sep 2002 23:43:12 -0700 (PDT) Received: from guinness.syncrontech.com (guinness.syncrontech.com [62.71.8.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id D21AB43E6A for ; Sun, 1 Sep 2002 23:43:10 -0700 (PDT) (envelope-from ari.suutari@syncrontech.com) Received: from linux (coffee.syncrontech.com [62.71.8.37]) by guinness.syncrontech.com (8.12.3/8.12.3) with ESMTP id g826h7eA019301; Mon, 2 Sep 2002 09:43:07 +0300 (EEST) (envelope-from ari.suutari@syncrontech.com) Content-Type: text/plain; charset="iso-8859-1" From: Ari Suutari Organization: Syncron Tech Oy To: Gary Jennejohn , hselasky@c2i.net Subject: Re: New ihfc driver Date: Mon, 2 Sep 2002 09:43:29 +0300 User-Agent: KMail/1.4.2 Cc: freebsd-isdn@FreeBSD.ORG References: <200208301111.g7UBBUQI005381@peedub.jennejohn.org> In-Reply-To: <200208301111.g7UBBUQI005381@peedub.jennejohn.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200209020943.29552.ari.suutari@syncrontech.com> Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi again, On Friday 30 August 2002 14:11, Gary Jennejohn wrote: > The weird dynamic goto's and opaque macros which you use in > your drivers are IMO not acceptable.=20 =09I just browsed through the sources and the goto statements =09are really weird ! I didn't know that you could do something =09like that in C-language...=20 =09Gary is right about those, they should be changed to something =09that is more common style (like just switch/case). I think that =09everyone understands that a man who can write a device driver =09is a brilliant one even without using the weirdest c-language=20 =09style at all. =09=09Ari S. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message