From owner-freebsd-cvsweb@FreeBSD.ORG  Wed Apr  2 02:31:37 2003
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E398B37B401
	for <freebsd-cvsweb@FreeBSD.org>;
	Wed,  2 Apr 2003 02:31:37 -0800 (PST)
Received: from imap.multamedio.de (imap.multamedio.de [195.27.36.186])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EF52143FA3
	for <freebsd-cvsweb@FreeBSD.org>;
	Wed,  2 Apr 2003 02:31:36 -0800 (PST)
	(envelope-from sschwerdhoefer@multamedio.de)
Received: from amalthea (188.cw2.multamedio.de [195.27.36.188])ESMTP
	id 1887BD5B; Wed,  2 Apr 2003 12:31:35 +0200 (CEST)
Received: by amalthea (Postfix, from userid 1000)
	id A01C33F667; Wed,  2 Apr 2003 12:31:34 +0200 (CEST)
Date: Wed, 2 Apr 2003 12:31:34 +0200
To: freebsd-cvsweb@FreeBSD.org
Message-ID: <20030402103134.GA937@amalthea>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Priority: normal
X-Mailer: Mutt
User-Agent: Mutt/1.5.3i
From: sschwerdhoefer@multamedio.de (Sebastian Schwerdhoefer)
X-Mailman-Approved-At: Wed, 02 Apr 2003 08:19:03 -0800
Subject: error in onclick event
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list [restricted posting]
	<freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2003 10:31:38 -0000

Hi developers

i'm not a perl programmer, but it seem's that i found a little mistake
in cvsweb.cgi. when trying to download a specific revision of a file
not in the default repository via cvsweb in a browser supporting
javascript, we got an error site. The Mistake seems to be in the
onClick event (on the "download" link), where no repository is
specified. so cvs try's to co the file out of the standart repository
which does not work.

cause disabling javascript is not the ultimate solution, i looked at
cvsweb.cgi, searched "onclick" and changed the line below from

hrefquote($fullurl), join (',', @attr);

to 

hrefquote("$fullurl$barequery"), join (',', @attr);

... and it works :-)

we use cvsweb 2.0.4 on Linux 2.2.19 with perl 5.

Sebastian 'Schwerdy' Schwerdhoefer