From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 15:13:20 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 850FE37B401 for ; Tue, 20 May 2003 15:13:20 -0700 (PDT) Received: from EXCHMAIL.softtek.com (exchmail.softtek.com [200.33.249.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id B20E343FB1 for ; Tue, 20 May 2003 15:13:19 -0700 (PDT) (envelope-from rogerio.tambellini@softtek.com) Received: from softtek.com (200-158-60-144.dsl.telesp.net.br [200.158.60.144]) by EXCHMAIL.softtek.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2656.59) id L1F6G6PF; Tue, 20 May 2003 17:09:38 -0500 Message-ID: <3ECAA87C.7090406@softtek.com> Date: Tue, 20 May 2003 19:13:16 -0300 From: Rogerio Tambellini Organization: Softtek do Brasil User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.1 Subject: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 22:13:20 -0000 Hi folks, I'm new on cvsweb and I'm getting this error when I click in a project in the main page of cvsweb (that is working fine). ---------- Error: Failed to spawn GNU rlog on "/usr/local/cvs/JBlog//.classpath,v, /usr/local/cvs/JBlog//.project,v". Did you set the $command_path in your configuration file correctly ? (Currently "/bin:/usr/bin:/usr/local/bin" ---------- My $command_path is configured correctly as rlog command is in /usr/bin directory. What can I do to fix this error? Should I give any permission to my httpd user group? Please, I'm working on this for a couple of days and I need this working propertly urgent. Thanks very much, Rogério From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 15:31:52 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83FE137B401 for ; Tue, 20 May 2003 15:31:52 -0700 (PDT) Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id E236C43FBF for ; Tue, 20 May 2003 15:31:51 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp3.pp.htv.fi (Postfix) with ESMTP id A2B6627AEC8; Wed, 21 May 2003 01:31:50 +0300 (EEST) Received: from cs78130147.pp.htv.fi (cs78130147.pp.htv.fi [62.78.130.147]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id h4KMWP908321; Wed, 21 May 2003 01:32:26 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: Rogerio Tambellini In-Reply-To: <3ECAA87C.7090406@softtek.com> References: <3ECAA87C.7090406@softtek.com> Content-Type: text/plain; charset=ISO-8859-1 Organization: FreeBSD Message-Id: <1053469908.22989.53.camel@bobcat.ods.org> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 21 May 2003 01:31:48 +0300 Content-Transfer-Encoding: 8bit cc: freebsd-cvsweb@FreeBSD.org Subject: Re: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 22:31:52 -0000 On Wed, 2003-05-21 at 01:13, Rogerio Tambellini wrote: > ---------- > > Error: Failed to spawn GNU rlog on "/usr/local/cvs/JBlog//.classpath,v, > /usr/local/cvs/JBlog//.project,v". > > Did you set the $command_path in your configuration file correctly ? > (Currently "/bin:/usr/bin:/usr/local/bin" > ---------- > > My $command_path is configured correctly as rlog command is in /usr/bin > directory. What can I do to fix this error? To get the real errors, you can comment out the line(s) like: open(STDERR, '>/dev/null'); # rlog may complain ... ...around line 2130 (assuming you're using FreeBSD-CVSweb 2.0.6) in cvsweb.cgi and watch your web server error log while clicking the problematic dir link. > Should I give any permission to my httpd user group? Yep, I guess this is a permissions issue. Your web server user needs to be able at least to read the files in the repository. The files INSTALL and cvsweb.conf contain more hints. HTH, -- \/ille Skyttä scop at FreeBSD.org From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 16:07:00 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6040A37B401 for ; Tue, 20 May 2003 16:07:00 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83E3E43F93 for ; Tue, 20 May 2003 16:06:59 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4KN6vH12367; Tue, 20 May 2003 19:06:57 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3])h4KN6uI29263; Tue, 20 May 2003 19:06:56 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4KN6rj02017; Wed, 21 May 2003 09:06:54 +1000 Message-ID: <3ECAB6F8.9000604@redhat.com> Date: Wed, 21 May 2003 09:15:04 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: Rogerio Tambellini References: <3ECAA87C.7090406@softtek.com> In-Reply-To: <3ECAA87C.7090406@softtek.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-cvsweb@freebsd.org Subject: Re: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 23:07:00 -0000 Rogerio, > Error: Failed to spawn GNU rlog on > "/usr/local/cvs/JBlog//.classpath,v, /usr/local/cvs/JBlog//.project,v". > > Did you set the $command_path in your configuration file correctly ? > (Currently "/bin:/usr/bin:/usr/local/bin" As Ville said, this is most likely due to you not having read-permissions on the files in that directory. Since it's not entirely clear as what user CVSweb is running and since you do not necessarily want to give that user all permissions the group has, I suggest to simply allow everyone read-permissions on any files (all directories to be executable for everyone). This should fix it. Cheers, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 16:18:41 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B88EB37B405; Tue, 20 May 2003 16:18:41 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id D770743FCB; Tue, 20 May 2003 16:18:40 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4KNIeH14342; Tue, 20 May 2003 19:18:40 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3])h4KNIcI00945; Tue, 20 May 2003 19:18:38 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4KNIZj02275; Wed, 21 May 2003 09:18:36 +1000 Message-ID: <3ECAB9B5.6060005@redhat.com> Date: Wed, 21 May 2003 09:26:45 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ville_Skytt=E4?= References: <3ECAA87C.7090406@softtek.com> <1053469908.22989.53.camel@bobcat.ods.org> In-Reply-To: <1053469908.22989.53.camel@bobcat.ods.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-cvsweb@freebsd.org Subject: Re: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 23:18:42 -0000 Ville, >To get the real errors, you can comment out the line(s) like: > > open(STDERR, '>/dev/null'); # rlog may complain ... > >...around line 2130 (assuming you're using FreeBSD-CVSweb 2.0.6) in >cvsweb.cgi and watch your web server error log while clicking the >problematic dir link. > I actually ran into the same problem last week, made a fix to the script and submitted it to the list. But, I did this BEFORE I was a member of this list, as such, I only got the response that it awaits confirmation of the list-owner, and I had no response yet. Shall I re-submit the fix? It's very simple, it only checks whether you've got write-permissions to all the files you want to spawn rlog on, and if you don't, then it doesn't spawn rlog on that particular file (as a result, rlog seems to not complain anymore either). You can actually, given you can see the files, check for read-permissions and output an according error-message, this wouldn't require manual fixes in the script later on in order to determine whether you've got the right permissions. Cheers, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 16:56:29 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3A2937B401; Tue, 20 May 2003 16:56:29 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id A47A343F85; Tue, 20 May 2003 16:56:28 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4KNuSH21556; Tue, 20 May 2003 19:56:28 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3])h4KNuPI15424; Tue, 20 May 2003 19:56:26 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4KNuNj02906; Wed, 21 May 2003 09:56:23 +1000 Message-ID: <3ECAC291.3000801@redhat.com> Date: Wed, 21 May 2003 10:04:33 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: Bernd Groh References: <3ECAA87C.7090406@softtek.com> <1053469908.22989.53.camel@bobcat.ods.org> <3ECAB9B5.6060005@redhat.com> In-Reply-To: <3ECAB9B5.6060005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-cvsweb@freebsd.org Subject: Re: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 23:56:30 -0000 Here's the fix: sub getDirLogs($$@) { my ($cvsroot, $dirname, @otherFiles) = @_; my ($state, $otherFiles, $tag, $file, $date, $branchpoint, $branch, $log); my ($rev, $revision, $revwanted, $filename, $head, $author); $tag = $input{only_with_tag}; my ($DirName) = $cvsroot . '/' . $where; my (@files, @filetags); # added new array to store files initially my (@allfiles); my $fh = do { local (*FH); }; push (@allfiles, &safeglob($DirName . '*,v')); push (@allfiles, &safeglob($DirName . 'Attic/*,v')) if (!$input{'hideattic'}); foreach my $file (@otherFiles) { push (@allfiles, $DirName . $file); } # just execute rlog with the files we have read access to # (i'm sure there's an easier way than actually having to # open the file, but I can't think of it at the moment *l*) foreach my $file (@allfiles) { if (-r $file) { push (@files, $file); } } # just execute rlog if there are any files if ($#files < 0) { return; } # this will now also ensure that rlog is not called on any # files it really shouldn't be # after this point, code remains the same ... This will now simply not display any files you do not have read-permissions on. Adding an according error-message later on might be a good option. Cheers, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Tue May 20 17:04:55 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A48E737B404; Tue, 20 May 2003 17:04:55 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81FA743F3F; Tue, 20 May 2003 17:04:54 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4L04sH23009; Tue, 20 May 2003 20:04:54 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3])h4L04qI17535; Tue, 20 May 2003 20:04:52 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4L04oj03040; Wed, 21 May 2003 10:04:50 +1000 Message-ID: <3ECAC48C.10503@redhat.com> Date: Wed, 21 May 2003 10:13:00 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: Bernd Groh References: <3ECAA87C.7090406@softtek.com> <1053469908.22989.53.camel@bobcat.ods.org> <3ECAB9B5.6060005@redhat.com> <3ECAC291.3000801@redhat.com> In-Reply-To: <3ECAC291.3000801@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-cvsweb@freebsd.org Subject: Re: Error: Failed to spawn GNU rlog X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 May 2003 00:04:56 -0000 > # (i'm sure there's an easier way than actually having to > # open the file, but I can't think of it at the moment *l*) Erm, yes, this comment you can ignore. *l* I tried -r the other day and it didn't work for some reason (I must have been too tired to figure what I did wrong), so I actually opened the files in my first fix -- as said, please ignore! :-) Cheers, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Wed May 14 23:13:59 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E27337B401 for ; Wed, 14 May 2003 23:13:59 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 877F143FAF for ; Wed, 14 May 2003 23:13:58 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4F6DwH08119 for ; Thu, 15 May 2003 02:13:58 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4F6DuI05630 for ; Thu, 15 May 2003 02:13:57 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.77]) h4F6Dsj19765 for ; Thu, 15 May 2003 16:13:55 +1000 Message-ID: <3EC3320F.3050104@redhat.com> Date: Thu, 15 May 2003 16:22:07 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@FreeBSD.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 20 May 2003 18:50:42 -0700 Subject: cvsweb.cgi: minor bug report X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2003 06:13:59 -0000 Hi there, just a minor bug to report. I'm running Red Hat Linux 8.0 and my httpd version is 2.0.40-11.3. If within a cvs-directory, I do not have read-permissions on any files (though this directory contains files), $where appears to result in being "empty" (not if tested, but empty anyhow?), which results in following error message: ''Error: Failed to spawn GNU rlog on "/home/cvs/module//Module.pm,v, /home/cvs/module//Makefile.PL,v, /home/cvs/module//README,v, /home/cvs/module//MANIFEST,v". Did you set the $command_path in your configuration file correctly ? (Currently "/bin:/usr/bin:/usr/local/bin"'' I guess it would be better in that case to output something like: "Note: You do not appear to have read-permissions to any files within this directory", after listing any readable sub-directories (if any). If you change line 2111 (temporarily of course) to: my ($DirName) = "$cvsroot";#/$where"; the site is being displayed correctly, without any error-message (files or directories I don't have read-access to are simply not shown). Testing for $where doesn't seem to work though? I'd spend some more time on it, if I would have some at the moment, but I guess I'd need to get much more into this script than I have time for at the moment, unfortunately. Hope you know what the problem could be. Thanks, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Thu May 15 16:55:21 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C6A937B401 for ; Thu, 15 May 2003 16:55:21 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97EFB43FA3 for ; Thu, 15 May 2003 16:55:20 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4FNtKH00956 for ; Thu, 15 May 2003 19:55:20 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4FNtII13106 for ; Thu, 15 May 2003 19:55:18 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4FNtFj02490 for ; Fri, 16 May 2003 09:55:16 +1000 Message-ID: <3EC42AD0.5060801@redhat.com> Date: Fri, 16 May 2003 10:03:28 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@FreeBSD.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 20 May 2003 18:50:42 -0700 Subject: cvsweb.cgi: minor bug report [Correction] X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2003 23:55:21 -0000 Hi there again, I did have another short look. It's not related to the $where (I should have debugged it properly before sending out error reports, I know). That it worked with commenting $where out was simply due to the fact that in the $cvsroot weren't any files that could have had the wrong permissions. The problem must somehow be caused by rlog, being called on a set of files (which I happen to be able to see), where I have no read-permissions to any of the files. If I have read-permissions to only one of the files, it works fine. If I should get some more time another day, I might have another look. Until then, maybe you know how to fix it already? Thanks, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer From owner-freebsd-cvsweb@FreeBSD.ORG Thu May 15 17:32:36 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A98837B40E for ; Thu, 15 May 2003 17:32:36 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD4BF43F85 for ; Thu, 15 May 2003 17:32:34 -0700 (PDT) (envelope-from bgroh@redhat.com) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4G0WYH07289 for ; Thu, 15 May 2003 20:32:34 -0400 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4G0WVI22107 for ; Thu, 15 May 2003 20:32:32 -0400 Received: from redhat.com (bernd.brisbane.redhat.com [172.16.5.91]) h4G0WSj03086 for ; Fri, 16 May 2003 10:32:29 +1000 Message-ID: <3EC43389.2020101@redhat.com> Date: Fri, 16 May 2003 10:40:41 +1000 From: Bernd Groh User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.2.1) Gecko/20030225 X-Accept-Language: de-at, de, en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@freebsd.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 20 May 2003 18:50:42 -0700 Subject: cvsweb.cgi: minor bug report [temporary patch] X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2003 00:32:36 -0000 Hi there again, I know, I know, I didn't plan on doing it right now, but I ended up implementing a temporary fix. I'm sure there's a better way to do it, but I can't think of it right now, and I am too lazy to look it up. *l* Here's the patch: sub getDirLogs($$@) { my ($cvsroot, $dirname, @otherFiles) = @_; my ($state, $otherFiles, $tag, $file, $date, $branchpoint, $branch, $log); my ($rev, $revision, $revwanted, $filename, $head, $author); $tag = $input{only_with_tag}; my ($DirName) = $cvsroot . '/' . $where; my (@files, @filetags); # added new array to store files initially my (@allfiles); my $fh = do { local (*FH); }; push (@allfiles, &safeglob($DirName . '*,v')); push (@allfiles, &safeglob($DirName . 'Attic/*,v')) if (!$input{'hideattic'}); foreach my $file (@otherFiles) { push (@allfiles, $DirName . $file); } # just execute rlog with the files we have read access to # (i'm sure there's an easier way than actually having to # open the file, but I can't think of it at the moment *l*) foreach my $file (@allfiles) { my $readable = 1; open (READABLE, "<$file") or $readable = 0; if ($readable == 1) { close(READABLE); push (@files, $file); } } # just execute rlog if there are any files if ($#files < 0) { return; } # this will now also ensure that rlog is not called on any # files it really shouldn't be # after this point, code remains the same ... Cheers, Bernd -- Disclaimer: http://apac.redhat.com/disclaimer