From owner-freebsd-standards@FreeBSD.ORG Tue Jun 10 09:30:05 2003 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D674B37B401 for ; Tue, 10 Jun 2003 09:30:05 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBBE943FBF for ; Tue, 10 Jun 2003 09:30:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5AGU4Up009511 for ; Tue, 10 Jun 2003 09:30:04 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5AGU4cZ009510; Tue, 10 Jun 2003 09:30:04 -0700 (PDT) Resent-Date: Tue, 10 Jun 2003 09:30:04 -0700 (PDT) Resent-Message-Id: <200306101630.h5AGU4cZ009510@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Max Laier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46ADA37B401 for ; Tue, 10 Jun 2003 09:22:41 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id A547243FAF for ; Tue, 10 Jun 2003 09:22:40 -0700 (PDT) (envelope-from mlaier@vampire.homelinux.org) Received: from [212.227.126.205] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 19PltP-0002Jd-00 for FreeBSD-gnats-submit@freebsd.org; Tue, 10 Jun 2003 18:22:39 +0200 Received: from [217.83.15.168] (helo=vampire.homelinux.org) by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 19PltO-0000jl-00 for FreeBSD-gnats-submit@freebsd.org; Tue, 10 Jun 2003 18:22:39 +0200 Received: (qmail 1189 invoked by uid 1001); 10 Jun 2003 15:22:19 -0000 Message-Id: <20030610152219.1188.qmail@vampire.homelinux.org> Date: 10 Jun 2003 15:22:19 -0000 From: Max Laier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: standards/53151: inet_net_pton() returns 4 for *all* multicast hosts! X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Max Laier List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2003 16:30:06 -0000 >Number: 53151 >Category: standards >Synopsis: inet_net_pton() returns 4 for *all* multicast hosts! >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jun 10 09:30:03 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Max Laier >Release: FreeBSD 5.0-RELEASE-p7 i386 >Organization: >Environment: System: FreeBSD router.laiers.local 5.0-RELEASE-p7 FreeBSD 5.0-RELEASE-p7 #0: Mon Apr 14 13:13:41 CEST 2003 root@router.laiers.local:/usr/src/sys/i386/compile/MAX_SMP i386 >Description: See http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/net/inet_net_pton.c for the original issue and fix. It mentions "negotiated with Paul Vixie, original author of this function." so there might be a fix in the original bind sources by now! >How-To-Repeat: Use inet_net_pton() to get info about a multicast host will return 4. e.g.: inet_net_pton(AF_INET, "224.4.5.4", &dst, sizeof(dst)) should return 32 as all 4 byte are given i.e. we talk about 224.4.5.4/32 not about 224.0.0.0/4! >Fix: Use the attached pacht against "src/contrib/bind/lib/inet/inet_net_pton.c" (or resync with offical bind dist?) --- inet_net_pton.c.patch begins here --- --- inet_net_pton.c.orig Tue Jun 10 17:01:18 2003 +++ inet_net_pton.c Tue Jun 10 17:02:00 2003 @@ -160,7 +160,7 @@ else /* Class A */ bits = 8; /* If imputed mask is narrower than specified octets, widen. */ - if (bits >= 8 && bits < ((dst - odst) * 8)) + if (bits < ((dst - odst) * 8)) bits = (dst - odst) * 8; } /* Extend network to cover the actual mask. */ --- inet_net_pton.c.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-standards@FreeBSD.ORG Wed Jun 11 19:48:33 2003 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5196037B401; Wed, 11 Jun 2003 19:48:33 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E14F943F75; Wed, 11 Jun 2003 19:48:32 -0700 (PDT) (envelope-from mike@FreeBSD.org) Received: from freefall.freebsd.org (mike@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5C2mWUp041297; Wed, 11 Jun 2003 19:48:32 -0700 (PDT) (envelope-from mike@freefall.freebsd.org) Received: (from mike@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5C2mWxw041293; Wed, 11 Jun 2003 19:48:32 -0700 (PDT) Date: Wed, 11 Jun 2003 19:48:32 -0700 (PDT) From: Mike Barcroft Message-Id: <200306120248.h5C2mWxw041293@freefall.freebsd.org> To: mike@FreeBSD.org, freebsd-standards@FreeBSD.org, fenner@FreeBSD.org Subject: Re: standards/53151: inet_net_pton() returns 4 for *all* multicast hosts! X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2003 02:48:33 -0000 Synopsis: inet_net_pton() returns 4 for *all* multicast hosts! Responsible-Changed-From-To: freebsd-standards->fenner Responsible-Changed-By: mike Responsible-Changed-When: Wed Jun 11 19:48:05 PDT 2003 Responsible-Changed-Why: Over to Bill Fenner for review. http://www.freebsd.org/cgi/query-pr.cgi?pr=53151