Date: Sun, 17 Aug 2003 11:32:52 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Pawel Jakub Dawidek <nick@garage.freebsd.pl> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 35655 for review Message-ID: <Pine.NEB.3.96L.1030817112953.8748A-100000@fledge.watson.org> In-Reply-To: <20030816164300.GS395@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 16 Aug 2003, Pawel Jakub Dawidek wrote: > On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote: > +> - mode ~= cmask; > +> + mode = mode &~ cmask; > > IMHO this is a style bug. > > This should be: mode = mode & ~cmask; > > On time, when I was tired, I've spend few minutes wondering why 'foo' > after this operation isn't equal to 'foo - bar':) > > foo =- bar; Heh. :-) Yeah -- all these instances of mode/cmask combination will move into a centralized function in the next pass, similar to the acl_posix1e_newfilemode() function (which will also gain a cmask argument). In the current pass, I'm trying to hit every place where modes and masks will be combined at the file system level. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1030817112953.8748A-100000>