From owner-cvs-src@FreeBSD.ORG Sun Oct 31 01:28:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D03016A4CE; Sun, 31 Oct 2004 01:28:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7923F43D3F; Sun, 31 Oct 2004 01:28:59 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V1SxaT098357; Sun, 31 Oct 2004 01:28:59 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9V1Sxg6098356; Sun, 31 Oct 2004 01:28:59 GMT (envelope-from marcel) Message-Id: <200410310128.i9V1Sxg6098356@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 31 Oct 2004 01:28:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libdisk chunk.c open_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 01:28:59 -0000 marcel 2004-10-31 01:28:59 UTC FreeBSD src repository Modified files: lib/libdisk chunk.c open_disk.c Log: Don't barf when we encounter an UUID for GPT partitions. Instead, add the GPT partition on i386 and adm64 as type=gpt, subtype=0 and with the sname set to the UUID. This prevents sysinstall from bombing out. This also makes sure the GPT partition shows up in sysinstall so as to avoid accidental "clobberage". PR: bin/72896 Revision Changes Path 1.52 +1 -0 src/lib/libdisk/chunk.c 1.9 +2 -2 src/lib/libdisk/open_disk.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 02:20:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ABC0D16A4CE; Sun, 31 Oct 2004 02:20:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88ECE43D2D; Sun, 31 Oct 2004 02:20:18 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V2KIpG099884; Sun, 31 Oct 2004 02:20:18 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9V2KIqG099883; Sun, 31 Oct 2004 02:20:18 GMT (envelope-from marcel) Message-Id: <200410310220.i9V2KIqG099883@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 31 Oct 2004 02:20:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/gpt gpt.8 migrate.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 02:20:18 -0000 marcel 2004-10-31 02:20:17 UTC FreeBSD src repository Modified files: sbin/gpt gpt.8 migrate.c Log: Remove the -k option to migrate. The option causes gpt(8) to preserve the MBR after it is migrated to a GPT. While this was useful during the early days when GPT support was under development, it's something that users can use without knowing what they're getting themselves into. The possible harm outweights the marginal usefulness it now has. Revision Changes Path 1.7 +1 -10 src/sbin/gpt/gpt.8 1.11 +24 -29 src/sbin/gpt/migrate.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 03:50:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4724F16A4D0 for ; Sun, 31 Oct 2004 03:50:37 +0000 (GMT) Received: from web21422.mail.yahoo.com (web21422.mail.yahoo.com [216.136.232.40]) by mx1.FreeBSD.org (Postfix) with SMTP id 11BFD43D4C for ; Sun, 31 Oct 2004 03:50:37 +0000 (GMT) (envelope-from mjacob44@yahoo.com) Message-ID: <20041031035037.59607.qmail@web21422.mail.yahoo.com> Received: from [192.67.166.1] by web21422.mail.yahoo.com via HTTP; Sat, 30 Oct 2004 20:50:36 PDT Date: Sat, 30 Oct 2004 20:50:36 -0700 (PDT) From: Matthew Jacob To: "Justin T. Gibbs" , Bruce M Simpson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 03:50:37 -0000 Shouldn't an API for adding or removing ISR's be responsible for handling just such a race condition? __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail From owner-cvs-src@FreeBSD.ORG Sun Oct 31 04:21:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D50016A4CF; Sun, 31 Oct 2004 04:21:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E54143D54; Sun, 31 Oct 2004 04:21:44 +0000 (GMT) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V4LiWP004262; Sun, 31 Oct 2004 04:21:44 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9V4Li9A004261; Sun, 31 Oct 2004 04:21:44 GMT (envelope-from julian) Message-Id: <200410310421.i9V4Li9A004261@repoman.freebsd.org> From: Julian Elischer Date: Sun, 31 Oct 2004 04:21:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/lib/libpthread/thread thr_create.cthr_find_thread.c thr_kern.c thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:21:45 -0000 julian 2004-10-31 04:21:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libpthread/thread thr_create.c thr_find_thread.c thr_kern.c thr_private.h thr_sig.c Log: MFC: Revision Changes Path 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c fix race conditions Approved by: re (scottl) Revision Changes Path 1.57.2.1 +1 -0 src/lib/libpthread/thread/thr_create.c 1.13.4.1 +1 -1 src/lib/libpthread/thread/thr_find_thread.c 1.112.2.1 +27 -10 src/lib/libpthread/thread/thr_kern.c 1.118.2.1 +15 -11 src/lib/libpthread/thread/thr_private.h 1.79.2.1 +1 -2 src/lib/libpthread/thread/thr_sig.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 04:34:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B25CD16A4CF; Sun, 31 Oct 2004 04:34:45 +0000 (GMT) Received: from aslan.scsiguy.com (mail.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E08C43D31; Sun, 31 Oct 2004 04:34:45 +0000 (GMT) (envelope-from gibbs@scsiguy.com) Received: from caspian.scsiguy.com (caspian.scsiguy.com [63.229.232.105]) by aslan.scsiguy.com (8.12.11/8.12.11) with ESMTP id i9V4Yhjk044263; Sat, 30 Oct 2004 22:34:43 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Date: Sat, 30 Oct 2004 22:35:58 -0700 From: "Justin T. Gibbs" To: Matthew Jacob , Bruce M Simpson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: In-Reply-To: <20041031035037.59607.qmail@web21422.mail.yahoo.com> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:34:45 -0000 > Shouldn't an API for adding or removing ISR's be responsible for > handling just such a race condition? bus_teardown_intr() already has these semantics, but you have to know to use it and that it should only be called without locks held since it may sleep waiting for another CPU to leave your interrupt handler. The code that was added to this driver shouldn't be necessary if the ISR is properly deregistered during suspend, detach, etc. -- Justin From owner-cvs-src@FreeBSD.ORG Sun Oct 31 04:40:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D4CD16A4CF; Sun, 31 Oct 2004 04:40:38 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8829043D1D; Sun, 31 Oct 2004 04:40:37 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 9DC21653F8; Sun, 31 Oct 2004 04:40:35 +0000 (GMT) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 37708-04; Sun, 31 Oct 2004 04:40:35 +0000 (GMT) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id B791B653DF; Sun, 31 Oct 2004 04:40:34 +0000 (GMT) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id AE57A6247; Sat, 30 Oct 2004 21:40:21 -0700 (PDT) Date: Sat, 30 Oct 2004 21:40:21 -0700 From: Bruce M Simpson To: "Justin T. Gibbs" Message-ID: <20041031044021.GA2123@empiric.icir.org> Mail-Followup-To: "Justin T. Gibbs" , Matthew Jacob , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: cc: Matthew Jacob cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:40:38 -0000 On Sat, Oct 30, 2004 at 10:35:58PM -0700, Justin T. Gibbs wrote: > > Shouldn't an API for adding or removing ISR's be responsible for > > handling just such a race condition? > > bus_teardown_intr() already has these semantics, but you have > to know to use it and that it should only be called without > locks held since it may sleep waiting for another CPU to > leave your interrupt handler. Unfortunately I don't have a vr(4) card to test the changes with, and it looks like the copy of if_vr.c in my local tree uses bus_teardown_intr() correctly; these changes will have to be tested and committed after 5.3R. BMS From owner-cvs-src@FreeBSD.ORG Sun Oct 31 04:43:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C37516A4CF; Sun, 31 Oct 2004 04:43:24 +0000 (GMT) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8816743D41; Sun, 31 Oct 2004 04:43:23 +0000 (GMT) (envelope-from gibbs@scsiguy.com) Received: from caspian.scsiguy.com (caspian.scsiguy.com [63.229.232.105]) by aslan.scsiguy.com (8.12.11/8.12.11) with ESMTP id i9V4hMYo044316; Sat, 30 Oct 2004 22:43:22 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Date: Sat, 30 Oct 2004 22:44:36 -0700 From: "Justin T. Gibbs" To: Bruce M Simpson Message-ID: In-Reply-To: <20041031044021.GA2123@empiric.icir.org> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> <20041031044021.GA2123@empiric.icir.org> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline cc: Matthew Jacob cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:43:24 -0000 > On Sat, Oct 30, 2004 at 10:35:58PM -0700, Justin T. Gibbs wrote: >> > Shouldn't an API for adding or removing ISR's be responsible for >> > handling just such a race condition? >> >> bus_teardown_intr() already has these semantics, but you have >> to know to use it and that it should only be called without >> locks held since it may sleep waiting for another CPU to >> leave your interrupt handler. > > Unfortunately I don't have a vr(4) card to test the changes with, and > it looks like the copy of if_vr.c in my local tree uses bus_teardown_intr() > correctly; these changes will have to be tested and committed after 5.3R. > > BMS You should be able to get rid of the suspended check in the isr too. -- Justin From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:03:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B86FE16A4CE; Sun, 31 Oct 2004 05:03:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9753B43D4C; Sun, 31 Oct 2004 05:03:50 +0000 (GMT) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V53oE6011897; Sun, 31 Oct 2004 05:03:50 GMT (envelope-from green@repoman.freebsd.org) Received: (from green@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9V53ofj011896; Sun, 31 Oct 2004 05:03:50 GMT (envelope-from green) Message-Id: <200410310503.i9V53ofj011896@repoman.freebsd.org> From: Brian Feldman Date: Sun, 31 Oct 2004 05:03:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:03:50 -0000 green 2004-10-31 05:03:50 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_mutex.c Log: Make pthread_mutex_trylock(3) return EBUSY on failure, as all software packages expect and seems to be most correct according to the slightly- ambiguous standards. MFC after: 1 month Corroborated by: POSIX Reviewed by: silence on threads@ Revision Changes Path 1.46 +1 -8 src/lib/libpthread/thread/thr_mutex.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:06:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id E216716A4CE; Sun, 31 Oct 2004 05:06:22 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9V56M9K095788; Sun, 31 Oct 2004 01:06:22 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9V56Lfa095787; Sun, 31 Oct 2004 01:06:21 -0400 (EDT) (envelope-from green) Date: Sun, 31 Oct 2004 01:06:20 -0400 From: Brian Fundakowski Feldman To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041031050620.GQ93831@green.homeunix.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410310503.i9V53ofj011896@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:06:23 -0000 On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > green 2004-10-31 05:03:50 UTC > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_mutex.c > Log: > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > packages expect and seems to be most correct according to the slightly- > ambiguous standards. > > MFC after: 1 month > Corroborated by: POSIX > Reviewed by: silence on threads@ Software such as mozilla projects (using NSPR) and Java have been broken in various ways by this. We need to try to be more compatible with the most popular interpretation of the standards (instead of just inventing our own) -- usually we're pretty good about this. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:28:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2120C16A4CE; Sun, 31 Oct 2004 05:28:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED0A343D46; Sun, 31 Oct 2004 05:28:15 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V5SFBb012787; Sun, 31 Oct 2004 05:28:15 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9V5SF7O012786; Sun, 31 Oct 2004 05:28:15 GMT (envelope-from dd) Message-Id: <200410310528.i9V5SF7O012786@repoman.freebsd.org> From: Dima Dorfman Date: Sun, 31 Oct 2004 05:28:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ccdconfig ccdconfig.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:28:16 -0000 dd 2004-10-31 05:28:15 UTC FreeBSD src repository Modified files: sbin/ccdconfig ccdconfig.8 Log: Replace link to nonexistent raid(4) with one to geom(8). I don't like implying that geom(8) is a RAID solution, but it can be used for that purpose, and a pointer in that direction is better than nothing. PR: 73088 Submitted by: Miguel Mendez Revision Changes Path 1.30 +1 -2 src/sbin/ccdconfig/ccdconfig.8 From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:38:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3EE316A4CE; Sun, 31 Oct 2004 05:38:49 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5EC143D41; Sun, 31 Oct 2004 05:38:49 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) i9V5clkO050914; Sun, 31 Oct 2004 05:38:48 GMT (envelope-from davidxu@freebsd.org) Message-ID: <41847A66.6050306@freebsd.org> Date: Sun, 31 Oct 2004 13:38:46 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Julian Elischer References: <200410310421.i9V4Li9A004261@repoman.freebsd.org> In-Reply-To: <200410310421.i9V4Li9A004261@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_create.cthr_find_thread.c thr_kern.c thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:38:49 -0000 Thank you! David Xu Julian Elischer wrote: >julian 2004-10-31 04:21:43 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > lib/libpthread/thread thr_create.c thr_find_thread.c > thr_kern.c thr_private.h thr_sig.c > Log: > MFC: > Revision Changes Path > 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c > 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c > 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c > 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h > 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c > > fix race conditions > > Approved by: re (scottl) > > > From owner-cvs-src@FreeBSD.ORG Sun Oct 31 05:56:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E618616A4CE; Sun, 31 Oct 2004 05:56:30 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C551B43D31; Sun, 31 Oct 2004 05:56:30 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id BDE515D17C; Sat, 30 Oct 2004 22:56:30 -0700 (PDT) Date: Sat, 30 Oct 2004 22:56:30 -0700 From: Alfred Perlstein To: Brian Fundakowski Feldman Message-ID: <20041031055630.GE24892@elvis.mu.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> <20041031050620.GQ93831@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041031050620.GQ93831@green.homeunix.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 05:56:31 -0000 * Brian Fundakowski Feldman [041030 22:06] wrote: > On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > > green 2004-10-31 05:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libpthread/thread thr_mutex.c > > Log: > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > packages expect and seems to be most correct according to the slightly- > > ambiguous standards. > > > > MFC after: 1 month > > Corroborated by: POSIX > > Reviewed by: silence on threads@ > > Software such as mozilla projects (using NSPR) and Java have been > broken in various ways by this. We need to try to be more compatible > with the most popular interpretation of the standards (instead of just > inventing our own) -- usually we're pretty good about this. Good catch... it could have just been an oversight though. :) We need a "configure" like regression suite for pthreads[*]. [*] and a ton of other stuff. :) -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Sun Oct 31 06:13:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 606E916A4CE; Sun, 31 Oct 2004 06:13:25 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9V6DOgO096132; Sun, 31 Oct 2004 01:13:24 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9V6DOlJ096131; Sun, 31 Oct 2004 01:13:24 -0500 (EST) (envelope-from green) Date: Sun, 31 Oct 2004 01:13:24 -0500 From: Brian Fundakowski Feldman To: Alfred Perlstein Message-ID: <20041031061324.GR93831@green.homeunix.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> <20041031050620.GQ93831@green.homeunix.org> <20041031055630.GE24892@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041031055630.GE24892@elvis.mu.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 06:13:25 -0000 On Sat, Oct 30, 2004 at 10:56:30PM -0700, Alfred Perlstein wrote: > * Brian Fundakowski Feldman [041030 22:06] wrote: > > On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > > > green 2004-10-31 05:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libpthread/thread thr_mutex.c > > > Log: > > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > > packages expect and seems to be most correct according to the slightly- > > > ambiguous standards. > > > > > > MFC after: 1 month > > > Corroborated by: POSIX > > > Reviewed by: silence on threads@ > > > > Software such as mozilla projects (using NSPR) and Java have been > > broken in various ways by this. We need to try to be more compatible > > with the most popular interpretation of the standards (instead of just > > inventing our own) -- usually we're pretty good about this. > > Good catch... it could have just been an oversight though. :) > > We need a "configure" like regression suite for pthreads[*]. > > [*] and a ton of other stuff. :) Actually, I think POSIX has a whole bunch of regression tests! I wonder if anyone could ever convince them to make them free for BSD operating systems... http://www.opengroup.org/testing/testsuites/vsthover.htm -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Sun Oct 31 07:41:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FF5116A4CE; Sun, 31 Oct 2004 07:41:41 +0000 (GMT) Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net [207.115.63.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB64843D41; Sun, 31 Oct 2004 07:41:40 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [192.168.1.102] (adsl-68-123-122-146.dsl.snfc21.pacbell.net [68.123.122.146])i9V7fcpq209248; Sun, 31 Oct 2004 02:41:39 -0500 Message-ID: <41849731.1020404@elischer.org> Date: Sun, 31 Oct 2004 00:41:37 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017 X-Accept-Language: en, hu MIME-Version: 1.0 To: Jeff Roberson References: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> In-Reply-To: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 07:41:41 -0000 Jeff Roberson wrote: > jeff 2004-10-30 07:35:53 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - In sched_prio() check to see if the kse is assigned to a runq as the > check for TD_ON_RUNQ() no longer means the thread is really on a run- > queue. I suspect this state should be re-evaluated as it must mean > something else now. This fixes ULE+KSE+PREEMPTION on UP x86. It never did mean that it was on a system run queue.. It meant that it was on the KSEGROUP's run queue. For whether the kse associated with the thread is in a system run queue you need to ask the KSE. > > Revision Changes Path > 1.135 +1 -1 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 07:46:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4163216A4CE; Sun, 31 Oct 2004 07:46:53 +0000 (GMT) Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net [207.115.63.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBE1143D1D; Sun, 31 Oct 2004 07:46:52 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [192.168.1.102] (adsl-68-123-122-146.dsl.snfc21.pacbell.net [68.123.122.146])i9V7knpq323836; Sun, 31 Oct 2004 02:46:49 -0500 Message-ID: <41849868.3080003@elischer.org> Date: Sun, 31 Oct 2004 00:46:48 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017 X-Accept-Language: en, hu MIME-Version: 1.0 To: Julian Elischer References: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> <41849731.1020404@elischer.org> In-Reply-To: <41849731.1020404@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: Jeff Roberson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 07:46:53 -0000 Julian Elischer wrote: > Jeff Roberson wrote: > >> jeff 2004-10-30 07:35:53 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern sched_ule.c Log: >> - In sched_prio() check to see if the kse is assigned to a runq as the >> check for TD_ON_RUNQ() no longer means the thread is really on a >> run- >> queue. I suspect this state should be re-evaluated as it must mean >> something else now. This fixes ULE+KSE+PREEMPTION on UP x86. > > > It never did mean that it was on a system run queue.. > It meant that it was on the KSEGROUP's run queue. > For whether the kse associated with the thread is in a system run queue you > need to ask the KSE. To add more to this: you need to check the KSE state to see if it is set to KES_ONRUNQ A thread can be runnable from the processes point of view but not available to the system to schedule because that process already has too many threads runnable or running. Once the thread is made availabel to the system to run and sis put on the system run queues, it's KSE's sate will be set to KES_ONRUNQ. > >> Revision Changes Path >> 1.135 +1 -1 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 08:12:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4710B16A52B; Sun, 31 Oct 2004 08:12:21 +0000 (GMT) Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net [207.115.63.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF2DA43D5C; Sun, 31 Oct 2004 08:12:20 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [192.168.1.102] (adsl-68-123-122-146.dsl.snfc21.pacbell.net [68.123.122.146])i9V8CIpq096460; Sun, 31 Oct 2004 03:12:19 -0500 Message-ID: <41849E61.3010000@elischer.org> Date: Sun, 31 Oct 2004 01:12:17 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8a3) Gecko/20041017 X-Accept-Language: en, hu MIME-Version: 1.0 To: David Xu References: <200410310421.i9V4Li9A004261@repoman.freebsd.org> <41847A66.6050306@freebsd.org> In-Reply-To: <41847A66.6050306@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Julian Elischer cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_create.cthr_find_thread.c thr_kern.c thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 08:12:21 -0000 David Xu wrote: > Thank you! > > David Xu > > Julian Elischer wrote: > >> julian 2004-10-31 04:21:43 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_5) >> lib/libpthread/thread thr_create.c thr_find_thread.c >> thr_kern.c thr_private.h thr_sig.c Log: >> MFC: >> Revision Changes Path >> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c >> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c >> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c >> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h >> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c >> >> fix race conditions >> >> Approved by: re (scottl) >> >> >> still not in 5.3 From owner-cvs-src@FreeBSD.ORG Sun Oct 31 09:25:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from [IPv6:::1] (hub.freebsd.org [216.136.204.18]) by hub.freebsd.org (Postfix) with ESMTP id 0DE2016A4CE; Sun, 31 Oct 2004 09:25:33 +0000 (GMT) Message-ID: <4184BD2D.9030209@freebsd.org> Date: Sun, 31 Oct 2004 03:23:41 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brian Fundakowski Feldman References: <200410310503.i9V53ofj011896@repoman.freebsd.org> <20041031050620.GQ93831@green.homeunix.org> In-Reply-To: <20041031050620.GQ93831@green.homeunix.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 09:25:34 -0000 Brian Fundakowski Feldman wrote: > On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > >>green 2004-10-31 05:03:50 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libpthread/thread thr_mutex.c >> Log: >> Make pthread_mutex_trylock(3) return EBUSY on failure, as all software >> packages expect and seems to be most correct according to the slightly- >> ambiguous standards. >> >> MFC after: 1 month >> Corroborated by: POSIX >> Reviewed by: silence on threads@ > > > Software such as mozilla projects (using NSPR) and Java have been > broken in various ways by this. We need to try to be more compatible > with the most popular interpretation of the standards (instead of just > inventing our own) -- usually we're pretty good about this. > Please define 'broken'? There are many test suites available for pthreads. How does this affect those test suites, and have you _directly_ talked with those who run the tests suites? Scott From owner-cvs-src@FreeBSD.ORG Sun Oct 31 11:13:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13A9D16A4CE; Sun, 31 Oct 2004 11:13:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E751643D2F; Sun, 31 Oct 2004 11:12:59 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VBCxi5029386; Sun, 31 Oct 2004 11:12:59 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VBCxdC029385; Sun, 31 Oct 2004 11:12:59 GMT (envelope-from pjd) Message-Id: <200410311112.i9VBCxdC029385@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sun, 31 Oct 2004 11:12:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern imgact_shell.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 11:13:00 -0000 pjd 2004-10-31 11:12:59 UTC FreeBSD src repository Modified files: sys/kern imgact_shell.c Log: Don't treat # as a comment in interpreter specification line. This is magic and no other operating system do so (i.e. Solaris, Tru64, Linux, AIX, HP-UX, Irix, MacOS X, NetBSD). Discussed on: current@ Reported by: Sławek Żak Revision Changes Path 1.27 +1 -1 src/sys/kern/imgact_shell.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 11:19:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E261116A4CE; Sun, 31 Oct 2004 11:19:46 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 850B943D1F; Sun, 31 Oct 2004 11:19:46 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) i9VBJjDu008631; Sun, 31 Oct 2004 06:19:45 -0500 (EST) Date: Sun, 31 Oct 2004 06:19:45 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Feldman In-Reply-To: <200410310503.i9V53ofj011896@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 11:19:47 -0000 On Sun, 31 Oct 2004, Brian Feldman wrote: > green 2004-10-31 05:03:50 UTC > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_mutex.c > Log: > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > packages expect and seems to be most correct according to the slightly- > ambiguous standards. > > MFC after: 1 month > Corroborated by: POSIX > Reviewed by: silence on threads@ I never saw this, and there has been a couple of long threads about it. The current behavior was deemed correct especially since default mutexes are error check mutexes. The rationale is that it provides a way for a thread to tell if it owns the mutex if EDEADLK is returned. Please back out and sorry for not seeing a posting on -threads. -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Sun Oct 31 15:02:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 49A1716A4CE; Sun, 31 Oct 2004 15:02:07 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9VF253Q004634; Sun, 31 Oct 2004 10:02:05 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9VF25ZG004633; Sun, 31 Oct 2004 10:02:05 -0500 (EST) (envelope-from green) Date: Sun, 31 Oct 2004 10:02:04 -0500 From: Brian Fundakowski Feldman To: Daniel Eischen Message-ID: <20041031150204.GS93831@green.homeunix.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 15:02:07 -0000 On Sun, Oct 31, 2004 at 06:19:45AM -0500, Daniel Eischen wrote: > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > green 2004-10-31 05:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libpthread/thread thr_mutex.c > > Log: > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > packages expect and seems to be most correct according to the slightly- > > ambiguous standards. > > > > MFC after: 1 month > > Corroborated by: POSIX > > Reviewed by: silence on threads@ > > I never saw this, and there has been a couple of long threads about > it. The current behavior was deemed correct especially since default > mutexes are error check mutexes. The rationale is that it provides a way > for a thread to tell if it owns the mutex if EDEADLK is returned. > > Please back out and sorry for not seeing a posting on -threads. What is your rationale for choosing a very, very loose interpretation that deliberately acts entirely differently from essentially every other implementation, and is proven to be repeated cause for breakage in software because of the gratuitous differences. I am not even going to bother going into our choice of PTHREAD_MUTEX_DEFAULT as a _#define_ for PTHREAD_MUTEX_ERRORCHECK. Just read the standard and point out, after reading the entire thing, then re-reading the ERRORS section again and again, where it says pthread_mutex_trylock(3) can return EDEADLK. Notice how every one of those four functions is explicitly broken out into which error returns it supports. After further review, I can't possibly see how the behavior you chose to use is allowed by a reasonable interpretation of the standard. Have you consulted any standards@ people? Where did you get this interpretation? If you want to back this out and make dead certain to error on the side of incompatibility, go ahead and do it yourself. You're not the one that has spent the hours finding this problem in existing pthreads applications, and you're probably not going to find and fix all the rest of the cases of incompatibility this choice makes. It really doesn't effect you at all, does it? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Sun Oct 31 15:02:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9C8016A4CE; Sun, 31 Oct 2004 15:02:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8685A43D2D; Sun, 31 Oct 2004 15:02:53 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VF2rLC043219; Sun, 31 Oct 2004 15:02:53 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VF2r97043218; Sun, 31 Oct 2004 15:02:53 GMT (envelope-from des) Message-Id: <200410311502.i9VF2r97043218@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 31 Oct 2004 15:02:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c src/sys/sys kernel.h systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 15:02:53 -0000 des 2004-10-31 15:02:53 UTC FreeBSD src repository Modified files: sys/amd64/pci pci_bus.c sys/dev/acpica acpi_pcib_acpi.c sys/i386/pci pci_bus.c sys/sys kernel.h systm.h Log: Whitespace cleanup Revision Changes Path 1.111 +5 -5 src/sys/amd64/pci/pci_bus.c 1.43 +4 -4 src/sys/dev/acpica/acpi_pcib_acpi.c 1.116 +8 -8 src/sys/i386/pci/pci_bus.c 1.119 +1 -1 src/sys/sys/kernel.h 1.218 +5 -5 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Sun Oct 31 15:40:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2CBA416A4CE; Sun, 31 Oct 2004 15:40:48 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9VFelDV004867; Sun, 31 Oct 2004 10:40:47 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9VFelAf004866; Sun, 31 Oct 2004 10:40:47 -0500 (EST) (envelope-from green) Date: Sun, 31 Oct 2004 10:40:46 -0500 From: Brian Fundakowski Feldman To: Scott Long Message-ID: <20041031154046.GU93831@green.homeunix.org> References: <200410310503.i9V53ofj011896@repoman.freebsd.org> <20041031050620.GQ93831@green.homeunix.org> <4184BD2D.9030209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4184BD2D.9030209@freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 15:40:48 -0000 On Sun, Oct 31, 2004 at 03:23:41AM -0700, Scott Long wrote: > Brian Fundakowski Feldman wrote: > >On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > > > >>green 2004-10-31 05:03:50 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libpthread/thread thr_mutex.c > >> Log: > >> Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > >> packages expect and seems to be most correct according to the slightly- > >> ambiguous standards. > >> > >> MFC after: 1 month > >> Corroborated by: POSIX > >> Reviewed by: silence on threads@ > > > > > >Software such as mozilla projects (using NSPR) and Java have been > >broken in various ways by this. We need to try to be more compatible > >with the most popular interpretation of the standards (instead of just > >inventing our own) -- usually we're pretty good about this. > > > > Please define 'broken'? There are many test suites available for > pthreads. How does this affect those test suites, and have you > _directly_ talked with those who run the tests suites? It causes them to _FAIL_. Try to build a mozilla port without the FreeBSD-specific pthread_mutex_trylock(3) workaround, with debugging turned on, and without the removal of EDEADLK from the function. We break the assertions that software developers use when writing to the pthreads API, and then when we "port" applications written to standard POSIX threads implementations in Solaris, Linux, etc., we have to modify them to catch this. Have you tried any of the test suites? The POSIX-provided-for-free one does not have coverage of error return values from what I can see, and the Linux pthreads ones also don't test this because as far as they are concerned, it's a code invariant, and the implementation which they control is not going to start returning EDEADLK one day. The FreeBSD one has similar issues (lack of coverage ones) but additionally is exceedingly moldy and if it were actually a "regression" test we'd fail it because half of them do not produce expected results. What other ones do you want me to try? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Sun Oct 31 15:50:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A36A816A4CF; Sun, 31 Oct 2004 15:50:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B07043D48; Sun, 31 Oct 2004 15:50:33 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VFoXRp044962; Sun, 31 Oct 2004 15:50:33 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VFoXWf044961; Sun, 31 Oct 2004 15:50:33 GMT (envelope-from des) Message-Id: <200410311550.i9VFoXWf044961@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 31 Oct 2004 15:50:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/pci pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c src/sys/kern kern_environment.c src/sys/sys kernel.h systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 15:50:34 -0000 des 2004-10-31 15:50:33 UTC FreeBSD src repository Modified files: sys/amd64/pci pci_bus.c sys/dev/acpica acpi_pcib_acpi.c sys/i386/pci pci_bus.c sys/kern kern_environment.c sys/sys kernel.h systm.h Log: Add TUNABLE_LONG and TUNABLE_ULONG, and use the latter for the hw.pci.host_mem_start tunable. Add comments to TUNABLE_INT and TUNABLE_QUAD recommending against their use. MFC after: 3 weeks Revision Changes Path 1.112 +3 -4 src/sys/amd64/pci/pci_bus.c 1.44 +2 -2 src/sys/dev/acpica/acpi_pcib_acpi.c 1.117 +3 -4 src/sys/i386/pci/pci_bus.c 1.35 +46 -0 src/sys/kern/kern_environment.c 1.120 +54 -0 src/sys/sys/kernel.h 1.219 +2 -0 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Sun Oct 31 17:32:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA7A216A4CE; Sun, 31 Oct 2004 17:32:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA39343D2F; Sun, 31 Oct 2004 17:32:51 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VHWpmw054428; Sun, 31 Oct 2004 17:32:51 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VHWpE5054427; Sun, 31 Oct 2004 17:32:51 GMT (envelope-from glebius) Message-Id: <200410311732.i9VHWpE5054427@repoman.freebsd.org> From: Gleb Smirnoff Date: Sun, 31 Oct 2004 17:32:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_device.c ng_pppoe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 17:32:52 -0000 glebius 2004-10-31 17:32:51 UTC FreeBSD src repository Modified files: sys/netgraph ng_device.c ng_pppoe.c Log: Since last change moved ';' from macro to code, we need to embrace macros with 'do {} while (0)' to avoid error in case macro is not defined. Prodded by: julian, archie Pointy hat to: glebius Revision Changes Path 1.14 +2 -2 src/sys/netgraph/ng_device.c 1.69 +2 -2 src/sys/netgraph/ng_pppoe.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 17:39:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9660516A4CE; Sun, 31 Oct 2004 17:39:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74CC143D31; Sun, 31 Oct 2004 17:39:46 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VHdkaT054649; Sun, 31 Oct 2004 17:39:46 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VHdkTf054648; Sun, 31 Oct 2004 17:39:46 GMT (envelope-from glebius) Message-Id: <200410311739.i9VHdkTf054648@repoman.freebsd.org> From: Gleb Smirnoff Date: Sun, 31 Oct 2004 17:39:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_tap.c if_tun.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 17:39:46 -0000 glebius 2004-10-31 17:39:46 UTC FreeBSD src repository Modified files: sys/net if_tap.c if_tun.c Log: Utilize m_uiotombuf() in device write method, instead of home-grown implementation. This also gives a performance improvement, because m_uiotombuf() utilizes clusters. Approved by: julian (mentor) MFC after: 1 month Revision Changes Path 1.48 +5 -31 src/sys/net/if_tap.c 1.146 +12 -38 src/sys/net/if_tun.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 17:41:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E902516A4CE; Sun, 31 Oct 2004 17:41:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB96743D48; Sun, 31 Oct 2004 17:41:31 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VHfVI7054775; Sun, 31 Oct 2004 17:41:31 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VHfVbW054774; Sun, 31 Oct 2004 17:41:31 GMT (envelope-from hrs) Message-Id: <200410311741.i9VHfVbW054774@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 31 Oct 2004 17:41:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 17:41:32 -0000 hrs 2004-10-31 17:41:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: - Fix a lot of typos and grammatical errors[1]. - Update the following items: * remove "s/tag=RELENG_5/tag=RELENG_5_3/ in cvsup/standard-cvsup" and "sk(4) panic on shutdown" because they are already fixed. * update "sk(4) locking up"[2] and "gvinum at boot time"[3]. - Add new items: ULE scheduler disabled[4], libpthread CPU usage statistics[5], and ataraid support for CMD649 and SiI0680 controllers[6]. Reported by: Pawel Worach (pawel.worach at telia.com)[1], Adrian Wontroba (aw1 at stade.co.uk)[1], Joel Dahl (joel at automatvapen.se)[1], Bjoern A. Zeeb (bzeeb-lists at lists.zabbadoz.net)[2], le[3], Ryan Sommers (ryans at gamersimpact.com)[4], Dan Nelson (dnelson at allantgroup.com)[5], and Emanuel Strobl (Emanuel.Strobl at gmx.net)[6] Approved by: re (implicitly) Revision Changes Path 1.69.2.4 +33 -53 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Sun Oct 31 18:35:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8ED1F16A4CE; Sun, 31 Oct 2004 18:35:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B61643D39; Sun, 31 Oct 2004 18:35:58 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VIZwNo056573; Sun, 31 Oct 2004 18:35:58 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VIZwCn056572; Sun, 31 Oct 2004 18:35:58 GMT (envelope-from hrs) Message-Id: <200410311835.i9VIZwCn056572@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 31 Oct 2004 18:35:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/ja_JP.eucJP/hardware/amd64 proc-amd64.sgml src/release/doc/ja_JP.eucJP/hardware/sparc64 proc-sparc64.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 18:35:58 -0000 hrs 2004-10-31 18:35:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/ja_JP.eucJP/hardware/amd64 proc-amd64.sgml release/doc/ja_JP.eucJP/hardware/sparc64 proc-sparc64.sgml Log: Fix missing parts in the previous commit. Submitted by: rushani Approved by: re (implicitly) Revision Changes Path 1.3.2.2 +1 -1 src/release/doc/ja_JP.eucJP/hardware/amd64/proc-amd64.sgml 1.4.6.2 +0 -3 src/release/doc/ja_JP.eucJP/hardware/sparc64/proc-sparc64.sgml From owner-cvs-src@FreeBSD.ORG Sun Oct 31 19:32:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E95BD16A4CE; Sun, 31 Oct 2004 19:32:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA05D43D49; Sun, 31 Oct 2004 19:32:59 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9VJWvTS058194; Sun, 31 Oct 2004 19:32:57 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9VJWvmo058193; Sun, 31 Oct 2004 19:32:57 GMT (envelope-from alc) Message-Id: <200410311932.i9VJWvmo058193@repoman.freebsd.org> From: Alan Cox Date: Sun, 31 Oct 2004 19:32:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 19:33:00 -0000 alc 2004-10-31 19:32:57 UTC FreeBSD src repository Modified files: sys/vm vm_zeroidle.c Log: Introduce a Boolean variable wakeup_needed to avoid repeated, unnecessary calls to wakeup() by vm_page_zero_idle_wakeup(). Revision Changes Path 1.31 +9 -2 src/sys/vm/vm_zeroidle.c From owner-cvs-src@FreeBSD.ORG Sun Oct 31 21:20:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2CEC16A4CE; Sun, 31 Oct 2004 21:20:46 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F49B43D2D; Sun, 31 Oct 2004 21:20:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id i9VLJ0EI028452; Sun, 31 Oct 2004 14:19:00 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 31 Oct 2004 14:19:00 -0700 (MST) Message-Id: <20041031.141900.36023096.imp@bsdimp.com> To: mjacob44@yahoo.com From: "M. Warner Losh" In-Reply-To: <20041031035037.59607.qmail@web21422.mail.yahoo.com> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: gibbs@scsiguy.com cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: bms@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 21:20:47 -0000 In message: <20041031035037.59607.qmail@web21422.mail.yahoo.com> Matthew Jacob writes: : Shouldn't an API for adding or removing ISR's be responsible for : handling just such a race condition? It does. After you've deregistered your interrupt, you are guaranteed that (a) it will never be called again and (b) no one is currently in that ISR. However, if you just turn off the interrupts in the hardware device, neither (a) nor (b) apply. Warner From owner-cvs-src@FreeBSD.ORG Sun Oct 31 22:00:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A65B16A4CE; Sun, 31 Oct 2004 22:00:48 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FAA843D3F; Sun, 31 Oct 2004 22:00:47 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) i9VM0kgq003678; Sun, 31 Oct 2004 17:00:46 -0500 (EST) Date: Sun, 31 Oct 2004 17:00:46 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Fundakowski Feldman In-Reply-To: <20041031150204.GS93831@green.homeunix.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 22:00:48 -0000 On Sun, 31 Oct 2004, Brian Fundakowski Feldman wrote: > On Sun, Oct 31, 2004 at 06:19:45AM -0500, Daniel Eischen wrote: > > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > > > green 2004-10-31 05:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libpthread/thread thr_mutex.c > > > Log: > > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > > packages expect and seems to be most correct according to the slightly- > > > ambiguous standards. > > > > > > MFC after: 1 month > > > Corroborated by: POSIX > > > Reviewed by: silence on threads@ > > > > I never saw this, and there has been a couple of long threads about > > it. The current behavior was deemed correct especially since default > > mutexes are error check mutexes. The rationale is that it provides a way > > for a thread to tell if it owns the mutex if EDEADLK is returned. > > > > Please back out and sorry for not seeing a posting on -threads. > > What is your rationale for choosing a very, very loose interpretation > that deliberately acts entirely differently from essentially every other > implementation, and is proven to be repeated cause for breakage in > software because of the gratuitous differences. We use error check mutexes by default, which is allowed by the spec, because they come at no cost and it is good to detech buggy use of mutexes. When we get a faster (probably using atomic_cmpset_*, in 6.0), we'll switch the default mutex over to normal and lose the error checking. > I am not even going to bother going into our choice of PTHREAD_MUTEX_DEFAULT > as a _#define_ for PTHREAD_MUTEX_ERRORCHECK. Just read the standard and I've done that. > point out, after reading the entire thing, then re-reading the ERRORS > section again and again, where it says pthread_mutex_trylock(3) can return > EDEADLK. Notice how every one of those four functions is explicitly broken ^^^^^^^ I think you mean EBUSY, no? > out into which error returns it supports. > > After further review, I can't possibly see how the behavior you chose to > use is allowed by a reasonable interpretation of the standard. Have you > consulted any standards@ people? Where did you get this interpretation? Because pthread_mutex_trylock() is defined in terms of pthread_mutex_lock() and pthread_mutex_lock() returns EDEADLK when a thread tries to recursively lock an error checking mutex. Since our mutexes are error checking, you get EDEADLK. > If you want to back this out and make dead certain to error on the side > of incompatibility, go ahead and do it yourself. You're not the one that > has spent the hours finding this problem in existing pthreads applications, > and you're probably not going to find and fix all the rest of the cases > of incompatibility this choice makes. It really doesn't effect you at all, > does it? I've been running mozilla and other things with libpthread for quite a while without any problems. You make it sound like all hell's going to break loose because of this. This has been brought up at least twice before on -threads and we've discussed the behavior. I've also sent an email to austin asking for clarification. And I sent you follow up email saying the change was OK if you wanted to limit it to PTHREAD_MUTEX_NORMAL mutexes. -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Sun Oct 31 22:12:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A27416A4CE; Sun, 31 Oct 2004 22:12:21 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8EF243D2F; Sun, 31 Oct 2004 22:12:20 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) i9VMCJFh017733; Sun, 31 Oct 2004 17:12:19 -0500 (EST) Date: Sun, 31 Oct 2004 17:12:19 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Fundakowski Feldman In-Reply-To: <20041031154046.GU93831@green.homeunix.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 22:12:21 -0000 On Sun, 31 Oct 2004, Brian Fundakowski Feldman wrote: > On Sun, Oct 31, 2004 at 03:23:41AM -0700, Scott Long wrote: > > Brian Fundakowski Feldman wrote: > > >On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > > > > > >>green 2004-10-31 05:03:50 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> lib/libpthread/thread thr_mutex.c > > >> Log: > > >> Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > >> packages expect and seems to be most correct according to the slightly- > > >> ambiguous standards. > > >> > > >> MFC after: 1 month > > >> Corroborated by: POSIX > > >> Reviewed by: silence on threads@ > > > > > > > > >Software such as mozilla projects (using NSPR) and Java have been > > >broken in various ways by this. We need to try to be more compatible > > >with the most popular interpretation of the standards (instead of just > > >inventing our own) -- usually we're pretty good about this. > > > > > > > Please define 'broken'? There are many test suites available for > > pthreads. How does this affect those test suites, and have you > > _directly_ talked with those who run the tests suites? > > It causes them to _FAIL_. Try to build a mozilla port without the > FreeBSD-specific pthread_mutex_trylock(3) workaround, with debugging > turned on, and without the removal of EDEADLK from the function. > We break the assertions that software developers use when writing to > the pthreads API, and then when we "port" applications written to > standard POSIX threads implementations in Solaris, Linux, etc., we > have to modify them to catch this. > > Have you tried any of the test suites? The POSIX-provided-for-free > one does not have coverage of error return values from what I can see, > and the Linux pthreads ones also don't test this because as far as they > are concerned, it's a code invariant, and the implementation which they > control is not going to start returning EDEADLK one day. The FreeBSD > one has similar issues (lack of coverage ones) but additionally is > exceedingly moldy and if it were actually a "regression" test we'd fail > it because half of them do not produce expected results. If you're talking about the FreeBSD mutex test (libpthread/test/mutex_d.c), that should work. -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Mon Nov 1 03:13:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA4D616A4CE; Mon, 1 Nov 2004 03:13:17 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88B8343D53; Mon, 1 Nov 2004 03:13:17 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 7AD455CB65; Sun, 31 Oct 2004 19:13:17 -0800 (PST) Date: Sun, 31 Oct 2004 19:13:17 -0800 From: Alfred Perlstein To: Alan Cox Message-ID: <20041101031317.GK24892@elvis.mu.org> References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410311932.i9VJWvmo058193@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 03:13:17 -0000 * Alan Cox [041031 11:33] wrote: > alc 2004-10-31 19:32:57 UTC > > FreeBSD src repository > > Modified files: > sys/vm vm_zeroidle.c > Log: > Introduce a Boolean variable wakeup_needed to avoid repeated, unnecessary > calls to wakeup() by vm_page_zero_idle_wakeup(). > > Revision Changes Path > 1.31 +9 -2 src/sys/vm/vm_zeroidle.c Why not switch to a cv? -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 04:53:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B9E716A4CE; Mon, 1 Nov 2004 04:53:32 +0000 (GMT) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D3C743D41; Mon, 1 Nov 2004 04:53:32 +0000 (GMT) (envelope-from alc@cs.rice.edu) Received: from localhost (calypso.cs.rice.edu [128.42.1.127]) by cs.rice.edu (Postfix) with ESMTP id 20C9B4AC1F; Sun, 31 Oct 2004 22:53:32 -0600 (CST) Received: from cs.rice.edu ([128.42.1.30]) by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024) with LMTP id 20346-01-26; Sun, 31 Oct 2004 22:53:31 -0600 (CST) Received: by cs.rice.edu (Postfix, from userid 19572) id BC9454AC1E; Sun, 31 Oct 2004 22:53:31 -0600 (CST) Date: Sun, 31 Oct 2004 22:53:31 -0600 From: Alan Cox To: Alfred Perlstein Message-ID: <20041101045331.GP16728@cs.rice.edu> References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101031317.GK24892@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041101031317.GK24892@elvis.mu.org> User-Agent: Mutt/1.4.2i X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 04:53:32 -0000 On Sun, Oct 31, 2004 at 07:13:17PM -0800, Alfred Perlstein wrote: > * Alan Cox [041031 11:33] wrote: > > alc 2004-10-31 19:32:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm vm_zeroidle.c > > Log: > > Introduce a Boolean variable wakeup_needed to avoid repeated, unnecessary > > calls to wakeup() by vm_page_zero_idle_wakeup(). > > > > Revision Changes Path > > 1.31 +9 -2 src/sys/vm/vm_zeroidle.c > > Why not switch to a cv? Calling cv_signal repeatedly would be no better than calling wakeup() repeatedly. Either way, a Boolean variable is desirable to prevent unnecessary calls. As for the question of msleep()/wakeup() vs. cv_wait*()/cv_signal(), cv_wait*() has no analogue to msleep()'s PDROP. In this case, there is no need to hold the lock after returning from the sleep. So, msleep(PDROP) is better suited to this case. Regards, Alan From owner-cvs-src@FreeBSD.ORG Mon Nov 1 09:04:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 2019516A4CF; Mon, 1 Nov 2004 09:04:04 +0000 (GMT) Date: Mon, 1 Nov 2004 09:04:04 +0000 From: Alexey Dokuchaev To: Jeff Roberson Message-ID: <20041101090404.GB52876@FreeBSD.org> References: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 09:04:04 -0000 On Sat, Oct 30, 2004 at 07:35:53AM +0000, Jeff Roberson wrote: > jeff 2004-10-30 07:35:53 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - In sched_prio() check to see if the kse is assigned to a runq as the > check for TD_ON_RUNQ() no longer means the thread is really on a run- > queue. I suspect this state should be re-evaluated as it must mean > something else now. This fixes ULE+KSE+PREEMPTION on UP x86. Leaving aside technical concerns Julian'd mentioned, it's really cool to have you doing ULE work again. Keep it up! ;-) ./danfe From owner-cvs-src@FreeBSD.ORG Mon Nov 1 10:49:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0F1A16A4CE; Mon, 1 Nov 2004 10:49:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C320A43D62; Mon, 1 Nov 2004 10:49:34 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1AnY4j012137; Mon, 1 Nov 2004 10:49:34 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1AnY8m012136; Mon, 1 Nov 2004 10:49:34 GMT (envelope-from davidxu) Message-Id: <200411011049.iA1AnY8m012136@repoman.freebsd.org> From: David Xu Date: Mon, 1 Nov 2004 10:49:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 10:49:35 -0000 davidxu 2004-11-01 10:49:34 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_private.h thr_sig.c Log: Save cancelflags in signal frame, this fixes a problem that a thread in pthread_cond_wait handled a signal can no longer be canceled. Reviewed by: deischen Revision Changes Path 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 10:51:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A33EF16A4CE; Mon, 1 Nov 2004 10:51:13 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85E8E43D3F; Mon, 1 Nov 2004 10:51:13 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 7AE535D1DA; Mon, 1 Nov 2004 02:51:13 -0800 (PST) Date: Mon, 1 Nov 2004 02:51:13 -0800 From: Alfred Perlstein To: Alan Cox Message-ID: <20041101105113.GS24892@elvis.mu.org> References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101031317.GK24892@elvis.mu.org> <20041101045331.GP16728@cs.rice.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041101045331.GP16728@cs.rice.edu> User-Agent: Mutt/1.4.2.1i cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 10:51:13 -0000 * Alan Cox [041031 20:53] wrote: > On Sun, Oct 31, 2004 at 07:13:17PM -0800, Alfred Perlstein wrote: > > * Alan Cox [041031 11:33] wrote: > > > alc 2004-10-31 19:32:57 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/vm vm_zeroidle.c > > > Log: > > > Introduce a Boolean variable wakeup_needed to avoid repeated, unnecessary > > > calls to wakeup() by vm_page_zero_idle_wakeup(). > > > > > > Revision Changes Path > > > 1.31 +9 -2 src/sys/vm/vm_zeroidle.c > > > > Why not switch to a cv? > > Calling cv_signal repeatedly would be no better than calling wakeup() > repeatedly. Either way, a Boolean variable is desirable to prevent > unnecessary calls. Yah, I figured there would be something in the cv code to optimize the "no waiters" case. > As for the question of msleep()/wakeup() vs. cv_wait*()/cv_signal(), > cv_wait*() has no analogue to msleep()'s PDROP. In this case, there > is no need to hold the lock after returning from the sleep. So, > msleep(PDROP) is better suited to this case. Didn't see that. thank you, -Alfred From owner-cvs-src@FreeBSD.ORG Mon Nov 1 11:43:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EEEC16A4CE; Mon, 1 Nov 2004 11:43:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52D2D43D49; Mon, 1 Nov 2004 11:43:07 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1Bh7dC015218; Mon, 1 Nov 2004 11:43:07 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1Bh7nC015217; Mon, 1 Nov 2004 11:43:07 GMT (envelope-from mlaier) Message-Id: <200411011143.iA1Bh7nC015217@repoman.freebsd.org> From: Max Laier Date: Mon, 1 Nov 2004 11:43:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 altq.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 11:43:07 -0000 mlaier 2004-11-01 11:43:07 UTC FreeBSD src repository Modified files: share/man/man4 altq.4 Log: des added bge(4) support. Revision Changes Path 1.3 +1 -0 src/share/man/man4/altq.4 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 12:31:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74AF516A4CE; Mon, 1 Nov 2004 12:31:51 +0000 (GMT) Received: from jc.ngo.org.uk (jc.ngo.org.uk [69.55.225.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89E2843D39; Mon, 1 Nov 2004 12:31:48 +0000 (GMT) (envelope-from nik@crf-consulting.co.uk) Received: from crf-consulting.co.uk (82-44-220-218.cable.ubr10.haye.blueyonder.co.uk [82.44.220.218]) by jc.ngo.org.uk (8.12.11/8.13.1) with ESMTP id iA1CVhiW044737; Mon, 1 Nov 2004 04:31:44 -0800 (PST) (envelope-from nik@crf-consulting.co.uk) Received: from clan.nothing-going-on.org (clan.nothing-going-on.org [192.168.1.20])iA1CVhpQ027964; Mon, 1 Nov 2004 12:31:43 GMT (envelope-from nik@catkin) Received: from clan.nothing-going-on.org (localhost [127.0.0.1]) iA1CVgGG035406; Mon, 1 Nov 2004 12:31:42 GMT (envelope-from nik@clan.nothing-going-on.org) Received: (from nik@localhost) by clan.nothing-going-on.org (8.13.1/8.13.1/Submit) id iA1CVgRb035405; Mon, 1 Nov 2004 12:31:42 GMT (envelope-from nik) Date: Mon, 1 Nov 2004 12:31:42 +0000 From: Nik Clayton To: Ken Smith Message-ID: <20041101123140.GB86304@clan.nothing-going-on.org> References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> <20041030014408.GA17500@electra.cse.Buffalo.EDU> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mvpLiMfbWzRoNl4x" Content-Disposition: inline In-Reply-To: <20041030014408.GA17500@electra.cse.Buffalo.EDU> User-Agent: Mutt/1.4.2.1i Organization: FreeBSD Project cc: cvs-src@FreeBSD.org cc: Alfred Perlstein cc: cvs-all@FreeBSD.org cc: John Baldwin cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 12:31:51 -0000 --mvpLiMfbWzRoNl4x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 29, 2004 at 09:44:08PM -0400, Ken Smith wrote: > Ok, last try at a compromise. If I commit the fix to todo=20 [...] If J. Random committer fixes something on the ToDo list, and gets re@ approval to merge it back to the appropriate branch, why isn't J. Random committer updating the ToDo list at the same time? Seems to me if you've gone to all the trouble of fixing an item on the ToDo list it's only fair that you get to be the one that gets to remove it from there too. N --=20 FreeBSD: The Power to Serve http://www.freebsd.org/ (__) FreeBSD Documentation Project http://www.freebsd.org/docproj/ \\\'',) \/ \= ^ --- 15B8 3FFC DDB4 34B0 AA5F 94B7 93A8 0764 2C37 E375 --- .\._/= _) --mvpLiMfbWzRoNl4x Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBhiysk6gHZCw343URAkfOAKCF9yBCBjVx4zKGAR0tE5DGnUBEhQCdHEf6 H0c/Fvx8svfYB2EKZ80ZK7g= =ywC6 -----END PGP SIGNATURE----- --mvpLiMfbWzRoNl4x-- From owner-cvs-src@FreeBSD.ORG Mon Nov 1 14:31:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C480A16A4CE; Mon, 1 Nov 2004 14:31:11 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56DA643D1F; Mon, 1 Nov 2004 14:31:11 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) iA1EVA3Y016807; Mon, 1 Nov 2004 09:31:10 -0500 (EST) Date: Mon, 1 Nov 2004 09:31:10 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Feldman In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 14:31:11 -0000 On Sun, 31 Oct 2004, Daniel Eischen wrote: > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > green 2004-10-31 05:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libpthread/thread thr_mutex.c > > Log: > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > packages expect and seems to be most correct according to the slightly- > > ambiguous standards. > > > > MFC after: 1 month > > Corroborated by: POSIX > > Reviewed by: silence on threads@ > > I never saw this, and there has been a couple of long threads about > it. The current behavior was deemed correct especially since default > mutexes are error check mutexes. The rationale is that it provides a way > for a thread to tell if it owns the mutex if EDEADLK is returned. > > Please back out and sorry for not seeing a posting on -threads. I retract the backout request. I have response from Dave Butenhof over at the Austin Group mailing list, and EBUSY should be returned even for error check mutexes. He acknolwedged the spec was not clear and thought they had cleaned it up in that regard. So this is the correct fix :-) -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Mon Nov 1 15:29:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id ECCA516A4CE; Mon, 1 Nov 2004 15:29:17 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id iA1FTHdu023705; Mon, 1 Nov 2004 10:29:17 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id iA1FTGSn023704; Mon, 1 Nov 2004 10:29:16 -0500 (EST) (envelope-from green) Date: Mon, 1 Nov 2004 10:29:16 -0500 From: Brian Fundakowski Feldman To: Daniel Eischen Message-ID: <20041101152916.GV93831@green.homeunix.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 15:29:18 -0000 On Mon, Nov 01, 2004 at 09:31:10AM -0500, Daniel Eischen wrote: > On Sun, 31 Oct 2004, Daniel Eischen wrote: > > > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > > > green 2004-10-31 05:03:50 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libpthread/thread thr_mutex.c > > > Log: > > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > > packages expect and seems to be most correct according to the slightly- > > > ambiguous standards. > > > > > > MFC after: 1 month > > > Corroborated by: POSIX > > > Reviewed by: silence on threads@ > > > > I never saw this, and there has been a couple of long threads about > > it. The current behavior was deemed correct especially since default > > mutexes are error check mutexes. The rationale is that it provides a way > > for a thread to tell if it owns the mutex if EDEADLK is returned. > > > > Please back out and sorry for not seeing a posting on -threads. > > I retract the backout request. I have response from Dave Butenhof > over at the Austin Group mailing list, and EBUSY should be returned > even for error check mutexes. He acknolwedged the spec was not > clear and thought they had cleaned it up in that regard. So this > is the correct fix :-) Could you please remind me what the procedure is for including POSIX text within our manual pages? For pthreads it should be trivial to use almost the same text, since we didn't originate the interfaces ourselves, no? Thanks for checking this out at the source. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Mon Nov 1 15:46:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C600116A4CE; Mon, 1 Nov 2004 15:46:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A665043D1D; Mon, 1 Nov 2004 15:46:21 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1FkLlJ029230; Mon, 1 Nov 2004 15:46:21 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1FkLJ2029229; Mon, 1 Nov 2004 15:46:21 GMT (envelope-from pjd) Message-Id: <200411011546.iA1FkLJ2029229@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 1 Nov 2004 15:46:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/raid3 graid3.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 15:46:21 -0000 pjd 2004-11-01 15:46:21 UTC FreeBSD src repository Modified files: sbin/geom/class/raid3 graid3.8 Log: Remove redundant 'not'. Revision Changes Path 1.5 +1 -1 src/sbin/geom/class/raid3/graid3.8 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 15:51:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC75316A4CE; Mon, 1 Nov 2004 15:51:36 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 822DB43D3F; Mon, 1 Nov 2004 15:51:36 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 8995111B7F; Mon, 1 Nov 2004 16:51:34 +0100 (CET) Date: Mon, 1 Nov 2004 16:51:33 +0100 From: "Simon L. Nielsen" To: Brian Fundakowski Feldman Message-ID: <20041101155132.GB752@zaphod.nitro.dk> References: <20041101152916.GV93831@green.homeunix.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline In-Reply-To: <20041101152916.GV93831@green.homeunix.org> User-Agent: Mutt/1.5.6i cc: Daniel Eischen cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 15:51:37 -0000 --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.11.01 10:29:16 -0500, Brian Fundakowski Feldman wrote: [...] > Could you please remind me what the procedure is for including > POSIX text within our manual pages? I talked to Ruslan about this at EuroBSDCon, and he is going to send me the text we got from The Open Group (when he gets back home), then I'm going to put it on a web page. So, there should be a web page about this very soon (hopefully within a couple of days). --=20 Simon L. Nielsen FreeBSD Documentation Team --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBhluEh9pcDSc1mlERAv76AKC+jaXMHVrmEBGgL0VYamB9C+C/9ACfdMgT WBxuATh3iCph1BDlQCoGQf4= =siql -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW-- From owner-cvs-src@FreeBSD.ORG Mon Nov 1 16:05:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 273CD16A4CE; Mon, 1 Nov 2004 16:05:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0755C43D39; Mon, 1 Nov 2004 16:05:58 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1G5vqw029852; Mon, 1 Nov 2004 16:05:57 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1G5vOL029851; Mon, 1 Nov 2004 16:05:57 GMT (envelope-from yar) Message-Id: <200411011605.iA1G5vOL029851@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 1 Nov 2004 16:05:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 16:05:58 -0000 yar 2004-11-01 16:05:57 UTC FreeBSD src repository Modified files: libexec/ftpd ftpd.c Log: OpenPAM allows passing a NULL "pamh" to pam_strerror() to indicate that the creation of a PAM context has failed. N.B. This does not apply to pam_strerror() in RELENG_4, it will mishandle a NULL "pamh". Discussed with: des Revision Changes Path 1.172 +5 -2 src/libexec/ftpd/ftpd.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 16:32:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CF0916A4CE; Mon, 1 Nov 2004 16:32:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D85E43D1D; Mon, 1 Nov 2004 16:32:10 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1GWA3Q030778; Mon, 1 Nov 2004 16:32:10 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1GWA8q030777; Mon, 1 Nov 2004 16:32:10 GMT (envelope-from obrien) Message-Id: <200411011632.iA1GWA8q030777@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 1 Nov 2004 16:32:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 16:32:10 -0000 obrien 2004-11-01 16:32:10 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall config.c Log: fix typo in generated /etc/exports: escape all ' Revision Changes Path 1.228 +1 -1 src/usr.sbin/sysinstall/config.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 16:52:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3144F16A4CE; Mon, 1 Nov 2004 16:52:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 106DE43D39; Mon, 1 Nov 2004 16:52:35 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1GqY0e037841; Mon, 1 Nov 2004 16:52:34 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1GqY9V037840; Mon, 1 Nov 2004 16:52:34 GMT (envelope-from delphij) Message-Id: <200411011652.iA1GqY9V037840@repoman.freebsd.org> From: Xin LI Date: Mon, 1 Nov 2004 16:52:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/rm rm.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 16:52:35 -0000 delphij 2004-11-01 16:52:34 UTC FreeBSD src repository Modified files: bin/rm rm.1 Log: Correct a typo and make the documentation more mdoc(7) complaint. Pointed out by: dd Approved by: murray (mentor) Revision Changes Path 1.33 +3 -3 src/bin/rm/rm.1 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 17:07:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 519A716A4CE; Mon, 1 Nov 2004 17:07:57 +0000 (GMT) Received: from bgezal.inso.tuwien.ac.at (bgezal.inso.tuwien.ac.at [128.130.59.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD92143D5F; Mon, 1 Nov 2004 17:07:56 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from fafoe.narf.at (unknown [212.186.3.235]) by bgezal.inso.tuwien.ac.at (Postfix) with ESMTP id 7F3F520AB; Mon, 1 Nov 2004 18:07:55 +0100 (CET) Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42]) by fafoe.narf.at (Postfix) with ESMTP id 430B4419E; Mon, 1 Nov 2004 18:07:52 +0100 (CET) Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 71AA9DC; Mon, 1 Nov 2004 18:07:51 +0100 (CET) Date: Mon, 1 Nov 2004 18:07:51 +0100 From: Stefan Farfeleder To: "David E. O'Brien" Message-ID: <20041101170748.GA81210@wombat.fafoe.narf.at> References: <200411011632.iA1GWA8q030777@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411011632.iA1GWA8q030777@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 17:07:57 -0000 On Mon, Nov 01, 2004 at 04:32:10PM +0000, David E. O'Brien wrote: > obrien 2004-11-01 16:32:10 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/sysinstall config.c > Log: > fix typo in generated /etc/exports: escape all ' > - vsystem("echo '# Note that BSD's export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > + vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); You need two backslashes here; \' is equivalent to ' inside string literals. Stefan From owner-cvs-src@FreeBSD.ORG Mon Nov 1 17:11:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F1C116A4CE; Mon, 1 Nov 2004 17:11:35 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21DFA43D48; Mon, 1 Nov 2004 17:11:35 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) iA1HBXcx029665; Mon, 1 Nov 2004 12:11:34 -0500 (EST) Date: Mon, 1 Nov 2004 12:11:33 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Fundakowski Feldman In-Reply-To: <20041101152916.GV93831@green.homeunix.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 17:11:35 -0000 On Mon, 1 Nov 2004, Brian Fundakowski Feldman wrote: > On Mon, Nov 01, 2004 at 09:31:10AM -0500, Daniel Eischen wrote: > > On Sun, 31 Oct 2004, Daniel Eischen wrote: > > > > > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > > > > > green 2004-10-31 05:03:50 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > lib/libpthread/thread thr_mutex.c > > > > Log: > > > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > > > packages expect and seems to be most correct according to the slightly- > > > > ambiguous standards. > > > > > > > > MFC after: 1 month > > > > Corroborated by: POSIX > > > > Reviewed by: silence on threads@ > > > > > > I never saw this, and there has been a couple of long threads about > > > it. The current behavior was deemed correct especially since default > > > mutexes are error check mutexes. The rationale is that it provides a way > > > for a thread to tell if it owns the mutex if EDEADLK is returned. > > > > > > Please back out and sorry for not seeing a posting on -threads. > > > > I retract the backout request. I have response from Dave Butenhof > > over at the Austin Group mailing list, and EBUSY should be returned > > even for error check mutexes. He acknolwedged the spec was not > > clear and thought they had cleaned it up in that regard. So this > > is the correct fix :-) > > Could you please remind me what the procedure is for including > POSIX text within our manual pages? For pthreads it should be > trivial to use almost the same text, since we didn't originate > the interfaces ourselves, no? See the -standards folks, and probably Ruslan. From what I understand, we have approval to include POSIX man pages. -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Mon Nov 1 17:21:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C36AF16A4CE; Mon, 1 Nov 2004 17:21:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A384443D4C; Mon, 1 Nov 2004 17:21:04 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1HL4vk039466; Mon, 1 Nov 2004 17:21:04 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1HL4DV039465; Mon, 1 Nov 2004 17:21:04 GMT (envelope-from obrien) Message-Id: <200411011721.iA1HL4DV039465@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 1 Nov 2004 17:21:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_sk.c if_skreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 17:21:04 -0000 obrien 2004-11-01 17:21:04 UTC FreeBSD src repository Modified files: sys/pci if_sk.c if_skreg.h Log: * Correct an off-by-one reading vpd ro data. * Announce some more fields from ro area for better debugging of broken sk(4)s on various boards. Submitted by: Bjoern A. Zeeb Revision Changes Path 1.87 +32 -3 src/sys/pci/if_sk.c 1.23 +1 -0 src/sys/pci/if_skreg.h From owner-cvs-src@FreeBSD.ORG Mon Nov 1 18:05:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 815B116A4CE; Mon, 1 Nov 2004 18:05:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 709AA43D48; Mon, 1 Nov 2004 18:05:41 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1I5f6f040915; Mon, 1 Nov 2004 18:05:41 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1I5fCZ040914; Mon, 1 Nov 2004 18:05:41 GMT (envelope-from mtm) Message-Id: <200411011805.iA1I5fCZ040914@repoman.freebsd.org> From: Mike Makonnen Date: Mon, 1 Nov 2004 18:05:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc usbd.conf src/etc/defaults rc.conf src/etc/rc.d moused src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 18:05:41 -0000 mtm 2004-11-01 18:05:41 UTC FreeBSD src repository Modified files: etc usbd.conf etc/defaults rc.conf etc/rc.d moused share/man/man5 rc.conf.5 Log: Do a better job of supporting more than one mouse device on the system. To start/stop/check on a specific device give the device name as the second argument to the script: # /etc/rc.d/moused start ums0 To use different rc.conf(5) knobs with different mice use the device name as part of the knob. For example, if the mouse device is ums0, then: moused_ums0_enable=yes moused_ums0_flags="-z 4" moused_ums0_port="/dev/ums0" Starting rc.d/moused without the device argument will use the standard moused_* flags. So, this commit should not disrupt or change current usage. To preserve current behaviour with respect to usb mice, which appear automatically when inserted, there is a new knob, moused_nondefault_enable, which will treat any devices without rc.conf knobs as enabled. To minimize knobs in /etc/rc.conf, the device file and pid file are auto-computed, so that in the typical case for a usb mouse you don't need to add anything extra in /etc/rc.conf to get it working. Additionally, this updates /etc/usbd.conf to use the rc.d/moused script so people don't have to modify it to configure their usb mouse anymore. MFC after: 1 month Revision Changes Path 1.228 +2 -0 src/etc/defaults/rc.conf 1.8 +39 -4 src/etc/rc.d/moused 1.13 +1 -1 src/etc/usbd.conf 1.234 +15 -0 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:05:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1B0B16A4CE; Mon, 1 Nov 2004 19:05:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C00B743D45; Mon, 1 Nov 2004 19:05:04 +0000 (GMT) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1J543B043016; Mon, 1 Nov 2004 19:05:04 GMT (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1J54nw043015; Mon, 1 Nov 2004 19:05:04 GMT (envelope-from alfred) Message-Id: <200411011905.iA1J54nw043015@repoman.freebsd.org> From: Alfred Perlstein Date: Mon, 1 Nov 2004 19:05:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/sh sh.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:05:05 -0000 alfred 2004-11-01 19:05:04 UTC FreeBSD src repository Modified files: bin/sh sh.1 Log: When listing the special $ variables, ($!, $#, etc) list them as $! instead of just !, this allows one to more easily locate/understand the section of the manpage in question. Additional wording correction by: keramida Reviewed by: keramida Revision Changes Path 1.93 +16 -12 src/bin/sh/sh.1 From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:06:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10DCD16A4CE; Mon, 1 Nov 2004 19:06:16 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EB6243D45; Mon, 1 Nov 2004 19:06:15 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA1J5f0O007714; Mon, 1 Nov 2004 12:05:41 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 01 Nov 2004 12:05:43 -0700 (MST) Message-Id: <20041101.120543.32720740.imp@bsdimp.com> To: mtm@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200411011805.iA1I5fCZ040914@repoman.freebsd.org> References: <200411011805.iA1I5fCZ040914@repoman.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc usbd.conf src/etc/defaults rc.conf src/etc/rc.d moused src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:06:16 -0000 In message: <200411011805.iA1I5fCZ040914@repoman.freebsd.org> Mike Makonnen writes: : Additionally, this updates /etc/usbd.conf to use the rc.d/moused script so : people don't have to modify it to configure their usb mouse anymore. Actually, we should be moving this configruation to devd.conf from usbd.conf... Warner From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:31:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E4CB16A4CE for ; Mon, 1 Nov 2004 19:31:13 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19F0143D41 for ; Mon, 1 Nov 2004 19:31:13 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 14774 invoked from network); 1 Nov 2004 19:31:12 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 1 Nov 2004 19:31:12 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA1JV42O061830; Mon, 1 Nov 2004 14:31:08 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nik Clayton Date: Mon, 1 Nov 2004 14:27:03 -0500 User-Agent: KMail/1.6.2 References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <20041030014408.GA17500@electra.cse.Buffalo.EDU> <20041101123140.GB86304@clan.nothing-going-on.org> In-Reply-To: <20041101123140.GB86304@clan.nothing-going-on.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411011427.03540.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Alfred Perlstein cc: cvs-src@FreeBSD.org cc: Ken Smith cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:31:13 -0000 On Monday 01 November 2004 07:31 am, Nik Clayton wrote: > On Fri, Oct 29, 2004 at 09:44:08PM -0400, Ken Smith wrote: > > Ok, last try at a compromise. If I commit the fix to todo > > [...] > > If J. Random committer fixes something on the ToDo list, and gets re@ > approval to merge it back to the appropriate branch, why isn't J. Random > committer updating the ToDo list at the same time? > > Seems to me if you've gone to all the trouble of fixing an item on the > ToDo list it's only fair that you get to be the one that gets to remove > it from there too. re@ decided to manage the todo list itself as people were adding items to the todo list without asking re@ if they were really show stoppers first, etc. Perhaps re@'s "managing" of the todo list can use some more refinement. Having it be a static webpage is actually not always intuitive, would be nice if it was in some kind of tracking system instead (along with all the merge requests). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:31:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 631AF16A4D5 for ; Mon, 1 Nov 2004 19:31:15 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21A7343D46 for ; Mon, 1 Nov 2004 19:31:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6216 invoked from network); 1 Nov 2004 19:31:14 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 1 Nov 2004 19:31:14 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA1JV42P061830; Mon, 1 Nov 2004 14:31:10 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 1 Nov 2004 14:29:38 -0500 User-Agent: KMail/1.6.2 References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> In-Reply-To: <20041029234823.GW24892@elvis.mu.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411011429.38840.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:31:19 -0000 On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: > * John Baldwin [041029 12:49] wrote: > > On Friday 29 October 2004 04:24 am, Alfred Perlstein wrote: > > > alfred 2004-10-29 08:24:41 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_sig.c > > > Log: > > > Backout 1.291. > > > > > > re doesn't seem to think this fixes: > > > Desired features for 5.3-RELEASE "More truss problems" > > > > Umm, the todo list always lags the fixes. This is nothing personal, it's > > just that approving requests, etc. takes up most of re@'s limited time. > > Geez. Usually the reson the todo gets updated is that someone explicitly > > e-mails re@ saying "you can move this item from todo to done". As with > > other e-mails sent to re@ (like MFC requests), if they don't respond to > > it, it probably got lost in the bitbucket, so you have to resend it until > > you get an ack. (Kind of like TCP. :-P) > > I made 3-4 requestss, each one had an ACK that said, "sorry, right > on it!" > > It's just not acceptable. Are you volunteering to be an re@ secretary ala wilko@? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:31:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BB0F16A555 for ; Mon, 1 Nov 2004 19:31:17 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6158F43D49 for ; Mon, 1 Nov 2004 19:31:17 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6299 invoked from network); 1 Nov 2004 19:31:17 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 1 Nov 2004 19:31:16 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA1JV42Q061830; Mon, 1 Nov 2004 14:31:13 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Mike Silbersack Date: Mon, 1 Nov 2004 14:34:28 -0500 User-Agent: KMail/1.6.2 References: <200410291910.i9TJAlNf089795@repoman.freebsd.org> <200410291549.17355.jhb@FreeBSD.org> <20041029174131.A6530@odysseus.silby.com> In-Reply-To: <20041029174131.A6530@odysseus.silby.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411011434.28141.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:31:19 -0000 On Friday 29 October 2004 06:51 pm, Mike Silbersack wrote: > On Fri, 29 Oct 2004, John Baldwin wrote: > > On Friday 29 October 2004 03:10 pm, Alan Cox wrote: > >> Implement per-CPU SYSMAPs, i.e., CADDR* and CMAP*, to reduce lock > >> contention within pmap_zero_page() and pmap_copy_page(). > > > > Cool. One note: I think you have to move the sched_pin before the lookup > > in the sysmaps_pcpu[] table so you don't migrate to another CPU if you > > get an interrupt after you've locked the sysmap. I'm curious if can get > > rid of the sysmaps lock altogether actually. It might require a critical > > section to do so though, and zero'ing page(s) is probably too long to > > defer interrupts. > > > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > > I think we really need some sort of light-weight critical_enter that > simply assures you that you won't get rescheduled to another CPU, but > gives no guarantees beyond that. That's very easy, it's just critical_enter/exit() without the cpu_critical_*(). As mentioned in the SMP "design doc", the cpu_critical_*() are only needed for spin mutexes that are used in both top-half and bottom-half code (where ithreads are top-half, but "fast" interrupts and the code that schedules ithreads are bottom-half). I've thought about shoving cpu_critical_*() off into another API that spin mutexes would use, but that not all critical sections would use, this would give us critical sections that don't block interrupts, but just block preempting. For idle page zeroing though, I'm not sure we really want to use even a cheap critical section since it would still defer an ithread from running, and ithreads are more important than idle page zeroing. Note that you can easily pin the current thread to its current CPU via sched_pin/unpin() and that that works across preemptions. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:31:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B52616A4F2 for ; Mon, 1 Nov 2004 19:31:20 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25ACC43D41 for ; Mon, 1 Nov 2004 19:31:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6384 invoked from network); 1 Nov 2004 19:31:19 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 1 Nov 2004 19:31:19 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA1JV42R061830; Mon, 1 Nov 2004 14:31:15 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 1 Nov 2004 14:41:33 -0500 User-Agent: KMail/1.6.2 References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> In-Reply-To: <20041101105113.GS24892@elvis.mu.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411011441.33067.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Alan Cox cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:31:20 -0000 On Monday 01 November 2004 05:51 am, Alfred Perlstein wrote: > * Alan Cox [041031 20:53] wrote: > > On Sun, Oct 31, 2004 at 07:13:17PM -0800, Alfred Perlstein wrote: > > > * Alan Cox [041031 11:33] wrote: > > > > alc 2004-10-31 19:32:57 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/vm vm_zeroidle.c > > > > Log: > > > > Introduce a Boolean variable wakeup_needed to avoid repeated, > > > > unnecessary calls to wakeup() by vm_page_zero_idle_wakeup(). > > > > > > > > Revision Changes Path > > > > 1.31 +9 -2 src/sys/vm/vm_zeroidle.c > > > > > > Why not switch to a cv? > > > > Calling cv_signal repeatedly would be no better than calling wakeup() > > repeatedly. Either way, a Boolean variable is desirable to prevent > > unnecessary calls. > > Yah, I figured there would be something in the cv code to optimize > the "no waiters" case. There is, though sometimes it might think there are waiters when there actually aren't any. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Nov 1 19:45:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C88516A4CE; Mon, 1 Nov 2004 19:45:17 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABAED43D39; Mon, 1 Nov 2004 19:45:16 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id EE4561FF9AC; Mon, 1 Nov 2004 20:45:14 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 1347E1FF9A8; Mon, 1 Nov 2004 20:45:13 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 6C8D0156B7; Mon, 1 Nov 2004 19:45:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 5C5CE156B6; Mon, 1 Nov 2004 19:45:08 +0000 (UTC) Date: Mon, 1 Nov 2004 19:45:08 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: "David E. O'Brien" In-Reply-To: <200411011721.iA1HL4DV039465@repoman.freebsd.org> Message-ID: References: <200411011721.iA1HL4DV039465@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_sk.c if_skreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 19:45:17 -0000 On Mon, 1 Nov 2004, David E. O'Brien wrote: Hi, > obrien 2004-11-01 17:21:04 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_sk.c if_skreg.h > Log: > * Correct an off-by-one reading vpd ro data. > * Announce some more fields from ro area for better debugging of broken > sk(4)s on various boards. > > Submitted by: Bjoern A. Zeeb *huh* what happened to make you commit this thing that fast? not that I would have anything against it - apart from that the words "ugly quick hack" are missing from the second part of the commit message. I am just a bit ... marvelled. Thanks for committing. Safes me the time to cleanup and coordinate with my mentors;) -- Greetings bz@ From owner-cvs-src@FreeBSD.ORG Mon Nov 1 20:01:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D622F16A4CE; Mon, 1 Nov 2004 20:01:16 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99A6443D46; Mon, 1 Nov 2004 20:01:16 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 641607A427; Mon, 1 Nov 2004 12:01:16 -0800 (PST) Message-ID: <4186960C.6090805@elischer.org> Date: Mon, 01 Nov 2004 12:01:16 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: David Xu References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> In-Reply-To: <200411011049.iA1AnY8m012136@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 20:01:17 -0000 shuold there be an MFC date? David Xu wrote: >davidxu 2004-11-01 10:49:34 UTC > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_private.h thr_sig.c > Log: > Save cancelflags in signal frame, this fixes a problem that > a thread in pthread_cond_wait handled a signal can no longer > be canceled. > > Reviewed by: deischen > > Revision Changes Path > 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h > 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c > > From owner-cvs-src@FreeBSD.ORG Mon Nov 1 20:12:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB83916A4CE; Mon, 1 Nov 2004 20:12:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 850C843D77; Mon, 1 Nov 2004 20:12:07 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1KC37I049263; Mon, 1 Nov 2004 20:12:03 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1KC3ax049262; Mon, 1 Nov 2004 20:12:03 GMT (envelope-from glebius) Message-Id: <200411012012.iA1KC3ax049262@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 1 Nov 2004 20:12:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_cisco.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 20:12:08 -0000 glebius 2004-11-01 20:12:03 UTC FreeBSD src repository Modified files: sys/netgraph ng_cisco.c Log: o style changes: - tabs after defines - tabs instead of many spaces - sort local variables by size o remove spl(9) calls Approved by: julian (mentor) Revision Changes Path 1.24 +11 -13 src/sys/netgraph/ng_cisco.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 20:52:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E98416A4D2; Mon, 1 Nov 2004 20:52:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4C1643D1D; Mon, 1 Nov 2004 20:52:24 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1KqOPm056780; Mon, 1 Nov 2004 20:52:24 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1KqOYD056779; Mon, 1 Nov 2004 20:52:24 GMT (envelope-from glebius) Message-Id: <200411012052.iA1KqOYD056779@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 1 Nov 2004 20:52:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph/netflow netflow.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 20:52:25 -0000 glebius 2004-11-01 20:52:24 UTC FreeBSD src repository Modified files: sys/netgraph/netflow netflow.c Log: Removed bogus comment. Revision Changes Path 1.3 +0 -2 src/sys/netgraph/netflow/netflow.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:11:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2554A16A4CE; Mon, 1 Nov 2004 22:11:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02EC143D41; Mon, 1 Nov 2004 22:11:28 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1MBRkW064392; Mon, 1 Nov 2004 22:11:27 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1MBRrd064391; Mon, 1 Nov 2004 22:11:27 GMT (envelope-from jhb) Message-Id: <200411012211.iA1MBRrd064391@repoman.freebsd.org> From: John Baldwin Date: Mon, 1 Nov 2004 22:11:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/i386 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:11:28 -0000 jhb 2004-11-01 22:11:27 UTC FreeBSD src repository Modified files: sys/i386/i386 mp_machdep.c Log: Allow individual application processors to be disabled from the loader via hints for 'lapicX'. For example, to disable the CPU with the local APIC ID of 7, use 'hint.lapic.7.disabled=1'. MFC after: 1 month Revision Changes Path 1.240 +16 -1 src/sys/i386/i386/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:15:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 653D116A4CF; Mon, 1 Nov 2004 22:15:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3734E43D1F; Mon, 1 Nov 2004 22:15:16 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1MFGv8064811; Mon, 1 Nov 2004 22:15:16 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA1MFGof064810; Mon, 1 Nov 2004 22:15:16 GMT (envelope-from jhb) Message-Id: <200411012215.iA1MFGof064810@repoman.freebsd.org> From: John Baldwin Date: Mon, 1 Nov 2004 22:15:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha db_trace.c src/sys/amd64/amd64 db_trace.c intr_machdep.c src/sys/arm/arm db_trace.c src/sys/ddb db_output.c db_ps.c db_thread.c db_variables.c ddb.h... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:15:16 -0000 jhb 2004-11-01 22:15:15 UTC FreeBSD src repository Modified files: sys/alpha/alpha db_trace.c sys/amd64/amd64 db_trace.c intr_machdep.c sys/arm/arm db_trace.c sys/ddb db_output.c db_ps.c db_thread.c db_variables.c ddb.h sys/dev/pci pci.c sys/i386/i386 db_trace.c intr_machdep.c machdep.c sys/ia64/ia64 db_trace.c sys/kern kern_intr.c kern_ktr.c sys/pc98/i386 machdep.c sys/powerpc/powerpc db_trace.c sys/sparc64/sparc64 db_trace.c Log: - Change the ddb paging "support" to use a variable (db_lines_per_page) to control the number of lines per page rather than a constant. The variable can be examined and changed in ddb as '$lines'. Setting the variable to 0 will effectively turn off paging. - Change db_putchar() to force out pending whitespace before outputting newlines and carriage returns so that one can rub out content on the current line via '\r \r' type strings. - Change the simple pager to rub out the --More-- prompt explicitly when the routine exits. - Add some aliases to the simple pager to make it more compatible with more(1): 'e' and 'j' do a single line. 'd' does half a page, and 'f' does a full page. MFC after: 1 month Inspired by: kris Revision Changes Path 1.22 +1 -1 src/sys/alpha/alpha/db_trace.c 1.64 +1 -1 src/sys/amd64/amd64/db_trace.c 1.10 +1 -1 src/sys/amd64/amd64/intr_machdep.c 1.7 +1 -1 src/sys/arm/arm/db_trace.c 1.32 +24 -8 src/sys/ddb/db_output.c 1.54 +1 -1 src/sys/ddb/db_ps.c 1.2 +1 -1 src/sys/ddb/db_thread.c 1.22 +1 -0 src/sys/ddb/db_variables.c 1.37 +1 -2 src/sys/ddb/ddb.h 1.267 +1 -1 src/sys/dev/pci/pci.c 1.64 +1 -1 src/sys/i386/i386/db_trace.c 1.10 +1 -1 src/sys/i386/i386/intr_machdep.c 1.600 +1 -1 src/sys/i386/i386/machdep.c 1.22 +1 -1 src/sys/ia64/ia64/db_trace.c 1.116 +1 -1 src/sys/kern/kern_intr.c 1.46 +1 -1 src/sys/kern/kern_ktr.c 1.345 +1 -1 src/sys/pc98/i386/machdep.c 1.7 +1 -1 src/sys/powerpc/powerpc/db_trace.c 1.22 +1 -1 src/sys/sparc64/sparc64/db_trace.c From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:18:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69D7A16A4CF; Mon, 1 Nov 2004 22:18:12 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id C59BB43D41; Mon, 1 Nov 2004 22:18:11 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id B2CD75312; Mon, 1 Nov 2004 23:18:10 +0100 (CET) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 05D3C5310; Mon, 1 Nov 2004 23:18:03 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 2602) id B9488B85E; Mon, 1 Nov 2004 23:18:03 +0100 (CET) To: Yar Tikhiy References: <200411011605.iA1G5vOL029851@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Mon, 01 Nov 2004 23:18:03 +0100 In-Reply-To: <200411011605.iA1G5vOL029851@repoman.freebsd.org> (Yar Tikhiy's message of "Mon, 1 Nov 2004 16:05:57 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:18:12 -0000 Yar Tikhiy writes: > Log: > OpenPAM allows passing a NULL "pamh" to pam_strerror() to indicate > that the creation of a PAM context has failed. Actually, OpenPAM's pam_strerror(3) completely ignores the pamh argument since all the information it needs is in the error_number argument. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:24:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 169FA16A4CE; Mon, 1 Nov 2004 22:24:24 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB90243D1F; Mon, 1 Nov 2004 22:24:23 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id F12975312; Mon, 1 Nov 2004 23:24:22 +0100 (CET) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 1FCCC5310; Mon, 1 Nov 2004 23:24:16 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 2602) id AD03AB85E; Mon, 1 Nov 2004 23:24:15 +0100 (CET) To: Daniel Eischen References: From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Mon, 01 Nov 2004 23:24:15 +0100 In-Reply-To: (Daniel Eischen's message of "Sun, 31 Oct 2004 17:00:46 -0500 (EST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.5 required=5.0 tests=AWL,NO_COST autolearn=no version=2.64 cc: Brian Fundakowski Feldman cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:24:24 -0000 Daniel Eischen writes: > We use error check mutexes by default, which is allowed by the > spec, because they come at no cost [...] They come at considerable cost. They make it impossible to use the Boehm garbage collector in threaded programs, for instance, because pthread_mutex_init() calls malloc() which tries to use a mutex. There is probably a significant performance penalty as well. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:32:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C68116A4CE; Mon, 1 Nov 2004 22:32:33 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 476AB43D1F; Mon, 1 Nov 2004 22:32:33 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) iA1MWUx8001384; Mon, 1 Nov 2004 17:32:30 -0500 (EST) Date: Mon, 1 Nov 2004 17:32:30 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN Content-Transfer-Encoding: QUOTED-PRINTABLE X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: Brian Fundakowski Feldman cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:32:33 -0000 On Mon, 1 Nov 2004, [iso-8859-1] Dag-Erling Sm=F8rgrav wrote: > Daniel Eischen writes: > > We use error check mutexes by default, which is allowed by the > > spec, because they come at no cost [...] > > They come at considerable cost. They make it impossible to use the > Boehm garbage collector in threaded programs, for instance, because > pthread_mutex_init() calls malloc() which tries to use a mutex. There > is probably a significant performance penalty as well. No, they all call malloc() since all mutexes are currently pointers to thingies. --=20 Dan Eischen From owner-cvs-src@FreeBSD.ORG Mon Nov 1 22:43:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25E3416A4CE; Mon, 1 Nov 2004 22:43:40 +0000 (GMT) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 584BB43D48; Mon, 1 Nov 2004 22:43:39 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.12.9p2/8.12.9) with ESMTP id iA1MhaUp046037; Tue, 2 Nov 2004 01:43:36 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.12.9p2/8.12.9/Submit) id iA1MhZ77046036; Tue, 2 Nov 2004 01:43:35 +0300 (MSK) (envelope-from yar) Date: Tue, 2 Nov 2004 01:43:35 +0300 From: Yar Tikhiy To: Dag-Erling Sm?rgrav Message-ID: <20041101224334.GA44247@comp.chem.msu.su> References: <200411011605.iA1G5vOL029851@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 22:43:40 -0000 On Mon, Nov 01, 2004 at 11:18:03PM +0100, Dag-Erling Sm?rgrav wrote: > Yar Tikhiy writes: > > Log: > > OpenPAM allows passing a NULL "pamh" to pam_strerror() to indicate > > that the creation of a PAM context has failed. > > Actually, OpenPAM's pam_strerror(3) completely ignores the pamh > argument since all the information it needs is in the error_number > argument. I guess it _currently_ ignores the pamh argument. According to a theatrical proverb, a rifle hanging on the wall from the beginning ought to go off in the last act. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Nov 1 23:04:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC31816A4CF; Mon, 1 Nov 2004 23:04:56 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F2A243D45; Mon, 1 Nov 2004 23:04:56 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) iA1N4rd1082288; Mon, 1 Nov 2004 23:04:55 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4186C114.1000004@freebsd.org> Date: Tue, 02 Nov 2004 07:04:52 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Julian Elischer References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> In-Reply-To: <4186960C.6090805@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 23:04:56 -0000 Not every important, I think I have another very important history bug in hand, did you get my "fix famous libpthread conditional variable race condition" mail ? :-) David Xu Julian Elischer wrote: > shuold there be an MFC date? > > > David Xu wrote: > >> davidxu 2004-11-01 10:49:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libpthread/thread thr_private.h thr_sig.c Log: >> Save cancelflags in signal frame, this fixes a problem that >> a thread in pthread_cond_wait handled a signal can no longer >> be canceled. >> >> Reviewed by: deischen >> >> Revision Changes Path >> 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h >> 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c >> >> > > > From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:06:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD8A016A4CE; Tue, 2 Nov 2004 09:06:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE03643D49; Tue, 2 Nov 2004 09:06:48 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA296mUD007376; Tue, 2 Nov 2004 09:06:48 GMT (envelope-from ssouhlal@repoman.freebsd.org) Received: (from ssouhlal@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA296mNk007375; Tue, 2 Nov 2004 09:06:48 GMT (envelope-from ssouhlal) Message-Id: <200411020906.iA296mNk007375@repoman.freebsd.org> From: Suleiman Souhlal Date: Tue, 2 Nov 2004 09:06:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/powerpc/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:06:49 -0000 ssouhlal 2004-11-02 09:06:48 UTC FreeBSD src repository Modified files: sys/powerpc/conf GENERIC Log: Uncomment options _KPOSIX_PRIORITY_SCHEDULING as it is enabled in the other architectures, and does not give any problems. Approved by: grehan (mentor) Revision Changes Path 1.44 +1 -1 src/sys/powerpc/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:09:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 190C316A4CF for ; Tue, 2 Nov 2004 09:09:34 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1432B43D4C for ; Tue, 2 Nov 2004 09:09:33 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 74733 invoked from network); 2 Nov 2004 09:06:02 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.54]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 2 Nov 2004 09:06:02 -0000 Message-ID: <41874ED1.662A02@freebsd.org> Date: Tue, 02 Nov 2004 10:09:37 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: John Baldwin References: <200410291910.i9TJAlNf089795@repoman.freebsd.org> <200410291549.17355.jhb@FreeBSD.org> <20041029174131.A6530@odysseus.silby.com> <200411011434.28141.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Alan Cox cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:09:34 -0000 John Baldwin wrote: > > That's very easy, it's just critical_enter/exit() without the > cpu_critical_*(). As mentioned in the SMP "design doc", the cpu_critical_*() > are only needed for spin mutexes that are used in both top-half and > bottom-half code (where ithreads are top-half, but "fast" interrupts and the > code that schedules ithreads are bottom-half). I've thought about shoving > cpu_critical_*() off into another API that spin mutexes would use, but that > not all critical sections would use, this would give us critical sections > that don't block interrupts, but just block preempting. For idle page > zeroing though, I'm not sure we really want to use even a cheap critical > section since it would still defer an ithread from running, and ithreads are > more important than idle page zeroing. > > Note that you can easily pin the current thread to its current CPU via > sched_pin/unpin() and that that works across preemptions. Does this involve any mutexes or so? This is very interesting for a couple of cases in the network stack which uses a lot of heavy-weight mutexes at the moment. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:29:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D35416A4CE; Tue, 2 Nov 2004 09:29:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CE7943D55; Tue, 2 Nov 2004 09:29:32 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA29TWsG008141; Tue, 2 Nov 2004 09:29:32 GMT (envelope-from ssouhlal@repoman.freebsd.org) Received: (from ssouhlal@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA29TWk6008140; Tue, 2 Nov 2004 09:29:32 GMT (envelope-from ssouhlal) Message-Id: <200411020929.iA29TWk6008140@repoman.freebsd.org> From: Suleiman Souhlal Date: Tue, 2 Nov 2004 09:29:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/powerpc/powermac ata_kauai.c ata_macio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:29:32 -0000 ssouhlal 2004-11-02 09:29:32 UTC FreeBSD src repository Modified files: sys/powerpc/powermac ata_kauai.c ata_macio.c Log: Stay up to date with the latest ATA developments, where ata_channel.locking now returns an int. Approved by: grehan (mentor) Revision Changes Path 1.6 +2 -1 src/sys/powerpc/powermac/ata_kauai.c 1.12 +2 -1 src/sys/powerpc/powermac/ata_macio.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:40:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4168F16A4CE; Tue, 2 Nov 2004 09:40:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22A8043D45; Tue, 2 Nov 2004 09:40:58 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA29ewR4008677; Tue, 2 Nov 2004 09:40:58 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA29evef008676; Tue, 2 Nov 2004 09:40:57 GMT (envelope-from maxim) Message-Id: <200411020940.iA29evef008676@repoman.freebsd.org> From: Maxim Konovalov Date: Tue, 2 Nov 2004 09:40:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:40:58 -0000 maxim 2004-11-02 09:40:57 UTC FreeBSD src repository Modified files: share/misc bsd-family-tree Log: Add OpenBSD 3.6. Revision Changes Path 1.85 +4 -3 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:42:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB59416A4CE; Tue, 2 Nov 2004 09:42:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA02F43D48; Tue, 2 Nov 2004 09:42:21 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA29gLqO008732; Tue, 2 Nov 2004 09:42:21 GMT (envelope-from ssouhlal@repoman.freebsd.org) Received: (from ssouhlal@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA29gL7m008731; Tue, 2 Nov 2004 09:42:21 GMT (envelope-from ssouhlal) Message-Id: <200411020942.iA29gL7m008731@repoman.freebsd.org> From: Suleiman Souhlal Date: Tue, 2 Nov 2004 09:42:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:42:22 -0000 ssouhlal 2004-11-02 09:42:21 UTC FreeBSD src repository Modified files: libexec/rtld-elf rtld.c Log: Do the TLS offset allocations before relocations, as otherwise there can be overlap in the TLS offsets, if the relocations are done in a certain order. Approved by: dfr, grehan (mentor) Revision Changes Path 1.101 +11 -11 src/libexec/rtld-elf/rtld.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 09:47:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51E2616A4CE; Tue, 2 Nov 2004 09:47:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2759D43D53; Tue, 2 Nov 2004 09:47:02 +0000 (GMT) (envelope-from ssouhlal@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA29l2gs008986; Tue, 2 Nov 2004 09:47:02 GMT (envelope-from ssouhlal@repoman.freebsd.org) Received: (from ssouhlal@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA29l2QG008985; Tue, 2 Nov 2004 09:47:02 GMT (envelope-from ssouhlal) Message-Id: <200411020947.iA29l2QG008985@repoman.freebsd.org> From: Suleiman Souhlal Date: Tue, 2 Nov 2004 09:47:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/rtld-elf/powerpc reloc.c rtld_machdep.h src/sys/powerpc/include elf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 09:47:02 -0000 ssouhlal 2004-11-02 09:47:02 UTC FreeBSD src repository Modified files: libexec/rtld-elf/powerpc reloc.c rtld_machdep.h sys/powerpc/include elf.h Log: Implement TLS relocations for powerpc. Approved by: grehan (mentor) Revision Changes Path 1.5 +65 -3 src/libexec/rtld-elf/powerpc/reloc.c 1.4 +8 -0 src/libexec/rtld-elf/powerpc/rtld_machdep.h 1.7 +28 -0 src/sys/powerpc/include/elf.h From owner-cvs-src@FreeBSD.ORG Tue Nov 2 10:26:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4BD9716A4CE; Tue, 2 Nov 2004 10:26:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B42A43D58; Tue, 2 Nov 2004 10:26:18 +0000 (GMT) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2AQIMs010528; Tue, 2 Nov 2004 10:26:18 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2AQIMM010527; Tue, 2 Nov 2004 10:26:18 GMT (envelope-from wilko) Message-Id: <200411021026.iA2AQIMM010527@repoman.freebsd.org> From: Wilko Bulte Date: Tue, 2 Nov 2004 10:26:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 10:26:18 -0000 wilko 2004-11-02 10:26:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) games/fortune/datfiles fortunes Log: Never be afraid to try something new. Remember, amateurs built the ark. Professionals built the Titanic. Revision Changes Path 1.34.2.15 +3 -0 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Tue Nov 2 10:46:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33CD116A4CE; Tue, 2 Nov 2004 10:46:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12DDE43D41; Tue, 2 Nov 2004 10:46:29 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2AkS4N011203; Tue, 2 Nov 2004 10:46:28 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2AkSJH011202; Tue, 2 Nov 2004 10:46:28 GMT (envelope-from harti) Message-Id: <200411021046.iA2AkSJH011202@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 2 Nov 2004 10:46:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 Makefile ngatmbase.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 10:46:29 -0000 harti 2004-11-02 10:46:28 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Added files: share/man/man4 ngatmbase.4 Log: Add a man page for the NgATM helper module ngatmbase. Requested by: Ulrich Spoerlein Revision Changes Path 1.288 +1 -0 src/share/man/man4/Makefile 1.1 +122 -0 src/share/man/man4/ngatmbase.4 (new) From owner-cvs-src@FreeBSD.ORG Tue Nov 2 11:59:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31E4216A4CE; Tue, 2 Nov 2004 11:59:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1180B43D39; Tue, 2 Nov 2004 11:59:28 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2BxRPT013223; Tue, 2 Nov 2004 11:59:27 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2BxRij013222; Tue, 2 Nov 2004 11:59:27 GMT (envelope-from ru) Message-Id: <200411021159.iA2BxRij013222@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 2 Nov 2004 11:59:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 11:59:28 -0000 ru 2004-11-02 11:59:27 UTC FreeBSD src repository Modified files: release Makefile Log: Actually put hint.atkbd.0.flags="0x1" in /boot/device.hints on CD-ROMs. (Brought to my attention by Brooks while sitting together on the floor in "Kairo".) Revision Changes Path 1.867 +3 -2 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Nov 2 12:35:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BE3216A4CE; Tue, 2 Nov 2004 12:35:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B6C943D5A; Tue, 2 Nov 2004 12:35:55 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2CZsMG014309; Tue, 2 Nov 2004 12:35:54 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2CZsBw014308; Tue, 2 Nov 2004 12:35:54 GMT (envelope-from pjd) Message-Id: <200411021235.iA2CZsBw014308@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 2 Nov 2004 12:35:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 12:35:55 -0000 pjd 2004-11-02 12:35:54 UTC FreeBSD src repository Modified files: etc/rc.d Makefile Log: Sort files properly. Revision Changes Path 1.45 +2 -2 src/etc/rc.d/Makefile From owner-cvs-src@FreeBSD.ORG Tue Nov 2 13:02:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BED2516A4CE; Tue, 2 Nov 2004 13:02:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FC9643D39; Tue, 2 Nov 2004 13:02:22 +0000 (GMT) (envelope-from philip@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2D2Mfk021575; Tue, 2 Nov 2004 13:02:22 GMT (envelope-from philip@repoman.freebsd.org) Received: (from philip@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2D2Mbr021574; Tue, 2 Nov 2004 13:02:22 GMT (envelope-from philip) Message-Id: <200411021302.iA2D2Mbr021574@repoman.freebsd.org> From: Philip Paeps Date: Tue, 2 Nov 2004 13:02:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica acpi_asus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 13:02:22 -0000 philip 2004-11-02 13:02:22 UTC FreeBSD src repository Modified files: sys/i386/acpica acpi_asus.c Log: Add support for Asus M6N laptops Submitted by: Andreas Dieling Revision Changes Path 1.12 +11 -0 src/sys/i386/acpica/acpi_asus.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 14:49:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B45AC16A4CE; Tue, 2 Nov 2004 14:49:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9396143D2F; Tue, 2 Nov 2004 14:49:46 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2EnkQr024829; Tue, 2 Nov 2004 14:49:46 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2EnkHA024828; Tue, 2 Nov 2004 14:49:46 GMT (envelope-from yar) Message-Id: <200411021449.iA2EnkHA024828@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 2 Nov 2004 14:49:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 14:49:46 -0000 yar 2004-11-02 14:49:46 UTC FreeBSD src repository Modified files: libexec/ftpd ftpd.c Log: This is a forced commit to note that actually pam_strerror() in RELENG_4 can handle a NULL "pamh", too, because the code that wouldn't allow that is effectively ifdef'ed out. Therefore rev. 1.171-1.172 can be merged to RELENG_4 safely. Revision Changes Path 1.173 +0 -0 src/libexec/ftpd/ftpd.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 15:55:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22BEA16A4CF; Tue, 2 Nov 2004 15:55:26 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 957B043D55; Tue, 2 Nov 2004 15:55:24 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) iA2FtGIo012638; Tue, 2 Nov 2004 10:55:16 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id iA2FtGwi012637; Tue, 2 Nov 2004 10:55:16 -0500 (EST) Date: Tue, 2 Nov 2004 10:55:16 -0500 From: Ken Smith To: David Xu Message-ID: <20041102155516.GE9346@electra.cse.Buffalo.EDU> References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4186C114.1000004@freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 15:55:26 -0000 On Tue, Nov 02, 2004 at 07:04:52AM +0800, David Xu wrote: > Not every important, I think I have another very important history > bug in hand, did you get my "fix famous libpthread conditional > variable race condition" mail ? :-) > > David Xu > > Julian Elischer wrote: > > >shuold there be an MFC date? > > > > > >David Xu wrote: > > > >>davidxu 2004-11-01 10:49:34 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libpthread/thread thr_private.h thr_sig.c Log: > >> Save cancelflags in signal frame, this fixes a problem that > >> a thread in pthread_cond_wait handled a signal can no longer > >> be canceled. > >> > >> Reviewed by: deischen > >> > >> Revision Changes Path > >> 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h > >> 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c Keep in mind that even 'Not very important' things most often can and probably should be MFC-ed now since HEAD and -STABLE are now so close to being the same thing. We have gone through a long period of time where what was considered HEAD or -CURRENT was drastically different from -STABLE (the 5.x versus 4.x branches). But now we'll be going through a stage where we'll be putting out at least a few releases based on RELENG_5 (5.4, 5.5, etc). So right now "MFC-ing something" means merging it into RELENG_5. If you do not MFC it then it won't wind up in a release until 6.0 comes out. -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | From owner-cvs-src@FreeBSD.ORG Tue Nov 2 17:15:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 734CE16A4CE; Tue, 2 Nov 2004 17:15:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51CD543D5A; Tue, 2 Nov 2004 17:15:14 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2HFEXd035622; Tue, 2 Nov 2004 17:15:14 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2HFDKT035621; Tue, 2 Nov 2004 17:15:13 GMT (envelope-from rwatson) Message-Id: <200411021715.iA2HFDKT035621@repoman.freebsd.org> From: Robert Watson Date: Tue, 2 Nov 2004 17:15:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 17:15:14 -0000 rwatson 2004-11-02 17:15:13 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Acquire the accept mutex in soabort() before calling sotryfree(), as that is now required. RELENG_5_3 candidate. Foot provided by: Dikshie Revision Changes Path 1.216 +1 -0 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 17:59:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE30716A4CE; Tue, 2 Nov 2004 17:59:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3B8E43D5D; Tue, 2 Nov 2004 17:59:12 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2HxCT1036897; Tue, 2 Nov 2004 17:59:12 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2HxCbe036896; Tue, 2 Nov 2004 17:59:12 GMT (envelope-from rwatson) Message-Id: <200411021759.iA2HxCbe036896@repoman.freebsd.org> From: Robert Watson Date: Tue, 2 Nov 2004 17:59:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/sockets/listenclose Makefile listenclose.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 17:59:13 -0000 rwatson 2004-11-02 17:59:12 UTC FreeBSD src repository Added files: tools/regression/sockets/listenclose Makefile listenclose.c Log: Add a small regression test that opens a TCP socket, listens on it, performs a non-blocking connect from another socket, and then closes the listen socket rather than accepting. This is intended to exercise the close path in which connections are aborted due to a close on the listen socket while the connection is in the listen queue. Revision Changes Path 1.1 +9 -0 src/tools/regression/sockets/listenclose/Makefile (new) 1.1 +111 -0 src/tools/regression/sockets/listenclose/listenclose.c (new) From owner-cvs-src@FreeBSD.ORG Tue Nov 2 18:10:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 683B316A4CE; Tue, 2 Nov 2004 18:10:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 495C943D49; Tue, 2 Nov 2004 18:10:02 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2IA2sU037248; Tue, 2 Nov 2004 18:10:02 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2IA200037247; Tue, 2 Nov 2004 18:10:02 GMT (envelope-from phk) Message-Id: <200411021810.iA2IA200037247@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 2 Nov 2004 18:10:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/stty key.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 18:10:02 -0000 phk 2004-11-02 18:10:01 UTC FreeBSD src repository Modified files: bin/stty key.c Log: stty sane should set the echo bits. PR: 73423 Submitted by: Michiel Boland Overlooked by: phk Revision Changes Path 1.19 +1 -1 src/bin/stty/key.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 18:48:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A89316A4D9; Tue, 2 Nov 2004 18:48:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B1B543D4C; Tue, 2 Nov 2004 18:48:45 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2ImiM7038598; Tue, 2 Nov 2004 18:48:44 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2ImiTH038597; Tue, 2 Nov 2004 18:48:44 GMT (envelope-from yar) Message-Id: <200411021848.iA2ImiTH038597@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 2 Nov 2004 18:48:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 18:48:45 -0000 yar 2004-11-02 18:48:44 UTC FreeBSD src repository Modified files: libexec/ftpd ftpd.c Log: Replace the last occurence of (long long) and %qd with (intmax_t) and %jd, which is the right way to printf an off_t in the presence of . Submitted by: Nick Leuta Revision Changes Path 1.174 +2 -2 src/libexec/ftpd/ftpd.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 20:01:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BA0116A4CE; Tue, 2 Nov 2004 20:01:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4679143D5D; Tue, 2 Nov 2004 20:01:42 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2K1gd7040889; Tue, 2 Nov 2004 20:01:42 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2K1gYE040888; Tue, 2 Nov 2004 20:01:42 GMT (envelope-from emax) Message-Id: <200411022001.iA2K1gYE040888@repoman.freebsd.org> From: Maksim Yevmenkin Date: Tue, 2 Nov 2004 20:01:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph/bluetooth/drivers/h4 ng_h4.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 20:01:42 -0000 emax 2004-11-02 20:01:42 UTC FreeBSD src repository Modified files: sys/netgraph/bluetooth/drivers/h4 ng_h4.c Log: Fix broken ng_h4(4). Basically, do not abuse t_sc field and use new t_lsc field created for line disciplne drivers private use. Also add NET_NEEDS_GIANT warning. For whatever reason ng_tty(4) was fixed but ng_h4(4) was not :( Revision Changes Path 1.11 +9 -7 src/sys/netgraph/bluetooth/drivers/h4/ng_h4.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 20:06:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F17C16A4CE; Tue, 2 Nov 2004 20:06:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64AB243D48; Tue, 2 Nov 2004 20:06:33 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2K6XM2041133; Tue, 2 Nov 2004 20:06:33 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2K6Xj5041132; Tue, 2 Nov 2004 20:06:33 GMT (envelope-from emax) Message-Id: <200411022006.iA2K6Xj5041132@repoman.freebsd.org> From: Maksim Yevmenkin Date: Tue, 2 Nov 2004 20:06:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/examples/netgraph/bluetooth rc.bluetooth X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 20:06:33 -0000 emax 2004-11-02 20:06:33 UTC FreeBSD src repository Modified files: share/examples/netgraph/bluetooth rc.bluetooth Log: Serial devices now called /dev/cuadXX not /dev/cuaaXX Revision Changes Path 1.2 +1 -1 src/share/examples/netgraph/bluetooth/rc.bluetooth From owner-cvs-src@FreeBSD.ORG Tue Nov 2 20:12:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B53016A4CE; Tue, 2 Nov 2004 20:12:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A68A43D49; Tue, 2 Nov 2004 20:12:06 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2KC6pi041301; Tue, 2 Nov 2004 20:12:06 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2KC69k041300; Tue, 2 Nov 2004 20:12:06 GMT (envelope-from emax) Message-Id: <200411022012.iA2KC69k041300@repoman.freebsd.org> From: Maksim Yevmenkin Date: Tue, 2 Nov 2004 20:12:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/bluetooth/hcseriald hcseriald.8 hcseriald.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 20:12:06 -0000 emax 2004-11-02 20:12:06 UTC FreeBSD src repository Modified files: usr.sbin/bluetooth/hcseriald hcseriald.8 hcseriald.c Log: Serial devices now called /dev/cuadXX not /dev/cuaaXX Revision Changes Path 1.6 +1 -1 src/usr.sbin/bluetooth/hcseriald/hcseriald.8 1.5 +1 -1 src/usr.sbin/bluetooth/hcseriald/hcseriald.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 20:26:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 387C616A4CE; Tue, 2 Nov 2004 20:26:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A05D43D5E; Tue, 2 Nov 2004 20:26:42 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2KQfUu041743; Tue, 2 Nov 2004 20:26:41 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2KQfvn041738; Tue, 2 Nov 2004 20:26:41 GMT (envelope-from glebius) Message-Id: <200411022026.iA2KQfvn041738@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 2 Nov 2004 20:26:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_source.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 20:26:42 -0000 glebius 2004-11-02 20:26:41 UTC FreeBSD src repository Modified files: sys/netgraph ng_source.c Log: Fix a harmless error in order of ng_timeout() arguments. Approved by: julian (mentor) Revision Changes Path 1.19 +2 -2 src/sys/netgraph/ng_source.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 20:57:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0216716A4CE; Tue, 2 Nov 2004 20:57:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D715343D39; Tue, 2 Nov 2004 20:57:20 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2KvKTn051861; Tue, 2 Nov 2004 20:57:20 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2KvKNu051860; Tue, 2 Nov 2004 20:57:20 GMT (envelope-from andre) Message-Id: <200411022057.iA2KvKNu051860@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 2 Nov 2004 20:57:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/conf GENERIC src/sys/amd64/conf GENERIC src/sys/arm/conf IQ31244 SIMICS src/sys/i386/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 20:57:21 -0000 andre 2004-11-02 20:57:20 UTC FreeBSD src repository Modified files: sys/alpha/conf GENERIC sys/amd64/conf GENERIC sys/arm/conf IQ31244 SIMICS sys/i386/conf GENERIC sys/powerpc/conf GENERIC sys/sparc64/conf GENERIC sys/conf NOTES Log: Reduce annoying SCSI probing delay from 15 to 5 seconds in all GENRIC kernels. Discussed on: -current Revision Changes Path 1.180 +1 -1 src/sys/alpha/conf/GENERIC 1.426 +1 -1 src/sys/amd64/conf/GENERIC 1.3 +1 -1 src/sys/arm/conf/IQ31244 1.5 +1 -1 src/sys/arm/conf/SIMICS 1.1286 +1 -1 src/sys/conf/NOTES 1.420 +1 -1 src/sys/i386/conf/GENERIC 1.45 +1 -1 src/sys/powerpc/conf/GENERIC 1.83 +1 -1 src/sys/sparc64/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:11:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EEE3416A4CE for ; Tue, 2 Nov 2004 21:11:12 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6187843D2F for ; Tue, 2 Nov 2004 21:11:12 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 10523 invoked from network); 2 Nov 2004 21:11:12 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Nov 2004 21:11:11 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA2LAuYP070948; Tue, 2 Nov 2004 16:11:08 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Xu Date: Tue, 2 Nov 2004 15:49:27 -0500 User-Agent: KMail/1.6.2 References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org> In-Reply-To: <4186C114.1000004@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411021549.27511.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:11:13 -0000 On Monday 01 November 2004 06:04 pm, David Xu wrote: > Not every important, I think I have another very important history > bug in hand, did you get my "fix famous libpthread conditional > variable race condition" mail ? :-) Oooo, can I test it please? We are still having problems with mono on HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 to libpthread but that seemed to make it worse. The problems seem to be that a signal handler is being run when the SYNCQ sflag is set (but the thread is not on a cv or a mutex queue), and the handler calls sem_post() which is supposed to be signal safe. sem_post() tries to lock a mutex and then bombs with the assertion failure. > David Xu > > Julian Elischer wrote: > > shuold there be an MFC date? > > > > David Xu wrote: > >> davidxu 2004-11-01 10:49:34 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libpthread/thread thr_private.h thr_sig.c Log: > >> Save cancelflags in signal frame, this fixes a problem that > >> a thread in pthread_cond_wait handled a signal can no longer > >> be canceled. > >> > >> Reviewed by: deischen > >> > >> Revision Changes Path > >> 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h > >> 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:11:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0B2A16A4FE for ; Tue, 2 Nov 2004 21:11:17 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id C835743D58 for ; Tue, 2 Nov 2004 21:11:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 2218 invoked from network); 2 Nov 2004 21:11:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Nov 2004 21:11:14 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA2LAuYQ070948; Tue, 2 Nov 2004 16:11:10 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Andre Oppermann Date: Tue, 2 Nov 2004 15:50:25 -0500 User-Agent: KMail/1.6.2 References: <200410291910.i9TJAlNf089795@repoman.freebsd.org> <200411011434.28141.jhb@FreeBSD.org> <41874ED1.662A02@freebsd.org> In-Reply-To: <41874ED1.662A02@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411021550.25945.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Alan Cox cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:11:18 -0000 On Tuesday 02 November 2004 04:09 am, Andre Oppermann wrote: > John Baldwin wrote: > > That's very easy, it's just critical_enter/exit() without the > > cpu_critical_*(). As mentioned in the SMP "design doc", the > > cpu_critical_*() are only needed for spin mutexes that are used in both > > top-half and bottom-half code (where ithreads are top-half, but "fast" > > interrupts and the code that schedules ithreads are bottom-half). I've > > thought about shoving cpu_critical_*() off into another API that spin > > mutexes would use, but that not all critical sections would use, this > > would give us critical sections that don't block interrupts, but just > > block preempting. For idle page zeroing though, I'm not sure we really > > want to use even a cheap critical section since it would still defer an > > ithread from running, and ithreads are more important than idle page > > zeroing. > > > > Note that you can easily pin the current thread to its current CPU via > > sched_pin/unpin() and that that works across preemptions. > > Does this involve any mutexes or so? This is very interesting for a couple > of cases in the network stack which uses a lot of heavy-weight mutexes at > the moment. No, pin/unpin just bounce a per-thread private counter with no locks needed. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:18:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8BC316A4CE; Tue, 2 Nov 2004 21:18:26 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29D4B43D2D; Tue, 2 Nov 2004 21:18:26 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.2] (vpn-client-2.marcuscom.com [10.2.1.2]) iA2LIDGo028179; Tue, 2 Nov 2004 16:18:13 -0500 (EST) (envelope-from marcus@marcuscom.com) Message-ID: <4187F99E.9090807@marcuscom.com> Date: Tue, 02 Nov 2004 16:18:22 -0500 From: Joe Marcus Clarke Organization: MarcusCom, Inc. User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org> <200411021549.27511.jhb@FreeBSD.org> In-Reply-To: <200411021549.27511.jhb@FreeBSD.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on creme-brulee.marcuscom.com cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: David Xu cc: cvs-all@freebsd.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:18:26 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 John Baldwin wrote: | On Monday 01 November 2004 06:04 pm, David Xu wrote: | |>Not every important, I think I have another very important history |>bug in hand, did you get my "fix famous libpthread conditional |>variable race condition" mail ? :-) | | | Oooo, can I test it please? We are still having problems with mono on HEAD | here at work. I tried merging the changes in uthread_cond.c 1.32 to | libpthread but that seemed to make it worse. The problems seem to be that a | signal handler is being run when the SYNCQ sflag is set (but the thread is | not on a cv or a mutex queue), and the handler calls sem_post() which is | supposed to be signal safe. sem_post() tries to lock a mutex and then bombs | with the assertion failure. This is a bit off-topic, but if you're working on Mono, you may want to talk with Tom McLaughlin . He's created a BSD# project, and has been working on the various Mono and C# ports for FreeBSD. I'm sure he would be very interested in any Mono work you're doing. Joe - -- PGP Key : http://www.marcuscom.com/pgp.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFBh/meb2iPiv4Uz4cRAtbnAJ9T2CcT+zpyWEtaPxLV2CfLEy69OACfUS/k 9djxtv7vIT0ngrpQ/EN4/BA= =U6OA -----END PGP SIGNATURE----- From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:24:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74B1D16A4CE; Tue, 2 Nov 2004 21:24:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52E7643D31; Tue, 2 Nov 2004 21:24:31 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2LOV8j052716; Tue, 2 Nov 2004 21:24:31 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2LOV80052715; Tue, 2 Nov 2004 21:24:31 GMT (envelope-from glebius) Message-Id: <200411022124.iA2LOV80052715@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 2 Nov 2004 21:24:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph netgraph.h ng_base.c ng_source.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:24:31 -0000 glebius 2004-11-02 21:24:31 UTC FreeBSD src repository Modified files: sys/netgraph netgraph.h ng_base.c ng_source.c Log: - Make ng_timeout() to use callout() interface instead of timeout(). - Remove callout-hacking from ng_untimeout(). Approved by: julian (mentor) MFC after: 1 month Revision Changes Path 1.45 +4 -3 src/sys/netgraph/netgraph.h 1.85 +17 -19 src/sys/netgraph/ng_base.c 1.20 +7 -8 src/sys/netgraph/ng_source.c From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:40:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 664) id E83AC16A4CF; Tue, 2 Nov 2004 21:40:14 +0000 (GMT) Date: Tue, 2 Nov 2004 21:40:14 +0000 From: David O'Brien To: John Baldwin Message-ID: <20041102214014.GA54727@hub.freebsd.org> References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> <200411011429.38840.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411011429.38840.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.10-STABLE Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:40:15 -0000 On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: > On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: > > I made 3-4 requestss, each one had an ACK that said, "sorry, right > > on it!" > > > > It's just not acceptable. > > Are you volunteering to be an re@ secretary ala wilko@? Why does every group now need a secretary? Maybe we just need more members on RE@ that are very active. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:43:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A734616A4D3 for ; Tue, 2 Nov 2004 21:43:56 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4ED343D5D for ; Tue, 2 Nov 2004 21:43:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 21045 invoked from network); 2 Nov 2004 21:43:55 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Nov 2004 21:43:55 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA2Lhnp6071228; Tue, 2 Nov 2004 16:43:51 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Joe Marcus Clarke Date: Tue, 2 Nov 2004 17:44:48 -0500 User-Agent: KMail/1.6.2 References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <200411021549.27511.jhb@FreeBSD.org> <4187F99E.9090807@marcuscom.com> In-Reply-To: <4187F99E.9090807@marcuscom.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411021744.48675.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: David Xu cc: cvs-all@FreeBSD.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:43:56 -0000 On Tuesday 02 November 2004 04:18 pm, Joe Marcus Clarke wrote: > John Baldwin wrote: > | On Monday 01 November 2004 06:04 pm, David Xu wrote: > |>Not every important, I think I have another very important history > |>bug in hand, did you get my "fix famous libpthread conditional > |>variable race condition" mail ? :-) > | > | Oooo, can I test it please? We are still having problems with mono on > > HEAD > > | here at work. I tried merging the changes in uthread_cond.c 1.32 to > | libpthread but that seemed to make it worse. The problems seem to be > > that a > > | signal handler is being run when the SYNCQ sflag is set (but the > > thread is > > | not on a cv or a mutex queue), and the handler calls sem_post() which is > | supposed to be signal safe. sem_post() tries to lock a mutex and then > > bombs > > | with the assertion failure. > > This is a bit off-topic, but if you're working on Mono, you may want to > talk with Tom McLaughlin . He's created a > BSD# project, and has been working on the various Mono and C# ports for > FreeBSD. I'm sure he would be very interested in any Mono work you're > doing. We're already using the BSD# stuff. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:44:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3E5016A4CE; Tue, 2 Nov 2004 21:44:49 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42E0E43D48; Tue, 2 Nov 2004 21:44:49 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA2LimMm003048; Tue, 2 Nov 2004 22:44:48 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: obrien@FreeBSD.org From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 02 Nov 2004 21:40:14 GMT." <20041102214014.GA54727@hub.freebsd.org> Date: Tue, 02 Nov 2004 22:44:48 +0100 Message-ID: <3047.1099431888@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:44:50 -0000 In message <20041102214014.GA54727@hub.freebsd.org>, "David O'Brien" writes: >On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: >> On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: >> > I made 3-4 requestss, each one had an ACK that said, "sorry, right >> > on it!" >> > >> > It's just not acceptable. >> >> Are you volunteering to be an re@ secretary ala wilko@? > >Why does every group now need a secretary? Maybe we just need more >members on RE@ that are very active. Having a member of a group act as secretary is an extremely widespread practice because it works so well. For one thing it helps bring about overview of the activities so you can see if one particular issue or maybe one particular person wastes a lot of time with frequent and unecessary protests, objections or just general complaining. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:46:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71FFA16A4CE; Tue, 2 Nov 2004 21:46:25 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AABB43D45; Tue, 2 Nov 2004 21:46:25 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA2LmALq016324; Tue, 2 Nov 2004 14:48:10 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41880075.70309@freebsd.org> Date: Tue, 02 Nov 2004 14:47:33 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: obrien@freebsd.org References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> <200411011429.38840.jhb@FreeBSD.org> <20041102214014.GA54727@hub.freebsd.org> In-Reply-To: <20041102214014.GA54727@hub.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: John Baldwin Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:46:25 -0000 David O'Brien wrote: > On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: > >>On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: >> >>>I made 3-4 requestss, each one had an ACK that said, "sorry, right >>>on it!" >>> >>>It's just not acceptable. >> >>Are you volunteering to be an re@ secretary ala wilko@? > > > Why does every group now need a secretary? Maybe we just need more > members on RE@ that are very active. > With all due respect, I'd like the members of the release engineering team to decide what is best for them, and have less armchair quarterbacking of what others think we need. Scott From owner-cvs-src@FreeBSD.ORG Tue Nov 2 21:58:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EE9F16A4CE; Tue, 2 Nov 2004 21:58:56 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id D801343D49; Tue, 2 Nov 2004 21:58:55 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.2] (vpn-client-2.marcuscom.com [10.2.1.2]) iA2LwhFx028686; Tue, 2 Nov 2004 16:58:44 -0500 (EST) (envelope-from marcus@marcuscom.com) Message-ID: <4188031C.80509@marcuscom.com> Date: Tue, 02 Nov 2004 16:58:52 -0500 From: Joe Marcus Clarke Organization: MarcusCom, Inc. User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <200411021549.27511.jhb@FreeBSD.org> <4187F99E.9090807@marcuscom.com> <200411021744.48675.jhb@FreeBSD.org> In-Reply-To: <200411021744.48675.jhb@FreeBSD.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on creme-brulee.marcuscom.com cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: David Xu cc: cvs-all@freebsd.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 21:58:56 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 John Baldwin wrote: | On Tuesday 02 November 2004 04:18 pm, Joe Marcus Clarke wrote: | |>John Baldwin wrote: |>| On Monday 01 November 2004 06:04 pm, David Xu wrote: |>|>Not every important, I think I have another very important history |>|>bug in hand, did you get my "fix famous libpthread conditional |>|>variable race condition" mail ? :-) |>| |>| Oooo, can I test it please? We are still having problems with mono on |> |>HEAD |> |>| here at work. I tried merging the changes in uthread_cond.c 1.32 to |>| libpthread but that seemed to make it worse. The problems seem to be |> |>that a |> |>| signal handler is being run when the SYNCQ sflag is set (but the |> |>thread is |> |>| not on a cv or a mutex queue), and the handler calls sem_post() which is |>| supposed to be signal safe. sem_post() tries to lock a mutex and then |> |>bombs |> |>| with the assertion failure. |> |>This is a bit off-topic, but if you're working on Mono, you may want to |>talk with Tom McLaughlin . He's created a |>BSD# project, and has been working on the various Mono and C# ports for |>FreeBSD. I'm sure he would be very interested in any Mono work you're |>doing. | | | We're already using the BSD# stuff. :) Great! Joe | - -- PGP Key : http://www.marcuscom.com/pgp.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFBiAMcb2iPiv4Uz4cRAomUAJ0blBBaHD6EYbFN4LKgET3RiV8OQACggKMH J8hN8oN5jnMaEEFMwNfr1bE= =NFOx -----END PGP SIGNATURE----- From owner-cvs-src@FreeBSD.ORG Tue Nov 2 22:15:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E803C16A4CE; Tue, 2 Nov 2004 22:15:55 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48AEA43D2D; Tue, 2 Nov 2004 22:15:55 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id B5951119B9; Tue, 2 Nov 2004 23:15:53 +0100 (CET) Date: Tue, 2 Nov 2004 23:15:53 +0100 From: "Simon L. Nielsen" To: Scott Long Message-ID: <20041102221552.GD750@zaphod.nitro.dk> References: <200410240537.i9O5bNh3068130@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7" Content-Disposition: inline In-Reply-To: <200410240537.i9O5bNh3068130@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/hptmv access601.h array.h atapi.h command.h gui_lib.c hptproc.c i386-elf.raid.o.uu ioctl.c mvSata.h mvStorageDev.h raid5n.h readme.txt vdevice.h src/sys/dev/hptmv entry.c global.h hptintf.h mv.c mvOs.h osbsd.h... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 22:15:56 -0000 --oJ71EGRlYNjSvfq7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.10.24 05:37:23 +0000, Scott Long wrote: > scottl 2004-10-24 05:37:23 UTC >=20 > FreeBSD src repository >=20 > Added files: > sys/contrib/dev/hptmv access601.h array.h atapi.h command.h=20 > gui_lib.c hptproc.c i386-elf.raid.o.uu=20 > ioctl.c mvSata.h mvStorageDev.h raid5n.h=20 > readme.txt vdevice.h=20 > sys/dev/hptmv entry.c global.h hptintf.h mv.c mvOs.h=20 > osbsd.h=20 > sys/modules/hptmv Makefile=20 > Log: > Import the HighPoint RocketRAID 182x driver. Thanks to HighPoint for > providing the original driver, and thanks to IronSystems for providing > hardware for testing. Any plans for a manual page for this driver... ? --=20 Simon L. Nielsen FreeBSD Documentation Team --oJ71EGRlYNjSvfq7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBiAcYh9pcDSc1mlERAiISAKCUyCkrpFWNoLzNTGFJ4I0NGiK1hACgpRGU 3NcCWcQiseIu2VOxDmyOk1s= =5NQh -----END PGP SIGNATURE----- --oJ71EGRlYNjSvfq7-- From owner-cvs-src@FreeBSD.ORG Tue Nov 2 22:22:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4352016A4CE; Tue, 2 Nov 2004 22:22:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 318C243D1D; Tue, 2 Nov 2004 22:22:23 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2MMN1c054893; Tue, 2 Nov 2004 22:22:23 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2MMMJs054892; Tue, 2 Nov 2004 22:22:22 GMT (envelope-from andre) Message-Id: <200411022222.iA2MMMJs054892@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 2 Nov 2004 22:22:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fw2.c tcp.h tcp_hostcache.c tcp_input.c tcp_output.c tcp_seq.h tcp_subr.c tcp_syncache.c tcp_timer.c tcp_usrreq.c tcp_var.h src/share/man/man4 tcp.4 src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 22:22:23 -0000 andre 2004-11-02 22:22:22 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c tcp.h tcp_hostcache.c tcp_input.c tcp_output.c tcp_seq.h tcp_subr.c tcp_syncache.c tcp_timer.c tcp_usrreq.c tcp_var.h share/man/man4 tcp.4 . UPDATING Log: Remove RFC1644 T/TCP support from the TCP side of the network stack. A complete rationale and discussion is given in this message and the resulting discussion: http://docs.freebsd.org/cgi/mid.cgi?4177C8AD.6060706 Note that this commit removes only the functional part of T/TCP from the tcp_* related functions in the kernel. Other features introduced with RFC1644 are left intact (socket layer changes, sendmsg(2) on connection oriented protocols) and are meant to be reused by a simpler and less intrusive reimplemention of the previous T/TCP functionality. Discussed on: -arch Revision Changes Path 1.377 +5 -0 src/UPDATING 1.51 +2 -13 src/share/man/man4/tcp.4 1.84 +0 -5 src/sys/netinet/ip_fw2.c 1.27 +0 -8 src/sys/netinet/tcp.h 1.8 +0 -60 src/sys/netinet/tcp_hostcache.c 1.254 +10 -202 src/sys/netinet/tcp_input.c 1.105 +2 -82 src/sys/netinet/tcp_output.c 1.23 +0 -3 src/sys/netinet/tcp_seq.h 1.206 +2 -39 src/sys/netinet/tcp_subr.c 1.68 +2 -90 src/sys/netinet/tcp_syncache.c 1.67 +2 -2 src/sys/netinet/tcp_timer.c 1.108 +4 -69 src/sys/netinet/tcp_usrreq.c 1.112 +0 -40 src/sys/netinet/tcp_var.h From owner-cvs-src@FreeBSD.ORG Tue Nov 2 22:31:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 397A616A4D4; Tue, 2 Nov 2004 22:31:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1704043D48; Tue, 2 Nov 2004 22:31:30 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2MVTdT055314; Tue, 2 Nov 2004 22:31:29 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2MVTZV055313; Tue, 2 Nov 2004 22:31:29 GMT (envelope-from simon) Message-Id: <200411022231.iA2MVTZV055313@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Tue, 2 Nov 2004 22:31:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/common dev.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 22:31:30 -0000 simon 2004-11-02 22:31:29 UTC FreeBSD src repository (doc committer) Modified files: release/doc/en_US.ISO8859-1/hardware/common dev.sgml Log: Add an "old-style" entry for the hptmv(4) until it gets a manual page. Suggested by: brueffer Revision Changes Path 1.260 +3 -0 src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml From owner-cvs-src@FreeBSD.ORG Tue Nov 2 23:22:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B299D16A4CE; Tue, 2 Nov 2004 23:22:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 914AC43D54; Tue, 2 Nov 2004 23:22:11 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2NMBAK057361; Tue, 2 Nov 2004 23:22:11 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2NMBSq057360; Tue, 2 Nov 2004 23:22:11 GMT (envelope-from simon) Message-Id: <200411022322.iA2NMBSq057360@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Tue, 2 Nov 2004 23:22:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/common dev.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 23:22:11 -0000 simon 2004-11-02 23:22:11 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/hardware/common dev.sgml Log: Add an "old-style" entry for the hptmv(4) until it gets a manual page. Approved by: re (scottl) Revision Changes Path 1.227.2.15 +3 -0 src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml From owner-cvs-src@FreeBSD.ORG Tue Nov 2 23:27:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 134CE16A4CF; Tue, 2 Nov 2004 23:27:44 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDE2E43D45; Tue, 2 Nov 2004 23:27:43 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) iA2NRfL6078117; Tue, 2 Nov 2004 23:27:42 GMT (envelope-from davidxu@freebsd.org) Message-ID: <418817ED.2040201@freebsd.org> Date: Wed, 03 Nov 2004 07:27:41 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org> <200411021549.27511.jhb@FreeBSD.org> In-Reply-To: <200411021549.27511.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Julian Elischer cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 23:27:44 -0000 John Baldwin wrote: >On Monday 01 November 2004 06:04 pm, David Xu wrote: > > >>Not every important, I think I have another very important history >>bug in hand, did you get my "fix famous libpthread conditional >>variable race condition" mail ? :-) >> >> > >Oooo, can I test it please? We are still having problems with mono on HEAD >here at work. I tried merging the changes in uthread_cond.c 1.32 to >libpthread but that seemed to make it worse. The problems seem to be that a >signal handler is being run when the SYNCQ sflag is set (but the thread is >not on a cv or a mutex queue), and the handler calls sem_post() which is >supposed to be signal safe. sem_post() tries to lock a mutex and then bombs >with the assertion failure. > > > You can try: http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff But it was not designed to fix the problem you have seen. :-) From owner-cvs-src@FreeBSD.ORG Tue Nov 2 23:40:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A63216A4E0; Tue, 2 Nov 2004 23:40:44 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9F2343D5A; Tue, 2 Nov 2004 23:40:43 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) iA2Neb8N009722; Tue, 2 Nov 2004 18:40:37 -0500 (EST) Date: Tue, 2 Nov 2004 18:40:37 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: David Xu In-Reply-To: <418817ED.2040201@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: src-committers@freebsd.org cc: Julian Elischer cc: John Baldwin Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 23:40:51 -0000 On Wed, 3 Nov 2004, David Xu wrote: > John Baldwin wrote: > > >On Monday 01 November 2004 06:04 pm, David Xu wrote: > > > > > >>Not every important, I think I have another very important history > >>bug in hand, did you get my "fix famous libpthread conditional > >>variable race condition" mail ? :-) > >> > >> > > > >Oooo, can I test it please? We are still having problems with mono on HEAD > >here at work. I tried merging the changes in uthread_cond.c 1.32 to > >libpthread but that seemed to make it worse. The problems seem to be that a > >signal handler is being run when the SYNCQ sflag is set (but the thread is > >not on a cv or a mutex queue), and the handler calls sem_post() which is > >supposed to be signal safe. sem_post() tries to lock a mutex and then bombs > >with the assertion failure. > > > > > > > You can try: > http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff > > But it was not designed to fix the problem you have seen. :-) I think if _kse_critical_leave() were replaced by _kcb_critical_leave() at around line 676 in thr_kern.c, that should fix the problem, no? There's no reason to do a yield check after leaving the scheduler, and the check for signals and cancellation is done right after that point before returning. -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Tue Nov 2 23:52:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F89F16A4CE; Tue, 2 Nov 2004 23:52:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2C1F43D4C; Tue, 2 Nov 2004 23:52:58 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2NqwNi058433; Tue, 2 Nov 2004 23:52:58 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA2Nqwxc058432; Tue, 2 Nov 2004 23:52:58 GMT (envelope-from scottl) Message-Id: <200411022352.iA2Nqwxc058432@repoman.freebsd.org> From: Scott Long Date: Tue, 2 Nov 2004 23:52:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/i386 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 23:52:59 -0000 scottl 2004-11-02 23:52:58 UTC FreeBSD src repository Modified files: sys/i386/i386 busdma_machdep.c Log: Streamline busdma a bit. Inline _bus_dmamap_load_buffer, optimize some tests, replace a passed td with a passed pmap to eliminate some deferences. Revision Changes Path 1.62 +19 -18 src/sys/i386/i386/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 00:18:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB17B16A4DB; Wed, 3 Nov 2004 00:18:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6658843D2D; Wed, 3 Nov 2004 00:18:51 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA30Ipvh059410; Wed, 3 Nov 2004 00:18:51 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA30Ipdf059409; Wed, 3 Nov 2004 00:18:51 GMT (envelope-from simon) Message-Id: <200411030018.iA30Ipdf059409@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Nov 2004 00:18:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/common dev.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 00:18:52 -0000 simon 2004-11-03 00:18:51 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_5_3) release/doc/en_US.ISO8859-1/hardware/common dev.sgml Log: MFC 1.260: Add an "old-style" entry for the hptmv(4) until it gets a manual page. Approved by: re (scottl) Revision Changes Path 1.227.2.14.2.1 +3 -0 src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml From owner-cvs-src@FreeBSD.ORG Wed Nov 3 01:52:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 653FC16A4CE; Wed, 3 Nov 2004 01:52:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5704643D4C; Wed, 3 Nov 2004 01:52:51 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA31qpw5069165; Wed, 3 Nov 2004 01:52:51 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA31qoLv069164; Wed, 3 Nov 2004 01:52:50 GMT (envelope-from iedowse) Message-Id: <200411030152.iA31qoLv069164@repoman.freebsd.org> From: Ian Dowse Date: Wed, 3 Nov 2004 01:52:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 01:52:51 -0000 iedowse 2004-11-03 01:52:50 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h Log: Merge recent USB2/EHCI related changes from NetBSD: o Reduce the interrupt delay to 2 microframes. o Follow the spec more closely when updating the overlay qTD in the QH. o No need to generate an interrupt at the data part of a control transfer, it's generated by the status transfer. o Make sure to update the data toggle on short transfers. o Turn the printf about needing toggle update into a DPRINTF. o Keep track of what high speed port (if any) a device belongs to so we can set the transaction translator fields for the transfer. o Verbosely refuse to open low/full speed pipes that depend on unimplemented split transaction support. o Fix various typos in comments. Obtained from: NetBSD Revision Changes Path 1.16 +119 -80 src/sys/dev/usb/ehci.c 1.6 +2 -1 src/sys/dev/usb/ehcireg.h 1.64 +44 -4 src/sys/dev/usb/uhub.c 1.73 +23 -8 src/sys/dev/usb/usb_subr.c 1.42 +6 -1 src/sys/dev/usb/usbdivar.h From owner-cvs-src@FreeBSD.ORG Wed Nov 3 02:01:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE92D16A4CE; Wed, 3 Nov 2004 02:01:09 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21F6143D53; Wed, 3 Nov 2004 02:01:09 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 0630C652EC; Wed, 3 Nov 2004 02:01:07 +0000 (GMT) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 90310-02; Wed, 3 Nov 2004 02:01:06 +0000 (GMT) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id D29EF65292; Wed, 3 Nov 2004 02:01:05 +0000 (GMT) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 561166252; Tue, 2 Nov 2004 18:00:52 -0800 (PST) Date: Tue, 2 Nov 2004 18:00:52 -0800 From: Bruce M Simpson To: Ian Dowse Message-ID: <20041103020052.GC32562@dhcp120.icir.org> Mail-Followup-To: Ian Dowse , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200411030152.iA31qoLv069164@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411030152.iA31qoLv069164@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 02:01:09 -0000 On Wed, Nov 03, 2004 at 01:52:50AM +0000, Ian Dowse wrote: > Log: > Merge recent USB2/EHCI related changes from NetBSD: > o Reduce the interrupt delay to 2 microframes. > o Follow the spec more closely when updating the overlay qTD in the QH. > o No need to generate an interrupt at the data part of a control > transfer, it's generated by the status transfer. > o Make sure to update the data toggle on short transfers. > o Turn the printf about needing toggle update into a DPRINTF. > o Keep track of what high speed port (if any) a device belongs to > so we can set the transaction translator fields for the transfer. > o Verbosely refuse to open low/full speed pipes that depend on > unimplemented split transaction support. This looks very, very promising. BMS From owner-cvs-src@FreeBSD.ORG Wed Nov 3 06:52:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC65316A4CE; Wed, 3 Nov 2004 06:52:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C04243D48; Wed, 3 Nov 2004 06:52:40 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA36qeur084574; Wed, 3 Nov 2004 06:52:40 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA36qeOO084573; Wed, 3 Nov 2004 06:52:40 GMT (envelope-from yar) Message-Id: <200411030652.iA36qeOO084573@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 3 Nov 2004 06:52:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/ftpd ftpd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 06:52:40 -0000 yar 2004-11-03 06:52:40 UTC FreeBSD src repository Modified files: libexec/ftpd ftpd.c Log: Fix logxfer() by using realpath(3) instead of playing with getwd(3). Previously logxfer() used to record bogus pathnames to the log in some cases, namely, when cwd was / or "name" was absolute. Noticed by: Nick Leuta MFC after: 2 weeks Revision Changes Path 1.175 +8 -4 src/libexec/ftpd/ftpd.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:05:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15BB716A4CE; Wed, 3 Nov 2004 09:05:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA7F443D4C; Wed, 3 Nov 2004 09:05:56 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA395u5n095158; Wed, 3 Nov 2004 09:05:56 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA395uFC095157; Wed, 3 Nov 2004 09:05:56 GMT (envelope-from phk) Message-Id: <200411030905.iA395uFC095157@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:05:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys buf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:05:57 -0000 phk 2004-11-03 09:05:56 UTC FreeBSD src repository Modified files: sys/sys buf.h Log: Make the KASSERTS in bstrategy() stop claiming to be bwrite(). Spotted by: delphij Revision Changes Path 1.176 +4 -3 src/sys/sys/buf.h From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:06:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D8CA16A4CE; Wed, 3 Nov 2004 09:06:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E27F643D58; Wed, 3 Nov 2004 09:06:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA396jd8095258; Wed, 3 Nov 2004 09:06:45 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA396jB4095257; Wed, 3 Nov 2004 09:06:45 GMT (envelope-from phk) Message-Id: <200411030906.iA396jB4095257@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:06:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:06:46 -0000 phk 2004-11-03 09:06:45 UTC FreeBSD src repository Modified files: sys/kern subr_bus.c Log: Don't print the singularly unhelpful message: unknown: not probled (disabled) During verbose boot. Revision Changes Path 1.163 +1 -1 src/sys/kern/subr_bus.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:07:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E57C16A4CE; Wed, 3 Nov 2004 09:07:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E11D043D1F; Wed, 3 Nov 2004 09:07:44 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA397iiT095311; Wed, 3 Nov 2004 09:07:44 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA397iHp095310; Wed, 3 Nov 2004 09:07:44 GMT (envelope-from phk) Message-Id: <200411030907.iA397iHp095310@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:07:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/isa vga_isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:07:45 -0000 phk 2004-11-03 09:07:44 UTC FreeBSD src repository Modified files: sys/isa vga_isa.c Log: Stop printing the VGA registers during verbose boot, in order to not needlessly overflow the msgbuffer. Can be reenabled if somebody ever takes an interest in syscons again. Revision Changes Path 1.31 +1 -1 src/sys/isa/vga_isa.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:08:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B93D816A4CE; Wed, 3 Nov 2004 09:08:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9949C43D2F; Wed, 3 Nov 2004 09:08:10 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA398A92095351; Wed, 3 Nov 2004 09:08:10 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA398A9d095350; Wed, 3 Nov 2004 09:08:10 GMT (envelope-from phk) Message-Id: <200411030908.iA398A9d095350@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:08:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_slice.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:08:10 -0000 phk 2004-11-03 09:08:10 UTC FreeBSD src repository Modified files: sys/geom geom_slice.c Log: Stop wasting a bootverbose line on all geom slices. Revision Changes Path 1.57 +1 -1 src/sys/geom/geom_slice.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:08:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9B2D16A4CF; Wed, 3 Nov 2004 09:08:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B960E43D46; Wed, 3 Nov 2004 09:08:33 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA398XME095389; Wed, 3 Nov 2004 09:08:33 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA398XDd095388; Wed, 3 Nov 2004 09:08:33 GMT (envelope-from phk) Message-Id: <200411030908.iA398XDd095388@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:08:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_mbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:08:34 -0000 phk 2004-11-03 09:08:33 UTC FreeBSD src repository Modified files: sys/geom geom_mbr.c Log: Stop dumping the MBR entries under bootverbose Revision Changes Path 1.61 +2 -2 src/sys/geom/geom_mbr.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 09:09:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1B9916A4CE; Wed, 3 Nov 2004 09:09:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C24C243D46; Wed, 3 Nov 2004 09:09:13 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA399DiN095427; Wed, 3 Nov 2004 09:09:13 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA399DqU095426; Wed, 3 Nov 2004 09:09:13 GMT (envelope-from phk) Message-Id: <200411030909.iA399DqU095426@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 09:09:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/acpica acpi_timer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 09:09:14 -0000 phk 2004-11-03 09:09:13 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_timer.c Log: Make the bootverbose output from qualitydetermination of the ACPI timer take up only one line. Revision Changes Path 1.37 +6 -5 src/sys/dev/acpica/acpi_timer.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 10:02:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6639516A4CE; Wed, 3 Nov 2004 10:02:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 44DC443D1D; Wed, 3 Nov 2004 10:02:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3A2pU9097161; Wed, 3 Nov 2004 10:02:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3A2pcA097160; Wed, 3 Nov 2004 10:02:51 GMT (envelope-from rwatson) Message-Id: <200411031002.iA3A2pcA097160@repoman.freebsd.org> From: Robert Watson Date: Wed, 3 Nov 2004 10:02:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/random randomdev_soft.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 10:02:51 -0000 rwatson 2004-11-03 10:02:51 UTC FreeBSD src repository Modified files: sys/dev/random randomdev_soft.c Log: (1) Move from O(n) list copies to O(1) list concatenation, which is supported for STAILQ via STAILQ_CONCAT(). (2) Maintain a count of the number of entries in the thread-local entropy fifo so that we can keep the other fifo counts in synch. MFC after: 3 weeks MFC with: randomdev_soft.c revisions 1.5 and 1.6 Suggested by: jhb (1) Revision Changes Path 1.7 +11 -14 src/sys/dev/random/randomdev_soft.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 10:10:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C669A16A4D5; Wed, 3 Nov 2004 10:10:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A56EC43D46; Wed, 3 Nov 2004 10:10:09 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3AA9MW097377; Wed, 3 Nov 2004 10:10:09 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3AA9xA097376; Wed, 3 Nov 2004 10:10:09 GMT (envelope-from hrs) Message-Id: <200411031010.iA3AA9xA097376@repoman.freebsd.org> From: Hiroki Sato Date: Wed, 3 Nov 2004 10:10:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 10:10:09 -0000 hrs 2004-11-03 10:10:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: the SMP option disabled in the GENERIC kernel. Approved by: re (implicitly) Revision Changes Path 1.69.2.5 +8 -0 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Wed Nov 3 10:12:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FD0916A4CE; Wed, 3 Nov 2004 10:12:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F60E43D2F; Wed, 3 Nov 2004 10:12:52 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3ACp3N097505; Wed, 3 Nov 2004 10:12:51 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3ACp88097504; Wed, 3 Nov 2004 10:12:51 GMT (envelope-from hrs) Message-Id: <200411031012.iA3ACp88097504@repoman.freebsd.org> From: Hiroki Sato Date: Wed, 3 Nov 2004 10:12:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 10:12:52 -0000 hrs 2004-11-03 10:12:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Fix a lot of grammatical errors. Submitted by: Eric van Gyzen (vangyzen at stat dot duke dot edu) Approved by: re Revision Changes Path 1.761.2.12.2.3 +119 -112 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed Nov 3 12:19:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 543BA16A4CF; Wed, 3 Nov 2004 12:19:43 +0000 (GMT) Date: Wed, 3 Nov 2004 12:19:43 +0000 From: Alexey Dokuchaev To: Ian Dowse Message-ID: <20041103121943.GA96866@FreeBSD.org> References: <200411030152.iA31qoLv069164@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200411030152.iA31qoLv069164@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 12:19:43 -0000 On Wed, Nov 03, 2004 at 01:52:50AM +0000, Ian Dowse wrote: > iedowse 2004-11-03 01:52:50 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c > usbdivar.h > Log: > Merge recent USB2/EHCI related changes from NetBSD: > o Reduce the interrupt delay to 2 microframes. > o Follow the spec more closely when updating the overlay qTD in the QH. > o No need to generate an interrupt at the data part of a control > transfer, it's generated by the status transfer. > o Make sure to update the data toggle on short transfers. > o Turn the printf about needing toggle update into a DPRINTF. > o Keep track of what high speed port (if any) a device belongs to > so we can set the transaction translator fields for the transfer. > o Verbosely refuse to open low/full speed pipes that depend on > unimplemented split transaction support. > o Fix various typos in comments. > > Obtained from: NetBSD It had been mentioned that OpenBSD folks also had done some work on ehci. Is there any chance you (or someone else) might take a look at those? Thanks for taking care of USB2 under FreeBSD btw! ;-) ./danfe From owner-cvs-src@FreeBSD.ORG Wed Nov 3 12:40:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 517DC16A4CE; Wed, 3 Nov 2004 12:40:39 +0000 (GMT) Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B7DD43D3F; Wed, 3 Nov 2004 12:40:38 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])iA3CeYrc021253; Wed, 3 Nov 2004 14:40:36 +0200 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) iA3CeYPx034511; Wed, 3 Nov 2004 14:40:34 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost)iA3CeYRE034510; Wed, 3 Nov 2004 14:40:34 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Wed, 3 Nov 2004 14:40:33 +0200 From: Giorgos Keramidas To: Stefan Farfeleder Message-ID: <20041103124033.GA34455@orion.daedalusnetworks.priv> References: <200411011632.iA1GWA8q030777@repoman.freebsd.org> <20041101170748.GA81210@wombat.fafoe.narf.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041101170748.GA81210@wombat.fafoe.narf.at> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: "David E. O'Brien" Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 12:40:39 -0000 On 2004-11-01 18:07, Stefan Farfeleder wrote: > On Mon, Nov 01, 2004 at 04:32:10PM +0000, David E. O'Brien wrote: > > obrien 2004-11-01 16:32:10 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.sbin/sysinstall config.c > > Log: > > fix typo in generated /etc/exports: escape all ' > > > - vsystem("echo '# Note that BSD's export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > > + vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > > You need two backslashes here; \' is equivalent to ' inside string literals. I've discovered after submitting the change David committed that \' is not enough to quote single quotes in strings quoted with single quotes too. The correct quoting would be something like: vsystem("echo '# Note that BSD'\''s export syntax is \"host-centric\" vs. Sun'\''s \"FS-centric\" one.' >> /etc/exports"); Any chance for a fix of the fix? :-) From owner-cvs-src@FreeBSD.ORG Wed Nov 3 13:35:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5F6B16A4CE; Wed, 3 Nov 2004 13:35:08 +0000 (GMT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 64DA543D41; Wed, 3 Nov 2004 13:35:07 +0000 (GMT) (envelope-from iedowse@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 3 Nov 2004 13:35:06 +0000 (GMT) To: Alexey Dokuchaev In-Reply-To: Your message of "Wed, 03 Nov 2004 12:19:43 GMT." <20041103121943.GA96866@FreeBSD.org> Date: Wed, 03 Nov 2004 13:35:06 +0000 From: Ian Dowse Message-ID: <200411031335.aa39452@salmon.maths.tcd.ie> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 13:35:09 -0000 In message <20041103121943.GA96866@FreeBSD.org>, Alexey Dokuchaev writes: >It had been mentioned that OpenBSD folks also had done some work on ehci. >Is there any chance you (or someone else) might take a look at those? My previous suspend/resume commits to EHCI covered most of OpenBSD's changes, and OpenBSD has since incorporated NetBSD's work too (the interrupt pipe support that went into OpenBSD a couple of weeks ago was based on an earlier version of the patch I committed to FreeBSD in August). There has been a lot of cross-syncing of EHCI code between the BSDs recently so the EHCI bits should now be pretty much the same across NetBSD, OpenBSD and FreeBSD. Ian From owner-cvs-src@FreeBSD.ORG Wed Nov 3 13:40:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3A8316A4CE; Wed, 3 Nov 2004 13:40:14 +0000 (GMT) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F9A043D4C; Wed, 3 Nov 2004 13:40:14 +0000 (GMT) (envelope-from mark@grondar.org) Received: from storm.uk.FreeBSD.org (uucp@localhost [127.0.0.1]) by storm.uk.FreeBSD.org (8.13.1/8.13.1) with ESMTP id iA3DeCKn078919; Wed, 3 Nov 2004 13:40:12 GMT (envelope-from mark@grondar.org) Received: (from uucp@localhost)iA3DeBad078918; Wed, 3 Nov 2004 13:40:11 GMT (envelope-from mark@grondar.org) Received: from grondar.org (localhost [127.0.0.1]) by grovel.grondar.org (8.13.1/8.13.1) with ESMTP id iA3Db6Pv004623; Wed, 3 Nov 2004 13:37:06 GMT (envelope-from mark@grondar.org) Message-Id: <200411031337.iA3Db6Pv004623@grovel.grondar.org> To: Robert Watson From: Mark Murray In-Reply-To: Your message of "Wed, 03 Nov 2004 10:02:51 GMT." <200411031002.iA3A2pcA097160@repoman.freebsd.org> Date: Wed, 03 Nov 2004 13:37:06 +0000 Sender: mark@grondar.org cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/random randomdev_soft.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 13:40:14 -0000 Robert Watson writes: > (1) Move from O(n) list copies to O(1) list concatenation, which is > supported for STAILQ via STAILQ_CONCAT(). > > (2) Maintain a count of the number of entries in the thread-local entropy > fifo so that we can keep the other fifo counts in synch. Thanks! M -- Mark Murray iumop ap!sdn w,I idlaH From owner-cvs-src@FreeBSD.ORG Wed Nov 3 13:46:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F389716A4CE; Wed, 3 Nov 2004 13:46:22 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EB7743D53; Wed, 3 Nov 2004 13:46:22 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 1C2015314; Wed, 3 Nov 2004 14:46:21 +0100 (CET) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 528A15310; Wed, 3 Nov 2004 14:46:14 +0100 (CET) Received: by dwp.des.no (Postfix, from userid 2602) id 1CE43B85E; Wed, 3 Nov 2004 14:46:14 +0100 (CET) To: Ian Dowse References: <200411030152.iA31qoLv069164@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Wed, 03 Nov 2004 14:46:14 +0100 In-Reply-To: <200411030152.iA31qoLv069164@repoman.freebsd.org> (Ian Dowse's message of "Wed, 3 Nov 2004 01:52:50 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 13:46:23 -0000 Ian Dowse writes: > Log: > Merge recent USB2/EHCI related changes from NetBSD: It's great to see that someone is picking up the baton! Are you also going to have a look at Joe's USB PRs? I took a quick look last week, and it seems to me that some of them at least should be fairly easy to close. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Wed Nov 3 14:11:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DCE116A4CE; Wed, 3 Nov 2004 14:11:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F184743D49; Wed, 3 Nov 2004 14:11:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3EBIWM012135; Wed, 3 Nov 2004 14:11:18 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3EBIqL012134; Wed, 3 Nov 2004 14:11:18 GMT (envelope-from phk) Message-Id: <200411031411.iA3EBIqL012134@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 14:11:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 14:11:19 -0000 phk 2004-11-03 14:11:18 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon that we need to tell people about every cable in the network anymore. It can be enabled for debugging purposes with "boot -v". Revision Changes Path 1.51 +8 -6 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 14:33:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84C0616A4CF; Wed, 3 Nov 2004 14:33:56 +0000 (GMT) Received: from eddie.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 384AB43D4C; Wed, 3 Nov 2004 14:33:56 +0000 (GMT) (envelope-from simon@eddie.nitro.dk) Received: by eddie.nitro.dk (Postfix, from userid 1000) id 77331119CD9; Wed, 3 Nov 2004 15:33:55 +0100 (CET) Date: Wed, 3 Nov 2004 15:33:55 +0100 From: "Simon L. Nielsen" To: Poul-Henning Kamp Message-ID: <20041103143355.GD58226@eddie.nitro.dk> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY" Content-Disposition: inline In-Reply-To: <200411031411.iA3EBIqL012134@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 14:33:56 -0000 --Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.11.03 14:11:18 +0000, Poul-Henning Kamp wrote: > phk 2004-11-03 14:11:18 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/em if_em.c=20 > Log: > Put the "Link is up/down" printfs behind bootverbose. gigE is not so u= ncommon > that we need to tell people about every cable in the network anymore. = It can > be enabled for debugging purposes with "boot -v". Thanks! :-) --=20 Simon L. Nielsen FreeBSD Documentation Team --Bu8it7iiRSEf40bY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBiOxSh9pcDSc1mlERAgeOAKCKGy0S7bILWn4cdj3S/q+9guBe+QCeMmPM k6EISzFem4A4j6H/uj2DQgE= =7OkO -----END PGP SIGNATURE----- --Bu8it7iiRSEf40bY-- From owner-cvs-src@FreeBSD.ORG Wed Nov 3 15:12:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4B6516A4CE; Wed, 3 Nov 2004 15:12:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D6BA43D5E; Wed, 3 Nov 2004 15:12:18 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3FCIiY014074; Wed, 3 Nov 2004 15:12:18 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3FCIMh014073; Wed, 3 Nov 2004 15:12:18 GMT (envelope-from iedowse) Message-Id: <200411031512.iA3FCIMh014073@repoman.freebsd.org> From: Ian Dowse Date: Wed, 3 Nov 2004 15:12:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb ehci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 15:12:19 -0000 iedowse 2004-11-03 15:12:18 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c Log: The ehci_dump() function shouldn't be declared static, as it is just a convenience function to be called from debuggers that gets compiled in when EHCI_DEBUG is defined. Move its declaration to make this more obvious. Revision Changes Path 1.17 +1 -1 src/sys/dev/usb/ehci.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 15:23:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03B5D16A4CE; Wed, 3 Nov 2004 15:23:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7B7C43D5E; Wed, 3 Nov 2004 15:23:11 +0000 (GMT) (envelope-from paul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3FNBqG014505; Wed, 3 Nov 2004 15:23:11 GMT (envelope-from paul@repoman.freebsd.org) Received: (from paul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3FNBMl014504; Wed, 3 Nov 2004 15:23:11 GMT (envelope-from paul) Message-Id: <200411031523.iA3FNBMl014504@repoman.freebsd.org> From: Paul Richards Date: Wed, 3 Nov 2004 15:23:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tail forward.c misc.c read.c reverse.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 15:23:12 -0000 paul 2004-11-03 15:23:11 UTC FreeBSD src repository Modified files: usr.bin/tail forward.c misc.c read.c reverse.c tail.c Log: Convert to ANSI style function definitions. Revision Changes Path 1.34 +1 -5 src/usr.bin/tail/forward.c 1.8 +2 -6 src/usr.bin/tail/misc.c 1.11 +2 -6 src/usr.bin/tail/read.c 1.17 +3 -12 src/usr.bin/tail/reverse.c 1.16 +4 -2 src/usr.bin/tail/tail.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:22:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 355FA16A4CE; Wed, 3 Nov 2004 16:22:01 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id B380043D55; Wed, 3 Nov 2004 16:21:56 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3GNhcv020282; Wed, 3 Nov 2004 09:23:43 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <418905E5.1050605@freebsd.org> Date: Wed, 03 Nov 2004 09:23:01 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> In-Reply-To: <200411031411.iA3EBIqL012134@repoman.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:22:01 -0000 Poul-Henning Kamp wrote: > phk 2004-11-03 14:11:18 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon > that we need to tell people about every cable in the network anymore. It can > be enabled for debugging purposes with "boot -v". > > Revision Changes Path > 1.51 +8 -6 src/sys/dev/em/if_em.c I think that in general we can start eyeing a lot of similar verbosity in all of our drivers, both at boot and at runtime. For example most nic drivers print out their MAC and all of their possible negotiation rates on attach. This same info can be obtained from ifconfig. Why clutter the boot with it? Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:28:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C58416A4CE; Wed, 3 Nov 2004 16:28:07 +0000 (GMT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 172C043D55; Wed, 3 Nov 2004 16:28:07 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id iA3GS6od049336; Wed, 3 Nov 2004 08:28:06 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id iA3GS6be049335; Wed, 3 Nov 2004 08:28:06 -0800 (PST) (envelope-from rizzo) Date: Wed, 3 Nov 2004 08:28:06 -0800 From: Luigi Rizzo To: Scott Long Message-ID: <20041103082806.C49241@xorpc.icir.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <418905E5.1050605@freebsd.org>; from scottl@FreeBSD.org on Wed, Nov 03, 2004 at 09:23:01AM -0700 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:28:07 -0000 On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: ... > I think that in general we can start eyeing a lot of similar verbosity > in all of our drivers, both at boot and at runtime. For example most > nic drivers print out their MAC and all of their possible negotiation > rates on attach. This same info can be obtained from ifconfig. Why > clutter the boot with it? because sometimes you might need to enable some MAC-based filter before you have a chance to access the box. e.g. to set dhcp/bootp anbd the like. A bit of verbosity is useful, you can always switch to splash screens if you don't like them. I think the link-up/link-down thing is different because it happens not just at boot but also whenever the link status changes (e.g. when a spanning tree on a switch detects a reconfiguration), and this is annoying on the console. cheers luigi From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:32:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98B6616A4CE; Wed, 3 Nov 2004 16:32:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78CC643D5E; Wed, 3 Nov 2004 16:32:55 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3GWtQ7017181; Wed, 3 Nov 2004 16:32:55 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3GWteI017180; Wed, 3 Nov 2004 16:32:55 GMT (envelope-from pjd) Message-Id: <200411031632.iA3GWteI017180@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 3 Nov 2004 16:32:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/raid3 graid3.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:32:55 -0000 pjd 2004-11-03 16:32:55 UTC FreeBSD src repository Modified files: sbin/geom/class/raid3 graid3.8 Log: Remove one more redundant 'not'. Revision Changes Path 1.6 +1 -1 src/sbin/geom/class/raid3/graid3.8 From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:36:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02B3316A4CE; Wed, 3 Nov 2004 16:36:35 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9126D43D66; Wed, 3 Nov 2004 16:36:34 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3GcOu3020383; Wed, 3 Nov 2004 09:38:24 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41890956.2030705@freebsd.org> Date: Wed, 03 Nov 2004 09:37:42 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Luigi Rizzo References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> In-Reply-To: <20041103082806.C49241@xorpc.icir.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:36:35 -0000 Luigi Rizzo wrote: > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: > ... > >>I think that in general we can start eyeing a lot of similar verbosity >>in all of our drivers, both at boot and at runtime. For example most >>nic drivers print out their MAC and all of their possible negotiation >>rates on attach. This same info can be obtained from ifconfig. Why >>clutter the boot with it? > > > because sometimes you might need to enable some MAC-based filter > before you have a chance to access the box. e.g. to set dhcp/bootp > anbd the like. > > A bit of verbosity is useful, you can always switch to splash screens > if you don't like them. > > I think the link-up/link-down thing is different because it > happens not just at boot but also whenever the link status > changes (e.g. when a spanning tree on a switch detects a > reconfiguration), and this is annoying on the console. > > cheers > luigi > I'm not saying that these things should be removed, just places under bootverbose. Situations like what you are saying are rare and/or one-time occurances. And if you look at drivers like if_ath(no offense meant towards Sam): ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on cardbus1 ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 ath0: Ethernet address: 00:0c:41:15:5f:94 ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps The last 4 lines could easily go under bootverbose. I'd even wager that the second line can be hidden also; it provides little useful information for a normal boot. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:39:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43B6616A4CE; Wed, 3 Nov 2004 16:39:23 +0000 (GMT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F5A343D41; Wed, 3 Nov 2004 16:39:23 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id iA3GdNns049537; Wed, 3 Nov 2004 08:39:23 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id iA3GdNUB049536; Wed, 3 Nov 2004 08:39:23 -0800 (PST) (envelope-from rizzo) Date: Wed, 3 Nov 2004 08:39:23 -0800 From: Luigi Rizzo To: Scott Long Message-ID: <20041103083922.A49431@xorpc.icir.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <41890956.2030705@freebsd.org>; from scottl@FreeBSD.org on Wed, Nov 03, 2004 at 09:37:42AM -0700 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:39:23 -0000 On Wed, Nov 03, 2004 at 09:37:42AM -0700, Scott Long wrote: ... > > because sometimes you might need to enable some MAC-based filter > > before you have a chance to access the box. e.g. to set dhcp/bootp > > anbd the like. ... > > I think the link-up/link-down thing is different because it > > happens not just at boot but also whenever the link status > > changes (e.g. when a spanning tree on a switch detects a ... > bootverbose. Situations like what you are saying are rare and/or > one-time occurances. And if you look at drivers like if_ath(no offense ok, but that one time is precisely when you have little or no chance to intervene. Anyways, as long as you keep the MAC printout on by default i am happy :) cheers luigi From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:49:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B38916A4CE; Wed, 3 Nov 2004 16:49:02 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6969B43D1D; Wed, 3 Nov 2004 16:49:01 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA3GmY90040792; Wed, 3 Nov 2004 09:48:34 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 03 Nov 2004 09:48:41 -0700 (MST) Message-Id: <20041103.094841.89130476.imp@bsdimp.com> To: scottl@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <418905E5.1050605@freebsd.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: phk@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:49:02 -0000 In message: <418905E5.1050605@freebsd.org> Scott Long writes: : Poul-Henning Kamp wrote: : > phk 2004-11-03 14:11:18 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/em if_em.c : > Log: : > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon : > that we need to tell people about every cable in the network anymore. It can : > be enabled for debugging purposes with "boot -v". : > : > Revision Changes Path : > 1.51 +8 -6 src/sys/dev/em/if_em.c : : I think that in general we can start eyeing a lot of similar verbosity : in all of our drivers, both at boot and at runtime. For example most : nic drivers print out their MAC and all of their possible negotiation : rates on attach. This same info can be obtained from ifconfig. Why : clutter the boot with it? Well, you can't get all the info you need from ifconfig. If you want to know WHICH nic is in WHAT slot, it is a lot easier to get that from the one liner printed on boot (especially when trying to troubleshoot things) than to get it from ifconfig + dmesg. I think that's useful to continue to have there. I do agree that the rate thing of the wireless drivers is excessive, as is many of the rate things. fwohci likely can use some trimming as well, even in the non-verbose mode. The CAM messages are the only messages in FreeBSD more verbose than VMS :-) Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:52:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F42316A4CE; Wed, 3 Nov 2004 16:52:08 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4F4B43D49; Wed, 3 Nov 2004 16:52:07 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA3GncSo040805; Wed, 3 Nov 2004 09:49:38 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 03 Nov 2004 09:49:45 -0700 (MST) Message-Id: <20041103.094945.22504907.imp@bsdimp.com> To: scottl@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <41890956.2030705@freebsd.org> References: <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: rizzo@icir.org cc: src-committers@FreeBSD.ORG cc: phk@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:52:08 -0000 In message: <41890956.2030705@freebsd.org> Scott Long writes: : Luigi Rizzo wrote: : > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: : > ... : > : >>I think that in general we can start eyeing a lot of similar verbosity : >>in all of our drivers, both at boot and at runtime. For example most : >>nic drivers print out their MAC and all of their possible negotiation : >>rates on attach. This same info can be obtained from ifconfig. Why : >>clutter the boot with it? : > : > : > because sometimes you might need to enable some MAC-based filter : > before you have a chance to access the box. e.g. to set dhcp/bootp : > anbd the like. : > : > A bit of verbosity is useful, you can always switch to splash screens : > if you don't like them. : > : > I think the link-up/link-down thing is different because it : > happens not just at boot but also whenever the link status : > changes (e.g. when a spanning tree on a switch detects a : > reconfiguration), and this is annoying on the console. : > : > cheers : > luigi : > : : I'm not saying that these things should be removed, just places under : bootverbose. Situations like what you are saying are rare and/or : one-time occurances. And if you look at drivers like if_ath(no offense : meant towards Sam): : : ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on : cardbus1 : ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 : ath0: Ethernet address: 00:0c:41:15:5f:94 : ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps : ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps : ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps : 24Mbps 36Mbps 48Mbps 54Mbps : ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps : : The last 4 lines could easily go under bootverbose. I'd even wager that : the second line can be hidden also; it provides little useful : information for a normal boot. Agreed. The second line should likely be exported as a series of sysctls under dev.ath.0.mac_version, dev.ath.0.phy_version, etc if they are important. Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:52:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EB2016A4CE; Wed, 3 Nov 2004 16:52:53 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DBC243D48; Wed, 3 Nov 2004 16:52:52 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3Gsegf020515; Wed, 3 Nov 2004 09:54:41 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41890D26.5050101@freebsd.org> Date: Wed, 03 Nov 2004 09:53:58 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103.094841.89130476.imp@bsdimp.com> In-Reply-To: <20041103.094841.89130476.imp@bsdimp.com> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: phk@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:52:53 -0000 M. Warner Losh wrote: > In message: <418905E5.1050605@freebsd.org> > Scott Long writes: > : Poul-Henning Kamp wrote: > : > phk 2004-11-03 14:11:18 UTC > : > > : > FreeBSD src repository > : > > : > Modified files: > : > sys/dev/em if_em.c > : > Log: > : > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon > : > that we need to tell people about every cable in the network anymore. It can > : > be enabled for debugging purposes with "boot -v". > : > > : > Revision Changes Path > : > 1.51 +8 -6 src/sys/dev/em/if_em.c > : > : I think that in general we can start eyeing a lot of similar verbosity > : in all of our drivers, both at boot and at runtime. For example most > : nic drivers print out their MAC and all of their possible negotiation > : rates on attach. This same info can be obtained from ifconfig. Why > : clutter the boot with it? > > Well, you can't get all the info you need from ifconfig. If you want > to know WHICH nic is in WHAT slot, it is a lot easier to get that from > the one liner printed on boot (especially when trying to troubleshoot > things) than to get it from ifconfig + dmesg. I think that's useful > to continue to have there. > > I do agree that the rate thing of the wireless drivers is excessive, > as is many of the rate things. > > fwohci likely can use some trimming as well, even in the non-verbose > mode. > > The CAM messages are the only messages in FreeBSD more verbose than > VMS :-) > > Warner I've looked at the CAM messages, yes. I'm not calling for immediate action, just saying that it's something to keep an eye on and think about. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 3 17:21:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58BF916A4CE; Wed, 3 Nov 2004 17:21:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3876043D41; Wed, 3 Nov 2004 17:21:13 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3HLDYm025260; Wed, 3 Nov 2004 17:21:13 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3HLD72025259; Wed, 3 Nov 2004 17:21:13 GMT (envelope-from mlaier) Message-Id: <200411031721.iA3HLD72025259@repoman.freebsd.org> From: Max Laier Date: Wed, 3 Nov 2004 17:21:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/contrib/pf/net pf_if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 17:21:13 -0000 mlaier 2004-11-03 17:21:12 UTC FreeBSD src repository Modified files: sys/contrib/pf/net pf_if.c Log: Improved interface handling. This should fix the use of renamed interfaces (ifconfig xl0 name foo) as well as some special interfaces such as the 6to4 tunnel. Reported by: Ed Schouten Tested by: freebsd-pf PR: kern/72444 MFC after: 3 weeks Revision Changes Path 1.7 +12 -17 src/sys/contrib/pf/net/pf_if.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 17:21:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CAC416A4CF; Wed, 3 Nov 2004 17:21:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1A143D41; Wed, 3 Nov 2004 17:21:37 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3HLba0025299; Wed, 3 Nov 2004 17:21:37 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3HLbwu025298; Wed, 3 Nov 2004 17:21:37 GMT (envelope-from pjd) Message-Id: <200411031721.iA3HLbwu025298@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 3 Nov 2004 17:21:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/raid3 graid3.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 17:21:37 -0000 pjd 2004-11-03 17:21:37 UTC FreeBSD src repository Modified files: sbin/geom/class/raid3 graid3.8 Log: Be more correct. Submitted by: ceri Revision Changes Path 1.7 +2 -2 src/sbin/geom/class/raid3/graid3.8 From owner-cvs-src@FreeBSD.ORG Wed Nov 3 17:31:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E272716A4CE; Wed, 3 Nov 2004 17:31:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B435B43D39; Wed, 3 Nov 2004 17:31:09 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3HV9VN025640; Wed, 3 Nov 2004 17:31:09 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3HV9np025639; Wed, 3 Nov 2004 17:31:09 GMT (envelope-from pjd) Message-Id: <200411031731.iA3HV9np025639@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 3 Nov 2004 17:31:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/raid3 graid3.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 17:31:10 -0000 pjd 2004-11-03 17:31:09 UTC FreeBSD src repository Modified files: sbin/geom/class/raid3 graid3.8 Log: Remove extra 's'. Submitted by: ceri Revision Changes Path 1.8 +2 -2 src/sbin/geom/class/raid3/graid3.8 From owner-cvs-src@FreeBSD.ORG Wed Nov 3 17:52:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D1BB16A4CE; Wed, 3 Nov 2004 17:52:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CA1B43D5E; Wed, 3 Nov 2004 17:52:30 +0000 (GMT) (envelope-from paul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3HqTx3026381; Wed, 3 Nov 2004 17:52:29 GMT (envelope-from paul@repoman.freebsd.org) Received: (from paul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3HqTuF026380; Wed, 3 Nov 2004 17:52:29 GMT (envelope-from paul) Message-Id: <200411031752.iA3HqTuF026380@repoman.freebsd.org> From: Paul Richards Date: Wed, 3 Nov 2004 17:52:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tail tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 17:52:30 -0000 paul 2004-11-03 17:52:29 UTC FreeBSD src repository Modified files: usr.bin/tail tail.c Log: Revert a WIP change that shouldn't have been in last commit. Revision Changes Path 1.17 +2 -4 src/usr.bin/tail/tail.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:00:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D4AE16A4CE; Wed, 3 Nov 2004 18:00:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B4E343D64; Wed, 3 Nov 2004 18:00:49 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3I0n66026725; Wed, 3 Nov 2004 18:00:49 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3I0noZ026724; Wed, 3 Nov 2004 18:00:49 GMT (envelope-from emax) Message-Id: <200411031800.iA3I0noZ026724@repoman.freebsd.org> From: Maksim Yevmenkin Date: Wed, 3 Nov 2004 18:00:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph/bluetooth/hci ng_hci_main.cng_hci_misc.c ng_hci_var.h src/sys/netgraph/bluetooth/l2cap ng_l2cap_misc.c ng_l2cap_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:00:49 -0000 emax 2004-11-03 18:00:49 UTC FreeBSD src repository Modified files: sys/netgraph/bluetooth/hci ng_hci_main.c ng_hci_misc.c ng_hci_var.h sys/netgraph/bluetooth/l2cap ng_l2cap_misc.c ng_l2cap_var.h Log: Fix kernel build (caused by recent ng_{un}timeout API change) Submitted by: glebius Revision Changes Path 1.5 +1 -1 src/sys/netgraph/bluetooth/hci/ng_hci_main.c 1.8 +7 -7 src/sys/netgraph/bluetooth/hci/ng_hci_misc.c 1.5 +2 -2 src/sys/netgraph/bluetooth/hci/ng_hci_var.h 1.8 +11 -11 src/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.c 1.5 +2 -2 src/sys/netgraph/bluetooth/l2cap/ng_l2cap_var.h From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:01:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBF6F16A4CF; Wed, 3 Nov 2004 18:01:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7F9043D4C; Wed, 3 Nov 2004 18:01:21 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3I1LBK027165; Wed, 3 Nov 2004 18:01:21 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3I1L2L027164; Wed, 3 Nov 2004 18:01:21 GMT (envelope-from ru) Message-Id: <200411031801.iA3I1L2L027164@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 3 Nov 2004 18:01:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/mk bsd.prog.mk src/bin/rcp Makefile src/kerberos5/usr.bin/ksu Makefile src/libexec/rtld-aout Makefile src/libexec/rtld-elf Makefile src/release/picobsd/tinyware/login Makefile src/sbin/init Makefile src/usr.bin/login Makefile ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:01:22 -0000 ru 2004-11-03 18:01:21 UTC FreeBSD src repository Modified files: share/mk bsd.prog.mk bin/rcp Makefile kerberos5/usr.bin/ksu Makefile libexec/rtld-aout Makefile libexec/rtld-elf Makefile release/picobsd/tinyware/login Makefile sbin/init Makefile usr.bin/login Makefile usr.bin/newgrp Makefile usr.bin/opieinfo Makefile usr.bin/opiepasswd Makefile usr.bin/rlogin Makefile usr.bin/rsh Makefile usr.bin/su Makefile usr.sbin/cron/crontab Makefile usr.sbin/moused Makefile usr.sbin/sliplogin Makefile Log: Introduce the PRECIOUSPROG knob in bsd.prog.mk, similar to PRECIOUSLIB from bsd.lib.mk. The side effect of this is making installing the world under jail(8) possible by using another knob, NOFSCHG. Reviewed by: oliver Revision Changes Path 1.23 +1 -1 src/bin/rcp/Makefile 1.14 +1 -1 src/kerberos5/usr.bin/ksu/Makefile 1.32 +3 -2 src/libexec/rtld-aout/Makefile 1.33 +2 -1 src/libexec/rtld-elf/Makefile 1.3 +1 -1 src/release/picobsd/tinyware/login/Makefile 1.30 +2 -1 src/sbin/init/Makefile 1.137 +4 -0 src/share/mk/bsd.prog.mk 1.48 +1 -1 src/usr.bin/login/Makefile 1.3 +1 -1 src/usr.bin/newgrp/Makefile 1.11 +1 -1 src/usr.bin/opieinfo/Makefile 1.10 +1 -1 src/usr.bin/opiepasswd/Makefile 1.27 +1 -1 src/usr.bin/rlogin/Makefile 1.23 +1 -1 src/usr.bin/rsh/Makefile 1.40 +1 -1 src/usr.bin/su/Makefile 1.14 +1 -1 src/usr.sbin/cron/crontab/Makefile 1.7 +2 -2 src/usr.sbin/moused/Makefile 1.8 +2 -2 src/usr.sbin/sliplogin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:03:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3E2D16A4CE; Wed, 3 Nov 2004 18:03:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A25E843D67; Wed, 3 Nov 2004 18:03:06 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3I36Tj027247; Wed, 3 Nov 2004 18:03:06 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3I36ac027246; Wed, 3 Nov 2004 18:03:06 GMT (envelope-from scottl) Message-Id: <200411031803.iA3I36ac027246@repoman.freebsd.org> From: Scott Long Date: Wed, 3 Nov 2004 18:03:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/i386/i386 intr_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:03:07 -0000 scottl 2004-11-03 18:03:06 UTC FreeBSD src repository Modified files: sys/amd64/amd64 intr_machdep.c sys/i386/i386 intr_machdep.c Log: Don't use atomic ops to increment interrupt stats. This was only done on amd64 and i386 anyways. The stats are only kept for informational purposes. Revision Changes Path 1.11 +3 -3 src/sys/amd64/amd64/intr_machdep.c 1.11 +3 -3 src/sys/i386/i386/intr_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:09:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13DCB16A4CF for ; Wed, 3 Nov 2004 18:09:51 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAF9543D45 for ; Wed, 3 Nov 2004 18:09:50 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 28333 invoked from network); 3 Nov 2004 18:09:50 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Nov 2004 18:09:49 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA3I9YLL078281; Wed, 3 Nov 2004 13:09:44 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Xu Date: Wed, 3 Nov 2004 14:04:56 -0500 User-Agent: KMail/1.6.2 References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <200411021549.27511.jhb@FreeBSD.org> <418817ED.2040201@freebsd.org> In-Reply-To: <418817ED.2040201@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411031404.56440.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Julian Elischer cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:09:51 -0000 On Tuesday 02 November 2004 06:27 pm, David Xu wrote: > John Baldwin wrote: > >On Monday 01 November 2004 06:04 pm, David Xu wrote: > >>Not every important, I think I have another very important history > >>bug in hand, did you get my "fix famous libpthread conditional > >>variable race condition" mail ? :-) > > > >Oooo, can I test it please? We are still having problems with mono on > > HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 to > > libpthread but that seemed to make it worse. The problems seem to be > > that a signal handler is being run when the SYNCQ sflag is set (but the > > thread is not on a cv or a mutex queue), and the handler calls sem_post() > > which is supposed to be signal safe. sem_post() tries to lock a mutex > > and then bombs with the assertion failure. > > You can try: > http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff > > But it was not designed to fix the problem you have seen. :-) This looks like it's trying to fix the same problem as uthread_cond.c rev 1.32 in libc_r but in a different way. The fix for libc_r was to always unlock the mutex instead of trying to keep it locked in some cases. The kernel cv code works like this as well. I have a patch that ports 1.32 of uthread_cond.c to thr_cond.c if you are interested. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:09:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95C4A16A557 for ; Wed, 3 Nov 2004 18:09:54 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E43F43D46 for ; Wed, 3 Nov 2004 18:09:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 2537 invoked from network); 3 Nov 2004 18:09:53 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Nov 2004 18:09:52 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA3I9YLM078281; Wed, 3 Nov 2004 13:09:48 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Scott Long Date: Wed, 3 Nov 2004 14:08:03 -0500 User-Agent: KMail/1.6.2 References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> In-Reply-To: <41890956.2030705@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411031408.03949.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:09:55 -0000 On Wednesday 03 November 2004 11:37 am, Scott Long wrote: > Luigi Rizzo wrote: > > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: > > ... > > > >>I think that in general we can start eyeing a lot of similar verbosity > >>in all of our drivers, both at boot and at runtime. For example most > >>nic drivers print out their MAC and all of their possible negotiation > >>rates on attach. This same info can be obtained from ifconfig. Why > >>clutter the boot with it? > > > > because sometimes you might need to enable some MAC-based filter > > before you have a chance to access the box. e.g. to set dhcp/bootp > > anbd the like. > > > > A bit of verbosity is useful, you can always switch to splash screens > > if you don't like them. > > > > I think the link-up/link-down thing is different because it > > happens not just at boot but also whenever the link status > > changes (e.g. when a spanning tree on a switch detects a > > reconfiguration), and this is annoying on the console. > > > > cheers > > luigi > > I'm not saying that these things should be removed, just places under > bootverbose. Situations like what you are saying are rare and/or > one-time occurances. And if you look at drivers like if_ath(no offense > meant towards Sam): I think bootverbose needs to be split up some. Imagine having a 'verbose.ether' tunable that would turn on dumping all the MAC addresses for NICs but would be off by default. Many of the interrupt messages on x86 need to move from bootverbose to some kind of apic_verbose. Might even be nice to have some kind of acpi-like verbose variable that could be set as: set verbose="boot,apic,ether" or some such. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:12:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD40F16A4CE; Wed, 3 Nov 2004 18:12:34 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D46943D45; Wed, 3 Nov 2004 18:12:34 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA3ICV20023322; Wed, 3 Nov 2004 19:12:31 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: John Baldwin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 03 Nov 2004 14:08:03 EST." <200411031408.03949.jhb@FreeBSD.org> Date: Wed, 03 Nov 2004 19:12:31 +0100 Message-ID: <23321.1099505551@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:12:34 -0000 In message <200411031408.03949.jhb@FreeBSD.org>, John Baldwin writes: >I think bootverbose needs to be split up some. Imagine having a >'verbose.ether' tunable that would turn on dumping all the MAC addresses for >NICs but would be off by default. Many of the interrupt messages on x86 need >to move from bootverbose to some kind of apic_verbose. Might even be nice to >have some kind of acpi-like verbose variable that could be set as: > >set verbose="boot,apic,ether" I think that would be overkill. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:23:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5766816A540 for ; Wed, 3 Nov 2004 18:23:11 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA66D43D39 for ; Wed, 3 Nov 2004 18:23:08 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 89563 invoked from network); 3 Nov 2004 18:19:23 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 3 Nov 2004 18:19:23 -0000 Message-ID: <41892210.8D5718F3@freebsd.org> Date: Wed, 03 Nov 2004 19:23:12 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Luigi Rizzo References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> <20041103083922.A49431@xorpc.icir.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:23:14 -0000 Luigi Rizzo wrote: > > On Wed, Nov 03, 2004 at 09:37:42AM -0700, Scott Long wrote: > ... > > > because sometimes you might need to enable some MAC-based filter > > > before you have a chance to access the box. e.g. to set dhcp/bootp > > > anbd the like. > ... > > > I think the link-up/link-down thing is different because it > > > happens not just at boot but also whenever the link status > > > changes (e.g. when a spanning tree on a switch detects a > ... > > bootverbose. Situations like what you are saying are rare and/or > > one-time occurances. And if you look at drivers like if_ath(no offense > > ok, but that one time is precisely when you have little or > no chance to intervene. Anyways, as long as you keep the MAC > printout on by default i am happy :) Me too. :) -- Andre From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:26:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF6A416A4DA; Wed, 3 Nov 2004 18:26:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CABC343D2F; Wed, 3 Nov 2004 18:26:06 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3IQ6KR028012; Wed, 3 Nov 2004 18:26:06 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3IQ6sr028011; Wed, 3 Nov 2004 18:26:06 GMT (envelope-from kensmith) Message-Id: <200411031826.iA3IQ6sr028011@repoman.freebsd.org> From: Ken Smith Date: Wed, 3 Nov 2004 18:26:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall index.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:26:11 -0000 kensmith 2004-11-03 18:26:06 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall index.c Log: Update the list of package names/descriptions. Last second MFC candidate? Revision Changes Path 1.103 +7 -0 src/usr.sbin/sysinstall/index.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:30:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0609816A4CF for ; Wed, 3 Nov 2004 18:30:56 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB36843D49 for ; Wed, 3 Nov 2004 18:30:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 14107 invoked from network); 3 Nov 2004 18:30:55 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Nov 2004 18:30:12 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA3ITuin078425; Wed, 3 Nov 2004 13:29:59 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Daniel Eischen Date: Wed, 3 Nov 2004 14:31:16 -0500 User-Agent: KMail/1.6.2 References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411031431.16218.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: David Xu cc: cvs-all@FreeBSD.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:30:56 -0000 On Tuesday 02 November 2004 06:40 pm, Daniel Eischen wrote: > On Wed, 3 Nov 2004, David Xu wrote: > > John Baldwin wrote: > > >On Monday 01 November 2004 06:04 pm, David Xu wrote: > > >>Not every important, I think I have another very important history > > >>bug in hand, did you get my "fix famous libpthread conditional > > >>variable race condition" mail ? :-) > > > > > >Oooo, can I test it please? We are still having problems with mono on > > > HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 > > > to libpthread but that seemed to make it worse. The problems seem to > > > be that a signal handler is being run when the SYNCQ sflag is set (but > > > the thread is not on a cv or a mutex queue), and the handler calls > > > sem_post() which is supposed to be signal safe. sem_post() tries to > > > lock a mutex and then bombs with the assertion failure. > > > > You can try: > > http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff > > > > But it was not designed to fix the problem you have seen. :-) > > I think if _kse_critical_leave() were replaced by _kcb_critical_leave() > at around line 676 in thr_kern.c, that should fix the problem, no? > There's no reason to do a yield check after leaving the scheduler, > and the check for signals and cancellation is done right after > that point before returning. Well, it moved it. :) Now thr_sig_rundown() is called from thr_resume_check() from thr_sched_switch_unlocked(), but psf->valid is zero, so it still doesn't work. What would happen if the signal came in before curthread->frame was set to &psf in thread_sched_switch_unlocked()? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:35:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA6C316A4CE; Wed, 3 Nov 2004 18:35:12 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id E508143D46; Wed, 3 Nov 2004 18:35:11 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 0DD311FFACB; Wed, 3 Nov 2004 19:35:08 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 2AF811FFACA; Wed, 3 Nov 2004 19:35:06 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 8DD38153C4; Wed, 3 Nov 2004 18:31:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 813E615389; Wed, 3 Nov 2004 18:31:49 +0000 (UTC) Date: Wed, 3 Nov 2004 18:31:49 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Poul-Henning Kamp In-Reply-To: <23321.1099505551@critter.freebsd.dk> Message-ID: References: <23321.1099505551@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:35:12 -0000 On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > In message <200411031408.03949.jhb@FreeBSD.org>, John Baldwin writes: > > >I think bootverbose needs to be split up some. Imagine having a > >'verbose.ether' tunable that would turn on dumping all the MAC addresses for > >NICs but would be off by default. Many of the interrupt messages on x86 need > >to move from bootverbose to some kind of apic_verbose. Might even be nice to > >have some kind of acpi-like verbose variable that could be set as: > > > >set verbose="boot,apic,ether" > > I think that would be overkill. I think it's overkill to enable all verbose msgs just to see link state messages in my logs again when someone fiddles at the cabling in the colo hotel where he shouldn't - or did I mis-read the commit message ? I am totally agreeing that some changes (including my latest sk patch) my be far too verbose for many things in default configuration but enabling all to get one thing back - isn't that overkill ? The better question should perhaps be if it's best to put things under boot_verbose if they can also be printed at runtime ? -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Wed Nov 3 18:41:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B07D16A4CE; Wed, 3 Nov 2004 18:41:11 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id B11C343D1D; Wed, 3 Nov 2004 18:41:10 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA3If4OP023792; Wed, 3 Nov 2004 19:41:09 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "Bjoern A. Zeeb" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 03 Nov 2004 18:31:49 GMT." Date: Wed, 03 Nov 2004 19:41:04 +0100 Message-ID: <23791.1099507264@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 18:41:11 -0000 In message , "Bjoern A. Zeeb" writes: >I think it's overkill to enable all verbose msgs just to see link state >messages in my logs again when someone fiddles at the cabling in the >colo hotel where he shouldn't - or did I mis-read the commit message ? Link states are visible with ifconfig(8). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:00:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37E9416A4CE; Wed, 3 Nov 2004 19:00:11 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7DD243D62; Wed, 3 Nov 2004 19:00:10 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id EA18C1FF9AF; Wed, 3 Nov 2004 20:00:06 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 1278D1FF91D; Wed, 3 Nov 2004 20:00:05 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id EFCE9153C4; Wed, 3 Nov 2004 18:57:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id E4DE115389; Wed, 3 Nov 2004 18:57:23 +0000 (UTC) Date: Wed, 3 Nov 2004 18:57:23 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Poul-Henning Kamp In-Reply-To: <23791.1099507264@critter.freebsd.dk> Message-ID: References: <23791.1099507264@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:00:11 -0000 On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > In message , "Bjoern A. Zeeb" writes: > > >I think it's overkill to enable all verbose msgs just to see link state > >messages in my logs again when someone fiddles at the cabling in the > >colo hotel where he shouldn't - or did I mis-read the commit message ? > > Link states are visible with ifconfig(8). of course they are but who will notify me or write them to my logs so I have timestamps ? Do I need to write a small daemon to regularly and fast enough poll for link state changes now ? -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:02:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2030516A4CE; Wed, 3 Nov 2004 19:02:56 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5208343D55; Wed, 3 Nov 2004 19:02:55 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA3J2s2Q024244; Wed, 3 Nov 2004 20:02:54 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "Bjoern A. Zeeb" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 03 Nov 2004 18:57:23 GMT." Date: Wed, 03 Nov 2004 20:02:54 +0100 Message-ID: <24243.1099508574@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:02:56 -0000 In message , "Bjoern A. Zeeb" writes: >On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > >> In message , "Bjoern A. Zeeb" writes: >> >> >I think it's overkill to enable all verbose msgs just to see link state >> >messages in my logs again when someone fiddles at the cabling in the >> >colo hotel where he shouldn't - or did I mis-read the commit message ? >> >> Link states are visible with ifconfig(8). > >of course they are but who will notify me or write them to my logs so >I have timestamps ? Do I need to write a small daemon to regularly >and fast enough poll for link state changes now ? I'm not against logging link states, but if we do it, we should not arbitrarily limit it to when the link is gigE. In general I would say it is a job for SNMP. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:15:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F58B16A4D1 for ; Wed, 3 Nov 2004 19:15:33 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DA9E43D2F for ; Wed, 3 Nov 2004 19:15:33 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 1489 invoked from network); 3 Nov 2004 19:15:32 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail1.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 3 Nov 2004 19:15:32 -0000 Received: from hydrogen.funkthat.com (zsxery@localhost.funkthat.com [127.0.0.1])iA3JFVB6055079; Wed, 3 Nov 2004 11:15:31 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id iA3JFTVI055078; Wed, 3 Nov 2004 11:15:29 -0800 (PST) Date: Wed, 3 Nov 2004 11:15:29 -0800 From: John-Mark Gurney To: "Bjoern A. Zeeb" Message-ID: <20041103191529.GT22681@funkthat.com> References: <23791.1099507264@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:15:33 -0000 Bjoern A. Zeeb wrote this message on Wed, Nov 03, 2004 at 18:57 +0000: > On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > > > In message , "Bjoern A. Zeeb" writes: > > > > >I think it's overkill to enable all verbose msgs just to see link state > > >messages in my logs again when someone fiddles at the cabling in the > > >colo hotel where he shouldn't - or did I mis-read the commit message ? > > > > Link states are visible with ifconfig(8). > > of course they are but who will notify me or write them to my logs so > I have timestamps ? Do I need to write a small daemon to regularly > and fast enough poll for link state changes now ? Sounds like we need to expand devd for this.. We already have miibus hooked up for kevent notification... And it shoudln't be hard to make the kevent notification happen for non-miibus drivers... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:16:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 174EC16A4CE; Wed, 3 Nov 2004 19:16:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBBE443D3F; Wed, 3 Nov 2004 19:16:55 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3JGtwb029654; Wed, 3 Nov 2004 19:16:55 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3JGteN029653; Wed, 3 Nov 2004 19:16:55 GMT (envelope-from phk) Message-Id: <200411031916.iA3JGteN029653@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 19:16:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys ttydefaults.h src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:16:56 -0000 phk 2004-11-03 19:16:55 UTC FreeBSD src repository Modified files: sys/sys ttydefaults.h sys/kern tty.c Log: Restore TTYDEF_LFLAG to set echo bits. Revision Changes Path 1.240 +1 -1 src/sys/kern/tty.c 1.19 +4 -2 src/sys/sys/ttydefaults.h From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:18:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BBF616A4D0 for ; Wed, 3 Nov 2004 19:18:44 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE9B443D4C for ; Wed, 3 Nov 2004 19:18:43 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 89957 invoked from network); 3 Nov 2004 19:14:58 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 3 Nov 2004 19:14:58 -0000 Message-ID: <41892F17.79C393F4@freebsd.org> Date: Wed, 03 Nov 2004 20:18:47 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: John-Mark Gurney References: <23791.1099507264@critter.freebsd.dk> <20041103191529.GT22681@funkthat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: "Bjoern A. Zeeb" cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:18:44 -0000 John-Mark Gurney wrote: > > Bjoern A. Zeeb wrote this message on Wed, Nov 03, 2004 at 18:57 +0000: > > On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > > > > > In message , "Bjoern A. Zeeb" writes: > > > > > > >I think it's overkill to enable all verbose msgs just to see link state > > > >messages in my logs again when someone fiddles at the cabling in the > > > >colo hotel where he shouldn't - or did I mis-read the commit message ? > > > > > > Link states are visible with ifconfig(8). > > > > of course they are but who will notify me or write them to my logs so > > I have timestamps ? Do I need to write a small daemon to regularly > > and fast enough poll for link state changes now ? > > Sounds like we need to expand devd for this.. We already have miibus > hooked up for kevent notification... And it shoudln't be hard to make > the kevent notification happen for non-miibus drivers... The network drivers poll their PHY via MII every second for connection status. You don't have to worry about milliseconds or so. -- Andre From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:20:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 605E416A4E0; Wed, 3 Nov 2004 19:20:24 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4F5743D5C; Wed, 3 Nov 2004 19:20:23 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.10.171.95] (mail.atheros.com [65.212.155.130]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id iA3JKEWi030113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Nov 2004 11:20:20 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <41892F68.9080603@errno.com> Date: Wed, 03 Nov 2004 11:20:08 -0800 From: Sam Leffler Organization: Errno Consulting User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> In-Reply-To: <41890956.2030705@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-vtss-Metrics: ebb.errno.com 1018; Body=6 Fuz1=6 Fuz2=6 cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:20:24 -0000 Scott Long wrote: > Luigi Rizzo wrote: > >> On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: >> ... >> >>> I think that in general we can start eyeing a lot of similar verbosity >>> in all of our drivers, both at boot and at runtime. For example most >>> nic drivers print out their MAC and all of their possible negotiation >>> rates on attach. This same info can be obtained from ifconfig. Why >>> clutter the boot with it? >> >> >> >> because sometimes you might need to enable some MAC-based filter >> before you have a chance to access the box. e.g. to set dhcp/bootp >> anbd the like. >> >> A bit of verbosity is useful, you can always switch to splash screens >> if you don't like them. >> >> I think the link-up/link-down thing is different because it >> happens not just at boot but also whenever the link status >> changes (e.g. when a spanning tree on a switch detects a >> reconfiguration), and this is annoying on the console. >> >> cheers >> luigi >> > > I'm not saying that these things should be removed, just places under > bootverbose. Situations like what you are saying are rare and/or > one-time occurances. And if you look at drivers like if_ath(no offense > meant towards Sam): > > ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on > cardbus1 > ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 > ath0: Ethernet address: 00:0c:41:15:5f:94 > ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps > ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps > ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps > 24Mbps 36Mbps 48Mbps 54Mbps > ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps > > The last 4 lines could easily go under bootverbose. I'd even wager that > the second line can be hidden also; it provides little useful > information for a normal boot. The 2nd line cannot be removed. I'm ok with moving the rates under bootverbose. Sam From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:36:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85B7916A4CE; Wed, 3 Nov 2004 19:36:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6720943D1D; Wed, 3 Nov 2004 19:36:38 +0000 (GMT) (envelope-from murray@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3JacOi030310; Wed, 3 Nov 2004 19:36:38 GMT (envelope-from murray@repoman.freebsd.org) Received: (from murray@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3JacQT030309; Wed, 3 Nov 2004 19:36:38 GMT (envelope-from murray) Message-Id: <200411031936.iA3JacQT030309@repoman.freebsd.org> From: Murray Stokely Date: Wed, 3 Nov 2004 19:36:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:36:38 -0000 murray 2004-11-03 19:36:38 UTC FreeBSD src repository Modified files: . access Log: Forced commit to note that Xin LI is now free of needing his mentor's approval for commits. Revision Changes Path 1.682 +0 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:55:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC9BC16A4CF; Wed, 3 Nov 2004 19:55:21 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 145F843D2D; Wed, 3 Nov 2004 19:55:21 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id iA3JtKJJ056775; Wed, 3 Nov 2004 22:55:20 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id iA3JtJAZ056774; Wed, 3 Nov 2004 22:55:19 +0300 (MSK) (envelope-from ache) Date: Wed, 3 Nov 2004 22:55:19 +0300 From: Andrey Chernov To: Poul-Henning Kamp Message-ID: <20041103195519.GA56692@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200411031916.iA3JGteN029653@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411031916.iA3JGteN029653@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.12; VDF: 6.28.0.50; host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys ttydefaults.h src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:55:21 -0000 On Wed, Nov 03, 2004 at 07:16:55PM +0000, Poul-Henning Kamp wrote: > sys/sys ttydefaults.h > sys/kern tty.c > Log: > Restore TTYDEF_LFLAG to set echo bits. Thanx! Please don't forget to back out stty/key.c v1.19 too. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Wed Nov 3 19:59:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B692416A4CE; Wed, 3 Nov 2004 19:59:18 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62E2143D53; Wed, 3 Nov 2004 19:59:18 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) iA3JxEV1016439; Wed, 3 Nov 2004 14:59:14 -0500 (EST) Date: Wed, 3 Nov 2004 14:59:14 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200411031431.16218.jhb@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: David Xu cc: cvs-all@freebsd.org cc: Julian Elischer Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 19:59:18 -0000 On Wed, 3 Nov 2004, John Baldwin wrote: > On Tuesday 02 November 2004 06:40 pm, Daniel Eischen wrote: > > > > I think if _kse_critical_leave() were replaced by _kcb_critical_leave() > > at around line 676 in thr_kern.c, that should fix the problem, no? > > There's no reason to do a yield check after leaving the scheduler, > > and the check for signals and cancellation is done right after > > that point before returning. > > Well, it moved it. :) Now thr_sig_rundown() is called from thr_resume_check() > from thr_sched_switch_unlocked(), but psf->valid is zero, so it still doesn't > work. What would happen if the signal came in before curthread->frame was > set to &psf in thread_sched_switch_unlocked()? That would cause the problem also. How's this look? http://people.freebsd.org/~deischen/kse/libpthread.cond.diffs -- Dan Eischen From owner-cvs-src@FreeBSD.ORG Wed Nov 3 20:01:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D605E16A4CE; Wed, 3 Nov 2004 20:01:31 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C12043D4C; Wed, 3 Nov 2004 20:01:31 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id iA3K1UXg056934; Wed, 3 Nov 2004 23:01:30 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id iA3K1T77056929; Wed, 3 Nov 2004 23:01:29 +0300 (MSK) (envelope-from ache) Date: Wed, 3 Nov 2004 23:01:29 +0300 From: Andrey Chernov To: Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041103200128.GA56859@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200411031916.iA3JGteN029653@repoman.freebsd.org> <20041103195519.GA56692@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041103195519.GA56692@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.12; VDF: 6.28.0.50; host: pobrecita.freebsd.ru) Subject: Re: cvs commit: src/sys/sys ttydefaults.h src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 20:01:32 -0000 On Wed, Nov 03, 2004 at 10:55:19PM +0300, Andrey Chernov wrote: > On Wed, Nov 03, 2004 at 07:16:55PM +0000, Poul-Henning Kamp wrote: > > sys/sys ttydefaults.h > > sys/kern tty.c > > Log: > > Restore TTYDEF_LFLAG to set echo bits. > > Thanx! Please don't forget to back out stty/key.c v1.19 too. Although it will be NOP change, but just to minimize diffs with other BSDs. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Wed Nov 3 20:17:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4309D16A4CE; Wed, 3 Nov 2004 20:17:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 322BE43D3F; Wed, 3 Nov 2004 20:17:32 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3KHWia031698; Wed, 3 Nov 2004 20:17:32 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3KHWJX031697; Wed, 3 Nov 2004 20:17:32 GMT (envelope-from alc) Message-Id: <200411032017.iA3KHWJX031697@repoman.freebsd.org> From: Alan Cox Date: Wed, 3 Nov 2004 20:17:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_subr.c uipc_jumbo.c uipc_syscalls.c vfs_bio.c src/sys/sparc64/sparc64 pmap.c src/sys/vm vm_contig.c vm_glue.c vm_object.c vm_page.c vm_pageout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 20:17:32 -0000 alc 2004-11-03 20:17:32 UTC FreeBSD src repository Modified files: sys/kern kern_subr.c uipc_jumbo.c uipc_syscalls.c vfs_bio.c sys/sparc64/sparc64 pmap.c sys/vm vm_contig.c vm_glue.c vm_object.c vm_page.c vm_pageout.c Log: The synchronization provided by vm object locking has eliminated the need for most calls to vm_page_busy(). Specifically, most calls to vm_page_busy() occur immediately prior to a call to vm_page_remove(). In such cases, the containing vm object is locked across both calls. Consequently, the setting of the vm page's PG_BUSY flag is not even visible to other threads that are following the synchronization protocol. This change (1) eliminates the calls to vm_page_busy() that immediately precede a call to vm_page_remove() or functions, such as vm_page_free() and vm_page_rename(), that call it and (2) relaxes the requirement in vm_page_remove() that the vm page's PG_BUSY flag is set. Now, the vm page's PG_BUSY flag is set only when the vm object lock is released while the vm page is still in transition. Typically, this is when it is undergoing I/O. Revision Changes Path 1.90 +0 -2 src/sys/kern/kern_subr.c 1.11 +0 -1 src/sys/kern/uipc_jumbo.c 1.205 +0 -1 src/sys/kern/uipc_syscalls.c 1.464 +0 -2 src/sys/kern/vfs_bio.c 1.140 +0 -1 src/sys/sparc64/sparc64/pmap.c 1.40 +0 -2 src/sys/vm/vm_contig.c 1.206 +0 -2 src/sys/vm/vm_glue.c 1.333 +0 -3 src/sys/vm/vm_object.c 1.298 +5 -14 src/sys/vm/vm_page.c 1.265 +0 -2 src/sys/vm/vm_pageout.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 20:32:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E99016A4E2; Wed, 3 Nov 2004 20:32:49 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5CF843D5F; Wed, 3 Nov 2004 20:32:48 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iA3KWluQ005262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Nov 2004 23:32:47 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iA3KWkKv005261; Wed, 3 Nov 2004 23:32:47 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Wed, 3 Nov 2004 23:32:46 +0300 From: Gleb Smirnoff To: Luigi Rizzo Message-ID: <20041103203246.GD5033@cell.sick.ru> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041103082806.C49241@xorpc.icir.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 20:32:49 -0000 On Wed, Nov 03, 2004 at 08:28:06AM -0800, Luigi Rizzo wrote: L> > I think that in general we can start eyeing a lot of similar verbosity L> > in all of our drivers, both at boot and at runtime. For example most L> > nic drivers print out their MAC and all of their possible negotiation L> > rates on attach. This same info can be obtained from ifconfig. Why L> > clutter the boot with it? L> L> because sometimes you might need to enable some MAC-based filter L> before you have a chance to access the box. e.g. to set dhcp/bootp L> anbd the like. L> L> A bit of verbosity is useful, you can always switch to splash screens L> if you don't like them. L> L> I think the link-up/link-down thing is different because it L> happens not just at boot but also whenever the link status L> changes (e.g. when a spanning tree on a switch detects a L> reconfiguration), and this is annoying on the console. My 1 penny: I completely agree with Luigi at this point. So my vote is: keep initialization printfs as is, remove any runtime printfs. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Wed Nov 3 20:45:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBCC416A4CE; Wed, 3 Nov 2004 20:45:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA35E43D41; Wed, 3 Nov 2004 20:45:52 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3KjqWU032869; Wed, 3 Nov 2004 20:45:52 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3KjqsC032868; Wed, 3 Nov 2004 20:45:52 GMT (envelope-from ceri) Message-Id: <200411032045.iA3KjqsC032868@repoman.freebsd.org> From: Ceri Davies Date: Wed, 3 Nov 2004 20:45:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ancontrol ancontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 20:45:53 -0000 ceri 2004-11-03 20:45:52 UTC FreeBSD src repository (doc committer) Modified files: usr.sbin/ancontrol ancontrol.c Log: Allow the -f argument to work. PR: bin/73229 Submitted by: Irina Liakh MT4: 2 weeks MT5: After 5.3-RELEASE Revision Changes Path 1.25 +1 -1 src/usr.sbin/ancontrol/ancontrol.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:09:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAD2216A4CE; Wed, 3 Nov 2004 21:09:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA7E743D49; Wed, 3 Nov 2004 21:09:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3L9N4Y039859; Wed, 3 Nov 2004 21:09:23 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3L9NWL039858; Wed, 3 Nov 2004 21:09:23 GMT (envelope-from phk) Message-Id: <200411032109.iA3L9NWL039858@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 21:09:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:09:24 -0000 phk 2004-11-03 21:09:23 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: Always initialize bo_private along with bo_ops in getnewvnode(). Spotted by: tegge Revision Changes Path 1.546 +1 -1 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:11:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC5CB16A4D4; Wed, 3 Nov 2004 21:11:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B98B043D53; Wed, 3 Nov 2004 21:11:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3LBY9M040016; Wed, 3 Nov 2004 21:11:34 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3LBY2B040015; Wed, 3 Nov 2004 21:11:34 GMT (envelope-from rwatson) Message-Id: <200411032111.iA3LBY2B040015@repoman.freebsd.org> From: Robert Watson Date: Wed, 3 Nov 2004 21:11:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:11:35 -0000 rwatson 2004-11-03 21:11:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/kern uipc_socket.c Log: Merge uipc_socket.c:1.216 from HEAD to RELENG_5: date: 2004/11/02 17:15:13; author: rwatson; state: Exp; lines: +1 -0 Acquire the accept mutex in soabort() before calling sotryfree(), as that is now required. RELENG_5_3 candidate. Foot provided by: Dikshie Approved by: re (kensmith) Revision Changes Path 1.208.2.5 +1 -0 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:14:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D395F16A4CE; Wed, 3 Nov 2004 21:14:06 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3434043D1F; Wed, 3 Nov 2004 21:14:06 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iA3LDEur084633; Wed, 3 Nov 2004 16:13:14 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iA3LDDou084630; Wed, 3 Nov 2004 16:13:13 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Wed, 3 Nov 2004 16:13:13 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Bjoern A. Zeeb" In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:14:07 -0000 On Wed, 3 Nov 2004, Bjoern A. Zeeb wrote: > On Wed, 3 Nov 2004, Poul-Henning Kamp wrote: > > > In message , "Bjoern A. Zeeb" writes: > > > > >I think it's overkill to enable all verbose msgs just to see link state > > >messages in my logs again when someone fiddles at the cabling in the > > >colo hotel where he shouldn't - or did I mis-read the commit message ? > > > > Link states are visible with ifconfig(8). > > of course they are but who will notify me or write them to my logs so I > have timestamps ? Do I need to write a small daemon to regularly and > fast enough poll for link state changes now ? If the information provided by "route monitor" isn't sufficiently useful and detailed (i.e., easily parsable) we should make it more useful, I think. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:16:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEFC716A4CE; Wed, 3 Nov 2004 21:16:14 +0000 (GMT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4766B43D54; Wed, 3 Nov 2004 21:16:14 +0000 (GMT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id iA3LGCqw077598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.lcs.mit.edu issuer=SSL+20Client+20CA); Wed, 3 Nov 2004 16:16:13 -0500 (EST) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id iA3LGCKX077595; Wed, 3 Nov 2004 16:16:12 -0500 (EST) (envelope-from wollman) Date: Wed, 3 Nov 2004 16:16:12 -0500 (EST) From: Garrett Wollman Message-Id: <200411032116.iA3LGCKX077595@khavrinen.lcs.mit.edu> To: Robert Watson In-Reply-To: References: X-Spam-Score: -19.8 () IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Scanned-By: MIMEDefang 2.37 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:16:14 -0000 < said: > If the information provided by "route monitor" isn't sufficiently useful > and detailed (i.e., easily parsable) we should make it more useful, I > think. Why can't we simply log() a message? -GAWollman From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:36:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F97616A4CE; Wed, 3 Nov 2004 21:36:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D52743D3F; Wed, 3 Nov 2004 21:36:42 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3LagsD040773; Wed, 3 Nov 2004 21:36:42 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3LagBt040772; Wed, 3 Nov 2004 21:36:42 GMT (envelope-from phk) Message-Id: <200411032136.iA3LagBt040772@repoman.freebsd.org> From: Poul-Henning Kamp Date: Wed, 3 Nov 2004 21:36:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/ntfs ntfs.h ntfs_subr.c ntfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:36:42 -0000 phk 2004-11-03 21:36:41 UTC FreeBSD src repository Modified files: sys/fs/ntfs ntfs.h ntfs_subr.c ntfs_vfsops.c Log: Make a more whole-hearted attempt at GEOM'ifying NTFS. I must have been sleepy when I did the first pass. Spotted by: tegge Revision Changes Path 1.17 +2 -1 src/sys/fs/ntfs/ntfs.h 1.35 +2 -2 src/sys/fs/ntfs/ntfs_subr.c 1.63 +17 -6 src/sys/fs/ntfs/ntfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 21:51:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B988716A4CE; Wed, 3 Nov 2004 21:51:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9893743D2D; Wed, 3 Nov 2004 21:51:34 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3LpYfJ041384; Wed, 3 Nov 2004 21:51:34 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3LpYl6041383; Wed, 3 Nov 2004 21:51:34 GMT (envelope-from ceri) Message-Id: <200411032151.iA3LpYl6041383@repoman.freebsd.org> From: Ceri Davies Date: Wed, 3 Nov 2004 21:51:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ipfw ipfw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 21:51:34 -0000 ceri 2004-11-03 21:51:34 UTC FreeBSD src repository (doc committer) Modified files: sbin/ipfw ipfw.8 Log: Be more clear that "bridged" is a synonym for "layer2". PR: docs/44400 Submitted by: Constantin Stefanov Revision Changes Path 1.159 +2 -1 src/sbin/ipfw/ipfw.8 From owner-cvs-src@FreeBSD.ORG Wed Nov 3 22:02:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDC8416A4CE; Wed, 3 Nov 2004 22:02:39 +0000 (GMT) Received: from smtp-vbr12.xs4all.nl (smtp-vbr12.xs4all.nl [194.109.24.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A34943D67; Wed, 3 Nov 2004 22:02:39 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) iA3M2b7x010219; Wed, 3 Nov 2004 23:02:38 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.1/8.12.9) with ESMTP id iA3M2bFw037638; Wed, 3 Nov 2004 23:02:37 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.1/8.13.1/Submit) id iA3M2bMf037637; Wed, 3 Nov 2004 23:02:37 +0100 (CET) (envelope-from wb) Date: Wed, 3 Nov 2004 23:02:37 +0100 From: Wilko Bulte To: Scott Long Message-ID: <20041103220237.GB37480@freebie.xs4all.nl> References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> <200411011429.38840.jhb@FreeBSD.org> <20041102214014.GA54727@hub.freebsd.org> <41880075.70309@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41880075.70309@freebsd.org> User-Agent: Mutt/1.4.1i X-OS: FreeBSD 4.10-STABLE X-PGP: finger wilko@freebsd.org X-Virus-Scanned: by XS4ALL Virus Scanner cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: John Baldwin cc: obrien@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 22:02:40 -0000 On Tue, Nov 02, 2004 at 02:47:33PM -0700, Scott Long wrote.. > David O'Brien wrote: > >On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: > > > >>On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: > >> > >>>I made 3-4 requestss, each one had an ACK that said, "sorry, right > >>>on it!" > >>> > >>>It's just not acceptable. > >> > >>Are you volunteering to be an re@ secretary ala wilko@? > > > > > >Why does every group now need a secretary? Maybe we just need more > >members on RE@ that are very active. > > With all due respect, I'd like the members of the release engineering > team to decide what is best for them, and have less armchair > quarterbacking of what others think we need. I would just like to say this: don't overengineer what aint broken. Sjeez.. it is hardly a Supreme Court worthy case that re@ forgot to update some stupid web page is it? Wouldn't a normal, if need be public, reply to the automated reminder email have been sufficient to get that fixed? -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Nov 3 22:06:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C9BB16A4CE; Wed, 3 Nov 2004 22:06:16 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1042D43D31; Wed, 3 Nov 2004 22:06:16 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3M854j021922; Wed, 3 Nov 2004 15:08:05 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41895699.6020300@freebsd.org> Date: Wed, 03 Nov 2004 15:07:21 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Wilko Bulte References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <200410291338.50383.jhb@FreeBSD.org> <20041029234823.GW24892@elvis.mu.org> <200411011429.38840.jhb@FreeBSD.org> <20041102214014.GA54727@hub.freebsd.org> <41880075.70309@freebsd.org> <20041103220237.GB37480@freebie.xs4all.nl> In-Reply-To: <20041103220237.GB37480@freebie.xs4all.nl> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: src-committers@freebsd.org cc: John Baldwin cc: obrien@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 22:06:16 -0000 Wilko Bulte wrote: > On Tue, Nov 02, 2004 at 02:47:33PM -0700, Scott Long wrote.. > >>David O'Brien wrote: >> >>>On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: >>> >>> >>>>On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: >>>> >>>> >>>>>I made 3-4 requestss, each one had an ACK that said, "sorry, right >>>>>on it!" >>>>> >>>>>It's just not acceptable. >>>> >>>>Are you volunteering to be an re@ secretary ala wilko@? >>> >>> >>>Why does every group now need a secretary? Maybe we just need more >>>members on RE@ that are very active. >> >>With all due respect, I'd like the members of the release engineering >>team to decide what is best for them, and have less armchair >>quarterbacking of what others think we need. > > > I would just like to say this: don't overengineer what aint broken. Sjeez.. > it is hardly a Supreme Court worthy case that re@ forgot to update some > stupid web page is it? > > Wouldn't a normal, if need be public, reply to the automated reminder > email have been sufficient to get that fixed? > To be fair, Alfred had reminded me several times about it, and each time that I edited the list I forgot to scroll down far enough to remember it. Poor organizational skills on my part, nothing more. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 3 22:11:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE6AE16A4CE; Wed, 3 Nov 2004 22:11:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A197543D46; Wed, 3 Nov 2004 22:11:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA3MBKjC042183; Wed, 3 Nov 2004 22:11:20 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA3MBKkh042182; Wed, 3 Nov 2004 22:11:20 GMT (envelope-from jhb) Message-Id: <200411032211.iA3MBKkh042182@repoman.freebsd.org> From: John Baldwin Date: Wed, 3 Nov 2004 22:11:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_intr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 22:11:20 -0000 jhb 2004-11-03 22:11:20 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c Log: Revert most of 1.109. Although it improved the situation on one particular motherboard, in practice the changes resulted in many false positives for heavy network loads, etc. resulting in poor performance. Also, the motherboard referenced in the 1.109 log has other problems and simply does not seem to work with the APIC enabled even with the changes in 1.109. The correct fix for that board seems to be to not use the APIC at all. One thing kept from 1.109 is that throttled interrupts are now effectively polled on every clock tick rather than just 10 times per second. MFC after: 1 month Tested by: Shunsuke SHINOMIYA shino at fornext dot org Revision Changes Path 1.117 +12 -42 src/sys/kern/kern_intr.c From owner-cvs-src@FreeBSD.ORG Wed Nov 3 22:39:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97BE216A4D3 for ; Wed, 3 Nov 2004 22:39:52 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id E77CF43D5D for ; Wed, 3 Nov 2004 22:39:51 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 26879 invoked from network); 3 Nov 2004 22:39:51 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Nov 2004 22:39:51 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA3Mdjc3080119; Wed, 3 Nov 2004 17:39:47 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Wilko Bulte Date: Wed, 3 Nov 2004 17:09:49 -0500 User-Agent: KMail/1.6.2 References: <200410290824.i9T8Oflr047896@repoman.freebsd.org> <41880075.70309@freebsd.org> <20041103220237.GB37480@freebie.xs4all.nl> In-Reply-To: <20041103220237.GB37480@freebie.xs4all.nl> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411031709.49809.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 22:39:53 -0000 On Wednesday 03 November 2004 05:02 pm, Wilko Bulte wrote: > On Tue, Nov 02, 2004 at 02:47:33PM -0700, Scott Long wrote.. > > > David O'Brien wrote: > > >On Mon, Nov 01, 2004 at 02:29:38PM -0500, John Baldwin wrote: > > >>On Friday 29 October 2004 07:48 pm, Alfred Perlstein wrote: > > >>>I made 3-4 requestss, each one had an ACK that said, "sorry, right > > >>>on it!" > > >>> > > >>>It's just not acceptable. > > >> > > >>Are you volunteering to be an re@ secretary ala wilko@? > > > > > >Why does every group now need a secretary? Maybe we just need more > > >members on RE@ that are very active. > > > > With all due respect, I'd like the members of the release engineering > > team to decide what is best for them, and have less armchair > > quarterbacking of what others think we need. > > I would just like to say this: don't overengineer what aint broken. > Sjeez.. it is hardly a Supreme Court worthy case that re@ forgot to update > some stupid web page is it? > > Wouldn't a normal, if need be public, reply to the automated reminder > email have been sufficient to get that fixed? My suggestions about a secretary were trying to do two things: 1) ask if Alfred wanted to help be a solution to the problem (though that is not required), and 2) acknowledge that re@ does have a problem in that requests really do get dropped on the floor. During hectic release times re@ gets almost as much mail as current@, and that's a lot of e-mail for a handful of folks to handle. The role of a secretary would be similar to that of yourself in core@ to help keep items from slipping through the cracks, etc. Maybe this is something that I can try to work on for the next release cycle myself. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Nov 3 23:16:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94EE816A4CF; Wed, 3 Nov 2004 23:16:07 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A45D43D5F; Wed, 3 Nov 2004 23:16:07 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) iA3NG4fH067519; Wed, 3 Nov 2004 23:16:05 GMT (envelope-from davidxu@freebsd.org) Message-ID: <418966B5.4010404@freebsd.org> Date: Thu, 04 Nov 2004 07:16:05 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200411031431.16218.jhb@FreeBSD.org> In-Reply-To: <200411031431.16218.jhb@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: Daniel Eischen cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Julian Elischer cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 23:16:07 -0000 John Baldwin wrote: >On Tuesday 02 November 2004 06:40 pm, Daniel Eischen wrote: > > >>On Wed, 3 Nov 2004, David Xu wrote: >> >> >>>John Baldwin wrote: >>> >>> >>>>On Monday 01 November 2004 06:04 pm, David Xu wrote: >>>> >>>> >>>>>Not every important, I think I have another very important history >>>>>bug in hand, did you get my "fix famous libpthread conditional >>>>>variable race condition" mail ? :-) >>>>> >>>>> >>>>Oooo, can I test it please? We are still having problems with mono on >>>>HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 >>>>to libpthread but that seemed to make it worse. The problems seem to >>>>be that a signal handler is being run when the SYNCQ sflag is set (but >>>>the thread is not on a cv or a mutex queue), and the handler calls >>>>sem_post() which is supposed to be signal safe. sem_post() tries to >>>>lock a mutex and then bombs with the assertion failure. >>>> >>>> >>>You can try: >>>http://people.freebsd.org/~davidxu/kse/thr_cond.c.diff >>> >>>But it was not designed to fix the problem you have seen. :-) >>> >>> >>I think if _kse_critical_leave() were replaced by _kcb_critical_leave() >>at around line 676 in thr_kern.c, that should fix the problem, no? >>There's no reason to do a yield check after leaving the scheduler, >>and the check for signals and cancellation is done right after >>that point before returning. >> >> > >Well, it moved it. :) Now thr_sig_rundown() is called from thr_resume_check() >from thr_sched_switch_unlocked(), but psf->valid is zero, so it still doesn't >work. What would happen if the signal came in before curthread->frame was >set to &psf in thread_sched_switch_unlocked()? > > > I think the race condition is that a signal was delivered to thread before thread sets its state to PS_COND_WAIT, so the THR_LOCK_RELEASE(curthread, &(*cond)->c_lock) cause it to be handled, at the time curframe is NULL. Daniel has a fix for this problem, mine is for pthread_cond_wait() and pthread_cond_signal/broadcast race. :-) We already have a patch merged two fixes, it is being tested. From owner-cvs-src@FreeBSD.ORG Thu Nov 4 01:17:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FD3716A4CE; Thu, 4 Nov 2004 01:17:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FD0443D3F; Thu, 4 Nov 2004 01:17:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA41HWSl055080; Thu, 4 Nov 2004 01:17:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA41HVAG055079; Thu, 4 Nov 2004 01:17:31 GMT (envelope-from rwatson) Message-Id: <200411040117.iA41HVAG055079@repoman.freebsd.org> From: Robert Watson Date: Thu, 4 Nov 2004 01:17:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 01:17:32 -0000 rwatson 2004-11-04 01:17:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/kern uipc_socket.c Log: Merged uipc_socket.c:1.216 from HEAD to RELENG_5_3: date: 2004/11/02 17:15:13; author: rwatson; state: Exp; lines: +1 -0 Acquire the accept mutex in soabort() before calling sotryfree(), as that is now required. RELENG_5_3 candidate. Foot provided by: Dikshie Approved by: re (kensmith) Revision Changes Path 1.208.2.3.2.2 +1 -0 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 01:25:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CBEE16A56F; Thu, 4 Nov 2004 01:25:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F35F943D41; Thu, 4 Nov 2004 01:25:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA41PNvO055406; Thu, 4 Nov 2004 01:25:23 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA41PNmH055405; Thu, 4 Nov 2004 01:25:23 GMT (envelope-from rwatson) Message-Id: <200411040125.iA41PNmH055405@repoman.freebsd.org> From: Robert Watson Date: Thu, 4 Nov 2004 01:25:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 01:25:24 -0000 rwatson 2004-11-04 01:25:23 UTC FreeBSD src repository Modified files: sys/netinet udp_usrreq.c Log: Until this change, the UDP input code used global variables udp_in, udp_in6, and udp_ip6 to pass socket address state between udp_input(), udp_append(), and soappendaddr_locked(). While file in the default configuration, when running with multiple netisrs or direct ithread dispatch, this can result in races wherein user processes using recvmsg() get back the wrong source IP/port. To correct this and related races: - Eliminate udp_ip6, which is believed to be generated but then never used. Eliminate ip_2_ip6_hdr() as it is now unneeded. - Eliminate setting, testing, and existence of 'init' status fields for the IPv6 structures. While with multiple UDP delivery this could lead to amortization of IPv4 -> IPv6 conversion when delivering an IPv4 UDP packet to an IPv6 socket, it added substantial complexity and side effects. - Move global structures into the stack, declaring udp_in in udp_input(), and udp_in6 in udp_append() to be used if a conversion is required. Pass &udp_in into udp_append(). - Re-annotate comments to reflect updates. With this change, UDP appears to operate correctly in the presence of substantial inbound processing parallelism. This solution avoids introducing additional synchronization, but does increase the potential stack depth. Discovered by: kris (Bug Magnet) MFC after: 3 weeks Revision Changes Path 1.168 +24 -57 src/sys/netinet/udp_usrreq.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 01:28:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B2E916A4CE; Thu, 4 Nov 2004 01:28:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E041143D3F; Thu, 4 Nov 2004 01:28:43 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA41ShOa055583; Thu, 4 Nov 2004 01:28:43 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA41ShNQ055582; Thu, 4 Nov 2004 01:28:43 GMT (envelope-from obrien) Message-Id: <200411040128.iA41ShNQ055582@repoman.freebsd.org> From: "David E. O'Brien" Date: Thu, 4 Nov 2004 01:28:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 01:28:44 -0000 obrien 2004-11-04 01:28:43 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall config.c Log: Stop listening to bug reports with wrong solutions and commit a fix to the ' problem I know will work. Revision Changes Path 1.229 +1 -1 src/usr.sbin/sysinstall/config.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 01:29:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBC5A16A4CF; Thu, 4 Nov 2004 01:29:21 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D31843D49; Thu, 4 Nov 2004 01:29:21 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id iA41TKmJ018948; Wed, 3 Nov 2004 17:29:20 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id iA41TKlS018947; Wed, 3 Nov 2004 17:29:20 -0800 (PST) (envelope-from obrien) Date: Wed, 3 Nov 2004 17:29:19 -0800 From: "David O'Brien" To: Giorgos Keramidas Message-ID: <20041104012919.GA18156@dragon.nuxi.com> References: <200411011632.iA1GWA8q030777@repoman.freebsd.org> <20041101170748.GA81210@wombat.fafoe.narf.at> <20041103124033.GA34455@orion.daedalusnetworks.priv> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041103124033.GA34455@orion.daedalusnetworks.priv> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: Stefan Farfeleder cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 01:29:22 -0000 On Wed, Nov 03, 2004 at 02:40:33PM +0200, Giorgos Keramidas wrote: > I've discovered after submitting the change David committed that \' is > not enough to quote single quotes in strings quoted with single quotes > too. The correct quoting would be something like: > > vsystem("echo '# Note that BSD'\''s export syntax is \"host-centric\" vs. Sun'\''s \"FS-centric\" one.' >> /etc/exports"); This isn't a fix either -- what is '\'' supose to do? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 02:13:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D08A16A4CE; Thu, 4 Nov 2004 02:13:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D90C43D3F; Thu, 4 Nov 2004 02:13:16 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA42DF1a057130; Thu, 4 Nov 2004 02:13:15 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA42DFSn057129; Thu, 4 Nov 2004 02:13:15 GMT (envelope-from bms) Message-Id: <200411040213.iA42DFSn057129@repoman.freebsd.org> From: Bruce M Simpson Date: Thu, 4 Nov 2004 02:13:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 route.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 02:13:16 -0000 bms 2004-11-04 02:13:15 UTC FreeBSD src repository Modified files: share/man/man4 route.4 Log: Document the fact that the flags for a FreeBSD kernel routing table entry are documented in the page for route(8), not route(4). Sponsored by: eXtensible Open Router Project MFC after: 3 weeks Revision Changes Path 1.19 +6 -0 src/share/man/man4/route.4 From owner-cvs-src@FreeBSD.ORG Thu Nov 4 02:14:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8730316A4CE; Thu, 4 Nov 2004 02:14:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 676C643D41; Thu, 4 Nov 2004 02:14:38 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA42EcVY057218; Thu, 4 Nov 2004 02:14:38 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA42Ec8M057217; Thu, 4 Nov 2004 02:14:38 GMT (envelope-from bms) Message-Id: <200411040214.iA42Ec8M057217@repoman.freebsd.org> From: Bruce M Simpson Date: Thu, 4 Nov 2004 02:14:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fastfwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 02:14:38 -0000 bms 2004-11-04 02:14:38 UTC FreeBSD src repository Modified files: sys/netinet ip_fastfwd.c Log: When performing IP fast forwarding, immediately drop traffic which is destined for a blackhole route. This also means that blackhole routes do not need to be bound to lo(4) or disc(4) interfaces for the net.inet.ip.fastforwarding=1 case. Submitted by: james at towardex dot com Sponsored by: eXtensible Open Router Project MFC after: 3 weeks Revision Changes Path 1.23 +6 -0 src/sys/netinet/ip_fastfwd.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 02:15:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31A8716A4CE; Thu, 4 Nov 2004 02:15:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11E7F43D49; Thu, 4 Nov 2004 02:15:04 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA42F3bV057270; Thu, 4 Nov 2004 02:15:03 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA42F3U4057269; Thu, 4 Nov 2004 02:15:03 GMT (envelope-from bms) Message-Id: <200411040215.iA42F3U4057269@repoman.freebsd.org> From: Bruce M Simpson Date: Thu, 4 Nov 2004 02:15:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/route route.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 02:15:04 -0000 bms 2004-11-04 02:15:03 UTC FreeBSD src repository Modified files: sbin/route route.8 Log: Document the fact that blackhole routes normally need to be bound to lo(4) interfaces to have an effect, and that this is not needed when using IP fast forwarding. Sponsored by: eXtensible Open Router Project MFC after: 3 weeks Revision Changes Path 1.39 +10 -0 src/sbin/route/route.8 From owner-cvs-src@FreeBSD.ORG Thu Nov 4 05:03:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 450F816A4CE; Thu, 4 Nov 2004 05:03:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27D6743D3F; Thu, 4 Nov 2004 05:03:25 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA453Phl069339; Thu, 4 Nov 2004 05:03:25 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA453Pij069338; Thu, 4 Nov 2004 05:03:25 GMT (envelope-from kensmith) Message-Id: <200411040503.iA453Pij069338@repoman.freebsd.org> From: Ken Smith Date: Thu, 4 Nov 2004 05:03:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/usr.sbin/sysinstall index.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 05:03:25 -0000 kensmith 2004-11-04 05:03:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.sbin/sysinstall index.c Log: MFC of Rev. 1.103: > revision 1.103 > date: 2004/11/03 18:26:06; author: kensmith; state: Exp; lines: +7 -0 > Update the list of package names/descriptions. Approved by: re (scottl) Revision Changes Path 1.102.2.1 +7 -0 src/usr.sbin/sysinstall/index.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 05:04:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6BFE16A4CE; Thu, 4 Nov 2004 05:04:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7BCA43D1F; Thu, 4 Nov 2004 05:04:53 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA454riJ069382; Thu, 4 Nov 2004 05:04:53 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA454rZH069381; Thu, 4 Nov 2004 05:04:53 GMT (envelope-from kensmith) Message-Id: <200411040504.iA454rZH069381@repoman.freebsd.org> From: Ken Smith Date: Thu, 4 Nov 2004 05:04:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/usr.sbin/sysinstall index.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 05:04:54 -0000 kensmith 2004-11-04 05:04:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) usr.sbin/sysinstall index.c Log: MFC of Rev. 1.103: > revision 1.103 > date: 2004/11/03 18:26:06; author: kensmith; state: Exp; lines: +7 -0 > Update the list of package names/descriptions. Approved by: re (scottl) Revision Changes Path 1.102.4.1 +7 -0 src/usr.sbin/sysinstall/index.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 05:24:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5BDF16A4CE; Thu, 4 Nov 2004 05:24:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6901343D1F; Thu, 4 Nov 2004 05:24:29 +0000 (GMT) (envelope-from gshapiro@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA45OTVG070010; Thu, 4 Nov 2004 05:24:29 GMT (envelope-from gshapiro@repoman.freebsd.org) Received: (from gshapiro@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA45OTdx070009; Thu, 4 Nov 2004 05:24:29 GMT (envelope-from gshapiro) Message-Id: <200411040524.iA45OTdx070009@repoman.freebsd.org> From: Gregory Neil Shapiro Date: Thu, 4 Nov 2004 05:24:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/mtree BIND.chroot.dist src/etc/namedb named.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 05:24:29 -0000 gshapiro 2004-11-04 05:24:29 UTC FreeBSD src repository Modified files: etc/mtree BIND.chroot.dist etc/namedb named.conf Log: Create a separate directory for dynamic zones which is owned by the bind user (for creation of the zone journal file). This is separate from the master/ directory for security. Give an example dynamic zone in the sample named.conf. Approved by: dougb Noticed by: Eivind Olsen MFC after: 1 week Revision Changes Path 1.6 +2 -0 src/etc/mtree/BIND.chroot.dist 1.20 +14 -0 src/etc/namedb/named.conf From owner-cvs-src@FreeBSD.ORG Thu Nov 4 07:02:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8FBA16A4CF for ; Thu, 4 Nov 2004 07:02:26 +0000 (GMT) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.FreeBSD.org (Postfix) with SMTP id 23E5743D4C for ; Thu, 4 Nov 2004 07:02:26 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 61423 invoked from network); 4 Nov 2004 07:02:24 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay03.pair.com with SMTP; 4 Nov 2004 07:02:24 -0000 X-pair-Authenticated: 209.68.2.70 Date: Thu, 4 Nov 2004 01:02:23 -0600 (CST) From: Mike Silbersack To: Gleb Smirnoff In-Reply-To: <200410311739.i9VHdkTf054648@repoman.freebsd.org> Message-ID: <20041104005726.G16834@odysseus.silby.com> References: <200410311739.i9VHdkTf054648@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tap.c if_tun.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 07:02:27 -0000 On Sun, 31 Oct 2004, Gleb Smirnoff wrote: > glebius 2004-10-31 17:39:46 UTC > > FreeBSD src repository > > Modified files: > sys/net if_tap.c if_tun.c > Log: > Utilize m_uiotombuf() in device write method, instead of home-grown > implementation. This also gives a performance improvement, because > m_uiotombuf() utilizes clusters. > > Approved by: julian (mentor) > MFC after: 1 month This is only somewhat related to your commit, but since I'm thinking of it, I'll throw it out there... One of the main disappointments I had when I wrote m_uiotombuf is that I didn't have time to use it where it really should be used - in uipc_socket.c:sosend. The reason it's not there is because of the zero-copy send code, which I didn't have time to untangle. If someone had the time, it would be great to take the zero copy code, integrate it *into* m_uiotombuf, then replace the huge mess in sosend with a simple call to m_uiotombuf. This would make sosend much easier to read, and provide the benefits of zero-copy writes for many more places throughout the kernel. Whether or not zero copy send is a performance win is only a tiny side issue; if it's not actually a performance win on a particular system, then hey, at least there would be one clear place to #ifdef it out. :) Mike "Silby" Silbersack From owner-cvs-src@FreeBSD.ORG Thu Nov 4 07:14:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DE5E16A4CE; Thu, 4 Nov 2004 07:14:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D47743D1F; Thu, 4 Nov 2004 07:14:04 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA47E4Sf073177; Thu, 4 Nov 2004 07:14:04 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA47E3XZ073176; Thu, 4 Nov 2004 07:14:03 GMT (envelope-from phk) Message-Id: <200411040714.iA47E3XZ073176@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 07:14:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 07:14:04 -0000 phk 2004-11-04 07:14:03 UTC FreeBSD src repository Modified files: sys/netinet udp_usrreq.c Log: Hide udp_in6 behind #ifdef INET6 Revision Changes Path 1.169 +2 -0 src/sys/netinet/udp_usrreq.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 07:17:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A03716A4CF; Thu, 4 Nov 2004 07:17:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46B0343D39; Thu, 4 Nov 2004 07:17:09 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA47H9gH073349; Thu, 4 Nov 2004 07:17:09 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA47H8Vp073348; Thu, 4 Nov 2004 07:17:09 GMT (envelope-from phk) Message-Id: <200411040717.iA47H8Vp073348@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 07:17:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_vfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 07:17:09 -0000 phk 2004-11-04 07:17:08 UTC FreeBSD src repository Modified files: sys/geom geom_vfs.c Log: Finish cut&paste adjustments. Spotted by: tegge Revision Changes Path 1.2 +1 -1 src/sys/geom/geom_vfs.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 07:18:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49F9A16A4CE; Thu, 4 Nov 2004 07:18:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A48743D31; Thu, 4 Nov 2004 07:18:55 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA47ItZj073418; Thu, 4 Nov 2004 07:18:55 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA47It1m073417; Thu, 4 Nov 2004 07:18:55 GMT (envelope-from phk) Message-Id: <200411040718.iA47It1m073417@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 07:18:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/ntfs ntfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 07:18:55 -0000 phk 2004-11-04 07:18:54 UTC FreeBSD src repository Modified files: sys/fs/ntfs ntfs_vfsops.c Log: s/ffs/ntfs/ Fix error handling to not use VOP_CLOSE() on the disk. Spotted by: tegge Revision Changes Path 1.64 +6 -2 src/sys/fs/ntfs/ntfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 07:59:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F68216A4CE; Thu, 4 Nov 2004 07:59:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C1FE43D2D; Thu, 4 Nov 2004 07:59:58 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA47xwCY074975; Thu, 4 Nov 2004 07:59:58 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA47xvmd074974; Thu, 4 Nov 2004 07:59:57 GMT (envelope-from phk) Message-Id: <200411040759.iA47xvmd074974@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 07:59:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_physio.c kern_shutdown.c vfs_aio.c vfs_bio.c vfs_subr.c src/sys/sys buf.h src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 07:59:58 -0000 phk 2004-11-04 07:59:57 UTC FreeBSD src repository Modified files: sys/kern kern_physio.c kern_shutdown.c vfs_aio.c vfs_bio.c vfs_subr.c sys/sys buf.h sys/vm swap_pager.c Log: Remove buf->b_dev field. Revision Changes Path 1.67 +0 -1 src/sys/kern/kern_physio.c 1.168 +5 -2 src/sys/kern/kern_shutdown.c 1.180 +0 -1 src/sys/kern/vfs_aio.c 1.465 +2 -7 src/sys/kern/vfs_bio.c 1.547 +0 -2 src/sys/kern/vfs_subr.c 1.177 +0 -1 src/sys/sys/buf.h 1.261 +2 -4 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:25:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34BAC16A4CE; Thu, 4 Nov 2004 08:25:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1473A43D1D; Thu, 4 Nov 2004 08:25:04 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48P3Yw075826; Thu, 4 Nov 2004 08:25:03 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48P326075825; Thu, 4 Nov 2004 08:25:03 GMT (envelope-from ru) Message-Id: <200411040825.iA48P326075825@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Nov 2004 08:25:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libbegemot Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:25:04 -0000 ru 2004-11-04 08:25:03 UTC FreeBSD src repository Modified files: lib/libbegemot Makefile Log: Fixed "make clean". Revision Changes Path 1.2 +1 -0 src/lib/libbegemot/Makefile From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:25:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0003916A4CE; Thu, 4 Nov 2004 08:25:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4E2A43D49; Thu, 4 Nov 2004 08:25:52 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48PqpQ075918; Thu, 4 Nov 2004 08:25:52 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48Pq1m075917; Thu, 4 Nov 2004 08:25:52 GMT (envelope-from phk) Message-Id: <200411040825.iA48Pq1m075917@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 08:25:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_bio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:25:53 -0000 phk 2004-11-04 08:25:52 UTC FreeBSD src repository Modified files: sys/kern vfs_bio.c Log: whitespace Revision Changes Path 1.466 +2 -4 src/sys/kern/vfs_bio.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:29:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BB3716A4CE; Thu, 4 Nov 2004 08:29:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1916D43D4C; Thu, 4 Nov 2004 08:29:29 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48TSti076075; Thu, 4 Nov 2004 08:29:28 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48TSNm076074; Thu, 4 Nov 2004 08:29:28 GMT (envelope-from bms) Message-Id: <200411040829.iA48TSNm076074@repoman.freebsd.org> From: Bruce M Simpson Date: Thu, 4 Nov 2004 08:29:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 route.4 src/sbin/route route.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:29:29 -0000 bms 2004-11-04 08:29:28 UTC FreeBSD src repository Modified files: share/man/man4 route.4 sbin/route route.8 Log: Fix markup: .Dv -> .Va Update document dates. Prodded by: ru Revision Changes Path 1.40 +2 -2 src/sbin/route/route.8 1.20 +2 -2 src/share/man/man4/route.4 From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:31:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A90816A4CE; Thu, 4 Nov 2004 08:31:28 +0000 (GMT) Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34AC443D41; Thu, 4 Nov 2004 08:31:22 +0000 (GMT) (envelope-from keramida@ceid.upatras.gr) Received: from gothmog.gr (patr530-a041.otenet.gr [212.205.215.41]) iA48VJHO032060; Thu, 4 Nov 2004 10:31:20 +0200 Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.13.1/8.13.1) with ESMTP id iA48VIh1036923; Thu, 4 Nov 2004 10:31:18 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from giorgos@localhost) by gothmog.gr (8.13.1/8.13.1/Submit) id iA48VIVn036922; Thu, 4 Nov 2004 10:31:18 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Thu, 4 Nov 2004 10:31:18 +0200 From: Giorgos Keramidas To: "David O'Brien" Message-ID: <20041104083118.GA36569@gothmog.gr> References: <200411011632.iA1GWA8q030777@repoman.freebsd.org> <20041101170748.GA81210@wombat.fafoe.narf.at> <20041103124033.GA34455@orion.daedalusnetworks.priv> <20041104012919.GA18156@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041104012919.GA18156@dragon.nuxi.com> cc: cvs-src@freebsd.org cc: Stefan Farfeleder cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:31:28 -0000 On 2004-11-03 17:29, David O'Brien wrote: > On Wed, Nov 03, 2004 at 02:40:33PM +0200, Giorgos Keramidas wrote: > > I've discovered after submitting the change David committed that \' is > > not enough to quote single quotes in strings quoted with single quotes > > too. The correct quoting would be something like: > > > > vsystem("echo '# Note that BSD'\''s export syntax is \"host-centric\" vs. Sun'\''s \"FS-centric\" one.' >> /etc/exports"); > > This isn't a fix either -- what is '\'' supose to do? Using \' to quote a single quote does not work in 'quoted material'. It does work outside 'quoted material' though: $ echo "Sun's Solaris" Sun's Solaris $ echo 'Sun'\''s Solaris' Sun's Solaris From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:34:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D793416A4CE; Thu, 4 Nov 2004 08:34:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B511943D3F; Thu, 4 Nov 2004 08:34:57 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48Yv4f076386; Thu, 4 Nov 2004 08:34:57 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48Yv35076385; Thu, 4 Nov 2004 08:34:57 GMT (envelope-from delphij) Message-Id: <200411040834.iA48Yv35076385@repoman.freebsd.org> From: Xin LI Date: Thu, 4 Nov 2004 08:34:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/stdtime strftime.3 strftime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:34:58 -0000 delphij 2004-11-04 08:34:57 UTC FreeBSD src repository Modified files: lib/libc/stdtime strftime.3 strftime.c Log: Add glibc-style strftime(3) padding specifiers, namely, -(no padding), _(use space as padding), and 0(zero padding). These GNU extensions are widely used ones that is worthy for us to have. Discussed with: stefanf, roam, -current Approved by: murray Prodded by: ports/72722, ports/72723 MFC After: 1 month Revision Changes Path 1.35 +10 -1 src/lib/libc/stdtime/strftime.3 1.41 +69 -20 src/lib/libc/stdtime/strftime.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:35:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EE7716A5A2; Thu, 4 Nov 2004 08:35:26 +0000 (GMT) Received: from imap.univie.ac.at (mail.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id B504F43D39; Thu, 4 Nov 2004 08:35:25 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from korben.prv.univie.ac.at (korben.prv.univie.ac.at [131.130.7.98]) by imap.univie.ac.at (8.12.10/8.12.10) with ESMTP id iA48ZHMx101696; Thu, 4 Nov 2004 09:35:19 +0100 Date: Thu, 4 Nov 2004 09:35:18 +0100 (CET) From: Lukas Ertl To: "David E. O'Brien" In-Reply-To: <200411040128.iA41ShNQ055582@repoman.freebsd.org> Message-ID: <20041104093455.M563@korben.in.tern> References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-DCC-ZID-Univie-Metrics: mx9.univie.ac.at 4247; Body=4 Fuz1=4 Fuz2=4 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:35:26 -0000 On Thu, 4 Nov 2004, David E. O'Brien wrote: > obrien 2004-11-04 01:28:43 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/sysinstall config.c > Log: > Stop listening to bug reports with wrong solutions and commit a fix to the ' > problem I know will work. Does the fix that works really involve /tmp/exports? cheers, le -- Lukas Ertl http://homepage.univie.ac.at/l.ertl/ le@FreeBSD.org http://people.freebsd.org/~le/ From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:38:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 389E116A4CE; Thu, 4 Nov 2004 08:38:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1858A43D1D; Thu, 4 Nov 2004 08:38:08 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48c7PX076589; Thu, 4 Nov 2004 08:38:07 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48c7pt076588; Thu, 4 Nov 2004 08:38:07 GMT (envelope-from phk) Message-Id: <200411040838.iA48c7pt076588@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 08:38:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:38:08 -0000 phk 2004-11-04 08:38:07 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: De-couple our I/O bio request from the embedded bio in buf by explicitly copying the fields. Revision Changes Path 1.262 +6 -1 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:38:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A56016A4CF; Thu, 4 Nov 2004 08:38:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EBC143D49; Thu, 4 Nov 2004 08:38:35 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA48cYYK076623; Thu, 4 Nov 2004 08:38:34 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA48cYfq076622; Thu, 4 Nov 2004 08:38:34 GMT (envelope-from delphij) Message-Id: <200411040838.iA48cYfq076622@repoman.freebsd.org> From: Xin LI Date: Thu, 4 Nov 2004 08:38:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:38:35 -0000 delphij 2004-11-04 08:38:34 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version after addition of glibc-style strftime(3) padding specifiers. This helps the port team to decide whether to use local patch for applications that makes use of these GNU extensions (and hopefully we can get rid of these patches finally) Requested by: marcus Revision Changes Path 1.218 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:43:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 669BB16A4CE; Thu, 4 Nov 2004 08:43:37 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59EE043D49; Thu, 4 Nov 2004 08:43:37 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from freebsd.org (davidxu@localhost [127.0.0.1]) iA48hULd066899; Thu, 4 Nov 2004 08:43:34 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4189ECFC.5060808@freebsd.org> Date: Thu, 04 Nov 2004 16:49:00 +0800 From: David Xu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030723 Thunderbird/0.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Xin LI References: <200411040834.iA48Yv35076385@repoman.freebsd.org> In-Reply-To: <200411040834.iA48Yv35076385@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime strftime.3 strftime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:43:37 -0000 Will this fix ugly date text bug at up-right corner of gnome desktop ? David Xu Xin LI wrote: > delphij 2004-11-04 08:34:57 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdtime strftime.3 strftime.c > Log: > Add glibc-style strftime(3) padding specifiers, namely, -(no padding), > _(use space as padding), and 0(zero padding). > > These GNU extensions are widely used ones that is worthy for us to > have. > > Discussed with: stefanf, roam, -current > Approved by: murray > Prodded by: ports/72722, ports/72723 > MFC After: 1 month > > Revision Changes Path > 1.35 +10 -1 src/lib/libc/stdtime/strftime.3 > 1.41 +69 -20 src/lib/libc/stdtime/strftime.c > From owner-cvs-src@FreeBSD.ORG Thu Nov 4 08:54:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89AAC16A4CE; Thu, 4 Nov 2004 08:54:10 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E3F343D45; Thu, 4 Nov 2004 08:54:10 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from freefall.freebsd.org (delphij@localhost [127.0.0.1]) iA48sAFf068150; Thu, 4 Nov 2004 08:54:10 GMT (envelope-from delphij@freefall.freebsd.org) Received: (from delphij@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA48sAww068149; Thu, 4 Nov 2004 08:54:10 GMT (envelope-from delphij) Date: Thu, 4 Nov 2004 08:54:10 +0000 From: Xin LI To: David Xu Message-ID: <20041104085410.GA68066@freefall.freebsd.org> References: <200411040834.iA48Yv35076385@repoman.freebsd.org> <4189ECFC.5060808@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4189ECFC.5060808@freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime strftime.3 strftime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 08:54:10 -0000 Yes, AFAIK it fixes gdm's date representation as well without maintaining our local patches against the official version. Cheers, On Thu, Nov 04, 2004 at 04:49:00PM +0800, David Xu wrote: > Will this fix ugly date text bug at up-right corner of gnome > desktop ? > > David Xu > > Xin LI wrote: > >delphij 2004-11-04 08:34:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libc/stdtime strftime.3 strftime.c > > Log: > > Add glibc-style strftime(3) padding specifiers, namely, -(no padding), > > _(use space as padding), and 0(zero padding). From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:06:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BC1916A4CE; Thu, 4 Nov 2004 09:06:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BAD243D2F; Thu, 4 Nov 2004 09:06:56 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA496uK9084026; Thu, 4 Nov 2004 09:06:56 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA496uLf084025; Thu, 4 Nov 2004 09:06:56 GMT (envelope-from phk) Message-Id: <200411040906.iA496uLf084025@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:06:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_bio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:06:56 -0000 phk 2004-11-04 09:06:54 UTC FreeBSD src repository Modified files: sys/kern vfs_bio.c Log: Change buf->b_object to buf->b_bufobj->bo_object some whitespace fixes. Revision Changes Path 1.467 +16 -14 src/sys/kern/vfs_bio.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:11:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A289F16A4CE; Thu, 4 Nov 2004 09:11:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 815AD43D46; Thu, 4 Nov 2004 09:11:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA49BN4b084164; Thu, 4 Nov 2004 09:11:23 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA49BNak084163; Thu, 4 Nov 2004 09:11:23 GMT (envelope-from phk) Message-Id: <200411040911.iA49BNak084163@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:11:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:11:23 -0000 phk 2004-11-04 09:11:22 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_vfsops.c Log: Don't grab the exclusive bit on a root filesystem until we are willing to mount it. Doing so prevented fsck to be run after a refused mount. Revision Changes Path 1.251 +14 -14 src/sys/ufs/ffs/ffs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:15:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D26716A4CE; Thu, 4 Nov 2004 09:15:52 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id C72DB43D49; Thu, 4 Nov 2004 09:15:49 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iA49Fl2E009837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 4 Nov 2004 12:15:48 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iA49FloB009836; Thu, 4 Nov 2004 12:15:47 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Thu, 4 Nov 2004 12:15:47 +0300 From: Gleb Smirnoff To: Poul-Henning Kamp Message-ID: <20041104091547.GD9529@cell.sick.ru> References: <200411040911.iA49BNak084163@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200411040911.iA49BNak084163@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:15:52 -0000 Thanks! On Thu, Nov 04, 2004 at 09:11:22AM +0000, Poul-Henning Kamp wrote: P> phk 2004-11-04 09:11:22 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/ufs/ffs ffs_vfsops.c P> Log: P> Don't grab the exclusive bit on a root filesystem until we are willing P> to mount it. Doing so prevented fsck to be run after a refused mount. P> P> Revision Changes Path P> 1.251 +14 -14 src/sys/ufs/ffs/ffs_vfsops.c -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:17:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 003F116A4CE; Thu, 4 Nov 2004 09:17:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1A1B43D45; Thu, 4 Nov 2004 09:17:55 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA49Ht6d084482; Thu, 4 Nov 2004 09:17:55 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA49Ht6f084481; Thu, 4 Nov 2004 09:17:55 GMT (envelope-from phk) Message-Id: <200411040917.iA49Ht6f084481@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:17:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:17:56 -0000 phk 2004-11-04 09:17:55 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: Add back securelevel check for disks. XXX: This should live in geom_dev.c but we don't have access to the cred there. XXX: XXX: This may not matter anymore since filesystems use geom_vfs. Revision Changes Path 1.80 +12 -0 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:37:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B2F516A4CE; Thu, 4 Nov 2004 09:37:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A5BA43D3F; Thu, 4 Nov 2004 09:37:51 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA49bpFa085299; Thu, 4 Nov 2004 09:37:51 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA49bpEH085298; Thu, 4 Nov 2004 09:37:51 GMT (envelope-from phk) Message-Id: <200411040937.iA49bpEH085298@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:37:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys buf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:37:51 -0000 phk 2004-11-04 09:37:50 UTC FreeBSD src repository Modified files: sys/sys buf.h Log: Eliminate the embedded struct bio in struct buf. Saves approx 100-170 bytes per buf depending on architecture. Revision Changes Path 1.178 +9 -10 src/sys/sys/buf.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:48:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9820A16A4CE; Thu, 4 Nov 2004 09:48:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 757F343D45; Thu, 4 Nov 2004 09:48:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA49mIl4085739; Thu, 4 Nov 2004 09:48:18 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA49mIXJ085738; Thu, 4 Nov 2004 09:48:18 GMT (envelope-from phk) Message-Id: <200411040948.iA49mIXJ085738@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:48:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_bio.c vfs_cluster.c src/sys/nfsclient nfs_bio.c src/sys/sys buf.h src/sys/vm vm_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:48:18 -0000 phk 2004-11-04 09:48:18 UTC FreeBSD src repository Modified files: sys/kern vfs_bio.c vfs_cluster.c sys/nfsclient nfs_bio.c sys/sys buf.h sys/vm vm_pager.c Log: Retire b_magic now, we have the bufobj containing the same hint. Revision Changes Path 1.468 +0 -1 src/sys/kern/vfs_bio.c 1.158 +0 -1 src/sys/kern/vfs_cluster.c 1.139 +0 -1 src/sys/nfsclient/nfs_bio.c 1.179 +0 -3 src/sys/sys/buf.h 1.97 +0 -1 src/sys/vm/vm_pager.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:57:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02F0916A4CE; Thu, 4 Nov 2004 09:57:21 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F96843D45; Thu, 4 Nov 2004 09:57:20 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iA49uRNc014490; Thu, 4 Nov 2004 04:56:27 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iA49uR9G014487; Thu, 4 Nov 2004 04:56:27 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 4 Nov 2004 04:56:27 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Poul-Henning Kamp In-Reply-To: <200411040714.iA47E3XZ073176@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:57:21 -0000 On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: > phk 2004-11-04 07:14:03 UTC > > FreeBSD src repository > > Modified files: > sys/netinet udp_usrreq.c > Log: > Hide udp_in6 behind #ifdef INET6 Thanks for fixing that! Alan Cox also sent me an identical patch last night. This is one of those things you don't catch by building LINT, unfortunately. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Thu Nov 4 09:57:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DDA716A4E9; Thu, 4 Nov 2004 09:57:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F1F243D3F; Thu, 4 Nov 2004 09:57:22 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA49vLww086150; Thu, 4 Nov 2004 09:57:21 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA49vLIW086149; Thu, 4 Nov 2004 09:57:21 GMT (envelope-from phk) Message-Id: <200411040957.iA49vLIW086149@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 09:57:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/vinum COPYRIGHT makestatetext request.h statetexts.h vinum.c vinumconfig.c vinumdaemon.c vinumext.h vinumhdr.h vinuminterrupt.c vinumio.c vinumio.h vinumioctl.c vinumkw.h vinumlock.c vinummemory.c vinumobj.h vinumparser.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 09:57:25 -0000 phk 2004-11-04 09:57:21 UTC FreeBSD src repository Removed files: sys/dev/vinum COPYRIGHT makestatetext request.h statetexts.h vinum.c vinumconfig.c vinumdaemon.c vinumext.h vinumhdr.h vinuminterrupt.c vinumio.c vinumio.h vinumioctl.c vinumkw.h vinumlock.c vinummemory.c vinumobj.h vinumparser.c vinumraid5.c vinumrequest.c vinumrevive.c vinumstate.c vinumstate.h vinumutil.c vinumutil.h vinumvar.h Log: Remove unused vinum files. Revision Changes Path 1.5 +0 -37 src/sys/dev/vinum/COPYRIGHT (dead) 1.7 +0 -78 src/sys/dev/vinum/makestatetext (dead) 1.22 +0 -273 src/sys/dev/vinum/request.h (dead) 1.10 +0 -91 src/sys/dev/vinum/statetexts.h (dead) 1.67 +0 -542 src/sys/dev/vinum/vinum.c (dead) 1.68 +0 -2166 src/sys/dev/vinum/vinumconfig.c (dead) 1.27 +0 -283 src/sys/dev/vinum/vinumdaemon.c (dead) 1.44 +0 -261 src/sys/dev/vinum/vinumext.h (dead) 1.32 +0 -81 src/sys/dev/vinum/vinumhdr.h (dead) 1.45 +0 -473 src/sys/dev/vinum/vinuminterrupt.c (dead) 1.101 +0 -918 src/sys/dev/vinum/vinumio.c (dead) 1.24 +0 -154 src/sys/dev/vinum/vinumio.h (dead) 1.52 +0 -960 src/sys/dev/vinum/vinumioctl.c (dead) 1.24 +0 -152 src/sys/dev/vinum/vinumkw.h (dead) 1.28 +0 -266 src/sys/dev/vinum/vinumlock.c (dead) 1.37 +0 -290 src/sys/dev/vinum/vinummemory.c (dead) 1.12 +0 -321 src/sys/dev/vinum/vinumobj.h (dead) 1.34 +0 -236 src/sys/dev/vinum/vinumparser.c (dead) 1.15 +0 -700 src/sys/dev/vinum/vinumraid5.c (dead) 1.74 +0 -1125 src/sys/dev/vinum/vinumrequest.c (dead) 1.46 +0 -620 src/sys/dev/vinum/vinumrevive.c (dead) 1.35 +0 -1095 src/sys/dev/vinum/vinumstate.c (dead) 1.10 +0 -257 src/sys/dev/vinum/vinumstate.h (dead) 1.20 +0 -311 src/sys/dev/vinum/vinumutil.c (dead) 1.2 +0 -54 src/sys/dev/vinum/vinumutil.h (dead) 1.50 +0 -395 src/sys/dev/vinum/vinumvar.h (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 10:02:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B38BF16A4CE; Thu, 4 Nov 2004 10:02:31 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B84043D55; Thu, 4 Nov 2004 10:02:31 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA4A2S6D040998; Thu, 4 Nov 2004 11:02:28 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Robert Watson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 04 Nov 2004 04:56:27 EST." Date: Thu, 04 Nov 2004 11:02:28 +0100 Message-ID: <40997.1099562548@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 10:02:31 -0000 In message , Robert Watson writes: > >On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: > >> phk 2004-11-04 07:14:03 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet udp_usrreq.c >> Log: >> Hide udp_in6 behind #ifdef INET6 > >Thanks for fixing that! Alan Cox also sent me an identical patch last >night. This is one of those things you don't catch by building LINT, >unfortunately. Yeah, we need a "IPV6_HAHAHA" kernel :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Nov 4 11:01:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 987B316A4CE; Thu, 4 Nov 2004 11:01:10 +0000 (GMT) Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id A123F43D53; Thu, 4 Nov 2004 11:01:09 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])iA4B0YgV003826; Thu, 4 Nov 2004 13:00:51 +0200 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) iA4B0OiL001776; Thu, 4 Nov 2004 13:00:24 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost)iA4B0OTO001775; Thu, 4 Nov 2004 13:00:24 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Thu, 4 Nov 2004 13:00:24 +0200 From: Giorgos Keramidas To: "David E. O'Brien" Message-ID: <20041104110024.GA1685@orion.daedalusnetworks.priv> References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411040128.iA41ShNQ055582@repoman.freebsd.org> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 11:01:10 -0000 On 2004-11-04 01:28, "David E. O'Brien" wrote: > Stop listening to bug reports with wrong solutions and commit a fix to the ' > problem I know will work. > > Revision Changes Path > 1.229 +1 -1 src/usr.sbin/sysinstall/config.c I don't think this log message is very nice to the one who reported the bug or the `wrong solutions', but thanks for working on this anyway. From owner-cvs-src@FreeBSD.ORG Thu Nov 4 11:10:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5281016A4CE; Thu, 4 Nov 2004 11:10:27 +0000 (GMT) Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com [81.103.67.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1AA843D55; Thu, 4 Nov 2004 11:10:26 +0000 (GMT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.43 (FreeBSD)) id 1CPfVZ-000B3q-VO; Thu, 04 Nov 2004 11:10:25 +0000 Date: Thu, 4 Nov 2004 11:10:25 +0000 From: Ceri Davies To: "David E. O'Brien" Message-ID: <20041104111025.GG57641@submonkey.net> Mail-Followup-To: Ceri Davies , "David E. O'Brien" , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kWb2NB+iM6KO7H8g" Content-Disposition: inline In-Reply-To: <200411040128.iA41ShNQ055582@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.6i Sender: Ceri Davies cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 11:10:27 -0000 --kWb2NB+iM6KO7H8g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 04, 2004 at 01:28:43AM +0000, David E. O'Brien wrote: > obrien 2004-11-04 01:28:43 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.sbin/sysinstall config.c=20 > Log: > Stop listening to bug reports with wrong solutions and commit a fix to = the ' > problem I know will work. This line now gets written to /tmp/exports: > | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self) > | vsystem("echo '#/a -maproot=3D0 -network 10.0.1.0 -mask 255= =2E255.248.0' >> /etc/exports"); > | vsystem("echo '#' >> /etc/exports"); > | vsystem("echo '# You should replace these lines with your actual = exported filesystems.' >> /etc/exports"); > | - vsystem("echo '# Note that BSD\'s export syntax is \"host-centric= \" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > | + vsystem("echo \"# Note that BSD's export syntax is 'host-centric'= vs. Sun's 'FS-centric' one.\" >> /tmp/exports"); Also, wouldn't it just be easier to open() /etc/exports and write to it that way? I understand that this isn't how this is done anywhere else in sysinstall, but why not? Ceri --=20 --kWb2NB+iM6KO7H8g Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBig4hocfcwTS3JF8RAvvHAKCnjpd8pN4cgb6lRLbrxTIiO6Zg1gCgmrKu G5wC93y6f65TEYdYfeDY5vs= =airX -----END PGP SIGNATURE----- --kWb2NB+iM6KO7H8g-- From owner-cvs-src@FreeBSD.ORG Thu Nov 4 12:33:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6BFE16A4CF; Thu, 4 Nov 2004 12:33:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A282343D48; Thu, 4 Nov 2004 12:33:55 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4CXtxP091397; Thu, 4 Nov 2004 12:33:55 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4CXt25091396; Thu, 4 Nov 2004 12:33:55 GMT (envelope-from harti) Message-Id: <200411041233.iA4CXt25091396@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 4 Nov 2004 12:33:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph/atm/sscop ng_sscop_cust.h src/sys/netgraph/atm/uni ng_uni_cust.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 12:33:55 -0000 harti 2004-11-04 12:33:55 UTC FreeBSD src repository Modified files: sys/netgraph/atm/sscop ng_sscop_cust.h sys/netgraph/atm/uni ng_uni_cust.h Log: Adapt to the new ng_timeout/ng_untimeout arguments. These now use the callout instead of the timeout interface. Submitted by: glebius Revision Changes Path 1.2 +5 -8 src/sys/netgraph/atm/sscop/ng_sscop_cust.h 1.3 +6 -9 src/sys/netgraph/atm/uni/ng_uni_cust.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 12:46:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 324D616A4CE; Thu, 4 Nov 2004 12:46:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 259BE43D46; Thu, 4 Nov 2004 12:46:47 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4Ckl5H095419; Thu, 4 Nov 2004 12:46:47 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4Cklx5095418; Thu, 4 Nov 2004 12:46:47 GMT (envelope-from phk) Message-Id: <200411041246.iA4Cklx5095418@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 12:46:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin Makefile src/sbin/vinum Makefile commands.c list.c v.c vext.h vinum.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 12:46:47 -0000 phk 2004-11-04 12:46:47 UTC FreeBSD src repository Modified files: sbin Makefile Removed files: sbin/vinum Makefile commands.c list.c v.c vext.h vinum.8 Log: Ups! Forgot to put "sbin" on the commit line: Remove userland vinum(8) stuff. Revision Changes Path 1.144 +0 -5 src/sbin/Makefile 1.27 +0 -15 src/sbin/vinum/Makefile (dead) 1.61 +0 -2329 src/sbin/vinum/commands.c (dead) 1.41 +0 -1502 src/sbin/vinum/list.c (dead) 1.41 +0 -685 src/sbin/vinum/v.c (dead) 1.29 +0 -218 src/sbin/vinum/vext.h (dead) 1.71 +0 -2925 src/sbin/vinum/vinum.8 (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 12:57:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F16616A4CE; Thu, 4 Nov 2004 12:57:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C61A43D49; Thu, 4 Nov 2004 12:57:41 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4Cvfjr002412; Thu, 4 Nov 2004 12:57:41 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4Cvfb1002411; Thu, 4 Nov 2004 12:57:41 GMT (envelope-from phk) Message-Id: <200411041257.iA4Cvfb1002411@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 12:57:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/examples/etc make.conf src/share/man/man5 make.conf.5 src/rescue/rescue Makefile src/tools/tools/nanobsd make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 12:57:41 -0000 phk 2004-11-04 12:57:41 UTC FreeBSD src repository Modified files: share/examples/etc make.conf share/man/man5 make.conf.5 rescue/rescue Makefile tools/tools/nanobsd make.conf Log: Remove references to NO_VINUM Revision Changes Path 1.30 +0 -4 src/rescue/rescue/Makefile 1.239 +0 -1 src/share/examples/etc/make.conf 1.99 +0 -5 src/share/man/man5/make.conf.5 1.8 +0 -1 src/tools/tools/nanobsd/make.conf From owner-cvs-src@FreeBSD.ORG Thu Nov 4 12:57:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B351F16A4CF; Thu, 4 Nov 2004 12:57:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9086143D1D; Thu, 4 Nov 2004 12:57:41 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4CvfSx002445; Thu, 4 Nov 2004 12:57:41 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4CvfCo002444; Thu, 4 Nov 2004 12:57:41 GMT (envelope-from harti) Message-Id: <200411041257.iA4CvfCo002444@repoman.freebsd.org> From: Hartmut Brandt Date: Thu, 4 Nov 2004 12:57:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/make job.c job.h main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 12:57:41 -0000 harti 2004-11-04 12:57:41 UTC FreeBSD src repository Modified files: usr.bin/make job.c job.h main.c Log: Remove the remote stuff from make. This actually never worked in our make because the necessary files were not imported with the original import. If somebody really needs it, there is still the devel/pmake port. This is just the first step and removes just everything that is ifdef'ed out. Otherwise the code is unchanged. Checked by: md5 Approved by: no objections on arch@ Revision Changes Path 1.53 +49 -413 src/usr.bin/make/job.c 1.23 +0 -22 src/usr.bin/make/job.h 1.93 +1 -25 src/usr.bin/make/main.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 12:59:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7B3A16A4CE; Thu, 4 Nov 2004 12:59:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86EEF43D1D; Thu, 4 Nov 2004 12:59:16 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4CxGjS002644; Thu, 4 Nov 2004 12:59:16 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4CxG9u002643; Thu, 4 Nov 2004 12:59:16 GMT (envelope-from phk) Message-Id: <200411041259.iA4CxG9u002643@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 12:59:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d Makefile vinum X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 12:59:16 -0000 phk 2004-11-04 12:59:16 UTC FreeBSD src repository Modified files: etc/rc.d Makefile Removed files: etc/rc.d vinum Log: remove vinum startup script. Revision Changes Path 1.46 +1 -1 src/etc/rc.d/Makefile 1.4 +0 -17 src/etc/rc.d/vinum (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 13:32:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C153B16A4CE; Thu, 4 Nov 2004 13:32:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FF8A43D3F; Thu, 4 Nov 2004 13:32:24 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4DWOOu003944; Thu, 4 Nov 2004 13:32:24 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4DWOtc003943; Thu, 4 Nov 2004 13:32:24 GMT (envelope-from phk) Message-Id: <200411041332.iA4DWOtc003943@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 13:32:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/vinum Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 13:32:25 -0000 phk 2004-11-04 13:32:24 UTC FreeBSD src repository Removed files: sys/modules/vinum Makefile Log: Remove another vinum file Revision Changes Path 1.25 +0 -16 src/sys/modules/vinum/Makefile (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 13:33:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D51E416A4CE; Thu, 4 Nov 2004 13:33:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B42B443D2D; Thu, 4 Nov 2004 13:33:29 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4DXTO4004006; Thu, 4 Nov 2004 13:33:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4DXTNA004005; Thu, 4 Nov 2004 13:33:29 GMT (envelope-from ru) Message-Id: <200411041333.iA4DXTNA004005@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Nov 2004 13:33:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 13:33:30 -0000 ru 2004-11-04 13:33:29 UTC FreeBSD src repository Modified files: etc/defaults rc.conf share/man/man5 rc.conf.5 Log: Sync up with vinum(8) and rc.d/vinum removal. OK'ed by: phk Revision Changes Path 1.229 +0 -1 src/etc/defaults/rc.conf 1.235 +1 -9 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Thu Nov 4 13:34:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73C7616A4CE; Thu, 4 Nov 2004 13:34:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52BF243D5C; Thu, 4 Nov 2004 13:34:06 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4DY6aa004057; Thu, 4 Nov 2004 13:34:06 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4DY67O004056; Thu, 4 Nov 2004 13:34:06 GMT (envelope-from phk) Message-Id: <200411041334.iA4DY67O004056@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Nov 2004 13:34:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/debugscripts dot.gdbinit gdbinit.vinum X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 13:34:06 -0000 phk 2004-11-04 13:34:06 UTC FreeBSD src repository Modified files: tools/debugscripts dot.gdbinit Removed files: tools/debugscripts gdbinit.vinum Log: Remove vinum bits. Revision Changes Path 1.7 +0 -1 src/tools/debugscripts/dot.gdbinit 1.4 +0 -329 src/tools/debugscripts/gdbinit.vinum (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 14:40:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 826FE16A4CE; Thu, 4 Nov 2004 14:40:49 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 356CC43D45; Thu, 4 Nov 2004 14:40:49 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iA4EdtEA033115; Thu, 4 Nov 2004 09:39:55 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iA4Eds3P033112; Thu, 4 Nov 2004 09:39:54 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 4 Nov 2004 09:39:54 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Poul-Henning Kamp In-Reply-To: <200411040957.iA49vLIW086149@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum COPYRIGHT makestatetext request.h statetexts.h vinum.c vinumconfig.c vinumdaemon.c vinumext.h vinumhdr.h vinuminterrupt.c vinumio.c vinumio.h vinumioctl.c vinumkw.h vinumlock.c vinummemory.c vinumobj.h vinumparser.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 14:40:49 -0000 On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: > Remove unused vinum files. Should we now be renaming the gvinum command line tool to match the old name, and possibly the module as well? Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Thu Nov 4 14:45:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2596A16A4CE; Thu, 4 Nov 2004 14:45:02 +0000 (GMT) Received: from imap.univie.ac.at (mailbox-lmtp.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3809F43D1F; Thu, 4 Nov 2004 14:45:01 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from pcle2.cc.univie.ac.at (pcle2.cc.univie.ac.at [131.130.2.177]) by imap.univie.ac.at (8.12.10/8.12.10) with ESMTP id iA4EirMx165360; Thu, 4 Nov 2004 15:44:54 +0100 Date: Thu, 4 Nov 2004 15:44:50 +0100 (CET) From: Lukas Ertl To: Robert Watson In-Reply-To: Message-ID: <20041104154414.S5398@pcle2.cc.univie.ac.at> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-DCC-ZID-Univie-Metrics: mx9.univie.ac.at 4248; Body=5 Fuz1=5 Fuz2=5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum COPYRIGHT makestatetext request.h vinumhdr.hvinumlock.c vinummemory.c vinumobj.h vinumparser.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 14:45:02 -0000 On Thu, 4 Nov 2004, Robert Watson wrote: > > On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: > >> Remove unused vinum files. > > Should we now be renaming the gvinum command line tool to match the old > name, and possibly the module as well? I'd go for yes. Then I'd also like to rename the device from /dev/gvinum/foo to /dev/vinum/foo. cheers, le -- Lukas Ertl http://homepage.univie.ac.at/l.ertl/ le@FreeBSD.org http://people.freebsd.org/~le/ From owner-cvs-src@FreeBSD.ORG Thu Nov 4 14:46:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35BD516A4CE; Thu, 4 Nov 2004 14:46:58 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9063443D6B; Thu, 4 Nov 2004 14:46:57 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA4EkuN5046804; Thu, 4 Nov 2004 15:46:56 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Lukas Ertl From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 04 Nov 2004 15:44:50 +0100." <20041104154414.S5398@pcle2.cc.univie.ac.at> Date: Thu, 04 Nov 2004 15:46:56 +0100 Message-ID: <46803.1099579616@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum COPYRIGHT makestatetext request.h statetexts.h vinum.c vinumconfig.c vinumdaemon.c vinumext.h vinumhdr.h vinuminterrupt.c vinumio.c vinumio.h vinumioctl.c vinumkw.h vinumlock.c vinummemory.c vinumobj.h vinumparser.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 14:46:58 -0000 In message <20041104154414.S5398@pcle2.cc.univie.ac.at>, Lukas Ertl writes: >On Thu, 4 Nov 2004, Robert Watson wrote: > >> >> On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: >> >>> Remove unused vinum files. >> >> Should we now be renaming the gvinum command line tool to match the old >> name, and possibly the module as well? > >I'd go for yes. Then I'd also like to rename the device from >/dev/gvinum/foo to /dev/vinum/foo. I abstain totally, this is your baby, you get to decide :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Nov 4 14:47:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B08316A4CF; Thu, 4 Nov 2004 14:47:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E81D43D73; Thu, 4 Nov 2004 14:47:16 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4ElFbR007630; Thu, 4 Nov 2004 14:47:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4ElFQ4007629; Thu, 4 Nov 2004 14:47:15 GMT (envelope-from ru) Message-Id: <200411041447.iA4ElFQ4007629@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Nov 2004 14:47:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 Makefile gdb.4 vinumdebug.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 14:47:16 -0000 ru 2004-11-04 14:47:15 UTC FreeBSD src repository Modified files: share/man/man4 Makefile gdb.4 Removed files: share/man/man4 vinumdebug.4 Log: Sync up with gdbinit.vinum removal. OK'ed by: phk Revision Changes Path 1.289 +0 -1 src/share/man/man4/Makefile 1.10 +0 -1 src/share/man/man4/gdb.4 1.3 +0 -100 src/share/man/man4/vinumdebug.4 (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 4 15:09:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C533816A4CE; Thu, 4 Nov 2004 15:09:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A33BA43D45; Thu, 4 Nov 2004 15:09:27 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4F9RsV008678; Thu, 4 Nov 2004 15:09:27 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4F9R0Y008677; Thu, 4 Nov 2004 15:09:27 GMT (envelope-from hrs) Message-Id: <200411041509.iA4F9R0Y008677@repoman.freebsd.org> From: Hiroki Sato Date: Thu, 4 Nov 2004 15:09:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 15:09:27 -0000 hrs 2004-11-04 15:09:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: New errata: bsdtar(1) does not detect the end of a media. Reported by: oliver Approved by: re (implicitly) Revision Changes Path 1.69.2.6 +6 -0 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Thu Nov 4 15:20:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BE0216A4CE; Thu, 4 Nov 2004 15:20:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CC3743D4C; Thu, 4 Nov 2004 15:20:27 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4FKRv4009285; Thu, 4 Nov 2004 15:20:27 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4FKR9k009284; Thu, 4 Nov 2004 15:20:27 GMT (envelope-from nyan) Message-Id: <200411041520.iA4FKR9k009284@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Thu, 4 Nov 2004 15:20:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 15:20:27 -0000 nyan 2004-11-04 15:20:27 UTC FreeBSD src repository Modified files: sys/pc98/conf GENERIC Log: MFi386: revision 1.420 (Reduce annoying SCSI probing delay). Revision Changes Path 1.260 +1 -1 src/sys/pc98/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Thu Nov 4 15:47:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4659116A4CE; Thu, 4 Nov 2004 15:47:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 265EA43D62; Thu, 4 Nov 2004 15:47:00 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4Fl0ZR010065; Thu, 4 Nov 2004 15:47:00 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4Fl0Yp010064; Thu, 4 Nov 2004 15:47:00 GMT (envelope-from obrien) Message-Id: <200411041547.iA4Fl0Yp010064@repoman.freebsd.org> From: "David E. O'Brien" Date: Thu, 4 Nov 2004 15:47:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 15:47:00 -0000 obrien 2004-11-04 15:47:00 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall config.c Log: Fix braino where I didn't fix the file path from when the line was copied from the test program. Revision Changes Path 1.230 +1 -1 src/usr.sbin/sysinstall/config.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:48:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFCEA16A4CE; Thu, 4 Nov 2004 18:48:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DB7143D6A; Thu, 4 Nov 2004 18:48:52 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4ImqPc026961; Thu, 4 Nov 2004 18:48:52 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4ImquC026960; Thu, 4 Nov 2004 18:48:52 GMT (envelope-from cognet) Message-Id: <200411041848.iA4ImquC026960@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 18:48:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm elf_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:48:52 -0000 cognet 2004-11-04 18:48:52 UTC FreeBSD src repository Modified files: sys/arm/arm elf_machdep.c Log: Get kernel modules to work. Revision Changes Path 1.5 +9 -8 src/sys/arm/arm/elf_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:51:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 703FC16A4CF; Thu, 4 Nov 2004 18:51:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4FB4043D39; Thu, 4 Nov 2004 18:51:31 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4IpV39027129; Thu, 4 Nov 2004 18:51:31 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4IpV2V027128; Thu, 4 Nov 2004 18:51:31 GMT (envelope-from scottl) Message-Id: <200411041851.iA4IpV2V027128@repoman.freebsd.org> From: Scott Long Date: Thu, 4 Nov 2004 18:51:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:51:31 -0000 scottl 2004-11-04 18:51:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/conf newvers.sh Log: Move back up to 5.3-RELEASE Approved by: re Revision Changes Path 1.62.2.15.2.5 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:52:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA63C16A4CE; Thu, 4 Nov 2004 18:52:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B87DF43D69; Thu, 4 Nov 2004 18:52:55 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4Iqtve027222; Thu, 4 Nov 2004 18:52:55 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4IqtSG027221; Thu, 4 Nov 2004 18:52:55 GMT (envelope-from scottl) Message-Id: <200411041852.iA4IqtSG027221@repoman.freebsd.org> From: Scott Long Date: Thu, 4 Nov 2004 18:52:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:52:56 -0000 scottl 2004-11-04 18:52:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) . UPDATING Log: New date for 5.3-RELEASE Approved by: re Revision Changes Path 1.342.2.13.2.2 +1 -1 src/UPDATING From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:56:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2129916A4CE; Thu, 4 Nov 2004 18:56:01 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id A166343D2F; Thu, 4 Nov 2004 18:56:00 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) iA4ItamX054449; Thu, 4 Nov 2004 13:55:37 -0500 (EST) (envelope-from marcus@marcuscom.com) Date: Thu, 4 Nov 2004 13:55:11 -0500 (EST) From: Joe Marcus Clarke To: Xin LI In-Reply-To: <200411040834.iA48Yv35076385@repoman.freebsd.org> Message-ID: <20041104135432.V41340@shumai.marcuscom.com> References: <200411040834.iA48Yv35076385@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on creme-brulee.marcuscom.com cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime strftime.3 strftime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:56:01 -0000 On Thu, 4 Nov 2004, Xin LI wrote: > delphij 2004-11-04 08:34:57 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdtime strftime.3 strftime.c > Log: > Add glibc-style strftime(3) padding specifiers, namely, -(no padding), > _(use space as padding), and 0(zero padding). > > These GNU extensions are widely used ones that is worthy for us to > have. Thanks! Please bump __FreeBSD_version so I have something with which I can check for gnomepanel and gdm. Joe PGP Key : http://www.marcuscom.com/pgp.asc From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:56:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2D2B16A4CE; Thu, 4 Nov 2004 18:56:19 +0000 (GMT) Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com [81.103.67.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D02743D49; Thu, 4 Nov 2004 18:56:19 +0000 (GMT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.43 (FreeBSD)) id 1CPmmR-000EEA-08; Thu, 04 Nov 2004 18:56:19 +0000 Date: Thu, 4 Nov 2004 18:56:18 +0000 From: Ceri Davies To: Scott Long Message-ID: <20041104185618.GK57641@submonkey.net> Mail-Followup-To: Ceri Davies , Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200411041852.iA4IqtSG027221@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UZbF713KgFe4yePC" Content-Disposition: inline In-Reply-To: <200411041852.iA4IqtSG027221@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.6i Sender: Ceri Davies cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:56:20 -0000 --UZbF713KgFe4yePC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 04, 2004 at 06:52:55PM +0000, Scott Long wrote: > scottl 2004-11-04 18:52:55 UTC >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_5_3) > . UPDATING=20 > Log: > New date for 5.3-RELEASE Typo alert! > | @@ -8,7 +8,7 @@ Items affecting the ports and packages s > | /usr/ports/UPDATING. Please read that file before running > | portupgrade. Important recent entries: 20040724 (default X changes). > | =20 > | -20041024: > | +200411104: > | FreeBSD 5.3-RELEASE One too many ones (if that makes any sense!). Ceri --=20 --UZbF713KgFe4yePC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBintSocfcwTS3JF8RAnmXAJ9bbaxL4njfqD1s/Or7NBzordmPXQCfXE4M ejIQHnekLLXh8Kxhl5v/dTw= =meXW -----END PGP SIGNATURE----- --UZbF713KgFe4yePC-- From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:57:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E3B816A4CE; Thu, 4 Nov 2004 18:57:15 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id A237943D55; Thu, 4 Nov 2004 18:57:14 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) iA4IutFQ054467; Thu, 4 Nov 2004 13:56:55 -0500 (EST) (envelope-from marcus@marcuscom.com) Date: Thu, 4 Nov 2004 13:56:30 -0500 (EST) From: Joe Marcus Clarke To: Xin LI In-Reply-To: <200411040838.iA48cYfq076622@repoman.freebsd.org> Message-ID: <20041104135600.F41340@shumai.marcuscom.com> References: <200411040838.iA48cYfq076622@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on creme-brulee.marcuscom.com cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:57:15 -0000 On Thu, 4 Nov 2004, Xin LI wrote: > delphij 2004-11-04 08:38:34 UTC > > FreeBSD src repository > > Modified files: > sys/sys param.h > Log: > Bump __FreeBSD_version after addition of glibc-style strftime(3) padding > specifiers. > > This helps the port team to decide whether to use local patch for > applications that makes use of these GNU extensions (and hopefully we > can get rid of these patches finally) > > Requested by: marcus I spoke too soon. Thanks again! I'll fix gnomepanel and gdm ASAP. Joe PGP Key : http://www.marcuscom.com/pgp.asc From owner-cvs-src@FreeBSD.ORG Thu Nov 4 18:59:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8058916A4CE; Thu, 4 Nov 2004 18:59:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E6D043D31; Thu, 4 Nov 2004 18:59:02 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4Ix298027456; Thu, 4 Nov 2004 18:59:02 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4Ix2K3027455; Thu, 4 Nov 2004 18:59:02 GMT (envelope-from cognet) Message-Id: <200411041859.iA4Ix2K3027455@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 18:59:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 18:59:02 -0000 cognet 2004-11-04 18:59:02 UTC FreeBSD src repository Modified files: sys/arm/arm vm_machdep.c Log: Implement cpu_set_upcall and cpu_set_upcall_kse. Calculate td_frame and td_pcb the right way in cpu_thread_setup. Revision Changes Path 1.5 +29 -4 src/sys/arm/arm/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:04:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B013E16A4CE; Thu, 4 Nov 2004 19:04:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EF2243D1D; Thu, 4 Nov 2004 19:04:30 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4J4U4b027752; Thu, 4 Nov 2004 19:04:30 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4J4Ug6027751; Thu, 4 Nov 2004 19:04:30 GMT (envelope-from cognet) Message-Id: <200411041904.iA4J4Ug6027751@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:04:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:04:30 -0000 cognet 2004-11-04 19:04:30 UTC FreeBSD src repository Modified files: sys/arm/arm machdep.c Log: Implement cpu_thread_siginfo() and set_mcontext(). Nuke getframe(), and choose which stack to use directly in sendsig(). Revision Changes Path 1.7 +46 -53 src/sys/arm/arm/machdep.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:07:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F093516A4CF; Thu, 4 Nov 2004 19:07:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD90843D31; Thu, 4 Nov 2004 19:07:28 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4J7SEF028003; Thu, 4 Nov 2004 19:07:28 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4J7Sb4028002; Thu, 4 Nov 2004 19:07:28 GMT (envelope-from cognet) Message-Id: <200411041907.iA4J7Sb4028002@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:07:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include endian.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:07:29 -0000 cognet 2004-11-04 19:07:28 UTC FreeBSD src repository Modified files: sys/arm/include endian.h Log: Use casts to enforce the return type of bswap16() and bswap32(). Revision Changes Path 1.6 +6 -6 src/sys/arm/include/endian.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:10:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D373F16A4CF; Thu, 4 Nov 2004 19:10:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF30243D39; Thu, 4 Nov 2004 19:10:51 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JApFh028199; Thu, 4 Nov 2004 19:10:51 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JAp4P028198; Thu, 4 Nov 2004 19:10:51 GMT (envelope-from scottl) Message-Id: <200411041910.iA4JAp4P028198@repoman.freebsd.org> From: Scott Long Date: Thu, 4 Nov 2004 19:10:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:10:52 -0000 scottl 2004-11-04 19:10:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) share/misc bsd-family-tree Log: Update the BSD family tree for OpenBSD 3.6 and the new 5.3 date Approved by: re Revision Changes Path 1.82.2.2 +5 -4 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:11:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2368C16A4CE; Thu, 4 Nov 2004 19:11:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2DBC43D2F; Thu, 4 Nov 2004 19:11:55 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JBtWW028257; Thu, 4 Nov 2004 19:11:55 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JBt4i028256; Thu, 4 Nov 2004 19:11:55 GMT (envelope-from scottl) Message-Id: <200411041911.iA4JBt4i028256@repoman.freebsd.org> From: Scott Long Date: Thu, 4 Nov 2004 19:11:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:11:56 -0000 scottl 2004-11-04 19:11:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) share/misc bsd-family-tree Log: Update the BSD Family tree for OpenBSD 3.6 and the new 5.3 date Approved by: re Revision Changes Path 1.82.4.2 +5 -4 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:12:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE7C116A4CE; Thu, 4 Nov 2004 19:12:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D60D43D46; Thu, 4 Nov 2004 19:12:42 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JCgJG028377; Thu, 4 Nov 2004 19:12:42 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JCgIh028369; Thu, 4 Nov 2004 19:12:42 GMT (envelope-from scottl) Message-Id: <200411041912.iA4JCgIh028369@repoman.freebsd.org> From: Scott Long Date: Thu, 4 Nov 2004 19:12:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:12:42 -0000 scottl 2004-11-04 19:12:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) . UPDATING Log: Oops, correct date for 5.3 Approved by: re Revision Changes Path 1.342.2.13.2.3 +1 -1 src/UPDATING From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:12:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2847316A50D; Thu, 4 Nov 2004 19:12:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19B9443D46; Thu, 4 Nov 2004 19:12:44 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JChLO028474; Thu, 4 Nov 2004 19:12:43 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JChtN028473; Thu, 4 Nov 2004 19:12:43 GMT (envelope-from ceri) Message-Id: <200411041912.iA4JChtN028473@repoman.freebsd.org> From: Ceri Davies Date: Thu, 4 Nov 2004 19:12:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/concat gconcat.8src/sbin/geom/class/label glabel.8 src/sbin/geom/class/mirror gmirror.8 src/sbin/geom/class/nop gnop.8 src/sbin/geom/class/raid3 graid3.8 src/sbin/geom/class/stripe gstripe.8 src/sbin/geom/core geom.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:12:46 -0000 ceri 2004-11-04 19:12:43 UTC FreeBSD src repository (doc committer) Modified files: sbin/geom/class/concat gconcat.8 sbin/geom/class/label glabel.8 sbin/geom/class/mirror gmirror.8 sbin/geom/class/nop gnop.8 sbin/geom/class/raid3 graid3.8 sbin/geom/class/stripe gstripe.8 sbin/geom/core geom.8 Log: Grammatical and spelling improvements. Reviewed by: pjd Revision Changes Path 1.12 +2 -2 src/sbin/geom/class/concat/gconcat.8 1.7 +4 -4 src/sbin/geom/class/label/glabel.8 1.6 +21 -21 src/sbin/geom/class/mirror/gmirror.8 1.13 +6 -6 src/sbin/geom/class/nop/gnop.8 1.9 +22 -21 src/sbin/geom/class/raid3/graid3.8 1.17 +8 -8 src/sbin/geom/class/stripe/gstripe.8 1.8 +2 -2 src/sbin/geom/core/geom.8 From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:14:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D20D916A4CE; Thu, 4 Nov 2004 19:14:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0C3543D62; Thu, 4 Nov 2004 19:14:50 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JEoIo028668; Thu, 4 Nov 2004 19:14:50 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JEohY028667; Thu, 4 Nov 2004 19:14:50 GMT (envelope-from cognet) Message-Id: <200411041914.iA4JEohY028667@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:14:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include atomic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:14:51 -0000 cognet 2004-11-04 19:14:50 UTC FreeBSD src repository Modified files: sys/arm/include atomic.h Log: Try to implement atomic operations using swp, instead of disabling interrupts. Revision Changes Path 1.2 +65 -76 src/sys/arm/include/atomic.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:15:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CE1316A4CE; Thu, 4 Nov 2004 19:15:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB5C643D31; Thu, 4 Nov 2004 19:15:43 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JFhkx028789; Thu, 4 Nov 2004 19:15:43 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JFhLA028788; Thu, 4 Nov 2004 19:15:43 GMT (envelope-from cognet) Message-Id: <200411041915.iA4JFhLA028788@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:15:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include cpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:15:44 -0000 cognet 2004-11-04 19:15:43 UTC FreeBSD src repository Modified files: sys/arm/include cpu.h Log: Implement get_cyclecount(). Revision Changes Path 1.3 +7 -1 src/sys/arm/include/cpu.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:16:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9737516A4CE; Thu, 4 Nov 2004 19:16:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7629143D31; Thu, 4 Nov 2004 19:16:31 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JGVva028864; Thu, 4 Nov 2004 19:16:31 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JGVTh028863; Thu, 4 Nov 2004 19:16:31 GMT (envelope-from cognet) Message-Id: <200411041916.iA4JGVTh028863@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:16:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include cpuconf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:16:31 -0000 cognet 2004-11-04 19:16:31 UTC FreeBSD src repository Modified files: sys/arm/include cpuconf.h Log: Don't barf if no CPU type is defined while compiling kernel modules. Revision Changes Path 1.2 +2 -2 src/sys/arm/include/cpuconf.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:18:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6951916A4CE; Thu, 4 Nov 2004 19:18:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4788D43D69; Thu, 4 Nov 2004 19:18:19 +0000 (GMT) (envelope-from paul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JIJL8028944; Thu, 4 Nov 2004 19:18:19 GMT (envelope-from paul@repoman.freebsd.org) Received: (from paul@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JIJsd028943; Thu, 4 Nov 2004 19:18:19 GMT (envelope-from paul) Message-Id: <200411041918.iA4JIJsd028943@repoman.freebsd.org> From: Paul Richards Date: Thu, 4 Nov 2004 19:18:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:18:19 -0000 paul 2004-11-04 19:18:19 UTC FreeBSD src repository Modified files: usr.bin/tail extern.h forward.c tail.c Log: Add support for following more than one file i.e. tail -f file1 file2 Revision Changes Path 1.9 +10 -1 src/usr.bin/tail/extern.h 1.35 +160 -88 src/usr.bin/tail/forward.c 1.18 +30 -7 src/usr.bin/tail/tail.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:18:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F238B16A4CE; Thu, 4 Nov 2004 19:18:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D03A043D58; Thu, 4 Nov 2004 19:18:50 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JIoQm028985; Thu, 4 Nov 2004 19:18:50 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JIoJm028984; Thu, 4 Nov 2004 19:18:50 GMT (envelope-from cognet) Message-Id: <200411041918.iA4JIoJm028984@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:18:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include cpufunc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:18:51 -0000 cognet 2004-11-04 19:18:50 UTC FreeBSD src repository Modified files: sys/arm/include cpufunc.h Log: Use interrupts_disable() and interrupts_restore() as intr_disable() and intr_restore() instead of re-implement it. Revision Changes Path 1.4 +6 -24 src/sys/arm/include/cpufunc.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:19:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CD8916A4CE; Thu, 4 Nov 2004 19:19:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B76843D5C; Thu, 4 Nov 2004 19:19:21 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JJLDU029028; Thu, 4 Nov 2004 19:19:21 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JJLZW029027; Thu, 4 Nov 2004 19:19:21 GMT (envelope-from cognet) Message-Id: <200411041919.iA4JJLZW029027@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:19:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:19:21 -0000 cognet 2004-11-04 19:19:21 UTC FreeBSD src repository Modified files: sys/arm/include param.h Log: Decrease KSTACK_PAGES and UAREA_PAGES. Revision Changes Path 1.7 +2 -2 src/sys/arm/include/param.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:19:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89BF716A4CE; Thu, 4 Nov 2004 19:19:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69FD843D5E; Thu, 4 Nov 2004 19:19:44 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JJirC029069; Thu, 4 Nov 2004 19:19:44 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JJiS7029068; Thu, 4 Nov 2004 19:19:44 GMT (envelope-from cognet) Message-Id: <200411041919.iA4JJiS7029068@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:19:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include pcpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:19:44 -0000 cognet 2004-11-04 19:19:44 UTC FreeBSD src repository Modified files: sys/arm/include pcpu.h Log: Directly use __pcpu for PCPU_* instead of pcpup. Revision Changes Path 1.2 +4 -3 src/sys/arm/include/pcpu.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 19:20:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CAF116A4CE; Thu, 4 Nov 2004 19:20:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF5EA43D66; Thu, 4 Nov 2004 19:20:54 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4JKs1J029196; Thu, 4 Nov 2004 19:20:54 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4JKsHB029195; Thu, 4 Nov 2004 19:20:54 GMT (envelope-from cognet) Message-Id: <200411041920.iA4JKsHB029195@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 4 Nov 2004 19:20:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include reg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 19:20:55 -0000 cognet 2004-11-04 19:20:54 UTC FreeBSD src repository Modified files: sys/arm/include reg.h Log: Protect the function declarations with #ifdef _KERNEL. Revision Changes Path 1.2 +2 -0 src/sys/arm/include/reg.h From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:01:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B82216A4CE; Thu, 4 Nov 2004 20:01:25 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF3B243D45; Thu, 4 Nov 2004 20:01:24 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id iA4K1NWi036432 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Thu, 4 Nov 2004 12:01:24 -0800 (PST) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Paul Richards Date: Thu, 4 Nov 2004 12:08:51 -0800 User-Agent: KMail/1.7 References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> In-Reply-To: <200411041918.iA4JIJsd028943@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200411041208.51978.sam@errno.com> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:01:25 -0000 On Thursday 04 November 2004 11:18 am, Paul Richards wrote: > paul 2004-11-04 19:18:19 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tail extern.h forward.c tail.c > Log: > Add support for following more than one file i.e. > tail -f file1 file2 > > Revision Changes Path > 1.9 +10 -1 src/usr.bin/tail/extern.h > http://cvsweb.FreeBSD.org/src/usr.bin/tail/extern.h.diff?r1=1.8&r2=1.9 > 1.35 +160 -88 src/usr.bin/tail/forward.c > http://cvsweb.FreeBSD.org/src/usr.bin/tail/forward.c.diff?r1=1.34&r2=1.35 > 1.18 +30 -7 src/usr.bin/tail/tail.c > http://cvsweb.FreeBSD.org/src/usr.bin/tail/tail.c.diff?r1=1.17&r2=1.18 Why is this better than tail -f file1& tail -f file2 Sam From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:03:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9448316A4CE; Thu, 4 Nov 2004 20:03:50 +0000 (GMT) Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com [81.103.67.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 439B343D1F; Thu, 4 Nov 2004 20:03:50 +0000 (GMT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.43 (FreeBSD)) id 1CPnpl-000Esb-Kf; Thu, 04 Nov 2004 20:03:49 +0000 Date: Thu, 4 Nov 2004 20:03:49 +0000 From: Ceri Davies To: Sam Leffler Message-ID: <20041104200349.GP57641@submonkey.net> Mail-Followup-To: Ceri Davies , Sam Leffler , Paul Richards , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> <200411041208.51978.sam@errno.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xvHfTupNqIESFprb" Content-Disposition: inline In-Reply-To: <200411041208.51978.sam@errno.com> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.6i Sender: Ceri Davies cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Paul Richards Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:03:50 -0000 --xvHfTupNqIESFprb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 04, 2004 at 12:08:51PM -0800, Sam Leffler wrote: > On Thursday 04 November 2004 11:18 am, Paul Richards wrote: > > paul 2004-11-04 19:18:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/tail extern.h forward.c tail.c > > Log: > > Add support for following more than one file i.e. > > tail -f file1 file2 > > > > Revision Changes Path > > 1.9 +10 -1 src/usr.bin/tail/extern.h > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/extern.h.diff?r1=3D1.8&r2=3D= 1.9 > > 1.35 +160 -88 src/usr.bin/tail/forward.c > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/forward.c.diff?r1=3D1.34&r2= =3D1.35 > > 1.18 +30 -7 src/usr.bin/tail/tail.c > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/tail.c.diff?r1=3D1.17&r2=3D1= =2E18 >=20 > Why is this better than >=20 > tail -f file1& > tail -f file2 It tells you which file you're getting output from. Ceri --=20 --xvHfTupNqIESFprb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBioslocfcwTS3JF8RAjlvAKCqmmTSjqqJdwM66arwp4JbNH7u7QCgxoAy bv/KW7jWODfWZaGN+tU0pJc= =vASv -----END PGP SIGNATURE----- --xvHfTupNqIESFprb-- From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:05:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0006816A4CE; Thu, 4 Nov 2004 20:05:24 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id C80AD43D2F; Thu, 4 Nov 2004 20:05:24 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id iA4K5OWi036460 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Thu, 4 Nov 2004 12:05:24 -0800 (PST) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Ceri Davies Date: Thu, 4 Nov 2004 12:12:51 -0800 User-Agent: KMail/1.7 References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> <200411041208.51978.sam@errno.com> <20041104200349.GP57641@submonkey.net> In-Reply-To: <20041104200349.GP57641@submonkey.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200411041212.52277.sam@errno.com> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Paul Richards Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:05:25 -0000 On Thursday 04 November 2004 12:03 pm, Ceri Davies wrote: > On Thu, Nov 04, 2004 at 12:08:51PM -0800, Sam Leffler wrote: > > On Thursday 04 November 2004 11:18 am, Paul Richards wrote: > > > paul 2004-11-04 19:18:19 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > usr.bin/tail extern.h forward.c tail.c > > > Log: > > > Add support for following more than one file i.e. > > > tail -f file1 file2 > > > > > > Revision Changes Path > > > 1.9 +10 -1 src/usr.bin/tail/extern.h > > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/extern.h.diff?r1=1.8&r2=1.9 > > > 1.35 +160 -88 src/usr.bin/tail/forward.c > > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/forward.c.diff?r1=1.34&r2=1. > > >35 1.18 +30 -7 src/usr.bin/tail/tail.c > > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/tail.c.diff?r1=1.17&r2=1.18 > > > > Why is this better than > > > > tail -f file1& > > tail -f file2 > > It tells you which file you're getting output from. Why not just add an option to tag output with the filename? Sam From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:05:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8144916A4CE; Thu, 4 Nov 2004 20:05:46 +0000 (GMT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AB0D43D46; Thu, 4 Nov 2004 20:05:46 +0000 (GMT) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1]) by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id iA4K5Yaa089653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.lcs.mit.edu issuer=SSL+20Client+20CA); Thu, 4 Nov 2004 15:05:34 -0500 (EST) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id iA4K5Yvi089650; Thu, 4 Nov 2004 15:05:34 -0500 (EST) (envelope-from wollman) Date: Thu, 4 Nov 2004 15:05:34 -0500 (EST) From: Garrett Wollman Message-Id: <200411042005.iA4K5Yvi089650@khavrinen.lcs.mit.edu> To: Sam Leffler In-Reply-To: <200411041208.51978.sam@errno.com> References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> <200411041208.51978.sam@errno.com> X-Spam-Score: -9.9 () IN_REP_TO,REFERENCES X-Scanned-By: MIMEDefang 2.37 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:05:46 -0000 < said: > Why is this better than > tail -f file1& > tail -f file2 ITYM: oldflags="$(stty -g)" stty -tostop tail -f file 1 & tail -f file2 stty ${oldflags} -GAWollman From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:51:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A906316A4CE; Thu, 4 Nov 2004 20:51:18 +0000 (GMT) Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47FE043D68; Thu, 4 Nov 2004 20:51:18 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp4.server.rpi.edu (8.13.0/8.13.0) with ESMTP id iA4KpDO9032492; Thu, 4 Nov 2004 15:51:15 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200411041918.iA4JIJsd028943@repoman.freebsd.org> References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> Date: Thu, 4 Nov 2004 15:51:13 -0400 To: Paul Richards , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:51:18 -0000 At 7:18 PM +0000 11/4/04, Paul Richards wrote: >paul 2004-11-04 19:18:19 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tail extern.h forward.c tail.c > Log: > Add support for following more than one file i.e. > tail -f file1 file2 I have often wanted that. Thanks. [of course, I might have some suggestions once I see how it works in practice... :-) ] -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Thu Nov 4 20:54:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F68416A501 for ; Thu, 4 Nov 2004 20:54:49 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id D078043D54 for ; Thu, 4 Nov 2004 20:54:48 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 1639 invoked from network); 4 Nov 2004 20:54:48 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 4 Nov 2004 20:54:47 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA4KsIlH088385; Thu, 4 Nov 2004 15:54:38 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Poul-Henning Kamp" Date: Thu, 4 Nov 2004 15:14:17 -0500 User-Agent: KMail/1.6.2 References: <23321.1099505551@critter.freebsd.dk> In-Reply-To: <23321.1099505551@critter.freebsd.dk> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411041514.17726.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Luigi Rizzo cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 20:54:49 -0000 On Wednesday 03 November 2004 01:12 pm, Poul-Henning Kamp wrote: > In message <200411031408.03949.jhb@FreeBSD.org>, John Baldwin writes: > >I think bootverbose needs to be split up some. Imagine having a > >'verbose.ether' tunable that would turn on dumping all the MAC addresses > > for NICs but would be off by default. Many of the interrupt messages on > > x86 need to move from bootverbose to some kind of apic_verbose. Might > > even be nice to have some kind of acpi-like verbose variable that could > > be set as: > > > >set verbose="boot,apic,ether" > > I think that would be overkill. Well, an apic_verbose and possibly pci_intr_verbose is coming regardless. When I need info to debug problems with interrupt routing, etc. boot -v is just too much to wade through. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Nov 4 21:30:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EDE316A4CE; Thu, 4 Nov 2004 21:30:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B70943D54; Thu, 4 Nov 2004 21:30:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4LUJdl039607; Thu, 4 Nov 2004 21:30:19 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4LUIkw039606; Thu, 4 Nov 2004 21:30:18 GMT (envelope-from glebius) Message-Id: <200411042130.iA4LUIkw039606@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 4 Nov 2004 21:30:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 21:30:19 -0000 glebius 2004-11-04 21:30:18 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Partically backout previous commit. Since _callout_stop_safe() clears out c->c_func, we can't take it after callout_stop(). To take it before we need to acquire callout_lock, to avoid race. This commit narrows down area where lock is held, but hack is still present. This should be redesigned. Approved by: julian (mentor) Revision Changes Path 1.86 +7 -2 src/sys/netgraph/ng_base.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 22:13:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0363216A4CE; Thu, 4 Nov 2004 22:13:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6BB543D53; Thu, 4 Nov 2004 22:13:16 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4MDG8o041247; Thu, 4 Nov 2004 22:13:16 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4MDG64041246; Thu, 4 Nov 2004 22:13:16 GMT (envelope-from davidxu) Message-Id: <200411042213.iA4MDG64041246@repoman.freebsd.org> From: David Xu Date: Thu, 4 Nov 2004 22:13:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 22:13:17 -0000 davidxu 2004-11-04 22:13:16 UTC FreeBSD src repository Modified files: sys/kern kern_thread.c Log: Don't forget to turn off P_SINGLE_BOUNDARY for thread_single(SINGLE_EXIT), otherwise a threaded process which calls execv() will hang in kernel and may can not be killed! Revision Changes Path 1.205 +1 -1 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 22:20:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E8A616A4CE; Thu, 4 Nov 2004 22:20:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C11843D73; Thu, 4 Nov 2004 22:20:22 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4MKMAC041492; Thu, 4 Nov 2004 22:20:22 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4MKMEk041491; Thu, 4 Nov 2004 22:20:22 GMT (envelope-from glebius) Message-Id: <200411042220.iA4MKMEk041491@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 4 Nov 2004 22:20:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/syslogd syslogd.8 syslogd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 22:20:26 -0000 glebius 2004-11-04 22:20:21 UTC FreeBSD src repository Modified files: usr.sbin/syslogd syslogd.8 syslogd.c Log: - Use stailqueue for sockets instead of socket buffer. Thus remove limit for 20 sockets. - Add possibility to specify file mode for sockets created with '-l'. - Check that socket name in '-l' is absolute. Reviewed by: dwmalone, Andrea Campi Approved by: julian (mentor) Revision Changes Path 1.53 +8 -3 src/usr.sbin/syslogd/syslogd.8 1.132 +74 -38 src/usr.sbin/syslogd/syslogd.c From owner-cvs-src@FreeBSD.ORG Thu Nov 4 22:42:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FBFC16A4CE; Thu, 4 Nov 2004 22:42:29 +0000 (GMT) Received: from mx1.originative.co.uk (freebsd.gotadsl.co.uk [81.6.249.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A92643D58; Thu, 4 Nov 2004 22:42:26 +0000 (GMT) (envelope-from paul@originative.co.uk) Received: from localhost (unknown [127.0.0.1]) by mx1.originative.co.uk (Postfix) with ESMTP id 1AE3F15586; Thu, 4 Nov 2004 22:42:25 +0000 (GMT) Received: from mx1.originative.co.uk ([127.0.0.1])port 10024) with ESMTP id 42175-01; Thu, 4 Nov 2004 22:42:19 +0000 (GMT) Received: from [192.168.7.2] (myrddin [192.168.7.2]) by mx1.originative.co.uk (Postfix) with ESMTP id 135321556F; Thu, 4 Nov 2004 22:42:17 +0000 (GMT) From: Paul Richards To: Sam Leffler In-Reply-To: <200411041208.51978.sam@errno.com> References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> <200411041208.51978.sam@errno.com> Content-Type: text/plain Message-Id: <1099608134.42071.6.camel@myrddin> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 04 Nov 2004 22:42:15 +0000 Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Paul Richards Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 22:42:29 -0000 On Thu, 2004-11-04 at 20:08, Sam Leffler wrote: > On Thursday 04 November 2004 11:18 am, Paul Richards wrote: > > paul 2004-11-04 19:18:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/tail extern.h forward.c tail.c > > Log: > > Add support for following more than one file i.e. > > tail -f file1 file2 > > > > Revision Changes Path > > 1.9 +10 -1 src/usr.bin/tail/extern.h > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/extern.h.diff?r1=1.8&r2=1.9 > > 1.35 +160 -88 src/usr.bin/tail/forward.c > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/forward.c.diff?r1=1.34&r2=1.35 > > 1.18 +30 -7 src/usr.bin/tail/tail.c > > http://cvsweb.FreeBSD.org/src/usr.bin/tail/tail.c.diff?r1=1.17&r2=1.18 > > Why is this better than > > tail -f file1& > tail -f file2 > > Sam A few reasons. Main one is that it's a single process. If you debug webservers a lot you'd like to be able to do: vi httpd.conf apachectl restart; tail -f errors access ctrl C and then start the cycle again. With your suggestion it's a bit of a pain to also have to kill the background job which has a habit of spitting out output when you really don't want it. It's more efficient, though that's a marginal argument :-) You can do things like find /weservers/logs -name access |xargs tail -f So, on the whole I think it provides some useful new functionality. Paul. From owner-cvs-src@FreeBSD.ORG Thu Nov 4 23:09:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14D3016A4CE; Thu, 4 Nov 2004 23:09:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0728543D1D; Thu, 4 Nov 2004 23:09:58 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4N9v9T043346; Thu, 4 Nov 2004 23:09:57 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4N9v06043345; Thu, 4 Nov 2004 23:09:57 GMT (envelope-from glebius) Message-Id: <200411042309.iA4N9v06043345@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 4 Nov 2004 23:09:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/syslogd syslogd.8 syslogd.c src/sys/sys syslog.h src/lib/libc/gen syslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 23:09:58 -0000 glebius 2004-11-04 23:09:57 UTC FreeBSD src repository Modified files: usr.sbin/syslogd syslogd.8 syslogd.c sys/sys syslog.h lib/libc/gen syslog.c Log: Protect against local flooder of /var/run/log. Do not loop forever in syslog(3) if we are a priveleged program (sshd, su, etc.). - Make syslogd open an additional socket /var/run/logpriv, with 0600 permissions. - In libc, try to use this socket. - Do not loop forever if we are using this socket (partial backout of 1.31) Reviewed by: dwmalone, Andrea Campi Approved by: julian (mentor) MFC after: 1 month Revision Changes Path 1.32 +41 -13 src/lib/libc/gen/syslog.c 1.25 +1 -0 src/sys/sys/syslog.h 1.54 +7 -2 src/usr.sbin/syslogd/syslogd.8 1.133 +7 -3 src/usr.sbin/syslogd/syslogd.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 01:26:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39D6516A4CE; Fri, 5 Nov 2004 01:26:13 +0000 (GMT) Received: from castle.jp.FreeBSD.org (castle.jp.FreeBSD.org [210.226.20.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC56443D3F; Fri, 5 Nov 2004 01:26:11 +0000 (GMT) (envelope-from matusita@jp.FreeBSD.org) Received: from localhost (localhost [::1])iA51QA886098; Fri, 5 Nov 2004 10:26:10 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) In-Reply-To: <200411042309.iA4N9v06043345@repoman.freebsd.org> References: <200411042309.iA4N9v06043345@repoman.freebsd.org> X-User-Agent: Mew/1.94.2 Emacs/21.3 X-FaceAnim: (-O_O-)(O_O- )(_O- )(O- )(- -)( -O)( -O_)( -O_O)(-O_O-) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Dispatcher: imput version 20040704(IM147) Lines: 13 From: Makoto Matsushita To: glebius@FreeBSD.org Date: Fri, 05 Nov 2004 10:26:09 +0900 Message-Id: <20041105102609W.matusita@jp.FreeBSD.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.8 syslogd.c src/sys/sys syslog.h src/lib/libc/gen syslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 01:26:13 -0000 glebius> - Make syslogd open an additional socket /var/run/logpriv, with 0600 glebius> permissions. It would be a good one, but how do I open yet another priv socket? (Imagine you have a chroot/jail sandbox, and sshd runs inside sandbox.) Do we have yet another option, say, option -L (open priv socket), and use it as "syslogd -l /my/jail/var/run/log -L /my/jail/var/run/logpriv" or something like that? -- - Makoto `MAR' Matsushita From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:16:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F66816A4CE; Fri, 5 Nov 2004 05:16:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80D2143D2F; Fri, 5 Nov 2004 05:16:40 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55GeIS068255; Fri, 5 Nov 2004 05:16:40 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55Gepj068254; Fri, 5 Nov 2004 05:16:40 GMT (envelope-from kientzle) Message-Id: <200411050516.iA55Gepj068254@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:16:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_read_extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:16:40 -0000 kientzle 2004-11-05 05:16:40 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_extract.c Log: Update a comment. Revision Changes Path 1.36 +1 -0 src/lib/libarchive/archive_read_extract.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:23:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F280816A4CE; Fri, 5 Nov 2004 05:23:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D50D043D2F; Fri, 5 Nov 2004 05:23:18 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55NIvH068458; Fri, 5 Nov 2004 05:23:18 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55NI32068457; Fri, 5 Nov 2004 05:23:18 GMT (envelope-from kientzle) Message-Id: <200411050523.iA55NI32068457@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:23:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:23:19 -0000 kientzle 2004-11-05 05:23:18 UTC FreeBSD src repository Modified files: lib/libarchive Makefile Log: archive.h gets built in ${.OBJDIR} Revision Changes Path 1.24 +1 -1 src/lib/libarchive/Makefile From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:26:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02C4B16A4CE; Fri, 5 Nov 2004 05:26:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E73A643D2D; Fri, 5 Nov 2004 05:26:30 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55QUTH068634; Fri, 5 Nov 2004 05:26:30 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55QUIb068633; Fri, 5 Nov 2004 05:26:30 GMT (envelope-from kientzle) Message-Id: <200411050526.iA55QUIb068633@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:26:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_write.3 archive_write.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c archive_write_set_format_shar.c archive_write_set_format_ustar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:26:31 -0000 kientzle 2004-11-05 05:26:30 UTC FreeBSD src repository Modified files: lib/libarchive archive_write.3 archive_write.c archive_write_set_compression_bzip2.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_shar.c archive_write_set_format_ustar.c Log: Clean up the error handling in the write path. In particular, this should solve some problems people have seen with bsdtar not exiting on various write errors. Revision Changes Path 1.8 +7 -7 src/lib/libarchive/archive_write.3 1.13 +4 -1 src/lib/libarchive/archive_write.c 1.6 +27 -18 src/lib/libarchive/archive_write_set_compression_bzip2.c 1.8 +28 -19 src/lib/libarchive/archive_write_set_compression_gzip.c 1.6 +17 -9 src/lib/libarchive/archive_write_set_compression_none.c 1.5 +9 -9 src/lib/libarchive/archive_write_set_format_cpio.c 1.19 +8 -8 src/lib/libarchive/archive_write_set_format_pax.c 1.11 +109 -58 src/lib/libarchive/archive_write_set_format_shar.c 1.12 +4 -4 src/lib/libarchive/archive_write_set_format_ustar.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:29:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40CF616A4CE; Fri, 5 Nov 2004 05:29:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22E6A43D1D; Fri, 5 Nov 2004 05:29:37 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55TbR3068770; Fri, 5 Nov 2004 05:29:37 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55Tb86068769; Fri, 5 Nov 2004 05:29:37 GMT (envelope-from kientzle) Message-Id: <200411050529.iA55Tb86068769@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:29:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:29:37 -0000 kientzle 2004-11-05 05:29:36 UTC FreeBSD src repository Modified files: lib/libarchive Makefile Log: Revert 1.24: Brain glitch. Revision Changes Path 1.25 +1 -1 src/lib/libarchive/Makefile From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:32:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3329716A4CE; Fri, 5 Nov 2004 05:32:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 151C143D1F; Fri, 5 Nov 2004 05:32:05 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55W4KF068944; Fri, 5 Nov 2004 05:32:04 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55W4vB068943; Fri, 5 Nov 2004 05:32:04 GMT (envelope-from kientzle) Message-Id: <200411050532.iA55W4vB068943@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:32:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_string.h archive_string_sprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:32:05 -0000 kientzle 2004-11-05 05:32:04 UTC FreeBSD src repository Modified files: lib/libarchive archive_string.h archive_string_sprintf.c Log: Remove the unused archive_string_sprintf() utility function. Revision Changes Path 1.4 +0 -5 src/lib/libarchive/archive_string.h 1.6 +0 -13 src/lib/libarchive/archive_string_sprintf.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:36:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C461016A4CE; Fri, 5 Nov 2004 05:36:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B634F43D1D; Fri, 5 Nov 2004 05:36:56 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55au0s069110; Fri, 5 Nov 2004 05:36:56 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55auAU069109; Fri, 5 Nov 2004 05:36:56 GMT (envelope-from das) Message-Id: <200411050536.iA55auAU069109@repoman.freebsd.org> From: David Schultz Date: Fri, 5 Nov 2004 05:36:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:36:56 -0000 das 2004-11-05 05:36:56 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: Close a race in swapoff(). Here are the gory details: In order to avoid livelock, swapoff() skips over objects with a nonzero pip count and makes another pass if necessary. Since it is impossible to know which objects we care about, it would choose an arbitrary object with a nonzero pip count and wait for it before making another pass, the theory being that this object would finish paging about as quickly as the ones we care about. Unfortunately, we may have slept since we acquired a reference to this object. Hack around this problem by tsleep()ing on the pointer anyway, but timeout after a fixed interval. More elegant solutions are possible, but the ones I considered unnecessarily complicate this rare case. Also, kill some nits that seem to have crept into the swapoff() code in the last 75 revisions or so: - Don't pass both sp and sp->sw_used to swap_pager_swapoff(), since the latter can be derived from the former. - Replace swp_pager_find_dev() with something simpler. There's no need to iterate over the entire list of swap devices just to determine if a given block is assigned to the one we're interested in. - Expand the scope of the swhash_mtx in a couple of places so that it isn't released and reacquired once for every hash bucket. - Don't drop the swhash_mtx while holding a reference to an object. We need to lock the object first. Unfortunately, doing so would violate the established lock order, so use VM_OBJECT_TRYLOCK() and try again on a subsequent pass if the object is already locked. - Refactor swp_pager_force_pagein() and swap_pager_swapoff() a bit. Revision Changes Path 1.263 +53 -70 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:38:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2269416A4CE; Fri, 5 Nov 2004 05:38:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01A0E43D53; Fri, 5 Nov 2004 05:38:16 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55cF3g069229; Fri, 5 Nov 2004 05:38:15 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55cF0l069228; Fri, 5 Nov 2004 05:38:15 GMT (envelope-from kientzle) Message-Id: <200411050538.iA55cF0l069228@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:38:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:38:16 -0000 kientzle 2004-11-05 05:38:15 UTC FreeBSD src repository Modified files: lib/libarchive Makefile Log: Makefile tweaks: * Update Version * Add a missing MLINK * Fix 'distfile' target so it works from a clean checkout Revision Changes Path 1.26 +3 -2 src/lib/libarchive/Makefile From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:39:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19DC316A4CE; Fri, 5 Nov 2004 05:39:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE72743D46; Fri, 5 Nov 2004 05:39:37 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55dbMg069290; Fri, 5 Nov 2004 05:39:37 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55dbBe069289; Fri, 5 Nov 2004 05:39:37 GMT (envelope-from kientzle) Message-Id: <200411050539.iA55dbBe069289@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 5 Nov 2004 05:39:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar Makefile write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:39:38 -0000 kientzle 2004-11-05 05:39:37 UTC FreeBSD src repository Modified files: usr.bin/tar Makefile write.c Log: Correct error handling on failed writes to the archive. Revision Changes Path 1.12 +1 -1 src/usr.bin/tar/Makefile 1.35 +2 -4 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 05:40:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0502016A4CE; Fri, 5 Nov 2004 05:40:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA9EF43D1F; Fri, 5 Nov 2004 05:40:45 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA55ejfA069419; Fri, 5 Nov 2004 05:40:45 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA55ej4n069418; Fri, 5 Nov 2004 05:40:45 GMT (envelope-from alc) Message-Id: <200411050540.iA55ej4n069418@repoman.freebsd.org> From: Alan Cox Date: Fri, 5 Nov 2004 05:40:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 05:40:46 -0000 alc 2004-11-05 05:40:45 UTC FreeBSD src repository Modified files: sys/vm vm_object.c Log: Eliminate another unnecessary call to vm_page_busy() that immediately precedes a call to vm_page_rename(). (See the previous revision for a detailed explanation.) Revision Changes Path 1.334 +0 -1 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 06:24:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9066A16A4CE; Fri, 5 Nov 2004 06:24:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 714CF43D46; Fri, 5 Nov 2004 06:24:05 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA56O5jf071233; Fri, 5 Nov 2004 06:24:05 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA56O5Sl071232; Fri, 5 Nov 2004 06:24:05 GMT (envelope-from alc) Message-Id: <200411050624.iA56O5Sl071232@repoman.freebsd.org> From: Alan Cox Date: Fri, 5 Nov 2004 06:24:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_pageout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 06:24:05 -0000 alc 2004-11-05 06:24:05 UTC FreeBSD src repository Modified files: sys/vm vm_pageout.c Log: During traversal of the inactive queue, try locking the page's containing object before accessing the page's flags or the object's reference count. Revision Changes Path 1.266 +9 -4 src/sys/vm/vm_pageout.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 06:39:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DE4716A4CE; Fri, 5 Nov 2004 06:39:11 +0000 (GMT) Received: from mail20.syd.optusnet.com.au (mail20.syd.optusnet.com.au [211.29.132.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DA8D43D2D; Fri, 5 Nov 2004 06:39:10 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c211-30-75-229.belrs2.nsw.optusnet.com.au [211.30.75.229]) iA56d8VQ011513 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 5 Nov 2004 17:39:09 +1100 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1])iA56d8xP011847; Fri, 5 Nov 2004 17:39:08 +1100 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost)iA56d7X0011846; Fri, 5 Nov 2004 17:39:07 +1100 (EST) (envelope-from pjeremy) Date: Fri, 5 Nov 2004 17:39:07 +1100 From: Peter Jeremy To: Paul Richards Message-ID: <20041105063907.GI79646@cirb503493.alcatel.com.au> References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411041918.iA4JIJsd028943@repoman.freebsd.org> User-Agent: Mutt/1.4.2i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 06:39:11 -0000 On Thu, 2004-Nov-04 19:18:19 +0000, Paul Richards wrote: >paul 2004-11-04 19:18:19 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tail extern.h forward.c tail.c > Log: > Add support for following more than one file i.e. > tail -f file1 file2 Very handy. Can you please update the man page to match. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Fri Nov 5 06:52:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1170116A4CE; Fri, 5 Nov 2004 06:52:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E759443D53; Fri, 5 Nov 2004 06:52:29 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA56qT82072234; Fri, 5 Nov 2004 06:52:29 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA56qTNO072233; Fri, 5 Nov 2004 06:52:29 GMT (envelope-from alc) Message-Id: <200411050652.iA56qTNO072233@repoman.freebsd.org> From: Alan Cox Date: Fri, 5 Nov 2004 06:52:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 06:52:30 -0000 alc 2004-11-05 06:52:29 UTC FreeBSD src repository Modified files: sys/kern kern_subr.c Log: Two changes to vm_pgmoveco(): - Eliminate an initialized but unused variable. - Eliminate an unnecessary call to clear the page's PG_BUSY flag. (The call to vm_page_rename() already clears the page's PG_BUSY flag through its call to vm_page_remove().) Revision Changes Path 1.91 +1 -3 src/sys/kern/kern_subr.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 07:24:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3243C16A4CE; Fri, 5 Nov 2004 07:24:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1404F43D1D; Fri, 5 Nov 2004 07:24:12 +0000 (GMT) (envelope-from philip@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA57OBQw073286; Fri, 5 Nov 2004 07:24:11 GMT (envelope-from philip@repoman.freebsd.org) Received: (from philip@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA57OBnq073285; Fri, 5 Nov 2004 07:24:11 GMT (envelope-from philip) Message-Id: <200411050724.iA57OBnq073285@repoman.freebsd.org> From: Philip Paeps Date: Fri, 5 Nov 2004 07:24:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica acpi_asus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 07:24:12 -0000 philip 2004-11-05 07:24:11 UTC FreeBSD src repository Modified files: sys/i386/acpica acpi_asus.c Log: Fix support for the Asus-compatible gadgets in Samsung P30/P35 laptops. PR: 73380 Submitted by: Sebastian Schulze Struchtrup Revision Changes Path 1.13 +47 -9 src/sys/i386/acpica/acpi_asus.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 07:25:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D78416A4CE; Fri, 5 Nov 2004 07:25:07 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5F8543D48; Fri, 5 Nov 2004 07:25:06 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id iA57P53C087753; Fri, 5 Nov 2004 10:25:05 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id iA57P5o5087752; Fri, 5 Nov 2004 10:25:05 +0300 (MSK) (envelope-from ache) Date: Fri, 5 Nov 2004 10:25:05 +0300 From: Andrey Chernov To: David Schultz Message-ID: <20041105072505.GA87598@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , David Schultz , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200411050536.iA55auAU069109@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411050536.iA55auAU069109@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.12; VDF: 6.28.0.56; host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 07:25:07 -0000 On Fri, Nov 05, 2004 at 05:36:56AM +0000, David Schultz wrote: > das 2004-11-05 05:36:56 UTC > > FreeBSD src repository > > Modified files: > sys/vm swap_pager.c > Log: > Close a race in swapoff(). Here are the gory details: > Is this commit supposed to fix lost blocks race using swapoff in /etc/rc.d/swap1 ? -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Nov 5 07:35:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0DCC16A4CE; Fri, 5 Nov 2004 07:35:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2AD543D3F; Fri, 5 Nov 2004 07:35:31 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA57ZVnf073728; Fri, 5 Nov 2004 07:35:31 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA57ZV58073727; Fri, 5 Nov 2004 07:35:31 GMT (envelope-from mtm) Message-Id: <200411050735.iA57ZV58073727@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 5 Nov 2004 07:35:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d initdiskless X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 07:35:32 -0000 mtm 2004-11-05 07:35:31 UTC FreeBSD src repository Modified files: etc/rc.d initdiskless Log: - Make the header conform to standard rc.d style. - The 'before ipfw' directive seems bogus, and should instead be 'before rcconf'. Revision Changes Path 1.40 +2 -2 src/etc/rc.d/initdiskless From owner-cvs-src@FreeBSD.ORG Fri Nov 5 08:03:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACAC116A4CE; Fri, 5 Nov 2004 08:03:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EAF843D49; Fri, 5 Nov 2004 08:03:35 +0000 (GMT) (envelope-from philip@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA583ZkF075086; Fri, 5 Nov 2004 08:03:35 GMT (envelope-from philip@repoman.freebsd.org) Received: (from philip@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA583ZLO075085; Fri, 5 Nov 2004 08:03:35 GMT (envelope-from philip) Message-Id: <200411050803.iA583ZLO075085@repoman.freebsd.org> From: Philip Paeps Date: Fri, 5 Nov 2004 08:03:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4/man4.i386 acpi_asus.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 08:03:35 -0000 philip 2004-11-05 08:03:34 UTC FreeBSD src repository Modified files: share/man/man4/man4.i386 acpi_asus.4 Log: Sync acpi_asus(4) manual with reality. Revision Changes Path 1.5 +12 -2 src/share/man/man4/man4.i386/acpi_asus.4 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 09:05:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88C6716A4CE; Fri, 5 Nov 2004 09:05:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D87143D49; Fri, 5 Nov 2004 09:05:16 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA595GSO083809; Fri, 5 Nov 2004 09:05:16 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA595Gct083808; Fri, 5 Nov 2004 09:05:16 GMT (envelope-from pjd) Message-Id: <200411050905.iA595Gct083808@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 09:05:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/mirror g_mirror.c g_mirror.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 09:05:16 -0000 pjd 2004-11-05 09:05:15 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c g_mirror.h Log: MFp4: - Fix for good (I hope) force-stopping mirrors and some filure cases (e.g. the last good component dies when synchronization is in progress). Don't use ->nstart/->nend consumer's fields, as this could be racy, because those fields are used in g_down/g_up, use ->index consumer's field instead for tracking number of not finished requests. Reported by: marcel - After 5 seconds of idle time (this should be configurable) mark all dirty providers as clean, so when mirror is not used in 5 seconds and there will be power failure, no synchronization on boot is needed. Idea from: sorry, I can't find who suggested this - When there are no ACTIVE components and no NEW components destroy whole mirror, not only provider. - Fix one debug to show information about I/O request, before we change its command. Revision Changes Path 1.39 +68 -13 src/sys/geom/mirror/g_mirror.c 1.11 +1 -0 src/sys/geom/mirror/g_mirror.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 09:14:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4642016A4CE; Fri, 5 Nov 2004 09:14:19 +0000 (GMT) Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com [81.103.67.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3E9E43D3F; Fri, 5 Nov 2004 09:14:18 +0000 (GMT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.43 (FreeBSD)) id 1CQ0Ak-000JnJ-Ah; Fri, 05 Nov 2004 09:14:18 +0000 Date: Fri, 5 Nov 2004 09:14:18 +0000 From: Ceri Davies To: Peter Jeremy Message-ID: <20041105091418.GS57641@submonkey.net> Mail-Followup-To: Ceri Davies , Peter Jeremy , Paul Richards , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200411041918.iA4JIJsd028943@repoman.freebsd.org> <20041105063907.GI79646@cirb503493.alcatel.com.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O0WzNXnlZrEJWrBT" Content-Disposition: inline In-Reply-To: <20041105063907.GI79646@cirb503493.alcatel.com.au> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.6i Sender: Ceri Davies cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Paul Richards Subject: Re: cvs commit: src/usr.bin/tail extern.h forward.c tail.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 09:14:19 -0000 --O0WzNXnlZrEJWrBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 05, 2004 at 05:39:07PM +1100, Peter Jeremy wrote: > On Thu, 2004-Nov-04 19:18:19 +0000, Paul Richards wrote: > >paul 2004-11-04 19:18:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/tail extern.h forward.c tail.c=20 > > Log: > > Add support for following more than one file i.e. > > tail -f file1 file2 >=20 > Very handy. Can you please update the man page to match. The manpage actually already matches; I could find nothing that needed an update after this. Ceri --=20 --O0WzNXnlZrEJWrBT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBi0RqocfcwTS3JF8RAmynAJ4wXCDDQ6Jjm2G/yn4/UawCdjzVTwCeOmDF fYPqzibkLiu92rsZv/mNsPU= =QGW0 -----END PGP SIGNATURE----- --O0WzNXnlZrEJWrBT-- From owner-cvs-src@FreeBSD.ORG Fri Nov 5 09:27:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D48DD16A4CE; Fri, 5 Nov 2004 09:27:20 +0000 (GMT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 4465943D2D; Fri, 5 Nov 2004 09:27:19 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 5 Nov 2004 09:27:18 +0000 (GMT) Date: Fri, 5 Nov 2004 09:27:17 +0000 From: David Malone To: Makoto Matsushita Message-ID: <20041105092717.GA98184@walton.maths.tcd.ie> References: <200411042309.iA4N9v06043345@repoman.freebsd.org> <20041105102609W.matusita@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041105102609W.matusita@jp.FreeBSD.org> User-Agent: Mutt/1.5.6i Sender: dwmalone@maths.tcd.ie cc: cvs-src@FreeBSD.org cc: glebius@FreeBSD.org cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.8 syslogd.c src/sys/sys syslog.h src/lib/libc/gen syslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 09:27:21 -0000 On Fri, Nov 05, 2004 at 10:26:09AM +0900, Makoto Matsushita wrote: > It would be a good one, but how do I open yet another priv socket? > (Imagine you have a chroot/jail sandbox, and sshd runs inside sandbox.) libc automatically falls back to the original socket if there is no priv socket, so it shouldn't cause any problems. > Do we have yet another option, say, option -L (open priv socket), and > use it as "syslogd -l /my/jail/var/run/log -L /my/jail/var/run/logpriv" > or something like that? You can now specify the the mode for the socket on the command line, so you should be able to do: syslogd -l /my/jail/var/run/log -l 600:/my/jail/var/run/logpriv David. From owner-cvs-src@FreeBSD.ORG Fri Nov 5 09:38:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1392616A4CE; Fri, 5 Nov 2004 09:38:45 +0000 (GMT) Received: from castle.jp.FreeBSD.org (castle.jp.FreeBSD.org [210.226.20.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84E0843D1F; Fri, 5 Nov 2004 09:38:44 +0000 (GMT) (envelope-from matusita@jp.FreeBSD.org) Received: from localhost (localhost [::1]) ESMTP/inet6 id iA59cg810444; Fri, 5 Nov 2004 18:38:42 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) In-Reply-To: <20041105092717.GA98184@walton.maths.tcd.ie> References: <200411042309.iA4N9v06043345@repoman.freebsd.org> <20041105102609W.matusita@jp.FreeBSD.org> <20041105092717.GA98184@walton.maths.tcd.ie> X-User-Agent: Mew/1.94.2 Emacs/21.3 X-FaceAnim: (-O_O-)(O_O- )(_O- )(O- )(- -)( -O)( -O_)( -O_O)(-O_O-) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Dispatcher: imput version 20040704(IM147) Lines: 10 From: Makoto Matsushita To: dwmalone@maths.tcd.ie Date: Fri, 05 Nov 2004 18:38:40 +0900 Message-Id: <20041105183840T.matusita@jp.FreeBSD.org> cc: cvs-src@FreeBSD.org cc: glebius@FreeBSD.org cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.8 syslogd.c src/sys/sys syslog.h src/lib/libc/gen syslog.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 09:38:45 -0000 dwmalone> You can now specify the the mode for the socket on the command line, dwmalone> so you should be able to do: dwmalone> syslogd -l /my/jail/var/run/log -l 600:/my/jail/var/run/logpriv That's fine enough, thank you! -- - Makoto `MAR' Matsushita From owner-cvs-src@FreeBSD.ORG Fri Nov 5 10:18:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AD5016A4CE; Fri, 5 Nov 2004 10:18:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C06743D4C; Fri, 5 Nov 2004 10:18:06 +0000 (GMT) (envelope-from fjoe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5AI6Bc085980; Fri, 5 Nov 2004 10:18:06 GMT (envelope-from fjoe@repoman.freebsd.org) Received: (from fjoe@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5AI69s085979; Fri, 5 Nov 2004 10:18:06 GMT (envelope-from fjoe) Message-Id: <200411051018.iA5AI69s085979@repoman.freebsd.org> From: Max Khon Date: Fri, 5 Nov 2004 10:18:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/ee ee.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 10:18:06 -0000 fjoe 2004-11-05 10:18:06 UTC FreeBSD src repository Modified files: usr.bin/ee ee.c Log: Check that ee's standard input and output is a terminal. Do not ignore all the signals in range [1..24]. PR: 65892 MFC after: 2 weeks Revision Changes Path 1.32 +5 -4 src/usr.bin/ee/ee.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 10:45:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32CC416A4CE; Fri, 5 Nov 2004 10:45:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 123AC43D54; Fri, 5 Nov 2004 10:45:24 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5AjN1n086861; Fri, 5 Nov 2004 10:45:23 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5AjNQl086860; Fri, 5 Nov 2004 10:45:23 GMT (envelope-from tjr) Message-Id: <200411051045.iA5AjNQl086860@repoman.freebsd.org> From: "Tim J. Robbins" Date: Fri, 5 Nov 2004 10:45:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/cut cut.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 10:45:24 -0000 tjr 2004-11-05 10:45:23 UTC FreeBSD src repository Modified files: usr.bin/cut cut.c Log: When the last line of a file is missing a newline in -f mode, pass a length argument to mbrtowc() that accounts for the terminating newline character we add automatically. Failing to do this caused the loop to unexpectedly run out of characters and incorrectly signal an "Illegal byte sequence" error. Revision Changes Path 1.30 +5 -3 src/usr.bin/cut/cut.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 10:55:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F33316A4D0; Fri, 5 Nov 2004 10:55:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFA6043D39; Fri, 5 Nov 2004 10:55:04 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5At4lN087105; Fri, 5 Nov 2004 10:55:04 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5At4hG087104; Fri, 5 Nov 2004 10:55:04 GMT (envelope-from pjd) Message-Id: <200411051055.iA5At4hG087104@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 10:55:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/mirror g_mirror.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 10:55:05 -0000 pjd 2004-11-05 10:55:04 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c Log: - Add a sysctl kern.geom.mirror.idletime, so one can specify after how many seconds of idling, DRITY flags are removed. - If mirror is in idle state or is not open for writing, sleep without timeout when waiting for I/O requests. - Don't use atomic operations, for now sysctls are protected by Giant. - Update debugs. Revision Changes Path 1.40 +37 -13 src/sys/geom/mirror/g_mirror.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 11:41:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8282216A4CE; Fri, 5 Nov 2004 11:41:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6180843D41; Fri, 5 Nov 2004 11:41:36 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5BfaNj091253; Fri, 5 Nov 2004 11:41:36 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5BfaRw091252; Fri, 5 Nov 2004 11:41:36 GMT (envelope-from harti) Message-Id: <200411051141.iA5BfaRw091252@repoman.freebsd.org> From: Hartmut Brandt Date: Fri, 5 Nov 2004 11:41:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/make config.h job.c job.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 11:41:36 -0000 harti 2004-11-05 11:41:36 UTC FreeBSD src repository Modified files: usr.bin/make config.h job.c job.h Log: Now with the remote job support removed there can be no remote jobs and no jobs that need to be remigrated. Remove the flags and the associated code. Revision Changes Path 1.13 +1 -1 src/usr.bin/make/config.h 1.54 +30 -103 src/usr.bin/make/job.c 1.24 +1 -7 src/usr.bin/make/job.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 12:02:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A900E16A4CE; Fri, 5 Nov 2004 12:02:11 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 369A743D46; Fri, 5 Nov 2004 12:02:11 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iA5C1EoL000381; Fri, 5 Nov 2004 07:01:14 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iA5C1EWC000378; Fri, 5 Nov 2004 12:01:14 GMT (envelope-from robert@fledge.watson.org) Date: Fri, 5 Nov 2004 12:01:14 +0000 (GMT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mike Silbersack In-Reply-To: <20041029174131.A6530@odysseus.silby.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 12:02:12 -0000 On Fri, 29 Oct 2004, Mike Silbersack wrote: > I think we really need some sort of light-weight critical_enter that > simply assures you that you won't get rescheduled to another CPU, but > gives no guarantees beyond that. > Er, wait - I guess I'm forgetting something, there exists the potential > for the interrupt that preempted whatever was calling arc4random to also > call arc4random, thereby breaking things... I've been looking at related issues for the last couple of days and must have missed this thread while at EuroBSDCon. Alan Cox pointed me at it, so here I am. :-) Right now, the cost of acquiring and dropping an uncontended a sleep mutex on a UP kernel is very low -- about 21 cycles on my PIII and 40 on my P4, including some efficiency problems in my measurement which probably add a non-trivial overhead. Compare this with the SMP versions on the PIII (90 cycles) and P4 (260 cycles!). Critical sections on the SMP PIII are about the same cost as the SMP mutex, but on the P4 a critical section is less than half the cost. Getting to a model where critical sections were as cheap as UP sleep mutexes, or where we could use a similar combination of primitives (such as UP mutexes with pinning) would be very useful. Otherwise, optimizing through use of critical sections will improve SMP but potentially damage performance on UP. There's been a fair amount of discussion of such approaches, including the implementation briefly present in the FreeBSD. I know John Baldwin and Justin Gibbs both have theories and plans in this area. If we do create a UP mutex primitive for use on SMP, I would suggest we actually expand the contents of the UP mutex structure slightly to include a cpu number that can be asserted, along with pinning, when an operation is attempted and INVARIANTS is present. One of the great strengths of the mutex/lock model is a strong assertion capability, both for the purposes of documentation and testing, so we should make sure that carries into any new synchronization primitives. Small table of synchronization primitives below; in each case, the count is in cycles and reflects the cost of acquiring and dropping the primitive (lock+unlock, enter+exit). The P4 is a 3ghz box, and the PIII is an 800mhz box. Note that the synchronization primitives requiring atomic operations are substantially pessimized on the P4 vs the PIII. A discussion with John Baldwin and Scott Long yesterday revealed that the UP spin mutex is currently pessimized from a critical section to a critical section plus mutex internals due to a need for mtx_owned() on spin locks. I'm not convinced that explains the entire performance irregularity I see for P4 spin mutexes on UP, however. Note that 39 (P4 UP sleep mutex) + 120 (P4 UP critical section) is not 274 (P4 UP spin mutex) by a fair amount. Figuring out what's going on there would be a good idea, although it could well be a property of my measurement environment. I'm currently using this to do measurements: //depot/user/rwatson/percpu/sys/test/test_synch_timing.c In all of the below, the standard deviation is very small if you're careful about not bumping into hard clock or other interrupts during testing, especially when it comes to spin mutexes and critical sections. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research sleep mutex crit section spin mutex UP SMP UP SMP UP SMP PIII 21 90 83 81 112 141 P4 39 260 120 119 274 342 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 12:31:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81B1716A4CE; Fri, 5 Nov 2004 12:31:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 635C043D55; Fri, 5 Nov 2004 12:31:32 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5CVWmk093646; Fri, 5 Nov 2004 12:31:32 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5CVWU5093645; Fri, 5 Nov 2004 12:31:32 GMT (envelope-from pjd) Message-Id: <200411051231.iA5CVWU5093645@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 12:31:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/mirror g_mirror.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 12:31:32 -0000 pjd 2004-11-05 12:31:32 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c Log: Remove unused #include. Revision Changes Path 1.41 +0 -1 src/sys/geom/mirror/g_mirror.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 12:35:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4481816A4CE; Fri, 5 Nov 2004 12:35:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25D4543D1D; Fri, 5 Nov 2004 12:35:22 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5CZLvu093753; Fri, 5 Nov 2004 12:35:21 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5CZLkm093752; Fri, 5 Nov 2004 12:35:21 GMT (envelope-from pjd) Message-Id: <200411051235.iA5CZLkm093752@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 12:35:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/mirror g_mirror.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 12:35:22 -0000 pjd 2004-11-05 12:35:21 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c Log: Use shutdown hooks to mark mirrors as clean after all file systems are unmounted. Suggested by: scottl Revision Changes Path 1.42 +47 -1 src/sys/geom/mirror/g_mirror.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 12:38:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDBC316A4CE; Fri, 5 Nov 2004 12:38:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E47143D5D; Fri, 5 Nov 2004 12:38:27 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5CcRjV093908; Fri, 5 Nov 2004 12:38:27 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5CcR9F093907; Fri, 5 Nov 2004 12:38:27 GMT (envelope-from pjd) Message-Id: <200411051238.iA5CcR9F093907@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 12:38:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d swap1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 12:38:27 -0000 pjd 2004-11-05 12:38:27 UTC FreeBSD src repository Modified files: etc/rc.d swap1 Log: Stop method for swap1 script was introduced, because gmirror needed it. Now gmirror use shutdown hooks to mark mirrors as clean on shutdown, so this is not needed anymore. Revision Changes Path 1.9 +1 -1 src/etc/rc.d/swap1 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 12:42:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73E6216A4CE; Fri, 5 Nov 2004 12:42:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5379C43D46; Fri, 5 Nov 2004 12:42:16 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5CgG5R094078; Fri, 5 Nov 2004 12:42:16 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5CgGnK094077; Fri, 5 Nov 2004 12:42:16 GMT (envelope-from pjd) Message-Id: <200411051242.iA5CgGnK094077@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 12:42:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 12:42:16 -0000 pjd 2004-11-05 12:42:16 UTC FreeBSD src repository Modified files: sys/geom/raid3 g_raid3.c Log: - Use ->index consumer's field to track number of in-flight requests. - Remove unused #include. Revision Changes Path 1.19 +10 -2 src/sys/geom/raid3/g_raid3.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 13:01:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D95016A4CE; Fri, 5 Nov 2004 13:01:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E87143D31; Fri, 5 Nov 2004 13:01:26 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5D1QIE001477; Fri, 5 Nov 2004 13:01:26 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5D1Qml001476; Fri, 5 Nov 2004 13:01:26 GMT (envelope-from pjd) Message-Id: <200411051301.iA5D1Qml001476@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 13:01:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 13:01:26 -0000 pjd 2004-11-05 13:01:26 UTC FreeBSD src repository Modified files: sys/geom/raid3 g_raid3.c Log: Mark raid3 devices as clean on shutdown (after all file systems are unmounted). Suggested by: scottl Revision Changes Path 1.20 +52 -3 src/sys/geom/raid3/g_raid3.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 13:12:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E89316A4CE; Fri, 5 Nov 2004 13:12:49 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E70BB43D1F; Fri, 5 Nov 2004 13:12:48 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA5DEn4O031328; Fri, 5 Nov 2004 06:14:49 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <418B7C92.5000005@freebsd.org> Date: Fri, 05 Nov 2004 06:13:54 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200411050905.iA595Gct083808@repoman.freebsd.org> In-Reply-To: <200411050905.iA595Gct083808@repoman.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c g_mirror.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 13:12:49 -0000 Pawel Jakub Dawidek wrote: > pjd 2004-11-05 09:05:15 UTC > > FreeBSD src repository > > Modified files: > sys/geom/mirror g_mirror.c g_mirror.h > Log: > MFp4: > - Fix for good (I hope) force-stopping mirrors and some filure cases > (e.g. the last good component dies when synchronization is in progress). > Don't use ->nstart/->nend consumer's fields, as this could be racy, > because those fields are used in g_down/g_up, use ->index consumer's > field instead for tracking number of not finished requests. > > Reported by: marcel > > - After 5 seconds of idle time (this should be configurable) mark all > dirty providers as clean, so when mirror is not used in 5 seconds > and there will be power failure, no synchronization on boot is needed. > > Idea from: sorry, I can't find who suggested this Do you check that all outstanding writes are actually completed in this timeout period, or just that you haven't recieved any new writes in this period? Scott From owner-cvs-src@FreeBSD.ORG Fri Nov 5 13:12:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6612016A4D2; Fri, 5 Nov 2004 13:12:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4454643D39; Fri, 5 Nov 2004 13:12:59 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5DCxL4003816; Fri, 5 Nov 2004 13:12:59 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5DCxLX003815; Fri, 5 Nov 2004 13:12:59 GMT (envelope-from pjd) Message-Id: <200411051312.iA5DCxLX003815@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 13:12:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/raid3 g_raid3.c g_raid3.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 13:12:59 -0000 pjd 2004-11-05 13:12:59 UTC FreeBSD src repository Modified files: sys/geom/raid3 g_raid3.c g_raid3.h Log: - Mark all raid3 components as clean after kern.geom.raid3.idletime seconds. - Make kern.geom.raid3.timeout variable tunable. Revision Changes Path 1.21 +81 -2 src/sys/geom/raid3/g_raid3.c 1.7 +1 -0 src/sys/geom/raid3/g_raid3.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 13:29:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 897A516A4CE; Fri, 5 Nov 2004 13:29:16 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6167C43D2D; Fri, 5 Nov 2004 13:29:15 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id iA5DTEs5008473; Fri, 5 Nov 2004 16:29:14 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id iA5DTEgZ008464; Fri, 5 Nov 2004 16:29:14 +0300 (MSK) (envelope-from ache) Date: Fri, 5 Nov 2004 16:29:14 +0300 From: Andrey Chernov To: Pawel Jakub Dawidek Message-ID: <20041105132914.GA8130@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Pawel Jakub Dawidek , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200411051238.iA5CcR9F093907@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411051238.iA5CcR9F093907@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.12; VDF: 6.28.0.56; host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc/rc.d swap1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 13:29:16 -0000 On Fri, Nov 05, 2004 at 12:38:27PM +0000, Pawel Jakub Dawidek wrote: > Log: > Stop method for swap1 script was introduced, because gmirror needed it. > Now gmirror use shutdown hooks to mark mirrors as clean on shutdown, > so this is not needed anymore. Thanx! -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Nov 5 17:18:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3F2B16A4CE; Fri, 5 Nov 2004 17:18:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A19C243D49; Fri, 5 Nov 2004 17:18:39 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5HIdwE019662; Fri, 5 Nov 2004 17:18:39 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5HIdLw019661; Fri, 5 Nov 2004 17:18:39 GMT (envelope-from pjd) Message-Id: <200411051718.iA5HIdLw019661@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 17:18:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 17:18:39 -0000 pjd 2004-11-05 17:18:39 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c sys/geom/raid3 g_raid3.c Log: Don't forget to make sure that there are no not-finished requests before marking components as clean. Pointed out by: scottl Revision Changes Path 1.43 +33 -16 src/sys/geom/mirror/g_mirror.c 1.22 +33 -14 src/sys/geom/raid3/g_raid3.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 17:23:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46D4E16A4CE; Fri, 5 Nov 2004 17:23:11 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCDD043D5A; Fri, 5 Nov 2004 17:23:10 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 008E9ACDD0; Fri, 5 Nov 2004 18:23:08 +0100 (CET) Date: Fri, 5 Nov 2004 18:23:08 +0100 From: Pawel Jakub Dawidek To: Scott Long Message-ID: <20041105172308.GW8120@darkness.comp.waw.pl> References: <200411050905.iA595Gct083808@repoman.freebsd.org> <418B7C92.5000005@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LGr9gtkSK9ARF7Ax" Content-Disposition: inline In-Reply-To: <418B7C92.5000005@freebsd.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c g_mirror.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 17:23:11 -0000 --LGr9gtkSK9ARF7Ax Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 05, 2004 at 06:13:54AM -0700, Scott Long wrote: +> Pawel Jakub Dawidek wrote: +> >pjd 2004-11-05 09:05:15 UTC +> > +> > FreeBSD src repository +> > +> > Modified files: +> > sys/geom/mirror g_mirror.c g_mirror.h=20 +> > Log: +> > MFp4: +> > - Fix for good (I hope) force-stopping mirrors and some filure cases +> > (e.g. the last good component dies when synchronization is in=20 +> > progress). +> > Don't use ->nstart/->nend consumer's fields, as this could be racy, +> > because those fields are used in g_down/g_up, use ->index consumer's +> > field instead for tracking number of not finished requests. +> > =20 +> > Reported by: marcel +> > =20 +> > - After 5 seconds of idle time (this should be configurable) mark all +> > dirty providers as clean, so when mirror is not used in 5 seconds +> > and there will be power failure, no synchronization on boot is need= ed. +> > =20 +> > Idea from: sorry, I can't find who suggested this +>=20 +> Do you check that all outstanding writes are actually completed in this +> timeout period, or just that you haven't recieved any new writes in this +> period? I'm checking it now, thanks! --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --LGr9gtkSK9ARF7Ax Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBi7b8ForvXbEpPzQRAgmcAKDjJttrod9fGMKqyWMLWA6gXW5gawCbBFCa 4UYW/n/HSsNtswYnQhff/4E= =og9R -----END PGP SIGNATURE----- --LGr9gtkSK9ARF7Ax-- From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:09:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 183A216A4CE; Fri, 5 Nov 2004 18:09:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB0D243D5E; Fri, 5 Nov 2004 18:09:19 +0000 (GMT) (envelope-from roam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5I9J53021562; Fri, 5 Nov 2004 18:09:19 GMT (envelope-from roam@repoman.freebsd.org) Received: (from roam@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5I9Jii021561; Fri, 5 Nov 2004 18:09:19 GMT (envelope-from roam) Message-Id: <200411051809.iA5I9Jii021561@repoman.freebsd.org> From: Peter Pentchev Date: Fri, 5 Nov 2004 18:09:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/release/sysinstall sysinstall.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:09:20 -0000 roam 2004-11-05 18:09:19 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_4) release/sysinstall sysinstall.8 Log: Correct the instructions for automated X setup: use 'configXSetup' instead of 'configXEnvironment', and add 'configXDesktop'. Not applicable to 5.x or 6.x, since the X configuration stuff has been ripped out of sysinstall(8) there. PR: 62665 Submitted by: makham Revision Changes Path 1.31.2.16 +7 -2 src/release/sysinstall/sysinstall.8 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:24:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA65F16A4CF; Fri, 5 Nov 2004 18:24:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8B5743D46; Fri, 5 Nov 2004 18:24:01 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5IO1Fd022219; Fri, 5 Nov 2004 18:24:01 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5IO19a022218; Fri, 5 Nov 2004 18:24:01 GMT (envelope-from peter) Message-Id: <200411051824.iA5IO19a022218@repoman.freebsd.org> From: Peter Wemm Date: Fri, 5 Nov 2004 18:24:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:24:02 -0000 peter 2004-11-05 18:24:01 UTC FreeBSD src repository Modified files: sys/amd64/amd64 busdma_machdep.c Log: MFi386: rev 1.61 (scottl): Add KTR tracing rev 1.62 (scottl): Optimize (td->pmap, inlines, etc) Revision Changes Path 1.59 +79 -28 src/sys/amd64/amd64/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:25:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 817DF16A4D0; Fri, 5 Nov 2004 18:25:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61D5F43D1D; Fri, 5 Nov 2004 18:25:22 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5IPM0Q022340; Fri, 5 Nov 2004 18:25:22 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5IPMKV022339; Fri, 5 Nov 2004 18:25:22 GMT (envelope-from peter) Message-Id: <200411051825.iA5IPMKV022339@repoman.freebsd.org> From: Peter Wemm Date: Fri, 5 Nov 2004 18:25:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:25:22 -0000 peter 2004-11-05 18:25:22 UTC FreeBSD src repository Modified files: sys/amd64/amd64 mp_machdep.c Log: MFi386 1.238 (jhb): Allow hints to disable cpus Revision Changes Path 1.248 +16 -1 src/sys/amd64/amd64/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:29:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8836216A4D0; Fri, 5 Nov 2004 18:29:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 530CD43D48; Fri, 5 Nov 2004 18:29:11 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5ITBul022622; Fri, 5 Nov 2004 18:29:11 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5ITBgE022621; Fri, 5 Nov 2004 18:29:11 GMT (envelope-from peter) Message-Id: <200411051829.iA5ITBgE022621@repoman.freebsd.org> From: Peter Wemm Date: Fri, 5 Nov 2004 18:29:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:29:11 -0000 peter 2004-11-05 18:29:11 UTC FreeBSD src repository Modified files: sys/kern kern_shutdown.c Log: Bind to cpu0 for boot() processing. (Note this is reboot, not startup) This means we'll always call the event hooks, device_shutdown etc on the BSP and theoretically means we can de-cruftify the cpu_reset_proxy stuff. Revision Changes Path 1.169 +8 -0 src/sys/kern/kern_shutdown.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:29:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4120616A4CF; Fri, 5 Nov 2004 18:29:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D50043D58; Fri, 5 Nov 2004 18:29:46 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5ITksN022662; Fri, 5 Nov 2004 18:29:46 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5ITjN8022661; Fri, 5 Nov 2004 18:29:46 GMT (envelope-from cognet) Message-Id: <200411051829.iA5ITjN8022661@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 18:29:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm critical.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:29:46 -0000 cognet 2004-11-05 18:29:45 UTC FreeBSD src repository Modified files: sys/arm/arm critical.c Log: In cpu_critical_fork_exit(), make sure to set td_md.md_critnest so that interrupts will be enabled. Spotted out by: jhb Revision Changes Path 1.2 +2 -0 src/sys/arm/arm/critical.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:32:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4418516A4CE; Fri, 5 Nov 2004 18:32:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 220ED43D41; Fri, 5 Nov 2004 18:32:15 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5IWF3I022842; Fri, 5 Nov 2004 18:32:15 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5IWFPe022841; Fri, 5 Nov 2004 18:32:15 GMT (envelope-from cognet) Message-Id: <200411051832.iA5IWFPe022841@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 18:32:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/snp snp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:32:15 -0000 cognet 2004-11-05 18:32:14 UTC FreeBSD src repository Modified files: sys/dev/snp snp.c Log: Walk through the snp softc list instead of abusing tp->ts_c to find the snp attached to a tty. This fixes the panic that happens when using snp. Revision Changes Path 1.95 +17 -8 src/sys/dev/snp/snp.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 18:45:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 981B116A4F2 for ; Fri, 5 Nov 2004 18:45:00 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71CA943D54 for ; Fri, 5 Nov 2004 18:45:00 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7388 invoked from network); 5 Nov 2004 18:45:00 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 5 Nov 2004 18:44:59 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA5Iim5h096153; Fri, 5 Nov 2004 13:44:56 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Peter Wemm Date: Fri, 5 Nov 2004 13:39:48 -0500 User-Agent: KMail/1.6.2 References: <200411051829.iA5ITBgE022621@repoman.freebsd.org> In-Reply-To: <200411051829.iA5ITBgE022621@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411051339.48767.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 18:45:00 -0000 On Friday 05 November 2004 01:29 pm, Peter Wemm wrote: > peter 2004-11-05 18:29:11 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_shutdown.c > Log: > Bind to cpu0 for boot() processing. (Note this is reboot, not startup) > This means we'll always call the event hooks, device_shutdown etc on the > BSP and theoretically means we can de-cruftify the cpu_reset_proxy stuff. This breaks Alpha for now. :( Maybe this will incentivize people to test the patch I posted to alpha@. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:00:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93B7B16A4CE; Fri, 5 Nov 2004 19:00:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73B9543D39; Fri, 5 Nov 2004 19:00:29 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5J0Ol7023884; Fri, 5 Nov 2004 19:00:24 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5J0Ojx023883; Fri, 5 Nov 2004 19:00:24 GMT (envelope-from peter) Message-Id: <200411051900.iA5J0Ojx023883@repoman.freebsd.org> From: Peter Wemm Date: Fri, 5 Nov 2004 19:00:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:00:37 -0000 peter 2004-11-05 19:00:24 UTC FreeBSD src repository Modified files: sys/kern kern_shutdown.c Log: Restrict the sched_bind to cpu 0 to i386 and amd64 for now. I forgot that alpha still doesn't use logical cpu id's. Revision Changes Path 1.170 +1 -1 src/sys/kern/kern_shutdown.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:06:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E14316A4CF; Fri, 5 Nov 2004 19:06:11 +0000 (GMT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D58D43D41; Fri, 5 Nov 2004 19:06:11 +0000 (GMT) (envelope-from peter@wemm.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id D3DAB2A92A; Fri, 5 Nov 2004 11:06:10 -0800 (PST) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id 6B0C8E2B3; Fri, 5 Nov 2004 11:06:10 -0800 (PST) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (8.13.1/8.13.1) with ESMTP id iA5J69OO051905; Fri, 5 Nov 2004 11:06:09 -0800 (PST) (envelope-from peter@wemm.org) Received: from localhost (localhost [[UNIX: localhost]]) by overcee.wemm.org (8.13.1/8.13.1/Submit) id iA5J692D051904; Fri, 5 Nov 2004 11:06:09 -0800 (PST) (envelope-from peter@wemm.org) X-Authentication-Warning: overcee.wemm.org: peter set sender to peter@wemm.org using -f From: Peter Wemm To: Tim Kientzle Date: Fri, 5 Nov 2004 11:06:09 -0800 User-Agent: KMail/1.7 References: <200411050526.iA55QUIb068633@repoman.freebsd.org> In-Reply-To: <200411050526.iA55QUIb068633@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200411051106.09523.peter@wemm.org> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_write.3 archive_write.c archive_write_set_compression_bzip2.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_shar.c archive_write_set_format_ustar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:06:11 -0000 This broke world for me: /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: error: conflicting types for 'archive_compressor_bzip2_write' /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: error: previous declaration of 'archive_compressor_bzip2_write' was here /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: error: conflicting types for 'archive_compressor_bzip2_write' /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: error: previous declaration of 'archive_compressor_bzip2_write' was here /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: warning: 'archive_compressor_bzip2_write' used but never defined /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: warning: 'archive_compressor_bzip2_write' defined but not used *** Error code 1 'int' != 'ssize_t'. In the patch you changed a 'static ssize_t' to a 'static int' and didn't update the prototype. On Thursday 04 November 2004 09:26 pm, Tim Kientzle wrote: > kientzle 2004-11-05 05:26:30 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_write.3 archive_write.c > archive_write_set_compression_bzip2.c > archive_write_set_compression_gzip.c > archive_write_set_compression_none.c > archive_write_set_format_cpio.c > archive_write_set_format_pax.c > archive_write_set_format_shar.c > archive_write_set_format_ustar.c > Log: > Clean up the error handling in the > write path. In particular, this should > solve some problems people have seen with > bsdtar not exiting on various write errors. > > Revision Changes Path > 1.8 +7 -7 src/lib/libarchive/archive_write.3 > 1.13 +4 -1 src/lib/libarchive/archive_write.c > 1.6 +27 -18 > src/lib/libarchive/archive_write_set_compression_bzip2.c 1.8 > +28 -19 src/lib/libarchive/archive_write_set_compression_gzip.c > 1.6 +17 -9 > src/lib/libarchive/archive_write_set_compression_none.c 1.5 +9 > -9 src/lib/libarchive/archive_write_set_format_cpio.c 1.19 > +8 -8 src/lib/libarchive/archive_write_set_format_pax.c 1.11 > +109 -58 src/lib/libarchive/archive_write_set_format_shar.c 1.12 > +4 -4 src/lib/libarchive/archive_write_set_format_ustar.c -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:11:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7840B16A4CE; Fri, 5 Nov 2004 19:11:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 556CE43D39; Fri, 5 Nov 2004 19:11:24 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JBOKg024333; Fri, 5 Nov 2004 19:11:24 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JBOED024332; Fri, 5 Nov 2004 19:11:24 GMT (envelope-from jhb) Message-Id: <200411051911.iA5JBOED024332@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Nov 2004 19:11:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_intr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:11:24 -0000 jhb 2004-11-05 19:11:24 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c Log: - Make setting of IT_ENTROPY a bit simpler in ithread_update(). - Tweak the updating of the ithread name in ithread_update() so that the '+' and '*' characters for device names that were too short only get added at the end after as many device names as possible were fit into the allocated space. Prior to this, some long devices would result in '+' chars showing up between two different devices rather than at the end. Revision Changes Path 1.118 +10 -10 src/sys/kern/kern_intr.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:14:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9629F16A4CE; Fri, 5 Nov 2004 19:14:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73CD543D45; Fri, 5 Nov 2004 19:14:02 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JE20j024474; Fri, 5 Nov 2004 19:14:02 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JE2qc024473; Fri, 5 Nov 2004 19:14:02 GMT (envelope-from jhb) Message-Id: <200411051914.iA5JE2qc024473@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Nov 2004 19:14:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:14:02 -0000 jhb 2004-11-05 19:14:02 UTC FreeBSD src repository Modified files: sys/vm vm_zeroidle.c Log: - Set the priority of the page zeroing thread using sched_prio() when the thread is created rather than adjusting the priority in the main function. (kthread_create() should probably take the initial priority as an argument.) - Only yield the CPU in the !PREEMPTION case if there are any other runnable threads. Yielding when there isn't anything else better to do just wastes time in pointless context switches (albeit while the system is idle.) Revision Changes Path 1.32 +5 -14 src/sys/vm/vm_zeroidle.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:14:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5255D16A4CE; Fri, 5 Nov 2004 19:14:53 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23E8443D5A; Fri, 5 Nov 2004 19:14:53 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id iA5JEpVY078068; Fri, 5 Nov 2004 11:14:51 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id iA5JEpvO078067; Fri, 5 Nov 2004 11:14:51 -0800 (PST) (envelope-from obrien) Date: Fri, 5 Nov 2004 11:14:50 -0800 From: "David O'Brien" To: Ceri Davies , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041105191450.GB44972@dragon.nuxi.com> References: <200411040128.iA41ShNQ055582@repoman.freebsd.org> <20041104111025.GG57641@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041104111025.GG57641@submonkey.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:14:53 -0000 On Thu, Nov 04, 2004 at 11:10:25AM +0000, Ceri Davies wrote: > This line now gets written to /tmp/exports: > > | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self) > > | vsystem("echo '#/a -maproot=0 -network 10.0.1.0 -mask 255.255.248.0' >> /etc/exports"); > > | vsystem("echo '#' >> /etc/exports"); > > | vsystem("echo '# You should replace these lines with your actual exported filesystems.' >> /etc/exports"); > > | - vsystem("echo '# Note that BSD\'s export syntax is \"host-centric\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports"); > > | + vsystem("echo \"# Note that BSD's export syntax is 'host-centric' vs. Sun's 'FS-centric' one.\" >> /tmp/exports"); > > Also, wouldn't it just be easier to open() /etc/exports and write to it > that way? I understand that this isn't how this is done anywhere else > in sysinstall, but why not? That's a good question. I guess JKH had a reason at the time. Given the prickliness of sysinstall, I wouldn't change it without a good amount of thought and testing. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:16:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 652AC16A4CE; Fri, 5 Nov 2004 19:16:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58C2843D46; Fri, 5 Nov 2004 19:16:44 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JGiTL024649; Fri, 5 Nov 2004 19:16:44 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JGiod024648; Fri, 5 Nov 2004 19:16:44 GMT (envelope-from jhb) Message-Id: <200411051916.iA5JGiod024648@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Nov 2004 19:16:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha machdep.c mp_machdep.c src/sys/alpha/include pcpu.h smp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:16:44 -0000 jhb 2004-11-05 19:16:44 UTC FreeBSD src repository Modified files: sys/alpha/alpha machdep.c mp_machdep.c sys/alpha/include pcpu.h smp.h Log: - Add a new MD per-CPU field for Alpha 'pal_id' which is the PAL ID associated with each processor. This ID is inferred from the index of the pcs structure in the hwprb. - Give Alpha CPUs FreeBSD CPU IDs more like other architectures where the boot processor is always CPU 0 and the other processors are numbered 1 ... N. List active CPUs in the system in cpu_mp_announce() as well. Silence on: alpha@ Revision Changes Path 1.224 +2 -1 src/sys/alpha/alpha/machdep.c 1.53 +50 -39 src/sys/alpha/alpha/mp_machdep.c 1.15 +1 -0 src/sys/alpha/include/pcpu.h 1.7 +2 -2 src/sys/alpha/include/smp.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:48:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BA1516A4CE; Fri, 5 Nov 2004 19:48:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C58343D49; Fri, 5 Nov 2004 19:48:40 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JmeVe025864; Fri, 5 Nov 2004 19:48:40 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5Jme4e025863; Fri, 5 Nov 2004 19:48:40 GMT (envelope-from cognet) Message-Id: <200411051948.iA5Jme4e025863@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:48:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm cpufunc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:48:40 -0000 cognet 2004-11-05 19:48:40 UTC FreeBSD src repository Modified files: sys/arm/arm cpufunc.c Log: Call pmap_pte_init_arm9 instead of pmap_pte_init_generic if ARM9_CACHE_WRITE_THROUGH is defined. Revision Changes Path 1.4 +4 -0 src/sys/arm/arm/cpufunc.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:50:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB90D16A4CE; Fri, 5 Nov 2004 19:50:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBED843D46; Fri, 5 Nov 2004 19:50:48 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5Jom4D026047; Fri, 5 Nov 2004 19:50:48 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JomT0026046; Fri, 5 Nov 2004 19:50:48 GMT (envelope-from cognet) Message-Id: <200411051950.iA5JomT0026046@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:50:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm fusu.S support.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:50:49 -0000 cognet 2004-11-05 19:50:48 UTC FreeBSD src repository Modified files: sys/arm/arm fusu.S support.S Log: Implement casuptr. Revision Changes Path 1.3 +51 -2 src/sys/arm/arm/fusu.S 1.6 +0 -4 src/sys/arm/arm/support.S From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:51:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D7D116A4CE; Fri, 5 Nov 2004 19:51:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F175043D3F; Fri, 5 Nov 2004 19:51:23 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JpN9l026099; Fri, 5 Nov 2004 19:51:23 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JpNO1026098; Fri, 5 Nov 2004 19:51:23 GMT (envelope-from cognet) Message-Id: <200411051951.iA5JpNO1026098@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:51:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:51:24 -0000 cognet 2004-11-05 19:51:23 UTC FreeBSD src repository Modified files: sys/arm/arm identcpu.c Log: Be more verbose about cache capacities. Revision Changes Path 1.3 +18 -2 src/sys/arm/arm/identcpu.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:52:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB1C016A4CE; Fri, 5 Nov 2004 19:52:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA57043D46; Fri, 5 Nov 2004 19:52:55 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JqthF026215; Fri, 5 Nov 2004 19:52:55 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JqtDW026214; Fri, 5 Nov 2004 19:52:55 GMT (envelope-from cognet) Message-Id: <200411051952.iA5JqtDW026214@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:52:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm locore.S src/sys/arm/xscale/i80321 iq31244_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:52:56 -0000 cognet 2004-11-05 19:52:55 UTC FreeBSD src repository Modified files: sys/arm/arm locore.S sys/arm/xscale/i80321 iq31244_machdep.c Log: If we're still running at the physical address, jump to the virtual address instead before calling initarm(). This removes the need to map virtual == physical in initarm(). Revision Changes Path 1.5 +13 -0 src/sys/arm/arm/locore.S 1.2 +7 -33 src/sys/arm/xscale/i80321/iq31244_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:54:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F57716A4CE; Fri, 5 Nov 2004 19:54:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E031343D49; Fri, 5 Nov 2004 19:54:13 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JsDQB026314; Fri, 5 Nov 2004 19:54:13 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JsDYY026313; Fri, 5 Nov 2004 19:54:13 GMT (envelope-from cognet) Message-Id: <200411051954.iA5JsDYY026313@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:54:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm swtch.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:54:14 -0000 cognet 2004-11-05 19:54:13 UTC FreeBSD src repository Modified files: sys/arm/arm swtch.S Log: Save a few cycles in context switch. Update comments to reflect reality. Revision Changes Path 1.4 +36 -90 src/sys/arm/arm/swtch.S From owner-cvs-src@FreeBSD.ORG Fri Nov 5 19:57:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E86816A4CE; Fri, 5 Nov 2004 19:57:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C7CC43D39; Fri, 5 Nov 2004 19:57:11 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JvAA2026535; Fri, 5 Nov 2004 19:57:10 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5JvAYr026534; Fri, 5 Nov 2004 19:57:10 GMT (envelope-from cognet) Message-Id: <200411051957.iA5JvAYr026534@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 19:57:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm trap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 19:57:11 -0000 cognet 2004-11-05 19:57:10 UTC FreeBSD src repository Modified files: sys/arm/arm trap.c Log: Copy the syscall args in a tmp variable instead of directly using the trapframe, as it can be modified in the syscall. Call thread_user_enter() when appropriate. Revision Changes Path 1.3 +55 -23 src/sys/arm/arm/trap.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 20:15:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6614116A4CE; Fri, 5 Nov 2004 20:15:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 449EB43D2F; Fri, 5 Nov 2004 20:15:07 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5KF750027206; Fri, 5 Nov 2004 20:15:07 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5KF76r027205; Fri, 5 Nov 2004 20:15:07 GMT (envelope-from jhb) Message-Id: <200411052015.iA5KF76r027205@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Nov 2004 20:15:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/random randomdev_soft.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 20:15:07 -0000 jhb 2004-11-05 20:15:06 UTC FreeBSD src repository Modified files: sys/dev/random randomdev_soft.c Log: Don't change the priority to PUSER when sleeping, just keep the current priority. Revision Changes Path 1.8 +4 -2 src/sys/dev/random/randomdev_soft.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 20:19:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EC3016A4CE; Fri, 5 Nov 2004 20:19:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71D6743D48; Fri, 5 Nov 2004 20:19:58 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5KJwuD027376; Fri, 5 Nov 2004 20:19:58 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5KJw7F027375; Fri, 5 Nov 2004 20:19:58 GMT (envelope-from jhb) Message-Id: <200411052019.iA5KJw7F027375@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Nov 2004 20:19:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_sleepqueue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 20:19:58 -0000 jhb 2004-11-05 20:19:58 UTC FreeBSD src repository Modified files: sys/kern subr_sleepqueue.c Log: - Store threads on sleep queues in FIFO order rather than sorted by priority. The sleep queues don't get updated when the priority of threads changes, so sleepq_signal() might not always wakeup the highest priority thread. Updating the queues when thread priorities change cannot be easily done due to lock orders, so instead we do an O(n) walk of the queue for a sleepq_signal() operation instead of O(1). On the other hand, adding a thread to a sleep queue now goes from O(n) to O(1) so it ends up as an even tradeoff. The correctness here with regards to priorities is actually fairly important. msleep() gives interactive threads their priority "boost" after they are placed on the queue, but before this fix that "boost" wasn't used to determine the highest priority thread that sleepq_signal() awoke. - Fix up some comments. Inspired by: ups, bde Revision Changes Path 1.14 +19 -16 src/sys/kern/subr_sleepqueue.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 20:42:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DCA516A4CE for ; Fri, 5 Nov 2004 20:42:56 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC48E43D41 for ; Fri, 5 Nov 2004 20:42:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 10531 invoked from network); 5 Nov 2004 20:42:55 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 5 Nov 2004 20:42:55 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iA5KgoSo097202; Fri, 5 Nov 2004 15:42:50 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Peter Wemm Date: Fri, 5 Nov 2004 15:34:03 -0500 User-Agent: KMail/1.6.2 References: <200411051829.iA5ITBgE022621@repoman.freebsd.org> <200411051339.48767.jhb@FreeBSD.org> In-Reply-To: <200411051339.48767.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411051534.03335.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 20:42:56 -0000 On Friday 05 November 2004 01:39 pm, John Baldwin wrote: > On Friday 05 November 2004 01:29 pm, Peter Wemm wrote: > > peter 2004-11-05 18:29:11 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_shutdown.c > > Log: > > Bind to cpu0 for boot() processing. (Note this is reboot, not startup) > > This means we'll always call the event hooks, device_shutdown etc on > > the BSP and theoretically means we can de-cruftify the cpu_reset_proxy > > stuff. > > This breaks Alpha for now. :( Maybe this will incentivize people to test > the patch I posted to alpha@. Alpha should be ok now as I committed the patch. You can probably turn it on for all archs now. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Nov 5 21:21:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 854AB16A4CE; Fri, 5 Nov 2004 21:21:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63F9E43D2D; Fri, 5 Nov 2004 21:21:30 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5LLUJ0036583; Fri, 5 Nov 2004 21:21:30 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5LLU5w036582; Fri, 5 Nov 2004 21:21:30 GMT (envelope-from hrs) Message-Id: <200411052121.iA5LLU5w036582@repoman.freebsd.org> From: Hiroki Sato Date: Fri, 5 Nov 2004 21:21:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 21:21:30 -0000 hrs 2004-11-05 21:21:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: Update errata: describe the USB keyboard problem in detail. Based on the patch by: brooks Approved by: re (implicitly) Revision Changes Path 1.69.2.7 +8 -3 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Fri Nov 5 22:21:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4AA716A520; Fri, 5 Nov 2004 22:21:37 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6648543D1D; Fri, 5 Nov 2004 22:21:37 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id iA5MLJuI007212; Fri, 5 Nov 2004 17:21:20 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id iA5MLJo3007211; Fri, 5 Nov 2004 17:21:19 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Fri, 5 Nov 2004 17:21:19 -0500 From: David Schultz To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041105222119.GB6935@VARK.MIT.EDU> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200411050536.iA55auAU069109@repoman.freebsd.org> <20041105072505.GA87598@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041105072505.GA87598@nagual.pp.ru> Subject: Re: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 22:21:37 -0000 On Fri, Nov 05, 2004, Andrey Chernov wrote: > On Fri, Nov 05, 2004 at 05:36:56AM +0000, David Schultz wrote: > > das 2004-11-05 05:36:56 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm swap_pager.c > > Log: > > Close a race in swapoff(). Here are the gory details: > > > > Is this commit supposed to fix lost blocks race using swapoff in > /etc/rc.d/swap1 ? Probably not. I believe the race that's causing this problem is related to putpages(). The swapoff() code assumes that any thread that has allocated swap blocks has initialized at least one of the swblock structures to point to the object that's paging. However, putpages() may be sleeping in getpbuf() while it's claiming a bunch of blocks that aren't in the swblock hash table yet. With a little bit of rearranging, I could probably fix the problem in putpages(), or I could make swapoff() retry until it gets everything. I think md devices with -oreserve could be a problem as well. From owner-cvs-src@FreeBSD.ORG Fri Nov 5 22:31:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA56A16A4CE; Fri, 5 Nov 2004 22:31:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A97E43D39; Fri, 5 Nov 2004 22:31:20 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5MVK7a038947; Fri, 5 Nov 2004 22:31:20 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5MVKJv038946; Fri, 5 Nov 2004 22:31:20 GMT (envelope-from davidxu) Message-Id: <200411052231.iA5MVKJv038946@repoman.freebsd.org> From: David Xu Date: Fri, 5 Nov 2004 22:31:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 22:31:20 -0000 davidxu 2004-11-05 22:31:20 UTC FreeBSD src repository Modified files: sys/kern kern_thread.c Log: Backout previous commit, the P_STOPPED_BOUNDARY flag was already cleared at the begin of thread_single() when needed. Revision Changes Path 1.206 +1 -1 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 22:38:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BEE716A4CE; Fri, 5 Nov 2004 22:38:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A0B343D41; Fri, 5 Nov 2004 22:38:15 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5McEZ6039209; Fri, 5 Nov 2004 22:38:14 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5McEUg039208; Fri, 5 Nov 2004 22:38:14 GMT (envelope-from pjd) Message-Id: <200411052238.iA5McEUg039208@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 5 Nov 2004 22:38:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/geom/class/mirror gmirror.8src/sbin/geom/class/raid3 graid3.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 22:38:15 -0000 pjd 2004-11-05 22:38:14 UTC FreeBSD src repository Modified files: sbin/geom/class/mirror gmirror.8 sbin/geom/class/raid3 graid3.8 Log: Note that sysctls documentation is missing. Revision Changes Path 1.7 +2 -0 src/sbin/geom/class/mirror/gmirror.8 1.10 +2 -0 src/sbin/geom/class/raid3/graid3.8 From owner-cvs-src@FreeBSD.ORG Fri Nov 5 22:40:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E28E916A4CE; Fri, 5 Nov 2004 22:40:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C26C943D39; Fri, 5 Nov 2004 22:40:33 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5MeXQY039318; Fri, 5 Nov 2004 22:40:33 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5MeX0g039317; Fri, 5 Nov 2004 22:40:33 GMT (envelope-from davidxu) Message-Id: <200411052240.iA5MeX0g039317@repoman.freebsd.org> From: David Xu Date: Fri, 5 Nov 2004 22:40:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 22:40:34 -0000 davidxu 2004-11-05 22:40:33 UTC FreeBSD src repository Modified files: sys/kern kern_thread.c Log: Respect TDF_SINTR, don't suspend uninterruptible thread. Revision Changes Path 1.207 +3 -4 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:48:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A78516A4CE; Fri, 5 Nov 2004 23:48:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EECE043D53; Fri, 5 Nov 2004 23:48:12 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5NmCFk041603; Fri, 5 Nov 2004 23:48:12 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5NmCLP041602; Fri, 5 Nov 2004 23:48:12 GMT (envelope-from cognet) Message-Id: <200411052348.iA5NmCLP041602@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:48:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/include atomic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:48:13 -0000 cognet 2004-11-05 23:48:12 UTC FreeBSD src repository Modified files: sys/arm/include atomic.h Log: Disable interrupts for atomic_cmpset_32, this one is just not atomic. Don't export it to userland. Revision Changes Path 1.3 +13 -10 src/sys/arm/include/atomic.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:49:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE1B616A4CE; Fri, 5 Nov 2004 23:49:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA07543D46; Fri, 5 Nov 2004 23:49:21 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5NnLHk041692; Fri, 5 Nov 2004 23:49:21 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5NnLSU041691; Fri, 5 Nov 2004 23:49:21 GMT (envelope-from cognet) Message-Id: <200411052349.iA5NnLSU041691@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:49:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/arm/arm context.S pthread_md.c src/lib/libpthread/arch/arm/include atomic_ops.h pthread_md.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:49:22 -0000 cognet 2004-11-05 23:49:21 UTC FreeBSD src repository Modified files: lib/libpthread/arch/arm/arm context.S pthread_md.c lib/libpthread/arch/arm/include atomic_ops.h pthread_md.h Log: Partial support of KSE for arm. Revision Changes Path 1.2 +8 -13 src/lib/libpthread/arch/arm/arm/context.S 1.3 +4 -11 src/lib/libpthread/arch/arm/arm/pthread_md.c 1.2 +20 -3 src/lib/libpthread/arch/arm/include/atomic_ops.h 1.7 +34 -32 src/lib/libpthread/arch/arm/include/pthread_md.h From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:51:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D307B16A4D1; Fri, 5 Nov 2004 23:51:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 760B343D49; Fri, 5 Nov 2004 23:51:24 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5NpOV9041966; Fri, 5 Nov 2004 23:51:24 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5NpOYj041965; Fri, 5 Nov 2004 23:51:24 GMT (envelope-from cognet) Message-Id: <200411052351.iA5NpOYj041965@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:51:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/arm Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:51:25 -0000 cognet 2004-11-05 23:51:24 UTC FreeBSD src repository Added files: lib/libc/arm Makefile.inc Log: Import a Makefile for arm. Revision Changes Path 1.1 +8 -0 src/lib/libc/arm/Makefile.inc (new) From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:52:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40A4D16A4CE; Fri, 5 Nov 2004 23:52:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CF2A43D1D; Fri, 5 Nov 2004 23:52:06 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5Nq6Y4042032; Fri, 5 Nov 2004 23:52:06 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5Nq5AR042031; Fri, 5 Nov 2004 23:52:06 GMT (envelope-from cognet) Message-Id: <200411052352.iA5Nq5AR042031@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:52:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/arm/sys Makefile.inc getcontext.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:52:06 -0000 cognet 2004-11-05 23:52:05 UTC FreeBSD src repository Modified files: lib/libc/arm/sys Makefile.inc Removed files: lib/libc/arm/sys getcontext.S Log: Remove getcontext.S, it is not needed. Revision Changes Path 1.2 +1 -1 src/lib/libc/arm/sys/Makefile.inc 1.2 +0 -63 src/lib/libc/arm/sys/getcontext.S (dead) From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:53:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C2B116A4CE; Fri, 5 Nov 2004 23:53:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A01E43D45; Fri, 5 Nov 2004 23:53:03 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5Nr2Ws042115; Fri, 5 Nov 2004 23:53:02 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5Nr2Le042114; Fri, 5 Nov 2004 23:53:02 GMT (envelope-from cognet) Message-Id: <200411052353.iA5Nr2Le042114@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:53:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/arm/gen _ctx_start.S makecontext.c signalcontext.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:53:03 -0000 cognet 2004-11-05 23:53:02 UTC FreeBSD src repository Modified files: lib/libc/arm/gen _ctx_start.S makecontext.c signalcontext.c Log: Fix signalcontext and makecontext. Revision Changes Path 1.2 +3 -2 src/lib/libc/arm/gen/_ctx_start.S 1.2 +6 -4 src/lib/libc/arm/gen/makecontext.c 1.2 +8 -8 src/lib/libc/arm/gen/signalcontext.c From owner-cvs-src@FreeBSD.ORG Fri Nov 5 23:53:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AF3716A4CE; Fri, 5 Nov 2004 23:53:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 490E443D39; Fri, 5 Nov 2004 23:53:54 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5Nrsa2042153; Fri, 5 Nov 2004 23:53:54 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA5NrsAH042152; Fri, 5 Nov 2004 23:53:54 GMT (envelope-from cognet) Message-Id: <200411052353.iA5NrsAH042152@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 5 Nov 2004 23:53:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/arm/gen _setjmp.S setjmp.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 23:53:54 -0000 cognet 2004-11-05 23:53:54 UTC FreeBSD src repository Modified files: lib/libc/arm/gen _setjmp.S setjmp.S Log: Don't define SOFTFLOAT directly in source files, it's now done in the Makefile. Revision Changes Path 1.2 +1 -1 src/lib/libc/arm/gen/_setjmp.S 1.3 +0 -1 src/lib/libc/arm/gen/setjmp.S From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:14:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B879016A4CE; Sat, 6 Nov 2004 03:14:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACFC443D1D; Sat, 6 Nov 2004 03:14:26 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63EQjI055361; Sat, 6 Nov 2004 03:14:26 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63EQNL055360; Sat, 6 Nov 2004 03:14:26 GMT (envelope-from peter) Message-Id: <200411060314.iA63EQNL055360@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:14:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src Makefile Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:14:26 -0000 peter 2004-11-06 03:14:26 UTC FreeBSD src repository Modified files: . Makefile Makefile.inc1 Log: Convert tools/lib32/build.sh into world connectable hooks. This still rates pretty high on the "hack!" scale, but it works for me. Adding -DWANT_LIB32 to the world build command line, or 'WANT_LIB32=yes' to /etc/make.conf will include the 32 bit libraries with the build. I have not made this default behavior. Cross compiling this stuff is an adventure I have not investigated. This is still a WIP. We needed this at work so that we could install from a readonly obj tree - lib32/build.sh wasn't up to that. Revision Changes Path 1.310 +2 -1 src/Makefile 1.451 +93 -0 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:22:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0AA816A4CF for ; Sat, 6 Nov 2004 03:22:57 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B05543D4C for ; Sat, 6 Nov 2004 03:22:57 +0000 (GMT) (envelope-from caelian@gmail.com) Received: by rproxy.gmail.com with SMTP id a36so148475rnf for ; Fri, 05 Nov 2004 19:22:53 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=AG0vVAWpnFMCEGM6go9N71Gq4cAD1stPOx/rLAgnIZzTQ+t1cVdOlWEaU+VtRTkqzDhn8rz9vL6votJ3IN37cVbP021nSq6/4euCjtYCQJfjucGrWq/9FJDIcqcqlYnm0PZ+uJ/t5yyNkGHPlc4SbLEnGuU3TwkGSuPviPLVv7w= Received: by 10.38.209.23 with SMTP id h23mr739989rng; Fri, 05 Nov 2004 19:22:53 -0800 (PST) Received: by 10.38.79.65 with HTTP; Fri, 5 Nov 2004 19:22:53 -0800 (PST) Message-ID: Date: Fri, 5 Nov 2004 19:22:53 -0800 From: Pascal Hofstee To: Jeff Roberson In-Reply-To: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <200410300735.i9U7ZrL2031884@repoman.freebsd.org> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Pascal Hofstee List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:22:58 -0000 On Sat, 30 Oct 2004 07:35:53 +0000 (UTC), Jeff Roberson wrote: > jeff 2004-10-30 07:35:53 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - In sched_prio() check to see if the kse is assigned to a runq as the > check for TD_ON_RUNQ() no longer means the thread is really on a run- > queue. I suspect this state should be re-evaluated as it must mean > something else now. This fixes ULE+KSE+PREEMPTION on UP x86. Hi Jeff, I decided to take this commit as a good moment to give SCHED_ULE + PREEMPTION a shot again in the hope of triggering potential bugs to further improve SCHED_ULE. And i must say ... without INVARIANTS/WITNESS ... SCED_ULE + PREEMPTION == SOLID ... No Panics for well over 2 days during general desktop usage and compilation. I then decided to give it a real stress-test and decided to also enable WITNESS, INVARIANTS and FULL_PREEMPTION. This combination seemed just as stable at first ... untill i decided to shutdown Firefox .. which caused a system panic with the famous "Negative nice count" KASSERT from kern/sched_ule.c I did some additional testing and so far it seems that Every threaded application seems to exhibit this panic upon exit. I don't have an actual kerneldump at the moment ... but i should be able to generate one and provide additional information and/or a backtrace if desired. To reproduce simply exit a multi-threaded application ... firefox, ogg123 and apache-worker all caused the same panic. This is on a UP P2-400 MHz running 6.0-CURRENT as of November 3rd or 4th, With kind regard, Pascal Hofstee From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:23:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2B7216A4CE; Sat, 6 Nov 2004 03:23:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA9F943D39; Sat, 6 Nov 2004 03:23:36 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63Nafh055663; Sat, 6 Nov 2004 03:23:36 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63Nakd055662; Sat, 6 Nov 2004 03:23:36 GMT (envelope-from peter) Message-Id: <200411060323.iA63Nakd055662@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:23:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/include sysarch.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:23:37 -0000 peter 2004-11-06 03:23:36 UTC FreeBSD src repository Modified files: sys/i386/include sysarch.h Log: Begin an invasion of i386-land by amd64. Expose some of the amd64-specific sysarch functions to allow alternative implementations of the %fs/%gs code for TLS, threads, etc. USER_LDT does not exist on the amd64 kernel, so we have to implement things other ways. Revision Changes Path 1.21 +11 -0 src/sys/i386/include/sysarch.h From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:28:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03D1816A4CE; Sat, 6 Nov 2004 03:28:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9DE443D1D; Sat, 6 Nov 2004 03:28:26 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63SQHr055998; Sat, 6 Nov 2004 03:28:26 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63SQBH055997; Sat, 6 Nov 2004 03:28:26 GMT (envelope-from peter) Message-Id: <200411060328.iA63SQBH055997@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:28:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/i386/gen _set_tp.c src/lib/libc/i386/sys Makefile.inc _amd64_get_fsbase.c _amd64_get_gsbase.c _amd64_set_fsbase.c _amd64_set_gsbase.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:28:27 -0000 peter 2004-11-06 03:28:26 UTC FreeBSD src repository Modified files: lib/libc/i386/gen _set_tp.c lib/libc/i386/sys Makefile.inc Added files: lib/libc/i386/sys _amd64_get_fsbase.c _amd64_get_gsbase.c _amd64_set_fsbase.c _amd64_set_gsbase.c Log: When building the custom i386 libraries for use on amd64 kernels, we can't use the i386_set_ldt() family of routines, because they are not implemented. Instead, use the recently exposed direct access sysarch routines for setting what %fs and %gs point to. Use this for the i386 TLS _set_tp() routine, but only when compiling to run as a 32 bit support binary for amd64 kernels. Revision Changes Path 1.2 +4 -0 src/lib/libc/i386/gen/_set_tp.c 1.28 +4 -0 src/lib/libc/i386/sys/Makefile.inc 1.1 +44 -0 src/lib/libc/i386/sys/_amd64_get_fsbase.c (new) 1.1 +44 -0 src/lib/libc/i386/sys/_amd64_get_gsbase.c (new) 1.1 +37 -0 src/lib/libc/i386/sys/_amd64_set_fsbase.c (new) 1.1 +37 -0 src/lib/libc/i386/sys/_amd64_set_gsbase.c (new) From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:30:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6653416A4CE; Sat, 6 Nov 2004 03:30:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 463C643D49; Sat, 6 Nov 2004 03:30:53 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63UrI6056162; Sat, 6 Nov 2004 03:30:53 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63UrIe056161; Sat, 6 Nov 2004 03:30:53 GMT (envelope-from peter) Message-Id: <200411060330.iA63UrIe056161@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:30:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libthr/arch/i386/i386 _setcurthread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:30:53 -0000 peter 2004-11-06 03:30:53 UTC FreeBSD src repository Modified files: lib/libthr/arch/i386/i386 _setcurthread.c Log: Use the recently exposed fs/gs set functions when compiling libthr to run as a 32 bit support library for an amd64 kernel. 32 bit consumers of libthr have zero chance of running on an amd64 kernel since we don't implement the i386_set_ldt() family of functions. Note that this commit doesn't make it actually work, it just removes one more obstacle. Revision Changes Path 1.16 +12 -0 src/lib/libthr/arch/i386/i386/_setcurthread.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:32:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5174016A4CE; Sat, 6 Nov 2004 03:32:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30EEA43D3F; Sat, 6 Nov 2004 03:32:08 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63W8pv056218; Sat, 6 Nov 2004 03:32:08 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63W8Ts056217; Sat, 6 Nov 2004 03:32:08 GMT (envelope-from peter) Message-Id: <200411060332.iA63W8Ts056217@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:32:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/rtld-elf/i386 reloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:32:08 -0000 peter 2004-11-06 03:32:08 UTC FreeBSD src repository Modified files: libexec/rtld-elf/i386 reloc.c Log: The 32 bit compatability ld-elf32.so.1 cannot use i386_set_ldt() when running on an amd64 kernel. Use the recently exposed direct %fs/%gs set routines instead for the TLS setup of 32 bit binaries. Revision Changes Path 1.14 +6 -0 src/libexec/rtld-elf/i386/reloc.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:33:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1055A16A4CE; Sat, 6 Nov 2004 03:33:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4F6A43D1D; Sat, 6 Nov 2004 03:33:19 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63XJQ5056280; Sat, 6 Nov 2004 03:33:19 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63XJqf056279; Sat, 6 Nov 2004 03:33:19 GMT (envelope-from peter) Message-Id: <200411060333.iA63XJqf056279@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:33:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/amd64/amd64 pthread_md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:33:20 -0000 peter 2004-11-06 03:33:19 UTC FreeBSD src repository Modified files: lib/libpthread/arch/amd64/amd64 pthread_md.c Log: Cosmetic tweaks to reduce diffs to the i386 counterpart. Revision Changes Path 1.4 +3 -2 src/lib/libpthread/arch/amd64/amd64/pthread_md.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 03:35:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8069A16A4CE; Sat, 6 Nov 2004 03:35:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED2F43D2D; Sat, 6 Nov 2004 03:35:51 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA63Zpvp056497; Sat, 6 Nov 2004 03:35:51 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA63ZpTK056496; Sat, 6 Nov 2004 03:35:51 GMT (envelope-from peter) Message-Id: <200411060335.iA63ZpTK056496@repoman.freebsd.org> From: Peter Wemm Date: Sat, 6 Nov 2004 03:35:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/arch/i386/i386 pthread_md.c src/lib/libpthread/arch/i386/include pthread_md.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 03:35:51 -0000 peter 2004-11-06 03:35:51 UTC FreeBSD src repository Modified files: lib/libpthread/arch/i386/i386 pthread_md.c lib/libpthread/arch/i386/include pthread_md.h Log: i386_set_ldt() is not available when running 32 bit binaries on amd64 kernels. Use the recently exposed direct-set routines instead. This is only activated for when we compile i386 support libraries on amd64. Revision Changes Path 1.4 +6 -0 src/lib/libpthread/arch/i386/i386/pthread_md.c 1.13 +7 -0 src/lib/libpthread/arch/i386/include/pthread_md.h From owner-cvs-src@FreeBSD.ORG Sat Nov 6 05:25:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7355516A4CE; Sat, 6 Nov 2004 05:25:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6829943D41; Sat, 6 Nov 2004 05:25:53 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA65PrHT068038; Sat, 6 Nov 2004 05:25:53 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA65PrRO068037; Sat, 6 Nov 2004 05:25:53 GMT (envelope-from kientzle) Message-Id: <200411060525.iA65PrRO068037@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 6 Nov 2004 05:25:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_private.h archive_write_set_compression_bzip2.carchive_write_set_compression_none.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 05:25:53 -0000 kientzle 2004-11-06 05:25:53 UTC FreeBSD src repository Modified files: lib/libarchive archive_private.h archive_write_set_compression_bzip2.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c Log: Ooops. ssize_t != int. Thanks to: Oliver Lehmann and Peter Wemm Revision Changes Path 1.16 +1 -1 src/lib/libarchive/archive_private.h 1.7 +1 -1 src/lib/libarchive/archive_write_set_compression_bzip2.c 1.9 +1 -1 src/lib/libarchive/archive_write_set_compression_gzip.c 1.7 +1 -1 src/lib/libarchive/archive_write_set_compression_none.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 05:33:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63F6C16A4CE; Sat, 6 Nov 2004 05:33:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5970843D46; Sat, 6 Nov 2004 05:33:02 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA65X2qt068367; Sat, 6 Nov 2004 05:33:02 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA65X2wH068366; Sat, 6 Nov 2004 05:33:02 GMT (envelope-from alc) Message-Id: <200411060533.iA65X2wH068366@repoman.freebsd.org> From: Alan Cox Date: Sat, 6 Nov 2004 05:33:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_default.c src/sys/vm vm_object.c vm_object.h vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 05:33:02 -0000 alc 2004-11-06 05:33:02 UTC FreeBSD src repository Modified files: sys/kern vfs_default.c sys/vm vm_object.c vm_object.h vnode_pager.c Log: Move a call to wakeup() from vm_object_terminate() to vnode_pager_dealloc() because this call is only needed to wake threads that slept when they discovered a dead object connected to a vnode. To eliminate unnecessary calls to wakeup() by vnode_pager_dealloc(), introduce a new flag, OBJ_DISCONNECTWNT. Reviewed by: tegge@ Revision Changes Path 1.104 +1 -0 src/sys/kern/vfs_default.c 1.335 +0 -2 src/sys/vm/vm_object.c 1.107 +1 -0 src/sys/vm/vm_object.h 1.202 +5 -0 src/sys/vm/vnode_pager.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 06:13:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD90816A4CE; Sat, 6 Nov 2004 06:13:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C31F43D41; Sat, 6 Nov 2004 06:13:13 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA66DDxb069631; Sat, 6 Nov 2004 06:13:13 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA66DDgP069630; Sat, 6 Nov 2004 06:13:13 GMT (envelope-from keramida) Message-Id: <200411060613.iA66DDgP069630@repoman.freebsd.org> From: Giorgos Keramidas Date: Sat, 6 Nov 2004 06:13:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/boot/i386/boot0 boot0.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 06:13:13 -0000 keramida 2004-11-06 06:13:13 UTC FreeBSD src repository (doc committer) Modified files: sys/boot/i386/boot0 boot0.S Log: Clean up the comments, rewording, adding missing punctuation and other minor nits. Approved by: jhb Revision Changes Path 1.11 +26 -35 src/sys/boot/i386/boot0/boot0.S From owner-cvs-src@FreeBSD.ORG Sat Nov 6 06:29:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 450C616A4CE; Sat, 6 Nov 2004 06:29:50 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9CBF43D39; Sat, 6 Nov 2004 06:29:49 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id iA66Tt0W002661; Sat, 6 Nov 2004 01:29:55 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id iA66Ttc0002660; Sat, 6 Nov 2004 01:29:55 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Sat, 6 Nov 2004 01:29:55 -0500 From: David Schultz To: John Baldwin Message-ID: <20041106062955.GA1986@VARK.MIT.EDU> Mail-Followup-To: John Baldwin , Alfred Perlstein , Alan Cox , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> <200411011441.33067.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411011441.33067.jhb@FreeBSD.org> cc: Alan Cox cc: cvs-src@FreeBSD.ORG cc: Alfred Perlstein cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 06:29:50 -0000 On Mon, Nov 01, 2004, John Baldwin wrote: > On Monday 01 November 2004 05:51 am, Alfred Perlstein wrote: > > * Alan Cox [041031 20:53] wrote: > > > On Sun, Oct 31, 2004 at 07:13:17PM -0800, Alfred Perlstein wrote: > > > > * Alan Cox [041031 11:33] wrote: > > > > > alc 2004-10-31 19:32:57 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/vm vm_zeroidle.c > > > > > Log: > > > > > Introduce a Boolean variable wakeup_needed to avoid repeated, > > > > > unnecessary calls to wakeup() by vm_page_zero_idle_wakeup(). > > > > > > > > > > Revision Changes Path > > > > > 1.31 +9 -2 src/sys/vm/vm_zeroidle.c > > > > > > > > Why not switch to a cv? > > > > > > Calling cv_signal repeatedly would be no better than calling wakeup() > > > repeatedly. Either way, a Boolean variable is desirable to prevent > > > unnecessary calls. > > > > Yah, I figured there would be something in the cv code to optimize > > the "no waiters" case. > > There is, though sometimes it might think there are waiters when there > actually aren't any. It doesn't look very optimized: void cv_signal(struct cv *cvp) { sleepq_lock(cvp); ^^^^^^^^^^^^^^^^^ if (cvp->cv_waiters > 0) { [...] } else sleepq_release(cvp); The mutex associated with the condition variable will be held on entry to both cv_wait() and cv_signal(), so why is the sleepqueue locked in the no waiters case? From owner-cvs-src@FreeBSD.ORG Sat Nov 6 07:17:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C07A016A4CE; Sat, 6 Nov 2004 07:17:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B666943D58; Sat, 6 Nov 2004 07:17:50 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA67HogA071580; Sat, 6 Nov 2004 07:17:50 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA67HoHA071579; Sat, 6 Nov 2004 07:17:50 GMT (envelope-from das) Message-Id: <200411060717.iA67HoHA071579@repoman.freebsd.org> From: David Schultz Date: Sat, 6 Nov 2004 07:17:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 07:17:50 -0000 das 2004-11-06 07:17:50 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: Fix the last known race in swapoff(), which could lead to a spurious panic: swapoff: failed to locate %d swap blocks The race occurred because putpages() can block between the time it allocates swap space and the time it updates the swap metadata to associate that space with a vm_object, so swapoff() would complain about the temporary inconsistency. I hoped to fix this by making swp_pager_getswapspace() and swp_pager_meta_build() a single atomic operation, but that proved to be inconvenient. With this change, swapoff() simply doesn't attempt to be so clever about detecting when all the pageout activity to the target device should have drained. Revision Changes Path 1.264 +14 -21 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 07:59:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BA0F16A4CE; Sat, 6 Nov 2004 07:59:17 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E876943D31; Sat, 6 Nov 2004 07:59:16 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) iA67xCUP069854; Sat, 6 Nov 2004 07:59:13 GMT (envelope-from davidxu@freebsd.org) Message-ID: <418C844E.3030403@freebsd.org> Date: Sat, 06 Nov 2004 15:59:10 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Schultz References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> <200411011441.33067.jhb@FreeBSD.org> <20041106062955.GA1986@VARK.MIT.EDU> In-Reply-To: <20041106062955.GA1986@VARK.MIT.EDU> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: John Baldwin cc: Alan Cox cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 07:59:17 -0000 David Schultz wrote: >On Mon, Nov 01, 2004, John Baldwin wrote: > > >>On Monday 01 November 2004 05:51 am, Alfred Perlstein wrote: >> >> >>>* Alan Cox [041031 20:53] wrote: >>> >>> >>>>On Sun, Oct 31, 2004 at 07:13:17PM -0800, Alfred Perlstein wrote: >>>> >>>> >>>>>* Alan Cox [041031 11:33] wrote: >>>>> >>>>> >>>>>>alc 2004-10-31 19:32:57 UTC >>>>>> >>>>>> FreeBSD src repository >>>>>> >>>>>> Modified files: >>>>>> sys/vm vm_zeroidle.c >>>>>> Log: >>>>>> Introduce a Boolean variable wakeup_needed to avoid repeated, >>>>>>unnecessary calls to wakeup() by vm_page_zero_idle_wakeup(). >>>>>> >>>>>> Revision Changes Path >>>>>> 1.31 +9 -2 src/sys/vm/vm_zeroidle.c >>>>>> >>>>>> >>>>>Why not switch to a cv? >>>>> >>>>> >>>>Calling cv_signal repeatedly would be no better than calling wakeup() >>>>repeatedly. Either way, a Boolean variable is desirable to prevent >>>>unnecessary calls. >>>> >>>> >>>Yah, I figured there would be something in the cv code to optimize >>>the "no waiters" case. >>> >>> >>There is, though sometimes it might think there are waiters when there >>actually aren't any. >> >> > >It doesn't look very optimized: > > void > cv_signal(struct cv *cvp) > { > > sleepq_lock(cvp); > ^^^^^^^^^^^^^^^^^ > if (cvp->cv_waiters > 0) { > [...] > } else > sleepq_release(cvp); > >The mutex associated with the condition variable will be held on >entry to both cv_wait() and cv_signal(), so why is the sleepqueue >locked in the no waiters case? > > > > cv_wait and cv_signal have to pass a serialization point, the serialization point is condition variable internal lock, before testing cvp_waiters, the internal lock should be locked, otherwise you should be ready to hit the race condition. It is legal to call cv_signal() without a locked mutex. David Xu From owner-cvs-src@FreeBSD.ORG Sat Nov 6 08:11:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DD4C16A4CE; Sat, 6 Nov 2004 08:11:42 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11DFB43D41; Sat, 6 Nov 2004 08:11:42 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id iA68BlRo001797; Sat, 6 Nov 2004 03:11:47 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id iA68BlOR001796; Sat, 6 Nov 2004 03:11:47 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Sat, 6 Nov 2004 03:11:47 -0500 From: David Schultz To: David Xu Message-ID: <20041106081147.GA1419@VARK.MIT.EDU> Mail-Followup-To: David Xu , John Baldwin , Alfred Perlstein , Alan Cox , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> <200411011441.33067.jhb@FreeBSD.org> <20041106062955.GA1986@VARK.MIT.EDU> <418C844E.3030403@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <418C844E.3030403@freebsd.org> cc: src-committers@FreeBSD.ORG cc: John Baldwin cc: Alan Cox cc: cvs-src@FreeBSD.ORG cc: Alfred Perlstein cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 08:11:42 -0000 On Sat, Nov 06, 2004, David Xu wrote: [...] > It is legal to call cv_signal() without a locked mutex. Not according to the manpage or the comments in the code. What you say is true about pthreads, but pthreads is broken in this respect. From owner-cvs-src@FreeBSD.ORG Sat Nov 6 08:18:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 854FF16A4CE; Sat, 6 Nov 2004 08:18:20 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7913343D2F; Sat, 6 Nov 2004 08:18:20 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1]) iA68IFee074168; Sat, 6 Nov 2004 08:18:17 GMT (envelope-from davidxu@freebsd.org) Message-ID: <418C88C5.9010803@freebsd.org> Date: Sat, 06 Nov 2004 16:18:13 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Schultz References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> <200411011441.33067.jhb@FreeBSD.org> <20041106062955.GA1986@VARK.MIT.EDU> <418C844E.3030403@freebsd.org> <20041106081147.GA1419@VARK.MIT.EDU> In-Reply-To: <20041106081147.GA1419@VARK.MIT.EDU> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: John Baldwin cc: Alan Cox cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 08:18:20 -0000 David Schultz wrote: >On Sat, Nov 06, 2004, David Xu wrote: >[...] > > >>It is legal to call cv_signal() without a locked mutex. >> >> > >Not according to the manpage or the comments in the code. >What you say is true about pthreads, but pthreads is broken >in this respect. > > > > I don't think it is broken, calling cv_signal with mutex locked just introduce ping-pong problem. From owner-cvs-src@FreeBSD.ORG Sat Nov 6 09:56:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4484516A4CE; Sat, 6 Nov 2004 09:56:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1042543D5C; Sat, 6 Nov 2004 09:56:28 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA69uRtR083757; Sat, 6 Nov 2004 09:56:27 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA69uRat083756; Sat, 6 Nov 2004 09:56:27 GMT (envelope-from dd) Message-Id: <200411060956.iA69uRat083756@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 6 Nov 2004 09:56:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/mdconfig mdconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 09:56:28 -0000 dd 2004-11-06 09:56:27 UTC FreeBSD src repository Modified files: sbin/mdconfig mdconfig.c Log: If there aren't any devices to list, output nothing instead of an empty line. This is consistent with other utilities. While I'm here, remove artifacts of the previous list implementation. Revision Changes Path 1.36 +2 -10 src/sbin/mdconfig/mdconfig.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 10:21:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28FBF16A4CE; Sat, 6 Nov 2004 10:21:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0899D43D3F; Sat, 6 Nov 2004 10:21:13 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6ALCcG084568; Sat, 6 Nov 2004 10:21:12 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6ALCII084567; Sat, 6 Nov 2004 10:21:12 GMT (envelope-from dd) Message-Id: <200411061021.iA6ALCII084567@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 6 Nov 2004 10:21:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/mdconfig mdconfig.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 10:21:13 -0000 dd 2004-11-06 10:21:12 UTC FreeBSD src repository Modified files: sbin/mdconfig mdconfig.8 Log: Update the description of -l to reflect reality. After mdconfig.c 1.25, -l without -u only lists the names, so specifying -u does more than just limit the output to one device. Revision Changes Path 1.31 +5 -6 src/sbin/mdconfig/mdconfig.8 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 10:47:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 062C616A4CE; Sat, 6 Nov 2004 10:47:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DABB843D2F; Sat, 6 Nov 2004 10:47:36 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6AlaWY085356; Sat, 6 Nov 2004 10:47:36 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6Ala0w085355; Sat, 6 Nov 2004 10:47:36 GMT (envelope-from andre) Message-Id: <200411061047.iA6Ala0w085355@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 6 Nov 2004 10:47:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fastfwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 10:47:37 -0000 andre 2004-11-06 10:47:36 UTC FreeBSD src repository Modified files: sys/netinet ip_fastfwd.c Log: Fix a double-free in the 'm->m_len < sizeof (struct ip)' sanity check. Bug report by: MFC after: 2 weeks Revision Changes Path 1.24 +2 -2 src/sys/netinet/ip_fastfwd.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:03:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9ACE516A4CE; Sat, 6 Nov 2004 11:03:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A46443D54; Sat, 6 Nov 2004 11:03:59 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6B3xE1085852; Sat, 6 Nov 2004 11:03:59 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6B3xRZ085851; Sat, 6 Nov 2004 11:03:59 GMT (envelope-from dd) Message-Id: <200411061103.iA6B3xRZ085851@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 6 Nov 2004 11:03:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/devfs devfs.8 rule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:03:59 -0000 dd 2004-11-06 11:03:59 UTC FreeBSD src repository Modified files: sbin/devfs devfs.8 rule.c Log: Parse file mode with setmode(3) for consistency with other programs that do this kind of thing. Revision Changes Path 1.9 +2 -1 src/sbin/devfs/devfs.8 1.6 +7 -11 src/sbin/devfs/rule.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:16:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 284CC16A4CE; Sat, 6 Nov 2004 11:16:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09B2F43D2F; Sat, 6 Nov 2004 11:16:57 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BGuLL086369; Sat, 6 Nov 2004 11:16:56 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BGuZK086368; Sat, 6 Nov 2004 11:16:56 GMT (envelope-from dd) Message-Id: <200411061116.iA6BGuZK086368@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 6 Nov 2004 11:16:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/devfs devfs.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:16:57 -0000 dd 2004-11-06 11:16:56 UTC FreeBSD src repository Modified files: sbin/devfs devfs.8 Log: Remove a useless use of cat, strip overzealous punctuation, and clarify some text. Revision Changes Path 1.10 +16 -16 src/sbin/devfs/devfs.8 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:24:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38DA416A4CE; Sat, 6 Nov 2004 11:24:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1818643D46; Sat, 6 Nov 2004 11:24:41 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BOe2U086573; Sat, 6 Nov 2004 11:24:40 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BOe2L086572; Sat, 6 Nov 2004 11:24:40 GMT (envelope-from rwatson) Message-Id: <200411061124.iA6BOe2L086572@repoman.freebsd.org> From: Robert Watson Date: Sat, 6 Nov 2004 11:24:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:24:41 -0000 rwatson 2004-11-06 11:24:40 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Annotate what bucket_size[] array does; staticize since it's used only in uma_core.c. Revision Changes Path 1.109 +5 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:33:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD42F16A4CE; Sat, 6 Nov 2004 11:33:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E07B43D1D; Sat, 6 Nov 2004 11:33:11 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BXBJo086907; Sat, 6 Nov 2004 11:33:11 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BXBXl086906; Sat, 6 Nov 2004 11:33:11 GMT (envelope-from phk) Message-Id: <200411061133.iA6BXBXl086906@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 11:33:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:33:11 -0000 phk 2004-11-06 11:33:11 UTC FreeBSD src repository Modified files: sys/vm vm_zeroidle.c Log: Remove dangling variable Revision Changes Path 1.33 +0 -1 src/sys/vm/vm_zeroidle.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:33:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A80C16A4CE; Sat, 6 Nov 2004 11:33:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE6DC43D54; Sat, 6 Nov 2004 11:33:43 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BXhrU086941; Sat, 6 Nov 2004 11:33:43 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BXhHT086940; Sat, 6 Nov 2004 11:33:43 GMT (envelope-from phk) Message-Id: <200411061133.iA6BXhHT086940@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 11:33:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:33:44 -0000 phk 2004-11-06 11:33:43 UTC FreeBSD src repository Modified files: sys/kern subr_param.c Log: Increase default HZ for i386 to 1000 Revision Changes Path 1.65 +6 -4 src/sys/kern/subr_param.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:41:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EBD116A4CE; Sat, 6 Nov 2004 11:41:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82C4243D49; Sat, 6 Nov 2004 11:41:22 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BfMHo087342; Sat, 6 Nov 2004 11:41:22 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BfM7u087341; Sat, 6 Nov 2004 11:41:22 GMT (envelope-from phk) Message-Id: <200411061141.iA6BfM7u087341@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 11:41:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern vfs_default.c src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:41:22 -0000 phk 2004-11-06 11:41:22 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c sys/fs/fifofs fifo_vnops.c sys/gnu/ext2fs ext2_vnops.c sys/kern vfs_default.c sys/ufs/ufs ufs_vnops.c Log: Properly implement a default version of VOP_GETWRITEMOUNT. Remove improper access to vop_stdgetwritemount() which should and will instead rely on the VOP default path. Revision Changes Path 1.81 +0 -1 src/sys/fs/devfs/devfs_vnops.c 1.102 +0 -1 src/sys/fs/fifofs/fifo_vnops.c 1.90 +0 -1 src/sys/gnu/ext2fs/ext2_vnops.c 1.105 +1 -0 src/sys/kern/vfs_default.c 1.250 +0 -1 src/sys/ufs/ufs/ufs_vnops.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 11:43:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8BF216A4CE; Sat, 6 Nov 2004 11:43:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B863E43D2D; Sat, 6 Nov 2004 11:43:30 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6BhU1N087470; Sat, 6 Nov 2004 11:43:30 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6BhUbf087469; Sat, 6 Nov 2004 11:43:30 GMT (envelope-from rwatson) Message-Id: <200411061143.iA6BhUbf087469@repoman.freebsd.org> From: Robert Watson Date: Sat, 6 Nov 2004 11:43:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 11:43:31 -0000 rwatson 2004-11-06 11:43:30 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Abstract the logic to look up the uma_bucket_zone given a desired number of entries into bucket_zone_lookup(), which helps make more clear the logic of consumers of bucket zones. Annotate the behavior of bucket_init() with a comment indicating how the various data structures, including the bucket lookup tables, are initialized. Revision Changes Path 1.110 +23 -7 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 12:15:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3942F16A4CE; Sat, 6 Nov 2004 12:15:22 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2522143D45; Sat, 6 Nov 2004 12:15:22 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1D3B95CA1A; Sat, 6 Nov 2004 04:15:22 -0800 (PST) Date: Sat, 6 Nov 2004 04:15:22 -0800 From: Alfred Perlstein To: David Xu Message-ID: <20041106121522.GE24892@elvis.mu.org> References: <200410311932.i9VJWvmo058193@repoman.freebsd.org> <20041101045331.GP16728@cs.rice.edu> <20041101105113.GS24892@elvis.mu.org> <200411011441.33067.jhb@FreeBSD.org> <20041106062955.GA1986@VARK.MIT.EDU> <418C844E.3030403@freebsd.org> <20041106081147.GA1419@VARK.MIT.EDU> <418C88C5.9010803@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <418C88C5.9010803@freebsd.org> User-Agent: Mutt/1.4.2.1i cc: src-committers@freebsd.org cc: John Baldwin cc: Alan Cox cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: David Schultz Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 12:15:22 -0000 * David Xu [041106 00:18] wrote: > David Schultz wrote: > > >On Sat, Nov 06, 2004, David Xu wrote: > >[...] > > > > > >>It is legal to call cv_signal() without a locked mutex. > >> > >> > > > >Not according to the manpage or the comments in the code. > >What you say is true about pthreads, but pthreads is broken > >in this respect. > > > > > > > > > I don't think it is broken, calling cv_signal with mutex locked > just introduce ping-pong problem. Being able to rely on an external mutex will effectively halve the number of mutex operations needed on CVs. It seems to make sense to enforce that the associated mutex is held. The external mutex should be dropped as soon as possible, and that means it'll only add the time of a couple of more cycles to the race for contesting on the external mutex. -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 13:07:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0200316A4CE; Sat, 6 Nov 2004 13:07:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D444943D46; Sat, 6 Nov 2004 13:07:02 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6D72rp096847; Sat, 6 Nov 2004 13:07:02 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6D72uE096846; Sat, 6 Nov 2004 13:07:02 GMT (envelope-from pjd) Message-Id: <200411061307.iA6D72uE096846@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 6 Nov 2004 13:07:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys mdioctl.h src/sys/dev/md md.c src/sbin/mdconfig mdconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 13:07:03 -0000 pjd 2004-11-06 13:07:02 UTC FreeBSD src repository Modified files: sys/sys mdioctl.h sys/dev/md md.c sbin/mdconfig mdconfig.c Log: For file backed md(4) devices output their source file via 'mdconfig -l -u '. Bump version number, as this change breaks ABI/API. Revision Changes Path 1.37 +7 -2 src/sbin/mdconfig/mdconfig.c 1.143 +13 -4 src/sys/dev/md/md.c 1.18 +2 -2 src/sys/sys/mdioctl.h From owner-cvs-src@FreeBSD.ORG Sat Nov 6 13:16:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3BB216A4CE; Sat, 6 Nov 2004 13:16:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3AE543D55; Sat, 6 Nov 2004 13:16:35 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6DGZfD097233; Sat, 6 Nov 2004 13:16:35 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6DGZt6097232; Sat, 6 Nov 2004 13:16:35 GMT (envelope-from pjd) Message-Id: <200411061316.iA6DGZt6097232@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 6 Nov 2004 13:16:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/md md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 13:16:36 -0000 pjd 2004-11-06 13:16:35 UTC FreeBSD src repository Modified files: sys/dev/md md.c Log: Be consistent and use 'if (error != 0)' instead of 'if (error)' everywhere. Revision Changes Path 1.144 +5 -5 src/sys/dev/md/md.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 13:24:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDB2616A4CE; Sat, 6 Nov 2004 13:24:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDF8F43D1D; Sat, 6 Nov 2004 13:24:53 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6DOrp4097569; Sat, 6 Nov 2004 13:24:53 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6DOrOO097568; Sat, 6 Nov 2004 13:24:53 GMT (envelope-from mtm) Message-Id: <200411061324.iA6DOrOO097568@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 6 Nov 2004 13:24:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man7 tuning.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 13:24:54 -0000 mtm 2004-11-06 13:24:53 UTC FreeBSD src repository Modified files: share/man/man7 tuning.7 Log: Sync description of IP portrange sysctls with reality. MFC after: 2 weeks Revision Changes Path 1.68 +9 -10 src/share/man/man7/tuning.7 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 13:38:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1156816A4CE; Sat, 6 Nov 2004 13:38:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4FFF43D5A; Sat, 6 Nov 2004 13:38:45 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6Dcjb7098111; Sat, 6 Nov 2004 13:38:45 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6DcjQ9098110; Sat, 6 Nov 2004 13:38:45 GMT (envelope-from ru) Message-Id: <200411061338.iA6DcjQ9098110@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 6 Nov 2004 13:38:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ifconfig ifconfig.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 13:38:46 -0000 ru 2004-11-06 13:38:45 UTC FreeBSD src repository Modified files: sbin/ifconfig ifconfig.8 Log: First there was an -m option. Then Peter killed it and made it the default. Then Brooks and Poul-Henning added it again. Then Ruslan fixed the manpage... Revision Changes Path 1.86 +0 -3 src/sbin/ifconfig/ifconfig.8 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 13:56:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E139D16A4CE; Sat, 6 Nov 2004 13:56:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1A7743D45; Sat, 6 Nov 2004 13:56:18 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6DuIR0098777; Sat, 6 Nov 2004 13:56:18 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6DuIK4098776; Sat, 6 Nov 2004 13:56:18 GMT (envelope-from ache) Message-Id: <200411061356.iA6DuIK4098776@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sat, 6 Nov 2004 13:56:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/stty key.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 13:56:19 -0000 ache 2004-11-06 13:56:18 UTC FreeBSD src repository Modified files: bin/stty key.c Log: Back out recent TTYDEF_LFLAG_ECHO invention. This change is NOP, because TTYDEF_LFLAG = TTYDEF_LFLAG_ECHO now, but to minimize diffs with other BSDs. Revision Changes Path 1.20 +1 -1 src/bin/stty/key.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 14:03:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECD1F16A4CE; Sat, 6 Nov 2004 14:03:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC97843D49; Sat, 6 Nov 2004 14:03:37 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6E3ben099026; Sat, 6 Nov 2004 14:03:37 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6E3bB5099025; Sat, 6 Nov 2004 14:03:37 GMT (envelope-from dd) Message-Id: <200411061403.iA6E3bB5099025@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 6 Nov 2004 14:03:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/mdconfig mdconfig.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 14:03:38 -0000 dd 2004-11-06 14:03:37 UTC FreeBSD src repository Modified files: sbin/mdconfig mdconfig.8 Log: Bump .Dd, replace missing letter, and prefer to use a verb that matches the option letter. Submitted by: ru Should know better by now: dd Revision Changes Path 1.32 +3 -5 src/sbin/mdconfig/mdconfig.8 From owner-cvs-src@FreeBSD.ORG Sat Nov 6 14:38:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6697316A4CE; Sat, 6 Nov 2004 14:38:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4705043D2F; Sat, 6 Nov 2004 14:38:55 +0000 (GMT) (envelope-from josef@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6Ectgg000177; Sat, 6 Nov 2004 14:38:55 GMT (envelope-from josef@repoman.freebsd.org) Received: (from josef@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6Ect7S000176; Sat, 6 Nov 2004 14:38:55 GMT (envelope-from josef) Message-Id: <200411061438.iA6Ect7S000176@repoman.freebsd.org> From: Josef El-Rayes Date: Sat, 6 Nov 2004 14:38:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall menus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 14:38:55 -0000 josef 2004-11-06 14:38:54 UTC FreeBSD src repository (doc committer) Modified files: usr.sbin/sysinstall menus.c Log: Add ftp8.de.freebsd.org Requested by: vs Approved by: ssouhlal Revision Changes Path 1.402 +2 -0 src/usr.sbin/sysinstall/menus.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 14:50:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CB0016A4CE; Sat, 6 Nov 2004 14:50:10 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72BDC43D49; Sat, 6 Nov 2004 14:50:09 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 848F51FFACF; Sat, 6 Nov 2004 15:50:07 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 81E6C1FFACA; Sat, 6 Nov 2004 15:50:05 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 197271539F; Sat, 6 Nov 2004 14:48:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 0E8D615380; Sat, 6 Nov 2004 14:48:39 +0000 (UTC) Date: Sat, 6 Nov 2004 14:48:38 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Peter Wemm In-Reply-To: <200411060314.iA63EQNL055360@repoman.freebsd.org> Message-ID: References: <200411060314.iA63EQNL055360@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 14:50:10 -0000 On Sat, 6 Nov 2004, Peter Wemm wrote: > peter 2004-11-06 03:14:26 UTC > > FreeBSD src repository > > Modified files: > . Makefile Makefile.inc1 > Log: > Convert tools/lib32/build.sh into world connectable hooks. This still > rates pretty high on the "hack!" scale, but it works for me. Adding > -DWANT_LIB32 to the world build command line, or 'WANT_LIB32=yes' to > /etc/make.conf will include the 32 bit libraries with the build. MANY thanks :) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Sat Nov 6 16:38:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B673816A4CE; Sat, 6 Nov 2004 16:38:06 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id D13D843D2F; Sat, 6 Nov 2004 16:38:05 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iA6Gc44E040882; Sat, 6 Nov 2004 18:38:04 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 46828-10; Sat, 6 Nov 2004 18:38:03 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iA6Gc3aJ040879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Nov 2004 18:38:03 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iA6GbnE2039869; Sat, 6 Nov 2004 18:37:49 +0200 (EET) (envelope-from ru) Date: Sat, 6 Nov 2004 18:37:48 +0200 From: Ruslan Ermilov To: Poul-Henning Kamp Message-ID: <20041106163748.GB38881@ip.net.ua> References: <200411061133.iA6BXhHT086940@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz" Content-Disposition: inline In-Reply-To: <200411061133.iA6BXhHT086940@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 16:38:06 -0000 --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Nov 06, 2004 at 11:33:43AM +0000, Poul-Henning Kamp wrote: > phk 2004-11-06 11:33:43 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/kern subr_param.c=20 > Log: > Increase default HZ for i386 to 1000 > =20 > Revision Changes Path > 1.65 +6 -4 src/sys/kern/subr_param.c >=20 What's the motivation for this change? Also, NOTES and clocks(7) have not been updated. There may be more places to catch up with this change... Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --eJnRUKwClWJh1Khz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBjP3cqRfpzJluFF4RAjFIAJ93F8iOtyfeSuS0QcFAd9SQ9WL27QCeLOhv eyy8hoUgGmhw7dneYdQk+to= =p/Z9 -----END PGP SIGNATURE----- --eJnRUKwClWJh1Khz-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 16:47:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADACE16A4CE; Sat, 6 Nov 2004 16:47:27 +0000 (GMT) Received: from smtp-vbr1.xs4all.nl (smtp-vbr1.xs4all.nl [194.109.24.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 169A443D1F; Sat, 6 Nov 2004 16:47:27 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr1.xs4all.nl (8.12.11/8.12.11) with ESMTP id iA6GlOHq069079; Sat, 6 Nov 2004 17:47:25 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.1/8.12.9) with ESMTP id iA6GlO7n080700; Sat, 6 Nov 2004 17:47:24 +0100 (CET) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.1/8.13.1/Submit) id iA6GlOTW080699; Sat, 6 Nov 2004 17:47:24 +0100 (CET) (envelope-from wb) Date: Sat, 6 Nov 2004 17:47:24 +0100 From: Wilko Bulte To: Ruslan Ermilov Message-ID: <20041106164724.GA80682@freebie.xs4all.nl> References: <200411061133.iA6BXhHT086940@repoman.freebsd.org> <20041106163748.GB38881@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041106163748.GB38881@ip.net.ua> X-OS: FreeBSD 4.10-STABLE X-PGP: finger wilko@freebsd.org User-Agent: Mutt/1.5.6i X-Virus-Scanned: by XS4ALL Virus Scanner cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 16:47:27 -0000 On Sat, Nov 06, 2004 at 06:37:48PM +0200, Ruslan Ermilov wrote.. > Hi, > > On Sat, Nov 06, 2004 at 11:33:43AM +0000, Poul-Henning Kamp wrote: > > phk 2004-11-06 11:33:43 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_param.c > > Log: > > Increase default HZ for i386 to 1000 > > > > Revision Changes Path > > 1.65 +6 -4 src/sys/kern/subr_param.c > > > What's the motivation for this change? Also, NOTES > and clocks(7) have not been updated. There may be > more places to catch up with this change... dummynet(4) manpage / docs come to mind. -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Sat Nov 6 17:07:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC86E16A4CF; Sat, 6 Nov 2004 17:07:04 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EC0A43D41; Sat, 6 Nov 2004 17:07:04 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 5D6F5ACC68; Sat, 6 Nov 2004 18:07:02 +0100 (CET) Date: Sat, 6 Nov 2004 18:07:02 +0100 From: Pawel Jakub Dawidek To: Wilko Bulte Message-ID: <20041106170702.GY8120@darkness.comp.waw.pl> References: <200411061133.iA6BXhHT086940@repoman.freebsd.org> <20041106163748.GB38881@ip.net.ua> <20041106164724.GA80682@freebie.xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXAoLeOWtqbacoe/" Content-Disposition: inline In-Reply-To: <20041106164724.GA80682@freebie.xs4all.nl> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Ruslan Ermilov cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 17:07:05 -0000 --OXAoLeOWtqbacoe/ Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 06, 2004 at 05:47:24PM +0100, Wilko Bulte wrote: +> On Sat, Nov 06, 2004 at 06:37:48PM +0200, Ruslan Ermilov wrote.. +> > Hi, +> >=20 +> > On Sat, Nov 06, 2004 at 11:33:43AM +0000, Poul-Henning Kamp wrote: +> > > phk 2004-11-06 11:33:43 UTC +> > >=20 +> > > FreeBSD src repository +> > >=20 +> > > Modified files: +> > > sys/kern subr_param.c=20 +> > > Log: +> > > Increase default HZ for i386 to 1000 +> > > =20 +> > > Revision Changes Path +> > > 1.65 +6 -4 src/sys/kern/subr_param.c +> > >=20 +> > What's the motivation for this change? Also, NOTES +> > and clocks(7) have not been updated. There may be +> > more places to catch up with this change... +>=20 +> dummynet(4) manpage / docs come to mind. sys/boot/forth/loader.conf also has: #kern.hz=3D"100" # Set the kernel interval timer rate --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --OXAoLeOWtqbacoe/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBjQS2ForvXbEpPzQRAoyMAJ4wmj8GWkIT7v77B6o5tXnUMDIslgCg9kuZ xXMWnbXfNqmmEkNNqPHmKxA= =9h93 -----END PGP SIGNATURE----- --OXAoLeOWtqbacoe/-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 17:10:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2635916A4CE; Sat, 6 Nov 2004 17:10:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 052FF43D45; Sat, 6 Nov 2004 17:10:25 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6HAOki012652; Sat, 6 Nov 2004 17:10:24 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6HAOS9012651; Sat, 6 Nov 2004 17:10:24 GMT (envelope-from pjd) Message-Id: <200411061710.iA6HAOS9012651@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 6 Nov 2004 17:10:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/raidtest raidtest.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 17:10:25 -0000 pjd 2004-11-06 17:10:24 UTC FreeBSD src repository Modified files: tools/tools/raidtest raidtest.c Log: Allow to write random data while testing RAID device, so we can also test data integrity. Revision Changes Path 1.3 +23 -6 src/tools/tools/raidtest/raidtest.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 17:19:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF45916A4CE; Sat, 6 Nov 2004 17:19:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D13A743D1D; Sat, 6 Nov 2004 17:19:55 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6HJt5c013109; Sat, 6 Nov 2004 17:19:55 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6HJtP3013108; Sat, 6 Nov 2004 17:19:55 GMT (envelope-from pjd) Message-Id: <200411061719.iA6HJtP3013108@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 6 Nov 2004 17:19:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/raidtest README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 17:19:56 -0000 pjd 2004-11-06 17:19:55 UTC FreeBSD src repository Modified files: tools/tools/raidtest README Log: Add description of all available options. Revision Changes Path 1.2 +17 -0 src/tools/tools/raidtest/README From owner-cvs-src@FreeBSD.ORG Sat Nov 6 17:59:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FD0016A4CE; Sat, 6 Nov 2004 17:59:57 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1365743D41; Sat, 6 Nov 2004 17:59:57 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CQUqx-00054R-00; Sat, 06 Nov 2004 18:59:55 +0100 Received: from [84.128.136.6] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CQUqx-0007sE-00; Sat, 06 Nov 2004 18:59:56 +0100 From: Max Laier To: Ruslan Ermilov Date: Sat, 6 Nov 2004 18:59:42 +0100 User-Agent: KMail/1.7 References: <200411061133.iA6BXhHT086940@repoman.freebsd.org> <20041106163748.GB38881@ip.net.ua> In-Reply-To: <20041106163748.GB38881@ip.net.ua> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1700439.v7TejALuV9"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200411061859.56624.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 17:59:57 -0000 --nextPart1700439.v7TejALuV9 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 06 November 2004 17:37, Ruslan Ermilov wrote: > Hi, > > On Sat, Nov 06, 2004 at 11:33:43AM +0000, Poul-Henning Kamp wrote: > > phk 2004-11-06 11:33:43 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_param.c > > Log: > > Increase default HZ for i386 to 1000 > > > > Revision Changes Path > > 1.65 +6 -4 src/sys/kern/subr_param.c > > What's the motivation for this change? Also, NOTES This has been discussed here: http://lists.freebsd.org/pipermail/freebsd-arch/2004-November/003085.html > and clocks(7) have not been updated. There may be > more places to catch up with this change... =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1700439.v7TejALuV9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBjREcXyyEoT62BG0RAs1cAJwMyZdGU6+pPQg2AL/xO4f43AqWHwCdFJCQ vTf2FNvsudrO70b06Tn/ZP8= =L4cv -----END PGP SIGNATURE----- --nextPart1700439.v7TejALuV9-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 18:15:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A091716A4CE; Sat, 6 Nov 2004 18:15:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EB0843D2F; Sat, 6 Nov 2004 18:15:44 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6IFiMi015411; Sat, 6 Nov 2004 18:15:44 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6IFivf015410; Sat, 6 Nov 2004 18:15:44 GMT (envelope-from delphij) Message-Id: <200411061815.iA6IFivf015410@repoman.freebsd.org> From: Xin LI Date: Sat, 6 Nov 2004 18:15:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/nfsd Makefile nfsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 18:15:44 -0000 delphij 2004-11-06 18:15:44 UTC FreeBSD src repository Modified files: usr.sbin/nfsd Makefile nfsd.c Log: ANSI'fy nfsd(8) and some minor changes to make it WARNS=6 clean. This commit does not affect the code generated, as proven by md5'ing resulting binaries. Bump WARNS accordingly. Compiled on: sparc64, ia64, i386 Reviewed by: alfred (but blame me if anything goes wrong :-) Revision Changes Path 1.17 +1 -1 src/usr.sbin/nfsd/Makefile 1.31 +5 -9 src/usr.sbin/nfsd/nfsd.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 18:18:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 970C616A4CE; Sat, 6 Nov 2004 18:18:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 775D743D39; Sat, 6 Nov 2004 18:18:58 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6IIwwd015507; Sat, 6 Nov 2004 18:18:58 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6IIwHC015506; Sat, 6 Nov 2004 18:18:58 GMT (envelope-from phk) Message-Id: <200411061818.iA6IIwHC015506@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 18:18:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/gnu/ext2fs ext2_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 18:18:58 -0000 phk 2004-11-06 18:18:58 UTC FreeBSD src repository Modified files: sys/gnu/ext2fs ext2_vfsops.c Log: Get closer to unbreaking ext2fs Revision Changes Path 1.131 +2 -0 src/sys/gnu/ext2fs/ext2_vfsops.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 18:24:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3014316A4CE; Sat, 6 Nov 2004 18:24:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1099A43D31; Sat, 6 Nov 2004 18:24:34 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6IOXsJ015709; Sat, 6 Nov 2004 18:24:33 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6IOXkn015708; Sat, 6 Nov 2004 18:24:33 GMT (envelope-from phk) Message-Id: <200411061824.iA6IOXkn015708@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 18:24:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/gnu/ext2fs ext2_mount.h ext2_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 18:24:34 -0000 phk 2004-11-06 18:24:33 UTC FreeBSD src repository Modified files: sys/gnu/ext2fs ext2_mount.h ext2_vfsops.c Log: Get even closer to not crashing ext2fs Revision Changes Path 1.30 +0 -1 src/sys/gnu/ext2fs/ext2_mount.h 1.132 +1 -1 src/sys/gnu/ext2fs/ext2_vfsops.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 18:38:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 404EE16A4CE; Sat, 6 Nov 2004 18:38:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F7C743D48; Sat, 6 Nov 2004 18:38:14 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6IcD7J016233; Sat, 6 Nov 2004 18:38:14 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6IcDq8016232; Sat, 6 Nov 2004 18:38:13 GMT (envelope-from kientzle) Message-Id: <200411061838.iA6IcDq8016232@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 6 Nov 2004 18:38:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar bsdtar_platform.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 18:38:14 -0000 kientzle 2004-11-06 18:38:13 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar_platform.h Log: FreeBSD does have uintmax_t, so it can correctly print out very large file sizes. Thanks to: Yar Tikhiy Revision Changes Path 1.11 +1 -0 src/usr.bin/tar/bsdtar_platform.h From owner-cvs-src@FreeBSD.ORG Sat Nov 6 20:20:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 284FF16A4CE; Sat, 6 Nov 2004 20:20:01 +0000 (GMT) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2770943D31; Sat, 6 Nov 2004 20:20:00 +0000 (GMT) (envelope-from grog@lemis.com) Received: by blackwater.lemis.com (Postfix, from userid 1004) id C63F38564B; Sun, 7 Nov 2004 06:49:57 +1030 (CST) Date: Sun, 7 Nov 2004 06:49:57 +1030 From: Greg 'groggy' Lehey To: Poul-Henning Kamp Message-ID: <20041106201957.GB24507@wantadilla.lemis.com> References: <200411041334.iA4DY67O004056@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C" Content-Disposition: inline In-Reply-To: <200411041334.iA4DY67O004056@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/debugscripts dot.gdbinit gdbinit.vinum X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 20:20:01 -0000 --XF85m9dhOBO43t/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thursday, 4 November 2004 at 13:34:06 +0000, Poul-Henning Kamp wrote: > phk 2004-11-04 13:34:06 UTC > > FreeBSD src repository > > Removed files: > tools/debugscripts gdbinit.vinum > Log: > Remove vinum bits. > > Revision Changes Path > 1.4 +0 -329 src/tools/debugscripts/gdbinit.vinum (dead) Are you sure that none of this is usable for gvinum? I'm not. Until you are, it's premature to remove the file. Greg -- See complete headers for address and phone numbers. --XF85m9dhOBO43t/C Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBjTHtIubykFB6QiMRAqvjAJ4kT2BBaKLRl90NW64x8XXyOdo6RACaAppA cEOvYriPBozz8Ppw/NRwWdI= =frAk -----END PGP SIGNATURE----- --XF85m9dhOBO43t/C-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 20:26:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13ED916A4CE; Sat, 6 Nov 2004 20:26:55 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5686343D2D; Sat, 6 Nov 2004 20:26:54 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iA6KQqJU008181; Sat, 6 Nov 2004 21:26:52 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "Greg 'groggy' Lehey" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 07 Nov 2004 06:49:57 +1030." <20041106201957.GB24507@wantadilla.lemis.com> Date: Sat, 06 Nov 2004 21:26:52 +0100 Message-ID: <8180.1099772812@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/debugscripts dot.gdbinit gdbinit.vinum X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 20:26:55 -0000 In message <20041106201957.GB24507@wantadilla.lemis.com>, "Greg 'groggy' Lehey" writes: >Are you sure that none of this is usable for gvinum? I'm not. Until >you are, it's premature to remove the file. I have already asked le@ if there were any bits he cherised. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Nov 6 21:43:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E652A16A4CE; Sat, 6 Nov 2004 21:43:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C755C43D53; Sat, 6 Nov 2004 21:43:16 +0000 (GMT) (envelope-from archie@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6LhG8K029159; Sat, 6 Nov 2004 21:43:16 GMT (envelope-from archie@repoman.freebsd.org) Received: (from archie@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6LhGMm029158; Sat, 6 Nov 2004 21:43:16 GMT (envelope-from archie) Message-Id: <200411062143.iA6LhGMm029158@repoman.freebsd.org> From: Archie Cobbs Date: Sat, 6 Nov 2004 21:43:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/netgraph ng_l2tp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 21:43:17 -0000 archie 2004-11-06 21:43:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/netgraph ng_l2tp.c Log: MFC: (rev. 1.7) Rename internal structure to fix cut & paste error. Revision Changes Path 1.1.2.2 +3 -3 src/sys/netgraph/ng_l2tp.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 21:48:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A58F516A4CE; Sat, 6 Nov 2004 21:48:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 854A143D2D; Sat, 6 Nov 2004 21:48:45 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6LmjGC029383; Sat, 6 Nov 2004 21:48:45 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6LmjrY029382; Sat, 6 Nov 2004 21:48:45 GMT (envelope-from alc) Message-Id: <200411062148.iA6LmjrY029382@repoman.freebsd.org> From: Alan Cox Date: Sat, 6 Nov 2004 21:48:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 21:48:45 -0000 alc 2004-11-06 21:48:45 UTC FreeBSD src repository Modified files: sys/vm vm_object.c Log: Eliminate an unnecessary atomic operation. Articulate the rationale in a comment. Revision Changes Path 1.336 +11 -4 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 22:24:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D00D16A4CE for ; Sat, 6 Nov 2004 22:24:16 +0000 (GMT) Received: from duchess.speedfactory.net (duchess.speedfactory.net [66.23.201.84]) by mx1.FreeBSD.org (Postfix) with SMTP id 590FA43D5A for ; Sat, 6 Nov 2004 22:24:15 +0000 (GMT) (envelope-from ups@tree.com) Received: (qmail 16322 invoked by uid 89); 6 Nov 2004 22:24:14 -0000 Received: from duchess.speedfactory.net (66.23.201.84) by duchess.speedfactory.net with SMTP; 6 Nov 2004 22:24:14 -0000 Received: (qmail 16290 invoked by uid 89); 6 Nov 2004 22:24:13 -0000 Received: from unknown (HELO palm.tree.com) (66.23.216.49) by duchess.speedfactory.net with SMTP; 6 Nov 2004 22:24:13 -0000 Received: from [127.0.0.1] (localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id iA6MOC5R014080; Sat, 6 Nov 2004 17:24:12 -0500 (EST) (envelope-from ups@tree.com) From: Stephan Uphoff To: Robert Watson In-Reply-To: References: Content-Type: text/plain Message-Id: <1099779852.8097.68.camel@palm.tree.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sat, 06 Nov 2004 17:24:12 -0500 Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: John Baldwin cc: Alan Cox cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 22:24:16 -0000 On Fri, 2004-11-05 at 07:01, Robert Watson wrote: > On Fri, 29 Oct 2004, Mike Silbersack wrote: > > > I think we really need some sort of light-weight critical_enter that > > simply assures you that you won't get rescheduled to another CPU, but > > gives no guarantees beyond that. > > > Er, wait - I guess I'm forgetting something, there exists the potential > > for the interrupt that preempted whatever was calling arc4random to also > > call arc4random, thereby breaking things... > > I've been looking at related issues for the last couple of days and must > have missed this thread while at EuroBSDCon. Alan Cox pointed me at it, > so here I am. :-) > > Right now, the cost of acquiring and dropping an uncontended a sleep mutex > on a UP kernel is very low -- about 21 cycles on my PIII and 40 on my P4, > including some efficiency problems in my measurement which probably add a > non-trivial overhead. Compare this with the SMP versions on the PIII (90 > cycles) and P4 (260 cycles!). Critical sections on the SMP PIII are about > the same cost as the SMP mutex, but on the P4 a critical section is less > than half the cost. Getting to a model where critical sections were as > cheap as UP sleep mutexes, or where we could use a similar combination of > primitives (such as UP mutexes with pinning) would be very useful. > Otherwise, optimizing through use of critical sections will improve SMP > but potentially damage performance on UP. There's been a fair amount of > discussion of such approaches, including the implementation briefly > present in the FreeBSD. I know John Baldwin and Justin Gibbs both have > theories and plans in this area. > > If we do create a UP mutex primitive for use on SMP, I would suggest we > actually expand the contents of the UP mutex structure slightly to include > a cpu number that can be asserted, along with pinning, when an operation > is attempted and INVARIANTS is present. One of the great strengths of the > mutex/lock model is a strong assertion capability, both for the purposes > of documentation and testing, so we should make sure that carries into any > new synchronization primitives. > > Small table of synchronization primitives below; in each case, the count > is in cycles and reflects the cost of acquiring and dropping the primitive > (lock+unlock, enter+exit). The P4 is a 3ghz box, and the PIII is an > 800mhz box. Note that the synchronization primitives requiring atomic > operations are substantially pessimized on the P4 vs the PIII. > > A discussion with John Baldwin and Scott Long yesterday revealed that the > UP spin mutex is currently pessimized from a critical section to a > critical section plus mutex internals due to a need for mtx_owned() on > spin locks. I'm not convinced that explains the entire performance > irregularity I see for P4 spin mutexes on UP, however. Note that 39 (P4 > UP sleep mutex) + 120 (P4 UP critical section) is not 274 (P4 UP spin > mutex) by a fair amount. Figuring out what's going on there would be a > good idea, although it could well be a property of my measurement > environment. I'm currently using this to do measurements: > > //depot/user/rwatson/percpu/sys/test/test_synch_timing.c > > In all of the below, the standard deviation is very small if you're > careful about not bumping into hard clock or other interrupts during > testing, especially when it comes to spin mutexes and critical sections. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Principal Research Scientist, McAfee Research > > sleep mutex crit section spin mutex > UP SMP UP SMP UP SMP > PIII 21 90 83 81 112 141 > P4 39 260 120 119 274 342 Nice catch! On a UP releasing a spin mutex involves a xchgl operation while releasing an uncontested sleep mutex uses cmpxchgl. Since the xchgl does an implicit LOCK (and cmpxchgl does NOT) this could explain why the spin mutex needs a lot more cycles. This should be easy to fix since the xchgl is not needed on a UP system. Right now I am sick and don't trust my own code so I won't write a patch for the next few days ... hopefully someone else can get to it first. Stephan From owner-cvs-src@FreeBSD.ORG Sat Nov 6 22:55:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E20CA16A4CE; Sat, 6 Nov 2004 22:55:02 +0000 (GMT) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13F8E43D2D; Sat, 6 Nov 2004 22:55:01 +0000 (GMT) (envelope-from grog@lemis.com) Received: by blackwater.lemis.com (Postfix, from userid 1004) id 0BE2585651; Sun, 7 Nov 2004 09:24:59 +1030 (CST) Date: Sun, 7 Nov 2004 09:24:59 +1030 From: Greg 'groggy' Lehey To: Lukas Ertl Message-ID: <20041106225458.GF24507@wantadilla.lemis.com> References: <20041104154414.S5398@pcle2.cc.univie.ac.at> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <20041104154414.S5398@pcle2.cc.univie.ac.at> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum COPYRIGHT makestatetext request.h statetexts.h vinum.c vinumconfig.c vinumdaemon.c vinumext.h vinumhdr.h vinuminterrupt.c vinumio.c vinumio.h vinumioctl.c vinumkw.h vinumlock.c vinummemory.c vinumobj.h vinumparser.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 22:55:03 -0000 --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thursday, 4 November 2004 at 15:44:50 +0100, Lukas Ertl wrote: > On Thu, 4 Nov 2004, Robert Watson wrote: > >> >> On Thu, 4 Nov 2004, Poul-Henning Kamp wrote: >> >>> Remove unused vinum files. >> >> Should we now be renaming the gvinum command line tool to match the old >> name, and possibly the module as well? > > I'd go for yes. Then I'd also like to rename the device from > /dev/gvinum/foo to /dev/vinum/foo. Yes, very much so. "gvinum" was a temporary measure to deal with the presence of two different vinums. Greg -- See complete headers for address and phone numbers. --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBjVZCIubykFB6QiMRAnLZAJ4togMAOQn9NvKvZFNEpW6rQZC69wCgo770 kExn1Mnlx1kXYbOYUZi+MKo= =HgrF -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 23:06:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 201EB16A4CE; Sat, 6 Nov 2004 23:06:55 +0000 (GMT) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 014E643D45; Sat, 6 Nov 2004 23:06:54 +0000 (GMT) (envelope-from grog@lemis.com) Received: by blackwater.lemis.com (Postfix, from userid 1004) id 3B88F85654; Sun, 7 Nov 2004 09:36:51 +1030 (CST) Date: Sun, 7 Nov 2004 09:36:51 +1030 From: Greg 'groggy' Lehey To: Ian Dowse Message-ID: <20041106230651.GG24507@wantadilla.lemis.com> References: <20041103121943.GA96866@FreeBSD.org> <200411031335.aa39452@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hTiIB9CRvBOLTyqY" Content-Disposition: inline In-Reply-To: <200411031335.aa39452@salmon.maths.tcd.ie> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: Alexey Dokuchaev cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ehci.c ehcireg.h uhub.c usb_subr.c usbdivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 23:06:55 -0000 --hTiIB9CRvBOLTyqY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wednesday, 3 November 2004 at 13:35:06 +0000, Ian Dowse wrote: > In message <20041103121943.GA96866@FreeBSD.org>, Alexey Dokuchaev writes: >> It had been mentioned that OpenBSD folks also had done some work on ehci. >> Is there any chance you (or someone else) might take a look at those? > > My previous suspend/resume commits to EHCI covered most of OpenBSD's > changes, and OpenBSD has since incorporated NetBSD's work too (the > interrupt pipe support that went into OpenBSD a couple of weeks ago > was based on an earlier version of the patch I committed to FreeBSD > in August). > > There has been a lot of cross-syncing of EHCI code between the BSDs > recently so the EHCI bits should now be pretty much the same across > NetBSD, OpenBSD and FreeBSD. To what extent would it be practicable to get people from each project to maintain a base USB code independently of the individual projects? Greg -- See complete headers for address and phone numbers. --hTiIB9CRvBOLTyqY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBjVkLIubykFB6QiMRAmJpAKCiOgxYyYt7T11xM0IMfT08xPECPgCgjKYe VIY408nP2vy+uMt8LRsajjU= =HsxN -----END PGP SIGNATURE----- --hTiIB9CRvBOLTyqY-- From owner-cvs-src@FreeBSD.ORG Sat Nov 6 23:36:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E56616A4CE; Sat, 6 Nov 2004 23:36:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F299D43D48; Sat, 6 Nov 2004 23:36:09 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA6Na9Wd034695; Sat, 6 Nov 2004 23:36:09 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA6Na9rN034694; Sat, 6 Nov 2004 23:36:09 GMT (envelope-from phk) Message-Id: <200411062336.iA6Na9rN034694@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 6 Nov 2004 23:36:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 23:36:10 -0000 phk 2004-11-06 23:36:09 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: When we open /dev/null for stdin/out/err for safety reasons, do it right: we should preserve f_data and f_ops if they are already set. Revision Changes Path 1.247 +5 -3 src/sys/kern/kern_descrip.c From owner-cvs-src@FreeBSD.ORG Sat Nov 6 23:53:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E803A16A4CE; Sat, 6 Nov 2004 23:53:12 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFB3843D3F; Sat, 6 Nov 2004 23:53:12 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-186-185.dsl.snfc21.pacbell.net [64.171.186.185]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id iA6NrAFp000602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 6 Nov 2004 15:53:11 -0800 Message-ID: <418D632E.2020402@root.org> Date: Sat, 06 Nov 2004 15:50:06 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Max Laier References: <200411061133.iA6BXhHT086940@repoman.freebsd.org> <20041106163748.GB38881@ip.net.ua> <200411061859.56624.max@love2party.net> In-Reply-To: <200411061859.56624.max@love2party.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2004 23:53:13 -0000 Max Laier wrote: > On Saturday 06 November 2004 17:37, Ruslan Ermilov wrote: >>On Sat, Nov 06, 2004 at 11:33:43AM +0000, Poul-Henning Kamp wrote: >> >>>phk 2004-11-06 11:33:43 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern subr_param.c >>> Log: >>> Increase default HZ for i386 to 1000 >>> >>> Revision Changes Path >>> 1.65 +6 -4 src/sys/kern/subr_param.c >> >>What's the motivation for this change? Also, NOTES > > This has been discussed here: > http://lists.freebsd.org/pipermail/freebsd-arch/2004-November/003085.html I was traveling out of the country so I didn't get a chance to comment. The two caveats I'm aware of is a slight loss in processes that are CPU bound and an audio hum from ACPI CPU idling. The latter is rather interesting actually. At hz=100, it's just a quiet low buzz but at 1000, it is readily audible on many laptops and annoying. Windows uses hz=1000 too and has the same problem. I believe it's related to the capacitors and other devices charging/discharging when clocks are stopped. I'm fine with this change and just wanted to make sure people know where these behavioral changes are coming from when reports come in. -- Nate