From owner-freebsd-bugbusters@FreeBSD.ORG Thu Apr 29 07:36:26 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3D6516A4CE for ; Thu, 29 Apr 2004 07:36:26 -0700 (PDT) Received: from shaft.techsupport.co.uk (shaft.techsupport.co.uk [212.250.77.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 851D243D2D for ; Thu, 29 Apr 2004 07:36:26 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com ([81.103.67.204] helo=shrike.submonkey.net ident=mailnull) by shaft.techsupport.co.uk with esmtp (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.31; FreeBSD) id 1BJCeH-000MsF-47 for freebsd-bugbusters@freebsd.org; Thu, 29 Apr 2004 15:36:25 +0100 Received: from setantae by shrike.submonkey.net with local (Exim 4.32; FreeBSD) id 1BJCeF-000IjQ-79 for freebsd-bugbusters@freebsd.org; Thu, 29 Apr 2004 15:36:23 +0100 Date: Thu, 29 Apr 2004 15:36:23 +0100 From: Ceri Davies To: freebsd-bugbusters Message-ID: <20040429143623.GM10877@submonkey.net> References: <20040414073119.GC1544@isis.wad.cz> <20040414103655.GN465@submonkey.net> <20040421093315.GC1051@isis.wad.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Re2uCLPLNzqOLVJA" Content-Disposition: inline In-Reply-To: <20040421093315.GC1051@isis.wad.cz> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.4i Sender: Ceri Davies Subject: Re: per-user send-pr defaults: ~/.send-pr.rc? X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2004 14:36:26 -0000 --Re2uCLPLNzqOLVJA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 21, 2004 at 11:33:15AM +0200, Roman Neuhauser wrote: > # ceri@FreeBSD.org / 2004-04-14 11:36:55 +0100: > > On Wed, Apr 14, 2004 at 09:31:19AM +0200, Roman Neuhauser wrote: > > > Would a patch for send-pr adding support for defaults handling using > > > an rc file be welcome? If so, should I target send-pr as is in our tr= ee, > > > the one from the 4.0 tarball, or upstream cvs? > >=20 > > I'd certainly be interested in looking at it. At the moment my plan to > > upgrade is entirely {hub,www,freefall}.FreeBSD.org based - there seems > > to be no pressing need to upgrade the distributed send-pr, so I'd target > > the in-tree send-pr. If it should turn out that a client-side upgrade > > is worth the effort then we can bring the patches forward (I had to do > > the same for our local edit-pr hacks). >=20 > I've used the attached patch to submit some PRs (65668 - 65680), and > it was a relief. > =20 > It's not commitable as-is (e. g. note -s/-S are swapped), I'd just > like to know whether I'm on the right track. Roman, Apologies for the delay in responding - I meant to get to this much sooner. I'm out of the country for a couple of weeks as of tomorrow so any further replies will be delayed accordingly - I won't have any email access while I'm there. This looks really good so far to me. I'd recommend at first look that the file be renamed .send-pr.conf (or just .send-pr), and perhaps an option to ignore it would be useful too (I think most commands use -f for that, which is already taken). I'm slightly uncomfortable with allowing users to specify a default priority and severity, but those fields are becoming useless anyway so this may not be too much of an issue - I need to think about that a bit. There's also a bit of churn in the variable names, but if this is necessary for clarity (which looks the case) then it's a necessary evil. Thanks again for working on this. Ceri --=20 --Re2uCLPLNzqOLVJA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAkRLmocfcwTS3JF8RAjtYAJ4p2MKx3rxkbSjFiIHIThJXcOBxQgCfb0no bEb3kW3GrlgZSZ0pdOebx+0= =wuuO -----END PGP SIGNATURE----- --Re2uCLPLNzqOLVJA-- From owner-freebsd-bugbusters@FreeBSD.ORG Thu Apr 29 09:28:50 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D827A16A4CE; Thu, 29 Apr 2004 09:28:50 -0700 (PDT) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8AFE43D1F; Thu, 29 Apr 2004 09:28:50 -0700 (PDT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 304A81472F; Thu, 29 Apr 2004 11:28:50 -0500 (CDT) Date: Thu, 29 Apr 2004 11:28:50 -0500 (CDT) From: Mark Linimon X-X-Sender: linimon@pancho To: Ceri Davies In-Reply-To: <20040429143623.GM10877@submonkey.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-bugbusters Subject: Re: per-user send-pr defaults: ~/.send-pr.rc? X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2004 16:28:51 -0000 On Thu, 29 Apr 2004, Ceri Davies wrote: > I'm slightly uncomfortable with allowing users to specify a default > priority and severity, but those fields are becoming useless anyway so > this may not be too much of an issue - I need to think about that a bit. Many people assign unsuitable values to these fields. Unless someone wants to do some kind of enforcement effort (code to say "if Foo says it, it's really a priority, if Bar says it, it's not") these fields should just be suppressed. DES has argued that they are meaningless at this point and should just be dropped. I disagreed with him when he last posted it but at this point I've changed my mind -- the time spent trying to bring sense to the current state of these fields in the database would be much better spent just fixing the PRs. The only alternative I would see is to go through and reset everything to, e.g., non-critical, and start enforcing people to choose appropriate values as they come in. I'm not volunteering for this, I have too many other projects, and unless someone comes forward pretty quickly to do something like that, I'd just say drop 'em. mcl From owner-freebsd-bugbusters@FreeBSD.ORG Thu Apr 29 12:21:34 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29F2E16A4D0 for ; Thu, 29 Apr 2004 12:21:34 -0700 (PDT) Received: from smtp.dkm.cz (smtp.dkm.cz [62.24.64.34]) by mx1.FreeBSD.org (Postfix) with SMTP id ECE6943D1F for ; Thu, 29 Apr 2004 12:21:32 -0700 (PDT) (envelope-from neuhauser@chello.cz) Received: (qmail 90336 invoked by uid 0); 29 Apr 2004 19:21:31 -0000 Received: from r3al16.mistral.cz (HELO isis.wad.cz) (213.220.229.16) by smtp.dkm.cz with SMTP; 29 Apr 2004 19:21:31 -0000 Received: by isis.wad.cz (Postfix, from userid 1001) id 174952FDA01; Thu, 29 Apr 2004 21:21:31 +0200 (CEST) Date: Thu, 29 Apr 2004 21:21:31 +0200 From: Roman Neuhauser To: freebsd-bugbusters Message-ID: <20040429192130.GA429@isis.wad.cz> Mail-Followup-To: freebsd-bugbusters References: <20040414073119.GC1544@isis.wad.cz> <20040414103655.GN465@submonkey.net> <20040421093315.GC1051@isis.wad.cz> <20040429143623.GM10877@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040429143623.GM10877@submonkey.net> User-Agent: Mutt/1.5.6i Subject: Re: per-user send-pr defaults: ~/.send-pr.rc? X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2004 19:21:34 -0000 # ceri@FreeBSD.org / 2004-04-29 15:36:23 +0100: > On Wed, Apr 21, 2004 at 11:33:15AM +0200, Roman Neuhauser wrote: > > # ceri@FreeBSD.org / 2004-04-14 11:36:55 +0100: > > > On Wed, Apr 14, 2004 at 09:31:19AM +0200, Roman Neuhauser wrote: > > > > Would a patch for send-pr adding support for defaults handling using > > > > an rc file be welcome? If so, should I target send-pr as is in our tree, > > > > the one from the 4.0 tarball, or upstream cvs? > > > > > > I'd certainly be interested in looking at it. At the moment my plan to > > > upgrade is entirely {hub,www,freefall}.FreeBSD.org based - there seems > > > to be no pressing need to upgrade the distributed send-pr, so I'd target > > > the in-tree send-pr. If it should turn out that a client-side upgrade > > > is worth the effort then we can bring the patches forward (I had to do > > > the same for our local edit-pr hacks). > > > > I've used the attached patch to submit some PRs (65668 - 65680), and > > it was a relief. > > > > It's not commitable as-is (e. g. note -s/-S are swapped), I'd just > > like to know whether I'm on the right track. > This looks really good so far to me. I'd recommend at first look that > the file be renamed .send-pr.conf (or just .send-pr), Yeah, the file name was intended to have the leading dot. > and perhaps an option to ignore it would be useful too (I think most > commands use -f for that, which is already taken). I'll look into this. There's a few things I'd like to change about option handling, but fear breaking BC. One alternative I've been thinking about is putting minimum (or no) changes in send-pr, and writing another client, perhaps in awk. Is there any chance of getting that commited if it provided considerably more functionality than send-pr? > I'm slightly uncomfortable with allowing users to specify a default > priority and severity, but those fields are becoming useless anyway so > this may not be too much of an issue - I need to think about that a bit. Current send-pr allows the user to change them anyway (I wanted as much compatibility as possible), they just cannot have it preset. In my case that means I have to set the same (lowest) values by hand in every pr. > There's also a bit of churn in the variable names, but if this is > necessary for clarity (which looks the case) then it's a necessary evil. I had a simpler scheme in the beginning, but send-pr refused to send out the PR because it stayed the same across an edit. > Thanks again for working on this. NP, I'm doing that for my own sanity. -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html From owner-freebsd-bugbusters@FreeBSD.ORG Fri Apr 30 02:00:33 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC82316A4CE; Fri, 30 Apr 2004 02:00:33 -0700 (PDT) Received: from fillmore.dyndns.org (port-212-202-49-130.reverse.qsc.de [212.202.49.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A14843D4C; Fri, 30 Apr 2004 02:00:33 -0700 (PDT) (envelope-from eikemeier@fillmore-labs.com) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.32; FreeBSD) id 1BJTsj-000IsZ-RA; Fri, 30 Apr 2004 11:00:32 +0200 Message-ID: <409215AD.2000402@fillmore-labs.com> Date: Fri, 30 Apr 2004 11:00:29 +0200 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: Kris Kennaway References: <20040430001819.GA377@isis.wad.cz> <20040430005946.GA91404@freebsd.csie.nctu.edu.tw> <20040430010502.GA56303@xor.obsecurity.org> In-Reply-To: <20040430010502.GA56303@xor.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: FreeBSD Ports cc: FreeBSD Bugbusters cc: Ying-Chieh Liao Subject: CC'ing when submitting a PR [Was: [PATCH] small speedups in Mk/bsd.port.mk] X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2004 09:00:34 -0000 Kris Kennaway wrote: > On Fri, Apr 30, 2004 at 08:59:46AM +0800, Ying-Chieh Liao wrote: > >>maybe you can send a pr, and dont forget CC to portmgr@FreeBSD.org :) > > Don't CC people when submitting a PR, it can cause followups to become > misfiled as new PRs. I consider this good practice, it is easily forgotten otherwise, and you can see in GNATS if the maintainer is CCed. We should fix this in GNATS, either by searching for the Subject when no GNATS fields are given, by handling the CC in GNATS or modifying send-pr to include an appropriate Reply-To address. I know that we have a lot of misfiled PR answers in GNATS, but you can't really blame the people for it. -Oliver