From owner-freebsd-bugbusters@FreeBSD.ORG Wed Sep 29 21:07:42 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69E6816A4CE for ; Wed, 29 Sep 2004 21:07:42 +0000 (GMT) Received: from imo-d02.mx.aol.com (imo-d02.mx.aol.com [205.188.157.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B5643D54 for ; Wed, 29 Sep 2004 21:07:42 +0000 (GMT) (envelope-from mgooderum@netscape.net) Received: from mgooderum@netscape.net by imo-d02.mx.aol.com (mail_out_v37_r3.7.) id n.1c.ebcb9a8 (16238) for ; Wed, 29 Sep 2004 17:07:39 -0400 (EDT) Received: from netscape.net (rrcs-67-52-60-146.west.biz.rr.com [67.52.60.146]) by air-in03.mx.aol.com (v101_r1.4) with ESMTP id MAILININ32-3f6e415b241a123; Wed, 29 Sep 2004 17:07:39 -0400 Message-ID: <415B241A.4030509@netscape.net> Date: Wed, 29 Sep 2004 16:07:38 -0500 From: Mark Gooderum User-Agent: Mozilla/5.0 (X11; U; Linux i386; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: bugbusters@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AOL-IP: 67.52.60.146 X-Mailer: Unknown (No Version) Subject: FreeBSD PR X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2004 21:07:42 -0000 Just filed a PR with the subject: "em driver em_poll doesn't start send if pending packets" the subject should be: "em driver em_intr doesn't start send if pending packets" I believe this may be the problem (and fix) to the if_em problems noted in the 5.3 TODO list. The following patch to em_intr() has fixed the problem for us. We basically would see an em interface hang after 5-10 minutes of throughput testing GigE-GigE with an Ixia. -=- Mark --- /tmp/tmp.44554.0 Wed Sep 29 15:52:32 2004 +++ /data/work/mark/5.3B4A1.i386/usr/build/ambit2/freebsd5/sys/dev/em/if_em.c Wed Sep 29 15:51:31 2004 @@ -986,11 +986,11 @@ em_clean_transmit_interrupts(adapter); } loop_cnt--; } - if (ifp->if_flags & IFF_RUNNING && IFQ_DRV_IS_EMPTY(&ifp->if_snd)) + if (ifp->if_flags & IFF_RUNNING && !IFQ_DRV_IS_EMPTY(&ifp->if_snd)) em_start_locked(ifp); EM_UNLOCK(adapter); return; } From owner-freebsd-bugbusters@FreeBSD.ORG Wed Sep 29 21:23:48 2004 Return-Path: Delivered-To: freebsd-bugbusters@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A516A16A4CE for ; Wed, 29 Sep 2004 21:23:48 +0000 (GMT) Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com [81.103.67.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58F0643D39 for ; Wed, 29 Sep 2004 21:23:48 +0000 (GMT) (envelope-from setantae@submonkey.net) Received: from setantae by shrike.submonkey.net with local (Exim 4.42 (FreeBSD)) id 1CClvP-000Kch-Nn; Wed, 29 Sep 2004 22:23:47 +0100 Date: Wed, 29 Sep 2004 22:23:47 +0100 From: Ceri Davies To: Mark Gooderum Message-ID: <20040929212347.GJ2493@submonkey.net> Mail-Followup-To: Ceri Davies , Mark Gooderum , bugbusters@FreeBSD.org References: <415B241A.4030509@netscape.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U6tw7swXxW8PLjR9" Content-Disposition: inline In-Reply-To: <415B241A.4030509@netscape.net> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.6i Sender: Ceri Davies cc: bugbusters@FreeBSD.org Subject: Re: FreeBSD PR X-BeenThere: freebsd-bugbusters@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Coordination of the Problem Report handling effort. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2004 21:23:48 -0000 --U6tw7swXxW8PLjR9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 29, 2004 at 04:07:38PM -0500, Mark Gooderum wrote: > Just filed a PR with the subject: >=20 > "em driver em_poll doesn't start send if pending packets" >=20 > the subject should be: >=20 > "em driver em_intr doesn't start send if pending packets" Corrected. Ceri --=20 It is not tinfoil, it is my new skin. I am a robot. --U6tw7swXxW8PLjR9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBWyfjocfcwTS3JF8RAr52AJ9V2F3WcIbAaulSrBL/2UthT6LRzQCcCltD YpP8GoSNDYGFWA2hBfGAhEQ= =fhAT -----END PGP SIGNATURE----- --U6tw7swXxW8PLjR9--