From owner-freebsd-cvsweb@FreeBSD.ORG Thu Jul 22 21:15:53 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0CFB16A4CE for ; Thu, 22 Jul 2004 21:15:53 +0000 (GMT) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C7D543D41 for ; Thu, 22 Jul 2004 21:15:53 +0000 (GMT) (envelope-from scop@FreeBSD.org) Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 86032802D4 for ; Fri, 23 Jul 2004 00:15:52 +0300 (EEST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: "'freebsd-cvsweb@freebsd.org'" In-Reply-To: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net> References: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net> Content-Type: text/plain Organization: FreeBSD Message-Id: <1090530951.29086.371.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Fri, 23 Jul 2004 00:15:51 +0300 Content-Transfer-Encoding: 7bit Subject: Re: Bug in sub hrefquote X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2004 21:15:53 -0000 On Fri, 2004-07-16 at 18:09, Quezada, Alex wrote: Hi, and sorry for the delay, > this routine is incorrectly translating spaces into +: > y/ /+/; > > This is wrong, and if you have directories in your path that include > spaces, the link you get is wrong. I have replaced this with a substitution > of '%20', which works as expected. That change should be ok (see also below), but could you provide an exact reproducer for this? Ie. name of the directory, the resulting link, where in the CVSweb UI it occurs, and the browser + version. I've spotted a few places where hrefquote() is clearly used in a wrong way ( There's probably other ways to do this (like urlencode), but this > seems simpler. I would like to get rid of hrefquote() altogether. Will look into it soonish. > PS: I figured out my broken binary problem. BEA Weblogic's cgi interpreter > was the culprit. I installed Apache, and all is peachy now. What OS do you use? It is possible that we need to add a few binmode() calls here and there. From owner-freebsd-cvsweb@FreeBSD.ORG Fri Jul 23 14:07:35 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31A1716A4CE for ; Fri, 23 Jul 2004 14:07:35 +0000 (GMT) Received: from yorktown.nielsenmedia.com (yorktown.nielsenmedia.com [206.113.192.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3DC243D1D for ; Fri, 23 Jul 2004 14:07:32 +0000 (GMT) (envelope-from Alex.Quezada@nielsenmedia.com) Received: from NMRFLIMG1.nmrlan.net (nmrflimg1.nmrlan.net [10.38.67.53]) i6NE67rE012830 for ; Fri, 23 Jul 2004 10:06:07 -0400 (EDT) Received: from nmrusdunsxg2.nielsenmedia.com (unverified) by NMRFLIMG1.nmrlan.net for ; Fri, 23 Jul 2004 10:06:34 -0400 Received: by nmrusdunsxg2.nmrlan.net with Internet Mail Service (5.5.2653.19) id ; Fri, 23 Jul 2004 09:46:52 -0400 Message-ID: <762A181C0D966E459A2EB3B810142C7707B2199A@nmrusdunsx12.nmrlan.net> From: "Quezada, Alex" To: "'freebsd-cvsweb@freebsd.org'" Date: Fri, 23 Jul 2004 09:46:06 -0400 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="iso-8859-1" Subject: Re: Bug in sub hrefquote X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2004 14:07:35 -0000 Date: Fri, 23 Jul 2004 00:15:51 +0300 From: VilleSkytt? Subject: Re: Bug in sub hrefquote To: "'freebsd-cvsweb@freebsd.org'" Message-ID: <1090530951.29086.371.camel@bobcat.mine.nu> Content-Type: text/plain On Fri, 2004-07-16 at 18:09, Quezada, Alex wrote: >Hi, and sorry for the delay, >> this routine is incorrectly translating spaces into +: >> y/ /+/; >> >> This is wrong, and if you have directories in your path that include >> spaces, the link you get is wrong. I have replaced this with a substitution >> of '%20', which works as expected. >That change should be ok (see also below), but could you provide an >exact reproducer for this? Ie. name of the directory, the resulting >link, where in the CVSweb UI it occurs, and the browser + version. I've >spotted a few places where hrefquote() is clearly used in a wrong way >(whitespace in paths for a long time. It happens in the download links (from either the log view or the markup view) for files under a directory with spaces in it. In my case, the directory and file are: /dstdir/src/stored procs/CntcEventsDailyCallsReport.sp and the link ends up as: download I don't think the browser has any impact, unless there are some that will change the '+' to '%20'. I tried with IE 6.0 and Mozilla 1.5 with the same results. >> There's probably other ways to do this (like urlencode), but this >> seems simpler. >I would like to get rid of hrefquote() altogether. Will look into it >soonish. >> PS: I figured out my broken binary problem. BEA Weblogic's cgi interpreter >> was the culprit. I installed Apache, and all is peachy now. >What OS do you use? It is possible that we need to add a few binmode() >calls here and there. This problem was running Weblogic 7.0 on a SunOS 5.8 box. It uses a servlet to interpret cgi scripts. ------------------------------ _______________________________________________ freebsd-cvsweb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb To unsubscribe, send any mail to "freebsd-cvsweb-unsubscribe@freebsd.org" End of freebsd-cvsweb Digest, Vol 52, Issue 1 *********************************************