From owner-freebsd-hackers@FreeBSD.ORG  Sun Oct 31 09:05:34 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5B7F816A4CE; Sun, 31 Oct 2004 09:05:34 +0000 (GMT)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D9DE843D58; Sun, 31 Oct 2004 09:05:33 +0000 (GMT)
	(envelope-from nectar@celabo.org)
Received: from lum.celabo.org (localhost [127.0.0.1])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "lum.celabo.org", Issuer "celabo.org CA" (not verified))
	by gw.celabo.org (Postfix) with ESMTP
	id BF0795482B; Sun, 31 Oct 2004 03:05:32 -0600 (CST)
Received: by lum.celabo.org (Postfix, from userid 1001)
	id 3AC5A48DBA4; Sun, 31 Oct 2004 09:45:26 +0100 (CET)
Date: Sun, 31 Oct 2004 09:45:25 +0100
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Danny Braniss <danny@cs.huji.ac.il>
Message-ID: <20041031084525.GF2099@lum.celabo.org>
Mail-Followup-To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	Danny Braniss <danny@cs.huji.ac.il>, bushman@rsu.ru,
	hackers@freebsd.org, "Christian S.J. Peron" <csjp@freebsd.org>
References: <1098785868.61417.39.camel@localhost>
	<20041027073335.8B74343D55@mx1.FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041027073335.8B74343D55@mx1.FreeBSD.org>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.6i
cc: hackers@freebsd.org
cc: "Christian S.J. Peron" <csjp@freebsd.org>
cc: bushman@rsu.ru
Subject: Re: nsdispatch services patch + lookupd
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Oct 2004 09:05:34 -0000

On Wed, Oct 27, 2004 at 09:33:33AM +0200, Danny Braniss wrote:
> while trying to add hesiod/dns support, i've noticed, what looks as a problem:
> 
> in nss_tls.h, the function name##_getstate(...) can return a static pointer,
> which gets freed in name##_endstate(...), as far as i know, freeing a non
> malloced memory is asking for trouble.
> proposed fix, instead of static, also do a calloc(...).

Yes, looks like you are correct.  I will fix this month.  Thanks for the
report!  (Is there already a PR?)
Cheers,
-- 
Jacques A Vidrine / NTT/Verio
nectar@celabo.org / jvidrine@verio.net / nectar@FreeBSD.org