From owner-cvs-src@FreeBSD.ORG Sun Sep 11 00:22:21 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFF0B16A41F; Sun, 11 Sep 2005 00:22:21 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 538EB43D46; Sun, 11 Sep 2005 00:22:21 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B0ML2r083241; Sun, 11 Sep 2005 00:22:21 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B0MLV9083240; Sun, 11 Sep 2005 00:22:21 GMT (envelope-from obrien) Message-Id: <200509110022.j8B0MLV9083240@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 00:22:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 00:22:21 -0000 obrien 2005-09-11 00:22:21 UTC FreeBSD src repository Modified files: sys/conf kern.post.mk Log: For HEAD, install a kernel with debug information if DEBUG is a kernel config option. It is too easy to loose the build directory and not have symbols for kgdb to read. Revision Changes Path 1.84 +4 -17 src/sys/conf/kern.post.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 00:47:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 120F316A41F; Sun, 11 Sep 2005 00:47:04 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C500143D45; Sun, 11 Sep 2005 00:47:03 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B0l3Bx085862; Sun, 11 Sep 2005 00:47:03 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B0l3tf085772; Sun, 11 Sep 2005 00:47:03 GMT (envelope-from marcel) Message-Id: <200509110047.j8B0l3tf085772@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 11 Sep 2005 00:47:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_ia64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 00:47:04 -0000 marcel 2005-09-11 00:47:03 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb trgt_ia64.c Log: Unwind across trap frames. Handles all entry points, except the EPC syscall. This is an entry from userland anyway. MFC after: 1 week Revision Changes Path 1.4 +201 -47 src/gnu/usr.bin/gdb/kgdb/trgt_ia64.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 00:52:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF8A916A41F; Sun, 11 Sep 2005 00:52:05 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EE9743D48; Sun, 11 Sep 2005 00:52:05 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B0q5hh091511; Sun, 11 Sep 2005 00:52:05 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B0q5Zb091510; Sun, 11 Sep 2005 00:52:05 GMT (envelope-from obrien) Message-Id: <200509110052.j8B0q5Zb091510@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 00:52:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c tw_osl_includes.h tw_osl_ioctl.h tw_osl_share.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 00:52:05 -0000 obrien 2005-09-11 00:52:05 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c tw_osl_includes.h tw_osl_ioctl.h tw_osl_share.h Log: Don't pollute the entire kernel build with -I$S/dev/twa. Revision Changes Path 1.1043 +10 -5 src/sys/conf/files 1.66 +0 -3 src/sys/conf/kern.pre.mk 1.4 +1 -1 src/sys/dev/twa/tw_osl_cam.c 1.2 +4 -4 src/sys/dev/twa/tw_osl_freebsd.c 1.2 +4 -4 src/sys/dev/twa/tw_osl_includes.h 1.2 +2 -2 src/sys/dev/twa/tw_osl_ioctl.h 1.3 +1 -1 src/sys/dev/twa/tw_osl_share.h From owner-cvs-src@FreeBSD.ORG Sun Sep 11 01:02:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2779016A41F; Sun, 11 Sep 2005 01:02:36 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id C361E43D46; Sun, 11 Sep 2005 01:02:35 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-187-179.dsl.snfc21.pacbell.net [64.171.187.179]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8B12co5021097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 10 Sep 2005 18:02:39 -0700 Message-ID: <43238229.4040809@root.org> Date: Sat, 10 Sep 2005 18:02:33 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David E. O'Brien" References: <20050911005213.5C5EB16A478@hub.freebsd.org> In-Reply-To: <20050911005213.5C5EB16A478@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c tw_osl_includes.h tw_osl_ioctl.h tw_osl_share.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 01:02:36 -0000 David E. O'Brien wrote: > obrien 2005-09-11 00:52:05 UTC > > FreeBSD src repository > > Modified files: > sys/conf files kern.pre.mk > sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c > tw_osl_includes.h tw_osl_ioctl.h > tw_osl_share.h > Log: > Don't pollute the entire kernel build with -I$S/dev/twa. > > Revision Changes Path > 1.1043 +10 -5 src/sys/conf/files > 1.66 +0 -3 src/sys/conf/kern.pre.mk > 1.4 +1 -1 src/sys/dev/twa/tw_osl_cam.c > 1.2 +4 -4 src/sys/dev/twa/tw_osl_freebsd.c > 1.2 +4 -4 src/sys/dev/twa/tw_osl_includes.h > 1.2 +2 -2 src/sys/dev/twa/tw_osl_ioctl.h > 1.3 +1 -1 src/sys/dev/twa/tw_osl_share.h > > > Index: src/sys/conf/files > diff -u src/sys/conf/files:1.1042 src/sys/conf/files:1.1043 > --- src/sys/conf/files:1.1042 Fri Aug 26 12:48:34 2005 > +++ src/sys/conf/files Sun Sep 11 00:52:04 2005 > @@ -859,11 +859,16 @@ > dev/syscons/warp/warp_saver.c optional warp_saver > dev/tdfx/tdfx_pci.c optional tdfx pci > dev/trm/trm.c optional trm > -dev/twa/tw_cl_fwimg.c optional twa > -dev/twa/tw_cl_init.c optional twa > -dev/twa/tw_cl_intr.c optional twa > -dev/twa/tw_cl_io.c optional twa > -dev/twa/tw_cl_misc.c optional twa > +dev/twa/tw_cl_fwimg.c optional twa \ > + compile-with "${NORMAL_C} -I$S/dev/twa" > +dev/twa/tw_cl_init.c optional twa \ > + compile-with "${NORMAL_C} -I$S/dev/twa" > +dev/twa/tw_cl_intr.c optional twa \ > + compile-with "${NORMAL_C} -I$S/dev/twa" > +dev/twa/tw_cl_io.c optional twa \ > + compile-with "${NORMAL_C} -I$S/dev/twa" > +dev/twa/tw_cl_misc.c optional twa \ > + compile-with "${NORMAL_C} -I$S/dev/twa" > dev/twa/tw_osl_cam.c optional twa > dev/twa/tw_osl_freebsd.c optional twa > dev/twe/twe.c optional twe Is that -I flag needed now that you fixed the C files to use ? -- Nate From owner-cvs-src@FreeBSD.ORG Sun Sep 11 01:05:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82CF216A41F; Sun, 11 Sep 2005 01:05:02 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33A6B43D46; Sun, 11 Sep 2005 01:05:01 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-187-179.dsl.snfc21.pacbell.net [64.171.187.179]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8B155o5021118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 10 Sep 2005 18:05:05 -0700 Message-ID: <432382BC.5080105@root.org> Date: Sat, 10 Sep 2005 18:05:00 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David E. O'Brien" References: <20050911002229.51F4916A471@hub.freebsd.org> In-Reply-To: <20050911002229.51F4916A471@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 01:05:02 -0000 David E. O'Brien wrote: > obrien 2005-09-11 00:22:21 UTC > > FreeBSD src repository > > Modified files: > sys/conf kern.post.mk > Log: > For HEAD, install a kernel with debug information if DEBUG is a kernel > config option. It is too easy to loose the build directory and not have > symbols for kgdb to read. > > Revision Changes Path > 1.84 +4 -17 src/sys/conf/kern.post.mk I disagree with this change. We do not need to waste the space in /. If I'm running a debug kernel, it is based on the latest version of kernel.debug in my kernel compile dir and I know to find it there. -- Nate From owner-cvs-src@FreeBSD.ORG Sun Sep 11 01:10:49 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB1DF16A41F for ; Sun, 11 Sep 2005 01:10:49 +0000 (GMT) (envelope-from Emanuel.strobl@gmx.net) Received: from mail.gmx.net (imap.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 42E6943D49 for ; Sun, 11 Sep 2005 01:10:47 +0000 (GMT) (envelope-from Emanuel.strobl@gmx.net) Received: (qmail invoked by alias); 11 Sep 2005 01:10:46 -0000 Received: from flb.schmalzbauer.de (EHLO cale.flintsbach.schmalzbauer.de) [62.245.232.135] by mail.gmx.net (mp008) with SMTP; 11 Sep 2005 03:10:46 +0200 X-Authenticated: #301138 From: Emanuel Strobl To: cvs-src@freebsd.org Date: Sun, 11 Sep 2005 03:10:24 +0200 User-Agent: KMail/1.8.1 References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> In-Reply-To: <432382BC.5080105@root.org> X-Birthday: Oct. 6th 1972 X-CelPhone: +49 (0) 173 9967781 X-Tel: +49 (0) 89 18947781 X-Country: Germany X-Address: Munich, 80686 X-OS: FreeBSD MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1180484.pxZHp64qNc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200509110310.36423@harrymail> X-Y-GMX-Trusted: 0 Cc: src-committers@freebsd.org, cvs-all@freebsd.org, "David E. O'Brien" , Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 01:10:50 -0000 --nextPart1180484.pxZHp64qNc Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Am Sonntag, 11. September 2005 03:05 CEST schrieb Nate Lawson: > David E. O'Brien wrote: > > obrien 2005-09-11 00:22:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.post.mk > > Log: > > For HEAD, install a kernel with debug information if DEBUG is a > > kernel config option. It is too easy to loose the build directory and > > not have symbols for kgdb to read. > > > > Revision Changes Path > > 1.84 +4 -17 src/sys/conf/kern.post.mk > > I disagree with this change. We do not need to waste the space in /. Hmm, why was default size of root changed to 500M? Incredable much too much= =20 IMHO, if not reserved for debug kernels.... I've just been wondering today how wasteful FreeBSD uses the hard disk=20 these days (BETA4)... =2DHarry > If I'm running a debug kernel, it is based on the latest version of > kernel.debug in my kernel compile dir and I know to find it there. --nextPart1180484.pxZHp64qNc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBDI4QMBylq0S4AzzwRAoMRAJ9evw8Xi2flOye6dDQFxEMQgaDS2wCeOQmm K7+t5vTmKvF7PRJv/Kv7eB4= =D4qL -----END PGP SIGNATURE----- --nextPart1180484.pxZHp64qNc-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 01:17:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDBFA16A41F; Sun, 11 Sep 2005 01:17:07 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id E59E043D49; Sun, 11 Sep 2005 01:17:04 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8B1H3gG074349; Sat, 10 Sep 2005 18:17:04 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8B1H2jF074176; Sat, 10 Sep 2005 18:17:02 -0700 (PDT) (envelope-from obrien) Date: Sat, 10 Sep 2005 18:17:02 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20050911011702.GA42159@dragon.NUXI.org> References: <20050911005213.5C5EB16A478@hub.freebsd.org> <43238229.4040809@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43238229.4040809@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c tw_osl_includes.h tw_osl_ioctl.h tw_osl_share.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 01:17:07 -0000 On Sat, Sep 10, 2005 at 06:02:33PM -0700, Nate Lawson wrote: > David E. O'Brien wrote: > >obrien 2005-09-11 00:52:05 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files kern.pre.mk > > sys/dev/twa tw_osl_cam.c tw_osl_freebsd.c > > tw_osl_includes.h tw_osl_ioctl.h > > tw_osl_share.h > > Log: > > Don't pollute the entire kernel build with -I$S/dev/twa. > > > > Revision Changes Path > > 1.1043 +10 -5 src/sys/conf/files > > 1.66 +0 -3 src/sys/conf/kern.pre.mk > > 1.4 +1 -1 src/sys/dev/twa/tw_osl_cam.c > > 1.2 +4 -4 src/sys/dev/twa/tw_osl_freebsd.c > > 1.2 +4 -4 src/sys/dev/twa/tw_osl_includes.h > > 1.2 +2 -2 src/sys/dev/twa/tw_osl_ioctl.h > > 1.3 +1 -1 src/sys/dev/twa/tw_osl_share.h > > > > > >Index: src/sys/conf/files > >diff -u src/sys/conf/files:1.1042 src/sys/conf/files:1.1043 > >--- src/sys/conf/files:1.1042 Fri Aug 26 12:48:34 2005 > >+++ src/sys/conf/files Sun Sep 11 00:52:04 2005 > >@@ -859,11 +859,16 @@ > > dev/syscons/warp/warp_saver.c optional warp_saver > > dev/tdfx/tdfx_pci.c optional tdfx pci > > dev/trm/trm.c optional trm > >-dev/twa/tw_cl_fwimg.c optional twa > >-dev/twa/tw_cl_init.c optional twa > >-dev/twa/tw_cl_intr.c optional twa > >-dev/twa/tw_cl_io.c optional twa > >-dev/twa/tw_cl_misc.c optional twa > >+dev/twa/tw_cl_fwimg.c optional twa \ > >+ compile-with "${NORMAL_C} -I$S/dev/twa" > >+dev/twa/tw_cl_init.c optional twa \ > >+ compile-with "${NORMAL_C} -I$S/dev/twa" > >+dev/twa/tw_cl_intr.c optional twa \ > >+ compile-with "${NORMAL_C} -I$S/dev/twa" > >+dev/twa/tw_cl_io.c optional twa \ > >+ compile-with "${NORMAL_C} -I$S/dev/twa" > >+dev/twa/tw_cl_misc.c optional twa \ > >+ compile-with "${NORMAL_C} -I$S/dev/twa" > > dev/twa/tw_osl_cam.c optional twa > > dev/twa/tw_osl_freebsd.c optional twa > > dev/twe/twe.c optional twe > > Is that -I flag needed now that you fixed the C files to use ? I only changed the tw_osl_* files (OS layer). I'd love to fix the tw_cl_ (common layer) files also, but took the conservative approach for the moment. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 01:28:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D1B116A41F; Sun, 11 Sep 2005 01:28:06 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C091943D46; Sun, 11 Sep 2005 01:28:05 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B1S5j8092777; Sun, 11 Sep 2005 01:28:05 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B1S5sQ092776; Sun, 11 Sep 2005 01:28:05 GMT (envelope-from obrien) Message-Id: <200509110128.j8B1S5sQ092776@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 01:28:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 01:28:06 -0000 obrien 2005-09-11 01:28:05 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk Log: Don't pollute the entire kernel build with -I$S/contrib/ngatm. Revision Changes Path 1.1044 +54 -27 src/sys/conf/files 1.67 +0 -3 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:01:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2279716A41F; Sun, 11 Sep 2005 02:01:19 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id B671143D45; Sun, 11 Sep 2005 02:01:18 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j8B21GQn027686; Sat, 10 Sep 2005 22:01:17 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <432382BC.5080105@root.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> Date: Sat, 10 Sep 2005 22:01:15 -0400 To: Nate Lawson , "David E. O'Brien" From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.1 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:01:19 -0000 At 6:05 PM -0700 9/10/05, Nate Lawson wrote: >David E. O'Brien wrote: >>obrien 2005-09-11 00:22:21 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/conf kern.post.mk Log: >> For HEAD, install a kernel with debug information if DEBUG is a kernel >> config option. It is too easy to loose the build directory and not have >> symbols for kgdb to read. >> Revision Changes Path >> 1.84 +4 -17 src/sys/conf/kern.post.mk > >I disagree with this change. We do not need to waste the space >in /. If I'm running a debug kernel, it is based on the latest >version of kernel.debug in my kernel compile dir and I know to >find it there. Fwiw, I've been burned by building a debug kernel, only to have removed the original compile-directory for that kernel by the time I actually *needed* the debug symbols. It's one thing if you're building a debug kernel because you know you're going to spend the next hour debugging some change. It's another if you're building a debug kernel because your machine might panic sometime in the next two or three weeks. I'm not sure this change was the best idea to address that, but some change along these lines would be nice. Or is there some other knob which already exists and I simply don't know about? I have my own ways to deal with this, but I'm sure that I am not the only one who has been burned by this (and I am *sure*, because I have friends who have also been burnt by this). -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:04:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A579416A41F; Sun, 11 Sep 2005 02:04:04 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6620B43D45; Sun, 11 Sep 2005 02:04:04 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B2447Z094194; Sun, 11 Sep 2005 02:04:04 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B244i7094193; Sun, 11 Sep 2005 02:04:04 GMT (envelope-from obrien) Message-Id: <200509110204.j8B244i7094193@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 02:04:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:04:04 -0000 obrien 2005-09-11 02:04:04 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk Log: Don't pollute the entire kernel build with -I$S/contrib/pf. Revision Changes Path 1.1045 +32 -16 src/sys/conf/files 1.68 +0 -3 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:27:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CF2416A41F; Sun, 11 Sep 2005 02:27:36 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF92F43D5A; Sun, 11 Sep 2005 02:27:34 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B2RYHN095274; Sun, 11 Sep 2005 02:27:34 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B2RYx8095273; Sun, 11 Sep 2005 02:27:34 GMT (envelope-from obrien) Message-Id: <200509110227.j8B2RYx8095273@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 02:27:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:27:36 -0000 obrien 2005-09-11 02:27:34 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk Log: Don't pollute the entire kernel build with -I$S/contrib/ipfilter. Revision Changes Path 1.1046 +26 -13 src/sys/conf/files 1.69 +0 -3 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:29:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7394F16A41F; Sun, 11 Sep 2005 02:29:08 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id F223543D45; Sun, 11 Sep 2005 02:29:07 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8B2T70r020923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Sep 2005 22:29:07 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8B2T36P012950; Sat, 10 Sep 2005 22:29:04 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 709EA511D2; Sat, 10 Sep 2005 22:29:02 -0400 (EDT) Date: Sat, 10 Sep 2005 22:29:02 -0400 From: Kris Kennaway To: Garance A Drosihn Message-ID: <20050911022901.GA3090@xor.obsecurity.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:29:08 -0000 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 10, 2005 at 10:01:15PM -0400, Garance A Drosihn wrote: > At 6:05 PM -0700 9/10/05, Nate Lawson wrote: > >David E. O'Brien wrote: > >>obrien 2005-09-11 00:22:21 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/conf kern.post.mk Log: > >> For HEAD, install a kernel with debug information if DEBUG is a kernel > >> config option. It is too easy to loose the build directory and not h= ave > >> symbols for kgdb to read. > >> Revision Changes Path > >> 1.84 +4 -17 src/sys/conf/kern.post.mk > > > >I disagree with this change. We do not need to waste the space > >in /. If I'm running a debug kernel, it is based on the latest > >version of kernel.debug in my kernel compile dir and I know to > >find it there. >=20 > Fwiw, I've been burned by building a debug kernel, only to have > removed the original compile-directory for that kernel by the time I > actually *needed* the debug symbols. It's one thing if you're building > a debug kernel because you know you're going to spend the next hour > debugging some change. It's another if you're building a debug kernel > because your machine might panic sometime in the next two or three > weeks. Likewise, I also find this change very useful. When I'm juggling a few dozen panics on a few dozen machines with a few dozen different customized source trees, it's hard to keep track of all the kernel.debugs. Now I don't have to. Also, now we won't have to throw away panic reports from users who didn't think to save their kernel.debug, and the quality of bug reports can increase. Kris --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDI5ZtWry0BWjoQKURAlQbAKDrFkWXLEqWCaMGEUIbaMe3TsODUACfYZ+2 Jdf8+sUf5vd2GeHtjP4ROoI= =aS5o -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:36:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C819D16A41F; Sun, 11 Sep 2005 02:36:23 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 773D443D45; Sun, 11 Sep 2005 02:36:23 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8B2aMmw052012; Sat, 10 Sep 2005 19:36:22 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8B2aMJO052011; Sat, 10 Sep 2005 19:36:22 -0700 (PDT) (envelope-from obrien) Date: Sat, 10 Sep 2005 19:36:22 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20050911023622.GA51877@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <432382BC.5080105@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:36:24 -0000 On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: > David E. O'Brien wrote: > >obrien 2005-09-11 00:22:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.post.mk > > Log: > > For HEAD, install a kernel with debug information if DEBUG is a kernel > > config option. It is too easy to loose the build directory and not have > > symbols for kgdb to read. > > > > Revision Changes Path > > 1.84 +4 -17 src/sys/conf/kern.post.mk > > I disagree with this change. We do not need to waste the space in /. > If I'm running a debug kernel, it is based on the latest version of > kernel.debug in my kernel compile dir and I know to find it there. We do need this. The panic I posted yesterday happened in the 'make' stage of the below sequence: cd /sys//conf config FOO cd ../compile/FOO make clean make Note that the kernel.debug matching the running kernel was blown away at this point. I was going to just install kernel.sym instead of a kernel with symbols, but kgdb's usage doesn't claim to support '-s' as the previous kgdb did. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 02:41:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A0C716A41F for ; Sun, 11 Sep 2005 02:41:14 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.61]) by mx1.FreeBSD.org (Postfix) with SMTP id 3634B43D48 for ; Sun, 11 Sep 2005 02:41:13 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 21080 invoked by uid 399); 11 Sep 2005 02:35:29 -0000 Received: from localhost (HELO ?192.168.1.101?) (dougb@dougbarton.net@127.0.0.1) by localhost with SMTP; 11 Sep 2005 02:35:29 -0000 Message-ID: <432397EF.5000409@FreeBSD.org> Date: Sat, 10 Sep 2005 19:35:27 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> In-Reply-To: <20050911022901.GA3090@xor.obsecurity.org> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Nate Lawson , Garance A Drosihn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 02:41:14 -0000 Kris Kennaway wrote: > Likewise, I also find this change very useful. When I'm juggling a > few dozen panics on a few dozen machines with a few dozen different > customized source trees, it's hard to keep track of all the > kernel.debugs. Now I don't have to. > > Also, now we won't have to throw away panic reports from users who > didn't think to save their kernel.debug, and the quality of bug > reports can increase. I agree with Kris and David here, FWIW. Doug From owner-cvs-src@FreeBSD.ORG Sun Sep 11 03:22:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E236116A41F; Sun, 11 Sep 2005 03:22:03 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2BF143D45; Sun, 11 Sep 2005 03:22:03 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B3M3KL097462; Sun, 11 Sep 2005 03:22:03 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B3M3JK097461; Sun, 11 Sep 2005 03:22:03 GMT (envelope-from imp) Message-Id: <200509110322.j8B3M3JK097461@repoman.freebsd.org> From: Warner Losh Date: Sun, 11 Sep 2005 03:22:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pci.c pcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 03:22:04 -0000 imp 2005-09-11 03:22:03 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c pcivar.h Log: Allow one to access the cached values for CMDREG, CACHELNSZ, MINGNT, MAXLAT and LATTIMER. Improve error message when a bogus RID type is requested for a bar. Revision Changes Path 1.296 +23 -6 src/sys/dev/pci/pci.c 1.67 +10 -0 src/sys/dev/pci/pcivar.h From owner-cvs-src@FreeBSD.ORG Sun Sep 11 03:38:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95AED16A420; Sun, 11 Sep 2005 03:38:19 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5461E43D45; Sun, 11 Sep 2005 03:38:19 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B3cJIa098051; Sun, 11 Sep 2005 03:38:19 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B3cJwv098050; Sun, 11 Sep 2005 03:38:19 GMT (envelope-from obrien) Message-Id: <200509110338.j8B3cJwv098050@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 03:38:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 03:38:19 -0000 obrien 2005-09-11 03:38:19 UTC FreeBSD src repository Modified files: sys/conf files kern.pre.mk Log: Don't pollute the entire kernel build with -I$S/contrib/dev/ath and -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be defined to globally get back -I$S/contrib/dev/ath. Revision Changes Path 1.1047 +8 -4 src/sys/conf/files 1.70 +5 -2 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 04:09:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AEA216A420; Sun, 11 Sep 2005 04:09:45 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D63143D46; Sun, 11 Sep 2005 04:09:45 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B49iMQ099211; Sun, 11 Sep 2005 04:09:44 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B49ig7099210; Sun, 11 Sep 2005 04:09:44 GMT (envelope-from imp) Message-Id: <200509110409.j8B49ig7099210@repoman.freebsd.org> From: Warner Losh Date: Sun, 11 Sep 2005 04:09:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 04:09:45 -0000 imp 2005-09-11 04:09:44 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c Log: Change hw.pci.do_powerstate from a boolean to a range. 0 means the same as today: do no power management. 1 means be conservative about what you power down (any device class that has caused problems gets added here). 2 means be agressive about what gets powered down (any device class that's fundamental to the system is here). 3 means power them all down, reguardless. The default is 1. The effect in the default system is to add mass storage devices to the list that we don't power down. From all the pciconf -l lists that I've seen for the aac and amr issue, the bad device has been a mass storage device class. This is an attempt at a compromise between the very small number of systems that have extreme issues with powerdown, and the very large number of systems that gain real benefits from powerdown (I get about 20% more battery life when I attach a minimal set of drivers on my Sony). Hopefully it will strike the proper balance. MFC After: 3 days (before next beta) Revision Changes Path 1.297 +34 -15 src/sys/dev/pci/pci.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 04:59:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4913316A41F; Sun, 11 Sep 2005 04:59:25 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02F8143D46; Sun, 11 Sep 2005 04:59:24 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.200] ([10.0.0.200]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j8B4xN6j022427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Sep 2005 21:59:23 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4323BB54.6060600@errno.com> Date: Sat, 10 Sep 2005 22:06:28 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David E. O'Brien" References: <200509110338.j8B3cJwv098050@repoman.freebsd.org> In-Reply-To: <200509110338.j8B3cJwv098050@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 04:59:25 -0000 David E. O'Brien wrote: > obrien 2005-09-11 03:38:19 UTC > > FreeBSD src repository > > Modified files: > sys/conf files kern.pre.mk > Log: > Don't pollute the entire kernel build with -I$S/contrib/dev/ath and > -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be defined to > globally get back -I$S/contrib/dev/ath. Thanks for explicitly ignoring my request for you NOT to do this. It's really great how you do these drive-by commits that do nothing but f*ck up people's development environment. Sam From owner-cvs-src@FreeBSD.ORG Sun Sep 11 05:36:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9128516A41F; Sun, 11 Sep 2005 05:36:30 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50F6143D45; Sun, 11 Sep 2005 05:36:30 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B5aUUH009694; Sun, 11 Sep 2005 05:36:30 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B5aU5U009693; Sun, 11 Sep 2005 05:36:30 GMT (envelope-from marcel) Message-Id: <200509110536.j8B5aU5U009693@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 11 Sep 2005 05:36:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_i386.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 05:36:30 -0000 marcel 2005-09-11 05:36:30 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb trgt_i386.c Log: Unwind across intrframes as well. MFC after: 1 week Revision Changes Path 1.5 +8 -3 src/gnu/usr.bin/gdb/kgdb/trgt_i386.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 05:55:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2B5916A420; Sun, 11 Sep 2005 05:55:25 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17E4743D46; Sun, 11 Sep 2005 05:55:25 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B5tOGW010364; Sun, 11 Sep 2005 05:55:24 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B5tOpo010363; Sun, 11 Sep 2005 05:55:24 GMT (envelope-from marcel) Message-Id: <200509110555.j8B5tOpo010363@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 11 Sep 2005 05:55:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_amd64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 05:55:25 -0000 marcel 2005-09-11 05:55:24 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb trgt_amd64.c Log: Unwind across intrframes as well. While here, better handle bottom of stack by claiming the frame when the IP is 0. It's a bit of a kluge, but avoids screens full of bogus frames. MFC after: 1 week Revision Changes Path 1.5 +8 -2 src/gnu/usr.bin/gdb/kgdb/trgt_amd64.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 06:01:46 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C125416A41F; Sun, 11 Sep 2005 06:01:46 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A81C43D45; Sun, 11 Sep 2005 06:01:46 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8B61cEd083793; Sat, 10 Sep 2005 23:01:39 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8B61cL8083792; Sat, 10 Sep 2005 23:01:38 -0700 (PDT) (envelope-from obrien) Date: Sat, 10 Sep 2005 23:01:38 -0700 From: "David O'Brien" To: Sam Leffler Message-ID: <20050911060138.GA83586@dragon.NUXI.org> References: <200509110338.j8B3cJwv098050@repoman.freebsd.org> <4323BB54.6060600@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4323BB54.6060600@errno.com> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 06:01:46 -0000 On Sat, Sep 10, 2005 at 10:06:28PM -0700, Sam Leffler wrote: > David E. O'Brien wrote: > >obrien 2005-09-11 03:38:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files kern.pre.mk > > Log: > > Don't pollute the entire kernel build with -I$S/contrib/dev/ath and > > -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be defined > > to > > globally get back -I$S/contrib/dev/ath. > > Thanks for explicitly ignoring my request for you NOT to do this. It's > really great how you do these drive-by commits that do nothing but f*ck > up people's development environment. > Sam I did my best to take your needs into account. I even asked you to propose a patch when you didn't like the ones I sent you - your response was "David, I have no time to waste on stuff like this." "-INCLUDES+= -I$S/contrib/dev/ath" should never have been in the public FreeBSD source tree as not a single file in /usr/src/sys needed it to compile. We don't commit Yahoo!'s, The Weather Channel, Interjet's or any other vendor-specific needs into the open source /usr/src. I think you're more than able to stick "ATH_BUILDING_FROM_SOURCE=yes" in the /etc/make.conf of the machines you build the ath(4) HAL on. I'm sorry you don't see that we shouldn't pollute the kernel build with tons of -I's. It was getting out of hand that every one felt they could add yet another global -I with every new code import rather than edit their code to build in our tree correctly. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 06:52:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 467CC16A41F; Sun, 11 Sep 2005 06:52:15 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0596743D46; Sun, 11 Sep 2005 06:52:15 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B6qEMZ012349; Sun, 11 Sep 2005 06:52:14 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B6qEsl012348; Sun, 11 Sep 2005 06:52:14 GMT (envelope-from marcel) Message-Id: <200509110652.j8B6qEsl012348@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 11 Sep 2005 06:52:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_sparc64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 06:52:15 -0000 marcel 2005-09-11 06:52:14 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb trgt_sparc64.c Log: Claim frames corresponding to tl(0|1)_intr and tl0_trap as well. I think that's the lot, but it's hard to understand the exception code by mere glancing at it. MFC after: 1 week Revision Changes Path 1.6 +4 -1 src/gnu/usr.bin/gdb/kgdb/trgt_sparc64.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 07:33:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EED6716A41F; Sun, 11 Sep 2005 07:33:43 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACD4843D46; Sun, 11 Sep 2005 07:33:43 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B7XhOA014052; Sun, 11 Sep 2005 07:33:43 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B7Xh2N014051; Sun, 11 Sep 2005 07:33:43 GMT (envelope-from obrien) Message-Id: <200509110733.j8B7Xh2N014051@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 07:33:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 07:33:44 -0000 obrien 2005-09-11 07:33:43 UTC FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: The kernel-depend target doesn't get any information from "compile-with", so repeat the includes paths for that target. Revision Changes Path 1.71 +19 -0 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Sun Sep 11 07:57:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 432F816A41F; Sun, 11 Sep 2005 07:57:07 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0138643D46; Sun, 11 Sep 2005 07:57:07 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B7v604014990; Sun, 11 Sep 2005 07:57:06 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B7v6W0014989; Sun, 11 Sep 2005 07:57:06 GMT (envelope-from truckman) Message-Id: <200509110757.j8B7v6W0014989@repoman.freebsd.org> From: Don Lewis Date: Sun, 11 Sep 2005 07:57:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 07:57:07 -0000 truckman 2005-09-11 07:57:06 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c Log: Relocate witness_levelall(), witness_leveldescendents(), and witness_displaydescendants() so that they are protected by "#ifdef DDB/#endif" to unbreak kernels not using "option DDB". MFC after: 3 weeks Revision Changes Path 1.200 +86 -86 src/sys/kern/subr_witness.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 09:15:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94E8216A41F; Sun, 11 Sep 2005 09:15:44 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4955543D46; Sun, 11 Sep 2005 09:15:44 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8B9Fh4H025338; Sun, 11 Sep 2005 09:15:44 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8B9Fham025331; Sun, 11 Sep 2005 09:15:43 GMT (envelope-from netchild) Message-Id: <200509110915.j8B9Fham025331@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 09:15:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/usb uaudio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 09:15:44 -0000 netchild 2005-09-11 09:15:42 UTC FreeBSD src repository Modified files: sys/dev/sound/usb uaudio.c Log: Fix a bug in volume calculation, this sometimes gives a USB audio device an unexpected value (when the volume is high). Submitted by: Kazuhito HONDA Revision Changes Path 1.15 +2 -2 src/sys/dev/sound/usb/uaudio.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 10:07:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FAF316A41F; Sun, 11 Sep 2005 10:07:13 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D7A643D45; Sun, 11 Sep 2005 10:07:13 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BA7CTB027956; Sun, 11 Sep 2005 10:07:12 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BA7CIW027955; Sun, 11 Sep 2005 10:07:12 GMT (envelope-from netchild) Message-Id: <200509111007.j8BA7CIW027955@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 10:07:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 10:07:13 -0000 netchild 2005-09-11 10:07:12 UTC FreeBSD src repository Modified files: sys/dev/sound/isa mss.c Log: Fix misdetection of the sound chip on PC98 systems. The submitter doesn't believe that there are PC98 systems with an OPTi chip. I don't know enough about this special PC architecture to be sure about this, so let's find out by letting people with such a system complain in case this commit breaks the sound system for them. It's easy to revert then. PR: 45673 Submitted by: Watanabe Kazuhiro Revision Changes Path 1.98 +2 -0 src/sys/dev/sound/isa/mss.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 10:58:41 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9759416A47C; Sun, 11 Sep 2005 10:58:41 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from mail15.syd.optusnet.com.au (mail15.syd.optusnet.com.au [211.29.132.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03D7E43D58; Sun, 11 Sep 2005 10:58:24 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from server.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail15.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id j8BAwMNv006350 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sun, 11 Sep 2005 20:58:22 +1000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.13.4/8.13.4) with ESMTP id j8BAwMxR092986; Sun, 11 Sep 2005 20:58:22 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.13.4/8.13.1/Submit) id j8BAwM4Z092985; Sun, 11 Sep 2005 20:58:22 +1000 (EST) (envelope-from peter) Date: Sun, 11 Sep 2005 20:58:22 +1000 From: Peter Jeremy To: Nate Lawson Message-ID: <20050911105821.GA91588@server.vk2pj.dyndns.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <432382BC.5080105@root.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "David E. O'Brien" Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 10:58:41 -0000 On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: >David E. O'Brien wrote: >> For HEAD, install a kernel with debug information if DEBUG is a kernel >> config option. It is too easy to loose the build directory and not have >> symbols for kgdb to read. > >I disagree with this change. We do not need to waste the space in /. >If I'm running a debug kernel, it is based on the latest version of >kernel.debug in my kernel compile dir and I know to find it there. I'd agree with Nate here. I agree that the debug kernel is worth keeping but it's not needed in /. If you want to install it, how about installing it in /var/crash. A number of people have mentioned losing the debug kernel when they do a rebuild. The normal reasons for doing a rebuild are either that you have updated your source or you've changed your config. In the former case, the old debug kernel loses some of its validity because it no longer matches the source code it was built from. In the latter case, I would suggest that the only reason to change the kernel config is if you are planning on installing a new kernel, so again you don't need the old debug kernel. This just leaves the relatively small window whilst you are building and installing the new kernel - though David has found that this window can unfortunately be hit. In this change intended for -current only or will it remain in 7-RELEASE? -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Sun Sep 11 10:58:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96F4C16A4EF; Sun, 11 Sep 2005 10:58:48 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5721343D46; Sun, 11 Sep 2005 10:58:40 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 40D1C46BC6; Sun, 11 Sep 2005 06:58:39 -0400 (EDT) Date: Sun, 11 Sep 2005 11:58:39 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Nate Lawson In-Reply-To: <432382BC.5080105@root.org> Message-ID: <20050911115526.A33344@fledge.watson.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 10:58:48 -0000 On Sat, 10 Sep 2005, Nate Lawson wrote: > David E. O'Brien wrote: >> obrien 2005-09-11 00:22:21 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/conf kern.post.mk Log: >> For HEAD, install a kernel with debug information if DEBUG is a kernel >> config option. It is too easy to loose the build directory and not have >> symbols for kgdb to read. >> Revision Changes Path >> 1.84 +4 -17 src/sys/conf/kern.post.mk > > I disagree with this change. We do not need to waste the space in /. If > I'm running a debug kernel, it is based on the latest version of > kernel.debug in my kernel compile dir and I know to find it there. If it is decided to keep this change in the tree, then we should make sure that removing it is added to the "Create a -STABLE branch" directions -- systems as recent as early to middle 4.x have quite small roots, and cannot support debugging kernel information for kernel and kernel.old. Maintaining that upgrade path as feasible is a good idea, so if we want to keep around debugging kernels, we shouldn't try to do it in production branches that may be used on many systems with smaller disk sizes. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Sun Sep 11 11:10:54 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A72F916A422 for ; Sun, 11 Sep 2005 11:10:54 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.197]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E3D743D4C for ; Sun, 11 Sep 2005 11:10:53 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: by zproxy.gmail.com with SMTP id z31so105300nzd for ; Sun, 11 Sep 2005 04:10:52 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Qczk79fzToFqe5zEa5yKti/ZP9GSFTSxAFbP4mXMAV4JJ2PZAN/C+ZiaPP70/iiLJjLraL50rA1zmOmKCjC/SqyKub8yQPt0Ld9w3TnMF7vx3d11FuwET4p2DYzbT2D8O5DTveCNt10mjPnp+D5+lE9iSdbUOvEC2EmGhoPsS0Y= Received: by 10.36.141.14 with SMTP id o14mr1947174nzd; Sun, 11 Sep 2005 04:10:52 -0700 (PDT) Received: by 10.36.80.10 with HTTP; Sun, 11 Sep 2005 04:10:52 -0700 (PDT) Message-ID: Date: Sun, 11 Sep 2005 13:10:52 +0200 From: Arjan Van Leeuwen To: Andre Oppermann In-Reply-To: <200508291846.j7TIkdcM090396@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200508291846.j7TIkdcM090396@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memmem.3 memmem.c strchr.3 strstr.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: avleeuwen@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 11:10:54 -0000 Hi Andre, On 8/29/05, Andre Oppermann wrote: > andre 2005-08-29 18:46:39 UTC >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_6) > include string.h > lib/libc/string Makefile.inc memchr.3 strchr.3 strstr.3 > Added files: (Branch: RELENG_6) > lib/libc/string memmem.3 memmem.c > Log: > MFC addition of memmem(3). Shouldn't __FreeBSD_version be bumped for this? I'm asking because I maintain a port that uses memmem(3), and there's now no way to distinguish between the FreeBSD 6 installations that have memmem(3), and the ones that don't. Best regards, Arjan >=20 > Submitted by: Pascal Gloor > Approved by: re (scottl) >=20 > Revision Changes Path > 1.21.2.1 +3 -0 src/include/string.h > 1.34.8.1 +5 -5 src/lib/libc/string/Makefile.inc > 1.7.14.1 +2 -1 src/lib/libc/string/memchr.3 > 1.1.2.1 +84 -0 src/lib/libc/string/memmem.3 (new) > 1.1.2.1 +67 -0 src/lib/libc/string/memmem.c (new) > 1.11.10.1 +1 -0 src/lib/libc/string/strchr.3 > 1.12.14.1 +1 -0 src/lib/libc/string/strstr.3 > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" > From owner-cvs-src@FreeBSD.ORG Sun Sep 11 11:55:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C211E16A41F; Sun, 11 Sep 2005 11:55:39 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AF9943D45; Sun, 11 Sep 2005 11:55:39 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BBtdOu032268; Sun, 11 Sep 2005 11:55:39 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BBtdmg032267; Sun, 11 Sep 2005 11:55:39 GMT (envelope-from mlaier) Message-Id: <200509111155.j8BBtdmg032267@repoman.freebsd.org> From: Max Laier Date: Sun, 11 Sep 2005 11:55:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/pf/net if_pfsync.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 11:55:39 -0000 mlaier 2005-09-11 11:55:39 UTC FreeBSD src repository Modified files: sys/contrib/pf/net if_pfsync.c Log: Stop leaking a lock. This used to cause a propagate_priority() page fault when setting syncdev and syncpeer. Reported by: Dominic Marks Revision Changes Path 1.23 +3 -3 src/sys/contrib/pf/net/if_pfsync.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 11:59:38 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 993AC16A420 for ; Sun, 11 Sep 2005 11:59:38 +0000 (GMT) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64D3D43D66 for ; Sun, 11 Sep 2005 11:59:37 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 18158 invoked from network); 11 Sep 2005 11:35:25 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.54]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 11 Sep 2005 11:35:25 -0000 Message-ID: <43241C3A.11C24A9C@freebsd.org> Date: Sun, 11 Sep 2005 13:59:54 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: avleeuwen@gmail.com References: <200508291846.j7TIkdcM090396@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memmem.3 memmem.c strchr.3 strstr.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 11:59:38 -0000 Arjan Van Leeuwen wrote: > > Hi Andre, > > On 8/29/05, Andre Oppermann wrote: > > andre 2005-08-29 18:46:39 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > include string.h > > lib/libc/string Makefile.inc memchr.3 strchr.3 strstr.3 > > Added files: (Branch: RELENG_6) > > lib/libc/string memmem.3 memmem.c > > Log: > > MFC addition of memmem(3). > > Shouldn't __FreeBSD_version be bumped for this? I'm asking because I > maintain a port that uses memmem(3), and there's now no way to > distinguish between the FreeBSD 6 installations that have memmem(3), > and the ones that don't. There are no FreeBSD 6 installations to differentiate. FreeBSD 6 is not out yet. You don't have to support FreeBSD 6 BETA or RC in the ports tree. -- Andre From owner-cvs-src@FreeBSD.ORG Sun Sep 11 12:18:50 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADC3A16A41F for ; Sun, 11 Sep 2005 12:18:50 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id E786F43D4C for ; Sun, 11 Sep 2005 12:18:48 +0000 (GMT) (envelope-from avleeuwen@gmail.com) Received: by zproxy.gmail.com with SMTP id z31so108439nzd for ; Sun, 11 Sep 2005 05:18:48 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=TdF3DHcfIom0TBPBlP+IGhUhN+WAHHjIX1GbrByowIEEJcayh/SzRRiy99BBuim2hsSi5yhZ+a6JKBYhcs2aGai4mZpG+NQNveIv7K2XGbjGF5hM20/5cWMzFL7jK+WwTIdjbfiSFBygr2v+UKmdII7r5v7JhKXtWYL3OaDbhS8= Received: by 10.37.2.6 with SMTP id e6mr488757nzi; Sun, 11 Sep 2005 05:18:48 -0700 (PDT) Received: by 10.36.80.10 with HTTP; Sun, 11 Sep 2005 05:18:48 -0700 (PDT) Message-ID: Date: Sun, 11 Sep 2005 14:18:48 +0200 From: Arjan Van Leeuwen To: Andre Oppermann In-Reply-To: <43241C3A.11C24A9C@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200508291846.j7TIkdcM090396@repoman.freebsd.org> <43241C3A.11C24A9C@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memmem.3 memmem.c strchr.3 strstr.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: avleeuwen@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 12:18:50 -0000 On 9/11/05, Andre Oppermann wrote: > Arjan Van Leeuwen wrote: > > > > Hi Andre, > > > > On 8/29/05, Andre Oppermann wrote: > > > andre 2005-08-29 18:46:39 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > include string.h > > > lib/libc/string Makefile.inc memchr.3 strchr.3 strstr.3 > > > Added files: (Branch: RELENG_6) > > > lib/libc/string memmem.3 memmem.c > > > Log: > > > MFC addition of memmem(3). > > > > Shouldn't __FreeBSD_version be bumped for this? I'm asking because I > > maintain a port that uses memmem(3), and there's now no way to > > distinguish between the FreeBSD 6 installations that have memmem(3), > > and the ones that don't. >=20 > There are no FreeBSD 6 installations to differentiate. FreeBSD 6 is > not out yet. You don't have to support FreeBSD 6 BETA or RC in the > ports tree. That's all the information I needed, thanks! Arjan >=20 > -- > Andre > From owner-cvs-src@FreeBSD.ORG Sun Sep 11 12:27:01 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBA8316A41F for ; Sun, 11 Sep 2005 12:27:01 +0000 (GMT) (envelope-from joerg@britannica.bec.de) Received: from hydra.bec.de (www.ostsee-abc.de [62.206.222.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6710743D46 for ; Sun, 11 Sep 2005 12:27:01 +0000 (GMT) (envelope-from joerg@britannica.bec.de) Received: from britannica.bec.de (unknown [139.30.252.72]) by hydra.bec.de (Postfix) with ESMTP id A551135707 for ; Sun, 11 Sep 2005 14:26:59 +0200 (CEST) Received: by britannica.bec.de (Postfix, from userid 1001) id CDAF2101F1; Sun, 11 Sep 2005 14:26:20 +0200 (CEST) Date: Sun, 11 Sep 2005 14:26:19 +0200 From: Joerg Sonnenberger To: cvs-src@freebsd.org Message-ID: <20050911122619.GA6514@britannica.bec.de> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911115526.A33344@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050911115526.A33344@fledge.watson.org> User-Agent: Mutt/1.5.10i Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 12:27:01 -0000 On Sun, Sep 11, 2005 at 11:58:39AM +0100, Robert Watson wrote: > If it is decided to keep this change in the tree, then we should make sure > that removing it is added to the "Create a -STABLE branch" directions -- > systems as recent as early to middle 4.x have quite small roots, and > cannot support debugging kernel information for kernel and kernel.old. It should be mentioned that DragonFly installs /kernel without stripping at all, but /kernel.old gets stripped. Since /kernel.old is normally a fallback kernel, it seems to be a good trade-off. Joerg From owner-cvs-src@FreeBSD.ORG Sun Sep 11 12:35:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EAAA16A41F; Sun, 11 Sep 2005 12:35:33 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2B4243D46; Sun, 11 Sep 2005 12:35:32 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BCZW92034044; Sun, 11 Sep 2005 12:35:32 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BCZW00034043; Sun, 11 Sep 2005 12:35:32 GMT (envelope-from phk) Message-Id: <200509111235.j8BCZW00034043@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 11 Sep 2005 12:35:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/md md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 12:35:33 -0000 phk 2005-09-11 12:35:32 UTC FreeBSD src repository Modified files: sys/dev/md md.c Log: Do not destroy the queue mutex until the thread is done with it. Revision Changes Path 1.156 +1 -1 src/sys/dev/md/md.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 12:55:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CB5316A41F; Sun, 11 Sep 2005 12:55:08 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E521F43D48; Sun, 11 Sep 2005 12:55:07 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BCt7Wk041932; Sun, 11 Sep 2005 12:55:07 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BCt79f041931; Sun, 11 Sep 2005 12:55:07 GMT (envelope-from cperciva) Message-Id: <200509111255.j8BCt79f041931@repoman.freebsd.org> From: Colin Percival Date: Sun, 11 Sep 2005 12:55:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/portsnap/portsnap portsnap.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 12:55:08 -0000 cperciva 2005-09-11 12:55:07 UTC FreeBSD src repository Modified files: usr.sbin/portsnap/portsnap portsnap.sh Log: Fix typo: ${PORTDIR} -> ${PORTSDIR}. Apologies to everyone who has run portsnap in 7.0-CURRENT since Tuesday; if there is a file "/.portsnap.INDEX" on your system, you can delete it (or even better, move it to /usr/ports/.portsnap.INDEX). Big pointy hat to: cperciva Reported that things weren't working properly: Aleksander Fafula Revision Changes Path 1.11 +1 -1 src/usr.sbin/portsnap/portsnap/portsnap.sh From owner-cvs-src@FreeBSD.ORG Sun Sep 11 13:03:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC12816A41F; Sun, 11 Sep 2005 13:03:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A76043D45; Sun, 11 Sep 2005 13:03:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BD3bJ4042314; Sun, 11 Sep 2005 13:03:37 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BD3bTK042313; Sun, 11 Sep 2005 13:03:37 GMT (envelope-from rwatson) Message-Id: <200509111303.j8BD3bTK042313@repoman.freebsd.org> From: Robert Watson Date: Sun, 11 Sep 2005 13:03:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_open Makefile fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 13:03:37 -0000 rwatson 2005-09-11 13:03:36 UTC FreeBSD src repository Added files: tools/regression/fifo/fifo_open Makefile fifo_open.c Log: Add fifo_open, a basic regression test for opening fifos, which tests the blocking and non-blocking forms of open based on the POSIX spec for now O_NONBLOCK should be handled. Revision Changes Path 1.1 +7 -0 src/tools/regression/fifo/fifo_open/Makefile (new) 1.1 +474 -0 src/tools/regression/fifo/fifo_open/fifo_open.c (new) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 13:49:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C53E16A41F; Sun, 11 Sep 2005 13:49:25 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDD0243D53; Sun, 11 Sep 2005 13:49:24 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BDnO95044123; Sun, 11 Sep 2005 13:49:24 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BDnOSQ044122; Sun, 11 Sep 2005 13:49:24 GMT (envelope-from netchild) Message-Id: <200509111349.j8BDnOSQ044122@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 13:49:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 13:49:25 -0000 netchild 2005-09-11 13:49:24 UTC FreeBSD src repository Modified files: sys/dev/sound/isa mss.c Log: Allow to record non 8bit-mono formats even in half-duplex configurations. PR: 45679 Submitted by: Watanabe Kazuhiro Revision Changes Path 1.99 +2 -1 src/sys/dev/sound/isa/mss.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 13:59:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D17216A41F; Sun, 11 Sep 2005 13:59:03 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1933243D48; Sun, 11 Sep 2005 13:59:03 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BDx266044547; Sun, 11 Sep 2005 13:59:02 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BDx2FE044546; Sun, 11 Sep 2005 13:59:02 GMT (envelope-from netchild) Message-Id: <200509111359.j8BDx2FE044546@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 13:59:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 13:59:03 -0000 netchild 2005-09-11 13:59:02 UTC FreeBSD src repository Modified files: sys/dev/sound/isa mss.c Log: Add some ad_wait_init() calls to fix some problems in some configs (e.g. PC98, CS4231A, "pcm0: play interrupt timeout"). PR: 45682 Submitted by: Watanabe Kazuhiro Revision Changes Path 1.100 +5 -1 src/sys/dev/sound/isa/mss.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 14:02:06 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D63D416A41F; Sun, 11 Sep 2005 14:02:06 +0000 (GMT) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05ABB43D69; Sun, 11 Sep 2005 14:02:01 +0000 (GMT) (envelope-from max@love2party.net) Received: from p54A3DDDF.dip.t-dialin.net [84.163.221.223] (helo=donor.laier.local) by mrelayeu.kundenserver.de with ESMTP (Nemesis), id 0ML25U-1EESPA1GpR-0005wP; Sun, 11 Sep 2005 16:02:00 +0200 From: Max Laier To: "David E. O'Brien" Date: Sun, 11 Sep 2005 16:01:41 +0200 User-Agent: KMail/1.8.2 References: <200509110204.j8B244i7094193@repoman.freebsd.org> In-Reply-To: <200509110204.j8B244i7094193@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1430232.k5vohTbd5N"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200509111601.58876.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 14:02:07 -0000 --nextPart1430232.k5vohTbd5N Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 11 September 2005 04:04, David E. O'Brien wrote: > obrien 2005-09-11 02:04:04 UTC > > FreeBSD src repository > > Modified files: > sys/conf files kern.pre.mk > Log: > Don't pollute the entire kernel build with -I$S/contrib/pf. > > Revision Changes Path > 1.1045 +32 -16 src/sys/conf/files These changes didn't really improve the readability of conf/files. I don't= =20 understand in what way a global -I "pollutes" the kernel build. We install= =20 these include files so there must not be a conflict anyway. Unless you can give some reasoning why this -I is such a bad thing, I'd lik= e=20 to see this reverted in order to keep conf/files clean(er) - thanks. > 1.68 +0 -3 src/sys/conf/kern.pre.mk =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1430232.k5vohTbd5N Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDJDjWXyyEoT62BG0RArtgAJ9abg8VEqht6mX2EHu8MJnnpWc9BwCfZhh6 604QuIC2vpOsOGBpCV6k0Ow= =+DzM -----END PGP SIGNATURE----- --nextPart1430232.k5vohTbd5N-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 14:15:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DE5B16A41F; Sun, 11 Sep 2005 14:15:05 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AA6E43D46; Sun, 11 Sep 2005 14:15:05 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BEF57d045733; Sun, 11 Sep 2005 14:15:05 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BEF5JE045732; Sun, 11 Sep 2005 14:15:05 GMT (envelope-from netchild) Message-Id: <200509111415.j8BEF5JE045732@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 14:15:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci csapcm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 14:15:05 -0000 netchild 2005-09-11 14:15:05 UTC FreeBSD src repository Modified files: sys/dev/sound/pci csapcm.c Log: Power up the external amplifiers additionally to powering up the DAC and ADC. PR: 47029 Submitted by: Anish Mistry Tested by: David Murphy Revision Changes Path 1.35 +8 -0 src/sys/dev/sound/pci/csapcm.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 14:29:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 795A216A41F; Sun, 11 Sep 2005 14:29:58 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 364A443D46; Sun, 11 Sep 2005 14:29:58 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BETwwh046360; Sun, 11 Sep 2005 14:29:58 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BETw5H046359; Sun, 11 Sep 2005 14:29:58 GMT (envelope-from maxim) Message-Id: <200509111429.j8BETw5H046359@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 11 Sep 2005 14:29:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/periodic/security 550.ipfwlimit X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 14:29:58 -0000 maxim 2005-09-11 14:29:58 UTC FreeBSD src repository Modified files: etc/periodic/security 550.ipfwlimit Log: A new version of rev. 1.4: postpone a temporary file creation until we realize if ipfw(4) ever used. PR: bin/85970 Submitted by: Andre Albsmeier MFC after: 3 days Revision Changes Path 1.10 +1 -1 src/etc/periodic/security/550.ipfwlimit From owner-cvs-src@FreeBSD.ORG Sun Sep 11 15:57:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A03016A41F; Sun, 11 Sep 2005 15:57:08 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 162A043D45; Sun, 11 Sep 2005 15:57:08 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BFv7wR050066; Sun, 11 Sep 2005 15:57:07 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BFv7fV050065; Sun, 11 Sep 2005 15:57:07 GMT (envelope-from rodrigc) Message-Id: <200509111557.j8BFv7fV050065@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 11 Sep 2005 15:57:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/ntfs ntfs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 15:57:08 -0000 rodrigc 2005-09-11 15:57:07 UTC FreeBSD src repository Modified files: sys/fs/ntfs ntfs.h Log: Do not declare M_NTFSMNT with extern linkage here, since it is defined with static linkage in ntfs_vfsops.c. Fixes compilation with GCC 4.0. Revision Changes Path 1.20 +0 -1 src/sys/fs/ntfs/ntfs.h From owner-cvs-src@FreeBSD.ORG Sun Sep 11 16:02:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D52F516A421; Sun, 11 Sep 2005 16:02:15 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40D7343D49; Sun, 11 Sep 2005 16:02:14 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BG2ECC050356; Sun, 11 Sep 2005 16:02:14 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BG2ESK050355; Sun, 11 Sep 2005 16:02:14 GMT (envelope-from rodrigc) Message-Id: <200509111602.j8BG2ESK050355@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 11 Sep 2005 16:02:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/ntfs ntfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 16:02:16 -0000 rodrigc 2005-09-11 16:02:14 UTC FreeBSD src repository Modified files: sys/fs/ntfs ntfs_vfsops.c Log: Cast bf_sysid to const char * when passing it to strncmp(), because strncmp does not take an unsigned char *. Eliminates warning with GCC 4.0. Revision Changes Path 1.81 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 16:04:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F1EE16A41F; Sun, 11 Sep 2005 16:04:57 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C007143D45; Sun, 11 Sep 2005 16:04:56 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BG4u7T050443; Sun, 11 Sep 2005 16:04:56 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BG4uHm050442; Sun, 11 Sep 2005 16:04:56 GMT (envelope-from rodrigc) Message-Id: <200509111604.j8BG4uHm050442@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 11 Sep 2005 16:04:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netatalk at_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 16:04:57 -0000 rodrigc 2005-09-11 16:04:56 UTC FreeBSD src repository Modified files: sys/netatalk at_proto.c Log: Forward declare atalkdomain with static linkage, not extern, since it is defined with static linkage later in the file. Eliminates GCC 4.0 error. Revision Changes Path 1.11 +1 -1 src/sys/netatalk/at_proto.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 16:13:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ECCA16A41F; Sun, 11 Sep 2005 16:13:03 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C925F43D46; Sun, 11 Sep 2005 16:13:02 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BGD2ww050866; Sun, 11 Sep 2005 16:13:02 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BGD2ic050862; Sun, 11 Sep 2005 16:13:02 GMT (envelope-from rodrigc) Message-Id: <200509111613.j8BGD2ic050862@repoman.freebsd.org> From: Craig Rodrigues Date: Sun, 11 Sep 2005 16:13:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net zlib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 16:13:03 -0000 rodrigc 2005-09-11 16:13:02 UTC FreeBSD src repository Modified files: sys/net zlib.c Log: Forward declare z_errmsg with static linkage since it is defined with static linkage later in the file. Eliminates GCC 4.0 error. Revision Changes Path 1.20 +1 -1 src/sys/net/zlib.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 16:50:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7FA916A41F; Sun, 11 Sep 2005 16:50:38 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 188C843D4C; Sun, 11 Sep 2005 16:50:38 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BGobVJ059718; Sun, 11 Sep 2005 16:50:37 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BGob0O059717; Sun, 11 Sep 2005 16:50:37 GMT (envelope-from des) Message-Id: <200509111650.j8BGob0O059717@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 11 Sep 2005 16:50:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/secure/lib/libssh Makefile src/crypto/openssh CREDITS ChangeLog FREEBSD-tricks LICENCE Makefile.in README README.privsep WARNING.RNG acconfig.h acss.c atomicio.c atomicio.h audit.c auth-krb5.c auth-pam.c auth-passwd.c auth-rh-rsa.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 16:50:39 -0000 des 2005-09-11 16:50:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) secure/lib/libssh Makefile crypto/openssh CREDITS ChangeLog FREEBSD-tricks LICENCE Makefile.in README README.privsep WARNING.RNG acconfig.h acss.c atomicio.c atomicio.h audit.c auth-krb5.c auth-pam.c auth-passwd.c auth-rh-rsa.c auth-rhosts.c auth-rsa.c auth-shadow.c auth-skey.c auth.c auth.h auth1.c auth2-chall.c auth2-gss.c auth2.c authfd.c authfile.c bufaux.c canohost.c channels.c channels.h cipher-acss.c cipher-ctr.c cipher.c clientloop.c clientloop.h config.guess config.h config.sub configure.ac defines.h dns.c entropy.c gss-genr.c gss-serv-krb5.c gss-serv.c hostfile.c includes.h kex.c kex.h key.c loginrec.c loginrec.h mac.c match.c mdoc2man.awk misc.c misc.h moduli.c monitor.c monitor_wrap.c msg.c myproposal.h packet.c packet.h progressmeter.c readconf.c readconf.h readpass.c scp.c servconf.c serverloop.c session.c session.h sftp-client.c sftp-client.h sftp-server.c sftp.c ssh-add.1 ssh-add.c ssh-agent.1 ssh-keygen.1 ssh-keygen.c ssh-keyscan.c ssh-rand-helper.c ssh-rsa.c ssh.1 ssh.c ssh_config ssh_config.5 sshconnect.c sshconnect1.c sshconnect2.c sshd.8 sshd.c sshd_config sshd_config.5 sshpty.c ttymodes.c version.h crypto/openssh/openbsd-compat Makefile.in bsd-cygwin_util.c bsd-misc.c fake-rfc2553.h getrrsetbyname.c openbsd-compat.h port-aix.c port-aix.h realpath.c xcrypt.c crypto/openssh/regress reexec.sh test-exec.sh Added files: (Branch: RELENG_6) crypto/openssh/openbsd-compat openssl-compat.c openssl-compat.h port-uw.c port-uw.h strtoll.c strtonum.c Removed files: (Branch: RELENG_6) crypto/openssh mpaux.c mpaux.h tildexpand.c Log: Upgrade to 4.2p1. Approved by: re (kensmith) Revision Changes Path 1.1.1.5.2.1 +3 -1 src/crypto/openssh/CREDITS 1.1.1.10.2.1 +495 -2 src/crypto/openssh/ChangeLog 1.5.2.1 +3 -3 src/crypto/openssh/FREEBSD-tricks 1.7.2.1 +2 -0 src/crypto/openssh/LICENCE 1.1.1.8.2.1 +4 -4 src/crypto/openssh/Makefile.in 1.1.1.11.2.1 +5 -4 src/crypto/openssh/README 1.1.1.7.2.1 +3 -3 src/crypto/openssh/README.privsep 1.1.1.3.2.1 +2 -2 src/crypto/openssh/WARNING.RNG 1.11.2.1 +2 -8 src/crypto/openssh/acconfig.h 1.1.1.1.8.1 +64 -64 src/crypto/openssh/acss.c 1.1.1.8.8.1 +9 -5 src/crypto/openssh/atomicio.c 1.1.1.3.8.1 +2 -2 src/crypto/openssh/atomicio.h 1.1.1.1.2.1 +4 -4 src/crypto/openssh/audit.c 1.19.2.1 +32 -27 src/crypto/openssh/auth-krb5.c 1.16.2.1 +31 -16 src/crypto/openssh/auth-pam.c 1.19.2.1 +4 -2 src/crypto/openssh/auth-passwd.c 1.12.8.1 +2 -2 src/crypto/openssh/auth-rh-rsa.c 1.1.1.9.8.1 +2 -2 src/crypto/openssh/auth-rhosts.c 1.15.2.1 +4 -2 src/crypto/openssh/auth-rsa.c 1.1.1.2.2.1 +2 -2 src/crypto/openssh/auth-shadow.c 1.15.8.1 +2 -2 src/crypto/openssh/auth-skey.c 1.17.2.1 +27 -43 src/crypto/openssh/auth.c 1.15.2.1 +7 -3 src/crypto/openssh/auth.h 1.32.2.1 +196 -134 src/crypto/openssh/auth1.c 1.10.2.1 +6 -7 src/crypto/openssh/auth2-chall.c 1.1.1.3.2.1 +4 -5 src/crypto/openssh/auth2-gss.c 1.25.2.1 +2 -2 src/crypto/openssh/auth2.c 1.18.2.1 +6 -6 src/crypto/openssh/authfd.c 1.18.2.1 +9 -7 src/crypto/openssh/authfile.c 1.16.2.1 +3 -3 src/crypto/openssh/bufaux.c 1.17.2.1 +5 -4 src/crypto/openssh/canohost.c 1.20.2.1 +60 -46 src/crypto/openssh/channels.c 1.13.2.1 +5 -4 src/crypto/openssh/channels.h 1.1.1.1.8.1 +3 -3 src/crypto/openssh/cipher-acss.c 1.1.1.3.2.1 +2 -2 src/crypto/openssh/cipher-ctr.c 1.20.2.1 +41 -61 src/crypto/openssh/cipher.c 1.1.1.16.2.1 +142 -11 src/crypto/openssh/clientloop.c 1.1.1.6.2.1 +8 -1 src/crypto/openssh/clientloop.h 1.1.1.6.2.1 +339 -251 src/crypto/openssh/config.guess 1.11.2.1 +56 -12 src/crypto/openssh/config.h 1.1.1.5.2.1 +98 -38 src/crypto/openssh/config.sub 1.11.2.1 +334 -71 src/crypto/openssh/configure.ac 1.1.1.9.2.1 +49 -2 src/crypto/openssh/defines.h 1.1.1.3.2.1 +29 -4 src/crypto/openssh/dns.c 1.1.1.3.8.1 +3 -3 src/crypto/openssh/entropy.c 1.1.1.2.8.1 +3 -3 src/crypto/openssh/gss-genr.c 1.1.1.4.2.1 +4 -31 src/crypto/openssh/gss-serv-krb5.c 1.1.1.2.8.1 +16 -5 src/crypto/openssh/gss-serv.c 1.14.2.1 +2 -2 src/crypto/openssh/hostfile.c 1.19.2.1 +11 -2 src/crypto/openssh/includes.h 1.1.1.11.2.1 +23 -20 src/crypto/openssh/kex.c 1.1.1.10.2.1 +8 -4 src/crypto/openssh/kex.h 1.19.2.1 +2 -2 src/crypto/openssh/key.c 1.9.2.1 +21 -20 src/crypto/openssh/loginrec.c 1.1.1.3.2.1 +2 -2 src/crypto/openssh/loginrec.h 1.1.1.4.8.1 +7 -4 src/crypto/openssh/mac.c 1.1.1.6.14.1 +2 -2 src/crypto/openssh/match.c 1.1.1.3.2.1 +3 -0 src/crypto/openssh/mdoc2man.awk 1.1.1.10.2.1 +127 -1 src/crypto/openssh/misc.c 1.1.1.7.2.1 +4 -5 src/crypto/openssh/misc.h 1.1.1.4.2.1 +17 -16 src/crypto/openssh/moduli.c 1.17.2.1 +5 -5 src/crypto/openssh/monitor.c 1.10.2.1 +13 -14 src/crypto/openssh/monitor_wrap.c 1.9.14.1 +0 -46 src/crypto/openssh/mpaux.c (dead) 1.1.1.5.14.1 +0 -22 src/crypto/openssh/mpaux.h (dead) 1.1.1.6.8.1 +6 -9 src/crypto/openssh/msg.c 1.7.2.1 +5 -4 src/crypto/openssh/myproposal.h 1.1.1.6.2.1 +4 -4 src/crypto/openssh/openbsd-compat/Makefile.in 1.1.1.6.2.1 +1 -1 src/crypto/openssh/openbsd-compat/bsd-cygwin_util.c 1.1.1.7.2.1 +19 -1 src/crypto/openssh/openbsd-compat/bsd-misc.c 1.6.2.1 +12 -6 src/crypto/openssh/openbsd-compat/fake-rfc2553.h 1.1.1.4.2.1 +4 -0 src/crypto/openssh/openbsd-compat/getrrsetbyname.c 1.1.1.6.2.1 +6 -1 src/crypto/openssh/openbsd-compat/openbsd-compat.h 1.1.1.1.2.1 +46 -0 src/crypto/openssh/openbsd-compat/openssl-compat.c (new) 1.1.1.1.2.1 +65 -0 src/crypto/openssh/openbsd-compat/openssl-compat.h (new) 1.1.1.7.2.1 +7 -9 src/crypto/openssh/openbsd-compat/port-aix.c 1.1.1.8.2.1 +8 -7 src/crypto/openssh/openbsd-compat/port-aix.h 1.1.1.1.2.1 +134 -0 src/crypto/openssh/openbsd-compat/port-uw.c (new) 1.1.1.1.2.1 +30 -0 src/crypto/openssh/openbsd-compat/port-uw.h (new) 1.1.1.5.2.1 +130 -138 src/crypto/openssh/openbsd-compat/realpath.c 1.1.1.1.2.1 +151 -0 src/crypto/openssh/openbsd-compat/strtoll.c (new) 1.1.1.1.2.1 +69 -0 src/crypto/openssh/openbsd-compat/strtonum.c (new) 1.1.1.3.8.1 +5 -0 src/crypto/openssh/openbsd-compat/xcrypt.c 1.1.1.16.2.1 +58 -5 src/crypto/openssh/packet.c 1.14.2.1 +4 -2 src/crypto/openssh/packet.h 1.1.1.5.2.1 +36 -13 src/crypto/openssh/progressmeter.c 1.25.2.1 +28 -5 src/crypto/openssh/readconf.c 1.17.2.1 +6 -1 src/crypto/openssh/readconf.h 1.1.1.11.2.1 +8 -3 src/crypto/openssh/readpass.c 1.1.1.2.2.1 +3 -3 src/crypto/openssh/regress/reexec.sh 1.1.1.7.2.1 +4 -3 src/crypto/openssh/regress/test-exec.sh 1.8.2.1 +23 -19 src/crypto/openssh/scp.c 1.46.2.1 +32 -6 src/crypto/openssh/servconf.c 1.13.2.1 +3 -3 src/crypto/openssh/serverloop.c 1.46.2.1 +122 -13 src/crypto/openssh/session.c 1.9.2.1 +3 -2 src/crypto/openssh/session.h 1.1.1.13.2.1 +19 -20 src/crypto/openssh/sftp-client.c 1.1.1.6.2.1 +2 -2 src/crypto/openssh/sftp-client.h 1.1.1.11.2.1 +6 -6 src/crypto/openssh/sftp-server.c 1.1.1.13.2.1 +34 -19 src/crypto/openssh/sftp.c 1.1.1.11.2.1 +7 -7 src/crypto/openssh/ssh-add.1 1.15.2.1 +2 -2 src/crypto/openssh/ssh-add.c 1.1.1.11.2.1 +7 -7 src/crypto/openssh/ssh-agent.1 1.1.1.14.2.1 +15 -15 src/crypto/openssh/ssh-keygen.1 1.1.1.18.2.1 +51 -31 src/crypto/openssh/ssh-keygen.c 1.11.2.1 +21 -13 src/crypto/openssh/ssh-keyscan.c 1.1.1.7.2.1 +8 -8 src/crypto/openssh/ssh-rand-helper.c 1.1.1.8.8.1 +2 -2 src/crypto/openssh/ssh-rsa.c 1.31.2.1 +57 -44 src/crypto/openssh/ssh.1 1.28.2.1 +94 -142 src/crypto/openssh/ssh.c 1.27.2.1 +2 -2 src/crypto/openssh/ssh_config 1.17.2.1 +67 -19 src/crypto/openssh/ssh_config.5 1.29.2.1 +22 -48 src/crypto/openssh/sshconnect.c 1.19.2.1 +2 -2 src/crypto/openssh/sshconnect1.c 1.15.2.1 +10 -8 src/crypto/openssh/sshconnect2.c 1.31.2.1 +17 -17 src/crypto/openssh/sshd.8 1.39.2.1 +27 -13 src/crypto/openssh/sshd.c 1.42.2.1 +5 -5 src/crypto/openssh/sshd_config 1.23.2.1 +23 -18 src/crypto/openssh/sshd_config.5 1.11.2.1 +2 -2 src/crypto/openssh/sshpty.c 1.1.1.6.2.1 +0 -73 src/crypto/openssh/tildexpand.c (dead) 1.1.1.7.8.1 +28 -2 src/crypto/openssh/ttymodes.c 1.30.2.1 +4 -4 src/crypto/openssh/version.h 1.34.2.2 +4 -3 src/secure/lib/libssh/Makefile From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:09:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C67F16A41F; Sun, 11 Sep 2005 17:09:51 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF51743D45; Sun, 11 Sep 2005 17:09:50 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BH9oN9060362; Sun, 11 Sep 2005 17:09:50 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BH9oT7060361; Sun, 11 Sep 2005 17:09:50 GMT (envelope-from stefanf) Message-Id: <200509111709.j8BH9oT7060361@repoman.freebsd.org> From: Stefan Farfeleder Date: Sun, 11 Sep 2005 17:09:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdtime time2posix.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:09:51 -0000 stefanf 2005-09-11 17:09:50 UTC FreeBSD src repository Modified files: lib/libc/stdtime time2posix.3 Log: The arguments for time2posix() and posix2time() are time_t values, not pointers. Revision Changes Path 1.15 +3 -3 src/lib/libc/stdtime/time2posix.3 From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:10:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79EBB16A41F; Sun, 11 Sep 2005 17:10:07 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 225EA43D49; Sun, 11 Sep 2005 17:10:07 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8BHA6ov077470; Sun, 11 Sep 2005 10:10:06 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8BHA69F077469; Sun, 11 Sep 2005 10:10:06 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 10:10:05 -0700 From: "David O'Brien" To: Robert Watson Message-ID: <20050911171005.GA77440@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911115526.A33344@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050911115526.A33344@fledge.watson.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:10:07 -0000 On Sun, Sep 11, 2005 at 11:58:39AM +0100, Robert Watson wrote: > On Sat, 10 Sep 2005, Nate Lawson wrote: > >David E. O'Brien wrote: > >>obrien 2005-09-11 00:22:21 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/conf kern.post.mk Log: > >> For HEAD, install a kernel with debug information if DEBUG is a kernel > >> config option. It is too easy to loose the build directory and not have > >> symbols for kgdb to read. > >> Revision Changes Path > >> 1.84 +4 -17 src/sys/conf/kern.post.mk > > > >I disagree with this change. We do not need to waste the space in /. If > >I'm running a debug kernel, it is based on the latest version of > >kernel.debug in my kernel compile dir and I know to find it there. > > If it is decided to keep this change in the tree, then we should make sure > that removing it is added to the "Create a -STABLE branch" directions -- That is something for RE to decide, who I know have a checklist of things to modify/change/add when creating a RELENG_ branch. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:24:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB45C16A41F; Sun, 11 Sep 2005 17:24:50 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 467FC43D48; Sun, 11 Sep 2005 17:24:50 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BHOopL061024; Sun, 11 Sep 2005 17:24:50 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BHOo60061023; Sun, 11 Sep 2005 17:24:50 GMT (envelope-from yar) Message-Id: <200509111724.j8BHOo60061023@repoman.freebsd.org> From: Yar Tikhiy Date: Sun, 11 Sep 2005 17:24:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:24:50 -0000 yar 2005-09-11 17:24:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man5 rc.conf.5 Log: MFC rev. 1.263: Reflect a recent change in /etc/rc.subr that made ``-M'' appear in tmpmfs and varmfs default flags explicitly. Explain why -M is good for these file systems (it maximizes performance and makes the system more stable at low memory conditions by reducing the chance of thrashing.) Bump .Dd accordingly. Approved by: re (hrs) Revision Changes Path 1.256.2.3 +9 -5 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:30:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E4F916A41F; Sun, 11 Sep 2005 17:30:28 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A71C43D45; Sun, 11 Sep 2005 17:30:28 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BHUR0M061331; Sun, 11 Sep 2005 17:30:27 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BHURK3061330; Sun, 11 Sep 2005 17:30:27 GMT (envelope-from netchild) Message-Id: <200509111730.j8BHURK3061330@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 17:30:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci neomagic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:30:28 -0000 netchild 2005-09-11 17:30:27 UTC FreeBSD src repository Modified files: sys/dev/sound/pci neomagic.c Log: Fix hang at init for MagicMedia 256A[VX] chips. [1] In case this causes trouble for some other chipsets add a comment how to proceed. If we don't get bugreports, this should be removed after a while (some releases?). PR: 56617 [1], 29465, 39260, 40574, 68225 Submitted by: Matthew E. Gove [1] Revision Changes Path 1.35 +9 -0 src/sys/dev/sound/pci/neomagic.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:32:56 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DFEA16A41F; Sun, 11 Sep 2005 17:32:56 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A043E43D4C; Sun, 11 Sep 2005 17:32:53 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8BHWqB4077816; Sun, 11 Sep 2005 10:32:52 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8BHWqpn077815; Sun, 11 Sep 2005 10:32:52 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 10:32:52 -0700 From: "David O'Brien" To: Max Laier Message-ID: <20050911173252.GB77440@dragon.NUXI.org> References: <200509110204.j8B244i7094193@repoman.freebsd.org> <200509111601.58876.max@love2party.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509111601.58876.max@love2party.net> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:32:56 -0000 On Sun, Sep 11, 2005 at 04:01:41PM +0200, Max Laier wrote: > On Sunday 11 September 2005 04:04, David E. O'Brien wrote: > > obrien 2005-09-11 02:04:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files kern.pre.mk > > Log: > > Don't pollute the entire kernel build with -I$S/contrib/pf. > > > > Revision Changes Path > > 1.1045 +32 -16 src/sys/conf/files > > These changes didn't really improve the readability of conf/files. Since when was the readability of conf/files a goal? If it were we would fix config(8) so the first 100 or so lines was readable. conf/files is seldomly changed or read. > I don't understand in what way a global -I "pollutes" the kernel build. ... > Unless you can give some reasoning why this -I is such a bad thing, I'd like > to see this reverted in order to keep conf/files clean(er) - thanks. One reason is that we are open to conflicts in header names. Another is the output from doing a compile is too cluttered, and this helps quite a bit. Another is BSD convention is to use a complete include path from /usr/src/sys. We don't put -I$S/dev/{acc,acpica,advansys,aha,ahb,aic,aic7xxx,amd,amr,an,arcmsr,arl,asr,ata,ath,atkbdc,auxio,awi,bfe,bge,bktr,buslogic,cardbus,ciss,cm,cnw,cnw,cp,cs,ct,ctau,cx,cx,cy,dcons,dec,digi,dpt,drm,ed,eisa,em,en,ep,esp,ex,exca,fatm,fb,fdc,fe,firewire,fxp,gem,gfb,hatm,hfa,hifn,hme,hptmv,hwpmc,ic,ichsmb,ichwd,ida,idt,ie,ieee488,if_ndis,iicbus,iir,ips,ipw,isp,ispfw,iwi,ixgb,joy,kbd,led,lge,lnc,mc146818,mca,mcd,mii,mk48txx,mlx,mly,mpt,mse,my,ncv,nge,nsp,nve,ofw,owi,patm,pbio,pccard,pccbb,pcf,pci,pdq,ppbus,ppc,pst,puc,ral,random,ray,rc,rndtest,rp,sab,safe,sbni,sbsh,scd,si,sio,smbus,sn,snc,sound,sr,stg,sx,sym,syscons,tdfx,tga,trm,twa,twe,tx,txp,uart,ubsec,usb,utopia,vge,vkbd,vx,wi,wl,xe,zs} in our kernel Makefile and manage to have all those subsystems buildable and usable. A bad precedent was started with the initial ACPICA import by adding a global -I to the kernel build. He should have preprocessed the files before importing them. Just like we do with things imported into src/contrib (as documented by FREEBSD-upgrade). But because we had one -I that affected 130 files, others later felt it was acceptable to add a global -I for as little as 4 files that was changing the include path for 1000's of files. It has been said by many that for a kernel component to be imported, even into contrib, the code has to be editable so we can adapt it our needs. I can see some argument in having -I$S/contrib, but beyond that files in sys/contrib should follow the include conventions in the rest of the sys tree. > We install these include files so there must not be a conflict anyway. What pf files are installed in /usr/include? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:40:37 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2D4816A41F; Sun, 11 Sep 2005 17:40:37 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DC2743D66; Sun, 11 Sep 2005 17:40:32 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8BHeVo4077966; Sun, 11 Sep 2005 10:40:31 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8BHeVd5077965; Sun, 11 Sep 2005 10:40:31 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 10:40:31 -0700 From: "David O'Brien" To: Peter Jeremy Message-ID: <20050911174031.GC77440@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911105821.GA91588@server.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050911105821.GA91588@server.vk2pj.dyndns.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:40:37 -0000 On Sun, Sep 11, 2005 at 08:58:22PM +1000, Peter Jeremy wrote: > On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: > >David E. O'Brien wrote: > >> For HEAD, install a kernel with debug information if DEBUG is a kernel > >> config option. It is too easy to loose the build directory and not have > >> symbols for kgdb to read. > > > >I disagree with this change. We do not need to waste the space in /. > >If I'm running a debug kernel, it is based on the latest version of > >kernel.debug in my kernel compile dir and I know to find it there. > > I'd agree with Nate here. I agree that the debug kernel is worth > keeping but it's not needed in /. If you want to install it, how > about installing it in /var/crash. How do I go about doing that? Copy kernel.debug to /var/crash? That allows only a single kernel to be debugable. There is no unque filename I can think of that gives us what putting the symbols beside the kernel does. If it helps get better bug reports from users in -CURRENT (the in-development version), isn't it worth a little disk space. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:41:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D7FB16A420; Sun, 11 Sep 2005 17:41:33 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5957043D80; Sun, 11 Sep 2005 17:41:33 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BHfX6S061876; Sun, 11 Sep 2005 17:41:33 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BHfXnn061875; Sun, 11 Sep 2005 17:41:33 GMT (envelope-from rwatson) Message-Id: <200509111741.j8BHfXnn061875@repoman.freebsd.org> From: Robert Watson Date: Sun, 11 Sep 2005 17:41:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_open fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:41:33 -0000 rwatson 2005-09-11 17:41:33 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_open fifo_open.c Log: After going to some trouble to create a temporary directory in which to run fifo tests, chdir to it. Revision Changes Path 1.2 +2 -0 src/tools/regression/fifo/fifo_open/fifo_open.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:43:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F348C16A41F; Sun, 11 Sep 2005 17:43:04 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B174343D45; Sun, 11 Sep 2005 17:43:04 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BHh4qN061964; Sun, 11 Sep 2005 17:43:04 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BHh4Ex061963; Sun, 11 Sep 2005 17:43:04 GMT (envelope-from obrien) Message-Id: <200509111743.j8BHh4Ex061963@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 17:43:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/contrib/gcc c-decl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:43:05 -0000 obrien 2005-09-11 17:43:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) contrib/gcc c-decl.c Log: MFC rev 1.13: fix bug where static forward declarations weren't accepted. Revision Changes Path 1.11.2.1 +5 -2 src/contrib/gcc/c-decl.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:46:54 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A51116A41F; Sun, 11 Sep 2005 17:46:54 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id D07A143D45; Sun, 11 Sep 2005 17:46:53 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8BHkq0r032152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Sep 2005 13:46:53 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8BHkp6P005402; Sun, 11 Sep 2005 13:46:52 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id BAE005118D; Sun, 11 Sep 2005 13:46:51 -0400 (EDT) Date: Sun, 11 Sep 2005 13:46:51 -0400 From: Kris Kennaway To: Peter Jeremy Message-ID: <20050911174651.GA58934@xor.obsecurity.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911105821.GA91588@server.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <20050911105821.GA91588@server.vk2pj.dyndns.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "David E. O'Brien" , Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:46:54 -0000 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2005 at 08:58:22PM +1000, Peter Jeremy wrote: > On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: > >David E. O'Brien wrote: > >> For HEAD, install a kernel with debug information if DEBUG is a kernel > >> config option. It is too easy to loose the build directory and not h= ave > >> symbols for kgdb to read. > > > >I disagree with this change. We do not need to waste the space in /.=20 > >If I'm running a debug kernel, it is based on the latest version of=20 > >kernel.debug in my kernel compile dir and I know to find it there. >=20 > I'd agree with Nate here. I agree that the debug kernel is worth > keeping but it's not needed in /. If you want to install it, how > about installing it in /var/crash. >=20 > A number of people have mentioned losing the debug kernel when they do > a rebuild. The normal reasons for doing a rebuild are either that you > have updated your source or you've changed your config. In the former > case, the old debug kernel loses some of its validity because it no > longer matches the source code it was built from. In the latter case, > I would suggest that the only reason to change the kernel config is if > you are planning on installing a new kernel, so again you don't need the > old debug kernel. This just leaves the relatively small window whilst > you are building and installing the new kernel - though David has found > that this window can unfortunately be hit. No, I run many machines from the same few source trees. When I rebuild a kernel to add a patch to try and fix one of the many bugs in FreeBSD, I lose the ability to debug the other machines when they panic unless I remember to first save the old kernel.debug. This change has negligible impact for those for whom it does not help, and helps the rest of us significantly, so please just give it up. Kris --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDJG2LWry0BWjoQKURAjxJAKDjEgh2exB8QHCnVLX9DLZHolbCQACghSaE BqAmVh6okNlw5hj/l8Ej0zk= =OGw4 -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:47:29 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 302E516A41F; Sun, 11 Sep 2005 17:47:29 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE21243D45; Sun, 11 Sep 2005 17:47:28 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8BHlS0r032200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Sep 2005 13:47:28 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8BHlP6P005478; Sun, 11 Sep 2005 13:47:25 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 5527D5118D; Sun, 11 Sep 2005 13:47:25 -0400 (EDT) Date: Sun, 11 Sep 2005 13:47:25 -0400 From: Kris Kennaway To: Arjan Van Leeuwen Message-ID: <20050911174725.GB58934@xor.obsecurity.org> References: <200508291846.j7TIkdcM090396@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andre Oppermann , cvs-all@freebsd.org Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memmem.3 memmem.c strchr.3 strstr.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:47:29 -0000 --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2005 at 01:10:52PM +0200, Arjan Van Leeuwen wrote: > Hi Andre, >=20 > On 8/29/05, Andre Oppermann wrote: > > andre 2005-08-29 18:46:39 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: (Branch: RELENG_6) > > include string.h > > lib/libc/string Makefile.inc memchr.3 strchr.3 strstr.3 > > Added files: (Branch: RELENG_6) > > lib/libc/string memmem.3 memmem.c > > Log: > > MFC addition of memmem(3). >=20 > Shouldn't __FreeBSD_version be bumped for this? I'm asking because I > maintain a port that uses memmem(3), and there's now no way to > distinguish between the FreeBSD 6 installations that have memmem(3), > and the ones that don't. Yes, it should have been. Kris --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDJG2sWry0BWjoQKURAqMHAJ4p+pmOJmxBwbhXSCtHUcIaBhoFcACgykH3 msBowDYwU1vF/z8juEdCsCk= =Jc2L -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 17:50:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD99316A41F; Sun, 11 Sep 2005 17:50:20 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 777D543D45; Sun, 11 Sep 2005 17:50:20 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BHoKmk062271; Sun, 11 Sep 2005 17:50:20 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BHoKsV062270; Sun, 11 Sep 2005 17:50:20 GMT (envelope-from obrien) Message-Id: <200509111750.j8BHoKsV062270@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 17:50:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/dev/nve/amd64 nvenetlib.README src/sys/contrib/dev/nve/i386 nvenetlib.README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 17:50:20 -0000 obrien 2005-09-11 17:50:20 UTC FreeBSD src repository Added files: sys/contrib/dev/nve/amd64 nvenetlib.README sys/contrib/dev/nve/i386 nvenetlib.README Log: Per a request from Nick Triantos of nVidia, nVidia's legal department asked that we provide their license document beside their nForce MCP object code. Revision Changes Path 1.1 +52 -0 src/sys/contrib/dev/nve/amd64/nvenetlib.README (new) 1.1 +52 -0 src/sys/contrib/dev/nve/i386/nvenetlib.README (new) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 18:19:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDBB016A41F; Sun, 11 Sep 2005 18:19:42 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AA5143D73; Sun, 11 Sep 2005 18:19:42 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BIJgWa063425; Sun, 11 Sep 2005 18:19:42 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BIJgn5063424; Sun, 11 Sep 2005 18:19:42 GMT (envelope-from netchild) Message-Id: <200509111819.j8BIJgn5063424@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 11 Sep 2005 18:19:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 18:19:43 -0000 netchild 2005-09-11 18:19:42 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add the {get,put}ino man pages for those people which got them in the small window. Add the date to the T/TCP entry. Revision Changes Path 1.15 +4 -1 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Sun Sep 11 18:39:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E196E16A41F; Sun, 11 Sep 2005 18:39:03 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95A7243D48; Sun, 11 Sep 2005 18:39:03 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BId3Sw064386; Sun, 11 Sep 2005 18:39:03 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BId3fF064385; Sun, 11 Sep 2005 18:39:03 GMT (envelope-from obrien) Message-Id: <200509111839.j8BId3fF064385@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 18:39:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c src/sys/dev/acpi_support acpi_asus.c acpi_fujitsu.c acpi_ibm.c acpi_panasonic.c acpi_sony.c acpi_toshiba.c src/sys/dev/acpica acpi.c acpi_acad.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 18:39:04 -0000 obrien 2005-09-11 18:39:03 UTC FreeBSD src repository Modified files: sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c sys/dev/acpi_support acpi_asus.c acpi_fujitsu.c acpi_ibm.c acpi_panasonic.c acpi_sony.c acpi_toshiba.c sys/dev/acpica acpi.c acpi_acad.c acpi_battery.c acpi_button.c acpi_cmbat.c acpi_cpu.c acpi_ec.c acpi_if.m acpi_isab.c acpi_lid.c acpi_package.c acpi_pci.c acpi_pci_link.c acpi_pcib.c acpi_pcib_acpi.c acpi_pcib_pci.c acpi_perf.c acpi_powerres.c acpi_quirk.c acpi_resource.c acpi_thermal.c acpi_throttle.c acpi_timer.c acpi_video.c sys/dev/acpica/Osd OsdDebug.c OsdHardware.c OsdInterrupt.c OsdMemory.c OsdSchedule.c OsdStream.c OsdSynch.c OsdTable.c sys/dev/fdc fdc_acpi.c sys/i386/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c sys/ia64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c Log: Canonize the include of acpi.h. Revision Changes Path 1.13 +1 -1 src/sys/amd64/acpica/OsdEnvironment.c 1.17 +1 -1 src/sys/amd64/acpica/acpi_machdep.c 1.22 +1 -1 src/sys/amd64/acpica/acpi_wakeup.c 1.17 +1 -1 src/sys/amd64/acpica/madt.c 1.25 +1 -1 src/sys/dev/acpi_support/acpi_asus.c 1.3 +1 -1 src/sys/dev/acpi_support/acpi_fujitsu.c 1.9 +1 -1 src/sys/dev/acpi_support/acpi_ibm.c 1.9 +1 -1 src/sys/dev/acpi_support/acpi_panasonic.c 1.9 +1 -1 src/sys/dev/acpi_support/acpi_sony.c 1.17 +1 -1 src/sys/dev/acpi_support/acpi_toshiba.c 1.11 +2 -2 src/sys/dev/acpica/Osd/OsdDebug.c 1.17 +1 -1 src/sys/dev/acpica/Osd/OsdHardware.c 1.21 +1 -1 src/sys/dev/acpica/Osd/OsdInterrupt.c 1.13 +1 -1 src/sys/dev/acpica/Osd/OsdMemory.c 1.34 +1 -1 src/sys/dev/acpica/Osd/OsdSchedule.c 1.6 +1 -1 src/sys/dev/acpica/Osd/OsdStream.c 1.24 +1 -1 src/sys/dev/acpica/Osd/OsdSynch.c 1.10 +1 -1 src/sys/dev/acpica/Osd/OsdTable.c 1.215 +1 -1 src/sys/dev/acpica/acpi.c 1.35 +1 -1 src/sys/dev/acpica/acpi_acad.c 1.19 +1 -1 src/sys/dev/acpica/acpi_battery.c 1.31 +1 -1 src/sys/dev/acpica/acpi_button.c 1.41 +1 -1 src/sys/dev/acpica/acpi_cmbat.c 1.58 +1 -1 src/sys/dev/acpica/acpi_cpu.c 1.66 +1 -1 src/sys/dev/acpica/acpi_ec.c 1.8 +1 -1 src/sys/dev/acpica/acpi_if.m 1.10 +1 -1 src/sys/dev/acpica/acpi_isab.c 1.28 +1 -1 src/sys/dev/acpica/acpi_lid.c 1.8 +1 -1 src/sys/dev/acpica/acpi_package.c 1.27 +1 -1 src/sys/dev/acpica/acpi_pci.c 1.46 +1 -1 src/sys/dev/acpica/acpi_pci_link.c 1.57 +1 -1 src/sys/dev/acpica/acpi_pcib.c 1.48 +1 -1 src/sys/dev/acpica/acpi_pcib_acpi.c 1.13 +1 -1 src/sys/dev/acpica/acpi_pcib_pci.c 1.22 +1 -1 src/sys/dev/acpica/acpi_perf.c 1.29 +1 -1 src/sys/dev/acpica/acpi_powerres.c 1.3 +1 -1 src/sys/dev/acpica/acpi_quirk.c 1.35 +1 -1 src/sys/dev/acpica/acpi_resource.c 1.60 +1 -1 src/sys/dev/acpica/acpi_thermal.c 1.8 +1 -1 src/sys/dev/acpica/acpi_throttle.c 1.39 +1 -1 src/sys/dev/acpica/acpi_timer.c 1.11 +1 -1 src/sys/dev/acpica/acpi_video.c 1.11 +1 -1 src/sys/dev/fdc/fdc_acpi.c 1.11 +1 -1 src/sys/i386/acpica/OsdEnvironment.c 1.30 +1 -1 src/sys/i386/acpica/acpi_machdep.c 1.41 +1 -1 src/sys/i386/acpica/acpi_wakeup.c 1.20 +1 -1 src/sys/i386/acpica/madt.c 1.9 +1 -1 src/sys/ia64/acpica/OsdEnvironment.c 1.6 +1 -1 src/sys/ia64/acpica/acpi_machdep.c 1.3 +1 -1 src/sys/ia64/acpica/acpi_wakeup.c 1.19 +1 -1 src/sys/ia64/acpica/madt.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 18:46:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 076DD16A41F; Sun, 11 Sep 2005 18:46:34 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AADFA43D48; Sun, 11 Sep 2005 18:46:33 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BIkXLI064871; Sun, 11 Sep 2005 18:46:33 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BIkXHJ064870; Sun, 11 Sep 2005 18:46:33 GMT (envelope-from obrien) Message-Id: <200509111846.j8BIkXHJ064870@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 11 Sep 2005 18:46:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/contrib/dev/nve/amd64 nvenetlib.README src/sys/contrib/dev/nve/i386 nvenetlib.README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 18:46:34 -0000 obrien 2005-09-11 18:46:33 UTC FreeBSD src repository Added files: (Branch: RELENG_6) sys/contrib/dev/nve/amd64 nvenetlib.README sys/contrib/dev/nve/i386 nvenetlib.README Log: MFC the license files. Approved by: re(scottl) Revision Changes Path 1.1.2.1 +52 -0 src/sys/contrib/dev/nve/amd64/nvenetlib.README (new) 1.1.2.1 +52 -0 src/sys/contrib/dev/nve/i386/nvenetlib.README (new) From owner-cvs-src@FreeBSD.ORG Sun Sep 11 19:06:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 745B716A41F; Sun, 11 Sep 2005 19:06:51 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D15B43D48; Sun, 11 Sep 2005 19:06:51 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BJ6pRP065600; Sun, 11 Sep 2005 19:06:51 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BJ6pOH065599; Sun, 11 Sep 2005 19:06:51 GMT (envelope-from truckman) Message-Id: <200509111906.j8BJ6pOH065599@repoman.freebsd.org> From: Don Lewis Date: Sun, 11 Sep 2005 19:06:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/gnu/fs/ext2fs fs.h src/sys/kern kern_shutdown.c src/sys/sys buf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 19:06:51 -0000 truckman 2005-09-11 19:06:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/gnu/fs/ext2fs fs.h sys/kern kern_shutdown.c sys/sys buf.h Log: MFC src/sys/gnu/fs/ext2fs/fs.h 1.18 src/sys/kern/kern_shutdown.c 1.175 src/sys/sys/buf.h 1.189 Modified files: sys/gnu/fs/ext2fs fs.h sys/kern kern_shutdown.c sys/sys buf.h Log: Add a new struct buf flag bit, B_PERSISTENT, and use it to tag struct bufs that are persistently held by ext2fs. Ignore any buffers with this flag in the code in boot() that counts "busy" and dirty buffers and attempts to sync the dirty buffers, which is done before attempting to unmount all the file systems during shutdown. This fixes the problem caused by any ext2fs file systems that are mounted at system shutdown time, which caused boot() to give up on a non-zero number of buffers and skip the call to vfs_unmountall(). This left all the mounted file systems in a dirty state and caused them to all require cleanup by fsck on reboot. Move the two separate copies of the "busy" buffer test in boot() to a separate function. Nuke the useless spl() stuff in the ext2fs ULCK_BUF() macro. Bring the PRINT_BUF_FLAGS definition in sys/buf.h up to date with this and previous flag changes. PR: kern/56675, kern/85163 Tested by: "Matthias Andree" matthias.andree at gmx.de Reviewed by: bde MFC after: 3 days PR: kern/56675, kern/85163 Tested by: "Hanspeter Roth" hampi at rootshell.be Tested by: "Matthias Andree" matthias.andree at gmx.de Reviewed by: bde Approved by: re (scottl) Revision Changes Path 1.17.2.1 +8 -8 src/sys/gnu/fs/ext2fs/fs.h 1.174.2.1 +13 -11 src/sys/kern/kern_shutdown.c 1.187.2.2 +4 -4 src/sys/sys/buf.h From owner-cvs-src@FreeBSD.ORG Sun Sep 11 19:28:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACBDA16A41F; Sun, 11 Sep 2005 19:28:32 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 802F643D45; Sun, 11 Sep 2005 19:28:32 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BJSWSn066428; Sun, 11 Sep 2005 19:28:32 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BJSWci066427; Sun, 11 Sep 2005 19:28:32 GMT (envelope-from imp) Message-Id: <200509111928.j8BJSWci066427@repoman.freebsd.org> From: Warner Losh Date: Sun, 11 Sep 2005 19:28:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 19:28:32 -0000 imp 2005-09-11 19:28:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci.c Log: Change the default of pci_do_powerstate to 0, per request from re@. The number of raid controllers that violate the WHQL seems to be growing in number and not isolated to old versions as previously thought. Though the numbers of these seen in the wild is still relatively small, they hang the system when parts of their devices are powered down. The one area that these parts appear often are in the higher end servers. As such, be conservative about powering down devices that have no driver attached by default. Until a better approach is proven in current, this is the prudent choice. Laptop users wishing the benefits of powering down devices with no drivers will now need to set hw.pci.do_powerstate=1 in their /boot/loader.conf file. Some users will have devices that will prevent this setting (hence the need to make it default 0). Approved by: re@ (scottl) Revision Changes Path 1.292.2.2 +2 -2 src/sys/dev/pci/pci.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 19:58:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0B5F16A41F; Sun, 11 Sep 2005 19:58:26 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEC6043D45; Sun, 11 Sep 2005 19:58:19 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BJwJ4Z068036; Sun, 11 Sep 2005 19:58:19 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BJwJ9F068035; Sun, 11 Sep 2005 19:58:19 GMT (envelope-from mjacob) Message-Id: <200509111958.j8BJwJ9F068035@repoman.freebsd.org> From: Matt Jacob Date: Sun, 11 Sep 2005 19:58:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 19:58:26 -0000 mjacob 2005-09-11 19:58:19 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: Restore the 929X support that got nuked in merge Revision Changes Path 1.22 +7 -0 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Sun Sep 11 20:18:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 338F316A41F; Sun, 11 Sep 2005 20:18:39 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84A6443D48; Sun, 11 Sep 2005 20:18:38 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8BKIaCe006327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 12 Sep 2005 00:18:37 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8BKIaOT006325; Mon, 12 Sep 2005 00:18:36 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 12 Sep 2005 00:18:36 +0400 From: Gleb Smirnoff To: Alexander Leidinger , Ariff Abdullah Message-ID: <20050911201836.GM53891@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200509101751.j8AHpdvp058669@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm dsp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 20:18:39 -0000 Alexander, Ariff, > Modified files: > sys/dev/sound/pcm dsp.c > Log: > Release lock for a while during chn_reset() / pcm_chnalloc() operation > while malloc()ing, this fixes LOR 129. > > See > - http://lists.freebsd.org/pipermail/freebsd-current/2005-June/051157.html > - http://lists.freebsd.org/pipermail/freebsd-current/2005-August/054620.html > - http://sources.zabbadoz.net/freebsd/lor.html#129 > > Submitted by: Ariff Abdullah This change means "release the mutex right before it's being asserted". Do you guys test you changes with INVARIANTS on? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Sun Sep 11 20:51:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8252416A41F; Sun, 11 Sep 2005 20:51:15 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D4A243D48; Sun, 11 Sep 2005 20:51:15 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BKpFLJ077467; Sun, 11 Sep 2005 20:51:15 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BKpFPJ077466; Sun, 11 Sep 2005 20:51:15 GMT (envelope-from alc) Message-Id: <200509112051.j8BKpFPJ077466@repoman.freebsd.org> From: Alan Cox Date: Sun, 11 Sep 2005 20:51:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/include param.h vmparam.h src/sys/ia64/include param.h vmparam.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 20:51:15 -0000 alc 2005-09-11 20:51:15 UTC FreeBSD src repository Modified files: sys/alpha/include param.h vmparam.h sys/ia64/include param.h vmparam.h Log: Eliminate unused definitions. Revision Changes Path 1.39 +0 -7 src/sys/alpha/include/param.h 1.11 +1 -1 src/sys/alpha/include/vmparam.h 1.22 +0 -7 src/sys/ia64/include/param.h 1.11 +1 -1 src/sys/ia64/include/vmparam.h From owner-cvs-src@FreeBSD.ORG Sun Sep 11 20:59:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A743016A41F; Sun, 11 Sep 2005 20:59:52 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6672F43D48; Sun, 11 Sep 2005 20:59:52 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8BKxqYP077912; Sun, 11 Sep 2005 20:59:52 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8BKxqm8077911; Sun, 11 Sep 2005 20:59:52 GMT (envelope-from stefanf) Message-Id: <200509112059.j8BKxqm8077911@repoman.freebsd.org> From: Stefan Farfeleder Date: Sun, 11 Sep 2005 20:59:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/rpc Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 20:59:52 -0000 stefanf 2005-09-11 20:59:52 UTC FreeBSD src repository Modified files: lib/libc/rpc Makefile.inc Log: Add a couple of missing MLINKS. Revision Changes Path 1.27 +17 -0 src/lib/libc/rpc/Makefile.inc From owner-cvs-src@FreeBSD.ORG Sun Sep 11 21:29:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D1DC16A41F; Sun, 11 Sep 2005 21:29:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id C49C743D45; Sun, 11 Sep 2005 21:29:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id E8B9246B33; Sun, 11 Sep 2005 17:29:16 -0400 (EDT) Date: Sun, 11 Sep 2005 22:29:16 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: "David E. O'Brien" In-Reply-To: <200509071006.j87A6E8s012380@repoman.freebsd.org> Message-ID: <20050911222701.W33344@fledge.watson.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 21:29:18 -0000 On Wed, 7 Sep 2005, David E. O'Brien wrote: > Modified files: > sys/kern kern_tc.c > sys/net rtsock.c > sys/netipx ipx_proto.c > sys/netnatm natm_proto.c > Log: > Forward declaring static variables as extern is invalid ISO-C. Now that > GCC can properly handle forward static declarations, do this properly. As a result of this change, it is no longer possible to build 7.x kernels on 6.x worlds without building all of world or tweaking kernel makefiles. While that's not a formally supported configuration, it makes it a lot easier and faster to do development from a central buildbox on a farm of test systems. Given that you've MFC'd the gcc fix to RELENG_5, I assume a change will be queued to merge to RELENG_6, but in the mean time it's something of an irritating problem (up there with NOMAN -> NO_MAN). In the future, could you merge the gcc fixes to the relevant branches before merging the dependent C changes, in order to avoid this sort of thing? Robert N M Watson From owner-cvs-src@FreeBSD.ORG Sun Sep 11 21:47:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D80A516A41F; Sun, 11 Sep 2005 21:47:30 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AED743D46; Sun, 11 Sep 2005 21:47:30 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-185-177.dsl.snfc21.pacbell.net [64.171.185.177]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8BLlWo5000948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 11 Sep 2005 14:47:33 -0700 Message-ID: <4324A5EF.3050803@root.org> Date: Sun, 11 Sep 2005 14:47:27 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Doug Barton References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> In-Reply-To: <432397EF.5000409@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Kris Kennaway , Garance A Drosihn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 21:47:31 -0000 Doug Barton wrote: > Kris Kennaway wrote: > > >>Likewise, I also find this change very useful. When I'm juggling a >>few dozen panics on a few dozen machines with a few dozen different >>customized source trees, it's hard to keep track of all the >>kernel.debugs. Now I don't have to. >> >>Also, now we won't have to throw away panic reports from users who >>didn't think to save their kernel.debug, and the quality of bug >>reports can increase. > > > I agree with Kris and David here, FWIW. > > Doug Can we put it somewhere other than /? /var/run/kernel? -- Nate From owner-cvs-src@FreeBSD.ORG Sun Sep 11 21:49:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4DCB16A41F; Sun, 11 Sep 2005 21:49:26 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F93443D46; Sun, 11 Sep 2005 21:49:26 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-185-177.dsl.snfc21.pacbell.net [64.171.185.177]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8BLnTo5000962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 11 Sep 2005 14:49:30 -0700 Message-ID: <4324A665.3070405@root.org> Date: Sun, 11 Sep 2005 14:49:25 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: obrien@FreeBSD.org References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> In-Reply-To: <20050911023622.GA51877@dragon.NUXI.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 21:49:27 -0000 David O'Brien wrote: > On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: > >>David E. O'Brien wrote: >> >>>obrien 2005-09-11 00:22:21 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/conf kern.post.mk >>> Log: >>> For HEAD, install a kernel with debug information if DEBUG is a kernel >>> config option. It is too easy to loose the build directory and not have >>> symbols for kgdb to read. >>> >>> Revision Changes Path >>> 1.84 +4 -17 src/sys/conf/kern.post.mk >> >>I disagree with this change. We do not need to waste the space in /. >>If I'm running a debug kernel, it is based on the latest version of >>kernel.debug in my kernel compile dir and I know to find it there. > > > We do need this. The panic I posted yesterday happened in the 'make' > stage of the below sequence: > > cd /sys//conf > config FOO > cd ../compile/FOO > make clean > make > > Note that the kernel.debug matching the running kernel was blown away at > this point. > > I was going to just install kernel.sym instead of a kernel with symbols, > but kgdb's usage doesn't claim to support '-s' as the previous kgdb did. > kernel.sym would be better since it wouldn't have the duplication that kernel and kernel.debug have. Alternately, we can make loader(8) skip symbol sections when booting and just install kernel.debug -- Nate From owner-cvs-src@FreeBSD.ORG Sun Sep 11 21:58:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9CBA16A424; Sun, 11 Sep 2005 21:58:12 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2FB543D48; Sun, 11 Sep 2005 21:58:11 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8BLwB0r022211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Sep 2005 17:58:11 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8BLw96P026578; Sun, 11 Sep 2005 17:58:09 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 7CE8051379; Sun, 11 Sep 2005 17:58:08 -0400 (EDT) Date: Sun, 11 Sep 2005 17:58:08 -0400 From: Kris Kennaway To: Nate Lawson Message-ID: <20050911215807.GA96773@xor.obsecurity.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: <4324A5EF.3050803@root.org> User-Agent: Mutt/1.4.2.1i Cc: Doug Barton , cvs-src@FreeBSD.org, "David E. O'Brien" , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway , Garance A Drosihn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 21:58:13 -0000 --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2005 at 02:47:27PM -0700, Nate Lawson wrote: > Doug Barton wrote: > >Kris Kennaway wrote: > > > > > >>Likewise, I also find this change very useful. When I'm juggling a > >>few dozen panics on a few dozen machines with a few dozen different > >>customized source trees, it's hard to keep track of all the > >>kernel.debugs. Now I don't have to. > >> > >>Also, now we won't have to throw away panic reports from users who > >>didn't think to save their kernel.debug, and the quality of bug > >>reports can increase. > > > > > >I agree with Kris and David here, FWIW. > > > >Doug >=20 > Can we put it somewhere other than /? /var/run/kernel? Why? That would use up even more space, in total. Kris --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDJKhvWry0BWjoQKURAqYrAJ909n6LvhYWeoe9p8wT6O9Db+MiYgCfX26x 9Tm8/VdSR8ENGFXzigWbrlU= =IhxF -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 21:58:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A279F16A41F; Sun, 11 Sep 2005 21:58:51 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7B6543D48; Sun, 11 Sep 2005 21:58:49 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8BLwn0r022490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Sep 2005 17:58:49 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8BLwm6P026635; Sun, 11 Sep 2005 17:58:48 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 62CB451379; Sun, 11 Sep 2005 17:58:48 -0400 (EDT) Date: Sun, 11 Sep 2005 17:58:48 -0400 From: Kris Kennaway To: Nate Lawson Message-ID: <20050911215848.GB96773@xor.obsecurity.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline In-Reply-To: <4324A665.3070405@root.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 21:58:51 -0000 --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2005 at 02:49:25PM -0700, Nate Lawson wrote: > David O'Brien wrote: > >On Sat, Sep 10, 2005 at 06:05:00PM -0700, Nate Lawson wrote: > > > >>David E. O'Brien wrote: > >> > >>>obrien 2005-09-11 00:22:21 UTC > >>> > >>>FreeBSD src repository > >>> > >>>Modified files: > >>> sys/conf kern.post.mk=20 > >>>Log: > >>>For HEAD, install a kernel with debug information if DEBUG is a kernel > >>>config option. It is too easy to loose the build directory and not ha= ve > >>>symbols for kgdb to read. > >>> > >>>Revision Changes Path > >>>1.84 +4 -17 src/sys/conf/kern.post.mk > >> > >>I disagree with this change. We do not need to waste the space in /.= =20 > >>If I'm running a debug kernel, it is based on the latest version of=20 > >>kernel.debug in my kernel compile dir and I know to find it there. > > > > > >We do need this. The panic I posted yesterday happened in the 'make' > >stage of the below sequence: > > > > cd /sys//conf > > config FOO > > cd ../compile/FOO > > make clean > > make > > > >Note that the kernel.debug matching the running kernel was blown away at > >this point. > > > >I was going to just install kernel.sym instead of a kernel with symbols, > >but kgdb's usage doesn't claim to support '-s' as the previous kgdb did. > > >=20 > kernel.sym would be better since it wouldn't have the duplication that=20 > kernel and kernel.debug have. Alternately, we can make loader(8) skip=20 > symbol sections when booting and just install kernel.debug It does skip symbol sections. Kris --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDJKiXWry0BWjoQKURAsJiAKDoFUwLBszfXsLzPvtbBQo21FMv/QCfRWrH gQ/5M5ukHkhqKHVp2hyqQxE= =BSq9 -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6-- From owner-cvs-src@FreeBSD.ORG Sun Sep 11 22:22:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9090A16A41F; Sun, 11 Sep 2005 22:22:06 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B12843D48; Sun, 11 Sep 2005 22:22:05 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j8BMM203022643; Sun, 11 Sep 2005 18:22:04 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <20050911105821.GA91588@server.vk2pj.dyndns.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911105821.GA91588@server.vk2pj.dyndns.org> Date: Sun, 11 Sep 2005 18:22:02 -0400 To: Peter Jeremy , Nate Lawson From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.3 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 22:22:06 -0000 At 8:58 PM +1000 9/11/05, Peter Jeremy wrote: > >A number of people have mentioned losing the debug kernel when >they do a rebuild. I can't speak for others, but I mentioned losing the debug-symbol information before the point in time where I actually needed it (due to some sytsem panic). I did not mention building a new kernel. I have removed files from /usr/obj/usr/src without building any new kernel, so the problem does not require a rebuild. >The normal reasons for doing a rebuild are either that you have >updated your source or you've changed your config. The "normal" reasons are not universally true. Ie, even if the "normal" reasons apply 85% of the time, there's 15% of the time when they don't apply. And the coredumps lost in that 15% are still likely to be valuable. Valuable and lost. >In the latter case, I would suggest that the only reason to change >the kernel config is if you are planning on installing a new kernel, >so again you don't need the old debug kernel. Except when you built the new kernel, and it panics IMMEDIATELY upon boot, so you revert back to the previous kernel. And that previous kernel is one which "only occasionally" panics. Now, I know that the above comments do not apply 100% of the time, but they apply often enough that I've been burned (multiple times!) where I did not have the debug symbols for a coredump generated from an unexpected system panic. And I know other freebsd users who have burnt by this same issue. So I'd like to see some change done. Maybe not this one, but this one will do nicely until a better one comes along. >In this change intended for -current only or will it remain in >7-RELEASE? I expect it's much too soon to decide that. Let's get 6.0-release finished before we worry about the low-level details of exactly how 7.0-release should be built! :-) -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Sun Sep 11 22:40:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE48916A41F; Sun, 11 Sep 2005 22:40:02 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 423AA43D46; Sun, 11 Sep 2005 22:40:02 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j8BMe0OI025300; Sun, 11 Sep 2005 18:40:00 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <4324A5EF.3050803@root.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> Date: Sun, 11 Sep 2005 18:39:59 -0400 To: Nate Lawson , Doug Barton From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.3 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Kris Kennaway Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 22:40:02 -0000 At 2:47 PM -0700 9/11/05, Nate Lawson wrote: > >Can we put it somewhere other than /? /var/run/kernel? and At 2:49 PM -0700 9/11/05, Nate Lawson wrote: >kernel.sym would be better since it wouldn't have the duplication >that kernel and kernel.debug have. Alternately, we can make >loader(8) skip symbol sections when booting and just install >kernel.debug I like having the symbols in the same directory as the kernel object files. Perhaps we could do something with making kernel.sym files (and .sym files for the kernel modules). Another idea that I meant to try sometime was to bzip2 the *.debug files (or the *.sym files, if we can generate those). That way, the info would be in the right place when it's needed, but until then it won't take up as much room. I have no idea how practical that would be, though... -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Mon Sep 12 00:51:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DBF516A41F; Mon, 12 Sep 2005 00:51:37 +0000 (GMT) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 636D943D46; Mon, 12 Sep 2005 00:51:36 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 846CE1310DA; Mon, 12 Sep 2005 10:21:34 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 4602F84F7E; Mon, 12 Sep 2005 10:21:34 +0930 (CST) Date: Mon, 12 Sep 2005 10:21:34 +0930 From: Greg 'groggy' Lehey To: Kris Kennaway Message-ID: <20050912005134.GB2929@wantadilla.lemis.com> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: <20050911022901.GA3090@xor.obsecurity.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Nate Lawson , Garance A Drosihn Subject: How to debug kernels (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 00:51:37 -0000 --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Saturday, 10 September 2005 at 22:29:02 -0400, Kris Kennaway wrote: > On Sat, Sep 10, 2005 at 10:01:15PM -0400, Garance A Drosihn wrote: >> At 6:05 PM -0700 9/10/05, Nate Lawson wrote: >>> David E. O'Brien wrote: >>>> obrien 2005-09-11 00:22:21 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/conf kern.post.mk Log: >>>> For HEAD, install a kernel with debug information if DEBUG is a kernel >>>> config option. It is too easy to loose the build directory and not have >>>> symbols for kgdb to read. >>>> Revision Changes Path >>>> 1.84 +4 -17 src/sys/conf/kern.post.mk >>> >>> I disagree with this change. We do not need to waste the space >>> in /. If I'm running a debug kernel, it is based on the latest >>> version of kernel.debug in my kernel compile dir and I know to >>> find it there. >> >> Fwiw, I've been burned by building a debug kernel, only to have >> removed the original compile-directory for that kernel by the time I >> actually *needed* the debug symbols. It's one thing if you're building >> a debug kernel because you know you're going to spend the next hour >> debugging some change. It's another if you're building a debug kernel >> because your machine might panic sometime in the next two or three >> weeks. > > Likewise, I also find this change very useful. When I'm juggling a > few dozen panics on a few dozen machines with a few dozen different > customized source trees, it's hard to keep track of all the > kernel.debugs. Now I don't have to. A lot must depend on how you use your debug kernel. One of the biggest problems I've found is keeping the kernel and the sources in sync. This change makes it more difficult. Also, the kernel build can install debugging macros in the build directory; if you blow away that directory, you've lost the macros too. The method I use is described in http://wwww.lemis.com/grog/Papers/Debug-tutorial/tutorial.pdf. Basically, you debug from the kernel build directory and just pull in the dump from /var/crash. I'm planning to present it again in Basel in November, so if anybody disagrees with the approach, now is the time to tell me. With this method, having symbols in the booted kernel is a waste of time and space. Greg -- See complete headers for address and phone numbers. --98e8jtXdkpgskNou Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDJNEWIubykFB6QiMRAl1uAJ0WpTPyyuzgx4syeso3mqsBJp1csACeN59a yv2UsIIgDyStPGMAjQ4kNo4= =98E8 -----END PGP SIGNATURE----- --98e8jtXdkpgskNou-- From owner-cvs-src@FreeBSD.ORG Mon Sep 12 00:59:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0557616A41F; Mon, 12 Sep 2005 00:59:05 +0000 (GMT) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66C5243D45; Mon, 12 Sep 2005 00:59:04 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 85FFC131D47; Mon, 12 Sep 2005 10:29:03 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 5D87284F7E; Mon, 12 Sep 2005 10:29:03 +0930 (CST) Date: Mon, 12 Sep 2005 10:29:03 +0930 From: Greg 'groggy' Lehey To: "David E. O'Brien" Message-ID: <20050912005903.GC2929@wantadilla.lemis.com> References: <200509111839.j8BId3fF064385@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V88s5gaDVPzZ0KCq" Content-Disposition: inline In-Reply-To: <200509111839.j8BId3fF064385@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c src/sys/dev/acpi_support acpi_asus.c acpi_fujitsu.c acpi_ibm.c acpi_panasonic.c acpi_sony.c acpi_toshiba.c src/sys/dev/acpica acpi.c acpi_acad.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 00:59:05 -0000 --V88s5gaDVPzZ0KCq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sunday, 11 September 2005 at 18:39:03 +0000, David E. O'Brien wrote: > obrien 2005-09-11 18:39:03 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/acpica OsdEnvironment.c acpi_machdep.c > ... > acpi_wakeup.c madt.c > Log: > Canonize the include of acpi.h. Now called Saint-acpi.h? Greg -- See complete headers for address and phone numbers. --V88s5gaDVPzZ0KCq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDJNLXIubykFB6QiMRAnhQAJsFQ8BDiFZvj4Czf2rlCJUOYjH9VACgtPY2 ctQyVDx22ehmVhdL4xzZbI0= =0eZX -----END PGP SIGNATURE----- --V88s5gaDVPzZ0KCq-- From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:00:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78F5B16A41F; Mon, 12 Sep 2005 01:00:38 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2972343D4C; Mon, 12 Sep 2005 01:00:37 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8C10a47077918; Sun, 11 Sep 2005 18:00:36 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8C10Y31077917; Sun, 11 Sep 2005 18:00:34 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 18:00:34 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20050912010034.GA77819@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4324A665.3070405@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:00:38 -0000 On Sun, Sep 11, 2005 at 02:49:25PM -0700, Nate Lawson wrote: > David O'Brien wrote: > >I was going to just install kernel.sym instead of a kernel with symbols, > >but kgdb's usage doesn't claim to support '-s' as the previous kgdb did. > > kernel.sym would be better since it wouldn't have the duplication that > kernel and kernel.debug have. Duplication in RELENG_* or in HEAD? > Alternately, we can make loader(8) skip > symbol sections when booting and just install kernel.debug That *is* what my change does - except it calls it "kernel" so there aren't loading issues. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:07:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 890CE16A41F; Mon, 12 Sep 2005 01:07:47 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 326BB43D45; Mon, 12 Sep 2005 01:07:47 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8C17kXg078110; Sun, 11 Sep 2005 18:07:46 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8C17kaX078109; Sun, 11 Sep 2005 18:07:46 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 18:07:46 -0700 From: "David O'Brien" To: "Greg 'groggy' Lehey" Message-ID: <20050912010746.GA77456@dragon.NUXI.org> References: <200509111839.j8BId3fF064385@repoman.freebsd.org> <20050912005903.GC2929@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050912005903.GC2929@wantadilla.lemis.com> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/acpica OsdEnvironment.c acpi_machdep.c acpi_wakeup.c madt.c src/sys/dev/acpi_support acpi_asus.c acpi_fujitsu.c acpi_ibm.c acpi_panasonic.c acpi_sony.c acpi_toshiba.c src/sys/dev/acpica acpi.c acpi_acad.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:07:47 -0000 On Mon, Sep 12, 2005 at 10:29:03AM +0930, Greg 'groggy' Lehey wrote: > On Sunday, 11 September 2005 at 18:39:03 +0000, David E. O'Brien wrote: > > obrien 2005-09-11 18:39:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/acpica OsdEnvironment.c acpi_machdep.c > > ... > > acpi_wakeup.c madt.c > > Log: > > Canonize the include of acpi.h. > > Now called Saint-acpi.h? Blah, spell checkers. Canonify. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:21:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BE4A16A41F; Mon, 12 Sep 2005 01:21:43 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C24143D45; Mon, 12 Sep 2005 01:21:43 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C1LhYv095640; Mon, 12 Sep 2005 01:21:43 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C1Lhfs095639; Mon, 12 Sep 2005 01:21:43 GMT (envelope-from tegge) Message-Id: <200509120121.j8C1Lhfs095639@repoman.freebsd.org> From: Tor Egge Date: Mon, 12 Sep 2005 01:21:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_rawread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:21:43 -0000 tegge 2005-09-12 01:21:43 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_rawread.c Log: Giant is no longer needed here. Revision Changes Path 1.26 +0 -3 src/sys/ufs/ffs/ffs_rawread.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:36:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D3AE16A41F; Mon, 12 Sep 2005 01:36:18 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8EE643D46; Mon, 12 Sep 2005 01:36:17 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8C1aHcA078534; Sun, 11 Sep 2005 18:36:17 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8C1aG40078533; Sun, 11 Sep 2005 18:36:16 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 18:36:16 -0700 From: "David O'Brien" To: Robert Watson Message-ID: <20050912013616.GA78451@dragon.NUXI.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050911222701.W33344@fledge.watson.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:36:18 -0000 On Sun, Sep 11, 2005 at 10:29:16PM +0100, Robert Watson wrote: > On Wed, 7 Sep 2005, David E. O'Brien wrote: > > Modified files: > > sys/kern kern_tc.c > > sys/net rtsock.c > > sys/netipx ipx_proto.c > > sys/netnatm natm_proto.c > > Log: > > Forward declaring static variables as extern is invalid ISO-C. Now that > > GCC can properly handle forward static declarations, do this properly. > > As a result of this change, it is no longer possible to build 7.x kernels > on 6.x worlds without building all of world or tweaking kernel makefiles. We do not support building a HEAD kernel on a RELENG_ box. Never have. That it usually works for you is just gravy. The documented minimal steps to build a HEAD kernel is: make kernel-toolchain make -DALWAYS_CHECK_MAKE buildkernel KERNCONF=YOUR_KERNEL_HERE > While that's not a formally supported configuration, it makes it a lot > easier and faster to do development from a central buildbox on a farm of > test systems. Building a HEAD kernel on RELENG_ isn't anywhere near a supported configuration. I really don't know where you got the idea it was. On a 6.0-beta2 machine I just did a HEAD 'make kernel-toolchain' - it took 3m53.49s and allowed me to build a HEAD kernel just fine. > In the future, could you merge the gcc fixes to the relevant branches > before merging the dependent C changes, in order to avoid this sort of > thing? I'm afraid that is unreasonable to do in this case. I'd be waiting an undetermined amount of time for RELENG_6 to thaw before I could do this work. HEAD was already frozen for 1 months this year - you're effectively asking me to work as if is frozen for an additional 2 months. On top of that - the "relevant branches" is HEAD and only HEAD. Which is where the GCC fixes were committed before depending on them. Note that I did the RELENG_5 MFC for you personally, knowing you do try to build HEAD kernels on RELENG_*. I would have MFC'ed to RELENG_6 for your benefit, but its frozen. You are an RE - please feel free to MFC the bug fix. I certainly would not mind. :-) -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:48:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1823716A420; Mon, 12 Sep 2005 01:48:58 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9F3543D4C; Mon, 12 Sep 2005 01:48:57 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C1mvbO096537; Mon, 12 Sep 2005 01:48:57 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C1mvFS096536; Mon, 12 Sep 2005 01:48:57 GMT (envelope-from tegge) Message-Id: <200509120148.j8C1mvFS096536@repoman.freebsd.org> From: Tor Egge Date: Mon, 12 Sep 2005 01:48:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_hash.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:48:58 -0000 tegge 2005-09-12 01:48:57 UTC FreeBSD src repository Modified files: sys/kern vfs_hash.c Log: Don't retry when vget() returns ENOENT in the nonblocking case due to the vnode being doomed. It causes a livelock. Revision Changes Path 1.10 +2 -2 src/sys/kern/vfs_hash.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 01:53:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDFE416A41F; Mon, 12 Sep 2005 01:53:13 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79A3D43D48; Mon, 12 Sep 2005 01:53:09 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j8C1r7jR060820; Sun, 11 Sep 2005 19:53:07 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4324DF83.1030202@samsco.org> Date: Sun, 11 Sep 2005 19:53:07 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: obrien@FreeBSD.org References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> In-Reply-To: <20050912013616.GA78451@dragon.NUXI.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 01:53:14 -0000 David O'Brien wrote: > On Sun, Sep 11, 2005 at 10:29:16PM +0100, Robert Watson wrote: > >>On Wed, 7 Sep 2005, David E. O'Brien wrote: >> >>>Modified files: >>> sys/kern kern_tc.c >>> sys/net rtsock.c >>> sys/netipx ipx_proto.c >>> sys/netnatm natm_proto.c >>>Log: >>>Forward declaring static variables as extern is invalid ISO-C. Now that >>>GCC can properly handle forward static declarations, do this properly. >> >>As a result of this change, it is no longer possible to build 7.x kernels >>on 6.x worlds without building all of world or tweaking kernel makefiles. > > > We do not support building a HEAD kernel on a RELENG_ box. Never have. > That it usually works for you is just gravy. > > The documented minimal steps to build a HEAD kernel is: > > make kernel-toolchain > make -DALWAYS_CHECK_MAKE buildkernel KERNCONF=YOUR_KERNEL_HERE > > >>While that's not a formally supported configuration, it makes it a lot >>easier and faster to do development from a central buildbox on a farm of >>test systems. > > > Building a HEAD kernel on RELENG_ isn't anywhere near a supported > configuration. I really don't know where you got the idea it was. On a > 6.0-beta2 machine I just did a HEAD 'make kernel-toolchain' - it took > 3m53.49s and allowed me to build a HEAD kernel just fine. > It might not be supported, but having it work helps people do work. Having it break for trivial reasons is frustrating and slows down work. > >>In the future, could you merge the gcc fixes to the relevant branches >>before merging the dependent C changes, in order to avoid this sort of >>thing? > > > I'm afraid that is unreasonable to do in this case. I'd be waiting an > undetermined amount of time for RELENG_6 to thaw before I could do this > work. Alternatively, you could ask to MFC it to RELENG_6. I would have happily said 'yes'. I agree with Robert on this point. > HEAD was already frozen for 1 months this year - you're > effectively asking me to work as if is frozen for an additional 2 months. > On top of that - the "relevant branches" is HEAD and only HEAD. Which > is where the GCC fixes were committed before depending on them. > > Note that I did the RELENG_5 MFC for you personally, knowing you do try > to build HEAD kernels on RELENG_*. I would have MFC'ed to RELENG_6 for > your benefit, but its frozen. You are an RE - please feel free to MFC > the bug fix. I certainly would not mind. :-) > David, you're shifting blame here, whatever little blame there is. Please be a good team player and ask to MFC the change to RELENG_6. Scott From owner-cvs-src@FreeBSD.ORG Mon Sep 12 02:16:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44F8916A41F; Mon, 12 Sep 2005 02:16:10 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id D032943D46; Mon, 12 Sep 2005 02:16:09 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8C2G9Ga079049; Sun, 11 Sep 2005 19:16:09 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8C2G8mG079048; Sun, 11 Sep 2005 19:16:08 -0700 (PDT) (envelope-from obrien) Date: Sun, 11 Sep 2005 19:16:08 -0700 From: "David O'Brien" To: Scott Long Message-ID: <20050912021608.GB78451@dragon.NUXI.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <4324DF83.1030202@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4324DF83.1030202@samsco.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 02:16:10 -0000 On Sun, Sep 11, 2005 at 07:53:07PM -0600, Scott Long wrote: > David O'Brien wrote: > >Building a HEAD kernel on RELENG_ isn't anywhere near a supported > >configuration. I really don't know where you got the idea it was. On a > >6.0-beta2 machine I just did a HEAD 'make kernel-toolchain' - it took > >3m53.49s and allowed me to build a HEAD kernel just fine. > > It might not be supported, but having it work helps people do work. > Having it break for trivial reasons is frustrating and slows down > work. Getting HEAD ready for GCC 4.x isn't a trivial tastk. This was all part of doing that. > >>In the future, could you merge the gcc fixes to the relevant branches > >>before merging the dependent C changes, in order to avoid this sort of > >>thing? > > > >I'm afraid that is unreasonable to do in this case. I'd be waiting an > >undetermined amount of time for RELENG_6 to thaw before I could do this > >work. > > Alternatively, you could ask to MFC it to RELENG_6. I would have > happily said 'yes'. I agree with Robert on this point. I wont get into a public debate about this - as has been expressed by others the MFC request process doesn't always run smoothly. MFC'ing something to RELENG_* isn't a requirement to progress on HEAD. If this was, we'd never be able to rev the toolchain. I don't believe those that insist on building HEAD kernels with a non-HEAD userland have been thru a large compiler upgrade (a.out->2.7->EGCS->2.95->3.x). Otherwise it would be clear that you simply cannot depend on building HEAD code with an old compiler. > >HEAD was already frozen for 1 months this year - you're > >effectively asking me to work as if is frozen for an additional 2 months. > >On top of that - the "relevant branches" is HEAD and only HEAD. Which > >is where the GCC fixes were committed before depending on them. > > >Note that I did the RELENG_5 MFC for you personally, knowing you do try > >to build HEAD kernels on RELENG_*. I would have MFC'ed to RELENG_6 for > >your benefit, but its frozen. You are an RE - please feel free to MFC > >the bug fix. I certainly would not mind. :-) > > David, you're shifting blame here, whatever little blame there is. The blame is that someone is trying to hold blame on me for advancing 7-CURRENT. > Please be a good team player and ask to MFC the change to RELENG_6. No. RE owns the branch - RE is free to MFC things they feel important to have in the release. You guys are experienced professionals and don't need my permission to MFC something RE wants in 6.0-R. In the past I've had multiple bad experience tired of begging to MFC things and then having to send at times multiple begging followup emails to get a response. If I don't feel very strongly about something, I don't bother anymore trying to MFC it during a code RELENG_* freeze. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 03:32:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4507216A41F; Mon, 12 Sep 2005 03:32:47 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA96943D46; Mon, 12 Sep 2005 03:32:46 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C3WkIZ000502; Mon, 12 Sep 2005 03:32:46 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C3Wk9D000501; Mon, 12 Sep 2005 03:32:46 GMT (envelope-from obrien) Message-Id: <200509120332.j8C3Wk9D000501@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 12 Sep 2005 03:32:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 03:32:47 -0000 obrien 2005-09-12 03:32:46 UTC FreeBSD src repository Modified files: sys/dev/usb usbdevs Log: Note that Keyspan is also InnoSys Inc. Revision Changes Path 1.233 +1 -1 src/sys/dev/usb/usbdevs From owner-cvs-src@FreeBSD.ORG Mon Sep 12 03:34:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1652E16A41F; Mon, 12 Sep 2005 03:34:06 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B5EF43D45; Mon, 12 Sep 2005 03:34:05 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C3Y5Y0000574; Mon, 12 Sep 2005 03:34:05 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C3Y5J4000573; Mon, 12 Sep 2005 03:34:05 GMT (envelope-from obrien) Message-Id: <200509120334.j8C3Y5J4000573@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 12 Sep 2005 03:34:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include ucontext.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 03:34:06 -0000 obrien 2005-09-12 03:34:05 UTC FreeBSD src repository Modified files: sys/i386/include ucontext.h Log: MFamd64: use register_t's. Revision Changes Path 1.11 +42 -42 src/sys/i386/include/ucontext.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 04:12:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6340416A41F; Mon, 12 Sep 2005 04:12:51 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2470D43D45; Mon, 12 Sep 2005 04:12:51 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C4Cp3P001972; Mon, 12 Sep 2005 04:12:51 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C4CorF001971; Mon, 12 Sep 2005 04:12:50 GMT (envelope-from imp) Message-Id: <200509120412.j8C4CorF001971@repoman.freebsd.org> From: Warner Losh Date: Mon, 12 Sep 2005 04:12:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 04:12:51 -0000 imp 2005-09-12 04:12:50 UTC FreeBSD src repository Modified files: sys/dev/sound/isa mss.c Log: Since opti_detect is now only called on !PC98 machines, only declare and define there as well. This should fix the pc98 tinderbox. Revision Changes Path 1.101 +4 -0 src/sys/dev/sound/isa/mss.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 04:25:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76FEB16A41F; Mon, 12 Sep 2005 04:25:54 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4CBE43D46; Mon, 12 Sep 2005 04:25:53 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C4PrlN002635; Mon, 12 Sep 2005 04:25:53 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C4PrDq002634; Mon, 12 Sep 2005 04:25:53 GMT (envelope-from truckman) Message-Id: <200509120425.j8C4PrDq002634@repoman.freebsd.org> From: Don Lewis Date: Mon, 12 Sep 2005 04:25:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/gnu/ext2fs fs.h src/sys/kern kern_shutdown.c src/sys/sys buf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 04:25:54 -0000 truckman 2005-09-12 04:25:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/gnu/ext2fs fs.h sys/kern kern_shutdown.c sys/sys buf.h Log: MFC src/sys/gnu/fs/ext2fs/fs.h 1.18 src/sys/kern/kern_shutdown.c 1.175 src/sys/sys/buf.h 1.189 FreeBSD src repository Modified files: sys/gnu/fs/ext2fs fs.h sys/kern kern_shutdown.c sys/sys buf.h Log: Add a new struct buf flag bit, B_PERSISTENT, and use it to tag struct bufs that are persistently held by ext2fs. Ignore any buffers with this flag in the code in boot() that counts "busy" and dirty buffers and attempts to sync the dirty buffers, which is done before attempting to unmount all the file systems during shutdown. This fixes the problem caused by any ext2fs file systems that are mounted at system shutdown time, which caused boot() to give up on a non-zero number of buffers and skip the call to vfs_unmountall(). This left all the mounted file systems in a dirty state and caused them to all require cleanup by fsck on reboot. Move the two separate copies of the "busy" buffer test in boot() to a separate function. Nuke the useless spl() stuff in the ext2fs ULCK_BUF() macro. Bring the PRINT_BUF_FLAGS definition in sys/buf.h up to date with this and previous flag changes. PR: kern/56675, kern/85163 Tested by: "Matthias Andree" matthias.andree at gmx.de Reviewed by: bde MFC after: 3 days Revision Changes Path 1.18 +8 -8 src/sys/gnu/fs/ext2fs/fs.h 1.175 +13 -11 src/sys/kern/kern_shutdown.c 1.189 +4 -4 src/sys/sys/buf.h PR: kern/56675, kern/85163 Tested by: "Matthias Andree" matthias.andree at gmx.de Reviewed by: bde Revision Changes Path 1.16.2.2 +8 -8 src/sys/gnu/ext2fs/fs.h 1.163.2.5 +13 -11 src/sys/kern/kern_shutdown.c 1.167.2.4 +3 -3 src/sys/sys/buf.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 05:25:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FF7516A41F; Mon, 12 Sep 2005 05:25:30 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C94E143D49; Mon, 12 Sep 2005 05:25:29 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C5PTAA012094; Mon, 12 Sep 2005 05:25:29 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C5PTwm012093; Mon, 12 Sep 2005 05:25:29 GMT (envelope-from mjacob) Message-Id: <200509120525.j8C5PTwm012093@repoman.freebsd.org> From: Matt Jacob Date: Mon, 12 Sep 2005 05:25:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 05:25:30 -0000 mjacob 2005-09-12 05:25:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mpt mpt_pci.c Log: MFC: Restore the 929X support that got nuked in merge Approved by: re Revision Changes Path 1.20.2.1 +7 -0 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 05:30:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1100916A41F; Mon, 12 Sep 2005 05:30:08 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fileserver.fields.utoronto.ca (fileserver.fields.utoronto.ca [128.100.216.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C33843D46; Mon, 12 Sep 2005 05:30:07 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from fields.fields.utoronto.ca (fields.localdomain [192.168.216.11]) by fileserver.fields.utoronto.ca (8.12.8/8.12.8/Fields 6.0) with ESMTP id j8C5U40r008772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 12 Sep 2005 01:30:04 -0400 Received: from obsecurity.dyndns.org (localhost.localdomain [127.0.0.1]) by fields.fields.utoronto.ca (8.12.8/8.12.8/Fields WS 6.0) with ESMTP id j8C5U16P030944; Mon, 12 Sep 2005 01:30:01 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0017A51233; Mon, 12 Sep 2005 01:30:00 -0400 (EDT) Date: Mon, 12 Sep 2005 01:30:00 -0400 From: Kris Kennaway To: "Greg 'groggy' Lehey" Message-ID: <20050912053000.GA28227@xor.obsecurity.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <20050912005134.GB2929@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <20050912005134.GB2929@wantadilla.lemis.com> User-Agent: Mutt/1.4.2.1i Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Kris Kennaway , "David E. O'Brien" , cvs-all@FreeBSD.org, Nate Lawson , Garance A Drosihn Subject: Re: How to debug kernels (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 05:30:08 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 12, 2005 at 10:21:34AM +0930, Greg 'groggy' Lehey wrote: > On Saturday, 10 September 2005 at 22:29:02 -0400, Kris Kennaway wrote: > > On Sat, Sep 10, 2005 at 10:01:15PM -0400, Garance A Drosihn wrote: > >> At 6:05 PM -0700 9/10/05, Nate Lawson wrote: > >>> David E. O'Brien wrote: > >>>> obrien 2005-09-11 00:22:21 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: > >>>> sys/conf kern.post.mk Log: > >>>> For HEAD, install a kernel with debug information if DEBUG is a ker= nel > >>>> config option. It is too easy to loose the build directory and not= have > >>>> symbols for kgdb to read. > >>>> Revision Changes Path > >>>> 1.84 +4 -17 src/sys/conf/kern.post.mk > >>> > >>> I disagree with this change. We do not need to waste the space > >>> in /. If I'm running a debug kernel, it is based on the latest > >>> version of kernel.debug in my kernel compile dir and I know to > >>> find it there. > >> > >> Fwiw, I've been burned by building a debug kernel, only to have > >> removed the original compile-directory for that kernel by the time I > >> actually *needed* the debug symbols. It's one thing if you're building > >> a debug kernel because you know you're going to spend the next hour > >> debugging some change. It's another if you're building a debug kernel > >> because your machine might panic sometime in the next two or three > >> weeks. > > > > Likewise, I also find this change very useful. When I'm juggling a > > few dozen panics on a few dozen machines with a few dozen different > > customized source trees, it's hard to keep track of all the > > kernel.debugs. Now I don't have to. >=20 > A lot must depend on how you use your debug kernel. One of the > biggest problems I've found is keeping the kernel and the sources in > sync. This change makes it more difficult. Also, the kernel build > can install debugging macros in the build directory; if you blow away > that directory, you've lost the macros too. >=20 > The method I use is described in > http://wwww.lemis.com/grog/Papers/Debug-tutorial/tutorial.pdf. > Basically, you debug from the kernel build directory and just pull in > the dump from /var/crash. I'm planning to present it again in Basel > in November, so if anybody disagrees with the approach, now is the > time to tell me. With this method, having symbols in the booted > kernel is a waste of time and space. Please reread my earlier posts for why this is a hindrance in my environment. Kris --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDJRJYWry0BWjoQKURAgyoAJ4xSzqAgQengXo7mH4pbVo39OSX8QCg9ehL rdgKNL780OW4hQ3aUpzjdA8= =rrMo -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH-- From owner-cvs-src@FreeBSD.ORG Mon Sep 12 05:35:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F1BB16A41F; Mon, 12 Sep 2005 05:35:12 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D332443D46; Mon, 12 Sep 2005 05:35:11 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C5ZB8c012476; Mon, 12 Sep 2005 05:35:11 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C5ZBfG012475; Mon, 12 Sep 2005 05:35:11 GMT (envelope-from imp) Message-Id: <200509120535.j8C5ZBfG012475@repoman.freebsd.org> From: Warner Losh Date: Mon, 12 Sep 2005 05:35:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 05:35:12 -0000 imp 2005-09-12 05:35:11 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c Log: This appears to be good for some folks, but really bad for others. Until we know why, back out 1.127. Revision Changes Path 1.128 +0 -1 src/sys/dev/pccbb/pccbb.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 06:06:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 710B716A41F; Mon, 12 Sep 2005 06:06:03 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01B8243D46; Mon, 12 Sep 2005 06:06:02 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j8C661oj026565; Mon, 12 Sep 2005 02:06:01 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <20050912005134.GB2929@wantadilla.lemis.com> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <20050912005134.GB2929@wantadilla.lemis.com> Date: Mon, 12 Sep 2005 02:06:00 -0400 To: "Greg 'groggy' Lehey" , Kris Kennaway From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.1 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" , Nate Lawson Subject: Re: How to debug kernels (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 06:06:03 -0000 [this will be a repeat to Greg, but I'll mention it publicly...] At 10:21 AM +0930 9/12/05, Greg 'groggy' Lehey wrote: > >A lot must depend on how you use your debug kernel. One of the >biggest problems I've found is keeping the kernel and the sources >in sync. ... > >The method I use is described in >http://wwww.lemis.com/grog/Papers/Debug-tutorial/tutorial.pdf. This looks like a very useful document, which pulls together a lot of information for the benefit of those developers who want to work at the kernel-level. I've only skimmed it over, but I intend to read it in more detail later... But I think David's change is a significant help for those users who are not kernel developers, and who have no desire to become a kernel developer. Most of the time I am not debugging any kernel- change of my own, for instance. All I want from a debug kernel is to have the information around if some other developer asks: "Can you get a traceback from that coredump?". I'll only care about the debug information *IF* my system hits a panic, and that may not happen until weeks after I have built a kernel. A lot can happen in my /usr/obj directories in the course of two weeks! (especially if I am not *expecting* to need any of the information in it). More serious kernel developers would still want to check out the information and follow the advice included your tutorial. But there are many users who are not working at that level of detail. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Mon Sep 12 06:26:50 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E18516A41F for ; Mon, 12 Sep 2005 06:26:50 +0000 (GMT) (envelope-from minimarmot@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3190243D6A for ; Mon, 12 Sep 2005 06:26:39 +0000 (GMT) (envelope-from minimarmot@gmail.com) Received: by xproxy.gmail.com with SMTP id i27so1832645wxd for ; Sun, 11 Sep 2005 23:26:39 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=al+a3J+R+qM3h5BoqORJn/7HrWk/PTEXgOS7X1Nww9KSmL2nIEwfWj1aVUlZiLKNWqhr2UMSJB1jF9XfObZIObGZgqfyN3pP/OuY8oRQQfyTfkv44SGTNtQR/tRJXlNZfxyC7CvXNEkrAsUzrN2NmOYLUExl+rDuiTpPKcLhc2w= Received: by 10.70.44.14 with SMTP id r14mr95867wxr; Sun, 11 Sep 2005 23:19:19 -0700 (PDT) Received: by 10.70.9.2 with HTTP; Sun, 11 Sep 2005 23:19:19 -0700 (PDT) Message-ID: <47d0403c050911231950b35471@mail.gmail.com> Date: Mon, 12 Sep 2005 06:19:19 +0000 From: Ben Kaduk To: Greg 'groggy' Lehey In-Reply-To: <20050912005134.GB2929@wantadilla.lemis.com> Mime-Version: 1.0 References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <20050912005134.GB2929@wantadilla.lemis.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: How to debug kernels (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: minimarmot@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 06:26:50 -0000 On 9/12/05, Greg 'groggy' Lehey wrote: >=20 > On Saturday, 10 September 2005 at 22:29:02 -0400, Kris Kennaway wrote: > > On Sat, Sep 10, 2005 at 10:01:15PM -0400, Garance A Drosihn wrote: > >> At 6:05 PM -0700 9/10/05, Nate Lawson wrote: > >>> David E. O'Brien wrote: > >>>> obrien 2005-09-11 00:22:21 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: > >>>> sys/conf kern.post.mk Log: > >>>> For HEAD, install a kernel with debug information if DEBUG is a=20 > kernel > >>>> config option. It is too easy to loose the build directory and not= =20 > have > >>>> symbols for kgdb to read. > >>>> Revision Changes Path > >>>> 1.84 +4 -17 src/sys/conf/kern.post.mk > >>> > >>> I disagree with this change. We do not need to waste the space > >>> in /. If I'm running a debug kernel, it is based on the latest > >>> version of kernel.debug in my kernel compile dir and I know to > >>> find it there. > >> > >> Fwiw, I've been burned by building a debug kernel, only to have > >> removed the original compile-directory for that kernel by the time I > >> actually *needed* the debug symbols. It's one thing if you're building > >> a debug kernel because you know you're going to spend the next hour > >> debugging some change. It's another if you're building a debug kernel > >> because your machine might panic sometime in the next two or three > >> weeks. > > > > Likewise, I also find this change very useful. When I'm juggling a > > few dozen panics on a few dozen machines with a few dozen different > > customized source trees, it's hard to keep track of all the > > kernel.debugs. Now I don't have to. >=20 > A lot must depend on how you use your debug kernel. One of the > biggest problems I've found is keeping the kernel and the sources in > sync. This change makes it more difficult. Also, the kernel build > can install debugging macros in the build directory; if you blow away > that directory, you've lost the macros too. >=20 > The method I use is described in > http://wwww.lemis.com/grog/Papers/Debug-tutorial/tutorial.pdf. > Basically, you debug from the kernel build directory and just pull in > the dump from /var/crash. I'm planning to present it again in Basel > in November, so if anybody disagrees with the approach, now is the > time to tell me. With this method, having symbols in the booted > kernel is a waste of time and space. >=20 > Greg > -- > See complete headers for address and phone numbers. >=20 >=20 >=20 Somewhat of a side point, but what do people think of doing a similar thing= =20 for loadable modules? I am actually quite ignorant about the matter, not=20 even knowing if a DEBUG=3D-g line in a kernel config file propogates to=20 modules built at the same time (I should think it would), but the same=20 situation can occur for modules as for the core kernel. In fact, I just today needed snd_ich.ko.debug, but very nearly blasted it= =20 away with a buildworld/buildkernel, since I want to check if the panic I ge= t=20 has been fixed in the past week. Luckily, the need to save such a file was= =20 pointed out to me quickly, but (as a fairly ignorant end-user), it may make= =20 it possible to solve a problem reported by the same. This of course magnifies the space requirement, and deciding which modules= =20 to include could be a big bikeshed, but if the debug kernel on / stays, it= =20 should be thought about. Ben Kaduk From owner-cvs-src@FreeBSD.ORG Mon Sep 12 07:16:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 709AD16A41F; Mon, 12 Sep 2005 07:16:13 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 250C543D49; Mon, 12 Sep 2005 07:16:12 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j8C7G1eM048092; Mon, 12 Sep 2005 00:16:05 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200509120716.j8C7G1eM048092@gw.catspoiler.org> Date: Mon, 12 Sep 2005 00:16:01 -0700 (PDT) From: Don Lewis To: Emanuel.strobl@gmx.net In-Reply-To: <200509110310.36423@harrymail> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org, nate@root.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 07:16:13 -0000 On 11 Sep, Emanuel Strobl wrote: > Am Sonntag, 11. September 2005 03:05 CEST schrieb Nate Lawson: >> David E. O'Brien wrote: >> > obrien 2005-09-11 00:22:21 UTC >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/conf kern.post.mk >> > Log: >> > For HEAD, install a kernel with debug information if DEBUG is a >> > kernel config option. It is too easy to loose the build directory and >> > not have symbols for kgdb to read. >> > >> > Revision Changes Path >> > 1.84 +4 -17 src/sys/conf/kern.post.mk >> >> I disagree with this change. We do not need to waste the space in /. > > Hmm, why was default size of root changed to 500M? Incredable much too much > IMHO, if not reserved for debug kernels.... > I've just been wondering today how wasteful FreeBSD uses the hard disk > these days (BETA4)... I just filled / on my laptop during the installworld (due to /tmp/install*) after my first installkernel after this change. I was able to free up enough space to do the installworld, but I'll be in trouble after the next installkernel results in copies of kernel.debug in both /boot/kernel and /boot/kernel.old, and I'll lose the ability to stash away a third kernel version. I did the initial FreeBSD install before the default root size was increased to 500M and I'm not looking forward to trying to resize root. From owner-cvs-src@FreeBSD.ORG Mon Sep 12 07:41:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1285B16A41F; Mon, 12 Sep 2005 07:41:33 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B998443D4C; Mon, 12 Sep 2005 07:41:32 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C7fW1t017563; Mon, 12 Sep 2005 07:41:32 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C7fWpo017562; Mon, 12 Sep 2005 07:41:32 GMT (envelope-from glebius) Message-Id: <200509120741.j8C7fWpo017562@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 07:41:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph netgraph.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 07:41:33 -0000 glebius 2005-09-12 07:41:32 UTC FreeBSD src repository Modified files: sys/netgraph netgraph.h Log: Remove ng_callout_init_mtx() macro. Mutexed callouts are incompatible with netgraph(4). Revision Changes Path 1.61 +0 -1 src/sys/netgraph/netgraph.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 08:03:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A015416A41F; Mon, 12 Sep 2005 08:03:16 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D7D543D45; Mon, 12 Sep 2005 08:03:16 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C83GO0018472; Mon, 12 Sep 2005 08:03:16 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C83GFt018470; Mon, 12 Sep 2005 08:03:16 GMT (envelope-from phk) Message-Id: <200509120803.j8C83GFt018470@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 12 Sep 2005 08:03:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 08:03:16 -0000 phk 2005-09-12 08:03:15 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: Clean up prototypes. Revision Changes Path 1.122 +96 -258 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 08:22:13 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E4DE16A41F; Mon, 12 Sep 2005 08:22:13 +0000 (GMT) (envelope-from dom@helenmarks.co.uk) Received: from mail.helenmarks.co.uk (mail.helenmarks.co.uk [82.68.196.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0168D43D46; Mon, 12 Sep 2005 08:22:12 +0000 (GMT) (envelope-from dom@helenmarks.co.uk) Received: from localhost (localhost [127.0.0.1]) by mail.helenmarks.co.uk (Postfix) with ESMTP id 12AE92710C02; Mon, 12 Sep 2005 09:22:08 +0100 (BST) Received: from mail.helenmarks.co.uk ([127.0.0.1]) by localhost (mail.helenmarks.co.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 54672-05; Mon, 12 Sep 2005 09:22:04 +0100 (BST) Received: by mail.helenmarks.co.uk (Postfix, from userid 80) id 8B8982710C01; Mon, 12 Sep 2005 09:22:04 +0100 (BST) Received: from graphicaldatacapture-ll-194.altohiway.com ([195.12.22.194]) (SquirrelMail authenticated user dom) by www.helenmarks.co.uk with HTTP; Mon, 12 Sep 2005 09:22:04 +0100 (BST) Message-ID: <3644.195.12.22.194.1126513324.squirrel@www.helenmarks.co.uk> In-Reply-To: <200509111155.j8BBtdmg032267@repoman.freebsd.org> References: <200509111155.j8BBtdmg032267@repoman.freebsd.org> Date: Mon, 12 Sep 2005 09:22:04 +0100 (BST) From: "Dominic Marks" To: "Max Laier" User-Agent: SquirrelMail/1.4.5 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-15 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: By ClamAV 0.85.1 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/contrib/pf/net if_pfsync.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 08:22:13 -0000 Max Laier wrote: > mlaier 2005-09-11 11:55:39 UTC > > FreeBSD src repository > > Modified files: > sys/contrib/pf/net if_pfsync.c > Log: > Stop leaking a lock. This used to cause a propagate_priority() page > fault > when setting syncdev and syncpeer. > > Reported by: Dominic Marks All is well again. Thanks for the fast diagnosis. > Revision Changes Path > 1.23 +3 -3 src/sys/contrib/pf/net/if_pfsync.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > -- Dominic Marks From owner-cvs-src@FreeBSD.ORG Mon Sep 12 08:46:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1510C16A41F; Mon, 12 Sep 2005 08:46:09 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C638B43D45; Mon, 12 Sep 2005 08:46:08 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C8k8tJ020232; Mon, 12 Sep 2005 08:46:08 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C8k8q7020231; Mon, 12 Sep 2005 08:46:08 GMT (envelope-from phk) Message-Id: <200509120846.j8C8k8q7020231@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 12 Sep 2005 08:46:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys vnode.h src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 08:46:09 -0000 phk 2005-09-12 08:46:08 UTC FreeBSD src repository Modified files: sys/sys vnode.h sys/kern vfs_subr.c Log: Introduce vfs_read_dirent() which can help VOP_READDIR() implementations by handling all the cookie stuff. Revision Changes Path 1.644 +27 -0 src/sys/kern/vfs_subr.c 1.307 +2 -0 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 09:16:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6453416A41F; Mon, 12 Sep 2005 09:16:01 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2D8B43D48; Mon, 12 Sep 2005 09:16:00 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 3505746B08; Mon, 12 Sep 2005 05:16:00 -0400 (EDT) Date: Mon, 12 Sep 2005 10:16:00 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: David O'Brien In-Reply-To: <20050912013616.GA78451@dragon.NUXI.org> Message-ID: <20050912094446.P33344@fledge.watson.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 09:16:01 -0000 On Sun, 11 Sep 2005, David O'Brien wrote: > On Sun, Sep 11, 2005 at 10:29:16PM +0100, Robert Watson wrote: >> On Wed, 7 Sep 2005, David E. O'Brien wrote: >>> Modified files: >>> sys/kern kern_tc.c >>> sys/net rtsock.c >>> sys/netipx ipx_proto.c >>> sys/netnatm natm_proto.c >>> Log: >>> Forward declaring static variables as extern is invalid ISO-C. Now that >>> GCC can properly handle forward static declarations, do this properly. >> >> As a result of this change, it is no longer possible to build 7.x kernels >> on 6.x worlds without building all of world or tweaking kernel makefiles. > > We do not support building a HEAD kernel on a RELENG_ box. Never have. > That it usually works for you is just gravy. Or, an alternative viewpoint suggests that the fact that it works for me is what makes it possible to develop on a dozen branches at a time, rather than constantly stumbling over build problems. I.e., I don't really care if it's supported, I just want it to work. I accept that things like C99 support won't ever reach 4.x, so 4.x is no longer a viable build platform for active development, but using the current notion of -STABLE as a build platform is very useful. And by allowing, where possible, a uniform set of build tools we greatly reduce the daily administrative overhead for developers. Breakage can't be avoided if we have progress, but it can be minimized. It's a lot easier for me if you can tell me "Update your build box to the latest RELENG_6" than "As of today, for a relatively minor syntax tweak in the compiler in HEAD but not STABLE, you need to maintain separate build chains for all your development trees". See below for details. > Building a HEAD kernel on RELENG_ isn't anywhere near a supported > configuration. I really don't know where you got the idea it was. On a > 6.0-beta2 machine I just did a HEAD 'make kernel-toolchain' - it took > 3m53.49s and allowed me to build a HEAD kernel just fine. Supposing for a moment that I didn't work for a large CPU manafacturor, but instead had a moderately well-configured desktop system, and that instead of having one source tree I worked on, I were a kernel developer who had 12 active development branches with various kernels, then the math settles out a little differently. On my desktop (P4 1.8GHz, 512MB), it takes 15 minutes per kernel tools build, which assuming I built them on the three machines sequentially, would result in spending 9 hours rebuilding kernel tools as a result of introducing dependencies on compiler tweaks before merging them. In practice, I would hopefully parallelize the builds across all the machines once I discovered that my feet had been shot at, meaning no less than three hours per machine. However, I now also have the following additional administrative hassles: I have to separately manage a build chain source tree for each branch, rather than just a kernel source tree, I have to fault the changes in, trip over build problems, and so on. Which means I also need to decide what components I will need in order to rebuild the kernel toolchains, which presumably means managing the merging of parts of share, src/gnu, the top of tree Makefiles, and countless other things. So the difference between it working may be gravy to you, but it's the difference between spending several days of my FreeBSD time chasing build tool changes over a dozen branches and several machines and spending those days doing productive work. Which isn't to say that progress shouldn't happen, just that a minor change in the order of commits would have saved me a lot of time. >> In the future, could you merge the gcc fixes to the relevant branches >> before merging the dependent C changes, in order to avoid this sort of >> thing? > > I'm afraid that is unreasonable to do in this case. I'd be waiting an > undetermined amount of time for RELENG_6 to thaw before I could do this > work. HEAD was already frozen for 1 months this year - you're > effectively asking me to work as if is frozen for an additional 2 > months. On top of that - the "relevant branches" is HEAD and only HEAD. > Which is where the GCC fixes were committed before depending on them. Just because you don't know how to request MFC's from the release engineering team, which typically has a turn around time of less than a day, doesn't mean I shouldn't expect you to know how to do it :-). > Note that I did the RELENG_5 MFC for you personally, knowing you do try > to build HEAD kernels on RELENG_*. I would have MFC'ed to RELENG_6 for > your benefit, but its frozen. You are an RE - please feel free to MFC > the bug fix. I certainly would not mind. :-) In case you missed it over the last few years, as a developer you are not helpless in supporting the release engineering team by ordering your commits usefully and participating in the MFC process rather than spouting "Let the RE team take care of it". Right now, the expectation is that developers will drive the merging of their commits because they are most familiar with the need to merge the changes, how long the changes will take to settle out, and so on. This is also much preferable to later recriminations of "I didn't want that change merged!". I agree we don't want our end users to build using old toolchains, and therefore don't want to support it, and that it won't always be possible to make it work (i.e., major gcc upgrade in HEAD that doesn't make it to STABLE for two years due to a delayed 5.x release cycle), but when it's trivial to make it work and saves everyone a lot of trouble, it seems like it would be worth it. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Mon Sep 12 09:19:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3C6C16A41F; Mon, 12 Sep 2005 09:19:26 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B219843D48; Mon, 12 Sep 2005 09:19:26 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C9JQCx028620; Mon, 12 Sep 2005 09:19:26 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C9JQqn028619; Mon, 12 Sep 2005 09:19:26 GMT (envelope-from rwatson) Message-Id: <200509120919.j8C9JQqn028619@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 09:19:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/sys umask.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 09:19:27 -0000 rwatson 2005-09-12 09:19:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/sys umask.2 Log: Merge umask.2:1.13 from HEAD to RELENG_6: Add mkfifo(2) to the man page SEE ALSO list for umask(2) -- it's mentioned in the description. Approved by: re (hrs) Revision Changes Path 1.12.8.1 +1 -0 src/lib/libc/sys/umask.2 From owner-cvs-src@FreeBSD.ORG Mon Sep 12 09:24:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A699016A41F; Mon, 12 Sep 2005 09:24:33 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0742643D49; Mon, 12 Sep 2005 09:24:32 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5C6C6.dip.t-dialin.net [84.165.198.198]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id j8C9DCck055895; Mon, 12 Sep 2005 11:13:25 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id j8C9Ni2j023063; Mon, 12 Sep 2005 11:23:44 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by netchild.homeip.net (Horde MIME library) with HTTP; Mon, 12 Sep 2005 11:23:43 +0200 Message-ID: <20050912112343.48wtxw8ys44044so@netchild.homeip.net> X-Priority: 3 (Normal) Date: Mon, 12 Sep 2005 11:23:43 +0200 From: Alexander Leidinger To: Warner Losh References: <200509120412.j8C4CorF001971@repoman.freebsd.org> In-Reply-To: <200509120412.j8C4CorF001971@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 09:24:33 -0000 Warner Losh wrote: > imp 2005-09-12 04:12:50 UTC > > FreeBSD src repository > > Modified files: > sys/dev/sound/isa mss.c > Log: > Since opti_detect is now only called on !PC98 machines, only declare > and define there as well. This should fix the pc98 tinderbox. Thank you. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 I try not to break the rules but merely to test their elasticity. -- Bill Veeck From owner-cvs-src@FreeBSD.ORG Mon Sep 12 09:42:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A26816A41F; Mon, 12 Sep 2005 09:42:30 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB43743D46; Mon, 12 Sep 2005 09:42:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8C9gTn3030202; Mon, 12 Sep 2005 09:42:29 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8C9gTmQ030201; Mon, 12 Sep 2005 09:42:29 GMT (envelope-from rwatson) Message-Id: <200509120942.j8C9gTmQ030201@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 09:42:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_io Makefile fifo_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 09:42:30 -0000 rwatson 2005-09-12 09:42:29 UTC FreeBSD src repository Added files: tools/regression/fifo/fifo_io Makefile fifo_io.c Log: Add fifo_io, a regression test for I/O operations on POSIX fifos. We currently can't pass this regression test due to broken poll() and select() support for fifos, but past the basic I/O operation tests. Revision Changes Path 1.1 +7 -0 src/tools/regression/fifo/fifo_io/Makefile (new) 1.1 +1252 -0 src/tools/regression/fifo/fifo_io/fifo_io.c (new) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 09:58:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74A5D16A41F; Mon, 12 Sep 2005 09:58:45 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd2mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13B2F43D49; Mon, 12 Sep 2005 09:58:44 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr8so.prod.shaw.ca (pd4mr8so-qfe3.prod.shaw.ca [10.0.141.101]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IMP00F6H7PVVZ40@l-daemon>; Mon, 12 Sep 2005 03:58:43 -0600 (MDT) Received: from pn2ml10so.prod.shaw.ca ([10.0.121.80]) by pd4mr8so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IMP00BTJ7PV8R40@pd4mr8so.prod.shaw.ca>; Mon, 12 Sep 2005 03:58:43 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0IMP0070K7PVZE@l-daemon>; Mon, 12 Sep 2005 03:58:43 -0600 (MDT) Date: Mon, 12 Sep 2005 02:58:42 -0700 From: Colin Percival In-reply-to: <200509110310.36423@harrymail> To: Emanuel Strobl Message-id: <43255152.3000609@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.92.0.0 References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050724) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 09:58:45 -0000 Emanuel Strobl wrote: > Hmm, why was default size of root changed to 500M? Because I was increasing the sizes of /tmp and /var at the same time; because I know that some users do somehow manage to fill up /; and because re@ told me to. :-) I still have a 128MB / on most of my systems. > Incredable much too much > IMHO, if not reserved for debug kernels.... > I've just been wondering today how wasteful FreeBSD uses the hard disk > these days (BETA4)... You'll only get a 500MB / if you have more than 10GB of space on your hard disk. I don't think that going from 2.5% of the disk up to 5% of the disk is problematically wasteful, particularly since we're only talking about the _default_ value and it's very easy to change in sysinstall. Colin Percival From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:05:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F1EF16A41F; Mon, 12 Sep 2005 10:05:09 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F6E743D48; Mon, 12 Sep 2005 10:05:09 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CA59Di031033; Mon, 12 Sep 2005 10:05:09 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CA58J4031032; Mon, 12 Sep 2005 10:05:08 GMT (envelope-from rwatson) Message-Id: <200509121005.j8CA58J4031032@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 10:05:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:05:09 -0000 rwatson 2005-09-12 10:05:08 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Rather than reaching into the internals of the UNIX domain socket code by calling uipc_connect2() to connect two socket endpoints to create a fifo, call soconnect2(). MFC after: 3 days Revision Changes Path 1.114 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:06:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DC1216A41F; Mon, 12 Sep 2005 10:06:38 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BBC443D46; Mon, 12 Sep 2005 10:06:38 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CA6cIi031178; Mon, 12 Sep 2005 10:06:38 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CA6cvr031177; Mon, 12 Sep 2005 10:06:38 GMT (envelope-from rwatson) Message-Id: <200509121006.j8CA6cvr031177@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 10:06:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:06:38 -0000 rwatson 2005-09-12 10:06:38 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Add an assertion that fifo_open() doesn't race against other threads while sleeping to allocate fifo state: due to using the vnode lock to serialize access to a fifo during open, it shouldn't happen (tm). MFC after: 3 days Revision Changes Path 1.115 +2 -0 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:07:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FFE216A41F; Mon, 12 Sep 2005 10:07:22 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F79843D45; Mon, 12 Sep 2005 10:07:22 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CA7Mfx031220; Mon, 12 Sep 2005 10:07:22 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CA7MWf031219; Mon, 12 Sep 2005 10:07:22 GMT (envelope-from rwatson) Message-Id: <200509121007.j8CA7MWf031219@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 10:07:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:07:22 -0000 rwatson 2005-09-12 10:07:22 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: When a writer opens a fifo, wake up the read socket for read, not the write socket. MFC after: 3 days Revision Changes Path 1.116 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:13:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12ED216A41F; Mon, 12 Sep 2005 10:13:16 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2ABF43D45; Mon, 12 Sep 2005 10:13:15 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CADFx0031482; Mon, 12 Sep 2005 10:13:15 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CADF1h031481; Mon, 12 Sep 2005 10:13:15 GMT (envelope-from rwatson) Message-Id: <200509121013.j8CADF1h031481@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 10:13:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:13:16 -0000 rwatson 2005-09-12 10:13:15 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: After going to some trouble to identify only the write-related events to poll the write socket for, the fifo polling code proceeded to poll for the complete set of events. Use 'levents' instead of 'events' as the argument to poll, and only poll the write socket if there is interest in write events. MFC after: 3 days Revision Changes Path 1.117 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:16:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B82CE16A420; Mon, 12 Sep 2005 10:16:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73DFA43D45; Mon, 12 Sep 2005 10:16:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CAGIRU031742; Mon, 12 Sep 2005 10:16:18 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CAGIBp031741; Mon, 12 Sep 2005 10:16:18 GMT (envelope-from rwatson) Message-Id: <200509121016.j8CAGIBp031741@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 10:16:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:16:18 -0000 rwatson 2005-09-12 10:16:18 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Only poll the fifo for read events if the fifo is attached to a readable file descriptor. Otherwise, the read end of a fifo might return that it is writable (which it isn't). Only poll the fifo for write events if the fifo attached to a writable file descriptor. Otherwise, the write end of a fifo might return that it is readable (which it isn't). In the event that a file is FREAD|FWRITE (which is allowed by POSIX, but has undefined behavior), we poll for both. MFC after: 3 days Revision Changes Path 1.118 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 10:22:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9531716A41F; Mon, 12 Sep 2005 10:22:54 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5410A43D45; Mon, 12 Sep 2005 10:22:54 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CAMsY0032475; Mon, 12 Sep 2005 10:22:54 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CAMsus032474; Mon, 12 Sep 2005 10:22:54 GMT (envelope-from scottl) Message-Id: <200509121022.j8CAMsus032474@repoman.freebsd.org> From: Scott Long Date: Mon, 12 Sep 2005 10:22:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/gcc c-decl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 10:22:54 -0000 scottl 2005-09-12 10:22:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/gcc c-decl.c Log: MFC rev 1.13 of c-decl.c. A nice side effect is that it's once again possible to compile a HEAD kernel in a RELENG_6 world via the normal shortcuts. Approved by: re Revision Changes Path 1.12.2.1 +5 -2 src/contrib/gcc/c-decl.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 11:20:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63E5616A41F; Mon, 12 Sep 2005 11:20:08 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20E7F43D45; Mon, 12 Sep 2005 11:20:08 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CBK7r5035090; Mon, 12 Sep 2005 11:20:08 GMT (envelope-from brian@repoman.freebsd.org) Received: (from brian@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CBK7Oh035089; Mon, 12 Sep 2005 11:20:07 GMT (envelope-from brian) Message-Id: <200509121120.j8CBK7Oh035089@repoman.freebsd.org> From: Brian Somers Date: Mon, 12 Sep 2005 11:20:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ppp README.devel X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 11:20:08 -0000 brian 2005-09-12 11:20:07 UTC FreeBSD src repository Removed files: usr.sbin/ppp README.devel Log: Remove this file as it's mostly out of date. Up-to-date info such as the program's origin is already in the man page. Update requested by: Xavier Venient & Jason McIntyre Revision Changes Path 1.8 +0 -49 src/usr.sbin/ppp/README.devel (dead) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 11:25:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B302616A41F; Mon, 12 Sep 2005 11:25:17 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8515A43D48; Mon, 12 Sep 2005 11:25:17 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CBPHV8035411; Mon, 12 Sep 2005 11:25:17 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CBPHQm035410; Mon, 12 Sep 2005 11:25:17 GMT (envelope-from mlaier) Message-Id: <200509121125.j8CBPHQm035410@repoman.freebsd.org> From: Max Laier Date: Mon, 12 Sep 2005 11:25:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/contrib/pf/net pf.c pf_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 11:25:17 -0000 mlaier 2005-09-12 11:25:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/contrib/pf/net pf.c pf_ioctl.c Log: Commit imported changes to RELENG_6: pf_ioctl.c Revision 1.153 Sun Aug 7 11:37:33 2005 UTC by dhartmei | verify ticket in DIOCADDADDR, from Boris Polevoy, ok deraadt@ pf_ioctl.c Revision 1.158 Mon Sep 5 14:51:08 2005 UTC by dhartmei | in DIOCCHANGERULE, properly initialize table, if used in NAT rule. | from Boris Polevoy , ok mcbride@ pf.c Revision 1.502 Mon Aug 22 11:54:25 2005 UTC by dhartmei | when nat'ing icmp 'connections', replace icmp id with proxy values | (similar to proxy ports for tcp/udp). not all clients use | per-invokation random ids, this allows multiple concurrent | connections from such clients. | thanks for testing to Rod Whitworth, "looks ok" markus@ pf.c Revision 1.501 Mon Aug 22 09:48:05 2005 UTC by dhartmei | fix rdr to bitmask replacement address pool. patch from Max Laier, | reported by Boris Polevoy, tested by Jean Debogue, ok henning@ Approved by: re (scottl) Revision Changes Path 1.34.2.2 +61 -21 src/sys/contrib/pf/net/pf.c 1.20.2.1 +7 -0 src/sys/contrib/pf/net/pf_ioctl.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 11:43:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08D8A16A420; Mon, 12 Sep 2005 11:43:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 876DC43D46; Mon, 12 Sep 2005 11:43:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CBhpbB036205; Mon, 12 Sep 2005 11:43:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CBhpnt036204; Mon, 12 Sep 2005 11:43:51 GMT (envelope-from rwatson) Message-Id: <200509121143.j8CBhpnt036204@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 11:43:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_io fifo_io.c src/tools/regression/fifo/fifo_open fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 11:43:54 -0000 rwatson 2005-09-12 11:43:51 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_io fifo_io.c tools/regression/fifo/fifo_open fifo_open.c Log: Use different temporary directory templates for fifo_io and fifo_open so that if the tests fail to GC their working spaces, it's clear which it is. Revision Changes Path 1.2 +1 -1 src/tools/regression/fifo/fifo_io/fifo_io.c 1.3 +1 -1 src/tools/regression/fifo/fifo_open/fifo_open.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 11:58:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C7A016A41F; Mon, 12 Sep 2005 11:58:16 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED28943D46; Mon, 12 Sep 2005 11:58:15 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CBwFqY036688; Mon, 12 Sep 2005 11:58:15 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CBwFXr036687; Mon, 12 Sep 2005 11:58:15 GMT (envelope-from rwatson) Message-Id: <200509121158.j8CBwFXr036687@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 11:58:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_misc Makefile fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 11:58:16 -0000 rwatson 2005-09-12 11:58:14 UTC FreeBSD src repository Added files: tools/regression/fifo/fifo_misc Makefile fifo_misc.c Log: Add fifo_misc, a regression test to hold misc. functional tests for fifos that don't obviously fit into create, open, and io. For now, add only a regression test to make sure that lseek() fails with ESPIPE (which it doesn't). Revision Changes Path 1.1 +7 -0 src/tools/regression/fifo/fifo_misc/Makefile (new) 1.1 +140 -0 src/tools/regression/fifo/fifo_misc/fifo_misc.c (new) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 12:15:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 848D616A41F; Mon, 12 Sep 2005 12:15:14 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42F4F43D45; Mon, 12 Sep 2005 12:15:14 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CCFEta037366; Mon, 12 Sep 2005 12:15:14 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CCFEH8037361; Mon, 12 Sep 2005 12:15:14 GMT (envelope-from rwatson) Message-Id: <200509121215.j8CCFEH8037361@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 12:15:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 12:15:14 -0000 rwatson 2005-09-12 12:15:12 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Remove DFLAG_SEEKABLE from fifo file descriptors: fifos are not seekable according to POSIX, not to mention the fact that it doesn't make sense (and hence isn't really implemented). This causes the fifo_misc regression test to succeed. Revision Changes Path 1.119 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 12:16:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91EF416A41F; Mon, 12 Sep 2005 12:16:12 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2057743D45; Mon, 12 Sep 2005 12:16:12 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 39E3346BB7; Mon, 12 Sep 2005 08:16:11 -0400 (EDT) Date: Mon, 12 Sep 2005 13:16:11 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200509121215.j8CCFEH8037361@repoman.freebsd.org> Message-ID: <20050912131556.Y89155@fledge.watson.org> References: <200509121215.j8CCFEH8037361@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: Re: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 12:16:12 -0000 On Mon, 12 Sep 2005, Robert Watson wrote: > rwatson 2005-09-12 12:15:12 UTC > > FreeBSD src repository > > Modified files: > sys/fs/fifofs fifo_vnops.c > Log: > Remove DFLAG_SEEKABLE from fifo file descriptors: fifos are not seekable > according to POSIX, not to mention the fact that it doesn't make sense > (and hence isn't really implemented). This causes the fifo_misc > regression test to succeed. > > Revision Changes Path > 1.119 +1 -1 src/sys/fs/fifofs/fifo_vnops.c MFC after: 3 days Robert N M Watson From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:31:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B84D516A41F; Mon, 12 Sep 2005 13:31:33 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7851343D45; Mon, 12 Sep 2005 13:31:33 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDVX69049695; Mon, 12 Sep 2005 13:31:33 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDVXx2049694; Mon, 12 Sep 2005 13:31:33 GMT (envelope-from kensmith) Message-Id: <200509121331.j8CDVXx2049694@repoman.freebsd.org> From: Ken Smith Date: Mon, 12 Sep 2005 13:31:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/examples/cvsup stable-supfile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:31:33 -0000 kensmith 2005-09-12 13:31:33 UTC FreeBSD src repository Modified files: share/examples/cvsup stable-supfile Log: Update for RELENG_6. Pointed out by: Many on current@. MFC after: 1 day Revision Changes Path 1.30 +4 -3 src/share/examples/cvsup/stable-supfile From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:37:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A414F16A41F; Mon, 12 Sep 2005 13:37:56 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61FA043D46; Mon, 12 Sep 2005 13:37:56 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDbu04049980; Mon, 12 Sep 2005 13:37:56 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDbuqN049979; Mon, 12 Sep 2005 13:37:56 GMT (envelope-from glebius) Message-Id: <200509121337.j8CDbuqN049979@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 13:37:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet ip_carp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:37:56 -0000 glebius 2005-09-12 13:37:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet ip_carp.c Log: MFC 1.31: When a carp(4) interface is being destroyed and is in a promiscous mode, first interface is detached from parent and then bpfdetach() is called. If the interface was the last carp(4) interface attached to parent, then the mutex on parent is destroyed. When bpfdetach() calls if_setflags() we panic on destroyed mutex. To prevent the above scenario, clear pointer to parent, when we detach ourselves from parent. Approved by: re (kensmith) Revision Changes Path 1.27.2.2 +1 -0 src/sys/netinet/ip_carp.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:38:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE44B16A41F; Mon, 12 Sep 2005 13:38:36 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38E6843D45; Mon, 12 Sep 2005 13:38:36 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDcaG5050031; Mon, 12 Sep 2005 13:38:36 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDcahR050030; Mon, 12 Sep 2005 13:38:36 GMT (envelope-from glebius) Message-Id: <200509121338.j8CDcahR050030@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 13:38:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/netinet ip_carp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:38:36 -0000 glebius 2005-09-12 13:38:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netinet ip_carp.c Log: MFC 1.31: When a carp(4) interface is being destroyed and is in a promiscous mode, first interface is detached from parent and then bpfdetach() is called. If the interface was the last carp(4) interface attached to parent, then the mutex on parent is destroyed. When bpfdetach() calls if_setflags() we panic on destroyed mutex. To prevent the above scenario, clear pointer to parent, when we detach ourselves from parent. Revision Changes Path 1.21.2.5 +1 -0 src/sys/netinet/ip_carp.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:39:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A482E16A41F; Mon, 12 Sep 2005 13:39:52 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 225FA43D6B; Mon, 12 Sep 2005 13:39:47 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDdlmV050114; Mon, 12 Sep 2005 13:39:47 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDdli6050113; Mon, 12 Sep 2005 13:39:47 GMT (envelope-from glebius) Message-Id: <200509121339.j8CDdli6050113@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 13:39:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sys ktr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:39:52 -0000 glebius 2005-09-12 13:39:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sys ktr.h Log: MFC 1.33: Change default KTR_COMPILE from KTR_GEN to KTR_ALL, to match with manual page. Reviewed by: jhb, pjd Approved by: re (kensmith) Revision Changes Path 1.32.2.1 +1 -1 src/sys/sys/ktr.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:40:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ED3E16A41F; Mon, 12 Sep 2005 13:40:12 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 619A943D45; Mon, 12 Sep 2005 13:40:11 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDeB1H050157; Mon, 12 Sep 2005 13:40:11 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDeB5l050156; Mon, 12 Sep 2005 13:40:11 GMT (envelope-from nyan) Message-Id: <200509121340.j8CDeB5l050156@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 12 Sep 2005 13:40:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/isa mss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:40:12 -0000 nyan 2005-09-12 13:40:11 UTC FreeBSD src repository Modified files: sys/dev/sound/isa mss.c Log: more #ifndef PC98. This really fix the pc98 tinderbox. Revision Changes Path 1.102 +4 -0 src/sys/dev/sound/isa/mss.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:43:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4F1216A41F; Mon, 12 Sep 2005 13:43:34 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1A9F43D45; Mon, 12 Sep 2005 13:43:34 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDhYcM050501; Mon, 12 Sep 2005 13:43:34 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDhYqe050500; Mon, 12 Sep 2005 13:43:34 GMT (envelope-from glebius) Message-Id: <200509121343.j8CDhYqe050500@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 13:43:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man9 timeout.9 src/sys/kern kern_timeout.c src/sys/sys callout.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:43:35 -0000 glebius 2005-09-12 13:43:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man9 timeout.9 sys/kern kern_timeout.c sys/sys callout.h Log: MFC: Make callout_reset() return a non-zero value if a pending callout was rescheduled. If there was no pending callout, then return 0. Reviewed by: iedowse, cperciva Approved by: re (kensmith) Revision Changes Path 1.28.2.1 +7 -5 src/share/man/man9/timeout.9 1.97.2.1 +8 -3 src/sys/kern/kern_timeout.c 1.28.2.1 +1 -1 src/sys/sys/callout.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:46:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C179C16A41F; Mon, 12 Sep 2005 13:46:32 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A95C43D46; Mon, 12 Sep 2005 13:46:32 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDkWq6050768; Mon, 12 Sep 2005 13:46:32 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDkWPC050767; Mon, 12 Sep 2005 13:46:32 GMT (envelope-from stefanf) Message-Id: <200509121346.j8CDkWPC050767@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 13:46:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/include libc_private.h src/lib/libc/stdio local.h makebuf.c src/lib/libc/stdlib abort.c exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:46:32 -0000 stefanf 2005-09-12 13:46:32 UTC FreeBSD src repository Modified files: lib/libc/include libc_private.h lib/libc/stdio local.h makebuf.c lib/libc/stdlib abort.c exit.c Log: Move the declaration of __cleanup to libc_private.h as it is used in both stdio/ and stdlib/. Don't define __cleanup twice. Revision Changes Path 1.13 +5 -0 src/lib/libc/include/libc_private.h 1.27 +0 -1 src/lib/libc/stdio/local.h 1.5 +3 -1 src/lib/libc/stdio/makebuf.c 1.10 +1 -1 src/lib/libc/stdlib/abort.c 1.8 +3 -1 src/lib/libc/stdlib/exit.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 13:50:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A8B416A41F; Mon, 12 Sep 2005 13:50:57 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1434443D48; Mon, 12 Sep 2005 13:50:57 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CDouVR050937; Mon, 12 Sep 2005 13:50:56 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CDou99050936; Mon, 12 Sep 2005 13:50:56 GMT (envelope-from nyan) Message-Id: <200509121350.j8CDou99050936@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 12 Sep 2005 13:50:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 13:50:57 -0000 nyan 2005-09-12 13:50:56 UTC FreeBSD src repository Modified files: sys/i386/i386 vm_machdep.c Log: opt_pc98.h is not needed. Revision Changes Path 1.260 +0 -3 src/sys/i386/i386/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 14:11:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F04B16A41F; Mon, 12 Sep 2005 14:11:11 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E66B43D45; Mon, 12 Sep 2005 14:11:11 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CEBB8A051779; Mon, 12 Sep 2005 14:11:11 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CEBBpI051778; Mon, 12 Sep 2005 14:11:11 GMT (envelope-from glebius) Message-Id: <200509121411.j8CEBBpI051778@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 14:11:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 14:11:11 -0000 glebius 2005-09-12 14:11:11 UTC FreeBSD src repository Modified files: sys/netgraph ng_socket.c Log: When message can't fit into socket receive buffer return ENOBUFS to userland program instead of letting it wait until end of days. PR: kern/85907 Revision Changes Path 1.69 +3 -2 src/sys/netgraph/ng_socket.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 14:12:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F1E316A41F; Mon, 12 Sep 2005 14:12:10 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C48A43D46; Mon, 12 Sep 2005 14:12:10 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CECADs051834; Mon, 12 Sep 2005 14:12:10 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CECAIs051833; Mon, 12 Sep 2005 14:12:10 GMT (envelope-from maxim) Message-Id: <200509121412.j8CECAIs051833@repoman.freebsd.org> From: Maxim Konovalov Date: Mon, 12 Sep 2005 14:12:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sockets/shutdown Makefile shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 14:12:10 -0000 maxim 2005-09-12 14:12:10 UTC FreeBSD src repository Added files: tools/regression/sockets/shutdown Makefile shutdown.c Log: o Add shutdown(2) regression tests. At the moment we cannot pass shutdown-on-non connected socket test, kern/84761. Revision Changes Path 1.1 +9 -0 src/tools/regression/sockets/shutdown/Makefile (new) 1.1 +115 -0 src/tools/regression/sockets/shutdown/shutdown.c (new) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 14:31:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FC7716A420; Mon, 12 Sep 2005 14:31:49 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4291B43D48; Mon, 12 Sep 2005 14:31:49 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CEVnij052773; Mon, 12 Sep 2005 14:31:49 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CEVn3w052772; Mon, 12 Sep 2005 14:31:49 GMT (envelope-from le) Message-Id: <200509121431.j8CEVn3w052772@repoman.freebsd.org> From: Lukas Ertl Date: Mon, 12 Sep 2005 14:31:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/gvinum gvinum.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 14:31:49 -0000 le 2005-09-12 14:31:49 UTC FreeBSD src repository Modified files: sbin/gvinum gvinum.c Log: Clean up. Remove unused functions. Reduce indentation level by reverting the logic of the enclosing conditional statement. Revision Changes Path 1.5 +104 -196 src/sbin/gvinum/gvinum.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 14:46:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA16216A41F; Mon, 12 Sep 2005 14:46:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A822643D48; Mon, 12 Sep 2005 14:46:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CEkJfv053524; Mon, 12 Sep 2005 14:46:19 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CEkJlq053523; Mon, 12 Sep 2005 14:46:19 GMT (envelope-from glebius) Message-Id: <200509121446.j8CEkJlq053523@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 12 Sep 2005 14:46:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 14:46:20 -0000 glebius 2005-09-12 14:46:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_base.c Log: MFC 1.112: Fix an item leak, that happens when some node calls ng_callout() two times consequently, without checking whether callout has been serviced or not. (ng_pptpgre and ng_ppp were catched in this behavior). - In ng_callout() save old item before calling callout_reset(). If the latter has returned 1, then free this item. - In ng_uncallout() clear c->c_arg. Problem reported by: Alexandre Kardanev Approved by: re (kensmith) Revision Changes Path 1.102.2.5 +6 -2 src/sys/netgraph/ng_base.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 14:46:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06F5E16A41F; Mon, 12 Sep 2005 14:46:56 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74CEF43D49; Mon, 12 Sep 2005 14:46:55 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CEktPQ053565; Mon, 12 Sep 2005 14:46:55 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CEktoO053564; Mon, 12 Sep 2005 14:46:55 GMT (envelope-from mlaier) Message-Id: <200509121446.j8CEktoO053564@repoman.freebsd.org> From: Max Laier Date: Mon, 12 Sep 2005 14:46:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/contrib/pf/net pf_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 14:46:56 -0000 mlaier 2005-09-12 14:46:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/contrib/pf/net pf_ioctl.c Log: Commit imported changes to RELENG_5: pf_ioctl.c Revision 1.153 Sun Aug 7 11:37:33 2005 UTC by dhartmei | verify ticket in DIOCADDADDR, from Boris Polevoy, ok deraadt@ pf_ioctl.c Revision 1.158 Mon Sep 5 14:51:08 2005 UTC by dhartmei | in DIOCCHANGERULE, properly initialize table, if used in NAT rule. | from Boris Polevoy , ok mcbride@ Revision Changes Path 1.12.2.7 +7 -0 src/sys/contrib/pf/net/pf_ioctl.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:31:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A8B216A41F; Mon, 12 Sep 2005 15:31:29 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E414843D4C; Mon, 12 Sep 2005 15:31:28 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFVSHq055318; Mon, 12 Sep 2005 15:31:28 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFVSxj055317; Mon, 12 Sep 2005 15:31:28 GMT (envelope-from jkim) Message-Id: <200509121531.j8CFVSxj055317@repoman.freebsd.org> From: Jung-uk Kim Date: Mon, 12 Sep 2005 15:31:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:31:29 -0000 jkim 2005-09-12 15:31:28 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: use monotonic `time_uptime' instead of `time_second' Approved by: anholt (mentor) Discussed on: arch Revision Changes Path 1.645 +4 -4 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:53:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58D6516A41F; Mon, 12 Sep 2005 15:53:29 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F335B43D48; Mon, 12 Sep 2005 15:53:28 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFrSHv056425; Mon, 12 Sep 2005 15:53:28 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFrSVM056424; Mon, 12 Sep 2005 15:53:28 GMT (envelope-from stefanf) Message-Id: <200509121553.j8CFrSVM056424@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 15:53:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include resolv.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:53:29 -0000 stefanf 2005-09-12 15:53:28 UTC FreeBSD src repository Modified files: include resolv.h Log: Don't declare ___res_ext() twice. Revision Changes Path 1.27 +1 -2 src/include/resolv.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:53:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1525616A41F; Mon, 12 Sep 2005 15:53:59 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C889A43D48; Mon, 12 Sep 2005 15:53:58 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFrwjp056475; Mon, 12 Sep 2005 15:53:58 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFrw8E056474; Mon, 12 Sep 2005 15:53:58 GMT (envelope-from tegge) Message-Id: <200509121553.j8CFrw8E056474@repoman.freebsd.org> From: Tor Egge Date: Mon, 12 Sep 2005 15:53:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_hash.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:53:59 -0000 tegge 2005-09-12 15:53:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_hash.c Log: MFC: Don't retry when vget() returns ENOENT in the nonblocking case due to the vnode being doomed. It causes a livelock. Approved by: re (scottl) Revision Changes Path 1.9.2.1 +2 -2 src/sys/kern/vfs_hash.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:55:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F166016A41F; Mon, 12 Sep 2005 15:55:44 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B04D43D64; Mon, 12 Sep 2005 15:55:44 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFti6r056594; Mon, 12 Sep 2005 15:55:44 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFtiH2056593; Mon, 12 Sep 2005 15:55:44 GMT (envelope-from jkoshy) Message-Id: <200509121555.j8CFtiH2056593@repoman.freebsd.org> From: Joseph Koshy Date: Mon, 12 Sep 2005 15:55:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/hwpmc hwpmc_amd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:55:45 -0000 jkoshy 2005-09-12 15:55:44 UTC FreeBSD src repository Modified files: sys/dev/hwpmc hwpmc_amd.c Log: Process one NMI interrupt per handler invocation as the processor 'buffers' pending NMIs from multiple interrupting PMCs and delivers them serially. Reported by: Olivier Crameri MFC after: 3 days Revision Changes Path 1.12 +9 -4 src/sys/dev/hwpmc/hwpmc_amd.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:56:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DEC216A41F; Mon, 12 Sep 2005 15:56:07 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DA2F43D45; Mon, 12 Sep 2005 15:56:07 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFu756056627; Mon, 12 Sep 2005 15:56:07 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFu7So056626; Mon, 12 Sep 2005 15:56:07 GMT (envelope-from tegge) Message-Id: <200509121556.j8CFu7So056626@repoman.freebsd.org> From: Tor Egge Date: Mon, 12 Sep 2005 15:56:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_rawread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:56:07 -0000 tegge 2005-09-12 15:56:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ufs/ffs ffs_rawread.c Log: MFC: Giant is no longer needed here. Approved by: re (scottl) Revision Changes Path 1.25.2.1 +0 -3 src/sys/ufs/ffs/ffs_rawread.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:58:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DAA316A41F; Mon, 12 Sep 2005 15:58:17 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C7D443D5C; Mon, 12 Sep 2005 15:58:15 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CFwFHH056728; Mon, 12 Sep 2005 15:58:15 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CFwFVb056727; Mon, 12 Sep 2005 15:58:15 GMT (envelope-from stefanf) Message-Id: <200509121558.j8CFwFVb056727@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 15:58:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include stdlib.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:58:17 -0000 stefanf 2005-09-12 15:58:15 UTC FreeBSD src repository Modified files: include stdlib.h Log: Fix the prototypes for devname() and devname_r(), the first two argument types are supposed to be dev_t and mode_t (prefixed with __ due to namespace reasons). Revision Changes Path 1.58 +2 -2 src/include/stdlib.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 15:58:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E226A16A41F; Mon, 12 Sep 2005 15:58:30 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54C4F43D49; Mon, 12 Sep 2005 15:58:30 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-185-177.dsl.snfc21.pacbell.net [64.171.185.177]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8CFwWo5011911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 12 Sep 2005 08:58:33 -0700 Message-ID: <4325A5A1.8080804@root.org> Date: Mon, 12 Sep 2005 08:58:25 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> <20050911215807.GA96773@xor.obsecurity.org> In-Reply-To: <20050911215807.GA96773@xor.obsecurity.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Doug Barton , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, "David E. O'Brien" , Garance A Drosihn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 15:58:31 -0000 Kris Kennaway wrote: > On Sun, Sep 11, 2005 at 02:47:27PM -0700, Nate Lawson wrote: > >>Doug Barton wrote: >> >>>Kris Kennaway wrote: >>> >>> >>> >>>>Likewise, I also find this change very useful. When I'm juggling a >>>>few dozen panics on a few dozen machines with a few dozen different >>>>customized source trees, it's hard to keep track of all the >>>>kernel.debugs. Now I don't have to. >>>> >>>>Also, now we won't have to throw away panic reports from users who >>>>didn't think to save their kernel.debug, and the quality of bug >>>>reports can increase. >>> >>> >>>I agree with Kris and David here, FWIW. >>> >>>Doug >> >>Can we put it somewhere other than /? /var/run/kernel? > > > Why? That would use up even more space, in total. Huh? I mean kernel, *.ko -> /boot/kernel and kernel.debug (or kernel.sym once that's fixed) -> /var/crash/kernel/kernel.debug I guess that duplicates a few megs but it keeps / from overflowing as before. Typically /var or /usr is expected to have the available space, especially since /var/crash gets coredumps (if savecore is enabled) which are much bigger than debug kernels. -- Nate From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:00:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E94016A41F; Mon, 12 Sep 2005 16:00:37 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id A16DE43D48; Mon, 12 Sep 2005 16:00:36 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (adsl-64-171-185-177.dsl.snfc21.pacbell.net [64.171.185.177]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8CG0do5011923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 12 Sep 2005 09:00:40 -0700 Message-ID: <4325A621.4040605@root.org> Date: Mon, 12 Sep 2005 09:00:33 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: obrien@FreeBSD.org References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> <20050912010034.GA77819@dragon.NUXI.org> In-Reply-To: <20050912010034.GA77819@dragon.NUXI.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:00:37 -0000 David O'Brien wrote: > On Sun, Sep 11, 2005 at 02:49:25PM -0700, Nate Lawson wrote: > >>David O'Brien wrote: >> >>>I was going to just install kernel.sym instead of a kernel with symbols, >>>but kgdb's usage doesn't claim to support '-s' as the previous kgdb did. >> >>kernel.sym would be better since it wouldn't have the duplication that >>kernel and kernel.debug have. > > > Duplication in RELENG_* or in HEAD? (see below) > >>Alternately, we can make loader(8) skip >>symbol sections when booting and just install kernel.debug > > > That *is* what my change does - except it calls it "kernel" so there > aren't loading issues. Ah, I was wrong in thinking you were installing both kernel and kernel.debug. What do you think of installing (+ bzip2?) kernel.debug in /var/crash/kernel and /var/crash/kernel.old? -- Nate From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:02:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13A0A16A41F; Mon, 12 Sep 2005 16:02:55 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BED4043D49; Mon, 12 Sep 2005 16:02:54 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CG2s9O056990; Mon, 12 Sep 2005 16:02:54 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CG2sdI056989; Mon, 12 Sep 2005 16:02:54 GMT (envelope-from stefanf) Message-Id: <200509121602.j8CG2sdI056989@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 16:02:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/regex regex2.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:02:55 -0000 stefanf 2005-09-12 16:02:54 UTC FreeBSD src repository Modified files: lib/libc/regex regex2.h Log: Use prototypes for CHIN1() and CHIN(). Revision Changes Path 1.10 +2 -6 src/lib/libc/regex/regex2.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:06:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45B5F16A41F; Mon, 12 Sep 2005 16:06:16 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBF7D43D49; Mon, 12 Sep 2005 16:06:15 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CG6FLM057302; Mon, 12 Sep 2005 16:06:15 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CG6F6B057301; Mon, 12 Sep 2005 16:06:15 GMT (envelope-from stefanf) Message-Id: <200509121606.j8CG6F6B057301@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 16:06:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/i4b/isdnd log.c src/usr.sbin/i4b/isdnmonitor main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:06:16 -0000 stefanf 2005-09-12 16:06:15 UTC FreeBSD src repository Modified files: usr.sbin/i4b/isdnd log.c usr.sbin/i4b/isdnmonitor main.c Log: Include at the top of the file. Revision Changes Path 1.10 +4 -3 src/usr.sbin/i4b/isdnd/log.c 1.9 +3 -3 src/usr.sbin/i4b/isdnmonitor/main.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:09:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4604E16A41F; Mon, 12 Sep 2005 16:09:24 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0588D43D6E; Mon, 12 Sep 2005 16:09:24 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CG9NvM057459; Mon, 12 Sep 2005 16:09:23 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CG9NnL057458; Mon, 12 Sep 2005 16:09:23 GMT (envelope-from emax) Message-Id: <200509121609.j8CG9NnL057458@repoman.freebsd.org> From: Maksim Yevmenkin Date: Mon, 12 Sep 2005 16:09:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/bluetooth/l2ping l2ping.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:09:24 -0000 emax 2005-09-12 16:09:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/bluetooth/l2ping l2ping.c Log: MFC to RELENG_6 Fix typo in usage Submitted by: Jonatan B Approved by: re (scottl) Revision Changes Path 1.6.8.1 +1 -1 src/usr.sbin/bluetooth/l2ping/l2ping.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:11:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FFCC16A41F; Mon, 12 Sep 2005 16:11:25 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D57B43D49; Mon, 12 Sep 2005 16:11:25 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CGBP9O057648; Mon, 12 Sep 2005 16:11:25 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CGBP44057647; Mon, 12 Sep 2005 16:11:25 GMT (envelope-from emax) Message-Id: <200509121611.j8CGBP44057647@repoman.freebsd.org> From: Maksim Yevmenkin Date: Mon, 12 Sep 2005 16:11:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.sbin/bluetooth/l2ping l2ping.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:11:25 -0000 emax 2005-09-12 16:11:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.sbin/bluetooth/l2ping l2ping.c Log: MFC to RELENG_5 Fix typo in usage Submitted by: Jonatan B Approved by: re (scottl) Revision Changes Path 1.6.2.1 +1 -1 src/usr.sbin/bluetooth/l2ping/l2ping.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:11:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE46016A41F; Mon, 12 Sep 2005 16:11:49 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1EC443D5F; Mon, 12 Sep 2005 16:11:48 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CGBmf9057690; Mon, 12 Sep 2005 16:11:48 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CGBmkM057689; Mon, 12 Sep 2005 16:11:48 GMT (envelope-from stefanf) Message-Id: <200509121611.j8CGBmkM057689@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 16:11:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:11:50 -0000 stefanf 2005-09-12 16:11:48 UTC FreeBSD src repository Modified files: include Makefile Log: Put a getosreldate() prototype into , getosreldate(3) implies there is one. Revision Changes Path 1.247 +1 -0 src/include/Makefile From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:16:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DA9016A41F; Mon, 12 Sep 2005 16:16:13 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BE3C43D45; Mon, 12 Sep 2005 16:16:13 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CGGCiA057936; Mon, 12 Sep 2005 16:16:12 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CGGCCM057935; Mon, 12 Sep 2005 16:16:12 GMT (envelope-from stefanf) Message-Id: <200509121616.j8CGGCCM057935@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 16:16:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/quad quad.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:16:13 -0000 stefanf 2005-09-12 16:16:12 UTC FreeBSD src repository Modified files: lib/libc/quad quad.h Log: - Add prototypes for __cmpdi2() and __ucmpdi2(). - Remove GCC 1 stuff. Revision Changes Path 1.7 +2 -10 src/lib/libc/quad/quad.h From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:41:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5A1616A41F; Mon, 12 Sep 2005 16:41:13 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DD9A43D48; Mon, 12 Sep 2005 16:41:11 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j8CGkcoK012228; Mon, 12 Sep 2005 12:46:38 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: src-committers@FreeBSD.org Date: Mon, 12 Sep 2005 12:40:49 -0400 User-Agent: KMail/1.6.2 References: <200509121531.j8CFVSxj055317@repoman.freebsd.org> In-Reply-To: <200509121531.j8CFVSxj055317@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200509121240.51775.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.85.1/1079/Mon Sep 12 05:23:50 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:41:14 -0000 On Monday 12 September 2005 11:31 am, Jung-uk Kim wrote: > jkim 2005-09-12 15:31:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_subr.c > Log: > use monotonic `time_uptime' instead of `time_second' > > Approved by: anholt (mentor) > Discussed on: arch > > Revision Changes Path > 1.645 +4 -4 src/sys/kern/vfs_subr.c Please make sure to use `time_uptime' if you need monotonic timestamp. Especially many network stacks seem to make sequence IDs and timestamps to expire from `time_second' instead of time_uptime. time_second is not guaranteed to be monotonic! time_uptime is. http://docs.freebsd.org/cgi/mid.cgi?8153.1126340565 http://docs.freebsd.org/cgi/mid.cgi?20050909214808.GA6021 I was almost tempted to do `sed -i -e 's/time_second/time_uptime' net*' (with few exceptions) but I wasn't sure how many standards really demand time_second in their actual packets/cells. :-( Thanks, Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:45:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D64616A41F; Mon, 12 Sep 2005 16:45:58 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from pasmtp.tele.dk (pasmtp.tele.dk [193.162.159.95]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5DB443D46; Mon, 12 Sep 2005 16:45:57 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (0x535c0e2a.sgnxx1.adsl-dhcp.tele.dk [83.92.14.42]) by pasmtp.tele.dk (Postfix) with ESMTP id 76A471EC325; Mon, 12 Sep 2005 18:45:56 +0200 (CEST) To: Jung-uk Kim From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 12 Sep 2005 12:40:49 EDT." <200509121240.51775.jkim@FreeBSD.org> Date: Mon, 12 Sep 2005 18:45:52 +0200 Message-ID: <11401.1126543552@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:45:58 -0000 In message <200509121240.51775.jkim@FreeBSD.org>, Jung-uk Kim writes: >Please make sure to use `time_uptime' if you need monotonic timestamp. >Especially many network stacks seem to make sequence IDs and >timestamps to expire from `time_second' instead of time_uptime. >time_second is not guaranteed to be monotonic! time_uptime is. > >http://docs.freebsd.org/cgi/mid.cgi?8153.1126340565 >http://docs.freebsd.org/cgi/mid.cgi?20050909214808.GA6021 I would like to add that this is *also* true for userland where uptime is called clock_gettime(CLOCK_MONOTONIC,...). Please consider carefully, if you need a timestamp for a certain time of day or just a certain inverval of time measured from now. In the latter case, it is _always_ uptime/CLOCK_MONOTONIC you want. Failure to do this means that your program/kernel code will do the wrong thing when the clock is stepped (manually or by NTP). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:55:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C8FF16A41F; Mon, 12 Sep 2005 16:55:20 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5AC443D46; Mon, 12 Sep 2005 16:55:19 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CGtJRe094330; Mon, 12 Sep 2005 09:55:19 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CGtJr9094329; Mon, 12 Sep 2005 09:55:19 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 09:55:18 -0700 From: "David O'Brien" To: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20050912165518.GA94181@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43255152.3000609@freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:55:20 -0000 On Mon, Sep 12, 2005 at 02:58:42AM -0700, Colin Percival wrote: > Emanuel Strobl wrote: > > Hmm, why was default size of root changed to 500M? > > Because I was increasing the sizes of /tmp and /var at the same time; because > I know that some users do somehow manage to fill up /; and because re@ told > me to. :-) Perhaps we should follow what SGI and Sun has done for years on its workstations: a combined / + /var + /usr. We would make it 15GB and be done with it. My laptop has a combined /+/var+/usr of 12GB and I have multiple kernels installed and room in swap for a crashdump. No need to reply you hate this idea - just one opinion that there are other partitioning schemes (especially now that we have a dynamic /) successfully used. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 16:59:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70C4D16A41F; Mon, 12 Sep 2005 16:59:41 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1809E43D45; Mon, 12 Sep 2005 16:59:41 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CGxegB094403; Mon, 12 Sep 2005 09:59:40 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CGxdnh094401; Mon, 12 Sep 2005 09:59:39 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 09:59:39 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20050912165939.GB94181@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> <20050911215807.GA96773@xor.obsecurity.org> <4325A5A1.8080804@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4325A5A1.8080804@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 16:59:41 -0000 On Mon, Sep 12, 2005 at 08:58:25AM -0700, Nate Lawson wrote: > Kris Kennaway wrote: > >On Sun, Sep 11, 2005 at 02:47:27PM -0700, Nate Lawson wrote: > >>Can we put it somewhere other than /? /var/run/kernel? > > > >Why? That would use up even more space, in total. > > Huh? I mean kernel, *.ko -> /boot/kernel and kernel.debug (or > kernel.sym once that's fixed) -> /var/crash/kernel/kernel.debug I believe you'll get at least one response that it makes it harder to keep the straight which symbols match which kernel. One may 'mv /boot/kernel /boot/kernel.good-fifo' and forget to 'mv /var/crash/kernel /var/crash/kernel.good-fifo'. By keeping kernel + symbols in one place this isn't an issue. I think a better approach would be to split the kernel into runnable part and symbols part. The symbols would be bzip2'ed and kept beside the runnable part. kgdb would grow support to read a bzip2'ed file (using libbz2.so). Then the space issue wouldn't be such an issue. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 17:05:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56BC516A41F; Mon, 12 Sep 2005 17:05:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 295E043D49; Mon, 12 Sep 2005 17:05:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CH5mU1067231; Mon, 12 Sep 2005 17:05:48 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CH5mRg067230; Mon, 12 Sep 2005 17:05:48 GMT (envelope-from rwatson) Message-Id: <200509121705.j8CH5mRg067230@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 17:05:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_io fifo_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 17:05:49 -0000 rwatson 2005-09-12 17:05:48 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_io fifo_io.c Log: Further updates to fifo_io regression test: - Teach fifo_io about kqueue monitoring of fifo file descriptor status, and add test cases for kqueue to match existing case for poll and select. Add a new cleanup routine, cleanfifokq(), for use in tests that use kqueues. kqueue_setup() sets up kqueue sessions, and kqueue_status() returns file descriptor status. - Correct a bug in select handling relating to the nfds argument, which was incorrect so resulted in select occuring on the wrong file descriptor, and possible false positive/negative results. - Clarify error reporting in one byte write+read tests to distinguish errors in the after case from the before case. Revision Changes Path 1.3 +287 -61 src/tools/regression/fifo/fifo_io/fifo_io.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 17:07:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC03416A420 for ; Mon, 12 Sep 2005 17:07:38 +0000 (GMT) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id F380F43D5E for ; Mon, 12 Sep 2005 17:07:36 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 28315 invoked from network); 12 Sep 2005 16:43:11 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 12 Sep 2005 16:43:11 -0000 Message-ID: <4325B5E9.E14D4484@freebsd.org> Date: Mon, 12 Sep 2005 19:07:53 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Jung-uk Kim References: <200509121531.j8CFVSxj055317@repoman.freebsd.org> <200509121240.51775.jkim@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 17:07:39 -0000 Jung-uk Kim wrote: > > On Monday 12 September 2005 11:31 am, Jung-uk Kim wrote: > > jkim 2005-09-12 15:31:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern vfs_subr.c > > Log: > > use monotonic `time_uptime' instead of `time_second' > > > > Approved by: anholt (mentor) > > Discussed on: arch > > > > Revision Changes Path > > 1.645 +4 -4 src/sys/kern/vfs_subr.c > > Please make sure to use `time_uptime' if you need monotonic timestamp. > Especially many network stacks seem to make sequence IDs and > timestamps to expire from `time_second' instead of time_uptime. > time_second is not guaranteed to be monotonic! time_uptime is. > > http://docs.freebsd.org/cgi/mid.cgi?8153.1126340565 > http://docs.freebsd.org/cgi/mid.cgi?20050909214808.GA6021 > > I was almost tempted to do `sed -i -e 's/time_second/time_uptime' > net*' (with few exceptions) but I wasn't sure how many standards > really demand time_second in their actual packets/cells. :-( I'm working my way through netinet/*. -- Andre From owner-cvs-src@FreeBSD.ORG Mon Sep 12 17:29:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F116D16A41F; Mon, 12 Sep 2005 17:29:21 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F0DC43D64; Mon, 12 Sep 2005 17:29:20 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j8CHT8I8049567; Mon, 12 Sep 2005 10:29:12 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200509121729.j8CHT8I8049567@gw.catspoiler.org> Date: Mon, 12 Sep 2005 10:29:08 -0700 (PDT) From: Don Lewis To: cperciva@FreeBSD.org In-Reply-To: <43255152.3000609@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: Emanuel.strobl@gmx.net, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 17:29:22 -0000 On 12 Sep, Colin Percival wrote: > Emanuel Strobl wrote: >> Hmm, why was default size of root changed to 500M? > > Because I was increasing the sizes of /tmp and /var at the same time; because > I know that some users do somehow manage to fill up /; and because re@ told > me to. :-) > > I still have a 128MB / on most of my systems. As do I. >> Incredable much too much >> IMHO, if not reserved for debug kernels.... >> I've just been wondering today how wasteful FreeBSD uses the hard disk >> these days (BETA4)... > > You'll only get a 500MB / if you have more than 10GB of space on your hard > disk. I don't think that going from 2.5% of the disk up to 5% of the disk > is problematically wasteful, particularly since we're only talking about the > _default_ value and it's very easy to change in sysinstall. You haven't been listening to all those people who want to turn down the minfree percentage to gain more usable space. How many more mp3's could they store if / didn't gobble up that extra 372 MB? From owner-cvs-src@FreeBSD.ORG Mon Sep 12 17:53:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AFE3F16A41F; Mon, 12 Sep 2005 17:53:27 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4757B43D48; Mon, 12 Sep 2005 17:53:26 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j8CHrGGe049612; Mon, 12 Sep 2005 10:53:20 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200509121753.j8CHrGGe049612@gw.catspoiler.org> Date: Mon, 12 Sep 2005 10:53:16 -0700 (PDT) From: Don Lewis To: obrien@FreeBSD.org In-Reply-To: <20050912165939.GB94181@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, nate@root.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 17:53:27 -0000 On 12 Sep, David O'Brien wrote: > I think a better approach would be to split the kernel into runnable part > and symbols part. The symbols would be bzip2'ed and kept beside the > runnable part. kgdb would grow support to read a bzip2'ed file (using > libbz2.so). Then the space issue wouldn't be such an issue. Why not just bzip2 the symbols before storing them in kernel.debug? Kgdb would still have to grow support for decompressing the debug info that it reads from the executable. From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:04:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B548016A41F; Mon, 12 Sep 2005 18:04:37 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AAE243D46; Mon, 12 Sep 2005 18:04:37 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8CI4eo5013385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 12 Sep 2005 11:04:40 -0700 Message-ID: <4325C332.3060105@root.org> Date: Mon, 12 Sep 2005 11:04:34 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: obrien@FreeBSD.org References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> <20050911215807.GA96773@xor.obsecurity.org> <4325A5A1.8080804@root.org> <20050912165939.GB94181@dragon.NUXI.org> In-Reply-To: <20050912165939.GB94181@dragon.NUXI.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:04:37 -0000 David O'Brien wrote: > On Mon, Sep 12, 2005 at 08:58:25AM -0700, Nate Lawson wrote: > >>Kris Kennaway wrote: >> >>>On Sun, Sep 11, 2005 at 02:47:27PM -0700, Nate Lawson wrote: >>> >>>>Can we put it somewhere other than /? /var/run/kernel? >>> >>>Why? That would use up even more space, in total. >> >>Huh? I mean kernel, *.ko -> /boot/kernel and kernel.debug (or >>kernel.sym once that's fixed) -> /var/crash/kernel/kernel.debug > > > I believe you'll get at least one response that it makes it harder to > keep the straight which symbols match which kernel. One may > 'mv /boot/kernel /boot/kernel.good-fifo' and forget to > 'mv /var/crash/kernel /var/crash/kernel.good-fifo'. By keeping kernel + > symbols in one place this isn't an issue. > > I think a better approach would be to split the kernel into runnable part > and symbols part. The symbols would be bzip2'ed and kept beside the > runnable part. kgdb would grow support to read a bzip2'ed file (using > libbz2.so). Then the space issue wouldn't be such an issue. > This sounds good to me. -- Nate From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:07:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52DFC16A41F; Mon, 12 Sep 2005 18:07:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 107BC43D45; Mon, 12 Sep 2005 18:07:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CI7nc3069898; Mon, 12 Sep 2005 18:07:49 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CI7nQ0069897; Mon, 12 Sep 2005 18:07:49 GMT (envelope-from rwatson) Message-Id: <200509121807.j8CI7nQ0069897@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 18:07:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:07:50 -0000 rwatson 2005-09-12 18:07:49 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: When a request is made to register a filter on a fifo that doesn't apply to the fifo (i.e., not EVFILT_READ or EVFILT_WRITE), reject it as EINVAL, not by returning 1 (EPERM). MFC after: 3 days Revision Changes Path 1.120 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:12:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F27316A41F; Mon, 12 Sep 2005 18:12:53 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE95E43D46; Mon, 12 Sep 2005 18:12:52 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CICpiL096300; Mon, 12 Sep 2005 11:12:52 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CICpX1096299; Mon, 12 Sep 2005 11:12:51 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 11:12:51 -0700 From: "David O'Brien" To: Scott Long Message-ID: <20050912181251.GA96269@dragon.NUXI.org> References: <200509121022.j8CAMsus032474@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509121022.j8CAMsus032474@repoman.freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc c-decl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:12:53 -0000 On Mon, Sep 12, 2005 at 10:22:54AM +0000, Scott Long wrote: > scottl 2005-09-12 10:22:54 UTC > > FreeBSD src repository > Modified files: (Branch: RELENG_6) > contrib/gcc c-decl.c > Log: > MFC rev 1.13 of c-decl.c. A nice side effect is that it's once again > possible to compile a HEAD kernel in a RELENG_6 world via the normal > shortcuts. > > Approved by: re *sigh* now you've wasted my time. Last night I said I would MFC in the morning after you asked me to MFC it. Thanks. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:17:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 973A816A41F; Mon, 12 Sep 2005 18:17:28 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3376143D46; Mon, 12 Sep 2005 18:17:28 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CIHRFv096502; Mon, 12 Sep 2005 11:17:27 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CIHR6w096501; Mon, 12 Sep 2005 11:17:27 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 11:17:27 -0700 From: "David O'Brien" To: Robert Watson Message-ID: <20050912181727.GA96329@dragon.NUXI.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <20050912094446.P33344@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050912094446.P33344@fledge.watson.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:17:28 -0000 On Mon, Sep 12, 2005 at 10:16:00AM +0100, Robert Watson wrote: > Supposing for a moment that I didn't work for a large CPU manafacturor, > but instead had a moderately well-configured desktop system, and that > instead of having one source tree I worked on, I were a kernel developer > who had 12 active development branches with various kernels, then the math > settles out a little differently. Suppose that thru a long multi-month discussion with the TRB and parts of Core a matrix was created what was officially supported of what builds on what. And also stated what was should be kept building on what if reasonable to do so. And stated what wasn't supported. The build situation you championed wasn't even contemplated - it isn't one we'd run into to even consider having it in the matrix. I know for a fact that a RELENG_5 config(8) won't config a -CURRENT kernel. So you must have built a -CURRENT config(8) on your RELENG_x box (or be prepared to). You could also build -CURRENT gcc+binutils on your RELENG_x box and install it for use in building HEAD kernels. > On my desktop (P4 1.8GHz, 512MB), it takes 15 minutes per kernel tools > build, which assuming I built them on the three machines sequentially, > would result in spending 9 hours rebuilding kernel tools as a result of > introducing dependencies on compiler tweaks before merging them. Honestly, a 1.8GHz Intel (or AMD 1800+) desktop CPU is 4 years old. For some one building 12 active branches a day, I think you would be more than justified in asking for a more powerful desktop at http://www.freebsd.org/donations/wantlist.html With both Intel and AMD have dual-core desktops - allowing you to have a cheap SMP machine, its a good time to ask on wantlist.html. > So the difference between it working may be gravy to you, but it's the > difference between spending several days of my FreeBSD time chasing build > tool changes over a dozen branches and several machines and spending those > days doing productive work. Which isn't to say that progress shouldn't > happen, just that a minor change in the order of commits would have saved > me a lot of time. There are 100's and 100's of FreeBSD commits that if ordered or done slightly differently would have saved me hours and hours and hours. That, unfortunately, is the life of a committer in FreeBSD'ville. > Just because you don't know how to request MFC's from the release > engineering team, which typically has a turn around time of less than a > day, doesn't mean I shouldn't expect you to know how to do it :-). Feh. I don't know what world you live - this doesn't at all match my experience over the past two years. Maybe requests from members of RE gravitate to the top of other RE's inboxes where they are seen and answered... ;-) My experience is one of missed and forgotten requests. Or requests denied by one RE and approved by another, after poking them individually. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:18:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72F1916A41F; Mon, 12 Sep 2005 18:18:37 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93BB843D45; Mon, 12 Sep 2005 18:18:36 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CIIZIZ096550; Mon, 12 Sep 2005 11:18:35 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CIIZQb096549; Mon, 12 Sep 2005 11:18:35 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 11:18:35 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20050912181835.GB96329@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911022901.GA3090@xor.obsecurity.org> <432397EF.5000409@FreeBSD.org> <4324A5EF.3050803@root.org> <20050911215807.GA96773@xor.obsecurity.org> <4325A5A1.8080804@root.org> <20050912165939.GB94181@dragon.NUXI.org> <4325C332.3060105@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4325C332.3060105@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:18:37 -0000 On Mon, Sep 12, 2005 at 11:04:34AM -0700, Nate Lawson wrote: > David O'Brien wrote: > > I think a better approach would be to split the kernel into runnable > > part and symbols part. The symbols would be bzip2'ed and kept beside > > the runnable part. kgdb would grow support to read a bzip2'ed file > > (using libbz2.so). Then the space issue wouldn't be such an issue. > > This sounds good to me. Me too. But I'm not volenteering to do the work. The kgdb developer would need to (or someone else sufficiently motivied). -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:28:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8811616A41F; Mon, 12 Sep 2005 18:28:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2947343D45; Mon, 12 Sep 2005 18:28:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 52CDE46BC6; Mon, 12 Sep 2005 14:28:51 -0400 (EDT) Date: Mon, 12 Sep 2005 19:28:51 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: David O'Brien In-Reply-To: <20050912181727.GA96329@dragon.NUXI.org> Message-ID: <20050912192330.P96771@fledge.watson.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <20050912094446.P33344@fledge.watson.org> <20050912181727.GA96329@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:28:52 -0000 On Mon, 12 Sep 2005, David O'Brien wrote: > Suppose that thru a long multi-month discussion with the TRB and parts > of Core a matrix was created what was officially supported of what > builds on what. And also stated what was should be kept building on > what if reasonable to do so. And stated what wasn't supported. > > The build situation you championed wasn't even contemplated - it isn't > one we'd run into to even consider having it in the matrix. > > I know for a fact that a RELENG_5 config(8) won't config a -CURRENT > kernel. So you must have built a -CURRENT config(8) on your RELENG_x > box (or be prepared to). You could also build -CURRENT gcc+binutils on > your RELENG_x box and install it for use in building HEAD kernels. So it would appear: zoo:/zoo/rwatson/p4/projects/netsmp/src/sys/fs/fifofs% ls ~/bin ./ config4* config61* ministat* ../ config6* config62* p4* Easy to do it with config, a pain to do it with a complete toolchain. I have to say that the NOMAN->NO_MAN changes last year were among the most annoying of this sort we've had in ages, since there was little or no effort at forwards compatibility for builds. This required custom modification of the module Makefile for aic7xxx for every kernel source code tree I work with, which was also a waste of time. >> On my desktop (P4 1.8GHz, 512MB), it takes 15 minutes per kernel tools >> build, which assuming I built them on the three machines sequentially, >> would result in spending 9 hours rebuilding kernel tools as a result of >> introducing dependencies on compiler tweaks before merging them. > > Honestly, a 1.8GHz Intel (or AMD 1800+) desktop CPU is 4 years old. > For some one building 12 active branches a day, I think you would be > more than justified in asking for a more powerful desktop at > http://www.freebsd.org/donations/wantlist.html With both Intel and AMD > have dual-core desktops - allowing you to have a cheap SMP machine, its > a good time to ask on wantlist.html. While the build time is huge, it's much more the management time that makes it an issue: as I said, keeping 12 branches with in sync toolchains is very time-consuming, and adds overhead to day-to-day development that, in the general case, is unnecessary. >> So the difference between it working may be gravy to you, but it's the >> difference between spending several days of my FreeBSD time chasing >> build tool changes over a dozen branches and several machines and >> spending those days doing productive work. Which isn't to say that >> progress shouldn't happen, just that a minor change in the order of >> commits would have saved me a lot of time. > > There are 100's and 100's of FreeBSD commits that if ordered or done > slightly differently would have saved me hours and hours and hours. > That, unfortunately, is the life of a committer in FreeBSD'ville. No doubt. Yet you'd think that avoiding unnecessary inconvenience would be something you'd consider desirable, given that... Robert N M Watson From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:33:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8886C16A41F; Mon, 12 Sep 2005 18:33:34 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5831543D48; Mon, 12 Sep 2005 18:33:34 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CIXY7C071007; Mon, 12 Sep 2005 18:33:34 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CIXYNM071006; Mon, 12 Sep 2005 18:33:34 GMT (envelope-from netchild) Message-Id: <200509121833.j8CIXYNM071006@repoman.freebsd.org> From: Alexander Leidinger Date: Mon, 12 Sep 2005 18:33:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm dsp.c sound.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:33:34 -0000 netchild 2005-09-12 18:33:34 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm dsp.c sound.c Log: - Fix the locking in dsp.c to prevent a LOR (AFAIK not on the LOR page). - Remove an assertion in sound.c, it's not needed (and causes a panic now). From the conversation via mail between glebius and Ariff: ---snip--- > Well, but which mutex protects now? Do we own anything else > in pcm_chnalloc()? I see some queue(4) macros in pcm_chnalloc(), > they should be protected, shouldn't they? Queue insertion/removal occur during 1) driver loading (which is pretty much single thread / sequential) or unloading (mutex protected, bail out if there is any channel with refcount > 0 or busy). 2) vchan_create()/destroy(), (which is *sigh* quite complicated), but somehow protected by 'master'/parent channel mutex. Other thread cannot add/remove vchan (or even continue traversing that queue) unless it can acquire parent channel mutex. ---snip--- Fix the locking in dsp.c to prevent a LOR (AFAIK not on the LOR page). Submitted by: Ariff Abdullah Tested with: INVARIANTS[1] and DIAGNOSTICS[2] Tested by: netchild [1,2], David Reid [1] Revision Changes Path 1.84 +3 -3 src/sys/dev/sound/pcm/dsp.c 1.96 +0 -2 src/sys/dev/sound/pcm/sound.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:40:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEBAA16A41F; Mon, 12 Sep 2005 18:40:26 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 537BC43D46; Mon, 12 Sep 2005 18:40:26 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8CIePUW097109; Mon, 12 Sep 2005 11:40:25 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8CIePss097108; Mon, 12 Sep 2005 11:40:25 -0700 (PDT) (envelope-from obrien) Date: Mon, 12 Sep 2005 11:40:25 -0700 From: "David O'Brien" To: Robert Watson Message-ID: <20050912184025.GA96996@dragon.NUXI.org> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <20050912094446.P33344@fledge.watson.org> <20050912181727.GA96329@dragon.NUXI.org> <20050912192330.P96771@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050912192330.P96771@fledge.watson.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:40:26 -0000 On Mon, Sep 12, 2005 at 07:28:51PM +0100, Robert Watson wrote: > On Mon, 12 Sep 2005, David O'Brien wrote: > >There are 100's and 100's of FreeBSD commits that if ordered or done > >slightly differently would have saved me hours and hours and hours. > >That, unfortunately, is the life of a committer in FreeBSD'ville. > > No doubt. > > Yet you'd think that avoiding unnecessary inconvenience would be > something you'd consider desirable, given that... And I would have MFC'ed the bug fix the moment RELENG_6 was unfrozen. I'm not arguing that committing the fix to all the active RELENG_* branchs isn't a good idea. Nor have I said I wouldn't do it. The issue is you're essentially requiring me to MFC thru a code freeze (the process can be too heavy weight) before I could work on HEAD - a requirement that hasn't existed before and isn't written down anywhere. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:50:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FA0416A420; Mon, 12 Sep 2005 18:50:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id A931C43D46; Mon, 12 Sep 2005 18:50:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 12 Sep 2005 15:05:50 -0400 From: John Baldwin To: Ken Smith Date: Mon, 12 Sep 2005 14:51:14 -0400 User-Agent: KMail/1.8 References: <200509081350.j88DoG5s039090@repoman.freebsd.org> In-Reply-To: <200509081350.j88DoG5s039090@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509121451.15539.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:50:16 -0000 On Thursday 08 September 2005 09:50 am, Ken Smith wrote: > kensmith 2005-09-08 13:50:16 UTC > > FreeBSD src repository > > Modified files: > sys/dev/hme if_hme.c > Log: > Move hme_stop() after ether_ifdetach() and if_free() to prevent a > memory-referenced-after-free panic if the hme interface fails to > attach. > > Patch obtained from: marius > Suggested same thing: brooks > > MFC after: 3 days Umm, can't this lead to panics due to hme_intr() dereferencing sc_ifp? Why not do what all the other ethernet drivers do: if (device_is_attached(dev)) { HME_LOCK(sc); hme_stop(sc); HME_UNLOCK(sc); callout_drain(..); ether_ifdetach(...); if_free(...); } For references of similar drivers look at the detach methods for xl(4), pcn(4), wb(4), dc(4), sf(4), etc. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Sep 12 18:58:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47F7C16A41F; Mon, 12 Sep 2005 18:58:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9466A43D49; Mon, 12 Sep 2005 18:58:01 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 0CD8746B06; Mon, 12 Sep 2005 14:58:01 -0400 (EDT) Date: Mon, 12 Sep 2005 19:58:00 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <200407041052.i64Aqs78039847@repoman.freebsd.org> Message-ID: <20050912195632.V96771@fledge.watson.org> References: <200407041052.i64Aqs78039847@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_event.c vfs_mount.c vfs_subr.c src/sys/sys event.h mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 18:58:02 -0000 On Sun, 4 Jul 2004, Alfred Perlstein wrote: > Modified files: > sys/kern kern_event.c vfs_mount.c vfs_subr.c > sys/sys event.h mount.h > Log: > Introduce a new kevent filter. EVFILT_FS that will be used to signal > generic filesystem events to userspace. Currently only mount and unmount > of filesystems are signalled. Soon to be added, up/down status of NFS. > > Introduce a sysctl node used to route requests to/from filesystems > based on filesystem ids. > > Introduce a new vfsop, vfs_sysctl(mp, req) that is used as the callback/ > entrypoint by the sysctl code to change individual filesystems. Do you have any plans to update kqueue(2) to describe EVFILT_FS? Right now, the existing filter types appear to have useful summaries of what they represent, and information on how they are used with objects. This would be quite useful to have for EVFILT_FS also. Thanks, Robert N M Watson From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:03:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C248716A41F; Mon, 12 Sep 2005 19:03:54 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BBC443D48; Mon, 12 Sep 2005 19:03:54 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j8CJ3r61010670; Mon, 12 Sep 2005 12:03:53 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j8CJ3rjA010669; Mon, 12 Sep 2005 12:03:53 -0700 Date: Mon, 12 Sep 2005 12:03:53 -0700 From: Brooks Davis To: John Baldwin Message-ID: <20050912190353.GC24946@odin.ac.hmc.edu> References: <200509081350.j88DoG5s039090@repoman.freebsd.org> <200509121451.15539.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT" Content-Disposition: inline In-Reply-To: <200509121451.15539.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ken Smith Subject: Re: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:03:54 -0000 --KN5l+BnMqAQyZLvT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 12, 2005 at 02:51:14PM -0400, John Baldwin wrote: > On Thursday 08 September 2005 09:50 am, Ken Smith wrote: > > kensmith 2005-09-08 13:50:16 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/hme if_hme.c > > Log: > > Move hme_stop() after ether_ifdetach() and if_free() to prevent a > > memory-referenced-after-free panic if the hme interface fails to > > attach. > > > > Patch obtained from: marius > > Suggested same thing: brooks > > > > MFC after: 3 days >=20 > Umm, can't this lead to panics due to hme_intr() dereferencing sc_ifp? W= hy=20 > not do what all the other ethernet drivers do: >=20 > if (device_is_attached(dev)) { > HME_LOCK(sc); > hme_stop(sc); > HME_UNLOCK(sc); > callout_drain(..); > ether_ifdetach(...); > if_free(...); > } >=20 > For references of similar drivers look at the detach methods for xl(4),= =20 > pcn(4), wb(4), dc(4), sf(4), etc. The commit message is backwards. It's actually correcting this bug (I think Ken sent a followup). -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --KN5l+BnMqAQyZLvT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDJdEZXY6L6fI4GtQRAr3rAJoC/4ls87kh5dVDQ7gPoLOCaNYnHACfXcqp kCrgYxpv1eGRaplHN/JxMLI= =GAMW -----END PGP SIGNATURE----- --KN5l+BnMqAQyZLvT-- From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:22:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CA1B16A420; Mon, 12 Sep 2005 19:22:38 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D77BA43D46; Mon, 12 Sep 2005 19:22:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CJMbjF073084; Mon, 12 Sep 2005 19:22:37 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CJMbvA073083; Mon, 12 Sep 2005 19:22:37 GMT (envelope-from rwatson) Message-Id: <200509121922.j8CJMbvA073083@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 19:22:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:22:38 -0000 rwatson 2005-09-12 19:22:37 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: In vfs_kqfilter(), return EINVAL instead of 1 (EPERM) when an unsupported kqueue filter type is requested on a vnode. MFC after: 3 days Revision Changes Path 1.646 +1 -1 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:26:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DD6816A41F; Mon, 12 Sep 2005 19:26:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC4D743D46; Mon, 12 Sep 2005 19:26:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CJQ3FO073281; Mon, 12 Sep 2005 19:26:03 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CJQ3tR073280; Mon, 12 Sep 2005 19:26:03 GMT (envelope-from rwatson) Message-Id: <200509121926.j8CJQ3tR073280@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 19:26:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:26:04 -0000 rwatson 2005-09-12 19:26:03 UTC FreeBSD src repository Modified files: sys/net if.c Log: In netkqfilter(), return EINVAL instead of 1 (EPERM) when a filter type is requested on a network interface file descriptor that is non-applicable. MFC after: 3 days Revision Changes Path 1.246 +1 -1 src/sys/net/if.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:31:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F44C16A420; Mon, 12 Sep 2005 19:31:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4221043D5A; Mon, 12 Sep 2005 19:31:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CJVHJZ073595; Mon, 12 Sep 2005 19:31:17 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CJVHu3073594; Mon, 12 Sep 2005 19:31:17 GMT (envelope-from rwatson) Message-Id: <200509121931.j8CJVHu3073594@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 19:31:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_misc fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:31:17 -0000 rwatson 2005-09-12 19:31:17 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_misc fifo_misc.c Log: Comment test_lseek(). Add test_kqueue(), which registers and unregisters various kqueue filter types on a fifo in order to make sure that EVFILT_READ, EVFILT_WRITE can be registered, and that EVFILT_NETDEV can't be registered. For now, we don't test that EVFILT_VNODE can be registered on fifos, as that has been broken at some point. Revision Changes Path 1.2 +117 -0 src/tools/regression/fifo/fifo_misc/fifo_misc.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:42:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02D7216A41F; Mon, 12 Sep 2005 19:42:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E29243D48; Mon, 12 Sep 2005 19:42:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 12 Sep 2005 15:58:29 -0400 From: John Baldwin To: "David E. O'Brien" Date: Mon, 12 Sep 2005 14:55:40 -0400 User-Agent: KMail/1.8 References: <200509110022.j8B0MLV9083240@repoman.freebsd.org> In-Reply-To: <200509110022.j8B0MLV9083240@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509121455.41702.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:42:54 -0000 On Saturday 10 September 2005 08:22 pm, David E. O'Brien wrote: > obrien 2005-09-11 00:22:21 UTC > > FreeBSD src repository > > Modified files: > sys/conf kern.post.mk > Log: > For HEAD, install a kernel with debug information if DEBUG is a kernel > config option. It is too easy to loose the build directory and not have > symbols for kgdb to read. > > Revision Changes Path > 1.84 +4 -17 src/sys/conf/kern.post.mk Ouch. :( I tend to fill up the / on my test machines with all my test stripped kernels as it is. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:42:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4977F16A420; Mon, 12 Sep 2005 19:42:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A36F43D49; Mon, 12 Sep 2005 19:42:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 12 Sep 2005 15:58:29 -0400 From: John Baldwin To: Scott Long Date: Mon, 12 Sep 2005 15:27:15 -0400 User-Agent: KMail/1.8 References: <200509022021.j82KLnZ4076136@repoman.freebsd.org> <4318BCB5.5050001@samsco.org> In-Reply-To: <4318BCB5.5050001@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509121527.17178.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:42:54 -0000 On Friday 02 September 2005 04:57 pm, Scott Long wrote: > John Baldwin wrote: > > jhb 2005-09-02 20:21:49 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_mutex.c > > Log: > > - Add an assertion to panic if one tries to call mtx_trylock() on a > > spin mutex. > > Explaining exactly why this is bad, either in a commit log, in a > manpage, or in source code comments would be really nice. The pitfalls > are not immediately obvious to the casual observer. I can update the manpage. mtx_trylock() has never worked for spin mutexes since its import from BSD/OS. If we ever wanted one (I can think of one useful case in the idle loop perhaps) then it would be called mtx_trylock_spin() anyways. > > - Don't panic if a spin lock is held too long inside _mtx_lock_spin() > > if panicstr is set (meaning that we are already in a panic). Just keep > > spinning forever instead. > > If panicstr is set, shouldn't all CPUs have already been sent an NMI? > This seems like a step backwards in reliability. They should not recursively panic, yes, but in practice they do and once they do you can't get into the debugger. Just ask Kris if this is an improvement. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:42:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C74416A421; Mon, 12 Sep 2005 19:42:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFF8A43D46; Mon, 12 Sep 2005 19:42:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 12 Sep 2005 15:58:29 -0400 From: John Baldwin To: obrien@FreeBSD.org Date: Mon, 12 Sep 2005 15:43:39 -0400 User-Agent: KMail/1.8 References: <200509110338.j8B3cJwv098050@repoman.freebsd.org> <4323BB54.6060600@errno.com> <20050911060138.GA83586@dragon.NUXI.org> In-Reply-To: <20050911060138.GA83586@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509121543.41175.jhb@FreeBSD.org> Cc: Sam Leffler , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:42:54 -0000 On Sunday 11 September 2005 02:01 am, David O'Brien wrote: > On Sat, Sep 10, 2005 at 10:06:28PM -0700, Sam Leffler wrote: > > David E. O'Brien wrote: > > >obrien 2005-09-11 03:38:19 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/conf files kern.pre.mk > > > Log: > > > Don't pollute the entire kernel build with -I$S/contrib/dev/ath and > > > -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be > > > defined to > > > globally get back -I$S/contrib/dev/ath. > > > > Thanks for explicitly ignoring my request for you NOT to do this. It's > > really great how you do these drive-by commits that do nothing but f*ck > > up people's development environment. > > Sam > > I did my best to take your needs into account. I even asked you to > propose a patch when you didn't like the ones I sent you - your response > was "David, I have no time to waste on stuff like this." > > "-INCLUDES+= -I$S/contrib/dev/ath" should never have been in the public > FreeBSD source tree as not a single file in /usr/src/sys needed it to > compile. We don't commit Yahoo!'s, The Weather Channel, Interjet's or > any other vendor-specific needs into the open source /usr/src. I think > you're more than able to stick "ATH_BUILDING_FROM_SOURCE=yes" in the > /etc/make.conf of the machines you build the ath(4) HAL on. > > I'm sorry you don't see that we shouldn't pollute the kernel build with > tons of -I's. It was getting out of hand that every one felt they could > add yet another global -I with every new code import rather than edit > their code to build in our tree correctly. David, how did having -Ifoo waste your time? Also, we do put vendor-specific needs into the tree all the time. :) How do you think the limited ACPI support for 4.x was done? That wasn't some random act of kindness on my part because I was bored, it was something that ${REALJOB} needed. A lot of work on FreeBSD happens because people use it at their workplace and fix the needs and problems that come from that use. You just added some license files to a subdirectory for the nve(4) device driver to make a vendor happy yourself which was catering to that vendor as other vendors don't require that. Looks rather hyprocritical to me from over in this corner. I don't see how -Ifoo could have possibly been killing you. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:52:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9E3716A41F; Mon, 12 Sep 2005 19:52:42 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D17D43D48; Mon, 12 Sep 2005 19:52:42 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CJqgeM074745; Mon, 12 Sep 2005 19:52:42 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CJqgWs074744; Mon, 12 Sep 2005 19:52:42 GMT (envelope-from stefanf) Message-Id: <200509121952.j8CJqgWs074744@repoman.freebsd.org> From: Stefan Farfeleder Date: Mon, 12 Sep 2005 19:52:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/compat-43 gethostid.c src/lib/libc/gen daemon.c devname.c gethostname.c getosreldate.c getpagesize.c readdir.c sethostname.c strtofflags.c src/lib/libc/i386/gen _set_tp.c ldexp.c src/lib/libc/locale runetype.c tolower.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:52:43 -0000 stefanf 2005-09-12 19:52:42 UTC FreeBSD src repository Modified files: lib/libc/compat-43 gethostid.c lib/libc/gen daemon.c devname.c gethostname.c getosreldate.c getpagesize.c readdir.c sethostname.c strtofflags.c lib/libc/i386/gen _set_tp.c ldexp.c lib/libc/locale runetype.c tolower.c toupper.c lib/libc/posix1e extattr.c lib/libc/stdlib strfmon.c Log: Include a couple of headers to ensure consistency between the prototype and the function definition. Revision Changes Path 1.4 +2 -0 src/lib/libc/compat-43/gethostid.c 1.7 +1 -0 src/lib/libc/gen/daemon.c 1.10 +1 -0 src/lib/libc/gen/devname.c 1.6 +1 -0 src/lib/libc/gen/gethostname.c 1.7 +2 -0 src/lib/libc/gen/getosreldate.c 1.5 +2 -0 src/lib/libc/gen/getpagesize.c 1.12 +1 -0 src/lib/libc/gen/readdir.c 1.5 +2 -0 src/lib/libc/gen/sethostname.c 1.23 +1 -0 src/lib/libc/gen/strtofflags.c 1.7 +2 -0 src/lib/libc/i386/gen/_set_tp.c 1.12 +2 -0 src/lib/libc/i386/gen/ldexp.c 1.13 +1 -0 src/lib/libc/locale/runetype.c 1.12 +1 -0 src/lib/libc/locale/tolower.c 1.12 +1 -0 src/lib/libc/locale/toupper.c 1.7 +1 -0 src/lib/libc/posix1e/extattr.c 1.15 +1 -0 src/lib/libc/stdlib/strfmon.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 19:59:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B32316A41F; Mon, 12 Sep 2005 19:59:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1ECF43D46; Mon, 12 Sep 2005 19:59:12 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CJxCvb075065; Mon, 12 Sep 2005 19:59:12 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CJxCJL075064; Mon, 12 Sep 2005 19:59:12 GMT (envelope-from rwatson) Message-Id: <200509121959.j8CJxCJL075064@repoman.freebsd.org> From: Robert Watson Date: Mon, 12 Sep 2005 19:59:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 19:59:13 -0000 rwatson 2005-09-12 19:59:12 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Introduce no-op nosup fifo kqueue filter and detach routine, which are used when a read filter is requested on a write-only fifo descriptor, or a write filter is requested on a read-only fifo descriptor. This permits the filters to be registered, but never raises the event, which causes kqueue behavior for fifos to more closely match similar semantics for poll and select, which permit testing for the condition even though the condition will never be raised, and is consistent with POSIX's notion that a fifo has identical semantics to a one-way IPC channel created using pipe() on most operating systems. The fifo regression test suite can now run to completion on HEAD without errors. MFC after: 3 days Revision Changes Path 1.121 +33 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Sep 12 20:11:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C8F516A41F; Mon, 12 Sep 2005 20:11:38 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 907F343D49; Mon, 12 Sep 2005 20:11:37 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.3/8.13.3) with ESMTP id j8CKBaVO042165; Mon, 12 Sep 2005 13:11:36 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.3/8.13.3/Submit) id j8CKBaDQ042164; Mon, 12 Sep 2005 13:11:36 -0700 (PDT) (envelope-from jmg) Date: Mon, 12 Sep 2005 13:11:36 -0700 From: John-Mark Gurney To: Robert Watson Message-ID: <20050912201136.GK793@funkthat.com> References: <200509111303.j8BD3bTK042313@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509111303.j8BD3bTK042313@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/regression/fifo/fifo_open Makefile fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 20:11:38 -0000 Robert Watson wrote this message on Sun, Sep 11, 2005 at 13:03 +0000: > rwatson 2005-09-11 13:03:36 UTC > > FreeBSD src repository > > Added files: > tools/regression/fifo/fifo_open Makefile fifo_open.c > Log: > Add fifo_open, a basic regression test for opening fifos, which tests > the blocking and non-blocking forms of open based on the POSIX spec for > now O_NONBLOCK should be handled. I assume we aren't going to follow the useless POSIX spec for handling O_NONBLOCK'ing reads wrt select and friends? If you're interested in a basic test case, I can send you one... (That selecting on a fifo for read that doesn't have a writer will return true, due to the fact that EOF is available for reading on a O_NONBLOCK fifo.) -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Mon Sep 12 20:20:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BA6816A41F; Mon, 12 Sep 2005 20:20:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1D4143D49; Mon, 12 Sep 2005 20:20:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id F080646B4F; Mon, 12 Sep 2005 16:20:03 -0400 (EDT) Date: Mon, 12 Sep 2005 21:20:03 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John-Mark Gurney In-Reply-To: <20050912201136.GK793@funkthat.com> Message-ID: <20050912211820.W96771@fledge.watson.org> References: <200509111303.j8BD3bTK042313@repoman.freebsd.org> <20050912201136.GK793@funkthat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/regression/fifo/fifo_open Makefile fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 20:20:05 -0000 On Mon, 12 Sep 2005, John-Mark Gurney wrote: > Robert Watson wrote this message on Sun, Sep 11, 2005 at 13:03 +0000: >> rwatson 2005-09-11 13:03:36 UTC >> >> FreeBSD src repository >> >> Added files: >> tools/regression/fifo/fifo_open Makefile fifo_open.c >> Log: >> Add fifo_open, a basic regression test for opening fifos, which tests >> the blocking and non-blocking forms of open based on the POSIX spec for >> now O_NONBLOCK should be handled. > > I assume we aren't going to follow the useless POSIX spec for handling > O_NONBLOCK'ing reads wrt select and friends? If you're interested in a > basic test case, I can send you one... > > (That selecting on a fifo for read that doesn't have a writer will > return true, due to the fact that EOF is available for reading on a > O_NONBLOCK fifo.) Right now I haven't implemented tests for select/poll/kqueue that involve activity on a fifo where only one endpoint is open. I largely implemented these regression tests so I could try to avoid breaking fifos when fixing a race condition that Kris and others have been running into. Along the way, I ran into a lot of bugs that had to be fixed before I could run the tests successfully :-). I'm going to work on the race itself now and revisit further testing of half-open fifos in the future (there are some XXX's in the test code to indicate some of the uncovered cases I'm aware of). Robert N M Watson From owner-cvs-src@FreeBSD.ORG Mon Sep 12 20:20:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C337616A41F; Mon, 12 Sep 2005 20:20:44 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1357743D45; Mon, 12 Sep 2005 20:20:43 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.3/8.13.3) with ESMTP id j8CKKhHw042398; Mon, 12 Sep 2005 13:20:43 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.3/8.13.3/Submit) id j8CKKh4Q042397; Mon, 12 Sep 2005 13:20:43 -0700 (PDT) (envelope-from jmg) Date: Mon, 12 Sep 2005 13:20:43 -0700 From: John-Mark Gurney To: Robert Watson Message-ID: <20050912202043.GL793@funkthat.com> References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <20050912094446.P33344@fledge.watson.org> <20050912181727.GA96329@dragon.NUXI.org> <20050912192330.P96771@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050912192330.P96771@fledge.watson.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 20:20:45 -0000 Robert Watson wrote this message on Mon, Sep 12, 2005 at 19:28 +0100: > On Mon, 12 Sep 2005, David O'Brien wrote: > > >Suppose that thru a long multi-month discussion with the TRB and parts > >of Core a matrix was created what was officially supported of what > >builds on what. And also stated what was should be kept building on > >what if reasonable to do so. And stated what wasn't supported. > > > >The build situation you championed wasn't even contemplated - it isn't > >one we'd run into to even consider having it in the matrix. > > > >I know for a fact that a RELENG_5 config(8) won't config a -CURRENT > >kernel. So you must have built a -CURRENT config(8) on your RELENG_x > >box (or be prepared to). You could also build -CURRENT gcc+binutils on > >your RELENG_x box and install it for use in building HEAD kernels. > > So it would appear: > > zoo:/zoo/rwatson/p4/projects/netsmp/src/sys/fs/fifofs% ls ~/bin > ./ config4* config61* ministat* > ../ config6* config62* p4* > > Easy to do it with config, a pain to do it with a complete toolchain. Nope.. That is why I made buildenv in the first place... After a buildworld, it makes a user friendly environment to do the normal config KERN && cd ../compile/KERN && make depend && make -j 4 That most developers are fond of... And you only need to do the buildworld when material changes are made, not for every change... That's how I did quick turn builds for arm, when I got tired of going through buildkernel... Building for different platforms is the same problem as building for different branches... [...] -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Mon Sep 12 20:54:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7A3616A41F; Mon, 12 Sep 2005 20:54:01 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6629D43D46; Mon, 12 Sep 2005 20:54:01 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CKs1Hw084506; Mon, 12 Sep 2005 20:54:01 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CKs1JI084501; Mon, 12 Sep 2005 20:54:01 GMT (envelope-from das) Message-Id: <200509122054.j8CKs1JI084501@repoman.freebsd.org> From: David Schultz Date: Mon, 12 Sep 2005 20:54:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/msun/amd64 s_scalbnf.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 20:54:01 -0000 das 2005-09-12 20:54:00 UTC FreeBSD src repository Modified files: lib/msun/amd64 s_scalbnf.S Log: Add a missing ldexpf() alias for amd64. Noticed by: bz@, tjr@ Revision Changes Path 1.2 +3 -0 src/lib/msun/amd64/s_scalbnf.S From owner-cvs-src@FreeBSD.ORG Mon Sep 12 21:01:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B95A316A41F; Mon, 12 Sep 2005 21:01:28 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76A1543D46; Mon, 12 Sep 2005 21:01:28 +0000 (GMT) (envelope-from das@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8CL1SGx085015; Mon, 12 Sep 2005 21:01:28 GMT (envelope-from das@repoman.freebsd.org) Received: (from das@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8CL1Sxn085014; Mon, 12 Sep 2005 21:01:28 GMT (envelope-from das) Message-Id: <200509122101.j8CL1Sxn085014@repoman.freebsd.org> From: David Schultz Date: Mon, 12 Sep 2005 21:01:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/lib/msun Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 21:01:28 -0000 das 2005-09-12 21:01:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/msun Makefile Log: MFC rev 1.64. Rev 1.51.2.3 claimed to be an MFC of 1.53, 1.55, 1.56, 1.59, 1.60, 1.62, and 1.64, but I left out 1.64. Reported by: asmodai@ Revision Changes Path 1.51.2.4 +1 -1 src/lib/msun/Makefile From owner-cvs-src@FreeBSD.ORG Mon Sep 12 22:03:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4BCC16A41F; Mon, 12 Sep 2005 22:03:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B4E743D45; Mon, 12 Sep 2005 22:03:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 12 Sep 2005 18:19:01 -0400 From: John Baldwin To: Brooks Davis Date: Mon, 12 Sep 2005 15:51:45 -0400 User-Agent: KMail/1.8 References: <200509081350.j88DoG5s039090@repoman.freebsd.org> <200509121451.15539.jhb@FreeBSD.org> <20050912190353.GC24946@odin.ac.hmc.edu> In-Reply-To: <20050912190353.GC24946@odin.ac.hmc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509121551.47351.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ken Smith Subject: Re: cvs commit: src/sys/dev/hme if_hme.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 22:03:32 -0000 On Monday 12 September 2005 03:03 pm, Brooks Davis wrote: > On Mon, Sep 12, 2005 at 02:51:14PM -0400, John Baldwin wrote: > > On Thursday 08 September 2005 09:50 am, Ken Smith wrote: > > > kensmith 2005-09-08 13:50:16 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/hme if_hme.c > > > Log: > > > Move hme_stop() after ether_ifdetach() and if_free() to prevent a > > > memory-referenced-after-free panic if the hme interface fails to > > > attach. > > > > > > Patch obtained from: marius > > > Suggested same thing: brooks > > > > > > MFC after: 3 days > > > > Umm, can't this lead to panics due to hme_intr() dereferencing sc_ifp? > > Why not do what all the other ethernet drivers do: > > > > if (device_is_attached(dev)) { > > HME_LOCK(sc); > > hme_stop(sc); > > HME_UNLOCK(sc); > > callout_drain(..); > > ether_ifdetach(...); > > if_free(...); > > } > > > > For references of similar drivers look at the detach methods for xl(4), > > pcn(4), wb(4), dc(4), sf(4), etc. > > The commit message is backwards. It's actually correcting this bug (I > think Ken sent a followup). Ah, that's what I get for trusting the commit message. However, while writing the e-mail I did find that rl(4) was busted, so I've gone and fixed it so at least that part was productive. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Sep 13 00:45:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31B7616A41F; Tue, 13 Sep 2005 00:45:39 +0000 (GMT) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 796B543D46; Tue, 13 Sep 2005 00:45:38 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id B457113112A; Tue, 13 Sep 2005 10:15:36 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 87E1E84F7E; Tue, 13 Sep 2005 10:15:36 +0930 (CST) Date: Tue, 13 Sep 2005 10:15:36 +0930 From: Greg 'groggy' Lehey To: David O'Brien Message-ID: <20050913004536.GK53486@wantadilla.lemis.com> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="73fGQZLCrFzENemP" Content-Disposition: inline In-Reply-To: <20050912165518.GA94181@dragon.NUXI.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Combined root, /var and /usr (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 00:45:39 -0000 --73fGQZLCrFzENemP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Monday, 12 September 2005 at 9:55:18 -0700, David O'Brien wrote: > On Mon, Sep 12, 2005 at 02:58:42AM -0700, Colin Percival wrote: >> Emanuel Strobl wrote: >>> Hmm, why was default size of root changed to 500M? >> >> Because I was increasing the sizes of /tmp and /var at the same time; be= cause >> I know that some users do somehow manage to fill up /; and because re@ t= old >> me to. :-) > > Perhaps we should follow what SGI and Sun has done for years on its > workstations: a combined / + /var + /usr.=20 I've been recommending and doing this for years. FWIW in the fourth edition of "The Complete FreeBSD" I recommended 4 to 6 GB; I'd now say that 8 to 10 is better. I also recommend a separate /var if you're doing important things with it. Here's what I have on my two main machines: =3D=3D=3D root@wantadilla (/dev/ttyp0) ~ 98 -> df Filesystem 1048576-blocks Used Avail Capacity Mounted on /dev/ad0s1a 9912 4211 4908 46% / /dev/ad0s3h 51895 41842 5902 88% /home =3D=3D=3D root@echunga (/dev/ttyp4) ~ 29 -> df Filesystem 1048576-blocks Used Avail Capacity Mounted on /dev/ad0s1a 14873 7985 5698 58% / /dev/ad0s1g 9916 3846 5276 42% /home /dev/ad2s1h 188356 106658 66629 62% /src /src contains source files, including multiple FreeBSD source trees. I see that on echunga / is now 15 GB, but that includes a large /var, and it's still only just on 8 GB. > We would make it 15GB and be done with it. My laptop has a combined > /+/var+/usr of 12GB and I have multiple kernels installed and room > in swap for a crashdump. Note that this could also mean that you don't need to install the kernel; if you build it in /usr (on the root file system), you can link to it directly in the kernel build directory. > No need to reply you hate this idea - just one opinion that there > are other partitioning schemes (especially now that we have a > dynamic /) successfully used. In CFBSD IV I explain how / and /usr came to be: about 32 years ago, they had / on an RK03 (0.5 MB), so they *had* to put the rest of the system somewhere else. The fact that we still use a separate /usr has something to do with the reliability of the Seventh Edition file system and something to do with not changing the way our grandfathers did things (writing "return (FOO)" instead of "return FOO" is another example). Greg -- See complete headers for address and phone numbers. --73fGQZLCrFzENemP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDJiEwIubykFB6QiMRAjowAJ9xzjRFV3kQkZUg/Cxc+dqw9p6q5gCbBp61 F5Of4TbNtovstZQJ7b6/khA= =GClK -----END PGP SIGNATURE----- --73fGQZLCrFzENemP-- From owner-cvs-src@FreeBSD.ORG Tue Sep 13 02:23:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C5BB16A41F; Tue, 13 Sep 2005 02:23:26 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4886C43D46; Tue, 13 Sep 2005 02:23:26 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D2NQe7004785; Tue, 13 Sep 2005 02:23:26 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D2NQFu004783; Tue, 13 Sep 2005 02:23:26 GMT (envelope-from jkoshy) Message-Id: <200509130223.j8D2NQFu004783@repoman.freebsd.org> From: Joseph Koshy Date: Tue, 13 Sep 2005 02:23:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat_log.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 02:23:26 -0000 jkoshy 2005-09-13 02:23:25 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat_log.c Log: Fix a bug that caused generated gmon.out profiles to be out of whack. Use saturating arithmetic when incrementing a bucket. Improve a few comments. MFC after: 3 days Revision Changes Path 1.4 +31 -10 src/usr.sbin/pmcstat/pmcstat_log.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 05:11:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37FED16A41F; Tue, 13 Sep 2005 05:11:38 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9A9D43D48; Tue, 13 Sep 2005 05:11:37 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D5Bbkr018159; Tue, 13 Sep 2005 05:11:37 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D5BbMh018158; Tue, 13 Sep 2005 05:11:37 GMT (envelope-from grehan) Message-Id: <200509130511.j8D5BbMh018158@repoman.freebsd.org> From: Peter Grehan Date: Tue, 13 Sep 2005 05:11:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/powerpc/powerpc pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 05:11:38 -0000 grehan 2005-09-13 05:11:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/powerpc/powerpc pmap.c Log: MFC r1.101 Fix boot-time hang/panic on G3 systems when modifying IBAT0 in pmap_bootstrap by using the sync;isync big hammer to make sure all prior operations have completed. Reported by: Nathan Whitehorn Approved by: re (Ken Smith) Revision Changes Path 1.99.2.1 +2 -1 src/sys/powerpc/powerpc/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 05:18:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A684116A420; Tue, 13 Sep 2005 05:18:16 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09CF343D6D; Tue, 13 Sep 2005 05:18:10 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j8D5I9jU004892; Tue, 13 Sep 2005 15:18:09 +1000 Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j8D5I72e018203; Tue, 13 Sep 2005 15:18:07 +1000 Date: Tue, 13 Sep 2005 15:18:06 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: John-Mark Gurney In-Reply-To: <20050912201136.GK793@funkthat.com> Message-ID: <20050913143348.P1831@epsplex.bde.org> References: <200509111303.j8BD3bTK042313@repoman.freebsd.org> <20050912201136.GK793@funkthat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/regression/fifo/fifo_open Makefile fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 05:18:17 -0000 On Mon, 12 Sep 2005, John-Mark Gurney wrote: > Robert Watson wrote this message on Sun, Sep 11, 2005 at 13:03 +0000: >> rwatson 2005-09-11 13:03:36 UTC >> >> FreeBSD src repository >> >> Added files: >> tools/regression/fifo/fifo_open Makefile fifo_open.c >> Log: >> Add fifo_open, a basic regression test for opening fifos, which tests >> the blocking and non-blocking forms of open based on the POSIX spec for >> now O_NONBLOCK should be handled. > > I assume we aren't going to follow the useless POSIX spec for handling > O_NONBLOCK'ing reads wrt select and friends? If you're interested in a > basic test case, I can send you one... > > (That selecting on a fifo for read that doesn't have a writer will > return true, due to the fact that EOF is available for reading on a > O_NONBLOCK fifo.) PRs 76144 and 76525 give test cases for how not following the useful POSIX spec (for this and more directly by not even considering setting POLLHUP for poll()) breaks things. Perhaps the correct behaviour is for select() and poll() to return on EOF iff the EOF has occurred while there are any readers or any data. EOF should be sticky but not persist forever. It must be fairly sticky so that readers don't have races seeing it, and it must not persist forever so that POLLHUP works right for more than 1 "connection" to the fifo. I think a "connection" to a fifo should persist until not only all readers and writers have gone away, but until all data has been read and maybe for a few msec longer of inactivity to give straggling readers a chance to see the "hangup". Bruce From owner-cvs-src@FreeBSD.ORG Tue Sep 13 05:59:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1392E16A41F; Tue, 13 Sep 2005 05:59:08 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C496E43D45; Tue, 13 Sep 2005 05:59:07 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D5x7oh019847; Tue, 13 Sep 2005 05:59:07 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D5x7hN019846; Tue, 13 Sep 2005 05:59:07 GMT (envelope-from grehan) Message-Id: <200509130559.j8D5x7hN019846@repoman.freebsd.org> From: Peter Grehan Date: Tue, 13 Sep 2005 05:59:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/etc.powerpc ttys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 05:59:08 -0000 grehan 2005-09-13 05:59:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/etc.powerpc ttys Log: MFC 1.3 Comment out ofw_console 'screen' entry and zs tty entries. The OpenFirmware console isn't used on real systems anymore and I never get to multi-user mode in psim. There are problems with zs that need to be resolved before these lines can be enabled. This eliminates disconcerting warnings on boot. Approved by: re (Ken Smith) Revision Changes Path 1.1.8.2 +3 -3 src/etc/etc.powerpc/ttys From owner-cvs-src@FreeBSD.ORG Tue Sep 13 06:46:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1526816A41F; Tue, 13 Sep 2005 06:46:04 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 386AE43D45; Tue, 13 Sep 2005 06:46:02 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 455156156; Tue, 13 Sep 2005 08:45:47 +0200 (CEST) Received: from xps.des.no (des.no [80.203.228.37]) by tim.des.no (Postfix) with ESMTP id D21706152; Tue, 13 Sep 2005 08:45:46 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id AD12A33E48; Tue, 13 Sep 2005 08:45:56 +0200 (CEST) To: Robert Watson References: <200509071006.j87A6E8s012380@repoman.freebsd.org> <20050911222701.W33344@fledge.watson.org> <20050912013616.GA78451@dragon.NUXI.org> <20050912094446.P33344@fledge.watson.org> <20050912181727.GA96329@dragon.NUXI.org> <20050912192330.P96771@fledge.watson.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Tue, 13 Sep 2005 08:45:56 +0200 In-Reply-To: <20050912192330.P96771@fledge.watson.org> (Robert Watson's message of "Mon, 12 Sep 2005 19:28:51 +0100 (BST)") Message-ID: <86r7btqxcr.fsf@xps.des.no> User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Tests: ALL_TRUSTED,AWL,BAYES_00 X-Spam-Learn: ham X-Spam-Score: -5.2/3.0 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on tim.des.no Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien Subject: Re: cvs commit: src/sys/kern kern_tc.c src/sys/net rtsock.c src/sys/netipx ipx_proto.c src/sys/netnatm natm_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 06:46:04 -0000 Robert Watson writes: > Easy to do it with config, a pain to do it with a complete toolchain. $ cd ~/freebsd/head/src $ __MAKE_CONF=3D$PWD/make.conf make kernel-toolchain buildkernel DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Tue Sep 13 07:10:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 305C316A41F; Tue, 13 Sep 2005 07:10:33 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E40743D53; Tue, 13 Sep 2005 07:10:31 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8D7AUb6078389; Tue, 13 Sep 2005 10:10:30 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 27605-18; Tue, 13 Sep 2005 10:10:29 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8D7AJwY078377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Sep 2005 10:10:24 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8D7AWRN069332; Tue, 13 Sep 2005 10:10:32 +0300 (EEST) (envelope-from ru) Date: Tue, 13 Sep 2005 10:10:31 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20050913071031.GE37280@ip.net.ua> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> <20050912010034.GA77819@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DO5DiztRLs659m5i" Content-Disposition: inline In-Reply-To: <20050912010034.GA77819@dragon.NUXI.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Nate Lawson Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 07:10:33 -0000 --DO5DiztRLs659m5i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Sep 11, 2005 at 06:00:34PM -0700, David O'Brien wrote: > On Sun, Sep 11, 2005 at 02:49:25PM -0700, Nate Lawson wrote: > > David O'Brien wrote: > > >I was going to just install kernel.sym instead of a kernel with symbol= s, > > >but kgdb's usage doesn't claim to support '-s' as the previous kgdb di= d. > >=20 > > kernel.sym would be better since it wouldn't have the duplication that= =20 > > kernel and kernel.debug have. >=20 > Duplication in RELENG_* or in HEAD? >=20 > > Alternately, we can make loader(8) skip=20 > > symbol sections when booting and just install kernel.debug >=20 > That *is* what my change does - except it calls it "kernel" so there > aren't loading issues. > =20 What was wrong with using installkernel.debug or "make installkernel -DINSTALL_DEBUG" (the latter is useful when you don't know if your kernel was compiled with debug or not)? IOW, why enforce it? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --DO5DiztRLs659m5i Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDJntnqRfpzJluFF4RAnKgAJ9RS18od6K2iyxxZVI4QZNVKvdoagCdEsZy W51GeAx5r+6pt4zlsPYEM9c= =pDLX -----END PGP SIGNATURE----- --DO5DiztRLs659m5i-- From owner-cvs-src@FreeBSD.ORG Tue Sep 13 07:25:10 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74A0516A420; Tue, 13 Sep 2005 07:25:10 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5F4B43D4C; Tue, 13 Sep 2005 07:25:09 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 9295B1FF9AC; Tue, 13 Sep 2005 09:25:07 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 23DF81FF931; Tue, 13 Sep 2005 09:25:05 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id DDA7915823; Tue, 13 Sep 2005 07:25:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id D3073157B9; Tue, 13 Sep 2005 07:25:01 +0000 (UTC) Date: Tue, 13 Sep 2005 07:25:01 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: David Schultz In-Reply-To: <200509122054.j8CKs1JI084501@repoman.freebsd.org> Message-ID: References: <200509122054.j8CKs1JI084501@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/amd64 s_scalbnf.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 07:25:10 -0000 On Mon, 12 Sep 2005, David Schultz wrote: > das 2005-09-12 20:54:00 UTC > > FreeBSD src repository > > Modified files: > lib/msun/amd64 s_scalbnf.S > Log: > Add a missing ldexpf() alias for amd64. > > Noticed by: bz@, tjr@ > > Revision Changes Path > 1.2 +3 -0 src/lib/msun/amd64/s_scalbnf.S thanks :-) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Tue Sep 13 08:27:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AB3116A41F; Tue, 13 Sep 2005 08:27:39 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 394C443D45; Tue, 13 Sep 2005 08:27:39 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D8RdQe027065; Tue, 13 Sep 2005 08:27:39 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D8RdGf027064; Tue, 13 Sep 2005 08:27:39 GMT (envelope-from nyan) Message-Id: <200509130827.j8D8RdGf027064@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Tue, 13 Sep 2005 08:27:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/pc98 Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 08:27:39 -0000 nyan 2005-09-13 08:27:39 UTC FreeBSD src repository Modified files: sys/boot/pc98 Makefile.inc Log: MFi386: revisions 1.10 and 1.11. - Add '-mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3' to CFLAGS. Revision Changes Path 1.6 +2 -1 src/sys/boot/pc98/Makefile.inc From owner-cvs-src@FreeBSD.ORG Tue Sep 13 08:29:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E36EC16A41F; Tue, 13 Sep 2005 08:29:04 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A224143D48; Tue, 13 Sep 2005 08:29:04 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D8T4tb027129; Tue, 13 Sep 2005 08:29:04 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D8T4Z0027128; Tue, 13 Sep 2005 08:29:04 GMT (envelope-from nyan) Message-Id: <200509130829.j8D8T4Z0027128@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Tue, 13 Sep 2005 08:29:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/pc98/libpc98 comconsole.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 08:29:05 -0000 nyan 2005-09-13 08:29:03 UTC FreeBSD src repository Modified files: sys/boot/pc98/libpc98 comconsole.c Log: MFi386: revision 1.11. Revision Changes Path 1.7 +108 -9 src/sys/boot/pc98/libpc98/comconsole.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 08:58:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22F1616A41F; Tue, 13 Sep 2005 08:58:40 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CEE843D48; Tue, 13 Sep 2005 08:58:38 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8D8wafv095299; Tue, 13 Sep 2005 11:58:36 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 34829-20; Tue, 13 Sep 2005 11:58:35 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8D8wZCM095296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Sep 2005 11:58:35 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8D8wmrN069471; Tue, 13 Sep 2005 11:58:48 +0300 (EEST) (envelope-from ru) Date: Tue, 13 Sep 2005 11:58:48 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20050913085848.GG37280@ip.net.ua> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> <20050912010034.GA77819@dragon.NUXI.org> <20050913071031.GE37280@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PMULwz+zIGJzpDN9" Content-Disposition: inline In-Reply-To: <20050913071031.GE37280@ip.net.ua> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 08:58:40 -0000 --PMULwz+zIGJzpDN9 Content-Type: multipart/mixed; boundary="FUaywKC54iCcLzqT" Content-Disposition: inline --FUaywKC54iCcLzqT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 13, 2005 at 10:10:31AM +0300, Ruslan Ermilov wrote: > Hi, >=20 > On Sun, Sep 11, 2005 at 06:00:34PM -0700, David O'Brien wrote: > > On Sun, Sep 11, 2005 at 02:49:25PM -0700, Nate Lawson wrote: > > > David O'Brien wrote: > > > >I was going to just install kernel.sym instead of a kernel with symb= ols, > > > >but kgdb's usage doesn't claim to support '-s' as the previous kgdb = did. > > >=20 > > > kernel.sym would be better since it wouldn't have the duplication tha= t=20 > > > kernel and kernel.debug have. > >=20 > > Duplication in RELENG_* or in HEAD? > >=20 > > > Alternately, we can make loader(8) skip=20 > > > symbol sections when booting and just install kernel.debug > >=20 > > That *is* what my change does - except it calls it "kernel" so there > > aren't loading issues. > > =20 > What was wrong with using installkernel.debug or "make installkernel > -DINSTALL_DEBUG" (the latter is useful when you don't know if your > kernel was compiled with debug or not)? IOW, why enforce it? >=20 I'm not saying the idea is necessarily bad, but I'm not at all happy about the implementation in rev. 1.84. Before this change, we had installkernel.debug installing both normal and *.debug versions of kernel and module objects, and gdb scripts. And that was consistent. Now, installkernel.debug no longer installs kernel.debug but continues to install both normal and *.debug module objects. Also, it's very uneasy now to revert the behavior to installing only normal objects when DEBUG is defined, e.g. for STABLE branches. The floppies.1 target of "make release" will now provide the debugging kernel as well. I'm not sure if this is good or not. To address all of this, I suggest to revert kern.post.mk to rev. 1.83 and just make INSTALL_DEBUG the default in HEAD when DEBUG is also set. Should this be also true for modules, I'm not sure. My only question is do we want to install both versions of kernel and module objects, like we did before, or install debug versions over normal ones. My favour is the former, because it's consistent with documentation and POLA in general. The only change in behavior would be that installkernel.debug now installs *both* normal and debug versions, while previously it only installed debug versions. I didn't make INSTALL_DEBUG default for modules in the attached patch because it consumes 64M on yesterday's amd64 build, and that looks like too much. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --FUaywKC54iCcLzqT Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=p Content-Transfer-Encoding: quoted-printable Index: kern.post.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/conf/kern.post.mk,v retrieving revision 1.83 diff -u -r1.83 kern.post.mk --- kern.post.mk 9 Jun 2005 05:38:18 -0000 1.83 +++ kern.post.mk 13 Sep 2005 08:44:55 -0000 @@ -66,6 +66,8 @@ .if !defined(DEBUG) FULLKERNEL=3D ${KERNEL_KO} .else +# In HEAD, we want to install .debug version by default. +INSTALL_DEBUG=3D FULLKERNEL=3D ${KERNEL_KO}.debug ${KERNEL_KO}: ${FULLKERNEL} ${OBJCOPY} --strip-debug ${FULLKERNEL} ${KERNEL_KO} @@ -207,17 +209,15 @@ mkdir -p ${DESTDIR}${KODIR} .if defined(DEBUG) && defined(INSTALL_DEBUG) ${INSTALL} -p -m 555 -o root -g wheel ${FULLKERNEL} ${DESTDIR}${KODIR} -.else - ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} .endif + ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} =20 kernel-reinstall: @-chflags -R noschg ${DESTDIR}${KODIR} .if defined(DEBUG) && defined(INSTALL_DEBUG) ${INSTALL} -p -m 555 -o root -g wheel ${FULLKERNEL} ${DESTDIR}${KODIR} -.else - ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} .endif + ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} =20 config.o env.o hints.o vers.o vnode_if.o: ${NORMAL_C} Index: kmod.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/conf/kmod.mk,v retrieving revision 1.193 diff -u -r1.193 kmod.mk --- kmod.mk 7 Sep 2005 17:38:46 -0000 1.193 +++ kmod.mk 13 Sep 2005 08:51:17 -0000 @@ -147,6 +147,8 @@ FULLPROG=3D ${PROG} .else FULLPROG=3D ${PROG}.debug +# In HEAD, we want to install .debug version by default. +#INSTALL_DEBUG=3D ${PROG}: ${FULLPROG} ${OBJCOPY} --strip-debug ${FULLPROG} ${PROG} .endif @@ -252,7 +254,7 @@ .if defined(DEBUG_FLAGS) && defined(INSTALL_DEBUG) ${INSTALL} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \ ${_INSTALLFLAGS} ${FULLPROG} ${DESTDIR}${KMODDIR} -.else +.endif ${INSTALL} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \ ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR} =20 @@ -268,7 +270,6 @@ kldxref ${DESTDIR}${KMODDIR}; \ fi .endif -.endif .endif # !target(realinstall) =20 .endif # !target(install) --FUaywKC54iCcLzqT-- --PMULwz+zIGJzpDN9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDJpTIqRfpzJluFF4RApU5AJwJqhl2tB6vWOXLz06QND/N5XhfkQCeMh+Z JSJ1L55OSEElin7oiOEI+AI= =CyWQ -----END PGP SIGNATURE----- --PMULwz+zIGJzpDN9-- From owner-cvs-src@FreeBSD.ORG Tue Sep 13 09:23:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB6C616A41F; Tue, 13 Sep 2005 09:23:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7726743D45; Tue, 13 Sep 2005 09:23:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8D9NNIS036516; Tue, 13 Sep 2005 09:23:23 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8D9NM7O036515; Tue, 13 Sep 2005 09:23:22 GMT (envelope-from rwatson) Message-Id: <200509130923.j8D9NM7O036515@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 09:23:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 09:23:24 -0000 rwatson 2005-09-13 09:23:22 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Annotate two issues: 1) fifo_kqfilter() is not actually ever used, it likely should be GC'd. 2) fifo_kqfilter_f() doesn't implement EVFILT_VNODE, so detecting events on the underlying vnode for a fifo no longer works (it did in 4.x). Likely, fifo_kqfilter_f() should forward the request to the VFS using fp->f_vnode, which would work once fifo_kqfilter() was detached from the vnode operation vector (removing the fifo override). Discussed with: phk Revision Changes Path 1.122 +12 -0 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 10:12:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F4F916A41F; Tue, 13 Sep 2005 10:12:29 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DBAF43D4C; Tue, 13 Sep 2005 10:12:29 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DACTFc038542; Tue, 13 Sep 2005 10:12:29 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DACTt6038541; Tue, 13 Sep 2005 10:12:29 GMT (envelope-from yongari) Message-Id: <200509131012.j8DACTt6038541@repoman.freebsd.org> From: Pyun YongHyeon Date: Tue, 13 Sep 2005 10:12:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci maestro3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 10:12:29 -0000 yongari 2005-09-13 10:12:28 UTC FreeBSD src repository Modified files: sys/dev/sound/pci maestro3.c Log: Unlock driver lock before calling resource_int_value(9). This should fix LOR(in fact it's not LOR) in device attach. Revision Changes Path 1.29 +3 -0 src/sys/dev/sound/pci/maestro3.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 10:33:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F178916A41F; Tue, 13 Sep 2005 10:33:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF26243D48; Tue, 13 Sep 2005 10:33:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DAXWLq039291; Tue, 13 Sep 2005 10:33:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DAXWco039290; Tue, 13 Sep 2005 10:33:32 GMT (envelope-from rwatson) Message-Id: <200509131033.j8DAXWco039290@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 10:33:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_misc fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 10:33:33 -0000 rwatson 2005-09-13 10:33:32 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_misc fifo_misc.c Log: Remove a debugging printf. Revision Changes Path 1.3 +0 -1 src/tools/regression/fifo/fifo_misc/fifo_misc.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 10:39:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AAD516A41F; Tue, 13 Sep 2005 10:39:24 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5968843D45; Tue, 13 Sep 2005 10:39:24 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DAdOM3039560; Tue, 13 Sep 2005 10:39:24 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DAdOdU039559; Tue, 13 Sep 2005 10:39:24 GMT (envelope-from rwatson) Message-Id: <200509131039.j8DAdOdU039559@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 10:39:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 10:39:24 -0000 rwatson 2005-09-13 10:39:24 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: As a result of kqueue locking work, socket buffer locks will always be held when entering a kqueue filter for fifos via a socket buffer event: as such, assert the lock unconditionally rather than acquiring it conditionall. MFC after: 3 days Revision Changes Path 1.123 +6 -18 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 11:33:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1B6416A41F; Tue, 13 Sep 2005 11:33:25 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B119D43D46; Tue, 13 Sep 2005 11:33:25 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DBXPSW041688; Tue, 13 Sep 2005 11:33:25 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DBXPKd041687; Tue, 13 Sep 2005 11:33:25 GMT (envelope-from nyan) Message-Id: <200509131133.j8DBXPKd041687@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Tue, 13 Sep 2005 11:33:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/cbus fdc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 11:33:26 -0000 nyan 2005-09-13 11:33:25 UTC FreeBSD src repository Modified files: sys/pc98/cbus fdc.c Log: Remove EPSON_NRDISK support. Revision Changes Path 1.161 +2 -177 src/sys/pc98/cbus/fdc.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 11:34:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 674C816A41F; Tue, 13 Sep 2005 11:34:08 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27C2943D46; Tue, 13 Sep 2005 11:34:08 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DBY85J041739; Tue, 13 Sep 2005 11:34:08 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DBY8Qt041738; Tue, 13 Sep 2005 11:34:08 GMT (envelope-from nyan) Message-Id: <200509131134.j8DBY8Qt041738@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Tue, 13 Sep 2005 11:34:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/pc98 epsonio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 11:34:08 -0000 nyan 2005-09-13 11:34:08 UTC FreeBSD src repository Modified files: sys/pc98/pc98 epsonio.h Log: Remove unused functions. Revision Changes Path 1.10 +0 -39 src/sys/pc98/pc98/epsonio.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:25:14 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EB0016A41F; Tue, 13 Sep 2005 12:25:14 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id D93CE43D64; Tue, 13 Sep 2005 12:25:10 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 6EF121FF931; Tue, 13 Sep 2005 14:25:08 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 0208B1FF91D; Tue, 13 Sep 2005 14:25:05 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id ACFBD157B9; Tue, 13 Sep 2005 12:21:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id AA4701577D; Tue, 13 Sep 2005 12:21:38 +0000 (UTC) Date: Tue, 13 Sep 2005 12:21:38 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Pyun YongHyeon In-Reply-To: <200509131012.j8DACTt6038541@repoman.freebsd.org> Message-ID: References: <200509131012.j8DACTt6038541@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci maestro3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:25:14 -0000 On Tue, 13 Sep 2005, Pyun YongHyeon wrote: > yongari 2005-09-13 10:12:28 UTC > > FreeBSD src repository > > Modified files: > sys/dev/sound/pci maestro3.c > Log: > Unlock driver lock before calling resource_int_value(9). > This should fix LOR(in fact it's not LOR) in device attach. it this LOR known on the LOR page? http://sources.zabbadoz.net/freebsd/lor.html -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:41:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7936C16A41F; Tue, 13 Sep 2005 12:41:06 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 133F443D48; Tue, 13 Sep 2005 12:41:06 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DCf5IV044709; Tue, 13 Sep 2005 12:41:05 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DCf5hC044708; Tue, 13 Sep 2005 12:41:05 GMT (envelope-from glebius) Message-Id: <200509131241.j8DCf5hC044708@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 12:41:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph ng_parse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:41:06 -0000 glebius 2005-09-13 12:41:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_parse.c Log: MFC 1.26 by ru: Fixed parsing of unsigned integers. Approved by: re (kensmith) Revision Changes Path 1.25.2.1 +4 -1 src/sys/netgraph/ng_parse.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:41:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9010D16A41F; Tue, 13 Sep 2005 12:41:53 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DD6943D46; Tue, 13 Sep 2005 12:41:53 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DCfrF8044830; Tue, 13 Sep 2005 12:41:53 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DCfrh6044829; Tue, 13 Sep 2005 12:41:53 GMT (envelope-from glebius) Message-Id: <200509131241.j8DCfrh6044829@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 12:41:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/netgraph ng_parse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:41:53 -0000 glebius 2005-09-13 12:41:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netgraph ng_parse.c Log: MFC 1.26 by ru: Fixed parsing of unsigned integers. Revision Changes Path 1.23.2.2 +4 -1 src/sys/netgraph/ng_parse.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:43:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCC3816A41F; Tue, 13 Sep 2005 12:43:15 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8ACA643D45; Tue, 13 Sep 2005 12:43:15 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DChFpe044926; Tue, 13 Sep 2005 12:43:15 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DChFPq044925; Tue, 13 Sep 2005 12:43:15 GMT (envelope-from glebius) Message-Id: <200509131243.j8DChFPq044925@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 12:43:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph ng_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:43:16 -0000 glebius 2005-09-13 12:43:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_socket.c Log: MFC 1.68 by obrien: Fix missing '=' in structure initialization. Approved by: re (kensmith) Revision Changes Path 1.67.2.1 +1 -1 src/sys/netgraph/ng_socket.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:44:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0C1316A41F; Tue, 13 Sep 2005 12:44:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F8C043D49; Tue, 13 Sep 2005 12:44:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DCiJod045021; Tue, 13 Sep 2005 12:44:19 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DCiJQ5045020; Tue, 13 Sep 2005 12:44:19 GMT (envelope-from glebius) Message-Id: <200509131244.j8DCiJQ5045020@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 12:44:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph ng_split.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:44:19 -0000 glebius 2005-09-13 12:44:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_split.c Log: MFC 1.7: Plug item leak in case when not all hooks are connected. Found by: David Vos Approved by: re (kensmith) Revision Changes Path 1.6.2.1 +3 -0 src/sys/netgraph/ng_split.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:44:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27FCA16A41F; Tue, 13 Sep 2005 12:44:56 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB13143D45; Tue, 13 Sep 2005 12:44:55 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DCitGd045067; Tue, 13 Sep 2005 12:44:55 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DCitlu045066; Tue, 13 Sep 2005 12:44:55 GMT (envelope-from glebius) Message-Id: <200509131244.j8DCitlu045066@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 12:44:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/netgraph ng_split.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:44:56 -0000 glebius 2005-09-13 12:44:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netgraph ng_split.c Log: MFC 1.7: Plug item leak in case when not all hooks are connected. Found by: David Vos Revision Changes Path 1.4.2.1 +3 -0 src/sys/netgraph/ng_split.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 12:58:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id C1ED916A420; Tue, 13 Sep 2005 12:58:20 +0000 (GMT) Date: Tue, 13 Sep 2005 12:58:20 +0000 From: Alexey Dokuchaev To: David O'Brien Message-ID: <20050913125820.GA10663@FreeBSD.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050912165518.GA94181@dragon.NUXI.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 12:58:20 -0000 On Mon, Sep 12, 2005 at 09:55:18AM -0700, David O'Brien wrote: > On Mon, Sep 12, 2005 at 02:58:42AM -0700, Colin Percival wrote: > > Emanuel Strobl wrote: > > > Hmm, why was default size of root changed to 500M? > > > > Because I was increasing the sizes of /tmp and /var at the same time; because > > I know that some users do somehow manage to fill up /; and because re@ told > > me to. :-) > > Perhaps we should follow what SGI and Sun has done for years on its > workstations: a combined / + /var + /usr. We would make it 15GB and be > done with it. My laptop has a combined /+/var+/usr of 12GB and I have > multiple kernels installed and room in swap for a crashdump. AFAIK, we still do not turn softupdates on /, but do on other partitions. With your proposed idea, softupdates should be on on /. How safe is this today? ./danfe From owner-cvs-src@FreeBSD.ORG Tue Sep 13 13:34:03 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65B4116A41F; Tue, 13 Sep 2005 13:34:03 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9714C43D46; Tue, 13 Sep 2005 13:34:02 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5C5BB.dip.t-dialin.net [84.165.197.187]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id j8DDMSBc067365; Tue, 13 Sep 2005 15:22:42 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id j8DDXDRi064479; Tue, 13 Sep 2005 15:33:14 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by netchild.homeip.net (Horde MIME library) with HTTP; Tue, 13 Sep 2005 15:33:13 +0200 Message-ID: <20050913153313.q2hwaarrk8cwckkg@netchild.homeip.net> X-Priority: 3 (Normal) Date: Tue, 13 Sep 2005 15:33:13 +0200 From: Alexander Leidinger To: Alexey Dokuchaev References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> In-Reply-To: <20050913125820.GA10663@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, David O'Brien Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 13:34:03 -0000 Alexey Dokuchaev wrote: > AFAIK, we still do not turn softupdates on /, but do on other > partitions. With your proposed idea, softupdates should be on on /. > How safe is this today? The reason why we don't enable SU on / is that an installworld may fail on a filled up FS even when it would succeed in a SU disabled environment. This *may* not be case anymore since someone changed some internal behavior (you will see instant updates in df instead of delayed ones since 5.x), but this is pure speculation, I don't know for sure. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Nobody wants constructive criticism. It's all we can do to put up with constructive praise. From owner-cvs-src@FreeBSD.ORG Tue Sep 13 13:56:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCC0C16A41F; Tue, 13 Sep 2005 13:56:23 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 730A343D45; Tue, 13 Sep 2005 13:56:23 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DDuNZr055182; Tue, 13 Sep 2005 13:56:23 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DDuNBi055181; Tue, 13 Sep 2005 13:56:23 GMT (envelope-from andre) Message-Id: <200509131356.j8DDuNBi055181@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 13 Sep 2005 13:56:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 13:56:24 -0000 andre 2005-09-13 13:56:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet tcp_subr.c Log: MFC rev. 1.233: Fix ICMP_UNREACH_NEEDFRAG case where no MTU was proposed in the ICMP reply. PR: kern/81813 Submitted by: Vitezslav Novy Approved by: re (kensmith) Revision Changes Path 1.228.2.2 +3 -2 src/sys/netinet/tcp_subr.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:31:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBD2B16A41F; Tue, 13 Sep 2005 14:31:34 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79FC143D45; Tue, 13 Sep 2005 14:31:34 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DEVY0O056634; Tue, 13 Sep 2005 14:31:34 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DEVY0X056633; Tue, 13 Sep 2005 14:31:34 GMT (envelope-from maxim) Message-Id: <200509131431.j8DEVY0X056633@repoman.freebsd.org> From: Maxim Konovalov Date: Tue, 13 Sep 2005 14:31:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/periodic/security 550.ipfwlimit X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:31:34 -0000 maxim 2005-09-13 14:31:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/periodic/security 550.ipfwlimit Log: MFC rev. 1.10: postpone a temporary file creation until we realize if ipfw(4) ever used. Approved by: re (scottl) Revision Changes Path 1.7.2.2 +1 -1 src/etc/periodic/security/550.ipfwlimit From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:34:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 325FD16A41F; Tue, 13 Sep 2005 14:34:12 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B542143D45; Tue, 13 Sep 2005 14:34:11 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DEYBR4056709; Tue, 13 Sep 2005 14:34:11 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DEYBHi056708; Tue, 13 Sep 2005 14:34:11 GMT (envelope-from maxim) Message-Id: <200509131434.j8DEYBHi056708@repoman.freebsd.org> From: Maxim Konovalov Date: Tue, 13 Sep 2005 14:34:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/etc/periodic/security 550.ipfwlimit X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:34:12 -0000 maxim 2005-09-13 14:34:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) etc/periodic/security 550.ipfwlimit Log: MFC rev. 1.10: postpone a temporary file creation until we realize if ipfw(4) ever used. Approved by: re (scottl) Revision Changes Path 1.6.4.2 +1 -1 src/etc/periodic/security/550.ipfwlimit From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:37:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E8C916A41F; Tue, 13 Sep 2005 14:37:59 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E07C943D45; Tue, 13 Sep 2005 14:37:58 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DEbw8j056904; Tue, 13 Sep 2005 14:37:58 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DEbwJX056903; Tue, 13 Sep 2005 14:37:58 GMT (envelope-from glebius) Message-Id: <200509131437.j8DEbwJX056903@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 13 Sep 2005 14:37:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet if_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:37:59 -0000 glebius 2005-09-13 14:37:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet if_ether.c Log: MFC 1.141: - Do not hold route entry lock, when calling arprequest(). One such call was introduced by me in 1.139, the other one was present before. - Do all manipulations with rtentry and la before dropping the lock. - Copy interface address from route into local variable before dropping the lock. Supply this copy as argument to arprequest(). (LOR Ids in original commit message.) Approved by: re (scottl) Revision Changes Path 1.137.2.3 +17 -9 src/sys/netinet/if_ether.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:44:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6690116A41F; Tue, 13 Sep 2005 14:44:10 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D65F43D75; Tue, 13 Sep 2005 14:44:08 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DEi8Wh057156; Tue, 13 Sep 2005 14:44:08 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DEi8t2057155; Tue, 13 Sep 2005 14:44:08 GMT (envelope-from andre) Message-Id: <200509131444.j8DEi8t2057155@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 13 Sep 2005 14:44:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:44:10 -0000 andre 2005-09-13 14:44:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netinet tcp_subr.c Log: MFC rev. 1.233: Fix ICMP_UNREACH_NEEDFRAG case where no MTU was proposed in the ICMP reply. PR: kern/81813 Submitted by: Vitezslav Novy Revision Changes Path 1.201.2.22 +3 -2 src/sys/netinet/tcp_subr.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:53:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9E4A16A420; Tue, 13 Sep 2005 14:53:58 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6FD043D5F; Tue, 13 Sep 2005 14:53:56 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id BF4AB1A4D81; Tue, 13 Sep 2005 07:53:56 -0700 (PDT) Date: Tue, 13 Sep 2005 07:53:56 -0700 From: Alfred Perlstein To: Robert Watson Message-ID: <20050913145356.GO91162@elvis.mu.org> References: <200407041052.i64Aqs78039847@repoman.freebsd.org> <20050912195632.V96771@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050912195632.V96771@fledge.watson.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_event.c vfs_mount.c vfs_subr.c src/sys/sys event.h mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:53:59 -0000 * Robert Watson [050912 11:58] wrote: > > On Sun, 4 Jul 2004, Alfred Perlstein wrote: > > > Modified files: > > sys/kern kern_event.c vfs_mount.c vfs_subr.c > > sys/sys event.h mount.h > > Log: > > Introduce a new kevent filter. EVFILT_FS that will be used to signal > > generic filesystem events to userspace. Currently only mount and unmount > > of filesystems are signalled. Soon to be added, up/down status of NFS. > > > > Introduce a sysctl node used to route requests to/from filesystems > > based on filesystem ids. > > > > Introduce a new vfsop, vfs_sysctl(mp, req) that is used as the callback/ > > entrypoint by the sysctl code to change individual filesystems. > > Do you have any plans to update kqueue(2) to describe EVFILT_FS? Right > now, the existing filter types appear to have useful summaries of what > they represent, and information on how they are used with objects. This > would be quite useful to have for EVFILT_FS also. Everytime I touch FreeBSD something painful happens to me, I'll pass. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Tue Sep 13 14:58:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B556F16A41F; Tue, 13 Sep 2005 14:58:55 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from tomoyo.MyBSD.org.my (tomoyo.mybsd.org.my [202.157.186.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9BEA43D45; Tue, 13 Sep 2005 14:58:54 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from localhost (localhost [127.0.0.1]) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id CC11A6CC42; Tue, 13 Sep 2005 23:06:52 +0800 (MYT) Received: from tomoyo.MyBSD.org.my ([127.0.0.1]) by localhost (tomoyo.MyBSD.org.my [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49510-01; Tue, 13 Sep 2005 23:06:51 +0800 (MYT) Received: from kasumi.MyBSD.org.my (unknown [218.111.181.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id 6E3E86CC24; Tue, 13 Sep 2005 23:06:48 +0800 (MYT) Date: Tue, 13 Sep 2005 22:59:27 +0800 From: Ariff Abdullah To: "Bjoern A. Zeeb" Message-Id: <20050913225927.0c211113.skywizard@MyBSD.org.my> In-Reply-To: References: <200509131012.j8DACTt6038541@repoman.freebsd.org> Organization: MyBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-antivirus-mail-gateway at TOMOYO.MYBSD.ORG.MY Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, yongari@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci maestro3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 14:58:56 -0000 On Tue, 13 Sep 2005 12:21:38 +0000 (UTC) "Bjoern A. Zeeb" wrote: > On Tue, 13 Sep 2005, Pyun YongHyeon wrote: > > > yongari 2005-09-13 10:12:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/sound/pci maestro3.c > > Log: > > Unlock driver lock before calling resource_int_value(9). > > This should fix LOR(in fact it's not LOR) in device attach. > > it this LOR known on the LOR page? > http://sources.zabbadoz.net/freebsd/lor.html > Not known, but possible. Also, LOR #038 and #112 has been patched. -- Ariff Abdullah MyBSD http://www.MyBSD.org.my (IPv6/IPv4) http://staff.MyBSD.org.my (IPv6/IPv4) http://tomoyo.MyBSD.org.my (IPv6/IPv4) From owner-cvs-src@FreeBSD.ORG Tue Sep 13 15:16:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A75B116A41F; Tue, 13 Sep 2005 15:16:50 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7948143D45; Tue, 13 Sep 2005 15:16:50 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DFGovu058486; Tue, 13 Sep 2005 15:16:50 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DFGoW3058485; Tue, 13 Sep 2005 15:16:50 GMT (envelope-from jhb) Message-Id: <200509131516.j8DFGoW3058485@repoman.freebsd.org> From: John Baldwin Date: Tue, 13 Sep 2005 15:16:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 mutex.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 15:16:50 -0000 jhb 2005-09-13 15:16:50 UTC FreeBSD src repository Modified files: share/man/man9 mutex.9 Log: Various and sundry improvements: - Replace 'process' with 'thread' everywhere. - Update several places to note that that the fact that default mutexes may adaptively spin isn't necessarily MD, but is just part of the implementation as a whole. - Clarify the text about MTX_SPIN mutexes only being appropriate for INTR_FAST interrupts or other low level scheduler code to make the jargon more FreeBSD-ish rather than BSD/OS-ish. - Also, note that it is possible that interrupts aren't blocked but just deferred when a spin lock is held (the whole blocked vs. deferred bit is an MD implementation detail). - Remove statements saying that spin locks must be released in the exact opposite order that they were acquired. This stopped being true several years ago when we first added critical sections that stored their state in the current thread rather than in struct mtx. - Note that a mutex must be initialized before it is passed to any other mutex function, not just mtx_lock. - Clarify that mtx_trylock() only operates on MTX_DEF mutexes. - Simplify the text about possible preemption during a mtx_unlock(). - Use complete English sentences in place of phrases in a few places. - Clarify that it isn't ever safe to sleep with a mutex held. The kernel tends to panic when you do that. Requested by: scottl (7) MFC after: 3 days Revision Changes Path 1.48 +46 -49 src/share/man/man9/mutex.9 From owner-cvs-src@FreeBSD.ORG Tue Sep 13 15:23:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E09816A44A; Tue, 13 Sep 2005 15:23:27 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEB9543D48; Tue, 13 Sep 2005 15:23:26 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DFNQAR058764; Tue, 13 Sep 2005 15:23:26 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DFNQa0058763; Tue, 13 Sep 2005 15:23:26 GMT (envelope-from jkoshy) Message-Id: <200509131523.j8DFNQa0058763@repoman.freebsd.org> From: Joseph Koshy Date: Tue, 13 Sep 2005 15:23:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 15:23:27 -0000 jkoshy 2005-09-13 15:23:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pmcstat pmcstat.c Log: MFC r1.9: Improve an error message. Approved by: re (kensmith) Revision Changes Path 1.6.2.3 +2 -2 src/usr.sbin/pmcstat/pmcstat.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 15:29:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1347216A41F; Tue, 13 Sep 2005 15:29:40 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id B459143D45; Tue, 13 Sep 2005 15:29:39 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j8DFTcOJ085202; Tue, 13 Sep 2005 08:29:39 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20050913125820.GA10663@FreeBSD.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Tue, 13 Sep 2005 08:29:38 -0700 To: Alexey Dokuchaev X-Mailer: Apple Mail (2.734) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 15:29:40 -0000 On Sep 13, 2005, at 5:58 AM, Alexey Dokuchaev wrote: > On Mon, Sep 12, 2005 at 09:55:18AM -0700, David O'Brien wrote: > >> On Mon, Sep 12, 2005 at 02:58:42AM -0700, Colin Percival wrote: >> >>> Emanuel Strobl wrote: >>> >>>> Hmm, why was default size of root changed to 500M? >>>> >>> >>> Because I was increasing the sizes of /tmp and /var at the same >>> time; because >>> I know that some users do somehow manage to fill up /; and >>> because re@ told >>> me to. :-) >>> >> >> Perhaps we should follow what SGI and Sun has done for years on its >> workstations: a combined / + /var + /usr. We would make it 15GB >> and be >> done with it. My laptop has a combined /+/var+/usr of 12GB and I >> have >> multiple kernels installed and room in swap for a crashdump. >> > > AFAIK, we still do not turn softupdates on /, but do on other > partitions. With your proposed idea, softupdates should be on on /. > How safe is this today? I never use separate partitions for /usr and /var on my scratch boxes and I always enable SU on /. I can't say I've ever had any problems. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Tue Sep 13 15:45:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF7C716A41F; Tue, 13 Sep 2005 15:45:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1492443D46; Tue, 13 Sep 2005 15:45:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 3B81046B9D; Tue, 13 Sep 2005 11:45:34 -0400 (EDT) Date: Tue, 13 Sep 2005 16:45:33 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20050913145356.GO91162@elvis.mu.org> Message-ID: <20050913164445.U23515@fledge.watson.org> References: <200407041052.i64Aqs78039847@repoman.freebsd.org> <20050912195632.V96771@fledge.watson.org> <20050913145356.GO91162@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_event.c vfs_mount.c vfs_subr.c src/sys/sys event.h mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 15:45:36 -0000 On Tue, 13 Sep 2005, Alfred Perlstein wrote: >>> Introduce a new kevent filter. EVFILT_FS that will be used to signal >>> generic filesystem events to userspace. Currently only mount and >>> unmount of filesystems are signalled. Soon to be added, up/down >>> status of NFS. >>> >>> Introduce a sysctl node used to route requests to/from filesystems >>> based on filesystem ids. >>> >>> Introduce a new vfsop, vfs_sysctl(mp, req) that is used as the >>> callback/ entrypoint by the sysctl code to change individual >>> filesystems. >> >> Do you have any plans to update kqueue(2) to describe EVFILT_FS? >> Right now, the existing filter types appear to have useful summaries of >> what they represent, and information on how they are used with objects. >> This would be quite useful to have for EVFILT_FS also. > > Everytime I touch FreeBSD something painful happens to me, I'll pass. If you have any rough notes, I'm happy to experience nroff on your behalf. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Tue Sep 13 15:49:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5786316A41F; Tue, 13 Sep 2005 15:49:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 152FE43D45; Tue, 13 Sep 2005 15:49:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DFnC3Y059650; Tue, 13 Sep 2005 15:49:12 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DFnC2Q059649; Tue, 13 Sep 2005 15:49:12 GMT (envelope-from rwatson) Message-Id: <200509131549.j8DFnC2Q059649@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 15:49:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_io fifo_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 15:49:13 -0000 rwatson 2005-09-13 15:49:12 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_io fifo_io.c Log: Teach fifo_io how to use ioctl(FIONREAD) to determine if a fifo is readable, and use that in addition to poll+select+kqueue to verify appropriate readability. Revision Changes Path 1.4 +95 -6 src/tools/regression/fifo/fifo_io/fifo_io.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 16:04:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E797E16A449; Tue, 13 Sep 2005 16:04:56 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AA5043D49; Tue, 13 Sep 2005 16:04:56 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DG4u1v060335; Tue, 13 Sep 2005 16:04:56 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DG4uL8060334; Tue, 13 Sep 2005 16:04:56 GMT (envelope-from csjp) Message-Id: <200509131604.j8DG4uL8060334@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Tue, 13 Sep 2005 16:04:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/bpfstat Makefile bpfstat.8 bpfstat.c bpfstat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 16:04:57 -0000 csjp 2005-09-13 16:04:56 UTC FreeBSD src repository Removed files: tools/tools/bpfstat Makefile bpfstat.8 bpfstat.c bpfstat.h Log: Garbage collect bpfstat. This is handled by netstat now. Requested by: rwatson Revision Changes Path 1.2 +0 -17 src/tools/tools/bpfstat/Makefile (dead) 1.2 +0 -83 src/tools/tools/bpfstat/bpfstat.8 (dead) 1.4 +0 -266 src/tools/tools/bpfstat/bpfstat.c (dead) 1.2 +0 -53 src/tools/tools/bpfstat/bpfstat.h (dead) From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:05:10 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22BC616A41F; Tue, 13 Sep 2005 17:05:10 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id A085F43D46; Tue, 13 Sep 2005 17:05:09 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 696D51FF9A8; Tue, 13 Sep 2005 19:05:07 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 0D0DE1FF9A7; Tue, 13 Sep 2005 19:05:05 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 799E7157B9; Tue, 13 Sep 2005 17:01:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 76A941577D; Tue, 13 Sep 2005 17:01:42 +0000 (UTC) Date: Tue, 13 Sep 2005 17:01:42 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Ariff Abdullah In-Reply-To: <20050913225927.0c211113.skywizard@MyBSD.org.my> Message-ID: References: <200509131012.j8DACTt6038541@repoman.freebsd.org> <20050913225927.0c211113.skywizard@MyBSD.org.my> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, yongari@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci maestro3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:05:10 -0000 On Tue, 13 Sep 2005, Ariff Abdullah wrote: > On Tue, 13 Sep 2005 12:21:38 +0000 (UTC) > "Bjoern A. Zeeb" wrote: > > On Tue, 13 Sep 2005, Pyun YongHyeon wrote: > > > > > yongari 2005-09-13 10:12:28 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/sound/pci maestro3.c > > > Log: > > > Unlock driver lock before calling resource_int_value(9). > > > This should fix LOR(in fact it's not LOR) in device attach. > > > > it this LOR known on the LOR page? > > http://sources.zabbadoz.net/freebsd/lor.html > > > Not known, but possible. ok. > Also, LOR #038 and #112 has been patched. could you please point me to the commit messages on the docs.freebsd.org archive or give mr the Message-IDs of the commit messages. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:15:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3053816A41F; Tue, 13 Sep 2005 17:15:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0184943D45; Tue, 13 Sep 2005 17:15:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHF58G070180; Tue, 13 Sep 2005 17:15:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHF5Bg070179; Tue, 13 Sep 2005 17:15:05 GMT (envelope-from rwatson) Message-Id: <200509131715.j8DHF5Bg070179@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 17:15:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_io fifo_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:15:06 -0000 rwatson 2005-09-13 17:15:05 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_io fifo_io.c Log: Restructure fifo_io event-related tests in order to support test cases relating to O_RDWR file descriptors, which while not defined in POSIX, are in fact used: (1) Revise assumption that we have two file descriptors when testing I/O operations on a fifo. Provide cleanup routines that handle either two or three file descriptors (including a kqueue descriptor). (2) Add an openfifo_rw() routine to supplement openfifo(). (3) kqueue_setup() now configures an existing kqueue to monitor a new file descriptor, rather than allocating a new kqueue to monitor two existing file descriptors. (4) Wrap all direct poll/select/kqueue/FIONREAD interactions in a single function, assert_status(), which takes a file descriptor, kqueue descriptor, assertion of read/writable/exception states, and test description, then tests the assertion. This reduces the bulk of calls in many of the tests, making them shorter, more readable, and easier to determine correct. (5) Add a new test_events_rdwr() function, which performs a basic create/ write/read event test on a O_RDWR fifo file descriptor. This is currently failed by our fifo code in HEAD due to a bug in FIONREAD handling. Fix to be merged shortly. Revision Changes Path 1.5 +322 -480 src/tools/regression/fifo/fifo_io/fifo_io.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:25:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41E8516A41F; Tue, 13 Sep 2005 17:25:35 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from tomoyo.MyBSD.org.my (tomoyo.mybsd.org.my [202.157.186.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id E61F843D49; Tue, 13 Sep 2005 17:25:30 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from localhost (localhost [127.0.0.1]) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id 1C4876CC41; Wed, 14 Sep 2005 01:33:28 +0800 (MYT) Received: from tomoyo.MyBSD.org.my ([127.0.0.1]) by localhost (tomoyo.MyBSD.org.my [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 50754-01; Wed, 14 Sep 2005 01:33:27 +0800 (MYT) Received: from kasumi.MyBSD.org.my (unknown [218.111.181.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id 507426CC3D; Wed, 14 Sep 2005 01:33:19 +0800 (MYT) Date: Wed, 14 Sep 2005 01:25:51 +0800 From: Ariff Abdullah To: "Bjoern A. Zeeb" Message-Id: <20050914012551.768820e4.skywizard@MyBSD.org.my> In-Reply-To: References: <200509131012.j8DACTt6038541@repoman.freebsd.org> <20050913225927.0c211113.skywizard@MyBSD.org.my> Organization: MyBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-antivirus-mail-gateway at TOMOYO.MYBSD.ORG.MY Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, yongari@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pci maestro3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:25:35 -0000 On Tue, 13 Sep 2005 17:01:42 +0000 (UTC) "Bjoern A. Zeeb" wrote: > On Tue, 13 Sep 2005, Ariff Abdullah wrote: > > > On Tue, 13 Sep 2005 12:21:38 +0000 (UTC) > > "Bjoern A. Zeeb" wrote: > > > On Tue, 13 Sep 2005, Pyun YongHyeon wrote: > > > > > > > yongari 2005-09-13 10:12:28 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/sound/pci maestro3.c > > > > Log: > > > > Unlock driver lock before calling resource_int_value(9). > > > > This should fix LOR(in fact it's not LOR) in device attach. > > > > > > it this LOR known on the LOR page? > > > http://sources.zabbadoz.net/freebsd/lor.html > > > > > Not known, but possible. > > ok. > > > Also, LOR #038 and #112 has been patched. > > could you please point me to the commit messages on the > docs.freebsd.org archive or give mr the Message-IDs of the commit > messages. > #038 was ad1816.c, #112 was ess.c. Both are from http://lists.freebsd.org/pipermail/cvs-src/2005-July/050241.html -- Ariff Abdullah MyBSD http://www.MyBSD.org.my (IPv6/IPv4) http://staff.MyBSD.org.my (IPv6/IPv4) http://tomoyo.MyBSD.org.my (IPv6/IPv4) From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:25:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1815116A4E2; Tue, 13 Sep 2005 17:25:40 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6859B43D69; Tue, 13 Sep 2005 17:25:36 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHPajA070804; Tue, 13 Sep 2005 17:25:36 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHPa15070803; Tue, 13 Sep 2005 17:25:36 GMT (envelope-from rwatson) Message-Id: <200509131725.j8DHPa15070803@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 17:25:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fifo/fifo_misc fifo_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:25:40 -0000 rwatson 2005-09-13 17:25:36 UTC FreeBSD src repository Modified files: tools/regression/fifo/fifo_misc fifo_misc.c Log: Add two small tests to set and clear two file I/O flags using ioctl on a fifo: FIONBIO, FIOASYNC. Revision Changes Path 1.4 +77 -0 src/tools/regression/fifo/fifo_misc/fifo_misc.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:41:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F305B16A41F; Tue, 13 Sep 2005 17:41:53 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91A7A43D55; Tue, 13 Sep 2005 17:41:48 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHfm1K071552; Tue, 13 Sep 2005 17:41:48 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHfmY5071551; Tue, 13 Sep 2005 17:41:48 GMT (envelope-from imp) Message-Id: <200509131741.j8DHfmY5071551@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 17:41:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccard pccardvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:41:54 -0000 imp 2005-09-13 17:41:48 UTC FreeBSD src repository Modified files: sys/dev/pccard pccardvar.h Log: MFp4: Remove stale functions. Revision Changes Path 1.55 +0 -21 src/sys/dev/pccard/pccardvar.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:46:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E07416A41F; Tue, 13 Sep 2005 17:46:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0991243D48; Tue, 13 Sep 2005 17:46:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHkmap071793; Tue, 13 Sep 2005 17:46:48 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHkmVU071792; Tue, 13 Sep 2005 17:46:48 GMT (envelope-from rwatson) Message-Id: <200509131746.j8DHkmVU071792@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 17:46:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:46:49 -0000 rwatson 2005-09-13 17:46:48 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Trim down now (believed to be) unused fifo_ioctl() and fifo_kqfilter() VOP implementations, since they in theory are used only on open file descriptors, in which case the ioctls are via fifo_ioctl_f() and kqueue requests are via fifo_kqfilter_f(). Generate warnings if they are entered for now. These printf() calls should become panic() calls. Annotate and re-implement fifo_ioctl_f(): don't arbitrarily forward ioctls to the socket layer, only forward the ones we explicitly support for fifos. In the case of FIONREAD, don't forward the request to the write socket on a read-write fifo, or the read result is overwritten. Annotate a nasty case for the undefined POSIX O_RDWR on fifos, in which failure of the second ioctl will result in the socket pair being in an inconsistent state. Assert copyright as I find myself rewriting non-trivial parts of fifofs. MFC after: 3 days Revision Changes Path 1.124 +75 -65 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:49:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C170416A41F; Tue, 13 Sep 2005 17:49:47 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 813AC43D48; Tue, 13 Sep 2005 17:49:47 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHnlJt071880; Tue, 13 Sep 2005 17:49:47 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHnlFn071879; Tue, 13 Sep 2005 17:49:47 GMT (envelope-from imp) Message-Id: <200509131749.j8DHnlFn071879@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 17:49:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccard pccard.c pccardvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:49:48 -0000 imp 2005-09-13 17:49:47 UTC FreeBSD src repository Modified files: sys/dev/pccard pccard.c pccardvar.h Log: Define and use PCCARD_MEM_PAGE_SIZE. Revision Changes Path 1.109 +1 -1 src/sys/dev/pccard/pccard.c 1.56 +2 -0 src/sys/dev/pccard/pccardvar.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:56:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF62016A41F; Tue, 13 Sep 2005 17:56:16 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AB2143D45; Tue, 13 Sep 2005 17:56:14 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8DHuEtb026128; Tue, 13 Sep 2005 10:56:14 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8DHuEcj026127; Tue, 13 Sep 2005 10:56:14 -0700 (PDT) (envelope-from obrien) Date: Tue, 13 Sep 2005 10:56:13 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20050913175613.GA18137@dragon.NUXI.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> <20050912010034.GA77819@dragon.NUXI.org> <20050913071031.GE37280@ip.net.ua> <20050913085848.GG37280@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050913085848.GG37280@ip.net.ua> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:56:17 -0000 On Tue, Sep 13, 2005 at 11:58:48AM +0300, Ruslan Ermilov wrote: > To address all of this, I suggest to revert kern.post.mk to rev. 1.83 > and just make INSTALL_DEBUG the default in HEAD when DEBUG is also > set. Should this be also true for modules, I'm not sure. .. > The only change in behavior would be that installkernel.debug now > installs *both* normal and debug versions, while previously it only > installed debug versions. 1. We can still have the confusion of how to provide a usable traceback. The poster will have to know to kgdb kernel.debug vs. kernel. 2. Why install a file that is a complete copy of another and then extra needed information? Instead just install the fuller copy. Those suffering from small / partitions will have even more pressure installing an extra 6.7MB. Please remember the purpose of this is to get better bug reports on -CURRENT. While still trying to strike a balance with disk space and usability. Here is a patch that separates out the symbols into its own file and installs them beside the now stripped kernel executable. I've minimally tested in on i386 with 'kgdb' and 'gdb6 -k'. Index: kern.post.mk =================================================================== RCS file: /home/ncvs/src/sys/conf/kern.post.mk,v retrieving revision 1.84 diff -u -u -2 -r1.84 kern.post.mk --- kern.post.mk 11 Sep 2005 00:22:21 -0000 1.84 +++ kern.post.mk 13 Sep 2005 17:46:48 -0000 @@ -83,7 +83,7 @@ @echo linking ${.TARGET} ${SYSTEM_LD} -.if !defined(DEBUG) + ${OBJCOPY} --only-keep-debug ${.TARGET} ${.TARGET}.symbols ${OBJCOPY} --strip-debug ${.TARGET} -.endif + ${OBJCOPY} --add-gnu-debuglink=${.TARGET}.symbols ${.TARGET} ${SYSTEM_LD_TAIL} @@ -181,4 +181,10 @@ .endif +.if defined(DEBUG) && !defined(NO_INSTALL_KERNEL_SYMBOLS) +KERNEL_FILES= ${KERNEL_KO} ${KERNEL_KO}.symbols +.else +KERNEL_FILES= ${KERNEL_KO} +.endif + kernel-install: @if [ ! -f ${KERNEL_KO} ] ; then \ @@ -201,5 +207,5 @@ .endif mkdir -p ${DESTDIR}${KODIR} - ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_KO} ${DESTDIR}${KODIR} + ${INSTALL} -p -m 555 -o root -g wheel ${KERNEL_FILES} ${DESTDIR}${KODIR} kernel-reinstall: -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Sep 13 17:56:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B009B16A41F; Tue, 13 Sep 2005 17:56:36 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BF1643D46; Tue, 13 Sep 2005 17:56:36 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DHua8E072243; Tue, 13 Sep 2005 17:56:36 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DHuapb072242; Tue, 13 Sep 2005 17:56:36 GMT (envelope-from imp) Message-Id: <200509131756.j8DHuapb072242@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 17:56:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccard card_if.m pccard.c pccard_cis.c pccardvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 17:56:36 -0000 imp 2005-09-13 17:56:36 UTC FreeBSD src repository Modified files: sys/dev/pccard card_if.m pccard.c pccard_cis.c pccardvar.h Log: Add a few new functions interfaces to allow reading/writing attribute memory, the CCR and a tweak to cis_scan. Revision Changes Path 1.30 +41 -0 src/sys/dev/pccard/card_if.m 1.110 +89 -1 src/sys/dev/pccard/pccard.c 1.37 +9 -9 src/sys/dev/pccard/pccard_cis.c 1.57 +33 -1 src/sys/dev/pccard/pccardvar.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 18:02:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60C8A16A41F; Tue, 13 Sep 2005 18:02:40 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 300D443D46; Tue, 13 Sep 2005 18:02:40 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DI2eNn072696; Tue, 13 Sep 2005 18:02:40 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DI2ePG072695; Tue, 13 Sep 2005 18:02:40 GMT (envelope-from thompsa) Message-Id: <200509131802.j8DI2ePG072695@repoman.freebsd.org> From: Andrew Thompson Date: Tue, 13 Sep 2005 18:02:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_bridge.c if_ethersubr.c src/sys/netinet6 in6_ifattach.c nd6.c nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 18:02:40 -0000 thompsa 2005-09-13 18:02:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_bridge.c if_ethersubr.c sys/netinet6 in6_ifattach.c nd6.c nd6_nbr.c Log: MFC: if_bridge.c, r1.21; if_ethersubr.c, r1.198; in6_ifattach.c, r1.28; nd6.c, r1.55; nd6_nbr.c, r1.33 > Add support for multicast to the bridge and allow inet6 addresses to be > assigned to the interface. > > IPv6 auto-configuration is disabled. An IPv6 link-local address has a > link-local scope within one link, the spec is unclear for the bridge case and > it may cause scope violation. > > An address can be assigned in the usual way; > ifconfig bridge0 inet6 xxxx:... > > Tested by: bmah > Reviewed by: ume (netinet6) > Approved by: mlaier (mentor) Approved by: re (kensmith), mlaier (mentor) Revision Changes Path 1.11.2.10 +27 -5 src/sys/net/if_bridge.c 1.193.2.4 +1 -1 src/sys/net/if_ethersubr.c 1.26.2.1 +1 -4 src/sys/netinet6/in6_ifattach.c 1.48.2.2 +2 -0 src/sys/netinet6/nd6.c 1.29.2.2 +1 -0 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 18:06:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3B3716A41F; Tue, 13 Sep 2005 18:06:20 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73E4F43D45; Tue, 13 Sep 2005 18:06:18 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8DI6Lo5003839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 13 Sep 2005 11:06:21 -0700 Message-ID: <43271516.9000808@root.org> Date: Tue, 13 Sep 2005 11:06:14 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Greg 'groggy' Lehey" References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913004536.GK53486@wantadilla.lemis.com> In-Reply-To: <20050913004536.GK53486@wantadilla.lemis.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien Subject: Re: Combined root, /var and /usr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 18:06:21 -0000 Greg 'groggy' Lehey wrote: > I've been recommending and doing this for years. FWIW in the fourth > edition of "The Complete FreeBSD" I recommended 4 to 6 GB; I'd now say > that 8 to 10 is better. I also recommend a separate /var if you're > doing important things with it. Here's what I have on my two main > machines: > > === root@wantadilla (/dev/ttyp0) ~ 98 -> df > Filesystem 1048576-blocks Used Avail Capacity Mounted on > /dev/ad0s1a 9912 4211 4908 46% / > /dev/ad0s3h 51895 41842 5902 88% /home > > === root@echunga (/dev/ttyp4) ~ 29 -> df > Filesystem 1048576-blocks Used Avail Capacity Mounted on > /dev/ad0s1a 14873 7985 5698 58% / > /dev/ad0s1g 9916 3846 5276 42% /home > /dev/ad2s1h 188356 106658 66629 62% /src Large / means you have to wait for it to fsck before bg fsck can run on other filesystems. On my crashbox (laptop), that is unacceptable. /var on the same filesystem as / means that you're bound to have lots of problems found via fsck that you may have to review manually when a busy system crashes. With var separate from /, you can just blow it away (fsck -y) and get back to work. If you don't have a diskless server or livecd, having a separate / means you can boot and rebuild a fs with fsdb. With a combined partition, this is probabilistic. If you start getting block errors on your hard drive, separate partitions mean you can pull off the files still alive, remap bad sectors, and newfs. Try that with one large /. > In CFBSD IV I explain how / and /usr came to be: about 32 years ago, > they had / on an RK03 (0.5 MB), so they *had* to put the rest of the > system somewhere else. The fact that we still use a separate /usr has > something to do with the reliability of the Seventh Edition file > system See above for examples still valid today. > and something to do with not changing the way our grandfathers > did things (writing "return (FOO)" instead of "return FOO" is > another example). I think that one is more about consistency. return () is a keyword while exit() is a function. It's the same reason we don't write if(). -- Nate From owner-cvs-src@FreeBSD.ORG Tue Sep 13 18:15:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 664) id 54DBB16A420; Tue, 13 Sep 2005 18:15:05 +0000 (GMT) Date: Tue, 13 Sep 2005 18:15:05 +0000 From: David O'Brien To: Ruslan Ermilov Message-ID: <20050913181505.GA81297@hub.freebsd.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <20050911023622.GA51877@dragon.NUXI.org> <4324A665.3070405@root.org> <20050912010034.GA77819@dragon.NUXI.org> <20050913071031.GE37280@ip.net.ua> <20050913085848.GG37280@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050913085848.GG37280@ip.net.ua> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 4.11-STABLE Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 18:15:05 -0000 On Tue, Sep 13, 2005 at 11:58:48AM +0300, Ruslan Ermilov wrote: > Before this change, we had installkernel.debug installing both normal > and *.debug versions of kernel and module objects, and gdb scripts. > And that was consistent. > > Now, installkernel.debug no longer installs kernel.debug but continues > to install both normal and *.debug module objects. I wouldn't mind seeing us install the gdb scripts, etc. all the time now also. I think 'installkernel.debug" should be an alias for "installkernel" in -CURRENT. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Sep 13 18:55:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F077916A41F; Tue, 13 Sep 2005 18:55:29 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DF0A43D46; Tue, 13 Sep 2005 18:55:29 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DItTE4074878; Tue, 13 Sep 2005 18:55:29 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DItTwQ074877; Tue, 13 Sep 2005 18:55:29 GMT (envelope-from imp) Message-Id: <200509131855.j8DItTwQ074877@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 18:55:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ex if_ex_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 18:55:30 -0000 imp 2005-09-13 18:55:28 UTC FreeBSD src repository Modified files: sys/dev/ex if_ex_pccard.c Log: Add the olicom OC2231 and OC2232 to the list of cards that we should attach to. These cards are combo cards (in that they have a modem inside of them), but not true MFC cards. Full support of these cards will have to wait until we can pick the config to use and for the PFC support that I have brewing. Revision Changes Path 1.16 +2 -0 src/sys/dev/ex/if_ex_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 18:57:07 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F36816A41F; Tue, 13 Sep 2005 18:57:07 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from mail05.syd.optusnet.com.au (mail05.syd.optusnet.com.au [211.29.132.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id B124543D46; Tue, 13 Sep 2005 18:57:06 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail05.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id j8DIv4CT025657 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 14 Sep 2005 04:57:04 +1000 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1]) by cirb503493.alcatel.com.au (8.12.10/8.12.10) with ESMTP id j8DIv3SR042877; Wed, 14 Sep 2005 04:57:04 +1000 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost) by cirb503493.alcatel.com.au (8.12.10/8.12.9/Submit) id j8DIv3HC042876; Wed, 14 Sep 2005 04:57:03 +1000 (EST) (envelope-from pjeremy) Date: Wed, 14 Sep 2005 04:57:03 +1000 From: Peter Jeremy To: Alexey Dokuchaev Message-ID: <20050913185703.GA40237@cirb503493.alcatel.com.au> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050913125820.GA10663@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 18:57:07 -0000 On Tue, 2005-Sep-13 12:58:20 +0000, Alexey Dokuchaev wrote: >AFAIK, we still do not turn softupdates on /, but do on other >partitions. With your proposed idea, softupdates should be on on /. >How safe is this today? Quite safe. When running softupdates, freed disk space is not returned to the free list for 30-60 seconds. Since install(1) deletes the existing target files rather than over-writing them, this means that a larger pool of free space is required when doing installworld with a softupdates target. With the old 128MB (or less) root partition, there may not have been sufficient free space so softupdates was disabled by default. With the new 512MB root or the proposed multi-GB /+/usr+/var there is unlikely to be a shortage of free space so it would be quite safe to enable softupdates. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:01:54 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 082BA16A41F; Tue, 13 Sep 2005 19:01:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC35543D45; Tue, 13 Sep 2005 19:01:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJ1rmk075220; Tue, 13 Sep 2005 19:01:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJ1rLo075219; Tue, 13 Sep 2005 19:01:53 GMT (envelope-from rwatson) Message-Id: <200509131901.j8DJ1rLo075219@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 19:01:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/kenv kenv.1 kenv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:01:54 -0000 rwatson 2005-09-13 19:01:53 UTC FreeBSD src repository Modified files: bin/kenv kenv.1 kenv.c Log: Add a "-q" quiet flag to kenv so that warnings can be suppressed. MFC after: 1 week Revision Changes Path 1.12 +8 -1 src/bin/kenv/kenv.1 1.8 +12 -8 src/bin/kenv/kenv.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:07:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1791116A41F; Tue, 13 Sep 2005 19:07:01 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEDA243D48; Tue, 13 Sep 2005 19:07:00 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJ70iU075409; Tue, 13 Sep 2005 19:07:00 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJ70Qm075406; Tue, 13 Sep 2005 19:07:00 GMT (envelope-from imp) Message-Id: <200509131907.j8DJ70Qm075406@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:07:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:07:01 -0000 imp 2005-09-13 19:07:00 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_pci.c Log: Use smaller names. The "NE2000 PCI Ethernet" is largerly redundant with edX at pciY. This removes 8*22 bytes from the strings. Not a huge win, but a cheap one. Revision Changes Path 1.45 +9 -9 src/sys/dev/ed/if_ed_pci.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:07:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72EE616A471; Tue, 13 Sep 2005 19:07:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF72243D46; Tue, 13 Sep 2005 19:07:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJ72bU075443; Tue, 13 Sep 2005 19:07:02 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJ72sS075442; Tue, 13 Sep 2005 19:07:02 GMT (envelope-from rwatson) Message-Id: <200509131907.j8DJ72sS075442@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 19:07:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d dumpon X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:07:04 -0000 rwatson 2005-09-13 19:07:02 UTC FreeBSD src repository Modified files: etc/rc.d dumpon Log: Use kenv -q to extract dumpdev rather than kenv, in order to avoid spamming the console in the event that a loader tunable 'dumpdev' isn't defined, which is not a relevant failure to report. MFC after: 1 week Revision Changes Path 1.10 +1 -1 src/etc/rc.d/dumpon From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:09:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B75D16A41F; Tue, 13 Sep 2005 19:09:58 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFAB943D45; Tue, 13 Sep 2005 19:09:57 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJ9vU7075533; Tue, 13 Sep 2005 19:09:57 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJ9vo3075532; Tue, 13 Sep 2005 19:09:57 GMT (envelope-from imp) Message-Id: <200509131909.j8DJ9vo3075532@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:09:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:09:58 -0000 imp 2005-09-13 19:09:57 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_pccard.c Log: MFp4: Minor formatting nits in pccard table. Revision Changes Path 1.97 +9 -9 src/sys/dev/ed/if_ed_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:15:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 561EB16A41F; Tue, 13 Sep 2005 19:15:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EE9A43D4C; Tue, 13 Sep 2005 19:15:28 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJFS6x075875; Tue, 13 Sep 2005 19:15:28 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJFS1C075874; Tue, 13 Sep 2005 19:15:28 GMT (envelope-from rwatson) Message-Id: <200509131915.j8DJFS1C075874@repoman.freebsd.org> From: Robert Watson Date: Tue, 13 Sep 2005 19:15:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/savecore savecore.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:15:29 -0000 rwatson 2005-09-13 19:15:28 UTC FreeBSD src repository Modified files: sbin/savecore savecore.c Log: Don't consider being unable to open the bounds file worthy of printing at LOG_WARNING by default; instead, consider it something to be printed to the tty when 'verbose' mode is set. This avoids printing out extra lines at every boot on a system with crash dumps enabled, but that has not yet had to generate a crashdump. MFC after: 1 week Revision Changes Path 1.76 +2 -1 src/sbin/savecore/savecore.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:25:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F2D416A41F; Tue, 13 Sep 2005 19:25:34 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6339A43D62; Tue, 13 Sep 2005 19:25:30 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJPUmL076313; Tue, 13 Sep 2005 19:25:30 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJPUq5076312; Tue, 13 Sep 2005 19:25:30 GMT (envelope-from imp) Message-Id: <200509131925.j8DJPUq5076312@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:25:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sn if_sn_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:25:34 -0000 imp 2005-09-13 19:25:30 UTC FreeBSD src repository Modified files: sys/dev/sn if_sn_pccard.c Log: Use new convenience function to read CIS rather than the older, harder to use version. Revision Changes Path 1.35 +1 -2 src/sys/dev/sn/if_sn_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:28:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 427DD16A420; Tue, 13 Sep 2005 19:28:04 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0189043D45; Tue, 13 Sep 2005 19:28:03 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJS3aN076424; Tue, 13 Sep 2005 19:28:03 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJS3tK076423; Tue, 13 Sep 2005 19:28:03 GMT (envelope-from imp) Message-Id: <200509131928.j8DJS3tK076423@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:28:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ex if_ex_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:28:04 -0000 imp 2005-09-13 19:28:03 UTC FreeBSD src repository Modified files: sys/dev/ex if_ex_pccard.c Log: MFp4: o Move to new pccard_cis_scan convenience function. o Remove compat layer goo. Revision Changes Path 1.17 +40 -73 src/sys/dev/ex/if_ex_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:47:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE2FC16A445; Tue, 13 Sep 2005 19:47:44 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEE7643D46; Tue, 13 Sep 2005 19:47:44 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJliLf077284; Tue, 13 Sep 2005 19:47:44 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJli0a077283; Tue, 13 Sep 2005 19:47:44 GMT (envelope-from imp) Message-Id: <200509131947.j8DJli0a077283@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:47:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c if_edreg.h if_edvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:47:45 -0000 imp 2005-09-13 19:47:44 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed.c if_ed_pccard.c if_edreg.h if_edvar.h Log: MFp4: Omnibus ed changes o Attach AX88x90's MII bus to system, and require its presence. o Reorg the mii code a little, and move more of it into pccard attachment. o Eliminate ed_pccard_{read,write}_attrmem in favor of a more appropriate function in the pccard layer. o Update comments to reflect knowledge gained. o Update how re recognize a NE-2000 ROM. I found a couple of different datasheets that define the structure of the PROM data, so the code's old heuristics have been removed, and comments updated to reflect the structure. o Eliminate work around for EC2T. It is no longer needed, and was wrong headed since the EC2T has a Winbound 82C926C in it, not a AX88x90. o Add copyright to if_ed_pccard.c, since I believe I've re-written more than 3/4 of it. # With these changes, all of my 20-odd ed based cards work, except for the # NetGear FA-410, and I'm pretty sure that's a MII/PHY problem. Revision Changes Path 1.260 +0 -37 src/sys/dev/ed/if_ed.c 1.98 +267 -138 src/sys/dev/ed/if_ed_pccard.c 1.39 +18 -21 src/sys/dev/ed/if_edreg.h 1.36 +0 -2 src/sys/dev/ed/if_edvar.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:54:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AD9216A421; Tue, 13 Sep 2005 19:54:15 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF5B943D46; Tue, 13 Sep 2005 19:54:14 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJsEYv077594; Tue, 13 Sep 2005 19:54:14 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJsEMH077593; Tue, 13 Sep 2005 19:54:14 GMT (envelope-from imp) Message-Id: <200509131954.j8DJsEMH077593@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:54:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/xe if_xe_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:54:15 -0000 imp 2005-09-13 19:54:14 UTC FreeBSD src repository Modified files: sys/dev/xe if_xe_pccard.c Log: MFp4: o Use pccard_cis_scan o use pccard_attr_write_1 o Update comments Revision Changes Path 1.31 +13 -37 src/sys/dev/xe/if_xe_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 19:56:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEEF216A41F; Tue, 13 Sep 2005 19:56:07 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A085343D46; Tue, 13 Sep 2005 19:56:07 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DJu7NA077754; Tue, 13 Sep 2005 19:56:07 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DJu7uC077753; Tue, 13 Sep 2005 19:56:07 GMT (envelope-from imp) Message-Id: <200509131956.j8DJu7uC077753@repoman.freebsd.org> From: Warner Losh Date: Tue, 13 Sep 2005 19:56:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ep if_ep_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 19:56:08 -0000 imp 2005-09-13 19:56:07 UTC FreeBSD src repository Modified files: sys/dev/ep if_ep_pccard.c Log: MFp4: Migrate from CARD_CIS_SCAN to pccard_cis_scan Revision Changes Path 1.49 +1 -1 src/sys/dev/ep/if_ep_pccard.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 20:54:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F46816A41F; Tue, 13 Sep 2005 20:54:01 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B766743D48; Tue, 13 Sep 2005 20:54:00 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DKs02S087186; Tue, 13 Sep 2005 20:54:00 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DKs0cB087185; Tue, 13 Sep 2005 20:54:00 GMT (envelope-from marcel) Message-Id: <200509132054.j8DKs0cB087185@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 13 Sep 2005 20:54:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ia64/ia64 elf_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 20:54:01 -0000 marcel 2005-09-13 20:54:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ia64/ia64 elf_machdep.c Log: MFC 1.20: Remove the execute permission for stacks. Approved by: re (blanket) Revision Changes Path 1.19.8.1 +1 -1 src/sys/ia64/ia64/elf_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 21:07:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 678F616A41F; Tue, 13 Sep 2005 21:07:15 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DC6F43D45; Tue, 13 Sep 2005 21:07:15 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DL7FC4087837; Tue, 13 Sep 2005 21:07:15 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DL7F3C087836; Tue, 13 Sep 2005 21:07:15 GMT (envelope-from marcel) Message-Id: <200509132107.j8DL7F3C087836@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 13 Sep 2005 21:07:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ia64/conf GENERIC src/sys/ia64/ia64 exception.S interrupt.c machdep.c mp_machdep.c pmap.c sal.c trap.c vm_machdep.c src/sys/ia64/include ia64_cpu.h param.h pmap.h proc.h smp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 21:07:15 -0000 marcel 2005-09-13 21:07:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ia64/conf GENERIC sys/ia64/ia64 exception.S interrupt.c machdep.c mp_machdep.c pmap.c sal.c trap.c vm_machdep.c sys/ia64/include ia64_cpu.h param.h pmap.h proc.h smp.h Log: Mega-MFC: Add SMP support and enable it by default. This includes: conf/GENERIC: 1.73, 1.53 ia64/exception.S: 1.57 ia64/interrupt.c: 1.50, 1.51 ia64/machdep.c: 1.201, 1.202 ia64/mp_machdep.c: 1.56, 1.57, 1.58 ia64/pmap.c: 1.161, 1.162, 1.164, 1.165, 1.166 ia64/sal.c: 1.15 ia64/trap.c: 1.114, 1.115 ia64/vm_machdep.c: 1.91, 1.92 include/ia64_cpu.h: 1.20 include/param.h: 1.21 include/pmap.h: 1.25 include/proc.h: 1.15 include/smp.h: 1.10 Approved by: re (kensmith, scottl -- thanks!) Revision Changes Path 1.72.2.2 +2 -2 src/sys/ia64/conf/GENERIC 1.56.2.1 +8 -0 src/sys/ia64/ia64/exception.S 1.49.2.1 +5 -0 src/sys/ia64/ia64/interrupt.c 1.200.2.1 +30 -13 src/sys/ia64/ia64/machdep.c 1.55.2.1 +28 -25 src/sys/ia64/ia64/mp_machdep.c 1.160.2.1 +344 -379 src/sys/ia64/ia64/pmap.c 1.14.2.1 +4 -2 src/sys/ia64/ia64/sal.c 1.113.2.1 +12 -7 src/sys/ia64/ia64/trap.c 1.90.2.1 +1 -0 src/sys/ia64/ia64/vm_machdep.c 1.19.10.1 +4 -4 src/sys/ia64/include/ia64_cpu.h 1.20.2.1 +1 -1 src/sys/ia64/include/param.h 1.24.2.1 +3 -0 src/sys/ia64/include/pmap.h 1.14.2.1 +2 -1 src/sys/ia64/include/proc.h 1.9.2.1 +4 -2 src/sys/ia64/include/smp.h From owner-cvs-src@FreeBSD.ORG Tue Sep 13 22:13:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39D6B16A41F; Tue, 13 Sep 2005 22:13:02 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDECE43D46; Tue, 13 Sep 2005 22:13:01 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DMD1fY090769; Tue, 13 Sep 2005 22:13:01 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DMD1IG090768; Tue, 13 Sep 2005 22:13:01 GMT (envelope-from csjp) Message-Id: <200509132213.j8DMD1IG090768@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Tue, 13 Sep 2005 22:13:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 22:13:02 -0000 csjp 2005-09-13 22:13:01 UTC FreeBSD src repository Modified files: usr.bin/netstat bpf.c Log: If there are'nt any bpf descriptors to process than dont bother attempting to retrieve statistic information for them. Pointed out by: Pawel Worach < pawel.worach at gmail.com > Revision Changes Path 1.3 +2 -0 src/usr.bin/netstat/bpf.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 23:11:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09A4F16A41F; Tue, 13 Sep 2005 23:11:17 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC8B643D49; Tue, 13 Sep 2005 23:11:16 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8DNBG1i093644; Tue, 13 Sep 2005 23:11:16 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8DNBGbD093643; Tue, 13 Sep 2005 23:11:16 GMT (envelope-from csjp) Message-Id: <200509132311.j8DNBGbD093643@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Tue, 13 Sep 2005 23:11:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 23:11:17 -0000 csjp 2005-09-13 23:11:16 UTC FreeBSD src repository Modified files: usr.bin/netstat bpf.c Log: Print a warning if we fail to retrieve the process name for any reason. Revision Changes Path 1.4 +3 -1 src/usr.bin/netstat/bpf.c From owner-cvs-src@FreeBSD.ORG Tue Sep 13 23:50:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD1AA16A41F; Tue, 13 Sep 2005 23:50:24 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F48B43D45; Tue, 13 Sep 2005 23:50:23 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j8DNoLRJ006984; Tue, 13 Sep 2005 19:50:22 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> Date: Tue, 13 Sep 2005 19:50:20 -0400 To: Marcel Moolenaar , Alexey Dokuchaev From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.1 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2005 23:50:24 -0000 At 8:29 AM -0700 9/13/05, Marcel Moolenaar wrote: >On Sep 13, 2005, at 5:58 AM, Alexey Dokuchaev wrote: >>AFAIK, we still do not turn softupdates on /, but do on other >>partitions. With your proposed idea, softupdates should be >>on on /. How safe is this today? > >I never use separate partitions for /usr and /var on my scratch >boxes and I always enable SU on /. I can't say I've ever had any >problems. Just as another data point: I do *not* have a separate partition for /usr and /var (*), so my '/' partitions are similar in size to the standard setup. On two machines that I can quickly check here, I have a 300-meg '/' on one, and a 470-meg '/' on the other. My other systems probably have a smaller root partition, because these two machines are my two most-recent builds. I have been running with softupdates enabled on '/' for a long time, and as far as I know it hasn't caused me any problems since maybe 5.2.1. It did used to cause me occasional problems a few years ago, but I can't remember any recent problems. I must admit I'm a little uneasy moving /usr and /var into '/', just because I'm so used to the way it is. I really *like* having /var as a separate partition. But hard disks are huge compared to how they used to be, so I don't mind having a 500-meg '/'. I *do* save the kernel.debug information in my /boot/kernel's, and my root partition is still under 50% full. (* - Except for my PowerPC machine... That machine has everything in '/' except for one large empty partition on '/usr/obj', and a memory-disk partition sitting on /tmp_md ). -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Wed Sep 14 01:34:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FF0B16A41F; Wed, 14 Sep 2005 01:34:14 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E42243D48; Wed, 14 Sep 2005 01:34:14 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E1YE93006210; Wed, 14 Sep 2005 01:34:14 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E1YExZ006209; Wed, 14 Sep 2005 01:34:14 GMT (envelope-from yongari) Message-Id: <200509140134.j8E1YExZ006209@repoman.freebsd.org> From: Pyun YongHyeon Date: Wed, 14 Sep 2005 01:34:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm sndstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 01:34:14 -0000 yongari 2005-09-14 01:34:14 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm sndstat.c Log: Fix module unload panic which was caused by missing sx lock release. While I'm here add KASSERT(9) to notify failure of SYSUNINIT handler. Reported by: Ben Kaduk < minimarmot AT gmail DOT com > Tested by: Ben Kaduk < minimarmot AT gmail DOT com > Revision Changes Path 1.21 +5 -1 src/sys/dev/sound/pcm/sndstat.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 02:44:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC2FE16A41F; Wed, 14 Sep 2005 02:44:03 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89E1E43D46; Wed, 14 Sep 2005 02:44:03 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E2i3XK008630; Wed, 14 Sep 2005 02:44:03 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E2i3i9008629; Wed, 14 Sep 2005 02:44:03 GMT (envelope-from delphij) Message-Id: <200509140244.j8E2i3i9008629@repoman.freebsd.org> From: Xin LI Date: Wed, 14 Sep 2005 02:44:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern subr_prf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 02:44:04 -0000 delphij 2005-09-14 02:44:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern subr_prf.c Log: MFC 1.118: When padding with zero, do pad after prefixes rather than padding before prefixes. Use cases: printf("%05d", -42); --> "00-42" (should be "-0042") printf("%#05x", 12); --> "000xc" (should be "0x00c") Submitted by: Oliver Fromme PR: kern/85520 Approved by: re (kensmith) Revision Changes Path 1.116.2.1 +5 -1 src/sys/kern/subr_prf.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 02:45:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5434316A41F; Wed, 14 Sep 2005 02:45:51 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11F5B43D45; Wed, 14 Sep 2005 02:45:51 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E2joJ0008779; Wed, 14 Sep 2005 02:45:50 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E2joHM008778; Wed, 14 Sep 2005 02:45:50 GMT (envelope-from delphij) Message-Id: <200509140245.j8E2joHM008778@repoman.freebsd.org> From: Xin LI Date: Wed, 14 Sep 2005 02:45:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/kern subr_prf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 02:45:51 -0000 delphij 2005-09-14 02:45:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/kern subr_prf.c Log: MFC 1.118: When padding with zero, do pad after prefixes rather than padding before prefixes. Use cases: printf("%05d", -42); --> "00-42" (should be "-0042") printf("%#05x", 12); --> "000xc" (should be "0x00c") Submitted by: Oliver Fromme PR: kern/85520 Approved by: re (kensmith) Revision Changes Path 1.113.2.1 +5 -1 src/sys/kern/subr_prf.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 05:04:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53AC816A41F; Wed, 14 Sep 2005 05:04:16 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7918443D5D; Wed, 14 Sep 2005 05:04:13 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E54Cjb026582; Wed, 14 Sep 2005 05:04:12 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E54CoT026581; Wed, 14 Sep 2005 05:04:12 GMT (envelope-from brueffer) Message-Id: <200509140504.j8E54CoT026581@repoman.freebsd.org> From: Christian Brueffer Date: Wed, 14 Sep 2005 05:04:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4/man4.i386 acpi_sony.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 05:04:16 -0000 brueffer 2005-09-14 05:04:12 UTC FreeBSD src repository (doc committer) Added files: share/man/man4/man4.i386 acpi_sony.4 Log: Manpage for the acpi_sony(4) driver. This is more of a dummy page at the moment, but better than nothing. MFC after: 3 days Revision Changes Path 1.1 +56 -0 src/share/man/man4/man4.i386/acpi_sony.4 (new) From owner-cvs-src@FreeBSD.ORG Wed Sep 14 05:09:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F48116A41F; Wed, 14 Sep 2005 05:09:33 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E51C43D48; Wed, 14 Sep 2005 05:09:33 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E59Xa2026779; Wed, 14 Sep 2005 05:09:33 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E59X4E026778; Wed, 14 Sep 2005 05:09:33 GMT (envelope-from brueffer) Message-Id: <200509140509.j8E59X4E026778@repoman.freebsd.org> From: Christian Brueffer Date: Wed, 14 Sep 2005 05:09:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4/man4.i386 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 05:09:33 -0000 brueffer 2005-09-14 05:09:33 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4/man4.i386 Makefile Log: Hook up acpi_sony.4 Revision Changes Path 1.180 +1 -0 src/share/man/man4/man4.i386/Makefile From owner-cvs-src@FreeBSD.ORG Wed Sep 14 05:46:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D0C516A41F; Wed, 14 Sep 2005 05:46:29 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF12E43D46; Wed, 14 Sep 2005 05:46:28 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E5kSqo028215; Wed, 14 Sep 2005 05:46:28 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E5kSJM028214; Wed, 14 Sep 2005 05:46:28 GMT (envelope-from scottl) Message-Id: <200509140546.j8E5kSJM028214@repoman.freebsd.org> From: Scott Long Date: Wed, 14 Sep 2005 05:46:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/aac aac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 05:46:29 -0000 scottl 2005-09-14 05:46:28 UTC FreeBSD src repository Modified files: sys/dev/aac aac.c Log: Use time_uptime for timing commands instead of time_second. This is a bit risky because the "current time" is supposed to be fed to the card during initialization, and the current time is supposed to be put into each command that is sent to the card. Hopefully either the card doesn't actually care about the timestamps, or it doesn't care about the absolute values so long and the relative values are consistent. Not an MFC candidate until more thorough testing can be done. Revision Changes Path 1.110 +9 -9 src/sys/dev/aac/aac.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 05:49:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 894CD16A41F; Wed, 14 Sep 2005 05:49:34 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 478C843D45; Wed, 14 Sep 2005 05:49:34 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E5nYnA028415; Wed, 14 Sep 2005 05:49:34 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E5nYqM028414; Wed, 14 Sep 2005 05:49:34 GMT (envelope-from scottl) Message-Id: <200509140549.j8E5nYqM028414@repoman.freebsd.org> From: Scott Long Date: Wed, 14 Sep 2005 05:49:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/aac aac_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 05:49:34 -0000 scottl 2005-09-14 05:49:34 UTC FreeBSD src repository Modified files: sys/dev/aac aac_cam.c Log: Bring aac_cam into line with using time_uptime instead of time_second. Revision Changes Path 1.21 +1 -1 src/sys/dev/aac/aac_cam.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 05:50:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC77A16A420; Wed, 14 Sep 2005 05:50:09 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A621143D46; Wed, 14 Sep 2005 05:50:09 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E5o951028506; Wed, 14 Sep 2005 05:50:09 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E5o97g028504; Wed, 14 Sep 2005 05:50:09 GMT (envelope-from brueffer) Message-Id: <200509140550.j8E5o97g028504@repoman.freebsd.org> From: Christian Brueffer Date: Wed, 14 Sep 2005 05:50:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 05:50:10 -0000 brueffer 2005-09-14 05:50:09 UTC FreeBSD src repository (doc committer) Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Note acpi_sony(4) manpage addition. Revision Changes Path 1.890 +2 -2 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Wed Sep 14 07:53:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DA5516A41F; Wed, 14 Sep 2005 07:53:55 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B49343D46; Wed, 14 Sep 2005 07:53:55 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E7rtqn033678; Wed, 14 Sep 2005 07:53:55 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E7rsqQ033677; Wed, 14 Sep 2005 07:53:54 GMT (envelope-from bz) Message-Id: <200509140753.j8E7rsqQ033677@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Wed, 14 Sep 2005 07:53:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 07:53:55 -0000 bz 2005-09-14 07:53:54 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Fix panic when kernel compiled without INET6 by rejecting IPv6 opcodes which are behind #if(n)def INET6 now. PR: kern/85826 MFC after: 3 days Revision Changes Path 1.111 +30 -6 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 09:01:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7329316A420; Wed, 14 Sep 2005 09:01:07 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0208443D45; Wed, 14 Sep 2005 09:01:07 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8E9167L044613; Wed, 14 Sep 2005 09:01:06 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8E916mL044612; Wed, 14 Sep 2005 09:01:06 GMT (envelope-from stefanf) Message-Id: <200509140901.j8E916mL044612@repoman.freebsd.org> From: Stefan Farfeleder Date: Wed, 14 Sep 2005 09:01:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 09:01:07 -0000 stefanf 2005-09-14 09:01:06 UTC FreeBSD src repository Modified files: include Makefile Log: Back out 1.247. On ia64 is included from assembler source, the prototype broke buildword. Noticed by: marcel Revision Changes Path 1.248 +0 -1 src/include/Makefile From owner-cvs-src@FreeBSD.ORG Wed Sep 14 09:18:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB7E116A41F; Wed, 14 Sep 2005 09:18:00 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E23A43D46; Wed, 14 Sep 2005 09:17:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id A02F446B14; Wed, 14 Sep 2005 05:17:53 -0400 (EDT) Date: Wed, 14 Sep 2005 10:17:53 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Garance A Drosehn In-Reply-To: Message-ID: <20050914100957.L33820@fledge.watson.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Marcel Moolenaar Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 09:18:01 -0000 On Tue, 13 Sep 2005, Garance A Drosehn wrote: > I must admit I'm a little uneasy moving /usr and /var into '/', just > because I'm so used to the way it is. I really *like* having /var as a > separate partition. But hard disks are huge compared to how they used > to be, so I don't mind having a 500-meg '/'. I *do* save the > kernel.debug information in my /boot/kernel's, and my root partition is > still under 50% full. We probably ought to move this discussion to another list, but -- I remember two very specific occasions where I first realized how important an isolated /var is: (1) In about 1995, when I first started using ppp, I discovered the hard way that the default logging level was set a bit high, and filled the entire hard disk with log records in a couple of days. Don't remember which FreeBSD revision that was. It's amazing how little time it takes, if you get a log messsage ever second or so, to fill up a hard disk. (2) Whenever it was that Outlook started becoming really popular, and all e-mails became word files or power point presentations -- bandwidth was high, but disks weren't large enough to put up with that. Especially with single sender multiple recipient spamming of word files. In both of these cases, having an isolated /var meant that /tmp didn't fill, so new /tmp files could still be created. Today that would be the difference between being able to SSH into the machine or not, because SSH requires inodes and directories to be allocated by default when you log in. While sizing becomes a continuing problem with multiple partitions, having them offers some important isolation of software faults. The main "problem" is that the strength of isolation is a bit too high. If we supported live resizing and relocation of partitions, it would be less of a serious constraint. The problem people have now, and the reason that installkernel installing debuggin symbols is an issue, is that recovering from an early poor (or simply dated) choice about partition sizing is very difficult. While 300GB disks may be commonplace and affordable today, the layout choices for 4GB disks haven't gone away yet. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Wed Sep 14 09:52:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 687CF16A41F; Wed, 14 Sep 2005 09:52:23 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep11-int.chello.at (viefep19-int.chello.at [213.46.255.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 270DF43D48; Wed, 14 Sep 2005 09:52:21 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep11-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20050914095219.YFP1994.viefep11-int.chello.at@wombat.fafoe.narf.at>; Wed, 14 Sep 2005 11:52:19 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 11CA1B7; Wed, 14 Sep 2005 11:52:19 +0200 (CEST) Date: Wed, 14 Sep 2005 11:52:19 +0200 From: Stefan Farfeleder To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20050914095217.GC59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509140901.j8E916mL044612@repoman.freebsd.org> User-Agent: Mutt/1.5.10i Cc: Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 09:52:23 -0000 On Wed, Sep 14, 2005 at 09:01:06AM +0000, Stefan Farfeleder wrote: > Back out 1.247. On ia64 is included from assembler source, > the prototype broke buildword. I waver between guarding the prototype with #ifndef __ASSEMBLER__ and moving it to another header, eg. . Opinions? From owner-cvs-src@FreeBSD.ORG Wed Sep 14 10:28:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E402416A41F; Wed, 14 Sep 2005 10:28:01 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A38F543D45; Wed, 14 Sep 2005 10:28:01 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EAS14C048257; Wed, 14 Sep 2005 10:28:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EAS13n048256; Wed, 14 Sep 2005 10:28:01 GMT (envelope-from ru) Message-Id: <200509141028.j8EAS13n048256@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 14 Sep 2005 10:28:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 10:28:02 -0000 ru 2005-09-14 10:28:01 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Fix "Memory modified after free" panic on detach, caused by accessing already freed struct ifnet. Revision Changes Path 1.69 +0 -3 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 10:42:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8802816A41F; Wed, 14 Sep 2005 10:42:52 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4868643D46; Wed, 14 Sep 2005 10:42:52 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EAgqoT049007; Wed, 14 Sep 2005 10:42:52 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EAgq0g049006; Wed, 14 Sep 2005 10:42:52 GMT (envelope-from pjd) Message-Id: <200509141042.j8EAgq0g049006@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Wed, 14 Sep 2005 10:42:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libmd sha256.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 10:42:52 -0000 pjd 2005-09-14 10:42:51 UTC FreeBSD src repository Modified files: lib/libmd sha256.3 Log: Correct type. OK'ed by: cperciva Revision Changes Path 1.3 +4 -4 src/lib/libmd/sha256.3 From owner-cvs-src@FreeBSD.ORG Wed Sep 14 12:33:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F75616A41F; Wed, 14 Sep 2005 12:33:23 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50F1E43D45; Wed, 14 Sep 2005 12:33:23 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ECXNf8053908; Wed, 14 Sep 2005 12:33:23 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ECXN28053907; Wed, 14 Sep 2005 12:33:23 GMT (envelope-from ru) Message-Id: <200509141233.j8ECXN28053907@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 14 Sep 2005 12:33:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_rl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 12:33:23 -0000 ru 2005-09-14 12:33:23 UTC FreeBSD src repository Modified files: sys/pci if_rl.c Log: Fixed "Memory modified after free" panic in rl_detach() due to rl_stop() accessing already freed "struct ifnet". Fixed LOR between rl mutex and some ACPI mutex in rl_detach(). Revision Changes Path 1.155 +3 -4 src/sys/pci/if_rl.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 12:39:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E178616A41F; Wed, 14 Sep 2005 12:39:06 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A33843D48; Wed, 14 Sep 2005 12:39:06 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ECd6Ir054192; Wed, 14 Sep 2005 12:39:06 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ECd61r054191; Wed, 14 Sep 2005 12:39:06 GMT (envelope-from nyan) Message-Id: <200509141239.j8ECd61r054191@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Wed, 14 Sep 2005 12:39:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/pc98 epsonio.h src/sys/boot/pc98/boot2 io.c src/sys/pc98/cbus fdc.c gdc.c nmi.c sio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 12:39:07 -0000 nyan 2005-09-14 12:39:06 UTC FreeBSD src repository Modified files: sys/boot/pc98/boot2 io.c sys/pc98/cbus fdc.c gdc.c nmi.c sio.c Removed files: sys/pc98/pc98 epsonio.h Log: Remove EPSON PC-386 note A/W/AE/WR support. Revision Changes Path 1.9 +2 -13 src/sys/boot/pc98/boot2/io.c 1.162 +0 -8 src/sys/pc98/cbus/fdc.c 1.49 +6 -20 src/sys/pc98/cbus/gdc.c 1.3 +0 -5 src/sys/pc98/cbus/nmi.c 1.235 +4 -8 src/sys/pc98/cbus/sio.c 1.11 +0 -54 src/sys/pc98/pc98/epsonio.h (dead) From owner-cvs-src@FreeBSD.ORG Wed Sep 14 12:42:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C39C16A41F; Wed, 14 Sep 2005 12:42:40 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29CF043D45; Wed, 14 Sep 2005 12:42:40 +0000 (GMT) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ECgeLb054401; Wed, 14 Sep 2005 12:42:40 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ECgeXS054400; Wed, 14 Sep 2005 12:42:40 GMT (envelope-from nyan) Message-Id: <200509141242.j8ECgeXS054400@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Wed, 14 Sep 2005 12:42:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/pc98 machdep.c pc98_machdep.c pc98_machdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 12:42:40 -0000 nyan 2005-09-14 12:42:40 UTC FreeBSD src repository Modified files: sys/pc98/pc98 machdep.c pc98_machdep.c pc98_machdep.h Log: Add some defines for EPSON machines and use them. Revision Changes Path 1.365 +3 -3 src/sys/pc98/pc98/machdep.c 1.26 +9 -9 src/sys/pc98/pc98/pc98_machdep.c 1.13 +17 -0 src/sys/pc98/pc98/pc98_machdep.h From owner-cvs-src@FreeBSD.ORG Wed Sep 14 12:45:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5865E16A41F; Wed, 14 Sep 2005 12:45:07 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13CFB43D46; Wed, 14 Sep 2005 12:45:07 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ECj6d9054601; Wed, 14 Sep 2005 12:45:06 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ECj63Y054600; Wed, 14 Sep 2005 12:45:06 GMT (envelope-from sos) Message-Id: <200509141245.j8ECj63Y054600@repoman.freebsd.org> From: Søren Schmidt Date: Wed, 14 Sep 2005 12:45:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata ata-all.c ata-chipset.c ata-lowlevel.c ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 12:45:07 -0000 sos 2005-09-14 12:45:06 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-chipset.c ata-lowlevel.c ata-queue.c Log: Harden the hotplug support for SATA devices. This also fixes a few races that was present in the timeout/detach code. Sponsored by: pair.com Revision Changes Path 1.257 +39 -10 src/sys/dev/ata/ata-all.c 1.133 +4 -2 src/sys/dev/ata/ata-chipset.c 1.71 +5 -3 src/sys/dev/ata/ata-lowlevel.c 1.51 +29 -36 src/sys/dev/ata/ata-queue.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 13:12:11 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48A3A16A41F; Wed, 14 Sep 2005 13:12:11 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from mail.ijs.si (mail.ijs.si [193.2.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id C245F43D46; Wed, 14 Sep 2005 13:12:10 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (mail.ijs.si [193.2.4.66]) by patsy.ijs.si (Postfix) with ESMTP id E0AD817B8C2; Wed, 14 Sep 2005 15:12:09 +0200 (CEST) Received: from patsy.ijs.si ([127.0.0.1]) by localhost (patsy.ijs.si [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 44806-02-3; Wed, 14 Sep 2005 15:12:07 +0200 (CEST) Received: from radagast.ijs.si (radagast.ijs.si [193.2.4.168]) by patsy.ijs.si (Postfix) with ESMTP id 4A8F117B8C4; Wed, 14 Sep 2005 15:12:07 +0200 (CEST) Received: from radagast.ijs.si (localhost.ijs.si [127.0.0.1]) by radagast.ijs.si (Postfix) with SMTP id EAAF91702B; Wed, 14 Sep 2005 15:12:06 +0200 (CEST) From: Dejan Lesjak To: Stefan Farfeleder , cvs-src@freebsd.org Date: Wed, 14 Sep 2005 15:12:06 +0200 References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453__1440.7719871544$1126691658$gmane$org@wombat.fafoe.narf.at> Lines: 24 User-Agent: KNode/0.9.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: <20050914131206.EAAF91702B@radagast.ijs.si> X-Virus-Scanned: amavisd-new at ijs.si Cc: Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 13:12:11 -0000 Stefan Farfeleder wrote: > On Wed, Sep 14, 2005 at 09:01:06AM +0000, Stefan Farfeleder wrote: > >> Back out 1.247. On ia64 is included from assembler >> source, the prototype broke buildword. > > I waver between guarding the prototype with #ifndef __ASSEMBLER__ and > moving it to another header, eg. . Opinions? > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" Well, since you asked :) The inclusion of prototype seems to have broken imake: http://lists.freebsd.org/pipermail/freebsd-x11/2005-September/002189.html So putting it in another include would be neater from this particular point of view as imake doesn't need changes then :) Dejan From owner-cvs-src@FreeBSD.ORG Wed Sep 14 13:46:37 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEFAE16A41F; Wed, 14 Sep 2005 13:46:37 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id E10D543D46; Wed, 14 Sep 2005 13:46:21 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-66-30-115-133.hsd1.ma.comcast.net (c-66-30-112-193.hsd1.ma.comcast.net[66.30.112.193](misconfigured sender)) by comcast.net (sccrmhc12) with ESMTP id <2005091413462001200n1dv1e>; Wed, 14 Sep 2005 13:46:20 +0000 Received: from c-66-30-115-133.hsd1.ma.comcast.net (localhost.127.in-addr.arpa [127.0.0.1]) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id j8EDk5Bk005664; Wed, 14 Sep 2005 09:46:05 -0400 (EDT) (envelope-from rodrigc@c-66-30-115-133.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id j8EDk5LX005663; Wed, 14 Sep 2005 09:46:05 -0400 (EDT) (envelope-from rodrigc) Date: Wed, 14 Sep 2005 09:45:48 -0400 From: Craig Rodrigues To: Stefan Farfeleder Message-ID: <20050914134548.GA5653@crodrigues.org> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050914095217.GC59453@wombat.fafoe.narf.at> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 13:46:38 -0000 On Wed, Sep 14, 2005 at 11:52:19AM +0200, Stefan Farfeleder wrote: > moving it to another header, eg. . Opinions? How about libgen.h? I don't like polluting unistd.h more than we have to. -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Wed Sep 14 14:56:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F75116A41F; Wed, 14 Sep 2005 14:56:43 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DB1943D45; Wed, 14 Sep 2005 14:56:43 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EEuhsk067643; Wed, 14 Sep 2005 14:56:43 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EEuhDg067642; Wed, 14 Sep 2005 14:56:43 GMT (envelope-from andre) Message-Id: <200509141456.j8EEuhDg067642@repoman.freebsd.org> From: Andre Oppermann Date: Wed, 14 Sep 2005 14:56:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net route.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 14:56:43 -0000 andre 2005-09-14 14:56:43 UTC FreeBSD src repository Modified files: sys/net route.h Log: Remove bogous semicolons at the end of the definitions of 'do { ... } while (0)' macros. PR: kern/83088 Sumbitted by: Revision Changes Path 1.64 +2 -2 src/sys/net/route.h From owner-cvs-src@FreeBSD.ORG Wed Sep 14 14:57:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFCDB16A41F; Wed, 14 Sep 2005 14:57:04 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 872F643D48; Wed, 14 Sep 2005 14:57:04 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EEv4RP067682; Wed, 14 Sep 2005 14:57:04 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EEv4ba067681; Wed, 14 Sep 2005 14:57:04 GMT (envelope-from andre) Message-Id: <200509141457.j8EEv4ba067681@repoman.freebsd.org> From: Andre Oppermann Date: Wed, 14 Sep 2005 14:57:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys filedesc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 14:57:05 -0000 andre 2005-09-14 14:57:04 UTC FreeBSD src repository Modified files: sys/sys filedesc.h Log: Remove bogous semicolons at the end of the definitions of 'do { ... } while (0)' macros. PR: kern/83088 Sumbitted by: Revision Changes Path 1.73 +5 -5 src/sys/sys/filedesc.h From owner-cvs-src@FreeBSD.ORG Wed Sep 14 15:06:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFF9516A41F; Wed, 14 Sep 2005 15:06:22 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B2BA43D49; Wed, 14 Sep 2005 15:06:22 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EF6M4q068135; Wed, 14 Sep 2005 15:06:22 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EF6MHr068134; Wed, 14 Sep 2005 15:06:22 GMT (envelope-from andre) Message-Id: <200509141506.j8EF6MHr068134@repoman.freebsd.org> From: Andre Oppermann Date: Wed, 14 Sep 2005 15:06:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 15:06:23 -0000 andre 2005-09-14 15:06:22 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Do not ignore all other TCP options (eg. timestamp, window scaling) when responding to TCP SYN packets with TCP_MD5 enabled and set. PR: kern/82963 Submitted by: MFC after: 3 days Revision Changes Path 1.77 +1 -1 src/sys/netinet/tcp_syncache.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 15:18:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA46616A41F; Wed, 14 Sep 2005 15:18:12 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A409043D45; Wed, 14 Sep 2005 15:18:12 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EFIC3b068609; Wed, 14 Sep 2005 15:18:12 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EFICRo068608; Wed, 14 Sep 2005 15:18:12 GMT (envelope-from andre) Message-Id: <200509141518.j8EFICRo068608@repoman.freebsd.org> From: Andre Oppermann Date: Wed, 14 Sep 2005 15:18:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/digi digi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 15:18:13 -0000 andre 2005-09-14 15:18:12 UTC FreeBSD src repository Modified files: sys/dev/digi digi.c Log: Increase boot-time DigiBIOS initialization timeout to allow for a larger number of chained port modules. PR: kern/55018 Submitted by: Cyrill Shevchuk Revision Changes Path 1.59 +1 -1 src/sys/dev/digi/digi.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 15:19:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9FE116A420; Wed, 14 Sep 2005 15:19:26 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0ECBB43D45; Wed, 14 Sep 2005 15:19:23 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id j8EFOxb8074273; Wed, 14 Sep 2005 11:24:59 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Scott Long Date: Wed, 14 Sep 2005 11:18:58 -0400 User-Agent: KMail/1.6.2 References: <200509140546.j8E5kSJM028214@repoman.freebsd.org> In-Reply-To: <200509140546.j8E5kSJM028214@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: 7bit Message-Id: <200509141119.08733.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.85.1/1081/Tue Sep 13 03:06:09 2005 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aac aac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 15:19:26 -0000 On Wednesday 14 September 2005 01:46 am, Scott Long wrote: > scottl 2005-09-14 05:46:28 UTC > > FreeBSD src repository > > Modified files: > sys/dev/aac aac.c > Log: > Use time_uptime for timing commands instead of time_second. This > is a bit risky because the "current time" is supposed to be fed to > the card during initialization, and the current time is supposed to > be put into each command that is sent to the card. Hopefully > either the card doesn't actually care about the timestamps, or it > doesn't care about the absolute values so long and the relative > values are consistent. Not an MFC candidate until more thorough > testing can be done. > > Revision Changes Path > 1.110 +9 -9 src/sys/dev/aac/aac.c Thanks! FYI, twa(4) has the same issue. Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Wed Sep 14 15:53:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8BF416A41F; Wed, 14 Sep 2005 15:53:09 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21A2C43D45; Wed, 14 Sep 2005 15:53:08 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j8EFr8II001100; Wed, 14 Sep 2005 08:53:08 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j8EFr8AE001099; Wed, 14 Sep 2005 08:53:08 -0700 Date: Wed, 14 Sep 2005 08:53:08 -0700 From: Brooks Davis To: Robert Watson Message-ID: <20050914155307.GA32734@odin.ac.hmc.edu> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline In-Reply-To: <20050914100957.L33820@fledge.watson.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Marcel Moolenaar , Garance A Drosehn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 15:53:10 -0000 --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2005 at 10:17:53AM +0100, Robert Watson wrote: > On Tue, 13 Sep 2005, Garance A Drosehn wrote: >=20 > >I must admit I'm a little uneasy moving /usr and /var into '/', just=20 > >because I'm so used to the way it is. I really *like* having /var as a= =20 > >separate partition. But hard disks are huge compared to how they used= =20 > >to be, so I don't mind having a 500-meg '/'. I *do* save the=20 > >kernel.debug information in my /boot/kernel's, and my root partition is= =20 > >still under 50% full. >=20 > We probably ought to move this discussion to another list, but -- I=20 > remember two very specific occasions where I first realized how important= =20 > an isolated /var is: >=20 > (1) In about 1995, when I first started using ppp, I discovered the > hard way that the default logging level was set a bit high, and filled > the entire hard disk with log records in a couple of days. Don't > remember which FreeBSD revision that was. It's amazing how little > time it takes, if you get a log messsage ever second or so, to fill up > a hard disk. I've also hit cases where the log come in so fast that you can fill a 1GB /var fast enough that newsyslog never has a chance to compress the log. My particular case appears to be a program trying to dump core when not fully paged in and when the executable was on nfs, but has been deleted. I've trained my users not to delete there executables so fast and that seem to have stopped the problems, but I haven't had a chance to find a way to trigger the bug in the lab. I've found it on 4.x, but wouldn't be suprised if it effects all systems. The killer is that it generates two log messages per fault as fast as it can fault so while the file compresses very nicely, syslog's repeated line compression doesn't work. :( -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDKEdjXY6L6fI4GtQRAlgIAJ9OmCIsiZmd9F4P39TFS+Dx9Mn/JACeNUMv TQwy4BJTiFaf644xM6im/Ew= =G5CV -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1-- From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:27:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E02D16A41F; Wed, 14 Sep 2005 16:27:15 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id A058543D45; Wed, 14 Sep 2005 16:27:14 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j8EGRDTn018851; Wed, 14 Sep 2005 09:27:13 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20050914155307.GA32734@odin.ac.hmc.edu> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> <20050914155307.GA32734@odin.ac.hmc.edu> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Wed, 14 Sep 2005 09:27:11 -0700 To: Brooks Davis X-Mailer: Apple Mail (2.734) Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Robert Watson , Garance A Drosehn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:27:15 -0000 On Sep 14, 2005, at 8:53 AM, Brooks Davis wrote: >>> I must admit I'm a little uneasy moving /usr and /var into '/', just >>> because I'm so used to the way it is. I really *like* having / >>> var as a >>> separate partition. *snip* >> We probably ought to move this discussion to another list, but -- I >> remember two very specific occasions where I first realized how >> important >> an isolated /var is: >> >> (1) In about 1995, when I first started using ppp, I discovered the >> hard way that the default logging level was set a bit high, >> and filled >> the entire hard disk with log records in a couple of days. *snip* > > I've also hit cases where the log come in so fast that you can fill a > 1GB /var fast enough that newsyslog never has a chance to compress the > log. *snip* Just so that people realize: what is being described is not an argument for having /var be a separate partition, but really for having /var/log be a separate partition. It's just that the granularity of our thinking is highly influenced by our legacy, even to the extend of it becoming an intellectual jail. I think it's much easier to size a /var/log partition effectively than it is to size /, /usr and /var effectively... Just some food for thought, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:30:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C749716A41F; Wed, 14 Sep 2005 16:30:04 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep12-int.chello.at (viefep20-int.chello.at [213.46.255.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B11D43D46; Wed, 14 Sep 2005 16:30:03 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep12-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20050914163001.ZLSF2178.viefep12-int.chello.at@wombat.fafoe.narf.at>; Wed, 14 Sep 2005 18:30:01 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id C98C3B7; Wed, 14 Sep 2005 18:29:59 +0200 (CEST) Date: Wed, 14 Sep 2005 18:29:59 +0200 From: Stefan Farfeleder To: Craig Rodrigues Message-ID: <20050914162958.GF59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> <20050914134548.GA5653@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050914134548.GA5653@crodrigues.org> User-Agent: Mutt/1.5.10i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:30:05 -0000 On Wed, Sep 14, 2005 at 09:45:48AM -0400, Craig Rodrigues wrote: > On Wed, Sep 14, 2005 at 11:52:19AM +0200, Stefan Farfeleder wrote: > > moving it to another header, eg. . Opinions? > > How about libgen.h? I don't like polluting unistd.h more than > we have to. I proposed because gethost{name,id}() are somewhat similar. May I ask why libgen.h? POSIX describes it as "definitions for pattern matching functions". Stefan From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:30:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E027216A41F; Wed, 14 Sep 2005 16:30:29 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F48743D48; Wed, 14 Sep 2005 16:30:29 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j8EGUSSc018877; Wed, 14 Sep 2005 09:30:29 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20050914095217.GC59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Wed, 14 Sep 2005 09:30:26 -0700 To: Stefan Farfeleder X-Mailer: Apple Mail (2.734) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:30:30 -0000 On Sep 14, 2005, at 2:52 AM, Stefan Farfeleder wrote: >> Back out 1.247. On ia64 is included from >> assembler source, >> the prototype broke buildword. > > I waver between guarding the prototype with #ifndef __ASSEMBLER__ and > moving it to another header, eg. . Opinions? I would go with #ifndef __ASSEMBLER__. I think the prototype is essentially in the right header. I did test your patch and it does the trick... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:32:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4273E16A41F; Wed, 14 Sep 2005 16:32:22 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 026E143D46; Wed, 14 Sep 2005 16:32:22 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EGWL9h071577; Wed, 14 Sep 2005 16:32:21 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EGWLXr071576; Wed, 14 Sep 2005 16:32:21 GMT (envelope-from joel) Message-Id: <200509141632.j8EGWLXr071576@repoman.freebsd.org> From: Joel Dahl Date: Wed, 14 Sep 2005 16:32:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 msdosfs.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:32:22 -0000 joel 2005-09-14 16:32:21 UTC FreeBSD src repository (doc committer) Modified files: share/man/man5 msdosfs.5 Log: Remove superfluous reference to the FreeBSD handbook. Approved by: brueffer (mentor) Revision Changes Path 1.5 +0 -4 src/share/man/man5/msdosfs.5 From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:36:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA6BE16A41F; Wed, 14 Sep 2005 16:36:19 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA3DA43D4C; Wed, 14 Sep 2005 16:36:19 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EGaJo0071769; Wed, 14 Sep 2005 16:36:19 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EGaJf9071768; Wed, 14 Sep 2005 16:36:19 GMT (envelope-from joel) Message-Id: <200509141636.j8EGaJf9071768@repoman.freebsd.org> From: Joel Dahl Date: Wed, 14 Sep 2005 16:36:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount_msdosfs mount_msdosfs.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:36:20 -0000 joel 2005-09-14 16:36:19 UTC FreeBSD src repository (doc committer) Modified files: sbin/mount_msdosfs mount_msdosfs.8 Log: Xref msdosfs(5) Approved by: brueffer (mentor) Revision Changes Path 1.32 +1 -0 src/sbin/mount_msdosfs/mount_msdosfs.8 From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:37:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 461F416A41F; Wed, 14 Sep 2005 16:37:06 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0F9F43D58; Wed, 14 Sep 2005 16:37:05 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EGb5xh071827; Wed, 14 Sep 2005 16:37:05 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EGb5MZ071826; Wed, 14 Sep 2005 16:37:05 GMT (envelope-from andre) Message-Id: <200509141637.j8EGb5MZ071826@repoman.freebsd.org> From: Andre Oppermann Date: Wed, 14 Sep 2005 16:37:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:37:06 -0000 andre 2005-09-14 16:37:05 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Undo a tad little optimization to bpf_mtap() introduced in rev. 1.95 which broke the correct handling of the BIOCGSEESENT flag in the bpf listener. PR: kern/56441 Submitted by: MFC after: 3 days Revision Changes Path 1.160 +0 -4 src/sys/net/bpf.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 16:53:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3EB916A41F; Wed, 14 Sep 2005 16:53:18 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep17-int.chello.at (viefep17-int.chello.at [213.46.255.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6017243D46; Wed, 14 Sep 2005 16:53:17 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep17-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20050914165314.FJQG1234.viefep17-int.chello.at@wombat.fafoe.narf.at>; Wed, 14 Sep 2005 18:53:14 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 71F9BB7; Wed, 14 Sep 2005 18:53:02 +0200 (CEST) Date: Wed, 14 Sep 2005 18:53:02 +0200 From: Stefan Farfeleder To: Marcel Moolenaar Message-ID: <20050914165300.GG59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> User-Agent: Mutt/1.5.10i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 16:53:18 -0000 On Wed, Sep 14, 2005 at 09:30:26AM -0700, Marcel Moolenaar wrote: > On Sep 14, 2005, at 2:52 AM, Stefan Farfeleder wrote: > > >> Back out 1.247. On ia64 is included from > >>assembler source, > >> the prototype broke buildword. > > > >I waver between guarding the prototype with #ifndef __ASSEMBLER__ and > >moving it to another header, eg. . Opinions? > > I would go with #ifndef __ASSEMBLER__. I think the prototype is > essentially in the right header. I did test your patch and it does > the trick... That would require fixing xorg-server's usage of the header too. I don't know how difficult this is. Stefan From owner-cvs-src@FreeBSD.ORG Wed Sep 14 17:16:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D806E16A41F; Wed, 14 Sep 2005 17:16:15 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DCDC43D45; Wed, 14 Sep 2005 17:16:15 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.3/8.13.3) with ESMTP id j8EHGEMA002663; Wed, 14 Sep 2005 10:16:14 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.3/8.13.3/Submit) id j8EHGDi2002662; Wed, 14 Sep 2005 10:16:13 -0700 (PDT) (envelope-from jmg) Date: Wed, 14 Sep 2005 10:16:13 -0700 From: John-Mark Gurney To: Robert Watson Message-ID: <20050914171613.GQ793@funkthat.com> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050914100957.L33820@fledge.watson.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Marcel Moolenaar , Garance A Drosehn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 17:16:16 -0000 Robert Watson wrote this message on Wed, Sep 14, 2005 at 10:17 +0100: > In both of these cases, having an isolated /var meant that /tmp didn't > fill, so new /tmp files could still be created. Today that would be the > difference between being able to SSH into the machine or not, because SSH > requires inodes and directories to be allocated by default when you log > in. Personally, this is why /tmp should be mfs: tmpmfs="YES" # Set to YES to always create an mfs /tmp, NO to never tmpsize="500m" # Size of mfs /tmp if created I've run with mfs /tmp for a very long time.. I'm surprised we don't enable this by default... even MacOSX does it (though /tmp isn't normally available to the user through Finder)... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Wed Sep 14 17:39:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 865E416A41F; Wed, 14 Sep 2005 17:39:41 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DBC643D49; Wed, 14 Sep 2005 17:39:40 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 327C946B16; Wed, 14 Sep 2005 13:39:40 -0400 (EDT) Date: Wed, 14 Sep 2005 18:39:40 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Marcel Moolenaar In-Reply-To: <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> Message-ID: <20050914183720.P57836@fledge.watson.org> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> <20050914155307.GA32734@odin.ac.hmc.edu> <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Garance A Drosehn Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 17:39:41 -0000 On Wed, 14 Sep 2005, Marcel Moolenaar wrote: >>> We probably ought to move this discussion to another list, but -- I >>> remember two very specific occasions where I first realized how >>> important an isolated /var is: >>> >>> (1) In about 1995, when I first started using ppp, I discovered the >>> hard way that the default logging level was set a bit high, and filled >>> the entire hard disk with log records in a couple of days. > *snip* >> >> I've also hit cases where the log come in so fast that you can fill a >> 1GB /var fast enough that newsyslog never has a chance to compress the >> log. > *snip* > > Just so that people realize: what is being described is not an argument > for having /var be a separate partition, but really for having /var/log > be a separate partition. It's just that the granularity of our thinking > is highly influenced by our legacy, even to the extend of it becoming an > intellectual jail. > > I think it's much easier to size a /var/log partition effectively than > it is to size /, /usr and /var effectively... > > Just some food for thought, Yeah, I specifically mentioned /var/mqueue and /var/mail as examples of other components. I agree though that what current and past state of the art has supported is narrowing our thinking. If we were using a system like AFS (listen to the groans from the crowd who hates it when I harp on AFS!), we would simply allocate different volumes for the directories using the same back-end storage pool, and be able to administratively change the volume quotas at low overhead. The traditional BSD/UNIX quota model and/or file system model has no way to express this sort of notion, and it's a very useful notion. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Wed Sep 14 17:40:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3366516A41F; Wed, 14 Sep 2005 17:40:57 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 695E443D45; Wed, 14 Sep 2005 17:40:56 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j8EHetFO019276; Wed, 14 Sep 2005 10:40:56 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20050914165300.GG59453@wombat.fafoe.narf.at> References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> <20050914165300.GG59453@wombat.fafoe.narf.at> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Wed, 14 Sep 2005 10:40:54 -0700 To: Stefan Farfeleder X-Mailer: Apple Mail (2.734) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 17:40:57 -0000 On Sep 14, 2005, at 9:53 AM, Stefan Farfeleder wrote: >>> I waver between guarding the prototype with #ifndef __ASSEMBLER__ >>> and >>> moving it to another header, eg. . Opinions? >> >> I would go with #ifndef __ASSEMBLER__. I think the prototype is >> essentially in the right header. I did test your patch and it does >> the trick... > > That would require fixing xorg-server's usage of the header too. I > don't know how difficult this is. In that case, you might as well get the prototype out of there. I have no suggestion where to put it yet... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:03:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77E1B16A41F; Wed, 14 Sep 2005 19:03:15 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35D4043D45; Wed, 14 Sep 2005 19:03:15 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EJ3FQr085552; Wed, 14 Sep 2005 19:03:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EJ3Fgh085551; Wed, 14 Sep 2005 19:03:15 GMT (envelope-from ru) Message-Id: <200509141903.j8EJ3Fgh085551@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 14 Sep 2005 19:03:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_cbus.c if_ed_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:03:15 -0000 ru 2005-09-14 19:03:15 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_cbus.c if_ed_pci.c Log: Make device_detach methods really work. Revision Changes Path 1.24 +1 -1 src/sys/dev/ed/if_ed_cbus.c 1.46 +1 -1 src/sys/dev/ed/if_ed_pci.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:05:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A87516A41F; Wed, 14 Sep 2005 19:05:04 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr10.xs4all.nl (smtp-vbr10.xs4all.nl [194.109.24.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A82B43D46; Wed, 14 Sep 2005 19:05:03 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr10.xs4all.nl (8.13.3/8.13.3) with ESMTP id j8EJ4wCK045330; Wed, 14 Sep 2005 21:04:59 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.3/8.13.3) with ESMTP id j8EJ4wKd071499; Wed, 14 Sep 2005 21:04:58 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.3/8.13.1/Submit) id j8EJ4tNo071485; Wed, 14 Sep 2005 21:04:55 +0200 (CEST) (envelope-from wb) Date: Wed, 14 Sep 2005 21:04:55 +0200 From: Wilko Bulte To: Robert Watson Message-ID: <20050914190455.GA71466@freebie.xs4all.nl> References: <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> <20050914155307.GA32734@odin.ac.hmc.edu> <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> <20050914183720.P57836@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050914183720.P57836@fledge.watson.org> X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Alexey Dokuchaev , src-committers@FreeBSD.ORG, Brooks Davis , cvs-src@FreeBSD.ORG, Garance A Drosehn , Marcel Moolenaar , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:05:04 -0000 On Wed, Sep 14, 2005 at 06:39:40PM +0100, Robert Watson wrote.. > > On Wed, 14 Sep 2005, Marcel Moolenaar wrote: > > >>>We probably ought to move this discussion to another list, but -- I > >>>remember two very specific occasions where I first realized how > >>>important an isolated /var is: > >>> > >>>(1) In about 1995, when I first started using ppp, I discovered the > >>> hard way that the default logging level was set a bit high, and > >>> filled > >>> the entire hard disk with log records in a couple of days. > >*snip* > >> > >>I've also hit cases where the log come in so fast that you can fill a > >>1GB /var fast enough that newsyslog never has a chance to compress the > >>log. > >*snip* > > > >Just so that people realize: what is being described is not an argument > >for having /var be a separate partition, but really for having /var/log > >be a separate partition. It's just that the granularity of our thinking > >is highly influenced by our legacy, even to the extend of it becoming an > >intellectual jail. > > > >I think it's much easier to size a /var/log partition effectively than > >it is to size /, /usr and /var effectively... > > > >Just some food for thought, > > Yeah, I specifically mentioned /var/mqueue and /var/mail as examples of > other components. > > I agree though that what current and past state of the art has supported > is narrowing our thinking. If we were using a system like AFS (listen to > the groans from the crowd who hates it when I harp on AFS!), we would > simply allocate different volumes for the directories using the same > back-end storage pool, and be able to administratively change the volume > quotas at low overhead. The traditional BSD/UNIX quota model and/or file > system model has no way to express this sort of notion, and it's a very > useful notion. /me goes out and dynamically expands his RAID LUN on the FC array ;) -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:14:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A558316A41F; Wed, 14 Sep 2005 19:14:32 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6330343D48; Wed, 14 Sep 2005 19:14:32 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EJEWu4086123; Wed, 14 Sep 2005 19:14:32 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EJEWAh086122; Wed, 14 Sep 2005 19:14:32 GMT (envelope-from ache) Message-Id: <200509141914.j8EJEWAh086122@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Wed, 14 Sep 2005 19:14:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen glob.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:14:32 -0000 ache 2005-09-14 19:14:32 UTC FreeBSD src repository Modified files: lib/libc/gen glob.c Log: Don't reuse *pl to skip [], it is already used for {} parts in the loop above (submitted patch slightly modified) PR: 86038 Submitted by: Gerd Rausch Revision Changes Path 1.23 +3 -3 src/lib/libc/gen/glob.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:36:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6CC516A41F; Wed, 14 Sep 2005 19:36:35 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id D21B543D46; Wed, 14 Sep 2005 19:36:34 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Wed, 14 Sep 2005 15:52:13 -0400 From: John Baldwin To: Ruslan Ermilov Date: Wed, 14 Sep 2005 15:37:30 -0400 User-Agent: KMail/1.8 References: <200509141233.j8ECXN28053907@repoman.freebsd.org> In-Reply-To: <200509141233.j8ECXN28053907@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509141537.31787.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_rl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:36:36 -0000 On Wednesday 14 September 2005 08:33 am, Ruslan Ermilov wrote: > ru 2005-09-14 12:33:23 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_rl.c > Log: > Fixed "Memory modified after free" panic in rl_detach() due > to rl_stop() accessing already freed "struct ifnet". > > Fixed LOR between rl mutex and some ACPI mutex in rl_detach(). Very close to the patch I had. :) Note that you can remove the 'attached' variable now since it is only used once and just use 'device_is_attached()' inline in the if-statement like other drivers. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Sep 14 19:47:06 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FA0116A439; Wed, 14 Sep 2005 19:47:06 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from mail.ijs.si (mail.ijs.si [193.2.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id EFEDC43D5D; Wed, 14 Sep 2005 19:47:04 +0000 (GMT) (envelope-from dejan.lesjak@ijs.si) Received: from localhost (mail.ijs.si [193.2.4.66]) by patsy.ijs.si (Postfix) with ESMTP id 2329117B8FA; Wed, 14 Sep 2005 21:47:04 +0200 (CEST) Received: from patsy.ijs.si ([127.0.0.1]) by localhost (patsy.ijs.si [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 67767-02-9; Wed, 14 Sep 2005 21:46:58 +0200 (CEST) Received: from radagast.ijs.si (radagast.ijs.si [193.2.4.168]) by patsy.ijs.si (Postfix) with ESMTP id B494717B8E4; Wed, 14 Sep 2005 21:46:57 +0200 (CEST) Received: from radagast.ijs.si (localhost.ijs.si [127.0.0.1]) by radagast.ijs.si (Postfix) with SMTP id 31EAC1702B; Wed, 14 Sep 2005 21:46:57 +0200 (CEST) From: Dejan Lesjak To: Stefan Farfeleder , cvs-src@freebsd.org, Marcel Moolenaar Date: Wed, 14 Sep 2005 21:46:57 +0200 References: <200509140901.j8E916mL044612@repoman.freebsd.org> <20050914095217.GC59453@wombat.fafoe.narf.at> <154E8DB1-C941-4477-9FB7-BD373DC11898@xcllnt.net> <20050914165300.GG59453__19251.2678368532$1126717092$gmane$org@wombat.fafoe.narf.at> Lines: 58 User-Agent: KNode/0.9.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: <20050914194657.31EAC1702B@radagast.ijs.si> X-Virus-Scanned: amavisd-new at ijs.si Cc: Subject: Re: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 19:47:06 -0000 Stefan Farfeleder wrote: > On Wed, Sep 14, 2005 at 09:30:26AM -0700, Marcel Moolenaar wrote: >> On Sep 14, 2005, at 2:52 AM, Stefan Farfeleder wrote: >> >> >> Back out 1.247. On ia64 is included from >> >>assembler source, >> >> the prototype broke buildword. >> > >> >I waver between guarding the prototype with #ifndef __ASSEMBLER__ and >> >moving it to another header, eg. . Opinions? >> >> I would go with #ifndef __ASSEMBLER__. I think the prototype is >> essentially in the right header. I did test your patch and it does >> the trick... > > That would require fixing xorg-server's usage of the header too. I > don't know how difficult this is. The trouble is rather in imake. To enable/disable some stuff imake grabs __FreeBSD_version (basically similarly that ports system uses OSVERSION variable). Since imake is basically cpp all it needs to do here is include osreldate.h and it gets the proper #define. Imake doesn't care much if there's a prototype for getosreldate there. It just blindly includes it in generated Makefile. make(1) is the one that then gets confused :) Example from x11-clocks/xtimer: ===> Configuring for xtimer-0.8089 imake -DUseInstalled -I/usr/X11R6/lib/X11/config make Makefiles "Makefile", line 33: Need an operator make: fatal errors encountered -- cannot continue *** Error code 1 The part of imake configuration (file FreeBSD.cf) that includes osreldate.h looks like this: #ifndef OSRelVersion /* Include this to get finer-grained information about the OS version */ #include "/usr/include/osreldate.h" #define OSRelVersion __FreeBSD_version #endif Now if the prototype would be guarded with #ifndef __ASSEMBLER__, we could change that part to something like: #ifndef OSRelVersion /* Include this to get finer-grained information about the OS version */ #define __ASSEMBLER__ #include "/usr/include/osreldate.h" #undef __ASSEMBLER__ #define OSRelVersion __FreeBSD_version #endif which seems a bit silly but it works :) Dejan From owner-cvs-src@FreeBSD.ORG Wed Sep 14 20:35:46 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB62F16A41F; Wed, 14 Sep 2005 20:35:46 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB27E43D45; Wed, 14 Sep 2005 20:35:46 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8EKZkwP089701; Wed, 14 Sep 2005 20:35:46 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8EKZk71089700; Wed, 14 Sep 2005 20:35:46 GMT (envelope-from ache) Message-Id: <200509142035.j8EKZk71089700@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Wed, 14 Sep 2005 20:35:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen getcwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 20:35:47 -0000 ache 2005-09-14 20:35:46 UTC FreeBSD src repository Modified files: lib/libc/gen getcwd.c Log: Remove any hardcoded assumptions about malloc's way of allocating, just use MAXPATHLEN. It prevents potential buffer overflow with other malloc implementations. (this change based on submitted patch) PR: 86135 Submitted by: Trevor Blackwell Revision Changes Path 1.26 +4 -4 src/lib/libc/gen/getcwd.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 21:15:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC47E16A423; Wed, 14 Sep 2005 21:15:51 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69A4943D45; Wed, 14 Sep 2005 21:15:51 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ELFpL0098542; Wed, 14 Sep 2005 21:15:51 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ELFp2M098541; Wed, 14 Sep 2005 21:15:51 GMT (envelope-from jkoshy) Message-Id: <200509142115.j8ELFp2M098541@repoman.freebsd.org> From: Joseph Koshy Date: Wed, 14 Sep 2005 21:15:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat_log.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 21:15:52 -0000 jkoshy 2005-09-14 21:15:50 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat_log.c Log: Determine where the runtime loader got mapped to when a dynamically linked process was exec()'ed, and map samples in that address range into the appropriate buckets in the runtime loader's profile. Improve a few comments. MFC after: 3 days Revision Changes Path 1.5 +119 -85 src/usr.sbin/pmcstat/pmcstat_log.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 21:21:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC96416A41F; Wed, 14 Sep 2005 21:21:45 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B8D743D48; Wed, 14 Sep 2005 21:21:45 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ELLjbI098827; Wed, 14 Sep 2005 21:21:45 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ELLj2B098826; Wed, 14 Sep 2005 21:21:45 GMT (envelope-from marius) Message-Id: <200509142121.j8ELLj2B098826@repoman.freebsd.org> From: Marius Strobl Date: Wed, 14 Sep 2005 21:21:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/geom/class Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 21:21:45 -0000 marius 2005-09-14 21:21:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/geom/class Makefile Log: MFC: 1.10 As with NO_CRYPT, don't try to compile geli(8) when NO_OPENSSL is defined either. Approved by: re (scottl) Revision Changes Path 1.5.2.3 +1 -1 src/sbin/geom/class/Makefile From owner-cvs-src@FreeBSD.ORG Wed Sep 14 21:23:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61EC516A41F; Wed, 14 Sep 2005 21:23:51 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3748943D49; Wed, 14 Sep 2005 21:23:51 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ELNpkl098942; Wed, 14 Sep 2005 21:23:51 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ELNpGe098941; Wed, 14 Sep 2005 21:23:51 GMT (envelope-from marius) Message-Id: <200509142123.j8ELNpGe098941@repoman.freebsd.org> From: Marius Strobl Date: Wed, 14 Sep 2005 21:23:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/gem if_gem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 21:23:51 -0000 marius 2005-09-14 21:23:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/gem if_gem.c Log: MFC: 1.34 - Allow for VLAN-sized frames and set IFCAP_VLAN_MTU. - On resume all registers have to be initialized again like after power-on so reset sc_inited in gem_suspend() in order get all of the registers set next time gem_init_regs() is called. - On at least some ERI and GEM revisions GEM_MAC_RX_OVERFLOW happen often due to a silicon bug and re-initializing is all we can do about these errors so make handling them non-verbose. - Remove a superfluous memset(3) call in gem_meminit(), all elements are initialized to 0 anyway. Approved by: re (scottl) Revision Changes Path 1.29.2.4 +23 -8 src/sys/dev/gem/if_gem.c From owner-cvs-src@FreeBSD.ORG Wed Sep 14 21:26:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3BA416A41F; Wed, 14 Sep 2005 21:26:10 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B816843D4C; Wed, 14 Sep 2005 21:26:09 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ELQ9BF099065; Wed, 14 Sep 2005 21:26:09 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ELQ9ka099064; Wed, 14 Sep 2005 21:26:09 GMT (envelope-from marius) Message-Id: <200509142126.j8ELQ9ka099064@repoman.freebsd.org> From: Marius Strobl Date: Wed, 14 Sep 2005 21:26:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 vlan.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 21:26:11 -0000 marius 2005-09-14 21:26:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 vlan.4 Log: MFC: 1.26 Add gem(4) to the list of devices supporting VLAN-sized frames natively (since sys/dev/gem/if_gem.c rev. 1.34, MFC'ed in rev. 1.29.2.4). Approved by: re (scottl) Revision Changes Path 1.23.2.1 +5 -1 src/share/man/man4/vlan.4 From owner-cvs-src@FreeBSD.ORG Wed Sep 14 21:38:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34E8116A41F; Wed, 14 Sep 2005 21:38:37 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA24443D67; Wed, 14 Sep 2005 21:38:35 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8ELcZfo099821; Wed, 14 Sep 2005 21:38:35 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8ELcZ3V099820; Wed, 14 Sep 2005 21:38:35 GMT (envelope-from rodrigc) Message-Id: <200509142138.j8ELcZ3V099820@repoman.freebsd.org> From: Craig Rodrigues Date: Wed, 14 Sep 2005 21:38:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_slice.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 21:38:37 -0000 rodrigc 2005-09-14 21:38:35 UTC FreeBSD src repository Modified files: sys/geom geom_slice.c Log: Fix so that when a slice or a partition is removed through g_slice_config(), it is destroyed in GEOM, in addition to being removed from /dev. Before this patch, if you applied a new MBR which deleted a slice, the deleted slice would not be in /dev, but it would still appear in kern.geom.conftxt and kern.geom.confxml, which would confused the diskPartitionEditor in sysinstall. Submitted by: pjd Tested by: pjd, rodrigc MFC after: 1 week Revision Changes Path 1.58 +1 -0 src/sys/geom/geom_slice.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 00:12:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9FE716A41F; Thu, 15 Sep 2005 00:12:30 +0000 (GMT) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76B7543D46; Thu, 15 Sep 2005 00:12:29 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 73744131D53; Thu, 15 Sep 2005 09:42:28 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 4DD6E84F7E; Thu, 15 Sep 2005 09:42:28 +0930 (CST) Date: Thu, 15 Sep 2005 09:42:28 +0930 From: Greg 'groggy' Lehey To: Marcel Moolenaar Message-ID: <20050915001228.GC38674@wantadilla.lemis.com> References: <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YjUCIDG0UL7zSTfa" Content-Disposition: inline In-Reply-To: <0D07312F-7DDB-40E4-A63A-3E00969F5A4C@xcllnt.net> <20050914100957.L33820@fledge.watson.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, Brooks Davis , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Garance A Drosehn Subject: Unifying partitions (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 00:12:31 -0000 --YjUCIDG0UL7zSTfa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wednesday, 14 September 2005 at 9:27:11 -0700, Marcel Moolenaar wrote: > On Sep 14, 2005, at 8:53 AM, Brooks Davis wrote: > >> I've also hit cases where the log come in so fast that you can fill a >> 1GB /var fast enough that newsyslog never has a chance to compress the >> log. > > Just so that people realize: what is being described is not an > argument for having /var be a separate partition, but really for > having /var/log be a separate partition. Brooks' argument, yes. rwatson's argument was for mail. The recommendation I made was to put /var in the root file system *unless there are good reasons not to do so*. The issue here is that automatic partitioning can't take your usage patterns into account. Where you do need large a /var, it makes sense to have a separate partition. But most people create a separate /var, usually too big or too small, because that's the way it's done. FWIW, I don't use a separate /var on any of my systems, though there's certainly an argument to do so. But I haven't run out of space. Note also that in this case, an alternative to a separate partition is to set up quotas. Not that I do that, either. Greg -- See complete headers for address and phone numbers. --YjUCIDG0UL7zSTfa Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKLxsIubykFB6QiMRAqjTAJ9obaw4TqAo2VViNlZaoFYzX8XYVgCfYHCu FSO8ENhjQWZaYKVPkc7cIBo= =cl0Y -----END PGP SIGNATURE----- --YjUCIDG0UL7zSTfa-- From owner-cvs-src@FreeBSD.ORG Thu Sep 15 02:29:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8724E16A41F; Thu, 15 Sep 2005 02:29:37 +0000 (GMT) (envelope-from jcamou@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45A8843D48; Thu, 15 Sep 2005 02:29:37 +0000 (GMT) (envelope-from jcamou@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F2TbGv020600; Thu, 15 Sep 2005 02:29:37 GMT (envelope-from jcamou@repoman.freebsd.org) Received: (from jcamou@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F2Tb8L020599; Thu, 15 Sep 2005 02:29:37 GMT (envelope-from jcamou) Message-Id: <200509150229.j8F2Tb8L020599@repoman.freebsd.org> From: "Jesus R. Camou" Date: Thu, 15 Sep 2005 02:29:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/contrib/amd/amd amd.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 02:29:37 -0000 jcamou 2005-09-15 02:29:37 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_5) contrib/amd/amd amd.8 Log: MFC: rev. 1.22. Approved by: trhodes (mentor) Revision Changes Path 1.19.2.1 +74 -49 src/contrib/amd/amd/amd.8 From owner-cvs-src@FreeBSD.ORG Thu Sep 15 04:05:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3595A16A41F; Thu, 15 Sep 2005 04:05:10 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C080243D49; Thu, 15 Sep 2005 04:05:09 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F459iZ024308; Thu, 15 Sep 2005 04:05:09 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F459GD024307; Thu, 15 Sep 2005 04:05:09 GMT (envelope-from imp) Message-Id: <200509150405.j8F459GD024307@repoman.freebsd.org> From: Warner Losh Date: Thu, 15 Sep 2005 04:05:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ed if_ed_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 04:05:10 -0000 imp 2005-09-15 04:05:09 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_pccard.c Log: When stopping the card, and returning to page 0, it is best if you do that with the NIC set of registers rather than the ASIC registers. I believe this was a harmless oversight, since we set ED_P0_CR to the same value 5ms later, but just to be safe... Revision Changes Path 1.99 +1 -1 src/sys/dev/ed/if_ed_pccard.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 05:32:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAABA16A41F; Thu, 15 Sep 2005 05:32:11 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90B0143D46; Thu, 15 Sep 2005 05:32:11 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F5WBmd034689; Thu, 15 Sep 2005 05:32:11 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F5WBk4034688; Thu, 15 Sep 2005 05:32:11 GMT (envelope-from marcel) Message-Id: <200509150532.j8F5WBk4034688@repoman.freebsd.org> From: Marcel Moolenaar Date: Thu, 15 Sep 2005 05:32:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.1 kgdb.h kthr.c main.c trgt.c trgt_alpha.c trgt_amd64.c trgt_i386.c trgt_ia64.c trgt_sparc64.c src/gnu/usr.bin/gdb/libgdb Makefile frame-unwind.diff X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 05:32:11 -0000 marcel 2005-09-15 05:32:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/gdb/kgdb kgdb.1 kgdb.h kthr.c main.c trgt.c trgt_alpha.c trgt_amd64.c trgt_i386.c trgt_ia64.c trgt_sparc64.c gnu/usr.bin/gdb/libgdb Makefile Added files: (Branch: RELENG_6) gnu/usr.bin/gdb/libgdb frame-unwind.diff Log: Mega-MFC: o Manpage type fix: kgdb/kgdb.1: 1.8 o Unwind across trapframes: kgdb/kgdb.h: 1.3 kgdb/kthr.c: 1.3 kgdb/main.c: 1.9 kgdb/trgt.c: 1.4 kgdb/trgt_alpha.c: 1.3, 1.4 kgdb/trgt_amd64.c: 1.3, 1.4, 1.5 kgdb/trgt_i386.c: 1.3, 1.4, 1.5 kgdb/trgt_ia64.c: 1.3, 1.4 kgdb/trgt_sparc64.c: 1.4, 1.5, 1.6 libgdb/Makefile: 1.10 libgdb/frame-unwind.diff: 1.1 Approved by: re (scottl) Revision Changes Path 1.7.2.1 +1 -1 src/gnu/usr.bin/gdb/kgdb/kgdb.1 1.2.2.1 +3 -1 src/gnu/usr.bin/gdb/kgdb/kgdb.h 1.2.2.1 +1 -0 src/gnu/usr.bin/gdb/kgdb/kthr.c 1.7.2.2 +5 -0 src/gnu/usr.bin/gdb/kgdb/main.c 1.2.2.2 +1 -0 src/gnu/usr.bin/gdb/kgdb/trgt.c 1.2.2.1 +122 -12 src/gnu/usr.bin/gdb/kgdb/trgt_alpha.c 1.2.2.1 +129 -11 src/gnu/usr.bin/gdb/kgdb/trgt_amd64.c 1.2.2.1 +120 -8 src/gnu/usr.bin/gdb/kgdb/trgt_i386.c 1.2.2.1 +229 -48 src/gnu/usr.bin/gdb/kgdb/trgt_ia64.c 1.2.2.2 +124 -2 src/gnu/usr.bin/gdb/kgdb/trgt_sparc64.c 1.9.2.1 +6 -2 src/gnu/usr.bin/gdb/libgdb/Makefile 1.1.2.1 +27 -0 src/gnu/usr.bin/gdb/libgdb/frame-unwind.diff (new) From owner-cvs-src@FreeBSD.ORG Thu Sep 15 06:57:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B55EC16A41F; Thu, 15 Sep 2005 06:57:28 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8780343D4C; Thu, 15 Sep 2005 06:57:28 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F6vSk2038374; Thu, 15 Sep 2005 06:57:28 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F6vSir038373; Thu, 15 Sep 2005 06:57:28 GMT (envelope-from phk) Message-Id: <200509150657.j8F6vSir038373@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 06:57:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs.h devfs_devs.c devfs_rule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 06:57:28 -0000 phk 2005-09-15 06:57:28 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs.h devfs_devs.c devfs_rule.c Log: Close a race which could result in unwarranted "ruleset %d already running" panics. Previously, recursion through the "include" feature was prevented by marking each ruleset as "running" when applied. This doesn't work for the case where two DEVFS instances try to apply the same ruleset at the same time. Instead introduce the sysctl vfs.devfs.rule_depth (default == 1) which limits how many levels of "include" we will traverse. Be aware that traversal of "include" is recursive and kernel stack size is limited. MFC: after 3 days Revision Changes Path 1.24 +2 -0 src/sys/fs/devfs/devfs.h 1.41 +4 -0 src/sys/fs/devfs/devfs_devs.c 1.16 +28 -44 src/sys/fs/devfs/devfs_rule.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 08:01:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEA3D16A41F; Thu, 15 Sep 2005 08:01:58 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C6ED43D46; Thu, 15 Sep 2005 08:01:58 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F81wDO041280; Thu, 15 Sep 2005 08:01:58 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F81wRL041279; Thu, 15 Sep 2005 08:01:58 GMT (envelope-from phk) Message-Id: <200509150801.j8F81wRL041279@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 08:01:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys conf.h src/sys/kern kern_conf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 08:01:59 -0000 phk 2005-09-15 08:01:57 UTC FreeBSD src repository Modified files: sys/sys conf.h sys/kern kern_conf.c Log: Retire unused dev_named() function. Revision Changes Path 1.192 +0 -13 src/sys/kern/kern_conf.c 1.227 +0 -1 src/sys/sys/conf.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 08:18:32 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F32A16A41F; Thu, 15 Sep 2005 08:18:32 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from mail26.syd.optusnet.com.au (mail26.syd.optusnet.com.au [211.29.133.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E58343D45; Thu, 15 Sep 2005 08:18:30 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail26.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id j8F8ISgV001117 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 15 Sep 2005 18:18:28 +1000 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1]) by cirb503493.alcatel.com.au (8.12.10/8.12.10) with ESMTP id j8F8IRSR045088; Thu, 15 Sep 2005 18:18:27 +1000 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost) by cirb503493.alcatel.com.au (8.12.10/8.12.9/Submit) id j8F8IR2w045087; Thu, 15 Sep 2005 18:18:27 +1000 (EST) (envelope-from pjeremy) Date: Thu, 15 Sep 2005 18:18:27 +1000 From: Peter Jeremy To: Robert Watson , "Greg 'groggy' Lehey" Message-ID: <20050915081826.GB40237@cirb503493.alcatel.com.au> References: <20050911002229.51F4916A471@hub.freebsd.org> <432382BC.5080105@root.org> <200509110310.36423@harrymail> <43255152.3000609@freebsd.org> <20050912165518.GA94181@dragon.NUXI.org> <20050913125820.GA10663@FreeBSD.org> <20050914100957.L33820@fledge.watson.org> <20050915001228.GC38674@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050914183720.P57836@fledge.watson.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: Unifying partitions (was: cvs commit: src/sys/conf kern.post.mk) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 08:18:32 -0000 On Wed, 2005-Sep-14 18:39:40 +0100, Robert Watson wrote: >I agree though that what current and past state of the art has supported >is narrowing our thinking. If we were using a system like AFS ... AdvFS is also good at this. Without a SAN backend, it's really nice to be able to migrate data from a 4GB disk to a 36GB disk without any outage. It would be _really_ nice if someone managed to implement the equivalent of addvol and rmvol in UFS. On Thu, 2005-Sep-15 09:42:28 +0930, Greg 'groggy' Lehey wrote: >partition. But most people create a separate /var, usually too big or >too small, because that's the way it's done. I've found the requirements on /var have increased significantly over time. >Note also that in this case, an alternative to a separate partition is >to set up quotas. Not that I do that, either. It's still useful to be able to segregate highly volatile data from relatively stable data. Mostly read-only root filesystem is far more likely to survive a serious melt-down. -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Thu Sep 15 08:36:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C3BA16A41F; Thu, 15 Sep 2005 08:36:38 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB1AA43D45; Thu, 15 Sep 2005 08:36:37 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F8aboj042683; Thu, 15 Sep 2005 08:36:37 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F8abV8042682; Thu, 15 Sep 2005 08:36:37 GMT (envelope-from phk) Message-Id: <200509150836.j8F8abV8042682@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 08:36:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs.h devfs_rule.c devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 08:36:38 -0000 phk 2005-09-15 08:36:37 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs.h devfs_rule.c devfs_vnops.c Log: Absolve devfs_rule.c from locking responsibility and call it with all necessary locking held. Revision Changes Path 1.25 +1 -1 src/sys/fs/devfs/devfs.h 1.17 +1 -15 src/sys/fs/devfs/devfs_rule.c 1.123 +3 -3 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 08:50:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 049BB16A41F; Thu, 15 Sep 2005 08:50:17 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5A2243D45; Thu, 15 Sep 2005 08:50:16 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8F8oGgB050351; Thu, 15 Sep 2005 08:50:16 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8F8oGgi050350; Thu, 15 Sep 2005 08:50:16 GMT (envelope-from phk) Message-Id: <200509150850.j8F8oGgi050350@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 08:50:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs_rule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 08:50:17 -0000 phk 2005-09-15 08:50:16 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_rule.c Log: Protect the devfs rule internal global lists with a sx lock, the per mount locks are not enough. Finer granularity (x)locking could be implemented, but I prefer to keep it simple for now. Revision Changes Path 1.18 +9 -1 src/sys/fs/devfs/devfs_rule.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 10:28:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AC1216A41F; Thu, 15 Sep 2005 10:28:20 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38C5A43D48; Thu, 15 Sep 2005 10:28:20 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FASK2G055829; Thu, 15 Sep 2005 10:28:20 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FASKpF055828; Thu, 15 Sep 2005 10:28:20 GMT (envelope-from phk) Message-Id: <200509151028.j8FASKpF055828@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 10:28:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs.h devfs_devs.c devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 10:28:20 -0000 phk 2005-09-15 10:28:20 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs.h devfs_devs.c devfs_vnops.c Log: Various minor polishing. Revision Changes Path 1.26 +1 -1 src/sys/fs/devfs/devfs.h 1.42 +5 -6 src/sys/fs/devfs/devfs_devs.c 1.124 +4 -15 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 11:45:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9ABC216A41F; Thu, 15 Sep 2005 11:45:37 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59CA143D45; Thu, 15 Sep 2005 11:45:37 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FBjbwL070615; Thu, 15 Sep 2005 11:45:37 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FBjbAU070614; Thu, 15 Sep 2005 11:45:37 GMT (envelope-from maxim) Message-Id: <200509151145.j8FBjbAU070614@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 15 Sep 2005 11:45:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 11:45:37 -0000 maxim 2005-09-15 11:45:37 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: o Return ENOTCONN when shutdown(2) on non-connected socket. PR: kern/84761 Submitted by: James Juran R-test: tools/regression/sockets/shutdown MFC after: 1 month Revision Changes Path 1.246 +2 -0 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 12:16:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B6E416A41F; Thu, 15 Sep 2005 12:16:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88A7A43D55; Thu, 15 Sep 2005 12:16:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id BC96446B81; Thu, 15 Sep 2005 08:16:46 -0400 (EDT) Date: Thu, 15 Sep 2005 13:16:46 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Konovalov In-Reply-To: <200509151145.j8FBjbAU070614@repoman.freebsd.org> Message-ID: <20050915130901.R75005@fledge.watson.org> References: <200509151145.j8FBjbAU070614@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 12:16:50 -0000 On Thu, 15 Sep 2005, Maxim Konovalov wrote: > maxim 2005-09-15 11:45:37 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > o Return ENOTCONN when shutdown(2) on non-connected socket. > > PR: kern/84761 > Submitted by: James Juran > R-test: tools/regression/sockets/shutdown > MFC after: 1 month Are you sure this is the right thing to do? I've seen shutdown used in several applications on non-connection-oriented sockets in order to indicate no messages will be received, so not to allow received packets to consume space. Typical use is in the context of a raw IP or IPv6 socket, where raw packets will be sent but never received, and the socket will otherwise collect the normal random network detrious. For example, rtsold(8) uses shutdown(2) on its IPv6 raw socket to indicate it is send-only, so received packets should not be stored in the socket buffer since they will never be read. It does, however, contain the not unusual bug that it is called with an argument of 0, assuming that that will be the value SHUT_RD. I'm fairly sure we used to have other examples of shutdown(2) being used in this way in the tree but don't see any others in a casual glance. While POSIX mentions behavior for full-duplex connections, it does not specify for sockets that are not connection-oriented, so as I read it, the behavior we provide is permitted. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:07:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CD2016A41F; Thu, 15 Sep 2005 13:07:39 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B22543D48; Thu, 15 Sep 2005 13:07:39 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FD7d0R081223; Thu, 15 Sep 2005 13:07:39 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FD7cT1081222; Thu, 15 Sep 2005 13:07:38 GMT (envelope-from phk) Message-Id: <200509151307.j8FD7cT1081222@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 13:07:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ieee488 upd7210.c upd7210.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:07:39 -0000 phk 2005-09-15 13:07:38 UTC FreeBSD src repository Modified files: sys/dev/ieee488 upd7210.c upd7210.h Log: Allocate unit numbers with unr, implement detach function. Revision Changes Path 1.8 +19 -5 src/sys/dev/ieee488/upd7210.c 1.5 +2 -0 src/sys/dev/ieee488/upd7210.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:14:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D3E716A41F; Thu, 15 Sep 2005 13:14:20 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 686C943D45; Thu, 15 Sep 2005 13:14:16 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.3/8.13.3) with ESMTP id j8FDE4Bq020649; Thu, 15 Sep 2005 17:14:15 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Thu, 15 Sep 2005 17:14:04 +0400 (MSD) From: Maxim Konovalov To: Robert Watson In-Reply-To: <20050915130901.R75005@fledge.watson.org> Message-ID: <20050915165142.F20393@mp2.macomnet.net> References: <200509151145.j8FBjbAU070614@repoman.freebsd.org> <20050915130901.R75005@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:14:20 -0000 On Thu, 15 Sep 2005, 13:16+0100, Robert Watson wrote: > > On Thu, 15 Sep 2005, Maxim Konovalov wrote: > > > maxim 2005-09-15 11:45:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_socket.c > > Log: > > o Return ENOTCONN when shutdown(2) on non-connected socket. > > > > PR: kern/84761 > > Submitted by: James Juran > > R-test: tools/regression/sockets/shutdown > > MFC after: 1 month > > Are you sure this is the right thing to do? I've seen shutdown used > in several applications on non-connection-oriented sockets in order > to indicate no messages will be received, so not to allow received > packets to consume space. Typical use is in the context of a raw IP > or IPv6 socket, where raw packets will be sent but never received, > and the socket will otherwise collect the normal random network > detrious. > > For example, rtsold(8) uses shutdown(2) on its IPv6 raw socket to > indicate it is send-only, so received packets should not be stored > in the socket buffer since they will never be read. It does, > however, contain the not unusual bug that it is called with an > argument of 0, assuming that that will be the value SHUT_RD. I'm > fairly sure we used to have other examples of shutdown(2) being used > in this way in the tree but don't see any others in a casual glance. > > While POSIX mentions behavior for full-duplex connections, it does > not specify for sockets that are not connection-oriented, so as I > read it, the behavior we provide is permitted. Linux 2.4.21 return ENOTSUP for SOCK_RAW and ENOTCONN for non-connected SOCK_DGRAM. Solaris 9 returns ENOTCONN for non-connected SOCK_RAW and they don't allow shutdown(2) on non-connected sockets. Anyhow, I'll backout this code. -- Maxim Konovalov From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:16:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D016816A422; Thu, 15 Sep 2005 13:16:07 +0000 (GMT) (envelope-from rse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B48943D45; Thu, 15 Sep 2005 13:16:07 +0000 (GMT) (envelope-from rse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDG76r081830; Thu, 15 Sep 2005 13:16:07 GMT (envelope-from rse@repoman.freebsd.org) Received: (from rse@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDG71X081829; Thu, 15 Sep 2005 13:16:07 GMT (envelope-from rse) Message-Id: <200509151316.j8FDG71X081829@repoman.freebsd.org> From: "Ralf S. Engelschall" Date: Thu, 15 Sep 2005 13:16:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern init_main.c src/sbin/init init.8 init.c src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:16:08 -0000 rse 2005-09-15 13:16:07 UTC FreeBSD src repository Modified files: sys/kern init_main.c sbin/init init.8 init.c share/man/man5 rc.conf.5 Log: Fix system shutdown timeout handling by again supporting longer running shutdown procedures (which have a duration of more than 120 seconds). We have two user-space affecting shutdown timeouts: a "soft" one in /etc/rc.shutdown and a "hard" one in init(8). The first one can be configured via /etc/rc.conf variable "rcshutdown_timeout" and defaults to 30 seconds. The second one was originally (in 1998) intended to be configured via sysctl(8) variable "kern.shutdown_timeout" and defaults to 120 seconds. Unfortunately, the "kern.shutdown_timeout" was declared "unused" in 1999 (as it obviously is actually not used within the kernel itself) and hence was intentionally but misleadingly removed in revision 1.107 from init_main.c. Kernel sysctl(8) variables are certainly a wrong way to control user-space processes in general, but in this particular case the sysctl(8) variable should have remained as it supports init(8), which isn't passed command line flags (which in turn could have been set via /etc/rc.conf), etc. As there is already a similar "kern.init_path" sysctl(8) variable which directly affects init(8), resurrect the init(8) shutdown timeout under sysctl(8) variable "kern.init_shutdown_timeout". But this time document it as being intentionally unused within the kernel and used by init(8). Also document it in the manpages init(8) and rc.conf(5). Reviewed by: phk MFC after: 2 weeks Revision Changes Path 1.48 +7 -1 src/sbin/init/init.8 1.61 +1 -1 src/sbin/init/init.c 1.264 +16 -1 src/share/man/man5/rc.conf.5 1.257 +11 -0 src/sys/kern/init_main.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:18:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9645916A41F; Thu, 15 Sep 2005 13:18:06 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56BF543D45; Thu, 15 Sep 2005 13:18:06 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDI6eE081892; Thu, 15 Sep 2005 13:18:06 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDI6CM081891; Thu, 15 Sep 2005 13:18:06 GMT (envelope-from maxim) Message-Id: <200509151318.j8FDI6CM081891@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 15 Sep 2005 13:18:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:18:06 -0000 maxim 2005-09-15 13:18:05 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Backout rev. 1.246, it breaks code uses shutdown(2) on non-connected sockets. Pointed out by: rwatson Revision Changes Path 1.247 +0 -2 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:20:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D594316A41F; Thu, 15 Sep 2005 13:20:42 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD3EF43D5C; Thu, 15 Sep 2005 13:20:39 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDKdYY082044; Thu, 15 Sep 2005 13:20:39 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDKdp6082043; Thu, 15 Sep 2005 13:20:39 GMT (envelope-from maxim) Message-Id: <200509151320.j8FDKdp6082043@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 15 Sep 2005 13:20:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sockets/shutdown shutdown.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:20:43 -0000 maxim 2005-09-15 13:20:39 UTC FreeBSD src repository Modified files: tools/regression/sockets/shutdown shutdown.c Log: Remove checks for shutdown(2) on non-connected socket. Revision Changes Path 1.2 +0 -7 src/tools/regression/sockets/shutdown/shutdown.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:27:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F00216A41F; Thu, 15 Sep 2005 13:27:17 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BE8543D49; Thu, 15 Sep 2005 13:27:17 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDRGCd082474; Thu, 15 Sep 2005 13:27:17 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDRGmr082473; Thu, 15 Sep 2005 13:27:16 GMT (envelope-from phk) Message-Id: <200509151327.j8FDRGmr082473@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 13:27:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ieee488 tnt4882.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:27:17 -0000 phk 2005-09-15 13:27:16 UTC FreeBSD src repository Added files: sys/dev/ieee488 tnt4882.c Log: First cut at a driver for National Instruments PCI-GPIB hardware. Hardware donated by: "Greg Maciejewski" Revision Changes Path 1.1 +400 -0 src/sys/dev/ieee488/tnt4882.c (new) From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:28:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7D7516A41F; Thu, 15 Sep 2005 13:28:33 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8764243D46; Thu, 15 Sep 2005 13:28:33 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDSXXY082577; Thu, 15 Sep 2005 13:28:33 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDSX0Z082576; Thu, 15 Sep 2005 13:28:33 GMT (envelope-from phk) Message-Id: <200509151328.j8FDSX0Z082576@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 13:28:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf NOTES files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:28:34 -0000 phk 2005-09-15 13:28:33 UTC FreeBSD src repository Modified files: sys/conf NOTES files Log: Add tnt4882 driver to the build Revision Changes Path 1.1329 +5 -1 src/sys/conf/NOTES 1.1048 +5 -2 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:29:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDF1116A41F; Thu, 15 Sep 2005 13:29:10 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AF4443D46; Thu, 15 Sep 2005 13:29:10 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FDTAcU082625; Thu, 15 Sep 2005 13:29:10 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FDTAm6082624; Thu, 15 Sep 2005 13:29:10 GMT (envelope-from cperciva) Message-Id: <200509151329.j8FDTAm6082624@repoman.freebsd.org> From: Colin Percival Date: Thu, 15 Sep 2005 13:29:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/portsnap/portsnap portsnap.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:29:10 -0000 cperciva 2005-09-15 13:29:10 UTC FreeBSD src repository Modified files: usr.sbin/portsnap/portsnap portsnap.sh Log: Portsnap uses host(1) to search for mirrors, but this is only available when the base system is not compiled with NO_BIND set. Before we start searching for mirrors, make sure that host(1) can be found, and if it doesn't exist then fallback to the A record instead of the SRV records. Submitted by: Luca Morettoni Revision Changes Path 1.12 +6 -0 src/usr.sbin/portsnap/portsnap/portsnap.sh From owner-cvs-src@FreeBSD.ORG Thu Sep 15 13:37:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 984FA16A41F; Thu, 15 Sep 2005 13:37:08 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id D360F43D49; Thu, 15 Sep 2005 13:37:07 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id DD1A346BA5; Thu, 15 Sep 2005 09:37:04 -0400 (EDT) Date: Thu, 15 Sep 2005 14:37:04 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Konovalov In-Reply-To: <20050915165142.F20393@mp2.macomnet.net> Message-ID: <20050915143344.P75005@fledge.watson.org> References: <200509151145.j8FBjbAU070614@repoman.freebsd.org> <20050915130901.R75005@fledge.watson.org> <20050915165142.F20393@mp2.macomnet.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:37:08 -0000 On Thu, 15 Sep 2005, Maxim Konovalov wrote: >> Are you sure this is the right thing to do? I've seen shutdown used in >> several applications on non-connection-oriented sockets in order to >> indicate no messages will be received, so not to allow received packets >> to consume space. Typical use is in the context of a raw IP or IPv6 >> socket, where raw packets will be sent but never received, and the >> socket will otherwise collect the normal random network detrious. >> >> For example, rtsold(8) uses shutdown(2) on its IPv6 raw socket to >> indicate it is send-only, so received packets should not be stored in >> the socket buffer since they will never be read. It does, however, >> contain the not unusual bug that it is called with an argument of 0, >> assuming that that will be the value SHUT_RD. I'm fairly sure we used >> to have other examples of shutdown(2) being used in this way in the >> tree but don't see any others in a casual glance. >> >> While POSIX mentions behavior for full-duplex connections, it does not >> specify for sockets that are not connection-oriented, so as I read it, >> the behavior we provide is permitted. > > Linux 2.4.21 return ENOTSUP for SOCK_RAW and ENOTCONN for non-connected > SOCK_DGRAM. Solaris 9 returns ENOTCONN for non-connected SOCK_RAW and > they don't allow shutdown(2) on non-connected sockets. Anyhow, I'll > backout this code. I suspect that where we sit today is that the specification is based on the least common denominator of the API's derived from the Berkeley sockets implementation. The good news is that POSIX doesn't appear to prohibit our useful behavior... The trick is going to be for us to define the behavior we guarantee vs. the behavior that is an accident of our implementation. For example, in the case of the fifo code, we permitted a broad range of socket and network stack ioctls on fifos, even though the fifo API specification is really derived from the behavior of pipes.. :-) Robert N M Watson From owner-cvs-src@FreeBSD.ORG Thu Sep 15 14:10:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D474716A41F; Thu, 15 Sep 2005 14:10:41 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A43843D45; Thu, 15 Sep 2005 14:10:41 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FEAfTw084271; Thu, 15 Sep 2005 14:10:41 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FEAfEe084270; Thu, 15 Sep 2005 14:10:41 GMT (envelope-from pjd) Message-Id: <200509151410.j8FEAfEe084270@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 15 Sep 2005 14:10:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 14:10:42 -0000 pjd 2005-09-15 14:10:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bge if_bge.c Log: MFC: sys/dev/bge/if_bge.c 1.94 When bge_stop() is called from bge_detach(), mii is already NULL, so check before trying to use it. This fix allows to 'kldunload if_bge' without panicing. Reviewed by: bz Approved by: re (scottl) Revision Changes Path 1.91.2.3 +10 -5 src/sys/dev/bge/if_bge.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 14:12:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3970716A41F; Thu, 15 Sep 2005 14:12:55 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0E0843D53; Thu, 15 Sep 2005 14:12:54 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FECsM9084375; Thu, 15 Sep 2005 14:12:54 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FECsAB084374; Thu, 15 Sep 2005 14:12:54 GMT (envelope-from pjd) Message-Id: <200509151412.j8FECsAB084374@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 15 Sep 2005 14:12:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/geom/class/eli geom_eli.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 14:12:55 -0000 pjd 2005-09-15 14:12:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/geom/class/eli geom_eli.c Log: MFC: sbin/geom/class/eli/geom_eli.c 1.4 Even if there are no valid keys in metadata, but provider is attached we can still use setkey subcommand. Found by: regression tests Approved by: re (scottl) Revision Changes Path 1.1.2.4 +5 -5 src/sbin/geom/class/eli/geom_eli.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 14:17:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F25C916A41F; Thu, 15 Sep 2005 14:17:31 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B018343D46; Thu, 15 Sep 2005 14:17:31 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FEHVEB084623; Thu, 15 Sep 2005 14:17:31 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FEHVlC084622; Thu, 15 Sep 2005 14:17:31 GMT (envelope-from pjd) Message-Id: <200509151417.j8FEHVlC084622@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 15 Sep 2005 14:17:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/geom/eli g_eli.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 14:17:32 -0000 pjd 2005-09-15 14:17:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/geom/eli g_eli.c Log: MFC: sys/geom/eli/g_eli.c 1.12,1.13 - Don't forget to initialize crp_etype field. Reported by: Nick Evans - Fix copy&paste typo. Approved by: re (scottl) Revision Changes Path 1.3.2.4 +2 -1 src/sys/geom/eli/g_eli.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 15:03:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB5DC16A41F; Thu, 15 Sep 2005 15:03:48 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD18243D46; Thu, 15 Sep 2005 15:03:48 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FF3m5D086439; Thu, 15 Sep 2005 15:03:48 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FF3m5i086438; Thu, 15 Sep 2005 15:03:48 GMT (envelope-from csjp) Message-Id: <200509151503.j8FF3m5i086438@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Thu, 15 Sep 2005 15:03:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern imgact_elf.c vfs_lookup.c vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 15:03:49 -0000 csjp 2005-09-15 15:03:48 UTC FreeBSD src repository Modified files: sys/kern imgact_elf.c vfs_lookup.c vfs_syscalls.c Log: Improve the MP safeness associated with the creation of symbolic links and the execution of ELF binaries. Two problems were found: 1) The link path wasn't tagged as being MP safe and thus was not properly protected. 2) The ELF interpreter vnode wasnt being locked in namei(9) and thus was insufficiently protected. This commit makes the following changes: -Sets the MPSAFE flag in NDINIT for symbolic link paths -Sets the MPSAFE flag in NDINIT and introduce a vfslocked variable which will be used to instruct VFS_UNLOCK_GIANT to unlock Giant if it has been picked up. -Drop in an assertion into vfs_lookup which ensures that if the MPSAFE flag is NOT set, that we have picked up giant. If not panic (if WITNESS compiled into the kernel). This should help us find conditions where vnode operations are in-sufficiently protected. This is a RELENG_6 candidate. Discussed with: jeff MFC after: 4 days Revision Changes Path 1.163 +7 -3 src/sys/kern/imgact_elf.c 1.82 +2 -0 src/sys/kern/vfs_lookup.c 1.394 +1 -1 src/sys/kern/vfs_syscalls.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 15:29:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F88416A41F; Thu, 15 Sep 2005 15:29:59 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id B109843D46; Thu, 15 Sep 2005 15:29:58 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 15 Sep 2005 11:45:38 -0400 From: John Baldwin To: "Christian S.J. Peron" Date: Thu, 15 Sep 2005 11:30:58 -0400 User-Agent: KMail/1.8 References: <200509151503.j8FF3m5i086438@repoman.freebsd.org> In-Reply-To: <200509151503.j8FF3m5i086438@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509151131.00450.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c vfs_lookup.c vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 15:29:59 -0000 On Thursday 15 September 2005 11:03 am, Christian S.J. Peron wrote: > csjp 2005-09-15 15:03:48 UTC > > FreeBSD src repository > > Modified files: > sys/kern imgact_elf.c vfs_lookup.c vfs_syscalls.c > Log: > Improve the MP safeness associated with the creation of symbolic > links and the execution of ELF binaries. Two problems were found: > > 1) The link path wasn't tagged as being MP safe and thus was not properly > protected. > 2) The ELF interpreter vnode wasnt being locked in namei(9) and thus was > insufficiently protected. > > This commit makes the following changes: > > -Sets the MPSAFE flag in NDINIT for symbolic link paths > -Sets the MPSAFE flag in NDINIT and introduce a vfslocked variable which > will be used to instruct VFS_UNLOCK_GIANT to unlock Giant if it has been > picked up. > -Drop in an assertion into vfs_lookup which ensures that if the MPSAFE > flag is NOT set, that we have picked up giant. If not panic (if WITNESS > compiled into the kernel). This should help us find conditions where > vnode operations are in-sufficiently protected. > > This is a RELENG_6 candidate. > > Discussed with: jeff > MFC after: 4 days Why not just use mtx_assert() to do locking assertions? if (!(cnp->cn_flags & MPSAFE)) mtx_assert(&Giant, MA_OWNED); Also, note that assertions only depend on INVARIANTS, not on WITNESS. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Sep 15 15:45:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF98B16A41F; Thu, 15 Sep 2005 15:45:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CB7343D4C; Thu, 15 Sep 2005 15:45:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FFjYgm088305; Thu, 15 Sep 2005 15:45:34 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FFjYkI088304; Thu, 15 Sep 2005 15:45:34 GMT (envelope-from rwatson) Message-Id: <200509151545.j8FFjYkI088304@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 15:45:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 15:45:34 -0000 rwatson 2005-09-15 15:45:34 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: The socket pointers in fifoinfo are not permitted to be NULL, so don't check if they are, it just confuses the fifo code more. MFC after: 3 days Revision Changes Path 1.125 +2 -5 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 15:48:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25EEE16A41F; Thu, 15 Sep 2005 15:48:17 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D85A743D49; Thu, 15 Sep 2005 15:48:16 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FFmGHB088395; Thu, 15 Sep 2005 15:48:16 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FFmG7s088394; Thu, 15 Sep 2005 15:48:16 GMT (envelope-from jkoshy) Message-Id: <200509151548.j8FFmG7s088394@repoman.freebsd.org> From: Joseph Koshy Date: Thu, 15 Sep 2005 15:48:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/hwpmc hwpmc_amd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 15:48:17 -0000 jkoshy 2005-09-15 15:48:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/hwpmc hwpmc_amd.c Log: MFC r1.12: ``Process one NMI interrupt per handler invocation as the processor buffers pending NMIs from multiple interrupting PMCs and delivers them serially.'' Approved by: re (kensmith) Revision Changes Path 1.9.2.1 +9 -4 src/sys/dev/hwpmc/hwpmc_amd.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 16:08:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A024A16A41F; Thu, 15 Sep 2005 16:08:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E0CA43D45; Thu, 15 Sep 2005 16:08:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FG85Ht089264; Thu, 15 Sep 2005 16:08:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FG85W3089263; Thu, 15 Sep 2005 16:08:05 GMT (envelope-from rwatson) Message-Id: <200509151608.j8FG85W3089263@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 16:08:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/sysctl sysctl.8 sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 16:08:05 -0000 rwatson 2005-09-15 16:08:04 UTC FreeBSD src repository Modified files: sbin/sysctl sysctl.8 sysctl.c Log: Add "-q" argument to sysctl(8), which suppresses a limited set of warnings/ errors generated. In particular, it suppresses "unknown oid" when attempting to get or set a sysctl not present in the kernel. MFC after: 1 week Revision Changes Path 1.59 +5 -1 src/sbin/sysctl/sysctl.8 1.68 +12 -4 src/sbin/sysctl/sysctl.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 16:09:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A63CD16A41F; Thu, 15 Sep 2005 16:09:24 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64D8743D45; Thu, 15 Sep 2005 16:09:24 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FG9Oo9089353; Thu, 15 Sep 2005 16:09:24 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FG9OTr089352; Thu, 15 Sep 2005 16:09:24 GMT (envelope-from csjp) Message-Id: <200509151609.j8FG9OTr089352@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Thu, 15 Sep 2005 16:09:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 16:09:24 -0000 csjp 2005-09-15 16:09:24 UTC FreeBSD src repository Modified files: usr.bin/netstat bpf.c Log: Use is '-' to imply that the flag is not set, rather than '.'. Revision Changes Path 1.5 +1 -1 src/usr.bin/netstat/bpf.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 16:09:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CACA16A47C; Thu, 15 Sep 2005 16:09:28 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5900143D45; Thu, 15 Sep 2005 16:09:28 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FG9SOj089382; Thu, 15 Sep 2005 16:09:28 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FG9Ssm089381; Thu, 15 Sep 2005 16:09:28 GMT (envelope-from rwatson) Message-Id: <200509151609.j8FG9Ssm089381@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 16:09:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc rc.initdiskless X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 16:09:30 -0000 rwatson 2005-09-15 16:09:28 UTC FreeBSD src repository Modified files: etc rc.initdiskless Log: Use sysctl -q when querying for kern.bootp_cookie in order to avoid printing boot-time errors that don't reflect true error conditions. MFC after: 1 week Revision Changes Path 1.45 +1 -1 src/etc/rc.initdiskless From owner-cvs-src@FreeBSD.ORG Thu Sep 15 17:09:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A729316A41F; Thu, 15 Sep 2005 17:09:43 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 461C843D48; Thu, 15 Sep 2005 17:09:43 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FH9hxd099888; Thu, 15 Sep 2005 17:09:43 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FH9hkm099887; Thu, 15 Sep 2005 17:09:43 GMT (envelope-from jhb) Message-Id: <200509151709.j8FH9hkm099887@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 17:09:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/alpha busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 17:09:43 -0000 jhb 2005-09-15 17:09:42 UTC FreeBSD src repository Modified files: sys/alpha/alpha busdma_machdep.c Log: Add a memory barrier for PREWRITE operations to ensure all writes by the CPU have drained before further writes to kick off the operation. MFC after: 1 week Revision Changes Path 1.52 +4 -0 src/sys/alpha/alpha/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 17:12:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BE5416A41F; Thu, 15 Sep 2005 17:12:30 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE47B43D45; Thu, 15 Sep 2005 17:12:29 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FHCTC3000330; Thu, 15 Sep 2005 17:12:29 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FHCTlV000329; Thu, 15 Sep 2005 17:12:29 GMT (envelope-from jhb) Message-Id: <200509151712.j8FHCTlV000329@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 17:12:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_tl.c if_tlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 17:12:30 -0000 jhb 2005-09-15 17:12:29 UTC FreeBSD src repository Modified files: sys/pci if_tl.c if_tlreg.h Log: - Fixup locking and mark MPSAFE. - Use callout_init_mtx() and static callouts rather than timeout(). - m_getcl() in one place to simplify the code. Tested by: Gavin Atkinson gavin dot atkinson at ury dot york dot ac dot uk MFC after: 1 week Revision Changes Path 1.102 +57 -50 src/sys/pci/if_tl.c 1.22 +1 -1 src/sys/pci/if_tlreg.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 17:25:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 227D316A41F; Thu, 15 Sep 2005 17:25:53 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D65F643D45; Thu, 15 Sep 2005 17:25:52 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FHPq38002010; Thu, 15 Sep 2005 17:25:52 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FHPqWF002009; Thu, 15 Sep 2005 17:25:52 GMT (envelope-from ache) Message-Id: <200509151725.j8FHPqWF002009@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Thu, 15 Sep 2005 17:25:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen getcwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 17:25:53 -0000 ache 2005-09-15 17:25:52 UTC FreeBSD src repository Modified files: lib/libc/gen getcwd.c Log: Cosmetic fixes to prev. commit. Change first MAXPATHLEN to more standard PATH_MAX Change second MAXPATHLEN to 1024 (it is temp buffer not related) Change comment to reflect that. Suggested by: bde Revision Changes Path 1.27 +4 -4 src/lib/libc/gen/getcwd.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 17:30:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C418C16A41F; Thu, 15 Sep 2005 17:30:08 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F15143D48; Thu, 15 Sep 2005 17:30:08 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FHU8jt002385; Thu, 15 Sep 2005 17:30:08 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FHU8Go002382; Thu, 15 Sep 2005 17:30:08 GMT (envelope-from jhb) Message-Id: <200509151730.j8FHU8Go002382@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 17:30:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 sys_machdep.c src/sys/i386/include pcb_ext.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 17:30:08 -0000 jhb 2005-09-15 17:30:08 UTC FreeBSD src repository Modified files: sys/i386/i386 sys_machdep.c sys/i386/include pcb_ext.h Log: Explicitly switch to the new TSS by updating the current CPU's TSS selector and reloading it in i386_extend_pcb() rather than trying to force a context switch to reload the TSS via the TDF_NEEDRESCHED flag. Optimizations to avoid calling cpu_switch() when the new thread was identical to the old thread defeated the attempt to force a TSS reload. Explicitly loading the new TSS is what we really want to do anyway. PR: i386/84842 Reported by: Alexander Best arundel at h3c dot de MFC after: 1 week Reviewed by: bde (mostly) Revision Changes Path 1.103 +6 -4 src/sys/i386/i386/sys_machdep.c 1.10 +1 -0 src/sys/i386/include/pcb_ext.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 17:51:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2991E16A41F; Thu, 15 Sep 2005 17:51:40 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC95943D45; Thu, 15 Sep 2005 17:51:39 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FHpdju004788; Thu, 15 Sep 2005 17:51:39 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FHpdVb004787; Thu, 15 Sep 2005 17:51:39 GMT (envelope-from keramida) Message-Id: <200509151751.j8FHpdVb004787@repoman.freebsd.org> From: Giorgos Keramidas Date: Thu, 15 Sep 2005 17:51:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_dc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 17:51:40 -0000 keramida 2005-09-15 17:51:39 UTC FreeBSD src repository (doc committer) Modified files: sys/pci if_dc.c Log: When bus_alloc_resource_any() fails, dc_detach() is called and it attempts to deallocate busdma tags and resources that haven't been allocated yet, causing a panic every time a dc interface fails to attach. Fix by checking that we really have something to dealloc before calling bus_dma*() functions. Approved by: jhb MFC after: 1 week Revision Changes Path 1.167 +11 -5 src/sys/pci/if_dc.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 18:21:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D210A16A41F; Thu, 15 Sep 2005 18:21:02 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A4B343D48; Thu, 15 Sep 2005 18:21:02 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 15 Sep 2005 14:36:42 -0400 From: John Baldwin To: src-committers@FreeBSD.org Date: Thu, 15 Sep 2005 13:41:41 -0400 User-Agent: KMail/1.8 References: <200509151709.j8FH9hkm099887@repoman.freebsd.org> In-Reply-To: <200509151709.j8FH9hkm099887@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509151341.42862.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 18:21:03 -0000 On Thursday 15 September 2005 01:09 pm, John Baldwin wrote: > jhb 2005-09-15 17:09:42 UTC > > FreeBSD src repository > > Modified files: > sys/alpha/alpha busdma_machdep.c > Log: > Add a memory barrier for PREWRITE operations to ensure all writes by the > CPU have drained before further writes to kick off the operation. Other architectures with relaxed memory ordering probably also need thus such as ia64, powerpc, and perhaps amd64. sparc64 already has a barrier. BTW, it seems that the bus_dma code could be somewhat simplified if there was a sys/kern/subr_busdma.c that contained routines to implement bounce buffers that could be used by the MD code since the MD code that does do bounce pages tends to duplicate a lot of stuff between the different archs. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Sep 15 18:59:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDFBE16A41F; Thu, 15 Sep 2005 18:59:36 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D95C43D46; Thu, 15 Sep 2005 18:59:35 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FIxYna007640; Thu, 15 Sep 2005 18:59:35 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FIxY6v007639; Thu, 15 Sep 2005 18:59:34 GMT (envelope-from ru) Message-Id: <200509151859.j8FIxY6v007639@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 18:59:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 18:59:37 -0000 ru 2005-09-15 18:59:34 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: re_detach() fixes: - Fixed if_free() logic screw-up that can either result in freeing a NULL pointer or leaking "struct ifnet". - Move if_free() after re_stop(); the latter accesses "struct ifnet". This bug was masked by a previous bug. - Restore the fix for a panic on detach caused by racing with BPF detach code by Bill by moving ether_ifdetach() after re_stop() and resetting IFF_UP; this got screwed up in revs. 1.30 and 1.36. Revision Changes Path 1.52 +7 -15 src/sys/dev/re/if_re.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:02:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03FB116A41F; Thu, 15 Sep 2005 19:02:03 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF13F43D73; Thu, 15 Sep 2005 19:02:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJ21PD007808; Thu, 15 Sep 2005 19:02:01 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJ21tt007807; Thu, 15 Sep 2005 19:02:01 GMT (envelope-from jhb) Message-Id: <200509151902.j8FJ21tt007807@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 19:02:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 local_apic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:02:03 -0000 jhb 2005-09-15 19:02:01 UTC FreeBSD src repository Modified files: sys/i386/i386 local_apic.c Log: - Adjust a comment, we do program the performance counter LVT entry now if hwpmc(4) is included. - Don't recursively panic if we are unable to send an IPI, just bail and hope for the best. MFC after: 1 week Revision Changes Path 1.18 +7 -3 src/sys/i386/i386/local_apic.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:05:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4BC1216A41F; Thu, 15 Sep 2005 19:05:38 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BC5743D46; Thu, 15 Sep 2005 19:05:38 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJ5b56008056; Thu, 15 Sep 2005 19:05:37 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJ5beJ008055; Thu, 15 Sep 2005 19:05:37 GMT (envelope-from jhb) Message-Id: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 19:05:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:05:38 -0000 jhb 2005-09-15 19:05:37 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c subr_sleepqueue.c sys/geom geom_io.c sys/sys proc.h Log: - Add a new simple facility for marking the current thread as being in a state where sleeping on a sleep queue is not allowed. The facility doesn't support recursion but uses a simple private per-thread flag (TDP_NOSLEEPING). The sleepq_add() function will panic if the flag is set and INVARIANTS is enabled. - Use this new facility to replace the g_xup and g_xdown mutexes that were (ab)used to achieve similar behavior. - Disallow sleeping in interrupt threads when invoking interrupt handlers. MFC after: 1 week Reviewed by: phk Revision Changes Path 1.67 +7 -30 src/sys/geom/geom_io.c 1.125 +2 -0 src/sys/kern/kern_intr.c 1.19 +4 -0 src/sys/kern/subr_sleepqueue.c 1.434 +14 -1 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:07:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D5B616A41F; Thu, 15 Sep 2005 19:07:10 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C5C543D45; Thu, 15 Sep 2005 19:07:10 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJ7AaR008183; Thu, 15 Sep 2005 19:07:10 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJ7A6B008182; Thu, 15 Sep 2005 19:07:10 GMT (envelope-from ru) Message-Id: <200509151907.j8FJ7A6B008182@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 19:07:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:07:10 -0000 ru 2005-09-15 19:07:10 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: Don't recommend re_detach() (like in vr(4)) as another possible method to prevent panicing in interrupt handler after re_shutdown(), sometimes seen on SMP systems. This would work here only because re_detach() clears IFF_UP (to prevent another race) and it was demonstrated that it's not enough to call vr_detach() in vr_shutdown() to prevent a panic. Revision Changes Path 1.53 +1 -2 src/sys/dev/re/if_re.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:07:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02CEC16A4A0; Thu, 15 Sep 2005 19:07:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9B2043D46; Thu, 15 Sep 2005 19:07:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJ7EIX008216; Thu, 15 Sep 2005 19:07:14 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJ7EB8008215; Thu, 15 Sep 2005 19:07:14 GMT (envelope-from jhb) Message-Id: <200509151907.j8FJ7EB8008215@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 19:07:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:07:15 -0000 jhb 2005-09-15 19:07:14 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c Log: - Enforce an implicit lock order that Giant cannot be locked while holding any other non-sleepable lock. In plain English: Giant comes before all other mutexes. - Add some extra description to the lock order reversal printf's to indicate when a reversal is triggered by a hard-coded implicit rule. Requested by: truckman (2) MFC after: 1 week Revision Changes Path 1.201 +17 -1 src/sys/kern/subr_witness.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:15:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A64A16A41F; Thu, 15 Sep 2005 19:15:05 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id C496D43D53; Thu, 15 Sep 2005 19:15:00 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j8FJExku001454; Thu, 15 Sep 2005 13:14:59 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4329C835.6020104@samsco.org> Date: Thu, 15 Sep 2005 13:15:01 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200509151709.j8FH9hkm099887@repoman.freebsd.org> <200509151341.42862.jhb@FreeBSD.org> In-Reply-To: <200509151341.42862.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:15:05 -0000 John Baldwin wrote: > On Thursday 15 September 2005 01:09 pm, John Baldwin wrote: > >>jhb 2005-09-15 17:09:42 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/alpha/alpha busdma_machdep.c >> Log: >> Add a memory barrier for PREWRITE operations to ensure all writes by the >> CPU have drained before further writes to kick off the operation. > > > Other architectures with relaxed memory ordering probably also need thus such > as ia64, powerpc, and perhaps amd64. sparc64 already has a barrier. BTW, it > seems that the bus_dma code could be somewhat simplified if there was a > sys/kern/subr_busdma.c that contained routines to implement bounce buffers > that could be used by the MD code since the MD code that does do bounce pages > tends to duplicate a lot of stuff between the different archs. > Indeed it does, and if you want to work on it, please feel free to send it to me for review. Scott From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:16:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBBCA16A41F; Thu, 15 Sep 2005 19:16:29 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9761643D46; Thu, 15 Sep 2005 19:16:29 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJGTLw008719; Thu, 15 Sep 2005 19:16:29 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJGTh5008718; Thu, 15 Sep 2005 19:16:29 GMT (envelope-from jhb) Message-Id: <200509151916.j8FJGTh5008718@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 19:16:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/pci if_ste.c if_stereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:16:30 -0000 jhb 2005-09-15 19:16:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_ste.c if_stereg.h Log: MFC: Fixup locking and mark MPSAFE. Approved by: re (kensmith) Revision Changes Path 1.84.2.4 +94 -59 src/sys/pci/if_ste.c 1.18.2.2 +1 -1 src/sys/pci/if_stereg.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:21:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D84C416A41F; Thu, 15 Sep 2005 19:21:27 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5A6543D5D; Thu, 15 Sep 2005 19:21:26 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJLQAO008957; Thu, 15 Sep 2005 19:21:26 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJLQev008956; Thu, 15 Sep 2005 19:21:26 GMT (envelope-from kan) Message-Id: <200509151921.j8FJLQev008956@repoman.freebsd.org> From: Alexander Kabaev Date: Thu, 15 Sep 2005 19:21:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nullfs null_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:21:28 -0000 kan 2005-09-15 19:21:26 UTC FreeBSD src repository Modified files: sys/fs/nullfs null_vnops.c Log: Handle a race condition where NULLFS vnode can be cleaned while threads can still be asleep waiting for lowervp lock. Tested by: kkenn Discussed with: ssouhlal, jeffr Revision Changes Path 1.89 +28 -4 src/sys/fs/nullfs/null_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:22:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5377E16A41F; Thu, 15 Sep 2005 19:22:06 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id B380243D45; Thu, 15 Sep 2005 19:22:05 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 15 Sep 2005 15:37:45 -0400 From: John Baldwin To: Ruslan Ermilov Date: Thu, 15 Sep 2005 15:21:12 -0400 User-Agent: KMail/1.8 References: <200509151859.j8FIxY6v007639@repoman.freebsd.org> In-Reply-To: <200509151859.j8FIxY6v007639@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509151521.14204.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:22:06 -0000 On Thursday 15 September 2005 02:59 pm, Ruslan Ermilov wrote: > ru 2005-09-15 18:59:34 UTC > > FreeBSD src repository > > Modified files: > sys/dev/re if_re.c > Log: > re_detach() fixes: > > - Fixed if_free() logic screw-up that can either result > in freeing a NULL pointer or leaking "struct ifnet". > - Move if_free() after re_stop(); the latter accesses > "struct ifnet". This bug was masked by a previous bug. > - Restore the fix for a panic on detach caused by racing > with BPF detach code by Bill by moving ether_ifdetach() > after re_stop() and resetting IFF_UP; this got screwed > up in revs. 1.30 and 1.36. Device drivers should not modify IFF_UP. Instead, the interrupt handler should be checking IFF_DRV_RUNNING rather than IFF_UP (foo_stop() clears IFF_DRV_RUNNING). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:22:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFBF816A420; Thu, 15 Sep 2005 19:22:06 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F62443D46; Thu, 15 Sep 2005 19:22:06 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Thu, 15 Sep 2005 15:37:46 -0400 From: John Baldwin To: Scott Long Date: Thu, 15 Sep 2005 15:22:37 -0400 User-Agent: KMail/1.8 References: <200509151709.j8FH9hkm099887@repoman.freebsd.org> <200509151341.42862.jhb@FreeBSD.org> <4329C835.6020104@samsco.org> In-Reply-To: <4329C835.6020104@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509151522.39043.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:22:07 -0000 On Thursday 15 September 2005 03:15 pm, Scott Long wrote: > John Baldwin wrote: > > On Thursday 15 September 2005 01:09 pm, John Baldwin wrote: > >>jhb 2005-09-15 17:09:42 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/alpha/alpha busdma_machdep.c > >> Log: > >> Add a memory barrier for PREWRITE operations to ensure all writes by > >> the CPU have drained before further writes to kick off the operation. > > > > Other architectures with relaxed memory ordering probably also need thus > > such as ia64, powerpc, and perhaps amd64. sparc64 already has a barrier. > > BTW, it seems that the bus_dma code could be somewhat simplified if > > there was a sys/kern/subr_busdma.c that contained routines to implement > > bounce buffers that could be used by the MD code since the MD code that > > does do bounce pages tends to duplicate a lot of stuff between the > > different archs. > > Indeed it does, and if you want to work on it, please feel free to send > it to me for > review. I can tack it onto my todo list but it'll be buried. :) I was hoping someone else might be able to hack on it and pass it off to you for review. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:31:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE10E16A41F; Thu, 15 Sep 2005 19:31:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD68043D45; Thu, 15 Sep 2005 19:31:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJVMB5009513; Thu, 15 Sep 2005 19:31:22 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJVMMW009512; Thu, 15 Sep 2005 19:31:22 GMT (envelope-from jhb) Message-Id: <200509151931.j8FJVMMW009512@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 19:31:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/include atomic.h src/sys/amd64/include atomic.h src/sys/i386/include atomic.h src/sys/powerpc/include atomic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:31:23 -0000 jhb 2005-09-15 19:31:22 UTC FreeBSD src repository Modified files: sys/alpha/include atomic.h sys/amd64/include atomic.h sys/i386/include atomic.h sys/powerpc/include atomic.h Log: Stop using the '+' constraint modifier with inline assembly. The '+' constraint is actually only allowed for register operands. Instead, use separate input and output memory constraints. Education from: alc Reviewed by: alc Tested on: i386, alpha MFC after: 1 week Revision Changes Path 1.23 +36 -36 src/sys/alpha/include/atomic.h 1.38 +27 -22 src/sys/amd64/include/atomic.h 1.40 +27 -22 src/sys/i386/include/atomic.h 1.13 +12 -12 src/sys/powerpc/include/atomic.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:34:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D59B16A41F; Thu, 15 Sep 2005 19:34:13 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BFE043D46; Thu, 15 Sep 2005 19:34:13 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJYCmw009617; Thu, 15 Sep 2005 19:34:12 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJYCXR009616; Thu, 15 Sep 2005 19:34:12 GMT (envelope-from ru) Message-Id: <200509151934.j8FJYCXR009616@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 19:34:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sn if_sn.c if_snvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:34:13 -0000 ru 2005-09-15 19:34:12 UTC FreeBSD src repository Modified files: sys/dev/sn if_sn.c if_snvar.h Log: Spell "destroy" correctly. Revision Changes Path 1.50 +1 -1 src/sys/dev/sn/if_sn.c 1.10 +1 -1 src/sys/dev/sn/if_snvar.h From owner-cvs-src@FreeBSD.ORG Thu Sep 15 19:41:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 30F1116A420; Thu, 15 Sep 2005 19:41:04 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D916743D58; Thu, 15 Sep 2005 19:41:03 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FJf3km010027; Thu, 15 Sep 2005 19:41:03 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FJf3Ce010026; Thu, 15 Sep 2005 19:41:03 GMT (envelope-from ru) Message-Id: <200509151941.j8FJf3Ce010026@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 19:41:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/txp if_txp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 19:41:04 -0000 ru 2005-09-15 19:41:03 UTC FreeBSD src repository Modified files: sys/dev/txp if_txp.c Log: Fixed a diagnostic message. Revision Changes Path 1.35 +1 -1 src/sys/dev/txp/if_txp.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:06:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C19B916A41F; Thu, 15 Sep 2005 20:06:44 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 672F243D48; Thu, 15 Sep 2005 20:06:44 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FK6i7U011405; Thu, 15 Sep 2005 20:06:44 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FK6iIv011404; Thu, 15 Sep 2005 20:06:44 GMT (envelope-from ru) Message-Id: <200509152006.j8FK6iIv011404@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 20:06:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/nge if_nge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:06:44 -0000 ru 2005-09-15 20:06:44 UTC FreeBSD src repository Modified files: sys/dev/nge if_nge.c Log: Add two missing if_free() calls. Revision Changes Path 1.78 +3 -0 src/sys/dev/nge/if_nge.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:08:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F2C116A41F; Thu, 15 Sep 2005 20:08:26 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCD1643D58; Thu, 15 Sep 2005 20:08:21 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FK8Lhv011531; Thu, 15 Sep 2005 20:08:21 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FK8LIw011530; Thu, 15 Sep 2005 20:08:21 GMT (envelope-from jhb) Message-Id: <200509152008.j8FK8LIw011530@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 20:08:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_intr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:08:26 -0000 jhb 2005-09-15 20:08:21 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c Log: Don't disallow sleeping for handlers on swi's since some swi handlers (like CAM) do sleep in their handlers. Requested by: scottl Revision Changes Path 1.126 +4 -2 src/sys/kern/kern_intr.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:09:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17DBE16A41F; Thu, 15 Sep 2005 20:09:09 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC2A043D46; Thu, 15 Sep 2005 20:09:08 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FK98qo011621; Thu, 15 Sep 2005 20:09:08 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FK98bZ011620; Thu, 15 Sep 2005 20:09:08 GMT (envelope-from jhb) Message-Id: <200509152009.j8FK98bZ011620@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 20:09:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_timeout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:09:09 -0000 jhb 2005-09-15 20:09:08 UTC FreeBSD src repository Modified files: sys/kern kern_timeout.c Log: Replace the dont_sleep_in_callout mutex hack (similar to g_x{up,down}) with the disallow sleeping facility. Revision Changes Path 1.99 +2 -8 src/sys/kern/kern_timeout.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:20:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7673416A41F; Thu, 15 Sep 2005 20:20:37 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34E3C43D45; Thu, 15 Sep 2005 20:20:37 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKKbCW012342; Thu, 15 Sep 2005 20:20:37 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKKbc4012341; Thu, 15 Sep 2005 20:20:37 GMT (envelope-from jhb) Message-Id: <200509152020.j8FKKbc4012341@repoman.freebsd.org> From: John Baldwin Date: Thu, 15 Sep 2005 20:20:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_timeout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:20:37 -0000 jhb 2005-09-15 20:20:36 UTC FreeBSD src repository Modified files: sys/kern kern_timeout.c Log: Oops, missed adding the required include. Pointy hat to: jhb Revision Changes Path 1.100 +1 -0 src/sys/kern/kern_timeout.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:26:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3442E16A41F; Thu, 15 Sep 2005 20:26:20 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DABFF43D4C; Thu, 15 Sep 2005 20:26:19 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKQJ7h012689; Thu, 15 Sep 2005 20:26:19 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKQJ3P012688; Thu, 15 Sep 2005 20:26:19 GMT (envelope-from rwatson) Message-Id: <200509152026.j8FKQJ3P012688@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:26:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:26:20 -0000 rwatson 2005-09-15 20:26:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.114 from HEAD to RELENG_6: Rather than reaching into the internals of the UNIX domain socket code by calling uipc_connect2() to connect two socket endpoints to create a fifo, call soconnect2(). Approved by: re (kensmith) Revision Changes Path 1.113.2.1 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:27:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FF4916A41F; Thu, 15 Sep 2005 20:27:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5C1043D49; Thu, 15 Sep 2005 20:27:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKRPfq012740; Thu, 15 Sep 2005 20:27:25 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKRPPL012739; Thu, 15 Sep 2005 20:27:25 GMT (envelope-from rwatson) Message-Id: <200509152027.j8FKRPPL012739@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:27:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:27:31 -0000 rwatson 2005-09-15 20:27:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.115 from HEAD to RELENG_6: Add an assertion that fifo_open() doesn't race against other threads while sleeping to allocate fifo state: due to using the vnode lock to serialize access to a fifo during open, it shouldn't happen (tm). Approved by: re (kensmith) Revision Changes Path 1.113.2.2 +2 -0 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:28:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC62D16A41F; Thu, 15 Sep 2005 20:28:01 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5494C43D78; Thu, 15 Sep 2005 20:27:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKRvjl012775; Thu, 15 Sep 2005 20:27:57 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKRvxc012774; Thu, 15 Sep 2005 20:27:57 GMT (envelope-from rwatson) Message-Id: <200509152027.j8FKRvxc012774@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:27:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:28:02 -0000 rwatson 2005-09-15 20:27:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.116 from HEAD to RELENG_6: When a writer opens a fifo, wake up the read socket for read, not the write socket. Approved by: re (kensmith) Revision Changes Path 1.113.2.3 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:28:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AD5116A41F; Thu, 15 Sep 2005 20:28:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC90643D5E; Thu, 15 Sep 2005 20:28:27 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKSRlc012853; Thu, 15 Sep 2005 20:28:27 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKSRXq012852; Thu, 15 Sep 2005 20:28:27 GMT (envelope-from rwatson) Message-Id: <200509152028.j8FKSRXq012852@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:28:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:28:32 -0000 rwatson 2005-09-15 20:28:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.117 from HEAD to RELENG_6: After going to some trouble to identify only the write-related events to poll the write socket for, the fifo polling code proceeded to poll for the complete set of events. Use 'levents' instead of 'events' as the argument to poll, and only poll the write socket if there is interest in write events. Approved by: re (kensmith) Revision Changes Path 1.113.2.4 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:28:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40B6816A420; Thu, 15 Sep 2005 20:28:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D250E43D46; Thu, 15 Sep 2005 20:28:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKSu8F012922; Thu, 15 Sep 2005 20:28:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKSusB012921; Thu, 15 Sep 2005 20:28:56 GMT (envelope-from rwatson) Message-Id: <200509152028.j8FKSusB012921@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:28:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:28:57 -0000 rwatson 2005-09-15 20:28:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.118 from HEAD to RELENG_6: Only poll the fifo for read events if the fifo is attached to a readable file descriptor. Otherwise, the read end of a fifo might return that it is writable (which it isn't). Only poll the fifo for write events if the fifo attached to a writable file descriptor. Otherwise, the write end of a fifo might return that it is readable (which it isn't). In the event that a file is FREAD|FWRITE (which is allowed by POSIX, but has undefined behavior), we poll for both. Approved by: re (kensmith) Revision Changes Path 1.113.2.5 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:50:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 21FA516A41F; Thu, 15 Sep 2005 20:50:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D01F843D45; Thu, 15 Sep 2005 20:50:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKo4O3021310; Thu, 15 Sep 2005 20:50:04 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKo4Rl021309; Thu, 15 Sep 2005 20:50:04 GMT (envelope-from rwatson) Message-Id: <200509152050.j8FKo4Rl021309@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:50:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:50:05 -0000 rwatson 2005-09-15 20:50:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.119 from HEAD to RELENG_6: Remove DFLAG_SEEKABLE from fifo file descriptors: fifos are not seekable according to POSIX, not to mention the fact that it doesn't make sense (and hence isn't really implemented). This causes the fifo_misc regression test to succeed. Approved by: re (scottl) Revision Changes Path 1.113.2.6 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:50:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D261016A41F; Thu, 15 Sep 2005 20:50:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69F5643D45; Thu, 15 Sep 2005 20:50:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKoV8g021422; Thu, 15 Sep 2005 20:50:31 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKoVIW021421; Thu, 15 Sep 2005 20:50:31 GMT (envelope-from rwatson) Message-Id: <200509152050.j8FKoVIW021421@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:50:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:50:32 -0000 rwatson 2005-09-15 20:50:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.120 from HEAD to RELENG_6: When a request is made to register a filter on a fifo that doesn't apply to the fifo (i.e., not EVFILT_READ or EVFILT_WRITE), reject it as EINVAL, not by returning 1 (EPERM). Approved by: re (kensmith) Revision Changes Path 1.113.2.7 +2 -2 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:52:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D90B116A41F; Thu, 15 Sep 2005 20:52:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95E2A43D49; Thu, 15 Sep 2005 20:52:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKqrpA021671; Thu, 15 Sep 2005 20:52:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKqr9t021670; Thu, 15 Sep 2005 20:52:53 GMT (envelope-from rwatson) Message-Id: <200509152052.j8FKqr9t021670@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:52:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:52:54 -0000 rwatson 2005-09-15 20:52:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_subr.c Log: Merge vfs_subr.c:1.646 from HEAD to RELENG_6: In vfs_kqfilter(), return EINVAL instead of 1 (EPERM) when an unsupported kqueue filter type is requested on a vnode. Approved by: re (kensmith) Revision Changes Path 1.635.2.6 +1 -1 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:53:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FF5916A41F; Thu, 15 Sep 2005 20:53:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F97743D46; Thu, 15 Sep 2005 20:53:23 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKrMAq021738; Thu, 15 Sep 2005 20:53:22 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKrMNB021737; Thu, 15 Sep 2005 20:53:22 GMT (envelope-from rwatson) Message-Id: <200509152053.j8FKrMNB021737@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:53:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:53:23 -0000 rwatson 2005-09-15 20:53:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if.c Log: Merge if.c:1.246 from HEAD to RELENG_6: In netkqfilter(), return EINVAL instead of 1 (EPERM) when a filter type is requested on a network interface file descriptor that is non-applicable. Approved by: re (kensmith) Revision Changes Path 1.234.2.11 +1 -1 src/sys/net/if.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:53:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5096A16A445; Thu, 15 Sep 2005 20:53:26 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 593CC43D49; Thu, 15 Sep 2005 20:53:25 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id D68B352CD7; Thu, 15 Sep 2005 22:53:22 +0200 (CEST) Received: from localhost (dkk194.neoplus.adsl.tpnet.pl [83.24.14.194]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0B44452CCD; Thu, 15 Sep 2005 22:53:15 +0200 (CEST) Date: Thu, 15 Sep 2005 22:52:33 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20050915205233.GA23141@garage.freebsd.pl> References: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:53:27 -0000 --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2005 at 07:05:37PM +0000, John Baldwin wrote: +> jhb 2005-09-15 19:05:37 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/kern kern_intr.c subr_sleepqueue.c=20 +> sys/geom geom_io.c=20 +> sys/sys proc.h=20 +> Log: +> - Add a new simple facility for marking the current thread as being in= a +> state where sleeping on a sleep queue is not allowed. The facility +> doesn't support recursion but uses a simple private per-thread flag +> (TDP_NOSLEEPING). The sleepq_add() function will panic if the flag = is +> set and INVARIANTS is enabled. +> - Use this new facility to replace the g_xup and g_xdown mutexes that = were +> (ab)used to achieve similar behavior. So is this still possible to use mutexes in I/O paths (g_up/g_down threads) or it will panic immediatelly? The policy for now was: using mutexes in a sane way is possible. The question is: did we went from a warning when WITNESS is enabled to a panic with INVARIANTS only? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKd8RForvXbEpPzQRAotOAJ4n47PBn2tTPgLf/v4GZPM/ZZfXrgCcCE2r GKro8kdFYwwUPGLxYjgBOx0= =mGRl -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI-- From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:53:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EE5F16A41F; Thu, 15 Sep 2005 20:53:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B90B043D4C; Thu, 15 Sep 2005 20:53:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FKruPR021813; Thu, 15 Sep 2005 20:53:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FKruCf021812; Thu, 15 Sep 2005 20:53:56 GMT (envelope-from rwatson) Message-Id: <200509152053.j8FKruCf021812@repoman.freebsd.org> From: Robert Watson Date: Thu, 15 Sep 2005 20:53:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:53:57 -0000 rwatson 2005-09-15 20:53:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.121 from HEAD to RELENG_6: Introduce no-op nosup fifo kqueue filter and detach routine, which are used when a read filter is requested on a write-only fifo descriptor, or a write filter is requested on a read-only fifo descriptor. This permits the filters to be registered, but never raises the event, which causes kqueue behavior for fifos to more closely match similar semantics for poll and select, which permit testing for the condition even though the condition will never be raised, and is consistent with POSIX's notion that a fifo has identical semantics to a one-way IPC channel created using pipe() on most operating systems. The fifo regression test suite can now run to completion on HEAD without errors. Approved by: re (kensmith) Revision Changes Path 1.113.2.8 +33 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 20:56:37 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 186AE16A41F; Thu, 15 Sep 2005 20:56:37 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AADD43D45; Thu, 15 Sep 2005 20:56:36 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8FKuYgx001400; Thu, 15 Sep 2005 23:56:34 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 40719-12; Thu, 15 Sep 2005 23:56:33 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8FKuOtK001389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Sep 2005 23:56:29 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8FKudAs064689; Thu, 15 Sep 2005 23:56:39 +0300 (EEST) (envelope-from ru) Date: Thu, 15 Sep 2005 23:56:39 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20050915205639.GD88456@ip.net.ua> References: <200509151859.j8FIxY6v007639@repoman.freebsd.org> <200509151521.14204.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/unnNtmY43mpUSKx" Content-Disposition: inline In-Reply-To: <200509151521.14204.jhb@FreeBSD.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 20:56:37 -0000 --/unnNtmY43mpUSKx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2005 at 03:21:12PM -0400, John Baldwin wrote: > On Thursday 15 September 2005 02:59 pm, Ruslan Ermilov wrote: > > ru 2005-09-15 18:59:34 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/re if_re.c > > Log: > > re_detach() fixes: > > > > - Fixed if_free() logic screw-up that can either result > > in freeing a NULL pointer or leaking "struct ifnet". > > - Move if_free() after re_stop(); the latter accesses > > "struct ifnet". This bug was masked by a previous bug. > > - Restore the fix for a panic on detach caused by racing > > with BPF detach code by Bill by moving ether_ifdetach() > > after re_stop() and resetting IFF_UP; this got screwed > > up in revs. 1.30 and 1.36. >=20 > Device drivers should not modify IFF_UP. Instead, the interrupt handler= =20 > should be checking IFF_DRV_RUNNING rather than IFF_UP (foo_stop() clears= =20 > IFF_DRV_RUNNING). >=20 Ideally they shoudn't, yes. But there are at least two scenarios where resetting IFF_UP is currently used to attack bugs. The first is the BPF detach bad interaction with foo_detach(), as described in re_detach(). This panic is real with (I think) all drivers. And testing IFF_DRV_RUNNING here doesn't seem to be able to prevent the panic. Perhaps the fix would be to move ether_ifdetach() before foo_stop() in foo_detach(), I'm not yet sure. Another panic sometimes seen on SMP machines on shutdown is when foo_intr() is called after foo_shutdown() has already been called. Some drivers (if_re, if_vr, if_ath) attack this problem by clearing IFF_UP so that foo_intr() bails out quickly. I don't know if anybody diagnosed the roots of this problem, but I have the following idea: foo_shutdown() calls foo_stop() which disables device interrupts. After foo_stop() has freed resources but before interrupt has been teared down, another device that shares the same IRQ generated an interrupt, and foo_intr() is called again. It checks ISR register, and it has some interrupt active, and the code calls some function that accesses already freed memory. I don't have any real SMP hardware to play with, so the above is pure theoretical. Do you think this is possible? If so, checking IFF_DRV_RUNNING in foo_intr() should fix this. If we can also fix the "BPF detach MII tick reactivation" panic without involving resetting IFF_UP, all drivers can be cleaned up to not much with IFF_UP. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --/unnNtmY43mpUSKx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKeAGqRfpzJluFF4RAqU9AJwMvHZoD2tN1+oKuRn0xglCqK4JaACfYQ10 rmr8m41YHBHtZfIysdpmQAY= =9Isy -----END PGP SIGNATURE----- --/unnNtmY43mpUSKx-- From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:04:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 575CB16A41F; Thu, 15 Sep 2005 21:04:22 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id E92F043D49; Thu, 15 Sep 2005 21:04:21 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 21A0946B08; Thu, 15 Sep 2005 17:04:21 -0400 (EDT) Date: Thu, 15 Sep 2005 22:04:21 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Pawel Jakub Dawidek In-Reply-To: <20050915205233.GA23141@garage.freebsd.pl> Message-ID: <20050915220207.A75005@fledge.watson.org> References: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> <20050915205233.GA23141@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:04:22 -0000 On Thu, 15 Sep 2005, Pawel Jakub Dawidek wrote: > +> - Add a new simple facility for marking the current thread as being in a > +> state where sleeping on a sleep queue is not allowed. The facility > +> doesn't support recursion but uses a simple private per-thread flag > +> (TDP_NOSLEEPING). The sleepq_add() function will panic if the flag is > +> set and INVARIANTS is enabled. > +> - Use this new facility to replace the g_xup and g_xdown mutexes that were > +> (ab)used to achieve similar behavior. > > So is this still possible to use mutexes in I/O paths (g_up/g_down > threads) or it will panic immediatelly? > > The policy for now was: using mutexes in a sane way is possible. The > question is: did we went from a warning when WITNESS is enabled to a > panic with INVARIANTS only? The term "sleep" is rather overloaded in BSD kernels, and the FreeBSD kernel in particular. With these changes, it is possible to lock spin and sleep mutexes in a TDF_NOSLEEPING region, but not perform unbounded sleeps, such as tsleep() and msleep(). It's also not possible to use code that performs such sleeps, such as malloc(9) with M_WAITOK, uma_zalloc() with M_WAITOK, and sx(9) locks. So the constraints are basically the same as what you're allowed to do while holding a mutex, which is the invariant that was enforced previously by holding the g_xup and g_xdown mutexes. I.e., John has now formalized the mechanism by which code can assert that an invariant is that between two points, no sleeping shall occur, rather than relying on the fact that that invariant is also enforced if you hold a mutex. Robert N M Watson From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:10:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79E0D16A41F; Thu, 15 Sep 2005 21:10:13 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3867143D45; Thu, 15 Sep 2005 21:10:13 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FLADi0023725; Thu, 15 Sep 2005 21:10:13 GMT (envelope-from ups@repoman.freebsd.org) Received: (from ups@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FLADI0023722; Thu, 15 Sep 2005 21:10:13 GMT (envelope-from ups) Message-Id: <200509152110.j8FLADI0023722@repoman.freebsd.org> From: Stephan Uphoff Date: Thu, 15 Sep 2005 21:10:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_event.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:10:13 -0000 ups 2005-09-15 21:10:13 UTC FreeBSD src repository Modified files: sys/kern kern_event.c Log: Fix race condition that caused activation of an event to be ignored immediately after it was deactivated. Found by: Yahoo! MFC after: 3 days Revision Changes Path 1.94 +4 -2 src/sys/kern/kern_event.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:16:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E317416A41F; Thu, 15 Sep 2005 21:16:43 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7938843D4C; Thu, 15 Sep 2005 21:16:43 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FLGhjR024493; Thu, 15 Sep 2005 21:16:43 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FLGhkM024492; Thu, 15 Sep 2005 21:16:43 GMT (envelope-from phk) Message-Id: <200509152116.j8FLGhkM024492@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 15 Sep 2005 21:16:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs_devs.c devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:16:44 -0000 phk 2005-09-15 21:16:43 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_devs.c devfs_vnops.c Log: Don't attempt to recurse lockmgr, it doesn't like it. Revision Changes Path 1.43 +0 -2 src/sys/fs/devfs/devfs_devs.c 1.125 +6 -1 src/sys/fs/devfs/devfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:27:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4657C16A41F; Thu, 15 Sep 2005 21:27:22 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id C385043D46; Thu, 15 Sep 2005 21:27:19 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j8FLRIkT002318; Thu, 15 Sep 2005 15:27:18 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4329E739.4070707@samsco.org> Date: Thu, 15 Sep 2005 15:27:21 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> <20050915205233.GA23141@garage.freebsd.pl> In-Reply-To: <20050915205233.GA23141@garage.freebsd.pl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:27:22 -0000 Pawel Jakub Dawidek wrote: > On Thu, Sep 15, 2005 at 07:05:37PM +0000, John Baldwin wrote: > +> jhb 2005-09-15 19:05:37 UTC > +> > +> FreeBSD src repository > +> > +> Modified files: > +> sys/kern kern_intr.c subr_sleepqueue.c > +> sys/geom geom_io.c > +> sys/sys proc.h > +> Log: > +> - Add a new simple facility for marking the current thread as being in a > +> state where sleeping on a sleep queue is not allowed. The facility > +> doesn't support recursion but uses a simple private per-thread flag > +> (TDP_NOSLEEPING). The sleepq_add() function will panic if the flag is > +> set and INVARIANTS is enabled. > +> - Use this new facility to replace the g_xup and g_xdown mutexes that were > +> (ab)used to achieve similar behavior. > > So is this still possible to use mutexes in I/O paths (g_up/g_down threads) > or it will panic immediatelly? > > The policy for now was: using mutexes in a sane way is possible. > The question is: did we went from a warning when WITNESS is enabled to > a panic with INVARIANTS only? > Well, there is a subtle distinction here that isn't well understood. Sleep mutexes "block", they don't "sleep". "Sleeping" implies that scheduling is lost for the thread for an unbounded period of time. "Blocking" implies that scheduling is lost for a relatively short and bounded period of time. So yes, sleep mutexes are still allowed. Scott From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:30:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF4D116A41F; Thu, 15 Sep 2005 21:30:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FDE143D45; Thu, 15 Sep 2005 21:30:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 01AA246B38; Thu, 15 Sep 2005 17:30:06 -0400 (EDT) Date: Thu, 15 Sep 2005 22:30:05 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <4329E739.4070707@samsco.org> Message-ID: <20050915222821.W75005@fledge.watson.org> References: <200509151905.j8FJ5beJ008055@repoman.freebsd.org> <20050915205233.GA23141@garage.freebsd.pl> <4329E739.4070707@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:30:07 -0000 On Thu, 15 Sep 2005, Scott Long wrote: >> So is this still possible to use mutexes in I/O paths (g_up/g_down >> threads) or it will panic immediatelly? >> >> The policy for now was: using mutexes in a sane way is possible. The >> question is: did we went from a warning when WITNESS is enabled to a >> panic with INVARIANTS only? > > Well, there is a subtle distinction here that isn't well understood. > Sleep mutexes "block", they don't "sleep". "Sleeping" implies that > scheduling is lost for the thread for an unbounded period of time. > "Blocking" implies that scheduling is lost for a relatively short and > bounded period of time. So yes, sleep mutexes are still allowed. Unless of course you're talking about blocking as in I/O, in which case blocking refers to unbounded sleeping associated with waiting on I/O events, hence non-blocking I/O. However, even if you set a file descriptor to non-blocking, your thread may still sleep waiting on a mutex (bounded sleeps) or on kernel memory (unbounded sleeps). I try to avoid using the term blocking except when talking about file descriptors, and then just confuse people by using sleep to mean both "what a mutex can do" and "what tsleep does". The useful distinction basically being a convention on the degree to which things are bounded... Robert N M Watson From owner-cvs-src@FreeBSD.ORG Thu Sep 15 21:30:32 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 300E016A41F; Thu, 15 Sep 2005 21:30:32 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD79543D45; Thu, 15 Sep 2005 21:30:31 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 1FE44BC96; Thu, 15 Sep 2005 21:30:25 +0000 (UTC) To: Scott Long From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 15 Sep 2005 15:27:21 MDT." <4329E739.4070707@samsco.org> Date: Thu, 15 Sep 2005 23:30:24 +0200 Message-ID: <7524.1126819824@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/kern kern_intr.c subr_sleepqueue.c src/sys/geom geom_io.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 21:30:32 -0000 In message <4329E739.4070707@samsco.org>, Scott Long writes: >Well, there is a subtle distinction here that isn't well understood. >Sleep mutexes "block", they don't "sleep". A good rule of thumb is that userland won't get to run while mutexes are held, whereas userland may run while a thread is sleeping. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Sep 15 22:55:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9393516A41F; Thu, 15 Sep 2005 22:55:19 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id CBB7D43D45; Thu, 15 Sep 2005 22:55:18 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id j8FMtHET001143; Fri, 16 Sep 2005 02:55:17 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.4/8.13.4/Submit) id j8FMtGlg001142; Fri, 16 Sep 2005 02:55:16 +0400 (MSD) (envelope-from ache) Date: Fri, 16 Sep 2005 02:55:16 +0400 From: Andrey Chernov To: Poul-Henning Kamp Message-ID: <20050915225516.GA1107@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200509152116.j8FLGhkM024492@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509152116.j8FLGhkM024492@repoman.freebsd.org> User-Agent: Mutt/1.5.10i Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/fs/devfs devfs_devs.c devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 22:55:19 -0000 On Thu, Sep 15, 2005 at 09:16:43PM +0000, Poul-Henning Kamp wrote: > Log: > Don't attempt to recurse lockmgr, it doesn't like it. > Thanx for quick fix. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Sep 16 01:26:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B227916A420; Fri, 16 Sep 2005 01:26:18 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B49243D46; Fri, 16 Sep 2005 01:26:18 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G1QImt043133; Fri, 16 Sep 2005 01:26:18 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G1QI6n043132; Fri, 16 Sep 2005 01:26:18 GMT (envelope-from mjacob) Message-Id: <200509160126.j8G1QI6n043132@repoman.freebsd.org> From: Matt Jacob Date: Fri, 16 Sep 2005 01:26:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 01:26:19 -0000 mjacob 2005-09-16 01:26:17 UTC FreeBSD src repository Modified files: sys/cam cam_xpt.c Log: Make the exploring of all luns supported by an HBA more of a tunable (until we get REPORT LUNS in place). If we're probing luns, and each probe succeeds, we keep going past lun 7 if we're a SCSI3 or better device (until we fail to probe). If we're probing luns, and a probe fails, we only keep going if we're quirked *for* it (CAM_QUIRK_HILUNS), and if we're not quirked *against* it (CAM_QUIRK_NOHILUNS), or we're a SCSI3 or better device and the tunable (kern.cam.cam_srch_hi) is set non-zero. Reviewed by: nate@rootlabs.org, gibbs@scsiguy.com, ken@kdm.com, scottl@samsco.org MFC after: 1 week Revision Changes Path 1.156 +38 -5 src/sys/cam/cam_xpt.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 01:42:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7CC916A41F; Fri, 16 Sep 2005 01:42:50 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8454843D45; Fri, 16 Sep 2005 01:42:50 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G1goCT043752; Fri, 16 Sep 2005 01:42:50 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G1goKK043751; Fri, 16 Sep 2005 01:42:50 GMT (envelope-from suz) Message-Id: <200509160142.j8G1goKK043751@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 16 Sep 2005 01:42:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet6 nd6_nbr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 01:42:51 -0000 suz 2005-09-16 01:42:50 UTC FreeBSD src repository Modified files: sys/netinet6 nd6_nbr.c Log: plugged a possible memory leak Obtained from: KAME MFC after: 1 day Revision Changes Path 1.34 +1 -1 src/sys/netinet6/nd6_nbr.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 02:08:19 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A32C716A41F; Fri, 16 Sep 2005 02:08:19 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D2EF43D46; Fri, 16 Sep 2005 02:08:18 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from centtech.com (andersonbox4.centtech.com [192.168.42.24]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id j8G28HNS069122; Thu, 15 Sep 2005 21:08:17 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <432A2970.8090200@centtech.com> Date: Thu, 15 Sep 2005 21:09:52 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040316 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Matt Jacob References: <200509160126.j8G1QI6n043132@repoman.freebsd.org> In-Reply-To: <200509160126.j8G1QI6n043132@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.82/1082/Wed Sep 14 10:22:17 2005 on mh2.centtech.com X-Virus-Status: Clean Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 02:08:19 -0000 Matt Jacob wrote: >mjacob 2005-09-16 01:26:17 UTC > > FreeBSD src repository > > Modified files: > sys/cam cam_xpt.c > Log: > Make the exploring of all luns supported by an HBA more of a > tunable (until we get REPORT LUNS in place). > > If we're probing luns, and each probe succeeds, we keep going past > lun 7 if we're a SCSI3 or better device (until we fail to probe). > > If we're probing luns, and a probe fails, we only keep going if > we're quirked *for* it (CAM_QUIRK_HILUNS), and if we're not quirked > *against* it (CAM_QUIRK_NOHILUNS), or we're a SCSI3 or better device > and the tunable (kern.cam.cam_srch_hi) is set non-zero. > > Reviewed by: nate@rootlabs.org, gibbs@scsiguy.com, ken@kdm.com, scottl@samsco.org > MFC after: 1 week > > Revision Changes Path > 1.156 +38 -5 src/sys/cam/cam_xpt.c > > Matt, do you think this would fix issues with Qlogic (FC) cards scanning and finding duplicate luns on some FC devices? (I see that in 6.0, but not in 5.x). Eric From owner-cvs-src@FreeBSD.ORG Fri Sep 16 02:34:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A7F916A41F; Fri, 16 Sep 2005 02:34:10 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB98C43D45; Fri, 16 Sep 2005 02:34:07 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j8G2Y3C8003743; Thu, 15 Sep 2005 20:34:03 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <432A2F1F.3080606@samsco.org> Date: Thu, 15 Sep 2005 20:34:07 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eric Anderson References: <200509160126.j8G1QI6n043132@repoman.freebsd.org> <432A2970.8090200@centtech.com> In-Reply-To: <432A2970.8090200@centtech.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Matt Jacob , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 02:34:10 -0000 Eric Anderson wrote: > Matt Jacob wrote: > >> mjacob 2005-09-16 01:26:17 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam cam_xpt.c Log: >> Make the exploring of all luns supported by an HBA more of a >> tunable (until we get REPORT LUNS in place). >> >> If we're probing luns, and each probe succeeds, we keep going past >> lun 7 if we're a SCSI3 or better device (until we fail to probe). >> >> If we're probing luns, and a probe fails, we only keep going if >> we're quirked *for* it (CAM_QUIRK_HILUNS), and if we're not quirked >> *against* it (CAM_QUIRK_NOHILUNS), or we're a SCSI3 or better device >> and the tunable (kern.cam.cam_srch_hi) is set non-zero. >> >> Reviewed by: nate@rootlabs.org, gibbs@scsiguy.com, ken@kdm.com, >> scottl@samsco.org >> MFC after: 1 week >> >> Revision Changes Path >> 1.156 +38 -5 src/sys/cam/cam_xpt.c >> >> > > Matt, do you think this would fix issues with Qlogic (FC) cards scanning > and finding duplicate luns on some FC devices? (I see that in 6.0, but > not in 5.x). > > Eric > > We added more aggressive LUN scanning code into 6-CURRENT a few months ago, but didn't merge it back to 5-STABLE precisely becasue we knew that it might cause problems. This commit will hopefully address those problems by making the scanning less aggressive by default but more configurable. Scott From owner-cvs-src@FreeBSD.ORG Fri Sep 16 05:17:26 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AF6916A41F for ; Fri, 16 Sep 2005 05:17:26 +0000 (GMT) (envelope-from lydianconcepts@gmail.com) Received: from qproxy.gmail.com (qproxy.gmail.com [72.14.204.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92BFB43D45 for ; Fri, 16 Sep 2005 05:17:25 +0000 (GMT) (envelope-from lydianconcepts@gmail.com) Received: by qproxy.gmail.com with SMTP id p36so47311qba for ; Thu, 15 Sep 2005 22:17:24 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=UiZHifj3GzdthNM6Jq/SyE3xG0f3uZD8BcqfDPGAhO62lU8c+hc/LK9z7day4dkjuqLgjyIMKw5YT82ZfT2GJxKm+kc+10X4pV/gOHfTBcHnfysQVSZPkHvB+NAbGAA3xZq1s6a0nQryVou6i0W0a3XYreOIWH+YCNCoKjr1/ik= Received: by 10.65.147.11 with SMTP id z11mr6068qbn; Thu, 15 Sep 2005 22:10:57 -0700 (PDT) Received: by 10.65.151.4 with HTTP; Thu, 15 Sep 2005 22:10:57 -0700 (PDT) Message-ID: <7579f7fb0509152210240b9883@mail.gmail.com> Date: Thu, 15 Sep 2005 22:10:57 -0700 From: Matthew Jacob To: Eric Anderson In-Reply-To: <432A2970.8090200@centtech.com> Mime-Version: 1.0 References: <200509160126.j8G1QI6n043132@repoman.freebsd.org> <432A2970.8090200@centtech.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lydianconcepts@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 05:17:26 -0000 What Scott said... yes, this should, I hope, fix the 6.0 spasms as soon as= =20 it gets MFC'd. On 9/15/05, Eric Anderson wrote:=20 >=20 > Matt Jacob wrote: >=20 > >mjacob 2005-09-16 01:26:17 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/cam cam_xpt.c > > Log: > > Make the exploring of all luns supported by an HBA more of a > > tunable (until we get REPORT LUNS in place). > > > > If we're probing luns, and each probe succeeds, we keep going past > > lun 7 if we're a SCSI3 or better device (until we fail to probe). > > > > If we're probing luns, and a probe fails, we only keep going if > > we're quirked *for* it (CAM_QUIRK_HILUNS), and if we're not quirked > > *against* it (CAM_QUIRK_NOHILUNS), or we're a SCSI3 or better device > > and the tunable (kern.cam.cam_srch_hi) is set non-zero. > > > > Reviewed by: nate@rootlabs.org, gibbs@scsiguy.com, ken@kdm.com,=20 > scottl@samsco.org > > MFC after: 1 week > > > > Revision Changes Path > > 1.156 +38 -5 src/sys/cam/cam_xpt.c > > > > >=20 > Matt, do you think this would fix issues with Qlogic (FC) cards scanning > and finding duplicate luns on some FC devices? (I see that in 6.0, but > not in 5.x). >=20 > Eric >=20 >=20 > From owner-cvs-src@FreeBSD.ORG Fri Sep 16 06:57:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16F3E16A41F; Fri, 16 Sep 2005 06:57:29 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A21143D46; Fri, 16 Sep 2005 06:57:28 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8G6vPu3073036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 10:57:25 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8G6vPBF073035; Fri, 16 Sep 2005 10:57:25 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 16 Sep 2005 10:57:24 +0400 From: Gleb Smirnoff To: Maxim Konovalov Message-ID: <20050916065724.GI53891@cell.sick.ru> References: <200509151145.j8FBjbAU070614@repoman.freebsd.org> <20050915130901.R75005@fledge.watson.org> <20050915165142.F20393@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050915165142.F20393@mp2.macomnet.net> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 06:57:29 -0000 On Thu, Sep 15, 2005 at 05:14:04PM +0400, Maxim Konovalov wrote: M> > Are you sure this is the right thing to do? I've seen shutdown used M> > in several applications on non-connection-oriented sockets in order M> > to indicate no messages will be received, so not to allow received M> > packets to consume space. Typical use is in the context of a raw IP M> > or IPv6 socket, where raw packets will be sent but never received, M> > and the socket will otherwise collect the normal random network M> > detrious. M> > M> > For example, rtsold(8) uses shutdown(2) on its IPv6 raw socket to M> > indicate it is send-only, so received packets should not be stored M> > in the socket buffer since they will never be read. It does, M> > however, contain the not unusual bug that it is called with an M> > argument of 0, assuming that that will be the value SHUT_RD. I'm M> > fairly sure we used to have other examples of shutdown(2) being used M> > in this way in the tree but don't see any others in a casual glance. M> > M> > While POSIX mentions behavior for full-duplex connections, it does M> > not specify for sockets that are not connection-oriented, so as I M> > read it, the behavior we provide is permitted. M> M> Linux 2.4.21 return ENOTSUP for SOCK_RAW and ENOTCONN for M> non-connected SOCK_DGRAM. Solaris 9 returns ENOTCONN for M> non-connected SOCK_RAW and they don't allow shutdown(2) on M> non-connected sockets. Anyhow, I'll backout this code. I see you have already backed out :( What about return code back with check that socket belongs to PR_CONNREQUIRED protocol? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Sep 16 07:02:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2950C16A41F; Fri, 16 Sep 2005 07:02:30 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC12243D4C; Fri, 16 Sep 2005 07:02:29 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G72TTf063545; Fri, 16 Sep 2005 07:02:29 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G72TBv063544; Fri, 16 Sep 2005 07:02:29 GMT (envelope-from imp) Message-Id: <200509160702.j8G72TBv063544@repoman.freebsd.org> From: Warner Losh Date: Fri, 16 Sep 2005 07:02:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 07:02:30 -0000 imp 2005-09-16 07:02:29 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_pcib_acpi.c sys/i386/pci pci_bus.c Log: Commit a workaround to a problem with resource allocation. This helps with some Dell servers that booted w/o a problem[*] on 5.4, but failed with 6.0-BETA. On the PCI bus, when we do lazy resource allocation, we narrow the range requested as we pass through bridges to reflect how the bridges are programmed and what addresses they pass. However, when we're doing an allocation on a bus that's directly connected to a host bridge, no such translation can take place. We already had a fallback range for memory requests, but none for ioports. As such, provide a fallback for I/O ports so we don't allocate location 0, which will have undesired side effects when the resources are actually used. This fixes a problem with booting a Dell server with usb in the kernel. However, it is an unsatisfying solution. I don't like the hard coded value, and I think we should start narrowing the resources returned to not be in the so-called isa alias area (where the ranage & 0x0300 must be 0 iirc). Doing such filtering will have to wait for another day. This may be a good 6 candidate, maybe after its had a chance to be refined. Tested by: glebius@ Revision Changes Path 1.49 +2 -0 src/sys/dev/acpica/acpi_pcib_acpi.c 1.120 +2 -0 src/sys/i386/pci/pci_bus.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 07:08:44 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAC1D16A41F; Fri, 16 Sep 2005 07:08:44 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 572F743D48; Fri, 16 Sep 2005 07:08:44 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8G77Y9P042700; Fri, 16 Sep 2005 01:07:34 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 01:07:46 -0600 (MDT) Message-Id: <20050916.010746.98777894.imp@bsdimp.com> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200509160702.j8G72TBv063544@repoman.freebsd.org> References: <200509160702.j8G72TBv063544@repoman.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 01:07:34 -0600 (MDT) Cc: Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 07:08:44 -0000 In message: <200509160702.j8G72TBv063544@repoman.freebsd.org> Warner Losh writes: : imp 2005-09-16 07:02:29 UTC : : FreeBSD src repository : : Modified files: : sys/dev/acpica acpi_pcib_acpi.c : sys/i386/pci pci_bus.c : Log: : Commit a workaround to a problem with resource allocation. This helps : with some Dell servers that booted w/o a problem[*] on 5.4, but failed : with 6.0-BETA. : : On the PCI bus, when we do lazy resource allocation, we narrow the : range requested as we pass through bridges to reflect how the bridges : are programmed and what addresses they pass. However, when we're : doing an allocation on a bus that's directly connected to a host : bridge, no such translation can take place. We already had a fallback : range for memory requests, but none for ioports. As such, provide a : fallback for I/O ports so we don't allocate location 0, which will : have undesired side effects when the resources are actually used. : : This fixes a problem with booting a Dell server with usb in the : kernel. However, it is an unsatisfying solution. I don't like the : hard coded value, and I think we should start narrowing the resources : returned to not be in the so-called isa alias area (where the ranage & : 0x0300 must be 0 iirc). Doing such filtering will have to wait for : another day. : : This may be a good 6 candidate, maybe after its had a chance to be : refined. : : Tested by: glebius@ for those interested in the omitted footnote: [*] and also without its first usb controller: uhci0 failed to attach. I don't think this is worthy of a forced commit, but I know how some people are when they see dangling references... Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:00:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00EFF16A41F; Fri, 16 Sep 2005 09:00:58 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B10B443D48; Fri, 16 Sep 2005 09:00:58 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G90wld074854; Fri, 16 Sep 2005 09:00:58 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G90wr8074853; Fri, 16 Sep 2005 09:00:58 GMT (envelope-from rwatson) Message-Id: <200509160900.j8G90wr8074853@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:00:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:00:59 -0000 rwatson 2005-09-16 09:00:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.114 from HEAD to RELENG_5: Rather than reaching into the internals of the UNIX domain socket code by calling uipc_connect2() to connect two socket endpoints to create a fifo, call soconnect2(). Revision Changes Path 1.101.2.2 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:01:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 967DB16A41F; Fri, 16 Sep 2005 09:01:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50FD543D49; Fri, 16 Sep 2005 09:01:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G91obQ074892; Fri, 16 Sep 2005 09:01:50 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G91okV074891; Fri, 16 Sep 2005 09:01:50 GMT (envelope-from rwatson) Message-Id: <200509160901.j8G91okV074891@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:01:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:01:50 -0000 rwatson 2005-09-16 09:01:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.115 from HEAD to RELENG_5: Add an assertion that fifo_open() doesn't race against other threads while sleeping to allocate fifo state: due to using the vnode lock to serialize access to a fifo during open, it shouldn't happen (tm). Revision Changes Path 1.101.2.3 +2 -0 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:02:26 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D38816A41F; Fri, 16 Sep 2005 09:02:26 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDE5E43D48; Fri, 16 Sep 2005 09:02:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G92PY6074931; Fri, 16 Sep 2005 09:02:25 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G92PH1074930; Fri, 16 Sep 2005 09:02:25 GMT (envelope-from rwatson) Message-Id: <200509160902.j8G92PH1074930@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:02:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:02:26 -0000 rwatson 2005-09-16 09:02:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.116 from HEAD to RELENG_5: When a writer opens a fifo, wake up the read socket for read, not the write socket. Revision Changes Path 1.101.2.4 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:06:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D951E16A420; Fri, 16 Sep 2005 09:06:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53E5243D4C; Fri, 16 Sep 2005 09:06:17 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G96HNH075047; Fri, 16 Sep 2005 09:06:17 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G96HZe075046; Fri, 16 Sep 2005 09:06:17 GMT (envelope-from rwatson) Message-Id: <200509160906.j8G96HZe075046@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:06:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:06:18 -0000 rwatson 2005-09-16 09:06:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.120 (in spirit) from HEAD to RELENG_5: When a request is made to register a filter on a fifo that doesn't apply to the fifo (i.e., not EVFILT_READ or EVFILT_WRITE), reject it as EINVAL, not by returning 1 (EPERM). Revision Changes Path 1.101.2.5 +1 -1 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:11:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFE5116A41F; Fri, 16 Sep 2005 09:11:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8DC843D46; Fri, 16 Sep 2005 09:11:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G9Bpkc075195; Fri, 16 Sep 2005 09:11:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G9BpMj075194; Fri, 16 Sep 2005 09:11:51 GMT (envelope-from rwatson) Message-Id: <200509160911.j8G9BpMj075194@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:11:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_vnops.c src/sys/gnu/ext2fs ext2_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:11:52 -0000 rwatson 2005-09-16 09:11:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/ufs/ufs ufs_vnops.c sys/gnu/ext2fs ext2_vnops.c Log: Merge vfs_subr.c:1.646 (in spirit) from HEAD to RELENG_5: In vfs_kqfilter(), return EINVAL instead of 1 (EPERM) when an unsupported kqueue filter type is requested on a vnode. Revision Changes Path 1.85.2.2 +1 -1 src/sys/gnu/ext2fs/ext2_vnops.c 1.242.2.6 +1 -1 src/sys/ufs/ufs/ufs_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:12:36 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A47DD16A41F; Fri, 16 Sep 2005 09:12:36 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6041E43D46; Fri, 16 Sep 2005 09:12:36 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G9CaMP075240; Fri, 16 Sep 2005 09:12:36 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G9Can6075239; Fri, 16 Sep 2005 09:12:36 GMT (envelope-from rwatson) Message-Id: <200509160912.j8G9Can6075239@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 09:12:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:12:36 -0000 rwatson 2005-09-16 09:12:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/net if.c Log: Merge if.c:1.246 from HEAD to RELENG_5: In netkqfilter(), return EINVAL instead of 1 (EPERM) when a filter type is requested on a network interface file descriptor that is non-applicable. Revision Changes Path 1.199.2.17 +1 -1 src/sys/net/if.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:16:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0CC016A420; Fri, 16 Sep 2005 09:16:48 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30D0C43D46; Fri, 16 Sep 2005 09:16:48 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G9Glvf075407; Fri, 16 Sep 2005 09:16:48 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G9Glmv075390; Fri, 16 Sep 2005 09:16:47 GMT (envelope-from ru) Message-Id: <200509160916.j8G9Glmv075390@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 09:16:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_rue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:16:49 -0000 ru 2005-09-16 09:16:47 UTC FreeBSD src repository Modified files: sys/dev/usb if_rue.c Log: Add missing if_free() in rue_detach(). Revision Changes Path 1.25 +1 -0 src/sys/dev/usb/if_rue.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:19:18 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9597916A41F; Fri, 16 Sep 2005 09:19:18 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1B4143D45; Fri, 16 Sep 2005 09:19:17 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8G9JFAW038093; Fri, 16 Sep 2005 12:19:15 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 69652-16; Fri, 16 Sep 2005 12:19:14 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8G9JE10038090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 12:19:14 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8G9JS0p023554; Fri, 16 Sep 2005 12:19:28 +0300 (EEST) (envelope-from ru) Date: Fri, 16 Sep 2005 12:19:28 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20050916091928.GG88456@ip.net.ua> References: <200509151859.j8FIxY6v007639@repoman.freebsd.org> <200509151521.14204.jhb@FreeBSD.org> <20050915205639.GD88456@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S5HS5MvDw4DmbRmb" Content-Disposition: inline In-Reply-To: <20050915205639.GD88456@ip.net.ua> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:19:18 -0000 --S5HS5MvDw4DmbRmb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2005 at 11:56:39PM +0300, Ruslan Ermilov wrote: > The first is the BPF detach bad interaction with foo_detach(), > as described in re_detach(). This panic is real with (I think) > all drivers. And testing IFF_DRV_RUNNING here doesn't seem to > be able to prevent the panic. Perhaps the fix would be to > move ether_ifdetach() before foo_stop() in foo_detach(), I'm > not yet sure. >=20 I tried with rl(4) PCCARD, by moving ether_ifdetach() before rl_stop() in rl_detach(). It fixes the panic when you eject the card, but doesn't fix it when kldunloading the module. The difference is that rl_detach() is called already after miibus0 and rlphy0 has been detached when kldunloading the module. When ejecting the card, rl_detach() is called first. What happens when you kldunload the module with BPF listener attached, is that bpfdetach() calls rl_ioctl() to reset promisc, that calls rl_init_locked(), and that results in mii =3D device_get_softc(sc->rl_miibus); being NULL (remember the miibus has already been detached), and that panics later here: mii_mediachg(mii); When we reset IFF_UP, rl_ioctl(SIOCSIFFLAGS) silently exits and no harm is done. So the question is: how do we prevent this from happening without resetting IFF_UP. One possible solution would be to add sc->detaching, similar to sc->suspended, abd check it in rl_ioctl(). Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --S5HS5MvDw4DmbRmb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKo4gqRfpzJluFF4RAgwpAJ9XUqVw6jUfvNIhgXxyPBEiybgaJACeNHE1 5zkD9pY0litznIDunXgrCMo= =2nIV -----END PGP SIGNATURE----- --S5HS5MvDw4DmbRmb-- From owner-cvs-src@FreeBSD.ORG Fri Sep 16 09:21:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EBBC16A41F; Fri, 16 Sep 2005 09:21:00 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 196D143D48; Fri, 16 Sep 2005 09:21:00 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8G9Kxhx075548; Fri, 16 Sep 2005 09:20:59 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8G9KxsY075547; Fri, 16 Sep 2005 09:20:59 GMT (envelope-from ru) Message-Id: <200509160920.j8G9KxsY075547@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 09:20:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_aue.c if_axe.c if_cdce.c if_cue.c if_kue.c if_udav.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 09:21:00 -0000 ru 2005-09-16 09:20:58 UTC FreeBSD src repository Modified files: sys/dev/usb if_aue.c if_axe.c if_cdce.c if_cue.c if_kue.c if_udav.c Log: Add missing mtx_destroy() when if_alloc() fails. Add missing if_free() when mii_phy_probe() fails. Put if_free() into the correct #ifdef in detach(). Revision Changes Path 1.93 +6 -1 src/sys/dev/usb/if_aue.c 1.33 +6 -1 src/sys/dev/usb/if_axe.c 1.9 +2 -0 src/sys/dev/usb/if_cdce.c 1.60 +5 -1 src/sys/dev/usb/if_cue.c 1.67 +5 -1 src/sys/dev/usb/if_kue.c 1.17 +3 -0 src/sys/dev/usb/if_udav.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 10:09:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09D3016A41F; Fri, 16 Sep 2005 10:09:24 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC90943D45; Fri, 16 Sep 2005 10:09:23 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GA9No4077157; Fri, 16 Sep 2005 10:09:23 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GA9NqR077155; Fri, 16 Sep 2005 10:09:23 GMT (envelope-from ru) Message-Id: <200509161009.j8GA9NqR077155@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 10:09:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ath if_ath.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 10:09:24 -0000 ru 2005-09-16 10:09:23 UTC FreeBSD src repository Modified files: sys/dev/ath if_ath.c Log: Fix "struct ifnet" leak on detach. Revision Changes Path 1.104 +1 -0 src/sys/dev/ath/if_ath.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:11:52 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3C6D16A41F; Fri, 16 Sep 2005 11:11:52 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6307B43D45; Fri, 16 Sep 2005 11:11:52 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBBqpj080454; Fri, 16 Sep 2005 11:11:52 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBBq7X080453; Fri, 16 Sep 2005 11:11:52 GMT (envelope-from ru) Message-Id: <200509161111.j8GBBq7X080453@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 11:11:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:11:52 -0000 ru 2005-09-16 11:11:52 UTC FreeBSD src repository Modified files: sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c Log: Fix "struct ifnet" leaks when attach() fails in the middle, e.g. when mii_phy_probe() or bus_setup_intr() fails. For drivers that call their detach() in this case, call if_free() there to cover this case too. Revision Changes Path 1.168 +2 -2 src/sys/pci/if_dc.c 1.75 +2 -2 src/sys/pci/if_pcn.c 1.156 +3 -5 src/sys/pci/if_rl.c 1.87 +2 -2 src/sys/pci/if_sf.c 1.136 +2 -3 src/sys/pci/if_sis.c 1.110 +2 -3 src/sys/pci/if_sk.c 1.89 +2 -2 src/sys/pci/if_ste.c 1.110 +2 -2 src/sys/pci/if_ti.c 1.103 +2 -2 src/sys/pci/if_tl.c 1.107 +2 -2 src/sys/pci/if_vr.c 1.83 +2 -2 src/sys/pci/if_wb.c 1.196 +2 -2 src/sys/pci/if_xl.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:19:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 727E116A41F; Fri, 16 Sep 2005 11:19:38 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31A2843D45; Fri, 16 Sep 2005 11:19:38 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBJcU3080867; Fri, 16 Sep 2005 11:19:38 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBJcS0080866; Fri, 16 Sep 2005 11:19:38 GMT (envelope-from pjd) Message-Id: <200509161119.j8GBJcS0080866@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 16 Sep 2005 11:19:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libutil pidfile.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:19:38 -0000 pjd 2005-09-16 11:19:38 UTC FreeBSD src repository Modified files: lib/libutil pidfile.3 Log: Pidfiles should be created with permission preventing users from opening them for reading. When user can open file for reading, he can also flock(2) it, which can lead to confusions. Pointed out by: green Revision Changes Path 1.2 +1 -1 src/lib/libutil/pidfile.3 From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:24:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B51C416A41F; Fri, 16 Sep 2005 11:24:28 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82CF343D46; Fri, 16 Sep 2005 11:24:28 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBOSrO081364; Fri, 16 Sep 2005 11:24:28 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBOSYc081363; Fri, 16 Sep 2005 11:24:28 GMT (envelope-from pjd) Message-Id: <200509161124.j8GBOSYc081363@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 16 Sep 2005 11:24:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/cron/cron cron.c src/usr.sbin/inetd inetd.c src/usr.sbin/mountd mountd.c src/usr.sbin/moused moused.c src/usr.sbin/watchdogd watchdogd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:24:28 -0000 pjd 2005-09-16 11:24:28 UTC FreeBSD src repository Modified files: usr.sbin/cron/cron cron.c usr.sbin/inetd inetd.c usr.sbin/mountd mountd.c usr.sbin/moused moused.c usr.sbin/watchdogd watchdogd.c Log: Pidfiles should be created with permission preventing users from opening them for reading. When user can open file for reading, he can also flock(2) it, which can lead to confusions. Pointed out by: green Revision Changes Path 1.17 +1 -1 src/usr.sbin/cron/cron/cron.c 1.131 +1 -1 src/usr.sbin/inetd/inetd.c 1.83 +1 -1 src/usr.sbin/mountd/mountd.c 1.73 +1 -1 src/usr.sbin/moused/moused.c 1.12 +1 -1 src/usr.sbin/watchdogd/watchdogd.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:25:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F1EC16A41F; Fri, 16 Sep 2005 11:25:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBCE743D46; Fri, 16 Sep 2005 11:25:19 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBPJiR081660; Fri, 16 Sep 2005 11:25:19 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBPJwJ081659; Fri, 16 Sep 2005 11:25:19 GMT (envelope-from ru) Message-Id: <200509161125.j8GBPJwJ081659@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 11:25:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfe.c src/sys/dev/bge if_bge.c src/sys/dev/cnw if_cnw.c src/sys/dev/ed if_ed.c src/sys/dev/en if_en_pci.c src/sys/dev/ex if_ex.c src/sys/dev/hatm if_hatm.c src/sys/dev/ie if_ie.c src/sys/dev/vge if_vge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:25:20 -0000 ru 2005-09-16 11:25:19 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c sys/dev/bge if_bge.c sys/dev/cnw if_cnw.c sys/dev/ed if_ed.c sys/dev/en if_en_pci.c sys/dev/ex if_ex.c sys/dev/hatm if_hatm.c sys/dev/ie if_ie.c sys/dev/vge if_vge.c Log: Fix "struct ifnet" leaks when attach() fails in the middle. Revision Changes Path 1.28 +4 -5 src/sys/dev/bfe/if_bfe.c 1.95 +3 -2 src/sys/dev/bge/if_bge.c 1.21 +2 -0 src/sys/dev/cnw/if_cnw.c 1.261 +2 -1 src/sys/dev/ed/if_ed.c 1.38 +9 -2 src/sys/dev/en/if_en_pci.c 1.59 +3 -1 src/sys/dev/ex/if_ex.c 1.26 +4 -3 src/sys/dev/hatm/if_hatm.c 1.105 +2 -1 src/sys/dev/ie/if_ie.c 1.17 +2 -1 src/sys/dev/vge/if_vge.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:44:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D722B16A41F; Fri, 16 Sep 2005 11:44:43 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 958D843D45; Fri, 16 Sep 2005 11:44:43 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBihSv082731; Fri, 16 Sep 2005 11:44:43 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBihiM082730; Fri, 16 Sep 2005 11:44:43 GMT (envelope-from yar) Message-Id: <200509161144.j8GBihiM082730@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 16 Sep 2005 11:44:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:44:44 -0000 yar 2005-09-16 11:44:43 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: Test the new M_VLANTAG packet flag before calling m_tag_locate(). This adds little overhead of a simple bitwise operation in case hardware VLAN acceleration is on, yet saves the more expensive function call if the acceleration is off. Reviewed by: ru, glebius X-MFC-after: 6.0 Revision Changes Path 1.84 +5 -2 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:53:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA38A16A41F; Fri, 16 Sep 2005 11:53:16 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41DA843D48; Fri, 16 Sep 2005 11:53:15 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8GBrDMK076964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 15:53:14 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8GBrCnL076961; Fri, 16 Sep 2005 15:53:13 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 16 Sep 2005 15:53:12 +0400 From: Gleb Smirnoff To: Yar Tikhiy Message-ID: <20050916115312.GT53891@cell.sick.ru> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200509161144.j8GBihiM082730@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:53:17 -0000 On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: Y> yar 2005-09-16 11:44:43 UTC Y> Y> FreeBSD src repository Y> Y> Modified files: Y> sys/net if_vlan.c Y> Log: Y> Test the new M_VLANTAG packet flag before calling Y> m_tag_locate(). This adds little overhead of a simple Y> bitwise operation in case hardware VLAN acceleration Y> is on, yet saves the more expensive function call if Y> the acceleration is off. Y> Y> Reviewed by: ru, glebius Y> X-MFC-after: 6.0 ^^^^^^^^^^^^^^^^^^^ Why? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Sep 16 11:58:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E327516A41F; Fri, 16 Sep 2005 11:58:58 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2BA643D46; Fri, 16 Sep 2005 11:58:58 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GBwwAZ083483; Fri, 16 Sep 2005 11:58:58 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GBwws3083482; Fri, 16 Sep 2005 11:58:58 GMT (envelope-from yar) Message-Id: <200509161158.j8GBwws3083482@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 16 Sep 2005 11:58:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 11:58:59 -0000 yar 2005-09-16 11:58:58 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: It's nice to have relevant comments both in if {} and else {}, not in just one of them. Revision Changes Path 1.85 +4 -1 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:17:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1323516A420; Fri, 16 Sep 2005 12:17:19 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 036FE43D69; Fri, 16 Sep 2005 12:17:13 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GCHDnp084345; Fri, 16 Sep 2005 12:17:13 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GCHDgD084344; Fri, 16 Sep 2005 12:17:13 GMT (envelope-from ru) Message-Id: <200509161217.j8GCHDgD084344@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 12:17:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ral if_ral.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:17:19 -0000 ru 2005-09-16 12:17:12 UTC FreeBSD src repository Modified files: sys/dev/ral if_ral.c Log: Avoid deferencing NULL in if_free(). Revision Changes Path 1.16 +2 -3 src/sys/dev/ral/if_ral.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:24:29 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D43F16A41F; Fri, 16 Sep 2005 12:24:29 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0BF943D45; Fri, 16 Sep 2005 12:24:28 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GCOSXX084686; Fri, 16 Sep 2005 12:24:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GCOSSb084685; Fri, 16 Sep 2005 12:24:28 GMT (envelope-from yar) Message-Id: <200509161224.j8GCOSSb084685@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 16 Sep 2005 12:24:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:24:29 -0000 yar 2005-09-16 12:24:28 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: Do assorted nitpicking in diagnostics while I'm here: - Use __func__ consistently instead of copying function name to message strings. Code tends to migrate around source files. - DIAGNOSTIC is for information, INVARIANTS is for panics. Revision Changes Path 1.86 +9 -9 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:34:28 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E9A216A41F; Fri, 16 Sep 2005 12:34:28 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C19743D58; Fri, 16 Sep 2005 12:34:24 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j8GCYMgP028372; Fri, 16 Sep 2005 16:34:22 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j8GCYMvj028371; Fri, 16 Sep 2005 16:34:22 +0400 (MSD) (envelope-from yar) Date: Fri, 16 Sep 2005 16:34:21 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20050916123421.GB23109@comp.chem.msu.su> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> <20050916115312.GT53891@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050916115312.GT53891@cell.sick.ru> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:34:28 -0000 On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote: > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: > Y> yar 2005-09-16 11:44:43 UTC > Y> > Y> FreeBSD src repository > Y> > Y> Modified files: > Y> sys/net if_vlan.c > Y> Log: > Y> Test the new M_VLANTAG packet flag before calling > Y> m_tag_locate(). This adds little overhead of a simple > Y> bitwise operation in case hardware VLAN acceleration > Y> is on, yet saves the more expensive function call if > Y> the acceleration is off. > Y> > Y> Reviewed by: ru, glebius > Y> X-MFC-after: 6.0 > ^^^^^^^^^^^^^^^^^^^ > Why? 'Cause it's more about code consistency than stability, or performance, or features. So I'd rather not bother re@ with this when they are being flooded with really important bugfixes. It shouldn't be the extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;) -- Yar From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:37:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 416F016A41F; Fri, 16 Sep 2005 12:37:31 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6730A43D69; Fri, 16 Sep 2005 12:37:21 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8GCbBAg077938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 16:37:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8GCbAvO077937; Fri, 16 Sep 2005 16:37:10 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 16 Sep 2005 16:37:10 +0400 From: Gleb Smirnoff To: Yar Tikhiy Message-ID: <20050916123710.GX53891@cell.sick.ru> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> <20050916115312.GT53891@cell.sick.ru> <20050916123421.GB23109@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050916123421.GB23109@comp.chem.msu.su> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:37:31 -0000 On Fri, Sep 16, 2005 at 04:34:21PM +0400, Yar Tikhiy wrote: Y> On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote: Y> > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: Y> > Y> yar 2005-09-16 11:44:43 UTC Y> > Y> Y> > Y> FreeBSD src repository Y> > Y> Y> > Y> Modified files: Y> > Y> sys/net if_vlan.c Y> > Y> Log: Y> > Y> Test the new M_VLANTAG packet flag before calling Y> > Y> m_tag_locate(). This adds little overhead of a simple Y> > Y> bitwise operation in case hardware VLAN acceleration Y> > Y> is on, yet saves the more expensive function call if Y> > Y> the acceleration is off. Y> > Y> Y> > Y> Reviewed by: ru, glebius Y> > Y> X-MFC-after: 6.0 Y> > ^^^^^^^^^^^^^^^^^^^ Y> > Why? Y> Y> 'Cause it's more about code consistency than stability, or performance, Y> or features. So I'd rather not bother re@ with this when they are Y> being flooded with really important bugfixes. It shouldn't be the Y> extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;) Not a bottleneck, but a significant processing addon for every inbound packet. If you don't mind I will request MFC from re@ after some testing. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:48:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1E7A16A41F; Fri, 16 Sep 2005 12:48:34 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71E4043D53; Fri, 16 Sep 2005 12:48:25 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j8GCmLfw029171; Fri, 16 Sep 2005 16:48:21 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j8GCmLec029170; Fri, 16 Sep 2005 16:48:21 +0400 (MSD) (envelope-from yar) Date: Fri, 16 Sep 2005 16:48:21 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20050916124820.GC23109@comp.chem.msu.su> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> <20050916115312.GT53891@cell.sick.ru> <20050916123421.GB23109@comp.chem.msu.su> <20050916123710.GX53891@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050916123710.GX53891@cell.sick.ru> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:48:35 -0000 On Fri, Sep 16, 2005 at 04:37:10PM +0400, Gleb Smirnoff wrote: > On Fri, Sep 16, 2005 at 04:34:21PM +0400, Yar Tikhiy wrote: > Y> On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote: > Y> > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: > Y> > Y> yar 2005-09-16 11:44:43 UTC > Y> > Y> > Y> > Y> FreeBSD src repository > Y> > Y> > Y> > Y> Modified files: > Y> > Y> sys/net if_vlan.c > Y> > Y> Log: > Y> > Y> Test the new M_VLANTAG packet flag before calling > Y> > Y> m_tag_locate(). This adds little overhead of a simple > Y> > Y> bitwise operation in case hardware VLAN acceleration > Y> > Y> is on, yet saves the more expensive function call if > Y> > Y> the acceleration is off. > Y> > Y> > Y> > Y> Reviewed by: ru, glebius > Y> > Y> X-MFC-after: 6.0 > Y> > ^^^^^^^^^^^^^^^^^^^ > Y> > Why? > Y> > Y> 'Cause it's more about code consistency than stability, or performance, > Y> or features. So I'd rather not bother re@ with this when they are > Y> being flooded with really important bugfixes. It shouldn't be the > Y> extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;) > > Not a bottleneck, but a significant processing addon for every > inbound packet. > > If you don't mind I will request MFC from re@ after some testing. Well, I am not happy to shift off my job upon you... But if you feel like doing it, I have no objection against MFC ;-) -- Yar From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:49:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6F8116A420; Fri, 16 Sep 2005 12:49:06 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F29843D46; Fri, 16 Sep 2005 12:49:06 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GCn6NV092892; Fri, 16 Sep 2005 12:49:06 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GCn6JP092891; Fri, 16 Sep 2005 12:49:06 GMT (envelope-from ru) Message-Id: <200509161249.j8GCn6JP092891@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 12:49:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/dev/oltr if_oltr.c src/sys/dev/lnc if_lnc.c src/sys/dev/nve if_nve.c src/sys/dev/patm if_patm_attach.c src/sys/dev/fe if_fe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:49:07 -0000 ru 2005-09-16 12:49:06 UTC FreeBSD src repository Modified files: sys/contrib/dev/oltr if_oltr.c sys/dev/lnc if_lnc.c sys/dev/nve if_nve.c sys/dev/patm if_patm_attach.c sys/dev/fe if_fe.c Log: Fix "struct ifnet" leak if attach() fails in the middle. Revision Changes Path 1.39 +2 -0 src/sys/contrib/dev/oltr/if_oltr.c 1.94 +1 -0 src/sys/dev/fe/if_fe.c 1.114 +3 -1 src/sys/dev/lnc/if_lnc.c 1.11 +3 -1 src/sys/dev/nve/if_nve.c 1.12 +3 -1 src/sys/dev/patm/if_patm_attach.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 13:36:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2316816A41F; Fri, 16 Sep 2005 13:36:45 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D410543D46; Fri, 16 Sep 2005 13:36:44 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GDaiTf094848; Fri, 16 Sep 2005 13:36:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GDaieJ094847; Fri, 16 Sep 2005 13:36:44 GMT (envelope-from rwatson) Message-Id: <200509161336.j8GDaieJ094847@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 13:36:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 13:36:45 -0000 rwatson 2005-09-16 13:36:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.123 from HEAD to RELENG_6: As a result of kqueue locking work, socket buffer locks will always be held when entering a kqueue filter for fifos via a socket buffer event: as such, assert the lock unconditionally rather than acquiring it conditionally. Approved by: re (scottl) Revision Changes Path 1.113.2.9 +6 -18 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 14:03:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8EFB16A41F; Fri, 16 Sep 2005 14:03:10 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D40443D48; Fri, 16 Sep 2005 14:03:10 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GE3AkT095774; Fri, 16 Sep 2005 14:03:10 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GE3AeX095773; Fri, 16 Sep 2005 14:03:10 GMT (envelope-from rwatson) Message-Id: <200509161403.j8GE3AeX095773@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 14:03:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 14:03:10 -0000 rwatson 2005-09-16 14:03:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.122 from HEAD to RELENG_6: Annotate two issues: 1) fifo_kqfilter() is not actually ever used, it likely should be GC'd. 2) fifo_kqfilter_f() doesn't implement EVFILT_VNODE, so detecting events on the underlying vnode for a fifo no longer works (it did in 4.x). Likely, fifo_kqfilter_f() should forward the request to the VFS using fp->f_vnode, which would work once fifo_kqfilter() was detached from the vnode operation vector (removing the fifo override). Discussed with: phk Approved by: re (scottl) Revision Changes Path 1.113.2.10 +12 -0 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 14:03:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C90A16A41F; Fri, 16 Sep 2005 14:03:58 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E5B243D58; Fri, 16 Sep 2005 14:03:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GE3vkU095821; Fri, 16 Sep 2005 14:03:57 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GE3v4l095820; Fri, 16 Sep 2005 14:03:57 GMT (envelope-from rwatson) Message-Id: <200509161403.j8GE3v4l095820@repoman.freebsd.org> From: Robert Watson Date: Fri, 16 Sep 2005 14:03:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 14:03:58 -0000 rwatson 2005-09-16 14:03:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/fifofs fifo_vnops.c Log: Merge fifo_vnops.c:1.124 from HEAD to RELENG_6: Trim down now (believed to be) unused fifo_ioctl() and fifo_kqfilter() VOP implementations, since they in theory are used only on open file descriptors, in which case the ioctls are via fifo_ioctl_f() and kqueue requests are via fifo_kqfilter_f(). Generate warnings if they are entered for now. These printf() calls should become panic() calls. Annotate and re-implement fifo_ioctl_f(): don't arbitrarily forward ioctls to the socket layer, only forward the ones we explicitly support for fifos. In the case of FIONREAD, don't forward the request to the write socket on a read-write fifo, or the read result is overwritten. Annotate a nasty case for the undefined POSIX O_RDWR on fifos, in which failure of the second ioctl will result in the socket pair being in an inconsistent state. Assert copyright as I find myself rewriting non-trivial parts of fifofs. Approved by: re (scottl) Revision Changes Path 1.113.2.11 +75 -65 src/sys/fs/fifofs/fifo_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 14:18:59 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5268016A41F; Fri, 16 Sep 2005 14:18:59 +0000 (GMT) (envelope-from stb@lassitu.de) Received: from schlepper.zs64.net (schlepper.zs64.net [212.12.50.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56E6343D79; Fri, 16 Sep 2005 14:18:57 +0000 (GMT) (envelope-from stb@lassitu.de) Received: from [IPv6:::1] (schlepper [212.12.50.230]) by schlepper.zs64.net (8.13.3/8.12.9) with ESMTP id j8GEItsj033121; Fri, 16 Sep 2005 16:18:56 +0200 (CEST) (envelope-from stb@lassitu.de) In-Reply-To: <200509161119.j8GBJcS0080866@repoman.freebsd.org> References: <200509161119.j8GBJcS0080866@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v734) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Stefan Bethke Date: Fri, 16 Sep 2005 16:19:09 +0200 To: Pawel Jakub Dawidek X-Mailer: Apple Mail (2.734) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libutil pidfile.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 14:18:59 -0000 Am 16.09.2005 um 13:19 schrieb Pawel Jakub Dawidek: > pjd 2005-09-16 11:19:38 UTC > > FreeBSD src repository > > Modified files: > lib/libutil pidfile.3 > Log: > Pidfiles should be created with permission preventing users from > opening > them for reading. When user can open file for reading, he can also > flock(2) it, which can lead to confusions. This means that a monitoring tool would need to run with elevated privileges to determine the PID of the process to monitor, correct? Stefan -- Stefan Bethke Fon +49 170 346 0140 From owner-cvs-src@FreeBSD.ORG Fri Sep 16 15:03:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B598716A41F; Fri, 16 Sep 2005 15:03:34 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E98443D45; Fri, 16 Sep 2005 15:03:34 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8GF1T7i050256; Fri, 16 Sep 2005 09:01:29 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 09:01:40 -0600 (MDT) Message-Id: <20050916.090140.58827157.imp@bsdimp.com> To: ru@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20050916091928.GG88456@ip.net.ua> References: <200509151521.14204.jhb@FreeBSD.org> <20050915205639.GD88456@ip.net.ua> <20050916091928.GG88456@ip.net.ua> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 09:01:29 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 15:03:34 -0000 In message: <20050916091928.GG88456@ip.net.ua> Ruslan Ermilov writes: : On Thu, Sep 15, 2005 at 11:56:39PM +0300, Ruslan Ermilov wrote: : > The first is the BPF detach bad interaction with foo_detach(), : > as described in re_detach(). This panic is real with (I think) : > all drivers. And testing IFF_DRV_RUNNING here doesn't seem to : > be able to prevent the panic. Perhaps the fix would be to : > move ether_ifdetach() before foo_stop() in foo_detach(), I'm : > not yet sure. : > : I tried with rl(4) PCCARD, by moving ether_ifdetach() before : rl_stop() in rl_detach(). It fixes the panic when you eject : the card, but doesn't fix it when kldunloading the module. : The difference is that rl_detach() is called already after : miibus0 and rlphy0 has been detached when kldunloading the : module. When ejecting the card, rl_detach() is called first. : What happens when you kldunload the module with BPF listener : attached, is that bpfdetach() calls rl_ioctl() to reset : promisc, that calls rl_init_locked(), and that results in : : mii = device_get_softc(sc->rl_miibus); : : being NULL (remember the miibus has already been detached), : and that panics later here: : : mii_mediachg(mii); : : When we reset IFF_UP, rl_ioctl(SIOCSIFFLAGS) silently exits : and no harm is done. So the question is: how do we prevent : this from happening without resetting IFF_UP. One possible : solution would be to add sc->detaching, similar to : sc->suspended, abd check it in rl_ioctl(). Ugg. In ed, we check to make sure that we still have a child before doing things with mii bus. A similar fix could be made. Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 17:09:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A036B16A41F; Fri, 16 Sep 2005 17:09:37 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 411A843D53; Fri, 16 Sep 2005 17:09:36 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8GH9Po5015372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 16 Sep 2005 10:09:26 -0700 Message-ID: <432AFC3A.8000400@root.org> Date: Fri, 16 Sep 2005 10:09:14 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <200509160702.j8G72TBv063544@repoman.freebsd.org> <20050916.010746.98777894.imp@bsdimp.com> In-Reply-To: <20050916.010746.98777894.imp@bsdimp.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 17:09:37 -0000 M. Warner Losh wrote: > In message: <200509160702.j8G72TBv063544@repoman.freebsd.org> > Warner Losh writes: > : imp 2005-09-16 07:02:29 UTC > : > : FreeBSD src repository > : > : Modified files: > : sys/dev/acpica acpi_pcib_acpi.c > : sys/i386/pci pci_bus.c > : Log: > : Commit a workaround to a problem with resource allocation. This helps > : with some Dell servers that booted w/o a problem[*] on 5.4, but failed > : with 6.0-BETA. > : > : On the PCI bus, when we do lazy resource allocation, we narrow the > : range requested as we pass through bridges to reflect how the bridges > : are programmed and what addresses they pass. However, when we're > : doing an allocation on a bus that's directly connected to a host > : bridge, no such translation can take place. We already had a fallback > : range for memory requests, but none for ioports. As such, provide a > : fallback for I/O ports so we don't allocate location 0, which will > : have undesired side effects when the resources are actually used. > : > : This fixes a problem with booting a Dell server with usb in the > : kernel. However, it is an unsatisfying solution. I don't like the > : hard coded value, and I think we should start narrowing the resources > : returned to not be in the so-called isa alias area (where the ranage & > : 0x0300 must be 0 iirc). Doing such filtering will have to wait for > : another day. > : > : This may be a good 6 candidate, maybe after its had a chance to be > : refined. > : > : Tested by: glebius@ > > for those interested in the omitted footnote: > > [*] and also without its first usb controller: uhci0 failed to attach. > > I don't think this is worthy of a forced commit, but I know how some > people are when they see dangling references... At some point, I may implement a similar workaround as Windows XP. It blocks access by AML to the following port ranges. http://www.softwaretipsandtricks.com/forum/printthread.php?t=1674 Address Function Comments 0x000 – 0x00F DMA Controller 1 0x020 – 0x021 PIC Access is never allowed* 0x040 – 0x043 System Timer 1 0x048 – 0x04B Timer 2 Failsafe 0x070 – 0x071 System CMOS, RTC 0x074 – 0x076 Extended CMOS 0x081 – 0x083 DMA1 Page Registers 0x087 DMA1 CH0 Low Page 0x089 DMA2 CH2 Low Page 0x08A – 0x08B DMA2 CH3 Low Page, 0x08F DMA2 Low Page Refresh 0x090 – 0x091 Arbitration Control Port Card Select Feedback 0x093 – 0x094 Reserved System Board Setup 0x096 – 0x097 POS Channel Select 0x0A0 – 0x0A1 Cascaded PIC Access is never allowed* 0x0C0 – 0x0DF ISA DMA 0x4D0 – 0x4D1 PIC Edge/Level CR Access is never allowed* 0xCF8 – 0xD00 PCI Configuration Space *Read or write accesses to these ports are always blocked, regardless of the BIOS use of the _OSI method. Of course, you're describing device resources, but it seems like a similar issue. If someone else wants to do this, let me know. -- Nate From owner-cvs-src@FreeBSD.ORG Fri Sep 16 17:58:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 851DC16A41F; Fri, 16 Sep 2005 17:58:07 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4451643D48; Fri, 16 Sep 2005 17:58:07 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GHw7kt012400; Fri, 16 Sep 2005 17:58:07 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GHw7Gv012399; Fri, 16 Sep 2005 17:58:07 GMT (envelope-from ps) Message-Id: <200509161758.j8GHw7Gv012399@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 17:58:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/pci pci_user.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 17:58:07 -0000 ps 2005-09-16 17:58:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci_user.c Log: MFC: rev 1.20 For FreeBSD 4 binaries, when trying to read from a device that does not exsist, do not have ioctl return an error, but instead set -1 in the data returned to the user. This allows the HP bios flash utilities to work without requiring changes to their code. Approved by: re (scottl) Revision Changes Path 1.19.2.1 +8 -1 src/sys/dev/pci/pci_user.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 17:58:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7979416A41F; Fri, 16 Sep 2005 17:58:55 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34ED143D48; Fri, 16 Sep 2005 17:58:55 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GHwtpe013324; Fri, 16 Sep 2005 17:58:55 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GHwtJc013323; Fri, 16 Sep 2005 17:58:55 GMT (envelope-from ps) Message-Id: <200509161758.j8GHwtJc013323@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 17:58:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 17:58:55 -0000 ps 2005-09-16 17:58:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet tcp_input.c Log: MFC: rev 1.283 Remove a KASSERT in the sack path that fails because of a interaction between sack and a bug in the "bad retransmit recovery" logic. This is a workaround, the underlying bug will be fixed later. Approved by: re (scottl) Revision Changes Path 1.281.2.1 +0 -3 src/sys/netinet/tcp_input.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 17:59:49 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75E7E16A41F; Fri, 16 Sep 2005 17:59:49 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3505943D45; Fri, 16 Sep 2005 17:59:49 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GHxnm4013376; Fri, 16 Sep 2005 17:59:49 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GHxnE0013375; Fri, 16 Sep 2005 17:59:49 GMT (envelope-from ps) Message-Id: <200509161759.j8GHxnE0013375@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 17:59:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/ciss ciss.c cissreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 17:59:49 -0000 ps 2005-09-16 17:59:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ciss ciss.c cissreg.h Log: MFC: There's no reason to check the valence. This allows ciss to work on the P600. Approved by: re (scottl) Revision Changes Path 1.64.2.1 +0 -6 src/sys/dev/ciss/ciss.c 1.15.2.1 +0 -2 src/sys/dev/ciss/cissreg.h From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:01:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FAA616A41F; Fri, 16 Sep 2005 18:01:00 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FA6143D45; Fri, 16 Sep 2005 18:01:00 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GI102t013501; Fri, 16 Sep 2005 18:01:00 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GI0xJd013500; Fri, 16 Sep 2005 18:00:59 GMT (envelope-from ps) Message-Id: <200509161800.j8GI0xJd013500@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 18:00:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:01:00 -0000 ps 2005-09-16 18:00:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/aac aac_pci.c Log: MFC: Add support for HP branded 2610SA Approved by: re (scottl) Revision Changes Path 1.54.2.2 +2 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:02:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 930BB16A420; Fri, 16 Sep 2005 18:02:00 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C013A43D5C; Fri, 16 Sep 2005 18:01:55 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GI1tij013580; Fri, 16 Sep 2005 18:01:55 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GI1tvu013579; Fri, 16 Sep 2005 18:01:55 GMT (envelope-from ps) Message-Id: <200509161801.j8GI1tvu013579@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 18:01:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:02:00 -0000 ps 2005-09-16 18:01:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_mutex.c Log: MFC: Ignore mutex asserts when we're dumping as well. This allows me to panic a system from DDB when INVARIANTS is compiled into the kernel on a scsi system. Approved by: re (scottl) Revision Changes Path 1.154.2.2 +2 -1 src/sys/kern/kern_mutex.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:02:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E4AC16A41F; Fri, 16 Sep 2005 18:02:39 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9272143D49; Fri, 16 Sep 2005 18:02:38 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GI2co6013624; Fri, 16 Sep 2005 18:02:38 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GI2cgS013623; Fri, 16 Sep 2005 18:02:38 GMT (envelope-from ps) Message-Id: <200509161802.j8GI2cgS013623@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 18:02:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/amr amr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:02:39 -0000 ps 2005-09-16 18:02:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/amr amr.c Log: MFC: rev 1.67 Print the actual disk device we failed to complete i/o on. Approved by: re (scottl) Revision Changes Path 1.65.2.1 +2 -2 src/sys/dev/amr/amr.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:04:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AEE416A41F; Fri, 16 Sep 2005 18:04:11 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDCD143D46; Fri, 16 Sep 2005 18:04:10 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GI4AWa013707; Fri, 16 Sep 2005 18:04:10 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GI4ARZ013706; Fri, 16 Sep 2005 18:04:10 GMT (envelope-from ps) Message-Id: <200509161804.j8GI4ARZ013706@repoman.freebsd.org> From: Paul Saab Date: Fri, 16 Sep 2005 18:04:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/amr amr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:04:11 -0000 ps 2005-09-16 18:04:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/amr amr.c Log: MFC: rev 1.66 Don't allow ioctl commands to be interrupted by the user. Approved by: re (scottl) Revision Changes Path 1.65.2.2 +4 -6 src/sys/dev/amr/amr.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:20:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8E1E16A41F; Fri, 16 Sep 2005 18:20:49 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79FEA43D45; Fri, 16 Sep 2005 18:20:49 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8GIKKXw051857; Fri, 16 Sep 2005 12:20:20 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 12:20:32 -0600 (MDT) Message-Id: <20050916.122032.85719690.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <432AFC3A.8000400@root.org> References: <200509160702.j8G72TBv063544@repoman.freebsd.org> <20050916.010746.98777894.imp@bsdimp.com> <432AFC3A.8000400@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp-2 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 12:20:20 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:20:50 -0000 In message: <432AFC3A.8000400@root.org> Nate Lawson writes: : M. Warner Losh wrote: : > In message: <200509160702.j8G72TBv063544@repoman.freebsd.org> : > Warner Losh writes: : > : imp 2005-09-16 07:02:29 UTC : > : : > : FreeBSD src repository : > : : > : Modified files: : > : sys/dev/acpica acpi_pcib_acpi.c : > : sys/i386/pci pci_bus.c : > : Log: : > : Commit a workaround to a problem with resource allocation. This helps : > : with some Dell servers that booted w/o a problem[*] on 5.4, but failed : > : with 6.0-BETA. : > : : > : On the PCI bus, when we do lazy resource allocation, we narrow the : > : range requested as we pass through bridges to reflect how the bridges : > : are programmed and what addresses they pass. However, when we're : > : doing an allocation on a bus that's directly connected to a host : > : bridge, no such translation can take place. We already had a fallback : > : range for memory requests, but none for ioports. As such, provide a : > : fallback for I/O ports so we don't allocate location 0, which will : > : have undesired side effects when the resources are actually used. : > : : > : This fixes a problem with booting a Dell server with usb in the : > : kernel. However, it is an unsatisfying solution. I don't like the : > : hard coded value, and I think we should start narrowing the resources : > : returned to not be in the so-called isa alias area (where the ranage & : > : 0x0300 must be 0 iirc). Doing such filtering will have to wait for : > : another day. : > : : > : This may be a good 6 candidate, maybe after its had a chance to be : > : refined. : > : : > : Tested by: glebius@ : > : > for those interested in the omitted footnote: : > : > [*] and also without its first usb controller: uhci0 failed to attach. : > : > I don't think this is worthy of a forced commit, but I know how some : > people are when they see dangling references... : : At some point, I may implement a similar workaround as Windows XP. It : blocks access by AML to the following port ranges. : : http://www.softwaretipsandtricks.com/forum/printthread.php?t=1674 : : Address Function Comments : 0x000 – 0x00F DMA Controller 1 : 0x020 – 0x021 PIC Access is never allowed* : 0x040 – 0x043 System Timer 1 : 0x048 – 0x04B Timer 2 Failsafe : 0x070 – 0x071 System CMOS, RTC : 0x074 – 0x076 Extended CMOS : 0x081 – 0x083 DMA1 Page Registers : 0x087 DMA1 CH0 Low Page : 0x089 DMA2 CH2 Low Page : 0x08A – 0x08B DMA2 CH3 Low Page, : 0x08F DMA2 Low Page Refresh : 0x090 – 0x091 Arbitration Control Port Card Select Feedback : 0x093 – 0x094 Reserved System Board Setup : 0x096 – 0x097 POS Channel Select : 0x0A0 – 0x0A1 Cascaded PIC Access is never allowed* : 0x0C0 – 0x0DF ISA DMA : 0x4D0 – 0x4D1 PIC Edge/Level CR Access is never allowed* : 0xCF8 – 0xD00 PCI Configuration Space : : *Read or write accesses to these ports are always blocked, regardless of : the BIOS use of the _OSI method. : : Of course, you're describing device resources, but it seems like a : similar issue. If someone else wants to do this, let me know. I've been thinking for a long time of having silent devices that gobble up these resources until such time that we have real devices. Most of it could be driven by PnP or ACPI info, I believe. The only one that couldn't be is the PCI Config space, but one change to pci.c would fix that :-). Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 18:28:14 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA30C16A41F; Fri, 16 Sep 2005 18:28:14 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8D9943D45; Fri, 16 Sep 2005 18:28:14 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GISEH7014571; Fri, 16 Sep 2005 18:28:14 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GISD1B014567; Fri, 16 Sep 2005 18:28:13 GMT (envelope-from tegge) Message-Id: <200509161828.j8GISD1B014567@repoman.freebsd.org> From: Tor Egge Date: Fri, 16 Sep 2005 18:28:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 18:28:15 -0000 tegge 2005-09-16 18:28:13 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: Break out of loop if next buffer pointer has become invalid while flushing current buffer. Reviewed by: kan Revision Changes Path 1.647 +15 -0 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 19:21:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF00316A41F; Fri, 16 Sep 2005 19:21:42 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3395943D45; Fri, 16 Sep 2005 19:21:42 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j8GJLe5I008409; Fri, 16 Sep 2005 13:21:40 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <432B1B49.2010400@samsco.org> Date: Fri, 16 Sep 2005 13:21:45 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Warner Losh References: <200509160702.j8G72TBv063544@repoman.freebsd.org> In-Reply-To: <200509160702.j8G72TBv063544@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 19:21:42 -0000 Warner Losh wrote: > imp 2005-09-16 07:02:29 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pcib_acpi.c > sys/i386/pci pci_bus.c > Log: > Commit a workaround to a problem with resource allocation. This helps > with some Dell servers that booted w/o a problem[*] on 5.4, but failed > with 6.0-BETA. > > On the PCI bus, when we do lazy resource allocation, we narrow the > range requested as we pass through bridges to reflect how the bridges > are programmed and what addresses they pass. However, when we're > doing an allocation on a bus that's directly connected to a host > bridge, no such translation can take place. We already had a fallback > range for memory requests, but none for ioports. As such, provide a > fallback for I/O ports so we don't allocate location 0, which will > have undesired side effects when the resources are actually used. > > This fixes a problem with booting a Dell server with usb in the > kernel. However, it is an unsatisfying solution. I don't like the > hard coded value, and I think we should start narrowing the resources > returned to not be in the so-called isa alias area (where the ranage & > 0x0300 must be 0 iirc). Doing such filtering will have to wait for > another day. > > This may be a good 6 candidate, maybe after its had a chance to be > refined. > > Tested by: glebius@ > > Revision Changes Path > 1.49 +2 -0 src/sys/dev/acpica/acpi_pcib_acpi.c > 1.120 +2 -0 src/sys/i386/pci/pci_bus.c Only the ACPI side of this patch works. The legacy PCI side has no effect on the problem. Scott From owner-cvs-src@FreeBSD.ORG Fri Sep 16 19:26:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E95516A41F; Fri, 16 Sep 2005 19:26:50 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9251F43D45; Fri, 16 Sep 2005 19:26:49 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8GJQOCP052319; Fri, 16 Sep 2005 13:26:24 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 13:26:36 -0600 (MDT) Message-Id: <20050916.132636.54186001.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <432B1B49.2010400@samsco.org> References: <200509160702.j8G72TBv063544@repoman.freebsd.org> <432B1B49.2010400@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 13:26:24 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 19:26:50 -0000 In message: <432B1B49.2010400@samsco.org> Scott Long writes: : Only the ACPI side of this patch works. The legacy PCI side has no : effect on the problem. OK. I'll take a look at why that is the case... Thanks for the report... Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 19:44:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70BA116A41F; Fri, 16 Sep 2005 19:44:09 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFE3743D45; Fri, 16 Sep 2005 19:44:08 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8GJhqhG048565; Fri, 16 Sep 2005 22:43:52 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 93757-18; Fri, 16 Sep 2005 22:43:52 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8GJhptt048562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 22:43:51 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8GJi6C8068306; Fri, 16 Sep 2005 22:44:06 +0300 (EEST) (envelope-from ru) Date: Fri, 16 Sep 2005 22:44:05 +0300 From: Ruslan Ermilov To: "M. Warner Losh" Message-ID: <20050916194405.GB24879@ip.net.ua> References: <200509151521.14204.jhb@FreeBSD.org> <20050915205639.GD88456@ip.net.ua> <20050916091928.GG88456@ip.net.ua> <20050916.090140.58827157.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1UWUbFP1cBYEclgG" Content-Disposition: inline In-Reply-To: <20050916.090140.58827157.imp@bsdimp.com> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 19:44:09 -0000 --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2005 at 09:01:40AM -0600, M. Warner Losh wrote: > In message: <20050916091928.GG88456@ip.net.ua> > Ruslan Ermilov writes: > : On Thu, Sep 15, 2005 at 11:56:39PM +0300, Ruslan Ermilov wrote: > : > The first is the BPF detach bad interaction with foo_detach(), > : > as described in re_detach(). This panic is real with (I think) > : > all drivers. And testing IFF_DRV_RUNNING here doesn't seem to > : > be able to prevent the panic. Perhaps the fix would be to > : > move ether_ifdetach() before foo_stop() in foo_detach(), I'm > : > not yet sure. > : >=20 > : I tried with rl(4) PCCARD, by moving ether_ifdetach() before > : rl_stop() in rl_detach(). It fixes the panic when you eject > : the card, but doesn't fix it when kldunloading the module. > : The difference is that rl_detach() is called already after > : miibus0 and rlphy0 has been detached when kldunloading the > : module. When ejecting the card, rl_detach() is called first. > : What happens when you kldunload the module with BPF listener > : attached, is that bpfdetach() calls rl_ioctl() to reset > : promisc, that calls rl_init_locked(), and that results in > :=20 > : mii =3D device_get_softc(sc->rl_miibus); > :=20 > : being NULL (remember the miibus has already been detached), > : and that panics later here: > :=20 > : mii_mediachg(mii); > :=20 > : When we reset IFF_UP, rl_ioctl(SIOCSIFFLAGS) silently exits > : and no harm is done. So the question is: how do we prevent > : this from happening without resetting IFF_UP. One possible > : solution would be to add sc->detaching, similar to > : sc->suspended, abd check it in rl_ioctl(). >=20 > Ugg. In ed, we check to make sure that we still have a child before > doing things with mii bus. A similar fix could be made. >=20 No, ed(4) has the same problem: if (sc->miibus !=3D NULL) { struct mii_data *mii; mii =3D device_get_softc(sc->miibus); mii_mediachg(mii); } The device (sc->miibus) will still be there but already detached, and its softc will already be freed, so "mii" will be NULL, and mii_mediachg(NULL) will panic the system. xl(4), for example, also checks for "mii" to be not NULL: /* XXX Downcall to miibus. */ if (mii !=3D NULL) mii_mediachg(mii); Somehow I think it's plain incorrect to implicitly call start() after explicitly calling stop() from detach() -- except for possibly panicing the system, it also re-enables interrupts, re-schedules just cancelled callouts, etc. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --1UWUbFP1cBYEclgG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKyCFqRfpzJluFF4RAtzYAKCI8FrGhA6bZllV0eVwrBlLPKDElgCeMncG y2MdRABLbL7BC6WsIKsggJY= =0AaR -----END PGP SIGNATURE----- --1UWUbFP1cBYEclgG-- From owner-cvs-src@FreeBSD.ORG Fri Sep 16 20:00:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78C8616A420; Fri, 16 Sep 2005 20:00:17 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id E522943D48; Fri, 16 Sep 2005 20:00:16 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8GJwT3s052629; Fri, 16 Sep 2005 13:58:29 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 13:58:41 -0600 (MDT) Message-Id: <20050916.135841.130619528.imp@bsdimp.com> To: ru@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20050916194405.GB24879@ip.net.ua> References: <20050916091928.GG88456@ip.net.ua> <20050916.090140.58827157.imp@bsdimp.com> <20050916194405.GB24879@ip.net.ua> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 13:58:30 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 20:00:17 -0000 In message: <20050916194405.GB24879@ip.net.ua> Ruslan Ermilov writes: : On Fri, Sep 16, 2005 at 09:01:40AM -0600, M. Warner Losh wrote: : > In message: <20050916091928.GG88456@ip.net.ua> : > Ruslan Ermilov writes: : > : On Thu, Sep 15, 2005 at 11:56:39PM +0300, Ruslan Ermilov wrote: : > : > The first is the BPF detach bad interaction with foo_detach(), : > : > as described in re_detach(). This panic is real with (I think) : > : > all drivers. And testing IFF_DRV_RUNNING here doesn't seem to : > : > be able to prevent the panic. Perhaps the fix would be to : > : > move ether_ifdetach() before foo_stop() in foo_detach(), I'm : > : > not yet sure. : > : > : > : I tried with rl(4) PCCARD, by moving ether_ifdetach() before : > : rl_stop() in rl_detach(). It fixes the panic when you eject : > : the card, but doesn't fix it when kldunloading the module. : > : The difference is that rl_detach() is called already after : > : miibus0 and rlphy0 has been detached when kldunloading the : > : module. When ejecting the card, rl_detach() is called first. : > : What happens when you kldunload the module with BPF listener : > : attached, is that bpfdetach() calls rl_ioctl() to reset : > : promisc, that calls rl_init_locked(), and that results in : > : : > : mii = device_get_softc(sc->rl_miibus); : > : : > : being NULL (remember the miibus has already been detached), : > : and that panics later here: : > : : > : mii_mediachg(mii); : > : : > : When we reset IFF_UP, rl_ioctl(SIOCSIFFLAGS) silently exits : > : and no harm is done. So the question is: how do we prevent : > : this from happening without resetting IFF_UP. One possible : > : solution would be to add sc->detaching, similar to : > : sc->suspended, abd check it in rl_ioctl(). : > : > Ugg. In ed, we check to make sure that we still have a child before : > doing things with mii bus. A similar fix could be made. : > : No, ed(4) has the same problem: : : if (sc->miibus != NULL) { : struct mii_data *mii; : mii = device_get_softc(sc->miibus); : mii_mediachg(mii); : } : No it doesn't: void ed_child_detached(device_t dev, device_t child) { struct ed_softc *sc; sc = device_get_softc(dev); if (child == sc->miibus) sc->miibus = NULL; } : The device (sc->miibus) will still be there but already detached, : and its softc will already be freed, so "mii" will be NULL, and : mii_mediachg(NULL) will panic the system. sc->miibus will be NULL after the device is detached, so you don't get an error. How again can this happen? Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 20:21:58 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E2F616A41F; Fri, 16 Sep 2005 20:21:58 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6947A43D48; Fri, 16 Sep 2005 20:21:57 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8GKLsOg056112; Fri, 16 Sep 2005 23:21:54 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 95111-13; Fri, 16 Sep 2005 23:21:53 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8GKLqqo056106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 23:21:53 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8GKM7tR042872; Fri, 16 Sep 2005 23:22:07 +0300 (EEST) (envelope-from ru) Date: Fri, 16 Sep 2005 23:22:07 +0300 From: Ruslan Ermilov To: "M. Warner Losh" Message-ID: <20050916202207.GA22151@ip.net.ua> References: <20050916091928.GG88456@ip.net.ua> <20050916.090140.58827157.imp@bsdimp.com> <20050916194405.GB24879@ip.net.ua> <20050916.135841.130619528.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: <20050916.135841.130619528.imp@bsdimp.com> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 20:21:58 -0000 --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2005 at 01:58:41PM -0600, M. Warner Losh wrote: > In message: <20050916194405.GB24879@ip.net.ua> > Ruslan Ermilov writes: > : On Fri, Sep 16, 2005 at 09:01:40AM -0600, M. Warner Losh wrote: > : > In message: <20050916091928.GG88456@ip.net.ua> > : > Ruslan Ermilov writes: > : > : On Thu, Sep 15, 2005 at 11:56:39PM +0300, Ruslan Ermilov wrote: > : > : > The first is the BPF detach bad interaction with foo_detach(), > : > : > as described in re_detach(). This panic is real with (I think) > : > : > all drivers. And testing IFF_DRV_RUNNING here doesn't seem to > : > : > be able to prevent the panic. Perhaps the fix would be to > : > : > move ether_ifdetach() before foo_stop() in foo_detach(), I'm > : > : > not yet sure. > : > : >=20 > : > : I tried with rl(4) PCCARD, by moving ether_ifdetach() before > : > : rl_stop() in rl_detach(). It fixes the panic when you eject > : > : the card, but doesn't fix it when kldunloading the module. > : > : The difference is that rl_detach() is called already after > : > : miibus0 and rlphy0 has been detached when kldunloading the > : > : module. When ejecting the card, rl_detach() is called first. > : > : What happens when you kldunload the module with BPF listener > : > : attached, is that bpfdetach() calls rl_ioctl() to reset > : > : promisc, that calls rl_init_locked(), and that results in > : > :=20 > : > : mii =3D device_get_softc(sc->rl_miibus); > : > :=20 > : > : being NULL (remember the miibus has already been detached), > : > : and that panics later here: > : > :=20 > : > : mii_mediachg(mii); > : > :=20 > : > : When we reset IFF_UP, rl_ioctl(SIOCSIFFLAGS) silently exits > : > : and no harm is done. So the question is: how do we prevent > : > : this from happening without resetting IFF_UP. One possible > : > : solution would be to add sc->detaching, similar to > : > : sc->suspended, abd check it in rl_ioctl(). > : >=20 > : > Ugg. In ed, we check to make sure that we still have a child before > : > doing things with mii bus. A similar fix could be made. > : >=20 > : No, ed(4) has the same problem: > :=20 > : if (sc->miibus !=3D NULL) { > : struct mii_data *mii; > : mii =3D device_get_softc(sc->miibus); > : mii_mediachg(mii); > : } > :=20 >=20 > No it doesn't: >=20 > void > ed_child_detached(device_t dev, device_t child) > { > struct ed_softc *sc; >=20 > sc =3D device_get_softc(dev); > if (child =3D=3D sc->miibus) > sc->miibus =3D NULL; > } >=20 > : The device (sc->miibus) will still be there but already detached, > : and its softc will already be freed, so "mii" will be NULL, and > : mii_mediachg(NULL) will panic the system. >=20 > sc->miibus will be NULL after the device is detached, so you don't get > an error. >=20 Hmm, I'm not very fluent in device(9) API, but I wonder what's then the analog of device_delete_child(sc->miibus) that the majority of foo_detach() methods do. I.e., will the miibus device really be removed? > How again can this happen? >=20 tcpdump -n -i ed0 & kldunload if_ed Still, ed_init_locked() will instantiate many things inappropriate for ed_detach() context. When experimenting with removing device_delete_child(sc->miibus) in rl(4), every new kldunload/kldload will add another miibusX device, showing that the child device removal doesn't happen implicitly. I wonder if you can see the same with ed(4), or if there's some code that does this. Also, the code that you refer seems to only work for pccard, while PCI version should be affected by the same "mii =3D=3D NULL" bug. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDKylvqRfpzJluFF4RAnHNAJ9CoWZTm4FQbhDYY6MlYU3BrI8PHgCdFi/F yuCcDlFjA8kl64/rtOORkSE= =m7i9 -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF-- From owner-cvs-src@FreeBSD.ORG Fri Sep 16 20:38:34 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7411B16A41F; Fri, 16 Sep 2005 20:38:34 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33E1E43D45; Fri, 16 Sep 2005 20:38:34 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GKcY2i020468; Fri, 16 Sep 2005 20:38:34 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GKcYL2020467; Fri, 16 Sep 2005 20:38:34 GMT (envelope-from ru) Message-Id: <200509162038.j8GKcYL2020467@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 16 Sep 2005 20:38:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 20:38:34 -0000 ru 2005-09-16 20:38:34 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: The arguments to printf() were swapped. Revision Changes Path 1.87 +2 -2 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 20:56:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 129A816A41F; Fri, 16 Sep 2005 20:56:18 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C68B843D45; Fri, 16 Sep 2005 20:56:17 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GKuHTK028596; Fri, 16 Sep 2005 20:56:17 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GKuHSE028595; Fri, 16 Sep 2005 20:56:17 GMT (envelope-from kan) Message-Id: <200509162056.j8GKuHSE028595@repoman.freebsd.org> From: Alexander Kabaev Date: Fri, 16 Sep 2005 20:56:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/lib/libstdc++ config.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 20:56:18 -0000 kan 2005-09-16 20:56:17 UTC FreeBSD src repository Modified files: gnu/lib/libstdc++ config.h Log: Do not expose vfwscanf, vswscanf, vwscanf and wcstof functions if they are not visible from wchar.h. Revision Changes Path 1.12 +8 -0 src/gnu/lib/libstdc++/config.h From owner-cvs-src@FreeBSD.ORG Fri Sep 16 21:15:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F24F716A41F; Fri, 16 Sep 2005 21:15:03 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E66343D46; Fri, 16 Sep 2005 21:15:03 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8GLCmjd053323; Fri, 16 Sep 2005 15:12:48 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 16 Sep 2005 15:13:01 -0600 (MDT) Message-Id: <20050916.151301.122028383.imp@bsdimp.com> To: ru@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20050916202207.GA22151@ip.net.ua> References: <20050916194405.GB24879@ip.net.ua> <20050916.135841.130619528.imp@bsdimp.com> <20050916202207.GA22151@ip.net.ua> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 16 Sep 2005 15:12:49 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 21:15:04 -0000 In message: <20050916202207.GA22151@ip.net.ua> Ruslan Ermilov writes: : Hmm, I'm not very fluent in device(9) API, but I wonder what's then : the analog of device_delete_child(sc->miibus) that the majority of : foo_detach() methods do. I.e., will the miibus device really be : removed? Yes. I believe so. : > How again can this happen? : > : tcpdump -n -i ed0 & : kldunload if_ed : : Still, ed_init_locked() will instantiate many things inappropriate : for ed_detach() context. How does ed_init_locked get called in ed_detach()? It looks to me that ed_stop is called, but ed_init() isn't. Where would it be called? : When experimenting with removing device_delete_child(sc->miibus) : in rl(4), every new kldunload/kldload will add another miibusX : device, showing that the child device removal doesn't happen : implicitly. I wonder if you can see the same with ed(4), or : if there's some code that does this. Also, the code that you : refer seems to only work for pccard, while PCI version should : be affected by the same "mii == NULL" bug. There's no ed + mii + pci. I'll take a look at these details tonight. Warner From owner-cvs-src@FreeBSD.ORG Fri Sep 16 21:24:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 735CC16A41F; Fri, 16 Sep 2005 21:24:11 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3329C43D45; Fri, 16 Sep 2005 21:24:11 +0000 (GMT) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GLOBvN029737; Fri, 16 Sep 2005 21:24:11 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GLOBxw029736; Fri, 16 Sep 2005 21:24:11 GMT (envelope-from kan) Message-Id: <200509162124.j8GLOBxw029736@repoman.freebsd.org> From: Alexander Kabaev Date: Fri, 16 Sep 2005 21:24:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/lib/libstdc++ config.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 21:24:11 -0000 kan 2005-09-16 21:24:11 UTC FreeBSD src repository Modified files: gnu/lib/libstdc++ config.h Log: Include to get __ISO_C_VISIBLE definition is one is not already available. Revision Changes Path 1.13 +3 -0 src/gnu/lib/libstdc++/config.h From owner-cvs-src@FreeBSD.ORG Fri Sep 16 21:54:01 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A851016A41F; Fri, 16 Sep 2005 21:54:01 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0022443D46; Fri, 16 Sep 2005 21:54:00 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8GLrejl081888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Sep 2005 01:53:40 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8GLrdpw081887; Sat, 17 Sep 2005 01:53:39 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 17 Sep 2005 01:53:39 +0400 From: Gleb Smirnoff To: "M. Warner Losh" Message-ID: <20050916215339.GA53891@cell.sick.ru> References: <200509160702.j8G72TBv063544@repoman.freebsd.org> <432B1B49.2010400@samsco.org> <20050916.132636.54186001.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050916.132636.54186001.imp@bsdimp.com> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c src/sys/i386/pci pci_bus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 21:54:01 -0000 On Fri, Sep 16, 2005 at 01:26:36PM -0600, M. Warner Losh wrote: M> : Only the ACPI side of this patch works. The legacy PCI side has no M> : effect on the problem. M> M> OK. I'll take a look at why that is the case... Thanks for the M> report... btw, I haven't tested the PCI side. Neither I have evidence that 5.4-RELEASE boots without ACPI. I can test both things in Monday. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Sep 16 22:59:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D593F16A41F; Fri, 16 Sep 2005 22:59:47 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7D1343D46; Fri, 16 Sep 2005 22:59:47 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8GMxlm0034400; Fri, 16 Sep 2005 22:59:47 GMT (envelope-from anholt@repoman.freebsd.org) Received: (from anholt@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8GMxlAn034399; Fri, 16 Sep 2005 22:59:47 GMT (envelope-from anholt) Message-Id: <200509162259.j8GMxlAn034399@repoman.freebsd.org> From: Eric Anholt Date: Fri, 16 Sep 2005 22:59:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci agp_nvidia.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 22:59:48 -0000 anholt 2005-09-16 22:59:47 UTC FreeBSD src repository Modified files: sys/pci agp_nvidia.c Log: Fix agp_nvidia.c to behave more like the linux driver, fixing DRI on Radeon 9200 according to one responder. The primary issue was not setting some bits to say that the entries were active, but also fix one place where some memory wasn't being used as volatile as it should. While here, change some use of ffs to a relatively short case statement, to make it more obvious what's going on. PR: kern/71638, kern/72372, kern/71547? Submitted by: Andrew J. Caines , Robin Schoonover , Jason Henson Revision Changes Path 1.10 +20 -11 src/sys/pci/agp_nvidia.c From owner-cvs-src@FreeBSD.ORG Fri Sep 16 23:06:08 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 618) id AA96916A420; Fri, 16 Sep 2005 23:06:08 +0000 (GMT) In-Reply-To: <20050916.151301.122028383.imp@bsdimp.com> from "M. Warner Losh" at "Sep 16, 2005 03:13:01 pm" To: imp@bsdimp.com (M. Warner Losh) Date: Fri, 16 Sep 2005 23:06:08 +0000 (GMT) X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20050916230608.AA96916A420@hub.freebsd.org> From: wpaul@FreeBSD.ORG (Bill Paul) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, ru@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 23:06:08 -0000 > In message: <20050916202207.GA22151@ip.net.ua> > Ruslan Ermilov writes: > : Hmm, I'm not very fluent in device(9) API, but I wonder what's then > : the analog of device_delete_child(sc->miibus) that the majority of > : foo_detach() methods do. I.e., will the miibus device really be > : removed? > > Yes. I believe so. > > : > How again can this happen? > : > > : tcpdump -n -i ed0 & > : kldunload if_ed > : > : Still, ed_init_locked() will instantiate many things inappropriate > : for ed_detach() context. > > How does ed_init_locked get called in ed_detach()? It looks to me > that ed_stop is called, but ed_init() isn't. Where would it be > called? BPF calls it. If someone's got a BPF listener on an interface and you detach the interface, BPF goes "oh shit, this interface is going away and I've still got my grimy paws on it -- I better clean up" and one of the things it does in the process is turn off promiscuous mode. To do that, it calls (*ifp->if_ioctl)(SIOCSIFFLAGS) to turn off IFF_PROMISC. Now, _some_ drivers will shortcut the handling of SIOCSIFFLAGS by simply calling their (*ifp->if_init)() function, since they know this routine configures the RX filter settings anyway. At this point, even though you're in the middle of detaching the interface, IFF_UP is still set, so (*ifp->if_init)() goes through the motions of initializing the chip and all the other driver machinery, which brings the interface back up again even though foo_detach() just stopped it. The main way you get in trouble with this is if your foo_init() routine launches any timers or taskqueue processing. These may be triggered after foo_detach() returns, by which time either the resources allocated for the driver have been deleted or the text pages have been invalidated, or both. You could also get in trouble if you did: foo_detach() { foo_stop(sc); free(sc->something_really_important, M_WHATEVER); ether_ifdetach(ifp); } If foo_init() depends on something_really_important, then you're hosed if foo_init() runs again. My solution in re_detach() was basically just convenient. I had no idea a bikeshed would errupt over the fact that I was clearing IFF_UP. I know IFF_UP is supposed to be an administratively changed flag, but unloading the driver _is_ an administrative action. And for crying out loud, the interface is about to be destroyed: what difference does it make? If you insist on sticking to the "no twiddling IFF_UP from inside the driver" rule, then I think the problem can be avoided by simply not being lazy in foo_ioctl() and actually having explicit code in SIOCSIFFLAGS case that turns promisc mode on and off on an IFF_PROMISC transition, and is careful not to do it unless IFF_RUNNING is set. It also needs to handle IFF_UP separately from IFF_PROMISC. I think the correct logic would look something like: if (IFF_UP was toggled up) foo_init(sc); else if (IFF_UP was toggled down) foo_stop(sc); if (IFF_PROMISC was toggled up && ifp->if_flags & IFF_RUNNING) foo_set_promisc(sc); else if (IFF_PROMISC was toggled down && ifp->if_flags & IFF_RUNNING) foo_clear_promisc(sc); Note that the ether_ifdetach->bpf->foo_ioctl interaction can occur regardless of the bus the NIC is attached to. It doesn't matter if it's PCI, pccard or usb, or whether or not it uses mii. The bus attachments can influence the thing ends up crashing though. -Bill -- ============================================================================= -Bill Paul (510) 749-2329 | Senior Engineer, Master of Unix-Fu wpaul@windriver.com | Wind River Systems ============================================================================= "Ignorance may be bliss, but delusion is ecstasy!" -Perki ============================================================================= From owner-cvs-src@FreeBSD.ORG Sat Sep 17 03:36:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E954F16A41F; Sat, 17 Sep 2005 03:36:47 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8C7443D45; Sat, 17 Sep 2005 03:36:47 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H3algY083993; Sat, 17 Sep 2005 03:36:47 GMT (envelope-from anholt@repoman.freebsd.org) Received: (from anholt@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H3alVZ083992; Sat, 17 Sep 2005 03:36:47 GMT (envelope-from anholt) Message-Id: <200509170336.j8H3alVZ083992@repoman.freebsd.org> From: Eric Anholt Date: Sat, 17 Sep 2005 03:36:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 03:36:48 -0000 anholt 2005-09-17 03:36:47 UTC FreeBSD src repository Modified files: sys/conf files.i386 sys/pci agpreg.h sys/modules/agp Makefile Added files: sys/pci agp_ati.c Log: Add a new AGP driver for ATI IGP chipsets. The driver is based on reading of the Linux driver, since specs are unavailable. Many thanks to Adam Kirchhoff for multiple useful testing cycles, and Ralf Wostrack for the final fix to get it working. PR: i386/75251 Submitted by: anholt Revision Changes Path 1.541 +1 -0 src/sys/conf/files.i386 1.15 +1 -1 src/sys/modules/agp/Makefile 1.1 +386 -0 src/sys/pci/agp_ati.c (new) 1.14 +12 -0 src/sys/pci/agpreg.h From owner-cvs-src@FreeBSD.ORG Sat Sep 17 04:01:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFA6E16A41F; Sat, 17 Sep 2005 04:01:05 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 780C543D48; Sat, 17 Sep 2005 04:01:05 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H415Kp085314; Sat, 17 Sep 2005 04:01:05 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H415VL085313; Sat, 17 Sep 2005 04:01:05 GMT (envelope-from imp) Message-Id: <200509170401.j8H415VL085313@repoman.freebsd.org> From: Warner Losh Date: Sat, 17 Sep 2005 04:01:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/ed if_ed.c if_ed_3c503.c if_ed_cbus.c if_ed_hpp.c if_ed_isa.c if_ed_novell.c if_ed_pccard.c if_ed_pci.c if_ed_sic.c if_ed_wd80x3.c if_edreg.h if_edvar.h src/sys/dev/ep if_ep.c if_ep_eisa.c if_ep_pccard.c if_epreg.h if_epvar.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 04:01:06 -0000 imp 2005-09-17 04:01:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ed if_ed.c if_ed_3c503.c if_ed_cbus.c if_ed_hpp.c if_ed_isa.c if_ed_novell.c if_ed_pccard.c if_ed_pci.c if_ed_sic.c if_ed_wd80x3.c if_edreg.h if_edvar.h sys/dev/ep if_ep.c if_ep_eisa.c if_ep_pccard.c if_epreg.h if_epvar.h sys/dev/pccard card_if.m pccard.c pccard_cis.c pccard_cis.h pccarddevs pccardvar.h sys/dev/sn if_sn.c if_sn_pccard.c if_snvar.h sys/dev/xe if_xe.c if_xe_pccard.c Log: MFC: pccard updates o New APIs to access CIS, attribute memory and pccard registers o Lock ed driver o Support more cards in ed, ep, sn, xe o Use new APIs to get MAC address right more often. Approved by: re (scottl) Revision Changes Path 1.254.2.3 +170 -182 src/sys/dev/ed/if_ed.c 1.2.2.1 +1 -1 src/sys/dev/ed/if_ed_3c503.c 1.21.2.1 +10 -7 src/sys/dev/ed/if_ed_cbus.c 1.2.2.1 +6 -5 src/sys/dev/ed/if_ed_hpp.c 1.23.2.1 +8 -2 src/sys/dev/ed/if_ed_isa.c 1.6.2.1 +11 -11 src/sys/dev/ed/if_ed_novell.c 1.84.2.1 +437 -272 src/sys/dev/ed/if_ed_pccard.c 1.43.2.1 +12 -11 src/sys/dev/ed/if_ed_pci.c 1.4.2.1 +4 -3 src/sys/dev/ed/if_ed_sic.c 1.4.2.1 +1 -1 src/sys/dev/ed/if_ed_wd80x3.c 1.37.2.1 +18 -21 src/sys/dev/ed/if_edreg.h 1.32.2.1 +25 -9 src/sys/dev/ed/if_edvar.h 1.140.2.2 +6 -4 src/sys/dev/ep/if_ep.c 1.33.2.1 +6 -6 src/sys/dev/ep/if_ep_eisa.c 1.48.2.1 +1 -1 src/sys/dev/ep/if_ep_pccard.c 1.37.2.1 +7 -2 src/sys/dev/ep/if_epreg.h 1.18.2.1 +1 -2 src/sys/dev/ep/if_epvar.h 1.29.2.1 +41 -0 src/sys/dev/pccard/card_if.m 1.105.2.1 +161 -49 src/sys/dev/pccard/pccard.c 1.34.2.1 +10 -24 src/sys/dev/pccard/pccard_cis.c 1.3.2.1 +0 -1 src/sys/dev/pccard/pccard_cis.h 1.109.2.1 +35 -8 src/sys/dev/pccard/pccarddevs 1.53.2.1 +36 -23 src/sys/dev/pccard/pccardvar.h 1.45.2.3 +8 -4 src/sys/dev/sn/if_sn.c 1.32.2.1 +184 -41 src/sys/dev/sn/if_sn_pccard.c 1.8.2.1 +3 -1 src/sys/dev/sn/if_snvar.h 1.55.2.3 +6 -13 src/sys/dev/xe/if_xe.c 1.26.2.2 +103 -188 src/sys/dev/xe/if_xe_pccard.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 06:34:20 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD21A16A41F; Sat, 17 Sep 2005 06:34:20 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D06143D48; Sat, 17 Sep 2005 06:34:20 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H6YKGZ098650; Sat, 17 Sep 2005 06:34:20 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H6YKYV098649; Sat, 17 Sep 2005 06:34:20 GMT (envelope-from marcel) Message-Id: <200509170634.j8H6YKYV098649@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 17 Sep 2005 06:34:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys gpt.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 06:34:21 -0000 marcel 2005-09-17 06:34:19 UTC FreeBSD src repository Modified files: sys/sys gpt.h Log: o Change the type of the ent_name field from short to uint16_t. UTF-16 characters are not negative. o Change the corresponding comment from UNICODE-16 to UTF-16. There's no such thing as UNICODE-16. Revision Changes Path 1.9 +1 -1 src/sys/sys/gpt.h From owner-cvs-src@FreeBSD.ORG Sat Sep 17 07:05:18 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A41316A41F; Sat, 17 Sep 2005 07:05:18 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D267743D45; Sat, 17 Sep 2005 07:05:17 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H75HDc099721; Sat, 17 Sep 2005 07:05:17 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H75Ho1099720; Sat, 17 Sep 2005 07:05:17 GMT (envelope-from marcel) Message-Id: <200509170705.j8H75Ho1099720@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 17 Sep 2005 07:05:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom geom_gpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 07:05:18 -0000 marcel 2005-09-17 07:05:17 UTC FreeBSD src repository Modified files: sys/geom geom_gpt.c Log: Complete rewrite in preparation of adding support for control requests. The following features have been added: 1. Extensive checking and validation of both the primary and secondary headers to protect against corrupted data and to take advantage of the redundancy to allow the GPT to be used in the face of recoverable corruption. 2. Dynamic data-structures to avoid hardcoding gratuitous table limits so as to support the creation of GPT tables of (as of yet) unspecified size. 3. Only allow kernel dumps to swap partitions to provide the necessary anti-footshooting measures. Linux swap partitions are allowed. 4. Complete dump of the GPT configuration, including labels. 5. Supports Byte Order Mark (U+FEFF) handling for big-endian, little-endian and mixed-endian partition names. Revision Changes Path 1.33 +727 -155 src/sys/geom/geom_gpt.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 08:27:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FE5616A41F; Sat, 17 Sep 2005 08:27:05 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5B1043D49; Sat, 17 Sep 2005 08:27:01 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j8H8Qu53080610; Sat, 17 Sep 2005 12:26:56 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j8H8QoOM080609; Sat, 17 Sep 2005 12:26:50 +0400 (MSD) (envelope-from yar) Date: Sat, 17 Sep 2005 12:26:50 +0400 From: Yar Tikhiy To: Ruslan Ermilov Message-ID: <20050917082650.GA80221@comp.chem.msu.su> References: <200509162038.j8GKcYL2020467@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200509162038.j8GKcYL2020467@repoman.freebsd.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 08:27:05 -0000 On Fri, Sep 16, 2005 at 08:38:34PM +0000, Ruslan Ermilov wrote: > ru 2005-09-16 20:38:34 UTC > > FreeBSD src repository > > Modified files: > sys/net if_vlan.c > Log: > The arguments to printf() were swapped. > > Revision Changes Path > 1.87 +2 -2 src/sys/net/if_vlan.c Thanks for fixing this, was my fault. -- Yar From owner-cvs-src@FreeBSD.ORG Sat Sep 17 08:47:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C840C16A420 for ; Sat, 17 Sep 2005 08:47:13 +0000 (GMT) (envelope-from silby@silby.com) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.FreeBSD.org (Postfix) with SMTP id 9FE5343D45 for ; Sat, 17 Sep 2005 08:47:12 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 60712 invoked from network); 17 Sep 2005 08:47:10 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 17 Sep 2005 08:47:10 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sat, 17 Sep 2005 03:47:09 -0500 (CDT) From: Mike Silbersack To: Eric Anholt In-Reply-To: <200509170336.j8H3alVZ083992@repoman.freebsd.org> Message-ID: <20050917034526.U3662@odysseus.silby.com> References: <200509170336.j8H3alVZ083992@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 08:47:13 -0000 I think I asked in irc a while ago, but I can't recall the answer. I don't seem to have agp support on my laptop, which has: (--) PCI:*(0:2:0) Intel Corporation 82852/855GM Integrated Graphics Device rev 2, Mem @ 0xe8000000/27, 0xe0000000/19, I/O @ 0x1800/3 (--) PCI: (0:2:1) Intel Corporation 82852/855GM Integrated Graphics Device rev 2, Mem @ 0xf0000000/27, 0xe0080000/19 According to Xorg. Was there something odd about the chipset, or is it just a matter of adding device IDs? This is with RELENG_6. Mike "Silby" Silbersack On Sat, 17 Sep 2005, Eric Anholt wrote: > anholt 2005-09-17 03:36:47 UTC > > FreeBSD src repository > > Modified files: > sys/conf files.i386 > sys/pci agpreg.h > sys/modules/agp Makefile > Added files: > sys/pci agp_ati.c > Log: > Add a new AGP driver for ATI IGP chipsets. The driver is based on reading of > the Linux driver, since specs are unavailable. Many thanks to Adam Kirchhoff > for multiple useful testing cycles, and Ralf Wostrack for the final fix to get > it working. > > PR: i386/75251 > Submitted by: anholt > > Revision Changes Path > 1.541 +1 -0 src/sys/conf/files.i386 > 1.15 +1 -1 src/sys/modules/agp/Makefile > 1.1 +386 -0 src/sys/pci/agp_ati.c (new) > 1.14 +12 -0 src/sys/pci/agpreg.h > From owner-cvs-src@FreeBSD.ORG Sat Sep 17 09:20:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A82D16A41F; Sat, 17 Sep 2005 09:20:17 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A2B343D46; Sat, 17 Sep 2005 09:20:17 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H9KGXp011678; Sat, 17 Sep 2005 09:20:16 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H9KGbC011677; Sat, 17 Sep 2005 09:20:16 GMT (envelope-from joel) Message-Id: <200509170920.j8H9KGbC011677@repoman.freebsd.org> From: Joel Dahl Date: Sat, 17 Sep 2005 09:20:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 cdce.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 09:20:17 -0000 joel 2005-09-17 09:20:16 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 cdce.4 Log: Add HARDWARE section. Reviewed by: brueffer Revision Changes Path 1.6 +14 -10 src/share/man/man4/cdce.4 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 09:35:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA30016A41F; Sat, 17 Sep 2005 09:35:57 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8351F43D48; Sat, 17 Sep 2005 09:35:57 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8H9ZvSr012322; Sat, 17 Sep 2005 09:35:57 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8H9Zv0V012321; Sat, 17 Sep 2005 09:35:57 GMT (envelope-from joel) Message-Id: <200509170935.j8H9Zv0V012321@repoman.freebsd.org> From: Joel Dahl Date: Sat, 17 Sep 2005 09:35:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/share/misc dev.archlist.txt src/release/doc/en_US.ISO8859-1/hardware/common dev.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 09:35:58 -0000 joel 2005-09-17 09:35:56 UTC FreeBSD src repository (doc committer) Modified files: release/doc/share/misc dev.archlist.txt release/doc/en_US.ISO8859-1/hardware/common dev.sgml Log: Add cdce(4). Reviewed by: brueffer Revision Changes Path 1.285 +2 -0 src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml 1.67 +1 -0 src/release/doc/share/misc/dev.archlist.txt From owner-cvs-src@FreeBSD.ORG Sat Sep 17 10:16:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F332216A41F; Sat, 17 Sep 2005 10:16:04 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33F8F43D45; Sat, 17 Sep 2005 10:16:03 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8HAFoWF003061; Sat, 17 Sep 2005 13:15:50 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 14934-14; Sat, 17 Sep 2005 13:15:49 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j8HAFbkb003056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Sep 2005 13:15:43 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j8HAFqUE046170; Sat, 17 Sep 2005 13:15:52 +0300 (EEST) (envelope-from ru) Date: Sat, 17 Sep 2005 13:15:52 +0300 From: Ruslan Ermilov To: Bill Paul Message-ID: <20050917101552.GC22151@ip.net.ua> References: <20050916.151301.122028383.imp@bsdimp.com> <20050916230608.AA96916A420@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: <20050916230608.AA96916A420@hub.freebsd.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, jhb@FreeBSD.org, "M. Warner Losh" Subject: Re: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 10:16:05 -0000 --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 16, 2005 at 11:06:08PM +0000, Bill Paul wrote: > If you insist on sticking to the "no twiddling IFF_UP from inside > the driver" rule, then I think the problem can be avoided by simply not > being lazy in foo_ioctl() and actually having explicit code in SIOCSIFFLA= GS > case that turns promisc mode on and off on an IFF_PROMISC transition, > and is careful not to do it unless IFF_RUNNING is set. It also > needs to handle IFF_UP separately from IFF_PROMISC. I think the > correct logic would look something like: >=20 > if (IFF_UP was toggled up) > foo_init(sc); > else if (IFF_UP was toggled down) > foo_stop(sc); >=20 > if (IFF_PROMISC was toggled up && ifp->if_flags & IFF_RUNNING) > foo_set_promisc(sc); > else if (IFF_PROMISC was toggled down && ifp->if_flags & IFF_RUNNING) > foo_clear_promisc(sc); >=20 How about prototyping the "lazy" SIOCSIFFLAGS handler as follows: if (IFF_UP has toggled up) foo_init(); /* foo_init takes care of IFF_PROMISC etc. */ else if (IFF_UP has toggled down) foo_stop(); else if (IFF_DRV_RUNNING) { if (something interesting has toggled) foo_init(); } Non-lazy handlers can specifially process IFF_PROMISC|IFF_ALLMULTI toggles. For comparison, the current "lazy" handler is as follows: if (IFF_UP) foo_init(); else if (!IFF_UP & IFF_DRV_RUNNING) foo_stop(); I.e., it doesn't remember the previous state. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDK+zXqRfpzJluFF4RAolZAJ4y+0V9/QikPJBEuDECfo7TFuHxXQCfbLhK /Bn2nksCGiuLfm2uNuyzACU= =IevN -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ-- From owner-cvs-src@FreeBSD.ORG Sat Sep 17 11:33:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFF2116A420; Sat, 17 Sep 2005 11:33:43 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4CBF43D46; Sat, 17 Sep 2005 11:33:41 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HBXfWu017023; Sat, 17 Sep 2005 11:33:41 GMT (envelope-from brian@repoman.freebsd.org) Received: (from brian@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HBXfEa017022; Sat, 17 Sep 2005 11:33:41 GMT (envelope-from brian) Message-Id: <200509171133.j8HBXfEa017022@repoman.freebsd.org> From: Brian Somers Date: Sat, 17 Sep 2005 11:33:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/cmp Makefile cmp.1 cmp.c extern.h link.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 11:33:44 -0000 brian 2005-09-17 11:33:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/cmp Makefile cmp.1 cmp.c extern.h Added files: (Branch: RELENG_6) usr.bin/cmp link.c Log: MFC: Add a -h option to tell cmp not to follow symbolic links. Approved by: re (scottl) Sponsored by: Sophos/ActiveState Revision Changes Path 1.6.14.1 +1 -1 src/usr.bin/cmp/Makefile 1.12.12.1 +3 -1 src/usr.bin/cmp/cmp.1 1.16.14.1 +25 -5 src/usr.bin/cmp/cmp.c 1.4.14.1 +1 -0 src/usr.bin/cmp/extern.h 1.1.2.1 +93 -0 src/usr.bin/cmp/link.c (new) From owner-cvs-src@FreeBSD.ORG Sat Sep 17 11:35:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5F5716A41F; Sat, 17 Sep 2005 11:35:24 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62FDD43D45; Sat, 17 Sep 2005 11:35:24 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HBZOTO017212; Sat, 17 Sep 2005 11:35:24 GMT (envelope-from brian@repoman.freebsd.org) Received: (from brian@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HBZOkr017211; Sat, 17 Sep 2005 11:35:24 GMT (envelope-from brian) Message-Id: <200509171135.j8HBZOkr017211@repoman.freebsd.org> From: Brian Somers Date: Sat, 17 Sep 2005 11:35:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.bin/cmp Makefile cmp.1 cmp.c extern.h link.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 11:35:24 -0000 brian 2005-09-17 11:35:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.bin/cmp Makefile cmp.1 cmp.c extern.h Added files: (Branch: RELENG_5) usr.bin/cmp link.c Log: MFC: Add a -h option to tell cmp not to follow symbolic links. Sponsored by: Sophos/ActiveState Revision Changes Path 1.6.8.1 +1 -1 src/usr.bin/cmp/Makefile 1.12.6.1 +3 -1 src/usr.bin/cmp/cmp.1 1.16.8.1 +25 -5 src/usr.bin/cmp/cmp.c 1.4.8.1 +1 -0 src/usr.bin/cmp/extern.h 1.1.4.1 +93 -0 src/usr.bin/cmp/link.c (new) From owner-cvs-src@FreeBSD.ORG Sat Sep 17 12:41:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9D3516A41F; Sat, 17 Sep 2005 12:41:05 +0000 (GMT) (envelope-from damien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A40E943D45; Sat, 17 Sep 2005 12:41:05 +0000 (GMT) (envelope-from damien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HCf54R019562; Sat, 17 Sep 2005 12:41:05 GMT (envelope-from damien@repoman.freebsd.org) Received: (from damien@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HCf5ov019561; Sat, 17 Sep 2005 12:41:05 GMT (envelope-from damien) Message-Id: <200509171241.j8HCf5ov019561@repoman.freebsd.org> From: Damien Bergamini Date: Sat, 17 Sep 2005 12:41:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 12:41:06 -0000 damien 2005-09-17 12:41:05 UTC FreeBSD src repository Modified files: sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h Log: o Add initial bits for IBSS support. o Allow association with APs that do not broadcast SSID (with hints from Nick Hudson and Hajimu Umemoto). o IFQ_DRV_PREPEND mbuf when h/w ring is full so it can be sent later. o Increment if_oerrors when appropriate. o Did some cleanup while I'm here. MFC after: 1 day Revision Changes Path 1.16 +93 -25 src/sys/dev/iwi/if_iwi.c 1.5 +13 -0 src/sys/dev/iwi/if_iwireg.h 1.6 +4 -0 src/sys/dev/iwi/if_iwivar.h From owner-cvs-src@FreeBSD.ORG Sat Sep 17 12:52:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA16216A41F; Sat, 17 Sep 2005 12:52:04 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 995EB43D45; Sat, 17 Sep 2005 12:52:04 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HCq4DL027313; Sat, 17 Sep 2005 12:52:04 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HCq4Jn027312; Sat, 17 Sep 2005 12:52:04 GMT (envelope-from rodrigc) Message-Id: <200509171252.j8HCq4Jn027312@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 17 Sep 2005 12:52:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/vidcontrol vidcontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 12:52:05 -0000 rodrigc 2005-09-17 12:52:04 UTC FreeBSD src repository Modified files: usr.sbin/vidcontrol vidcontrol.c Log: Fix so that color changes are not lost when the video mode changes. PR: bin/83553 Submitted by: Dan Lukes Revision Changes Path 1.53 +6 -0 src/usr.sbin/vidcontrol/vidcontrol.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 13:04:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66B1016A443; Sat, 17 Sep 2005 13:04:11 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C3E743D46; Sat, 17 Sep 2005 13:04:11 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HD4AcI027715; Sat, 17 Sep 2005 13:04:10 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HD4ASw027714; Sat, 17 Sep 2005 13:04:10 GMT (envelope-from jkoshy) Message-Id: <200509171304.j8HD4ASw027714@repoman.freebsd.org> From: Joseph Koshy Date: Sat, 17 Sep 2005 13:04:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/pmcstat pmcstat_log.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 13:04:11 -0000 jkoshy 2005-09-17 13:04:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pmcstat pmcstat_log.c Log: MFC { r1.4, r1.5 "pmcstat_log.c" } - Determine where the runtime loader got mapped to when a dynamically linked process was exec()'ed, and map samples in that address range into the appropriate buckets in the runtime loader's profile. - Fix a bug that caused generated gmon.out profiles to be out of whack. Use saturating arithmetic when incrementing a bucket. - Improve a few comments. Approved by: re (scottl) Revision Changes Path 1.3.2.1 +150 -95 src/usr.sbin/pmcstat/pmcstat_log.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 13:43:37 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7545F16A41F; Sat, 17 Sep 2005 13:43:37 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 344F643D46; Sat, 17 Sep 2005 13:43:37 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HDhbYO029090; Sat, 17 Sep 2005 13:43:37 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HDhbZ9029089; Sat, 17 Sep 2005 13:43:37 GMT (envelope-from bz) Message-Id: <200509171343.j8HDhbZ9029089@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 17 Sep 2005 13:43:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 13:43:37 -0000 bz 2005-09-17 13:43:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet ip_fw2.c Log: MFC: rev. 1.111 Fix panic when kernel compiled without INET6 by rejecting IPv6 opcodes which are behind #if(n)def INET6 now. PR: kern/85826 Approved by: re (scottl) Revision Changes Path 1.106.2.3 +30 -6 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 14:56:11 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D88316A41F; Sat, 17 Sep 2005 14:56:11 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C47443D46; Sat, 17 Sep 2005 14:56:10 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HEuARU031938; Sat, 17 Sep 2005 14:56:10 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HEuAk4031937; Sat, 17 Sep 2005 14:56:10 GMT (envelope-from rodrigc) Message-Id: <200509171456.j8HEuAk4031937@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 17 Sep 2005 14:56:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/fdisk fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 14:56:11 -0000 rodrigc 2005-09-17 14:56:10 UTC FreeBSD src repository Modified files: sbin/fdisk fdisk.c Log: Call gctl_free() to free resource allocated with gctl_get_handle(). PR: bin/84664 Submitted by: Daan Vreeken MFC after: 3 days Revision Changes Path 1.81 +4 -1 src/sbin/fdisk/fdisk.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:10:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39BE616A41F; Sat, 17 Sep 2005 15:10:40 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBF7043D46; Sat, 17 Sep 2005 15:10:39 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFAdML032712; Sat, 17 Sep 2005 15:10:39 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFAdJt032711; Sat, 17 Sep 2005 15:10:39 GMT (envelope-from rodrigc) Message-Id: <200509171510.j8HFAdJt032711@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 17 Sep 2005 15:10:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/bsdlabel bsdlabel.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:10:40 -0000 rodrigc 2005-09-17 15:10:39 UTC FreeBSD src repository Modified files: sbin/bsdlabel bsdlabel.8 Log: Clarify wording for -m flag. PR: docs/84704 Revision Changes Path 1.61 +12 -2 src/sbin/bsdlabel/bsdlabel.8 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:13:23 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D9F916A41F; Sat, 17 Sep 2005 15:13:23 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B80643D45; Sat, 17 Sep 2005 15:13:23 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFDM3s032813; Sat, 17 Sep 2005 15:13:22 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFDMi9032812; Sat, 17 Sep 2005 15:13:22 GMT (envelope-from joel) Message-Id: <200509171513.j8HFDMi9032812@repoman.freebsd.org> From: Joel Dahl Date: Sat, 17 Sep 2005 15:13:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 cdce.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:13:23 -0000 joel 2005-09-17 15:13:22 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 cdce.4 Log: Bump .Dd Reminded by: simon Revision Changes Path 1.7 +1 -1 src/share/man/man4/cdce.4 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:19:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96D0816A41F; Sat, 17 Sep 2005 15:19:38 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 546DB43D46; Sat, 17 Sep 2005 15:19:38 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFJcXH033211; Sat, 17 Sep 2005 15:19:38 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFJcpH033210; Sat, 17 Sep 2005 15:19:38 GMT (envelope-from mlaier) Message-Id: <200509171519.j8HFJcpH033210@repoman.freebsd.org> From: Max Laier Date: Sat, 17 Sep 2005 15:19:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/contrib/pf/net if_pfsync.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:19:38 -0000 mlaier 2005-09-17 15:19:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/contrib/pf/net if_pfsync.c Log: MFC: if_pfsync.c, 1.23: Stop leaking a lock. This used to cause a propagate_priority() page fault when setting syncdev and syncpeer. Reported by: Dominic Marks Approved by: re (scottl) Revision Changes Path 1.19.2.3 +4 -4 src/sys/contrib/pf/net/if_pfsync.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:27:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC67816A41F; Sat, 17 Sep 2005 15:27:27 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67D3643D46; Sat, 17 Sep 2005 15:27:27 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFRRDG033564; Sat, 17 Sep 2005 15:27:27 GMT (envelope-from garys@repoman.freebsd.org) Received: (from garys@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFRRxU033563; Sat, 17 Sep 2005 15:27:27 GMT (envelope-from garys) Message-Id: <200509171527.j8HFRRxU033563@repoman.freebsd.org> From: "Gary W. Swearingen" Date: Sat, 17 Sep 2005 15:27:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man1 builtin.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:27:27 -0000 garys 2005-09-17 15:27:27 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) share/man/man1 builtin.1 Log: MFC 1.25 Approved by: re Revision Changes Path 1.24.2.1 +36 -10 src/share/man/man1/builtin.1 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:30:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9768616A41F; Sat, 17 Sep 2005 15:30:16 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 548A543D45; Sat, 17 Sep 2005 15:30:16 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFUGln033732; Sat, 17 Sep 2005 15:30:16 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFUGNs033731; Sat, 17 Sep 2005 15:30:16 GMT (envelope-from cperciva) Message-Id: <200509171530.j8HFUGNs033731@repoman.freebsd.org> From: Colin Percival Date: Sat, 17 Sep 2005 15:30:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/portsnap/make_index make_index.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:30:16 -0000 cperciva 2005-09-17 15:30:16 UTC FreeBSD src repository Modified files: usr.sbin/portsnap/make_index make_index.c Log: Handle circular dependencies properly (via errx(3)) rather than dumping core. This bug was made visible by a recent change to the audio/timidity++ port, which now has itself as a run dependency. Reported by: Emil Mikulic, Andreas Klemm Revision Changes Path 1.3 +15 -2 src/usr.sbin/portsnap/make_index/make_index.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:43:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34F8916A41F; Sat, 17 Sep 2005 15:43:41 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E636243D46; Sat, 17 Sep 2005 15:43:40 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFhexJ034273; Sat, 17 Sep 2005 15:43:40 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFheen034272; Sat, 17 Sep 2005 15:43:40 GMT (envelope-from cperciva) Message-Id: <200509171543.j8HFheen034272@repoman.freebsd.org> From: Colin Percival Date: Sat, 17 Sep 2005 15:43:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/portsnap/make_index make_index.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:43:41 -0000 cperciva 2005-09-17 15:43:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/portsnap/make_index make_index.c Log: MFC revision 1.3: Log: Handle circular dependencies properly (via errx(3)) rather than dumping core. This bug was made visible by a recent change to the audio/timidity++ port, which now has itself as a run dependency. Approved by: re (scottl) Revision Changes Path 1.2.2.2 +15 -2 src/usr.sbin/portsnap/make_index/make_index.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:48:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7182616A41F; Sat, 17 Sep 2005 15:48:06 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F7CB43D49; Sat, 17 Sep 2005 15:48:06 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFm6x4034448; Sat, 17 Sep 2005 15:48:06 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFm6PJ034447; Sat, 17 Sep 2005 15:48:06 GMT (envelope-from delphij) Message-Id: <200509171548.j8HFm6PJ034447@repoman.freebsd.org> From: Xin LI Date: Sat, 17 Sep 2005 15:48:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/nullfs null_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:48:06 -0000 delphij 2005-09-17 15:48:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/nullfs null_vnops.c Log: MFC 1.88 (by ssouhlal): Use vput() instead of vrele() in null_reclaim() since the lower vnode is locked. MFC 1.89 (by kan): Handle a race condition where NULLFS vnode can be cleaned while threads can still be asleep waiting for lowervp lock. Tested by: kkenn Discussed with: ssouhlal, jeffr (rev. 1.89 is an early MFC for inclusion in the upcoming 6.0-BETA5) Approved by: re (scottl) Revision Changes Path 1.87.2.1 +5 -4 src/sys/fs/nullfs/null_vnops.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:50:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5DA816A41F; Sat, 17 Sep 2005 15:50:50 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7400043D45; Sat, 17 Sep 2005 15:50:50 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFoo6E034628; Sat, 17 Sep 2005 15:50:50 GMT (envelope-from garys@repoman.freebsd.org) Received: (from garys@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFooSK034627; Sat, 17 Sep 2005 15:50:50 GMT (envelope-from garys) Message-Id: <200509171550.j8HFooSK034627@repoman.freebsd.org> From: "Gary W. Swearingen" Date: Sat, 17 Sep 2005 15:50:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/share/man/man1 builtin.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:50:50 -0000 garys 2005-09-17 15:50:50 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_5) share/man/man1 builtin.1 Log: MFC 1.25 Approved by: keramida (mentor) Revision Changes Path 1.20.8.3 +37 -11 src/share/man/man1/builtin.1 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:51:13 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32B6816A41F; Sat, 17 Sep 2005 15:51:13 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E392D43D45; Sat, 17 Sep 2005 15:51:12 +0000 (GMT) (envelope-from tegge@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFpCre034661; Sat, 17 Sep 2005 15:51:12 GMT (envelope-from tegge@repoman.freebsd.org) Received: (from tegge@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFpCFP034660; Sat, 17 Sep 2005 15:51:12 GMT (envelope-from tegge) Message-Id: <200509171551.j8HFpCFP034660@repoman.freebsd.org> From: Tor Egge Date: Sat, 17 Sep 2005 15:51:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:51:13 -0000 tegge 2005-09-17 15:51:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_subr.c Log: MFC: Break out of loop if next buffer pointer has become invalid while flushing current buffer. Approved by: re (scottl) Revision Changes Path 1.635.2.7 +15 -0 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 15:51:42 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8477916A41F; Sat, 17 Sep 2005 15:51:42 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 275D343D45; Sat, 17 Sep 2005 15:51:42 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HFpgKd034720; Sat, 17 Sep 2005 15:51:42 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HFpg2h034719; Sat, 17 Sep 2005 15:51:42 GMT (envelope-from delphij) Message-Id: <200509171551.j8HFpg2h034719@repoman.freebsd.org> From: Xin LI Date: Sat, 17 Sep 2005 15:51:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/nullfs null_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 15:51:42 -0000 delphij 2005-09-17 15:51:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/nullfs null_vnops.c Log: Oops, actually MFC 1.89 (by kan) which was missed in previous commit: Handle a race condition where NULLFS vnode can be cleaned while threads can still be asleep waiting for lowervp lock. Tested by: kkenn Discussed with: ssouhlal, jeffr (this is an early MFC for inclusion in the upcoming 6.0-BETA5) Approved by: re (scottl) Revision Changes Path 1.87.2.2 +28 -4 src/sys/fs/nullfs/null_vnops.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 16:56:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC88016A41F; Sat, 17 Sep 2005 16:56:39 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86D9C43D45; Sat, 17 Sep 2005 16:56:39 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.200] ([10.0.0.200]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j8HGub6j068208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Sep 2005 09:56:38 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <432C4C6F.80906@errno.com> Date: Sat, 17 Sep 2005 10:03:43 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Damien Bergamini References: <200509171241.j8HCf5ov019561@repoman.freebsd.org> In-Reply-To: <200509171241.j8HCf5ov019561@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 16:56:40 -0000 Damien Bergamini wrote: > damien 2005-09-17 12:41:05 UTC > > FreeBSD src repository > > Modified files: > sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h > Log: > o Add initial bits for IBSS support. You appear to have added a private sta table so that you could have an index for each node table entry. However I don't see any place where you index into the table; only that you need the index to pass to the firmware. This seems to say you only need a per-node index and that can be done differently (see below). FWIW, the intended way to maange per-node driver-private data like this is for the driver to extend the node data structure with a private definition (override the class decl in c++ parlance) and store the index in the private data area. This could eliminate the table and avoid the problems you've introduced by holding uncounted references to node data structures. It also avoids likely race conditions that'll result from having an unlocked data structure that overlaps scope with the net80211 node table (I did something similar in the ath driver only to find out the hard way it was a mistake). > o Allow association with APs that do not broadcast SSID (with hints from > Nick Hudson and Hajimu Umemoto). > o IFQ_DRV_PREPEND mbuf when h/w ring is full so it can be sent later. > o Increment if_oerrors when appropriate. > o Did some cleanup while I'm here. > > MFC after: 1 day This commit msg didn't indicate that you also made changes for WME support. You appear to disallow QoS encapsulation of EAPOL frames but this is already done in ieee80211_encap. ieee80211_classify should assign an AC for all frames so use M_WME_GETAC(m) and don't make driver-local decisions unless they are required by the h/w (hard to tell from just looking at a diff). I suggest that MFC'ing some of these changes so quickly are a bad idea. Sam From owner-cvs-src@FreeBSD.ORG Sat Sep 17 17:12:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6ED0616A41F; Sat, 17 Sep 2005 17:12:19 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC5643D5A; Sat, 17 Sep 2005 17:12:18 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HHCIRi045378; Sat, 17 Sep 2005 17:12:18 GMT (envelope-from garys@repoman.freebsd.org) Received: (from garys@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HHCIsU045377; Sat, 17 Sep 2005 17:12:18 GMT (envelope-from garys) Message-Id: <200509171712.j8HHCIsU045377@repoman.freebsd.org> From: "Gary W. Swearingen" Date: Sat, 17 Sep 2005 17:12:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/compress compress.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 17:12:19 -0000 garys 2005-09-17 17:12:18 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) usr.bin/compress compress.1 Log: MFC 1.21 Approved by: re Revision Changes Path 1.20.2.1 +94 -26 src/usr.bin/compress/compress.1 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 17:19:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 499B016A41F; Sat, 17 Sep 2005 17:19:43 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06A4543D48; Sat, 17 Sep 2005 17:19:43 +0000 (GMT) (envelope-from garys@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HHJgj5045666; Sat, 17 Sep 2005 17:19:42 GMT (envelope-from garys@repoman.freebsd.org) Received: (from garys@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HHJgI2045665; Sat, 17 Sep 2005 17:19:42 GMT (envelope-from garys) Message-Id: <200509171719.j8HHJgI2045665@repoman.freebsd.org> From: "Gary W. Swearingen" Date: Sat, 17 Sep 2005 17:19:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.bin/compress compress.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 17:19:43 -0000 garys 2005-09-17 17:19:42 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_5) usr.bin/compress compress.1 Log: MFC 1.21 Approved by: keramida (mentor) Revision Changes Path 1.19.2.1 +94 -26 src/usr.bin/compress/compress.1 From owner-cvs-src@FreeBSD.ORG Sat Sep 17 19:07:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F28AA16A41F; Sat, 17 Sep 2005 19:07:03 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6789543D49; Sat, 17 Sep 2005 19:07:03 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (ppp-71-139-46-176.dsl.snfc21.pacbell.net [71.139.46.176]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8HJ76o5004474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 17 Sep 2005 12:07:06 -0700 Message-ID: <432C68D2.2060603@root.org> Date: Sat, 17 Sep 2005 12:04:50 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mike Silbersack References: <200509170336.j8H3alVZ083992@repoman.freebsd.org> <20050917034526.U3662@odysseus.silby.com> In-Reply-To: <20050917034526.U3662@odysseus.silby.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Anholt , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 19:07:04 -0000 Mike Silbersack wrote: > > I think I asked in irc a while ago, but I can't recall the answer. > > I don't seem to have agp support on my laptop, which has: > > (--) PCI:*(0:2:0) Intel Corporation 82852/855GM Integrated Graphics > Device rev 2, Mem @ 0xe8000000/27, > 0xe0000000/19, I/O @ 0x1800/3 > (--) PCI: (0:2:1) Intel Corporation 82852/855GM Integrated Graphics > Device rev 2, Mem @ 0xf0000000/27, > 0xe0080000/19 > > According to Xorg. Was there something odd about the chipset, or is it > just a matter of adding device IDs? This is with RELENG_6. 855GM and GMS are supported by the latest beta Xorg. So you just need to update your Xorg-server port. -- Nate From owner-cvs-src@FreeBSD.ORG Sat Sep 17 19:16:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96FDB16A41F; Sat, 17 Sep 2005 19:16:41 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from leguin.anholt.net (69-30-77-85.dq1sn.easystreet.com [69.30.77.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE97F43D49; Sat, 17 Sep 2005 19:16:40 +0000 (GMT) (envelope-from anholt@FreeBSD.org) Received: from leguin.anholt.net (localhost [127.0.0.1]) by leguin.anholt.net (8.13.4/8.13.1) with ESMTP id j8HJGdcL017604; Sat, 17 Sep 2005 12:16:39 -0700 (PDT) (envelope-from anholt@FreeBSD.org) Received: (from anholt@localhost) by leguin.anholt.net (8.13.4/8.13.1/Submit) id j8HJGdbY017603; Sat, 17 Sep 2005 12:16:39 -0700 (PDT) (envelope-from anholt@FreeBSD.org) X-Authentication-Warning: leguin.anholt.net: anholt set sender to anholt@FreeBSD.org using -f From: Eric Anholt To: Nate Lawson In-Reply-To: <432C68D2.2060603@root.org> References: <200509170336.j8H3alVZ083992@repoman.freebsd.org> <20050917034526.U3662@odysseus.silby.com> <432C68D2.2060603@root.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hSvJqiQx0rCCVh7lO7w6" Date: Sat, 17 Sep 2005 12:16:38 -0700 Message-Id: <1126984598.45786.29.camel@leguin> Mime-Version: 1.0 X-Mailer: Evolution 2.3.8 FreeBSD GNOME Team Port Cc: cvs-src@FreeBSD.org, Mike Silbersack , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: eta@lclark.edu List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 19:16:41 -0000 --=-hSvJqiQx0rCCVh7lO7w6 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2005-09-17 at 12:04 -0700, Nate Lawson wrote: > Mike Silbersack wrote: > >=20 > > I think I asked in irc a while ago, but I can't recall the answer. > >=20 > > I don't seem to have agp support on my laptop, which has: > >=20 > > (--) PCI:*(0:2:0) Intel Corporation 82852/855GM Integrated Graphics=20 > > Device rev 2, Mem @ 0xe8000000/27, > > 0xe0000000/19, I/O @ 0x1800/3 > > (--) PCI: (0:2:1) Intel Corporation 82852/855GM Integrated Graphics=20 > > Device rev 2, Mem @ 0xf0000000/27, > > 0xe0080000/19 > >=20 > > According to Xorg. Was there something odd about the chipset, or is it= =20 > > just a matter of adding device IDs? This is with RELENG_6. >=20 > 855GM and GMS are supported by the latest beta Xorg. So you just need=20 > to update your Xorg-server port. We clarified in private mail that the agp device isn't attaching. I think acpi_video is beating it out, confirming that we really need to be able to somehow share devices well for video. That's 3 drivers now (agp, drm, and acpi_video) that would all like to play. --=20 Eric Anholt eta@lclark.edu http://people.freebsd.org/~anholt/ anholt@FreeBSD.org --=-hSvJqiQx0rCCVh7lO7w6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBDLGuWHUdvYGzw6vcRApV5AKCMaxWlNK2uWm6N1ZHnJF3JN3d5AACgjglT bgSOcd01iqw055ic4sqKIKU= =e+iO -----END PGP SIGNATURE----- --=-hSvJqiQx0rCCVh7lO7w6-- From owner-cvs-src@FreeBSD.ORG Sat Sep 17 19:43:33 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A971316A41F; Sat, 17 Sep 2005 19:43:33 +0000 (GMT) (envelope-from damien.bergamini@free.fr) Received: from smtp4-g19.free.fr (smtp4-g19.free.fr [212.27.42.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6851643D55; Sat, 17 Sep 2005 19:43:32 +0000 (GMT) (envelope-from damien.bergamini@free.fr) Received: from COMETE (pasteur-1-82-67-68-158.fbx.proxad.net [82.67.68.158]) by smtp4-g19.free.fr (Postfix) with SMTP id 44980282F8; Sat, 17 Sep 2005 21:43:31 +0200 (CEST) Message-ID: <00d501c5bbc0$1e8a9240$0300a8c0@COMETE> From: "Damien Bergamini" To: "Sam Leffler" References: <200509171241.j8HCf5ov019561@repoman.freebsd.org> <432C4C6F.80906@errno.com> Date: Sat, 17 Sep 2005 21:43:46 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2670 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 19:43:33 -0000 | You appear to have added a private sta table so that you could have an | index for each node table entry. However I don't see any place where | you index into the table; only that you need the index to pass to the | firmware. This seems to say you only need a per-node index and that can | be done differently (see below). | | FWIW, the intended way to maange per-node driver-private data like this | is for the driver to extend the node data structure with a private | definition (override the class decl in c++ parlance) and store the index | in the private data area. This could eliminate the table and avoid the | problems you've introduced by holding uncounted references to node data | structures. It also avoids likely race conditions that'll result from | having an unlocked data structure that overlaps scope with the net80211 | node table (I did something similar in the ath driver only to find out | the hard way it was a mistake). No, you missed the point. This is not a table of ieee80211_node's, but just a table of the neighbours mac addresses. Thus there is no problem with reference counting, locking and such. The iwi_find_txnode() function just looks for a mac address in the table and returns its index (an entry is created if it was not already existing). | This commit msg didn't indicate that you also made changes for WME | support. You appear to disallow QoS encapsulation of EAPOL frames but | this is already done in ieee80211_encap. ieee80211_classify should | assign an AC for all frames so use M_WME_GETAC(m) and don't make | driver-local decisions unless they are required by the h/w (hard to tell | from just looking at a diff). No. I need to decide on which Tx ring the packet will be sent. And I must decide this before calling ieee80211_encap() because in case the ring is full, I want to put the packet back to the if_snd queue. Unfortunately, the check against EAPOL frames is done in ieee80211_encap(), not in ieee80211_classify(). If I use M_WME_GETAC(m) and the frame is an EAPOL frame, I'll end up checking for free space in the wrong ring. | I suggest that MFC'ing some of these changes so quickly are a bad idea. I don't think so. The WME changes have been in 7-CURRENT for a while now and the new changes are not likely to break anything. Most of the new code will not be triggered if IBSS mode is not active. I'd like this diff to make its way in BETA5 so it can be tested by many. Moreover it fixes the association problems with APs hiding their SSID. Damien From owner-cvs-src@FreeBSD.ORG Sat Sep 17 20:44:27 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5850B16A41F; Sat, 17 Sep 2005 20:44:27 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id F333743D46; Sat, 17 Sep 2005 20:44:26 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.250] (ppp-71-139-46-176.dsl.snfc21.pacbell.net [71.139.46.176]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8HKiLo5009839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 17 Sep 2005 13:44:21 -0700 Message-ID: <432C801E.2090904@root.org> Date: Sat, 17 Sep 2005 13:44:14 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: eta@lclark.edu References: <200509170336.j8H3alVZ083992@repoman.freebsd.org> <20050917034526.U3662@odysseus.silby.com> <432C68D2.2060603@root.org> <1126984598.45786.29.camel@leguin> In-Reply-To: <1126984598.45786.29.camel@leguin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Mike Silbersack , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 20:44:27 -0000 Eric Anholt wrote: > On Sat, 2005-09-17 at 12:04 -0700, Nate Lawson wrote: > >>Mike Silbersack wrote: >> >>>I think I asked in irc a while ago, but I can't recall the answer. >>> >>>I don't seem to have agp support on my laptop, which has: >>> >>>(--) PCI:*(0:2:0) Intel Corporation 82852/855GM Integrated Graphics >>>Device rev 2, Mem @ 0xe8000000/27, >>>0xe0000000/19, I/O @ 0x1800/3 >>>(--) PCI: (0:2:1) Intel Corporation 82852/855GM Integrated Graphics >>>Device rev 2, Mem @ 0xf0000000/27, >>>0xe0080000/19 >>> >>>According to Xorg. Was there something odd about the chipset, or is it >>>just a matter of adding device IDs? This is with RELENG_6. >> >>855GM and GMS are supported by the latest beta Xorg. So you just need >>to update your Xorg-server port. > > > We clarified in private mail that the agp device isn't attaching. I > think acpi_video is beating it out, confirming that we really need to be > able to somehow share devices well for video. That's 3 drivers now > (agp, drm, and acpi_video) that would all like to play. Ah. Yes, I think we'll have to do something like what I did for cpu devices. Basically, cpu0, cpu1, etc. implement a pseudo bus and multiple drivers attach below it. Do a devinfo to see this. There is no real way in newbus to have multiple drivers attached to a device if it doesn't implement a bus interface. This will require some design thinking. -- Nate From owner-cvs-src@FreeBSD.ORG Sat Sep 17 20:56:00 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CFE016A41F; Sat, 17 Sep 2005 20:56:00 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBA7D43D45; Sat, 17 Sep 2005 20:55:59 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.200] ([10.0.0.200]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j8HKtu6j069026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Sep 2005 13:55:57 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <432C8486.8060808@errno.com> Date: Sat, 17 Sep 2005 14:03:02 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Damien Bergamini References: <200509171241.j8HCf5ov019561@repoman.freebsd.org> <432C4C6F.80906@errno.com> <00d501c5bbc0$1e8a9240$0300a8c0@COMETE> In-Reply-To: <00d501c5bbc0$1e8a9240$0300a8c0@COMETE> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 20:56:00 -0000 Damien Bergamini wrote: > | You appear to have added a private sta table so that you could have an > | index for each node table entry. However I don't see any place where > | you index into the table; only that you need the index to pass to the > | firmware. This seems to say you only need a per-node index and that can > | be done differently (see below). > | > | FWIW, the intended way to maange per-node driver-private data like this > | is for the driver to extend the node data structure with a private > | definition (override the class decl in c++ parlance) and store the index > | in the private data area. This could eliminate the table and avoid the > | problems you've introduced by holding uncounted references to node data > | structures. It also avoids likely race conditions that'll result from > | having an unlocked data structure that overlaps scope with the net80211 > | node table (I did something similar in the ath driver only to find out > | the hard way it was a mistake). > > No, you missed the point. This is not a table of ieee80211_node's, but > just a table of the neighbours mac addresses. Thus there is no problem > with reference counting, locking and such. > The iwi_find_txnode() function just looks for a mac address in the table > and returns its index (an entry is created if it was not already existing). Sorry, you're correct, these are mac addresses and not node references. But the suggestion still holds. You've got a separate piece of per-node information that logically belongs in a driver-private area of the node. Having it there would eliminate the table lookup; you just take the node pointer and deref to get the index. The intent of driver-private node storage is to eliminate add-on tables like this. > > | This commit msg didn't indicate that you also made changes for WME > | support. You appear to disallow QoS encapsulation of EAPOL frames but > | this is already done in ieee80211_encap. ieee80211_classify should > | assign an AC for all frames so use M_WME_GETAC(m) and don't make > | driver-local decisions unless they are required by the h/w (hard to tell > | from just looking at a diff). > > No. I need to decide on which Tx ring the packet will be sent. > And I must decide this before calling ieee80211_encap() because in case > the ring is full, I want to put the packet back to the if_snd queue. > Unfortunately, the check against EAPOL frames is done in ieee80211_encap(), > not in ieee80211_classify(). If I use M_WME_GETAC(m) and the frame is > an EAPOL frame, I'll end up checking for free space in the wrong ring. Thanks again, that'll teach me to read diffs instead of the final code. ath has no limits on the h/w tx queues, the limits are imposed by the s/w buffers that back each entry so I never needed this. Perhaps we should move the EAPOL check to the classify code as it's required that you classify packets before doing the encap. > > | I suggest that MFC'ing some of these changes so quickly are a bad idea. > > I don't think so. The WME changes have been in 7-CURRENT for a while now > and the new changes are not likely to break anything. Most of the new > code will not be triggered if IBSS mode is not active. > I'd like this diff to make its way in BETA5 so it can be tested by many. > Moreover it fixes the association problems with APs hiding their SSID. > Note that when I MFC'd changes in this driver recently that I did not MFC any of your WME mods. My suggestion was that you not MFC _some_ of the changes; not things like fixing hidden ap handling. re is the final arbiter of what can be MFC'd. Sam From owner-cvs-src@FreeBSD.ORG Sat Sep 17 21:29:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9935516A436 for ; Sat, 17 Sep 2005 21:29:50 +0000 (GMT) (envelope-from silby@silby.com) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.FreeBSD.org (Postfix) with SMTP id 9F8B443D46 for ; Sat, 17 Sep 2005 21:29:49 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 31785 invoked from network); 17 Sep 2005 21:29:48 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 17 Sep 2005 21:29:48 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sat, 17 Sep 2005 16:29:46 -0500 (CDT) From: Mike Silbersack To: eta@lclark.edu In-Reply-To: <1126984598.45786.29.camel@leguin> Message-ID: <20050917162703.F765@odysseus.silby.com> References: <200509170336.j8H3alVZ083992@repoman.freebsd.org> <20050917034526.U3662@odysseus.silby.com> <432C68D2.2060603@root.org> <1126984598.45786.29.camel@leguin> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Nate Lawson Subject: Re: cvs commit: src/sys/conf files.i386 src/sys/pci agp_ati.c agpreg.h src/sys/modules/agp Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 21:29:50 -0000 On Sat, 17 Sep 2005, Eric Anholt wrote: > We clarified in private mail that the agp device isn't attaching. I > think acpi_video is beating it out, confirming that we really need to be > able to somehow share devices well for video. That's 3 drivers now > (agp, drm, and acpi_video) that would all like to play. > > -- > Eric Anholt eta@lclark.edu You hit the nail on the head, acpi_video was the problem. I don't know exacltly why I had it in there, I just went acpi-happy one day and started adding things. :) Mike "Silby" Silbersack From owner-cvs-src@FreeBSD.ORG Sat Sep 17 22:01:15 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92A4316A41F; Sat, 17 Sep 2005 22:01:15 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6605043D45; Sat, 17 Sep 2005 22:01:15 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HM1F45065865; Sat, 17 Sep 2005 22:01:15 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HM1FfW065864; Sat, 17 Sep 2005 22:01:15 GMT (envelope-from csjp) Message-Id: <200509172201.j8HM1FfW065864@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 17 Sep 2005 22:01:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_acl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 22:01:15 -0000 csjp 2005-09-17 22:01:14 UTC FreeBSD src repository Modified files: sys/kern kern_acl.c Log: Implement new world order in VFS locking for ACLs. This will remove the unconditional acquisition of Giant for ACL related operations. If the file system is set as being MP safe and debug.mpsafevfs is 1, do not pickup giant. For any operations which require namei(9) lookups: __acl_get_file __acl_get_link __acl_set_file __acl_set_link __acl_delete_file __acl_delete_link __acl_aclcheck_file __acl_aclcheck_link -Set the MPSAFE flag in NDINIT -Initialize vfslocked variable using the NDHASGIANT macro For functions which operate on fds, make sure the operations are locked: __acl_get_fd __acl_set_fd __acl_delete_fd __acl_aclcheck_fd -Initialize vfslocked using VFS_LOCK_GIANT before we manipulate the vnode Discussed with: jeff Revision Changes Path 1.47 +45 -44 src/sys/kern/kern_acl.c From owner-cvs-src@FreeBSD.ORG Sat Sep 17 23:45:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D69EB16A41F; Sat, 17 Sep 2005 23:45:22 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 936FE43D45; Sat, 17 Sep 2005 23:45:22 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HNjMap074207; Sat, 17 Sep 2005 23:45:22 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HNjMXa074206; Sat, 17 Sep 2005 23:45:22 GMT (envelope-from csjp) Message-Id: <200509172345.j8HNjMXa074206@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 17 Sep 2005 23:45:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 23:45:23 -0000 csjp 2005-09-17 23:45:22 UTC FreeBSD src repository Modified files: tools/tools README Log: Remove reference to bpfstat, this no longer exists. Revision Changes Path 1.42 +0 -1 src/tools/tools/README From owner-cvs-src@FreeBSD.ORG Sat Sep 17 23:57:53 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFBF316A41F; Sat, 17 Sep 2005 23:57:53 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99D7943D45; Sat, 17 Sep 2005 23:57:53 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8HNvrnB074802; Sat, 17 Sep 2005 23:57:53 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8HNvrAx074801; Sat, 17 Sep 2005 23:57:53 GMT (envelope-from imp) Message-Id: <200509172357.j8HNvrAx074801@repoman.freebsd.org> From: Warner Losh Date: Sat, 17 Sep 2005 23:57:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include legacyvar.h src/sys/i386/pci pci_bus.c src/sys/i386/i386 mptable_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2005 23:57:54 -0000 imp 2005-09-17 23:57:53 UTC FreeBSD src repository Modified files: sys/i386/include legacyvar.h sys/i386/pci pci_bus.c sys/i386/i386 mptable_pci.c Log: Expose legacy_pcib_alloc_resource, and use it in the mptable pci bus implementation, like other routines in the legacy bus. This should fix problems with resource allocation on MP systems without ACPI enabled. Revision Changes Path 1.3 +1 -1 src/sys/i386/i386/mptable_pci.c 1.7 +2 -0 src/sys/i386/include/legacyvar.h 1.121 +1 -1 src/sys/i386/pci/pci_bus.c