Date: Mon, 22 Aug 2005 11:57:21 -0700 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: Jonatan B <onatan@gmail.com> Cc: freebsd-bluetooth@freebsd.org Subject: Re: [PANIC] 6.0BETA2 in l2ping flood Message-ID: <bb4a86c7050822115738da118c@mail.gmail.com> In-Reply-To: <bb4a86c705082211144b0e0e0b@mail.gmail.com> References: <430A12AB.3030800@savvis.net> <bb4a86c705082211144b0e0e0b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_5997_19668216.1124737041544 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Jonatan, On 8/22/05, Maksim Yevmenkin <maksim.yevmenkin@gmail.com> wrote: > Jonatan and Pawel, >=20 > > +> This is a repeatable panic I get when l2ping flooding my tungsten. > > +> Maksim? > > +> > > +> repeatable panic with bluetooth on SMP > > +> > > +> #> l2ping -fa MyTungsten -s 65531 >=20 > [...] >=20 > > Fixed in HEAD, thanks for the report. >=20 > first, let me thank you both for reporting the problem (Jonatan) and > spending time looking into this (Pawel). i was able to reproduce the > problem and have fix that i will commit after brief testing. >=20 > the patch Pawel has committed to HEAD indeed fixes the panic (thanks > Pawel!) however it somewhat hides bigger bug in the bluetooth l2cap > code. the panic happens when l2cap connection descriptor is deleted > with the l2cap command(s) pending in the queue. in this case when the > last l2cap command is deleted (due to cleanup) and reference counter > for the l2cap connection goes down to zero the auto disconnect timeout > is incorrectly set. could you please try the attached patch? this patch is against HEAD. it should apply cleanly (for the most part) against 6.x and 5.x. there will be some rejects in ng_l2cap_misc.c if you apply it against 5.x or 6.x. you could fix them by hand. also to build l2control(8) utility you will need to install ng_l2cap.h header from /sys/netgraph/bluetooth/incude into /usr/include/netgraph/bluetooth/include. or you could just do "make buildworld/installworld" thanks, max ------=_Part_5997_19668216.1124737041544 Content-Type: text/plain; name="l2cap.timo.patch.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="l2cap.timo.patch.txt" PyBzeXMvZGV2L2FuL2lmX2FuLmMubmV3Cj8gc3lzL25ldC9pZl90YXAuYy5hbHRxCj8gdXNyLmJp bi9ibHVldG9vdGgvcmZjb21tX3NwcGQvbG9nCj8gdXNyLnNiaW4vYmx1ZXRvb3RoL2J0aGlkZC9i dGhpZF9zd2l0Y2hfa2V5Ym9hcmQKSW5kZXg6IHN5cy9uZXRncmFwaC9ibHVldG9vdGgvaW5jbHVk ZS9uZ19sMmNhcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9uZXRn cmFwaC9ibHVldG9vdGgvaW5jbHVkZS9uZ19sMmNhcC5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjMKZGlmZiAtdSAtcjEuMyBuZ19sMmNhcC5oCi0tLSBzeXMvbmV0Z3JhcGgvYmx1ZXRvb3RoL2lu Y2x1ZGUvbmdfbDJjYXAuaAk3IEphbiAyMDA1IDAxOjQ1OjQzIC0wMDAwCTEuMworKysgc3lzL25l dGdyYXBoL2JsdWV0b290aC9pbmNsdWRlL25nX2wyY2FwLmgJMjIgQXVnIDIwMDUgMTg6NDE6MTQg LTAwMDAKQEAgLTYyMyw2ICs2MjMsNyBAQAogI2RlZmluZSBOR19MMkNBUF9DT05fT1VUR09JTkcJ CSgxIDw8IDIpIC8qIG91dGdvaW5nIGNvbm5lY3Rpb24gKi8KICNkZWZpbmUgTkdfTDJDQVBfQ09O X0xQX1RJTU8JCSgxIDw8IDMpIC8qIExQIHRpbWVvdXQgKi8KICNkZWZpbmUgTkdfTDJDQVBfQ09O X0FVVE9fRElTQ09OX1RJTU8JKDEgPDwgNCkgLyogYXV0byBkaXNjb24uIHRpbWVvdXQgKi8KKyNk ZWZpbmUgTkdfTDJDQVBfQ09OX0RZSU5HCQkoMSA8PCA1KSAvKiBjb25uZWN0aW9uIGlzIGR5aW5n ICovCiAKIHR5cGVkZWYgc3RydWN0IHsKIAl1X2ludDhfdAlzdGF0ZTsgICAgICAvKiBjb25uZWN0 aW9uIHN0YXRlICovCkluZGV4OiBzeXMvbmV0Z3JhcGgvYmx1ZXRvb3RoL2wyY2FwL25nX2wyY2Fw X2NtZHMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9zeXMvbmV0Z3JhcGgv Ymx1ZXRvb3RoL2wyY2FwL25nX2wyY2FwX2NtZHMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41 CmRpZmYgLXUgLXIxLjUgbmdfbDJjYXBfY21kcy5jCi0tLSBzeXMvbmV0Z3JhcGgvYmx1ZXRvb3Ro L2wyY2FwL25nX2wyY2FwX2NtZHMuYwk3IEphbiAyMDA1IDAxOjQ1OjQzIC0wMDAwCTEuNQorKysg c3lzL25ldGdyYXBoL2JsdWV0b290aC9sMmNhcC9uZ19sMmNhcF9jbWRzLmMJMjIgQXVnIDIwMDUg MTg6NDE6MTQgLTAwMDAKQEAgLTIyNiw2ICsyMjYsOSBAQAogIiVzOiAlcyAtIEFDTCBjb25uZWN0 aW9uIGZhaWxlZCwgcmVzdWx0PSVkXG4iLAogCQlfX2Z1bmNfXywgTkdfTk9ERV9OQU1FKGwyY2Fw LT5ub2RlKSwgcmVzdWx0KTsKIAorCS8qIENvbm5lY3Rpb24gaXMgZHlpbmcgKi8KKwljb24tPmZs YWdzIHw9IE5HX0wyQ0FQX0NPTl9EWUlORzsKKwogCS8qIENsZWFuIGNvbW1hbmQgcXVldWUgKi8K IAl3aGlsZSAoIVRBSUxRX0VNUFRZKCZjb24tPmNtZF9saXN0KSkgewogCQljbWQgPSBUQUlMUV9G SVJTVCgmY29uLT5jbWRfbGlzdCk7CkluZGV4OiBzeXMvbmV0Z3JhcGgvYmx1ZXRvb3RoL2wyY2Fw L25nX2wyY2FwX21pc2MuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9zeXMv bmV0Z3JhcGgvYmx1ZXRvb3RoL2wyY2FwL25nX2wyY2FwX21pc2MuYyx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4xMQpkaWZmIC11IC1yMS4xMSBuZ19sMmNhcF9taXNjLmMKLS0tIHN5cy9uZXRncmFw aC9ibHVldG9vdGgvbDJjYXAvbmdfbDJjYXBfbWlzYy5jCTIxIEF1ZyAyMDA1IDE5OjE2OjI3IC0w MDAwCTEuMTEKKysrIHN5cy9uZXRncmFwaC9ibHVldG9vdGgvbDJjYXAvbmdfbDJjYXBfbWlzYy5j CTIyIEF1ZyAyMDA1IDE4OjQxOjE0IC0wMDAwCkBAIC0xODIsMTIgKzE4MiwxNCBAQAogCSAqIDIp IGNvbm5lY3Rpb24gaXMgaW4gT1BFTiBzdGF0ZQogCSAqIDMpIGl0IGlzIGFuIG91dGdvaW5nIGNv bm5lY3Rpb24KIAkgKiA0KSBkaXNjb25uZWN0IHRpbWVvdXQgPiAwCisJICogNSkgY29ubmVjdGlv biBpcyBub3QgZHlpbmcKIAkgKi8KIAogCWlmICgoY29uLT5yZWZjbnQgPT0gMCkgJiYKIAkgICAg KGNvbi0+c3RhdGUgPT0gTkdfTDJDQVBfQ09OX09QRU4pICYmCiAJICAgIChjb24tPmZsYWdzICYg TkdfTDJDQVBfQ09OX09VVEdPSU5HKSAmJiAKLQkgICAgKGNvbi0+bDJjYXAtPmRpc2Nvbl90aW1v ID4gMCkpCisJICAgIChjb24tPmwyY2FwLT5kaXNjb25fdGltbyA+IDApICYmCisJICAgICgoY29u LT5mbGFncyAmIE5HX0wyQ0FQX0NPTl9EWUlORykgPT0gMCkpCiAJCW5nX2wyY2FwX2Rpc2Nvbl90 aW1lb3V0KGNvbik7CiB9IC8qIG5nX2wyY2FwX2Nvbl91bnJlZiAqLwogCkBAIC0yNzMsMTEgKzI3 NSwxNCBAQAogCQluZ19sMmNhcF9mcmVlX2NtZChjbWQpOwogCX0KIAorCWlmIChjb24tPmZsYWdz ICYgKE5HX0wyQ0FQX0NPTl9BVVRPX0RJU0NPTl9USU1PfE5HX0wyQ0FQX0NPTl9MUF9USU1PKSkK KwkJcGFuaWMoCisiJXM6ICVzIC0gdGltZW91dCBwZW5kaW5nISBzdGF0ZT0lZCwgZmxhZ3M9JSN4 XG4iLAorCQkJX19mdW5jX18sICBOR19OT0RFX05BTUUoY29uLT5sMmNhcC0+bm9kZSksCisJCQlj b24tPnN0YXRlLCBjb24tPmZsYWdzKTsKKwogCUxJU1RfUkVNT1ZFKGNvbiwgbmV4dCk7Ci0JaWYg KGNvbi0+ZmxhZ3MgJiBOR19MMkNBUF9DT05fQVVUT19ESVNDT05fVElNTykKLQkJbmdfbDJjYXBf ZGlzY29uX3VudGltZW91dChjb24pOwotCWlmIChjb24tPmZsYWdzICYgTkdfTDJDQVBfQ09OX0xQ X1RJTU8pCi0JCW5nX2wyY2FwX2xwX3VudGltZW91dChjb24pOworCiAJYnplcm8oY29uLCBzaXpl b2YoKmNvbikpOwogCUZSRUUoY29uLCBNX05FVEdSQVBIX0wyQ0FQKTsKIH0gLyogbmdfbDJjYXBf ZnJlZV9jb24gKi8KSW5kZXg6IHVzci5zYmluL2JsdWV0b290aC9sMmNvbnRyb2wvbDJjYXAuYwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy91c3Iuc2Jpbi9ibHVldG9vdGgvbDJj b250cm9sL2wyY2FwLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMwpkaWZmIC11IC1yMS4zIGwy Y2FwLmMKLS0tIHVzci5zYmluL2JsdWV0b290aC9sMmNvbnRyb2wvbDJjYXAuYwkxMiBPY3QgMjAw MyAyMjowNDoyMyAtMDAwMAkxLjMKKysrIHVzci5zYmluL2JsdWV0b290aC9sMmNvbnRyb2wvbDJj YXAuYwkyMiBBdWcgMjAwNSAxODo0MToxNCAtMDAwMApAQCAtMTU5LDcgKzE1OSw3IEBACiAJCWZw cmludGYoc3Rkb3V0LAogCQkJIiUtMTcuMTdzICIgXAogCQkJIiU2ZCAiIFwKLQkJCSIlYyVjJWMl YyVjICIgXAorCQkJIiVjJWMlYyVjJWMlYyAiIFwKIAkJCSIlN2QgIiBcCiAJCQkiJXNcbiIsCiAJ CQliZGFkZHJwcigmci5jb25uZWN0aW9uc1tuXS5yZW1vdGUpLApAQCAtMTY3LDYgKzE2Nyw3IEBA CiAJCQkoKHIuY29ubmVjdGlvbnNbbl0uZmxhZ3MgJiBOR19MMkNBUF9DT05fT1VUR09JTkcpPyAn TycgOiAnSScpLAogCQkJKChyLmNvbm5lY3Rpb25zW25dLmZsYWdzICYgTkdfTDJDQVBfQ09OX0xQ X1RJTU8pPyAnTCcgOiAnICcpLAogCQkJKChyLmNvbm5lY3Rpb25zW25dLmZsYWdzICYgTkdfTDJD QVBfQ09OX0FVVE9fRElTQ09OX1RJTU8pPyAnRCcgOiAnICcpLAorCQkJKChyLmNvbm5lY3Rpb25z W25dLmZsYWdzICYgTkdfTDJDQVBfQ09OX0RZSU5HKT8gJyEnIDogJyAnKSwKIAkJCSgoci5jb25u ZWN0aW9uc1tuXS5mbGFncyAmIE5HX0wyQ0FQX0NPTl9UWCk/ICdUJyA6ICcgJyksCiAJCQkoKHIu Y29ubmVjdGlvbnNbbl0uZmxhZ3MgJiBOR19MMkNBUF9DT05fUlgpPyAnUicgOiAnICcpLAogCQkJ ci5jb25uZWN0aW9uc1tuXS5wZW5kaW5nLAo= ------=_Part_5997_19668216.1124737041544--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c7050822115738da118c>