From owner-cvs-src@FreeBSD.ORG Sun Jul 30 00:29:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D771016A4DF; Sun, 30 Jul 2006 00:29:01 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FAFB43D46; Sun, 30 Jul 2006 00:29:01 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6U0T1kn072960; Sun, 30 Jul 2006 00:29:01 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6U0T1cj072959; Sun, 30 Jul 2006 00:29:01 GMT (envelope-from kientzle) Message-Id: <200607300029.k6U0T1cj072959@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 30 Jul 2006 00:29:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive.h.in archive_private.h archive_read.c archive_read_open_fd.c archive_read_open_file.c archive_read_support_compression_bzip2.c archive_read_support_compression_compress.c archive_read_support_compression_gzip.c archive_read_support_compression_none.c archive_read_support_format_tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 00:29:01 -0000 kientzle 2006-07-30 00:29:01 UTC FreeBSD src repository Modified files: lib/libarchive archive.h.in archive_private.h archive_read.c archive_read_open_fd.c archive_read_open_file.c archive_read_support_compression_bzip2.c archive_read_support_compression_compress.c archive_read_support_compression_gzip.c archive_read_support_compression_none.c archive_read_support_format_tar.c Log: Use 'skip' when ignoring data in tar archives. This dramatically increases performance when extracting a single entry from a large uncompressed archive, especially on slow devices such as USB hard drives. Requires a number of changes: * New archive_read_open2() supports a 'skip' client function * Old archive_read_open() is implemented as a wrapper now, to continue supporting the old API/ABI. * _read_open_fd and _read_open_file sprout new 'skip' functions. * compression layer gets a new 'skip' operation. * compression_none passes skip requests through to client. * compression_{gzip,bzip2,compress} simply ignore skip requests. Thanks to: Benjamin Lutz, who designed and implemented the whole thing. I'm just committing it. ;-) TODO: Need to update the documentation a little bit. Revision Changes Path 1.30 +10 -3 src/lib/libarchive/archive.h.in 1.22 +2 -0 src/lib/libarchive/archive_private.h 1.21 +15 -0 src/lib/libarchive/archive_read.c 1.6 +45 -3 src/lib/libarchive/archive_read_open_fd.c 1.10 +47 -2 src/lib/libarchive/archive_read_open_file.c 1.9 +1 -0 src/lib/libarchive/archive_read_support_compression_bzip2.c 1.5 +1 -0 src/lib/libarchive/archive_read_support_compression_compress.c 1.10 +1 -0 src/lib/libarchive/archive_read_support_compression_gzip.c 1.7 +72 -0 src/lib/libarchive/archive_read_support_compression_none.c 1.42 +46 -1 src/lib/libarchive/archive_read_support_format_tar.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:11:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E10D916A4DA; Sun, 30 Jul 2006 06:11:43 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D89943D45; Sun, 30 Jul 2006 06:11:43 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6U6Bh48014531; Sun, 30 Jul 2006 06:11:43 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6U6Bh6f014530; Sun, 30 Jul 2006 06:11:43 GMT (envelope-from ume) Message-Id: <200607300611.k6U6Bh6f014530@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Sun, 30 Jul 2006 06:11:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/net getaddrinfo.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:11:44 -0000 ume 2006-07-30 06:11:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/net getaddrinfo.c Log: MFC 1.85: do not overload the port number on to the return value of str2number(). this could result in an unexpected code path. Revision Changes Path 1.69.2.9 +9 -8 src/lib/libc/net/getaddrinfo.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:30:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 176F316A4E1; Sun, 30 Jul 2006 06:30:03 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4C6043D45; Sun, 30 Jul 2006 06:30:02 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6U6U22a015578; Sun, 30 Jul 2006 06:30:02 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6U6U2Qt015577; Sun, 30 Jul 2006 06:30:02 GMT (envelope-from kientzle) Message-Id: <200607300630.k6U6U2Qt015577@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 30 Jul 2006 06:30:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libarchive COPYING INSTALL Makefile Makefile.am archive.h.in archive_entry.3 archive_entry.c archive_entry.h archive_platform.h archive_private.h archive_read.3 archive_read.c archive_read_data_into_fd.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:30:03 -0000 kientzle 2006-07-30 06:30:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libarchive COPYING Makefile archive.h.in archive_entry.3 archive_entry.c archive_entry.h archive_platform.h archive_private.h archive_read.3 archive_read.c archive_read_data_into_fd.c archive_read_extract.c archive_read_open_fd.c archive_read_open_file.c archive_read_support_compression_bzip2.c archive_read_support_compression_compress.c archive_read_support_format_cpio.c archive_read_support_format_iso9660.c archive_read_support_format_tar.c archive_read_support_format_zip.c archive_util.3 archive_util.c archive_write.3 archive_write.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_ustar.c libarchive-formats.5 tar.5 Removed files: (Branch: RELENG_6) lib/libarchive INSTALL Makefile.am configure.ac.in Log: MFC libarchive 1.2.53 to FreeBSD 6. * Fixes bin/86690 (sparse file extraction) * Fixes bin/87911 (assertion failure after failed open) * Corrects handling of very old files (negative mtime) * Better error checking for memory allocation failures * Style and portability fixes * Documentation corrections * Initial extended attribute support Revision Changes Path 1.1.8.1 +1 -1 src/lib/libarchive/COPYING 1.1.8.1 +0 -39 src/lib/libarchive/INSTALL (dead) 1.36.2.2 +31 -53 src/lib/libarchive/Makefile 1.3.2.1 +0 -62 src/lib/libarchive/Makefile.am (dead) 1.23.2.1 +18 -5 src/lib/libarchive/archive.h.in 1.9.8.2 +4 -4 src/lib/libarchive/archive_entry.3 1.29.2.1 +185 -4 src/lib/libarchive/archive_entry.c 1.16.2.1 +24 -2 src/lib/libarchive/archive_entry.h 1.16.2.1 +7 -5 src/lib/libarchive/archive_platform.h 1.18.2.1 +2 -4 src/lib/libarchive/archive_private.h 1.20.2.2 +2 -2 src/lib/libarchive/archive_read.3 1.15.2.1 +62 -29 src/lib/libarchive/archive_read.c 1.8.2.1 +6 -3 src/lib/libarchive/archive_read_data_into_fd.c 1.41.2.2 +118 -21 src/lib/libarchive/archive_read_extract.c 1.3.8.1 +7 -0 src/lib/libarchive/archive_read_open_fd.c 1.8.2.1 +4 -0 src/lib/libarchive/archive_read_open_file.c 1.7.2.1 +1 -1 src/lib/libarchive/archive_read_support_compression_bzip2.c 1.3.2.1 +17 -9 src/lib/libarchive/archive_read_support_compression_compress.c 1.13.2.1 +29 -7 src/lib/libarchive/archive_read_support_format_cpio.c 1.8.2.1 +72 -12 src/lib/libarchive/archive_read_support_format_iso9660.c 1.32.2.1 +330 -78 src/lib/libarchive/archive_read_support_format_tar.c 1.5.2.1 +6 -2 src/lib/libarchive/archive_read_support_format_zip.c 1.3.2.1 +1 -1 src/lib/libarchive/archive_util.3 1.9.2.1 +1 -1 src/lib/libarchive/archive_util.c 1.12.2.1 +7 -7 src/lib/libarchive/archive_write.3 1.15.2.1 +1 -1 src/lib/libarchive/archive_write.c 1.5.2.1 +1 -1 src/lib/libarchive/archive_write_set_format_cpio.c 1.27.2.1 +252 -57 src/lib/libarchive/archive_write_set_format_pax.c 1.12.2.1 +8 -1 src/lib/libarchive/archive_write_set_format_ustar.c 1.6.2.1 +0 -87 src/lib/libarchive/configure.ac.in (dead) 1.7.2.1 +6 -5 src/lib/libarchive/libarchive-formats.5 1.12.2.1 +20 -6 src/lib/libarchive/tar.5 From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:32:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7654916A4DF; Sun, 30 Jul 2006 06:32:15 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19BB743D53; Sun, 30 Jul 2006 06:32:15 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6U6WEJH015843; Sun, 30 Jul 2006 06:32:14 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6U6WEXX015842; Sun, 30 Jul 2006 06:32:14 GMT (envelope-from kientzle) Message-Id: <200607300632.k6U6WEXX015842@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 30 Jul 2006 06:32:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar Makefile Makefile.am bsdtar.1 bsdtar.c bsdtar.h bsdtar_platform.h configure.ac.in getdate.y read.c tree.c util.c write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:32:15 -0000 kientzle 2006-07-30 06:32:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar Makefile bsdtar.1 bsdtar.c bsdtar.h bsdtar_platform.h getdate.y read.c tree.c util.c write.c Removed files: (Branch: RELENG_6) usr.bin/tar Makefile.am configure.ac.in Log: MFC bsdtar 1.2.53 to FreeBSD 6: * Fixes bin/87911 (internal error attempting -u with empty file) * Fixes bin/84993 (warnings with GCC 4.1) * Fixes bin/95175 (core dump on nonexistent symlink) * Documentation fixes * Corrections to pathname matching * Portability fixes * Initial extended attribute support Revision Changes Path 1.24.2.1 +2 -36 src/usr.bin/tar/Makefile 1.3.2.1 +0 -21 src/usr.bin/tar/Makefile.am (dead) 1.29.2.2 +5 -5 src/usr.bin/tar/bsdtar.1 1.63.2.3 +3 -7 src/usr.bin/tar/bsdtar.c 1.23.2.1 +1 -1 src/usr.bin/tar/bsdtar.h 1.15.2.2 +14 -4 src/usr.bin/tar/bsdtar_platform.h 1.9.2.1 +0 -117 src/usr.bin/tar/configure.ac.in (dead) 1.4.2.1 +4 -1 src/usr.bin/tar/getdate.y 1.23.2.1 +1 -3 src/usr.bin/tar/read.c 1.2.2.1 +3 -2 src/usr.bin/tar/tree.c 1.13.2.1 +0 -1 src/usr.bin/tar/util.c 1.41.2.1 +149 -29 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:47:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53D7A16A4DA; Sun, 30 Jul 2006 06:47:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D907443D45; Sun, 30 Jul 2006 06:47:34 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k6U6jXqW096601; Sun, 30 Jul 2006 00:45:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 30 Jul 2006 00:45:52 -0600 (MDT) Message-Id: <20060730.004552.1723235428.imp@bsdimp.com> To: marcel@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <200607291838.k6TIctG4032258@repoman.freebsd.org> References: <200607291838.k6TIctG4032258@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 30 Jul 2006 00:45:34 -0600 (MDT) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/conf NOTES src/sys/conf NOTES files files.amd64 files.i386 files.pc98 options options.amd64 options.i386 options.pc98 src/sys/i386/conf NOTES src/sys/ia64/conf NOTES src/sys/pc98/conf NOTES ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:47:35 -0000 In message: <200607291838.k6TIctG4032258@repoman.freebsd.org> Marcel Moolenaar writes: : sio(4) is usable on less than half the platforms, not counting : a future mips platform. Its presence in MI files is therefore : increasingly becoming a burden. I disagree. There's no need to remove it from the files* like you've done. It is not a burdon there. Please revert this part of the change. We have dozens of other drivers in the MI conf/files that work on only a couple of platforms. Warner From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:47:52 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 863E516A4E1 for ; Sun, 30 Jul 2006 06:47:52 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1ED0443D49 for ; Sun, 30 Jul 2006 06:47:50 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so66407nzn for ; Sat, 29 Jul 2006 23:47:49 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=koc72UN9rtmNN6sttYE0BLH4Ctz/Bil0ESCm1pOVKPoTNhmTXJgZb9ZLtH5Ep9XMr32U4skjbQDfLh+S+uQ/zynXMs1GK0Suo53oRyX1seiLG6hhTO6xl5pJAoaZXrXLp/z67HwTVJBEEAYEX+P2qHx3Iq7admAcVrtCYc7I/OY= Received: by 10.65.114.11 with SMTP id r11mr1606767qbm; Sat, 29 Jul 2006 23:47:49 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 14sm3285022nzp.2006.07.29.23.47.46; Sat, 29 Jul 2006 23:47:49 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k6U6m8eO032986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 30 Jul 2006 15:48:08 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k6U6m75S032985; Sun, 30 Jul 2006 15:48:07 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sun, 30 Jul 2006 15:48:07 +0900 From: Pyun YongHyeon To: Yar Tikhiy Message-ID: <20060730064807.GA32731@cdnetworks.co.kr> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729205009.GA37970@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060729205009.GA37970@freefall.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:47:52 -0000 On Sat, Jul 29, 2006 at 08:50:09PM +0000, Yar Tikhiy wrote: > On Thu, Jul 27, 2006 at 12:43:34AM +0000, Pyun YongHyeon wrote: > > yongari 2006-07-27 00:43:34 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > > Log: > > Prepending an mbuf after loading a DMA map results in unexpected > > result. So, modify mbuf chains before loading a DMA map. > > > > Revision Changes Path > > 1.122 +28 -31 src/sys/dev/em/if_em.c > > Thanks a lot! Do you think this can fix kern/72933? > I can't sure it helps as the submitter reported the same issue on bge(4). Btw, I think the VLAN fixup code should use m_prepend(9) insatead of M_PREEND(9) because we don't know whether a new mbuf is allocated or not after M_PREPEND(9) call. -- Regards, Pyun YongHyeon From owner-cvs-src@FreeBSD.ORG Sun Jul 30 06:48:41 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 30F6A16A4DE for ; Sun, 30 Jul 2006 06:48:41 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86F1143D55 for ; Sun, 30 Jul 2006 06:48:39 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so66431nzn for ; Sat, 29 Jul 2006 23:48:39 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Xl/9jdqi+uY+a6Y9t1x26jyye6219QYXsQdX/FNc9/UhyWTr5mEPHB+wZFPf9ZwIgsy69pej9N2TYGYCRV5NS2Jo7PGwuXC7Ns9fNnZVeC5QExHypQlSOkhThBmh7HVtU6At9AJaqqI4rDZHvzH+8/xJHYjbyOS1SNzLBpJHg94= Received: by 10.65.232.18 with SMTP id j18mr1616517qbr; Sat, 29 Jul 2006 23:48:38 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id i5sm634418nzi.2006.07.29.23.48.36; Sat, 29 Jul 2006 23:48:38 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k6U6mxCn033000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 30 Jul 2006 15:48:59 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k6U6mwML032999; Sun, 30 Jul 2006 15:48:58 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sun, 30 Jul 2006 15:48:58 +0900 From: Pyun YongHyeon To: John Birrell Message-ID: <20060730064858.GB32731@cdnetworks.co.kr> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729220154.GA23870@what-creek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060729220154.GA23870@what-creek.com> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 06:48:41 -0000 On Sat, Jul 29, 2006 at 10:01:54PM +0000, John Birrell wrote: > On Thu, Jul 27, 2006 at 12:43:34AM +0000, Pyun YongHyeon wrote: > > yongari 2006-07-27 00:43:34 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > > Log: > > Prepending an mbuf after loading a DMA map results in unexpected > > result. So, modify mbuf chains before loading a DMA map. > > > > Revision Changes Path > > 1.122 +28 -31 src/sys/dev/em/if_em.c > > The change immediately after the one that I tested on sun4v brought the > bus_dmamap_unload diagnostics back (worse than before). So much so, > I had to back the change out of my P4 tree. > > This is the change that causes the grief: > > > That's odd. Do you use VLAN with hardware tagging and the interface is in promiscuous mode? Would you should me the diagnostics trace again? -- Regards, Pyun YongHyeon From owner-cvs-src@FreeBSD.ORG Sun Jul 30 07:02:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37E2216A589; Sun, 30 Jul 2006 07:02:41 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD34E43D45; Sun, 30 Jul 2006 07:02:40 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id 125F678C1F; Sun, 30 Jul 2006 07:02:37 +0000 (GMT) Date: Sun, 30 Jul 2006 07:02:37 +0000 From: John Birrell To: Pyun YongHyeon Message-ID: <20060730070237.GA26661@what-creek.com> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729220154.GA23870@what-creek.com> <20060730064858.GB32731@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060730064858.GB32731@cdnetworks.co.kr> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 07:02:41 -0000 On Sun, Jul 30, 2006 at 03:48:58PM +0900, Pyun YongHyeon wrote: > That's odd. Do you use VLAN with hardware tagging and the interface > is in promiscuous mode? No. > Would you should me the diagnostics trace again? That will have to wait until another problem with sun4v is solved. -- John Birrell From owner-cvs-src@FreeBSD.ORG Sun Jul 30 07:14:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72DD816A4DD; Sun, 30 Jul 2006 07:14:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05D5743D45; Sun, 30 Jul 2006 07:14:27 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k6U7D9k1097008; Sun, 30 Jul 2006 01:13:10 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 30 Jul 2006 01:13:29 -0600 (MDT) Message-Id: <20060730.011329.-490997054.imp@bsdimp.com> To: marcel@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <200607291838.k6TIctG4032258@repoman.freebsd.org> References: <200607291838.k6TIctG4032258@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 30 Jul 2006 01:13:10 -0600 (MDT) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/amd64/conf NOTES src/sys/conf NOTES files files.amd64 files.i386 files.pc98 options options.amd64 options.i386 options.pc98 src/sys/i386/conf NOTES src/sys/ia64/conf NOTES src/sys/pc98/conf NOTES ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 07:14:28 -0000 In message: <200607291838.k6TIctG4032258@repoman.freebsd.org> Marcel Moolenaar writes: : sio(4) is usable on less than half the platforms, not counting : a future mips platform. Its presence in MI files is therefore : increasingly becoming a burden. On second thought, I guess I don't care enough to put up any kind of stink. Forget I said anything. Instead of arguing over this, I'm going to try to make these sorts of issues moot. The build system for the kernel is showing its age and it is time for a revolution. No sense planning one of those and quibbling over the old world order at the same time :-) Warner From owner-cvs-src@FreeBSD.ORG Sun Jul 30 07:41:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADFBC16A4DA; Sun, 30 Jul 2006 07:41:29 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A55E43D45; Sun, 30 Jul 2006 07:41:29 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6U7fTDb020391; Sun, 30 Jul 2006 07:41:29 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6U7fTjj020390; Sun, 30 Jul 2006 07:41:29 GMT (envelope-from maxim) Message-Id: <200607300741.k6U7fTjj020390@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 30 Jul 2006 07:41:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/rev rev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 07:41:29 -0000 maxim 2006-07-30 07:41:28 UTC FreeBSD src repository Modified files: usr.bin/rev rev.c Log: o Kill unneeded assignment. Obtained from: OpenBSD Revision Changes Path 1.9 +0 -1 src/usr.bin/rev/rev.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 09:51:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 496FA16A4DA; Sun, 30 Jul 2006 09:51:00 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A540643D68; Sun, 30 Jul 2006 09:50:58 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6U9otAm036634; Sun, 30 Jul 2006 13:50:55 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6U9ottF036633; Sun, 30 Jul 2006 13:50:55 +0400 (MSD) (envelope-from yar) Date: Sun, 30 Jul 2006 13:50:55 +0400 From: Yar Tikhiy To: Pyun YongHyeon Message-ID: <20060730095054.GA36267@comp.chem.msu.su> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729205009.GA37970@freefall.freebsd.org> <20060730064807.GA32731@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060730064807.GA32731@cdnetworks.co.kr> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 09:51:00 -0000 On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > On Sat, Jul 29, 2006 at 08:50:09PM +0000, Yar Tikhiy wrote: > > On Thu, Jul 27, 2006 at 12:43:34AM +0000, Pyun YongHyeon wrote: > > > yongari 2006-07-27 00:43:34 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/em if_em.c > > > Log: > > > Prepending an mbuf after loading a DMA map results in unexpected > > > result. So, modify mbuf chains before loading a DMA map. > > > > > > Revision Changes Path > > > 1.122 +28 -31 src/sys/dev/em/if_em.c > > > > Thanks a lot! Do you think this can fix kern/72933? > > > > I can't sure it helps as the submitter reported the same issue > on bge(4). Sorry, my question wasn't accurate. I believe that the original PR in fact described a different issue with similar symptoms; it was fixed quite a while ago. Then Lev Shamardin posted a follow-up that he was still seeing the symptoms with em(4), which we (Gleb Smirnoff and yours truly) couldn't fully understand because we were missing the peculiarities of the interaction between DMA and mbufs you're so well aware of. > Btw, I think the VLAN fixup code should use m_prepend(9) > insatead of M_PREEND(9) because we don't know whether a new mbuf > is allocated or not after M_PREPEND(9) call. If a new mbuf should be allocated to satisfy DMA, m_prepend(9) is the function to use. M_PREPEND(9) can use the free space at the beginning of the mbuf's data area if there is enough of it. I'm unsure though whether we really need a new mbuf there. em_encap() gets just a mbuf chain, which can be tweaked a little before starting the DMA magic on it. -- Yar From owner-cvs-src@FreeBSD.ORG Sun Jul 30 12:54:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A154C16A4DF; Sun, 30 Jul 2006 12:54:37 +0000 (UTC) (envelope-from mckay@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C9AC43D45; Sun, 30 Jul 2006 12:54:37 +0000 (GMT) (envelope-from mckay@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UCsbOF056670; Sun, 30 Jul 2006 12:54:37 GMT (envelope-from mckay@repoman.freebsd.org) Received: (from mckay@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UCsbiY056669; Sun, 30 Jul 2006 12:54:37 GMT (envelope-from mckay) Message-Id: <200607301254.k6UCsbiY056669@repoman.freebsd.org> From: Stephen McKay Date: Sun, 30 Jul 2006 12:54:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d kernel X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 12:54:37 -0000 mckay 2006-07-30 12:54:37 UTC FreeBSD src repository Modified files: etc/rc.d kernel Log: This script should probably have an enabling variable since it can produce surprising results. For now, at least make it safe to boot the default kernel when /boot/kernel is already a symlink. Revision Changes Path 1.2 +4 -2 src/etc/rc.d/kernel From owner-cvs-src@FreeBSD.ORG Sun Jul 30 14:03:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AC8616A4E1; Sun, 30 Jul 2006 14:03:05 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EDD743D45; Sun, 30 Jul 2006 14:03:03 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UE33N1062734; Sun, 30 Jul 2006 14:03:03 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UE33gf062728; Sun, 30 Jul 2006 14:03:03 GMT (envelope-from simon) Message-Id: <200607301403.k6UE33gf062728@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 30 Jul 2006 14:03:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/crypto/openssl/crypto/engine eng_padlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 14:03:05 -0000 simon 2006-07-30 14:03:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) crypto/openssl/crypto/engine eng_padlock.c Log: Fix a bug in the padlock engine when handling small data blocks. This could cause problem e.g. when using OpenVPN. This is a direct commit to RELENG_6 since the issue was fixed by the OpenSSL 0.9.8b import in -CURRENT. PR: bin/86598 Submitted by: Mike Tancsa Tested by: Mike Tancsa, pjd Obtained from: OpenSSL CVS (eng_padlock.c 1.12 -> 1.13 diff) Revision Changes Path 1.2.8.1 +3 -3 src/crypto/openssl/crypto/engine/eng_padlock.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 14:17:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA93816A4DF; Sun, 30 Jul 2006 14:17:54 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F3E243D45; Sun, 30 Jul 2006 14:17:54 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UEHs5M063714; Sun, 30 Jul 2006 14:17:54 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UEHsSl063713; Sun, 30 Jul 2006 14:17:54 GMT (envelope-from simon) Message-Id: <200607301417.k6UEHsSl063713@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 30 Jul 2006 14:17:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/crypto/openssl/crypto/engine eng_padlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 14:17:54 -0000 simon 2006-07-30 14:17:54 UTC FreeBSD src repository Modified files: crypto/openssl/crypto/engine eng_padlock.c Log: Resolve conflicts after import of OpenSSL 0.9.8b. This was missed the first time around since eng_padlock.c was not part of OpenSSL 0.9.7e and therefor did not have the v0_9_7e CVS tag used during original resolve of conflicts. Noticed by: Antoine Brodin Revision Changes Path 1.3 +215 -53 src/crypto/openssl/crypto/engine/eng_padlock.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 18:33:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 871DC16A4DF; Sun, 30 Jul 2006 18:33:21 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4548343D49; Sun, 30 Jul 2006 18:33:21 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UIXLBM094270; Sun, 30 Jul 2006 18:33:21 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UIXLqD094269; Sun, 30 Jul 2006 18:33:21 GMT (envelope-from kientzle) Message-Id: <200607301833.k6UIXLqD094269@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 30 Jul 2006 18:33:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_read_support_format_cpio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 18:33:21 -0000 kientzle 2006-07-30 18:33:21 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_cpio.c Log: Conditionally include sys/mkdev.h on platforms (such as Solaris) that need it. Thanks to: VMiklos Revision Changes Path 1.18 +3 -0 src/lib/libarchive/archive_read_support_format_cpio.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 18:34:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0E1616A4DD; Sun, 30 Jul 2006 18:34:40 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70F2643D45; Sun, 30 Jul 2006 18:34:40 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UIYekE094346; Sun, 30 Jul 2006 18:34:40 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UIYemL094345; Sun, 30 Jul 2006 18:34:40 GMT (envelope-from kientzle) Message-Id: <200607301834.k6UIYemL094345@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 30 Jul 2006 18:34:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/tar read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 18:34:40 -0000 kientzle 2006-07-30 18:34:40 UTC FreeBSD src repository Modified files: usr.bin/tar read.c Log: Conditionally include sys/mkdev.h on platforms (such as Solaris) that need it. While I'm here, correctly alphabetize 't' after 's'. Thanks to: VMiklos Revision Changes Path 1.26 +4 -1 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 19:29:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D67E016A4DD; Sun, 30 Jul 2006 19:29:26 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9635D43D45; Sun, 30 Jul 2006 19:29:26 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UJTQqn098063; Sun, 30 Jul 2006 19:29:26 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UJTQ3x098062; Sun, 30 Jul 2006 19:29:26 GMT (envelope-from simon) Message-Id: <200607301929.k6UJTQ3x098062@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 30 Jul 2006 19:29:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libmp mpasbn.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 19:29:26 -0000 simon 2006-07-30 19:29:26 UTC FreeBSD src repository Modified files: lib/libmp mpasbn.c Log: Pass BN_CTX to internal functions instead of allocating it internally. This allows msqrt() to only call BN_CTX_new() once intead of many times. Suggested and reviewed by: stefanf Revision Changes Path 1.5 +35 -27 src/lib/libmp/mpasbn.c From owner-cvs-src@FreeBSD.ORG Sun Jul 30 19:32:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADA9516A4DA; Sun, 30 Jul 2006 19:32:52 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C56343D46; Sun, 30 Jul 2006 19:32:52 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UJWq8P098351; Sun, 30 Jul 2006 19:32:52 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UJWq0W098350; Sun, 30 Jul 2006 19:32:52 GMT (envelope-from simon) Message-Id: <200607301932.k6UJWq0W098350@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sun, 30 Jul 2006 19:32:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/tools/tools/nanobsd FlashDevice.sub X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 19:32:52 -0000 simon 2006-07-30 19:32:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) tools/tools/nanobsd FlashDevice.sub Log: MFC 1.7: Add Memory Corp 512MB CF Flash. Revision Changes Path 1.1.2.5 +15 -0 src/tools/tools/nanobsd/FlashDevice.sub From owner-cvs-src@FreeBSD.ORG Sun Jul 30 20:51:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DF1616A4DA; Sun, 30 Jul 2006 20:51:42 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D215343D46; Sun, 30 Jul 2006 20:51:41 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UKpfPb011189; Sun, 30 Jul 2006 20:51:41 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UKpfNU011188; Sun, 30 Jul 2006 20:51:41 GMT (envelope-from marcel) Message-Id: <200607302051.k6UKpfNU011188@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 30 Jul 2006 20:51:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 20:51:42 -0000 marcel 2006-07-30 20:51:41 UTC FreeBSD src repository Modified files: usr.sbin/kldxref Makefile Log: Use NO_SHARED=YES to force a static link. Pointed out by: ru@ Revision Changes Path 1.9 +1 -1 src/usr.sbin/kldxref/Makefile From owner-cvs-src@FreeBSD.ORG Sun Jul 30 23:25:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1C3A16A506; Sun, 30 Jul 2006 23:25:28 +0000 (UTC) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38B1E43D7E; Sun, 30 Jul 2006 23:25:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UNPLB2023549; Sun, 30 Jul 2006 23:25:21 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UNPLvw023548; Sun, 30 Jul 2006 23:25:21 GMT (envelope-from wpaul) Message-Id: <200607302325.k6UNPLvw023548@repoman.freebsd.org> From: Bill Paul Date: Sun, 30 Jul 2006 23:25:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 23:25:28 -0000 wpaul 2006-07-30 23:25:21 UTC FreeBSD src repository Modified files: sys/pci if_rlreg.h sys/dev/re if_re.c Log: Fix the following bugs in re(4) - Correct the PCI ID for the 8169SC/8110SC in the device list (I added the macro for it to if_rlreg.h before, but forgot to use it.) - Remove the extra interrupt spinlock I added previously. After giving it some more thought, it's not really needed. - Work around a hardware bug in some versions of the 8169. When sending very small IP datagrams with checksum offload enabled, a conflict can occur between the TX autopadding feature and the hardware checksumming that can corrupt the outbound packet. This is the reason that checksum offload sometimes breaks NFS: if you're using NFS over UDP, and you're very unlucky, you might find yourself doing a fragmented NFS write where the last fragment is smaller than the minimum ethernet frame size (60 bytes). (It's rare, but if you keep NFS running long enough it'll happen.) If checksum offload is enabled, the chip will have to both autopad the fragment and calculate its checksum header. This confuses some revs of the 8169, causing the packet that appears on the wire to be corrupted. (The IP addresses and the checksum field are mangled.) This will cause the NFS write to fail. Unfortunately, when NFS retries, it sends the same write request over and over again, and it keeps failing, so NFS stays wedged. (A simple way to provoke the failure is to connect the failing system to a network with a known good machine and do "ping -s 1473 " from the good system. The ping will fail.) Someone had previously worked around this using the heavy-handed approahch of just disabling checksum offload. The correct fix is to manually pad short frames where the TCP/IP stack has requested checksum offloading. This allows us to have checksum offload turned on by default but still let NFS work right. - Not a bug, but change the ID strings for devices with hardware rev 0x30000000 and 0x38000000 to both be 8168B/8111B. According to RealTek, they're both the same device, but 0x30000000 is an earlier silicon spin. Revision Changes Path 1.70 +32 -21 src/sys/dev/re/if_re.c 1.59 +19 -19 src/sys/pci/if_rlreg.h From owner-cvs-src@FreeBSD.ORG Sun Jul 30 23:32:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66C3E16A4DD; Sun, 30 Jul 2006 23:32:21 +0000 (UTC) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19F3A43D69; Sun, 30 Jul 2006 23:32:21 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6UNWK2q023996; Sun, 30 Jul 2006 23:32:20 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6UNWKON023995; Sun, 30 Jul 2006 23:32:20 GMT (envelope-from wpaul) Message-Id: <200607302332.k6UNWKON023995@repoman.freebsd.org> From: Bill Paul Date: Sun, 30 Jul 2006 23:32:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jul 2006 23:32:21 -0000 wpaul 2006-07-30 23:32:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_rlreg.h sys/dev/re if_re.c Log: MFC: correct PCI ID for 8169SC/8110SC, remove spinlock, work around checksum offload bugs, correct device descriptions Revision Changes Path 1.46.2.17 +32 -21 src/sys/dev/re/if_re.c 1.51.2.6 +19 -19 src/sys/pci/if_rlreg.h From owner-cvs-src@FreeBSD.ORG Mon Jul 31 01:27:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E678616A4DA; Mon, 31 Jul 2006 01:27:16 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1CC243D49; Mon, 31 Jul 2006 01:27:16 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6V1RGHQ039757; Mon, 31 Jul 2006 01:27:16 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6V1RGh2039756; Mon, 31 Jul 2006 01:27:16 GMT (envelope-from marcel) Message-Id: <200607310127.k6V1RGh2039756@repoman.freebsd.org> From: Marcel Moolenaar Date: Mon, 31 Jul 2006 01:27:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware/ia64 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 01:27:17 -0000 marcel 2006-07-31 01:27:16 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/hardware/ia64 Makefile Log: Add proc-ia64.sgml to SRCS (uncomment). Revision Changes Path 1.4 +1 -1 src/release/doc/en_US.ISO8859-1/hardware/ia64/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 31 01:32:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64E5016A4E2; Mon, 31 Jul 2006 01:32:31 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A231243D46; Mon, 31 Jul 2006 01:32:30 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6V1WUN4040265; Mon, 31 Jul 2006 01:32:30 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6V1WUbx040264; Mon, 31 Jul 2006 01:32:30 GMT (envelope-from marcel) Message-Id: <200607310132.k6V1WUbx040264@repoman.freebsd.org> From: Marcel Moolenaar Date: Mon, 31 Jul 2006 01:32:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware Makefile src/release/doc/en_US.ISO8859-1/hardware/common hw.ent src/release/doc/en_US.ISO8859-1/hardware/powerpc Makefile article.sgml proc-powerpc.sgml src/release/doc/en_US.ISO8859-1/installation Makefile src/release/doc/en_US.ISO8859-1/installation/powerpc Makefile ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 01:32:31 -0000 marcel 2006-07-31 01:32:30 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/hardware Makefile release/doc/en_US.ISO8859-1/hardware/common hw.ent release/doc/en_US.ISO8859-1/installation Makefile release/doc/en_US.ISO8859-1/relnotes Makefile release/doc/share/examples Makefile.relnotesng Added files: release/doc/en_US.ISO8859-1/hardware/powerpc Makefile article.sgml proc-powerpc.sgml release/doc/en_US.ISO8859-1/installation/powerpc Makefile article.sgml release/doc/en_US.ISO8859-1/relnotes/powerpc Makefile article.sgml Log: Add the bones for PowerPC release documentation. This has been derived from ia64. Revision Changes Path 1.8 +1 -0 src/release/doc/en_US.ISO8859-1/hardware/Makefile 1.6 +1 -0 src/release/doc/en_US.ISO8859-1/hardware/common/hw.ent 1.1 +22 -0 src/release/doc/en_US.ISO8859-1/hardware/powerpc/Makefile (new) 1.1 +31 -0 src/release/doc/en_US.ISO8859-1/hardware/powerpc/article.sgml (new) 1.1 +9 -0 src/release/doc/en_US.ISO8859-1/hardware/powerpc/proc-powerpc.sgml (new) 1.8 +1 -0 src/release/doc/en_US.ISO8859-1/installation/Makefile 1.1 +20 -0 src/release/doc/en_US.ISO8859-1/installation/powerpc/Makefile (new) 1.1 +26 -0 src/release/doc/en_US.ISO8859-1/installation/powerpc/article.sgml (new) 1.8 +1 -0 src/release/doc/en_US.ISO8859-1/relnotes/Makefile 1.1 +18 -0 src/release/doc/en_US.ISO8859-1/relnotes/powerpc/Makefile (new) 1.1 +21 -0 src/release/doc/en_US.ISO8859-1/relnotes/powerpc/article.sgml (new) 1.13 +1 -1 src/release/doc/share/examples/Makefile.relnotesng From owner-cvs-src@FreeBSD.ORG Mon Jul 31 02:43:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2DD616A4E0 for ; Mon, 31 Jul 2006 02:43:32 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5118943DA5 for ; Mon, 31 Jul 2006 02:43:27 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so119875nzn for ; Sun, 30 Jul 2006 19:43:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=FSBOc/weoQxAd8bI64UWO/ys6M4FeoAmEkVniygsO2CZmLjqtb3KhnomNqv5DARZbPFA290PW2MbEBwPjog2xbXEGlD86Yh1XwM4lYPRRHT7HgFjYekYv96v7tFMspvgHJY9Yj1Zo8FCXNq8YsnbjF/1DskNHv0tKIEo6p8Jkek= Received: by 10.65.119.14 with SMTP id w14mr2693582qbm; Sun, 30 Jul 2006 19:43:27 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 15sm4318243nzp.2006.07.30.19.43.23; Sun, 30 Jul 2006 19:43:26 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k6V2hu6o036121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Jul 2006 11:43:56 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k6V2hsvU036120; Mon, 31 Jul 2006 11:43:54 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 31 Jul 2006 11:43:54 +0900 From: Pyun YongHyeon To: Yar Tikhiy Message-ID: <20060731024354.GA35573@cdnetworks.co.kr> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729205009.GA37970@freefall.freebsd.org> <20060730064807.GA32731@cdnetworks.co.kr> <20060730095054.GA36267@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060730095054.GA36267@comp.chem.msu.su> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 02:43:33 -0000 On Sun, Jul 30, 2006 at 01:50:55PM +0400, Yar Tikhiy wrote: > On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > > On Sat, Jul 29, 2006 at 08:50:09PM +0000, Yar Tikhiy wrote: > > > On Thu, Jul 27, 2006 at 12:43:34AM +0000, Pyun YongHyeon wrote: > > > > yongari 2006-07-27 00:43:34 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/em if_em.c > > > > Log: > > > > Prepending an mbuf after loading a DMA map results in unexpected > > > > result. So, modify mbuf chains before loading a DMA map. > > > > > > > > Revision Changes Path > > > > 1.122 +28 -31 src/sys/dev/em/if_em.c > > > > > > Thanks a lot! Do you think this can fix kern/72933? > > > > > > > I can't sure it helps as the submitter reported the same issue > > on bge(4). > > Sorry, my question wasn't accurate. I believe that the original > PR in fact described a different issue with similar symptoms; it > was fixed quite a while ago. Then Lev Shamardin posted a follow-up > that he was still seeing the symptoms with em(4), which we (Gleb > Smirnoff and yours truly) couldn't fully understand because we were > missing the peculiarities of the interaction between DMA and mbufs > you're so well aware of. > > > Btw, I think the VLAN fixup code should use m_prepend(9) > > insatead of M_PREEND(9) because we don't know whether a new mbuf > > is allocated or not after M_PREPEND(9) call. > > If a new mbuf should be allocated to satisfy DMA, m_prepend(9) is No, prepending a new mbuf with m_prepend(9) is not necessary for DMA to work. > the function to use. M_PREPEND(9) can use the free space at the > beginning of the mbuf's data area if there is enough of it. I'm > unsure though whether we really need a new mbuf there. em_encap() > gets just a mbuf chain, which can be tweaked a little before starting > the DMA magic on it. > Sorry, I'm confused. I've misread VLAN fixup code. From my limited testing, it seems that it works as expected. Previously em(4) may have failed VLAN tag insertion if M_PREPEND(9) added a new mbuf into existing mbuf chains. > -- > Yar -- Regards, Pyun YongHyeon From owner-cvs-src@FreeBSD.ORG Mon Jul 31 04:57:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E98C416A4DA; Mon, 31 Jul 2006 04:57:46 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A430243D49; Mon, 31 Jul 2006 04:57:46 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6V4vkaB071024; Mon, 31 Jul 2006 04:57:46 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6V4vkbE071023; Mon, 31 Jul 2006 04:57:46 GMT (envelope-from kientzle) Message-Id: <200607310457.k6V4vkbE071023@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 31 Jul 2006 04:57:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 04:57:47 -0000 kientzle 2006-07-31 04:57:46 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Remove two unused variables. Thanks to: Stefan Farfeleder Revision Changes Path 1.47 +0 -6 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 08:25:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A16F116A4DE; Mon, 31 Jul 2006 08:25:52 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B81143D5C; Mon, 31 Jul 2006 08:25:46 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6V8Pfwe047635; Mon, 31 Jul 2006 12:25:41 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6V8PeJh047633; Mon, 31 Jul 2006 12:25:40 +0400 (MSD) (envelope-from yar) Date: Mon, 31 Jul 2006 12:25:39 +0400 From: Yar Tikhiy To: Pyun YongHyeon Message-ID: <20060731082539.GD46403@comp.chem.msu.su> References: <200607270043.k6R0hY8g088353@repoman.freebsd.org> <20060729205009.GA37970@freefall.freebsd.org> <20060730064807.GA32731@cdnetworks.co.kr> <20060730095054.GA36267@comp.chem.msu.su> <20060731024354.GA35573@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060731024354.GA35573@cdnetworks.co.kr> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 08:25:52 -0000 On Mon, Jul 31, 2006 at 11:43:54AM +0900, Pyun YongHyeon wrote: > On Sun, Jul 30, 2006 at 01:50:55PM +0400, Yar Tikhiy wrote: > > On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > > > On Sat, Jul 29, 2006 at 08:50:09PM +0000, Yar Tikhiy wrote: > > > > On Thu, Jul 27, 2006 at 12:43:34AM +0000, Pyun YongHyeon wrote: > > > > > yongari 2006-07-27 00:43:34 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/dev/em if_em.c > > > > > Log: > > > > > Prepending an mbuf after loading a DMA map results in unexpected > > > > > result. So, modify mbuf chains before loading a DMA map. > > > > > > > > > > Revision Changes Path > > > > > 1.122 +28 -31 src/sys/dev/em/if_em.c > > > > > > > > Thanks a lot! Do you think this can fix kern/72933? > > > > > > > > > > I can't sure it helps as the submitter reported the same issue > > > on bge(4). > > > > Sorry, my question wasn't accurate. I believe that the original > > PR in fact described a different issue with similar symptoms; it > > was fixed quite a while ago. Then Lev Shamardin posted a follow-up > > that he was still seeing the symptoms with em(4), which we (Gleb > > Smirnoff and yours truly) couldn't fully understand because we were > > missing the peculiarities of the interaction between DMA and mbufs > > you're so well aware of. > > > > > Btw, I think the VLAN fixup code should use m_prepend(9) > > > insatead of M_PREEND(9) because we don't know whether a new mbuf > > > is allocated or not after M_PREPEND(9) call. > > > > If a new mbuf should be allocated to satisfy DMA, m_prepend(9) is > > No, prepending a new mbuf with m_prepend(9) is not necessary for DMA > to work. > > > the function to use. M_PREPEND(9) can use the free space at the > > beginning of the mbuf's data area if there is enough of it. I'm > > unsure though whether we really need a new mbuf there. em_encap() > > gets just a mbuf chain, which can be tweaked a little before starting > > the DMA magic on it. > > > > Sorry, I'm confused. I've misread VLAN fixup code. From my limited testing, > it seems that it works as expected. > Previously em(4) may have failed VLAN tag insertion if M_PREPEND(9) added > a new mbuf into existing mbuf chains. Your analysis sounds correct to me. Previously the data from the mbuf chain passed to em_encap() were "wired" to the DMA engine (mapped through bus_dmamap_load*) first, and a VLAN header was prepended then, which was plain wrong and worked sometimes by accident, no matter M_PREPEND or m_prepend was used. With the order of the things being correct now, we can keep using M_PREPEND for efficiency. In the routing case, there is a fair chance that the packet came from another VLAN and there is some free leading space in the first mbuf. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Jul 31 09:11:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B85816A4DD; Mon, 31 Jul 2006 09:11:09 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB04743D46; Mon, 31 Jul 2006 09:11:08 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id B60A1189049; Mon, 31 Jul 2006 19:11:07 +1000 (EST) Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k6V9B3bn021139; Mon, 31 Jul 2006 19:11:04 +1000 Date: Mon, 31 Jul 2006 19:11:02 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: Jung-uk Kim In-Reply-To: <200607251525.11623.jkim@FreeBSD.org> Message-ID: <20060731172935.O923@epsplex.bde.org> References: <200607252001.aa18647@salmon.maths.tcd.ie> <200607251525.11623.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, "Christian S.J. Peron" , cvs-all@FreeBSD.org, David Malone , Sam Leffler Subject: Re: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 09:11:09 -0000 On Tue, 25 Jul 2006, Jung-uk Kim wrote: > On Tuesday 25 July 2006 03:01 pm, David Malone wrote: >> >> It sounds to me like a reasonable thing to do would be to pass up >> a raw version of the timestamp (as returned by the hardware). We'd >> also pass up the regular microtime() timestamp. You can then do any >> postprocessing to syncronise timestamps later in userland? > > Nope. In that case, you actually need to export few more things, > i.e., current hardware timecounter value, clock frequency, size of > the timecounter, etc. Even then, it's going to be hard to get > correct timeval without exposing few kernel internals. Synchronization is so hard to do that it is not done even in the kernel where all the variables are directly accessible (modulo locking), even for cases that are much more important. E.g.: - synchronization of TSCs across CPUs. This might require IPIs so it might be very inefficient. If all CPUs are driven by the same hardware clock then they might stay in sync even when the clock is throttled. Then IPIs would not be needed and the synchronization problems reduce to the next one. Otherwise it is difficult to keep the TSCs perfectly in sync even with IPIs and the next problem might need to be solved anyway (to keep the TSCs in sync with something). - synchronization of TSCs (or other efficient but possibly unstable timecounters) with "higher" quality timecounters (ones that are inefficient but possibly more stable). Before timecounters or SMP or much CPU throttling, the i386 TSC was synced with the i8254 on every clock tick. This worked OK, but was missing recalibration of the TSC and smoothing of jumps at sync points, and with CPU throttling recalibration is necessary else the jumps could be very large and remain large. Now there is some synchronization of "cpu ticks" with the active timecounter. This is missing almost the opposite things -- it has recalibration and doesn't need smoothing of jumps only since it doesn't have the jumps necessary for synchronhization. - synchronization of timecounters with themselves. The get*time() functions are not properly synchronized with the non-get versions, although this breaks the "get" versions, because proper synchronization would be less efficent and/or complicated. Synchronization only occurs every few msec in tc_windup(), but this is not enough for proper synchronization. E.g., timestamps made using time_second (as most file systems do) can be more that 1 second in the past relative to the current time, since updates of time_second are normally delayed by several msec. Userland can see this bug using code like "now = time(NULL); utimes(file, NULL); stat(file, &sb); assert(sb.st_mtime >= now);" -- time(3) uses microtime(9) and correctly rounds to seconds, while utimes(2) normally uses time_second which is the current time incorrectly rounded to seconds. I used to fix this in the non-SMP case by syncing time_second and other offsets in every call to a non-get function, using hackish locking that only works in the non-SMP case. >>> Okay. But I am worried about timecounter <-> timeval conversion >>> because I want to know timeval delta from system time, not just >>> some timer value. To get the delta, you would have to read the system time (not using a "get" function) so things might be slower than just reading the system time for everything. I think only cases where the hardware writes timestamps using DMA are interesting (if the timestamps involve bus accesses then they are likely to be slower than ACPI-"fast" ones which are hundreds of times slower than TSC accesses on most systems). Then the timestamps would have been made a relatively long time in the past and you would prefer to know the system time at which they were made, but it is impossible to know that time precisely. It is only possible to compare with the current time. The comparision might not need to be very precise but it should avoid obvious bugs like the ones for file times: now = time(NULL); assert(now >= packettime.tv_sec); Hardware could easily make incoherent timestamps here and then the system shouldn't just blindly convert them into negative deltas, etc. Bruce From owner-cvs-src@FreeBSD.ORG Mon Jul 31 09:25:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7656916A4DA; Mon, 31 Jul 2006 09:25:21 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EB4743D53; Mon, 31 Jul 2006 09:25:21 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6V9PKYn001184; Mon, 31 Jul 2006 09:25:20 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6V9PKW1001183; Mon, 31 Jul 2006 09:25:20 GMT (envelope-from yar) Message-Id: <200607310925.k6V9PKW1001183@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 09:25:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/test test.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 09:25:21 -0000 yar 2006-07-31 09:25:20 UTC FreeBSD src repository Modified files: bin/test test.1 Log: Granting the amount of misunderstanding the last change received, extend it with an example to clarify the point. Revision Changes Path 1.25 +7 -1 src/bin/test/test.1 From owner-cvs-src@FreeBSD.ORG Mon Jul 31 11:32:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89F4616A4DE; Mon, 31 Jul 2006 11:32:13 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 474C843D49; Mon, 31 Jul 2006 11:32:13 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VBWDG6009667; Mon, 31 Jul 2006 11:32:13 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VBWD0i009666; Mon, 31 Jul 2006 11:32:13 GMT (envelope-from yar) Message-Id: <200607311132.k6VBWD0i009666@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 11:32:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh parser.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 11:32:13 -0000 yar 2006-07-31 11:32:13 UTC FreeBSD src repository Modified files: bin/sh parser.c Log: Do not forget to increment the input line counter when reading a word spanning multiple lines. PR: bin/101094 MFC after: 5 days Revision Changes Path 1.57 +1 -0 src/bin/sh/parser.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 12:41:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79F6216A4E0; Mon, 31 Jul 2006 12:41:14 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36F5743D49; Mon, 31 Jul 2006 12:41:14 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VCfEIF014165; Mon, 31 Jul 2006 12:41:14 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VCfEA7014164; Mon, 31 Jul 2006 12:41:14 GMT (envelope-from yar) Message-Id: <200607311241.k6VCfEA7014164@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 12:41:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/options makeman X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 12:41:14 -0000 yar 2006-07-31 12:41:13 UTC FreeBSD src repository Modified files: tools/build/options makeman Log: Actually skip over undocumented options with "continue" to avoid artifacts in the manpage generated. Previously an orphaned paragraph on dependencies of such an option would appear. Revision Changes Path 1.5 +1 -0 src/tools/build/options/makeman From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:08:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8097716A4DA; Mon, 31 Jul 2006 13:08:48 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B51F43D49; Mon, 31 Jul 2006 13:08:48 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VD8mbt024347; Mon, 31 Jul 2006 13:08:48 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VD8mPl024346; Mon, 31 Jul 2006 13:08:48 GMT (envelope-from yar) Message-Id: <200607311308.k6VD8mPl024346@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 13:08:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/options WITHOUT_GNU WITHOUT_NS_CACHING WITHOUT_PAM X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:08:48 -0000 yar 2006-07-31 13:08:47 UTC FreeBSD src repository Added files: tools/build/options WITHOUT_GNU WITHOUT_NS_CACHING WITHOUT_PAM Log: Document some more src.conf(5) options: WITHOUT_GNU, WITHOUT_NS_CACHING, WITHOUT_PAM. Noticed by: src/tools/build/options/makeman Revision Changes Path 1.1 +4 -0 src/tools/build/options/WITHOUT_GNU (new) 1.1 +7 -0 src/tools/build/options/WITHOUT_NS_CACHING (new) 1.1 +2 -0 src/tools/build/options/WITHOUT_PAM (new) From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:15:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F06FF16A4E2; Mon, 31 Jul 2006 13:15:06 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20B8143D5D; Mon, 31 Jul 2006 13:15:05 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VDF543024698; Mon, 31 Jul 2006 13:15:05 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VDF4Ye024697; Mon, 31 Jul 2006 13:15:04 GMT (envelope-from yar) Message-Id: <200607311315.k6VDF4Ye024697@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 13:15:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:15:07 -0000 yar 2006-07-31 13:15:04 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Log: Regen from src/tools/build/options. Revision Changes Path 1.5 +26 -8 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:15:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60DC916A51A; Mon, 31 Jul 2006 13:15:20 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDA0643D58; Mon, 31 Jul 2006 13:15:06 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k6VDF3ZC001830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Jul 2006 17:15:03 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k6VDF30Z001829; Mon, 31 Jul 2006 17:15:03 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 31 Jul 2006 17:15:02 +0400 From: Gleb Smirnoff To: Pyun YongHyeon Message-ID: <20060731131502.GS96644@FreeBSD.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200607200357.k6K3vwg2039627@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:15:20 -0000 On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: P> yongari 2006-07-20 03:57:58 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> Honor IFF_DRV_OACTIVE in em_start_locked(). Isn't it better to shift this change to the em_start(), to avoid double check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the em_start()? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:20:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0046016A4E0; Mon, 31 Jul 2006 13:20:44 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAF1343D45; Mon, 31 Jul 2006 13:20:44 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VDKiLj025120; Mon, 31 Jul 2006 13:20:44 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VDKihd025119; Mon, 31 Jul 2006 13:20:44 GMT (envelope-from yar) Message-Id: <200607311320.k6VDKihd025119@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 13:20:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:20:45 -0000 yar 2006-07-31 13:20:44 UTC FreeBSD src repository Modified files: libexec/telnetd Makefile Log: telnetd(8) doesn't really go to the crunched floppies, so its Makefile needn't test for RELEASE_CRUNCH. Suggested by: ru Revision Changes Path 1.29 +0 -2 src/libexec/telnetd/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:29:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EB5616A4DE; Mon, 31 Jul 2006 13:29:41 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9544043D5F; Mon, 31 Jul 2006 13:29:36 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VDTaxX025636; Mon, 31 Jul 2006 13:29:36 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VDTaQY025635; Mon, 31 Jul 2006 13:29:36 GMT (envelope-from yar) Message-Id: <200607311329.k6VDTaQY025635@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 13:29:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libtelnet Makefile src/libexec/telnetd Makefile src/usr.bin/telnet Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:29:41 -0000 yar 2006-07-31 13:29:36 UTC FreeBSD src repository Modified files: lib/libtelnet Makefile libexec/telnetd Makefile usr.bin/telnet Makefile Log: Stop enforcing dependencies between MK_* options at Makefile level. All the dependencies are satisfied now in . Revision Changes Path 1.24 +2 -1 src/lib/libtelnet/Makefile 1.30 +2 -1 src/libexec/telnetd/Makefile 1.31 +2 -1 src/usr.bin/telnet/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:49:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 249FA16A4E0; Mon, 31 Jul 2006 13:49:08 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id F112C43D62; Mon, 31 Jul 2006 13:49:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0C83E46CD9; Mon, 31 Jul 2006 09:49:06 -0400 (EDT) Date: Mon, 31 Jul 2006 14:49:05 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Gleb Smirnoff In-Reply-To: <20060731131502.GS96644@FreeBSD.org> Message-ID: <20060731144841.Y71432@fledge.watson.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:49:08 -0000 On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: > P> yongari 2006-07-20 03:57:58 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c > P> Log: > P> Honor IFF_DRV_OACTIVE in em_start_locked(). > > Isn't it better to shift this change to the em_start(), to avoid double > check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the > em_start()? Isn't em_start_locked() called from quite a few different places, including the interrupt handler, etc, where the mutex is already held? Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Mon Jul 31 13:53:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14A2D16A4DF; Mon, 31 Jul 2006 13:53:29 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C18CE43D6D; Mon, 31 Jul 2006 13:53:28 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VDrSth027212; Mon, 31 Jul 2006 13:53:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VDrSEd027211; Mon, 31 Jul 2006 13:53:28 GMT (envelope-from yar) Message-Id: <200607311353.k6VDrSEd027211@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 13:53:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/options WITHOUT_GNU WITHOUT_PAM X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 13:53:29 -0000 yar 2006-07-31 13:53:28 UTC FreeBSD src repository Modified files: tools/build/options WITHOUT_GNU WITHOUT_PAM Log: Tell the bitter truth that WITHOUT_GNU and WITHOUT_PAM don't have any effect now. Revision Changes Path 1.2 +1 -0 src/tools/build/options/WITHOUT_GNU 1.2 +1 -0 src/tools/build/options/WITHOUT_PAM From owner-cvs-src@FreeBSD.ORG Mon Jul 31 14:09:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88C5516A4DA; Mon, 31 Jul 2006 14:09:56 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7924A43D46; Mon, 31 Jul 2006 14:09:55 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6VE9qRV050722; Mon, 31 Jul 2006 18:09:52 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6VE9qgb050721; Mon, 31 Jul 2006 18:09:52 +0400 (MSD) (envelope-from yar) Date: Mon, 31 Jul 2006 18:09:52 +0400 From: Yar Tikhiy To: Marcel Moolenaar Message-ID: <20060731140951.GC48538@comp.chem.msu.su> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607302051.k6UKpfNU011188@repoman.freebsd.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, ru@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 14:09:56 -0000 On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: > marcel 2006-07-30 20:51:41 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/kldxref Makefile > Log: > Use NO_SHARED=YES to force a static link. > > Pointed out by: ru@ > > Revision Changes Path > 1.9 +1 -1 src/usr.sbin/kldxref/Makefile Perhaps it should be spelled just ``NO_SHARED='' in keeping with the current style? Unfortunately style.Makefile(5) doesn't seem to list this rule... -- Yar From owner-cvs-src@FreeBSD.ORG Mon Jul 31 14:13:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E37B16A4E0; Mon, 31 Jul 2006 14:13:29 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29C0F43D55; Mon, 31 Jul 2006 14:13:26 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VEDQZT029704; Mon, 31 Jul 2006 14:13:26 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VEDQVj029703; Mon, 31 Jul 2006 14:13:26 GMT (envelope-from yar) Message-Id: <200607311413.k6VEDQVj029703@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 14:13:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 14:13:29 -0000 yar 2006-07-31 14:13:25 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Log: Regen. Revision Changes Path 1.6 +4 -2 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Mon Jul 31 14:17:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0ED3716A4DE; Mon, 31 Jul 2006 14:17:05 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B3C743D49; Mon, 31 Jul 2006 14:17:04 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VEH4hk029932; Mon, 31 Jul 2006 14:17:04 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VEH4f2029931; Mon, 31 Jul 2006 14:17:04 GMT (envelope-from jkoshy) Message-Id: <200607311417.k6VEH4f2029931@repoman.freebsd.org> From: Joseph Koshy Date: Mon, 31 Jul 2006 14:17:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/hexdump conv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 14:17:05 -0000 jkoshy 2006-07-31 14:17:04 UTC FreeBSD src repository Modified files: usr.bin/hexdump conv.c Log: In 'od -c' mode, deal with printable but zero-width combining characters correctly. These characters are displayed "combined" with a space character. PR: misc/100215 Submitted by: "J.R. Oldroyd" <> Reviewed by: "J.R. Oldroyd" <> (revised patch) MFC after: 3 days Revision Changes Path 1.9 +1 -1 src/usr.bin/hexdump/conv.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 15:31:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 033B716A4DA; Mon, 31 Jul 2006 15:31:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6FFD43D45; Mon, 31 Jul 2006 15:31:43 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VFVhTW034974; Mon, 31 Jul 2006 15:31:43 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VFVhv3034973; Mon, 31 Jul 2006 15:31:43 GMT (envelope-from jhb) Message-Id: <200607311531.k6VFVhv3034973@repoman.freebsd.org> From: John Baldwin Date: Mon, 31 Jul 2006 15:31:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_ktrace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 15:31:44 -0000 jhb 2006-07-31 15:31:43 UTC FreeBSD src repository Modified files: sys/kern kern_ktrace.c Log: Trim an obsolete comment. ktrgenio() stopped doing crazy gymnastics when ktrace was redone to be mostly synchronous again. Revision Changes Path 1.110 +0 -9 src/sys/kern/kern_ktrace.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 15:44:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 553DD16A4E1; Mon, 31 Jul 2006 15:44:14 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12A4343D45; Mon, 31 Jul 2006 15:44:14 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VFiDrr035686; Mon, 31 Jul 2006 15:44:13 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VFiDkg035685; Mon, 31 Jul 2006 15:44:13 GMT (envelope-from obrien) Message-Id: <200607311544.k6VFiDkg035685@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 31 Jul 2006 15:44:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 15:44:14 -0000 obrien 2006-07-31 15:44:13 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_lookup.c Log: Rather than print out a nice error message giving details sufficent to fix a 'ufs_dirbad' and then panicing (making it very hard to see the details), put them in the panic message itself. Revision Changes Path 1.82 +5 -3 src/sys/ufs/ufs/ufs_lookup.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:11:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C791616A4DF; Mon, 31 Jul 2006 16:11:27 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B4FD43D69; Mon, 31 Jul 2006 16:11:20 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.150] (pptp0.pn.xcllnt.net [192.168.4.150]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k6VGAq3g016257; Mon, 31 Jul 2006 09:10:53 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20060731140951.GC48538@comp.chem.msu.su> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Mon, 31 Jul 2006 09:10:43 -0700 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.2) Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , ru@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:11:27 -0000 On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: > On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: >> marcel 2006-07-30 20:51:41 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.sbin/kldxref Makefile >> Log: >> Use NO_SHARED=YES to force a static link. >> >> Pointed out by: ru@ >> >> Revision Changes Path >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile > > Perhaps it should be spelled just ``NO_SHARED='' in keeping with > the current style? I really don't know. Those NO_FOO knobs are not logical in their use. > Unfortunately style.Makefile(5) doesn't seem > to list this rule... Feel free to change my commit to whatever you think is right. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:31:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B364E16A4DD; Mon, 31 Jul 2006 16:31:00 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5573643D66; Mon, 31 Jul 2006 16:31:00 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k6VGUxGx016274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Jul 2006 09:30:59 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44CE3042.8060509@errno.com> Date: Mon, 31 Jul 2006 09:30:58 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.4 (X11/20060724) MIME-Version: 1.0 To: Yar Tikhiy References: <200607311320.k6VDKihd025119@repoman.freebsd.org> In-Reply-To: <200607311320.k6VDKihd025119@repoman.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:31:00 -0000 Yar Tikhiy wrote: > yar 2006-07-31 13:20:44 UTC > > FreeBSD src repository > > Modified files: > libexec/telnetd Makefile > Log: > telnetd(8) doesn't really go to the crunched floppies, > so its Makefile needn't test for RELEASE_CRUNCH. What about folks building crunchgen'd images w/ telnetd; is there an equivalent way to do the same thing w/ the new build knobs? Sam From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:32:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A50416A4E2; Mon, 31 Jul 2006 16:32:21 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CF3D43D8A; Mon, 31 Jul 2006 16:32:17 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6VGWAPg053070; Mon, 31 Jul 2006 20:32:10 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6VGWAW8053069; Mon, 31 Jul 2006 20:32:10 +0400 (MSD) (envelope-from yar) Date: Mon, 31 Jul 2006 20:32:09 +0400 From: Yar Tikhiy To: Marcel Moolenaar Message-ID: <20060731163209.GB50797@comp.chem.msu.su> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , ru@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:32:21 -0000 On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: > > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: > > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: > >>marcel 2006-07-30 20:51:41 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> usr.sbin/kldxref Makefile > >> Log: > >> Use NO_SHARED=YES to force a static link. > >> > >> Pointed out by: ru@ > >> > >> Revision Changes Path > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile > > > >Perhaps it should be spelled just ``NO_SHARED='' in keeping with > >the current style? > > I really don't know. Those NO_FOO knobs are not logical in their > use. > > > Unfortunately style.Makefile(5) doesn't seem > >to list this rule... > > Feel free to change my commit to whatever you think is right. I was sly enough to add Ruslan to Cc in my previous mail :-) Let's wait for his opinion on this and below. In the meanwhile I peeked in /usr/share/mk and found that the handling of NO_* knobs is quite far from being consistent. For example: - NO_MAN -- can be just defined ("YES" and "NO" both mean true), handled at level (note that is often included separately now and includes some magic); - NO_OBJ -- can be just defined to be true, handled in , which is included from more convenient files like ; - NO_SHARED -- must be set to something != "no" for the effect, handled in . I'm unsure if there is a reason behind all this diversity. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:49:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2788616A4DD; Mon, 31 Jul 2006 16:49:26 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D82EF43D46; Mon, 31 Jul 2006 16:49:25 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VGnPuD048126; Mon, 31 Jul 2006 16:49:25 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VGnPot048125; Mon, 31 Jul 2006 16:49:25 GMT (envelope-from brueffer) Message-Id: <200607311649.k6VGnPot048125@repoman.freebsd.org> From: Christian Brueffer Date: Mon, 31 Jul 2006 16:49:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:49:26 -0000 brueffer 2006-07-31 16:49:25 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Mark two more items as merged. Revision Changes Path 1.959 +2 -2 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:52:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9684516A4DA; Mon, 31 Jul 2006 16:52:16 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52ED843D46; Mon, 31 Jul 2006 16:52:16 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VGqGg8048362; Mon, 31 Jul 2006 16:52:16 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VGqF6e048359; Mon, 31 Jul 2006 16:52:15 GMT (envelope-from brueffer) Message-Id: <200607311652.k6VGqF6e048359@repoman.freebsd.org> From: Christian Brueffer Date: Mon, 31 Jul 2006 16:52:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:52:16 -0000 brueffer 2006-07-31 16:52:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: Note my(4) altq(4=) support. Revision Changes Path 1.883.2.31 +2 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Jul 31 16:58:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D13F16A4DD; Mon, 31 Jul 2006 16:58:16 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id D968943D45; Mon, 31 Jul 2006 16:58:15 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.150] (pptp0.pn.xcllnt.net [192.168.4.150]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k6VGvpPs016549; Mon, 31 Jul 2006 09:57:52 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <8F70D2AC-029E-4829-A775-600D6AABE69E@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Mon, 31 Jul 2006 09:57:42 -0700 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.2) Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , Ruslan Ermilov , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 16:58:16 -0000 On Jul 31, 2006, at 9:32 AM, Yar Tikhiy wrote: > On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: >> >> On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: >> >>> On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: >>>> marcel 2006-07-30 20:51:41 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> usr.sbin/kldxref Makefile >>>> Log: >>>> Use NO_SHARED=YES to force a static link. >>>> >>>> Pointed out by: ru@ >>>> >>>> Revision Changes Path >>>> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile >>> >>> Perhaps it should be spelled just ``NO_SHARED='' in keeping with >>> the current style? >> >> I really don't know. Those NO_FOO knobs are not logical in their >> use. >> >>> Unfortunately style.Makefile(5) doesn't seem >>> to list this rule... >> >> Feel free to change my commit to whatever you think is right. > > I was sly enough to add Ruslan to Cc in my previous mail :-) > Let's wait for his opinion on this and below. Sounds good. > In the meanwhile I peeked in /usr/share/mk and found that the handling > of NO_* knobs is quite far from being consistent. For example: > > - NO_MAN -- can be just defined ("YES" and "NO" both mean true), > handled at level (note that > is often included separately now and includes some magic); > > - NO_OBJ -- can be just defined to be true, handled in , > which is included from more convenient files like ; > > - NO_SHARED -- must be set to something != "no" for the effect, > handled in . > > I'm unsure if there is a reason behind all this diversity. I doubt there's a reason, because reason would be unreasonable then :-) I think the problem is inherent when the existence of the variable counts and not its value. It's not intuitive and people use it in different ways because of that. I personally like something simple like SHARED=NO or SHARED=YES. The lack of definition then meaning the default setting. This is trivially implemented with SHARED?=YES. Anyway: that's just me... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Mon Jul 31 17:04:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B61F16A4DD; Mon, 31 Jul 2006 17:04:29 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36ECB43D45; Mon, 31 Jul 2006 17:04:29 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VH4Tlh050180; Mon, 31 Jul 2006 17:04:29 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VH4TsT050179; Mon, 31 Jul 2006 17:04:29 GMT (envelope-from brueffer) Message-Id: <200607311704.k6VH4TsT050179@repoman.freebsd.org> From: Christian Brueffer Date: Mon, 31 Jul 2006 17:04:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/share/misc dev.archlist.txt X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 17:04:29 -0000 brueffer 2006-07-31 17:04:29 UTC FreeBSD src repository Modified files: release/doc/share/misc dev.archlist.txt Log: Note hardware supported by powerpc, based on GENERIC. Revision Changes Path 1.88 +13 -13 src/release/doc/share/misc/dev.archlist.txt From owner-cvs-src@FreeBSD.ORG Mon Jul 31 17:08:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A246E16A4DA; Mon, 31 Jul 2006 17:08:58 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BBDF43D49; Mon, 31 Jul 2006 17:08:53 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k6VH8VIA053422; Mon, 31 Jul 2006 21:08:31 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k6VH8VRw053421; Mon, 31 Jul 2006 21:08:31 +0400 (MSD) (envelope-from yar) Date: Mon, 31 Jul 2006 21:08:30 +0400 From: Yar Tikhiy To: Sam Leffler Message-ID: <20060731170830.GC50797@comp.chem.msu.su> References: <200607311320.k6VDKihd025119@repoman.freebsd.org> <44CE3042.8060509@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44CE3042.8060509@errno.com> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 17:08:58 -0000 On Mon, Jul 31, 2006 at 09:30:58AM -0700, Sam Leffler wrote: > Yar Tikhiy wrote: > > yar 2006-07-31 13:20:44 UTC > > > > FreeBSD src repository > > > > Modified files: > > libexec/telnetd Makefile > > Log: > > telnetd(8) doesn't really go to the crunched floppies, > > so its Makefile needn't test for RELEASE_CRUNCH. > > What about folks building crunchgen'd images w/ telnetd; is there an > equivalent way to do the same thing w/ the new build knobs? I'd suggest using WITHOUT_CRYPT=yes, it will have the same effect for telnetd. Anyway, the RELEASE_CRUNCH knob's coverage is rather limited, it's respected by only those parts of src/ that are included in the standard boot floppies--telnetd was just an exception. The other exception is inetd, which puts its IPSEC stuff under RELEASE_CRUNCH. The better way would be to introduce the MK_IPSEC_SUPPORT knob. RELEASE_CRUNCH could be mostly handled in a single place then. Few tools build in a really special way if RELEASE_CRUNCH is defined; most tools just have crypto, IPX etc stuff omitted from them. P.S. Just found that telnetd and inetd are optional components of src/release/picobsd (left out by default.) This can justify putting RELEASE_CRUNCH back into telnetd's Makefile accompanied by a clarifying comment. It stays a rather limited solution though. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Jul 31 18:53:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98E4416A4EC; Mon, 31 Jul 2006 18:53:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3051443D72; Mon, 31 Jul 2006 18:53:10 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VIrA0g057585; Mon, 31 Jul 2006 18:53:10 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VIrAMJ057580; Mon, 31 Jul 2006 18:53:10 GMT (envelope-from jhb) Message-Id: <200607311853.k6VIrAMJ057580@repoman.freebsd.org> From: John Baldwin Date: Mon, 31 Jul 2006 18:53:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 18:53:20 -0000 jhb 2006-07-31 18:53:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bce if_bce.c Log: MFC: Expand locking coverage to cover if_drv_flags in a few places where it wasn't locked. Revision Changes Path 1.2.2.5 +8 -4 src/sys/dev/bce/if_bce.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 18:53:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C014416A5A7; Mon, 31 Jul 2006 18:53:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E22C43D46; Mon, 31 Jul 2006 18:53:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VIrt8G057617; Mon, 31 Jul 2006 18:53:55 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VIrttg057616; Mon, 31 Jul 2006 18:53:55 GMT (envelope-from jhb) Message-Id: <200607311853.k6VIrttg057616@repoman.freebsd.org> From: John Baldwin Date: Mon, 31 Jul 2006 18:53:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern subr_autoconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 18:53:55 -0000 jhb 2006-07-31 18:53:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern subr_autoconf.c Log: MFC: Add a mutex to protect the list of interrupt config hooks. Revision Changes Path 1.22.2.1 +21 -11 src/sys/kern/subr_autoconf.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 18:55:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50C0616A4DA; Mon, 31 Jul 2006 18:55:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EECB343D45; Mon, 31 Jul 2006 18:55:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VItESg057752; Mon, 31 Jul 2006 18:55:14 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VItEo7057751; Mon, 31 Jul 2006 18:55:14 GMT (envelope-from jhb) Message-Id: <200607311855.k6VItEo7057751@repoman.freebsd.org> From: John Baldwin Date: Mon, 31 Jul 2006 18:55:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 machdep.c src/sys/i386/i386 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 18:55:15 -0000 jhb 2006-07-31 18:55:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 machdep.c sys/i386/i386 machdep.c Log: MFC: Fix hw.physmem/MAXMEM usage on systems with SMAP (including systems with ACPI). Revision Changes Path 1.638.2.8 +7 -7 src/sys/amd64/amd64/machdep.c 1.616.2.6 +10 -1 src/sys/i386/i386/machdep.c From owner-cvs-src@FreeBSD.ORG Mon Jul 31 19:15:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D44A16A4E8; Mon, 31 Jul 2006 19:15:10 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52F0D43D6E; Mon, 31 Jul 2006 19:15:10 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VJFA0u060602; Mon, 31 Jul 2006 19:15:10 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VJFAp9060601; Mon, 31 Jul 2006 19:15:10 GMT (envelope-from yar) Message-Id: <200607311915.k6VJFAp9060601@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 31 Jul 2006 19:15:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/telnetd Makefile src/usr.sbin/inetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 19:15:10 -0000 yar 2006-07-31 19:15:10 UTC FreeBSD src repository Modified files: libexec/telnetd Makefile usr.sbin/inetd Makefile Log: inetd and telnetd are not included in the standard release crunched floppies, but they can be included as options in src/release/picobsd (omitted by default though.) Therefore preserve the RELEASE_CRUNCH knob in their Makefiles, but tell its real purpose in a comment. Revision Changes Path 1.31 +3 -0 src/libexec/telnetd/Makefile 1.35 +1 -0 src/usr.sbin/inetd/Makefile From owner-cvs-src@FreeBSD.ORG Mon Jul 31 19:43:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE7B716A4DD; Mon, 31 Jul 2006 19:43:49 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A75B43D70; Mon, 31 Jul 2006 19:43:23 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k6VJhCTv004078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Jul 2006 23:43:12 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k6VJhBRv004077; Mon, 31 Jul 2006 23:43:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 31 Jul 2006 23:43:11 +0400 From: Gleb Smirnoff To: Robert Watson Message-ID: <20060731194311.GV96644@FreeBSD.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> <20060731144841.Y71432@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060731144841.Y71432@fledge.watson.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 19:43:50 -0000 On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: R> R> >On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: R> >P> yongari 2006-07-20 03:57:58 UTC R> >P> R> >P> FreeBSD src repository R> >P> R> >P> Modified files: R> >P> sys/dev/em if_em.c R> >P> Log: R> >P> Honor IFF_DRV_OACTIVE in em_start_locked(). R> > R> >Isn't it better to shift this change to the em_start(), to avoid double R> >check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the R> >em_start()? R> R> Isn't em_start_locked() called from quite a few different places, including R> the interrupt handler, etc, where the mutex is already held? It is, so the latter idea won't work. However, in all these places we can know the status of IFF_DRV_OACTIVE before calling the start routine. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Mon Jul 31 20:24:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF43B16A4DA; Mon, 31 Jul 2006 20:24:46 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA07143D45; Mon, 31 Jul 2006 20:24:46 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VKOk2Y065487; Mon, 31 Jul 2006 20:24:46 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VKOk5O065486; Mon, 31 Jul 2006 20:24:46 GMT (envelope-from thompsa) Message-Id: <200607312024.k6VKOk5O065486@repoman.freebsd.org> From: Andrew Thompson Date: Mon, 31 Jul 2006 20:24:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bridgestp.c bridgestp.h if_bridge.c if_bridgevar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 20:24:47 -0000 thompsa 2006-07-31 20:24:46 UTC FreeBSD src repository Modified files: sys/net bridgestp.c bridgestp.h if_bridge.c if_bridgevar.h Log: Add some statistics that are needed to support RFC4188 as part of the SoC2006 work on a bridge monitoring module for BSNMP. Submitted by: shteryana (SoC 2006) Revision Changes Path 1.15 +10 -0 src/sys/net/bridgestp.c 1.3 +2 -0 src/sys/net/bridgestp.h 1.73 +106 -1 src/sys/net/if_bridge.c 1.15 +43 -0 src/sys/net/if_bridgevar.h From owner-cvs-src@FreeBSD.ORG Mon Jul 31 22:53:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93BC216A4E2; Mon, 31 Jul 2006 22:53:12 +0000 (UTC) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (82.193.106.18.ipnet.kiev.ua [82.193.106.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9019F43D62; Mon, 31 Jul 2006 22:53:08 +0000 (GMT) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (localhost [127.0.0.1]) by frdp.freebsd.org.ua (8.13.6/8.13.6) with ESMTP id k6VMt1S6094019; Tue, 1 Aug 2006 01:55:01 +0300 (EEST) (envelope-from ru@FreeBSD.org.ua) Received: (from ru@localhost) by frdp.freebsd.org.ua (8.13.6/8.13.6/Submit) id k6VMt0Gs093998; Tue, 1 Aug 2006 01:55:00 +0300 (EEST) (envelope-from ru) Date: Tue, 1 Aug 2006 01:55:00 +0300 From: Ruslan Ermilov To: Yar Tikhiy Message-ID: <20060731225500.GB46645@frdp.freebsd.org.ua> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Marcel Moolenaar Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 22:53:12 -0000 --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2006 at 08:32:09PM +0400, Yar Tikhiy wrote: > On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: > >=20 > > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: > >=20 > > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: > > >>marcel 2006-07-30 20:51:41 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> usr.sbin/kldxref Makefile > > >> Log: > > >> Use NO_SHARED=3DYES to force a static link. > > >> > > >> Pointed out by: ru@ > > >> > > >> Revision Changes Path > > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile > > > > > >Perhaps it should be spelled just ``NO_SHARED=3D'' in keeping with > > >the current style? > >=20 > > I really don't know. Those NO_FOO knobs are not logical in their > > use. > >=20 > > > Unfortunately style.Makefile(5) doesn't seem > > >to list this rule... > >=20 > > Feel free to change my commit to whatever you think is right. >=20 > I was sly enough to add Ruslan to Cc in my previous mail :-) > Let's wait for his opinion on this and below. >=20 NO_SHARED is special in that it's usually set for a group of programs, e.g. src/bin/Makefile.inc, and then needs to be reset for some of them, e.g. src/bin/rmail/Makefile. > In the meanwhile I peeked in /usr/share/mk and found that the handling > of NO_* knobs is quite far from being consistent. For example: >=20 > - NO_MAN -- can be just defined ("YES" and "NO" both mean true), > handled at level (note that > is often included separately now and includes some magic); >=20 > - NO_OBJ -- can be just defined to be true, handled in , > which is included from more convenient files like ; >=20 > - NO_SHARED -- must be set to something !=3D "no" for the effect, > handled in . >=20 > I'm unsure if there is a reason behind all this diversity. >=20 NO_MAN is new style, NO_OBJ is old style and should be easily convertable, NO_SHARED is old style and not easily convertable. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFEzopEqRfpzJluFF4RAo5wAJ9ZfNm6zb1IGUEHjfCyUtPz/IFaTwCeNI+5 7puYbvte7dwlqJBrQzgpLRA= =dtF6 -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX-- From owner-cvs-src@FreeBSD.ORG Mon Jul 31 23:00:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92C1716A4DD; Mon, 31 Jul 2006 23:00:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AF4343D49; Mon, 31 Jul 2006 23:00:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6VN06vx089924; Mon, 31 Jul 2006 23:00:06 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6VN06sQ089923; Mon, 31 Jul 2006 23:00:06 GMT (envelope-from rwatson) Message-Id: <200607312300.k6VN06sQ089923@repoman.freebsd.org> From: Robert Watson Date: Mon, 31 Jul 2006 23:00:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 23:00:06 -0000 rwatson 2006-07-31 23:00:05 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Close a race that occurs when using sendto() to connect and send on a UNIX domain socket at the same time as the remote host is closing the new connections as quickly as they open. Since the connect() and send() paths are non-atomic with respect to another, it is possible for the second thread's close() call to disconnect the two sockets as connect() returns, leading to the consumer (which plans to send()) with a NULL kernel pointer to its proposed peer. As a result, after acquiring the UNIX domain socket subsystem lock, we need to revalidate the connection pointers even though connect() has technically succeed, and reurn an error to say that there's no connection on which to perform the send. We might want to rethink the specific errno number, perhaps ECONNRESET would be better. PR: 100940 Reported by: Young Hyun MFC after: 2 weeks MFC note: Some adaptation will be required Revision Changes Path 1.183 +22 -2 src/sys/kern/uipc_usrreq.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 00:39:41 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0C0216A4E7 for ; Tue, 1 Aug 2006 00:39:41 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BD2043D55 for ; Tue, 1 Aug 2006 00:39:38 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by ug-out-1314.google.com with SMTP id m2so1111441uge for ; Mon, 31 Jul 2006 17:39:37 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=omnlnJoKTeZfkNwkbyJdQkG/wiw7ZbMxB/lBGJKuGHlQUXIaTe2dMLNDejSQFuzVz46cZLfPEV/vVYDd50fNHOpsauqNURViEPoFZ9gJXWAzH2DCTHi0yJy3Ql699TgWWxb1fwF3MZZDE+j91yfbO4l+huJFC2ZvgAF5lrlvYAU= Received: by 10.65.83.18 with SMTP id k18mr247578qbl; Mon, 31 Jul 2006 17:39:36 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 15sm6467189nzp.2006.07.31.17.39.33; Mon, 31 Jul 2006 17:39:36 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k710eHTR039896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Aug 2006 09:40:17 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k710eGHX039895; Tue, 1 Aug 2006 09:40:16 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 1 Aug 2006 09:40:16 +0900 From: Pyun YongHyeon To: Gleb Smirnoff Message-ID: <20060801004016.GB39581@cdnetworks.co.kr> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> <20060731144841.Y71432@fledge.watson.org> <20060731194311.GV96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060731194311.GV96644@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 00:39:41 -0000 On Mon, Jul 31, 2006 at 11:43:11PM +0400, Gleb Smirnoff wrote: > On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: > R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > R> > R> >On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: > R> >P> yongari 2006-07-20 03:57:58 UTC > R> >P> > R> >P> FreeBSD src repository > R> >P> > R> >P> Modified files: > R> >P> sys/dev/em if_em.c > R> >P> Log: > R> >P> Honor IFF_DRV_OACTIVE in em_start_locked(). > R> > > R> >Isn't it better to shift this change to the em_start(), to avoid double > R> >check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the > R> >em_start()? > R> > R> Isn't em_start_locked() called from quite a few different places, including > R> the interrupt handler, etc, where the mutex is already held? > > It is, so the latter idea won't work. However, in all these places > we can know the status of IFF_DRV_OACTIVE before calling the start > routine. > You're right. Feel free to fix it. I have to solve re(4) issues on sparc64 at the moment... -- Regards, Pyun YongHyeon From owner-cvs-src@FreeBSD.ORG Tue Aug 1 01:17:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 225E016A4DA; Tue, 1 Aug 2006 01:17:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8704C43D49; Tue, 1 Aug 2006 01:17:39 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k711FZEI033003; Mon, 31 Jul 2006 19:15:35 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 31 Jul 2006 19:15:58 -0600 (MDT) Message-Id: <20060731.191558.-1253045041.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> References: <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 31 Jul 2006 19:15:36 -0600 (MDT) Cc: marcel@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, marcel@xcllnt.net, src-committers@freebsd.org, ru@freebsd.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 01:17:40 -0000 In message: <20060731163209.GB50797@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: : > : > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: : > : > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: : > >>marcel 2006-07-30 20:51:41 UTC : > >> : > >> FreeBSD src repository : > >> : > >> Modified files: : > >> usr.sbin/kldxref Makefile : > >> Log: : > >> Use NO_SHARED=YES to force a static link. : > >> : > >> Pointed out by: ru@ : > >> : > >> Revision Changes Path : > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile : > > : > >Perhaps it should be spelled just ``NO_SHARED='' in keeping with : > >the current style? : > : > I really don't know. Those NO_FOO knobs are not logical in their : > use. : > : > > Unfortunately style.Makefile(5) doesn't seem : > >to list this rule... : > : > Feel free to change my commit to whatever you think is right. : : I was sly enough to add Ruslan to Cc in my previous mail :-) : Let's wait for his opinion on this and below. : : In the meanwhile I peeked in /usr/share/mk and found that the handling : of NO_* knobs is quite far from being consistent. For example: : : - NO_MAN -- can be just defined ("YES" and "NO" both mean true), : handled at level (note that : is often included separately now and includes some magic); : : - NO_OBJ -- can be just defined to be true, handled in , : which is included from more convenient files like ; : : - NO_SHARED -- must be set to something != "no" for the effect, : handled in . : : I'm unsure if there is a reason behind all this diversity. Hysterical Raisons. It all started out '.if defined(NO_FOO)' or '.if !defined(NO_FOO)'. This is why NO_OBJ and NO_MAN are that way. Then people wanted to override the global default to force things to be linked statically. This was so that things like init could always be static back in the day. This accounts for NO_SHARED handling. It is a miss-mash. That's why we're not supposed to set NO_FOO anymore. MK_FOO is set to yes or no depending on defaults and WITH/WITHOUT_FOO. I'm not sure why ru@ didn't include the above in his big cleanup. Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 1 01:21:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B360816A4DD; Tue, 1 Aug 2006 01:21:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 212E343D6A; Tue, 1 Aug 2006 01:21:37 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k711IpXf033027; Mon, 31 Jul 2006 19:18:51 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 31 Jul 2006 19:19:13 -0600 (MDT) Message-Id: <20060731.191913.139568459.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20060731170830.GC50797@comp.chem.msu.su> References: <200607311320.k6VDKihd025119@repoman.freebsd.org> <44CE3042.8060509@errno.com> <20060731170830.GC50797@comp.chem.msu.su> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 31 Jul 2006 19:18:51 -0600 (MDT) Cc: sam@errno.com, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 01:21:41 -0000 In message: <20060731170830.GC50797@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Jul 31, 2006 at 09:30:58AM -0700, Sam Leffler wrote: : > Yar Tikhiy wrote: : > > yar 2006-07-31 13:20:44 UTC : > > : > > FreeBSD src repository : > > : > > Modified files: : > > libexec/telnetd Makefile : > > Log: : > > telnetd(8) doesn't really go to the crunched floppies, : > > so its Makefile needn't test for RELEASE_CRUNCH. : > : > What about folks building crunchgen'd images w/ telnetd; is there an : > equivalent way to do the same thing w/ the new build knobs? : : I'd suggest using WITHOUT_CRYPT=yes, it will have the same effect : for telnetd. Anyway, the RELEASE_CRUNCH knob's coverage is rather : limited, it's respected by only those parts of src/ that are included : in the standard boot floppies--telnetd was just an exception. The : other exception is inetd, which puts its IPSEC stuff under : RELEASE_CRUNCH. The better way would be to introduce the : MK_IPSEC_SUPPORT knob. RELEASE_CRUNCH could be mostly handled in : a single place then. Few tools build in a really special way if : RELEASE_CRUNCH is defined; most tools just have crypto, IPX etc : stuff omitted from them. We should test "MK_CRYPT" or "MK_IPSEC_SUPPORT" in the makefiles, set via WITH/WITHOUT_CRYPT/IPSEC_SUPPORT in configuration files. Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 1 01:21:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95A8216A523; Tue, 1 Aug 2006 01:21:47 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2179243D6A; Tue, 1 Aug 2006 01:21:42 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k711Hebo033015; Mon, 31 Jul 2006 19:17:40 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 31 Jul 2006 19:18:03 -0600 (MDT) Message-Id: <20060731.191803.270754578.imp@bsdimp.com> To: marcel@xcllnt.net From: "M. Warner Losh" In-Reply-To: <8F70D2AC-029E-4829-A775-600D6AABE69E@xcllnt.net> References: <20060731163209.GB50797@comp.chem.msu.su> <8F70D2AC-029E-4829-A775-600D6AABE69E@xcllnt.net> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 31 Jul 2006 19:17:40 -0600 (MDT) Cc: marcel@FreeBSD.org, yar@comp.chem.msu.su, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, ru@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 01:21:47 -0000 In message: <8F70D2AC-029E-4829-A775-600D6AABE69E@xcllnt.net> Marcel Moolenaar writes: : I think the problem is inherent when the existence of the variable : counts and not its value. It's not intuitive and people use it in : different ways because of that. I personally like something simple : like SHARED=NO or SHARED=YES. The lack of definition then meaning : the default setting. This is trivially implemented with SHARED?=YES. : Anyway: that's just me... NO_SHARED=no has been a long-running joke around the office. However, going to a simple SHARED=?yes/no won't work either. It is inconsistant with the new world order. I'd expecte that MK_SHARED=yes/no would be the right thing to do, but there may be parse time issues that makes it hard to do this simple fix.. Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 1 01:23:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA31616A4DE; Tue, 1 Aug 2006 01:23:39 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92D9843D49; Tue, 1 Aug 2006 01:23:39 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k711NdOs008899; Tue, 1 Aug 2006 01:23:39 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k711NdPV008898; Tue, 1 Aug 2006 01:23:39 GMT (envelope-from obrien) Message-Id: <200608010123.k711NdPV008898@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 1 Aug 2006 01:23:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 identcpu.c src/sys/amd64/amd64 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 01:23:40 -0000 obrien 2006-08-01 01:23:39 UTC FreeBSD src repository Modified files: sys/i386/i386 identcpu.c sys/amd64/amd64 identcpu.c Log: Correct spelling of 3DNow!. Revision Changes Path 1.148 +2 -2 src/sys/amd64/amd64/identcpu.c 1.168 +2 -2 src/sys/i386/i386/identcpu.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 05:32:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A2EB16AD30; Tue, 1 Aug 2006 05:31:30 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A985643D46; Tue, 1 Aug 2006 05:31:29 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k715VTfa035091; Tue, 1 Aug 2006 05:31:29 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k715VTV8035090; Tue, 1 Aug 2006 05:31:29 GMT (envelope-from kientzle) Message-Id: <200608010531.k715VTV8035090@repoman.freebsd.org> From: Tim Kientzle Date: Tue, 1 Aug 2006 05:31:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 05:32:39 -0000 kientzle 2006-08-01 05:31:29 UTC FreeBSD src repository Modified files: lib/libarchive archive_write.c Log: If skip_file_dev and skip_file_ino haven't been set (are still == 0), then don't use them for testing for a recursive add. Thanks to: Spencer Minear MFC after: 7 days Revision Changes Path 1.17 +3 -1 src/lib/libarchive/archive_write.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 07:37:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8FAF16A4DA; Tue, 1 Aug 2006 07:37:22 +0000 (UTC) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67FBF43D46; Tue, 1 Aug 2006 07:37:22 +0000 (GMT) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k717bMe9043769; Tue, 1 Aug 2006 07:37:22 GMT (envelope-from avatar@repoman.freebsd.org) Received: (from avatar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k717bMbU043768; Tue, 1 Aug 2006 07:37:22 GMT (envelope-from avatar) Message-Id: <200608010737.k717bMbU043768@repoman.freebsd.org> From: Tai-hwa Liang Date: Tue, 1 Aug 2006 07:37:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/wi if_wi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 07:37:22 -0000 avatar 2006-08-01 07:37:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/wi if_wi.c Log: MFC: (1.191) Fix "taskqueue_drain with the following non-sleepable locks held" witness(9) warning on detach. Ok'ed by: ru Tested on: 6-STABLE Revision Changes Path 1.180.2.8 +1 -1 src/sys/dev/wi/if_wi.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 09:24:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC1EB16A4DF; Tue, 1 Aug 2006 09:24:49 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6B3643D5E; Tue, 1 Aug 2006 09:24:47 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k719Oawg069028; Tue, 1 Aug 2006 13:24:36 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k719OZbV069023; Tue, 1 Aug 2006 13:24:35 +0400 (MSD) (envelope-from yar) Date: Tue, 1 Aug 2006 13:24:34 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20060801092434.GA68364@comp.chem.msu.su> References: <200607311320.k6VDKihd025119@repoman.freebsd.org> <44CE3042.8060509@errno.com> <20060731170830.GC50797@comp.chem.msu.su> <20060731.191913.139568459.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060731.191913.139568459.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: sam@errno.com, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/libexec/telnetd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 09:24:49 -0000 On Mon, Jul 31, 2006 at 07:19:13PM -0600, M. Warner Losh wrote: > In message: <20060731170830.GC50797@comp.chem.msu.su> > Yar Tikhiy writes: > : On Mon, Jul 31, 2006 at 09:30:58AM -0700, Sam Leffler wrote: > : > Yar Tikhiy wrote: > : > > yar 2006-07-31 13:20:44 UTC > : > > > : > > FreeBSD src repository > : > > > : > > Modified files: > : > > libexec/telnetd Makefile > : > > Log: > : > > telnetd(8) doesn't really go to the crunched floppies, > : > > so its Makefile needn't test for RELEASE_CRUNCH. > : > > : > What about folks building crunchgen'd images w/ telnetd; is there an > : > equivalent way to do the same thing w/ the new build knobs? > : > : I'd suggest using WITHOUT_CRYPT=yes, it will have the same effect > : for telnetd. Anyway, the RELEASE_CRUNCH knob's coverage is rather > : limited, it's respected by only those parts of src/ that are included > : in the standard boot floppies--telnetd was just an exception. The > : other exception is inetd, which puts its IPSEC stuff under > : RELEASE_CRUNCH. The better way would be to introduce the > : MK_IPSEC_SUPPORT knob. RELEASE_CRUNCH could be mostly handled in > : a single place then. Few tools build in a really special way if > : RELEASE_CRUNCH is defined; most tools just have crypto, IPX etc > : stuff omitted from them. > > We should test "MK_CRYPT" or "MK_IPSEC_SUPPORT" in the makefiles, set > via WITH/WITHOUT_CRYPT/IPSEC_SUPPORT in configuration files. And those Makefiles that decide whether to do something special depending on the status of RELEASE_CRUNCH can use a more general and convenient knob name, e.g., MK_MINIMAL (would be WITH_MINIMAL in src.conf). -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 1 09:47:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4989916A4DF; Tue, 1 Aug 2006 09:47:12 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0720D43D49; Tue, 1 Aug 2006 09:47:12 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k719lBnF061184; Tue, 1 Aug 2006 09:47:11 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k719lBsv061183; Tue, 1 Aug 2006 09:47:11 GMT (envelope-from yar) Message-Id: <200608010947.k719lBsv061183@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 1 Aug 2006 09:47:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/geom/eli g_eli.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 09:47:12 -0000 yar 2006-08-01 09:47:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/geom/eli g_eli.c Log: MFC rev. 1.27: Fix a misspelled module name. Revision Changes Path 1.3.2.11 +1 -1 src/sys/geom/eli/g_eli.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 09:53:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E6C416A4DA; Tue, 1 Aug 2006 09:53:54 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EFAC43D4C; Tue, 1 Aug 2006 09:53:54 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k719rrJv061561; Tue, 1 Aug 2006 09:53:53 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k719rrUn061560; Tue, 1 Aug 2006 09:53:53 GMT (envelope-from yar) Message-Id: <200608010953.k719rrUn061560@repoman.freebsd.org> From: Yar Tikhiy Date: Tue, 1 Aug 2006 09:53:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/bin/test test.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 09:53:54 -0000 yar 2006-08-01 09:53:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/test test.1 Log: MFC rev. 1.24-1.25: test(1) doesn't do shortcut evaluation in its logical operators. Revision Changes Path 1.23.2.1 +14 -1 src/bin/test/test.1 From owner-cvs-src@FreeBSD.ORG Tue Aug 1 10:03:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B374E16A4DA; Tue, 1 Aug 2006 10:03:52 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70E6B43D45; Tue, 1 Aug 2006 10:03:52 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71A3qRC063445; Tue, 1 Aug 2006 10:03:52 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71A3qe7063444; Tue, 1 Aug 2006 10:03:52 GMT (envelope-from thompsa) Message-Id: <200608011003.k71A3qe7063444@repoman.freebsd.org> From: Andrew Thompson Date: Tue, 1 Aug 2006 10:03:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 10:03:52 -0000 thompsa 2006-08-01 10:03:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_bridge.c Log: MFC r1.67 Remove variables that are overridden by ether_ifattach(). Revision Changes Path 1.11.2.35 +0 -3 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 10:30:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FEB116A4DA; Tue, 1 Aug 2006 10:30:27 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3FA7543D5D; Tue, 1 Aug 2006 10:30:27 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71AURDe064759; Tue, 1 Aug 2006 10:30:27 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71AURni064758; Tue, 1 Aug 2006 10:30:27 GMT (envelope-from rwatson) Message-Id: <200608011030.k71AURni064758@repoman.freebsd.org> From: Robert Watson Date: Tue, 1 Aug 2006 10:30:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_sockbuf.c uipc_socket.c src/sys/sys socketvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 10:30:27 -0000 rwatson 2006-08-01 10:30:26 UTC FreeBSD src repository Modified files: sys/kern uipc_sockbuf.c uipc_socket.c sys/sys socketvar.h Log: Reimplement socket buffer tear-down in sofree(): as the socket is no longer referenced by other threads (hence our freeing it), we don't need to set the can't send and can't receive flags, wake up the consumers, perform two levels of locking, etc. Implement a fast-path teardown, sbdestroy(), which flushes and releases each socket buffer. A manual dom_dispose of the receive buffer is still required explicitly to GC any in-flight file descriptors, etc, before flushing the buffer. This results in a 9% UP performance improvement and 16% SMP performance improvement on a tight loop of socket();close(); in micro-benchmarking, but will likely also affect CPU-bound macro-benchmark performance. Revision Changes Path 1.163 +53 -13 src/sys/kern/uipc_sockbuf.c 1.276 +22 -14 src/sys/kern/uipc_socket.c 1.154 +1 -0 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 11:01:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEE2B16A4E1 for ; Tue, 1 Aug 2006 11:01:43 +0000 (UTC) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (82.193.106.18.ipnet.kiev.ua [82.193.106.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id A412C43D46 for ; Tue, 1 Aug 2006 11:01:42 +0000 (GMT) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (localhost [127.0.0.1]) by frdp.freebsd.org.ua (8.13.6/8.13.6) with ESMTP id k71B3l1P035109; Tue, 1 Aug 2006 14:03:47 +0300 (EEST) (envelope-from ru@FreeBSD.org.ua) Received: (from ru@localhost) by frdp.freebsd.org.ua (8.13.6/8.13.6/Submit) id k71B3lEi035104; Tue, 1 Aug 2006 14:03:47 +0300 (EEST) (envelope-from ru) Date: Tue, 1 Aug 2006 14:03:47 +0300 From: Ruslan Ermilov To: "M. Warner Losh" Message-ID: <20060801110347.GA35056@frdp.freebsd.org.ua> References: <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> <20060731.191558.-1253045041.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20060731.191558.-1253045041.imp@bsdimp.com> User-Agent: Mutt/1.5.12-2006-07-14 Cc: marcel@FreeBSD.org, yar@comp.chem.msu.su, cvs-all@FreeBSD.org, marcel@xcllnt.net, src-committers@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 11:01:43 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2006 at 07:15:58PM -0600, M. Warner Losh wrote: > It all started out '.if defined(NO_FOO)' or '.if !defined(NO_FOO)'. > This is why NO_OBJ and NO_MAN are that way. Then people wanted to > override the global default to force things to be linked statically. > This was so that things like init could always be static back in the > day. This accounts for NO_SHARED handling. It is a miss-mash. >=20 > That's why we're not supposed to set NO_FOO anymore. MK_FOO is set to > yes or no depending on defaults and WITH/WITHOUT_FOO. I'm not sure > why ru@ didn't include the above in his big cleanup. >=20 NO_MAN has been converted, and is preserved for backwards compatibility. NO_OBJ I didn't test yet. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFEzzUTqRfpzJluFF4RAhcWAJ4tAgwYAuLPGoANVwELv/qjliq6IQCfV6oV gD8kMBi05rb6j/UbH3qGbas= =qvVE -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q-- From owner-cvs-src@FreeBSD.ORG Tue Aug 1 14:02:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3124516A4DD; Tue, 1 Aug 2006 14:02:55 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0DF543D46; Tue, 1 Aug 2006 14:02:54 +0000 (GMT) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71E2sgq094354; Tue, 1 Aug 2006 14:02:54 GMT (envelope-from gallatin@repoman.freebsd.org) Received: (from gallatin@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71E2slR094353; Tue, 1 Aug 2006 14:02:54 GMT (envelope-from gallatin) Message-Id: <200608011402.k71E2slR094353@repoman.freebsd.org> From: Andrew Gallatin Date: Tue, 1 Aug 2006 14:02:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mxge if_mxge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 14:02:55 -0000 gallatin 2006-08-01 14:02:54 UTC FreeBSD src repository Modified files: sys/dev/mxge if_mxge.c Log: - add read only sysctl to indicate if write-combining was enabled - enable mxge_dummy_rdma() right after reset, and make sure to disable when detaching the driver. Revision Changes Path 1.8 +7 -1 src/sys/dev/mxge/if_mxge.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 15:26:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C83D216A4F4; Tue, 1 Aug 2006 15:26:43 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8614343DCB; Tue, 1 Aug 2006 15:26:09 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71FQ9HD001511; Tue, 1 Aug 2006 15:26:09 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71FQ9F8001510; Tue, 1 Aug 2006 15:26:09 GMT (envelope-from maxim) Message-Id: <200608011526.k71FQ9F8001510@repoman.freebsd.org> From: Maxim Konovalov Date: Tue, 1 Aug 2006 15:26:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 15:26:43 -0000 maxim 2006-08-01 15:26:09 UTC FreeBSD src repository Modified files: share/misc bsd-family-tree Log: o Reserve space for 3.x releases similar to 2.1. o 3.0.1 is a security/critical release. Submitted by: rpaulo@netbsd Revision Changes Path 1.107 +7 -7 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Tue Aug 1 15:29:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23E4C16A4DA; Tue, 1 Aug 2006 15:29:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D447243D72; Tue, 1 Aug 2006 15:29:46 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71FTkZl001733; Tue, 1 Aug 2006 15:29:46 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71FTkwV001732; Tue, 1 Aug 2006 15:29:46 GMT (envelope-from jhb) Message-Id: <200608011529.k71FTkwV001732@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 15:29:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ddb db_ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 15:29:47 -0000 jhb 2006-08-01 15:29:46 UTC FreeBSD src repository Modified files: sys/ddb db_ps.c Log: Some cosmetic tweaks: - Right justify 'pid' label. - Move the uid column to the right 2 columns so that the 3 process id columns (pid, ppid, pgrp) are grouped together. - Expand the uid column to 5 chars. - Don't indent the tid for multithreaded processes. Requested by: bde (1, 2, 4) Revision Changes Path 1.62 +10 -10 src/sys/ddb/db_ps.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 15:30:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E28BF16A4E0; Tue, 1 Aug 2006 15:30:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F58543D60; Tue, 1 Aug 2006 15:30:57 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71FUvKG001859; Tue, 1 Aug 2006 15:30:57 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71FUvTJ001858; Tue, 1 Aug 2006 15:30:57 GMT (envelope-from jhb) Message-Id: <200608011530.k71FUvTJ001858@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 15:30:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_fork.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 15:31:00 -0000 jhb 2006-08-01 15:30:56 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Don't lock each of the processes while looking for a pid. The allproc and proctree locks that we already hold provide sufficient protection. Revision Changes Path 1.260 +1 -5 src/sys/kern/kern_fork.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 15:32:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C15C616A4DA; Tue, 1 Aug 2006 15:32:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7128943D7B; Tue, 1 Aug 2006 15:32:25 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71FWPsC002001; Tue, 1 Aug 2006 15:32:25 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71FWPYF002000; Tue, 1 Aug 2006 15:32:25 GMT (envelope-from jhb) Message-Id: <200608011532.k71FWPYF002000@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 15:32:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsserver nfs_srvcache.c nfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 15:32:25 -0000 jhb 2006-08-01 15:32:25 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_srvcache.c nfs_syscalls.c Log: Use TAILQ_FOREACH_SAFE() in a couple of places. Revision Changes Path 1.42 +1 -2 src/sys/nfsserver/nfs_srvcache.c 1.106 +1 -3 src/sys/nfsserver/nfs_syscalls.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 16:27:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EB3716A4DE; Tue, 1 Aug 2006 16:27:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F33943D45; Tue, 1 Aug 2006 16:27:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71GRF81006559; Tue, 1 Aug 2006 16:27:15 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71GRFrm006558; Tue, 1 Aug 2006 16:27:15 GMT (envelope-from jhb) Message-Id: <200608011627.k71GRFrm006558@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 16:27:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsserver nfs.h nfs_srvcache.c nfs_srvsubs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 16:27:16 -0000 jhb 2006-08-01 16:27:15 UTC FreeBSD src repository Modified files: sys/nfsserver nfs.h nfs_srvcache.c nfs_srvsubs.c Log: - Add a new function nfsrv_destroycache() to tear down the server request cache when unloading the nfsserver module. This fixes a memory leak and a stale pointer. - Use callout_drain() rather than callout_stop() when unloading the nfsserver module. MFC after: 3 days Revision Changes Path 1.80 +1 -0 src/sys/nfsserver/nfs.h 1.43 +14 -2 src/sys/nfsserver/nfs_srvcache.c 1.143 +2 -1 src/sys/nfsserver/nfs_srvsubs.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 16:32:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23A5016A4E0; Tue, 1 Aug 2006 16:32:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0F6443D69; Tue, 1 Aug 2006 16:32:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71GWKOC006942; Tue, 1 Aug 2006 16:32:20 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71GWKMJ006941; Tue, 1 Aug 2006 16:32:20 GMT (envelope-from jhb) Message-Id: <200608011632.k71GWKMJ006941@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 16:32:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_syscalls.c src/sys/sys kernel.h sysent.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 16:32:24 -0000 jhb 2006-08-01 16:32:20 UTC FreeBSD src repository Modified files: sys/kern kern_syscalls.c sys/sys kernel.h sysent.h Log: Make system call modules a bit more robust: - If we fail to register the system call during MOD_LOAD, then note that so that we don't try to deregister it or invoke the chained event handler during the subsequent MOD_UNLOAD event. Doing the deregister when the register failed could result in trashing system call entries. - Add a SI_SUB_SYSCALLS just before starting up init and use that to register syscall modules instead of SI_SUB_DRIVERS. Registering system calls as late as possible increases the chances that any other module event handlers or SYSINITs in a module are executed to initialize the data in a kld before a syscall dependent on that data is able to be invoked. MFC after: 3 days Revision Changes Path 1.12 +11 -1 src/sys/kern/kern_syscalls.c 1.131 +1 -0 src/sys/sys/kernel.h 1.49 +1 -1 src/sys/sys/sysent.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 17:18:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A01B16A4DA; Tue, 1 Aug 2006 17:18:26 +0000 (UTC) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2BD643D78; Tue, 1 Aug 2006 17:18:25 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71HIP96018879; Tue, 1 Aug 2006 17:18:25 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71HIP4M018878; Tue, 1 Aug 2006 17:18:25 GMT (envelope-from wpaul) Message-Id: <200608011718.k71HIP4M018878@repoman.freebsd.org> From: Bill Paul Date: Tue, 1 Aug 2006 17:18:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 17:18:26 -0000 wpaul 2006-08-01 17:18:25 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c sys/pci if_rlreg.h Log: Another small update to the re(4) driver: - Change the workaround for the autopad/checksum offload bug so that instead of lying about the map size, we actually create a properly padded mbuf and map it as usual. The other trick works, but is ugly. This approach also gives us a chance to zero the pad space to avoid possibly leaking data. - With the PCIe devices, it looks issuing a TX command while there's already a transmission in progress doesn't have any effect. In other words, if you send two packets in rapid succession, the second one may end up sitting in the TX DMA ring until another transmit command is issued later in the future. Basically, if re_txeof() sees that there are still descriptors outstanding, it needs to manually resume the TX DMA channel by issuing another TX command to make sure all transmissions are flushed out. (The PCI devices seem to keep the TX channel moving until all descriptors have been consumed. I'm not sure why the PCIe devices behave differently.) (You can see this issue if you do the following test: plug an re(4) interface into another host via crossover cable, and from the other host do 'ping -c 2 ' to prime the ARP cache, then do 'ping -c 1 -s 1473 '. You're supposed to see two packets sent in response, but you may only see one. If you do 'ping -c 1 -s 1473 ' again, you'll see two packets, but one will be the missing fragment from the last ping, followed by one of the fragments from this ping.) - Add the PCI ID for the US Robotics 997902 NIC, which is based on the RTL8169S. - Add a tsleep() of 1 second in re_detach() after the interrupt handler is disconnected. This should allow any tasks queued up by the ISR to drain. Now, I know you're supposed to use taskqueue_drain() for this, but something about the way taskqueue_drain() works with taskqueue_fast queues doesn't seem quite right, and I refuse to be tricked into fixing it. Revision Changes Path 1.71 +52 -23 src/sys/dev/re/if_re.c 1.60 +8 -0 src/sys/pci/if_rlreg.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 17:28:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 537F016A4EF; Tue, 1 Aug 2006 17:28:11 +0000 (UTC) (envelope-from qingli@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D5F243D6B; Tue, 1 Aug 2006 17:28:11 +0000 (GMT) (envelope-from qingli@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71HSAh5019498; Tue, 1 Aug 2006 17:28:10 GMT (envelope-from qingli@repoman.freebsd.org) Received: (from qingli@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71HSA9m019497; Tue, 1 Aug 2006 17:28:10 GMT (envelope-from qingli) Message-Id: <200608011728.k71HSA9m019497@repoman.freebsd.org> From: Qing Li Date: Tue, 1 Aug 2006 17:28:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 17:28:11 -0000 qingli 2006-08-01 17:28:10 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: In vlan_input(), if the network interface does not perform h/w based vlan tag processing, the code will use bcopy() to remove the vlan tag field but the code copies 2 bytes too many, which essentially overwrites the protocol type field. Also, a tag value of -1 is generated for unrecognized interface type, which would cause an invalid memory access in the vlans[] array. In addition, removed a line of dead code and its associated comments. Reviewed by: sam Revision Changes Path 1.107 +9 -15 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 17:36:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE4A916A4E2; Tue, 1 Aug 2006 17:36:51 +0000 (UTC) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F182F43D5F; Tue, 1 Aug 2006 17:36:50 +0000 (GMT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71HaoxA020094; Tue, 1 Aug 2006 17:36:50 GMT (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71Hao1o020093; Tue, 1 Aug 2006 17:36:50 GMT (envelope-from wpaul) Message-Id: <200608011736.k71Hao1o020093@repoman.freebsd.org> From: Bill Paul Date: Tue, 1 Aug 2006 17:36:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 17:36:52 -0000 wpaul 2006-08-01 17:36:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/re if_re.c sys/pci if_rlreg.h Log: MFC: fix padding of short checksum offload frames, fix TX DMA channel stall, add USR NIC PCI ID, add tsleep() to re_detach() to avoid possible crash when unloading module Revision Changes Path 1.46.2.18 +52 -23 src/sys/dev/re/if_re.c 1.51.2.7 +8 -0 src/sys/pci/if_rlreg.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 17:40:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69C9516A4DA; Tue, 1 Aug 2006 17:40:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3286643D45; Tue, 1 Aug 2006 17:40:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71HeEkh020276; Tue, 1 Aug 2006 17:40:14 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71HeEsP020273; Tue, 1 Aug 2006 17:40:14 GMT (envelope-from jhb) Message-Id: <200608011740.k71HeEsP020273@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 17:40:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files src/sys/kern kern_mutex.c kern_sx.c subr_lock.c subr_turnstile.c subr_witness.c src/sys/sys lock.h mutex.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 17:40:14 -0000 jhb 2006-08-01 17:40:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files sys/kern kern_mutex.c kern_sx.c subr_turnstile.c subr_witness.c sys/sys lock.h mutex.h Added files: (Branch: RELENG_6) sys/kern subr_lock.c Log: MFC: Sync up with HEAD in some of the locking primitive details: - Teach WITNESS_SAVE() and WITNESS_RESTORE() to work with spin locks instead of only sleep locks. - Do the extra step required when destroying a locked spin mutex. - Initialize thread0.td_contested in init_turnstiles() rather than mutex_init(). - Add LOCK_CLASS() macro and sync with HEAD on its usage. For RELENG_6 this just maps to lock->lo_class. (In HEAD lo_class was removed an array index was encoded into lo_flags instead.) - Add subr_lock.c including adding lock_init() and lock_destroy() functions as we as moving the 'show lock' command into this file from kern_mutex.c. Revision Changes Path 1.1031.2.34 +1 -0 src/sys/conf/files 1.154.2.6 +31 -49 src/sys/kern/kern_mutex.c 1.25.2.2 +3 -16 src/sys/kern/kern_sx.c 1.4.2.1 +100 -0 src/sys/kern/subr_lock.c (new) 1.152.2.3 +1 -0 src/sys/kern/subr_turnstile.c 1.195.2.10 +48 -38 src/sys/kern/subr_witness.c 1.52.2.2 +12 -5 src/sys/sys/lock.h 1.79.2.3 +1 -1 src/sys/sys/mutex.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 18:38:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 873BD16A4DF; Tue, 1 Aug 2006 18:38:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5B7943D80; Tue, 1 Aug 2006 18:38:35 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71IcZEI027454; Tue, 1 Aug 2006 18:38:35 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71IcZxs027453; Tue, 1 Aug 2006 18:38:35 GMT (envelope-from jhb) Message-Id: <200608011838.k71IcZxs027453@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 18:38:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_mutex.c src/sys/sys mutex.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 18:38:41 -0000 jhb 2006-08-01 18:38:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_mutex.c sys/sys mutex.h Log: MFC: Write a magic value into mtx_lock when destroying a mutex. Revision Changes Path 1.154.2.7 +11 -0 src/sys/kern/kern_mutex.c 1.79.2.4 +5 -0 src/sys/sys/mutex.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 18:39:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B2DE16A4E1; Tue, 1 Aug 2006 18:39:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DA5C43D72; Tue, 1 Aug 2006 18:39:40 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71IdebT027534; Tue, 1 Aug 2006 18:39:40 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71IdebX027533; Tue, 1 Aug 2006 18:39:40 GMT (envelope-from jhb) Message-Id: <200608011839.k71IdebX027533@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 18:39:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 18:39:48 -0000 jhb 2006-08-01 18:39:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_mutex.c Log: MFC: Mark the thread pointer used during an adaptive spin volatile. Revision Changes Path 1.154.2.8 +1 -1 src/sys/kern/kern_mutex.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 19:03:15 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44D0816A4DF; Tue, 1 Aug 2006 19:03:15 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [205.211.164.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C6CD43D92; Tue, 1 Aug 2006 19:03:08 +0000 (GMT) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18]) by smarthost2.sentex.ca (8.13.6/8.13.4) with ESMTP id k71J37Ge052221; Tue, 1 Aug 2006 15:03:07 -0400 (EDT) (envelope-from mike@sentex.net) Received: from simian.sentex.net (simeon.sentex.ca [192.168.43.27]) by lava.sentex.ca (8.13.3P/8.13.3) with ESMTP id k71J36as079921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Aug 2006 15:03:06 -0400 (EDT) (envelope-from mike@sentex.net) Message-Id: <6.2.3.4.0.20060801145513.044677d0@64.7.153.2> X-Mailer: QUALCOMM Windows Eudora Version 6.2.3.4 Date: Tue, 01 Aug 2006 15:02:32 -0400 To: Michael Reifenberger , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org From: Mike Tancsa In-Reply-To: <200607211512.k6LFC3rR069466@repoman.freebsd.org> References: <200607211512.k6LFC3rR069466@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Cc: Subject: Re: cvs commit: src/sys/crypto/via padlock.c src/sys/dev/random probe.c src/sys/i386/i386 identcpu.c initcpu.c src/sys/i386/include md_var.h specialreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 19:03:15 -0000 Hi, This patch seems to incorrectly identify my C3 as a C7 It used to show CPU: VIA C3 Nehemiah+RNG+ACE (796.77-MHz 686-class CPU) Origin = "CentaurHauls" Id = 0x698 Stepping = 8 Features=0x381b03f real memory = 517865472 (493 MB) avail memory = 497397760 (474 MB) now it shows Timecounter "i8254" frequency 1193182 Hz quality 0 CPU: VIA C7 Esther+RNG+AES (796.77-MHz 686-class CPU) Origin = "CentaurHauls" Id = 0x698 Stepping = 8 Features=0x381b03f real memory = 517865472 (493 MB) avail memory = 497381376 (474 MB) PADLOCK: HW support loadedacpi0: on motherboard acpi0: Power Button (fixed) Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000 acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0 This is just a plain old C3 ---Mike At 11:12 AM 21/07/2006, Michael Reifenberger wrote: >mr 2006-07-21 15:12:03 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/crypto/via padlock.c > sys/dev/random probe.c > sys/i386/i386 identcpu.c initcpu.c > sys/i386/include md_var.h specialreg.h > Log: > MFC VIA C7 support. > > Obtained from: mostly OpenBSD > > Revision Changes Path > 1.1.2.2 +5 -16 src/sys/crypto/via/padlock.c > 1.4.2.1 +4 -13 src/sys/dev/random/probe.c > 1.145.2.4 +24 -8 src/sys/i386/i386/identcpu.c > 1.52.2.3 +83 -0 src/sys/i386/i386/initcpu.c > 1.72.2.3 +2 -0 src/sys/i386/include/md_var.h > 1.27.8.2 +35 -0 src/sys/i386/include/specialreg.h >_______________________________________________ >cvs-all@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/cvs-all >To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From owner-cvs-src@FreeBSD.ORG Tue Aug 1 19:06:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4F1716A4EA; Tue, 1 Aug 2006 19:06:07 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C58F43D6E; Tue, 1 Aug 2006 19:06:06 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71J66hI030436; Tue, 1 Aug 2006 19:06:06 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71J66pX030435; Tue, 1 Aug 2006 19:06:06 GMT (envelope-from alc) Message-Id: <200608011906.k71J66pX030435@repoman.freebsd.org> From: Alan Cox Date: Tue, 1 Aug 2006 19:06:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/arm/arm pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c src/sys/powerpc/powerpc mmu_if.m mmu_oea.c pmap_dispatch.c src/sys/sparc64/sparc64 pmap.c src/sys/vm pmap.h vm_object.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 19:06:07 -0000 alc 2006-08-01 19:06:06 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/arm/arm pmap.c sys/i386/i386 pmap.c sys/ia64/ia64 pmap.c sys/powerpc/powerpc mmu_if.m mmu_oea.c pmap_dispatch.c sys/sparc64/sparc64 pmap.c sys/vm pmap.h vm_object.c vm_page.c vm_pageout.c Log: Complete the transition from pmap_page_protect() to pmap_remove_write(). Originally, I had adopted sparc64's name, pmap_clear_write(), for the function that is now pmap_remove_write(). However, this function is more like pmap_remove_all() than like pmap_clear_modify() or pmap_clear_reference(), hence, the name change. The higher-level rationale behind this change is described in src/sys/amd64/amd64/pmap.c revision 1.567. The short version is that I'm trying to clean up and fix our support for execute access. Reviewed by: marcel@ (ia64) Revision Changes Path 1.568 +1 -18 src/sys/amd64/amd64/pmap.c 1.67 +1 -27 src/sys/arm/arm/pmap.c 1.572 +1 -18 src/sys/i386/i386/pmap.c 1.178 +37 -34 src/sys/ia64/ia64/pmap.c 1.6 +12 -14 src/sys/powerpc/powerpc/mmu_if.m 1.111 +44 -77 src/sys/powerpc/powerpc/mmu_oea.c 1.7 +6 -6 src/sys/powerpc/powerpc/pmap_dispatch.c 1.157 +1 -18 src/sys/sparc64/sparc64/pmap.c 1.79 +1 -2 src/sys/vm/pmap.h 1.363 +3 -3 src/sys/vm/vm_object.c 1.319 +1 -1 src/sys/vm/vm_page.c 1.276 +1 -1 src/sys/vm/vm_pageout.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 21:30:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3796B16A4DE; Tue, 1 Aug 2006 21:30:08 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC44743D5A; Tue, 1 Aug 2006 21:30:07 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71LU7Xx050605; Tue, 1 Aug 2006 21:30:07 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71LU7hq050604; Tue, 1 Aug 2006 21:30:07 GMT (envelope-from marcel) Message-Id: <200608012130.k71LU7hq050604@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 Aug 2006 21:30:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/uart uart_tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 21:30:08 -0000 marcel 2006-08-01 21:30:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/uart uart_tty.c Log: MFC rev. 1.29: Propagate overrun conditions to the TTY layer. Revision Changes Path 1.22.2.2 +2 -0 src/sys/dev/uart/uart_tty.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 21:52:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF2CD16A4DF; Tue, 1 Aug 2006 21:52:02 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDD3C43D8B; Tue, 1 Aug 2006 21:51:29 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71LpJE9051741; Tue, 1 Aug 2006 21:51:19 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71LpJNa051740; Tue, 1 Aug 2006 21:51:19 GMT (envelope-from marcel) Message-Id: <200608012151.k71LpJNa051740@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 Aug 2006 21:51:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sys serial.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 21:52:03 -0000 marcel 2006-08-01 21:51:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sys serial.h Log: MFC rev 1.3, 1.4 and 1.5: o Add defines for the 5 interrupt sources typical for serial devices. o Add bit masks for the various definitions. Revision Changes Path 1.2.8.1 +45 -17 src/sys/sys/serial.h From owner-cvs-src@FreeBSD.ORG Tue Aug 1 22:19:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CF9D16A4DE; Tue, 1 Aug 2006 22:19:02 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14C0843D53; Tue, 1 Aug 2006 22:19:02 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71MJ1Dk054823; Tue, 1 Aug 2006 22:19:01 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71MJ19N054822; Tue, 1 Aug 2006 22:19:01 GMT (envelope-from sobomax) Message-Id: <200608012219.k71MJ19N054822@repoman.freebsd.org> From: Maxim Sobolev Date: Tue, 1 Aug 2006 22:19:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.include.dist src/include Makefile src/share/man/man4/man4.powerpc Makefile powermac_nvram.4 src/sys/dev/powermac_nvram powermac_nvram.c powermac_nvramvar.h src/sys/modules Makefile src/sys/modules/powermac_nvram Makefile ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 22:19:02 -0000 sobomax 2006-08-01 22:19:01 UTC FreeBSD src repository Modified files: etc/mtree BSD.include.dist include Makefile sys/modules Makefile usr.sbin Makefile sys/conf files.powerpc sys/powerpc/conf GENERIC Added files: share/man/man4/man4.powerpc powermac_nvram.4 Makefile sys/dev/powermac_nvram powermac_nvram.c powermac_nvramvar.h sys/modules/powermac_nvram Makefile usr.sbin/nvram Makefile nvram.8 nvram.c Log: Add device to access and modify Open Firmware NVRAM settings in PowerPC-based Apple's machines and small utility to do it from userland modelled after the similar utility in Darwin/OSX. Only tested on 1.25GHz G4 Mac Mini. MFC after: 1 month Revision Changes Path 1.107 +2 -0 src/etc/mtree/BSD.include.dist 1.262 +5 -1 src/include/Makefile 1.1 +7 -0 src/share/man/man4/man4.powerpc/Makefile (new) 1.1 +58 -0 src/share/man/man4/man4.powerpc/powermac_nvram.4 (new) 1.57 +2 -0 src/sys/conf/files.powerpc 1.1 +423 -0 src/sys/dev/powermac_nvram/powermac_nvram.c (new) 1.1 +68 -0 src/sys/dev/powermac_nvram/powermac_nvramvar.h (new) 1.506 +2 -0 src/sys/modules/Makefile 1.1 +8 -0 src/sys/modules/powermac_nvram/Makefile (new) 1.59 +3 -0 src/sys/powerpc/conf/GENERIC 1.354 +2 -0 src/usr.sbin/Makefile 1.1 +8 -0 src/usr.sbin/nvram/Makefile (new) 1.1 +119 -0 src/usr.sbin/nvram/nvram.8 (new) 1.1 +222 -0 src/usr.sbin/nvram/nvram.c (new) From owner-cvs-src@FreeBSD.ORG Tue Aug 1 22:30:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5AABB16A4DF; Tue, 1 Aug 2006 22:30:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EAA3E43D49; Tue, 1 Aug 2006 22:30:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71MUt9V055521; Tue, 1 Aug 2006 22:30:55 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71MUtJ6055520; Tue, 1 Aug 2006 22:30:55 GMT (envelope-from jhb) Message-Id: <200608012230.k71MUtJ6055520@repoman.freebsd.org> From: John Baldwin Date: Tue, 1 Aug 2006 22:30:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ddb db_ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 22:30:56 -0000 jhb 2006-08-01 22:30:55 UTC FreeBSD src repository Modified files: sys/ddb db_ps.c Log: Fix two nits in the ps header that offset each other making them largely unnoticable. Revision Changes Path 1.63 +6 -6 src/sys/ddb/db_ps.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 22:57:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2DE616A4DA; Tue, 1 Aug 2006 22:57:07 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A305243D45; Tue, 1 Aug 2006 22:57:07 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71Mv7Wa057353; Tue, 1 Aug 2006 22:57:07 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71Mv7Y0057352; Tue, 1 Aug 2006 22:57:07 GMT (envelope-from marcel) Message-Id: <200608012257.k71Mv7Y0057352@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 1 Aug 2006 22:57:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/uart uart_bus_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 22:57:08 -0000 marcel 2006-08-01 22:57:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/uart uart_bus_pci.c Log: MFC revs 1.7, 1.8 and 1.9: o Add support for non-standard rclk values. o Add Quatech ID o Add 2 NEC IDs o Add 2 HP IDs o Add 5 Timedia IDs Revision Changes Path 1.5.2.2 +67 -30 src/sys/dev/uart/uart_bus_pci.c From owner-cvs-src@FreeBSD.ORG Tue Aug 1 23:17:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAAB416A4DA; Tue, 1 Aug 2006 23:17:33 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA25643D45; Tue, 1 Aug 2006 23:17:33 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k71NHXki060436; Tue, 1 Aug 2006 23:17:33 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k71NHXIF060435; Tue, 1 Aug 2006 23:17:33 GMT (envelope-from pjd) Message-Id: <200608012317.k71NHXIF060435@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 1 Aug 2006 23:17:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 23:17:34 -0000 pjd 2006-08-01 23:17:33 UTC FreeBSD src repository Modified files: sys/geom/mirror g_mirror.c sys/geom/raid3 g_raid3.c Log: Don't use f-word in comments. We are gentlemans. Pointed out by: Maciej Sobczak Revision Changes Path 1.86 +1 -1 src/sys/geom/mirror/g_mirror.c 1.70 +1 -1 src/sys/geom/raid3/g_raid3.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 00:19:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1297416A4DA; Wed, 2 Aug 2006 00:19:23 +0000 (UTC) (envelope-from darren.pilgrim@bitfreak.org) Received: from mail.twinthornes.com (mail.twinthornes.com [65.75.198.147]) by mx1.FreeBSD.org (Postfix) with ESMTP id A306143D46; Wed, 2 Aug 2006 00:19:20 +0000 (GMT) (envelope-from darren.pilgrim@bitfreak.org) Received: from [10.242.169.22] (c-67-171-135-169.hsd1.or.comcast.net [67.171.135.169]) by mail.twinthornes.com (Postfix) with ESMTP id 7F715F7C; Tue, 1 Aug 2006 17:19:19 -0700 (PDT) Message-ID: <44CFEF87.8010005@bitfreak.org> Date: Tue, 01 Aug 2006 17:19:19 -0700 From: Darren Pilgrim User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200608012317.k71NHXIF060435@repoman.freebsd.org> In-Reply-To: <200608012317.k71NHXIF060435@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 00:19:23 -0000 Pawel Jakub Dawidek wrote: > pjd 2006-08-01 23:17:33 UTC > > FreeBSD src repository > > Modified files: > sys/geom/mirror g_mirror.c > sys/geom/raid3 g_raid3.c > Log: > Don't use f-word in comments. We are gentlemans. There's a typo two lines down in both files: * If there were writes, device is broken, sorry. * I think the best choice here is don't touch - * this disk and inform the user laudly. + * this disk and inform the user loudly. */ I'll submit a PR if so asked. -- Darren Pilgrim From owner-cvs-src@FreeBSD.ORG Wed Aug 2 00:32:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5009716A4E6; Wed, 2 Aug 2006 00:32:27 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8757043D46; Wed, 2 Aug 2006 00:32:26 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k720WOlQ078510; Wed, 2 Aug 2006 04:32:24 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k720WNLU078505; Wed, 2 Aug 2006 04:32:23 +0400 (MSD) (envelope-from yar) Date: Wed, 2 Aug 2006 04:32:23 +0400 From: Yar Tikhiy To: Qing Li Message-ID: <20060802003223.GA77391@comp.chem.msu.su> References: <200608011728.k71HSA9m019497@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608011728.k71HSA9m019497@repoman.freebsd.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, sam@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 00:32:27 -0000 On Tue, Aug 01, 2006 at 05:28:10PM +0000, Qing Li wrote: > qingli 2006-08-01 17:28:10 UTC > > FreeBSD src repository > > Modified files: > sys/net if_vlan.c > Log: > In vlan_input(), if the network interface does not perform h/w based > vlan tag processing, the code will use bcopy() to remove the vlan > tag field but the code copies 2 bytes too many, which essentially > overwrites the protocol type field. This had not been true until you removed the line of "dead" code. > Also, a tag value of -1 is generated for unrecognized interface type, > which would cause an invalid memory access in the vlans[] array. This is the only part of your change I like in theory, but its implementation is rather questionable. See below. > In addition, removed a line of dead code and its associated comments. The code was not dead, you just misunderstood it. See below. > Reviewed by: sam I think now I may commit some code Sam didn't dig a couple of years ago ;-) > Revision Changes Path > 1.107 +9 -15 src/sys/net/if_vlan.c > =================================================================== > RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v > retrieving revision 1.106 > retrieving revision 1.107 > diff -u -p -r1.106 -r1.107 > --- src/sys/net/if_vlan.c 2006/07/09 06:04:00 1.106 > +++ src/sys/net/if_vlan.c 2006/08/01 17:28:10 1.107 > @@ -26,7 +26,7 @@ > * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > * > - * $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v 1.106 2006/07/09 06:04:00 sam Exp $ > + * $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v 1.107 2006/08/01 17:28:10 qingli Exp $ > */ > > /* > @@ -917,21 +917,15 @@ vlan_input(struct ifnet *ifp, struct mbu > __func__, ntohs(evl->evl_encap_proto))); > > tag = EVL_VLANOFTAG(ntohs(evl->evl_tag)); > - > - /* > - * Restore the original ethertype. We'll remove > - * the encapsulation after we've found the vlan > - * interface corresponding to the tag. > - */ > - evl->evl_encap_proto = evl->evl_proto; This "dead" code copied the ethertype value saved in the dot1q mini-header to the outer Ethernet header's ethertype field. I.e.: +---------------+ V | +---------+---------+--------+-------+--------+----------- | dst | src | proto1 | tag | proto0 | payload... +---------+---------+--------+-------+--------+----------- Then the outer Ethernet header was as before VLAN encapsulation. That was why we could bcopy full ETHER_HDR_LEN bytes later. > break; > default: > - tag = (uint16_t) -1; > -#ifdef INVARIANTS > - panic("%s: unsupported if_type (%u)", > - __func__, ifp->if_type); > +#ifdef DEBUG > + /* XXX rate limit? */ > + if_printf(ifp, "unsupported if_type %u", ifp->if_type); > #endif Do you see this message on your console so often that you think it needs rate limiting? The former code paniced here because it could be reached only due to a programming error elsewhere. See ether_demux() in if_ethersubr.c and vlan_config() in this file. This default case can never be reached due to a bogus frame coming from the network. > - break; > + m_freem(m); > + ifp->if_noproto++; /* XXX? */ Nothing wrong with using if_noproto here IMHO, but this still "just can't happen". > + return; > } > } > > @@ -952,12 +946,12 @@ vlan_input(struct ifnet *ifp, struct mbu > if (mtag == NULL) { > /* > * Packet had an in-line encapsulation header; > - * remove it. The original header has already > - * been fixed up above. > + * remove it. Note that we leave the type field > + * unchanged; we only copy up the mac addresses. > */ > bcopy(mtod(m, caddr_t), > mtod(m, caddr_t) + ETHER_VLAN_ENCAP_LEN, > - ETHER_HDR_LEN); > + ETHER_HDR_LEN - ETHER_TYPE_LEN); > m_adj(m, ETHER_VLAN_ENCAP_LEN); > } Removing the "dead" assignment to evl->evl_encap_proto above and reducing the bcopy window by 2 bytes here is a nano-optimization. Which is worse, it smuggles hidden dot1q details in this otherwise encapsulation-neutral block of code. E.g., I could use the former code for both dot1q and ISL privately by just redefining ETHER_VLAN_ENCAP_LEN. Grand total: I would greately appreciate if you backed out this change and then fixed the tag value of -1 alone, but let me review that first. Thanks! -- Yar From owner-cvs-src@FreeBSD.ORG Wed Aug 2 00:40:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6348316A4DD; Wed, 2 Aug 2006 00:40:58 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA8AE43D4C; Wed, 2 Aug 2006 00:40:57 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k720euQA026130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Aug 2006 17:40:57 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44CFF498.1040008@errno.com> Date: Tue, 01 Aug 2006 17:40:56 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.4 (X11/20060724) MIME-Version: 1.0 To: Yar Tikhiy References: <200608011728.k71HSA9m019497@repoman.freebsd.org> <20060802003223.GA77391@comp.chem.msu.su> In-Reply-To: <20060802003223.GA77391@comp.chem.msu.su> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Qing Li , sam@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 00:40:58 -0000 Yar Tikhiy wrote: > On Tue, Aug 01, 2006 at 05:28:10PM +0000, Qing Li wrote: >> qingli 2006-08-01 17:28:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/net if_vlan.c >> Log: >> In vlan_input(), if the network interface does not perform h/w based >> vlan tag processing, the code will use bcopy() to remove the vlan >> tag field but the code copies 2 bytes too many, which essentially >> overwrites the protocol type field. > > This had not been true until you removed the line of "dead" code. > >> Also, a tag value of -1 is generated for unrecognized interface type, >> which would cause an invalid memory access in the vlans[] array. > > This is the only part of your change I like in theory, but its > implementation is rather questionable. See below. > >> In addition, removed a line of dead code and its associated comments. > > The code was not dead, you just misunderstood it. See below. > >> Reviewed by: sam > > I think now I may commit some code Sam didn't dig a couple > of years ago ;-) > >> Revision Changes Path >> 1.107 +9 -15 src/sys/net/if_vlan.c > >> =================================================================== >> RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v >> retrieving revision 1.106 >> retrieving revision 1.107 >> diff -u -p -r1.106 -r1.107 >> --- src/sys/net/if_vlan.c 2006/07/09 06:04:00 1.106 >> +++ src/sys/net/if_vlan.c 2006/08/01 17:28:10 1.107 >> @@ -26,7 +26,7 @@ >> * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >> * SUCH DAMAGE. >> * >> - * $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v 1.106 2006/07/09 06:04:00 sam Exp $ >> + * $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sys/net/if_vlan.c,v 1.107 2006/08/01 17:28:10 qingli Exp $ >> */ >> >> /* >> @@ -917,21 +917,15 @@ vlan_input(struct ifnet *ifp, struct mbu >> __func__, ntohs(evl->evl_encap_proto))); >> >> tag = EVL_VLANOFTAG(ntohs(evl->evl_tag)); >> - >> - /* >> - * Restore the original ethertype. We'll remove >> - * the encapsulation after we've found the vlan >> - * interface corresponding to the tag. >> - */ >> - evl->evl_encap_proto = evl->evl_proto; > > This "dead" code copied the ethertype value saved in the dot1q > mini-header to the outer Ethernet header's ethertype field. I.e.: > > +---------------+ > V | > +---------+---------+--------+-------+--------+----------- > | dst | src | proto1 | tag | proto0 | payload... > +---------+---------+--------+-------+--------+----------- > > Then the outer Ethernet header was as before VLAN encapsulation. > That was why we could bcopy full ETHER_HDR_LEN bytes later. Correct, but with the short bcopy this is no longer needed. proto0 is left intact and only dst+src are copied up. > >> break; >> default: >> - tag = (uint16_t) -1; >> -#ifdef INVARIANTS >> - panic("%s: unsupported if_type (%u)", >> - __func__, ifp->if_type); >> +#ifdef DEBUG >> + /* XXX rate limit? */ >> + if_printf(ifp, "unsupported if_type %u", ifp->if_type); >> #endif > > Do you see this message on your console so often that you think it > needs rate limiting? The former code paniced here because it could > be reached only due to a programming error elsewhere. See ether_demux() > in if_ethersubr.c and vlan_config() in this file. This default > case can never be reached due to a bogus frame coming from the > network. I wrote the XXX comment. The previous code allowed an array index w/ -1 when the panic was not present. Rather than permit this incorrect code to remain the proper cleanup was done instead. I added a printf because if that action ever happened it was clearly a mistake. Qing Li wrapped it under DEBUG since the statistic already accounts for it and leaving it as a straight printf left open the possibility of spam'ing the console. I do not understand your complaint. Are you suggesting we leave panic's in code paths that we can recover from? Are you suggesting we not comment places where alternative choices might be made? > >> - break; >> + m_freem(m); >> + ifp->if_noproto++; /* XXX? */ > > Nothing wrong with using if_noproto here IMHO, but this still "just > can't happen". > >> + return; >> } >> } >> >> @@ -952,12 +946,12 @@ vlan_input(struct ifnet *ifp, struct mbu >> if (mtag == NULL) { >> /* >> * Packet had an in-line encapsulation header; >> - * remove it. The original header has already >> - * been fixed up above. >> + * remove it. Note that we leave the type field >> + * unchanged; we only copy up the mac addresses. >> */ >> bcopy(mtod(m, caddr_t), >> mtod(m, caddr_t) + ETHER_VLAN_ENCAP_LEN, >> - ETHER_HDR_LEN); >> + ETHER_HDR_LEN - ETHER_TYPE_LEN); >> m_adj(m, ETHER_VLAN_ENCAP_LEN); >> } > > Removing the "dead" assignment to evl->evl_encap_proto above and > reducing the bcopy window by 2 bytes here is a nano-optimization. > Which is worse, it smuggles hidden dot1q details in this otherwise > encapsulation-neutral block of code. E.g., I could use the former > code for both dot1q and ISL privately by just redefining > ETHER_VLAN_ENCAP_LEN. > > Grand total: I would greately appreciate if you backed out this > change and then fixed the tag value of -1 alone, but let me review > that first. Thanks! > We obviously had no idea you were interested in this. I was asked to review the original change and noticed the bogus panic code and suggested it be fixed at the same time. I already pointed out to Qing Li that the new code is equivalent to the old but he preferred it and since it does nothing wrong I don't see the point in arguing about it--work it out with him privately if you want it reverted. Sam From owner-cvs-src@FreeBSD.ORG Wed Aug 2 00:45:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CD5216A4E7; Wed, 2 Aug 2006 00:45:28 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA78743D49; Wed, 2 Aug 2006 00:45:27 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k720jRi9066011; Wed, 2 Aug 2006 00:45:27 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k720jR0x066010; Wed, 2 Aug 2006 00:45:27 GMT (envelope-from rwatson) Message-Id: <200608020045.k720jR0x066010@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 00:45:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 00:45:28 -0000 rwatson 2006-08-02 00:45:27 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move updated of 'numopensockets' from bottom of sodealloc() to the top, eliminating a second set of identical mutex operations at the bottom. This allows brief exceeding of the max sockets limit, but only by sockets in the last stages of being torn down. Revision Changes Path 1.277 +1 -3 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 01:36:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A0C16A4DA; Wed, 2 Aug 2006 01:36:40 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5271F43D45; Wed, 2 Aug 2006 01:36:40 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k721aehP077896; Wed, 2 Aug 2006 01:36:40 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k721aemR077895; Wed, 2 Aug 2006 01:36:40 GMT (envelope-from thompsa) Message-Id: <200608020136.k721aemR077895@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 01:36:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bridgestp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 01:36:40 -0000 thompsa 2006-08-02 01:36:40 UTC FreeBSD src repository Modified files: sys/net bridgestp.c Log: Be sure to disable the port when removing it from STP. Revision Changes Path 1.16 +2 -0 src/sys/net/bridgestp.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 01:55:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C2B616A4DF; Wed, 2 Aug 2006 01:55:22 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5BA943D45; Wed, 2 Aug 2006 01:55:13 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k721spTu079374; Wed, 2 Aug 2006 05:54:51 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k721smAt079373; Wed, 2 Aug 2006 05:54:48 +0400 (MSD) (envelope-from yar) Date: Wed, 2 Aug 2006 05:54:48 +0400 From: Yar Tikhiy To: Sam Leffler Message-ID: <20060802015448.GC77391@comp.chem.msu.su> References: <200608011728.k71HSA9m019497@repoman.freebsd.org> <20060802003223.GA77391@comp.chem.msu.su> <44CFF498.1040008@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44CFF498.1040008@errno.com> User-Agent: Mutt/1.5.9i Cc: Qing Li , sam@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 01:55:22 -0000 On Tue, Aug 01, 2006 at 05:40:56PM -0700, Sam Leffler wrote: > > We obviously had no idea you were interested in this. I was asked to > review the original change and noticed the bogus panic code and > suggested it be fixed at the same time. I already pointed out to Qing > Li that the new code is equivalent to the old but he preferred it and > since it does nothing wrong I don't see the point in arguing about > it--work it out with him privately if you want it reverted. Sam, you're right, I am not going to argue over this topic with you here. I just thought I should add you to Cc because your name was mentioned. Qing Li can support his commits by his own now, and I'll be glad to communicate with him. -- Yar From owner-cvs-src@FreeBSD.ORG Wed Aug 2 02:37:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E2F216A4E0; Wed, 2 Aug 2006 02:37:13 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45E3A43D79; Wed, 2 Aug 2006 02:37:00 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k722b0UQ081917; Wed, 2 Aug 2006 02:37:00 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k722b0pM081916; Wed, 2 Aug 2006 02:37:00 GMT (envelope-from yongari) Message-Id: <200608020237.k722b0pM081916@repoman.freebsd.org> From: Pyun YongHyeon Date: Wed, 2 Aug 2006 02:37:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sk if_sk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 02:37:13 -0000 yongari 2006-08-02 02:37:00 UTC FreeBSD src repository Modified files: sys/dev/sk if_sk.c Log: Fix incorrect busy check for PHY write operation. While I'm here remove unnecessary return statement. Revision Changes Path 1.129 +2 -4 src/sys/dev/sk/if_sk.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 02:47:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA8C416A4E9; Wed, 2 Aug 2006 02:47:27 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99B7743D49; Wed, 2 Aug 2006 02:47:27 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k722lRAs082456; Wed, 2 Aug 2006 02:47:27 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k722lRC2082455; Wed, 2 Aug 2006 02:47:27 GMT (envelope-from thompsa) Message-Id: <200608020247.k722lRC2082455@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 02:47:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bridgestp.c bridgestp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 02:47:28 -0000 thompsa 2006-08-02 02:47:27 UTC FreeBSD src repository Modified files: sys/net bridgestp.c bridgestp.h Log: Add a callback so we can notify the parent bridge that a port state change has occured, we need to do this from a taskqueue to avoid a LOR with the if_bridge mutex. Revision Changes Path 1.17 +34 -3 src/sys/net/bridgestp.c 1.4 +9 -1 src/sys/net/bridgestp.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 02:51:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 460AE16A4DD; Wed, 2 Aug 2006 02:51:47 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF5AE43D6E; Wed, 2 Aug 2006 02:51:42 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k722pgFS082690; Wed, 2 Aug 2006 02:51:42 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k722pgFS082689; Wed, 2 Aug 2006 02:51:42 GMT (envelope-from thompsa) Message-Id: <200608020251.k722pgFS082689@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 02:51:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net bridgestp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 02:51:47 -0000 thompsa 2006-08-02 02:51:42 UTC FreeBSD src repository Modified files: sys/net bridgestp.c Log: Fix style in the last commit, the variable declaration goes at the top of the function. Revision Changes Path 1.18 +2 -1 src/sys/net/bridgestp.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 02:59:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C62816A4DD; Wed, 2 Aug 2006 02:59:25 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FFD243D45; Wed, 2 Aug 2006 02:59:25 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k722xOcH083019; Wed, 2 Aug 2006 02:59:24 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k722xOkv083018; Wed, 2 Aug 2006 02:59:24 GMT (envelope-from thompsa) Message-Id: <200608020259.k722xOkv083018@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 02:59:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 02:59:25 -0000 thompsa 2006-08-02 02:59:24 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: Tell bridgestp that we are about to free the memory so it can cleanup. Revision Changes Path 1.74 +3 -0 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 03:37:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71D4716A508 for ; Wed, 2 Aug 2006 03:37:19 +0000 (UTC) (envelope-from qingli@speakeasy.net) Received: from webmail2.sea5.speakeasy.net (webmail2.speakeasy.net [69.17.117.49]) by mx1.FreeBSD.org (Postfix) with ESMTP id B82F443D79 for ; Wed, 2 Aug 2006 03:37:06 +0000 (GMT) (envelope-from qingli@speakeasy.net) Received: (qmail 16189 invoked from network); 2 Aug 2006 03:37:05 -0000 Received: from localhost (HELO webmail2) ([127.0.0.1]) (envelope-sender ) by localhost (qmail-ldap-1.03) with SMTP for ; 2 Aug 2006 03:37:05 -0000 Received: from 12.178.37.11 (unverified [12.178.37.11]) by webmail2 (VisualMail 4.0) with WEBMAIL id 11007; Wed, 02 Aug 2006 03:37:05 +0000 From: "Qing Li" To: "Yar Tikhiy" , "Qing Li" Importance: Normal Sensitivity: Normal Message-ID: X-Mailer: Mintersoft VisualMail, Build 4.0.111601 X-Originating-IP: [12.178.37.11] Date: Wed, 02 Aug 2006 03:37:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, sam@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 03:37:19 -0000 > > Removing the "dead" assignment to evl->evl_encap_proto above and > reducing the bcopy window by 2 bytes here is a nano-optimization. > Which is worse, it smuggles hidden dot1q details in this otherwise > encapsulation-neutral block of code. E.g., I could use the former > code for both dot1q and ISL privately by just redefining > ETHER_VLAN_ENCAP_LEN. > You are right. > > Grand total: I would greately appreciate if you backed out this > change and then fixed the tag value of -1 alone, but let me review > that first. Thanks! > Okay. Thanks, -- Qing From owner-cvs-src@FreeBSD.ORG Wed Aug 2 03:54:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B65416A4E0; Wed, 2 Aug 2006 03:54:32 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E45C143D55; Wed, 2 Aug 2006 03:54:29 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k723sTZ0087786; Wed, 2 Aug 2006 03:54:29 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k723sTNl087785; Wed, 2 Aug 2006 03:54:29 GMT (envelope-from thompsa) Message-Id: <200608020354.k723sTNl087785@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 03:54:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 03:54:32 -0000 thompsa 2006-08-02 03:54:29 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: - Use the new bridgestp callback to once again flush our bridge routes when an interface is disabled. - Log port changes to syslog, defaulting to off Revision Changes Path 1.75 +38 -2 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 04:11:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6C9816A4DE; Wed, 2 Aug 2006 04:11:28 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1B843D77; Wed, 2 Aug 2006 04:11:25 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k724BPZS089933; Wed, 2 Aug 2006 04:11:25 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k724BPPK089932; Wed, 2 Aug 2006 04:11:25 GMT (envelope-from thompsa) Message-Id: <200608020411.k724BPPK089932@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 2 Aug 2006 04:11:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 if_bridge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 04:11:28 -0000 thompsa 2006-08-02 04:11:25 UTC FreeBSD src repository Modified files: share/man/man4 if_bridge.4 Log: Document the log_stp variable. Revision Changes Path 1.19 +6 -0 src/share/man/man4/if_bridge.4 From owner-cvs-src@FreeBSD.ORG Wed Aug 2 04:27:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E05716A4DD; Wed, 2 Aug 2006 04:27:31 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F86143D46; Wed, 2 Aug 2006 04:27:31 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k724RV8R090699; Wed, 2 Aug 2006 04:27:31 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k724RVrP090698; Wed, 2 Aug 2006 04:27:31 GMT (envelope-from yongari) Message-Id: <200608020427.k724RVrP090698@repoman.freebsd.org> From: Pyun YongHyeon Date: Wed, 2 Aug 2006 04:27:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sk if_sk.c if_skreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 04:27:31 -0000 yongari 2006-08-02 04:27:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sk if_sk.c if_skreg.h Log: MFC: if_sk.c, 1.128 if_skreg.h, 1.38 to RELENG_6 Add device ID for second generation D-Link DGE-530T. Revision Changes Path 1.125.2.4 +8 -2 src/sys/dev/sk/if_sk.c 1.36.2.3 +2 -1 src/sys/dev/sk/if_skreg.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 04:54:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3070E16A4DA; Wed, 2 Aug 2006 04:54:15 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9AFC43D49; Wed, 2 Aug 2006 04:54:14 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k724sEAY000322; Wed, 2 Aug 2006 04:54:14 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k724sE5u000321; Wed, 2 Aug 2006 04:54:14 GMT (envelope-from sam) Message-Id: <200608020454.k724sE5u000321@repoman.freebsd.org> From: Sam Leffler Date: Wed, 2 Aug 2006 04:54:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ral rt2560.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 04:54:15 -0000 sam 2006-08-02 04:54:14 UTC FreeBSD src repository Modified files: sys/dev/ral rt2560.c Log: remove unnecessary null ptr check Coverity ID: 173911 Revision Changes Path 1.7 +1 -2 src/sys/dev/ral/rt2560.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 04:55:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 207CA16A4DA; Wed, 2 Aug 2006 04:55:05 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA35443D46; Wed, 2 Aug 2006 04:55:04 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k724t4ix000394; Wed, 2 Aug 2006 04:55:04 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k724t4UM000393; Wed, 2 Aug 2006 04:55:04 GMT (envelope-from sam) Message-Id: <200608020455.k724t4UM000393@repoman.freebsd.org> From: Sam Leffler Date: Wed, 2 Aug 2006 04:55:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_ural.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 04:55:05 -0000 sam 2006-08-02 04:55:04 UTC FreeBSD src repository Modified files: sys/dev/usb if_ural.c Log: remove unneccessary null ptr check Coverity ID: 173918 Revision Changes Path 1.43 +1 -2 src/sys/dev/usb/if_ural.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 05:28:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D37416A4DD; Wed, 2 Aug 2006 05:28:53 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1067F43D45; Wed, 2 Aug 2006 05:28:53 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k725Sqv9003654; Wed, 2 Aug 2006 05:28:52 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k725SqCA003653; Wed, 2 Aug 2006 05:28:52 GMT (envelope-from yongari) Message-Id: <200608020528.k725SqCA003653@repoman.freebsd.org> From: Pyun YongHyeon Date: Wed, 2 Aug 2006 05:28:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc dcphy.c pnphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 05:28:53 -0000 yongari 2006-08-02 05:28:52 UTC FreeBSD src repository Modified files: sys/dev/dc dcphy.c pnphy.c Log: Replace hard-coded magic constants to system defined constants (BUS_PROBE_DEFAULT, BUS_PROBE_GENERIC etc). These pseudo PHY drivers were forgotten from the conversion due to the repo copy to dc driver location. Revision Changes Path 1.32 +1 -1 src/sys/dev/dc/dcphy.c 1.21 +1 -1 src/sys/dev/dc/pnphy.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:02:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DF9116A4E1; Wed, 2 Aug 2006 07:02:23 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDDBC43D73; Wed, 2 Aug 2006 07:02:19 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7272Jrr011405; Wed, 2 Aug 2006 07:02:19 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7272Jck011404; Wed, 2 Aug 2006 07:02:19 GMT (envelope-from brueffer) Message-Id: <200608020702.k7272Jck011404@repoman.freebsd.org> From: Christian Brueffer Date: Wed, 2 Aug 2006 07:02:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4/man4.powerpc powermac_nvram.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:02:23 -0000 brueffer 2006-08-02 07:02:19 UTC FreeBSD src repository Modified files: share/man/man4/man4.powerpc powermac_nvram.4 Log: Cleanup and add our standard SYNOPSIS section. Revision Changes Path 1.2 +16 -4 src/share/man/man4/man4.powerpc/powermac_nvram.4 From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:21:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01BF716A4DE; Wed, 2 Aug 2006 07:21:26 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8B5B43D45; Wed, 2 Aug 2006 07:21:25 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k727LPMH013512; Wed, 2 Aug 2006 07:21:25 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k727LPdm013511; Wed, 2 Aug 2006 07:21:25 GMT (envelope-from njl) Message-Id: <200608020721.k727LPdm013511@repoman.freebsd.org> From: Nate Lawson Date: Wed, 2 Aug 2006 07:21:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/acpica acpi.c acpi_thermal.c acpivar.h src/share/man/man4 acpi.4 acpi_thermal.4 src/sbin/sysctl sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:21:26 -0000 njl 2006-08-02 07:21:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/acpica acpivar.h acpi_thermal.c acpi.c share/man/man4 acpi_thermal.4 acpi.4 sbin/sysctl sysctl.c Log: MFC: add control of thermal zone setpoints, add sysctl to enable ACPI-based rebooting, fix sysctl printing of negative decimals, document it all. Revision Changes Path 1.67.2.2 +6 -2 src/sbin/sysctl/sysctl.c 1.52.2.3 +90 -8 src/share/man/man4/acpi.4 1.6.8.3 +18 -10 src/share/man/man4/acpi_thermal.4 1.214.2.6 +5 -1 src/sys/dev/acpica/acpi.c 1.53.2.5 +55 -13 src/sys/dev/acpica/acpi_thermal.c 1.95.2.4 +2 -1 src/sys/dev/acpica/acpivar.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:34:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEC2816A4DF; Wed, 2 Aug 2006 07:34:55 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E82A43D70; Wed, 2 Aug 2006 07:34:51 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k727YpDF014151; Wed, 2 Aug 2006 07:34:51 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k727Yp2U014150; Wed, 2 Aug 2006 07:34:51 GMT (envelope-from davidxu) Message-Id: <200608020734.k727Yp2U014150@repoman.freebsd.org> From: David Xu Date: Wed, 2 Aug 2006 07:34:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_time.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:34:56 -0000 davidxu 2006-08-02 07:34:51 UTC FreeBSD src repository Modified files: sys/kern kern_time.c Log: INT_MAX is defined in file sys/limits.h, include the file now. Revision Changes Path 1.130 +1 -0 src/sys/kern/kern_time.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:38:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D57D816A4DA; Wed, 2 Aug 2006 07:38:59 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 919FF43D45; Wed, 2 Aug 2006 07:38:59 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k727cxmh014411; Wed, 2 Aug 2006 07:38:59 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k727cxVb014410; Wed, 2 Aug 2006 07:38:59 GMT (envelope-from davidxu) Message-Id: <200608020738.k727cxVb014410@repoman.freebsd.org> From: David Xu Date: Wed, 2 Aug 2006 07:38:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:38:59 -0000 davidxu 2006-08-02 07:38:59 UTC FreeBSD src repository Modified files: sys/sys sysproto.h Log: don't include sys/thr.h and sys/umtx.h, it is unnecessary. Revision Changes Path 1.199 +0 -3 src/sys/sys/sysproto.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:41:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24F3D16A4DE; Wed, 2 Aug 2006 07:41:25 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D13043D53; Wed, 2 Aug 2006 07:41:24 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.56] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.6/8.13.6) with ESMTP id k727fK9N021420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Aug 2006 00:41:22 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <44D05705.1020202@FreeBSD.org> Date: Wed, 02 Aug 2006 00:40:53 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Christian Brueffer References: <200608020702.k7272Jck011404@repoman.freebsd.org> In-Reply-To: <200608020702.k7272Jck011404@repoman.freebsd.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4/man4.powerpc powermac_nvram.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:41:25 -0000 Thanks! -Maxim Christian Brueffer wrote: > brueffer 2006-08-02 07:02:19 UTC > > FreeBSD src repository > > Modified files: > share/man/man4/man4.powerpc powermac_nvram.4 > Log: > Cleanup and add our standard SYNOPSIS section. > > Revision Changes Path > 1.2 +16 -4 src/share/man/man4/man4.powerpc/powermac_nvram.4 > > From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:50:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7766116A4DD; Wed, 2 Aug 2006 07:50:36 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep11-int.chello.at (viefep13-int.chello.at [213.46.255.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C3A343D7B; Wed, 2 Aug 2006 07:50:28 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep33-int.chello.at ([213.47.85.26]) by viefep11-int.chello.at (InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id <20060802075027.INBA4985.viefep11-int.chello.at@viefep33-int.chello.at>; Wed, 2 Aug 2006 09:50:27 +0200 Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep33-int.chello.at (InterMail vG.2.02.00.00 201-2161-120-101-20051020) with ESMTP id <20060802075026.SGLE10014.viefep33-int.chello.at@wombat.fafoe.narf.at>; Wed, 2 Aug 2006 09:50:26 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 9BA53BC75; Wed, 2 Aug 2006 09:50:25 +0200 (CEST) Date: Wed, 2 Aug 2006 09:50:25 +0200 From: Stefan Farfeleder To: David Xu Message-ID: <20060802075024.GA14099@wombat.fafoe.narf.at> References: <200608020738.k727cxVb014410@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608020738.k727cxVb014410@repoman.freebsd.org> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:50:36 -0000 On Wed, Aug 02, 2006 at 07:38:59AM +0000, David Xu wrote: > davidxu 2006-08-02 07:38:59 UTC > > FreeBSD src repository > > Modified files: > sys/sys sysproto.h > Log: > don't include sys/thr.h and sys/umtx.h, it is unnecessary. This file is generated by makesyscalls.sh. You should rather modify the script. From owner-cvs-src@FreeBSD.ORG Wed Aug 2 07:52:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 82A0716A4E2; Wed, 2 Aug 2006 07:52:47 +0000 (UTC) (envelope-from davidxu@freebsd.org) Message-ID: <44D059CF.7060403@freebsd.org> Date: Wed, 02 Aug 2006 15:52:47 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20060725 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Stefan Farfeleder References: <200608020738.k727cxVb014410@repoman.freebsd.org> <20060802075024.GA14099@wombat.fafoe.narf.at> In-Reply-To: <20060802075024.GA14099@wombat.fafoe.narf.at> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 07:52:49 -0000 Stefan Farfeleder wrote: > On Wed, Aug 02, 2006 at 07:38:59AM +0000, David Xu wrote: > >>davidxu 2006-08-02 07:38:59 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/sys sysproto.h >> Log: >> don't include sys/thr.h and sys/umtx.h, it is unnecessary. > > > This file is generated by makesyscalls.sh. You should rather modify the > script. > > OK, I will fix it, I forgot that it is a generated file. ;-) From owner-cvs-src@FreeBSD.ORG Wed Aug 2 08:09:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B2D116A4DD; Wed, 2 Aug 2006 08:09:27 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5940343D46; Wed, 2 Aug 2006 08:09:27 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7289RlQ017095; Wed, 2 Aug 2006 08:09:27 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7289RRs017094; Wed, 2 Aug 2006 08:09:27 GMT (envelope-from davidxu) Message-Id: <200608020809.k7289RRs017094@repoman.freebsd.org> From: David Xu Date: Wed, 2 Aug 2006 08:09:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern makesyscalls.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 08:09:27 -0000 davidxu 2006-08-02 08:09:25 UTC FreeBSD src repository Modified files: sys/kern makesyscalls.sh Log: Don't include sys/thr.h and umtx.h in sys/sysproto.h, it is unnecessary. Revision Changes Path 1.64 +1 -3 src/sys/kern/makesyscalls.sh From owner-cvs-src@FreeBSD.ORG Wed Aug 2 08:14:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 545FB16A4DA; Wed, 2 Aug 2006 08:14:04 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FCB943D68; Wed, 2 Aug 2006 08:14:01 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k728E11S017596; Wed, 2 Aug 2006 08:14:01 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k728E1SB017595; Wed, 2 Aug 2006 08:14:01 GMT (envelope-from davidxu) Message-Id: <200608020814.k728E1SB017595@repoman.freebsd.org> From: David Xu Date: Wed, 2 Aug 2006 08:14:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys syscall.h syscall.mk sysproto.h src/sys/kern init_sysent.c syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 08:14:04 -0000 davidxu 2006-08-02 08:14:01 UTC FreeBSD src repository Modified files: sys/sys syscall.h syscall.mk sysproto.h sys/kern init_sysent.c syscalls.c Log: Regenerate. Revision Changes Path 1.216 +0 -0 src/sys/kern/init_sysent.c 1.200 +0 -0 src/sys/kern/syscalls.c 1.197 +0 -0 src/sys/sys/syscall.h 1.152 +0 -0 src/sys/sys/syscall.mk 1.200 +0 -0 src/sys/sys/sysproto.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 12:42:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D7AD16A4DD; Wed, 2 Aug 2006 12:42:21 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8E7B43D45; Wed, 2 Aug 2006 12:42:20 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72CgK0P044858; Wed, 2 Aug 2006 12:42:20 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72CgKeD044857; Wed, 2 Aug 2006 12:42:20 GMT (envelope-from bms) Message-Id: <200608021242.k72CgKeD044857@repoman.freebsd.org> From: Bruce M Simpson Date: Wed, 2 Aug 2006 12:42:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/reboot reboot.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 12:42:21 -0000 bms 2006-08-02 12:42:20 UTC FreeBSD src repository Modified files: sbin/reboot reboot.c Log: Block SIGHUP before killing init(8), to avoid a race condition which may kill the current process and hang the system when attempting reboot. PR: bin/64664 Reviewed by: ssouhal, phk (historic) MFC after: 30 days Revision Changes Path 1.25 +3 -3 src/sbin/reboot/reboot.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 13:02:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAFA716A4DF; Wed, 2 Aug 2006 13:02:01 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADE0143D70; Wed, 2 Aug 2006 13:02:00 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72D20gp053701; Wed, 2 Aug 2006 13:02:00 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72D1xrf053683; Wed, 2 Aug 2006 13:01:59 GMT (envelope-from rwatson) Message-Id: <200608021301.k72D1xrf053683@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 13:01:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_sockbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 13:02:02 -0000 rwatson 2006-08-02 13:01:59 UTC FreeBSD src repository Modified files: sys/kern uipc_sockbuf.c Log: Remove 'register'. Use ANSI C prototypes/function headers. More deterministically line wrap comments. Revision Changes Path 1.164 +138 -199 src/sys/kern/uipc_sockbuf.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 13:05:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2514916A4DA; Wed, 2 Aug 2006 13:05:39 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90D5643D55; Wed, 2 Aug 2006 13:05:38 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72D5cD7055143; Wed, 2 Aug 2006 13:05:38 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72D5c9R055142; Wed, 2 Aug 2006 13:05:38 GMT (envelope-from bms) Message-Id: <200608021305.k72D5c9R055142@repoman.freebsd.org> From: Bruce M Simpson Date: Wed, 2 Aug 2006 13:05:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/reboot reboot.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 13:05:39 -0000 bms 2006-08-02 13:05:38 UTC FreeBSD src repository Modified files: sbin/reboot reboot.c Log: Block a variety of signals which may afffect reboot(8), before killing init(8), to avoid losing a race to them and dying before being able to call reboot(2). PR: bin/64664 Submitted by: maxim Obtained from: NetBSD MFC after: 30 days Revision Changes Path 1.26 +15 -2 src/sbin/reboot/reboot.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 13:21:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACFE016A4DA; Wed, 2 Aug 2006 13:21:45 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B41043D46; Wed, 2 Aug 2006 13:21:45 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72DLj0n056077; Wed, 2 Aug 2006 13:21:45 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72DLjHF056076; Wed, 2 Aug 2006 13:21:45 GMT (envelope-from bms) Message-Id: <200608021321.k72DLjHF056076@repoman.freebsd.org> From: Bruce M Simpson Date: Wed, 2 Aug 2006 13:21:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/logger logger.1 logger.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 13:21:45 -0000 bms 2006-08-02 13:21:45 UTC FreeBSD src repository Modified files: usr.bin/logger logger.1 logger.c Log: Add a new command-line option, -P, which allows the user to specify an arbitrary port to which syslog messages are to be sent. PR: bin/54026 Submitted by: Oliver Fromme MFC after: 10 days Revision Changes Path 1.17 +11 -0 src/usr.bin/logger/logger.1 1.15 +16 -11 src/usr.bin/logger/logger.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 14:29:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C53B616A4DF; Wed, 2 Aug 2006 14:29:31 +0000 (UTC) (envelope-from jcamou@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7ABC243D46; Wed, 2 Aug 2006 14:29:31 +0000 (GMT) (envelope-from jcamou@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72ETVHo060574; Wed, 2 Aug 2006 14:29:31 GMT (envelope-from jcamou@repoman.freebsd.org) Received: (from jcamou@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72ETVAq060573; Wed, 2 Aug 2006 14:29:31 GMT (envelope-from jcamou) Message-Id: <200608021429.k72ETVAq060573@repoman.freebsd.org> From: "Jesus R. Camou" Date: Wed, 2 Aug 2006 14:29:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man5 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 14:29:31 -0000 jcamou 2006-08-02 14:29:31 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) share/man/man5 Makefile Log: MFC link: rc.conf.local(5)->rc.conf(5) PR: docs/87698 Approved by: trhodes (mentor) Revision Changes Path 1.58.2.4 +1 -0 src/share/man/man5/Makefile From owner-cvs-src@FreeBSD.ORG Wed Aug 2 14:30:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD48516A4DD; Wed, 2 Aug 2006 14:30:59 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5319843D67; Wed, 2 Aug 2006 14:30:59 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72EUxtN060725; Wed, 2 Aug 2006 14:30:59 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72EUxEw060722; Wed, 2 Aug 2006 14:30:59 GMT (envelope-from rwatson) Message-Id: <200608021430.k72EUxEw060722@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 14:30:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 14:30:59 -0000 rwatson 2006-08-02 14:30:58 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Remove now unneeded ENOTCONN clause from SOCK_DGRAM side of uipc_send(): we have to check it regardless of the target address, so don't check it twice. Revision Changes Path 1.184 +0 -5 src/sys/kern/uipc_usrreq.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 14:58:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6FEA16A4DA; Wed, 2 Aug 2006 14:58:52 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B17443D58; Wed, 2 Aug 2006 14:58:52 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72EwqGa062297; Wed, 2 Aug 2006 14:58:52 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72Ewqa9062296; Wed, 2 Aug 2006 14:58:52 GMT (envelope-from oleg) Message-Id: <200608021458.k72Ewqa9062296@repoman.freebsd.org> From: Oleg Bulyzhin Date: Wed, 2 Aug 2006 14:58:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 14:58:52 -0000 oleg 2006-08-02 14:58:52 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Do not leak memory while flushing rules. Noticed by: yar Approved by: glebius (mentor) MFC after: 1 week Revision Changes Path 1.141 +3 -2 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 15:02:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6166316A4DE; Wed, 2 Aug 2006 15:02:00 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13CE743D7D; Wed, 2 Aug 2006 15:02:00 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72F1xMK062544; Wed, 2 Aug 2006 15:01:59 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72F1xcc062543; Wed, 2 Aug 2006 15:01:59 GMT (envelope-from glebius) Message-Id: <200608021501.k72F1xcc062543@repoman.freebsd.org> From: Gleb Smirnoff Date: Wed, 2 Aug 2006 15:01:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 15:02:00 -0000 glebius 2006-08-02 15:01:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bge if_bge.c if_bgereg.h Log: Sync with HEAD merging many things: - Support for BCM5754, BCM5755, BCM5787. - Recognize BCM5703 B0 ASIC. - Correctly recognize chips that can do Jumbo. - Fix kern/68351 - Rewrite arrays that hold names of chips and revisions. Also: - Big style(9) and whitespace cleanup. Revision Changes Path 1.91.2.15 +586 -716 src/sys/dev/bge/if_bge.c 1.36.2.6 +205 -157 src/sys/dev/bge/if_bgereg.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 15:25:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0675F16A4DE; Wed, 2 Aug 2006 15:25:05 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A48F843D80; Wed, 2 Aug 2006 15:24:59 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72FOx9n064979; Wed, 2 Aug 2006 15:24:59 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72FOxms064978; Wed, 2 Aug 2006 15:24:59 GMT (envelope-from netchild) Message-Id: <200608021524.k72FOxms064978@repoman.freebsd.org> From: Alexander Leidinger Date: Wed, 2 Aug 2006 15:24:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/kerneldoc/subsys Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 15:25:06 -0000 netchild 2006-08-02 15:24:59 UTC FreeBSD src repository Modified files: tools/kerneldoc/subsys Makefile Log: Fix build when .CURDIR != .OBJDIR. Noticed by: "Alexander Mogilny" Revision Changes Path 1.5 +3 -0 src/tools/kerneldoc/subsys/Makefile From owner-cvs-src@FreeBSD.ORG Wed Aug 2 15:26:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D200816A4E0; Wed, 2 Aug 2006 15:26:17 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC4D943D6E; Wed, 2 Aug 2006 15:26:15 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72FQFbD065101; Wed, 2 Aug 2006 15:26:15 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72FQFEg065100; Wed, 2 Aug 2006 15:26:15 GMT (envelope-from netchild) Message-Id: <200608021526.k72FQFEg065100@repoman.freebsd.org> From: Alexander Leidinger Date: Wed, 2 Aug 2006 15:26:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 15:26:17 -0000 netchild 2006-08-02 15:26:15 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Fix doxygen target. Submitted by: "Alexander Mogilny" Pointy hat to: netchild Revision Changes Path 1.550 +1 -1 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Wed Aug 2 15:27:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40B0116A4F0; Wed, 2 Aug 2006 15:27:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E823543D46; Wed, 2 Aug 2006 15:27:48 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72FRmAU065159; Wed, 2 Aug 2006 15:27:48 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72FRmZL065158; Wed, 2 Aug 2006 15:27:48 GMT (envelope-from jhb) Message-Id: <200608021527.k72FRmZL065158@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 Aug 2006 15:27:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 15:27:49 -0000 jhb 2006-08-02 15:27:48 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: Fix some bugs in the previous revision (1.419). Don't perform extra vfs_rel() on the mountpoint if the MAC checks fail in kern_statfs() and kern_fstatfs(). Similarly, don't perform an extra vfs_rel() if we get a doomed vnode in kern_fstatfs(), and handle the case of mp being NULL (for some doomed vnodes) by conditionalizing the vfs_rel() in kern_fstatfs() on mp != NULL. CID: 1517 Found by: Coverity Prevent (tm) (kern_fstatfs()) Pointy hat to: jhb Revision Changes Path 1.420 +4 -9 src/sys/kern/vfs_syscalls.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 16:18:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D54EA16A4DF; Wed, 2 Aug 2006 16:18:08 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A411243D5A; Wed, 2 Aug 2006 16:18:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72GI5id069007; Wed, 2 Aug 2006 16:18:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72GI5Bc069006; Wed, 2 Aug 2006 16:18:05 GMT (envelope-from rwatson) Message-Id: <200608021618.k72GI5Bc069006@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 16:18:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 16:18:08 -0000 rwatson 2006-08-02 16:18:05 UTC FreeBSD src repository Modified files: sys/netinet tcp_subr.c Log: Move soisdisconnected() in tcp_discardcb() to one of its calling contexts, tcp_twstart(), but not to the other, tcp_detach(), as the socket is already being torn down and therefore there are no listeners. This avoids a panic if kqueue state is registered on the socket at close(), and eliminates to XXX comments. There is one case remaining in which tcp_discardcb() reaches up to the socket layer as part of the TCP host cache, which would be good to avoid. Reported by: Goran Gajic Revision Changes Path 1.253 +7 -12 src/sys/netinet/tcp_subr.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 16:22:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4923D16A4E1; Wed, 2 Aug 2006 16:22:40 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6EAFA43D72; Wed, 2 Aug 2006 16:22:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72GMZO2069371; Wed, 2 Aug 2006 16:22:35 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72GMZnQ069370; Wed, 2 Aug 2006 16:22:35 GMT (envelope-from rwatson) Message-Id: <200608021622.k72GMZnQ069370@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 16:22:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netatalk ddp_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 16:22:40 -0000 rwatson 2006-08-02 16:22:35 UTC FreeBSD src repository Modified files: sys/netatalk ddp_pcb.c Log: Remove call to soisdisconnected() in at_pcbdetach(): by the time the socket is being detached, there are no consumers left worth notifying about the disconnect. Revision Changes Path 1.49 +0 -2 src/sys/netatalk/ddp_pcb.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 16:24:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D7BC16A4DF; Wed, 2 Aug 2006 16:24:09 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35A1E43D97; Wed, 2 Aug 2006 16:23:53 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72GNr1X069486; Wed, 2 Aug 2006 16:23:53 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72GNqGQ069485; Wed, 2 Aug 2006 16:23:52 GMT (envelope-from rwatson) Message-Id: <200608021623.k72GNqGQ069485@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 16:23:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 16:24:09 -0000 rwatson 2006-08-02 16:23:52 UTC FreeBSD src repository Modified files: sys/kern uipc_socket2.c Log: Change two XXX's to two notes: the fact that SOCK_LOCK(so) == SOCKBUF_LOCK(&so->so_rcv) is encoded, which is worth noting, but not a bug. Revision Changes Path 1.162 +2 -2 src/sys/kern/uipc_socket2.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 16:24:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F101E16A4E7; Wed, 2 Aug 2006 16:24:33 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B98243D92; Wed, 2 Aug 2006 16:24:23 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72GONec069521; Wed, 2 Aug 2006 16:24:23 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72GONBJ069520; Wed, 2 Aug 2006 16:24:23 GMT (envelope-from alc) Message-Id: <200608021624.k72GONBJ069520@repoman.freebsd.org> From: Alan Cox Date: Wed, 2 Aug 2006 16:24:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/include pmap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 16:24:34 -0000 alc 2006-08-02 16:24:23 UTC FreeBSD src repository Modified files: sys/amd64/include pmap.h Log: Define the additional page fault error codes that are implemented by amd64. Revision Changes Path 1.133 +2 -0 src/sys/amd64/include/pmap.h From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:07:14 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 680AA16A4DD; Wed, 2 Aug 2006 17:07:14 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id B267743D5D; Wed, 2 Aug 2006 17:07:12 +0000 (GMT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.13.7/8.13.7) with ESMTP id k72H7Cbc001358; Wed, 2 Aug 2006 10:07:12 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.13.7/8.13.7/Submit) id k72H7C4L001357; Wed, 2 Aug 2006 10:07:12 -0700 (PDT) (envelope-from sgk) Date: Wed, 2 Aug 2006 10:07:12 -0700 From: Steve Kargl To: Robert Watson Message-ID: <20060802170712.GB970@troutmask.apl.washington.edu> References: <200608021618.k72GI5Bc069006@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608021618.k72GI5Bc069006@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:07:14 -0000 On Wed, Aug 02, 2006 at 04:18:05PM +0000, Robert Watson wrote: > > Modified files: > sys/netinet tcp_subr.c > Log: > Move soisdisconnected() in tcp_discardcb() to one of its calling contexts, > tcp_twstart(), but not to the other, tcp_detach(), as the socket is > already being torn down and therefore there are no listeners. This avoids > a panic if kqueue state is registered on the socket at close(), and > eliminates to XXX comments. There is one case remaining in which > tcp_discardcb() reaches up to the socket layer as part of the TCP host > cache, which would be good to avoid. > Thanks! You beat me to my bug report. -- Steve From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:15:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3F5116A4DF; Wed, 2 Aug 2006 17:15:41 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F10643D6A; Wed, 2 Aug 2006 17:15:41 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72HFfOM080835; Wed, 2 Aug 2006 17:15:41 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72HFfnk080834; Wed, 2 Aug 2006 17:15:41 GMT (envelope-from marcel) Message-Id: <200608021715.k72HFfnk080834@repoman.freebsd.org> From: Marcel Moolenaar Date: Wed, 2 Aug 2006 17:15:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:15:42 -0000 marcel 2006-08-02 17:15:41 UTC FreeBSD src repository Modified files: usr.sbin Makefile Log: Remove remnants of Alpha. Revision Changes Path 1.355 +0 -9 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:16:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1700716A57E; Wed, 2 Aug 2006 17:16:52 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17F5043D53; Wed, 2 Aug 2006 17:16:49 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72HGmY3081045; Wed, 2 Aug 2006 17:16:48 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72HGmYa081044; Wed, 2 Aug 2006 17:16:48 GMT (envelope-from marcel) Message-Id: <200608021716.k72HGmYa081044@repoman.freebsd.org> From: Marcel Moolenaar Date: Wed, 2 Aug 2006 17:16:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/elf2exe Makefile elf2exe.8 elf2exe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:16:52 -0000 marcel 2006-08-02 17:16:48 UTC FreeBSD src repository Removed files: usr.sbin/elf2exe Makefile elf2exe.8 elf2exe.c Log: Remove remnants of Alpha. Revision Changes Path 1.8 +0 -7 src/usr.sbin/elf2exe/Makefile (dead) 1.13 +0 -56 src/usr.sbin/elf2exe/elf2exe.8 (dead) 1.8 +0 -403 src/usr.sbin/elf2exe/elf2exe.c (dead) From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:18:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9165116A4E2; Wed, 2 Aug 2006 17:18:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F53943D46; Wed, 2 Aug 2006 17:18:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id BB37A46CDA; Wed, 2 Aug 2006 13:18:17 -0400 (EDT) Date: Wed, 2 Aug 2006 18:18:17 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Steve Kargl In-Reply-To: <20060802170712.GB970@troutmask.apl.washington.edu> Message-ID: <20060802181553.V56791@fledge.watson.org> References: <200608021618.k72GI5Bc069006@repoman.freebsd.org> <20060802170712.GB970@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:18:18 -0000 On Wed, 2 Aug 2006, Steve Kargl wrote: > On Wed, Aug 02, 2006 at 04:18:05PM +0000, Robert Watson wrote: >> >> Modified files: >> sys/netinet tcp_subr.c >> Log: >> Move soisdisconnected() in tcp_discardcb() to one of its calling contexts, >> tcp_twstart(), but not to the other, tcp_detach(), as the socket is >> already being torn down and therefore there are no listeners. This avoids >> a panic if kqueue state is registered on the socket at close(), and >> eliminates to XXX comments. There is one case remaining in which >> tcp_discardcb() reaches up to the socket layer as part of the TCP host >> cache, which would be good to avoid. > > Thanks! You beat me to my bug report. I find myself a bit unsure about the entirely right solution here, though -- protocols inconsistently use soisdisconnected(), and at sometimes odd times. It's clear that, by the time the socket is being freed, the call to soisdisconnected() is too late to be useful. Some protocols, especially datagram protocols, don't use soisdisconnected(), they just remove the connected flag from the socket. It's not clear to me whether protocols should always invoke soisdisconnected() on every socket that's been at least partially connected, and when they should do that. By pru_detach it's too late, but perhaps at pru_close and pru_abort? Or perhaps the socket layer should auto-notify at that point, or just prior to pru_detach... Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:22:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2BA316A6B3; Wed, 2 Aug 2006 17:22:30 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A7DE43D46; Wed, 2 Aug 2006 17:22:30 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72HMUFY082085; Wed, 2 Aug 2006 17:22:30 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72HMUWj082084; Wed, 2 Aug 2006 17:22:30 GMT (envelope-from marcel) Message-Id: <200608021722.k72HMUWj082084@repoman.freebsd.org> From: Marcel Moolenaar Date: Wed, 2 Aug 2006 17:22:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.local.dist BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:22:30 -0000 marcel 2006-08-02 17:22:30 UTC FreeBSD src repository Modified files: etc/mtree BSD.local.dist BSD.usr.dist Log: Remove remnants of Alpha. Revision Changes Path 1.119 +0 -4 src/etc/mtree/BSD.local.dist 1.316 +0 -12 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:41:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C616916A4DE; Wed, 2 Aug 2006 17:41:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 766B743D79; Wed, 2 Aug 2006 17:41:58 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72Hfwkd082931; Wed, 2 Aug 2006 17:41:58 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72HfwEF082930; Wed, 2 Aug 2006 17:41:58 GMT (envelope-from jhb) Message-Id: <200608021741.k72HfwEF082930@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 Aug 2006 17:41:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ubsec ubsec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:41:58 -0000 jhb 2006-08-02 17:41:58 UTC FreeBSD src repository Modified files: sys/dev/ubsec ubsec.c Log: - Use m_getcl(), m_get(), and m_gethdr() rather than the older macros for alloc'ing mbufs so that there is less error handling required. - Go ahead and account for the data space in the first mbuf before entering the loop to alloc more mbuf's. This simplifies the loop logic and avoids confusing Coverity. CID: 817 Reviewed by: sam Tested by: pjd Found by: Coverity Prevent (tm) Revision Changes Path 1.45 +26 -37 src/sys/dev/ubsec/ubsec.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 17:50:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6BF516A4EA; Wed, 2 Aug 2006 17:50:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A5D343D46; Wed, 2 Aug 2006 17:50:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72HoVBL083346; Wed, 2 Aug 2006 17:50:31 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72HoVcJ083344; Wed, 2 Aug 2006 17:50:31 GMT (envelope-from jhb) Message-Id: <200608021750.k72HoVcJ083344@repoman.freebsd.org> From: John Baldwin Date: Wed, 2 Aug 2006 17:50:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/powerpc/powerpc intr_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:50:34 -0000 jhb 2006-08-02 17:50:31 UTC FreeBSD src repository Modified files: sys/powerpc/powerpc intr_machdep.c Log: Don't ignore errors from intr_event_add_handler(). CID: 1516 Found by: Coverity Prevent (tm) Revision Changes Path 1.8 +1 -3 src/sys/powerpc/powerpc/intr_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 18:37:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27A7816A4DA; Wed, 2 Aug 2006 18:37:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D89DB43D5E; Wed, 2 Aug 2006 18:37:44 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72IbiU6087253; Wed, 2 Aug 2006 18:37:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72IbiZk087252; Wed, 2 Aug 2006 18:37:44 GMT (envelope-from rwatson) Message-Id: <200608021837.k72IbiZk087252@repoman.freebsd.org> From: Robert Watson Date: Wed, 2 Aug 2006 18:37:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 18:37:45 -0000 rwatson 2006-08-02 18:37:44 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move destroying kqueue state from above pru_detach to below it in sofree(), as a number of protocols expect to be able to call soisdisconnected() during detach. That may not be a good assumption, but until I'm sure if it's a good assumption or not, allow it. Revision Changes Path 1.278 +2 -2 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Wed Aug 2 18:44:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ABADD16A4DE; Wed, 2 Aug 2006 18:44:13 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A68343D46; Wed, 2 Aug 2006 18:44:13 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72IiDF8087716; Wed, 2 Aug 2006 18:44:13 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72IiDsZ087715; Wed, 2 Aug 2006 18:44:13 GMT (envelope-from flz) Message-Id: <200608021844.k72IiDsZ087715@repoman.freebsd.org> From: Florent Thoumie Date: Wed, 2 Aug 2006 18:44:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/rc.d ntpdate src/share/man/man5 rc.conf.5 src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 18:44:13 -0000 flz 2006-08-02 18:44:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/rc.d ntpdate share/man/man5 rc.conf.5 etc/defaults rc.conf Log: MFC: - Remove hardcoded /etc/ntp.conf configuration file from ntpdate rc.d script and replace it with a new ntpdate_config variable. - Document it in defaults/rc.conf and rc.conf.5. - Document ntpdate_hosts in defaults/rc.conf. src/etc/rc.d/ntpdate: rev 1.15 -> 1.16 src/share/man/man5/rc.conf.5: rev 1.299 -> 1.300 src/etc/defaults/rc.conf: rev 1.288 -> 1.289 Requested by: Chris Timmons Revision Changes Path 1.252.2.23 +2 -0 src/etc/defaults/rc.conf 1.13.2.2 +2 -2 src/etc/rc.d/ntpdate 1.256.2.25 +8 -2 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Thu Aug 3 00:15:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BCC616A4E0; Thu, 3 Aug 2006 00:15:23 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23A4243D72; Thu, 3 Aug 2006 00:15:19 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k730FJ2g030630; Thu, 3 Aug 2006 00:15:19 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k730FJ41030629; Thu, 3 Aug 2006 00:15:19 GMT (envelope-from yongari) Message-Id: <200608030015.k730FJ41030629@repoman.freebsd.org> From: Pyun YongHyeon Date: Thu, 3 Aug 2006 00:15:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 00:15:23 -0000 yongari 2006-08-03 00:15:19 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: Fix re(4) breakge introduced in tree from rev 1.68. This should fix incorrect configuration of station address on big-endian architectures. Reviewed by: wpaul Tested on: sparc64 Revision Changes Path 1.72 +5 -6 src/sys/dev/re/if_re.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 03:28:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16D1E16A4DD; Thu, 3 Aug 2006 03:28:05 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55DFE43D5E; Thu, 3 Aug 2006 03:28:04 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k733S4kK052436; Thu, 3 Aug 2006 03:28:04 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k733S4X4052435; Thu, 3 Aug 2006 03:28:04 GMT (envelope-from jb) Message-Id: <200608030328.k733S4X4052435@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 03:28:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 03:28:05 -0000 jb 2006-08-03 03:28:04 UTC FreeBSD src repository Modified files: etc/mtree BSD.usr.dist Log: Add the library directory where DTrace library scripts live. Revision Changes Path 1.317 +2 -0 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Thu Aug 3 03:30:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2540916A4E2; Thu, 3 Aug 2006 03:30:54 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E386A43D53; Thu, 3 Aug 2006 03:30:53 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k733UrpP052772; Thu, 3 Aug 2006 03:30:53 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k733UrKi052771; Thu, 3 Aug 2006 03:30:53 GMT (envelope-from jb) Message-Id: <200608030330.k733UrKi052771@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 03:30:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 03:30:54 -0000 jb 2006-08-03 03:30:53 UTC FreeBSD src repository Modified files: etc/mtree BSD.usr.dist Log: Alphabetical order is probably better. Revision Changes Path 1.318 +2 -2 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Thu Aug 3 03:34:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FD3116A4E0; Thu, 3 Aug 2006 03:34:37 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7295B43D45; Thu, 3 Aug 2006 03:34:37 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k733YbIS052987; Thu, 3 Aug 2006 03:34:37 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k733Ybwd052986; Thu, 3 Aug 2006 03:34:37 GMT (envelope-from delphij) Message-Id: <200608030334.k733Ybwd052986@repoman.freebsd.org> From: Xin LI Date: Thu, 3 Aug 2006 03:34:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/uuid uuid_compare.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 03:34:37 -0000 delphij 2006-08-03 03:34:36 UTC FreeBSD src repository Modified files: lib/libc/uuid uuid_compare.c Log: In DCE 1.1, the time_low value is defined as an unsigned 32-bit integer. Presently, our implementation employs an approach that converts the value to int64_t, then back to int, unfortunately, this approach can be problematic when the the difference between the two time_low is larger than 0x7fffffff, as the value is then truncated to int. To quote the test case from the original PR, the following is true with the current implementation: 865e1a56-b9d9-11d9-ba27-0003476f2e88 < 062ac45c-b9d9-11d9-ba27-0003476f2e88 However, according to the DCE specification, the expected result should be: 865e1a56-b9d9-11d9-ba27-0003476f2e88 > 062ac45c-b9d9-11d9-ba27-0003476f2e88 This commit adds a new intermediate variable which uses int64_t to store the result of subtraction between the two time_low values, which would not introduce different semantic of the MSB found in time_low value. PR: 83107 Submitted by: Steve Sears MFC After: 1 month Revision Changes Path 1.5 +15 -5 src/lib/libc/uuid/uuid_compare.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 03:55:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4765E16A4DF; Thu, 3 Aug 2006 03:55:53 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FB1943D55; Thu, 3 Aug 2006 03:55:53 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k733tqFj054063; Thu, 3 Aug 2006 03:55:52 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k733tqgE054062; Thu, 3 Aug 2006 03:55:52 GMT (envelope-from delphij) Message-Id: <200608030355.k733tqgE054062@repoman.freebsd.org> From: Xin LI Date: Thu, 3 Aug 2006 03:55:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 03:55:53 -0000 delphij 2006-08-03 03:55:52 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vfsops.c Log: When the volume is being downgraded from a read-write mode, mark it as clean. PR: kern/85366 Submitted by: Dan Lukes MFC After: 2 weeks Revision Changes Path 1.152 +4 -0 src/sys/fs/msdosfs/msdosfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:19:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E94316A4DD; Thu, 3 Aug 2006 05:19:34 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C82C243D46; Thu, 3 Aug 2006 05:19:33 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735JXwf068240; Thu, 3 Aug 2006 05:19:33 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735JXRP068239; Thu, 3 Aug 2006 05:19:33 GMT (envelope-from jb) Message-Id: <200608030519.k735JXRP068239@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:19:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf options X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:19:34 -0000 jb 2006-08-03 05:19:33 UTC FreeBSD src repository Modified files: sys/conf options Log: Add an option to enable KSE support. Add an option to build in kernel DTrace hooks. Without this option, the DTrace modules acn't be loaded. Revision Changes Path 1.556 +2 -0 src/sys/conf/options From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:26:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A9616A4DE; Thu, 3 Aug 2006 05:26:55 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9595443D45; Thu, 3 Aug 2006 05:26:52 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735Qqie068654; Thu, 3 Aug 2006 05:26:52 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735QqvT068653; Thu, 3 Aug 2006 05:26:52 GMT (envelope-from jb) Message-Id: <200608030526.k735QqvT068653@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:26:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys sysent.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:26:55 -0000 jb 2006-08-03 05:26:52 UTC FreeBSD src repository Modified files: sys/sys sysent.h Log: Add fields to struct sysent to support the DTrace syscall provider called systrace. Another file called systrace_args.c is generated. This will be compiled into systrace and is used to map the syscall arguments into the 64-bit parameter array. Revision Changes Path 1.50 +16 -0 src/sys/sys/sysent.h From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:29:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD67116A4DE; Thu, 3 Aug 2006 05:29:11 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9032443D69; Thu, 3 Aug 2006 05:29:09 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735T92B068750; Thu, 3 Aug 2006 05:29:09 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735T9Pm068749; Thu, 3 Aug 2006 05:29:09 GMT (envelope-from jb) Message-Id: <200608030529.k735T9Pm068749@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:29:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern makesyscalls.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:29:12 -0000 jb 2006-08-03 05:29:09 UTC FreeBSD src repository Modified files: sys/kern makesyscalls.sh Log: Generate another file called systrace_args.c. This will be compiled into systrace and is used to map the syscall arguments into the 64-bit parameter array. Revision Changes Path 1.65 +38 -7 src/sys/kern/makesyscalls.sh From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:31:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5476616A4E0; Thu, 3 Aug 2006 05:31:29 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1575843D68; Thu, 3 Aug 2006 05:31:29 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735VSSG068929; Thu, 3 Aug 2006 05:31:28 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735VSWX068928; Thu, 3 Aug 2006 05:31:28 GMT (envelope-from jb) Message-Id: <200608030531.k735VSWX068928@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:31:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys syscall.h syscall.mk sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:31:29 -0000 jb 2006-08-03 05:31:28 UTC FreeBSD src repository Modified files: sys/sys syscall.h syscall.mk sysproto.h Log: Regen. Revision Changes Path 1.198 +0 -0 src/sys/sys/syscall.h 1.153 +0 -0 src/sys/sys/syscall.mk 1.201 +0 -0 src/sys/sys/sysproto.h From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:32:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 80BEE16A4DF; Thu, 3 Aug 2006 05:32:44 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4317A43D45; Thu, 3 Aug 2006 05:32:44 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735WiXZ069054; Thu, 3 Aug 2006 05:32:44 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735WiSn069053; Thu, 3 Aug 2006 05:32:44 GMT (envelope-from jb) Message-Id: <200608030532.k735WiSn069053@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:32:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern init_sysent.c syscalls.c systrace_args.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:32:44 -0000 jb 2006-08-03 05:32:44 UTC FreeBSD src repository Modified files: sys/kern init_sysent.c syscalls.c Added files: sys/kern systrace_args.c Log: Regen. Note the addition of the extra file now generated. Revision Changes Path 1.217 +469 -469 src/sys/kern/init_sysent.c 1.201 +0 -0 src/sys/kern/syscalls.c 1.1 +2785 -0 src/sys/kern/systrace_args.c (new) From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:36:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E0D216A4DD; Thu, 3 Aug 2006 05:36:34 +0000 (UTC) (envelope-from freebsd-cvs-src@oldach.net) Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB80343D45; Thu, 3 Aug 2006 05:36:33 +0000 (GMT) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (p548F8F80.dip0.t-ipconnect.de [84.143.143.128]) by rigel.oldach.net (8.13.6/8.13.6/hmo30jul04) with ESMTP id k735aJUJ036702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Aug 2006 07:36:20 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (localhost [127.0.0.1]) by sep.oldach.net (8.13.6/8.13.6/hmo26jun05) with ESMTP id k735aIfF081093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Aug 2006 07:36:18 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: (from hmo@localhost) by sep.oldach.net (8.13.6/8.13.6/Submit/hmo26jun05) id k735aIT3081092; Thu, 3 Aug 2006 07:36:18 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Message-Id: <200608030536.k735aIT3081092@sep.oldach.net> In-Reply-To: from Hajimu UMEMOTO at "Jul 18, 2006 1:14:20 pm" To: ume@FreeBSD.org (Hajimu UMEMOTO) Date: Thu, 3 Aug 2006 07:36:18 +0200 (CEST) From: freebsd-cvs-src@oldach.net (Helge Oldach) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-2.0.2 (rigel.oldach.net [194.8.96.250]); Thu, 03 Aug 2006 07:36:20 +0200 (CEST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sep.oldach.net [127.0.0.1]); Thu, 03 Aug 2006 07:36:18 +0200 (CEST) X-Virus-Scanned: ClamAV 0.88.3/1634/Thu Aug 3 00:32:49 2006 on rigel.oldach.net X-Virus-Scanned: ClamAV 0.88.3/1634/Thu Aug 3 00:32:49 2006 on sep.oldach.net X-Virus-Status: Clean X-Spam-Flag: NO X-Scanned-By: milter-spamc/0.25.321 (rigel.oldach.net [194.8.96.250]); Thu, 03 Aug 2006 07:36:22 +0200 X-Spam-Status: NO, hits=3.50 required=5.00 X-Spam-Level: *** Cc: cvs-src@FreeBSD.org, scottl@samsco.org, kensmith@cse.Buffalo.EDU, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:36:34 -0000 Hajimu UMEMOTO: > >>>>> On Mon, 17 Jul 2006 18:47:06 -0600 > >>>>> Scott Long said: > > scottl> Well then you've introduced a compatibility regression in the stable > scottl> branch. Did you give this patch to the ports team to test first? If > scottl> not, then you passed the problem on to them to try to correct, which is > scottl> a bit anti-social. Also, what about people trying to compile software > scottl> outside of the ports tree? > > No, I didn't. But, most of build failure on 7-CURRENT because of this > issue, detected on pointyhat were already fixed, and seeing > __FreeBSD_version for RELENG_6 will solve it. I'm working on it now, > and when ready, I'll sent the patches to the maintainers. Well... I've spotted a regression not with the ports tree but with 6-STABLE. On several boxes with this change applied I see lots of sendmails stacking up over time, for example: 713 ?? Ss 0:01.05 sendmail: accepting connections (sendmail) 717 ?? Is 0:00.02 sendmail: Queue runner@00:30:00 for /var/spool/client 31747 ?? I 0:00.00 sendmail: startup with 71.119.31.81 (sendmail) 32834 ?? I 0:00.00 sendmail: startup with 83.36.190.38 (sendmail) 33569 ?? I 0:00.00 sendmail: startup with 221.206.76.60 (sendmail) 34023 ?? I 0:00.00 sendmail: startup with 49.195.192.61.tokyo.flets.alph 34459 ?? I 0:00.00 sendmail: startup with 221.165.35.46 (sendmail) 36517 ?? I 0:00.00 sendmail: startup with 61.192.180.137 (sendmail) 38722 ?? I 0:00.00 sendmail: startup with 203.177.238.78 (sendmail) 39126 ?? I 0:00.00 sendmail: startup with 222.90.251.185 (sendmail) 39203 ?? I 0:00.00 sendmail: startup with 221.9.214.183 (sendmail) 39859 ?? I 0:00.00 sendmail: startup with 59.20.101.111 (sendmail) 41090 ?? I 0:00.00 sendmail: startup with 61.192.166.235 (sendmail) 41766 ?? I 0:00.00 sendmail: startup with 68.118.52.132 (sendmail) 42482 ?? I 0:00.00 sendmail: startup with 219.249.201.36 (sendmail) 42483 ?? I 0:00.00 sendmail: startup with 219.249.201.36 (sendmail) 43467 ?? I 0:00.00 sendmail: startup with 210.213.191.70 (sendmail) 43757 ?? I 0:00.00 sendmail: startup with 220.189.144.7 (sendmail) 44176 ?? I 0:00.00 sendmail: startup with 71.205.226.98 (sendmail) 44850 ?? I 0:00.00 sendmail: startup with 72.89.135.133 (sendmail) 44943 ?? I 0:00.00 sendmail: startup with 220.167.134.212 (sendmail) 48031 ?? I 0:00.00 sendmail: startup with 60.22.198.23 (sendmail) On one busy sendmail box I've seen literally thousands of such processes. Note that these processes don't disappear, so it is not related to sendmail.cf's timeouts. Broswing through the recent STABLE commits, I firstly thought it was related to the recent socket code changes, but no, it's not. It is definitely this introduction of BIND9's resolver. If I back out this change, all is fine again. As said, this is a very recent 6-STABLE. I'm tracking CTM, not cvs. I would seriously suggest to more thoroughly test this. I'm not asking to back it out right now, but this is definitely a breakage in 6-STABLE that should be fixed before 6.2. Regards, Helge From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:44:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1696216A4DD; Thu, 3 Aug 2006 05:44:52 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4FE643D5A; Thu, 3 Aug 2006 05:44:51 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735ipoI069635; Thu, 3 Aug 2006 05:44:51 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735ipqt069634; Thu, 3 Aug 2006 05:44:51 GMT (envelope-from jb) Message-Id: <200608030544.k735ipqt069634@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:44:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:44:52 -0000 jb 2006-08-03 05:44:51 UTC FreeBSD src repository Modified files: etc/mtree BSD.usr.dist Log: Not allowed to use tabs. The rule that proves the rule. Heh. Revision Changes Path 1.319 +2 -2 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Thu Aug 3 05:46:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEF5616A4DD; Thu, 3 Aug 2006 05:46:33 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E2BB43D53; Thu, 3 Aug 2006 05:46:33 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k735kXdR069742; Thu, 3 Aug 2006 05:46:33 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k735kXNZ069741; Thu, 3 Aug 2006 05:46:33 GMT (envelope-from jb) Message-Id: <200608030546.k735kXNZ069741@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 05:46:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man7 hier.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 05:46:33 -0000 jb 2006-08-03 05:46:32 UTC FreeBSD src repository Modified files: share/man/man7 hier.7 Log: Add the DTrace library script directory. Revision Changes Path 1.120 +2 -0 src/share/man/man7/hier.7 From owner-cvs-src@FreeBSD.ORG Thu Aug 3 08:07:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2815516A4DD; Thu, 3 Aug 2006 08:07:06 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99D4643D4C; Thu, 3 Aug 2006 08:07:05 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73875WJ087868; Thu, 3 Aug 2006 08:07:05 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73875bg087867; Thu, 3 Aug 2006 08:07:05 GMT (envelope-from jkoshy) Message-Id: <200608030807.k73875bg087867@repoman.freebsd.org> From: Joseph Koshy Date: Thu, 3 Aug 2006 08:07:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/mklocale UTF-8.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 08:07:06 -0000 jkoshy 2006-08-03 08:07:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/mklocale UTF-8.src Log: MFC rev 1.2: - Use SWIDTH0 for combining characters. - Unicode 4.1 related changes: - Add definitions for a new range of code points U+1DC0..U+1DFF "Combining Diacritical Marks Supplement". - Add U+04F6 and U+04F7 to the Cyrillic range. - Mark U+034F "Combining Grapheme Joiner" as non-printable. - Add new combining characters in the range U+0350..U+035F to the section "Combining Diacritical Marks". ============================================================================= Revision Changes Path 1.1.8.1 +34 -15 src/share/mklocale/UTF-8.src From owner-cvs-src@FreeBSD.ORG Thu Aug 3 09:06:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E788716A4DD; Thu, 3 Aug 2006 09:06:53 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D64043D4C; Thu, 3 Aug 2006 09:06:53 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7396rmg001395; Thu, 3 Aug 2006 09:06:53 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7396rdT001394; Thu, 3 Aug 2006 09:06:53 GMT (envelope-from jkoshy) Message-Id: <200608030906.k7396rdT001394@repoman.freebsd.org> From: Joseph Koshy Date: Thu, 3 Aug 2006 09:06:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/hexdump conv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 09:06:54 -0000 jkoshy 2006-08-03 09:06:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/hexdump conv.c Log: MFC rev 1.9: "In 'od -c' mode, deal with printable but zero-width combining characters correctly. These characters are displayed "combined" with a space character." Revision Changes Path 1.8.8.1 +1 -1 src/usr.bin/hexdump/conv.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 09:20:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6858716A4EF; Thu, 3 Aug 2006 09:20:15 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0BD543D6E; Thu, 3 Aug 2006 09:20:12 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k739KCMu002058; Thu, 3 Aug 2006 09:20:12 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k739KCjm002057; Thu, 3 Aug 2006 09:20:12 GMT (envelope-from glebius) Message-Id: <200608030920.k739KCjm002057@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 3 Aug 2006 09:20:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em README if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 09:20:15 -0000 glebius 2006-08-03 09:20:12 UTC FreeBSD src repository Modified files: sys/dev/em README if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h Log: Merge in new driver from Intel, version 6.0.5. It adds support for 80003 NICs and NICs found on ICH8 mobos, and improves support for already known chips. Details: - if_em.c. Merged manually, viewing diff between new vendor driver and previous one. This was an easy task, because most changes between 5.1.5 and 6.0.5 are bugfixes taken from FreeBSD. - if_em_hw.h. Dropped in from vendor, and then restored revisions 1.16, 1.17, 1.18. - if_em_hw.c. Dropped in from vendor, and then restored revision 1.15. - if_em_osdep.h. Added new required macros from vendor file and add a hack against define namespace mangling in if_em_hw.h. Intel made another hack, but I prefer mine. Revision Changes Path 1.13 +13 -6 src/sys/dev/em/README 1.123 +99 -41 src/sys/dev/em/if_em.c 1.46 +12 -2 src/sys/dev/em/if_em.h 1.21 +2230 -701 src/sys/dev/em/if_em_hw.c 1.21 +411 -57 src/sys/dev/em/if_em_hw.h 1.18 +44 -13 src/sys/dev/em/if_em_osdep.h From owner-cvs-src@FreeBSD.ORG Thu Aug 3 09:43:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1037916A4DA; Thu, 3 Aug 2006 09:43:22 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91CCF43D58; Thu, 3 Aug 2006 09:43:21 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 2DFE846C6C; Thu, 3 Aug 2006 05:43:21 -0400 (EDT) Date: Thu, 3 Aug 2006 10:43:21 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Helge Oldach In-Reply-To: <200608030536.k735aIT3081092@sep.oldach.net> Message-ID: <20060803104026.A45647@fledge.watson.org> References: <200608030536.k735aIT3081092@sep.oldach.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: scottl@samsco.org, src-committers@FreeBSD.org, Hajimu UMEMOTO , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, bz@FreeBSD.org, kensmith@cse.Buffalo.EDU Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 09:43:22 -0000 On Thu, 3 Aug 2006, Helge Oldach wrote: > Well... I've spotted a regression not with the ports tree but with 6-STABLE. > On several boxes with this change applied I see lots of sendmails stacking > up over time, for example: > > 713 ?? Ss 0:01.05 sendmail: accepting connections (sendmail) > 717 ?? Is 0:00.02 sendmail: Queue runner@00:30:00 for /var/spool/client > 31747 ?? I 0:00.00 sendmail: startup with 71.119.31.81 (sendmail) > 32834 ?? I 0:00.00 sendmail: startup with 83.36.190.38 (sendmail) > 33569 ?? I 0:00.00 sendmail: startup with 221.206.76.60 (sendmail) > 34023 ?? I 0:00.00 sendmail: startup with 49.195.192.61.tokyo.flets.alph > 34459 ?? I 0:00.00 sendmail: startup with 221.165.35.46 (sendmail) > 36517 ?? I 0:00.00 sendmail: startup with 61.192.180.137 (sendmail) > 38722 ?? I 0:00.00 sendmail: startup with 203.177.238.78 (sendmail) > 39126 ?? I 0:00.00 sendmail: startup with 222.90.251.185 (sendmail) > 39203 ?? I 0:00.00 sendmail: startup with 221.9.214.183 (sendmail) > 39859 ?? I 0:00.00 sendmail: startup with 59.20.101.111 (sendmail) > 41090 ?? I 0:00.00 sendmail: startup with 61.192.166.235 (sendmail) > 41766 ?? I 0:00.00 sendmail: startup with 68.118.52.132 (sendmail) > 42482 ?? I 0:00.00 sendmail: startup with 219.249.201.36 (sendmail) > 42483 ?? I 0:00.00 sendmail: startup with 219.249.201.36 (sendmail) > 43467 ?? I 0:00.00 sendmail: startup with 210.213.191.70 (sendmail) > 43757 ?? I 0:00.00 sendmail: startup with 220.189.144.7 (sendmail) > 44176 ?? I 0:00.00 sendmail: startup with 71.205.226.98 (sendmail) > 44850 ?? I 0:00.00 sendmail: startup with 72.89.135.133 (sendmail) > 44943 ?? I 0:00.00 sendmail: startup with 220.167.134.212 (sendmail) > 48031 ?? I 0:00.00 sendmail: startup with 60.22.198.23 (sendmail) > > On one busy sendmail box I've seen literally thousands of such processes. > Note that these processes don't disappear, so it is not related to > sendmail.cf's timeouts. > > Broswing through the recent STABLE commits, I firstly thought it was related > to the recent socket code changes, but no, it's not. It is definitely this > introduction of BIND9's resolver. If I back out this change, all is fine > again. > > As said, this is a very recent 6-STABLE. I'm tracking CTM, not cvs. > > I would seriously suggest to more thoroughly test this. I'm not asking to > back it out right now, but this is definitely a breakage in 6-STABLE that > should be fixed before 6.2. I've had a similar report from Bjoern Zeeb; at first we thought the reason he had stacking up TCP connections was a bug I introduced in 7.x, but it turns out it's because his sshd is wedging in name resolution, and not closing the TCP sockets (which are now visible in netstat in a way they weren't before). We only concluded that it was not a kernel socket bug a day or so ago, so I'm not sure he's had a chance to generate a resolver bug report. He reported that the application appeared to have two connected UDP sockets for name resolution, and one bad name server entry, but that the resolver appeared to be blocked in a read on the UDP socket that didn't have data queued, rather than the one that did. This was all from looking at netstat, and as far as I know, he's not dug into the resolver yet to see what might be happening. I've CC'd Bjoern in case he has further insight or can offer some more suggestions on what might be going on. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Thu Aug 3 09:50:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B93D16A4DD; Thu, 3 Aug 2006 09:50:16 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF8F543D53; Thu, 3 Aug 2006 09:50:15 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k739oF2L006709; Thu, 3 Aug 2006 09:50:15 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k739oFmc006708; Thu, 3 Aug 2006 09:50:15 GMT (envelope-from yar) Message-Id: <200608030950.k739oFmc006708@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 3 Aug 2006 09:50:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 09:50:16 -0000 yar 2006-08-03 09:50:15 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: Back out rev. 1.107 because it introduced as many problems as it tried to solve: - it smuggled hidden 802.1q details into otherwise protocol-neutral code; - it put an important code consistency check under DEBUG, which was never defined by anyone but a developer hacking this file for the moment; - lastly, the former bcopy() call had been correct as long as the "dead" code was there. (A new version of the fix for tag of -1 to come in the next commit.) Agreed by: qingli Revision Changes Path 1.108 +15 -9 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 09:59:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFEEC16A4E6; Thu, 3 Aug 2006 09:59:09 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8137C43D46; Thu, 3 Aug 2006 09:59:09 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k739x9rT007208; Thu, 3 Aug 2006 09:59:09 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k739x9N6007207; Thu, 3 Aug 2006 09:59:09 GMT (envelope-from yar) Message-Id: <200608030959.k739x9N6007207@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 3 Aug 2006 09:59:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 09:59:10 -0000 yar 2006-08-03 09:59:09 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: Should vlan_input() ever be called with ifp pointing to a non-Ethernet interface, do not just assign -1 to tag because it breaks the logic of the code to follow. The better way is to handle this case as an unsupported protocol and return unless INVARIANTS is in effect and we can panic. Panic is good there because the scenario can happen only because of a coding error elsewhere. We also should show the interface name in the panic message for easier debugging of the problem, should it ever emerge. Submitted by: qingli (initially) Revision Changes Path 1.109 +5 -4 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 12:05:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9ED4216A4DE; Thu, 3 Aug 2006 12:05:20 +0000 (UTC) (envelope-from simon@zaphod.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id B80D543D53; Thu, 3 Aug 2006 12:05:19 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: from zaphod.nitro.dk (unknown [192.168.3.39]) by mx.nitro.dk (Postfix) with ESMTP id 936EF2D8503; Thu, 3 Aug 2006 12:05:17 +0000 (UTC) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 6EAFB1141D; Thu, 3 Aug 2006 14:05:16 +0200 (CEST) Date: Thu, 3 Aug 2006 14:05:16 +0200 From: "Simon L. Nielsen" To: Poul-Henning Kamp Message-ID: <20060803120515.GA1223@zaphod.nitro.dk> References: <200607131406.k6DE6Agl026625@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607131406.k6DE6Agl026625@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/nanobsd nanobsd.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 12:05:20 -0000 On 2006.07.13 14:06:10 +0000, Poul-Henning Kamp wrote: > phk 2006-07-13 14:06:10 UTC > > FreeBSD src repository > > Modified files: > tools/tools/nanobsd nanobsd.sh > Log: > Create the diskless magic files in /etc during the install_etc() step > instead of setup_nanobsd(), because this gives customize tasks a chance > to fiddle the details. This makes it a bit harder to (ab)use nanobsd.sh as a framework to build more normal FreeBSD images where a normal /etc is used. Previously I simply replaced setup_nanobsd in my customize script and I got a pretty standard FreeBSD install out in the end. Would you mind if I split the "diskless" magic out into setup_nanobsd_etc() (the parts code you moved in this commit) and then run it right after install_etc()? It shouldn't make a difference for normal NanoBSD use, but then I can simply override setup_nanobsd_etc() in my cutomize script and avoid larger patches against nanobsd.sh. -- Simon L. Nielsen From owner-cvs-src@FreeBSD.ORG Thu Aug 3 12:50:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B4BC16A4EA; Thu, 3 Aug 2006 12:50:28 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EC4243D5C; Thu, 3 Aug 2006 12:50:21 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73CoLou026810; Thu, 3 Aug 2006 12:50:21 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73CoL9s026809; Thu, 3 Aug 2006 12:50:21 GMT (envelope-from davidxu) Message-Id: <200608031250.k73CoL9s026809@repoman.freebsd.org> From: David Xu Date: Thu, 3 Aug 2006 12:50:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/posix4 p1003_1b.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 12:50:28 -0000 davidxu 2006-08-03 12:50:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/posix4 p1003_1b.c Log: MFC revision 1.27. Don't allow non-root user to set a scheduler policy. Revision Changes Path 1.24.2.1 +4 -0 src/sys/posix4/p1003_1b.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 13:19:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8365B16A4DD; Thu, 3 Aug 2006 13:19:16 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39AE943D55; Thu, 3 Aug 2006 13:19:16 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73DJGcV029439; Thu, 3 Aug 2006 13:19:16 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73DJFMe029438; Thu, 3 Aug 2006 13:19:15 GMT (envelope-from yar) Message-Id: <200608031319.k73DJFMe029438@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 3 Aug 2006 13:19:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/bin/sh sh.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 13:19:16 -0000 yar 2006-08-03 13:19:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/sh sh.1 Log: MFC rev. 1.122: Tell more of the sh(1) history. Acknowledge Kenneth Almquist's contribution in AUTHORS. Revision Changes Path 1.102.2.6 +17 -2 src/bin/sh/sh.1 From owner-cvs-src@FreeBSD.ORG Thu Aug 3 15:31:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37BB716A4DE; Thu, 3 Aug 2006 15:31:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 088C743D6E; Thu, 3 Aug 2006 15:31:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73FVqMa039070; Thu, 3 Aug 2006 15:31:52 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73FVqGl039069; Thu, 3 Aug 2006 15:31:52 GMT (envelope-from jhb) Message-Id: <200608031531.k73FVqGl039069@repoman.freebsd.org> From: John Baldwin Date: Thu, 3 Aug 2006 15:31:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netsmb smb_trantcp.c src/sys/netncp ncp_sock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 15:31:54 -0000 jhb 2006-08-03 15:31:52 UTC FreeBSD src repository Modified files: sys/netsmb smb_trantcp.c sys/netncp ncp_sock.c Log: - Fix ncp_poll() to not panic if the socket doesn't have any pending data. We have to adjust curthread's state enough so that it appears to be in a poll(2) or select(2) call so that selrecord() will work and then teardown that state after calling sopoll(). - Fix some minor nits in nearby ncp_sock_rselect() and in the identical nbssn_rselect() function in the netsmb code: - Don't call nb_poll()/ncp_poll() now that ncp_poll() already fakes up poll(2) state since the rselect() functions already do that. Just invoke sopoll() directly. - To make things slightly more intuitive, store the results of sopoll() in a new 'revents' variable rather than 'error' since that's what sopoll() actually returns. - If the requested timeout time has been exceeded by the time we get ready to block, then return EWOULDBLOCK rather than 0 to signal a timeout as this is what the calling code expects. Tested by: Eric Christeson (1) MFC after: 1 week Revision Changes Path 1.17 +27 -7 src/sys/netncp/ncp_sock.c 1.24 +6 -10 src/sys/netsmb/smb_trantcp.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 16:31:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A61D16A4DF; Thu, 3 Aug 2006 16:31:27 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 051CD43D69; Thu, 3 Aug 2006 16:31:25 +0000 (GMT) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73GVPuJ043206; Thu, 3 Aug 2006 16:31:25 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73GVPlA043205; Thu, 3 Aug 2006 16:31:25 GMT (envelope-from emax) Message-Id: <200608031631.k73GVPlA043205@repoman.freebsd.org> From: Maksim Yevmenkin Date: Thu, 3 Aug 2006 16:31:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 16:31:27 -0000 emax 2006-08-03 16:31:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/kbdmux kbdmux.c Log: MFC: Add extra code into kbdmux(4)s read_char() method to poll (i.e. call read_char() method) slave keyboards. This workaround should fix problem with kbdmux(4) and atkbd(4) not working in ddb(4) and mid-boot. Revision Changes Path 1.2.2.6 +21 -0 src/sys/dev/kbdmux/kbdmux.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 17:11:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E10A16A4DD; Thu, 3 Aug 2006 17:11:14 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FC4F43D66; Thu, 3 Aug 2006 17:11:13 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k73HBBFn037511 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Aug 2006 10:11:12 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44D22E2F.4070307@errno.com> Date: Thu, 03 Aug 2006 10:11:11 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.4 (X11/20060724) MIME-Version: 1.0 To: Yar Tikhiy References: <200608030959.k739x9N6007207@repoman.freebsd.org> In-Reply-To: <200608030959.k739x9N6007207@repoman.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 17:11:14 -0000 Yar Tikhiy wrote: > yar 2006-08-03 09:59:09 UTC > > FreeBSD src repository > > Modified files: > sys/net if_vlan.c > Log: > Should vlan_input() ever be called with ifp pointing to a non-Ethernet > interface, do not just assign -1 to tag because it breaks the logic of > the code to follow. The better way is to handle this case as an unsupported > protocol and return unless INVARIANTS is in effect and we can panic. > Panic is good there because the scenario can happen only because of a > coding error elsewhere. > > We also should show the interface name in the panic message for easier > debugging of the problem, should it ever emerge. Introducing a panic in a place where you can trivially recover is bad regardless of why you got there. Many people run production systems with INVARIANTS turned on. Is it now possible to send a "packet of death" by exploiting this code path? Sam From owner-cvs-src@FreeBSD.ORG Thu Aug 3 17:34:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC95F16A4DD; Thu, 3 Aug 2006 17:34:13 +0000 (UTC) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76FF943D45; Thu, 3 Aug 2006 17:34:13 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id B3275170C5; Thu, 3 Aug 2006 17:34:11 +0000 (UTC) To: "Simon L. Nielsen" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 03 Aug 2006 14:05:16 +0200." <20060803120515.GA1223@zaphod.nitro.dk> Date: Thu, 03 Aug 2006 17:34:10 +0000 Message-ID: <49150.1154626450@critter.freebsd.dk> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/nanobsd nanobsd.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 17:34:14 -0000 In message <20060803120515.GA1223@zaphod.nitro.dk>, "Simon L. Nielsen" writes: >On 2006.07.13 14:06:10 +0000, Poul-Henning Kamp wrote: >> phk 2006-07-13 14:06:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> tools/tools/nanobsd nanobsd.sh >> Log: >> Create the diskless magic files in /etc during the install_etc() step >> instead of setup_nanobsd(), because this gives customize tasks a chance >> to fiddle the details. > >This makes it a bit harder to (ab)use nanobsd.sh as a framework to >build more normal FreeBSD images where a normal /etc is used. >Previously I simply replaced setup_nanobsd in my customize script and >I got a pretty standard FreeBSD install out in the end. > >Would you mind if I split the "diskless" magic out into >setup_nanobsd_etc() (the parts code you moved in this commit) and then >run it right after install_etc()? It shouldn't make a difference for >normal NanoBSD use, but then I can simply override setup_nanobsd_etc() >in my cutomize script and avoid larger patches against nanobsd.sh. That's ok with me. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Thu Aug 3 18:09:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BACB216A4E1; Thu, 3 Aug 2006 18:09:13 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC54E43D86; Thu, 3 Aug 2006 18:09:04 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k73I8tLL005510; Thu, 3 Aug 2006 22:08:55 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k73I8tqr005509; Thu, 3 Aug 2006 22:08:55 +0400 (MSD) (envelope-from yar) Date: Thu, 3 Aug 2006 22:08:55 +0400 From: Yar Tikhiy To: Sam Leffler Message-ID: <20060803180854.GI97316@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D22E2F.4070307@errno.com> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 18:09:13 -0000 On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: > Yar Tikhiy wrote: > > yar 2006-08-03 09:59:09 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net if_vlan.c > > Log: > > Should vlan_input() ever be called with ifp pointing to a non-Ethernet > > interface, do not just assign -1 to tag because it breaks the logic of > > the code to follow. The better way is to handle this case as an unsupported > > protocol and return unless INVARIANTS is in effect and we can panic. > > Panic is good there because the scenario can happen only because of a > > coding error elsewhere. > > > > We also should show the interface name in the panic message for easier > > debugging of the problem, should it ever emerge. > > Introducing a panic in a place where you can trivially recover is bad > regardless of why you got there. Many people run production systems > with INVARIANTS turned on. Is it now possible to send a "packet of > death" by exploiting this code path? No nastygram can ever achieve this; only FreeBSD commiters possess the ability to :-) The panic can never be reached unless one manages to attach a vlan interface to a non-Ethernet physical interface in advance, which is totally prohibited by the code at the beginning of vlan_config(); and vlan_config() is the only way to attach a vlan interface to a physical interface. I.e., it will take a developer breaking the logic in /sys/net to make the code path expoloitable. OTOH, you are right that we can at least attempt to recover from the situation. Perhaps it's time to introduce a common macro or function that emits a message on the console and then just calls kdb_backtrace() instead of dumping core and halting the system? So users will be able to post the stack traces to the lists and thus help to spot the possible bugs w/o having to go through panics. I'm unsure if sticking raw kdb_backtrace() calls in such places is a good idea, so I'm suggesting a wrapper function or macro. It is to be used in "can absolutely never happen" cases that are not fatal, like the one under discussion. -- Yar From owner-cvs-src@FreeBSD.ORG Thu Aug 3 18:58:38 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90DEA16A4E0; Thu, 3 Aug 2006 18:58:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5805243D5F; Thu, 3 Aug 2006 18:58:30 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k73Iw2Te099270; Thu, 3 Aug 2006 14:58:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Thu, 3 Aug 2006 14:58:00 -0400 User-Agent: KMail/1.9.1 References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> In-Reply-To: <20060803180854.GI97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608031458.01134.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 03 Aug 2006 14:58:03 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1634/Wed Aug 2 18:32:49 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Sam Leffler , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 18:58:38 -0000 On Thursday 03 August 2006 14:08, Yar Tikhiy wrote: > On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: > > Yar Tikhiy wrote: > > > yar 2006-08-03 09:59:09 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/net if_vlan.c > > > Log: > > > Should vlan_input() ever be called with ifp pointing to a non-Ethernet > > > interface, do not just assign -1 to tag because it breaks the logic of > > > the code to follow. The better way is to handle this case as an unsupported > > > protocol and return unless INVARIANTS is in effect and we can panic. > > > Panic is good there because the scenario can happen only because of a > > > coding error elsewhere. > > > > > > We also should show the interface name in the panic message for easier > > > debugging of the problem, should it ever emerge. > > > > Introducing a panic in a place where you can trivially recover is bad > > regardless of why you got there. Many people run production systems > > with INVARIANTS turned on. Is it now possible to send a "packet of > > death" by exploiting this code path? > > No nastygram can ever achieve this; only FreeBSD commiters possess > the ability to :-) > > The panic can never be reached unless one manages to attach a vlan > interface to a non-Ethernet physical interface in advance, which > is totally prohibited by the code at the beginning of vlan_config(); > and vlan_config() is the only way to attach a vlan interface to a > physical interface. > > I.e., it will take a developer breaking the logic in /sys/net to > make the code path expoloitable. > > OTOH, you are right that we can at least attempt to recover from > the situation. Perhaps it's time to introduce a common macro or > function that emits a message on the console and then just calls > kdb_backtrace() instead of dumping core and halting the system? > So users will be able to post the stack traces to the lists and > thus help to spot the possible bugs w/o having to go through panics. > I'm unsure if sticking raw kdb_backtrace() calls in such places > is a good idea, so I'm suggesting a wrapper function or macro. > It is to be used in "can absolutely never happen" cases that are > not fatal, like the one under discussion. kdb_backtrace() is the wrapper function around other internals. :) -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Aug 3 19:05:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB08316A4F3; Thu, 3 Aug 2006 19:05:08 +0000 (UTC) (envelope-from pdeuskar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E91C43D7B; Thu, 3 Aug 2006 19:05:06 +0000 (GMT) (envelope-from pdeuskar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73J56ju061871; Thu, 3 Aug 2006 19:05:06 GMT (envelope-from pdeuskar@repoman.freebsd.org) Received: (from pdeuskar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73J55D2061870; Thu, 3 Aug 2006 19:05:05 GMT (envelope-from pdeuskar) Message-Id: <200608031905.k73J55D2061870@repoman.freebsd.org> From: Prafulla Deuskar Date: Thu, 3 Aug 2006 19:05:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 19:05:08 -0000 pdeuskar 2006-08-03 19:05:05 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. This makes it easier for us to get the changes into -current and to -stable quickly. Revision Changes Path 1.124 +975 -975 src/sys/dev/em/if_em.c 1.47 +4 -4 src/sys/dev/em/if_em.h From owner-cvs-src@FreeBSD.ORG Thu Aug 3 20:43:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08E2316A4DA; Thu, 3 Aug 2006 20:43:52 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF68D43D45; Thu, 3 Aug 2006 20:43:51 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73Khpkf069065; Thu, 3 Aug 2006 20:43:51 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73KhpSk069064; Thu, 3 Aug 2006 20:43:51 GMT (envelope-from bms) Message-Id: <200608032043.k73KhpSk069064@repoman.freebsd.org> From: Bruce M Simpson Date: Thu, 3 Aug 2006 20:43:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/logger logger.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 20:43:52 -0000 bms 2006-08-03 20:43:51 UTC FreeBSD src repository Modified files: usr.bin/logger logger.1 Log: Update document date. Noticed by: ru Revision Changes Path 1.18 +1 -1 src/usr.bin/logger/logger.1 From owner-cvs-src@FreeBSD.ORG Thu Aug 3 21:19:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F0F516A4E0; Thu, 3 Aug 2006 21:19:14 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E845C43D68; Thu, 3 Aug 2006 21:19:13 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73LJDTh079727; Thu, 3 Aug 2006 21:19:13 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73LJD6t079726; Thu, 3 Aug 2006 21:19:13 GMT (envelope-from jb) Message-Id: <200608032119.k73LJD6t079726@repoman.freebsd.org> From: John Birrell Date: Thu, 3 Aug 2006 21:19:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_rman.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 21:19:14 -0000 jb 2006-08-03 21:19:13 UTC FreeBSD src repository Modified files: sys/kern subr_rman.c Log: Report the correct function name in a DPRINTF. Revision Changes Path 1.52 +4 -3 src/sys/kern/subr_rman.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 22:44:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C093716A4DE; Thu, 3 Aug 2006 22:44:47 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8470643D53; Thu, 3 Aug 2006 22:44:47 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73Milnt086147; Thu, 3 Aug 2006 22:44:47 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73Milqb086146; Thu, 3 Aug 2006 22:44:47 GMT (envelope-from sobomax) Message-Id: <200608032244.k73Milqb086146@repoman.freebsd.org> From: Maxim Sobolev Date: Thu, 3 Aug 2006 22:44:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/powerpc/powerpc machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 22:44:47 -0000 sobomax 2006-08-03 22:44:47 UTC FreeBSD src repository Modified files: sys/powerpc/powerpc machdep.c Log: Use proper trap code for the EXC_ALI traps. This fixes SIGBUS during unaligned 64-bits load/stores. MFC after: 2 weeks Revision Changes Path 1.96 +1 -1 src/sys/powerpc/powerpc/machdep.c From owner-cvs-src@FreeBSD.ORG Thu Aug 3 23:56:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FB2316A4E0; Thu, 3 Aug 2006 23:56:12 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B01343D45; Thu, 3 Aug 2006 23:56:12 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k73NuCAi096483; Thu, 3 Aug 2006 23:56:12 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k73NuCsa096482; Thu, 3 Aug 2006 23:56:12 GMT (envelope-from alc) Message-Id: <200608032356.k73NuCsa096482@repoman.freebsd.org> From: Alan Cox Date: Thu, 3 Aug 2006 23:56:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm swap_pager.c vm_object.c vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2006 23:56:12 -0000 alc 2006-08-03 23:56:12 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c vm_object.c vm_page.c Log: When sleeping on a busy page, use the lock from the containing object rather than the global page queues lock. Revision Changes Path 1.280 +4 -4 src/sys/vm/swap_pager.c 1.364 +6 -6 src/sys/vm/vm_object.c 1.320 +5 -8 src/sys/vm/vm_page.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 01:17:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 751B116A4E0 for ; Fri, 4 Aug 2006 01:17:02 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from pd4mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C84743D45 for ; Fri, 4 Aug 2006 01:17:02 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd5mr3so.prod.shaw.ca (pd5mr3so-qfe3.prod.shaw.ca [10.0.141.144]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G006C58U6OVE0@l-daemon> for cvs-src@FreeBSD.org; Thu, 03 Aug 2006 19:15:42 -0600 (MDT) Received: from pn2ml9so.prod.shaw.ca ([10.0.121.7]) by pd5mr3so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G006TM8U63KI0@pd5mr3so.prod.shaw.ca> for cvs-src@FreeBSD.org; Thu, 03 Aug 2006 19:15:42 -0600 (MDT) Received: from hexahedron.daemonology.net ([24.82.18.31]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with SMTP id <0J3G00JLO8U5CNF0@l-daemon> for cvs-src@FreeBSD.org; Thu, 03 Aug 2006 19:15:42 -0600 (MDT) Received: (qmail 1271 invoked from network); Fri, 04 Aug 2006 01:15:35 +0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; Fri, 04 Aug 2006 01:15:35 +0000 Date: Thu, 03 Aug 2006 18:15:34 -0700 From: Colin Percival In-reply-to: <200608031905.k73J55D2061870@repoman.freebsd.org> To: Prafulla Deuskar Message-id: <44D29FB6.9090209@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Enigmail-Version: 0.94.0.0 References: <200608031905.k73J55D2061870@repoman.freebsd.org> User-Agent: Thunderbird 1.5 (X11/20060416) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 01:17:02 -0000 Prafulla Deuskar wrote: > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > This makes it easier for us to get the changes into -current and to -stable quickly. I assume you've discussed this with glebius, who made the original changes; in the future, please add an "Approved by:", "No objections from:", or "Discussed with:" line to backout commits to make this more clear. Colin Percival From owner-cvs-src@FreeBSD.ORG Fri Aug 4 01:25:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE8B816A4DE; Fri, 4 Aug 2006 01:25:17 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B71743D46; Fri, 4 Aug 2006 01:25:17 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id B861578C1F; Fri, 4 Aug 2006 01:25:14 +0000 (GMT) Date: Fri, 4 Aug 2006 01:25:14 +0000 From: John Birrell To: pdeuskar@FreeBSD.org Message-ID: <20060804012514.GA63379@what-creek.com> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D29FB6.9090209@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cperciva@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 01:25:17 -0000 On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > Prafulla Deuskar wrote: > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > > This makes it easier for us to get the changes into -current and to -stable quickly. > > I assume you've discussed this with glebius, who made the original changes; in > the future, please add an "Approved by:", "No objections from:", or "Discussed > with:" line to backout commits to make this more clear. Also Pyun had made a fix for the bus_dmamap_unload problem we see on sun4v. This appears to have been backed out amongst what appears to be largely a white-space change. Are you prepared to do the work to solve the bus_dmamap_unload again? -- John Birrell From owner-cvs-src@FreeBSD.ORG Fri Aug 4 05:07:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8311716A4DD; Fri, 4 Aug 2006 05:07:46 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from ameno.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF9BE43D46; Fri, 4 Aug 2006 05:07:45 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from localhost (IDENT:mafDpuTLnNSH8qYymeyFVqMWfE4yYvYUv4xOCp4qzxYSJkfkf/jrLaG7T4ZVJrS6@localhost [IPv6:::1]) (user=ume mech=CRAM-MD5 bits=0) by ameno.mahoroba.org (8.13.6/8.13.6) with ESMTP/inet6 id k7457bmo056257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 14:07:37 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Fri, 04 Aug 2006 14:07:36 +0900 Message-ID: From: Hajimu UMEMOTO To: freebsd-cvs-src@oldach.net (Helge Oldach) In-Reply-To: <200608030536.k735aIT3081092@sep.oldach.net> References: <200608030536.k735aIT3081092@sep.oldach.net> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-pc-freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 6.1-RELEASE-p1 X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.1.12 (ameno.mahoroba.org [IPv6:::1]); Fri, 04 Aug 2006 14:07:39 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on ameno.mahoroba.org Cc: scottl@samsco.org, src-committers@FreeBSD.org, Hajimu UMEMOTO , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, kensmith@cse.Buffalo.EDU Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 05:07:46 -0000 Hi, >>>>> On Thu, 3 Aug 2006 07:36:18 +0200 (CEST) >>>>> Helge Oldach said: freebsd-cvs-src> Well... I've spotted a regression not with the ports tree but with freebsd-cvs-src> 6-STABLE. On several boxes with this change applied I see lots of freebsd-cvs-src> sendmails stacking up over time, for example: Could you show me your resolv.conf? Are all nameservers listed in your resolv.conf available? freebsd-cvs-src> On one busy sendmail box I've seen literally thousands of such freebsd-cvs-src> processes. Note that these processes don't disappear, so it is not freebsd-cvs-src> related to sendmail.cf's timeouts. Dou you mean that the processes are never disappered except killing them? Which status are they? Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ From owner-cvs-src@FreeBSD.ORG Fri Aug 4 05:12:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FFCE16A4E7; Fri, 4 Aug 2006 05:12:37 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from ameno.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74E0F43D4C; Fri, 4 Aug 2006 05:12:36 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from localhost (IDENT:wkrLVB0GgGVxUG3wGLNLlaN7nFCFE2F4TW7rlV+A5LkwAiMFL/vfY9Wxq3oiifrH@localhost [IPv6:::1]) (user=ume mech=CRAM-MD5 bits=0) by ameno.mahoroba.org (8.13.6/8.13.6) with ESMTP/inet6 id k745CO8m048504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 14:12:24 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Fri, 04 Aug 2006 14:12:24 +0900 Message-ID: From: Hajimu UMEMOTO To: Robert Watson In-Reply-To: <20060803104026.A45647@fledge.watson.org> References: <200608030536.k735aIT3081092@sep.oldach.net> <20060803104026.A45647@fledge.watson.org> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-pc-freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 6.1-RELEASE-p1 X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.1.12 (ameno.mahoroba.org [IPv6:::1]); Fri, 04 Aug 2006 14:12:24 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on ameno.mahoroba.org Cc: scottl@samsco.org, kensmith@cse.Buffalo.EDU, Hajimu UMEMOTO , cvs-src@FreeBSD.org, bz@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Helge Oldach Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 05:12:37 -0000 Hi, >>>>> On Thu, 3 Aug 2006 10:43:21 +0100 (BST) >>>>> Robert Watson said: rwatson> not sure he's had a chance to generate a resolver bug report. He reported rwatson> that the application appeared to have two connected UDP sockets for name rwatson> resolution, and one bad name server entry, but that the resolver appeared to rwatson> be blocked in a read on the UDP socket that didn't have data queued, rather rwatson> than the one that did. This was all from looking at netstat, and as far as I Are you make sure it is not kevent but read? Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ From owner-cvs-src@FreeBSD.ORG Fri Aug 4 05:39:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 509B516A4DD; Fri, 4 Aug 2006 05:39:46 +0000 (UTC) (envelope-from freebsd-cvs-src@oldach.net) Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A3DC43D46; Fri, 4 Aug 2006 05:39:45 +0000 (GMT) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (p548F8CF4.dip0.t-ipconnect.de [84.143.140.244]) by rigel.oldach.net (8.13.6/8.13.6/hmo30jul04) with ESMTP id k745dQwW070659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Aug 2006 07:39:28 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (localhost [127.0.0.1]) by sep.oldach.net (8.13.6/8.13.6/hmo26jun05) with ESMTP id k745dMZh063281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 07:39:22 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: (from hmo@localhost) by sep.oldach.net (8.13.6/8.13.6/Submit/hmo26jun05) id k745dM9K063280; Fri, 4 Aug 2006 07:39:22 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Message-Id: <200608040539.k745dM9K063280@sep.oldach.net> In-Reply-To: <20060803104026.A45647@fledge.watson.org> from Robert Watson at "Aug 3, 2006 10:43:21 am" To: rwatson@FreeBSD.org (Robert Watson) Date: Fri, 4 Aug 2006 07:39:22 +0200 (CEST) From: freebsd-cvs-src@oldach.net (Helge Oldach) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-2.0.2 (rigel.oldach.net [194.8.96.250]); Fri, 04 Aug 2006 07:39:29 +0200 (CEST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sep.oldach.net [127.0.0.1]); Fri, 04 Aug 2006 07:39:22 +0200 (CEST) X-Virus-Scanned: ClamAV 0.88.3/1634/Thu Aug 3 00:32:49 2006 on rigel.oldach.net X-Virus-Scanned: ClamAV version 0.88.3, clamav-milter version 0.88.3 on sep.oldach.net X-Virus-Status: Clean X-Spam-Flag: NO X-Scanned-By: milter-spamc/0.25.321 (rigel.oldach.net [194.8.96.250]); Fri, 04 Aug 2006 07:39:30 +0200 X-Spam-Status: NO, hits=2.30 required=5.00 X-Spam-Level: ** Cc: scottl@samsco.org, kensmith@cse.Buffalo.EDU, ume@FreeBSD.org, cvs-src@FreeBSD.org, bz@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-cvs-src@oldach.net Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 05:39:46 -0000 Robert Watson: > > Well... I've spotted a regression not with the ports tree but with 6-STABLE. > > On several boxes with this change applied I see lots of sendmails stacking > > up over time Just like to add that I've seen this with other processes as well, e.g. with ftp jobs that pick up the latest CTM deltas via cron. They get stuck in an early TCP phase. Guessing from tcpdumps it's right after the initial handshake. In netstat they show up as ESTABLISHED. > We only concluded that it was not a kernel socket bug a day or so ago, so I'm > not sure he's had a chance to generate a resolver bug report. He reported > that the application appeared to have two connected UDP sockets for name > resolution, and one bad name server entry, but that the resolver appeared to > be blocked in a read on the UDP socket that didn't have data queued, rather > than the one that did. So it seems. To add another observation: In netstat, the entries relating to the processes disappear after some time. The sockets clear up, but the process is still stuck. Also the UDP socket (resolver queries) disappears. Once I kill one such process, however, it sends a FIN packet and the TCP socket shows up again in netstat. So it's not completely dead but "just" stuck. I don't have a clue what is going on. Maybe it's not related to the resolver update, but this update just triggers another issue. I'm no resolver expert, but didn't BIND9 implement a new event library? On another occasion I had the vague feeling that it might be related to the calcru issue that was discussed in several threads recently. Just to verify that the issue hadn't been caught in the meantime I built a system from yesterday's 6-STABLE, but the issue is still present. :-( Helge From owner-cvs-src@FreeBSD.ORG Fri Aug 4 05:51:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2080A16A4DF; Fri, 4 Aug 2006 05:51:22 +0000 (UTC) (envelope-from freebsd-cvs-src@oldach.net) Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50B0C43D49; Fri, 4 Aug 2006 05:51:21 +0000 (GMT) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (p548F8CF4.dip0.t-ipconnect.de [84.143.140.244]) by rigel.oldach.net (8.13.6/8.13.6/hmo30jul04) with ESMTP id k745okSo072083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Aug 2006 07:50:47 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: from sep.oldach.net (localhost [127.0.0.1]) by sep.oldach.net (8.13.6/8.13.6/hmo26jun05) with ESMTP id k745ojm8063973 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 07:50:45 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Received: (from hmo@localhost) by sep.oldach.net (8.13.6/8.13.6/Submit/hmo26jun05) id k745ojss063972; Fri, 4 Aug 2006 07:50:45 +0200 (CEST) (envelope-from freebsd-cvs-src@oldach.net) Message-Id: <200608040550.k745ojss063972@sep.oldach.net> In-Reply-To: from Hajimu UMEMOTO at "Aug 4, 2006 2: 7:36 pm" To: ume@FreeBSD.org (Hajimu UMEMOTO) Date: Fri, 4 Aug 2006 07:50:45 +0200 (CEST) From: freebsd-cvs-src@oldach.net (Helge Oldach) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded STARTTLS authentication, not delayed by milter-greylist-2.0.2 (rigel.oldach.net [194.8.96.250]); Fri, 04 Aug 2006 07:50:47 +0200 (CEST) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sep.oldach.net [127.0.0.1]); Fri, 04 Aug 2006 07:50:45 +0200 (CEST) X-Virus-Scanned: ClamAV 0.88.3/1634/Thu Aug 3 00:32:49 2006 on rigel.oldach.net X-Virus-Scanned: ClamAV version 0.88.3, clamav-milter version 0.88.3 on sep.oldach.net X-Virus-Status: Clean X-Spam-Flag: NO X-Scanned-By: milter-spamc/0.25.321 (rigel.oldach.net [194.8.96.250]); Fri, 04 Aug 2006 07:51:12 +0200 X-Spam-Status: NO, hits=2.30 required=5.00 X-Spam-Level: ** Cc: scottl@samsco.org, kensmith@cse.Buffalo.EDU, ume@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-cvs-src@oldach.net Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 05:51:22 -0000 Hajimu UMEMOTO: > >>>>> On Thu, 3 Aug 2006 07:36:18 +0200 (CEST) > >>>>> Helge Oldach said: > > freebsd-cvs-src> Well... I've spotted a regression not with the ports tree but with > freebsd-cvs-src> 6-STABLE. On several boxes with this change applied I see lots of > freebsd-cvs-src> sendmails stacking up over time, for example: > > Could you show me your resolv.conf? Are all nameservers listed in > your resolv.conf available? Yes, certainly. As I've said, this issue shows up on several boxes. This includes machines with only a single resolver (which is up of course), resolving towards the internet, machines that talk to localhost (running a caching named with forwarders to public servers), but also to machines running on an internal network with private root servers. Actually I had already played around a bit with this, without any noticeable effect. OTOH, if one or all of the resolvers were just not available, the process should never get stuck indefinitely, but should log a message at least. > freebsd-cvs-src> On one busy sendmail box I've seen literally thousands of such > freebsd-cvs-src> processes. Note that these processes don't disappear, so it is not > freebsd-cvs-src> related to sendmail.cf's timeouts. > > Dou you mean that the processes are never disappered except killing > them? Exactly. > Which status are they? ps shows them as "I". See my other mail on more explanations. They disappear from netstat after some time. Once killed, they "normally" terminate their TCP session. Note that not only sendmail is affected but other processes that do name resolution as well. I have a test box that I can play with to spot more details, if that helps. Helge From owner-cvs-src@FreeBSD.ORG Fri Aug 4 05:53:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6E5816A4DA; Fri, 4 Aug 2006 05:53:21 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 804D743D45; Fri, 4 Aug 2006 05:53:21 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k745rL0B037187; Fri, 4 Aug 2006 05:53:21 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k745rLdN037186; Fri, 4 Aug 2006 05:53:21 GMT (envelope-from alc) Message-Id: <200608040553.k745rLdN037186@repoman.freebsd.org> From: Alan Cox Date: Fri, 4 Aug 2006 05:53:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 05:53:21 -0000 alc 2006-08-04 05:53:20 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: The page queues lock is no longer required by vm_page_io_start(). Reduce the scope of the page queues lock in kern_sendfile() accordingly. Revision Changes Path 1.235 +3 -3 src/sys/kern/uipc_syscalls.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:04:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F34F16A4DD; Fri, 4 Aug 2006 07:04:20 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB6DD43D46; Fri, 4 Aug 2006 07:04:17 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k7473plQ013004; Fri, 4 Aug 2006 11:03:52 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k7473m0v013002; Fri, 4 Aug 2006 11:03:48 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 11:03:48 +0400 From: Yar Tikhiy To: John Baldwin Message-ID: <20060804070348.GR97316@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> <200608031458.01134.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608031458.01134.jhb@freebsd.org> User-Agent: Mutt/1.5.9i Cc: Sam Leffler , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:04:20 -0000 On Thu, Aug 03, 2006 at 02:58:00PM -0400, John Baldwin wrote: > On Thursday 03 August 2006 14:08, Yar Tikhiy wrote: > > On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: > > > Yar Tikhiy wrote: > > > > yar 2006-08-03 09:59:09 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/net if_vlan.c > > > > Log: > > > > Should vlan_input() ever be called with ifp pointing to a non-Ethernet > > > > interface, do not just assign -1 to tag because it breaks the logic of > > > > the code to follow. The better way is to handle this case as an > unsupported > > > > protocol and return unless INVARIANTS is in effect and we can panic. > > > > Panic is good there because the scenario can happen only because of a > > > > coding error elsewhere. > > > > > > > > We also should show the interface name in the panic message for easier > > > > debugging of the problem, should it ever emerge. > > > > > > Introducing a panic in a place where you can trivially recover is bad > > > regardless of why you got there. Many people run production systems > > > with INVARIANTS turned on. Is it now possible to send a "packet of > > > death" by exploiting this code path? > > > > No nastygram can ever achieve this; only FreeBSD commiters possess > > the ability to :-) > > > > The panic can never be reached unless one manages to attach a vlan > > interface to a non-Ethernet physical interface in advance, which > > is totally prohibited by the code at the beginning of vlan_config(); > > and vlan_config() is the only way to attach a vlan interface to a > > physical interface. > > > > I.e., it will take a developer breaking the logic in /sys/net to > > make the code path expoloitable. > > > > OTOH, you are right that we can at least attempt to recover from > > the situation. Perhaps it's time to introduce a common macro or > > function that emits a message on the console and then just calls > > kdb_backtrace() instead of dumping core and halting the system? > > So users will be able to post the stack traces to the lists and > > thus help to spot the possible bugs w/o having to go through panics. > > I'm unsure if sticking raw kdb_backtrace() calls in such places > > is a good idea, so I'm suggesting a wrapper function or macro. > > It is to be used in "can absolutely never happen" cases that are > > not fatal, like the one under discussion. > > kdb_backtrace() is the wrapper function around other internals. :) Of course, we can always grep /sys for its usage later ;-) Just noticed that many calls to kdb_backtrace() are under "#ifdef KDB" while subr_kdb.c is marked as standard in /sys/conf/files and the function itself is always available (yet can do nothing.) Should calls to kdb_backtrace() be put under "#ifdef KDB"? If they should, it can justify introducing the combined printf+trace function. Thanks! -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:19:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B082E16A4DD; Fri, 4 Aug 2006 07:19:01 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69CBC43D45; Fri, 4 Aug 2006 07:19:01 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k747J1TB047567; Fri, 4 Aug 2006 07:19:01 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k747J1bX047566; Fri, 4 Aug 2006 07:19:01 GMT (envelope-from njl) Message-Id: <200608040719.k747J1bX047566@repoman.freebsd.org> From: Nate Lawson Date: Fri, 4 Aug 2006 07:19:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 acpi.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:19:01 -0000 njl 2006-08-04 07:19:01 UTC FreeBSD src repository Modified files: share/man/man4 acpi.4 Log: Improve quoting of the S1-S5 states. Suggested by yar@. Add a workaround for conflicts between ACPI Cx CPU idling and LAPIC timer. MFC after: 1 day Revision Changes Path 1.58 +47 -17 src/share/man/man4/acpi.4 From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:19:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9990716A513; Fri, 4 Aug 2006 07:19:21 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53A7043D53; Fri, 4 Aug 2006 07:19:18 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k747JAmw013194; Fri, 4 Aug 2006 11:19:10 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k747J90p013193; Fri, 4 Aug 2006 11:19:10 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 11:19:09 +0400 From: Yar Tikhiy To: pdeuskar@FreeBSD.org Message-ID: <20060804071909.GS97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804012514.GA63379@what-creek.com> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:19:21 -0000 On Fri, Aug 04, 2006 at 01:25:14AM +0000, John Birrell wrote: > On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > > Prafulla Deuskar wrote: > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > > > This makes it easier for us to get the changes into -current and to -stable quickly. > > > > I assume you've discussed this with glebius, who made the original changes; in > > the future, please add an "Approved by:", "No objections from:", or "Discussed > > with:" line to backout commits to make this more clear. > > Also Pyun had made a fix for the bus_dmamap_unload problem we see on sun4v. This > appears to have been backed out amongst what appears to be largely a white-space > change. > > Are you prepared to do the work to solve the bus_dmamap_unload again? As a general remark, it is a very good idea to keep large style(9) sweeps separate from actual code changes even if they are tiny. Changing style(9) shouldn't alter the binary code produced, and this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). Of course, changing line numbers will affect debug info, but the latter can be strip(1)'ed. In the case under discussion, I'd compare if_em.o with its former version to make sure no code changed. -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:31:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D2AB16A4DA; Fri, 4 Aug 2006 07:31:56 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C991A43D45; Fri, 4 Aug 2006 07:31:55 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k747Vt3e048211; Fri, 4 Aug 2006 07:31:55 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k747VtMc048210; Fri, 4 Aug 2006 07:31:55 GMT (envelope-from njl) Message-Id: <200608040731.k747VtMc048210@repoman.freebsd.org> From: Nate Lawson Date: Fri, 4 Aug 2006 07:31:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/sysctl sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:31:56 -0000 njl 2006-08-04 07:31:55 UTC FreeBSD src repository Modified files: sbin/sysctl sysctl.c Log: Use floating point instead of hacking something together. Suggested by bde@. Fix nearby int conversion and a couple style bugs. MFC after: 1 day Revision Changes Path 1.71 +8 -10 src/sbin/sysctl/sysctl.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:44:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 227A916A4DD; Fri, 4 Aug 2006 07:44:13 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep14-int.chello.at (viefep13-int.chello.at [213.46.255.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DC3443D46; Fri, 4 Aug 2006 07:44:11 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep14-int.chello.at (InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id <20060804074409.FBKK2199.viefep14-int.chello.at@wombat.fafoe.narf.at>; Fri, 4 Aug 2006 09:44:09 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 46C98BC7E; Fri, 4 Aug 2006 09:23:24 +0200 (CEST) Date: Fri, 4 Aug 2006 09:23:23 +0200 From: Stefan Farfeleder To: Yar Tikhiy Message-ID: <20060804072323.GC89735@wombat.fafoe.narf.at> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804071909.GS97316@comp.chem.msu.su> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:44:13 -0000 On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > As a general remark, it is a very good idea to keep large style(9) > sweeps separate from actual code changes even if they are tiny. > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > Of course, changing line numbers will affect debug info, but the > latter can be strip(1)'ed. In the case under discussion, I'd compare > if_em.o with its former version to make sure no code changed. It will produce different code if __LINE__ is used. Stefan From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:47:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 480D016A4DA; Fri, 4 Aug 2006 07:47:01 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57BC843D4C; Fri, 4 Aug 2006 07:47:00 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k747kvU0013471; Fri, 4 Aug 2006 11:46:58 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k747kvlo013470; Fri, 4 Aug 2006 11:46:57 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 11:46:57 +0400 From: Yar Tikhiy To: Stefan Farfeleder Message-ID: <20060804074657.GT97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804072323.GC89735@wombat.fafoe.narf.at> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:47:01 -0000 On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > As a general remark, it is a very good idea to keep large style(9) > > sweeps separate from actual code changes even if they are tiny. > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > Of course, changing line numbers will affect debug info, but the > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > if_em.o with its former version to make sure no code changed. > > It will produce different code if __LINE__ is used. Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. Fortunately, they are not widely used in src/, AFAIK. -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:49:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4A9F16A4E5 for ; Fri, 4 Aug 2006 07:49:20 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from pd4mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D4B443D45 for ; Fri, 4 Aug 2006 07:49:20 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr7so.prod.shaw.ca (pd4mr7so-qfe3.prod.shaw.ca [10.0.141.84]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G0001ER25Y0C0@l-daemon> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 01:49:17 -0600 (MDT) Received: from pn2ml5so.prod.shaw.ca ([10.0.121.149]) by pd4mr7so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G00C2AR24DE20@pd4mr7so.prod.shaw.ca> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 01:49:16 -0600 (MDT) Received: from hexahedron.daemonology.net ([24.82.18.31]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with SMTP id <0J3G00LRVR24DXX0@l-daemon> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 01:49:16 -0600 (MDT) Received: (qmail 3889 invoked from network); Fri, 04 Aug 2006 07:49:10 +0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; Fri, 04 Aug 2006 07:49:09 +0000 Date: Fri, 04 Aug 2006 00:49:09 -0700 From: Colin Percival In-reply-to: <20060804071909.GS97316@comp.chem.msu.su> To: Yar Tikhiy Message-id: <44D2FBF5.1010402@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Enigmail-Version: 0.94.0.0 References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> User-Agent: Thunderbird 1.5 (X11/20060416) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:49:20 -0000 Yar Tikhiy wrote: > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). With md5(1), you can only 99.999999999999999994579% verify it. :-) Colin Percival From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:56:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 758C016A4E0; Fri, 4 Aug 2006 07:56:36 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1770443D45; Fri, 4 Aug 2006 07:56:36 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k747uZXq049825; Fri, 4 Aug 2006 07:56:35 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k747uZ0P049824; Fri, 4 Aug 2006 07:56:35 GMT (envelope-from yar) Message-Id: <200608040756.k747uZ0P049824@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 4 Aug 2006 07:56:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh histedit.c src/games/fortune/datfiles fortunes src/lib/libc/sys kse.2 src/release/doc/fr_FR.ISO8859-1/hardware/alpha proc-alpha.sgml src/share/doc/papers/timecounter timecounter.ms src/share/man/man4 devctl.4 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:56:36 -0000 yar 2006-08-04 07:56:35 UTC FreeBSD src repository Modified files: bin/sh histedit.c games/fortune/datfiles fortunes lib/libc/sys kse.2 release/doc/fr_FR.ISO8859-1/hardware/alpha proc-alpha.sgml share/doc/papers/timecounter timecounter.ms share/man/man4 devctl.4 sys/boot/i386/loader main.c sys/boot/pc98/loader main.c sys/dev/bktr CHANGELOG.TXT sys/dev/dpt dpt_scsi.c sys/dev/em if_em.c sys/dev/fe if_fe.c sys/dev/ixgb if_ixgb.c sys/dev/patm if_patm_intr.c sys/dev/pci pcivar.h sys/dev/sym sym_fw1.h sym_fw2.h sys/fs/hpfs hpfs.h sys/geom/bde g_bde_work.c sys/geom/mirror g_mirror.c sys/geom/raid3 g_raid3.c sys/i386/i386 tsc.c sys/kern kern_resource.c kern_tc.c subr_bus.c sys/pci ncr.c Log: Commit the results of the typo hunt by Darren Pilgrim. This change affects documentation and comments only, no real code involved. PR: misc/101245 Submitted by: Darren Pilgrim Tested by: md5(1) MFC after: 1 week Revision Changes Path 1.29 +1 -1 src/bin/sh/histedit.c 1.224 +1 -1 src/games/fortune/datfiles/fortunes 1.18 +1 -1 src/lib/libc/sys/kse.2 1.6 +1 -1 src/release/doc/fr_FR.ISO8859-1/hardware/alpha/proc-alpha.sgml 1.4 +1 -1 src/share/doc/papers/timecounter/timecounter.ms 1.5 +1 -1 src/share/man/man4/devctl.4 1.37 +1 -1 src/sys/boot/i386/loader/main.c 1.23 +1 -1 src/sys/boot/pc98/loader/main.c 1.22 +1 -1 src/sys/dev/bktr/CHANGELOG.TXT 1.52 +1 -1 src/sys/dev/dpt/dpt_scsi.c 1.125 +1 -1 src/sys/dev/em/if_em.c 1.97 +1 -1 src/sys/dev/fe/if_fe.c 1.19 +1 -1 src/sys/dev/ixgb/if_ixgb.c 1.7 +1 -1 src/sys/dev/patm/if_patm_intr.c 1.70 +2 -2 src/sys/dev/pci/pcivar.h 1.8 +1 -1 src/sys/dev/sym/sym_fw1.h 1.9 +1 -1 src/sys/dev/sym/sym_fw2.h 1.20 +1 -1 src/sys/fs/hpfs/hpfs.h 1.28 +1 -1 src/sys/geom/bde/g_bde_work.c 1.87 +1 -1 src/sys/geom/mirror/g_mirror.c 1.71 +1 -1 src/sys/geom/raid3/g_raid3.c 1.206 +2 -2 src/sys/i386/i386/tsc.c 1.159 +1 -1 src/sys/kern/kern_resource.c 1.177 +1 -1 src/sys/kern/kern_tc.c 1.195 +1 -1 src/sys/kern/subr_bus.c 1.190 +1 -1 src/sys/pci/ncr.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 08:02:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7688216A4DA; Fri, 4 Aug 2006 08:02:09 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1162543D49; Fri, 4 Aug 2006 08:02:07 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k74826NH013662; Fri, 4 Aug 2006 12:02:06 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k74825x6013661; Fri, 4 Aug 2006 12:02:05 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 12:02:05 +0400 From: Yar Tikhiy To: Stefan Farfeleder Message-ID: <20060804080205.GV97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> <20060804075230.GD89735@wombat.fafoe.narf.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804075230.GD89735@wombat.fafoe.narf.at> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:02:09 -0000 On Fri, Aug 04, 2006 at 09:52:31AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > > sweeps separate from actual code changes even if they are tiny. > > > > Changing style(9) shouldn't alter the binary code produced, and > > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > > Of course, changing line numbers will affect debug info, but the > > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > > if_em.o with its former version to make sure no code changed. > > > > > > It will produce different code if __LINE__ is used. > > > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > > Fortunately, they are not widely used in src/, AFAIK. > > Not directly, but through all kinds of assertion macros. At least, KASSERT() doesn't use __LINE__. No doubt there may be others that do. -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 4 08:03:06 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B49316A4E2; Fri, 4 Aug 2006 08:03:06 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58DFD43D58; Fri, 4 Aug 2006 08:03:05 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k74833Hc013679; Fri, 4 Aug 2006 12:03:03 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k74833Zp013678; Fri, 4 Aug 2006 12:03:03 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 12:03:03 +0400 From: Yar Tikhiy To: Colin Percival Message-ID: <20060804080302.GW97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <44D2FBF5.1010402@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D2FBF5.1010402@freebsd.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:03:06 -0000 On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote: > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.999999999999999994579% verify it. :-) And cksum(1) loses even more :-) -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 4 08:15:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 502C916A4E2 for ; Fri, 4 Aug 2006 08:15:22 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from pd2mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A678C43D45 for ; Fri, 4 Aug 2006 08:15:12 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd2mr4so.prod.shaw.ca (pd2mr4so-qfe3.prod.shaw.ca [10.0.141.107]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G00CYZS924U00@l-daemon> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 02:15:02 -0600 (MDT) Received: from pn2ml5so.prod.shaw.ca ([10.0.121.149]) by pd2mr4so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0J3G00FT2S91FJM0@pd2mr4so.prod.shaw.ca> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 02:15:02 -0600 (MDT) Received: from hexahedron.daemonology.net ([24.82.18.31]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with SMTP id <0J3G00FJ7S919I22@l-daemon> for cvs-src@FreeBSD.org; Fri, 04 Aug 2006 02:15:01 -0600 (MDT) Received: (qmail 3985 invoked from network); Fri, 04 Aug 2006 08:14:55 +0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; Fri, 04 Aug 2006 08:14:55 +0000 Date: Fri, 04 Aug 2006 01:14:54 -0700 From: Colin Percival In-reply-to: <20060804074657.GT97316@comp.chem.msu.su> To: Yar Tikhiy Message-id: <44D301FE.6030007@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Enigmail-Version: 0.94.0.0 References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> User-Agent: Thunderbird 1.5 (X11/20060416) Cc: cvs-src@FreeBSD.org, Stefan Farfeleder , pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:15:22 -0000 Yar Tikhiy wrote: > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. FWIW, the following files in 6.1-RELEASE/i386 contain build timestamps: /boot/GENERIC/hptmv.ko /boot/GENERIC/kernel /boot/SMP/hptmv.ko /boot/SMP/kernel /boot/loader /boot/pxeboot /etc/mail/freebsd.cf /etc/mail/freebsd.submit.cf /etc/mail/sendmail.cf /etc/mail/submit.cf /lib/libcrypto.so.4 /usr/bin/ntpq /usr/include/osreldate.h /usr/sbin/amd /usr/sbin/iasl /usr/sbin/isdnd /usr/sbin/isdndebug /usr/sbin/isdnmonitor /usr/sbin/isdnphone /usr/sbin/isdntelctl /usr/sbin/lwresd /usr/sbin/named /usr/sbin/ntpd /usr/sbin/ntpdate /usr/sbin/ntpdc /usr/sbin/ppp Of these, I've recently removed the timestamps in /usr/sbin/isdn*, and dougb has a patch to remove the timestamps in lwresd and named. There are also timestamps in all of the library archive files, but those are required by the archive format, so we can't do much about them. Colin Percival From owner-cvs-src@FreeBSD.ORG Fri Aug 4 08:17:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 350E716A4DD; Fri, 4 Aug 2006 08:17:38 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep16-int.chello.at (viefep13-int.chello.at [213.46.255.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2B3C43D76; Fri, 4 Aug 2006 08:17:30 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep16-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060804081728.KUAK14012.viefep16-int.chello.at@wombat.fafoe.narf.at>; Fri, 4 Aug 2006 10:17:28 +0200 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 46598BC7E; Fri, 4 Aug 2006 09:52:31 +0200 (CEST) Date: Fri, 4 Aug 2006 09:52:31 +0200 From: Stefan Farfeleder To: Yar Tikhiy Message-ID: <20060804075230.GD89735@wombat.fafoe.narf.at> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, Stefan Farfeleder , pdeuskar@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 08:17:38 -0000 On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual code changes even if they are tiny. > > > Changing style(9) shouldn't alter the binary code produced, and > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > Of course, changing line numbers will affect debug info, but the > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > if_em.o with its former version to make sure no code changed. > > > > It will produce different code if __LINE__ is used. > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > Fortunately, they are not widely used in src/, AFAIK. Not directly, but through all kinds of assertion macros. Stefan From owner-cvs-src@FreeBSD.ORG Fri Aug 4 09:31:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66CA816A4DA; Fri, 4 Aug 2006 09:31:41 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD9D443D4C; Fri, 4 Aug 2006 09:31:40 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 700AC46D09; Fri, 4 Aug 2006 05:31:40 -0400 (EDT) Date: Fri, 4 Aug 2006 10:31:40 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Hajimu UMEMOTO In-Reply-To: Message-ID: <20060804103056.C45647@fledge.watson.org> References: <200608030536.k735aIT3081092@sep.oldach.net> <20060803104026.A45647@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: scottl@samsco.org, kensmith@cse.Buffalo.EDU, cvs-src@FreeBSD.org, bz@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Helge Oldach Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 09:31:41 -0000 On Fri, 4 Aug 2006, Hajimu UMEMOTO wrote: >>>>>> On Thu, 3 Aug 2006 10:43:21 +0100 (BST) >>>>>> Robert Watson said: > > rwatson> not sure he's had a chance to generate a resolver bug report. He reported > rwatson> that the application appeared to have two connected UDP sockets for name > rwatson> resolution, and one bad name server entry, but that the resolver appeared to > rwatson> be blocked in a read on the UDP socket that didn't have data queued, rather > rwatson> than the one that did. This was all from looking at netstat, and as far as I > > Are you make sure it is not kevent but read? Yes -- the stack traces appeared clear. Hopefully Bjoern will be able to submit a more detailed analysis at some point soon. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Fri Aug 4 09:54:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F0D916A4DE; Fri, 4 Aug 2006 09:54:18 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57B1A43D49; Fri, 4 Aug 2006 09:54:17 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k749sF1T034887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 13:54:15 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k749sEh7034882; Fri, 4 Aug 2006 13:54:14 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 4 Aug 2006 13:54:14 +0400 From: Gleb Smirnoff To: Prafulla Deuskar Message-ID: <20060804095414.GU96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200608031905.k73J55D2061870@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 09:54:18 -0000 Prafulla, On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: P> pdeuskar 2006-08-03 19:05:05 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c if_em.h P> Log: P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. P> This makes it easier for us to get the changes into -current and to -stable quickly. Can you please confirm that this was a mechanical substitution like this: s/sc/adapter/g s/em_softc/adapter/g and no more additional changes? If this is true, then I hope that we (FreeBSD and Intel) have finally came to a common codebase. This is good. :) I can stand the long unusual name for driver softc with no problems. I'm only a bit disappointed by the fact, that I haven't received a single email about these plans. You were in the void for a long time, and then began your work with a commit, w/o informing people who were maintaining driver while the vendor maintanance was on a hiatus. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Aug 4 10:21:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85C8416A4DD; Fri, 4 Aug 2006 10:21:12 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4040B43D46; Fri, 4 Aug 2006 10:21:12 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74ALCLg065930; Fri, 4 Aug 2006 10:21:12 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74ALC6o065929; Fri, 4 Aug 2006 10:21:12 GMT (envelope-from ume) Message-Id: <200608041021.k74ALC6o065929@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Fri, 4 Aug 2006 10:21:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/resolv res_init.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 10:21:12 -0000 ume 2006-08-04 10:21:11 UTC FreeBSD src repository Modified files: lib/libc/resolv res_init.c Log: _close() should be called instead of close() here. Revision Changes Path 1.3 +6 -2 src/lib/libc/resolv/res_init.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 10:50:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10E6016A4E2; Fri, 4 Aug 2006 10:50:53 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCD7443D49; Fri, 4 Aug 2006 10:50:52 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74AoqtB067298; Fri, 4 Aug 2006 10:50:52 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74Aoq7K067296; Fri, 4 Aug 2006 10:50:52 GMT (envelope-from oleg) Message-Id: <200608041050.k74Aoq7K067296@repoman.freebsd.org> From: Oleg Bulyzhin Date: Fri, 4 Aug 2006 10:50:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 10:50:53 -0000 oleg 2006-08-04 10:50:52 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Remove useless NULL pointer check: we are using M_WAITOK flag for memory allocation. Submitted by: Andrey Elsukov Approved by: glebius (mentor) MFC after: 1 week Revision Changes Path 1.142 +0 -4 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 12:26:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E641916A4DD; Fri, 4 Aug 2006 12:26:08 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EF8A43D45; Fri, 4 Aug 2006 12:26:08 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74CQ8dQ075023; Fri, 4 Aug 2006 12:26:08 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74CQ8fI075022; Fri, 4 Aug 2006 12:26:08 GMT (envelope-from ume) Message-Id: <200608041226.k74CQ8fI075022@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Fri, 4 Aug 2006 12:26:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/resolv res_send.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 12:26:09 -0000 ume 2006-08-04 12:26:08 UTC FreeBSD src repository Modified files: lib/libc/resolv res_send.c Log: Check if the filedes of kevent is expected one. Though our old resolver opened just one socket, BIND9's resolver may open more than one sockets. And, BIND9's resolver doesn't close the socket on timeout. So, we need this check. Reported by: freebsd-cvs-src__at__oldach.net (Helge Oldach), bz Hinted by: rwatson Revision Changes Path 1.3 +4 -0 src/lib/libc/resolv/res_send.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 12:38:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAD9D16A4DE; Fri, 4 Aug 2006 12:38:47 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from ameno.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9022A43D49; Fri, 4 Aug 2006 12:38:45 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from kasuga.mahoroba.org (IDENT:f1Uf1xcTReTfjCf9aK12o6lgcDkp/Ivv8Uuz6k/ul4R0oOOY9+YzTHJdStl+ZDAT@kasuga-iwi.mahoroba.org [IPv6:2001:2f0:104:8010:212:f0ff:fe52:6ac]) (user=ume mech=CRAM-MD5 bits=0) by ameno.mahoroba.org (8.13.6/8.13.6) with ESMTP/inet6 id k74CcXuP005290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 21:38:38 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Fri, 04 Aug 2006 21:38:33 +0900 Message-ID: From: Hajimu UMEMOTO To: freebsd-cvs-src@oldach.net (Helge Oldach) In-Reply-To: <200608040550.k745ojss063972@sep.oldach.net> References: <200608040550.k745ojss063972@sep.oldach.net> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-pc-freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 6.1-STABLE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.1.12 (ameno.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Fri, 04 Aug 2006 21:38:40 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on ameno.mahoroba.org Cc: scottl@samsco.org, src-committers@FreeBSD.org, Hajimu UMEMOTO , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, kensmith@cse.Buffalo.EDU Subject: Re: cvs commit: src/sys/sys param.h src/include Makefile netdb.h res_update.h resolv.h src/include/arpa inet.h nameser.h nameser X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 12:38:47 -0000 Hi, >>>>> On Fri, 4 Aug 2006 07:50:45 +0200 (CEST) >>>>> Helge Oldach said: freebsd-cvs-src> Yes, certainly. As I've said, this issue shows up on several boxes. This freebsd-cvs-src> includes machines with only a single resolver (which is up of course), freebsd-cvs-src> resolving towards the internet, machines that talk to localhost (running freebsd-cvs-src> a caching named with forwarders to public servers), but also to machines freebsd-cvs-src> running on an internal network with private root servers. Actually I had freebsd-cvs-src> already played around a bit with this, without any noticeable effect. Okay. Perhaps, I found the cause. Please try the following change and let me know the result: http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/resolv/res_send.c.diff?r1=1.2&r2=1.3 Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ From owner-cvs-src@FreeBSD.ORG Fri Aug 4 13:36:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57F7516A4DE; Fri, 4 Aug 2006 13:36:29 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C8ED43D5C; Fri, 4 Aug 2006 13:36:28 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74DaSLf089156; Fri, 4 Aug 2006 13:36:28 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74DaSRI089155; Fri, 4 Aug 2006 13:36:28 GMT (envelope-from glebius) Message-Id: <200608041336.k74DaSRI089155@repoman.freebsd.org> From: Gleb Smirnoff Date: Fri, 4 Aug 2006 13:36:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 13:36:29 -0000 glebius 2006-08-04 13:36:28 UTC FreeBSD src repository Modified files: sys/netgraph ng_ether.c Log: Turn off by default "feature" that overwrites MAC address on output frames. Many people were confused with not working CARP, ng_bridge(4) and other subsystems, because ng_ether(4) overwritten source MAC address. Revision Changes Path 1.61 +0 -1 src/sys/netgraph/ng_ether.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 13:37:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B006016A4DD; Fri, 4 Aug 2006 13:37:55 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6957143D58; Fri, 4 Aug 2006 13:37:55 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74DbtTS089246; Fri, 4 Aug 2006 13:37:55 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74DbtMR089245; Fri, 4 Aug 2006 13:37:55 GMT (envelope-from delphij) Message-Id: <200608041337.k74DbtMR089245@repoman.freebsd.org> From: Xin LI Date: Fri, 4 Aug 2006 13:37:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 13:37:55 -0000 delphij 2006-08-04 13:37:54 UTC FreeBSD src repository Modified files: libexec/rtld-elf rtld.c Log: In symlook_obj(): fix _rtld_error output. MFC After: 2 weeks Revision Changes Path 1.115 +2 -2 src/libexec/rtld-elf/rtld.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 13:49:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E164E16A4DA; Fri, 4 Aug 2006 13:49:17 +0000 (UTC) (envelope-from mr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BD8C43D4C; Fri, 4 Aug 2006 13:49:17 +0000 (GMT) (envelope-from mr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74DnHpA089901; Fri, 4 Aug 2006 13:49:17 GMT (envelope-from mr@repoman.freebsd.org) Received: (from mr@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74DnHbs089900; Fri, 4 Aug 2006 13:49:17 GMT (envelope-from mr) Message-Id: <200608041349.k74DnHbs089900@repoman.freebsd.org> From: Michael Reifenberger Date: Fri, 4 Aug 2006 13:49:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 13:49:18 -0000 mr 2006-08-04 13:49:16 UTC FreeBSD src repository Modified files: sys/i386/i386 identcpu.c Log: Dont overwrite cpu_model in the case of Via's C3-CPU. Noticed by: Mike Tancsa MFC after: 2 days Revision Changes Path 1.169 +2 -1 src/sys/i386/i386/identcpu.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 14:38:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 916) id 9A30316A4E5; Fri, 4 Aug 2006 14:38:25 +0000 (UTC) Date: Fri, 4 Aug 2006 14:38:25 +0000 From: Prafulla Deuskar To: Gleb Smirnoff Message-ID: <20060804143825.GA8797@hub.freebsd.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804095414.GU96644@FreeBSD.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 6.1-STABLE on an i386 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 14:38:25 -0000 Gleb Smirnoff [glebius@FreeBSD.org] wrote: > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > P> pdeuskar 2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > P> This makes it easier for us to get the changes into -current and to -stable quickly. > > Can you please confirm that this was a mechanical substitution like this: > > s/sc/adapter/g > s/em_softc/adapter/g > > and no more additional changes? If this is true, then I hope that we > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) > I can stand the long unusual name for driver softc with no problems. > > I'm only a bit disappointed by the fact, that I haven't received a single > email about these plans. You were in the void for a long time, and > then began your work with a commit, w/o informing people who were > maintaining driver while the vendor maintanance was on a hiatus. > Yes - it was a mechanical substitution. And thanks for taking care of 6.0.5 release. Thanks, Prafulla From owner-cvs-src@FreeBSD.ORG Fri Aug 4 14:43:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCD0116A4E2; Fri, 4 Aug 2006 14:43:46 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr8.xs4all.nl (smtp-vbr8.xs4all.nl [194.109.24.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id E288843D5F; Fri, 4 Aug 2006 14:43:37 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr8.xs4all.nl (8.13.6/8.13.6) with ESMTP id k74EhCeO015662; Fri, 4 Aug 2006 16:43:13 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.6/8.13.3) with ESMTP id k74EhCKW007221; Fri, 4 Aug 2006 16:43:12 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.6/8.13.6/Submit) id k74EhCjd007220; Fri, 4 Aug 2006 16:43:12 +0200 (CEST) (envelope-from wb) Date: Fri, 4 Aug 2006 16:43:11 +0200 From: Wilko Bulte To: Colin Percival Message-ID: <20060804144311.GA7175@freebie.xs4all.nl> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> <20060804071909.GS97316@comp.chem.msu.su> <44D2FBF5.1010402@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D2FBF5.1010402@freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Yar Tikhiy , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 14:43:46 -0000 On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote.. > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.999999999999999994579% verify it. :-) Is that with or without HT switched on? -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:14:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 213D916A4DD; Fri, 4 Aug 2006 15:14:25 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6115443D45; Fri, 4 Aug 2006 15:14:24 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k74FEMSl036879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 19:14:23 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k74FEMR6036878; Fri, 4 Aug 2006 19:14:22 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 4 Aug 2006 19:14:22 +0400 From: Gleb Smirnoff To: Prafulla Deuskar Message-ID: <20060804151422.GE96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060804143825.GA8797@hub.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:14:25 -0000 On Fri, Aug 04, 2006 at 02:38:25PM +0000, Prafulla Deuskar wrote: P> > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. P> > P> This makes it easier for us to get the changes into -current and to -stable quickly. P> > P> > Can you please confirm that this was a mechanical substitution like this: P> > P> > s/sc/adapter/g P> > s/em_softc/adapter/g P> > P> > and no more additional changes? If this is true, then I hope that we P> > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) P> > I can stand the long unusual name for driver softc with no problems. P> P> Yes - it was a mechanical substitution. P> And thanks for taking care of 6.0.5 release. Thanks. Any objections about merging the HEAD to RELENG_6 soon? I'm going to wait for about a week to see whether any problems with 6.0.5 or not. Also I need to look at new defects that Coverity has found in if_em_hw.c after 6.0.5 import. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:15:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2EDB16A4DF; Fri, 4 Aug 2006 15:15:11 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C3F943D49; Fri, 4 Aug 2006 15:15:10 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k74FF9Cd036903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 19:15:09 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k74FF9G5036902; Fri, 4 Aug 2006 19:15:09 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 4 Aug 2006 19:15:09 +0400 From: Gleb Smirnoff To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060804151509.GF96644@FreeBSD.org> References: <200608041336.k74DaSRI089155@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200608041336.k74DaSRI089155@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: Subject: Re: cvs commit: src/sys/netgraph ng_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:15:12 -0000 On Fri, Aug 04, 2006 at 01:36:28PM +0000, Gleb Smirnoff wrote: T> glebius 2006-08-04 13:36:28 UTC T> T> FreeBSD src repository T> T> Modified files: T> sys/netgraph ng_ether.c T> Log: T> Turn off by default "feature" that overwrites MAC address T> on output frames. T> T> Many people were confused with not working CARP, ng_bridge(4) T> and other subsystems, because ng_ether(4) overwritten source T> MAC address. About a year ago or more I have discussed this change with Yar and Julian. AFAIR, there were no objections. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:36:05 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E82716A65A; Fri, 4 Aug 2006 15:36:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6044E43D49; Fri, 4 Aug 2006 15:36:04 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k74FZnG1003112; Fri, 4 Aug 2006 11:35:51 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Fri, 4 Aug 2006 11:03:05 -0400 User-Agent: KMail/1.9.1 References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608041103.06045.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 Aug 2006 11:35:51 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, Stefan Farfeleder , pdeuskar@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:36:05 -0000 On Friday 04 August 2006 03:46, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual code changes even if they are tiny. > > > Changing style(9) shouldn't alter the binary code produced, and > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > > Of course, changing line numbers will affect debug info, but the > > > latter can be strip(1)'ed. In the case under discussion, I'd compare > > > if_em.o with its former version to make sure no code changed. > > > > It will produce different code if __LINE__ is used. > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > Fortunately, they are not widely used in src/, AFAIK. If you have INVARIANTS on then every mtx_lock/unlock will include __LINE__ and __FILE__. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:36:15 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EC4116A505; Fri, 4 Aug 2006 15:36:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id E884143D46; Fri, 4 Aug 2006 15:36:08 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k74FZnG0003112; Fri, 4 Aug 2006 11:35:49 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Fri, 4 Aug 2006 11:01:54 -0400 User-Agent: KMail/1.9.1 References: <200608030959.k739x9N6007207@repoman.freebsd.org> <200608031458.01134.jhb@freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> In-Reply-To: <20060804070348.GR97316@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608041101.55924.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 Aug 2006 11:35:50 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Sam Leffler , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:36:15 -0000 On Friday 04 August 2006 03:03, Yar Tikhiy wrote: > On Thu, Aug 03, 2006 at 02:58:00PM -0400, John Baldwin wrote: > > On Thursday 03 August 2006 14:08, Yar Tikhiy wrote: > > > On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: > > > > Yar Tikhiy wrote: > > > > > yar 2006-08-03 09:59:09 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/net if_vlan.c > > > > > Log: > > > > > Should vlan_input() ever be called with ifp pointing to a non-Ethernet > > > > > interface, do not just assign -1 to tag because it breaks the logic of > > > > > the code to follow. The better way is to handle this case as an > > unsupported > > > > > protocol and return unless INVARIANTS is in effect and we can panic. > > > > > Panic is good there because the scenario can happen only because of a > > > > > coding error elsewhere. > > > > > > > > > > We also should show the interface name in the panic message for easier > > > > > debugging of the problem, should it ever emerge. > > > > > > > > Introducing a panic in a place where you can trivially recover is bad > > > > regardless of why you got there. Many people run production systems > > > > with INVARIANTS turned on. Is it now possible to send a "packet of > > > > death" by exploiting this code path? > > > > > > No nastygram can ever achieve this; only FreeBSD commiters possess > > > the ability to :-) > > > > > > The panic can never be reached unless one manages to attach a vlan > > > interface to a non-Ethernet physical interface in advance, which > > > is totally prohibited by the code at the beginning of vlan_config(); > > > and vlan_config() is the only way to attach a vlan interface to a > > > physical interface. > > > > > > I.e., it will take a developer breaking the logic in /sys/net to > > > make the code path expoloitable. > > > > > > OTOH, you are right that we can at least attempt to recover from > > > the situation. Perhaps it's time to introduce a common macro or > > > function that emits a message on the console and then just calls > > > kdb_backtrace() instead of dumping core and halting the system? > > > So users will be able to post the stack traces to the lists and > > > thus help to spot the possible bugs w/o having to go through panics. > > > I'm unsure if sticking raw kdb_backtrace() calls in such places > > > is a good idea, so I'm suggesting a wrapper function or macro. > > > It is to be used in "can absolutely never happen" cases that are > > > not fatal, like the one under discussion. > > > > kdb_backtrace() is the wrapper function around other internals. :) > > Of course, we can always grep /sys for its usage later ;-) > > Just noticed that many calls to kdb_backtrace() are under "#ifdef > KDB" while subr_kdb.c is marked as standard in /sys/conf/files and > the function itself is always available (yet can do nothing.) > > Should calls to kdb_backtrace() be put under "#ifdef KDB"? If they > should, it can justify introducing the combined printf+trace function. If kdb_backtrace() is always present, then the calls probably shouldn't be under the #ifdef. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 4 15:44:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADEA416A4E6 for ; Fri, 4 Aug 2006 15:44:15 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D65EC43D67 for ; Fri, 4 Aug 2006 15:44:12 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 12579 invoked from network); 4 Aug 2006 15:35:21 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 4 Aug 2006 15:35:21 -0000 Message-ID: <44D36B4B.4050605@freebsd.org> Date: Fri, 04 Aug 2006 17:44:11 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Prafulla Deuskar References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> In-Reply-To: <20060804143825.GA8797@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 15:44:15 -0000 Prafulla Deuskar wrote: > Gleb Smirnoff [glebius@FreeBSD.org] wrote: >> Prafulla, >> >> On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: >> P> pdeuskar 2006-08-03 19:05:05 UTC >> P> >> P> FreeBSD src repository >> P> >> P> Modified files: >> P> sys/dev/em if_em.c if_em.h >> P> Log: >> P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. >> P> This makes it easier for us to get the changes into -current and to -stable quickly. >> >> Can you please confirm that this was a mechanical substitution like this: >> >> s/sc/adapter/g >> s/em_softc/adapter/g >> >> and no more additional changes? If this is true, then I hope that we >> (FreeBSD and Intel) have finally came to a common codebase. This is good. :) >> I can stand the long unusual name for driver softc with no problems. >> >> I'm only a bit disappointed by the fact, that I haven't received a single >> email about these plans. You were in the void for a long time, and >> then began your work with a commit, w/o informing people who were >> maintaining driver while the vendor maintanance was on a hiatus. >> > > Yes - it was a mechanical substitution. According to jb@freebsd.org at least one non-mechanical change slipped in breaking his Sun4v box. AFAIR some fix in/with bus_dmamap_unload() was reverted. -- Andre From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:14:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B279F16A4DA; Fri, 4 Aug 2006 16:14:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 456E343D45; Fri, 4 Aug 2006 16:14:59 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k74GBdr8098538; Fri, 4 Aug 2006 10:11:39 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 04 Aug 2006 10:11:39 -0600 (MDT) Message-Id: <20060804.101139.71187145.imp@bsdimp.com> To: cperciva@FreeBSD.org From: Warner Losh In-Reply-To: <44D301FE.6030007@freebsd.org> References: <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su> <44D301FE.6030007@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 04 Aug 2006 10:11:39 -0600 (MDT) Cc: src-committers@FreeBSD.org, yar@comp.chem.msu.su, cvs-all@FreeBSD.org, stefanf@FreeBSD.org, pdeuskar@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:14:59 -0000 From: Colin Percival Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 04 Aug 2006 01:14:54 -0700 > Yar Tikhiy wrote: > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > > FWIW, the following files in 6.1-RELEASE/i386 contain build timestamps: > > /boot/GENERIC/hptmv.ko > /boot/GENERIC/kernel > /boot/SMP/hptmv.ko > /boot/SMP/kernel > /boot/loader > /boot/pxeboot > /etc/mail/freebsd.cf > /etc/mail/freebsd.submit.cf > /etc/mail/sendmail.cf > /etc/mail/submit.cf > /lib/libcrypto.so.4 > /usr/bin/ntpq > /usr/include/osreldate.h > /usr/sbin/amd > /usr/sbin/iasl > /usr/sbin/isdnd > /usr/sbin/isdndebug > /usr/sbin/isdnmonitor > /usr/sbin/isdnphone > /usr/sbin/isdntelctl > /usr/sbin/lwresd > /usr/sbin/named > /usr/sbin/ntpd > /usr/sbin/ntpdate > /usr/sbin/ntpdc > /usr/sbin/ppp > > Of these, I've recently removed the timestamps in /usr/sbin/isdn*, and > dougb has a patch to remove the timestamps in lwresd and named. > > There are also timestamps in all of the library archive files, but those > are required by the archive format, so we can't do much about them. All static binaries on the system, in current, have the entire path to where the source code was built encoded into. This is due to an assert being used in malloc and other code which expands __FILE__, which gives you the entire path. Since we don't compile with -DNDEBUG, we expose ourselves to this. I have in my local tree a knob that allows one to turn on compiling with -DNDEBUG that I didn't have time to integrate before my move. Warner From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:18:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5948C16A4E5; Fri, 4 Aug 2006 16:18:18 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3CDC43D7C; Fri, 4 Aug 2006 16:18:11 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k74GEwC1098549; Fri, 4 Aug 2006 10:14:58 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 04 Aug 2006 10:14:58 -0600 (MDT) Message-Id: <20060804.101458.104131397.imp@bsdimp.com> To: glebius@freebsd.org From: Warner Losh In-Reply-To: <20060804095414.GU96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 04 Aug 2006 10:14:59 -0600 (MDT) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, pdeuskar@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:18:18 -0000 From: Gleb Smirnoff Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 4 Aug 2006 13:54:14 +0400 > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > P> pdeuskar 2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > P> This makes it easier for us to get the changes into -current and to -stable quickly. > > Can you please confirm that this was a mechanical substitution like this: > > s/sc/adapter/g > s/em_softc/adapter/g > > and no more additional changes? If this is true, then I hope that we > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) > I can stand the long unusual name for driver softc with no problems. That's what my eyeball of the patch showed. > I'm only a bit disappointed by the fact, that I haven't received a single > email about these plans. You were in the void for a long time, and > then began your work with a commit, w/o informing people who were > maintaining driver while the vendor maintanance was on a hiatus. You can blame that last part. Prafulla had sent several versions of the patch to me for review. I had gotten the mistaken impression that you were not longer interested in em (which appears to be in error), so I didn't have him bounce them off of you first. Please accept my appologies for not suggesting you be in the loop more. I gave him my signoff on the patch a few hours after you commited to em, but I didn't notice this until after he'd committed (gotta love qwest, nuf said). I soon realized my mistake, and would like to offer a public appology for it. Warner From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:21:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 916) id D065F16A4DD; Fri, 4 Aug 2006 16:21:49 +0000 (UTC) Date: Fri, 4 Aug 2006 16:21:49 +0000 From: Prafulla Deuskar To: Gleb Smirnoff Message-ID: <20060804162149.GB22299@hub.freebsd.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <20060804151422.GE96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804151422.GE96644@FreeBSD.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 6.1-STABLE on an i386 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:21:49 -0000 Gleb Smirnoff [glebius@FreeBSD.org] wrote: > On Fri, Aug 04, 2006 at 02:38:25PM +0000, Prafulla Deuskar wrote: > P> > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > P> > P> This makes it easier for us to get the changes into -current and to -stable quickly. > P> > > P> > Can you please confirm that this was a mechanical substitution like this: > P> > > P> > s/sc/adapter/g > P> > s/em_softc/adapter/g > P> > > P> > and no more additional changes? If this is true, then I hope that we > P> > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) > P> > I can stand the long unusual name for driver softc with no problems. > P> > P> Yes - it was a mechanical substitution. > P> And thanks for taking care of 6.0.5 release. > > Thanks. Any objections about merging the HEAD to RELENG_6 soon? Jack Vogel is doing the merge - I will send it out to you for review. So let us plan on committing early next week? Is there a report on what coverty found with if_em_hw.c? Thanks, Prafulla From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:24:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C68A016A4DF; Fri, 4 Aug 2006 16:24:31 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3998843D5F; Fri, 4 Aug 2006 16:24:28 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.150] (pptp0.pn.xcllnt.net [192.168.4.150]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k74GO5RT030919; Fri, 4 Aug 2006 09:24:06 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20060804070348.GR97316@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> <200608031458.01134.jhb@freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 4 Aug 2006 09:23:52 -0700 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.2) Cc: Sam Leffler , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:24:31 -0000 On Aug 4, 2006, at 12:03 AM, Yar Tikhiy wrote: > Just noticed that many calls to kdb_backtrace() are under "#ifdef > KDB" while subr_kdb.c is marked as standard in /sys/conf/files and > the function itself is always available (yet can do nothing.) > > Should calls to kdb_backtrace() be put under "#ifdef KDB"? If they > should, it can justify introducing the combined printf+trace function. subr_kdb.c is indeed unconditional. The reason is that it contains the interface functions and you should not make interface functions optional if modules can reference them. The KDB option is there to tell that one wants debugging features enabled. This means for example that serial drivers react to the line break condition by going into the debugger. Without the KDB option line break conditions just result in a 0-character in the input stream. So, putting the kdb_backtrace() under KDB is not a matter of said function not being present without KDB, it's that we don't want to emit backtraces when debugging is not enabled. Backtraces are a debugging tool and it makes sense to emit them only when the kernel is configured for debugging. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:28:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F06316A4DD; Fri, 4 Aug 2006 16:28:13 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 988CF43D46; Fri, 4 Aug 2006 16:28:12 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k74GRuqZ044252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 09:27:57 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44D3758C.1000609@errno.com> Date: Fri, 04 Aug 2006 09:27:56 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.4 (X11/20060724) MIME-Version: 1.0 To: Yar Tikhiy References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> In-Reply-To: <20060803180854.GI97316@comp.chem.msu.su> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:28:13 -0000 Yar Tikhiy wrote: > On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: >> Yar Tikhiy wrote: >>> yar 2006-08-03 09:59:09 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/net if_vlan.c >>> Log: >>> Should vlan_input() ever be called with ifp pointing to a non-Ethernet >>> interface, do not just assign -1 to tag because it breaks the logic of >>> the code to follow. The better way is to handle this case as an unsupported >>> protocol and return unless INVARIANTS is in effect and we can panic. >>> Panic is good there because the scenario can happen only because of a >>> coding error elsewhere. >>> >>> We also should show the interface name in the panic message for easier >>> debugging of the problem, should it ever emerge. >> Introducing a panic in a place where you can trivially recover is bad >> regardless of why you got there. Many people run production systems >> with INVARIANTS turned on. Is it now possible to send a "packet of >> death" by exploiting this code path? > > No nastygram can ever achieve this; only FreeBSD commiters possess > the ability to :-) > > The panic can never be reached unless one manages to attach a vlan > interface to a non-Ethernet physical interface in advance, which > is totally prohibited by the code at the beginning of vlan_config(); > and vlan_config() is the only way to attach a vlan interface to a > physical interface. > > I.e., it will take a developer breaking the logic in /sys/net to > make the code path expoloitable. > > OTOH, you are right that we can at least attempt to recover from > the situation. Perhaps it's time to introduce a common macro or > function that emits a message on the console and then just calls > kdb_backtrace() instead of dumping core and halting the system? > So users will be able to post the stack traces to the lists and > thus help to spot the possible bugs w/o having to go through panics. > I'm unsure if sticking raw kdb_backtrace() calls in such places > is a good idea, so I'm suggesting a wrapper function or macro. > It is to be used in "can absolutely never happen" cases that are > not fatal, like the one under discussion. > It is my experience that problems like the "packet of death" come about from (well-meaning) planting of a landmine of this sort followed, sometime later, by another person enabling the code path. I work by the rule that panic should be used only in places where you have no way to recover or recovery is so hard as to be not worthwhile (based on the circumstances). Sam From owner-cvs-src@FreeBSD.ORG Fri Aug 4 16:29:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 916) id 3BC6B16A4DF; Fri, 4 Aug 2006 16:29:53 +0000 (UTC) Date: Fri, 4 Aug 2006 16:29:53 +0000 From: Prafulla Deuskar To: Andre Oppermann Message-ID: <20060804162953.GA24414@hub.freebsd.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <44D36B4B.4050605@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D36B4B.4050605@freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 6.1-STABLE on an i386 Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:29:53 -0000 Andre Oppermann [andre@freebsd.org] wrote: > Prafulla Deuskar wrote: > >Gleb Smirnoff [glebius@FreeBSD.org] wrote: > >> Prafulla, > >> > >>On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > >>P> pdeuskar 2006-08-03 19:05:05 UTC > >>P> > >>P> FreeBSD src repository > >>P> > >>P> Modified files: > >>P> sys/dev/em if_em.c if_em.h > >>P> Log: > >>P> Revert back changes to made in rev 1.109 of if_em.c which were > >>unnecessary. > >>P> This makes it easier for us to get the changes into -current and to > >>-stable quickly. > >> > >>Can you please confirm that this was a mechanical substitution like this: > >> > >>s/sc/adapter/g > >>s/em_softc/adapter/g > >> > >>and no more additional changes? If this is true, then I hope that we > >>(FreeBSD and Intel) have finally came to a common codebase. This is good. > >>:) > >>I can stand the long unusual name for driver softc with no problems. > >> > >>I'm only a bit disappointed by the fact, that I haven't received a single > >>email about these plans. You were in the void for a long time, and > >>then began your work with a commit, w/o informing people who were > >>maintaining driver while the vendor maintanance was on a hiatus. > >> > > > >Yes - it was a mechanical substitution. > > According to jb@freebsd.org at least one non-mechanical change slipped > in breaking his Sun4v box. AFAIR some fix in/with bus_dmamap_unload() > was reverted. I have looked at the diffs again after jb@ mentioned it last night. I don't think I have made any functionality changes. Thanks, Prafulla > From owner-cvs-src@FreeBSD.ORG Fri Aug 4 17:55:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1D6516A4DE; Fri, 4 Aug 2006 17:55:56 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36A2D43D45; Fri, 4 Aug 2006 17:55:56 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74HtuFP019823; Fri, 4 Aug 2006 17:55:56 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74HtuEf019822; Fri, 4 Aug 2006 17:55:56 GMT (envelope-from marcel) Message-Id: <200608041755.k74HtuEf019822@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 4 Aug 2006 17:55:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthread_db/arch/powerpc libc_r_md.c libpthread_md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 17:55:56 -0000 marcel 2006-08-04 17:55:56 UTC FreeBSD src repository Added files: lib/libthread_db/arch/powerpc libc_r_md.c libpthread_md.c Log: Add stub functions. This allows libthread_db to be built and installed, which means that we also have . Revision Changes Path 1.1 +41 -0 src/lib/libthread_db/arch/powerpc/libc_r_md.c (new) 1.1 +65 -0 src/lib/libthread_db/arch/powerpc/libpthread_md.c (new) From owner-cvs-src@FreeBSD.ORG Fri Aug 4 17:56:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD31116A508; Fri, 4 Aug 2006 17:56:31 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B53B43D45; Fri, 4 Aug 2006 17:56:31 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74HuVbI019890; Fri, 4 Aug 2006 17:56:31 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74HuVfh019889; Fri, 4 Aug 2006 17:56:31 GMT (envelope-from marcel) Message-Id: <200608041756.k74HuVfh019889@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 4 Aug 2006 17:56:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 17:56:31 -0000 marcel 2006-08-04 17:56:31 UTC FreeBSD src repository Modified files: lib Makefile Log: Build libthread_db on PowerPC. Revision Changes Path 1.215 +1 -1 src/lib/Makefile From owner-cvs-src@FreeBSD.ORG Fri Aug 4 17:58:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E208A16A4DE; Fri, 4 Aug 2006 17:58:41 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D3A143D49; Fri, 4 Aug 2006 17:58:41 +0000 (GMT) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74HwfgT019972; Fri, 4 Aug 2006 17:58:41 GMT (envelope-from gallatin@repoman.freebsd.org) Received: (from gallatin@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74HwfXm019971; Fri, 4 Aug 2006 17:58:41 GMT (envelope-from gallatin) Message-Id: <200608041758.k74HwfXm019971@repoman.freebsd.org> From: Andrew Gallatin Date: Fri, 4 Aug 2006 17:58:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mxge if_mxge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 17:58:42 -0000 gallatin 2006-08-04 17:58:41 UTC FreeBSD src repository Modified files: sys/dev/mxge if_mxge.c Log: Copy the link-layer address from our ifnet pointer at reset time so that the mac address can be overridden. Revision Changes Path 1.9 +3 -0 src/sys/dev/mxge/if_mxge.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 18:28:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B109216A4DD; Fri, 4 Aug 2006 18:28:58 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FDDF43D46; Fri, 4 Aug 2006 18:28:58 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74ISwKl023133; Fri, 4 Aug 2006 18:28:58 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74ISwJp023132; Fri, 4 Aug 2006 18:28:58 GMT (envelope-from glebius) Message-Id: <200608041828.k74ISwJp023132@repoman.freebsd.org> From: Gleb Smirnoff Date: Fri, 4 Aug 2006 18:28:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ng_ether.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 18:28:58 -0000 glebius 2006-08-04 18:28:58 UTC FreeBSD src repository Modified files: share/man/man4 ng_ether.4 Log: By default "autosrc" is off. Submitted by: ru Revision Changes Path 1.27 +2 -2 src/share/man/man4/ng_ether.4 From owner-cvs-src@FreeBSD.ORG Fri Aug 4 18:37:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8ABAF16A4DE; Fri, 4 Aug 2006 18:37:04 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 085E143D58; Fri, 4 Aug 2006 18:37:04 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74Ib30I023567; Fri, 4 Aug 2006 18:37:03 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74Ib39w023566; Fri, 4 Aug 2006 18:37:03 GMT (envelope-from des) Message-Id: <200608041837.k74Ib39w023566@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 4 Aug 2006 18:37:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 18:37:04 -0000 des 2006-08-04 18:37:03 UTC FreeBSD src repository Modified files: etc/rc.d Makefile Log: Forgot to add mountlate to the Makefile. Revision Changes Path 1.74 +1 -1 src/etc/rc.d/Makefile From owner-cvs-src@FreeBSD.ORG Fri Aug 4 19:24:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A3F516A4DE; Fri, 4 Aug 2006 19:24:58 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0063F43D45; Fri, 4 Aug 2006 19:24:57 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.56] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.6/8.13.6) with ESMTP id k74JOsg9063410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 12:24:55 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <44D39EE8.9090704@FreeBSD.org> Date: Fri, 04 Aug 2006 12:24:24 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Marcel Moolenaar References: <200608041755.k74HtuEf019822@repoman.freebsd.org> In-Reply-To: <200608041755.k74HtuEf019822@repoman.freebsd.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthread_db/arch/powerpc libc_r_md.c libpthread_md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 19:24:58 -0000 Cool, please let me know if you need access to the test hardware. We have several spare G4 Mac Minis in the office, so that I can install FreeBSD on one of them for you. -Maxim Marcel Moolenaar wrote: > marcel 2006-08-04 17:55:56 UTC > > FreeBSD src repository > > Added files: > lib/libthread_db/arch/powerpc libc_r_md.c libpthread_md.c > Log: > Add stub functions. This allows libthread_db to be built and installed, > which means that we also have . > > Revision Changes Path > 1.1 +41 -0 src/lib/libthread_db/arch/powerpc/libc_r_md.c (new) > 1.1 +65 -0 src/lib/libthread_db/arch/powerpc/libpthread_md.c (new) > > From owner-cvs-src@FreeBSD.ORG Fri Aug 4 19:33:23 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 684B916A4DD; Fri, 4 Aug 2006 19:33:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADCDB43D46; Fri, 4 Aug 2006 19:33:22 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k74JX60w007138; Fri, 4 Aug 2006 15:33:07 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Marcel Moolenaar Date: Fri, 4 Aug 2006 13:14:22 -0400 User-Agent: KMail/1.9.1 References: <200608030959.k739x9N6007207@repoman.freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> In-Reply-To: <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608041314.24161.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 04 Aug 2006 15:33:08 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Yar Tikhiy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Sam Leffler Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 19:33:23 -0000 On Friday 04 August 2006 12:23, Marcel Moolenaar wrote: > On Aug 4, 2006, at 12:03 AM, Yar Tikhiy wrote: > > > Just noticed that many calls to kdb_backtrace() are under "#ifdef > > KDB" while subr_kdb.c is marked as standard in /sys/conf/files and > > the function itself is always available (yet can do nothing.) > > > > Should calls to kdb_backtrace() be put under "#ifdef KDB"? If they > > should, it can justify introducing the combined printf+trace function. > > subr_kdb.c is indeed unconditional. The reason is that it contains > the interface functions and you should not make interface functions > optional if modules can reference them. > > The KDB option is there to tell that one wants debugging features > enabled. This means for example that serial drivers react to the > line break condition by going into the debugger. Without the KDB > option line break conditions just result in a 0-character in the > input stream. > > So, putting the kdb_backtrace() under KDB is not a matter of said > function not being present without KDB, it's that we don't want > to emit backtraces when debugging is not enabled. Backtraces are > a debugging tool and it makes sense to emit them only when the > kernel is configured for debugging. In practice this ends up being redundant though as to have kdb_backtrace() actually do anything you have to have DDB in your kernel config, which requires KDB. Places that call kdb_enter() aren't all #ifdef KDB IIRC. It's just a feature that kdb_foo() functions become NOPs when the kernel isn't configured for debugging, so I think the #ifdef KDB's would be redundant. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 4 19:39:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CB2F16A4DD; Fri, 4 Aug 2006 19:39:35 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC41B43D46; Fri, 4 Aug 2006 19:39:34 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost.xcllnt.net [127.0.0.1]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k74JdYdQ031860; Fri, 4 Aug 2006 12:39:34 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.13.6/8.13.6/Submit) id k74JdY3d031859; Fri, 4 Aug 2006 12:39:34 -0700 (PDT) (envelope-from marcel) Date: Fri, 4 Aug 2006 12:39:34 -0700 From: Marcel Moolenaar To: Maxim Sobolev Message-ID: <20060804193934.GA31805@ns1.xcllnt.net> References: <200608041755.k74HtuEf019822@repoman.freebsd.org> <44D39EE8.9090704@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D39EE8.9090704@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthread_db/arch/powerpc libc_r_md.c libpthread_md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 19:39:35 -0000 On Fri, Aug 04, 2006 at 12:24:24PM -0700, Maxim Sobolev wrote: > Cool, please let me know if you need access to the test hardware. We > have several spare G4 Mac Minis in the office, so that I can install > FreeBSD on one of them for you. I have a iMac G3 dedicated to FreeBSD. Not the fastest, be adequate for now. If you have a G4 Mini available for FreeBSD, maybe you could set one up to run tinderboxes? I have done that on pluto1 and pluto2 in the FreeBSD cluster for ia64 and it's not that hard. That machine could then also be used for snapshot builds. I can help you if you think it's a good idea... Thanks for the offer though! -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:02:15 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5B4B16A4DD; Fri, 4 Aug 2006 20:02:15 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F2AF43D45; Fri, 4 Aug 2006 20:02:15 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost.xcllnt.net [127.0.0.1]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k74K1sI2031981; Fri, 4 Aug 2006 13:01:54 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.13.6/8.13.6/Submit) id k74K1stG031980; Fri, 4 Aug 2006 13:01:54 -0700 (PDT) (envelope-from marcel) Date: Fri, 4 Aug 2006 13:01:54 -0700 From: Marcel Moolenaar To: John Baldwin Message-ID: <20060804200154.GC31805@ns1.xcllnt.net> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> <200608041314.24161.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608041314.24161.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: Yar Tikhiy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Sam Leffler Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:02:16 -0000 On Fri, Aug 04, 2006 at 01:14:22PM -0400, John Baldwin wrote: > > > > So, putting the kdb_backtrace() under KDB is not a matter of said > > function not being present without KDB, it's that we don't want > > to emit backtraces when debugging is not enabled. Backtraces are > > a debugging tool and it makes sense to emit them only when the > > kernel is configured for debugging. > > In practice this ends up being redundant though as to have kdb_backtrace() > actually do anything you have to have DDB in your kernel config, which > requires KDB. That's really an implementation detail. What if we get a new debugger backend that allows backtraces? What if the GDB backend is extended to allow backtraces? The point is that kdb_backtrace() is there if you want a backtrace and you call it based on whatever option that makes sense at the call-site or even unconditionally if that's the right thing. Whether there's actually a backend that can make a backtrace is really a seperate issue. We just happen to implement backtracing and unwinding by debuggers, but with an unwinder in the kernel on ia64, we really don't need a debugger in order to make a backtrace and it's not that unrealistic that I create a backend that can only do backtraces... > Places that call kdb_enter() aren't all #ifdef KDB IIRC. It's > just a feature that kdb_foo() functions become NOPs when the kernel isn't > configured for debugging, so I think the #ifdef KDB's would be redundant. None of the kdb_*() functions in src/sys/kern/subr_kdb.c turn into NOPs when option KDB is not present. They are all unconditionally functional by design and should therefore be called conditionally by consequence. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:13:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F36016A4DD; Fri, 4 Aug 2006 20:13:28 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D65CE43D6E; Fri, 4 Aug 2006 20:13:27 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74KDRMV037962; Fri, 4 Aug 2006 20:13:27 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74KDRDs037961; Fri, 4 Aug 2006 20:13:27 GMT (envelope-from mjacob) Message-Id: <200608042013.k74KDRDs037961@repoman.freebsd.org> From: Matt Jacob Date: Fri, 4 Aug 2006 20:13:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:13:28 -0000 mjacob 2006-08-04 20:13:27 UTC FreeBSD src repository Modified files: sys/dev/isp isp_freebsd.c Log: Rename ioctl driven task management functions so they don't collide with task management definitions on other platforms. Revision Changes Path 1.121 +5 -5 src/sys/dev/isp/isp_freebsd.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:14:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7333516A4DE; Fri, 4 Aug 2006 20:14:04 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30D3743D49; Fri, 4 Aug 2006 20:14:04 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74KE4g6038027; Fri, 4 Aug 2006 20:14:04 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74KE4Nc038026; Fri, 4 Aug 2006 20:14:04 GMT (envelope-from mjacob) Message-Id: <200608042014.k74KE4Nc038026@repoman.freebsd.org> From: Matt Jacob Date: Fri, 4 Aug 2006 20:14:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_ioctl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:14:04 -0000 mjacob 2006-08-04 20:14:03 UTC FreeBSD src repository Modified files: sys/dev/isp isp_ioctl.h Log: Rename ioctl driven task management functions so they don't collide with task management definitions on other platforms. Revision Changes Path 1.17 +5 -1 src/sys/dev/isp/isp_ioctl.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:14:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19AA916A4DE; Fri, 4 Aug 2006 20:14:53 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAB1543D4C; Fri, 4 Aug 2006 20:14:52 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74KEqcL038070; Fri, 4 Aug 2006 20:14:52 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74KEqAL038069; Fri, 4 Aug 2006 20:14:52 GMT (envelope-from mjacob) Message-Id: <200608042014.k74KEqAL038069@repoman.freebsd.org> From: Matt Jacob Date: Fri, 4 Aug 2006 20:14:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:14:53 -0000 mjacob 2006-08-04 20:14:52 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c Log: Initialize 2300 request/response pointers in isp_reset- not in isp_fibre_init. Revision Changes Path 1.124 +4 -7 src/sys/dev/isp/isp.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:20:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C371E16A4DE; Fri, 4 Aug 2006 20:20:00 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F2A943D49; Fri, 4 Aug 2006 20:20:00 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74KK0pG038361; Fri, 4 Aug 2006 20:20:00 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74KK0pi038360; Fri, 4 Aug 2006 20:20:00 GMT (envelope-from mjacob) Message-Id: <200608042020.k74KK0pi038360@repoman.freebsd.org> From: Matt Jacob Date: Fri, 4 Aug 2006 20:20:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_library.c isp_target.c isp_target.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:20:00 -0000 mjacob 2006-08-04 20:20:00 UTC FreeBSD src repository Modified files: sys/dev/isp isp_library.c isp_target.c isp_target.h Log: Fix na_fcentry_t to not have a lun field. Fix indentation in handly the notify structs. Fix messages in isp_got_msg_fc to print out the loop id of the sender- not the wwpn which will be synthesized later, if possible, in the outer layers. Put in debug printouts to pair a notify ack to a notify so one can see the start/close of an immediate notify event. Put in spsace for TASK MANAGEMENT response flags (which we don't do yet). Revision Changes Path 1.5 +6 -6 src/sys/dev/isp/isp_library.c 1.39 +43 -26 src/sys/dev/isp/isp_target.c 1.27 +8 -5 src/sys/dev/isp/isp_target.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 20:20:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF2BB16A4DF; Fri, 4 Aug 2006 20:20:55 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B15B43D46; Fri, 4 Aug 2006 20:20:55 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74KKtq2038485; Fri, 4 Aug 2006 20:20:55 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74KKtiV038483; Fri, 4 Aug 2006 20:20:55 GMT (envelope-from mjacob) Message-Id: <200608042020.k74KKtiV038483@repoman.freebsd.org> From: Matt Jacob Date: Fri, 4 Aug 2006 20:20:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_tpublic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 20:20:55 -0000 mjacob 2006-08-04 20:20:55 UTC FreeBSD src repository Modified files: sys/dev/isp isp_tpublic.h Log: Increase local reserved (high && low) storage in each command structure from 2 to 3 words. Revision Changes Path 1.15 +1 -1 src/sys/dev/isp/isp_tpublic.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:15:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7C2B16A4DA; Fri, 4 Aug 2006 21:15:10 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 373CE43DA4; Fri, 4 Aug 2006 21:15:09 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74LF95E051107; Fri, 4 Aug 2006 21:15:09 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74LF9Wj051106; Fri, 4 Aug 2006 21:15:09 GMT (envelope-from brooks) Message-Id: <200608042115.k74LF9Wj051106@repoman.freebsd.org> From: Brooks Davis Date: Fri, 4 Aug 2006 21:15:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/svr4 svr4_sockio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:15:10 -0000 brooks 2006-08-04 21:15:09 UTC FreeBSD src repository Modified files: sys/compat/svr4 svr4_sockio.c Log: Use TAILQ_EMPTY instead of checking if TAILQ_FIRST is NULL. Revision Changes Path 1.18 +1 -1 src/sys/compat/svr4/svr4_sockio.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:27:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6E8116A4EE; Fri, 4 Aug 2006 21:27:40 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DBE043D49; Fri, 4 Aug 2006 21:27:40 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74LRe6l051984; Fri, 4 Aug 2006 21:27:40 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74LReAR051983; Fri, 4 Aug 2006 21:27:40 GMT (envelope-from brooks) Message-Id: <200608042127.k74LReAR051983@repoman.freebsd.org> From: Brooks Davis Date: Fri, 4 Aug 2006 21:27:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_faith.c if_gif.c if_gre.c if_stf.c if_var.h net_osdep.h src/sys/netinet in_gif.c ip_encap.c src/sys/netinet6 ah_aesxcbcmac.c ah_core.c ah_input.c ah_output.c esp_aesctr.c esp_core.c esp_input.c esp_output.c esp_rijndael.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:27:41 -0000 brooks 2006-08-04 21:27:40 UTC FreeBSD src repository Modified files: sys/net if_faith.c if_gif.c if_gre.c if_stf.c if_var.h sys/netinet in_gif.c ip_encap.c sys/netinet6 ah_aesxcbcmac.c ah_core.c ah_input.c ah_output.c esp_aesctr.c esp_core.c esp_input.c esp_output.c esp_rijndael.c frag6.c icmp6.c in6.c in6_cksum.c in6_gif.c in6_ifattach.c in6_proto.c in6_src.c ip6_forward.c ip6_input.c ip6_mroute.c ip6_output.c ipcomp_core.c ipcomp_input.c ipcomp_output.c ipsec.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c udp6_output.c sys/netkey key.c keydb.c Removed files: sys/net net_osdep.h Log: With exception of the if_name() macro, all definitions in net_osdep.h were unused or already in if_var.h so add if_name() to if_var.h and remove net_osdep.h along with all references to it. Longer term we may want to kill off if_name() entierly since all modern BSDs have if_xname variables rendering it unnecessicary. Revision Changes Path 1.42 +0 -2 src/sys/net/if_faith.c 1.65 +0 -2 src/sys/net/if_gif.c 1.44 +0 -1 src/sys/net/if_gre.c 1.58 +0 -2 src/sys/net/if_stf.c 1.108 +1 -0 src/sys/net/if_var.h 1.17 +0 -337 src/sys/net/net_osdep.h (dead) 1.35 +0 -2 src/sys/netinet/in_gif.c 1.22 +0 -2 src/sys/netinet/ip_encap.c 1.4 +0 -2 src/sys/netinet6/ah_aesxcbcmac.c 1.27 +0 -2 src/sys/netinet6/ah_core.c 1.21 +0 -2 src/sys/netinet6/ah_input.c 1.16 +0 -2 src/sys/netinet6/ah_output.c 1.4 +0 -2 src/sys/netinet6/esp_aesctr.c 1.24 +0 -2 src/sys/netinet6/esp_core.c 1.27 +0 -2 src/sys/netinet6/esp_input.c 1.14 +0 -2 src/sys/netinet6/esp_output.c 1.6 +0 -2 src/sys/netinet6/esp_rijndael.c 1.29 +0 -2 src/sys/netinet6/frag6.c 1.71 +0 -2 src/sys/netinet6/icmp6.c 1.63 +0 -2 src/sys/netinet6/in6.c 1.14 +0 -2 src/sys/netinet6/in6_cksum.c 1.26 +0 -2 src/sys/netinet6/in6_gif.c 1.33 +0 -2 src/sys/netinet6/in6_ifattach.c 1.38 +0 -2 src/sys/netinet6/in6_proto.c 1.39 +0 -2 src/sys/netinet6/in6_src.c 1.34 +0 -2 src/sys/netinet6/ip6_forward.c 1.88 +0 -2 src/sys/netinet6/ip6_input.c 1.38 +0 -2 src/sys/netinet6/ip6_mroute.c 1.104 +0 -2 src/sys/netinet6/ip6_output.c 1.10 +0 -2 src/sys/netinet6/ipcomp_core.c 1.10 +0 -2 src/sys/netinet6/ipcomp_input.c 1.9 +0 -2 src/sys/netinet6/ipcomp_output.c 1.46 +0 -1 src/sys/netinet6/ipsec.c 1.27 +0 -2 src/sys/netinet6/mld6.c 1.66 +0 -2 src/sys/netinet6/nd6.c 1.41 +0 -2 src/sys/netinet6/nd6_nbr.c 1.33 +0 -2 src/sys/netinet6/nd6_rtr.c 1.25 +0 -2 src/sys/netinet6/udp6_output.c 1.75 +0 -2 src/sys/netkey/key.c 1.8 +0 -2 src/sys/netkey/keydb.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:28:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F34E416A4DF; Fri, 4 Aug 2006 21:28:43 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B6DF43D46; Fri, 4 Aug 2006 21:28:43 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74LShZC052072; Fri, 4 Aug 2006 21:28:43 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74LShD7052071; Fri, 4 Aug 2006 21:28:43 GMT (envelope-from marcel) Message-Id: <200608042128.k74LShD7052071@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 4 Aug 2006 21:28:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:28:44 -0000 marcel 2006-08-04 21:28:43 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, so dest[MAXPATHLEN] falls outside the buffer. This bug corrupted arenas[0] defined in libc's malloc.c on PowerPC when kldxref is shared, which triggered a delayed SIGSERV. Revision Changes Path 1.13 +1 -1 src/usr.sbin/kldxref/kldxref.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:29:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AC8216A503; Fri, 4 Aug 2006 21:29:23 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F46943D46; Fri, 4 Aug 2006 21:29:23 +0000 (GMT) (envelope-from brooks@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74LTNSH052134; Fri, 4 Aug 2006 21:29:23 GMT (envelope-from brooks@repoman.freebsd.org) Received: (from brooks@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74LTNXV052133; Fri, 4 Aug 2006 21:29:23 GMT (envelope-from brooks) Message-Id: <200608042129.k74LTNXV052133@repoman.freebsd.org> From: Brooks Davis Date: Fri, 4 Aug 2006 21:29:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:29:23 -0000 brooks 2006-08-04 21:29:23 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: The KAME compatability shims in net_osdep.h have been removed. Revision Changes Path 1.42 +2 -0 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:29:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 237D016A4F6; Fri, 4 Aug 2006 21:29:40 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF54F43D45; Fri, 4 Aug 2006 21:29:39 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74LTd75052190; Fri, 4 Aug 2006 21:29:39 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74LTdEX052189; Fri, 4 Aug 2006 21:29:39 GMT (envelope-from marcel) Message-Id: <200608042129.k74LTdEX052189@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 4 Aug 2006 21:29:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:29:40 -0000 marcel 2006-08-04 21:29:39 UTC FreeBSD src repository Modified files: usr.sbin/kldxref Makefile Log: Build shared on PowerPC now that the bug has been found and fixed. Revision Changes Path 1.10 +0 -4 src/usr.sbin/kldxref/Makefile From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:35:28 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82D5E16A4DE; Fri, 4 Aug 2006 21:35:28 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail32.syd.optusnet.com.au (mail32.syd.optusnet.com.au [211.29.132.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EF4743D76; Fri, 4 Aug 2006 21:35:22 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail32.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k74LZEmS017994 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sat, 5 Aug 2006 07:35:15 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k74LZEDC050146; Sat, 5 Aug 2006 07:35:14 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k74LZEHF050145; Sat, 5 Aug 2006 07:35:14 +1000 (EST) (envelope-from peter) Date: Sat, 5 Aug 2006 07:35:14 +1000 From: Peter Jeremy To: Marcel Moolenaar Message-ID: <20060804213514.GA760@turion.vk2pj.dyndns.org> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> <200608031458.01134.jhb@freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:35:28 -0000 --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 2006-Aug-04 09:23:52 -0700, Marcel Moolenaar wrote: >So, putting the kdb_backtrace() under KDB is not a matter of said >function not being present without KDB, it's that we don't want >to emit backtraces when debugging is not enabled. Backtraces are >a debugging tool and it makes sense to emit them only when the >kernel is configured for debugging. I'm not sure this follows. Consider the average end-user who has hir system spit out a "something has gone screwy" error. They post the message into one of the FreeBSD lists and are then told that they need to rebuild their kernel with KDB and DDB, reproduce the error, maybe issue a few magic incantations and post the result. Making backtraces either unconditional or run-time conditional (ie a sysctl to enable/disable them) should remove one interation through the mailing lists and improve the quality of support as seen by users. One of the drivers for DTrace was the view that you can't separate debugging and production because the difficult problems only occur in a production environment. Therefore you need to have a production system that has all your debugging tools available but with no debugging overheads until a problem occurs. IMHO, having kdb_backtrace() invoked unconditionally is a step towards this (as is having debug versions of -RELEASE kernels available). --=20 Peter Jeremy --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE072R/opHv/APuIcRAqo1AJ0eTgQfVcWQId262HVpa73omKQTNgCeIqkd KYHvM7I7YcoEaKrfrG6zEuw= =KUna -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI-- From owner-cvs-src@FreeBSD.ORG Fri Aug 4 21:45:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A328616A4DF; Fri, 4 Aug 2006 21:45:09 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E8B643D45; Fri, 4 Aug 2006 21:45:09 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74Lj9T7053609; Fri, 4 Aug 2006 21:45:09 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74Lj9jr053604; Fri, 4 Aug 2006 21:45:09 GMT (envelope-from jb) Message-Id: <200608042145.k74Lj9jr053604@repoman.freebsd.org> From: John Birrell Date: Fri, 4 Aug 2006 21:45:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/fsx fsx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 21:45:09 -0000 jb 2006-08-04 21:45:08 UTC FreeBSD src repository Modified files: tools/regression/fsx fsx.c Log: Fix for architectures where sizeof(void *) > sizeof(int). Revision Changes Path 1.4 +2 -2 src/tools/regression/fsx/fsx.c From owner-cvs-src@FreeBSD.ORG Fri Aug 4 22:54:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 481CF16A4DD; Fri, 4 Aug 2006 22:54:11 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7B3543D46; Fri, 4 Aug 2006 22:54:10 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74MsA5f066374; Fri, 4 Aug 2006 22:54:10 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74MsAw5066373; Fri, 4 Aug 2006 22:54:10 GMT (envelope-from jb) Message-Id: <200608042254.k74MsAw5066373@repoman.freebsd.org> From: John Birrell Date: Fri, 4 Aug 2006 22:54:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys types.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 22:54:11 -0000 jb 2006-08-04 22:54:10 UTC FreeBSD src repository Modified files: sys/sys types.h Log: Add some compatibility definitions for OpenSolaris source. These are only defined if _SOLARIS_C_SOURCE is defined, so they don't polute the FreeBSD compile environment. They are used all over the OpenSolaris source, so defining them here removes the need to continually resolve differences in FreeBSD system haeder files from Solaris header files. Revision Changes Path 1.96 +30 -0 src/sys/sys/types.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:10:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 114C016A4DF; Fri, 4 Aug 2006 23:10:17 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0C2143D60; Fri, 4 Aug 2006 23:10:11 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74NABEK068394; Fri, 4 Aug 2006 23:10:11 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74NABOv068393; Fri, 4 Aug 2006 23:10:11 GMT (envelope-from jb) Message-Id: <200608042310.k74NABOv068393@repoman.freebsd.org> From: John Birrell Date: Fri, 4 Aug 2006 23:10:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys time.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:10:18 -0000 jb 2006-08-04 23:10:11 UTC FreeBSD src repository Modified files: sys/sys time.h Log: Add some OpenSolaris compatibility definitions which are only visible if _SOLARIS_C_SOURCE is defined. Add two function prototypes which are required to feed high-resolution times to DTrace. DTrace requires it's own functions with the dtrace_ prefix so that it knows not to try and trace them. This is a rule that code executed from the DTrace probe context must obey. The two functions are only be compiled if the KDTRACE option is defined to compile in kernel support for loading the DTrace modules. Revision Changes Path 1.72 +25 -0 src/sys/sys/time.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:15:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E6E316A4DD; Fri, 4 Aug 2006 23:15:30 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 936DC43D49; Fri, 4 Aug 2006 23:15:27 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.56] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.6/8.13.6) with ESMTP id k74NFOVI066363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 16:15:25 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <44D3D4ED.3000504@FreeBSD.org> Date: Fri, 04 Aug 2006 16:14:53 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Marcel Moolenaar References: <200608042128.k74LShD7052071@repoman.freebsd.org> In-Reply-To: <200608042128.k74LShD7052071@repoman.freebsd.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:15:30 -0000 Thanks! I saw this crash as well, but did not have a gdb working to inspect the core file at that time. -Maxim Marcel Moolenaar wrote: > marcel 2006-08-04 21:28:43 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/kldxref kldxref.c > Log: > Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, > so dest[MAXPATHLEN] falls outside the buffer. This bug corrupted > arenas[0] defined in libc's malloc.c on PowerPC when kldxref is shared, > which triggered a delayed SIGSERV. > > Revision Changes Path > 1.13 +1 -1 src/usr.sbin/kldxref/kldxref.c > > From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:22:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F13B316A4DF; Fri, 4 Aug 2006 23:22:00 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BA2443D46; Fri, 4 Aug 2006 23:22:00 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.5.252] (dhcp52.wlan.xcllnt.net [192.168.5.252]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k74NLxIm089303; Fri, 4 Aug 2006 16:22:00 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <44D3D4ED.3000504@FreeBSD.org> References: <200608042128.k74LShD7052071@repoman.freebsd.org> <44D3D4ED.3000504@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 4 Aug 2006 16:21:47 -0700 To: Maxim Sobolev X-Mailer: Apple Mail (2.752.2) Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:22:01 -0000 On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: > Thanks! I saw this crash as well, but did not have a gdb working to > inspect the core file at that time. I have a native gdb 6.5 that allowed me to work on a live process. Thanks in a big part to you, I might add :-) -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:28:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D4F316A4DA; Fri, 4 Aug 2006 23:28:31 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C3F343D45; Fri, 4 Aug 2006 23:28:30 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.56] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.6/8.13.6) with ESMTP id k74NSRtp066503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 16:28:28 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <44D3D7FC.5070507@FreeBSD.org> Date: Fri, 04 Aug 2006 16:27:56 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Marcel Moolenaar References: <200608042128.k74LShD7052071@repoman.freebsd.org> <44D3D4ED.3000504@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:28:31 -0000 Marcel Moolenaar wrote: > > On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: > >> Thanks! I saw this crash as well, but did not have a gdb working to >> inspect the core file at that time. > > I have a native gdb 6.5 that allowed me to work on a live process. > Thanks in a big part to you, I might add :-) Most of the credit should go to Andreas Tobler actually. :-) BTW, do you plan to commit your GDB changes into the tree? Since with current patches for gdb6 port it still doesn't work on live processes, and I don't have a time to track it down. -Maxim From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:31:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0F1216A4DE; Fri, 4 Aug 2006 23:31:16 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CB4B43D46; Fri, 4 Aug 2006 23:31:16 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74NVG4E069760; Fri, 4 Aug 2006 23:31:16 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74NVGTU069759; Fri, 4 Aug 2006 23:31:16 GMT (envelope-from jb) Message-Id: <200608042331.k74NVGTU069759@repoman.freebsd.org> From: John Birrell Date: Fri, 4 Aug 2006 23:31:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:31:16 -0000 jb 2006-08-04 23:31:16 UTC FreeBSD src repository Modified files: sys/sys systm.h Log: Add a type definition for the cyclic timer callback function. The cyclic timer is a high-resolution timer allows timeouts at nanosecond intervals where hardware support is available. Typically on i386 there is no HPET (high performance event timer) like the one Intel started specifying some time in 2004, so the best that tye cyclic timer subsystem can do is run at Hz. The cyclic timer code itself is ported from OpenSolaris and is covered by the CDDL, so it is only loaded as a module. This function type definition is used in machine-dependent code to provide a hook for the module to register it's callback function. Revision Changes Path 1.242 +6 -0 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Fri Aug 4 23:47:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52CBF16A4DD; Fri, 4 Aug 2006 23:47:31 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A70A43D45; Fri, 4 Aug 2006 23:47:31 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74NlVva073308; Fri, 4 Aug 2006 23:47:31 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74NlU5k073307; Fri, 4 Aug 2006 23:47:30 GMT (envelope-from jb) Message-Id: <200608042347.k74NlU5k073307@repoman.freebsd.org> From: John Birrell Date: Fri, 4 Aug 2006 23:47:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys stat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:47:31 -0000 jb 2006-08-04 23:47:30 UTC FreeBSD src repository Modified files: sys/sys stat.h Log: Add OpenSolaris compatibility definitions for stat64 and fstat64 which are only visible if _SOLARIS_C_SOURCE is defined. Note thar FreeBSD stat() and fstat() are 64-bit functions now and Solaris still persists with both 32- and 64-bit versions. When I query this, I am referred to: . But when you look at the main page of unix.org you will see that the Single Unix Specification is the most recent standard they are pushing. And there are no stat64() fstat64() functions defined there. I guess this just goes to prove that there are so many standards, you can take your pick. Revision Changes Path 1.42 +8 -0 src/sys/sys/stat.h From owner-cvs-src@FreeBSD.ORG Sat Aug 5 00:13:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FB5016A4DD; Sat, 5 Aug 2006 00:13:10 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id C882143D46; Sat, 5 Aug 2006 00:13:09 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.5.252] (dhcp52.wlan.xcllnt.net [192.168.5.252]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k750D9SP042013; Fri, 4 Aug 2006 17:13:09 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <44D3D7FC.5070507@FreeBSD.org> References: <200608042128.k74LShD7052071@repoman.freebsd.org> <44D3D4ED.3000504@FreeBSD.org> <44D3D7FC.5070507@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <233F3705-47A4-4F01-9A34-9FE33DE1E702@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Fri, 4 Aug 2006 17:12:56 -0700 To: Maxim Sobolev X-Mailer: Apple Mail (2.752.2) Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 00:13:10 -0000 On Aug 4, 2006, at 4:27 PM, Maxim Sobolev wrote: > Marcel Moolenaar wrote: >> On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: >>> Thanks! I saw this crash as well, but did not have a gdb working >>> to inspect the core file at that time. >> I have a native gdb 6.5 that allowed me to work on a live process. >> Thanks in a big part to you, I might add :-) > > Most of the credit should go to Andreas Tobler actually. :-) > > BTW, do you plan to commit your GDB changes into the tree? Since > with current patches for gdb6 port it still doesn't work on live > processes, and I don't have a time to track it down. Yes, I'm preparing a new GDB import. This unfortunately involves a lot of additional work, so it may take a bit longer than a normal import would need. The point is that the additional work has to be done once, after which new imports should be pretty easy... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Sat Aug 5 04:21:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 535A116A4DD; Sat, 5 Aug 2006 04:21:21 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B74843D49; Sat, 5 Aug 2006 04:21:21 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k754LKvN000985; Sat, 5 Aug 2006 04:21:20 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k754LKRR000984; Sat, 5 Aug 2006 04:21:20 GMT (envelope-from mjacob) Message-Id: <200608050421.k754LKRR000984@repoman.freebsd.org> From: Matt Jacob Date: Sat, 5 Aug 2006 04:21:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 04:21:21 -0000 mjacob 2006-08-05 04:21:20 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c Log: Remove reference to PTI cards. They haven't been functioning or around for probably at least 5 years. Revision Changes Path 1.125 +0 -15 src/sys/dev/isp/isp.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 04:58:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EB0E16A4DF; Sat, 5 Aug 2006 04:58:26 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33DB543D45; Sat, 5 Aug 2006 04:58:26 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k754wQx2010553; Sat, 5 Aug 2006 04:58:26 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k754wQW2010552; Sat, 5 Aug 2006 04:58:26 GMT (envelope-from sam) Message-Id: <200608050458.k754wQW2010552@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 04:58:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/wi if_wavelan_ieee.h if_wi.c if_wireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 04:58:26 -0000 sam 2006-08-05 04:58:25 UTC FreeBSD src repository Modified files: sys/dev/wi if_wavelan_ieee.h if_wi.c if_wireg.h Log: raw 802.11 packet transmit support Submitted by: Andrea Bittau Revision Changes Path 1.20 +2 -1 src/sys/dev/wi/if_wavelan_ieee.h 1.199 +144 -29 src/sys/dev/wi/if_wi.c 1.45 +1 -0 src/sys/dev/wi/if_wireg.h From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:07:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D96C216A4DA; Sat, 5 Aug 2006 05:07:17 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9013E43D46; Sat, 5 Aug 2006 05:07:17 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7557Hne012312; Sat, 5 Aug 2006 05:07:17 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7557HkF012311; Sat, 5 Aug 2006 05:07:17 GMT (envelope-from sam) Message-Id: <200608050507.k7557HkF012311@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:07:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ath if_ath.c if_athioctl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:07:18 -0000 sam 2006-08-05 05:07:17 UTC FreeBSD src repository Modified files: sys/dev/ath if_ath.c if_athioctl.h Log: raw 802.11 packet transmit support Joint work with: Andrea Bittau Revision Changes Path 1.151 +355 -100 src/sys/dev/ath/if_ath.c 1.16 +2 -1 src/sys/dev/ath/if_athioctl.h From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:09:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFCB616A4E0; Sat, 5 Aug 2006 05:09:23 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 512FA43D4C; Sat, 5 Aug 2006 05:09:21 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7559LpM012428; Sat, 5 Aug 2006 05:09:21 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7559LhJ012427; Sat, 5 Aug 2006 05:09:21 GMT (envelope-from sam) Message-Id: <200608050509.k7559LhJ012427@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:09:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/ath/athstats athstats.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:09:24 -0000 sam 2006-08-05 05:09:21 UTC FreeBSD src repository Modified files: tools/tools/ath/athstats athstats.c Log: raw tx stat Revision Changes Path 1.4 +1 -0 src/tools/tools/ath/athstats/athstats.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:12:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 409BF16A4DD; Sat, 5 Aug 2006 05:12:04 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E875243D45; Sat, 5 Aug 2006 05:12:03 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k755C3o2012755; Sat, 5 Aug 2006 05:12:03 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k755C3cN012754; Sat, 5 Aug 2006 05:12:03 GMT (envelope-from sam) Message-Id: <200608050512.k755C3cN012754@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:12:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/net80211/stumbler Makefile stumbler.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:12:04 -0000 sam 2006-08-05 05:12:03 UTC FreeBSD src repository Added files: tools/tools/net80211/stumbler Makefile stumbler.c Log: crude stumbler using raw packet api's Submitted by: Andrea Bittau Revision Changes Path 1.1 +10 -0 src/tools/tools/net80211/stumbler/Makefile (new) 1.1 +1067 -0 src/tools/tools/net80211/stumbler/stumbler.c (new) From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:13:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FE6516A4DA; Sat, 5 Aug 2006 05:13:32 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B804143D46; Sat, 5 Aug 2006 05:13:31 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k755DVWw012836; Sat, 5 Aug 2006 05:13:31 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k755DVEK012835; Sat, 5 Aug 2006 05:13:31 GMT (envelope-from sam) Message-Id: <200608050513.k755DVEK012835@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:13:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/net80211/wlaninject Makefile README wlaninject.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:13:32 -0000 sam 2006-08-05 05:13:31 UTC FreeBSD src repository Added files: tools/tools/net80211/wlaninject Makefile README wlaninject.c Log: 802.11 packet injection test tool Submitted by: Andrea Bittau Revision Changes Path 1.1 +8 -0 src/tools/tools/net80211/wlaninject/Makefile (new) 1.1 +82 -0 src/tools/tools/net80211/wlaninject/README (new) 1.1 +789 -0 src/tools/tools/net80211/wlaninject/wlaninject.c (new) From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:18:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EC3916A4DA; Sat, 5 Aug 2006 05:18:04 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B35ED43D49; Sat, 5 Aug 2006 05:18:03 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k755I3OS013237; Sat, 5 Aug 2006 05:18:03 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k755I363013236; Sat, 5 Aug 2006 05:18:03 GMT (envelope-from sam) Message-Id: <200608050518.k755I363013236@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:18:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/net80211/w00t Makefile Makefile.inc README src/tools/tools/net80211/w00t/ap Makefile ap.c src/tools/tools/net80211/w00t/assoc Makefile assoc.c src/tools/tools/net80211/w00t/expand Makefile expand.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:18:04 -0000 sam 2006-08-05 05:18:03 UTC FreeBSD src repository Added files: tools/tools/net80211/w00t Makefile Makefile.inc README tools/tools/net80211/w00t/ap Makefile ap.c tools/tools/net80211/w00t/assoc Makefile assoc.c tools/tools/net80211/w00t/expand Makefile expand.c tools/tools/net80211/w00t/libw00t Makefile w00t.c w00t.h tools/tools/net80211/w00t/prga Makefile prga.c tools/tools/net80211/w00t/redir Makefile buddy.c redir.c Log: test programs for 802.11 packet injection Submitted by: Andrea Bittau Revision Changes Path 1.1 +5 -0 src/tools/tools/net80211/w00t/Makefile (new) 1.1 +11 -0 src/tools/tools/net80211/w00t/Makefile.inc (new) 1.1 +78 -0 src/tools/tools/net80211/w00t/README (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/ap/Makefile (new) 1.1 +916 -0 src/tools/tools/net80211/w00t/ap/ap.c (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/assoc/Makefile (new) 1.1 +938 -0 src/tools/tools/net80211/w00t/assoc/assoc.c (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/expand/Makefile (new) 1.1 +468 -0 src/tools/tools/net80211/w00t/expand/expand.c (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/libw00t/Makefile (new) 1.1 +414 -0 src/tools/tools/net80211/w00t/libw00t/w00t.c (new) 1.1 +57 -0 src/tools/tools/net80211/w00t/libw00t/w00t.h (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/prga/Makefile (new) 1.1 +664 -0 src/tools/tools/net80211/w00t/prga/prga.c (new) 1.1 +7 -0 src/tools/tools/net80211/w00t/redir/Makefile (new) 1.1 +158 -0 src/tools/tools/net80211/w00t/redir/buddy.c (new) 1.1 +709 -0 src/tools/tools/net80211/w00t/redir/redir.c (new) From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:20:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12B7616A4DD; Sat, 5 Aug 2006 05:20:41 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 945DD43D5A; Sat, 5 Aug 2006 05:20:40 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k755Keie013428; Sat, 5 Aug 2006 05:20:40 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k755KeTS013427; Sat, 5 Aug 2006 05:20:40 GMT (envelope-from sam) Message-Id: <200608050520.k755KeTS013427@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 05:20:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/net80211 Makefile README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:20:41 -0000 sam 2006-08-05 05:20:40 UTC FreeBSD src repository Modified files: tools/tools/net80211 Makefile Added files: tools/tools/net80211 README Log: hook packet injection tools up Revision Changes Path 1.2 +1 -1 src/tools/tools/net80211/Makefile 1.1 +14 -0 src/tools/tools/net80211/README (new) From owner-cvs-src@FreeBSD.ORG Sat Aug 5 05:49:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8CF516A4E1; Sat, 5 Aug 2006 05:49:32 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DD4343D70; Sat, 5 Aug 2006 05:49:30 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k755nUEe020293; Sat, 5 Aug 2006 05:49:30 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k755nUvw020292; Sat, 5 Aug 2006 05:49:30 GMT (envelope-from njl) Message-Id: <200608050549.k755nUvw020292@repoman.freebsd.org> From: Nate Lawson Date: Sat, 5 Aug 2006 05:49:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 acpi.4 src/sbin/sysctl sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 05:49:33 -0000 njl 2006-08-05 05:49:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 acpi.4 sbin/sysctl sysctl.c Log: MFC: acpi man page formatting updates, sysctl temperature printing fixes. Revision Changes Path 1.67.2.3 +8 -10 src/sbin/sysctl/sysctl.c 1.52.2.4 +47 -17 src/share/man/man4/acpi.4 From owner-cvs-src@FreeBSD.ORG Sat Aug 5 11:41:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8816616A4DD; Sat, 5 Aug 2006 11:41:47 +0000 (UTC) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E9A643D46; Sat, 5 Aug 2006 11:41:47 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75BfksW053005; Sat, 5 Aug 2006 11:41:46 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75BfkYV053004; Sat, 5 Aug 2006 11:41:46 GMT (envelope-from sos) Message-Id: <200608051141.k75BfkYV053004@repoman.freebsd.org> From: Søren Schmidt Date: Sat, 5 Aug 2006 11:41:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 11:41:47 -0000 sos 2006-08-05 11:41:46 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c ata-pci.h Log: Unbreak nForce3 SATA support. Revision Changes Path 1.167 +19 -19 src/sys/dev/ata/ata-chipset.c 1.67 +1 -2 src/sys/dev/ata/ata-pci.h From owner-cvs-src@FreeBSD.ORG Sat Aug 5 12:50:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE84A16A4DE; Sat, 5 Aug 2006 12:50:38 +0000 (UTC) (envelope-from rse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5E8143D45; Sat, 5 Aug 2006 12:50:38 +0000 (GMT) (envelope-from rse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75Coc8M065479; Sat, 5 Aug 2006 12:50:38 GMT (envelope-from rse@repoman.freebsd.org) Received: (from rse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75Coc3o065477; Sat, 5 Aug 2006 12:50:38 GMT (envelope-from rse) Message-Id: <200608051250.k75Coc3o065477@repoman.freebsd.org> From: "Ralf S. Engelschall" Date: Sat, 5 Aug 2006 12:50:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/dump optr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 12:50:39 -0000 rse 2006-08-05 12:50:38 UTC FreeBSD src repository Modified files: sbin/dump optr.c Log: Do not pass-through the tailing newline character from the ctime(3) output to setproctitle(3) in order to get rid of the ugly two-character escape sequence "\n" in the ps(1) output of a dump(8) process: << [...] finished in 0:00 at Sat Aug 5 14:44:39 2006\n (dump) >> [...] finished in 0:00 at Sat Aug 5 14:44:39 2006 (dump) Revision Changes Path 1.33 +5 -3 src/sbin/dump/optr.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 13:45:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6E1616A4DF for ; Sat, 5 Aug 2006 13:45:35 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from antivirus.uni-rostock.de (mailrelay1.uni-rostock.de [139.30.8.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 665A243D45 for ; Sat, 5 Aug 2006 13:45:22 +0000 (GMT) (envelope-from joerg@britannica.bec.de) Received: from antivirus.exch.rz.uni-rostock.de ([127.0.0.1]) by antivirus.uni-rostock.de with Microsoft SMTPSVC(6.0.3790.1830); Sat, 5 Aug 2006 15:45:21 +0200 Received: from antivirus.uni-rostock.de (unverified) by antivirus.exch.rz.uni-rostock.de (Content Technologies SMTPRS 4.3.20) with ESMTP id for ; Sat, 5 Aug 2006 15:45:21 +0200 Received: from mail pickup service by antivirus.uni-rostock.de with Microsoft SMTPSVC; Sat, 5 Aug 2006 15:45:21 +0200 X-SCL: 4 67.7% Received: from mail.uni-rostock.de ([139.30.8.11]) by antivirus.uni-rostock.de with Microsoft SMTPSVC (6.0.3790.1830); Sat, 5 Aug 2006 15:45:13 +0200 Received: from conversion-daemon.mail2.uni-rostock.de by mail2.uni-rostock.de (iPlanet Messaging Server 5.2 HotFix 2.09 (built Nov 18 2005)) id <0J3J00I010UJ7A@mail.uni-rostock.de> (original mail from joerg@britannica.bec.de) for cvs-src@freebsd.org; Sat , 05 Aug 2006 15:45:12 +0200 (MEST) Received: from britannica.bec.de (storm.stura.uni-rostock.de [139.30.252.72]) by mail2.uni-rostock.de (iPlanet Messaging Server 5.2 HotFix 2.09 (built Nov 18 2005)) with ESMTP id <0J3J008HS27CZK@mail.uni-rostock.de> for cvs-src@freebsd.org; Sat, 05 Aug 2006 15:45:12 +0200 (MEST) Received: by britannica.bec.de (Postfix, from userid 1000) id D43015B12; Sat, 05 Aug 2006 15:44:47 +0200 (CEST) Date: Sat, 05 Aug 2006 15:44:47 +0200 From: Joerg Sonnenberger In-reply-to: <200608042347.k74NlU5k073307@repoman.freebsd.org> To: cvs-src@freebsd.org Message-id: <20060805134447.GC2020@britannica.bec.de> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7BIT Content-disposition: inline User-Agent: Mutt/1.5.12-2006-07-14 References: <200608042347.k74NlU5k073307@repoman.freebsd.org> X-OriginalArrivalTime: 05 Aug 2006 13:45:13.0265 (UTC) FILETIME=[6057EA10:01C6B895] Subject: Re: cvs commit: src/sys/sys stat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 13:45:35 -0000 On Fri, Aug 04, 2006 at 11:47:30PM +0000, John Birrell wrote: > Note thar FreeBSD stat() and fstat() are 64-bit functions now and Solaris > still persists with both 32- and 64-bit versions. The reason is that you need 32bit versions when you want to keep binary compatibility within e.g. libc. off_t can be 32bit and 64bit and moving to 64bit can be done by either: (1) Introduction of a new type and new functions, keeping the default as it was. This happened on Solaris and Linux. (2) Introduce a new libc major version (requiring a rebuild of everything) and make the 32bit compatibility system calls only. This is what happened on the BSDs and which removes a lot of hassles. Using stuff like stat64 is evil and NEVER be done. Joerg From owner-cvs-src@FreeBSD.ORG Sat Aug 5 13:58:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A53D116A4DD; Sat, 5 Aug 2006 13:58:51 +0000 (UTC) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26D9F43D69; Sat, 5 Aug 2006 13:58:51 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75DwpFa070714; Sat, 5 Aug 2006 13:58:51 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75DwpYr070713; Sat, 5 Aug 2006 13:58:51 GMT (envelope-from stefanf) Message-Id: <200608051358.k75DwpYr070713@repoman.freebsd.org> From: Stefan Farfeleder Date: Sat, 5 Aug 2006 13:58:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 13:58:51 -0000 stefanf 2006-08-05 13:58:50 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: Use the SLIST_NEXT macro instead of sle_next. Checked with: cmp(1) Revision Changes Path 1.92 +2 -2 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 14:14:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B05816A4DD; Sat, 5 Aug 2006 14:14:36 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45DC443D5A; Sat, 5 Aug 2006 14:14:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75EEZ6A072800; Sat, 5 Aug 2006 14:14:35 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75EEZcb072799; Sat, 5 Aug 2006 14:14:35 GMT (envelope-from rwatson) Message-Id: <200608051414.k75EEZcb072799@repoman.freebsd.org> From: Robert Watson Date: Sat, 5 Aug 2006 14:14:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netatalk ddp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 14:14:36 -0000 rwatson 2006-08-05 14:14:34 UTC FreeBSD src repository Modified files: sys/netatalk ddp_usrreq.c Log: Since soisdisconnected() is no longer called in pru_detach(), call it near consumers of at_pcbdisconnect() (_close, _abort). Revision Changes Path 1.52 +2 -0 src/sys/netatalk/ddp_usrreq.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 18:21:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7741F16A4DE; Sat, 5 Aug 2006 18:21:20 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E218943D8D; Sat, 5 Aug 2006 18:21:05 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75IL4KR029488; Sat, 5 Aug 2006 18:21:04 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75IL4Ql029487; Sat, 5 Aug 2006 18:21:04 GMT (envelope-from sam) Message-Id: <200608051821.k75IL4Ql029487@repoman.freebsd.org> From: Sam Leffler Date: Sat, 5 Aug 2006 18:21:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/net80211/wlaninject wlaninject.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 18:21:20 -0000 sam 2006-08-05 18:21:04 UTC FreeBSD src repository Modified files: tools/tools/net80211/wlaninject wlaninject.c Log: make it work after the api change Submitted by: Andrea Bittau Revision Changes Path 1.2 +43 -6 src/tools/tools/net80211/wlaninject/wlaninject.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 18:22:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 194C716A4E5; Sat, 5 Aug 2006 18:22:25 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3611B43DB0; Sat, 5 Aug 2006 18:22:13 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75IMB4x029588; Sat, 5 Aug 2006 18:22:11 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75IMBnB029587; Sat, 5 Aug 2006 18:22:11 GMT (envelope-from imp) Message-Id: <200608051822.k75IMBnB029587@repoman.freebsd.org> From: Warner Losh Date: Sat, 5 Aug 2006 18:22:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kldxref kldxref.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 18:22:25 -0000 imp 2006-08-05 18:22:11 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Use safe strlcpy rather than unsafe strncpy. After marcel's last fix, there was still one overflow possible. strlcpy is faster anyway because it doesn't unexpectedly zero the entire length of the string when copying short strings.... Revision Changes Path 1.14 +2 -4 src/usr.sbin/kldxref/kldxref.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 18:41:50 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0521216A4DE; Sat, 5 Aug 2006 18:41:50 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 243B643D5E; Sat, 5 Aug 2006 18:41:48 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k75IffFu030177; Sat, 5 Aug 2006 22:41:41 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k75IfdFh030176; Sat, 5 Aug 2006 22:41:39 +0400 (MSD) (envelope-from yar) Date: Sat, 5 Aug 2006 22:41:39 +0400 From: Yar Tikhiy To: Marcel Moolenaar Message-ID: <20060805184139.GD29277@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> <200608041314.24161.jhb@freebsd.org> <20060804200154.GC31805@ns1.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804200154.GC31805@ns1.xcllnt.net> User-Agent: Mutt/1.5.9i Cc: Sam Leffler , src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin , cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 18:41:50 -0000 On Fri, Aug 04, 2006 at 01:01:54PM -0700, Marcel Moolenaar wrote: > On Fri, Aug 04, 2006 at 01:14:22PM -0400, John Baldwin wrote: > > > > > > So, putting the kdb_backtrace() under KDB is not a matter of said > > > function not being present without KDB, it's that we don't want > > > to emit backtraces when debugging is not enabled. Backtraces are > > > a debugging tool and it makes sense to emit them only when the > > > kernel is configured for debugging. > > > > In practice this ends up being redundant though as to have kdb_backtrace() > > actually do anything you have to have DDB in your kernel config, which > > requires KDB. > > That's really an implementation detail. What if we get a new debugger > backend that allows backtraces? What if the GDB backend is extended to > allow backtraces? Anyway, they all will require KDB to register with. > The point is that kdb_backtrace() is there if you want a backtrace and > you call it based on whatever option that makes sense at the call-site > or even unconditionally if that's the right thing. > Whether there's actually a backend that can make a backtrace is really > a seperate issue. We just happen to implement backtracing and unwinding > by debuggers, but with an unwinder in the kernel on ia64, we really > don't need a debugger in order to make a backtrace and it's not that > unrealistic that I create a backend that can only do backtraces... Then it would be great to have that backend enabled by default. Backtraces are good not only to those who do actual debugging. Users could post them to the lists and so help developers. > > Places that call kdb_enter() aren't all #ifdef KDB IIRC. It's > > just a feature that kdb_foo() functions become NOPs when the kernel isn't > > configured for debugging, so I think the #ifdef KDB's would be redundant. > > None of the kdb_*() functions in src/sys/kern/subr_kdb.c turn into > NOPs when option KDB is not present. They are all unconditionally > functional by design and should therefore be called conditionally > by consequence. At least kdb_backtrace() will just return if there is no active backend. The KDB option seems to be used in two distinct cases. One of them is when a driver or subsystem can offer something to KDB. E.g., sio(4) can do line break condition. The other case is when a consumer call to KDB is made, e.g., that to kdb_backtrace(). Now KDB seems to be able to handle such calls even if they are made unconditionally. Of course, such calls will just return unless there is an active backend. Putting such calls under "#ifdef KDB" seems redundant now. As for the first case, such drivers could call something like kdb_is_on() to decide if special actions are to be taken. Using a build-time option to control a link between two kernel parts not depending on the option looks strange. E.g., the KDB code is always there, sio(4) is controlled by "device sio", but the ability of the latter to handle line break condition depends on "options KDB". Counter-intuitive, eh? -- Yar From owner-cvs-src@FreeBSD.ORG Sat Aug 5 19:07:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5313A16A4DF; Sat, 5 Aug 2006 19:07:08 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13FDB43D46; Sat, 5 Aug 2006 19:07:08 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75J77R0033395; Sat, 5 Aug 2006 19:07:07 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75J77er033394; Sat, 5 Aug 2006 19:07:07 GMT (envelope-from alc) Message-Id: <200608051907.k75J77er033394@repoman.freebsd.org> From: Alan Cox Date: Sat, 5 Aug 2006 19:07:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 19:07:08 -0000 alc 2006-08-05 19:07:07 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: Remove a stale comment. Revision Changes Path 1.281 +0 -5 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 19:25:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7285316A4DE; Sat, 5 Aug 2006 19:25:15 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0134C43D46; Sat, 5 Aug 2006 19:25:15 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75JPEFu034317; Sat, 5 Aug 2006 19:25:14 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75JPEob034316; Sat, 5 Aug 2006 19:25:14 GMT (envelope-from jb) Message-Id: <200608051925.k75JPEob034316@repoman.freebsd.org> From: John Birrell Date: Sat, 5 Aug 2006 19:25:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 19:25:15 -0000 jb 2006-08-05 19:25:14 UTC FreeBSD src repository Modified files: sys/kern Makefile Log: Add support for the generated file systrace_args.c. Revision Changes Path 1.13 +2 -1 src/sys/kern/Makefile From owner-cvs-src@FreeBSD.ORG Sat Aug 5 20:18:09 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AB5016A4DF; Sat, 5 Aug 2006 20:18:09 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1884943D5C; Sat, 5 Aug 2006 20:18:04 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.5.252] (dhcp52.wlan.xcllnt.net [192.168.5.252]) by ns1.xcllnt.net (8.13.6/8.13.6) with ESMTP id k75KHdhW002634; Sat, 5 Aug 2006 13:17:39 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <20060805184139.GD29277@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <20060804070348.GR97316@comp.chem.msu.su> <6B15CBE0-00E0-4F64-A652-4A4B614975C2@xcllnt.net> <200608041314.24161.jhb@freebsd.org> <20060804200154.GC31805@ns1.xcllnt.net> <20060805184139.GD29277@comp.chem.msu.su> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <76B6A9D8-5BF2-4F5D-A711-C87A87B60696@xcllnt.net> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Sat, 5 Aug 2006 13:17:26 -0700 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.2) Cc: Sam Leffler , src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin , cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 20:18:09 -0000 On Aug 5, 2006, at 11:41 AM, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 01:01:54PM -0700, Marcel Moolenaar wrote: >> On Fri, Aug 04, 2006 at 01:14:22PM -0400, John Baldwin wrote: >>>> >>>> So, putting the kdb_backtrace() under KDB is not a matter of said >>>> function not being present without KDB, it's that we don't want >>>> to emit backtraces when debugging is not enabled. Backtraces are >>>> a debugging tool and it makes sense to emit them only when the >>>> kernel is configured for debugging. >>> >>> In practice this ends up being redundant though as to have >>> kdb_backtrace() >>> actually do anything you have to have DDB in your kernel config, >>> which >>> requires KDB. >> >> That's really an implementation detail. What if we get a new debugger >> backend that allows backtraces? What if the GDB backend is >> extended to >> allow backtraces? > > Anyway, they all will require KDB to register with. KDB is not conditional upon the KDB option. KDB is unconditionally present. >> The point is that kdb_backtrace() is there if you want a backtrace >> and >> you call it based on whatever option that makes sense at the call- >> site >> or even unconditionally if that's the right thing. >> Whether there's actually a backend that can make a backtrace is >> really >> a seperate issue. We just happen to implement backtracing and >> unwinding >> by debuggers, but with an unwinder in the kernel on ia64, we really >> don't need a debugger in order to make a backtrace and it's not that >> unrealistic that I create a backend that can only do backtraces... > > Then it would be great to have that backend enabled by default. I can see how some people would want that. >>> Places that call kdb_enter() aren't all #ifdef KDB IIRC. It's >>> just a feature that kdb_foo() functions become NOPs when the >>> kernel isn't >>> configured for debugging, so I think the #ifdef KDB's would be >>> redundant. >> >> None of the kdb_*() functions in src/sys/kern/subr_kdb.c turn into >> NOPs when option KDB is not present. They are all unconditionally >> functional by design and should therefore be called conditionally >> by consequence. > > At least kdb_backtrace() will just return if there is no active > backend. Yes. > The KDB option seems to be used in two distinct cases. One of them > is when a driver or subsystem can offer something to KDB. E.g., > sio(4) can do line break condition. The other case is when a > consumer call to KDB is made, e.g., that to kdb_backtrace(). Now > KDB seems to be able to handle such calls even if they are made > unconditionally. Of course, such calls will just return unless > there is an active backend. Putting such calls under "#ifdef KDB" > seems redundant now. No, not really. There can be a performance impact or a correctness impact of calling into KDB. A line break condition does not result in a '\0' character in the input stream with option KDB and it does when option KDB is not present. This is a change in behaviour and changes in behaviour may have compatibility impacts visible in user- space. > As for the first case, such drivers could call something like > kdb_is_on() to decide if special actions are to be taken. For the serial line break condition you could use a sysctl, but there's also a case to be made that it just opens up security holes. The point is that there are 2 ways we could react to a line break condition and we need some way to tell the kernel how we want to do it. It's for that purpose, among others, that we have the KDB option. > Using a > build-time option to control a link between two kernel parts not > depending on the option looks strange. E.g., the KDB code is always > there, sio(4) is controlled by "device sio", but the ability of the > latter to handle line break condition depends on "options KDB". > Counter-intuitive, eh? I think what might cause the confusion is the name "KDB", not what it does. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Sat Aug 5 20:28:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2458F16A4DE; Sat, 5 Aug 2006 20:28:51 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D712543D45; Sat, 5 Aug 2006 20:28:50 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75KSoxn039911; Sat, 5 Aug 2006 20:28:50 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75KSoW2039910; Sat, 5 Aug 2006 20:28:50 GMT (envelope-from njl) Message-Id: <200608052028.k75KSoW2039910@repoman.freebsd.org> From: Nate Lawson Date: Sat, 5 Aug 2006 20:28:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 20:28:51 -0000 njl 2006-08-05 20:28:50 UTC FreeBSD src repository Modified files: etc/defaults rc.conf Log: Back out 1.272. The LAPIC timer conflicts with C2/3 on various systems, and so users get hangs until interrupts are generated another way. We'll have to find a way to make the 2 work together before re-enabling this by default. Revision Changes Path 1.291 +2 -2 src/etc/defaults/rc.conf From owner-cvs-src@FreeBSD.ORG Sat Aug 5 20:35:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7706016A4DE; Sat, 5 Aug 2006 20:35:12 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36A6343D45; Sat, 5 Aug 2006 20:35:12 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75KZCX3040305; Sat, 5 Aug 2006 20:35:12 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75KZCpo040304; Sat, 5 Aug 2006 20:35:12 GMT (envelope-from jb) Message-Id: <200608052035.k75KZCpo040304@repoman.freebsd.org> From: John Birrell Date: Sat, 5 Aug 2006 20:35:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 20:35:12 -0000 jb 2006-08-05 20:35:12 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Add OpenSolaris compatibility definitions which are only visible if _SOLARIS_C_SOURCE is defined. The _OpenSolaris_version is set to match the last import of the OpenSolaris tar ball and is based on the date in that file name. Revision Changes Path 1.270 +16 -0 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Sat Aug 5 20:38:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9573016A4DD; Sat, 5 Aug 2006 20:38:24 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4658943D49; Sat, 5 Aug 2006 20:38:24 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75KcOw5040531; Sat, 5 Aug 2006 20:38:24 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75KcOIX040530; Sat, 5 Aug 2006 20:38:24 GMT (envelope-from yar) Message-Id: <200608052038.k75KcOIX040530@repoman.freebsd.org> From: Yar Tikhiy Date: Sat, 5 Aug 2006 20:38:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/groff/tmac mdoc.local X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 20:38:24 -0000 yar 2006-08-05 20:38:24 UTC FreeBSD src repository Modified files: gnu/usr.bin/groff/tmac mdoc.local Log: Add libbsm to the list of our standard libraries. Approved by: ru Revision Changes Path 1.53 +1 -0 src/gnu/usr.bin/groff/tmac/mdoc.local From owner-cvs-src@FreeBSD.ORG Sat Aug 5 21:08:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1725316A4DE; Sat, 5 Aug 2006 21:08:48 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C94D843D46; Sat, 5 Aug 2006 21:08:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75L8lZ3050950; Sat, 5 Aug 2006 21:08:47 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75L8l48050949; Sat, 5 Aug 2006 21:08:47 GMT (envelope-from rwatson) Message-Id: <200608052108.k75L8l48050949@repoman.freebsd.org> From: Robert Watson Date: Sat, 5 Aug 2006 21:08:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 21:08:48 -0000 rwatson 2006-08-05 21:08:47 UTC FreeBSD src repository Modified files: sys/kern vfs_lookup.c Log: We now spell "inode" as "vnode" in the VFS layer, so update comment for new world order. MFC after: 3 days Pointed out by: mckusick Revision Changes Path 1.92 +3 -3 src/sys/kern/vfs_lookup.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 21:11:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E3AC16A4DD; Sat, 5 Aug 2006 21:11:59 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64EF443D53; Sat, 5 Aug 2006 21:11:58 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k75LBeTY031375; Sun, 6 Aug 2006 01:11:40 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k75LBeNl031374; Sun, 6 Aug 2006 01:11:40 +0400 (MSD) (envelope-from yar) Date: Sun, 6 Aug 2006 01:11:40 +0400 From: Yar Tikhiy To: Sam Leffler Message-ID: <20060805211140.GG29277@comp.chem.msu.su> References: <200608030959.k739x9N6007207@repoman.freebsd.org> <44D22E2F.4070307@errno.com> <20060803180854.GI97316@comp.chem.msu.su> <44D3758C.1000609@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D3758C.1000609@errno.com> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 21:11:59 -0000 On Fri, Aug 04, 2006 at 09:27:56AM -0700, Sam Leffler wrote: > Yar Tikhiy wrote: > > On Thu, Aug 03, 2006 at 10:11:11AM -0700, Sam Leffler wrote: > >> Yar Tikhiy wrote: > >>> yar 2006-08-03 09:59:09 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/net if_vlan.c > >>> Log: > >>> Should vlan_input() ever be called with ifp pointing to a non-Ethernet > >>> interface, do not just assign -1 to tag because it breaks the logic of > >>> the code to follow. The better way is to handle this case as an unsupported > >>> protocol and return unless INVARIANTS is in effect and we can panic. > >>> Panic is good there because the scenario can happen only because of a > >>> coding error elsewhere. > >>> > >>> We also should show the interface name in the panic message for easier > >>> debugging of the problem, should it ever emerge. > >> Introducing a panic in a place where you can trivially recover is bad > >> regardless of why you got there. Many people run production systems > >> with INVARIANTS turned on. Is it now possible to send a "packet of > >> death" by exploiting this code path? > > > > No nastygram can ever achieve this; only FreeBSD commiters possess > > the ability to :-) > > > > The panic can never be reached unless one manages to attach a vlan > > interface to a non-Ethernet physical interface in advance, which > > is totally prohibited by the code at the beginning of vlan_config(); > > and vlan_config() is the only way to attach a vlan interface to a > > physical interface. > > > > I.e., it will take a developer breaking the logic in /sys/net to > > make the code path expoloitable. > > > > OTOH, you are right that we can at least attempt to recover from > > the situation. Perhaps it's time to introduce a common macro or > > function that emits a message on the console and then just calls > > kdb_backtrace() instead of dumping core and halting the system? > > So users will be able to post the stack traces to the lists and > > thus help to spot the possible bugs w/o having to go through panics. > > I'm unsure if sticking raw kdb_backtrace() calls in such places > > is a good idea, so I'm suggesting a wrapper function or macro. > > It is to be used in "can absolutely never happen" cases that are > > not fatal, like the one under discussion. > > > > It is my experience that problems like the "packet of death" come about > from (well-meaning) planting of a landmine of this sort followed, > sometime later, by another person enabling the code path. I work by the > rule that panic should be used only in places where you have no way to > recover or recovery is so hard as to be not worthwhile (based on the > circumstances). Sounds fair! if_vlan.c appears to use quite a few KASSERT's and panic's in places where it could recover by, e.g., failing the current operation. I'll revise them. -- Yar From owner-cvs-src@FreeBSD.ORG Sat Aug 5 21:20:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0034216A4DA; Sat, 5 Aug 2006 21:20:54 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4125243D45; Sat, 5 Aug 2006 21:20:53 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k75LKqhQ031449; Sun, 6 Aug 2006 01:20:52 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k75LKq9O031448; Sun, 6 Aug 2006 01:20:52 +0400 (MSD) (envelope-from yar) Date: Sun, 6 Aug 2006 01:20:52 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20060805212051.GA31388@comp.chem.msu.su> References: <200608041336.k74DaSRI089155@repoman.freebsd.org> <20060804151509.GF96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804151509.GF96644@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 21:20:55 -0000 On Fri, Aug 04, 2006 at 07:15:09PM +0400, Gleb Smirnoff wrote: > On Fri, Aug 04, 2006 at 01:36:28PM +0000, Gleb Smirnoff wrote: > T> glebius 2006-08-04 13:36:28 UTC > T> > T> FreeBSD src repository > T> > T> Modified files: > T> sys/netgraph ng_ether.c > T> Log: > T> Turn off by default "feature" that overwrites MAC address > T> on output frames. > T> > T> Many people were confused with not working CARP, ng_bridge(4) > T> and other subsystems, because ng_ether(4) overwritten source > T> MAC address. > > About a year ago or more I have discussed this change with Yar > and Julian. AFAIR, there were no objections. I'm very happy with this change. Thanks! -- Yar From owner-cvs-src@FreeBSD.ORG Sat Aug 5 21:41:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD6E116A4DA; Sat, 5 Aug 2006 21:41:30 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA82043D8F; Sat, 5 Aug 2006 21:41:09 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75Lf5uC052588; Sat, 5 Aug 2006 21:41:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75Lf0Kb052587; Sat, 5 Aug 2006 21:41:00 GMT (envelope-from rwatson) Message-Id: <200608052141.k75Lf0Kb052587@repoman.freebsd.org> From: Robert Watson Date: Sat, 5 Aug 2006 21:41:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_lookup.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 21:41:30 -0000 rwatson 2006-08-05 21:41:00 UTC FreeBSD src repository Modified files: sys/kern vfs_lookup.c Log: Remove register, use ANSI function headers. Revision Changes Path 1.93 +9 -15 src/sys/kern/vfs_lookup.c From owner-cvs-src@FreeBSD.ORG Sat Aug 5 22:04:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D54C516A4DF; Sat, 5 Aug 2006 22:04:21 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 937F743D46; Sat, 5 Aug 2006 22:04:21 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k75M4LJa054938; Sat, 5 Aug 2006 22:04:21 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k75M4LJQ054937; Sat, 5 Aug 2006 22:04:21 GMT (envelope-from rwatson) Message-Id: <200608052204.k75M4LJQ054937@repoman.freebsd.org> From: Robert Watson Date: Sat, 5 Aug 2006 22:04:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/svr4 svr4_stream.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 22:04:21 -0000 rwatson 2006-08-05 22:04:21 UTC FreeBSD src repository Modified files: sys/compat/svr4 svr4_stream.c Log: With socket code no longer in svr4_stream.c, MAC includes are no longer required, so GC. Revision Changes Path 1.62 +0 -2 src/sys/compat/svr4/svr4_stream.c