From owner-cvs-src@FreeBSD.ORG Sun Oct 22 00:09:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A583116A407; Sun, 22 Oct 2006 00:09:41 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 612BA43D4C; Sun, 22 Oct 2006 00:09:41 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9M09f2C017130; Sun, 22 Oct 2006 00:09:41 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9M09fTB017129; Sun, 22 Oct 2006 00:09:41 GMT (envelope-from davidxu) Message-Id: <200610220009.k9M09fTB017129@repoman.freebsd.org> From: David Xu Date: Sun, 22 Oct 2006 00:09:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 00:09:41 -0000 davidxu 2006-10-22 00:09:41 UTC FreeBSD src repository Modified files: sys/kern kern_sig.c Log: Use macro TAILQ_FOREACH_SAFE instead of expanding it. Revision Changes Path 1.334 +3 -6 src/sys/kern/kern_sig.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 00:14:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C7D116A407; Sun, 22 Oct 2006 00:14:15 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (adsl-75-1-14-242.dsl.scrm01.sbcglobal.net [75.1.14.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B03B43D49; Sun, 22 Oct 2006 00:14:14 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id k9M0E5mG061752; Sat, 21 Oct 2006 17:14:09 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200610220014.k9M0E5mG061752@gw.catspoiler.org> Date: Sat, 21 Oct 2006 17:14:05 -0700 (PDT) From: Don Lewis To: davidxu@FreeBSD.org In-Reply-To: <200610212359.k9LNxF2P014387@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 00:14:15 -0000 On 21 Oct, David Xu wrote: > davidxu 2006-10-21 23:59:15 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_exit.c > Log: > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > opened a race window which can cause memory leak in signal queue. > Here we free memory for signal queue when process state is set to > PRS_ZOMBIE. > > Revision Changes Path > 1.291 +8 -2 src/sys/kern/kern_exit.c I wonder if the earlier change is what broke portupgrade after I upgraded from an August 31st version of current to yesterday's version. The symptoms were random processes dying from SIGHUP. It was easy to reproduce by just going to a port directory and running script foo make clean a few times. I'd randomly see make complain about a non-zero exit status from uname or some other sub-process. I tracked the problem back to the SIGHUP bit being set in td2's sigqueue in fork1(). As a workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. Disappearing back into the void ... From owner-cvs-src@FreeBSD.ORG Sun Oct 22 02:07:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D6EA16A412; Sun, 22 Oct 2006 02:07:19 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C56A143D46; Sun, 22 Oct 2006 02:07:18 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id A86F21A3C1C; Sat, 21 Oct 2006 19:07:18 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 04B7751595; Sat, 21 Oct 2006 22:07:16 -0400 (EDT) Date: Sat, 21 Oct 2006 22:07:16 -0400 From: Kris Kennaway To: Don Lewis Message-ID: <20061022020716.GA29912@xor.obsecurity.org> References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610220014.k9M0E5mG061752@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <200610220014.k9M0E5mG061752@gw.catspoiler.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 02:07:19 -0000 --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 21, 2006 at 05:14:05PM -0700, Don Lewis wrote: > On 21 Oct, David Xu wrote: > > davidxu 2006-10-21 23:59:15 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern kern_exit.c=20 > > Log: > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > opened a race window which can cause memory leak in signal queue. > > Here we free memory for signal queue when process state is set to > > PRS_ZOMBIE. > > =20 > > Revision Changes Path > > 1.291 +8 -2 src/sys/kern/kern_exit.c >=20 > I wonder if the earlier change is what broke portupgrade after I > upgraded from an August 31st version of current to yesterday's version. > The symptoms were random processes dying from SIGHUP. It was easy to > reproduce by just going to a port directory and running > script foo make clean > a few times. I'd randomly see make complain about a non-zero exit > status from uname or some other sub-process. I tracked the problem back > to the SIGHUP bit being set in td2's sigqueue in fork1(). As a > workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. Something is making java segfault reproducibly on a recent kernel too. I'll test to see whether this fixes it. Kris --DocE+STaALJfprDB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFOtJUWry0BWjoQKURAoaMAKDsl/UFHao/r6WjlWkK+WhQyWagQACeLLIu 5E8YovHpQFbvrUj/tO1fyxM= =gu5c -----END PGP SIGNATURE----- --DocE+STaALJfprDB-- From owner-cvs-src@FreeBSD.ORG Sun Oct 22 02:19:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59AAB16A407; Sun, 22 Oct 2006 02:19:34 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15B2343D5E; Sun, 22 Oct 2006 02:19:34 +0000 (GMT) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9M2JXfT047428; Sun, 22 Oct 2006 02:19:33 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9M2JXmH047427; Sun, 22 Oct 2006 02:19:33 GMT (envelope-from kevlo) Message-Id: <200610220219.k9M2JXmH047427@repoman.freebsd.org> From: Kevin Lo Date: Sun, 22 Oct 2006 02:19:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/crypto/sha2 sha2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 02:19:34 -0000 kevlo 2006-10-22 02:19:33 UTC FreeBSD src repository Modified files: sys/crypto/sha2 sha2.c Log: Initialize T1 to silent gcc warning. Approved by: cognet Revision Changes Path 1.9 +1 -1 src/sys/crypto/sha2/sha2.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 02:38:29 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 050BB16A403; Sun, 22 Oct 2006 02:38:29 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Kris Kennaway Date: Sun, 22 Oct 2006 10:38:21 +0800 User-Agent: KMail/1.8.2 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610220014.k9M0E5mG061752@gw.catspoiler.org> <20061022020716.GA29912@xor.obsecurity.org> In-Reply-To: <20061022020716.GA29912@xor.obsecurity.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200610221038.21967.davidxu@freebsd.org> Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Don Lewis , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 02:38:29 -0000 On Sunday 22 October 2006 10:07, Kris Kennaway wrote: > Something is making java segfault reproducibly on a recent kernel too. > I'll test to see whether this fixes it. > > Kris I posted a bug report on java@, a memory block returned by valloc can not be accessed, making java segfault. David Xu From owner-cvs-src@FreeBSD.ORG Sun Oct 22 04:18:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4403116A407; Sun, 22 Oct 2006 04:18:02 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F233043D46; Sun, 22 Oct 2006 04:18:01 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9M4I1Is069870; Sun, 22 Oct 2006 04:18:01 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9M4I1EY069869; Sun, 22 Oct 2006 04:18:01 GMT (envelope-from alc) Message-Id: <200610220418.k9M4I1EY069869@repoman.freebsd.org> From: Alan Cox Date: Sun, 22 Oct 2006 04:18:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 04:18:03 -0000 alc 2006-10-22 04:18:01 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c sys/ia64/ia64 pmap.c Log: Eliminate unnecessary PG_BUSY tests. Revision Changes Path 1.572 +1 -1 src/sys/amd64/amd64/pmap.c 1.576 +1 -1 src/sys/i386/i386/pmap.c 1.179 +1 -1 src/sys/ia64/ia64/pmap.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 04:28:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7F7116A403; Sun, 22 Oct 2006 04:28:15 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2631743D4C; Sun, 22 Oct 2006 04:28:15 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9M4SEn4071503; Sun, 22 Oct 2006 04:28:14 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9M4SEu3071502; Sun, 22 Oct 2006 04:28:14 GMT (envelope-from alc) Message-Id: <200610220428.k9M4SEu3071502@repoman.freebsd.org> From: Alan Cox Date: Sun, 22 Oct 2006 04:28:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exec.c uipc_syscalls.c vfs_bio.c vfs_cluster.c src/sys/vm device_pager.c phys_pager.c vm_contig.c vm_fault.c vm_object.c vm_page.c vm_page.h vm_pageout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 04:28:16 -0000 alc 2006-10-22 04:28:14 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c uipc_syscalls.c vfs_bio.c vfs_cluster.c sys/vm device_pager.c phys_pager.c vm_contig.c vm_fault.c vm_object.c vm_page.c vm_page.h vm_pageout.c Log: Replace PG_BUSY with VPO_BUSY. In other words, changes to the page's busy flag, i.e., VPO_BUSY, are now synchronized by the per-vm object lock instead of the global page queues lock. Revision Changes Path 1.296 +1 -1 src/sys/kern/kern_exec.c 1.238 +1 -1 src/sys/kern/uipc_syscalls.c 1.511 +3 -3 src/sys/kern/vfs_bio.c 1.174 +1 -1 src/sys/kern/vfs_cluster.c 1.80 +2 -2 src/sys/vm/device_pager.c 1.24 +1 -1 src/sys/vm/phys_pager.c 1.55 +2 -2 src/sys/vm/vm_contig.c 1.221 +8 -7 src/sys/vm/vm_fault.c 1.368 +7 -7 src/sys/vm/vm_object.c 1.329 +19 -18 src/sys/vm/vm_page.c 1.145 +3 -3 src/sys/vm/vm_page.h 1.277 +17 -11 src/sys/vm/vm_pageout.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 05:55:05 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id C753616A40F; Sun, 22 Oct 2006 05:55:04 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Don Lewis Date: Sun, 22 Oct 2006 13:54:57 +0800 User-Agent: KMail/1.8.2 References: <200610220014.k9M0E5mG061752@gw.catspoiler.org> In-Reply-To: <200610220014.k9M0E5mG061752@gw.catspoiler.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200610221354.57273.davidxu@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 05:55:05 -0000 On Sunday 22 October 2006 08:14, Don Lewis wrote: > On 21 Oct, David Xu wrote: > > davidxu 2006-10-21 23:59:15 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_exit.c > > Log: > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > opened a race window which can cause memory leak in signal queue. > > Here we free memory for signal queue when process state is set to > > PRS_ZOMBIE. > > > > Revision Changes Path > > 1.291 +8 -2 src/sys/kern/kern_exit.c > > I wonder if the earlier change is what broke portupgrade after I > upgraded from an August 31st version of current to yesterday's version. > The symptoms were random processes dying from SIGHUP. It was easy to > reproduce by just going to a port directory and running > script foo make clean > a few times. I'd randomly see make complain about a non-zero exit > status from uname or some other sub-process. I tracked the problem back > to the SIGHUP bit being set in td2's sigqueue in fork1(). As a > workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. > > Disappearing back into the void ... But I am still worrried by these signal changes, if an exiting process can be sent a signal, and msleep will interrupted in cleanup code, where the code will return to ? in normal case, code will return to userland, and signal will be removed and delivered, but if a thread is in exit1(), where the code can be returned to ? if a cleanup procedure is interrupted, isn't there is any resource leak or dead-loop if it is retried because signal is never removed ? David Xu From owner-cvs-src@FreeBSD.ORG Sun Oct 22 06:27:36 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B369C16A403; Sun, 22 Oct 2006 06:27:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from fw.zoral.com.ua (fw.zoral.com.ua [213.186.206.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05F1C43D45; Sun, 22 Oct 2006 06:27:35 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id k9M6BU1C062005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Oct 2006 09:11:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8) with ESMTP id k9M6RU7x005215; Sun, 22 Oct 2006 09:27:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8/Submit) id k9M6RTGO005210; Sun, 22 Oct 2006 09:27:29 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 22 Oct 2006 09:27:29 +0300 From: Kostik Belousov To: David Xu Message-ID: <20061022062729.GE45605@deviant.kiev.zoral.com.ua> References: <200610220014.k9M0E5mG061752@gw.catspoiler.org> <200610221354.57273.davidxu@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AsxXAMtlQ5JHofzM" Content-Disposition: inline In-Reply-To: <200610221354.57273.davidxu@freebsd.org> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.4, clamav-milter version 0.88.4 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=1.9 required=5.0 tests=DNS_FROM_RFC_ABUSE, SPF_NEUTRAL,UNPARSEABLE_RELAY autolearn=no version=3.1.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-25) on fw.zoral.com.ua Cc: cvs-src@freebsd.org, Don Lewis , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 06:27:36 -0000 --AsxXAMtlQ5JHofzM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 22, 2006 at 01:54:57PM +0800, David Xu wrote: > But I am still worrried by these signal changes, if an exiting process > can be sent a signal, and msleep will interrupted in cleanup code, where = the > code will return to ? in normal case, code will return to userland, and= =20 > signal will be removed and delivered, but if a thread is in exit1(), where > the code can be returned to ? if a cleanup procedure is interrupted, is= n't=20 > there is any resource leak or dead-loop if it is retried because signal i= s=20 > never removed ? As noted in the original commit message, I asked for something related some time ago. But, I wanted only to wake up the thread sleeping in exit code. The scenario when this is needed is driver (or nfs client) sleeping in file descriptors cleanup. Currently, such process may become unkillable. I proposed the following change: Index: kern_sig.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/local/arch/ncvs/src/sys/kern/kern_sig.c,v retrieving revision 1.332 diff -u -r1.332 kern_sig.c --- kern_sig.c 5 Oct 2006 01:56:11 -0000 1.332 +++ kern_sig.c 22 Oct 2006 06:23:55 -0000 @@ -2126,8 +2126,7 @@ * action will be SIG_DFL here.) */ mtx_lock(&ps->ps_mtx); - if (SIGISMEMBER(ps->ps_sigignore, sig) || - (p->p_flag & P_WEXIT)) { + if (SIGISMEMBER(ps->ps_sigignore, sig)) { mtx_unlock(&ps->ps_mtx); if (ksi && (ksi->ksi_flags & KSI_INS)) ksiginfo_tryfree(ksi); @@ -2144,7 +2143,12 @@ else intrval =3D ERESTART; mtx_unlock(&ps->ps_mtx); - + if (p->p_flag & P_WEXIT) { + mtx_lock_spin(&sched_lock); + tdsigwakeup(td, sig, action, intrval); + mtx_unlock_spin(&sched_lock); + return (ret); + } if (prop & SA_CONT) sigqueue_delete_stopmask_proc(p); else if (prop & SA_STOP) { I have a hope that kernel code would wake up and make a progress, while not actually delivering signal to the user mode handler. --AsxXAMtlQ5JHofzM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFOw9RC3+MBN1Mb4gRAmz5AKCozwSqUIAW5SvVCRrhuEEktqCU3QCgmvfF b+iRQ/efpmDYqO8pL1xVWiM= =0IKu -----END PGP SIGNATURE----- --AsxXAMtlQ5JHofzM-- From owner-cvs-src@FreeBSD.ORG Sun Oct 22 07:00:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BD9216A403; Sun, 22 Oct 2006 07:00:35 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3237143D5C; Sun, 22 Oct 2006 07:00:08 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9M708FI006423; Sun, 22 Oct 2006 07:00:08 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9M707nM006422; Sun, 22 Oct 2006 07:00:07 GMT (envelope-from bde) Message-Id: <200610220700.k9M707nM006422@repoman.freebsd.org> From: Bruce Evans Date: Sun, 22 Oct 2006 07:00:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/i386/include atomic.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 07:00:35 -0000 bde 2006-10-22 07:00:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/i386/include atomic.h Log: MFC: parts of the following, so that atomic.h in RELENG_4 can be compiled by RELENG_6's compiler: 1.26: pass constraints as a parameter since chars and shorts need different ones. 1.27: fix pedantic syntax errors. 1.40: don't use the '+' constraint so much, since gcc-3.3.mumble broke it for non-register operands. 1.40 essentially backs outs 1.22, and also avoids using the "0" constraint, and also remumbers asm parameters. 1.22 had already been merged to RELENG_4 in 1.9.2.2 in order to fix compiling with -O0 with RELENG_4's compiler. This turned out to be not future-proof. I think the "0" constaint would work with gcc-3, but not using it is a better way to fix compiling with -O0 in RELENG_4. Problems in this area go back to gcc-2.early or gcc-1 when the "0" and "+" constraints didn't exist and there were no correct alternatives for them. 1.9.2.1 unnecessarily used an incorrect alternative that happened to work except for -O0. This change is essentially null when compiled by RELENG_4's compiler. For GENERIC, LINT and one other configuration, it changes no object files except atomic.o compiled with -O0; for the latter it gives different register allocation and some unused instructions. Revision Changes Path 1.9.2.5 +26 -25 src/sys/i386/include/atomic.h From owner-cvs-src@FreeBSD.ORG Sun Oct 22 11:52:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4D9D16A403; Sun, 22 Oct 2006 11:52:32 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A340A43D8C; Sun, 22 Oct 2006 11:52:20 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MBqKE3067887; Sun, 22 Oct 2006 11:52:20 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MBqKuH067883; Sun, 22 Oct 2006 11:52:20 GMT (envelope-from rwatson) Message-Id: <200610221152.k9MBqKuH067883@repoman.freebsd.org> From: Robert Watson Date: Sun, 22 Oct 2006 11:52:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_file.c linux_getcwd.c linux_misc.c linux_stats.c src/sys/compat/svr4 svr4_fcntl.c svr4_misc.c src/sys/contrib/pf/net pf.c src/sys/fs/devfs devfs_devs.c devfs_vnops.c src/sys/i386/i386 sys_machdep.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 11:52:33 -0000 rwatson 2006-10-22 11:52:20 UTC FreeBSD src repository Modified files: sys/compat/linux linux_file.c linux_getcwd.c linux_misc.c linux_stats.c sys/compat/svr4 svr4_fcntl.c svr4_misc.c sys/contrib/pf/net pf.c sys/fs/devfs devfs_devs.c devfs_vnops.c sys/i386/i386 sys_machdep.c sys/i386/ibcs2 ibcs2_misc.c sys/kern init_main.c kern_acct.c kern_acl.c kern_alq.c kern_environment.c kern_exec.c kern_exit.c kern_fork.c kern_jail.c kern_ktrace.c kern_linker.c kern_mac.c kern_mbuf.c kern_prot.c kern_shutdown.c kern_sysctl.c kern_time.c link_elf.c link_elf_obj.c subr_trap.c sys_pipe.c sys_socket.c sysv_msg.c sysv_sem.c sysv_shm.c uipc_mbuf.c uipc_mbuf2.c uipc_sem.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_lookup.c vfs_mount.c vfs_subr.c vfs_syscalls.c vfs_vnops.c sys/net bpf.c bsd_comp.c if.c if_atmsubr.c if_ethersubr.c if_fddisubr.c if_fwsubr.c if_gif.c if_iso88025subr.c if_ppp.c if_stf.c if_tun.c sys/netatalk aarp.c ddp_input.c ddp_output.c sys/netinet if_ether.c igmp.c in_pcb.c ip_divert.c ip_fw2.c ip_icmp.c ip_input.c ip_mroute.c ip_options.c ip_output.c raw_ip.c tcp_input.c tcp_output.c tcp_subr.c tcp_syncache.c udp_usrreq.c sys/netinet6 nd6.c sys/nfsserver nfs_srvsock.c nfs_syscalls.c sys/security/mac mac_framework.h mac_inet.c mac_label.c mac_net.c mac_pipe.c mac_posix_sem.c mac_process.c mac_socket.c mac_system.c mac_sysv_msg.c mac_sysv_sem.c mac_sysv_shm.c mac_vfs.c sys/security/mac_lomac mac_lomac.c sys/sys mac.h mac_policy.h sys/ufs/ffs ffs_vfsops.c sys/ufs/ufs ufs_vnops.c sys/vm swap_pager.c vm_mmap.c Log: Complete break-out of sys/sys/mac.h into sys/security/mac/mac_framework.h begun with a repo-copy of mac.h to mac_framework.h. sys/mac.h now contains the userspace and user<->kernel API and definitions, with all in-kernel interfaces moved to mac_framework.h, which is now included across most of the kernel instead. This change is the first step in a larger cleanup and sweep of MAC Framework interfaces in the kernel, and will not be MFC'd. Obtained from: TrustedBSD Project Sponsored by: SPARTA Revision Changes Path 1.99 +2 -1 src/sys/compat/linux/linux_file.c 1.25 +2 -1 src/sys/compat/linux/linux_getcwd.c 1.189 +2 -1 src/sys/compat/linux/linux_misc.c 1.85 +2 -1 src/sys/compat/linux/linux_stats.c 1.38 +2 -1 src/sys/compat/svr4/svr4_fcntl.c 1.90 +2 -1 src/sys/compat/svr4/svr4_misc.c 1.42 +1 -1 src/sys/contrib/pf/net/pf.c 1.49 +2 -1 src/sys/fs/devfs/devfs_devs.c 1.139 +2 -1 src/sys/fs/devfs/devfs_vnops.c 1.106 +1 -1 src/sys/i386/i386/sys_machdep.c 1.65 +2 -1 src/sys/i386/ibcs2/ibcs2_misc.c 1.268 +1 -1 src/sys/kern/init_main.c 1.84 +2 -1 src/sys/kern/kern_acct.c 1.49 +2 -1 src/sys/kern/kern_acl.c 1.16 +2 -1 src/sys/kern/kern_alq.c 1.45 +2 -1 src/sys/kern/kern_environment.c 1.297 +1 -1 src/sys/kern/kern_exec.c 1.292 +1 -1 src/sys/kern/kern_exit.c 1.262 +1 -1 src/sys/kern/kern_fork.c 1.53 +2 -1 src/sys/kern/kern_jail.c 1.111 +2 -1 src/sys/kern/kern_ktrace.c 1.143 +2 -1 src/sys/kern/kern_linker.c 1.123 +2 -1 src/sys/kern/kern_mac.c 1.27 +2 -1 src/sys/kern/kern_mbuf.c 1.205 +1 -1 src/sys/kern/kern_prot.c 1.179 +2 -1 src/sys/kern/kern_shutdown.c 1.171 +3 -1 src/sys/kern/kern_sysctl.c 1.134 +2 -1 src/sys/kern/kern_time.c 1.91 +2 -1 src/sys/kern/link_elf.c 1.93 +2 -1 src/sys/kern/link_elf_obj.c 1.288 +2 -1 src/sys/kern/subr_trap.c 1.188 +2 -1 src/sys/kern/sys_pipe.c 1.71 +2 -1 src/sys/kern/sys_socket.c 1.63 +2 -1 src/sys/kern/sysv_msg.c 1.85 +2 -1 src/sys/kern/sysv_sem.c 1.108 +2 -1 src/sys/kern/sysv_shm.c 1.168 +2 -1 src/sys/kern/uipc_mbuf.c 1.33 +2 -1 src/sys/kern/uipc_mbuf2.c 1.25 +2 -1 src/sys/kern/uipc_sem.c 1.284 +2 -0 src/sys/kern/uipc_socket.c 1.239 +2 -1 src/sys/kern/uipc_syscalls.c 1.188 +2 -1 src/sys/kern/uipc_usrreq.c 1.96 +1 -1 src/sys/kern/vfs_lookup.c 1.241 +1 -1 src/sys/kern/vfs_mount.c 1.686 +2 -1 src/sys/kern/vfs_subr.c 1.426 +1 -1 src/sys/kern/vfs_syscalls.c 1.245 +2 -1 src/sys/kern/vfs_vnops.c 1.173 +2 -1 src/sys/net/bpf.c 1.24 +2 -1 src/sys/net/bsd_comp.c 1.263 +2 -1 src/sys/net/if.c 1.44 +2 -1 src/sys/net/if_atmsubr.c 1.219 +2 -1 src/sys/net/if_ethersubr.c 1.104 +2 -1 src/sys/net/if_fddisubr.c 1.22 +2 -1 src/sys/net/if_fwsubr.c 1.66 +2 -1 src/sys/net/if_gif.c 1.75 +2 -1 src/sys/net/if_iso88025subr.c 1.116 +2 -1 src/sys/net/if_ppp.c 1.59 +2 -1 src/sys/net/if_stf.c 1.159 +2 -1 src/sys/net/if_tun.c 1.40 +2 -1 src/sys/netatalk/aarp.c 1.30 +2 -1 src/sys/netatalk/ddp_input.c 1.29 +2 -1 src/sys/netatalk/ddp_output.c 1.157 +2 -1 src/sys/netinet/if_ether.c 1.52 +2 -1 src/sys/netinet/igmp.c 1.182 +2 -1 src/sys/netinet/in_pcb.c 1.121 +2 -1 src/sys/netinet/ip_divert.c 1.152 +2 -1 src/sys/netinet/ip_fw2.c 1.113 +2 -1 src/sys/netinet/ip_icmp.c 1.323 +2 -1 src/sys/netinet/ip_input.c 1.121 +2 -1 src/sys/netinet/ip_mroute.c 1.3 +2 -1 src/sys/netinet/ip_options.c 1.267 +2 -1 src/sys/netinet/ip_output.c 1.166 +2 -1 src/sys/netinet/raw_ip.c 1.310 +2 -1 src/sys/netinet/tcp_input.c 1.121 +2 -1 src/sys/netinet/tcp_output.c 1.265 +2 -1 src/sys/netinet/tcp_subr.c 1.102 +2 -1 src/sys/netinet/tcp_syncache.c 1.195 +2 -1 src/sys/netinet/udp_usrreq.c 1.71 +2 -1 src/sys/netinet6/nd6.c 1.101 +2 -1 src/sys/nfsserver/nfs_srvsock.c 1.107 +2 -1 src/sys/nfsserver/nfs_syscalls.c 1.73 +13 -73 src/sys/security/mac/mac_framework.h 1.4 +1 -0 src/sys/security/mac/mac_inet.c 1.4 +1 -0 src/sys/security/mac/mac_label.c 1.119 +1 -0 src/sys/security/mac/mac_net.c 1.108 +1 -0 src/sys/security/mac/mac_pipe.c 1.3 +1 -0 src/sys/security/mac/mac_posix_sem.c 1.114 +1 -0 src/sys/security/mac/mac_process.c 1.6 +1 -0 src/sys/security/mac/mac_socket.c 1.106 +1 -0 src/sys/security/mac/mac_system.c 1.4 +1 -0 src/sys/security/mac/mac_sysv_msg.c 1.4 +1 -0 src/sys/security/mac/mac_sysv_sem.c 1.3 +1 -0 src/sys/security/mac/mac_sysv_shm.c 1.114 +1 -0 src/sys/security/mac/mac_vfs.c 1.41 +1 -1 src/sys/security/mac_lomac/mac_lomac.c 1.72 +2 -369 src/sys/sys/mac.h 1.76 +2 -0 src/sys/sys/mac_policy.h 1.321 +2 -1 src/sys/ufs/ffs/ffs_vfsops.c 1.281 +2 -1 src/sys/ufs/ufs/ufs_vnops.c 1.283 +2 -1 src/sys/vm/swap_pager.c 1.207 +2 -1 src/sys/vm/vm_mmap.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 16:22:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C073B16A492; Sun, 22 Oct 2006 16:22:02 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32BEF43D83; Sun, 22 Oct 2006 16:21:55 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MGLtZo080085; Sun, 22 Oct 2006 16:21:55 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MGLtLa080066; Sun, 22 Oct 2006 16:21:55 GMT (envelope-from ru) Message-Id: <200610221621.k9MGLtLa080066@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 22 Oct 2006 16:21:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ng_pppoe.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 16:22:02 -0000 ru 2006-10-22 16:21:55 UTC FreeBSD src repository Modified files: share/man/man4 ng_pppoe.4 Log: Fix some typos and grammar. PR: docs/66770 Submitted by: Michel Lavondès MFC after: 3 days Revision Changes Path 1.39 +16 -13 src/share/man/man4/ng_pppoe.4 From owner-cvs-src@FreeBSD.ORG Sun Oct 22 16:30:19 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 80A4216A40F; Sun, 22 Oct 2006 16:30:19 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C40843D46; Sun, 22 Oct 2006 16:30:19 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id k9MGUIRV018084; Sun, 22 Oct 2006 09:30:18 -0700 (PDT) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id k9MGUISr018081; Sun, 22 Oct 2006 09:30:18 -0700 (PDT) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Sun, 22 Oct 2006 09:30:18 -0700 (PDT) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: src-committers@freebsd.org In-Reply-To: <200610221354.57273.davidxu@freebsd.org> Message-ID: <20061022092642.Y18042@ns1.feral.com> References: <200610220014.k9M0E5mG061752@gw.catspoiler.org> <200610221354.57273.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 16:30:19 -0000 Are these changes why 9 out of ten reboots for me go into panic with: panic: signal pending ? On Sun, 22 Oct 2006, David Xu wrote: > On Sunday 22 October 2006 08:14, Don Lewis wrote: >> On 21 Oct, David Xu wrote: >>> davidxu 2006-10-21 23:59:15 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern kern_exit.c >>> Log: >>> Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change >>> opened a race window which can cause memory leak in signal queue. >>> Here we free memory for signal queue when process state is set to >>> PRS_ZOMBIE. >>> >>> Revision Changes Path >>> 1.291 +8 -2 src/sys/kern/kern_exit.c >> >> I wonder if the earlier change is what broke portupgrade after I >> upgraded from an August 31st version of current to yesterday's version. >> The symptoms were random processes dying from SIGHUP. It was easy to >> reproduce by just going to a port directory and running >> script foo make clean >> a few times. I'd randomly see make complain about a non-zero exit >> status from uname or some other sub-process. I tracked the problem back >> to the SIGHUP bit being set in td2's sigqueue in fork1(). As a >> workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. >> >> Disappearing back into the void ... > > But I am still worrried by these signal changes, if an exiting process > can be sent a signal, and msleep will interrupted in cleanup code, where the > code will return to ? in normal case, code will return to userland, and > signal will be removed and delivered, but if a thread is in exit1(), where > the code can be returned to ? if a cleanup procedure is interrupted, isn't > there is any resource leak or dead-loop if it is retried because signal is > never removed ? > > David Xu > From owner-cvs-src@FreeBSD.ORG Sun Oct 22 16:33:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0880A16A541; Sun, 22 Oct 2006 16:33:44 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA15143D55; Sun, 22 Oct 2006 16:33:43 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MGXhVp005933; Sun, 22 Oct 2006 16:33:43 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MGXhwN005932; Sun, 22 Oct 2006 16:33:43 GMT (envelope-from delphij) Message-Id: <200610221633.k9MGXhwN005932@repoman.freebsd.org> From: Xin LI Date: Sun, 22 Oct 2006 16:33:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 16:33:44 -0000 delphij 2006-10-22 16:33:43 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v pmap.c Log: Fix build: remove (now) unnecessary PG_BUSY check, it's handled by vm object locking. Revision Changes Path 1.3 +1 -1 src/sys/sun4v/sun4v/pmap.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 17:21:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0B0216A415; Sun, 22 Oct 2006 17:21:04 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 678AC43D49; Sun, 22 Oct 2006 17:21:04 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MHL4IG022080; Sun, 22 Oct 2006 17:21:04 GMT (envelope-from hrs@repoman.freebsd.org) Received: (from hrs@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MHL44X022078; Sun, 22 Oct 2006 17:21:04 GMT (envelope-from hrs) Message-Id: <200610221721.k9MHL44X022078@repoman.freebsd.org> From: Hiroki Sato Date: Sun, 22 Oct 2006 17:21:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d auto_linklocal X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 17:21:04 -0000 hrs 2006-10-22 17:21:04 UTC FreeBSD src repository Modified files: etc/rc.d auto_linklocal Log: Suppress a spurious warning message when a kernel without INET6 is used. Spotted by: ru Reviewed by: ume MFC after: 3 days Revision Changes Path 1.3 +1 -1 src/etc/rc.d/auto_linklocal From owner-cvs-src@FreeBSD.ORG Sun Oct 22 18:02:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3293B16A407; Sun, 22 Oct 2006 18:02:02 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B29143D6A; Sun, 22 Oct 2006 18:02:01 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MI21wq028975; Sun, 22 Oct 2006 18:02:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MI21E0028974; Sun, 22 Oct 2006 18:02:01 GMT (envelope-from ru) Message-Id: <200610221802.k9MI21E0028974@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 22 Oct 2006 18:02:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 syscons.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 18:02:02 -0000 ru 2006-10-22 18:02:01 UTC FreeBSD src repository Modified files: share/man/man4 syscons.4 Log: Fix ttyv* device names. PR: docs/104376 Submitted by: Michael Le Barbier MFC after: 3 days Revision Changes Path 1.44 +7 -7 src/share/man/man4/syscons.4 From owner-cvs-src@FreeBSD.ORG Sun Oct 22 18:19:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6EEC16A47C; Sun, 22 Oct 2006 18:19:13 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E966543D6A; Sun, 22 Oct 2006 18:19:08 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MIJ8Ea032685; Sun, 22 Oct 2006 18:19:08 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MIJ8ii032684; Sun, 22 Oct 2006 18:19:08 GMT (envelope-from phk) Message-Id: <200610221819.k9MIJ8ii032684@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 22 Oct 2006 18:19:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_fattime.c src/sys/conf files src/sys/sys clock.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 18:19:14 -0000 phk 2006-10-22 18:19:08 UTC FreeBSD src repository Modified files: sys/conf files sys/sys clock.h Added files: sys/kern subr_fattime.c Log: Add two new functions to convert FAT filesystem format timestamps to and from struct timespec, to replace the crummy conversion function which have been copy&pasted into three different filesystems already. Apart from general crummyness as indicated by code like: for (year = 1970;; year++) { inc = year & 0x03 ? 365 : 366; if (days < inc) break; days -= inc; } They also contain specialized crummyness which tries to compensate for the general crummyness by caching recent conversion results, with no regard for locking or consistency. These replacement functions are smaller, O(1) and handle the Y2.1K leap-year correctly. Ideally, these functions should live in a module of their own, which the three offending filesystems would depend on, but the size is 877 bytes of code (on i386), so that would be false economy. Revision Changes Path 1.1153 +1 -0 src/sys/conf/files 1.1 +304 -0 src/sys/kern/subr_fattime.c (new) 1.6 +3 -0 src/sys/sys/clock.h From owner-cvs-src@FreeBSD.ORG Sun Oct 22 18:24:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 837B016A407; Sun, 22 Oct 2006 18:24:20 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDE4543D58; Sun, 22 Oct 2006 18:24:14 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 12D55170C6; Sun, 22 Oct 2006 18:24:13 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.8/8.13.8) with ESMTP id k9MIOCOd058767; Sun, 22 Oct 2006 18:24:12 GMT (envelope-from phk@critter.freebsd.dk) From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 22 Oct 2006 18:19:08 GMT." <200610221819.k9MIJ8ii032684@repoman.freebsd.org> Date: Sun, 22 Oct 2006 18:24:12 +0000 Message-ID: <58766.1161541452@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_fattime.c src/sys/conf files src/sys/sys clock.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 18:24:20 -0000 In message <200610221819.k9MIJ8ii032684@repoman.freebsd.org>, Poul-Henning Kamp writes: >phk 2006-10-22 18:19:08 UTC > > FreeBSD src repository > > Modified files: > sys/conf files > sys/sys clock.h > Added files: > sys/kern subr_fattime.c > Log: > Add two new functions to convert FAT filesystem format timestamps > to and from struct timespec, to replace the crummy conversion > function which have been copy&pasted into three different > filesystems already. I don't know if we have active janitors for msdosfs, nwfs and smbfs ? If we do, I'd prefer if they will apply these functions to their respective filesystems. Otherwise I'll do it at some point. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun Oct 22 19:51:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D03916A403; Sun, 22 Oct 2006 19:51:51 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7A0F43D7B; Sun, 22 Oct 2006 19:51:50 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MJpoKt096662; Sun, 22 Oct 2006 19:51:50 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MJpo6B096634; Sun, 22 Oct 2006 19:51:50 GMT (envelope-from ru) Message-Id: <200610221951.k9MJpo6B096634@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 22 Oct 2006 19:51:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/acpica Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 19:51:51 -0000 ru 2006-10-22 19:51:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/acpica Makefile Log: MFC: 1.7: Fix standalone build of the kernel with "device acpi". 1.8: Add missing acpi_wakecode.o: assym.s dependency. Approved by: re (hrs) Revision Changes Path 1.6.8.1 +8 -2 src/sys/i386/acpica/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 22 20:33:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3677A16A412; Sun, 22 Oct 2006 20:33:11 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8416943D73; Sun, 22 Oct 2006 20:33:10 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MKXA50060110; Sun, 22 Oct 2006 20:33:10 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MKXA7q060101; Sun, 22 Oct 2006 20:33:10 GMT (envelope-from flz) Message-Id: <200610222033.k9MKXA7q060101@repoman.freebsd.org> From: Florent Thoumie Date: Sun, 22 Oct 2006 20:33:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/rc.d amd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 20:33:11 -0000 flz 2006-10-22 20:33:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/rc.d amd Log: MFC: Add 'reload' to the list of available commands for the amd rc.d script. src/etc/rc.d/amd: rev 1.17 -> 1.18 PR: conf/104507 Submitted by: Douglas K. Rand Approved by: re (bmah) Revision Changes Path 1.15.2.3 +1 -0 src/etc/rc.d/amd From owner-cvs-src@FreeBSD.ORG Sun Oct 22 21:18:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3DE2916A416; Sun, 22 Oct 2006 21:18:49 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED4CE43D5D; Sun, 22 Oct 2006 21:18:48 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MLImUQ031510; Sun, 22 Oct 2006 21:18:48 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MLImg2031498; Sun, 22 Oct 2006 21:18:48 GMT (envelope-from alc) Message-Id: <200610222118.k9MLImg2031498@repoman.freebsd.org> From: Alan Cox Date: Sun, 22 Oct 2006 21:18:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exec.c src/sys/pci agp.c src/sys/vm vm_object.c vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 21:18:49 -0000 alc 2006-10-22 21:18:48 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c sys/pci agp.c sys/vm vm_object.c vm_page.c Log: The page queues lock is no longer required by vm_page_busy() or vm_page_wakeup(). Reduce or eliminate its use accordingly. Revision Changes Path 1.298 +1 -3 src/sys/kern/kern_exec.c 1.55 +0 -4 src/sys/pci/agp.c 1.369 +0 -2 src/sys/vm/vm_object.c 1.330 +4 -3 src/sys/vm/vm_page.c From owner-cvs-src@FreeBSD.ORG Sun Oct 22 21:34:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7220516A47B; Sun, 22 Oct 2006 21:34:36 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D916043DDE; Sun, 22 Oct 2006 21:34:18 +0000 (GMT) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MLXvm9050670; Sun, 22 Oct 2006 21:33:57 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MLXvar050667; Sun, 22 Oct 2006 21:33:57 GMT (envelope-from emaste) Message-Id: <200610222133.k9MLXvar050667@repoman.freebsd.org> From: Ed Maste Date: Sun, 22 Oct 2006 21:33:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ng_source.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 21:34:36 -0000 emaste 2006-10-22 21:33:57 UTC FreeBSD src repository Modified files: share/man/man4 ng_source.4 Log: Clarify that the input hook requires binary packet data. Instead of referencing an omitted example, include a short (Perl) example that queues an ICMP Echo message. Revision Changes Path 1.12 +17 -9 src/share/man/man4/ng_source.4 From owner-cvs-src@FreeBSD.ORG Sun Oct 22 22:26:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03DE216A412; Sun, 22 Oct 2006 22:26:55 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B56D143D4C; Sun, 22 Oct 2006 22:26:54 +0000 (GMT) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9MMQsVf028895; Sun, 22 Oct 2006 22:26:54 GMT (envelope-from danger@repoman.freebsd.org) Received: (from danger@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9MMQs16028882; Sun, 22 Oct 2006 22:26:54 GMT (envelope-from danger) Message-Id: <200610222226.k9MMQs16028882@repoman.freebsd.org> From: Daniel Gerzo Date: Sun, 22 Oct 2006 22:26:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 ipfirewall.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 22:26:55 -0000 danger 2006-10-22 22:26:54 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) share/man/man4 ipfirewall.4 Log: - Move available kernel options to SYNOPSIS, describe how to enable ipfw from within loader.conf - Remove IPDIVERT kernel option - Add notes about IPFIREWALL_DEFAULT_TO_ACCEPT and IPFIREWALL_FORWARD This change syncs this man page with the -CURRENT version. Approved by: re (bmah), keramida (mentor), trhodes (mentor) Revision Changes Path 1.31.2.1 +63 -23 src/share/man/man4/ipfirewall.4 From owner-cvs-src@FreeBSD.ORG Mon Oct 23 00:05:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4517F16A40F; Mon, 23 Oct 2006 00:05:29 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0392543D46; Mon, 23 Oct 2006 00:05:29 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N05S0n017596; Mon, 23 Oct 2006 00:05:28 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N05ScJ017575; Mon, 23 Oct 2006 00:05:28 GMT (envelope-from imp) Message-Id: <200610230005.k9N05ScJ017575@repoman.freebsd.org> From: Warner Losh Date: Mon, 23 Oct 2006 00:05:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 00:05:29 -0000 imp 2006-10-23 00:05:28 UTC FreeBSD src repository Modified files: sys/boot/arm Makefile Log: Don't descend into at91 until we sort out the boot loader issues more generally Revision Changes Path 1.3 +1 -1 src/sys/boot/arm/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 23 00:23:43 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9E4316A407; Mon, 23 Oct 2006 00:23:43 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99AFD43D55; Mon, 23 Oct 2006 00:23:42 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 4EFF21330FD; Mon, 23 Oct 2006 09:53:41 +0930 (CST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 4072A9C240; Mon, 23 Oct 2006 09:53:41 +0930 (CST) Date: Mon, 23 Oct 2006 09:53:41 +0930 From: Greg 'groggy' Lehey To: Peter Jeremy Message-ID: <20061023002341.GB85586@wantadilla.lemis.com> References: <200610200431.k9K4V2Qu037114@repoman.freebsd.org> <20061020193038.GA60387@rambler-co.ru> <453953F7.7000603@freebsd.org> <20061021050258.GA6215@turion.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uQr8t48UFsdbeI+V" Content-Disposition: inline In-Reply-To: <20061021050258.GA6215@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Ruslan Ermilov , cvs-all@freebsd.org, Colin Percival Subject: Re: cvs commit: src/usr.bin/jot jot.1 src/usr.bin/lam lam.1 src/usr.bin/rs rs.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 00:23:43 -0000 --uQr8t48UFsdbeI+V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Saturday, 21 October 2006 at 15:02:58 +1000, Peter Jeremy wrote: > On Fri, 2006-Oct-20 15:55:51 -0700, Colin Percival wrote: >> Ruslan Ermilov wrote: >>> On Fri, Oct 20, 2006 at 04:31:02AM +0000, Colin Percival wrote: >>>> Document that jot(1), rs(1), and lam(1) first appeared in 4.2BSD. >>>> >>> What information this is based on? >> >> John Kunze's CV states that he "wrote three UNIX tools distributed with >> 4.2/4.3BSD using this method (Master's Degree Project, 1983); these tools >> ("jot", "rs", and "lam") are distributed in current Mac OS X systems". > > I've just looked thru the CSRG CDs and I can only find them in 4.4 and > later. If they are in 4.2 or 4.3, they aren't obvious. Colin's right (or lucky :-). I have files here, from the CSRG CD-ROM set: /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/jot.1 /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/jot.c /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/rs.1 /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/rs.c /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/lam.1 /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/lam.c jot(1) starts: .TH JOT 1 "15 May 1983" .UC 4 .SH NAME jot \- print sequential or random data and ends .SH AUTHOR John Kunze No HISTORY section. rs(1): .TH RS 1 "14 June 1983" .UC 4 .SH NAME rs \- reshape a data array ... .SH AUTHOR John Kunze lam(1): .TH LAM 1 "14 June 1983" .UC 4 .SH NAME lam \- laminate files ... .SH AUTHOR John Kunze I can't find earlier mentions. If anybody wants these files, I'd be happy to send them. Greg -- See complete headers for address and phone numbers. --uQr8t48UFsdbeI+V Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFFPAuNIubykFB6QiMRApjEAKCjiGN1niH1mebp9VoT/+iMPPremgCfRWWa UMndv1E7AdumUSyOuTA/4t4= =sEDK -----END PGP SIGNATURE----- --uQr8t48UFsdbeI+V-- From owner-cvs-src@FreeBSD.ORG Mon Oct 23 00:34:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EFE216A49E; Mon, 23 Oct 2006 00:34:08 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 414CC43D5F; Mon, 23 Oct 2006 00:34:08 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N0Y8Op079609; Mon, 23 Oct 2006 00:34:08 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N0Y8Zm079608; Mon, 23 Oct 2006 00:34:08 GMT (envelope-from mlaier) Message-Id: <200610230034.k9N0Y8Zm079608@repoman.freebsd.org> From: Max Laier Date: Mon, 23 Oct 2006 00:34:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/iwi if_iwi.c if_iwireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 00:34:08 -0000 mlaier 2006-10-23 00:34:07 UTC FreeBSD src repository Modified files: sys/dev/iwi if_iwi.c if_iwireg.h Log: net80211 seems to give us more rates than specified via ic_sup_rates under yet to be investigated circumstances. If that happens truncate to the number of rates that the firmware supports. Found by: Jeremie Le Hen Obtained from: OpenBSD (w/ changes) MFC after: 3 days Revision Changes Path 1.41 +5 -0 src/sys/dev/iwi/if_iwi.c 1.13 +2 -1 src/sys/dev/iwi/if_iwireg.h From owner-cvs-src@FreeBSD.ORG Mon Oct 23 00:38:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46F2C16A403; Mon, 23 Oct 2006 00:38:59 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF9B843D5F; Mon, 23 Oct 2006 00:38:58 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N0cwXt079790; Mon, 23 Oct 2006 00:38:58 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N0cwQn079789; Mon, 23 Oct 2006 00:38:58 GMT (envelope-from marcel) Message-Id: <200610230038.k9N0cwQn079789@repoman.freebsd.org> From: Marcel Moolenaar Date: Mon, 23 Oct 2006 00:38:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 nexus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 00:38:59 -0000 marcel 2006-10-23 00:38:58 UTC FreeBSD src repository Modified files: sys/ia64/ia64 nexus.c Log: o Eliminate nexus_print_resources(). Use resource_list_print_type() instead. o Eliminate nexus_print_all_resources(). Inline the function body in nexus_print_child(). Revision Changes Path 1.15 +5 -50 src/sys/ia64/ia64/nexus.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 01:46:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 27B1C16A407; Mon, 23 Oct 2006 01:46:32 +0000 (UTC) (envelope-from davidxu@freebsd.org) Message-ID: <453C1EEE.3080901@freebsd.org> Date: Mon, 23 Oct 2006 09:46:22 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20060725 X-Accept-Language: en-us, en MIME-Version: 1.0 To: mjacob@freebsd.org References: <200610220014.k9M0E5mG061752@gw.catspoiler.org> <200610221354.57273.davidxu@freebsd.org> <20061022092642.Y18042@ns1.feral.com> In-Reply-To: <20061022092642.Y18042@ns1.feral.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 01:46:41 -0000 mjacob@freebsd.org wrote: > > Are these changes why 9 out of ten reboots for me go into panic with: > > panic: signal pending > > ? > This was fixed in kern_exit.c. David Xu From owner-cvs-src@FreeBSD.ORG Mon Oct 23 03:33:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12F2616A403; Mon, 23 Oct 2006 03:33:29 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63CD743D6D; Mon, 23 Oct 2006 03:33:28 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N3XSwa019553; Mon, 23 Oct 2006 03:33:28 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N3XSKw019552; Mon, 23 Oct 2006 03:33:28 GMT (envelope-from delphij) Message-Id: <200610230333.k9N3XSKw019552@repoman.freebsd.org> From: Xin LI Date: Mon, 23 Oct 2006 03:33:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/cpio ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog FREEBSD-upgrade INSTALL NEWS README THANKS TODO alloca.c copyin.c copyout.c copypass.c cpio.1 cpio.h cpio.texi cpiohdr.h defer.c defer.h dirname.c dstring.c dstring.h error.c extern.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 03:33:29 -0000 delphij 2006-10-23 03:33:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/cpio COPYING ChangeLog FREEBSD-upgrade NEWS README gnu/usr.bin/cpio Makefile gnu/usr.bin/cpio/doc Makefile Added files: (Branch: RELENG_6) contrib/cpio ABOUT-NLS AUTHORS INSTALL THANKS TODO contrib/cpio/doc cpio.1 cpio.texi contrib/cpio/lib alloca_.h argp-ba.c argp-eexst.c argp-fmtstream.c argp-fmtstream.h argp-fs-xinl.c argp-help.c argp-namefrob.h argp-parse.c argp-pv.c argp-pvh.c argp-xinl.c argp.h basename.c dirname.c dirname.h error.c error.h exit.h exitfail.c exitfail.h full-write.c full-write.h getopt.c getopt1.c getopt_.h getopt_int.h gettext.h localedir.h mempcpy.c mempcpy.h rmt.h rtapelib.c safe-read.c safe-read.h safe-write.c safe-write.h savedir.c savedir.h strcase.h strchrnul.c strchrnul.h stripslash.c strndup.c strndup.h strnlen.c system.h unlocked-io.h xalloc-die.c xalloc.h xmalloc.c contrib/cpio/src copyin.c copyout.c copypass.c cpio.h cpiohdr.h defer.c defer.h dstring.c dstring.h extern.h filemode.c filetypes.h global.c idcache.c main.c makepath.c safe-stat.h tar.c tar.h tarhdr.h userspec.c util.c gnu/usr.bin/cpio config.h Removed files: (Branch: RELENG_6) contrib/cpio COPYING.LIB alloca.c copyin.c copyout.c copypass.c cpio.1 cpio.h cpio.texi cpiohdr.h defer.c defer.h dirname.c dstring.c dstring.h error.c extern.h filemode.c filetypes.h global.c idcache.c main.c makepath.c rmt.h rtapelib.c safe-stat.h stripslash.c system.h tar.c tar.h tarhdr.h userspec.c util.c version.c xmalloc.c xstrdup.c Log: MFC: GNU cpio 2.6 (original committed by tjr@) Approved by: re (hrs) Revision Changes Path 1.1.1.1.2.1 +705 -0 src/contrib/cpio/ABOUT-NLS (new) 1.1.1.1.2.1 +6 -0 src/contrib/cpio/AUTHORS (new) 1.1.1.1.40.1 +6 -5 src/contrib/cpio/COPYING 1.1.1.1.40.1 +0 -481 src/contrib/cpio/COPYING.LIB (dead) 1.1.1.1.40.1 +431 -2 src/contrib/cpio/ChangeLog 1.4.8.1 +24 -12 src/contrib/cpio/FREEBSD-upgrade 1.1.1.1.2.1 +231 -0 src/contrib/cpio/INSTALL (new) 1.1.1.1.40.1 +61 -0 src/contrib/cpio/NEWS 1.1.1.1.40.1 +3 -3 src/contrib/cpio/README 1.1.1.1.2.1 +14 -0 src/contrib/cpio/THANKS (new) 1.1.1.1.2.1 +356 -0 src/contrib/cpio/TODO (new) 1.1.1.1.40.1 +0 -495 src/contrib/cpio/alloca.c (dead) 1.7.14.2 +0 -1464 src/contrib/cpio/copyin.c (dead) 1.2.40.2 +0 -963 src/contrib/cpio/copyout.c (dead) 1.3.10.2 +0 -484 src/contrib/cpio/copypass.c (dead) 1.3.38.2 +0 -328 src/contrib/cpio/cpio.1 (dead) 1.1.1.1.40.1 +0 -69 src/contrib/cpio/cpio.h (dead) 1.1.1.1.40.1 +0 -558 src/contrib/cpio/cpio.texi (dead) 1.1.1.1.40.1 +0 -90 src/contrib/cpio/cpiohdr.h (dead) 1.1.1.1.40.1 +0 -43 src/contrib/cpio/defer.c (dead) 1.1.1.1.40.1 +0 -8 src/contrib/cpio/defer.h (dead) 1.1.1.1.40.1 +0 -70 src/contrib/cpio/dirname.c (dead) 1.2.2.1 +41 -0 src/contrib/cpio/doc/cpio.1 (new) 1.2.2.1 +563 -0 src/contrib/cpio/doc/cpio.texi (new) 1.1.1.1.40.1 +0 -114 src/contrib/cpio/dstring.c (dead) 1.1.1.1.40.1 +0 -49 src/contrib/cpio/dstring.h (dead) 1.1.1.1.40.1 +0 -130 src/contrib/cpio/error.c (dead) 1.2.40.2 +0 -199 src/contrib/cpio/extern.h (dead) 1.1.1.1.40.1 +0 -255 src/contrib/cpio/filemode.c (dead) 1.1.1.1.40.1 +0 -84 src/contrib/cpio/filetypes.h (dead) 1.1.1.1.40.2 +0 -197 src/contrib/cpio/global.c (dead) 1.1.1.1.40.1 +0 -210 src/contrib/cpio/idcache.c (dead) 1.1.1.1.2.1 +54 -0 src/contrib/cpio/lib/alloca_.h (new) 1.1.1.1.2.1 +25 -0 src/contrib/cpio/lib/argp-ba.c (new) 1.1.1.1.2.1 +31 -0 src/contrib/cpio/lib/argp-eexst.c (new) 1.1.1.1.2.1 +440 -0 src/contrib/cpio/lib/argp-fmtstream.c (new) 1.1.1.1.2.1 +309 -0 src/contrib/cpio/lib/argp-fmtstream.h (new) 1.1.1.1.2.1 +43 -0 src/contrib/cpio/lib/argp-fs-xinl.c (new) 1.1.1.1.2.1 +1884 -0 src/contrib/cpio/lib/argp-help.c (new) 1.1.1.1.2.1 +156 -0 src/contrib/cpio/lib/argp-namefrob.h (new) 1.1.1.1.2.1 +926 -0 src/contrib/cpio/lib/argp-parse.c (new) 1.1.1.1.2.1 +24 -0 src/contrib/cpio/lib/argp-pv.c (new) 1.1.1.1.2.1 +31 -0 src/contrib/cpio/lib/argp-pvh.c (new) 1.1.1.1.2.1 +43 -0 src/contrib/cpio/lib/argp-xinl.c (new) 1.2.2.1 +606 -0 src/contrib/cpio/lib/argp.h (new) 1.1.1.1.2.1 +79 -0 src/contrib/cpio/lib/basename.c (new) 1.1.1.1.2.1 +121 -0 src/contrib/cpio/lib/dirname.c (new) 1.1.1.1.2.1 +47 -0 src/contrib/cpio/lib/dirname.h (new) 1.1.1.1.2.1 +306 -0 src/contrib/cpio/lib/error.c (new) 1.1.1.1.2.1 +66 -0 src/contrib/cpio/lib/error.h (new) 1.1.1.1.2.1 +32 -0 src/contrib/cpio/lib/exit.h (new) 1.1.1.1.2.1 +27 -0 src/contrib/cpio/lib/exitfail.c (new) 1.1.1.1.2.1 +20 -0 src/contrib/cpio/lib/exitfail.h (new) 1.1.1.1.2.1 +83 -0 src/contrib/cpio/lib/full-write.c (new) 1.1.1.1.2.1 +35 -0 src/contrib/cpio/lib/full-write.h (new) 1.1.1.1.2.1 +1241 -0 src/contrib/cpio/lib/getopt.c (new) 1.1.1.1.2.1 +174 -0 src/contrib/cpio/lib/getopt1.c (new) 1.1.1.1.2.1 +227 -0 src/contrib/cpio/lib/getopt_.h (new) 1.1.1.1.2.1 +131 -0 src/contrib/cpio/lib/getopt_int.h (new) 1.1.1.1.2.1 +68 -0 src/contrib/cpio/lib/gettext.h (new) 1.1.1.1.2.1 +4 -0 src/contrib/cpio/lib/localedir.h (new) 1.1.1.1.2.1 +29 -0 src/contrib/cpio/lib/mempcpy.c (new) 1.1.1.1.2.1 +36 -0 src/contrib/cpio/lib/mempcpy.h (new) 1.1.1.1.2.1 +99 -0 src/contrib/cpio/lib/rmt.h (new) 1.1.1.1.2.1 +740 -0 src/contrib/cpio/lib/rtapelib.c (new) 1.1.1.1.2.1 +82 -0 src/contrib/cpio/lib/safe-read.c (new) 1.1.1.1.2.1 +25 -0 src/contrib/cpio/lib/safe-read.h (new) 1.1.1.1.2.1 +19 -0 src/contrib/cpio/lib/safe-write.c (new) 1.1.1.1.2.1 +25 -0 src/contrib/cpio/lib/safe-write.h (new) 1.1.1.1.2.1 +123 -0 src/contrib/cpio/lib/savedir.c (new) 1.1.1.1.2.1 +26 -0 src/contrib/cpio/lib/savedir.h (new) 1.1.1.1.2.1 +47 -0 src/contrib/cpio/lib/strcase.h (new) 1.1.1.1.2.1 +30 -0 src/contrib/cpio/lib/strchrnul.c (new) 1.1.1.1.2.1 +28 -0 src/contrib/cpio/lib/strchrnul.h (new) 1.1.1.1.2.1 +39 -0 src/contrib/cpio/lib/stripslash.c (new) 1.1.1.1.2.1 +55 -0 src/contrib/cpio/lib/strndup.c (new) 1.1.1.1.2.1 +30 -0 src/contrib/cpio/lib/strndup.h (new) 1.1.1.1.2.1 +48 -0 src/contrib/cpio/lib/strnlen.c (new) 1.1.1.1.2.1 +524 -0 src/contrib/cpio/lib/system.h (new) 1.1.1.1.2.1 +137 -0 src/contrib/cpio/lib/unlocked-io.h (new) 1.1.1.1.2.1 +45 -0 src/contrib/cpio/lib/xalloc-die.c (new) 1.1.1.1.2.1 +79 -0 src/contrib/cpio/lib/xalloc.h (new) 1.1.1.1.2.1 +229 -0 src/contrib/cpio/lib/xmalloc.c (new) 1.3.34.2 +0 -533 src/contrib/cpio/main.c (dead) 1.1.1.1.40.1 +0 -307 src/contrib/cpio/makepath.c (dead) 1.1.1.1.40.1 +0 -98 src/contrib/cpio/rmt.h (dead) 1.2.40.1 +0 -566 src/contrib/cpio/rtapelib.c (dead) 1.1.1.1.40.1 +0 -1 src/contrib/cpio/safe-stat.h (dead) 1.4.2.1 +1658 -0 src/contrib/cpio/src/copyin.c (new) 1.3.2.1 +958 -0 src/contrib/cpio/src/copyout.c (new) 1.4.2.1 +482 -0 src/contrib/cpio/src/copypass.c (new) 1.1.1.1.2.1 +69 -0 src/contrib/cpio/src/cpio.h (new) 1.1.1.1.2.1 +90 -0 src/contrib/cpio/src/cpiohdr.h (new) 1.1.1.1.2.1 +42 -0 src/contrib/cpio/src/defer.c (new) 1.1.1.1.2.1 +25 -0 src/contrib/cpio/src/defer.h (new) 1.1.1.1.2.1 +107 -0 src/contrib/cpio/src/dstring.c (new) 1.1.1.1.2.1 +49 -0 src/contrib/cpio/src/dstring.h (new) 1.2.2.1 +200 -0 src/contrib/cpio/src/extern.h (new) 1.1.1.1.2.1 +242 -0 src/contrib/cpio/src/filemode.c (new) 1.1.1.1.2.1 +84 -0 src/contrib/cpio/src/filetypes.h (new) 1.2.2.1 +203 -0 src/contrib/cpio/src/global.c (new) 1.1.1.1.2.1 +206 -0 src/contrib/cpio/src/idcache.c (new) 1.3.2.1 +772 -0 src/contrib/cpio/src/main.c (new) 1.1.1.1.2.1 +301 -0 src/contrib/cpio/src/makepath.c (new) 1.1.1.1.2.1 +1 -0 src/contrib/cpio/src/safe-stat.h (new) 1.2.2.1 +515 -0 src/contrib/cpio/src/tar.c (new) 1.1.1.1.2.1 +112 -0 src/contrib/cpio/src/tar.h (new) 1.1.1.1.2.1 +62 -0 src/contrib/cpio/src/tarhdr.h (new) 1.2.2.1 +259 -0 src/contrib/cpio/src/userspec.c (new) 1.2.2.1 +1249 -0 src/contrib/cpio/src/util.c (new) 1.1.1.1.40.1 +0 -43 src/contrib/cpio/stripslash.c (dead) 1.1.1.1.40.1 +0 -142 src/contrib/cpio/system.h (dead) 1.2.2.1 +0 -537 src/contrib/cpio/tar.c (dead) 1.1.1.1.40.1 +0 -112 src/contrib/cpio/tar.h (dead) 1.1.1.1.40.1 +0 -62 src/contrib/cpio/tarhdr.h (dead) 1.1.1.1.40.1 +0 -277 src/contrib/cpio/userspec.c (dead) 1.2.40.1 +0 -1343 src/contrib/cpio/util.c (dead) 1.1.1.1.40.1 +0 -2 src/contrib/cpio/version.c (dead) 1.1.1.1.40.1 +0 -103 src/contrib/cpio/xmalloc.c (dead) 1.1.1.1.40.1 +0 -36 src/contrib/cpio/xstrdup.c (dead) 1.9.8.1 +53 -14 src/gnu/usr.bin/cpio/Makefile 1.1.2.1 +475 -0 src/gnu/usr.bin/cpio/config.h (new) 1.3.34.1 +2 -2 src/gnu/usr.bin/cpio/doc/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 23 05:09:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D87E816A415; Mon, 23 Oct 2006 05:09:44 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95E5C43D46; Mon, 23 Oct 2006 05:09:44 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N59iWG044182; Mon, 23 Oct 2006 05:09:44 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N59iVq044181; Mon, 23 Oct 2006 05:09:44 GMT (envelope-from delphij) Message-Id: <200610230509.k9N59iVq044181@repoman.freebsd.org> From: Xin LI Date: Mon, 23 Oct 2006 05:09:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc pf.os X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 05:09:45 -0000 delphij 2006-10-23 05:09:44 UTC FreeBSD src repository Modified files: etc pf.os Log: Synchronize pf.os with OpenBSD. Obtained from: OpenBSD MFC After: 3 days Approved by: mlaier (maintainer) Revision Changes Path 1.4 +71 -27 src/etc/pf.os From owner-cvs-src@FreeBSD.ORG Mon Oct 23 05:27:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EC1016A407; Mon, 23 Oct 2006 05:27:32 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBA5B43D53; Mon, 23 Oct 2006 05:27:31 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N5RVe4047189; Mon, 23 Oct 2006 05:27:31 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N5RV8b047188; Mon, 23 Oct 2006 05:27:31 GMT (envelope-from alc) Message-Id: <200610230527.k9N5RV8b047188@repoman.freebsd.org> From: Alan Cox Date: Mon, 23 Oct 2006 05:27:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_glue.c vm_kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 05:27:32 -0000 alc 2006-10-23 05:27:31 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c vm_fault.c vm_glue.c vm_kern.c Log: The page queues lock is no longer required by vm_page_wakeup(). Revision Changes Path 1.284 +2 -2 src/sys/vm/swap_pager.c 1.222 +3 -3 src/sys/vm/vm_fault.c 1.216 +2 -2 src/sys/vm/vm_glue.c 1.123 +1 -1 src/sys/vm/vm_kern.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 06:46:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F67E16A403; Mon, 23 Oct 2006 06:46:36 +0000 (UTC) (envelope-from rink@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5727B43D46; Mon, 23 Oct 2006 06:46:35 +0000 (GMT) (envelope-from rink@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N6kZqw060623; Mon, 23 Oct 2006 06:46:35 GMT (envelope-from rink@repoman.freebsd.org) Received: (from rink@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N6kZxF060622; Mon, 23 Oct 2006 06:46:35 GMT (envelope-from rink) Message-Id: <200610230646.k9N6kZxF060622@repoman.freebsd.org> From: Rink Springer Date: Mon, 23 Oct 2006 06:46:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/mountd mountd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 06:46:36 -0000 rink 2006-10-23 06:46:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/mountd mountd.c Log: MFC revision 1.90, log: My previous commit made it impossible to export / over NFS; this small change fixes this. Reported by: Lin Jui-Nan Eric < ericlin dot jnlin at gmail dot com > Submitted by: Erik Trulsson < ertr1013 at student dot uu dot se > (commit is i nspired by a patch from Erik) Pointyhat to: me Reviewed by: stable@ Approved by: re (bmah), imp (mentor) Revision Changes Path 1.81.2.6 +6 -1 src/usr.sbin/mountd/mountd.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 06:55:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFA1E16A407; Mon, 23 Oct 2006 06:55:47 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62F5343D49; Mon, 23 Oct 2006 06:55:46 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id DB4825EEF; Mon, 23 Oct 2006 10:55:44 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id CFC035E9A; Mon, 23 Oct 2006 10:55:44 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k9N6trEr030994; Mon, 23 Oct 2006 10:55:53 +0400 (MSD) (envelope-from ru) Date: Mon, 23 Oct 2006 10:55:53 +0400 From: Ruslan Ermilov To: "Greg 'groggy' Lehey" Message-ID: <20061023065553.GA30956@rambler-co.ru> References: <200610200431.k9K4V2Qu037114@repoman.freebsd.org> <20061020193038.GA60387@rambler-co.ru> <453953F7.7000603@freebsd.org> <20061021050258.GA6215@turion.vk2pj.dyndns.org> <20061023002341.GB85586@wantadilla.lemis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20061023002341.GB85586@wantadilla.lemis.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: Peter Jeremy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Colin Percival , cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/jot jot.1 src/usr.bin/lam lam.1 src/usr.bin/rs rs.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 06:55:47 -0000 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 23, 2006 at 09:53:41AM +0930, Greg 'groggy' Lehey wrote: > On Saturday, 21 October 2006 at 15:02:58 +1000, Peter Jeremy wrote: > > On Fri, 2006-Oct-20 15:55:51 -0700, Colin Percival wrote: > >> Ruslan Ermilov wrote: > >>> On Fri, Oct 20, 2006 at 04:31:02AM +0000, Colin Percival wrote: > >>>> Document that jot(1), rs(1), and lam(1) first appeared in 4.2BSD. > >>>> > >>> What information this is based on? > >> > >> John Kunze's CV states that he "wrote three UNIX tools distributed with > >> 4.2/4.3BSD using this method (Master's Degree Project, 1983); these to= ols > >> ("jot", "rs", and "lam") are distributed in current Mac OS X systems". > > > > I've just looked thru the CSRG CDs and I can only find them in 4.4 and > > later. If they are in 4.2 or 4.3, they aren't obvious. >=20 > Colin's right (or lucky :-). I have files here, from the CSRG CD-ROM > set: >=20 > /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/jot.1 > /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/jot.c > /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/rs.1 > /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/rs.c > /src/BSD-CSRG/4.2/usr/src/new/new/tools/man/lam.1 > /src/BSD-CSRG/4.2/usr/src/new/new/tools/src/lam.c >=20 Thanks Greg! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --ibTvN161/egqYuK8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFPGd5qRfpzJluFF4RAnOyAKCSMq+iXTMf/N9OYZUoOSh2PnVSSQCeNypD Vyt8ibuaxFGHJKCj2e691FU= =sac/ -----END PGP SIGNATURE----- --ibTvN161/egqYuK8-- From owner-cvs-src@FreeBSD.ORG Mon Oct 23 07:25:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 561E716A412; Mon, 23 Oct 2006 07:25:26 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1230143D55; Mon, 23 Oct 2006 07:25:26 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N7PPdd067824; Mon, 23 Oct 2006 07:25:25 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N7PP2l067823; Mon, 23 Oct 2006 07:25:25 GMT (envelope-from kib) Message-Id: <200610230725.k9N7PP2l067823@repoman.freebsd.org> From: Konstantin Belousov Date: Mon, 23 Oct 2006 07:25:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdio xprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 07:25:26 -0000 kib 2006-10-23 07:25:25 UTC FreeBSD src repository Modified files: lib/libc/stdio xprintf.c Log: Revert the rev. 1.4, it causes breakage on most arches except i386. Remove the const qualifier from ap argument for __v2printf, that induced that breakage, and seems to be the real reason for bad code. ap is modified inside the __v2printf body by va_arg macro. Pointy hat to: kib Approved by: pjd (mentor) Revision Changes Path 1.5 +1 -4 src/lib/libc/stdio/xprintf.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 08:38:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5B0716A407; Mon, 23 Oct 2006 08:38:43 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7013743D55; Mon, 23 Oct 2006 08:38:43 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N8ch4E080681; Mon, 23 Oct 2006 08:38:43 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N8chXk080680; Mon, 23 Oct 2006 08:38:43 GMT (envelope-from des) Message-Id: <200610230838.k9N8chXk080680@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Mon, 23 Oct 2006 08:38:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 08:38:44 -0000 des 2006-10-23 08:38:42 UTC FreeBSD src repository Modified files: sys/conf NOTES Log: Re-add screen savers, which I removed by mistake. Noticed by: ru Revision Changes Path 1.1393 +13 -0 src/sys/conf/NOTES From owner-cvs-src@FreeBSD.ORG Mon Oct 23 09:45:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77BA416A40F; Mon, 23 Oct 2006 09:45:28 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24F7043D46; Mon, 23 Oct 2006 09:45:28 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9N9jNgT000897; Mon, 23 Oct 2006 09:45:28 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9N9jMFl000896; Mon, 23 Oct 2006 09:45:22 GMT (envelope-from ru) Message-Id: <200610230945.k9N9jMFl000896@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 23 Oct 2006 09:45:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pc98/conf NOTES src/sys/powerpc/conf NOTES src/sys/sparc64/conf NOTES src/sys/sun4v/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 09:45:28 -0000 ru 2006-10-23 09:45:22 UTC FreeBSD src repository Modified files: sys/pc98/conf NOTES sys/powerpc/conf NOTES sys/sparc64/conf NOTES sys/sun4v/conf NOTES Log: Mechanically kill redundant nodevice/nooption/nomakeoption, i.e., those that do not exist in MI NOTES or switched on/off in the MD NOTES. Revision Changes Path 1.83 +0 -1 src/sys/pc98/conf/NOTES 1.5 +0 -14 src/sys/powerpc/conf/NOTES 1.26 +0 -7 src/sys/sparc64/conf/NOTES 1.6 +0 -19 src/sys/sun4v/conf/NOTES From owner-cvs-src@FreeBSD.ORG Mon Oct 23 09:49:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE33216A407; Mon, 23 Oct 2006 09:49:52 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 335A543D53; Mon, 23 Oct 2006 09:49:51 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 401465D4C; Mon, 23 Oct 2006 13:49:50 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 1F77D5D0C; Mon, 23 Oct 2006 13:49:50 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k9N9nx0b052936; Mon, 23 Oct 2006 13:49:59 +0400 (MSD) (envelope-from ru) Date: Mon, 23 Oct 2006 13:49:59 +0400 From: Ruslan Ermilov To: Dag-Erling Smorgrav Message-ID: <20061023094959.GB48293@rambler-co.ru> References: <200610230838.k9N8chXk080680@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JP+T4n/bALQSJXh8" Content-Disposition: inline In-Reply-To: <200610230838.k9N8chXk080680@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 09:49:52 -0000 --JP+T4n/bALQSJXh8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 23, 2006 at 08:38:42AM +0000, Dag-Erling Smorgrav wrote: > des 2006-10-23 08:38:42 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/conf NOTES=20 > Log: > Re-add screen savers, which I removed by mistake. > =20 > Noticed by: ru > =20 > Revision Changes Path > 1.1393 +13 -0 src/sys/conf/NOTES >=20 I was hoping you'd move them to MD NOTES since screen savers require "device splash" which you moved to MD NOTES. This would also obviate the need in many "nodevice .*_saver" in MD NOTES. BTW, I used the following script to clean up MD NOTES from redundant no's: : #!/bin/sh :=20 : for kw in device option makeoption; do : egrep "no${kw}s?" NOTES | while read _ v; do : egrep -qw "^${kw}s?[[:space:]]+$v" NOTES && echo "no${kw} $v is switched= on/off" : egrep -qw "^${kw}s?[[:space:]]+$v" ../../conf/NOTES || echo "no${kw} $v = is redundant" : done : done Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --JP+T4n/bALQSJXh8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFPJBHqRfpzJluFF4RAh2hAJ4vDTRN8SCuDyXwlbQunh0ct4rRywCdFYTk CBwOVsKXq3HVGT6q/VtTr3s= =QB5K -----END PGP SIGNATURE----- --JP+T4n/bALQSJXh8-- From owner-cvs-src@FreeBSD.ORG Mon Oct 23 10:05:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81D4816A403; Mon, 23 Oct 2006 10:05:54 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6123D43D8A; Mon, 23 Oct 2006 10:05:36 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NA5aO2005338; Mon, 23 Oct 2006 10:05:36 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NA5a0h005337; Mon, 23 Oct 2006 10:05:36 GMT (envelope-from ru) Message-Id: <200610231005.k9NA5a0h005337@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 23 Oct 2006 10:05:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sparc64/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 10:05:54 -0000 ru 2006-10-23 10:05:36 UTC FreeBSD src repository Modified files: sys/sparc64/conf NOTES Log: Revision 1.25 had the ATKBD_DFLT_KEYMAP option turned on and then off: : # Options for atkbd: : options ATKBD_DFLT_KEYMAP # specify the built-in keymap : makeoptions ATKBD_DFLT_KEYMAP=jp.106 [...] : nooption ATKBD_DFLT_KEYMAP : nomakeoption ATKBD_DFLT_KEYMAP (Previously the option was inherited from MI NOTES.) So my tool in rev. 1.26 reduced this to removing all "ATKBD_DFLT_KEYMAP" lines, leaving the option effectively disabled as it was before, but since it's actually supported on sparc64, turn it on now. Revision Changes Path 1.27 +4 -0 src/sys/sparc64/conf/NOTES From owner-cvs-src@FreeBSD.ORG Mon Oct 23 10:48:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD84A16A415; Mon, 23 Oct 2006 10:48:20 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BE4843D58; Mon, 23 Oct 2006 10:48:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NAmKgS049330; Mon, 23 Oct 2006 10:48:20 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NAmKkV049308; Mon, 23 Oct 2006 10:48:20 GMT (envelope-from ru) Message-Id: <200610231048.k9NAmKkV049308@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 23 Oct 2006 10:48:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/adjkerntz adjkerntz.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 10:48:20 -0000 ru 2006-10-23 10:48:19 UTC FreeBSD src repository Modified files: sbin/adjkerntz adjkerntz.c Log: If not compiled for debugging, redirect standard input/output/error to /dev/null before becoming a daemon. Revision Changes Path 1.32 +7 -1 src/sbin/adjkerntz/adjkerntz.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 11:48:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 215EF16A4C8; Mon, 23 Oct 2006 11:48:05 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FE3A43D79; Mon, 23 Oct 2006 11:48:01 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 31F5E208C; Mon, 23 Oct 2006 13:47:57 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-25) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id A7D9F2089; Mon, 23 Oct 2006 13:47:56 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 98BC2B85E; Mon, 23 Oct 2006 13:47:56 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Ruslan Ermilov References: <200610230838.k9N8chXk080680@repoman.freebsd.org> <20061023094959.GB48293@rambler-co.ru> Date: Mon, 23 Oct 2006 13:47:56 +0200 In-Reply-To: <20061023094959.GB48293@rambler-co.ru> (Ruslan Ermilov's message of "Mon, 23 Oct 2006 13:49:59 +0400") Message-ID: <86r6wz5k43.fsf@dwp.des.no> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 11:48:05 -0000 Ruslan Ermilov writes: > On Mon, Oct 23, 2006 at 08:38:42AM +0000, Dag-Erling Smorgrav wrote: > > Log: > > Re-add screen savers, which I removed by mistake. > I was hoping you'd move them to MD NOTES since screen savers require > "device splash" which you moved to MD NOTES. This would also obviate > the need in many "nodevice .*_saver" in MD NOTES. they're still in MI files; feel free to move them from files to files.{i386,pc98,whatever} DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Oct 23 13:05:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A70EB16A415; Mon, 23 Oct 2006 13:05:02 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D836D43D5C; Mon, 23 Oct 2006 13:05:01 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ND51ch044815; Mon, 23 Oct 2006 13:05:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ND51qJ044796; Mon, 23 Oct 2006 13:05:01 GMT (envelope-from ru) Message-Id: <200610231305.k9ND51qJ044796@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 23 Oct 2006 13:05:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files files.amd64 files.i386 files.ia64 files.pc98 files.powerpc files.sparc64 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 13:05:02 -0000 ru 2006-10-23 13:05:01 UTC FreeBSD src repository Modified files: sys/conf files files.amd64 files.i386 files.ia64 files.pc98 files.powerpc files.sparc64 Log: Move MI parts of syscons into MI "files". Revision Changes Path 1.1154 +7 -0 src/sys/conf/files 1.96 +0 -7 src/sys/conf/files.amd64 1.568 +0 -7 src/sys/conf/files.i386 1.89 +0 -7 src/sys/conf/files.ia64 1.347 +0 -7 src/sys/conf/files.pc98 1.60 +0 -7 src/sys/conf/files.powerpc 1.81 +0 -7 src/sys/conf/files.sparc64 From owner-cvs-src@FreeBSD.ORG Mon Oct 23 15:48:46 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0701916A403; Mon, 23 Oct 2006 15:48:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0307243D46; Mon, 23 Oct 2006 15:48:44 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9NFmWgj001019; Mon, 23 Oct 2006 11:48:35 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Mon, 23 Oct 2006 11:33:29 -0400 User-Agent: KMail/1.9.1 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> In-Reply-To: <200610212359.k9LNxF2P014387@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610231133.29990.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 23 Oct 2006 11:48:35 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2081/Mon Oct 23 09:43:22 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 15:48:46 -0000 On Saturday 21 October 2006 19:59, David Xu wrote: > davidxu 2006-10-21 23:59:15 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_exit.c > Log: > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > opened a race window which can cause memory leak in signal queue. > Here we free memory for signal queue when process state is set to > PRS_ZOMBIE. Is there any reason to not just harvest it in wait() instead? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Oct 23 15:48:54 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADE6516A529; Mon, 23 Oct 2006 15:48:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 199AA43D53; Mon, 23 Oct 2006 15:48:52 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9NFmWgk001019; Mon, 23 Oct 2006 11:48:43 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Mon, 23 Oct 2006 11:45:47 -0400 User-Agent: KMail/1.9.1 References: <200610201619.k9KGJLZH076566@repoman.freebsd.org> <200610210858.04180.davidxu@freebsd.org> In-Reply-To: <200610210858.04180.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610231145.48005.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 23 Oct 2006 11:48:44 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2081/Mon Oct 23 09:43:22 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 15:48:54 -0000 On Friday 20 October 2006 20:58, David Xu wrote: > On Saturday 21 October 2006 00:19, John Baldwin wrote: > > jhb 2006-10-20 16:19:21 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_sig.c > > Log: > > Remove the check that prevented signals from being delivered to exiting > > processes. It was originally added back when support for Linux threads > > (and thus shared sigacts objects) was added, but no one knows why. My > > guess is that at some point during the Linux threads patches, the sigacts > > object was torn down during exit1(), so this check was added to prevent > > a panic for that race. However, the stuff that was actually committed to > > the tree doesn't teardown sigacts until wait() making the above race > > moot. Re-allowing signals here lets one interrupt a NFS request during > > process teardown (such as closing descriptors) on an interruptible mount. > > > > Requested by: kib (long time ago) > > MFC after: 1 week > > > > Revision Changes Path > > 1.333 +1 -3 src/sys/kern/kern_sig.c > This commit opens a window that may cause memory leak, since we have > signal queue in -CURRENT now, signal queue uses memory, before this > change, the P_WEXIT will prevents new signal to be queued, after the > flag is set in kern_exit, we call signqueue_flush to free memory. I think > we should move sigqueue_flush down to a safe point where the > PROC lock is no longer unlocked or move it to a place after p_state is set > to PRS_ZOMBIE. Or just free it during wait() when most other things about a process are freed (sigacts, limits, etc.). -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Oct 23 15:49:10 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49B8B16A707; Mon, 23 Oct 2006 15:49:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41F4743D55; Mon, 23 Oct 2006 15:48:59 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9NFmWgl001019; Mon, 23 Oct 2006 11:48:51 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Mon, 23 Oct 2006 11:48:34 -0400 User-Agent: KMail/1.9.1 References: <200610220014.k9M0E5mG061752@gw.catspoiler.org> <200610221354.57273.davidxu@freebsd.org> In-Reply-To: <200610221354.57273.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610231148.35326.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 23 Oct 2006 11:48:52 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2081/Mon Oct 23 09:43:22 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Don Lewis , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 15:49:10 -0000 On Sunday 22 October 2006 01:54, David Xu wrote: > On Sunday 22 October 2006 08:14, Don Lewis wrote: > > On 21 Oct, David Xu wrote: > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_exit.c > > > Log: > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > > opened a race window which can cause memory leak in signal queue. > > > Here we free memory for signal queue when process state is set to > > > PRS_ZOMBIE. > > > > > > Revision Changes Path > > > 1.291 +8 -2 src/sys/kern/kern_exit.c > > > > I wonder if the earlier change is what broke portupgrade after I > > upgraded from an August 31st version of current to yesterday's version. > > The symptoms were random processes dying from SIGHUP. It was easy to > > reproduce by just going to a port directory and running > > script foo make clean > > a few times. I'd randomly see make complain about a non-zero exit > > status from uname or some other sub-process. I tracked the problem back > > to the SIGHUP bit being set in td2's sigqueue in fork1(). As a > > workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. > > > > Disappearing back into the void ... > > But I am still worrried by these signal changes, if an exiting process > can be sent a signal, and msleep will interrupted in cleanup code, where the > code will return to ? in normal case, code will return to userland, and > signal will be removed and delivered, but if a thread is in exit1(), where > the code can be returned to ? if a cleanup procedure is interrupted, isn't > there is any resource leak or dead-loop if it is retried because signal is > never removed ? It will return to the exit1() function. :) If a process has W_EXIT set and is asleep in msleep() with PCATCH, it called msleep() from exit1() or some other number of functions in between the two. Note that this was the behavior of FreeBSD prior to the Linux threads stuff (and BSD). -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Oct 23 20:07:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0270C16A407; Mon, 23 Oct 2006 20:07:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A61643D8F; Mon, 23 Oct 2006 20:07:46 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NK7kPL018355; Mon, 23 Oct 2006 20:07:46 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NK7kkh018348; Mon, 23 Oct 2006 20:07:46 GMT (envelope-from jhb) Message-Id: <200610232007.k9NK7kkh018348@repoman.freebsd.org> From: John Baldwin Date: Mon, 23 Oct 2006 20:07:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc_r/uthread uthread_select.c uthread_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 20:07:56 -0000 jhb 2006-10-23 20:07:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc_r/uthread uthread_select.c uthread_sig.c Log: MFC: Various uthread fixes: - Delay setting wakeup time until after poll array has been allocated. Blocking on the malloc spinlock would cause the select timeout to be lost. (uthread_select.c 1.22) - Delay unblocking signal and restoring process signal mask until the thread signal mask has been updated to avoid stack overflow during signal bursts. Don't block signal forever if no threads can currently handle signal. Check for pending signal after direct invocation of signal handler. (uthread_select.c 1.47) - Backout unblocking of signal if no threads can currently handle it. The check for pending signal after direct invocation of signal handler is sufficient. (uthread_select.c 1.48) Approved by: re (mux, bmah) Revision Changes Path 1.21.14.1 +20 -20 src/lib/libc_r/uthread/uthread_select.c 1.46.10.1 +38 -17 src/lib/libc_r/uthread/uthread_sig.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 20:11:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5210416A4A0; Mon, 23 Oct 2006 20:11:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EECB43DC7; Mon, 23 Oct 2006 20:11:32 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NKBWRE049644; Mon, 23 Oct 2006 20:11:32 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NKBWHB049631; Mon, 23 Oct 2006 20:11:32 GMT (envelope-from jhb) Message-Id: <200610232011.k9NKBWHB049631@repoman.freebsd.org> From: John Baldwin Date: Mon, 23 Oct 2006 20:11:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/lib/libc_r/uthread uthread_select.c uthread_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 20:11:39 -0000 jhb 2006-10-23 20:11:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libc_r/uthread uthread_select.c uthread_sig.c Log: MFC: uthread fixes for select timeout and signal handling. Revision Changes Path 1.16.2.6 +20 -20 src/lib/libc_r/uthread/uthread_select.c 1.25.2.14 +38 -17 src/lib/libc_r/uthread/uthread_sig.c From owner-cvs-src@FreeBSD.ORG Mon Oct 23 20:49:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 343A716A412; Mon, 23 Oct 2006 20:49:50 +0000 (UTC) (envelope-from erwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B100D43D6B; Mon, 23 Oct 2006 20:49:49 +0000 (GMT) (envelope-from erwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NKnnm6066975; Mon, 23 Oct 2006 20:49:49 GMT (envelope-from erwin@repoman.freebsd.org) Received: (from erwin@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NKnna1066959; Mon, 23 Oct 2006 20:49:49 GMT (envelope-from erwin) Message-Id: <200610232049.k9NKnna1066959@repoman.freebsd.org> From: Erwin Lansing Date: Mon, 23 Oct 2006 20:49:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall dist.c install.c sysinstall.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 20:49:50 -0000 erwin 2006-10-23 20:49:49 UTC FreeBSD src repository (ports committer) Modified files: usr.sbin/sysinstall dist.c install.c sysinstall.h Log: If the user did not chose a distribution from the menu, a sensible default distribution (user) will be installed, however, no kernel will be installed. Fix this by installing a sensible default kernel, SMP/GENERIC, depending on WITH_SMP and number of CPUS found. Reviewed by: jhb Revision Changes Path 1.245 +1 -1 src/usr.sbin/sysinstall/dist.c 1.370 +2 -0 src/usr.sbin/sysinstall/install.c 1.273 +1 -0 src/usr.sbin/sysinstall/sysinstall.h From owner-cvs-src@FreeBSD.ORG Mon Oct 23 20:59:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43A5F16A403; Mon, 23 Oct 2006 20:59:28 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0197243D5D; Mon, 23 Oct 2006 20:59:28 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9NKxRgF045258; Mon, 23 Oct 2006 20:59:27 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9NKxRU8045227; Mon, 23 Oct 2006 20:59:27 GMT (envelope-from ceri) Message-Id: <200610232059.k9NKxRU8045227@repoman.freebsd.org> From: Ceri Davies Date: Mon, 23 Oct 2006 20:59:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/gnu/usr.bin/send-pr send-pr.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 20:59:28 -0000 ceri 2006-10-23 20:59:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/send-pr send-pr.1 Log: MFC revision 1.20: Update the FILES section which has been wrong for some time. Approved by: re (hrs) Revision Changes Path 1.18.2.2 +6 -4 src/gnu/usr.bin/send-pr/send-pr.1 From owner-cvs-src@FreeBSD.ORG Mon Oct 23 22:47:06 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 3B45D16A403; Mon, 23 Oct 2006 22:47:06 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: John Baldwin Date: Tue, 24 Oct 2006 06:47:03 +0800 User-Agent: KMail/1.8.2 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610231133.29990.jhb@freebsd.org> In-Reply-To: <200610231133.29990.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610240647.03765.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2006 22:47:06 -0000 On Monday 23 October 2006 23:33, John Baldwin wrote: > On Saturday 21 October 2006 19:59, David Xu wrote: > > davidxu 2006-10-21 23:59:15 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_exit.c > > Log: > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > opened a race window which can cause memory leak in signal queue. > > Here we free memory for signal queue when process state is set to > > PRS_ZOMBIE. > > Is there any reason to not just harvest it in wait() instead? I prefer to free it earlier rather than delaying it if I can. From owner-cvs-src@FreeBSD.ORG Tue Oct 24 00:02:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56E1E16A40F; Tue, 24 Oct 2006 00:02:24 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0CBEA43D5E; Tue, 24 Oct 2006 00:02:24 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O02Ncs035487; Tue, 24 Oct 2006 00:02:23 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O02Nj2035453; Tue, 24 Oct 2006 00:02:23 GMT (envelope-from imp) Message-Id: <200610240002.k9O02Nj2035453@repoman.freebsd.org> From: Warner Losh Date: Tue, 24 Oct 2006 00:02:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/config config.y X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 00:02:24 -0000 imp 2006-10-24 00:02:23 UTC FreeBSD src repository Modified files: usr.sbin/config config.y Log: Since multiple hints lines do not work, make doing that a fatal error. Revision Changes Path 1.74 +3 -0 src/usr.sbin/config/config.y From owner-cvs-src@FreeBSD.ORG Tue Oct 24 00:07:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B60A816A403; Tue, 24 Oct 2006 00:07:50 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F0AD43D7F; Tue, 24 Oct 2006 00:07:40 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O07eLP078285; Tue, 24 Oct 2006 00:07:40 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O07eTm078269; Tue, 24 Oct 2006 00:07:40 GMT (envelope-from imp) Message-Id: <200610240007.k9O07eTm078269@repoman.freebsd.org> From: Warner Losh Date: Tue, 24 Oct 2006 00:07:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/config config.y X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 00:07:50 -0000 imp 2006-10-24 00:07:39 UTC FreeBSD src repository Modified files: usr.sbin/config config.y Log: style(9) pedantry Revision Changes Path 1.75 +7 -7 src/usr.sbin/config/config.y From owner-cvs-src@FreeBSD.ORG Tue Oct 24 00:32:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C777016A403; Tue, 24 Oct 2006 00:32:00 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D3F243D49; Tue, 24 Oct 2006 00:32:00 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O0W0R0072856; Tue, 24 Oct 2006 00:32:00 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O0W0Ob072783; Tue, 24 Oct 2006 00:32:00 GMT (envelope-from imp) Message-Id: <200610240032.k9O0W0Ob072783@repoman.freebsd.org> From: Warner Losh Date: Tue, 24 Oct 2006 00:31:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/config config.h config.y main.c mkmakefile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 00:32:00 -0000 imp 2006-10-24 00:31:59 UTC FreeBSD src repository Modified files: usr.sbin/config config.h config.y main.c mkmakefile.c Log: End my resistance to jmg's multiple hints files and bring in support for having multiple hints files generate a correct hints.c (eg, with all the specified ones catenated together). Revision Changes Path 1.60 +7 -1 src/usr.sbin/config/config.h 1.76 +5 -5 src/usr.sbin/config/config.y 1.73 +1 -0 src/usr.sbin/config/main.c 1.90 +6 -9 src/usr.sbin/config/mkmakefile.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 00:44:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5174816A403; Tue, 24 Oct 2006 00:44:41 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1045143D4C; Tue, 24 Oct 2006 00:44:41 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O0ie3e074597; Tue, 24 Oct 2006 00:44:40 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O0ieJI074581; Tue, 24 Oct 2006 00:44:40 GMT (envelope-from imp) Message-Id: <200610240044.k9O0ieJI074581@repoman.freebsd.org> From: Warner Losh Date: Tue, 24 Oct 2006 00:44:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/config config.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 00:44:41 -0000 imp 2006-10-24 00:44:40 UTC FreeBSD src repository Modified files: usr.sbin/config config.5 Log: Document multiple hints lines. Tweak machine description to more accurately reflect second argument being the cpu architecture. Note correspondence with MACHINE and MACHINE_ARCH. Revision Changes Path 1.10 +18 -4 src/usr.sbin/config/config.5 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 07:12:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2B5D16A403; Tue, 24 Oct 2006 07:12:31 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9175E43D49; Tue, 24 Oct 2006 07:12:31 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O7CV4k022956; Tue, 24 Oct 2006 07:12:31 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O7CVdo022950; Tue, 24 Oct 2006 07:12:31 GMT (envelope-from imp) Message-Id: <200610240712.k9O7CVdo022950@repoman.freebsd.org> From: Warner Losh Date: Tue, 24 Oct 2006 07:12:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/config mkmakefile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 07:12:31 -0000 imp 2006-10-24 07:12:31 UTC FreeBSD src repository Modified files: usr.sbin/config mkmakefile.c Log: Don't leak files. This also eliminates the need for ifp init. Submitted by: ru@ Revision Changes Path 1.91 +2 -3 src/usr.sbin/config/mkmakefile.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 08:18:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3167416A4C9; Tue, 24 Oct 2006 08:18:28 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0458743D96; Tue, 24 Oct 2006 08:18:20 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O8IARt022317; Tue, 24 Oct 2006 08:18:10 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O8IATH022313; Tue, 24 Oct 2006 08:18:10 GMT (envelope-from sobomax) Message-Id: <200610240818.k9O8IATH022313@repoman.freebsd.org> From: Maxim Sobolev Date: Tue, 24 Oct 2006 08:18:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 08:18:28 -0000 sobomax 2006-10-24 08:18:10 UTC FreeBSD src repository Modified files: usr.bin/su su.c Log: Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke su on system that don't have audit framefork compiled into kernel or ia32 binary on amd64 system will result in SIGSYS. There is one place in su.c itself where it tries to check for errno != ENOSYS, but it has been a nop since su does not catch SIGSYS anyway. There are few other places in libbsm, where attempt to invoke audit syscal would result in SIGSYS if no audit support is present in the kernel, so that the only reliable method for now is to disable SIGSYS completely in the case when BSM is compiled in. In the long run, both direct invocation of audit-related syscalls and libbsm should be made more intellegent to handle the case when BSM is not compiled into the kernel gracefully. MFC after: 3 days (provided re@ approval) Revision Changes Path 1.82 +2 -0 src/usr.bin/su/su.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 08:24:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D47416A4F5; Tue, 24 Oct 2006 08:24:32 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0F6D43D55; Tue, 24 Oct 2006 08:24:31 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O8OVDN070072; Tue, 24 Oct 2006 08:24:31 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O8OV2k070068; Tue, 24 Oct 2006 08:24:31 GMT (envelope-from scottl) Message-Id: <200610240824.k9O8OV2k070068@repoman.freebsd.org> From: Scott Long Date: Tue, 24 Oct 2006 08:24:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bce if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 08:24:32 -0000 scottl 2006-10-24 08:24:31 UTC FreeBSD src repository Modified files: sys/dev/bce if_bcereg.h Log: Refine the checksum hack a little. It appears that the chip can handle UDP and TCP checksum offloading fine, it only has a problem with IP checksums on IP fragments.. Barring a fix or workaround available from the hardware, the real solution would be to have finer grained control in the stack over what can and cannot be assisted in hardware. Revision Changes Path 1.9 +7 -3 src/sys/dev/bce/if_bcereg.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 08:47:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0058E16A40F; Tue, 24 Oct 2006 08:47:40 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A10C143D5E; Tue, 24 Oct 2006 08:47:40 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O8leVG035441; Tue, 24 Oct 2006 08:47:40 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O8le9I035409; Tue, 24 Oct 2006 08:47:40 GMT (envelope-from thompsa) Message-Id: <200610240847.k9O8le9I035409@repoman.freebsd.org> From: Andrew Thompson Date: Tue, 24 Oct 2006 08:47:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 if_bridge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 08:47:41 -0000 thompsa 2006-10-24 08:47:40 UTC FreeBSD src repository Modified files: share/man/man4 if_bridge.4 Log: Document net.link.bridge.ipfw_arp for filtering ARP packets with ipfw. MFC after: 3 days Revision Changes Path 1.25 +11 -0 src/share/man/man4/if_bridge.4 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 08:48:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E44A16A519; Tue, 24 Oct 2006 08:48:01 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3230143D53; Tue, 24 Oct 2006 08:47:53 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id F2A705F9C; Tue, 24 Oct 2006 12:47:51 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id D02265FA9; Tue, 24 Oct 2006 12:47:51 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k9O8lr2Q065260; Tue, 24 Oct 2006 12:47:53 +0400 (MSD) (envelope-from ru) Date: Tue, 24 Oct 2006 12:47:53 +0400 From: Ruslan Ermilov To: Maxim Sobolev Message-ID: <20061024084753.GA65029@rambler-co.ru> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <200610240818.k9O8IATH022313@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Robert Watson , cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 08:48:01 -0000 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 24, 2006 at 08:18:10AM +0000, Maxim Sobolev wrote: > sobomax 2006-10-24 08:18:10 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.bin/su su.c=20 > Log: > Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke su = on > system that don't have audit framefork compiled into kernel or ia32 bin= ary > on amd64 system will result in SIGSYS. There is one place in su.c itself > where it tries to check for errno !=3D ENOSYS, but it has been a nop si= nce su > does not catch SIGSYS anyway. There are few other places in libbsm, > where attempt to invoke audit syscal would result in SIGSYS if no audit > support is present in the kernel, so that the only reliable method for > now is to disable SIGSYS completely in the case when BSM is compiled in. > =20 > In the long run, both direct invocation of audit-related syscalls and > libbsm should be made more intellegent to handle the case when BSM is n= ot > compiled into the kernel gracefully. > =20 > MFC after: 3 days > (provided re@ approval) > =20 > Revision Changes Path > 1.82 +2 -0 src/usr.bin/su/su.c >=20 I don't have "options AUDIT" compiled into my amd64/i386 kernels, and "truss su" shows this (on amd64): : geteuid() =3D 0 (0x0) : getauid(0x7fffffffe4fc) ERR#78 'Function not imp= lemented' The audit_syscalls.c is always compiled in: : # grep audit_syscalls /sys/conf/files : security/audit/audit_syscalls.c standard And in the "#else /* !AUDIT *" case, it just returns ENOSYS: : int : getauid(struct thread *td, struct getauid_args *uap) : { :=20 : return (ENOSYS); : } How that could result in SIGSYS, I don't get it? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --jI8keyz6grp/JLjh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFPdM5qRfpzJluFF4RAkncAKCU0bf8uZGwxXnomefaiF+gtv0ubACfff/G VKNsre53Wp4HSBfJe23Zihc= =MCC4 -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:10:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF5D616A403; Tue, 24 Oct 2006 09:10:10 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A6E843D5A; Tue, 24 Oct 2006 09:10:10 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id BF02946CFE; Tue, 24 Oct 2006 05:10:08 -0400 (EDT) Date: Tue, 24 Oct 2006 10:10:08 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <200610240818.k9O8IATH022313@repoman.freebsd.org> Message-ID: <20061024094643.N37455@fledge.watson.org> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:10:11 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: > sobomax 2006-10-24 08:18:10 UTC > > FreeBSD src repository > > Modified files: > usr.bin/su su.c > Log: > Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke su on > system that don't have audit framefork compiled into kernel or ia32 binary > on amd64 system will result in SIGSYS. There is one place in su.c itself > where it tries to check for errno != ENOSYS, but it has been a nop since su > does not catch SIGSYS anyway. There are few other places in libbsm, > where attempt to invoke audit syscal would result in SIGSYS if no audit > support is present in the kernel, so that the only reliable method for > now is to disable SIGSYS completely in the case when BSM is compiled in. > > In the long run, both direct invocation of audit-related syscalls and > libbsm should be made more intellegent to handle the case when BSM is not > compiled into the kernel gracefully. > > MFC after: 3 days > (provided re@ approval) I have to admit being a bit puzzled by your commit. Since you didn't bother to contact me with a bug report before committing this presumed fix, I can only assume that you are entirely certain that what you're describing is the case. However, since it appears not to be the case on thousands of deployed HEAD and RELENG_6 machines, I have to wonder whether you're hitting an edge case that needs further debugging and discussion. Alternatively, you booted a really old kernel with a relatively new user space. And by really old, I mean RELENG_6 in March of this year, or HEAD in February. How did you manage to log in, as login(1) also invokes the same system calls unconditionally that su(1) calls? Returning ENOSYS from a system call stub should not (and in my experience, does not) generate SIGSYS. There are three common cases for unimplemented system calls: (1) The kernel doesn't recognize the system call. Return ENOSYS + SIGSYS. If a binary handles SIGSYS, it gets the ENOSYS return, otherwise, it exits. This occurs if the system call isn't listed in the system call table, or if it's listed but unimplemented. This is what happens if you invoke a random system call number, or a new system call on a really old kernel. (2) The kernel recognizes, but does not implement the system call, and the system call is one where error handling is possible. This occurs when a system call stub function returns ENOSYS. For example, the audit code contains conditionally compiled system call code that returns ENOSYS if AUDIT isn't in the kernel. This also occurs when compatibility stubs are inserted to allow forward compatibility. (3) The kernel recognizes and implements the system call, but the underlying object doesn't implement the call. Return EOPNOTSUPP, ENOTSUP, EINVAL, etc. Typical examples are VFS system calls where the file system doesn't implement the operation, such as extended attributes, hard links, etc. The audit subsystem uses the second approach so that userland binaries can detect that audit is not available and handle it properly (typically by not configuring audit and generating audit events). Notice that we merged audit system call stubs to RELENG_6 for 6.1-RELEASE so that the upgrade path to an audit-enabled userland in 6.2-RELEASE would be un-bumpy if the user didn't properly follow proper upgrade instructions (kernel before user space). So: could you confirm that what you're observing is happening and provide specific specific debugging information? For example, your commit message hand-waves at 32-bit binaries on amd64 -- perhaps there is a bug in the handling of ENOSYS in the compat/freebsd32 system call path. A casual reading of the system call code suggests that this is not the case, but I don't think this is a case I have specifically tested. If you're running a very old kernel (pre-February/March) with a new user space, understand that that is not a supported configuration that will break for other more subtle reasons, and please back out this commit. Thanks, Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:28:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9946616A407; Tue, 24 Oct 2006 09:28:06 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1050543D5E; Tue, 24 Oct 2006 09:28:05 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9O9S1Ct020250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 02:28:03 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453DDC66.9020501@FreeBSD.org> Date: Tue, 24 Oct 2006 02:27:02 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Ruslan Ermilov References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024084753.GA65029@rambler-co.ru> In-Reply-To: <20061024084753.GA65029@rambler-co.ru> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:28:06 -0000 I am trying to run ia32 su(8) binary on amd64 kernel. -Maxim Ruslan Ermilov wrote: > On Tue, Oct 24, 2006 at 08:18:10AM +0000, Maxim Sobolev wrote: >> sobomax 2006-10-24 08:18:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/su su.c >> Log: >> Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke su on >> system that don't have audit framefork compiled into kernel or ia32 binary >> on amd64 system will result in SIGSYS. There is one place in su.c itself >> where it tries to check for errno != ENOSYS, but it has been a nop since su >> does not catch SIGSYS anyway. There are few other places in libbsm, >> where attempt to invoke audit syscal would result in SIGSYS if no audit >> support is present in the kernel, so that the only reliable method for >> now is to disable SIGSYS completely in the case when BSM is compiled in. >> >> In the long run, both direct invocation of audit-related syscalls and >> libbsm should be made more intellegent to handle the case when BSM is not >> compiled into the kernel gracefully. >> >> MFC after: 3 days >> (provided re@ approval) >> >> Revision Changes Path >> 1.82 +2 -0 src/usr.bin/su/su.c >> > I don't have "options AUDIT" compiled into my amd64/i386 kernels, and > "truss su" shows this (on amd64): > > : geteuid() = 0 (0x0) > : getauid(0x7fffffffe4fc) ERR#78 'Function not implemented' > > The audit_syscalls.c is always compiled in: > > : # grep audit_syscalls /sys/conf/files > : security/audit/audit_syscalls.c standard > > And in the "#else /* !AUDIT *" case, it just returns ENOSYS: > > : int > : getauid(struct thread *td, struct getauid_args *uap) > : { > : > : return (ENOSYS); > : } > > How that could result in SIGSYS, I don't get it? > > > Cheers, From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:38:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42FE416A415; Tue, 24 Oct 2006 09:38:29 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id A035743D7C; Tue, 24 Oct 2006 09:38:26 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9O9cNwm020459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 02:38:24 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453DDED4.3070208@FreeBSD.org> Date: Tue, 24 Oct 2006 02:37:24 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Robert Watson References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> In-Reply-To: <20061024094643.N37455@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:38:29 -0000 OK, in this particular case I am trying to run su(8) binary compiled for FreeBSD/ia32 on FreeBSD/amd64 system (FreeBSD 6.2 but this doesn't really make any difference since the code is the same). Since all audit syscalls in freebsd32 emulation layer are redirected to nosys() any attempt to invoke such syscall results in both ENOSYS errno *and* SIGSYS signal delivered to the process in question. The latter kills the process without giving it any chance to handle ENOSYS. -Maxim Robert Watson wrote: > > On Tue, 24 Oct 2006, Maxim Sobolev wrote: > >> sobomax 2006-10-24 08:18:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/su su.c >> Log: >> Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke >> su on >> system that don't have audit framefork compiled into kernel or ia32 >> binary >> on amd64 system will result in SIGSYS. There is one place in su.c itself >> where it tries to check for errno != ENOSYS, but it has been a nop >> since su >> does not catch SIGSYS anyway. There are few other places in libbsm, >> where attempt to invoke audit syscal would result in SIGSYS if no audit >> support is present in the kernel, so that the only reliable method for >> now is to disable SIGSYS completely in the case when BSM is compiled in. >> >> In the long run, both direct invocation of audit-related syscalls and >> libbsm should be made more intellegent to handle the case when BSM is >> not >> compiled into the kernel gracefully. >> >> MFC after: 3 days >> (provided re@ approval) > > I have to admit being a bit puzzled by your commit. Since you didn't > bother to contact me with a bug report before committing this presumed > fix, I can only assume that you are entirely certain that what you're > describing is the case. However, since it appears not to be the case on > thousands of deployed HEAD and RELENG_6 machines, I have to wonder > whether you're hitting an edge case that needs further debugging and > discussion. > > Alternatively, you booted a really old kernel with a relatively new user > space. And by really old, I mean RELENG_6 in March of this year, or > HEAD in February. How did you manage to log in, as login(1) also > invokes the same system calls unconditionally that su(1) calls? > Returning ENOSYS from a system call stub should not (and in my > experience, does not) generate SIGSYS. There are three common cases for > unimplemented system calls: > > (1) The kernel doesn't recognize the system call. Return ENOSYS + > SIGSYS. If > a binary handles SIGSYS, it gets the ENOSYS return, otherwise, it > exits. > This occurs if the system call isn't listed in the system call > table, or > if it's listed but unimplemented. This is what happens if you invoke a > random system call number, or a new system call on a really old kernel. > > (2) The kernel recognizes, but does not implement the system call, and the > system call is one where error handling is possible. This occurs > when a > system call stub function returns ENOSYS. For example, the audit code > contains conditionally compiled system call code that returns ENOSYS if > AUDIT isn't in the kernel. This also occurs when compatibility > stubs are > inserted to allow forward compatibility. > > (3) The kernel recognizes and implements the system call, but the > underlying > object doesn't implement the call. Return EOPNOTSUPP, ENOTSUP, EINVAL, > etc. Typical examples are VFS system calls where the file system > doesn't > implement the operation, such as extended attributes, hard links, etc. > > The audit subsystem uses the second approach so that userland binaries > can detect that audit is not available and handle it properly (typically > by not configuring audit and generating audit events). Notice that we > merged audit system call stubs to RELENG_6 for 6.1-RELEASE so that the > upgrade path to an audit-enabled userland in 6.2-RELEASE would be > un-bumpy if the user didn't properly follow proper upgrade instructions > (kernel before user space). > > So: could you confirm that what you're observing is happening and > provide specific specific debugging information? For example, your > commit message hand-waves at 32-bit binaries on amd64 -- perhaps there > is a bug in the handling of ENOSYS in the compat/freebsd32 system call > path. A casual reading of the system call code suggests that this is > not the case, but I don't think this is a case I have specifically > tested. If you're running a very old kernel (pre-February/March) with a > new user space, understand that that is not a supported configuration > that will break for other more subtle reasons, and please back out this > commit. > > Thanks, > > Robert N M Watson > Computer Laboratory > University of Cambridge > > From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:45:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49B1B16A416; Tue, 24 Oct 2006 09:45:53 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD15443D55; Tue, 24 Oct 2006 09:45:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 23FB946BD5; Tue, 24 Oct 2006 05:45:52 -0400 (EDT) Date: Tue, 24 Oct 2006 10:45:52 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <453DDED4.3070208@FreeBSD.org> Message-ID: <20061024104143.Y37455@fledge.watson.org> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:45:53 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: > OK, in this particular case I am trying to run su(8) binary compiled for > FreeBSD/ia32 on FreeBSD/amd64 system (FreeBSD 6.2 but this doesn't really > make any difference since the code is the same). > > Since all audit syscalls in freebsd32 emulation layer are redirected to > nosys() any attempt to invoke such syscall results in both ENOSYS errno > *and* SIGSYS signal delivered to the process in question. The latter kills > the process without giving it any chance to handle ENOSYS. So the actual bug here is that there's no compat32 definitions for the audit system calls. I have a suspicion that we may need compat32 wrappers in some cases, but you could start by simply exposing the audit system calls in compat32 by changing UNIMPL to STD (or MSTD in RELENG_6)? Robert N M Watson Computer Laboratory University of Cambridge > > -Maxim > > Robert Watson wrote: >> >> On Tue, 24 Oct 2006, Maxim Sobolev wrote: >> >>> sobomax 2006-10-24 08:18:10 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> usr.bin/su su.c >>> Log: >>> Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke su on >>> system that don't have audit framefork compiled into kernel or ia32 >>> binary >>> on amd64 system will result in SIGSYS. There is one place in su.c itself >>> where it tries to check for errno != ENOSYS, but it has been a nop since >>> su >>> does not catch SIGSYS anyway. There are few other places in libbsm, >>> where attempt to invoke audit syscal would result in SIGSYS if no audit >>> support is present in the kernel, so that the only reliable method for >>> now is to disable SIGSYS completely in the case when BSM is compiled in. >>> >>> In the long run, both direct invocation of audit-related syscalls and >>> libbsm should be made more intellegent to handle the case when BSM is not >>> compiled into the kernel gracefully. >>> >>> MFC after: 3 days >>> (provided re@ approval) >> >> I have to admit being a bit puzzled by your commit. Since you didn't >> bother to contact me with a bug report before committing this presumed fix, >> I can only assume that you are entirely certain that what you're describing >> is the case. However, since it appears not to be the case on thousands of >> deployed HEAD and RELENG_6 machines, I have to wonder whether you're >> hitting an edge case that needs further debugging and discussion. >> >> Alternatively, you booted a really old kernel with a relatively new user >> space. And by really old, I mean RELENG_6 in March of this year, or HEAD >> in February. How did you manage to log in, as login(1) also invokes the >> same system calls unconditionally that su(1) calls? Returning ENOSYS from >> a system call stub should not (and in my experience, does not) generate >> SIGSYS. There are three common cases for unimplemented system calls: >> >> (1) The kernel doesn't recognize the system call. Return ENOSYS + SIGSYS. >> If >> a binary handles SIGSYS, it gets the ENOSYS return, otherwise, it >> exits. >> This occurs if the system call isn't listed in the system call table, >> or >> if it's listed but unimplemented. This is what happens if you invoke a >> random system call number, or a new system call on a really old kernel. >> >> (2) The kernel recognizes, but does not implement the system call, and the >> system call is one where error handling is possible. This occurs when >> a >> system call stub function returns ENOSYS. For example, the audit code >> contains conditionally compiled system call code that returns ENOSYS if >> AUDIT isn't in the kernel. This also occurs when compatibility stubs >> are >> inserted to allow forward compatibility. >> >> (3) The kernel recognizes and implements the system call, but the >> underlying >> object doesn't implement the call. Return EOPNOTSUPP, ENOTSUP, EINVAL, >> etc. Typical examples are VFS system calls where the file system >> doesn't >> implement the operation, such as extended attributes, hard links, etc. >> >> The audit subsystem uses the second approach so that userland binaries can >> detect that audit is not available and handle it properly (typically by not >> configuring audit and generating audit events). Notice that we merged >> audit system call stubs to RELENG_6 for 6.1-RELEASE so that the upgrade >> path to an audit-enabled userland in 6.2-RELEASE would be un-bumpy if the >> user didn't properly follow proper upgrade instructions (kernel before user >> space). >> >> So: could you confirm that what you're observing is happening and provide >> specific specific debugging information? For example, your commit message >> hand-waves at 32-bit binaries on amd64 -- perhaps there is a bug in the >> handling of ENOSYS in the compat/freebsd32 system call path. A casual >> reading of the system call code suggests that this is not the case, but I >> don't think this is a case I have specifically tested. If you're running a >> very old kernel (pre-February/March) with a new user space, understand that >> that is not a supported configuration that will break for other more subtle >> reasons, and please back out this commit. >> >> Thanks, >> >> Robert N M Watson >> Computer Laboratory >> University of Cambridge >> >> > > From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:48:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B6F816A403; Tue, 24 Oct 2006 09:48:25 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id BACDD43D4C; Tue, 24 Oct 2006 09:48:24 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9O9mL0j020683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 02:48:22 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453DE12A.5070509@FreeBSD.org> Date: Tue, 24 Oct 2006 02:47:22 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Maxim Sobolev References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> In-Reply-To: <453DDED4.3070208@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:48:25 -0000 P.S. Perhaps my mistake is that I have blindly assumed that attempt to invoke unimplemented syscall on native platform (i.e. ia32 binary running on ia32 kernel) results in the same error condition as attempt to invoke unimplemented syscall in binary compatibility mode (i.e. ia32 binary on amd64 kernel). If it is not, then the binary compatibility layer should be fixed instead to match behavior of the native mode. Maxim Sobolev wrote: > OK, in this particular case I am trying to run su(8) binary compiled for > FreeBSD/ia32 on FreeBSD/amd64 system (FreeBSD 6.2 but this doesn't > really make any difference since the code is the same). > > Since all audit syscalls in freebsd32 emulation layer are redirected to > nosys() any attempt to invoke such syscall results in both ENOSYS errno > *and* SIGSYS signal delivered to the process in question. The latter > kills the process without giving it any chance to handle ENOSYS. > > -Maxim > > Robert Watson wrote: >> >> On Tue, 24 Oct 2006, Maxim Sobolev wrote: >> >>> sobomax 2006-10-24 08:18:10 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> usr.bin/su su.c >>> Log: >>> Ignore SIGSYS when BSM is compiled in. Otherwise, attempt to invoke >>> su on >>> system that don't have audit framefork compiled into kernel or ia32 >>> binary >>> on amd64 system will result in SIGSYS. There is one place in su.c >>> itself >>> where it tries to check for errno != ENOSYS, but it has been a nop >>> since su >>> does not catch SIGSYS anyway. There are few other places in libbsm, >>> where attempt to invoke audit syscal would result in SIGSYS if no audit >>> support is present in the kernel, so that the only reliable method for >>> now is to disable SIGSYS completely in the case when BSM is compiled >>> in. >>> >>> In the long run, both direct invocation of audit-related syscalls and >>> libbsm should be made more intellegent to handle the case when BSM >>> is not >>> compiled into the kernel gracefully. >>> >>> MFC after: 3 days >>> (provided re@ approval) >> >> I have to admit being a bit puzzled by your commit. Since you didn't >> bother to contact me with a bug report before committing this presumed >> fix, I can only assume that you are entirely certain that what you're >> describing is the case. However, since it appears not to be the case >> on thousands of deployed HEAD and RELENG_6 machines, I have to wonder >> whether you're hitting an edge case that needs further debugging and >> discussion. >> >> Alternatively, you booted a really old kernel with a relatively new >> user space. And by really old, I mean RELENG_6 in March of this year, >> or HEAD in February. How did you manage to log in, as login(1) also >> invokes the same system calls unconditionally that su(1) calls? >> Returning ENOSYS from a system call stub should not (and in my >> experience, does not) generate SIGSYS. There are three common cases >> for unimplemented system calls: >> >> (1) The kernel doesn't recognize the system call. Return ENOSYS + >> SIGSYS. If >> a binary handles SIGSYS, it gets the ENOSYS return, otherwise, it >> exits. >> This occurs if the system call isn't listed in the system call >> table, or >> if it's listed but unimplemented. This is what happens if you >> invoke a >> random system call number, or a new system call on a really old >> kernel. >> >> (2) The kernel recognizes, but does not implement the system call, and >> the >> system call is one where error handling is possible. This occurs >> when a >> system call stub function returns ENOSYS. For example, the audit >> code >> contains conditionally compiled system call code that returns >> ENOSYS if >> AUDIT isn't in the kernel. This also occurs when compatibility >> stubs are >> inserted to allow forward compatibility. >> >> (3) The kernel recognizes and implements the system call, but the >> underlying >> object doesn't implement the call. Return EOPNOTSUPP, ENOTSUP, >> EINVAL, >> etc. Typical examples are VFS system calls where the file system >> doesn't >> implement the operation, such as extended attributes, hard links, >> etc. >> >> The audit subsystem uses the second approach so that userland binaries >> can detect that audit is not available and handle it properly >> (typically by not configuring audit and generating audit events). >> Notice that we merged audit system call stubs to RELENG_6 for >> 6.1-RELEASE so that the upgrade path to an audit-enabled userland in >> 6.2-RELEASE would be un-bumpy if the user didn't properly follow >> proper upgrade instructions (kernel before user space). >> >> So: could you confirm that what you're observing is happening and >> provide specific specific debugging information? For example, your >> commit message hand-waves at 32-bit binaries on amd64 -- perhaps there >> is a bug in the handling of ENOSYS in the compat/freebsd32 system call >> path. A casual reading of the system call code suggests that this is >> not the case, but I don't think this is a case I have specifically >> tested. If you're running a very old kernel (pre-February/March) with >> a new user space, understand that that is not a supported >> configuration that will break for other more subtle reasons, and >> please back out this commit. >> >> Thanks, >> >> Robert N M Watson >> Computer Laboratory >> University of Cambridge >> >> > > From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:50:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3704816A4E1; Tue, 24 Oct 2006 09:50:59 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E218343D58; Tue, 24 Oct 2006 09:50:58 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9O9owo9046803; Tue, 24 Oct 2006 09:50:58 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9O9owap046767; Tue, 24 Oct 2006 09:50:58 GMT (envelope-from cperciva) Message-Id: <200610240950.k9O9owap046767@repoman.freebsd.org> From: Colin Percival Date: Tue, 24 Oct 2006 09:50:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/freebsd-update freebsd-update.sh src/usr.sbin/portsnap/portsnap portsnap.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:50:59 -0000 cperciva 2006-10-24 09:50:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/freebsd-update freebsd-update.sh usr.sbin/portsnap/portsnap portsnap.sh Log: MFC: Set LC_ALL=C in order to avoid problems with character ranges and sorting. Approved by: re (hrs) Revision Changes Path 1.2.2.2 +3 -0 src/usr.sbin/freebsd-update/freebsd-update.sh 1.8.2.7 +3 -0 src/usr.sbin/portsnap/portsnap/portsnap.sh From owner-cvs-src@FreeBSD.ORG Tue Oct 24 09:53:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 096AC16A403; Tue, 24 Oct 2006 09:53:49 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8808343D45; Tue, 24 Oct 2006 09:53:48 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9O9rj4S020796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 02:53:46 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453DE26E.3040502@FreeBSD.org> Date: Tue, 24 Oct 2006 02:52:46 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Robert Watson References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> In-Reply-To: <20061024104143.Y37455@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 09:53:49 -0000 Robert Watson wrote: > > On Tue, 24 Oct 2006, Maxim Sobolev wrote: > >> OK, in this particular case I am trying to run su(8) binary compiled >> for FreeBSD/ia32 on FreeBSD/amd64 system (FreeBSD 6.2 but this doesn't >> really make any difference since the code is the same). >> >> Since all audit syscalls in freebsd32 emulation layer are redirected >> to nosys() any attempt to invoke such syscall results in both ENOSYS >> errno *and* SIGSYS signal delivered to the process in question. The >> latter kills the process without giving it any chance to handle ENOSYS. > > So the actual bug here is that there's no compat32 definitions for the > audit system calls. I have a suspicion that we may need compat32 > wrappers in some cases, but you could start by simply exposing the audit > system calls in compat32 by changing UNIMPL to STD (or MSTD in RELENG_6)? Shouldn't unimplemented syscall have the same semantics in binary compatibility mode and in native mode (i.e. ENOSYS, but not SIGSYS)? That's my biggest confusion. Why do we get just ENOSYS in native mode when audit is not in, while ENOSYS+SIGSYS in compatibility mode? -Maxim From owner-cvs-src@FreeBSD.ORG Tue Oct 24 10:02:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 021D616A412; Tue, 24 Oct 2006 10:02:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0D4B43D5C; Tue, 24 Oct 2006 10:02:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 187A146CFF; Tue, 24 Oct 2006 06:02:25 -0400 (EDT) Date: Tue, 24 Oct 2006 11:02:25 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <453DE26E.3040502@FreeBSD.org> Message-ID: <20061024105800.J37455@fledge.watson.org> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 10:02:33 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: >> On Tue, 24 Oct 2006, Maxim Sobolev wrote: >> >>> OK, in this particular case I am trying to run su(8) binary compiled for >>> FreeBSD/ia32 on FreeBSD/amd64 system (FreeBSD 6.2 but this doesn't really >>> make any difference since the code is the same). >>> >>> Since all audit syscalls in freebsd32 emulation layer are redirected to >>> nosys() any attempt to invoke such syscall results in both ENOSYS errno >>> *and* SIGSYS signal delivered to the process in question. The latter kills >>> the process without giving it any chance to handle ENOSYS. >> >> So the actual bug here is that there's no compat32 definitions for the >> audit system calls. I have a suspicion that we may need compat32 wrappers >> in some cases, but you could start by simply exposing the audit system >> calls in compat32 by changing UNIMPL to STD (or MSTD in RELENG_6)? > > Shouldn't unimplemented syscall have the same semantics in binary > compatibility mode and in native mode (i.e. ENOSYS, but not SIGSYS)? That's > my biggest confusion. Why do we get just ENOSYS in native mode when audit is > not in, while ENOSYS+SIGSYS in compatibility mode? The method by which the distinction between ENOSYS+SIGSYS and plain ENOSYS is determined is in the implementation of the system call. If a system call is flagged as unimplemented (i.e., you never hit the function implementing it), you get SIGSYS+ENOSYS. If you enter the stub, you get ENOSYS. So the problem is that the compat code doesn't enter the stub, so never gets to the ENOSYS path. A casual glance at the system call arguments for audit suggest that wrappers aren't needed (no pointers embedded in structure arguments), so simply marking them as implemented will likely work. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 24 10:11:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D6F816A415; Tue, 24 Oct 2006 10:11:46 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A00FA43D75; Tue, 24 Oct 2006 10:11:40 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OABe59005382; Tue, 24 Oct 2006 10:11:40 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OABeqG005345; Tue, 24 Oct 2006 10:11:40 GMT (envelope-from scottl) Message-Id: <200610241011.k9OABeqG005345@repoman.freebsd.org> From: Scott Long Date: Tue, 24 Oct 2006 10:11:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 10:11:46 -0000 scottl 2006-10-24 10:11:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bce if_bce.c if_bcereg.h Log: Merge all changes from HEAD, except for rev 1.8 which changes the VLAN API. This fixes a number of stability problems with the driver. Approved by: re Sponsored by: IronPort Revision Changes Path 1.2.2.6 +280 -312 src/sys/dev/bce/if_bce.c 1.1.2.3 +9 -18 src/sys/dev/bce/if_bcereg.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 10:27:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36FAF16A407; Tue, 24 Oct 2006 10:27:24 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEE6E43D6D; Tue, 24 Oct 2006 10:27:23 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OARN8f022015; Tue, 24 Oct 2006 10:27:23 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OARN8w022014; Tue, 24 Oct 2006 10:27:23 GMT (envelope-from phk) Message-Id: <200610241027.k9OARN8w022014@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 24 Oct 2006 10:27:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys clock.h src/sys/kern subr_fattime.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 10:27:24 -0000 phk 2006-10-24 10:27:23 UTC FreeBSD src repository Modified files: sys/sys clock.h sys/kern subr_fattime.c Log: Better naming of fattime conversion functions, they do convert to timespec after all. Add 'utc' argument to control if fattimestamps are on UTC or local timezone calendar. Revision Changes Path 1.2 +8 -5 src/sys/kern/subr_fattime.c 1.7 +2 -2 src/sys/sys/clock.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 10:30:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0CA616A415; Tue, 24 Oct 2006 10:30:51 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 345C943D5C; Tue, 24 Oct 2006 10:30:51 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9OAUlPv021997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 03:30:49 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453DEB1B.6040900@FreeBSD.org> Date: Tue, 24 Oct 2006 03:29:47 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Robert Watson References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> <20061024105800.J37455@fledge.watson.org> In-Reply-To: <20061024105800.J37455@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 10:30:51 -0000 Robert Watson wrote: > The method by which the distinction between ENOSYS+SIGSYS and plain > ENOSYS is determined is in the implementation of the system call. If a > system call is flagged as unimplemented (i.e., you never hit the > function implementing it), you get SIGSYS+ENOSYS. If you enter the > stub, you get ENOSYS. So the problem is that the compat code doesn't > enter the stub, so never gets to the ENOSYS path. A casual glance at > the system call arguments for audit suggest that wrappers aren't needed > (no pointers embedded in structure arguments), so simply marking them as > implemented will likely work. Well unless I have confused something it is not really the case. For example, getauid() system call takes pointer as an argument. But in fact you did not answer my question. I think we should have ability to flag the syscall as optional in the compatibility layer, just like we have ability to do so in the native layer, so that attempt to call it results in ENOSYS but not SIGSYS. There is no point to mandate implementing wrapper for the otherwise optional syscall - all userland binaries that can call it should be ready to handle ENOSYS properly, so that just returning ENOSYS unconditionally will hurt nothing, while promoting binary compatibility until the call gets real wrapper. Just like my own experience with failing su(8) suggests. -Maxim From owner-cvs-src@FreeBSD.ORG Tue Oct 24 10:46:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9DEE16A407; Tue, 24 Oct 2006 10:46:31 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F1E043D6E; Tue, 24 Oct 2006 10:46:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0CFB846E22; Tue, 24 Oct 2006 06:46:31 -0400 (EDT) Date: Tue, 24 Oct 2006 11:46:30 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <453DEB1B.6040900@FreeBSD.org> Message-ID: <20061024114421.L33725@fledge.watson.org> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> <20061024105800.J37455@fledge.watson.org> <453DEB1B.6040900@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 10:46:32 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: > Robert Watson wrote: >> The method by which the distinction between ENOSYS+SIGSYS and plain ENOSYS >> is determined is in the implementation of the system call. If a system >> call is flagged as unimplemented (i.e., you never hit the function >> implementing it), you get SIGSYS+ENOSYS. If you enter the stub, you get >> ENOSYS. So the problem is that the compat code doesn't enter the stub, so >> never gets to the ENOSYS path. A casual glance at the system call >> arguments for audit suggest that wrappers aren't needed (no pointers >> embedded in structure arguments), so simply marking them as implemented >> will likely work. > > Well unless I have confused something it is not really the case. For > example, getauid() system call takes pointer as an argument. I believe the problem is not taking a pointer as a direct argument; copyin/copyout deal with that fine. The problem is embedded pointers within data structures, causing the passed data structure to be different sizes for 32-bit/64-bit processes. I could be mistaken. > But in fact you did not answer my question. I think we should have ability > to flag the syscall as optional in the compatibility layer, just like we > have ability to do so in the native layer, so that attempt to call it > results in ENOSYS but not SIGSYS. There is no point to mandate implementing > wrapper for the otherwise optional syscall - all userland binaries that can > call it should be ready to handle ENOSYS properly, so that just returning > ENOSYS unconditionally will hurt nothing, while promoting binary > compatibility until the call gets real wrapper. Just like my own experience > with failing su(8) suggests. The real problem here is that freebsd32 remains a second class citizen, with many important system calls not implemented. For new system calls, the responsibility for that lies with the implementor (in the case of audit, me). For old ones, presumably that lies with incomplete work done in the freebsd32 compat code, and will continue to be a problem until that is fixed. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:14:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47CFD16A40F; Tue, 24 Oct 2006 11:14:06 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F21F343D5D; Tue, 24 Oct 2006 11:14:05 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBE5e2033518; Tue, 24 Oct 2006 11:14:05 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBE5hZ033515; Tue, 24 Oct 2006 11:14:05 GMT (envelope-from phk) Message-Id: <200610241114.k9OBE5hZ033515@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 24 Oct 2006 11:14:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs denode.h direntry.h msdosfs_conv.c msdosfs_denode.c msdosfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:14:06 -0000 phk 2006-10-24 11:14:05 UTC FreeBSD src repository Modified files: sys/fs/msdosfs denode.h direntry.h msdosfs_conv.c msdosfs_denode.c msdosfs_vnops.c Log: Replace slightly crummy fattime<->timespec conversion functions. Revision Changes Path 1.35 +5 -5 src/sys/fs/msdosfs/denode.h 1.23 +0 -3 src/sys/fs/msdosfs/direntry.h 1.49 +0 -164 src/sys/fs/msdosfs/msdosfs_conv.c 1.92 +2 -1 src/sys/fs/msdosfs/msdosfs_denode.c 1.164 +9 -7 src/sys/fs/msdosfs/msdosfs_vnops.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:17:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD82116A40F; Tue, 24 Oct 2006 11:17:47 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E400743D5E; Tue, 24 Oct 2006 11:17:46 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBHkt5033832; Tue, 24 Oct 2006 11:17:46 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBHkJQ033831; Tue, 24 Oct 2006 11:17:46 GMT (envelope-from ru) Message-Id: <200610241117.k9OBHkJQ033831@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 11:17:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ubsec ubsec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:17:47 -0000 ru 2006-10-24 11:17:46 UTC FreeBSD src repository Modified files: sys/dev/ubsec ubsec.c Log: Switch to using STAILQ_REMOVE_HEAD() instead of STAILQ_REMOVE_HEAD_UNTIL(). Submitted by: Stepan A. Baranov This corresponds to OpenBSD rev. 1.134: : revision 1.134 : date: 2004/05/04 16:59:31; author: grange; state: Exp; lines: +10 -10 : Remove useless ``elm'' argument from the SIMPLEQ_REMOVE_HEAD macro. : This matches our SLIST behaviour and NetBSD's SIMPLEQ as well. : : ok millert krw deraadt Revision Changes Path 1.47 +11 -11 src/sys/dev/ubsec/ubsec.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:19:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0469316A415; Tue, 24 Oct 2006 11:19:22 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B70DD43D5F; Tue, 24 Oct 2006 11:19:21 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBJLlk033876; Tue, 24 Oct 2006 11:19:21 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBJLsC033875; Tue, 24 Oct 2006 11:19:21 GMT (envelope-from ru) Message-Id: <200610241119.k9OBJLsC033875@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 11:19:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys queue.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:19:22 -0000 ru 2006-10-24 11:19:21 UTC FreeBSD src repository Modified files: sys/sys queue.h Log: Remove the non-standard and undocumented STAILQ_REMOVE_HEAD_UNTIL() macro now that we no longer use it. Revision Changes Path 1.67 +0 -5 src/sys/sys/queue.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:20:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89CF716A40F; Tue, 24 Oct 2006 11:20:30 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A282743D6A; Tue, 24 Oct 2006 11:20:29 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBKTvi034017; Tue, 24 Oct 2006 11:20:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBKTca034016; Tue, 24 Oct 2006 11:20:29 GMT (envelope-from ru) Message-Id: <200610241120.k9OBKTca034016@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 11:20:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys queue.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:20:30 -0000 ru 2006-10-24 11:20:29 UTC FreeBSD src repository Modified files: sys/sys queue.h Log: (Forced commit.) Forgot to note that previous change was Submitted by: Stepan A. Baranov Revision Changes Path 1.68 +0 -0 src/sys/sys/queue.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:43:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B197F16A403; Tue, 24 Oct 2006 11:43:41 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6EA5C43D45; Tue, 24 Oct 2006 11:43:41 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBhfMF039934; Tue, 24 Oct 2006 11:43:41 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBhfbw039933; Tue, 24 Oct 2006 11:43:41 GMT (envelope-from phk) Message-Id: <200610241143.k9OBhfbw039933@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 24 Oct 2006 11:43:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nwfs nwfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:43:41 -0000 phk 2006-10-24 11:43:41 UTC FreeBSD src repository Modified files: sys/fs/nwfs nwfs_subr.c Log: Drop crummy fattime to timespec conversion routines. Leave a XXX here for anybody able to test. Revision Changes Path 1.17 +11 -162 src/sys/fs/nwfs/nwfs_subr.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 11:55:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB12A16A4A0; Tue, 24 Oct 2006 11:55:20 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 238F143D78; Tue, 24 Oct 2006 11:55:19 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OBtJYT041690; Tue, 24 Oct 2006 11:55:19 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OBtImq041689; Tue, 24 Oct 2006 11:55:18 GMT (envelope-from phk) Message-Id: <200610241155.k9OBtImq041689@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 24 Oct 2006 11:55:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/smbfs smbfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 11:55:21 -0000 phk 2006-10-24 11:55:18 UTC FreeBSD src repository Modified files: sys/fs/smbfs smbfs_subr.c Log: Ditch crummy fattime <--> timespec conversion functions Revision Changes Path 1.11 +9 -150 src/sys/fs/smbfs/smbfs_subr.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 12:05:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C5BBF16A5FB; Tue, 24 Oct 2006 12:05:26 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB8D643DCC; Tue, 24 Oct 2006 12:04:24 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OC4Lto044350; Tue, 24 Oct 2006 12:04:21 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OC4LVW044348; Tue, 24 Oct 2006 12:04:21 GMT (envelope-from davidxu) Message-Id: <200610241204.k9OC4LVW044348@repoman.freebsd.org> From: David Xu Date: Tue, 24 Oct 2006 12:04:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 12:05:26 -0000 davidxu 2006-10-24 12:04:21 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c Log: Protect sigqueue_take() call by child process's lock, it fixed a potential race with ptrace 'attach' which changes parent of the child process. Revision Changes Path 1.293 +2 -2 src/sys/kern/kern_exit.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 12:30:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 846E016A403; Tue, 24 Oct 2006 12:30:29 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3823443D58; Tue, 24 Oct 2006 12:30:29 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OCUTm4048569; Tue, 24 Oct 2006 12:30:29 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OCUTxj048561; Tue, 24 Oct 2006 12:30:29 GMT (envelope-from keramida) Message-Id: <200610241230.k9OCUTxj048561@repoman.freebsd.org> From: Giorgos Keramidas Date: Tue, 24 Oct 2006 12:30:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man7 ports.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 12:30:29 -0000 keramida 2006-10-24 12:30:28 UTC FreeBSD src repository (doc committer) Modified files: share/man/man7 ports.7 Log: Document NO_IGNORE and its interation with FORBIDDEN. Triggered by: a question by Panagiotis Hadgis Revision Changes Path 1.56 +11 -0 src/share/man/man7/ports.7 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 13:23:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D388B16A40F; Tue, 24 Oct 2006 13:23:04 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A62A043D49; Tue, 24 Oct 2006 13:23:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ODN4E1070478; Tue, 24 Oct 2006 13:23:04 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ODN4O1070476; Tue, 24 Oct 2006 13:23:04 GMT (envelope-from rwatson) Message-Id: <200610241323.k9ODN4O1070476@repoman.freebsd.org> From: Robert Watson Date: Tue, 24 Oct 2006 13:23:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netinet ip_output.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 13:23:04 -0000 rwatson 2006-10-24 13:23:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet ip_output.c Log: Reduce the size of a number of race windows in the TCP socket options processing code: a RST may arrive during a socket option call, causing the PCB to be freed, leading to an invalid pointer dereference. When the kernel blocks in a socket option copyin or memory allocation (such as during heavy paging), the race window is greatly widened. This change re-validates the PCB pointer after returning from the copy/alloc operation. This does not eliminate the problem, but does narrow the window significantly (to the point where it may not be observed at all). The proper fix is in 7.x, which significantly re-works the socket and PCB code so that PCB's are not ripped out from under sockets on reset. However, those changes are not appropriate for an MFC during a release cycle. As a result, this is not an MFC, but new code crafted for 6.x. PR: kern/102412 Reported by: Daniel Austin Tested by: Diane Bruce Reviewed by: Diane Bruce Approved by: re (kensmith) Revision Changes Path 1.242.2.16 +18 -0 src/sys/netinet/ip_output.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 13:27:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33DA116A40F; Tue, 24 Oct 2006 13:27:09 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4DA943D4C; Tue, 24 Oct 2006 13:27:08 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ODR81p071038; Tue, 24 Oct 2006 13:27:08 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ODR88A071037; Tue, 24 Oct 2006 13:27:08 GMT (envelope-from keramida) Message-Id: <200610241327.k9ODR88A071037@repoman.freebsd.org> From: Giorgos Keramidas Date: Tue, 24 Oct 2006 13:27:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man7 ports.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 13:27:09 -0000 keramida 2006-10-24 13:27:08 UTC FreeBSD src repository (doc committer) Modified files: share/man/man7 ports.7 Log: Reduce our pointy-hat pool capacity by one (i.e. bump manpage date, after the last change to this manpage). Reminded by: ru Revision Changes Path 1.57 +1 -1 src/share/man/man7/ports.7 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 13:50:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60DB316A416; Tue, 24 Oct 2006 13:50:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7808243D9E; Tue, 24 Oct 2006 13:49:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ODniIx080678; Tue, 24 Oct 2006 13:49:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ODnied080677; Tue, 24 Oct 2006 13:49:44 GMT (envelope-from rwatson) Message-Id: <200610241349.k9ODnied080677@repoman.freebsd.org> From: Robert Watson Date: Tue, 24 Oct 2006 13:49:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 13:50:00 -0000 rwatson 2006-10-24 13:49:44 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 syscalls.master Log: Hook up audit functions in the freebsd32 compatibility code. It is believed these likely don't require wrappers. Reported by: sobomax MFC after: 3 days Revision Changes Path 1.84 +15 -9 src/sys/compat/freebsd32/syscalls.master From owner-cvs-src@FreeBSD.ORG Tue Oct 24 13:54:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F83116A40F; Tue, 24 Oct 2006 13:54:58 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6992343D5A; Tue, 24 Oct 2006 13:54:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ODsu3t083375; Tue, 24 Oct 2006 13:54:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ODsus4083374; Tue, 24 Oct 2006 13:54:56 GMT (envelope-from rwatson) Message-Id: <200610241354.k9ODsus4083374@repoman.freebsd.org> From: Robert Watson Date: Tue, 24 Oct 2006 13:54:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 13:54:58 -0000 rwatson 2006-10-24 13:54:56 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regenerate. Revision Changes Path 1.71 +51 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.69 +10 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.60 +10 -10 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.70 +10 -10 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 13:55:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 426FF16A58C; Tue, 24 Oct 2006 13:55:50 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8053D43D60; Tue, 24 Oct 2006 13:55:49 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0C13C46D96; Tue, 24 Oct 2006 09:55:49 -0400 (EDT) Date: Tue, 24 Oct 2006 14:55:48 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <453DEB1B.6040900@FreeBSD.org> Message-ID: <20061024145506.G48521@fledge.watson.org> References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> <20061024105800.J37455@fledge.watson.org> <453DEB1B.6040900@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 13:55:50 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: > Robert Watson wrote: >> The method by which the distinction between ENOSYS+SIGSYS and plain ENOSYS >> is determined is in the implementation of the system call. If a system >> call is flagged as unimplemented (i.e., you never hit the function >> implementing it), you get SIGSYS+ENOSYS. If you enter the stub, you get >> ENOSYS. So the problem is that the compat code doesn't enter the stub, so >> never gets to the ENOSYS path. A casual glance at the system call >> arguments for audit suggest that wrappers aren't needed (no pointers >> embedded in structure arguments), so simply marking them as implemented >> will likely work. > > Well unless I have confused something it is not really the case. For > example, getauid() system call takes pointer as an argument. I've gone ahead and updated the freebsd32 syscalls.master file to hook up the audit system calls. Could you locally back out your change and see if a kernel built with these changes operates properly? Thanks, Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 24 14:35:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66F5416A49E; Tue, 24 Oct 2006 14:35:33 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B4D743E75; Tue, 24 Oct 2006 14:32:41 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OEPocX091977; Tue, 24 Oct 2006 14:25:50 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OEPoRx091976; Tue, 24 Oct 2006 14:25:50 GMT (envelope-from ume) Message-Id: <200610241425.k9OEPoRx091976@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Tue, 24 Oct 2006 14:25:50 +0000 (UTC) To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org X-FreeBSD-CVS-Branch: ISC Cc: Subject: cvs commit: src/lib/libc/resolv - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 14:35:33 -0000 ume 2006-10-24 14:25:50 UTC FreeBSD src repository src/lib/libc/resolv - Imported sources Update of /home/ncvs/src/lib/libc/resolv In directory repoman.freebsd.org:/tmp/cvs-serv91964 Log Message: Import of BIND 9.3.3rc2 Status: Vendor Tag: ISC Release Tags: BIND_9_3_3_RC2 C src/lib/libc/resolv/res_send.c 1 conflicts created by this import. Use the following command to help the merge: cvs checkout -jISC:yesterday -jISC src/lib/libc/resolv From owner-cvs-src@FreeBSD.ORG Tue Oct 24 14:41:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F9C616A403; Tue, 24 Oct 2006 14:41:56 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5A6743D5A; Tue, 24 Oct 2006 14:41:43 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OEfhim094405; Tue, 24 Oct 2006 14:41:43 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OEfhL5094404; Tue, 24 Oct 2006 14:41:43 GMT (envelope-from ume) Message-Id: <200610241441.k9OEfhL5094404@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Tue, 24 Oct 2006 14:41:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/resolv res_send.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 14:41:56 -0000 ume 2006-10-24 14:41:43 UTC FreeBSD src repository Modified files: lib/libc/resolv res_send.c Log: Merge res_send.c of BIND9 9.3.3rc2 into main chunk. It includes following fix: Retransmission timeouts should be based on which attempt it is to the nameserver and not the nameserver itself. Obtained from: ISC MFC after: 3 days Revision Changes Path 1.4 +7 -6 src/lib/libc/resolv/res_send.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 15:02:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEFCA16A403; Tue, 24 Oct 2006 15:02:41 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45F5543D49; Tue, 24 Oct 2006 15:02:41 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OF2f1B000322; Tue, 24 Oct 2006 15:02:41 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OF2fRB000321; Tue, 24 Oct 2006 15:02:41 GMT (envelope-from kib) Message-Id: <200610241502.k9OF2fRB000321@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 24 Oct 2006 15:02:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern vfs_mount.c src/sys/sys mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 15:02:41 -0000 kib 2006-10-24 15:02:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern vfs_mount.c sys/sys mount.h Log: MFC rev. 1.232, 1.233, 1.240 of the src/sys/kern/vfs_mount.c, and rev. 1.215 of src/sys/sys/mount.h (with change to keep the RELENG_6 ABI). Fix the races that could occur while waiting for the coveredvp lock. Approved by: re (kensmith), pjd (mentor) Revision Changes Path 1.196.2.20 +31 -10 src/sys/kern/vfs_mount.c 1.197.2.7 +1 -0 src/sys/sys/mount.h From owner-cvs-src@FreeBSD.ORG Tue Oct 24 17:24:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E8BE16A412; Tue, 24 Oct 2006 17:24:12 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AD0C43D5C; Tue, 24 Oct 2006 17:24:12 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OHOB5e034131; Tue, 24 Oct 2006 17:24:11 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OHOBCW034130; Tue, 24 Oct 2006 17:24:11 GMT (envelope-from sobomax) Message-Id: <200610241724.k9OHOBCW034130@repoman.freebsd.org> From: Maxim Sobolev Date: Tue, 24 Oct 2006 17:24:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 17:24:12 -0000 sobomax 2006-10-24 17:24:11 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 syscalls.master Log: Fix kernel breakage introduced in the previous commit (redeclatation of the audit functions). Revision Changes Path 1.85 +9 -9 src/sys/compat/freebsd32/syscalls.master From owner-cvs-src@FreeBSD.ORG Tue Oct 24 17:25:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94E1F16A403; Tue, 24 Oct 2006 17:25:37 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DF5D43D58; Tue, 24 Oct 2006 17:25:37 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OHPb8b034244; Tue, 24 Oct 2006 17:25:37 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OHPbqc034243; Tue, 24 Oct 2006 17:25:37 GMT (envelope-from sobomax) Message-Id: <200610241725.k9OHPbqc034243@repoman.freebsd.org> From: Maxim Sobolev Date: Tue, 24 Oct 2006 17:25:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 17:25:37 -0000 sobomax 2006-10-24 17:25:37 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regen. Revision Changes Path 1.72 +1 -51 src/sys/compat/freebsd32/freebsd32_proto.h 1.70 +1 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.61 +1 -1 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.71 +1 -1 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 17:37:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A85A16A403; Tue, 24 Oct 2006 17:37:52 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3862B43D5C; Tue, 24 Oct 2006 17:37:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 4351446C21; Tue, 24 Oct 2006 13:37:49 -0400 (EDT) Date: Tue, 24 Oct 2006 18:37:49 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Sobolev In-Reply-To: <200610241724.k9OHOBCW034130@repoman.freebsd.org> Message-ID: <20061024183721.J48521@fledge.watson.org> References: <200610241724.k9OHOBCW034130@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 17:37:52 -0000 On Tue, 24 Oct 2006, Maxim Sobolev wrote: > sobomax 2006-10-24 17:24:11 UTC > > FreeBSD src repository > > Modified files: > sys/compat/freebsd32 syscalls.master > Log: > Fix kernel breakage introduced in the previous commit (redeclatation > of the audit functions). Thanks, much appreciated! Point hat required. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 24 17:41:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 793F416A49E; Tue, 24 Oct 2006 17:41:30 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85E0D43D67; Tue, 24 Oct 2006 17:41:29 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OHfTso036452; Tue, 24 Oct 2006 17:41:29 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OHfThh036450; Tue, 24 Oct 2006 17:41:29 GMT (envelope-from sobomax) Message-Id: <200610241741.k9OHfThh036450@repoman.freebsd.org> From: Maxim Sobolev Date: Tue, 24 Oct 2006 17:41:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 17:41:30 -0000 sobomax 2006-10-24 17:41:28 UTC FreeBSD src repository Modified files: usr.bin/su su.c Log: Backout previous change (SIGSYS related). The fix has been applied to the proper place. Pointed out by: rwatson Revision Changes Path 1.83 +0 -2 src/usr.bin/su/su.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 18:42:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8C0416A403; Tue, 24 Oct 2006 18:42:50 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A54A43D4C; Tue, 24 Oct 2006 18:42:50 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OIgggX047523; Tue, 24 Oct 2006 18:42:42 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OIggkH047522; Tue, 24 Oct 2006 18:42:42 GMT (envelope-from trhodes) Message-Id: <200610241842.k9OIggkH047522@repoman.freebsd.org> From: Tom Rhodes Date: Tue, 24 Oct 2006 18:42:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/cp cp.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 18:42:51 -0000 trhodes 2006-10-24 18:42:42 UTC FreeBSD src repository Modified files: bin/cp cp.1 Log: Flesh out the compatibility section a little bit. Bump doc date. Revision Changes Path 1.37 +20 -30 src/bin/cp/cp.1 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 18:47:38 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B14A216A403; Tue, 24 Oct 2006 18:47:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98FBD43D90; Tue, 24 Oct 2006 18:47:06 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9OIktLv011325; Tue, 24 Oct 2006 14:47:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Tue, 24 Oct 2006 14:30:11 -0400 User-Agent: KMail/1.9.1 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610231133.29990.jhb@freebsd.org> <200610240647.03765.davidxu@freebsd.org> In-Reply-To: <200610240647.03765.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610241430.12149.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 24 Oct 2006 14:47:03 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2091/Tue Oct 24 09:27:53 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 18:47:38 -0000 On Monday 23 October 2006 18:47, David Xu wrote: > On Monday 23 October 2006 23:33, John Baldwin wrote: > > On Saturday 21 October 2006 19:59, David Xu wrote: > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_exit.c > > > Log: > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > > opened a race window which can cause memory leak in signal queue. > > > Here we free memory for signal queue when process state is set to > > > PRS_ZOMBIE. > > > > Is there any reason to not just harvest it in wait() instead? > > I prefer to free it earlier rather than delaying it if I can. But we already do the free'ing "later" (wait() really isnt' all that later than exit1() for most processes) for sigacts, limits, etc. It would seem that sigqueue and sigacts would have nearly identical lifetimes. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 24 20:20:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E68EB16A416; Tue, 24 Oct 2006 20:20:42 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F69B43D5A; Tue, 24 Oct 2006 20:20:42 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OKKgAf064271; Tue, 24 Oct 2006 20:20:42 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OKKg58064269; Tue, 24 Oct 2006 20:20:42 GMT (envelope-from ru) Message-Id: <200610242020.k9OKKg58064269@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 20:20:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/devd devd.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 20:20:43 -0000 ru 2006-10-24 20:20:42 UTC FreeBSD src repository Modified files: sbin/devd devd.conf.5 Log: Fix the description of "media-type". Revision Changes Path 1.11 +14 -3 src/sbin/devd/devd.conf.5 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 20:45:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1931616A412; Tue, 24 Oct 2006 20:45:29 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1A5443D64; Tue, 24 Oct 2006 20:45:28 +0000 (GMT) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OKjSvv068813; Tue, 24 Oct 2006 20:45:28 GMT (envelope-from danger@repoman.freebsd.org) Received: (from danger@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OKjSdP068812; Tue, 24 Oct 2006 20:45:28 GMT (envelope-from danger) Message-Id: <200610242045.k9OKjSdP068812@repoman.freebsd.org> From: Daniel Gerzo Date: Tue, 24 Oct 2006 20:45:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 gre.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 20:45:29 -0000 danger 2006-10-24 20:45:28 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) share/man/man4 gre.4 Log: Sync with HEAD. This includes: - convert to the current style of section 4 man pages - s/ip.forwarding/net.inet.ip.forwarding/ to match reality - s/ifconfig tunnel greN/ifconfig greN tunnel/ Approved by: re (bmah), keramida (mentor), trhodes (mentor) Revision Changes Path 1.5.8.1 +16 -2 src/share/man/man4/gre.4 From owner-cvs-src@FreeBSD.ORG Tue Oct 24 20:52:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1839016A403; Tue, 24 Oct 2006 20:52:07 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC21043D4C; Tue, 24 Oct 2006 20:52:06 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OKq6Kc077730; Tue, 24 Oct 2006 20:52:06 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OKq6LR077728; Tue, 24 Oct 2006 20:52:06 GMT (envelope-from ru) Message-Id: <200610242052.k9OKq6LR077728@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 20:52:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 20:52:07 -0000 ru 2006-10-24 20:52:06 UTC FreeBSD src repository Modified files: release Makefile Log: Remove hint.atkbd.0.flags="0x1" from the installation device.hints; kbdmux(4) is available during install and should take care of USB keyboards. Revision Changes Path 1.915 +0 -6 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 24 21:00:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78CEF16A403; Tue, 24 Oct 2006 21:00:50 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3816043D64; Tue, 24 Oct 2006 21:00:50 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OL0ooj079024; Tue, 24 Oct 2006 21:00:50 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OL0oWH079020; Tue, 24 Oct 2006 21:00:50 GMT (envelope-from ru) Message-Id: <200610242100.k9OL0oWH079020@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 21:00:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 21:00:50 -0000 ru 2006-10-24 21:00:49 UTC FreeBSD src repository Modified files: release Makefile Log: The AUTO_KEYBOARD_DETECT is useful on amd64 as well. Revision Changes Path 1.916 +3 -1 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 24 22:02:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77BB416A47C; Tue, 24 Oct 2006 22:02:30 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02C9F43D5A; Tue, 24 Oct 2006 22:02:29 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OM2T8C090727; Tue, 24 Oct 2006 22:02:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OM2TIG090724; Tue, 24 Oct 2006 22:02:29 GMT (envelope-from ru) Message-Id: <200610242202.k9OM2TIG090724@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 22:02:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 22:02:30 -0000 ru 2006-10-24 22:02:29 UTC FreeBSD src repository Modified files: sbin/mount mount.c Log: Revert rev. 1.86 by jmallett@ as it breaks "ro" mounts specified in /etc/fstab. This has been happening due to the priority inversion; options specified on the command line should take precedence over options from fstab over default "noro" option, but since both the default "noro" and options specified on the command line (-w, -r, -o ...) were put into the same "options" variable, "noro" took precedence over fstab "ro" (this is easily visible with "mount -d"). PR: bin/100164 Revision Changes Path 1.89 +32 -6 src/sbin/mount/mount.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 22:16:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0856E16A403; Tue, 24 Oct 2006 22:16:52 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6D6343D55; Tue, 24 Oct 2006 22:16:51 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9OMGpFv093923; Tue, 24 Oct 2006 22:16:51 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9OMGptp093922; Tue, 24 Oct 2006 22:16:51 GMT (envelope-from ru) Message-Id: <200610242216.k9OMGptp093922@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 24 Oct 2006 22:16:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 22:16:52 -0000 ru 2006-10-24 22:16:51 UTC FreeBSD src repository Modified files: sbin/mount mount.c Log: Two tiny style fixes. Revision Changes Path 1.90 +3 -3 src/sbin/mount/mount.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 22:54:14 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 69C1D16A407; Tue, 24 Oct 2006 22:54:14 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: John Baldwin Date: Wed, 25 Oct 2006 06:54:11 +0800 User-Agent: KMail/1.8.2 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610240647.03765.davidxu@freebsd.org> <200610241430.12149.jhb@freebsd.org> In-Reply-To: <200610241430.12149.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610250654.11455.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 22:54:14 -0000 On Wednesday 25 October 2006 02:30, John Baldwin wrote: > On Monday 23 October 2006 18:47, David Xu wrote: > > On Monday 23 October 2006 23:33, John Baldwin wrote: > > > On Saturday 21 October 2006 19:59, David Xu wrote: > > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/kern kern_exit.c > > > > Log: > > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the > > > > change opened a race window which can cause memory leak in signal > > > > queue. Here we free memory for signal queue when process state is set > > > > to PRS_ZOMBIE. > > > > > > Is there any reason to not just harvest it in wait() instead? > > > > I prefer to free it earlier rather than delaying it if I can. > > But we already do the free'ing "later" (wait() really isnt' all that later > than exit1() for most processes) for sigacts, limits, etc. It would seem > that sigqueue and sigacts would have nearly identical lifetimes. But if system is under heavily memory loaded, doesn't freeing it earlier make it better ? sigqueue does not have safe lifetime as sigacts, every thread has it, we check signal queue leak in thread_exit(), if you move the sigqueue_flush into wait1, then that code also has to be adjusted, because now not every thread will free the memory when it is exited, they no long have consistent behavior. David Xu From owner-cvs-src@FreeBSD.ORG Tue Oct 24 23:18:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C108A16A492; Tue, 24 Oct 2006 23:18:07 +0000 (UTC) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D81E43D46; Tue, 24 Oct 2006 23:18:07 +0000 (GMT) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ONI7hs004414; Tue, 24 Oct 2006 23:18:07 GMT (envelope-from grog@repoman.freebsd.org) Received: (from grog@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ONI7UP004413; Tue, 24 Oct 2006 23:18:07 GMT (envelope-from grog) Message-Id: <200610242318.k9ONI7UP004413@repoman.freebsd.org> From: Greg Lehey Date: Tue, 24 Oct 2006 23:18:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar/calendars/de_DE.ISO8859-1 calendar.musik X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 23:18:07 -0000 grog 2006-10-24 23:18:07 UTC FreeBSD src repository Modified files: usr.bin/calendar/calendars/de_DE.ISO8859-1 calendar.musik Log: Bizet was only born once. Revision Changes Path 1.13 +0 -1 src/usr.bin/calendar/calendars/de_DE.ISO8859-1/calendar.musik From owner-cvs-src@FreeBSD.ORG Tue Oct 24 23:27:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0958D16A416; Tue, 24 Oct 2006 23:27:53 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8FB143D53; Tue, 24 Oct 2006 23:27:52 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ONRqKr006164; Tue, 24 Oct 2006 23:27:52 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ONRqfB006163; Tue, 24 Oct 2006 23:27:52 GMT (envelope-from cognet) Message-Id: <200610242327.k9ONRqfB006163@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 24 Oct 2006 23:27:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 23:27:53 -0000 cognet 2006-10-24 23:27:52 UTC FreeBSD src repository Modified files: sys/arm/arm vm_machdep.c Log: Ooops, dump_avail[i] can be 0 if the RAM starts at 0x00000000, so check that dump_avail[i + 1] is == 0 as a stop condition instead. MFC after: 3 days Revision Changes Path 1.28 +4 -4 src/sys/arm/arm/vm_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 24 23:52:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 602AF16A403; Tue, 24 Oct 2006 23:52:23 +0000 (UTC) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF3FF43D64; Tue, 24 Oct 2006 23:52:22 +0000 (GMT) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9ONqMht010426; Tue, 24 Oct 2006 23:52:22 GMT (envelope-from markus@repoman.freebsd.org) Received: (from markus@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9ONqMAS010425; Tue, 24 Oct 2006 23:52:22 GMT (envelope-from markus) Message-Id: <200610242352.k9ONqMAS010425@repoman.freebsd.org> From: Markus Brueffer Date: Tue, 24 Oct 2006 23:52:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/misc usb_hid_usages X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 23:52:23 -0000 markus 2006-10-24 23:52:22 UTC FreeBSD src repository Modified files: share/misc usb_hid_usages Log: - Update USB HID usage tables according to the following specs: * USB HID Usage Tables, V1.12 * USB Monitor Control Class Specification, V1.0 * USB Usage Tables for HID Power Devices, V1.0 * USB Device Class Definition for Physical Devices, V1.0 * USB HID Point of Sale Usage Tables, V1.02 - Fix spelling of 'Microsoft' - Bring the so called Microsoft page, in line with the style of the rest of the file. - Remove NetBSD version string as it doesn't reflect reality any longer Approved by: emax (mentor) Revision Changes Path 1.2 +709 -57 src/share/misc/usb_hid_usages From owner-cvs-src@FreeBSD.ORG Wed Oct 25 04:04:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E971916A415; Wed, 25 Oct 2006 04:04:17 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36F2E43D58; Wed, 25 Oct 2006 04:04:16 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9P44D0E044885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 21:04:14 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453EE201.9040305@FreeBSD.org> Date: Tue, 24 Oct 2006 21:03:13 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Robert Watson References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> <20061024105800.J37455@fledge.watson.org> <453DEB1B.6040900@FreeBSD.org> <20061024145506.G48521@fledge.watson.org> In-Reply-To: <20061024145506.G48521@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 04:04:18 -0000 Robert, Your patch works just fine. Please don't forget to MFC it before 6.2 is out. Thanks! Regards, Maxim Robert Watson wrote: > > On Tue, 24 Oct 2006, Maxim Sobolev wrote: > >> Robert Watson wrote: >>> The method by which the distinction between ENOSYS+SIGSYS and plain >>> ENOSYS is determined is in the implementation of the system call. If >>> a system call is flagged as unimplemented (i.e., you never hit the >>> function implementing it), you get SIGSYS+ENOSYS. If you enter the >>> stub, you get ENOSYS. So the problem is that the compat code doesn't >>> enter the stub, so never gets to the ENOSYS path. A casual glance at >>> the system call arguments for audit suggest that wrappers aren't >>> needed (no pointers embedded in structure arguments), so simply >>> marking them as implemented will likely work. >> >> Well unless I have confused something it is not really the case. For >> example, getauid() system call takes pointer as an argument. > > I've gone ahead and updated the freebsd32 syscalls.master file to hook > up the audit system calls. Could you locally back out your change and > see if a kernel built with these changes operates properly? > > Thanks, > > Robert N M Watson > Computer Laboratory > University of Cambridge > > From owner-cvs-src@FreeBSD.ORG Wed Oct 25 06:18:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32D8B16A415; Wed, 25 Oct 2006 06:18:05 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0A9E43D46; Wed, 25 Oct 2006 06:18:04 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P6I4TW093168; Wed, 25 Oct 2006 06:18:04 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P6I4Og093167; Wed, 25 Oct 2006 06:18:04 GMT (envelope-from davidxu) Message-Id: <200610250618.k9P6I4Og093167@repoman.freebsd.org> From: David Xu Date: Wed, 25 Oct 2006 06:18:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_exit.c sys_process.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 06:18:05 -0000 davidxu 2006-10-25 06:18:04 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c sys_process.c Log: Move sigqueue_take() call into proc_reparent(), this fixed bugs where proc_reparent() is called but sigqueue_take() is forgotten. Revision Changes Path 1.294 +3 -4 src/sys/kern/kern_exit.c 1.140 +1 -5 src/sys/kern/sys_process.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 06:28:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7903716A412; Wed, 25 Oct 2006 06:28:24 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3404A43D45; Wed, 25 Oct 2006 06:28:24 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P6SOCh094752; Wed, 25 Oct 2006 06:28:24 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P6SOjW094751; Wed, 25 Oct 2006 06:28:24 GMT (envelope-from davidxu) Message-Id: <200610250628.k9P6SOjW094751@repoman.freebsd.org> From: David Xu Date: Wed, 25 Oct 2006 06:28:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 06:28:24 -0000 davidxu 2006-10-25 06:28:23 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: Eliminate an unnecessary `if' statement. Revision Changes Path 1.50 +2 -1 src/sys/kern/kern_umtx.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 06:38:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E1E016A403; Wed, 25 Oct 2006 06:38:49 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8045643D72; Wed, 25 Oct 2006 06:38:46 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P6ckcX096319; Wed, 25 Oct 2006 06:38:46 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P6ck3v096318; Wed, 25 Oct 2006 06:38:46 GMT (envelope-from davidxu) Message-Id: <200610250638.k9P6ck3v096318@repoman.freebsd.org> From: David Xu Date: Wed, 25 Oct 2006 06:38:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 06:38:49 -0000 davidxu 2006-10-25 06:38:46 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: In order to eliminate a branch, convert opcode to unsigned integer. Revision Changes Path 1.51 +2 -2 src/sys/kern/kern_umtx.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 07:29:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEACC16A403; Wed, 25 Oct 2006 07:29:22 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B260F43D4C; Wed, 25 Oct 2006 07:29:22 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P7TMlv005322; Wed, 25 Oct 2006 07:29:22 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P7TMYi005321; Wed, 25 Oct 2006 07:29:22 GMT (envelope-from bde) Message-Id: <200610250729.k9P7TMYi005321@repoman.freebsd.org> From: Bruce Evans Date: Wed, 25 Oct 2006 07:29:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/gcc function.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 07:29:23 -0000 bde 2006-10-25 07:29:22 UTC FreeBSD src repository Modified files: contrib/gcc function.c Log: Fixed -mprofiler-epilogue. The garbage collector apparently doesn't understand that non-local variables can never be collected, and when it collected the static variable for mexitcount_libfunc, gcc aborted on the next use of this variable. This quick fix is to reinitialize the variable on every use and depend on garbage collection recovering the small amount of memory wasted by this, and not worry by the small amount of time wasted by this. It would be better to initialize the variable together with most of the other libfuncs in optabs.c and depend on whatever magic is there to prevent its collection, but we initialize it here to avoid taking at least 2 more files off the vendor branch. Revision Changes Path 1.23 +3 -1 src/contrib/gcc/function.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 07:58:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D556A16A40F; Wed, 25 Oct 2006 07:58:18 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A4FA43D49; Wed, 25 Oct 2006 07:58:18 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P7wICT009935; Wed, 25 Oct 2006 07:58:18 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P7wIiP009934; Wed, 25 Oct 2006 07:58:18 GMT (envelope-from imp) Message-Id: <200610250758.k9P7wIiP009934@repoman.freebsd.org> From: Warner Losh Date: Wed, 25 Oct 2006 07:58:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/at91 at91_sscreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 07:58:18 -0000 imp 2006-10-25 07:58:18 UTC FreeBSD src repository Modified files: sys/arm/at91 at91_sscreg.h Log: MFp4: Status register bits Revision Changes Path 1.3 +14 -0 src/sys/arm/at91/at91_sscreg.h From owner-cvs-src@FreeBSD.ORG Wed Oct 25 08:00:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67A9716A403; Wed, 25 Oct 2006 08:00:12 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F400943D55; Wed, 25 Oct 2006 08:00:11 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P80BqE010030; Wed, 25 Oct 2006 08:00:11 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P80BvR010029; Wed, 25 Oct 2006 08:00:11 GMT (envelope-from imp) Message-Id: <200610250800.k9P80BvR010029@repoman.freebsd.org> From: Warner Losh Date: Wed, 25 Oct 2006 08:00:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/at91 std.at91 std.kb920x X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 08:00:12 -0000 imp 2006-10-25 08:00:11 UTC FreeBSD src repository Modified files: sys/arm/at91 std.at91 std.kb920x Log: MFp4: Move the parameters that are basically dictated by the AT91 organization to that file. Revision Changes Path 1.3 +5 -0 src/sys/arm/at91/std.at91 1.4 +0 -5 src/sys/arm/at91/std.kb920x From owner-cvs-src@FreeBSD.ORG Wed Oct 25 09:40:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD7D116A4A0; Wed, 25 Oct 2006 09:40:07 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A80143D45; Wed, 25 Oct 2006 09:40:07 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P9e7nq035709; Wed, 25 Oct 2006 09:40:07 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P9e7h4035708; Wed, 25 Oct 2006 09:40:07 GMT (envelope-from ru) Message-Id: <200610250940.k9P9e7h4035708@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 09:40:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/lorder lorder.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 09:40:08 -0000 ru 2006-10-25 09:40:07 UTC FreeBSD src repository Modified files: usr.bin/lorder lorder.1 Log: Document the NM environment variable. Revision Changes Path 1.10 +9 -1 src/usr.bin/lorder/lorder.1 From owner-cvs-src@FreeBSD.ORG Wed Oct 25 09:43:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C44116A407; Wed, 25 Oct 2006 09:43:39 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 271A743D5E; Wed, 25 Oct 2006 09:43:39 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9P9hdBY036846; Wed, 25 Oct 2006 09:43:39 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9P9hdQ8036845; Wed, 25 Oct 2006 09:43:39 GMT (envelope-from ru) Message-Id: <200610250943.k9P9hdQ8036845@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 09:43:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.lib.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 09:43:39 -0000 ru 2006-10-25 09:43:38 UTC FreeBSD src repository Modified files: share/mk bsd.lib.mk Log: - Don't pass an empty ``NM='' to lorder(1) when NM is unset. - Don't redundantly use "env". - Protect NM value with quotes, just in case. Revision Changes Path 1.179 +17 -3 src/share/mk/bsd.lib.mk From owner-cvs-src@FreeBSD.ORG Wed Oct 25 10:45:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0DA0F16A403; Wed, 25 Oct 2006 10:45:00 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 891D443D55; Wed, 25 Oct 2006 10:44:59 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PAixnQ047232; Wed, 25 Oct 2006 10:44:59 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PAix05047231; Wed, 25 Oct 2006 10:44:59 GMT (envelope-from ru) Message-Id: <200610251044.k9PAix05047231@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 10:44:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/fdcontrol fdcontrol.8 src/usr.sbin/smbmsg smbmsg.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 10:45:00 -0000 ru 2006-10-25 10:44:59 UTC FreeBSD src repository Modified files: usr.sbin/fdcontrol fdcontrol.8 usr.sbin/smbmsg smbmsg.8 Log: Force the use of the tbl(1) preprocessor. Revision Changes Path 1.21 +1 -1 src/usr.sbin/fdcontrol/fdcontrol.8 1.5 +1 -0 src/usr.sbin/smbmsg/smbmsg.8 From owner-cvs-src@FreeBSD.ORG Wed Oct 25 12:22:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74F3816A417; Wed, 25 Oct 2006 12:22:20 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EF6D43D5E; Wed, 25 Oct 2006 12:22:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PCMKB2063913; Wed, 25 Oct 2006 12:22:20 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PCMKOZ063912; Wed, 25 Oct 2006 12:22:20 GMT (envelope-from ru) Message-Id: <200610251222.k9PCMKOZ063912@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 12:22:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ukbd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 12:22:20 -0000 ru 2006-10-25 12:22:19 UTC FreeBSD src repository Modified files: sys/dev/usb ukbd.c Log: Fix non-working CAPS LED under X by applying fix from atkbd.c,v 1.27: : revision 1.27 : date: 2000/05/28 12:43:24; author: ache; state: Exp; lines: +3 -2 : Manipulate with AltGR Led (really CapsLock Led) only in K_XLATE mode, because : all other modes not set ALKED flag and it means that CapsLock always turned : off for them. : Real bug example is X11 which never turn on CapsLock with Russian keyboard. : : PR: 18651 : Submitted by: "Mike E. Matsnev" MFC after: 3 days Revision Changes Path 1.58 +2 -1 src/sys/dev/usb/ukbd.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 13:15:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32FEA16A49E; Wed, 25 Oct 2006 13:15:07 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C61943DC4; Wed, 25 Oct 2006 13:14:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PDEPMw085953; Wed, 25 Oct 2006 13:14:25 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PDEPtt085952; Wed, 25 Oct 2006 13:14:25 GMT (envelope-from rwatson) Message-Id: <200610251314.k9PDEPtt085952@repoman.freebsd.org> From: Robert Watson Date: Wed, 25 Oct 2006 13:14:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/security/mac mac_framework.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 13:15:07 -0000 rwatson 2006-10-25 13:14:25 UTC FreeBSD src repository Modified files: sys/security/mac mac_framework.h Log: Remove extra _MAC_ from #ifdef guard. Revision Changes Path 1.74 +1 -1 src/sys/security/mac/mac_framework.h From owner-cvs-src@FreeBSD.ORG Wed Oct 25 13:35:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A595E16A407; Wed, 25 Oct 2006 13:35:42 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7347643D53; Wed, 25 Oct 2006 13:35:42 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PDZgRq089462; Wed, 25 Oct 2006 13:35:42 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PDZgFd089461; Wed, 25 Oct 2006 13:35:42 GMT (envelope-from ru) Message-Id: <200610251335.k9PDZgFd089461@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 13:35:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/atkbdc atkbd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 13:35:42 -0000 ru 2006-10-25 13:35:42 UTC FreeBSD src repository Modified files: sys/dev/atkbdc atkbd.c Log: Fix LEDs not working when atkbd is an active keyboard and the physical keyboard is attached only after the system has already booted. If USB keyboard is also present, and there's no kbdmux(4), the problem has been hiding itself because as soon as we get to multi-user, the USB keyboard becomes an active keyboard (see devd.conf), thus marking atkbd inactive and letting the old code initialize the keyboard. With kbdmux(4), or if there's no USB keyboard, the atkbd keyboard is always active, whether it's physically attached or not, thus it never initialized itself properly on a physical attach. To fix this, move block that initialized the keyboard on attach upper so it doesn't depend on the (KBD_IS_ACTIVE(kbd) && KBD_IS_BUSY(kbd)) condition. Also move KBD_FOUND_DEVICE() a few lines upper so that KDSETLED and KDSETREPEAT that follow it propagate to the controller. MFC after: 3 days Revision Changes Path 1.52 +16 -16 src/sys/dev/atkbdc/atkbd.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 14:44:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B15C416A412; Wed, 25 Oct 2006 14:44:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41F0043D46; Wed, 25 Oct 2006 14:44:30 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PEiUu7001008; Wed, 25 Oct 2006 14:44:30 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PEiUVl001006; Wed, 25 Oct 2006 14:44:30 GMT (envelope-from jhb) Message-Id: <200610251444.k9PEiUVl001006@repoman.freebsd.org> From: John Baldwin Date: Wed, 25 Oct 2006 14:44:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/sys/i386/i386 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 14:44:30 -0000 jhb 2006-10-25 14:44:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/i386/i386 mp_machdep.c Log: Ignore I/O APICs that aren't really there (return 0xffffffff when you try to talk to them) if they aren't listed as the destination of any interrupts in the MP Table instead of panic'ing when we fail to set the APIC ID. The new APIC code in 5.x+ has a similar check. Revision Changes Path 1.115.2.27 +31 -18 src/sys/i386/i386/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 15:03:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCFC116A492; Wed, 25 Oct 2006 15:03:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F9D243D6B; Wed, 25 Oct 2006 15:03:30 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PF3UmL005059; Wed, 25 Oct 2006 15:03:30 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PF3UBY005057; Wed, 25 Oct 2006 15:03:30 GMT (envelope-from jhb) Message-Id: <200610251503.k9PF3UBY005057@repoman.freebsd.org> From: John Baldwin Date: Wed, 25 Oct 2006 15:03:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/boot/ficl Makefile src/sys/boot/i386 Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:03:33 -0000 jhb 2006-10-25 15:03:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/boot/ficl Makefile sys/boot/i386 Makefile.inc Log: MFC: Add -march=i386 for the amd64 build to generate smaller binaries. Approved by: re (hrs) Revision Changes Path 1.41.2.1 +1 -1 src/sys/boot/ficl/Makefile 1.10.2.1 +1 -1 src/sys/boot/i386/Makefile.inc From owner-cvs-src@FreeBSD.ORG Wed Oct 25 15:04:13 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B9A216A4A7; Wed, 25 Oct 2006 15:04:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BA1F43D72; Wed, 25 Oct 2006 15:03:52 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9PF3hTs018720; Wed, 25 Oct 2006 11:03:44 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Wed, 25 Oct 2006 10:48:56 -0400 User-Agent: KMail/1.9.1 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610241430.12149.jhb@freebsd.org> <200610250654.11455.davidxu@freebsd.org> In-Reply-To: <200610250654.11455.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610251048.57097.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 25 Oct 2006 11:03:44 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2098/Wed Oct 25 09:14:20 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:04:13 -0000 On Tuesday 24 October 2006 18:54, David Xu wrote: > On Wednesday 25 October 2006 02:30, John Baldwin wrote: > > On Monday 23 October 2006 18:47, David Xu wrote: > > > On Monday 23 October 2006 23:33, John Baldwin wrote: > > > > On Saturday 21 October 2006 19:59, David Xu wrote: > > > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/kern kern_exit.c > > > > > Log: > > > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the > > > > > change opened a race window which can cause memory leak in signal > > > > > queue. Here we free memory for signal queue when process state is set > > > > > to PRS_ZOMBIE. > > > > > > > > Is there any reason to not just harvest it in wait() instead? > > > > > > I prefer to free it earlier rather than delaying it if I can. > > > > But we already do the free'ing "later" (wait() really isnt' all that later > > than exit1() for most processes) for sigacts, limits, etc. It would seem > > that sigqueue and sigacts would have nearly identical lifetimes. > > But if system is under heavily memory loaded, doesn't freeing it earlier make > it better ? sigqueue does not have safe lifetime as sigacts, every thread > has it, we check signal queue leak in thread_exit(), if you move the > sigqueue_flush into wait1, then that code also has to be adjusted, > because now not every thread will free the memory when it is exited, > they no long have consistent behavior. If it works as it is now, then it is fine. Forgot that sigqueue was per-thread rather than per-process. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Oct 25 15:16:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6973D16A407; Wed, 25 Oct 2006 15:16:14 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2276F43D46; Wed, 25 Oct 2006 15:16:14 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PFGEEn006963; Wed, 25 Oct 2006 15:16:14 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PFGD0K006962; Wed, 25 Oct 2006 15:16:13 GMT (envelope-from flz) Message-Id: <200610251516.k9PFGD0K006962@repoman.freebsd.org> From: Florent Thoumie Date: Wed, 25 Oct 2006 15:16:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/timedef da_DK.ISO8859-1.src da_DK.UTF-8.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:16:14 -0000 flz 2006-10-25 15:16:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/timedef da_DK.ISO8859-1.src da_DK.UTF-8.src Log: MFC: De-capitalize days and months' names. src/share/timedef/da_DK.UTF-8.src: rev 1.1 -> 1.2 src/share/timedef/da_DK.ISO8859-1.src: rev 1.10 -> 1.11 PR: conf/101154 Submitted by: Thomas Jensen Approved by: re (hrs) Revision Changes Path 1.10.16.1 +51 -51 src/share/timedef/da_DK.ISO8859-1.src 1.1.8.1 +50 -50 src/share/timedef/da_DK.UTF-8.src From owner-cvs-src@FreeBSD.ORG Wed Oct 25 15:23:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 30AB616A4C8; Wed, 25 Oct 2006 15:23:49 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8E4C43D5A; Wed, 25 Oct 2006 15:23:48 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PFNmrl008247; Wed, 25 Oct 2006 15:23:48 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PFNmq8008246; Wed, 25 Oct 2006 15:23:48 GMT (envelope-from ru) Message-Id: <200610251523.k9PFNmq8008246@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 15:23:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 ng_pppoe.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:23:49 -0000 ru 2006-10-25 15:23:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 ng_pppoe.4 Log: MFC: 1.37 (grammar), 1.38 (markup), 1.39 (grammar and typos). Approved by: re (blanket) Revision Changes Path 1.31.2.3 +19 -18 src/share/man/man4/ng_pppoe.4 From owner-cvs-src@FreeBSD.ORG Wed Oct 25 15:26:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BE5016A417; Wed, 25 Oct 2006 15:26:58 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5949443D83; Wed, 25 Oct 2006 15:26:54 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PFQsGE008503; Wed, 25 Oct 2006 15:26:54 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PFQsTr008502; Wed, 25 Oct 2006 15:26:54 GMT (envelope-from ru) Message-Id: <200610251526.k9PFQsTr008502@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 15:26:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 syscons.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:26:58 -0000 ru 2006-10-25 15:26:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 syscons.4 Log: MFC: 1.42 (kill redundant .Pp), 1.43 (hw.syscons.kbd_kbdkey -> hw.syscons.kbd_debug) 1.44 (Fix ttyv* device names). Approved by: re (blanket) Revision Changes Path 1.40.2.2 +10 -11 src/share/man/man4/syscons.4 From owner-cvs-src@FreeBSD.ORG Wed Oct 25 17:12:07 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id 1D3EA16A47B; Wed, 25 Oct 2006 17:12:07 +0000 (UTC) Date: Wed, 25 Oct 2006 17:12:07 +0000 From: Darren Reed To: Daniel O'Connor Message-ID: <20061025171207.GA94866@hub.freebsd.org> References: <200607210845.k6L8j0Ep026008@repoman.freebsd.org> <200607241336.29993.doconnor@gsoft.com.au> <20060724072513.GB727@turion.vk2pj.dyndns.org> <200607241819.08831.doconnor@gsoft.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607241819.08831.doconnor@gsoft.com.au> User-Agent: Mutt/1.4.2.1i Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: truss status X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 17:12:07 -0000 On Mon, Jul 24, 2006 at 06:18:36PM +0930, Daniel O'Connor wrote: > On Monday 24 July 2006 16:55, Peter Jeremy wrote: > > On Mon, 2006-Jul-24 13:36:19 +0930, Daniel O'Connor wrote: > > >Ktrace is almost useless "out of the box" because for any non-trivial > > >operation you run out of requests. > > > > Some changes were made to improve this and this problem has mostly > > gone away. > > Ahh nice! > On a related note, do you think it would be possible to allow ktrace to use > pipes? Have a look at NetBSD, it has something like this...although it is not without issues as ktrace doesn't stop the program to prevent missing events due to the buffer not being drained quickly enough. Darren From owner-cvs-src@FreeBSD.ORG Wed Oct 25 17:53:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 680) id D091616A407; Wed, 25 Oct 2006 17:53:02 +0000 (UTC) Date: Wed, 25 Oct 2006 17:53:02 +0000 From: Darren Reed To: Andrew Thompson Message-ID: <20061025175302.GB94866@hub.freebsd.org> References: <200604290537.k3T5bPXC071830@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604290537.k3T5bPXC071830@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 17:53:02 -0000 On Sat, Apr 29, 2006 at 05:37:25AM +0000, Andrew Thompson wrote: > thompsa 2006-04-29 05:37:25 UTC > > FreeBSD src repository > > Modified files: > sys/net if_bridge.c > Log: > Add support for fragmenting ipv4 packets. > > The packet filter may reassemble the ip fragments and return a packet that is > larger than the MTU of the sending interface. There is no check for DF or icmp > replies as we can only get a large packet to fragment by reassembling a > previous fragment, and this only happens after a call to pfil(9). I'm a long time in catching up with this change, but architecturally, this change is very very wrong. A bridge should have _no_ part in fragmenting up an IP packet regardless of what options are set (or not set) in an IP header. Darren From owner-cvs-src@FreeBSD.ORG Wed Oct 25 18:11:52 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0F3B16A47B for ; Wed, 25 Oct 2006 18:11:52 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt14.ihug.co.nz (grunt14.ihug.co.nz [203.109.254.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCD2143DA1 for ; Wed, 25 Oct 2006 18:10:19 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt14.ihug.co.nz with esmtp (Exim 3.35 #1 (Debian)) id 1GcnCk-0004Lx-00; Thu, 26 Oct 2006 07:10:18 +1300 Received: by heff.fud.org.nz (Postfix, from userid 1001) id A25821CC23; Thu, 26 Oct 2006 07:10:17 +1300 (NZDT) Date: Thu, 26 Oct 2006 07:10:17 +1300 From: Andrew Thompson To: Darren Reed Message-ID: <20061025181017.GA62176@heff.fud.org.nz> References: <200604290537.k3T5bPXC071830@repoman.freebsd.org> <20061025175302.GB94866@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061025175302.GB94866@hub.freebsd.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 18:11:53 -0000 On Wed, Oct 25, 2006 at 05:53:02PM +0000, Darren Reed wrote: > On Sat, Apr 29, 2006 at 05:37:25AM +0000, Andrew Thompson wrote: > > thompsa 2006-04-29 05:37:25 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net if_bridge.c > > Log: > > Add support for fragmenting ipv4 packets. > > > > The packet filter may reassemble the ip fragments and return a packet that is > > larger than the MTU of the sending interface. There is no check for DF or icmp > > replies as we can only get a large packet to fragment by reassembling a > > previous fragment, and this only happens after a call to pfil(9). > > I'm a long time in catching up with this change, but architecturally, > this change is very very wrong. > > A bridge should have _no_ part in fragmenting up an IP packet > regardless of what options are set (or not set) in an IP header. Its not really the bridge that is fragmenting packets. The packet filter may reassemble fragments and return a packet larger than we can send, the fragmenting is done in the layer between bridge<->pfil. As long as we may be returned a large packet this is unavoidable. I agree that a bridge should not have anything to do with IP, and technically it isn't. Andrew From owner-cvs-src@FreeBSD.ORG Wed Oct 25 21:00:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F06BB16A4EE; Wed, 25 Oct 2006 21:00:35 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A3EB43D80; Wed, 25 Oct 2006 21:00:09 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PL09ld082239; Wed, 25 Oct 2006 21:00:09 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PL0838082238; Wed, 25 Oct 2006 21:00:08 GMT (envelope-from cognet) Message-Id: <200610252100.k9PL0838082238@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 25 Oct 2006 21:00:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm nexus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 21:00:36 -0000 cognet 2006-10-25 21:00:08 UTC FreeBSD src repository Modified files: sys/arm/arm nexus.c Log: Setup multiple interrupts if needed. Revision Changes Path 1.8 +5 -2 src/sys/arm/arm/nexus.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 21:11:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3586916A47E; Wed, 25 Oct 2006 21:11:53 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89A9B43D46; Wed, 25 Oct 2006 21:11:51 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PLBkKj085745; Wed, 25 Oct 2006 21:11:46 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PLBkda085744; Wed, 25 Oct 2006 21:11:46 GMT (envelope-from cognet) Message-Id: <200610252111.k9PLBkda085744@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 25 Oct 2006 21:11:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm nexus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 21:11:53 -0000 cognet 2006-10-25 21:11:46 UTC FreeBSD src repository Modified files: sys/arm/arm nexus.c Log: Let allow to teardown multiple irqs as well. Revision Changes Path 1.9 +3 -1 src/sys/arm/arm/nexus.c From owner-cvs-src@FreeBSD.ORG Wed Oct 25 21:23:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CC0016A415; Wed, 25 Oct 2006 21:23:21 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35E5D43D55; Wed, 25 Oct 2006 21:23:21 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9PLNLQS088013; Wed, 25 Oct 2006 21:23:21 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9PLNLDc088012; Wed, 25 Oct 2006 21:23:21 GMT (envelope-from ru) Message-Id: <200610252123.k9PLNLDc088012@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 25 Oct 2006 21:23:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/awk Makefile tran.c.diff X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 21:23:21 -0000 ru 2006-10-25 21:23:21 UTC FreeBSD src repository Modified files: usr.bin/awk Makefile Added files: usr.bin/awk tran.c.diff Log: Fix a bug converting a variable from the numeric type to a string. PR: bin/104795 MFC after: 3 days Revision Changes Path 1.14 +1 -1 src/usr.bin/awk/Makefile 1.1 +22 -0 src/usr.bin/awk/tran.c.diff (new) From owner-cvs-src@FreeBSD.ORG Thu Oct 26 00:29:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E75B616A415; Thu, 26 Oct 2006 00:29:43 +0000 (UTC) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A112843D8A; Thu, 26 Oct 2006 00:29:43 +0000 (GMT) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9Q0ThZ0020513; Thu, 26 Oct 2006 00:29:43 GMT (envelope-from avatar@repoman.freebsd.org) Received: (from avatar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9Q0ThSw020512; Thu, 26 Oct 2006 00:29:43 GMT (envelope-from avatar) Message-Id: <200610260029.k9Q0ThSw020512@repoman.freebsd.org> From: Tai-hwa Liang Date: Thu, 26 Oct 2006 00:29:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d ppp X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 00:29:44 -0000 avatar 2006-10-26 00:29:43 UTC FreeBSD src repository Modified files: etc/rc.d ppp Log: Re-sync'ing pf rules in post command as we already did for ipfilter. With this patch, pf rules with dynamically created devices such like tun0 works without further intervention. Reviewed by: mlaier MFC after: 3 days Revision Changes Path 1.12 +2 -1 src/etc/rc.d/ppp From owner-cvs-src@FreeBSD.ORG Thu Oct 26 02:36:05 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8372616A47B; Thu, 26 Oct 2006 02:36:05 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49C2343D7C; Thu, 26 Oct 2006 02:35:57 +0000 (GMT) (envelope-from doconnor@gsoft.com.au) Received: from inchoate.gsoft.com.au (inchoate.gsoft.com.au [203.31.81.37]) (authenticated bits=0) by cain.gsoft.com.au (8.13.5/8.13.4) with ESMTP id k9Q2Zo3J036455 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Oct 2006 12:05:50 +0930 (CST) (envelope-from doconnor@gsoft.com.au) From: "Daniel O'Connor" To: Darren Reed Date: Thu, 26 Oct 2006 12:05:37 +0930 User-Agent: KMail/1.9.4 References: <200607210845.k6L8j0Ep026008@repoman.freebsd.org> <200607241819.08831.doconnor@gsoft.com.au> <20061025171207.GA94866@hub.freebsd.org> In-Reply-To: <20061025171207.GA94866@hub.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1221934.OocV2obkjW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200610261205.45942.doconnor@gsoft.com.au> X-Spam-Score: -3.421 () ALL_TRUSTED,AWL,BAYES_00 X-Scanned-By: MIMEDefang 2.57 on 203.31.81.10 Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: truss status X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 02:36:05 -0000 --nextPart1221934.OocV2obkjW Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 26 October 2006 02:42, Darren Reed wrote: > > On a related note, do you think it would be possible to allow ktrace to > > use pipes? > > Have a look at NetBSD, it has something like this...although it is not > without issues as ktrace doesn't stop the program to prevent missing > events due to the buffer not being drained quickly enough. OK thanks. I guess I could just bump up the buffer size 8-) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart1221934.OocV2obkjW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQBFQB8B5ZPcIHs/zowRAi5gAJ9Uo/j+KvekXKp1FlQHQQG6YK1k/QCeLtKe z6GMcMoreO2aGXBmiOMj5yE= =NlWy -----END PGP SIGNATURE----- --nextPart1221934.OocV2obkjW-- From owner-cvs-src@FreeBSD.ORG Thu Oct 26 09:33:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11B9816A407; Thu, 26 Oct 2006 09:33:35 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7F2743D58; Thu, 26 Oct 2006 09:33:34 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9Q9XY0v039285; Thu, 26 Oct 2006 09:33:34 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9Q9XYa7039284; Thu, 26 Oct 2006 09:33:34 GMT (envelope-from davidxu) Message-Id: <200610260933.k9Q9XYa7039284@repoman.freebsd.org> From: David Xu Date: Thu, 26 Oct 2006 09:33:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 09:33:35 -0000 davidxu 2006-10-26 09:33:34 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: Optimize umtx_lock_pi() a bit by moving some heavy code out of the loop, make a fast path when a umtx_pi can be allocated without being blocked. Revision Changes Path 1.52 +27 -32 src/sys/kern/kern_umtx.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 10:17:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93F5316A403; Thu, 26 Oct 2006 10:17:14 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B37D43D49; Thu, 26 Oct 2006 10:17:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QAHDx7047052; Thu, 26 Oct 2006 10:17:13 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QAHDOq047051; Thu, 26 Oct 2006 10:17:13 GMT (envelope-from rwatson) Message-Id: <200610261017.k9QAHDOq047051@repoman.freebsd.org> From: Robert Watson Date: Thu, 26 Oct 2006 10:17:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_malloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 10:17:14 -0000 rwatson 2006-10-26 10:17:13 UTC FreeBSD src repository Modified files: sys/kern kern_malloc.c Log: Increase usefulness of "show malloc" by moving from displaying the basic counters of allocs/frees/use for each malloc type to calculating InUse, MemUse, and Requests as displayed by the userspace vmstat -m. This is more useful when debugging malloc(9)-related memory leaks, where the count of allocs/frees may not usefully reflect that current memory allocation (i.e., when highly variable size allocations occur with the same malloc type, such as with contigmalloc). MFC after: 3 days Limitations observed by: scottl Revision Changes Path 1.156 +11 -5 src/sys/kern/kern_malloc.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 11:22:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC24D16A47B; Thu, 26 Oct 2006 11:22:06 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3CDF43D66; Thu, 26 Oct 2006 11:22:04 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QBM4D7058259; Thu, 26 Oct 2006 11:22:04 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QBM4Ec058258; Thu, 26 Oct 2006 11:22:04 GMT (envelope-from oleg) Message-Id: <200610261122.k9QBM4Ec058258@repoman.freebsd.org> From: Oleg Bulyzhin Date: Thu, 26 Oct 2006 11:22:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/contrib/ipfilter/netinet ip_fil_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 11:22:07 -0000 oleg 2006-10-26 11:22:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/contrib/ipfilter/netinet ip_fil_freebsd.c Log: MFC rev. 1.5 Workaround bad locking design: do not try to lock/unlock destroyed/non-existing mutex. PR: kern/103569 Reviewed by: guido Silence from: darrenr Approved by: re (hrs) Revision Changes Path 1.1.1.1.2.2 +10 -4 src/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 11:53:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D172916A47C; Thu, 26 Oct 2006 11:53:26 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C19143D49; Thu, 26 Oct 2006 11:53:26 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QBrQO2063104; Thu, 26 Oct 2006 11:53:26 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QBrQ66063103; Thu, 26 Oct 2006 11:53:26 GMT (envelope-from bde) Message-Id: <200610261153.k9QBrQ66063103@repoman.freebsd.org> From: Bruce Evans Date: Thu, 26 Oct 2006 11:53:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 11:53:26 -0000 bde 2006-10-26 11:53:26 UTC FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: Reduced the ifdef tangle for profiling by moving the unreachable never-working parts for icc to the attic. Fixed some nearby style bugs. Revision Changes Path 1.80 +2 -12 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Thu Oct 26 12:41:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34A6916A40F; Thu, 26 Oct 2006 12:41:54 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6DF943D64; Thu, 26 Oct 2006 12:41:53 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QCfrng072097; Thu, 26 Oct 2006 12:41:53 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QCfrOh072096; Thu, 26 Oct 2006 12:41:53 GMT (envelope-from kib) Message-Id: <200610261241.k9QCfrOh072096@repoman.freebsd.org> From: Konstantin Belousov Date: Thu, 26 Oct 2006 12:41:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 12:41:54 -0000 kib 2006-10-26 12:41:53 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_serv.c Log: Fix leak in NAMEI zone caused by nfs server when VOP_RENAME fails. Submitted by: Padma Bhooma Reviewed by: bde Approved by: pjd (mentor) MFC after: 1 week Revision Changes Path 1.166 +2 -2 src/sys/nfsserver/nfs_serv.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 12:55:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91E1F16A403; Thu, 26 Oct 2006 12:55:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CF8A43D55; Thu, 26 Oct 2006 12:55:33 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QCtXPt082460; Thu, 26 Oct 2006 12:55:33 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QCtXje082459; Thu, 26 Oct 2006 12:55:33 GMT (envelope-from rwatson) Message-Id: <200610261255.k9QCtXje082459@repoman.freebsd.org> From: Robert Watson Date: Thu, 26 Oct 2006 12:55:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 12:55:33 -0000 rwatson 2006-10-26 12:55:32 UTC FreeBSD src repository Modified files: sys/vm uma_core.c Log: Better align output of "show uma" by moving from displaying the basic counters of allocs/frees/use for each zone to the same statistics shown by userspace "vmstat -z". MFC after: 3 days Revision Changes Path 1.140 +7 -5 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 13:20:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A39D216A415; Thu, 26 Oct 2006 13:20:29 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6096743D45; Thu, 26 Oct 2006 13:20:29 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QDKT7n087248; Thu, 26 Oct 2006 13:20:29 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QDKT0r087247; Thu, 26 Oct 2006 13:20:29 GMT (envelope-from kib) Message-Id: <200610261320.k9QDKT0r087247@repoman.freebsd.org> From: Konstantin Belousov Date: Thu, 26 Oct 2006 13:20:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 13:20:29 -0000 kib 2006-10-26 13:20:29 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: The attempt to rename "." with MAC framework compiled in would cause attempt to twice unlock the vnode. Check that ni_vp and ni_dvp are different before doing second unlock. Reviewed by: rwatson Approved by: pjd (mentor) MFC after: 1 week Revision Changes Path 1.427 +2 -1 src/sys/kern/vfs_syscalls.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 14:33:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E22416A417; Thu, 26 Oct 2006 14:33:08 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1454043D49; Thu, 26 Oct 2006 14:33:08 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id EFA755C48; Thu, 26 Oct 2006 18:33:06 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id CD1C35C0E; Thu, 26 Oct 2006 18:33:06 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k9QEX6ih001133; Thu, 26 Oct 2006 18:33:06 +0400 (MSD) (envelope-from ru) Date: Thu, 26 Oct 2006 18:33:06 +0400 From: Ruslan Ermilov To: Robert Watson Message-ID: <20061026143306.GB790@rambler-co.ru> References: <200610261255.k9QCtXje082459@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ" Content-Disposition: inline In-Reply-To: <200610261255.k9QCtXje082459@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 14:33:08 -0000 --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 26, 2006 at 12:55:32PM +0000, Robert Watson wrote: > rwatson 2006-10-26 12:55:32 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/vm uma_core.c=20 > Log: > Better align output of "show uma" by moving from displaying the basic > counters of allocs/frees/use for each zone to the same statistics > shown by userspace "vmstat -z". > =20 > MFC after: 3 days > =20 > Revision Changes Path > 1.140 +7 -5 src/sys/vm/uma_core.c >=20 "The same statistics" also shows LIMIT, REQUESTS, and FAILURES. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --8P1HSweYDcXXzwPJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFQMciqRfpzJluFF4RAnaGAKCE2YbFGQGp2/vIbnsnBnatDBZ/fQCeLEb5 azmuwDQop90vIlhjiZ45ghA= =8PGV -----END PGP SIGNATURE----- --8P1HSweYDcXXzwPJ-- From owner-cvs-src@FreeBSD.ORG Thu Oct 26 15:16:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8E6516A47C; Thu, 26 Oct 2006 15:16:53 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C6DB43D94; Thu, 26 Oct 2006 15:16:44 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QFGiVE012578; Thu, 26 Oct 2006 15:16:44 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QFGi4C012576; Thu, 26 Oct 2006 15:16:44 GMT (envelope-from bde) Message-Id: <200610261516.k9QFGi4C012576@repoman.freebsd.org> From: Bruce Evans Date: Thu, 26 Oct 2006 15:16:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 15:16:53 -0000 bde 2006-10-26 15:16:43 UTC FreeBSD src repository Modified files: sys/conf kern.pre.mk Log: Fixed high resolution profiling on arches that support it (amd64 and i386). Use -mprofiler-epilogue again, and don't use -finstrument-functions. The former has been fixed for arches that implement high-res profiling, and the latter has been useless for kernel profiling since gcc-3.4 when it started forcing -fno-inline. -fno-inline gives a kernel with performance characteristics too different from a normal kernel to be worth profiling, by turning off inlining of all the little optimized functions in headers. This interacts especially badly with FreeBSD's use of "static inline" for all inlines in headers, by creating many separate copies of the little functions, so not inlining tends to increase cache pressure where it should reduce it, and (since gprof(1) doesn't understand the copies) the statistics for the little functions are hard to interpret even if you want them. Revision Changes Path 1.81 +1 -1 src/sys/conf/kern.pre.mk From owner-cvs-src@FreeBSD.ORG Thu Oct 26 16:27:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4325F16A403; Thu, 26 Oct 2006 16:27:08 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC1D143D55; Thu, 26 Oct 2006 16:27:07 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id A090F46D88; Thu, 26 Oct 2006 12:27:07 -0400 (EDT) Date: Thu, 26 Oct 2006 17:27:07 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ruslan Ermilov In-Reply-To: <20061026143306.GB790@rambler-co.ru> Message-ID: <20061026172516.E29443@fledge.watson.org> References: <200610261255.k9QCtXje082459@repoman.freebsd.org> <20061026143306.GB790@rambler-co.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 16:27:08 -0000 On Thu, 26 Oct 2006, Ruslan Ermilov wrote: > On Thu, Oct 26, 2006 at 12:55:32PM +0000, Robert Watson wrote: >> rwatson 2006-10-26 12:55:32 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/vm uma_core.c >> Log: >> Better align output of "show uma" by moving from displaying the basic >> counters of allocs/frees/use for each zone to the same statistics >> shown by userspace "vmstat -z". > > "The same statistics" also shows LIMIT, REQUESTS, and FAILURES. Requests are included in the output I added, but are spelt "Requests". Limits and failures currently aren't, but adding them wouldn't be a bad idea at all. I'm also thinking off adding a "show umazone " which would provide more detailed information about per-CPU caches, as we're currently looking at a potential UMA bug in a panic report on -stable. We'd pull some, but not all, of the logic from umastat.c. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Thu Oct 26 19:04:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A5CB16A407; Thu, 26 Oct 2006 19:04:21 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29A3843D46; Thu, 26 Oct 2006 19:04:21 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QJ4LRl074616; Thu, 26 Oct 2006 19:04:21 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QJ4Lhm074614; Thu, 26 Oct 2006 19:04:21 GMT (envelope-from ru) Message-Id: <200610261904.k9QJ4Lhm074614@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 26 Oct 2006 19:04:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf kern.post.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 19:04:21 -0000 ru 2006-10-26 19:04:20 UTC FreeBSD src repository Modified files: sys/conf kern.post.mk Log: MF kmod.mk 1.176: Properly handle vnode_if.h dependencies. Instructed by: bde Revision Changes Path 1.98 +5 -1 src/sys/conf/kern.post.mk From owner-cvs-src@FreeBSD.ORG Thu Oct 26 19:15:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2B8C16A412; Thu, 26 Oct 2006 19:15:54 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BF6C43D49; Thu, 26 Oct 2006 19:15:54 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QJFsWe076494; Thu, 26 Oct 2006 19:15:54 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QJFsgp076493; Thu, 26 Oct 2006 19:15:54 GMT (envelope-from ru) Message-Id: <200610261915.k9QJFsgp076493@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 26 Oct 2006 19:15:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 19:15:54 -0000 ru 2006-10-26 19:15:54 UTC FreeBSD src repository Modified files: sys/boot/i386/boot2 boot2.c Log: Back out rev. 1.71 as it breaks directly loading (i386) kernels. OK'ed by: jhb PR: i386/96430, i386/104709 MFC after: 3 days Revision Changes Path 1.80 +3 -3 src/sys/boot/i386/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 19:41:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C503716A417; Thu, 26 Oct 2006 19:41:02 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C0A943D5D; Thu, 26 Oct 2006 19:41:02 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QJf2TW081111; Thu, 26 Oct 2006 19:41:02 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QJf2oY081110; Thu, 26 Oct 2006 19:41:02 GMT (envelope-from ru) Message-Id: <200610261941.k9QJf2oY081110@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 26 Oct 2006 19:41:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 19:41:02 -0000 ru 2006-10-26 19:41:02 UTC FreeBSD src repository Modified files: sys/boot/i386/boot2 boot2.c Log: Restore support for -c and -d that were treacherously murdered in rev. 1.58. (This only costs us four bytes.) Prodded by: bde MFC after: 3 days Revision Changes Path 1.81 +4 -2 src/sys/boot/i386/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 20:04:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A44B16A492; Thu, 26 Oct 2006 20:04:23 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3640243D49; Thu, 26 Oct 2006 20:04:23 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QK4Naq086599; Thu, 26 Oct 2006 20:04:23 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QK4NPw086598; Thu, 26 Oct 2006 20:04:23 GMT (envelope-from ru) Message-Id: <200610262004.k9QK4NPw086598@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 26 Oct 2006 20:04:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/libi386 elf32_freebsd.c elf64_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 20:04:23 -0000 ru 2006-10-26 20:04:23 UTC FreeBSD src repository Modified files: sys/boot/i386/libi386 elf32_freebsd.c elf64_freebsd.c Log: Adopt comments borrowed from aout_freebsd.c. Revision Changes Path 1.15 +1 -1 src/sys/boot/i386/libi386/elf32_freebsd.c 1.17 +1 -1 src/sys/boot/i386/libi386/elf64_freebsd.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 20:39:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1079B16A407; Thu, 26 Oct 2006 20:39:51 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (vlsi00.si.noda.tus.ac.jp [133.31.130.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A45E43D46; Thu, 26 Oct 2006 20:39:50 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p2118-ipbf608funabasi.chiba.ocn.ne.jp [125.175.93.118]) (authenticated bits=128) by mail.allbsd.org (8.13.1/8.13.4) with ESMTP id k9QKdZQE086163; Fri, 27 Oct 2006 05:39:48 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id k9QKH4tT027987; Fri, 27 Oct 2006 05:17:05 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 27 Oct 2006 05:16:37 +0900 (JST) Message-Id: <20061027.051637.115993470.hrs@allbsd.org> To: tanimura@FreeBSD.org, re@FreeBSD.org From: Hiroki Sato In-Reply-To: <200610150504.k9F548ld008933@repoman.freebsd.org> References: <200610150504.k9F548ld008933@repoman.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 5.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Oct_27_05_16_37_2006_905)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (mail.allbsd.org [133.31.130.32]); Fri, 27 Oct 2006 05:39:48 +0900 (JST) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci agp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 20:39:51 -0000 ----Security_Multipart(Fri_Oct_27_05_16_37_2006_905)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Seigo Tanimura wrote in <200610150504.k9F548ld008933@repoman.freebsd.org>: ta> tanimura 2006-10-15 05:04:07 UTC ta> ta> FreeBSD src repository ta> ta> Modified files: ta> sys/pci agp.c ta> Log: ta> Fix the wraparound of memsize >=2GB. ta> ta> Revision Changes Path ta> 1.54 +3 -2 src/sys/pci/agp.c I have doubt about this change because int memsize->u_int memsize does not solve the problem directly; memsize never occurs wraparound actually and an implicit cast to unsigned int just makes the problem invisible. The questionable code fragment in agp.c is the following: memsize = ptoa(Maxmem) >> 20; for (i = 0; i < agp_max_size; i++) { if (memsize <= agp_max[i][0]) break; } ptoa(Maxmem)>>20 will occur a wraparound problem when Maxmem>=2GB, so this part should be fixed instead. BTW, this should be a problem only on i386 since the definition of ptoa() is "#define ptoa(x) ((x) << PAGE_SHIFT)". The other platforms use a cast like "#define ptoa(x) ((unsigned long)(x) << PAGE_SHIFT)". I think it can be solved by using "ptoa((unsigned long)Maxmem)" or so, but I am not sure if this is reasonable because there are more notional types like vm_paddr_t. If "#define ptoa(x) ((vm_paddr_t)(x) << PAGE_SHIFT)" works fine on all platforms, it looks more reasonable to me, but I have a misunderstanding? -- | Hiroki SATO ----Security_Multipart(Fri_Oct_27_05_16_37_2006_905)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBFQRenTyzT2CeTzy0RAicwAJ4j9uhCcWHrdHHt50rn7kpgtKkOtQCfZJzg WOMIuEdSAL9jIJs1aR+NKGY= =T7Vu -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Oct_27_05_16_37_2006_905)---- From owner-cvs-src@FreeBSD.ORG Thu Oct 26 21:42:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1A5E16A417; Thu, 26 Oct 2006 21:42:23 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E4EC43D55; Thu, 26 Oct 2006 21:42:23 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QLgNDZ035967; Thu, 26 Oct 2006 21:42:23 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QLgNoP035966; Thu, 26 Oct 2006 21:42:23 GMT (envelope-from jb) Message-Id: <200610262142.k9QLgNoP035966@repoman.freebsd.org> From: John Birrell Date: Thu, 26 Oct 2006 21:42:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src UPDATING src/lib/libkvm kvm_proc.c src/sys/amd64/amd64 machdep.c trap.c src/sys/amd64/conf GENERIC src/sys/arm/arm trap.c src/sys/arm/at91 kb920x_machdep.c src/sys/arm/conf EP80219 IQ31244 KB920X SIMICS SKYEYE ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 21:42:24 -0000 jb 2006-10-26 21:42:23 UTC FreeBSD src repository Modified files: . UPDATING lib/libkvm kvm_proc.c sys/amd64/amd64 machdep.c trap.c sys/amd64/conf GENERIC sys/arm/arm trap.c sys/arm/at91 kb920x_machdep.c sys/arm/conf EP80219 IQ31244 KB920X SIMICS SKYEYE sys/arm/sa11x0 assabet_machdep.c sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/ddb db_ps.c sys/fs/procfs procfs_status.c sys/i386/conf GENERIC sys/i386/i386 machdep.c trap.c sys/ia64/conf GENERIC sys/ia64/ia64 machdep.c trap.c sys/kern init_main.c kern_clock.c kern_fork.c kern_idle.c kern_intr.c kern_kse.c kern_poll.c kern_proc.c kern_resource.c kern_sig.c kern_subr.c kern_switch.c kern_synch.c kern_thr.c kern_thread.c kern_umtx.c sched_4bsd.c sched_ule.c subr_trap.c sys_process.c tty.c sys/pc98/conf GENERIC sys/pc98/pc98 machdep.c sys/posix4 ksched.c sys/powerpc/conf GENERIC sys/powerpc/powerpc machdep.c trap.c sys/sparc64/conf GENERIC sys/sparc64/sparc64 machdep.c trap.c sys/sun4v/sun4v machdep.c sys/sys proc.h rtprio.h sched.h sys/vm vm_glue.c vm_zeroidle.c Log: Make KSE a kernel option, turned on by default in all GENERIC kernel configs except sun4v (which doesn't process signals properly with KSE). Reviewed by: davidxu@ Revision Changes Path 1.461 +9 -0 src/UPDATING 1.89 +4 -4 src/lib/libkvm/kvm_proc.c 1.657 +4 -0 src/sys/amd64/amd64/machdep.c 1.311 +4 -0 src/sys/amd64/amd64/trap.c 1.467 +1 -0 src/sys/amd64/conf/GENERIC 1.32 +6 -0 src/sys/arm/arm/trap.c 1.18 +4 -0 src/sys/arm/at91/kb920x_machdep.c 1.2 +1 -0 src/sys/arm/conf/EP80219 1.16 +1 -0 src/sys/arm/conf/IQ31244 1.10 +1 -0 src/sys/arm/conf/KB920X 1.11 +1 -0 src/sys/arm/conf/SIMICS 1.6 +1 -0 src/sys/arm/conf/SKYEYE 1.19 +4 -0 src/sys/arm/sa11x0/assabet_machdep.c 1.3 +4 -0 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.24 +4 -0 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.64 +4 -0 src/sys/ddb/db_ps.c 1.58 +10 -0 src/sys/fs/procfs/procfs_status.c 1.458 +1 -0 src/sys/i386/conf/GENERIC 1.638 +4 -0 src/sys/i386/i386/machdep.c 1.297 +4 -0 src/sys/i386/i386/trap.c 1.85 +1 -0 src/sys/ia64/conf/GENERIC 1.209 +4 -0 src/sys/ia64/ia64/machdep.c 1.125 +2 -0 src/sys/ia64/ia64/trap.c 1.269 +28 -0 src/sys/kern/init_main.c 1.191 +19 -0 src/sys/kern/kern_clock.c 1.263 +12 -0 src/sys/kern/kern_fork.c 1.44 +9 -0 src/sys/kern/kern_idle.c 1.135 +4 -0 src/sys/kern/kern_intr.c 1.224 +28 -0 src/sys/kern/kern_kse.c 1.27 +4 -0 src/sys/kern/kern_poll.c 1.245 +25 -2 src/sys/kern/kern_proc.c 1.161 +86 -0 src/sys/kern/kern_resource.c 1.335 +60 -0 src/sys/kern/kern_sig.c 1.98 +4 -0 src/sys/kern/kern_subr.c 1.123 +68 -0 src/sys/kern/kern_switch.c 1.282 +2 -0 src/sys/kern/kern_synch.c 1.54 +24 -0 src/sys/kern/kern_thr.c 1.236 +105 -0 src/sys/kern/kern_thread.c 1.53 +6 -0 src/sys/kern/kern_umtx.c 1.88 +358 -0 src/sys/kern/sched_4bsd.c 1.166 +173 -234 src/sys/kern/sched_ule.c 1.289 +12 -0 src/sys/kern/subr_trap.c 1.141 +6 -0 src/sys/kern/sys_process.c 1.262 +11 -0 src/sys/kern/tty.c 1.286 +1 -0 src/sys/pc98/conf/GENERIC 1.381 +4 -0 src/sys/pc98/pc98/machdep.c 1.32 +18 -0 src/sys/posix4/ksched.c 1.62 +1 -0 src/sys/powerpc/conf/GENERIC 1.97 +4 -0 src/sys/powerpc/powerpc/machdep.c 1.63 +2 -0 src/sys/powerpc/powerpc/trap.c 1.117 +1 -0 src/sys/sparc64/conf/GENERIC 1.130 +4 -0 src/sys/sparc64/sparc64/machdep.c 1.86 +2 -0 src/sys/sparc64/sparc64/trap.c 1.3 +4 -0 src/sys/sun4v/sun4v/machdep.c 1.461 +102 -1 src/sys/sys/proc.h 1.16 +6 -0 src/sys/sys/rtprio.h 1.28 +16 -0 src/sys/sys/sched.h 1.217 +32 -1 src/sys/vm/vm_glue.c 1.40 +4 -0 src/sys/vm/vm_zeroidle.c From owner-cvs-src@FreeBSD.ORG Thu Oct 26 22:05:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 790B716A40F; Thu, 26 Oct 2006 22:05:26 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 439DE43D46; Thu, 26 Oct 2006 22:05:26 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QM5Q5j041418; Thu, 26 Oct 2006 22:05:26 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QM5QIX041417; Thu, 26 Oct 2006 22:05:26 GMT (envelope-from jb) Message-Id: <200610262205.k9QM5QIX041417@repoman.freebsd.org> From: John Birrell Date: Thu, 26 Oct 2006 22:05:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src UPDATING src/sys/amd64/conf DEFAULTS src/sys/i386/conf DEFAULTS src/sys/ia64/conf DEFAULTS src/sys/pc98/conf DEFAULTS src/sys/powerpc/conf DEFAULTS src/sys/sparc64/conf DEFAULTS src/sys/sun4v/conf DEFAULTS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 22:05:26 -0000 jb 2006-10-26 22:05:25 UTC FreeBSD src repository Modified files: . UPDATING sys/amd64/conf DEFAULTS sys/i386/conf DEFAULTS sys/ia64/conf DEFAULTS sys/pc98/conf DEFAULTS sys/powerpc/conf DEFAULTS sys/sparc64/conf DEFAULTS sys/sun4v/conf DEFAULTS Log: Add 'options KSE' to the kernel config DEFAULTS on all arches/machines except sun4v. This change makes the transition from a default to an option more transparent and is an attempt to head off all the compliants that are likely from people who don't read UPDATING, based on experience with the io/mem change. Submitted by: scottl@ Revision Changes Path 1.462 +6 -7 src/UPDATING 1.7 +3 -0 src/sys/amd64/conf/DEFAULTS 1.7 +3 -0 src/sys/i386/conf/DEFAULTS 1.7 +2 -0 src/sys/ia64/conf/DEFAULTS 1.7 +3 -0 src/sys/pc98/conf/DEFAULTS 1.5 +3 -0 src/sys/powerpc/conf/DEFAULTS 1.7 +3 -0 src/sys/sparc64/conf/DEFAULTS 1.2 +1 -1 src/sys/sun4v/conf/DEFAULTS From owner-cvs-src@FreeBSD.ORG Thu Oct 26 22:11:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8037C16A403; Thu, 26 Oct 2006 22:11:36 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 493D643D46; Thu, 26 Oct 2006 22:11:36 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QMBaUq042505; Thu, 26 Oct 2006 22:11:36 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QMBaaw042504; Thu, 26 Oct 2006 22:11:36 GMT (envelope-from jb) Message-Id: <200610262211.k9QMBaaw042504@repoman.freebsd.org> From: John Birrell Date: Thu, 26 Oct 2006 22:11:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf EP80219 IQ31244 KB920X SIMICS SKYEYE src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 22:11:36 -0000 jb 2006-10-26 22:11:36 UTC FreeBSD src repository Modified files: sys/amd64/conf GENERIC sys/arm/conf EP80219 IQ31244 KB920X SIMICS SKYEYE sys/i386/conf GENERIC sys/ia64/conf GENERIC sys/pc98/conf GENERIC sys/powerpc/conf GENERIC sys/sparc64/conf GENERIC Log: Remove the KSE option now that it's in DEFAULTS on these arches/machines. The 'nooption' kernel config entry has to be used to turn KSE off now. This isn't my preferred way of dealing with this, but I'll defer to scottl's experience with the io/mem kernel option change and the grief experienced over that. Submitted by: scottl@ Revision Changes Path 1.468 +0 -1 src/sys/amd64/conf/GENERIC 1.3 +0 -1 src/sys/arm/conf/EP80219 1.17 +0 -1 src/sys/arm/conf/IQ31244 1.11 +0 -1 src/sys/arm/conf/KB920X 1.12 +0 -1 src/sys/arm/conf/SIMICS 1.7 +0 -1 src/sys/arm/conf/SKYEYE 1.459 +0 -1 src/sys/i386/conf/GENERIC 1.86 +0 -1 src/sys/ia64/conf/GENERIC 1.287 +0 -1 src/sys/pc98/conf/GENERIC 1.63 +0 -1 src/sys/powerpc/conf/GENERIC 1.118 +0 -1 src/sys/sparc64/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Thu Oct 26 22:33:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D27116A531; Thu, 26 Oct 2006 22:33:39 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4DFA43D45; Thu, 26 Oct 2006 22:33:38 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9QMXcNG046420; Thu, 26 Oct 2006 22:33:38 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9QMXctp046419; Thu, 26 Oct 2006 22:33:38 GMT (envelope-from imp) Message-Id: <200610262233.k9QMXctp046419@repoman.freebsd.org> From: Warner Losh Date: Thu, 26 Oct 2006 22:33:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/fwcontrol Makefile fwcontrol.8 fwcontrol.c fwdv.c fwmethods.h fwmpegts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2006 22:33:39 -0000 imp 2006-10-26 22:33:38 UTC FreeBSD src repository Modified files: usr.sbin/fwcontrol Makefile fwcontrol.8 fwcontrol.c fwdv.c Added files: usr.sbin/fwcontrol fwmethods.h fwmpegts.c Log: Add MPEG2-TS/HDV support to fwcontrol. Submitted by: Petr Holub" Clean up by: mi@ Pr: 98134 Revision Changes Path 1.5 +2 -1 src/usr.sbin/fwcontrol/Makefile 1.17 +57 -5 src/usr.sbin/fwcontrol/fwcontrol.8 1.23 +86 -16 src/usr.sbin/fwcontrol/fwcontrol.c 1.6 +42 -34 src/usr.sbin/fwcontrol/fwdv.c 1.1 +10 -0 src/usr.sbin/fwcontrol/fwmethods.h (new) 1.1 +267 -0 src/usr.sbin/fwcontrol/fwmpegts.c (new) From owner-cvs-src@FreeBSD.ORG Fri Oct 27 00:04:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD48416A40F; Fri, 27 Oct 2006 00:04:03 +0000 (UTC) (envelope-from tanimura@tanimura.dyndns.org) Received: from silver.tanimura.dyndns.org (fntkngw003003.kngw.fnt.adsl.ppp.infoweb.ne.jp [222.158.252.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id C166A43D5D; Fri, 27 Oct 2006 00:04:02 +0000 (GMT) (envelope-from tanimura@tanimura.dyndns.org) Received: from silver.tanimura.dyndns.org (localhost [IPv6:::1]) by silver.tanimura.dyndns.org (8.13.7/3.7W-carrots-Keikyu-Kurihama) with ESMTP id k9R03ula032256 ; Fri, 27 Oct 2006 09:03:56 +0900 (JST) Message-Id: <200610270003.k9R03ula032256@silver.tanimura.dyndns.org> Date: Fri, 27 Oct 2006 09:03:56 +0900 From: Seigo Tanimura To: Hiroki Sato In-Reply-To: <20061027.051637.115993470.hrs@allbsd.org> References: <200610150504.k9F548ld008933@repoman.freebsd.org> <20061027.051637.115993470.hrs@allbsd.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 MULE XEmacs/21.4 (patch 19) (Constant Variable) (i386--freebsd) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=5.9 required=8.0 tests=AWL,BAYES_50,NO_RECEIVED, NO_RELAYS autolearn=no version=3.1.5 X-Spam-Level: ***** X-Spam-Checker-Version: SpamAssassin 3.1.5 (2006-08-29) on silver.tanimura.dyndns.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, re@FreeBSD.org, cvs-all@FreeBSD.org, tanimura@FreeBSD.org Subject: Re: cvs commit: src/sys/pci agp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 00:04:03 -0000 On Fri, 27 Oct 2006 05:16:37 +0900 (JST), Hiroki Sato said: hrs> Seigo Tanimura wrote hrs> in <200610150504.k9F548ld008933@repoman.freebsd.org>: ta> tanimura 2006-10-15 05:04:07 UTC ta> ta> FreeBSD src repository ta> ta> Modified files: ta> sys/pci agp.c ta> Log: ta> Fix the wraparound of memsize >=2GB. ta> ta> Revision Changes Path ta> 1.54 +3 -2 src/sys/pci/agp.c hrs> I have doubt about this change because int memsize->u_int memsize hrs> does not solve the problem directly; memsize never occurs wraparound hrs> actually and an implicit cast to unsigned int just makes the problem hrs> invisible. The questionable code fragment in agp.c is the following: hrs> memsize = ptoa(Maxmem) >> 20; hrs> for (i = 0; i < agp_max_size; i++) { hrs> if (memsize <= agp_max[i][0]) hrs> break; hrs> } hrs> ptoa(Maxmem)>>20 will occur a wraparound problem when Maxmem>=2GB, so hrs> this part should be fixed instead. BTW, this should be a problem hrs> only on i386 since the definition of ptoa() is "#define ptoa(x) ((x) hrs> << PAGE_SHIFT)". The other platforms use a cast like "#define hrs> ptoa(x) ((unsigned long)(x) << PAGE_SHIFT)". hrs> I think it can be solved by using "ptoa((unsigned long)Maxmem)" or hrs> so, but I am not sure if this is reasonable because there are more hrs> notional types like vm_paddr_t. If "#define ptoa(x) ((vm_paddr_t)(x) hrs> << PAGE_SHIFT)" works fine on all platforms, it looks more reasonable hrs> to me, but I have a misunderstanding? ptoa() is machine-dependent; (unsigned long) should be OK. (vm_paddr_t) would mess up the namespace. What hassles me is that Maxmem is *NOT* unsigned, grrr... hrs> -- hrs> | Hiroki SATO -- Seigo Tanimura From owner-cvs-src@FreeBSD.ORG Fri Oct 27 00:38:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E687F16A403; Fri, 27 Oct 2006 00:38:47 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5A1743D46; Fri, 27 Oct 2006 00:38:47 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9R0cl2x067208; Fri, 27 Oct 2006 00:38:47 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9R0clX8067207; Fri, 27 Oct 2006 00:38:47 GMT (envelope-from pjd) Message-Id: <200610270038.k9R0clX8067207@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Fri, 27 Oct 2006 00:38:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 00:38:48 -0000 pjd 2006-10-27 00:38:47 UTC FreeBSD src repository Modified files: . access Log: Note that kib is now free from mentorship. Discussed with: kan Approved by: core (blanket) Revision Changes Path 1.798 +0 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Fri Oct 27 05:45:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9800D16A415; Fri, 27 Oct 2006 05:45:45 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4DD9743D58; Fri, 27 Oct 2006 05:45:45 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9R5jj1H037864; Fri, 27 Oct 2006 05:45:45 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9R5jjZb037863; Fri, 27 Oct 2006 05:45:45 GMT (envelope-from davidxu) Message-Id: <200610270545.k9R5jjZb037863@repoman.freebsd.org> From: David Xu Date: Fri, 27 Oct 2006 05:45:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys proc.h src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 05:45:45 -0000 davidxu 2006-10-27 05:45:44 UTC FreeBSD src repository Modified files: sys/sys proc.h sys/kern kern_thread.c Log: Remove member p_procscopegrp which is no longer used by libthr. Revision Changes Path 1.237 +0 -8 src/sys/kern/kern_thread.c 1.462 +0 -3 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Fri Oct 27 08:20:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B3CE16A532; Fri, 27 Oct 2006 08:20:25 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18D3A43D4C; Fri, 27 Oct 2006 08:20:25 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9R8KO4V071171; Fri, 27 Oct 2006 08:20:24 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9R8KO1J071166; Fri, 27 Oct 2006 08:20:24 GMT (envelope-from ume) Message-Id: <200610270820.k9R8KO1J071166@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Fri, 27 Oct 2006 08:20:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/resolv res_send.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 08:20:25 -0000 ume 2006-10-27 08:20:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/resolv res_send.c Log: MFC 1.4: Retransmission timeouts should be based on which attempt it is to the nameserver and not the nameserver itself. Approved by: re (hrs) Obtained from: BIND 9.3.3rc2 Revision Changes Path 1.2.2.3 +7 -6 src/lib/libc/resolv/res_send.c From owner-cvs-src@FreeBSD.ORG Fri Oct 27 08:26:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E86016A412; Fri, 27 Oct 2006 08:26:25 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CA0243D46; Fri, 27 Oct 2006 08:26:25 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9R8QPYR072578; Fri, 27 Oct 2006 08:26:25 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9R8QPRH072577; Fri, 27 Oct 2006 08:26:25 GMT (envelope-from trhodes) Message-Id: <200610270826.k9R8QPRH072577@repoman.freebsd.org> From: Tom Rhodes Date: Fri, 27 Oct 2006 08:26:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/cp cp.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 08:26:25 -0000 trhodes 2006-10-27 08:26:24 UTC FreeBSD src repository Modified files: bin/cp cp.1 Log: Wording nits. Revision Changes Path 1.38 +7 -11 src/bin/cp/cp.1 From owner-cvs-src@FreeBSD.ORG Fri Oct 27 08:49:39 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 786DD16A40F; Fri, 27 Oct 2006 08:49:39 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE5CD43DA6; Fri, 27 Oct 2006 08:48:57 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id DC29E32A5D2; Fri, 27 Oct 2006 18:48:45 +1000 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id A62AD8C37; Fri, 27 Oct 2006 18:48:43 +1000 (EST) Date: Fri, 27 Oct 2006 18:48:42 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Seigo Tanimura In-Reply-To: <200610270003.k9R03ula032256@silver.tanimura.dyndns.org> Message-ID: <20061027171035.M10227@delplex.bde.org> References: <200610150504.k9F548ld008933@repoman.freebsd.org> <20061027.051637.115993470.hrs@allbsd.org> <200610270003.k9R03ula032256@silver.tanimura.dyndns.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, re@freebsd.org, cvs-src@freebsd.org, Hiroki Sato , cvs-all@freebsd.org, tanimura@freebsd.org Subject: Re: cvs commit: src/sys/pci agp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 08:49:39 -0000 On Fri, 27 Oct 2006, Seigo Tanimura wrote: > On Fri, 27 Oct 2006 05:16:37 +0900 (JST), > Hiroki Sato said: > ... > hrs> I have doubt about this change because int memsize->u_int memsize > hrs> does not solve the problem directly; memsize never occurs wraparound > hrs> actually and an implicit cast to unsigned int just makes the problem > hrs> invisible. The questionable code fragment in agp.c is the following: > > hrs> memsize = ptoa(Maxmem) >> 20; > hrs> for (i = 0; i < agp_max_size; i++) { > hrs> if (memsize <= agp_max[i][0]) > hrs> break; > hrs> } > > hrs> ptoa(Maxmem)>>20 will occur a wraparound problem when Maxmem>=2GB, so > hrs> this part should be fixed instead. BTW, this should be a problem > hrs> only on i386 since the definition of ptoa() is "#define ptoa(x) ((x) > hrs> << PAGE_SHIFT)". The other platforms use a cast like "#define > hrs> ptoa(x) ((unsigned long)(x) << PAGE_SHIFT)". I added some casts like that, but the author of PAE (jake@) wanted to avoid casts in macros. I don't remember exactly why. There are arguments for both ways. > hrs> I think it can be solved by using "ptoa((unsigned long)Maxmem)" or > hrs> so, but I am not sure if this is reasonable because there are more > hrs> notional types like vm_paddr_t. If "#define ptoa(x) ((vm_paddr_t)(x) > hrs> << PAGE_SHIFT)" works fine on all platforms, it looks more reasonable > hrs> to me, but I have a misunderstanding? Casting to vm_paddr_t is much better than casting to u_long. I may have added the similar cast to btoc(). It is wrong. btoc() cass to vm_offset_t but it should cast to vm_ooffset_t if anything so that casting to it doesn't break the case where the arg is a large physical byte count. This is one of the arguments for not casting -- if we don't cast, then if the arg is an unsigned type or a signed type with a positive value, than at least right shifting will give the correct value; then the cast, if any, should be applied to the result of the shift, to convert to the different type for a page count; however, such a cast would blindly truncate the value if it is unrepresentable in the new type, so it probably doesn't belong in the macro. In my local version, there is no cast in btoc(), but there is a cast to vm_size_t in ctob(). It is unclear whether btoc()/ctob() are supposed to work with physical or virtual byte counts. I guess jake's argument for not casting in the macro even for left shifts was similar: suppose we start with a page count and left shift to a byte count as in ptoa(). Then the result is a vm_paddr_t and might not fit in a vm_paddr_t. The caller needs to be aware that the result might be very large, and it is a small step from there to casting the arg appropriately, and an explicit cast provides some self-documentation that this case can happen. In the above code, the caller just assumes ptoa() doesn't overflow and that right shifting by 20 gives a size that doesn't overflow on assignment to `int memsize'. MD code for Maxmem in i386/machdep.c always casts it in calls to ptoa(). However, half the calls bogusly cast it to uintmax_t and then bogusly assume that the result is still uintmax_t so that it can be printed using %ju. It is the results that must be cast to uintmax_t; the args must be cast as necessary to avoid overflow. One of the buggy calls is for caclulating the size in MB as above; it spells the right shift by 20 as division by 1048576. I added not-so-similar casts to btodb() and dbtob(). The one for btodb() is bogus :-(. It wants to promote to an unsigned type in case the byte count is negative (the arg has type off_t so it can be negative in theory), but that case shouldn't happen, and if it does then the casts mess up the result further. For efficiency, It wants to promote to the smallest unsigned type possible, but it doesn't handle the case where sizeof(unsigned) < sizeof(unsigned long). it assumes that sizeof(daddr_t) < sizeof(unsigned long long). It became even more bogus many years after it was written, when daddr_t was changed from 32 bits to 64 bits. Now the optimized case is rarely used. > ptoa() is machine-dependent; (unsigned long) should be OK. > (vm_paddr_t) would mess up the namespace. The machine-dependence and duplication of macros for converting between bytes and pages is another bug. For i386's, there are atop()/ptoa(), i386_btop()/i386_ptob() which are "MD", and btoc()/ctob() which are MI. The difference between addresses and byte counts is subtle but shouldn't be MD. The difference between pages and clicks should be large (clicks should no longer exist) and MI, but is currently subtle and MD. vm has different types for sizes, addresses and offsets and for virtual/physical variants of some of these, but there aren't enough macros for all the combinations and having a choice for only some of the combinations is worse than not having a choice. (vm_offset_t) is still used for the bogus btoc() macro. It is as MI as vm_[p]addr_t (i.e., it is not very MI, but is MI enough, since we only support machines with flat address spaces). There is a minor problem with vm_paddr_t only being declared in vm headers while it is referenced in param.h. > What hassles me is that Maxmem is *NOT* unsigned, grrr... Using unsigned types to represent values just because the values are never negative is another common type error. It mainly gives sign extension bugs for arithmetic on such values in expressions where intermediate values are negative, and inhibits detection of overflows via overflow traps. Thus the signedness of Maxmem is a feature, but strictly, Maxmem should be a vm_size_t, which happens to be uint32_t or uint64_t on supported arches. However, even vm is sloppy about page counts. It uses struct vmmmeter for lots of fundamental page counts, and struct vmmeter uses u_int for page counts. vm also uses scale factors when it initializes parameters based on these page counts, so it will break long before the counts reach UINT_MAX. Using signed integers for the page counts and getting overflow traps when the scaling overflows would be a good way of detecting the breakage. Someone should fix this before machines with a few TB of physical memory are common. Bruce From owner-cvs-src@FreeBSD.ORG Fri Oct 27 10:52:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB44216A417; Fri, 27 Oct 2006 10:52:33 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67F0743D5E; Fri, 27 Oct 2006 10:52:33 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RAqXZs090628; Fri, 27 Oct 2006 10:52:33 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RAqXIU090626; Fri, 27 Oct 2006 10:52:33 GMT (envelope-from oleg) Message-Id: <200610271052.k9RAqXIU090626@repoman.freebsd.org> From: Oleg Bulyzhin Date: Fri, 27 Oct 2006 10:52:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_dummynet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 10:52:34 -0000 oleg 2006-10-27 10:52:33 UTC FreeBSD src repository Modified files: sys/netinet ip_dummynet.c Log: style(9) cleanup. MFC after: 2 month Revision Changes Path 1.102 +357 -334 src/sys/netinet/ip_dummynet.c From owner-cvs-src@FreeBSD.ORG Fri Oct 27 11:01:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 835BB16A407; Fri, 27 Oct 2006 11:01:48 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4128743D5E; Fri, 27 Oct 2006 11:01:48 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RB1mmQ091861; Fri, 27 Oct 2006 11:01:48 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RB1lx8091860; Fri, 27 Oct 2006 11:01:47 GMT (envelope-from ru) Message-Id: <200610271101.k9RB1lx8091860@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 27 Oct 2006 11:01:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/config config.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 11:01:48 -0000 ru 2006-10-27 11:01:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/config config.8 Log: MFC: 1.45: Comment out the first paragraph; while it tells the true (we're using the old BSD config(8) utility in FreeBSD), it does not look good. PR: docs/100328 Approved by: re (blanket) Revision Changes Path 1.43.2.2 +14 -14 src/usr.sbin/config/config.8 From owner-cvs-src@FreeBSD.ORG Fri Oct 27 11:03:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DFDF16A415; Fri, 27 Oct 2006 11:03:36 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E129C43D66; Fri, 27 Oct 2006 11:03:35 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RB3Z5o093492; Fri, 27 Oct 2006 11:03:35 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RB3Z4j093491; Fri, 27 Oct 2006 11:03:35 GMT (envelope-from ru) Message-Id: <200610271103.k9RB3Z4j093491@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 27 Oct 2006 11:03:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man8 intro.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 11:03:36 -0000 ru 2006-10-27 11:03:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man8 intro.8 Log: MFC: 1.12: Make it clear that section 8 also documents system management procedures, not necessarily commands. PR: docs/35011 Approved by: re (blanket) Revision Changes Path 1.11.12.1 +28 -17 src/share/man/man8/intro.8 From owner-cvs-src@FreeBSD.ORG Fri Oct 27 11:16:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33FB016A40F; Fri, 27 Oct 2006 11:16:59 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E31C843D49; Fri, 27 Oct 2006 11:16:58 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RBGw7d095569; Fri, 27 Oct 2006 11:16:58 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RBGw2f095568; Fri, 27 Oct 2006 11:16:58 GMT (envelope-from oleg) Message-Id: <200610271116.k9RBGw2f095568@repoman.freebsd.org> From: Oleg Bulyzhin Date: Fri, 27 Oct 2006 11:16:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_dummynet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 11:16:59 -0000 oleg 2006-10-27 11:16:58 UTC FreeBSD src repository Modified files: sys/netinet ip_dummynet.c Log: Use separate thread for servicing dummynet(4). Utilize taskqueue(9) API. Submitted by: glebius MFC after: 2 month Revision Changes Path 1.103 +32 -3 src/sys/netinet/ip_dummynet.c From owner-cvs-src@FreeBSD.ORG Fri Oct 27 13:05:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2390816A40F; Fri, 27 Oct 2006 13:05:39 +0000 (UTC) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59D6343D72; Fri, 27 Oct 2006 13:05:38 +0000 (GMT) (envelope-from oleg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RD5cxf022594; Fri, 27 Oct 2006 13:05:38 GMT (envelope-from oleg@repoman.freebsd.org) Received: (from oleg@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RD5cAJ022591; Fri, 27 Oct 2006 13:05:38 GMT (envelope-from oleg) Message-Id: <200610271305.k9RD5cAJ022591@repoman.freebsd.org> From: Oleg Bulyzhin Date: Fri, 27 Oct 2006 13:05:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_dummynet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 13:05:39 -0000 oleg 2006-10-27 13:05:38 UTC FreeBSD src repository Modified files: sys/netinet ip_dummynet.c Log: - Convert net.inet.ip.dummynet.curr_time net.inet.ip.dummynet.searches net.inet.ip.dummynet.search_steps to SYSCTL_LONG nodes. It will prevent frequent wrap around on 64bit archs. - Implement simple mechanics for dummynet(4) internal time correction. Under certain circumstances (system high load, dummynet lock contention, etc) dummynet's tick counter can be significantly slower than it should be. (I've observed up to 25% difference on one of my production servers). Since this counter used for packet scheduling, it's accuracy is vital for precise bandwidth limitation. Introduce new sysctl nodes: net.inet.ip.dummynet. tick_lost - number of ticks coalesced by taskqueue thread. tick_adjustment - number of time corrections done. tick_diff - adjusted vs non-adjusted tick counter difference tick_delta - last vs 'standard' tick differnece (usec). tick_delta_sum - accumulated (and not corrected yet) time difference (usec). Reviewed by: glebius MFC after: 2 month Revision Changes Path 1.104 +62 -5 src/sys/netinet/ip_dummynet.c From owner-cvs-src@FreeBSD.ORG Fri Oct 27 14:21:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2E3D16A4D0; Fri, 27 Oct 2006 14:21:28 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3042E43F08; Fri, 27 Oct 2006 14:18:01 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9REHo8t040734; Fri, 27 Oct 2006 14:17:50 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9REHoAC040733; Fri, 27 Oct 2006 14:17:50 GMT (envelope-from bde) Message-Id: <200610271417.k9REHoAC040733@repoman.freebsd.org> From: Bruce Evans Date: Fri, 27 Oct 2006 14:17:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include asmacros.h src/sys/i386/isa prof_machdep.c src/sys/amd64/amd64 prof_machdep.c src/sys/amd64/include asmacros.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 14:21:28 -0000 bde 2006-10-27 14:17:50 UTC FreeBSD src repository Modified files: sys/i386/include asmacros.h sys/i386/isa prof_machdep.c sys/amd64/amd64 prof_machdep.c sys/amd64/include asmacros.h Log: Don't call mexitcount or provide a stub mexitcount to call when profiling is configured but high resolution profiling is not configured. Only functions in *.[Ss] called the stub, so efficiency was not significantly affected. Revision Changes Path 1.25 +0 -13 src/sys/amd64/amd64/prof_machdep.c 1.31 +4 -0 src/sys/amd64/include/asmacros.h 1.28 +4 -0 src/sys/i386/include/asmacros.h 1.26 +0 -11 src/sys/i386/isa/prof_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Oct 27 19:28:56 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72CDF16A415; Fri, 27 Oct 2006 19:28:56 +0000 (UTC) (envelope-from prvs=julian=44840db18@elischer.org) Received: from a50.ironport.com (a50.ironport.com [63.251.108.112]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2A7F43D73; Fri, 27 Oct 2006 19:28:49 +0000 (GMT) (envelope-from prvs=julian=44840db18@elischer.org) Received: from unknown (HELO [10.251.18.229]) ([10.251.18.229]) by a50.ironport.com with ESMTP; 27 Oct 2006 12:28:49 -0700 Message-ID: <45425DF1.7070403@elischer.org> Date: Fri, 27 Oct 2006 12:28:49 -0700 From: Julian Elischer User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) MIME-Version: 1.0 To: David Xu References: <200610270545.k9R5jjZb037863@repoman.freebsd.org> In-Reply-To: <200610270545.k9R5jjZb037863@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 19:28:56 -0000 David Xu wrote: > davidxu 2006-10-27 05:45:44 UTC > > FreeBSD src repository > > Modified files: > sys/sys proc.h > sys/kern kern_thread.c > Log: > Remove member p_procscopegrp which is no longer used by libthr. but should be.. (see other email) > > Revision Changes Path > 1.237 +0 -8 src/sys/kern/kern_thread.c > 1.462 +0 -3 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Fri Oct 27 19:45:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFBF616A55B; Fri, 27 Oct 2006 19:45:31 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9616843D46; Fri, 27 Oct 2006 19:45:30 +0000 (GMT) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9RJjUSB006385; Fri, 27 Oct 2006 19:45:30 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9RJjUOL006384; Fri, 27 Oct 2006 19:45:30 GMT (envelope-from thompsa) Message-Id: <200610271945.k9RJjUOL006384@repoman.freebsd.org> From: Andrew Thompson Date: Fri, 27 Oct 2006 19:45:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 if_bridge.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2006 19:45:32 -0000 thompsa 2006-10-27 19:45:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 if_bridge.4 Log: MFC r1.25 Document net.link.bridge.ipfw_arp for filtering ARP packets with ipfw. Approved by: re (hrs) Revision Changes Path 1.5.2.13 +11 -0 src/share/man/man4/if_bridge.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 28 00:47:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E14D016A407; Sat, 28 Oct 2006 00:47:55 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F79643D45; Sat, 28 Oct 2006 00:47:55 +0000 (GMT) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S0ltC0080234; Sat, 28 Oct 2006 00:47:55 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S0lttZ080233; Sat, 28 Oct 2006 00:47:55 GMT (envelope-from jfv) Message-Id: <200610280047.k9S0lttZ080233@repoman.freebsd.org> From: Jack F Vogel Date: Sat, 28 Oct 2006 00:47:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 00:47:56 -0000 jfv 2006-10-28 00:47:55 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h Log: This is the merge of the Intel 6.2.9 driver. It provides all new shared code, new device support, and it is hoped a more stable driver for 6.2. RELEASE. This checkin was discussed and approved today by RE, scottl, jhb, and pdeuskar Revision Changes Path 1.155 +664 -873 src/sys/dev/em/if_em.c 1.51 +94 -76 src/sys/dev/em/if_em.h 1.23 +574 -531 src/sys/dev/em/if_em_hw.c 1.23 +125 -175 src/sys/dev/em/if_em_hw.h 1.19 +46 -52 src/sys/dev/em/if_em_osdep.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 01:37:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D5C516A4D2; Sat, 28 Oct 2006 01:37:15 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28FB543D49; Sat, 28 Oct 2006 01:37:15 +0000 (GMT) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S1bFSq089276; Sat, 28 Oct 2006 01:37:15 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S1bFq2089275; Sat, 28 Oct 2006 01:37:15 GMT (envelope-from jfv) Message-Id: <200610280137.k9S1bFq2089275@repoman.freebsd.org> From: Jack F Vogel Date: Sat, 28 Oct 2006 01:37:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 01:37:15 -0000 jfv 2006-10-28 01:37:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h Log: Merge of Intel 6.2.9 em driver code. Approved by: re, scottl, jhb, pdeuskar Revision Changes Path 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 06:04:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3AD416A403; Sat, 28 Oct 2006 06:04:29 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3D4443D49; Sat, 28 Oct 2006 06:04:29 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S64Tnd044544; Sat, 28 Oct 2006 06:04:29 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S64TWh044543; Sat, 28 Oct 2006 06:04:29 GMT (envelope-from bde) Message-Id: <200610280604.k9S64TWh044543@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 06:04:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include asmacros.h src/sys/i386/isa prof_machdep.c src/sys/amd64/amd64 prof_machdep.c src/sys/amd64/include asmacros.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 06:04:29 -0000 bde 2006-10-28 06:04:29 UTC FreeBSD src repository Modified files: sys/i386/include asmacros.h sys/i386/isa prof_machdep.c sys/amd64/amd64 prof_machdep.c sys/amd64/include asmacros.h Log: Removed all traces of HIDENAME() in amd64 and i386 kernel code. Using this used to be slightly cleaner than using ifdefs in a few places to support both a.out and elf, but using it now just causes messes and unportabilities. It seems to be impossible to implement the elf HIDENAME() portably in cpp (since token pasting of "." and is invalid). */prof_machdep.c: - Removed all uses of CNAME(). CNAME() is easy enough to use in pure asm code, but using it in inline asm requires messy quoting. The core pure asm code has been hacked on more and all uses of CNAME() in it have already gone away. Just assume the elf convention here too. - Removed now-uneeded include of . - Removed the workaround for a namespace conflict with this include. Revision Changes Path 1.26 +9 -11 src/sys/amd64/amd64/prof_machdep.c 1.32 +3 -5 src/sys/amd64/include/asmacros.h 1.29 +3 -5 src/sys/i386/include/asmacros.h 1.27 +9 -18 src/sys/i386/isa/prof_machdep.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 06:38:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2DAD16A403; Sat, 28 Oct 2006 06:38:51 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FB4143D4C; Sat, 28 Oct 2006 06:38:51 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S6cpki049748; Sat, 28 Oct 2006 06:38:51 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S6cpSo049747; Sat, 28 Oct 2006 06:38:51 GMT (envelope-from bde) Message-Id: <200610280638.k9S6cpSo049747@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 06:38:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/isa prof_machdep.c src/sys/amd64/amd64 prof_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 06:38:52 -0000 bde 2006-10-28 06:38:51 UTC FreeBSD src repository Modified files: sys/i386/isa prof_machdep.c sys/amd64/amd64 prof_machdep.c Log: Cleaned up includes. was unused. was only used in the GUPROF case, so the messes to get its i386 prerequisites included shouldn't have been needed. Fixed some style bugs. Quote #error contents, and don't repeat an #error directive on amd64. Revision Changes Path 1.27 +1 -7 src/sys/amd64/amd64/prof_machdep.c 1.28 +4 -7 src/sys/i386/isa/prof_machdep.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:12:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37BBA16A40F; Sat, 28 Oct 2006 07:12:00 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (vlsi00.si.noda.tus.ac.jp [133.31.130.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78D8443D45; Sat, 28 Oct 2006 07:11:59 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p3098-ipbf401funabasi.chiba.ocn.ne.jp [124.86.53.98]) (authenticated bits=128) by mail.allbsd.org (8.13.1/8.13.4) with ESMTP id k9S7Bkpq014428; Sat, 28 Oct 2006 16:11:57 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id k9S7BOpT039335; Sat, 28 Oct 2006 16:11:27 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sat, 28 Oct 2006 16:10:36 +0900 (JST) Message-Id: <20061028.161036.78701604.hrs@allbsd.org> To: jfv@FreeBSD.org From: Hiroki Sato In-Reply-To: <200610280137.k9S1bFq2089275@repoman.freebsd.org> References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 5.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sat_Oct_28_16_10_36_2006_499)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (mail.allbsd.org [133.31.130.32]); Sat, 28 Oct 2006 16:11:57 +0900 (JST) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:12:00 -0000 ----Security_Multipart(Sat_Oct_28_16_10_36_2006_499)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jack F Vogel wrote in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files: (Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> if_em_osdep.h jf> Log: jf> Merge of Intel 6.2.9 em driver code. jf> Approved by: re, scottl, jhb, pdeuskar jf> jf> Revision Changes Path jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h Just wanted to make sure, but is the following change in if_em.c really intentional? This means that the new version no longer supports 82542... Index: if_em.c @@ -116,8 +117,6 @@ { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, - { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, -- | Hiroki SATO ----Security_Multipart(Sat_Oct_28_16_10_36_2006_499)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBFQwJtTyzT2CeTzy0RAubzAJ9zmXYe5tgB69xP5rdrDzyGAk4GeACffKWs mEQVA09EB58Y25H1bNOf9Fo= =1Az0 -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Oct_28_16_10_36_2006_499)---- From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:19:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C19816A5C7 for ; Sat, 28 Oct 2006 07:19:33 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6560243D53 for ; Sat, 28 Oct 2006 07:19:31 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by nz-out-0102.google.com with SMTP id o37so711763nzf for ; Sat, 28 Oct 2006 00:19:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=f7PBhYVJp0ABqkGJPxsaFFLoRx39K6EzXBWMc7efXAhVLGRiP9ejjjVneoZ4v68Haqj+jMrzlBuSEYVTowNh/SLK+aU15i+ovUeobGydfMNGAcD0f32U8KGNYDQ5ye8Hg2LTCamQZuyfgowzp3geBx+RTci0HAgI4y68ULZY6v0= Received: by 10.35.8.13 with SMTP id l13mr998154pyi; Sat, 28 Oct 2006 00:19:30 -0700 (PDT) Received: by 10.35.118.6 with HTTP; Sat, 28 Oct 2006 00:19:25 -0700 (PDT) Message-ID: <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> Date: Sat, 28 Oct 2006 00:19:25 -0700 From: "Jack Vogel" To: "Hiroki Sato" In-Reply-To: <20061028.161036.78701604.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> <20061028.161036.78701604.hrs@allbsd.org> Cc: jfv@freebsd.org, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:19:33 -0000 On 10/28/06, Hiroki Sato wrote: > Jack F Vogel wrote > in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: > > jf> jfv 2006-10-28 01:37:14 UTC > jf> > jf> FreeBSD src repository > jf> > jf> Modified files: (Branch: RELENG_6) > jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h > jf> if_em_osdep.h > jf> Log: > jf> Merge of Intel 6.2.9 em driver code. > jf> Approved by: re, scottl, jhb, pdeuskar > jf> > jf> Revision Changes Path > jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c > jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h > jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c > jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h > jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h > > Just wanted to make sure, but is the following change in if_em.c > really intentional? This means that the new version no longer > supports 82542... > > Index: if_em.c > @@ -116,8 +117,6 @@ > { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, > { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, > > - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, > - > { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, > { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, Yes that was intentional, its an ID that the Intel source has not had for some time. When I put it back in our source a while back due to a merge our test group came to me and said these adapters dont even work with the driver, so clearly no one is using them :) I asked about dropping the ID to a set of developers and got the OK to drop it. If someone actually speaks up about having hardware that was working and now is broken I'll take it all back and we can put the ID back in, is that good enough? :) Cheers, Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:26:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E74416A407; Sat, 28 Oct 2006 07:26:51 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11B9943D4C; Sat, 28 Oct 2006 07:26:51 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S7Qojm058494; Sat, 28 Oct 2006 07:26:50 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S7QoDZ058493; Sat, 28 Oct 2006 07:26:50 GMT (envelope-from brueffer) Message-Id: <200610280726.k9S7QoDZ058493@repoman.freebsd.org> From: Christian Brueffer Date: Sat, 28 Oct 2006 07:26:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 sis.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:26:51 -0000 brueffer 2006-10-28 07:26:50 UTC FreeBSD src repository Modified files: share/man/man4 sis.4 Log: Document Soekris net48xx support. PR: docs/104865 Submitted by: Henrik Brix Andersen Revision Changes Path 1.24 +2 -2 src/share/man/man4/sis.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:42:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2794216A40F; Sat, 28 Oct 2006 07:42:26 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (vlsi00.si.noda.tus.ac.jp [133.31.130.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B62A43D45; Sat, 28 Oct 2006 07:42:25 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p3098-ipbf401funabasi.chiba.ocn.ne.jp [124.86.53.98]) (authenticated bits=128) by mail.allbsd.org (8.13.1/8.13.4) with ESMTP id k9S7gC6o014772; Sat, 28 Oct 2006 16:42:23 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id k9S7fkdO039476; Sat, 28 Oct 2006 16:41:49 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sat, 28 Oct 2006 16:41:40 +0900 (JST) Message-Id: <20061028.164140.102116870.hrs@allbsd.org> To: jfvogel@gmail.com From: Hiroki Sato In-Reply-To: <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> <20061028.161036.78701604.hrs@allbsd.org> <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 5.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sat_Oct_28_16_41_40_2006_504)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (mail.allbsd.org [133.31.130.32]); Sat, 28 Oct 2006 16:42:24 +0900 (JST) Cc: jfv@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:42:26 -0000 ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Jack Vogel" wrote in <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com>: jf> On 10/28/06, Hiroki Sato wrote: jf> > Jack F Vogel wrote jf> > in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: jf> > jf> > jf> jfv 2006-10-28 01:37:14 UTC jf> > jf> jf> > jf> FreeBSD src repository jf> > jf> jf> > jf> Modified files: (Branch: RELENG_6) jf> > jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> > jf> if_em_osdep.h jf> > jf> Log: jf> > jf> Merge of Intel 6.2.9 em driver code. jf> > jf> Approved by: re, scottl, jhb, pdeuskar jf> > jf> jf> > jf> Revision Changes Path jf> > jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c jf> > jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h jf> > jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c jf> > jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h jf> > jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h jf> > jf> > Just wanted to make sure, but is the following change in if_em.c jf> > really intentional? This means that the new version no longer jf> > supports 82542... jf> > jf> > Index: if_em.c jf> > @@ -116,8 +117,6 @@ jf> > { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > jf> > - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > - jf> > { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> jf> Yes that was intentional, its an ID that the Intel source has not jf> had for some time. When I put it back in our source a while back jf> due to a merge our test group came to me and said these adapters jf> dont even work with the driver, so clearly no one is using them :) jf> jf> I asked about dropping the ID to a set of developers and got the OK to drop jf> it. jf> jf> If someone actually speaks up about having hardware that was working and jf> now is broken I'll take it all back and we can put the ID back in, is that good jf> enough? :) So here is the report (from nyan@): em0@pci1:1:0: class=0x020000 card=0x10008086 chip=0x10008086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = '82542 Gigabit Ethernet Controller' class = network subclass = ethernet It is not recognized by the new driver at boot time while worked fine with the old one. I think we should not remove the existing hardware support (especially in -STABLE) if possible. -- | Hiroki SATO ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBFQwm0TyzT2CeTzy0RAnLLAJ9PhxxczQY/tGdazIx56Kx+LfU5hQCfeQJi GUoghxqg1pYh/SJD3WQ23go= =7uEI -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)---- From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:59:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 504BA16A403; Sat, 28 Oct 2006 07:59:12 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C70F43D4C; Sat, 28 Oct 2006 07:59:12 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S7xBri063048; Sat, 28 Oct 2006 07:59:11 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S7xBN9063047; Sat, 28 Oct 2006 07:59:11 GMT (envelope-from bde) Message-Id: <200610280759.k9S7xBN9063047@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 07:59:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include profile.h src/sys/amd64/include profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:59:12 -0000 bde 2006-10-28 07:59:11 UTC FreeBSD src repository Modified files: sys/i386/include profile.h sys/amd64/include profile.h Log: In MCOUNT_OVERHEAD(label), actually use the `label' parameter. We were still using the global label named "profil", and this worked accidentally because all callers use the same name. Revision Changes Path 1.46 +1 -1 src/sys/amd64/include/profile.h 1.41 +1 -1 src/sys/i386/include/profile.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 08:11:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CDAA16A40F; Sat, 28 Oct 2006 08:11:07 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8196543D5A; Sat, 28 Oct 2006 08:11:07 +0000 (GMT) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S8B785066022; Sat, 28 Oct 2006 08:11:07 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S8B7YQ066021; Sat, 28 Oct 2006 08:11:07 GMT (envelope-from jfv) Message-Id: <200610280811.k9S8B7YQ066021@repoman.freebsd.org> From: Jack F Vogel Date: Sat, 28 Oct 2006 08:11:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 08:11:08 -0000 jfv 2006-10-28 08:11:07 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h Log: Backout bogus checkin to HEAD Approved by: scottl Revision Changes Path 1.156 +873 -664 src/sys/dev/em/if_em.c 1.52 +76 -94 src/sys/dev/em/if_em.h 1.24 +531 -574 src/sys/dev/em/if_em_hw.c 1.24 +175 -125 src/sys/dev/em/if_em_hw.h 1.20 +52 -46 src/sys/dev/em/if_em_osdep.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 08:17:07 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D1F816A417 for ; Sat, 28 Oct 2006 08:17:07 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07DE343D55 for ; Sat, 28 Oct 2006 08:17:04 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by nz-out-0102.google.com with SMTP id o37so717098nzf for ; Sat, 28 Oct 2006 01:17:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RpNluYJk8yzIF9GN8xlhRLQInjMqVxlukCkqSmCMatFZWBxg0mQGgXm2swVx2rYtNfO7TRVNHMbxMgG/tIYkUrkDqhFGnEcrJb9v6sl99NVk5TOqCAzrKMxkFPTmCUAxbfDS7cXW9WSqQmscOc9BjXmDv8cyo+r9FWCt0FgDVFM= Received: by 10.35.9.2 with SMTP id m2mr1082337pyi; Sat, 28 Oct 2006 01:17:04 -0700 (PDT) Received: by 10.35.118.6 with HTTP; Sat, 28 Oct 2006 01:17:03 -0700 (PDT) Message-ID: <2a41acea0610280117v60a85890x104dd66591539ec1@mail.gmail.com> Date: Sat, 28 Oct 2006 01:17:03 -0700 From: "Jack Vogel" To: "Hiroki Sato" In-Reply-To: <20061028.164140.102116870.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> <20061028.161036.78701604.hrs@allbsd.org> <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> <20061028.164140.102116870.hrs@allbsd.org> Cc: jfv@freebsd.org, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 08:17:07 -0000 On 10/28/06, Hiroki Sato wrote: > "Jack Vogel" wrote > in <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com>: > > jf> On 10/28/06, Hiroki Sato wrote: > jf> > Jack F Vogel wrote > jf> > in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: > jf> > > jf> > jf> jfv 2006-10-28 01:37:14 UTC > jf> > jf> > jf> > jf> FreeBSD src repository > jf> > jf> > jf> > jf> Modified files: (Branch: RELENG_6) > jf> > jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h > jf> > jf> if_em_osdep.h > jf> > jf> Log: > jf> > jf> Merge of Intel 6.2.9 em driver code. > jf> > jf> Approved by: re, scottl, jhb, pdeuskar > jf> > jf> > jf> > jf> Revision Changes Path > jf> > jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c > jf> > jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h > jf> > jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c > jf> > jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h > jf> > jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h > jf> > > jf> > Just wanted to make sure, but is the following change in if_em.c > jf> > really intentional? This means that the new version no longer > jf> > supports 82542... > jf> > > jf> > Index: if_em.c > jf> > @@ -116,8 +117,6 @@ > jf> > { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, > jf> > { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, > jf> > > jf> > - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, > jf> > - > jf> > { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, > jf> > { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, > jf> > jf> Yes that was intentional, its an ID that the Intel source has not > jf> had for some time. When I put it back in our source a while back > jf> due to a merge our test group came to me and said these adapters > jf> dont even work with the driver, so clearly no one is using them :) > jf> > jf> I asked about dropping the ID to a set of developers and got the OK to drop > jf> it. > jf> > jf> If someone actually speaks up about having hardware that was working and > jf> now is broken I'll take it all back and we can put the ID back in, is that good > jf> enough? :) > > So here is the report (from nyan@): > > em0@pci1:1:0: class=0x020000 card=0x10008086 chip=0x10008086 rev=0x03 hdr=0x00 > vendor = 'Intel Corporation' > device = '82542 Gigabit Ethernet Controller' > class = network > subclass = ethernet > > It is not recognized by the new driver at boot time while worked fine > with the old one. I think we should not remove the existing > hardware support (especially in -STABLE) if possible. LOL, so in a few hours of my checkin you got someone with this hardware to complain? Oh well, its one line, not a big deal to put back, I will get to it tomorrow, right now i'm going to bed :) NIght! Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 28 09:51:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DE8E16A412; Sat, 28 Oct 2006 09:51:11 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4859243D45; Sat, 28 Oct 2006 09:51:11 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9S9pBtf090424; Sat, 28 Oct 2006 09:51:11 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9S9pBph090421; Sat, 28 Oct 2006 09:51:11 GMT (envelope-from netchild) Message-Id: <200610280951.k9S9pBph090421@repoman.freebsd.org> From: Alexander Leidinger Date: Sat, 28 Oct 2006 09:51:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys soundcard.h src/sys/dev/sound/pcm dsp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 09:51:11 -0000 netchild 2006-10-28 09:51:10 UTC FreeBSD src repository Modified files: sys/sys soundcard.h sys/dev/sound/pcm dsp.c Log: MFP4: Rename MAX_SAMPLE_RATES macro to OSS_MAX_SAMPLE_RATES. The old macro clashed with those used in other applications and libaries (ex: RtAudio). 4Front responded by updating their spec, so we will follow suit. Submitted by: ryanb Noticed by: pointyhat/kris Revision Changes Path 1.99 +2 -2 src/sys/dev/sound/pcm/dsp.c 1.47 +2 -2 src/sys/sys/soundcard.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 10:53:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C878A16A407; Sat, 28 Oct 2006 10:53:40 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6155443D46; Sat, 28 Oct 2006 10:53:40 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SArevg001772; Sat, 28 Oct 2006 10:53:40 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SAreF2001767; Sat, 28 Oct 2006 10:53:40 GMT (envelope-from maxim) Message-Id: <200610281053.k9SAreF2001767@repoman.freebsd.org> From: Maxim Konovalov Date: Sat, 28 Oct 2006 10:53:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libtacplus libtacplus.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 10:53:40 -0000 maxim 2006-10-28 10:53:39 UTC FreeBSD src repository Modified files: lib/libtacplus libtacplus.3 Log: o Fix function name. Obtained from: DragonFlyBSD MFC after: 1 week Revision Changes Path 1.14 +1 -1 src/lib/libtacplus/libtacplus.3 From owner-cvs-src@FreeBSD.ORG Sat Oct 28 10:57:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2B8F16A403; Sat, 28 Oct 2006 10:57:35 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8AA3D43D53; Sat, 28 Oct 2006 10:57:35 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SAvZOW003275; Sat, 28 Oct 2006 10:57:35 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SAvZnQ003274; Sat, 28 Oct 2006 10:57:35 GMT (envelope-from maxim) Message-Id: <200610281057.k9SAvZnQ003274@repoman.freebsd.org> From: Maxim Konovalov Date: Sat, 28 Oct 2006 10:57:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 kobj.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 10:57:35 -0000 maxim 2006-10-28 10:57:35 UTC FreeBSD src repository Modified files: share/man/man9 kobj.9 Log: o Fix incorrect function name (kobj_free -> kobj_delete). Obtained from: DragonFlyBSD MFC after: 1 week Revision Changes Path 1.17 +1 -1 src/share/man/man9/kobj.9 From owner-cvs-src@FreeBSD.ORG Sat Oct 28 11:00:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D4D716A407; Sat, 28 Oct 2006 11:00:00 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E3BB43D4C; Sat, 28 Oct 2006 11:00:00 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SB00iF003482; Sat, 28 Oct 2006 11:00:00 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SB00dU003481; Sat, 28 Oct 2006 11:00:00 GMT (envelope-from netchild) Message-Id: <200610281100.k9SB00dU003481@repoman.freebsd.org> From: Alexander Leidinger Date: Sat, 28 Oct 2006 10:59:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/linux32 linux32_dummy.c syscalls.master src/sys/compat/linux linux_emul.c linux_emul.h linux_misc.c linux_misc.h src/sys/i386/linux linux_dummy.c syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 11:00:00 -0000 netchild 2006-10-28 10:59:59 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_dummy.c syscalls.master sys/compat/linux linux_emul.c linux_emul.h linux_misc.c sys/i386/linux linux_dummy.c syscalls.master Added files: sys/compat/linux linux_misc.h Log: MFP4: Implement prctl(). Submitted by: rdivacky Tested with: LTP Revision Changes Path 1.6 +0 -1 src/sys/amd64/linux32/linux32_dummy.c 1.22 +2 -1 src/sys/amd64/linux32/syscalls.master 1.8 +23 -1 src/sys/compat/linux/linux_emul.c 1.4 +2 -0 src/sys/compat/linux/linux_emul.h 1.190 +51 -0 src/sys/compat/linux/linux_misc.c 1.1 +43 -0 src/sys/compat/linux/linux_misc.h (new) 1.44 +0 -1 src/sys/i386/linux/linux_dummy.c 1.82 +2 -1 src/sys/i386/linux/syscalls.master From owner-cvs-src@FreeBSD.ORG Sat Oct 28 11:03:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60CC316A40F; Sat, 28 Oct 2006 11:03:04 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D12E443D49; Sat, 28 Oct 2006 11:03:03 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SB33lL005362; Sat, 28 Oct 2006 11:03:03 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SB33YB005334; Sat, 28 Oct 2006 11:03:03 GMT (envelope-from bde) Message-Id: <200610281103.k9SB33YB005334@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 11:03:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include profile.h src/sys/amd64/include profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 11:03:04 -0000 bde 2006-10-28 11:03:03 UTC FreeBSD src repository Modified files: sys/i386/include profile.h sys/amd64/include profile.h Log: i386/include/profile.h: Fixed a syntax error for the (!__KERNEL && !__GNUCLIKE_ASM) case in rev.1.36. Apparently, this case has never been reached even by lint. Submitted by: stefanf {amd64,i386}/include/profile.h: In case the above case is actually reached, break it properly by providing null support that will fail at link time instead of a stub that gives wrong (null) profiling at runtime. Revision Changes Path 1.47 +1 -5 src/sys/amd64/include/profile.h 1.42 +1 -5 src/sys/i386/include/profile.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 11:24:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8506916A407; Sat, 28 Oct 2006 11:24:39 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E3B343D46; Sat, 28 Oct 2006 11:24:39 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SBOdKZ010530; Sat, 28 Oct 2006 11:24:39 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SBOdIp010529; Sat, 28 Oct 2006 11:24:39 GMT (envelope-from netchild) Message-Id: <200610281124.k9SBOdIp010529@repoman.freebsd.org> From: Alexander Leidinger Date: Sat, 28 Oct 2006 11:24:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 11:24:39 -0000 netchild 2006-10-28 11:24:39 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Log: regen (prctl addition) Revision Changes Path 1.24 +6 -2 src/sys/amd64/linux32/linux32_proto.h 1.24 +1 -1 src/sys/amd64/linux32/linux32_syscall.h 1.24 +2 -2 src/sys/amd64/linux32/linux32_sysent.c 1.85 +6 -2 src/sys/i386/linux/linux_proto.h 1.79 +1 -1 src/sys/i386/linux/linux_syscall.h 1.86 +2 -2 src/sys/i386/linux/linux_sysent.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 13:05:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4601116A4DD; Sat, 28 Oct 2006 13:05:14 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B7A143D45; Sat, 28 Oct 2006 13:05:11 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SD5BQu041790; Sat, 28 Oct 2006 13:05:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SD5BiO041789; Sat, 28 Oct 2006 13:05:11 GMT (envelope-from ru) Message-Id: <200610281305.k9SD5BiO041789@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 28 Oct 2006 13:05:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/net inet.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 13:05:14 -0000 ru 2006-10-28 13:05:10 UTC FreeBSD src repository Modified files: lib/libc/net inet.3 Log: Add missing markup bits. Submitted by: Emil Mikulic Revision Changes Path 1.31 +3 -1 src/lib/libc/net/inet.3 From owner-cvs-src@FreeBSD.ORG Sat Oct 28 13:12:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F09E216A40F; Sat, 28 Oct 2006 13:12:10 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74A8B43D46; Sat, 28 Oct 2006 13:12:10 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SDC7cU043045; Sat, 28 Oct 2006 13:12:07 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SDC7bU043044; Sat, 28 Oct 2006 13:12:07 GMT (envelope-from bde) Message-Id: <200610281312.k9SDC7bU043044@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 13:12:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/include profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 13:12:11 -0000 bde 2006-10-28 13:12:07 UTC FreeBSD src repository Modified files: sys/amd64/include profile.h Log: In the userland .mcount(): - Don't use a frame pointer. Our callers need a frame pointer, but we could only use one to support things that aren't supported. (These things are: - profiling of profiling - debugging of profiling. The core ENTRY() macro doesn't support forcing a frame pointer for debugging, so don't do more here.) - Ensure that we are in the text section and have normal alignment. - Use the normal syntax for `.type'. Revision Changes Path 1.48 +5 -7 src/sys/amd64/include/profile.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 13:34:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B257716A4A0; Sat, 28 Oct 2006 13:34:36 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D88943D58; Sat, 28 Oct 2006 13:34:36 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SDYao9046640; Sat, 28 Oct 2006 13:34:36 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SDYaRn046639; Sat, 28 Oct 2006 13:34:36 GMT (envelope-from bde) Message-Id: <200610281334.k9SDYaRn046639@repoman.freebsd.org> From: Bruce Evans Date: Sat, 28 Oct 2006 13:34:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gmon Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 13:34:36 -0000 bde 2006-10-28 13:34:36 UTC FreeBSD src repository Modified files: lib/libc/gmon Makefile.inc Log: Backed out rev.1.10 (a special case for amd64). The amd64 mcount code never needed any frame pointers for itself. Revision Changes Path 1.12 +0 -6 src/lib/libc/gmon/Makefile.inc From owner-cvs-src@FreeBSD.ORG Sat Oct 28 14:09:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08E5616A412; Sat, 28 Oct 2006 14:09:10 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id C663C43DB7; Sat, 28 Oct 2006 14:08:54 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k9SE8o8W034903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Oct 2006 18:08:50 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k9SE8nP6034902; Sat, 28 Oct 2006 18:08:49 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 28 Oct 2006 18:08:49 +0400 From: Gleb Smirnoff To: Jack F Vogel Message-ID: <20061028140849.GF75694@FreeBSD.org> References: <200610280047.k9S0lttZ080233@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200610280047.k9S0lttZ080233@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 14:09:10 -0000 On Sat, Oct 28, 2006 at 12:47:55AM +0000, Jack F Vogel wrote: J> jfv 2006-10-28 00:47:55 UTC J> J> FreeBSD src repository J> J> Modified files: J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> if_em_osdep.h J> Log: J> This is the merge of the Intel 6.2.9 driver. It provides all new shared code, J> new device support, and it is hoped a more stable driver for 6.2. RELEASE. J> This checkin was discussed and approved today by RE, scottl, jhb, and pdeuskar This is not a merge but a check in. Again, I see some code destroyed. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Sat Oct 28 16:47:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 321C216A4B3; Sat, 28 Oct 2006 16:47:40 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A60543D67; Sat, 28 Oct 2006 16:47:39 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SGlcYZ006030; Sat, 28 Oct 2006 16:47:38 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SGlcSN006029; Sat, 28 Oct 2006 16:47:38 GMT (envelope-from netchild) Message-Id: <200610281647.k9SGlcSN006029@repoman.freebsd.org> From: Alexander Leidinger Date: Sat, 28 Oct 2006 16:47:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 16:47:40 -0000 netchild 2006-10-28 16:47:38 UTC FreeBSD src repository Modified files: sys/compat/linux linux_misc.c Log: Fix style(9). Noticed by: rwatson Revision Changes Path 1.191 +29 -29 src/sys/compat/linux/linux_misc.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 17:06:24 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C5E616A47E for ; Sat, 28 Oct 2006 17:06:24 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BB0A43D5E for ; Sat, 28 Oct 2006 17:06:21 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by nz-out-0102.google.com with SMTP id o37so788476nzf for ; Sat, 28 Oct 2006 10:06:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=fJq2ETDPCcC4W/gmxhH8MTBqsAA6CFFzWYC38Dx5xZXFtAP2TlJc5Xgo9rK8LiPq6r3RMQEuNDiBIbaM9WXAR5CK8vO5Qa8CDVO71lR68zZjSfdx7pwC4FDquUlugbkeQryKiUhoPNUCczqnIQy0bCphTA4zQ6XgPmCLzqY1VhI= Received: by 10.35.78.1 with SMTP id f1mr721497pyl; Sat, 28 Oct 2006 10:06:21 -0700 (PDT) Received: by 10.35.118.6 with HTTP; Sat, 28 Oct 2006 10:06:21 -0700 (PDT) Message-ID: <2a41acea0610281006s40173a26o6024271562b30332@mail.gmail.com> Date: Sat, 28 Oct 2006 10:06:21 -0700 From: "Jack Vogel" To: "Gleb Smirnoff" In-Reply-To: <20061028140849.GF75694@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200610280047.k9S0lttZ080233@repoman.freebsd.org> <20061028140849.GF75694@FreeBSD.org> Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 17:06:24 -0000 On 10/28/06, Gleb Smirnoff wrote: > On Sat, Oct 28, 2006 at 12:47:55AM +0000, Jack F Vogel wrote: > J> jfv 2006-10-28 00:47:55 UTC > J> > J> FreeBSD src repository > J> > J> Modified files: > J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h > J> if_em_osdep.h > J> Log: > J> This is the merge of the Intel 6.2.9 driver. It provides all new shared code, > J> new device support, and it is hoped a more stable driver for 6.2. RELEASE. > J> This checkin was discussed and approved today by RE, scottl, jhb, and pdeuskar > > This is not a merge but a check in. Again, I see some code destroyed. yes Gleb, but I did it the way we all discussed and decided. Its a temporary waypoint, hoping for stability, nothing is destroyed that cant be recovered. Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 28 17:38:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 179F516A407; Sat, 28 Oct 2006 17:38:55 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8A3E43D4C; Sat, 28 Oct 2006 17:38:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SHcscw019912; Sat, 28 Oct 2006 17:38:54 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SHcs9I019911; Sat, 28 Oct 2006 17:38:54 GMT (envelope-from rwatson) Message-Id: <200610281738.k9SHcs9I019911@repoman.freebsd.org> From: Robert Watson Date: Sat, 28 Oct 2006 17:38:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 17:38:55 -0000 rwatson 2006-10-28 17:38:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/freebsd32 syscalls.master Log: Merge syscalls.master:1.84,1.85 from HEAD to RELENG_6: Hook up audit functions in the freebsd32 compatibility code. It is believed these likely don't require wrappers. Include's sobomax's compile fix. Requested by: sobomax Approved by: re (kensmith, hrs) Revision Changes Path 1.50.2.9 +16 -10 src/sys/compat/freebsd32/syscalls.master From owner-cvs-src@FreeBSD.ORG Sat Oct 28 18:04:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E2E316A4FF; Sat, 28 Oct 2006 18:04:40 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D7E643D86; Sat, 28 Oct 2006 18:04:12 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k9SI48g0035874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Oct 2006 22:04:08 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k9SI47KE035873; Sat, 28 Oct 2006 22:04:07 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 28 Oct 2006 22:04:07 +0400 From: Gleb Smirnoff To: Jack Vogel Message-ID: <20061028180407.GG75694@FreeBSD.org> References: <200610280047.k9S0lttZ080233@repoman.freebsd.org> <20061028140849.GF75694@FreeBSD.org> <2a41acea0610281006s40173a26o6024271562b30332@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <2a41acea0610281006s40173a26o6024271562b30332@mail.gmail.com> User-Agent: Mutt/1.5.6i Cc: Jack F Vogel , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 18:04:40 -0000 On Sat, Oct 28, 2006 at 10:06:21AM -0700, Jack Vogel wrote: J> >J> jfv 2006-10-28 00:47:55 UTC J> >J> J> >J> FreeBSD src repository J> >J> J> >J> Modified files: J> >J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> >J> if_em_osdep.h J> >J> Log: J> >J> This is the merge of the Intel 6.2.9 driver. It provides all new J> >shared code, J> >J> new device support, and it is hoped a more stable driver for 6.2. J> >RELEASE. J> >J> This checkin was discussed and approved today by RE, scottl, jhb, and J> >pdeuskar J> > J> >This is not a merge but a check in. Again, I see some code destroyed. J> J> yes Gleb, but I did it the way we all discussed and decided. Its a temporary J> waypoint, hoping for stability, nothing is destroyed that cant be recovered. I didn't notice next commit to HEAD. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Sat Oct 28 18:09:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BABD16A407; Sat, 28 Oct 2006 18:09:44 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D70CC43D78; Sat, 28 Oct 2006 18:09:41 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SI9feb025633; Sat, 28 Oct 2006 18:09:41 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SI9f9H025632; Sat, 28 Oct 2006 18:09:41 GMT (envelope-from glebius) Message-Id: <200610281809.k9SI9f9H025632@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 28 Oct 2006 18:09:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net if_ppp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 18:09:44 -0000 glebius 2006-10-28 18:09:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_ppp.c Log: MFC rev. 1.115: Fix error in rev. 1.68. The intention was to break out the switch(){}, but actually exited from the for(){} loop. This fixes the PPPIOCSCOMPRESS ioctl. PR: kern/101333 Submitted by: Igor Popov Approved by: re (hrs) Revision Changes Path 1.105.2.4 +1 -1 src/sys/net/if_ppp.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 18:15:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2504416A47E; Sat, 28 Oct 2006 18:15:15 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D54843D55; Sat, 28 Oct 2006 18:15:14 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SIFD0T027079; Sat, 28 Oct 2006 18:15:13 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SIFDlm027078; Sat, 28 Oct 2006 18:15:13 GMT (envelope-from glebius) Message-Id: <200610281815.k9SIFDlm027078@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 28 Oct 2006 18:15:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/vmstat vmstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 18:15:15 -0000 glebius 2006-10-28 18:15:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/vmstat vmstat.c Log: MFC rev. 1.93, 1.94: - Print the number of allocation failures in UMA zones. - Add comma after REQUESTS field missed in previous commit. - Widen some columns; make width of header columns less cryptic. PR: kern/102940 Approved by: re (hrs) Revision Changes Path 1.86.2.4 +4 -4 src/usr.bin/vmstat/vmstat.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 18:17:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4875C16A492; Sat, 28 Oct 2006 18:17:10 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08A6943D53; Sat, 28 Oct 2006 18:17:10 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SIH9v5027175; Sat, 28 Oct 2006 18:17:09 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SIH9oI027174; Sat, 28 Oct 2006 18:17:09 GMT (envelope-from glebius) Message-Id: <200610281817.k9SIH9oI027174@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 28 Oct 2006 18:17:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph netgraph.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 18:17:10 -0000 glebius 2006-10-28 18:17:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph netgraph.h Log: MFC rev. 1.67: - ng_address_ID() has already freed the message, don't do double free. - Get error from ng_address_ID(). Reported by: Coverity via pjd Approved by: re (hrs) Revision Changes Path 1.55.2.8 +2 -6 src/sys/netgraph/netgraph.h From owner-cvs-src@FreeBSD.ORG Sat Oct 28 19:16:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6374816A416; Sat, 28 Oct 2006 19:16:58 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2AB843D53; Sat, 28 Oct 2006 19:16:57 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SJGvHe037516; Sat, 28 Oct 2006 19:16:57 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SJGvjd037515; Sat, 28 Oct 2006 19:16:57 GMT (envelope-from alc) Message-Id: <200610281916.k9SJGvjd037515@repoman.freebsd.org> From: Alan Cox Date: Sat, 28 Oct 2006 19:16:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_bio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 19:16:58 -0000 alc 2006-10-28 19:16:57 UTC FreeBSD src repository Modified files: sys/kern vfs_bio.c Log: In bufdone_finish() restrict the acquisition and release of the page queues lock to BIO_READ operations. Recent changes to the implementation of the per-page flags have eliminated the need for the page queues lock in the other cases. Revision Changes Path 1.512 +8 -2 src/sys/kern/vfs_bio.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 19:43:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68D1B16A40F; Sat, 28 Oct 2006 19:43:03 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25E2B43D46; Sat, 28 Oct 2006 19:43:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SJh3Tv041899; Sat, 28 Oct 2006 19:43:03 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SJh2LX041896; Sat, 28 Oct 2006 19:43:02 GMT (envelope-from rwatson) Message-Id: <200610281943.k9SJh2LX041896@repoman.freebsd.org> From: Robert Watson Date: Sat, 28 Oct 2006 19:43:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 19:43:03 -0000 rwatson 2006-10-28 19:43:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regenerate. Approved by: re (hrs, kensmith) Revision Changes Path 1.38.2.10 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.38.2.10 +10 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.29.2.10 +10 -10 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.39.2.10 +10 -10 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 19:49:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B02216A407; Sat, 28 Oct 2006 19:49:07 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 925F943D5D; Sat, 28 Oct 2006 19:49:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SJn60D042376; Sat, 28 Oct 2006 19:49:06 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SJn5FN042375; Sat, 28 Oct 2006 19:49:05 GMT (envelope-from rwatson) Message-Id: <200610281949.k9SJn5FN042375@repoman.freebsd.org> From: Robert Watson Date: Sat, 28 Oct 2006 19:49:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 19:49:07 -0000 rwatson 2006-10-28 19:49:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/freebsd32 syscalls.master Log: Remove accidental change to comment. Spotted by: ru Approved by: re (kensmith, hrs) (implicit) Revision Changes Path 1.50.2.10 +1 -1 src/sys/compat/freebsd32/syscalls.master From owner-cvs-src@FreeBSD.ORG Sat Oct 28 19:50:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 178BE16A49E; Sat, 28 Oct 2006 19:50:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C2E643D7C; Sat, 28 Oct 2006 19:50:01 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SJo1sJ042439; Sat, 28 Oct 2006 19:50:01 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SJo0VH042438; Sat, 28 Oct 2006 19:50:00 GMT (envelope-from rwatson) Message-Id: <200610281950.k9SJo0VH042438@repoman.freebsd.org> From: Robert Watson Date: Sat, 28 Oct 2006 19:50:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 19:50:06 -0000 rwatson 2006-10-28 19:50:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regenerate. Approved by: re (kensmith, hrs) (implicit) Revision Changes Path 1.38.2.11 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.38.2.11 +1 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.29.2.11 +1 -1 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.39.2.11 +1 -1 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Sat Oct 28 20:08:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F9C316A47C; Sat, 28 Oct 2006 20:08:13 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42DBD43D55; Sat, 28 Oct 2006 20:08:13 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9SK8Dpe047892; Sat, 28 Oct 2006 20:08:13 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9SK8DxJ047891; Sat, 28 Oct 2006 20:08:13 GMT (envelope-from phk) Message-Id: <200610282008.k9SK8DxJ047891@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 28 Oct 2006 20:08:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc rc.firewall src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 20:08:13 -0000 phk 2006-10-28 20:08:12 UTC FreeBSD src repository Modified files: etc rc.firewall etc/defaults rc.conf Log: Give rc.firewall a polish and a new method. Factor out the loopback setup Use "me" instead of hardcoded $ip where possible. Add "workstation" which protects just this machine with stateful firewalling. Put the variables for this in rc.conf. Submitted by: Flemming Jacobsen Reviewed by: cperciva Revision Changes Path 1.301 +10 -0 src/etc/defaults/rc.conf 1.49 +107 -16 src/etc/rc.firewall From owner-cvs-src@FreeBSD.ORG Sat Oct 28 21:25:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 362D016A403; Sat, 28 Oct 2006 21:25:44 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7BBA43D5C; Sat, 28 Oct 2006 21:25:43 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.63 (FreeBSD)) (envelope-from ) id 1GdvgT-000Kum-UP; Sat, 28 Oct 2006 22:25:41 +0100 Date: Sat, 28 Oct 2006 22:25:41 +0100 From: Ceri Davies To: Poul-Henning Kamp Message-ID: <20061028212541.GJ1690@submonkey.net> Mail-Followup-To: Ceri Davies , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200610282008.k9SK8DxJ047891@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ev7mvGV+3JQuI2Eo" Content-Disposition: inline In-Reply-To: <200610282008.k9SK8DxJ047891@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.13 (2006-08-11) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.firewall src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 21:25:44 -0000 --ev7mvGV+3JQuI2Eo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 28, 2006 at 08:08:12PM +0000, Poul-Henning Kamp wrote: > phk 2006-10-28 20:08:12 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc rc.firewall=20 > etc/defaults rc.conf=20 > Log: > Give rc.firewall a polish and a new method. > =20 > Factor out the loopback setup > =20 > Use "me" instead of hardcoded $ip where possible. > =20 > Add "workstation" which protects just this machine with stateful > firewalling. Put the variables for this in rc.conf. Any reason not to replace/reimplement "client" with this? Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --ev7mvGV+3JQuI2Eo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFQ8rVocfcwTS3JF8RArVpAJ9nZhqqO4gdZyjLFTSaaWON+3Op8QCff4E2 4AAGs9RHvCW1T36I5Bbb0rE= =oz9M -----END PGP SIGNATURE----- --ev7mvGV+3JQuI2Eo-- From owner-cvs-src@FreeBSD.ORG Sat Oct 28 21:30:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFA4F16A49E; Sat, 28 Oct 2006 21:30:20 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B3F443D6E; Sat, 28 Oct 2006 21:30:15 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id BBA03170C5; Sat, 28 Oct 2006 21:30:13 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.8/8.13.8) with ESMTP id k9SLUCSQ001171; Sat, 28 Oct 2006 21:30:13 GMT (envelope-from phk@critter.freebsd.dk) To: Ceri Davies From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 28 Oct 2006 22:25:41 +0100." <20061028212541.GJ1690@submonkey.net> Date: Sat, 28 Oct 2006 21:30:12 +0000 Message-ID: <1170.1162071012@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.firewall src/etc/defaults rc.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 21:30:20 -0000 In message <20061028212541.GJ1690@submonkey.net>, Ceri Davies writes: >> Add "workstation" which protects just this machine with stateful >> firewalling. Put the variables for this in rc.conf. > >Any reason not to replace/reimplement "client" with this? Backwards compat ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.