From owner-cvs-src@FreeBSD.ORG Sun Nov 12 01:21:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D666C16A40F; Sun, 12 Nov 2006 01:21:16 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FAC443D5F; Sun, 12 Nov 2006 01:21:16 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAC1LFpb016969; Sun, 12 Nov 2006 01:21:15 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAC1LFhR016945; Sun, 12 Nov 2006 01:21:15 GMT (envelope-from kmacy) Message-Id: <200611120121.kAC1LFhR016945@repoman.freebsd.org> From: Kip Macy Date: Sun, 12 Nov 2006 01:21:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 01:21:17 -0000 kmacy 2006-11-12 01:21:15 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v pmap.c Log: Support up to 4 nucleus mappings to workaround issue hit by jb@ when booted off of CD Revision Changes Path 1.5 +13 -14 src/sys/sun4v/sun4v/pmap.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 03:18:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99E5716A40F; Sun, 12 Nov 2006 03:18:23 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DA3943D46; Sun, 12 Nov 2006 03:18:23 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAC3INde038145; Sun, 12 Nov 2006 03:18:23 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAC3INHR038144; Sun, 12 Nov 2006 03:18:23 GMT (envelope-from davidxu) Message-Id: <200611120318.kAC3INHR038144@repoman.freebsd.org> From: David Xu Date: Sun, 12 Nov 2006 03:18:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_idle.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 03:18:23 -0000 davidxu 2006-11-12 03:18:22 UTC FreeBSD src repository Modified files: sys/kern kern_idle.c Log: Use mi_switch, this should fix loadavg calculation problem in NO_KSE case. Revision Changes Path 1.45 +0 -5 src/sys/kern/kern_idle.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 03:30:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD51F16A407; Sun, 12 Nov 2006 03:30:02 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 829D643D45; Sun, 12 Nov 2006 03:30:02 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAC3U2Q2039911; Sun, 12 Nov 2006 03:30:02 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAC3U2gE039910; Sun, 12 Nov 2006 03:30:02 GMT (envelope-from kmacy) Message-Id: <200611120330.kAC3U2gE039910@repoman.freebsd.org> From: Kip Macy Date: Sun, 12 Nov 2006 03:30:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_lock.c subr_lock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 03:30:03 -0000 kmacy 2006-11-12 03:30:02 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c subr_lock.c Log: show lock class in profiling output for default case where type is not specified when initializing the lock Approved by: scottl (standing in for mentor rwatson) Revision Changes Path 1.102 +2 -0 src/sys/kern/kern_lock.c 1.9 +22 -19 src/sys/kern/subr_lock.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 03:34:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63E5016A40F; Sun, 12 Nov 2006 03:34:04 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2820443D62; Sun, 12 Nov 2006 03:34:04 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAC3Y36P041114; Sun, 12 Nov 2006 03:34:03 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAC3Y3aC041113; Sun, 12 Nov 2006 03:34:03 GMT (envelope-from trhodes) Message-Id: <200611120334.kAC3Y3aC041113@repoman.freebsd.org> From: Tom Rhodes Date: Sun, 12 Nov 2006 03:34:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern posix4_mib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 03:34:04 -0000 trhodes 2006-11-12 03:34:03 UTC FreeBSD src repository Modified files: sys/kern posix4_mib.c Log: Fix mispatch of includes list; allows my kernel to build successfully. Revision Changes Path 1.12 +1 -0 src/sys/kern/posix4_mib.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 05:16:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27B9F16A403; Sun, 12 Nov 2006 05:16:29 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC34543D66; Sun, 12 Nov 2006 05:16:28 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAC5GSDx087580; Sun, 12 Nov 2006 05:16:28 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAC5GSQC087579; Sun, 12 Nov 2006 05:16:28 GMT (envelope-from kmacy) Message-Id: <200611120516.kAC5GSQC087579@repoman.freebsd.org> From: Kip Macy Date: Sun, 12 Nov 2006 05:16:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys lock_profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 05:16:29 -0000 kmacy 2006-11-12 05:16:28 UTC FreeBSD src repository Modified files: sys/sys lock_profile.h Log: GRRRRR - missed this in the last commit Revision Changes Path 1.5 +1 -0 src/sys/sys/lock_profile.h From owner-cvs-src@FreeBSD.ORG Sun Nov 12 06:26:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A994416A40F; Sun, 12 Nov 2006 06:26:12 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 542E043D55; Sun, 12 Nov 2006 06:26:12 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 1B5213092E7; Sun, 12 Nov 2006 17:26:10 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 710EB8C12; Sun, 12 Nov 2006 17:26:09 +1100 (EST) Date: Sun, 12 Nov 2006 17:26:08 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200611120716.10773.davidxu@freebsd.org> Message-ID: <20061112170556.U71828@delplex.bde.org> References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <20061112031308.I69769@delplex.bde.org> <200611120716.10773.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 06:26:12 -0000 On Sun, 12 Nov 2006, David Xu wrote: > On Sunday 12 November 2006 00:22, Bruce Evans wrote: >> On Sat, 11 Nov 2006, David Xu wrote: >>> davidxu 2006-11-11 13:11:30 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern sched_4bsd.c >>> Log: >>> Unbreak userland priority inheriting in NO_KSE case. >> >> Is this what made the non-KSE case unusable? At least with the load >> average bug fixed, it gave very unfair scheduling, and would only start >> about 4 concurrent hog processes on a 2-way SMP system. >> >> Improvements in some benchmarks may have depended on the bugs. Maybe >> a random load average is optimal for some loads :-). > > No, this change is unrelated, the bug is in kern_idle.c, John should use > mi_switch(), not the choosethread(), otherwise the loadavg is not > maintianed correctly. That's not the bug I meant. I already had your fix for kern_idle.c. Testing showed that nothing much is fixed. Simple benchmarks like: %%% for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 do nice -$i sh -c "while :; do echo -n;done" & done top -o time %%% and %%% for i in 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 do nice -$i sh -c "while :; do echo -n;done" & done top -o time %%% still show that scheduling without KSE is very unfair. They can take several minutes to start the `top' process, and "killall sh" can take many seconds to start unless you have an rtprio shell to start the killall. With KSE, the top process starts soon enough and shows just the old 4BSD scheduler bug that too many cycles are given to niced programs, as in all versions of FreeBSD except 4.x. Since no one uses niced programs, this bug is unimportant. Bruce From owner-cvs-src@FreeBSD.ORG Sun Nov 12 11:48:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6703316A40F; Sun, 12 Nov 2006 11:48:38 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18C7543D5A; Sun, 12 Nov 2006 11:48:38 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACBmc6q065799; Sun, 12 Nov 2006 11:48:38 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACBmcZg065798; Sun, 12 Nov 2006 11:48:38 GMT (envelope-from davidxu) Message-Id: <200611121148.kACBmcZg065798@repoman.freebsd.org> From: David Xu Date: Sun, 12 Nov 2006 11:48:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern init_main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 11:48:38 -0000 davidxu 2006-11-12 11:48:37 UTC FreeBSD src repository Modified files: sys/kern init_main.c Log: Copy base user priority in NO_KSE case. Revision Changes Path 1.270 +1 -0 src/sys/kern/init_main.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 12:02:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F50416A47B; Sun, 12 Nov 2006 12:02:42 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEC8B43DAD; Sun, 12 Nov 2006 12:02:41 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACC2ZoL068450; Sun, 12 Nov 2006 12:02:35 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACC2Zin068449; Sun, 12 Nov 2006 12:02:35 GMT (envelope-from ache) Message-Id: <200611121202.kACC2Zin068449@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sun, 12 Nov 2006 12:02:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.local.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 12:02:42 -0000 ache 2006-11-12 12:02:35 UTC FreeBSD src repository Modified files: etc/mtree BSD.local.dist Log: Back out 1.120, it was premature. Revision Changes Path 1.125 +0 -2 src/etc/mtree/BSD.local.dist From owner-cvs-src@FreeBSD.ORG Sun Nov 12 14:51:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D2ED16A6CF; Sun, 12 Nov 2006 14:51:08 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26D5943D91; Sun, 12 Nov 2006 14:51:07 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACEp7T7007362; Sun, 12 Nov 2006 14:51:07 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACEp75c007361; Sun, 12 Nov 2006 14:51:07 GMT (envelope-from delphij) Message-Id: <200611121451.kACEp75c007361@repoman.freebsd.org> From: Xin LI Date: Sun, 12 Nov 2006 14:51:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 14:51:08 -0000 delphij 2006-11-12 14:51:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/errata article.sgml Log: MFen 1.73.2.32 -> 1.73.2.33 Approved by: re (blanket) Revision Changes Path 1.2.2.6 +9 -1 src/release/doc/zh_CN.GB2312/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Sun Nov 12 15:08:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E622416A407; Sun, 12 Nov 2006 15:08:55 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AE5843D64; Sun, 12 Nov 2006 15:08:54 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACF8saO011672; Sun, 12 Nov 2006 15:08:54 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACF8s9c011671; Sun, 12 Nov 2006 15:08:54 GMT (envelope-from delphij) Message-Id: <200611121508.kACF8s9c011671@repoman.freebsd.org> From: Xin LI Date: Sun, 12 Nov 2006 15:08:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 15:08:56 -0000 delphij 2006-11-12 15:08:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: MFen 1.883.2.47 -> 1.883.2.50 Approved by: re (zh_CN.GB2312 relnotes blanket) Revision Changes Path 1.5.2.10 +30 -6 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Sun Nov 12 17:13:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EF1F16A47E; Sun, 12 Nov 2006 17:13:46 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D71843D49; Sun, 12 Nov 2006 17:13:46 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACHDkwR042743; Sun, 12 Nov 2006 17:13:46 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACHDkX0042740; Sun, 12 Nov 2006 17:13:46 GMT (envelope-from ume) Message-Id: <200611121713.kACHDkX0042740@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Sun, 12 Nov 2006 17:13:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: mackerras Cc: Subject: cvs commit: src/usr.sbin/pppd - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 17:13:46 -0000 ume 2006-11-12 17:13:45 UTC FreeBSD src repository src/usr.sbin/pppd - Imported sources Update of /home/ncvs/src/usr.sbin/pppd In directory repoman.freebsd.org:/tmp/cvs-serv42719 Log Message: Import eui64.[ch] and ipv6cp.[ch] of ppp-2.3.11 Status: Vendor Tag: mackerras Release Tags: ppp_2_3_11 N src/usr.sbin/pppd/eui64.c N src/usr.sbin/pppd/eui64.h N src/usr.sbin/pppd/ipv6cp.c N src/usr.sbin/pppd/ipv6cp.h No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Sun Nov 12 17:36:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F15AC16A403; Sun, 12 Nov 2006 17:36:58 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B853C43D70; Sun, 12 Nov 2006 17:36:58 +0000 (GMT) (envelope-from ume@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACHawqM046576; Sun, 12 Nov 2006 17:36:58 GMT (envelope-from ume@repoman.freebsd.org) Received: (from ume@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACHawiG046575; Sun, 12 Nov 2006 17:36:58 GMT (envelope-from ume) Message-Id: <200611121736.kACHawiG046575@repoman.freebsd.org> From: Hajimu UMEMOTO Date: Sun, 12 Nov 2006 17:36:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pppd Makefile eui64.c ipv6cp.c ipv6cp.h main.c options.c pathnames.h pppd.8 pppd.h sys-bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 17:36:59 -0000 ume 2006-11-12 17:36:58 UTC FreeBSD src repository Modified files: usr.sbin/pppd Makefile eui64.c ipv6cp.c ipv6cp.h main.c options.c pathnames.h pppd.8 pppd.h sys-bsd.c Log: Teach an IPV6CP to pppd(8). The eui64.[ch] and ipv6cp.[ch] were taken from ppp-2.3.11. However, our stock pppd(8) doesn't provide option_t nor some utility functions. So, I made some hacks to adjust to our stock pppd(8). The sys_bsd.c part was taken from NetBSD with some modifications to adjust to our stock pppd(8). MFC after: 1 week Revision Changes Path 1.31 +5 -0 src/usr.sbin/pppd/Makefile 1.2 +6 -0 src/usr.sbin/pppd/eui64.c 1.2 +21 -78 src/usr.sbin/pppd/ipv6cp.c 1.2 +3 -0 src/usr.sbin/pppd/ipv6cp.h 1.22 +6 -0 src/usr.sbin/pppd/main.c 1.25 +113 -0 src/usr.sbin/pppd/options.c 1.11 +6 -1 src/usr.sbin/pppd/pathnames.h 1.27 +47 -2 src/usr.sbin/pppd/pppd.8 1.14 +16 -0 src/usr.sbin/pppd/pppd.h 1.21 +129 -1 src/usr.sbin/pppd/sys-bsd.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 17:41:02 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A116E16A40F; Sun, 12 Nov 2006 17:41:02 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 583C143D97; Sun, 12 Nov 2006 17:40:53 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (host155-42.pool8174.interbusiness.it [81.74.42.155] (may be forged)) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id kACHeCfe011154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 12 Nov 2006 19:40:21 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id kACHe58U004405; Sun, 12 Nov 2006 18:40:06 +0100 (CET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id kACHe5IX004404; Sun, 12 Nov 2006 18:40:05 +0100 (CET) (envelope-from keramida@freebsd.org) Date: Sun, 12 Nov 2006 18:40:05 +0100 From: Giorgos Keramidas To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20061112174004.GB4237@kobe.laptop> References: <200611112211.kABMBsHp073602@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611112211.kABMBsHp073602@repoman.freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.463, required 5, autolearn=not spam, BAYES_00 -2.60, FORGED_RCVD_HELO 0.14, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: Subject: Re: cvs commit: src/usr.bin/sockstat sockstat.1 sockstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 17:41:02 -0000 On 2006-11-11 22:11, Giorgos Keramidas wrote: > keramida 2006-11-11 22:11:54 UTC > > FreeBSD src repository (doc committer) > > Modified files: > usr.bin/sockstat sockstat.1 sockstat.c > Log: > Add support for filtering sockets by protocol type. The default > behavior of sockstat(1) will still be to show "udp", "tcp" and > "divert" protocols, but we can now provide a (comma-separated) > list of protocols, as in: > > % sockstat -P tcp > > to list only TCP sockets, or we can filter more than one protocol > by separating the protocol names with a comma: > > % sockstat -P tcp,udp > > Protocol names are parsed with getprotobyname(3), so any protocol > whose name is listed in `/etc/protocols' should work fine. > > Submitted by: Josh Carroll > Approved by: des > > Revision Changes Path > 1.21 +12 -2 src/usr.bin/sockstat/sockstat.1 > 1.14 +115 -12 src/usr.bin/sockstat/sockstat.c This commit breaks sockstat when only *one* of -4 or -6 is used. My apologies for not testing the changes more thoroughly, everyone :( I've already emailed a followup patch to des@ for review, which you can also find attached below. When I get his approval, I'll commit it to CVS too: %%% diff -r b717d3e25bc0 -r a894939b8792 usr.bin/sockstat/sockstat.c --- a/usr.bin/sockstat/sockstat.c Sun Nov 12 16:33:09 2006 +0100 +++ b/usr.bin/sockstat/sockstat.c Sun Nov 12 18:34:29 2006 +0100 @@ -714,12 +714,17 @@ main(int argc, char *argv[]) usage(); /* - * If protos_defined remains -1, no -P was provided, so we have to - * set up the default protocol list in protos[] first. + * If no -4, -6, -u or -P option was specified, use the default list + * of protocols *and* UNIX domain sockets. Otherwise, if only one + * of -4 and -6 was specified and we don't have a protocol list yet + * (i.e. because no -P option was present), still use the default + * protocol list (to list sockets of the respective address family). */ if (!opt_4 && !opt_6 && !opt_u && protos_defined == -1) { opt_u = 1; protos_defined = set_default_protos(); + } else if ((opt_4 || opt_6) && protos_defined == -1) { + protos_defined = set_default_protos(); } if (!opt_4 && !opt_6) %%% From owner-cvs-src@FreeBSD.ORG Sun Nov 12 18:20:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D011116A40F; Sun, 12 Nov 2006 18:20:30 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 451A843D68; Sun, 12 Nov 2006 18:20:30 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACIKUkp058396; Sun, 12 Nov 2006 18:20:30 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACIKU4C058395; Sun, 12 Nov 2006 18:20:30 GMT (envelope-from delphij) Message-Id: <200611121820.kACIKU4C058395@repoman.freebsd.org> From: Xin LI Date: Sun, 12 Nov 2006 18:20:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc pf.os X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 18:20:30 -0000 delphij 2006-11-12 18:20:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc pf.os Log: MFC 1.4: sync pf.os with OpenBSD. Approved by: re (bmah) Revision Changes Path 1.3.2.1 +71 -27 src/etc/pf.os From owner-cvs-src@FreeBSD.ORG Sun Nov 12 18:38:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A267616A47B; Sun, 12 Nov 2006 18:38:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A09743D5A; Sun, 12 Nov 2006 18:38:07 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACIc755061650; Sun, 12 Nov 2006 18:38:07 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACIc7Pr061649; Sun, 12 Nov 2006 18:38:07 GMT (envelope-from bz) Message-Id: <200611121838.kACIc7Pr061649@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sun, 12 Nov 2006 18:38:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/doc/IPv6 IMPLEMENTATION X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 18:38:07 -0000 bz 2006-11-12 18:38:07 UTC FreeBSD src repository Modified files: share/doc/IPv6 IMPLEMENTATION Log: Remove some comments about NetBSD. This in on FreeBSD and we do not want to confuse people at the very beginning. Sync TOC/paragraph numbers in the text. Requested by: Benedikt Stockebrand during his talk at EuroBSDCon 2006 Reviewed by: gnn Revision Changes Path 1.10 +7 -10 src/share/doc/IPv6/IMPLEMENTATION From owner-cvs-src@FreeBSD.ORG Sun Nov 12 18:44:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DDA816A47B; Sun, 12 Nov 2006 18:44:03 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13EF843D45; Sun, 12 Nov 2006 18:44:03 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACIhPFh062878; Sun, 12 Nov 2006 18:43:25 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACIhPfb062874; Sun, 12 Nov 2006 18:43:25 GMT (envelope-from jkoshy) Message-Id: <200611121843.kACIhPfb062874@repoman.freebsd.org> From: Joseph Koshy Date: Sun, 12 Nov 2006 18:43:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libelf Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 18:44:03 -0000 jkoshy 2006-11-12 18:43:25 UTC FreeBSD src repository Modified files: lib/libelf Makefile Log: - Replace the use of DPSRCS with something more appropriate. DPSRCS is for when you need something in ".depend", but not compiled in. - Style fixes: Spell ${.OBJDIR} as ".". - Neaten a comment. Submitted by: ru Revision Changes Path 1.2 +6 -5 src/lib/libelf/Makefile From owner-cvs-src@FreeBSD.ORG Sun Nov 12 19:03:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C19E16A492; Sun, 12 Nov 2006 19:03:41 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF48A43D7D; Sun, 12 Nov 2006 19:03:39 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACJ3dTG067542; Sun, 12 Nov 2006 19:03:39 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACJ3dvi067541; Sun, 12 Nov 2006 19:03:39 GMT (envelope-from keramida) Message-Id: <200611121903.kACJ3dvi067541@repoman.freebsd.org> From: Giorgos Keramidas Date: Sun, 12 Nov 2006 19:03:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/sockstat sockstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 19:03:41 -0000 keramida 2006-11-12 19:03:39 UTC FreeBSD src repository (doc committer) Modified files: usr.bin/sockstat sockstat.c Log: In revision 1.14 I broke the -4 and -6 options of sockstat(1). Using either one of the two would result in an empty protos[] array, and no sockets were actually listed: % sockstat -4 USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS % sockstat -6 USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS % Fix this bug by tweaking appropriately the logic of handling opt_4, opt_6, opt_u and protos_defined. Submitted by: des Pointy hat: keramida Revision Changes Path 1.15 +5 -10 src/usr.bin/sockstat/sockstat.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 20:57:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A6AEE16A403; Sun, 12 Nov 2006 20:57:01 +0000 (UTC) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75ED043D49; Sun, 12 Nov 2006 20:57:01 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACKv1cO096083; Sun, 12 Nov 2006 20:57:01 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACKv18j096081; Sun, 12 Nov 2006 20:57:01 GMT (envelope-from andre) Message-Id: <200611122057.kACKv18j096081@repoman.freebsd.org> From: Andre Oppermann Date: Sun, 12 Nov 2006 20:57:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 20:57:01 -0000 andre 2006-11-12 20:57:00 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: In kern_sendfile() fix the calculation of sbytes (the total number of bytes written to the socket). The rewrite in revision 1.240 got confused by the FreeBSD 4.x bug compatibility code. For some reason lighttpd, that was used for testing the new sendfile code, was not affected by the problem but apache and others using headers/trailers in the sendfile call received incorrect sbytes values after return from non- blocking sockets. This then lead to restarts with wrong offsets and thus mixed up file contents when the socket was writeable again. All programs not using headers/trailers, like ftpd, were not affected by the bug. Reported by: Pawel Worach Tested by: Pawel Worach Revision Changes Path 1.245 +19 -23 src/sys/kern/uipc_syscalls.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 21:43:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1810416A492; Sun, 12 Nov 2006 21:43:22 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C374643D5A; Sun, 12 Nov 2006 21:43:21 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACLhLp1005409; Sun, 12 Nov 2006 21:43:21 GMT (envelope-from joel@repoman.freebsd.org) Received: (from joel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACLhLsC005408; Sun, 12 Nov 2006 21:43:21 GMT (envelope-from joel) Message-Id: <200611122143.kACLhLsC005408@repoman.freebsd.org> From: Joel Dahl Date: Sun, 12 Nov 2006 21:43:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/ipfwpcap ipfwpcap.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 21:43:22 -0000 joel 2006-11-12 21:43:21 UTC FreeBSD src repository (doc committer) Modified files: usr.sbin/ipfwpcap ipfwpcap.8 Log: Change authors e-mail. Requested by: Niclas Zeising Revision Changes Path 1.4 +1 -1 src/usr.sbin/ipfwpcap/ipfwpcap.8 From owner-cvs-src@FreeBSD.ORG Sun Nov 12 21:48:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E53F016A415; Sun, 12 Nov 2006 21:48:49 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D12F43DC8; Sun, 12 Nov 2006 21:48:34 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACLmYjN006109; Sun, 12 Nov 2006 21:48:34 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACLmYDV006108; Sun, 12 Nov 2006 21:48:34 GMT (envelope-from alc) Message-Id: <200611122148.kACLmYDV006108@repoman.freebsd.org> From: Alan Cox Date: Sun, 12 Nov 2006 21:48:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/arm/arm pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c src/sys/powerpc/powerpc mmu_oea.c src/sys/sparc64/sparc64 pmap.c src/sys/sun4v/sun4v pmap.c src/sys/vm vm_fault.c vm_kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 21:48:50 -0000 alc 2006-11-12 21:48:34 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/arm/arm pmap.c sys/i386/i386 pmap.c sys/ia64/ia64 pmap.c sys/powerpc/powerpc mmu_oea.c sys/sparc64/sparc64 pmap.c sys/sun4v/sun4v pmap.c sys/vm vm_fault.c vm_kern.c Log: Make pmap_enter() responsible for setting PG_WRITEABLE instead of its caller. (As a beneficial side-effect, a high-contention acquisition of the page queues lock in vm_fault() is eliminated.) Revision Changes Path 1.573 +3 -1 src/sys/amd64/amd64/pmap.c 1.73 +4 -1 src/sys/arm/arm/pmap.c 1.577 +3 -1 src/sys/i386/i386/pmap.c 1.180 +2 -0 src/sys/ia64/ia64/pmap.c 1.112 +3 -2 src/sys/powerpc/powerpc/mmu_oea.c 1.160 +4 -1 src/sys/sparc64/sparc64/pmap.c 1.6 +3 -1 src/sys/sun4v/sun4v/pmap.c 1.223 +2 -7 src/sys/vm/vm_fault.c 1.124 +1 -1 src/sys/vm/vm_kern.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 23:16:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA85016A415; Sun, 12 Nov 2006 23:16:41 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DA5543D93; Sun, 12 Nov 2006 23:16:32 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACNGW5r023560; Sun, 12 Nov 2006 23:16:32 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACNGW5E023559; Sun, 12 Nov 2006 23:16:32 GMT (envelope-from ceri) Message-Id: <200611122316.kACNGW5E023559@repoman.freebsd.org> From: Ceri Davies Date: Sun, 12 Nov 2006 23:16:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 23:16:41 -0000 ceri 2006-11-12 23:16:32 UTC FreeBSD src repository Modified files: sys/sys proc.h Log: Correct typos in comments. Revision Changes Path 1.464 +2 -2 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Sun Nov 12 23:17:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 2D02216A51F; Sun, 12 Nov 2006 23:17:08 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Mon, 13 Nov 2006 07:17:03 +0800 User-Agent: KMail/1.8.2 References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <200611120716.10773.davidxu@freebsd.org> <20061112170556.U71828@delplex.bde.org> In-Reply-To: <20061112170556.U71828@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611130717.03734.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 23:17:08 -0000 On Sunday 12 November 2006 14:26, Bruce Evans wrote: > On Sun, 12 Nov 2006, David Xu wrote: > > On Sunday 12 November 2006 00:22, Bruce Evans wrote: > >> On Sat, 11 Nov 2006, David Xu wrote: > >>> davidxu 2006-11-11 13:11:30 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/kern sched_4bsd.c > >>> Log: > >>> Unbreak userland priority inheriting in NO_KSE case. > >> > >> Is this what made the non-KSE case unusable? At least with the load > >> average bug fixed, it gave very unfair scheduling, and would only start > >> about 4 concurrent hog processes on a 2-way SMP system. > >> > >> Improvements in some benchmarks may have depended on the bugs. Maybe > >> a random load average is optimal for some loads :-). > > > > No, this change is unrelated, the bug is in kern_idle.c, John should use > > mi_switch(), not the choosethread(), otherwise the loadavg is not > > maintianed correctly. > > That's not the bug I meant. I already had your fix for kern_idle.c. > > Testing showed that nothing much is fixed. Simple benchmarks like: > > %%% > for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 > do > nice -$i sh -c "while :; do echo -n;done" & > done > top -o time > %%% > > and > > %%% > for i in 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 > do > nice -$i sh -c "while :; do echo -n;done" & > done > top -o time > %%% > > still show that scheduling without KSE is very unfair. They can take > several minutes to start the `top' process, and "killall sh" can take > many seconds to start unless you have an rtprio shell to start the > killall. > > With KSE, the top process starts soon enough and shows just the old > 4BSD scheduler bug that too many cycles are given to niced programs, > as in all versions of FreeBSD except 4.x. Since no one uses niced > programs, this bug is unimportant. > > Bruce It might not be a bug of the NO_KSE, the problem is in sched_fork() and sched_exit(), for process which quickly fork() a child and then the child exits quickly, the parent's estcpu will be doubled quickly too, this fairness is really unfair, I think your examples is the scenario, however, I don't know why KSE works better. this might be fixed by remembering the inherited estcpu in child, and decay it every second. when the child exits, it add really used estcpu to parent. code looks like this: in sched_fork(), we remember inherited estcpu: td->td_inherited_estcpu = parent->td_estcpu; in schedcpu(), we decay it every second (should be fixed in sched_wakeup too): td->td_inherited_estcpu = decaycpu(loadfac, td->td_inherited_cpu); in sched_exit(); parent->td_estcpu = ESTCPULIM(parent->td_estcpu, childtd->td_estcpu - td->td_inherited_cpu); This should fix the quickly fork() and exit() problem for parent process. Regards, David Xu From owner-cvs-src@FreeBSD.ORG Sun Nov 12 23:23:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25B1D16A417; Sun, 12 Nov 2006 23:23:49 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3608143D8E; Sun, 12 Nov 2006 23:23:40 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACNNcEo024993; Sun, 12 Nov 2006 23:23:38 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACNNcOF024991; Sun, 12 Nov 2006 23:23:38 GMT (envelope-from kmacy) Message-Id: <200611122323.kACNNcOF024991@repoman.freebsd.org> From: Kip Macy Date: Sun, 12 Nov 2006 23:23:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_lock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 23:23:49 -0000 kmacy 2006-11-12 23:23:38 UTC FreeBSD src repository Modified files: sys/kern subr_lock.c Log: Unbreak witness Revision Changes Path 1.10 +1 -1 src/sys/kern/subr_lock.c From owner-cvs-src@FreeBSD.ORG Sun Nov 12 23:45:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6911316A403; Sun, 12 Nov 2006 23:45:41 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22F9543D64; Sun, 12 Nov 2006 23:45:41 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kACNjerH031408; Sun, 12 Nov 2006 23:45:41 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kACNjeNg031407; Sun, 12 Nov 2006 23:45:40 GMT (envelope-from kientzle) Message-Id: <200611122345.kACNjeNg031407@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 12 Nov 2006 23:45:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_read_data_into_fd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 23:45:41 -0000 kientzle 2006-11-12 23:45:40 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_data_into_fd.c Log: Correctly handle writing very large blocks (>1M) through to a disk file. This doesn't happen in normal use, because the file I/O and decompression layers only pass through smaller blocks. It can happen with custom read functions that block I/O in larger blocks. Revision Changes Path 1.12 +3 -1 src/lib/libarchive/archive_read_data_into_fd.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 00:26:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89A9716A403; Mon, 13 Nov 2006 00:26:46 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54A2E43D49; Mon, 13 Nov 2006 00:26:46 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD0QkVx039927; Mon, 13 Nov 2006 00:26:46 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD0QkBo039926; Mon, 13 Nov 2006 00:26:46 GMT (envelope-from kientzle) Message-Id: <200611130026.kAD0QkBo039926@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 13 Nov 2006 00:26:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_read_open_fd.c archive_read_open_file.c archive_write_open_fd.c archive_write_open_file.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 00:26:46 -0000 kientzle 2006-11-13 00:26:46 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_open_fd.c archive_read_open_file.c archive_write_open_fd.c archive_write_open_file.c Log: Minor cleanup of the standard read/write I/O modules: * Use public API, don't access struct archive directly. (People should be able to copy these into their applications as a template for custom I/O callbacks.) * Set "skip" only for regular files. ("skip" allows the low-level library to catch attempts to add an archive to itself or extract over itself.) * Simplify the write_open functions by just calling stat() at the beginning. Somehow, these functions had acquired some complex logic that tried to avoid the stat() call but never succeeded. MFC after: 10 days Revision Changes Path 1.8 +2 -2 src/lib/libarchive/archive_read_open_fd.c 1.13 +4 -3 src/lib/libarchive/archive_read_open_file.c 1.6 +21 -30 src/lib/libarchive/archive_write_open_fd.c 1.13 +26 -39 src/lib/libarchive/archive_write_open_file.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 00:27:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5402916A522; Mon, 13 Nov 2006 00:27:03 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F08B143D49; Mon, 13 Nov 2006 00:27:02 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD0R2ME039964; Mon, 13 Nov 2006 00:27:02 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD0R2hR039963; Mon, 13 Nov 2006 00:27:02 GMT (envelope-from alc) Message-Id: <200611130027.kAD0R2hR039963@repoman.freebsd.org> From: Alan Cox Date: Mon, 13 Nov 2006 00:27:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 00:27:03 -0000 alc 2006-11-13 00:27:02 UTC FreeBSD src repository Modified files: sys/vm vm_kern.c Log: There is no point in setting PG_REFERENCED on kmem_object pages because they are "unmanaged", i.e., non-pageable, pages. Remove a stale comment. Revision Changes Path 1.125 +1 -6 src/sys/vm/vm_kern.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 00:29:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47F9416A403; Mon, 13 Nov 2006 00:29:58 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14F5343D45; Mon, 13 Nov 2006 00:29:58 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD0TvPe040104; Mon, 13 Nov 2006 00:29:57 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD0Tv37040103; Mon, 13 Nov 2006 00:29:57 GMT (envelope-from kientzle) Message-Id: <200611130029.kAD0Tv37040103@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 13 Nov 2006 00:29:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_read_open_fd.c archive_read_open_file.c archive_write_open_fd.c archive_write_open_file.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 00:29:58 -0000 kientzle 2006-11-13 00:29:57 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_open_fd.c archive_read_open_file.c archive_write_open_fd.c archive_write_open_file.c Log: These files no longer use internal APIs, so no longer need to include archive_private.h. Revision Changes Path 1.9 +0 -1 src/lib/libarchive/archive_read_open_fd.c 1.14 +0 -1 src/lib/libarchive/archive_read_open_file.c 1.7 +0 -1 src/lib/libarchive/archive_write_open_fd.c 1.14 +0 -1 src/lib/libarchive/archive_write_open_file.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 00:53:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5B0116A412; Mon, 13 Nov 2006 00:53:04 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B81543D60; Mon, 13 Nov 2006 00:53:04 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD0r4Dk053898; Mon, 13 Nov 2006 00:53:04 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD0r4PM053897; Mon, 13 Nov 2006 00:53:04 GMT (envelope-from delphij) Message-Id: <200611130053.kAD0r4PM053897@repoman.freebsd.org> From: Xin LI Date: Mon, 13 Nov 2006 00:53:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 00:53:04 -0000 delphij 2006-11-13 00:53:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: Since SA-06:24.libarchive affects -STABLE after the latest release that this errata documents, the change should be documented in relnotes only, but not this errata. Discussed with: security-officer (simon), re (bmah) Approved by: re (bmah) Revision Changes Path 1.73.2.34 +0 -8 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 00:54:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65BB716A403; Mon, 13 Nov 2006 00:54:41 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1799B43D60; Mon, 13 Nov 2006 00:54:41 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD0seRj054103; Mon, 13 Nov 2006 00:54:40 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD0seIi054102; Mon, 13 Nov 2006 00:54:40 GMT (envelope-from delphij) Message-Id: <200611130054.kAD0seIi054102@repoman.freebsd.org> From: Xin LI Date: Mon, 13 Nov 2006 00:54:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 00:54:41 -0000 delphij 2006-11-13 00:54:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/errata article.sgml Log: MFen 1.73.2.33 -> 1.73.2.34 Approved by: re (blanket) Revision Changes Path 1.2.2.7 +1 -9 src/release/doc/zh_CN.GB2312/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 01:02:24 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D61816A407; Mon, 13 Nov 2006 01:02:24 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1153543D70; Mon, 13 Nov 2006 01:02:24 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD12NCt055086; Mon, 13 Nov 2006 01:02:23 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD12NHr055081; Mon, 13 Nov 2006 01:02:23 GMT (envelope-from kmacy) Message-Id: <200611130102.kAD12NHr055081@repoman.freebsd.org> From: Kip Macy Date: Mon, 13 Nov 2006 01:02:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files.sun4v src/sys/sun4v/sun4v rtc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 01:02:24 -0000 kmacy 2006-11-13 01:02:18 UTC FreeBSD src repository Modified files: sys/conf files.sun4v sys/sun4v/sun4v rtc.c Log: Add time-of-day support to sun4v Revision Changes Path 1.4 +1 -0 src/sys/conf/files.sun4v 1.2 +35 -120 src/sys/sun4v/sun4v/rtc.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 01:13:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FE1E16A412; Mon, 13 Nov 2006 01:13:29 +0000 (UTC) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19AD043D46; Mon, 13 Nov 2006 01:13:29 +0000 (GMT) (envelope-from markus@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD1DSrH058284; Mon, 13 Nov 2006 01:13:28 GMT (envelope-from markus@repoman.freebsd.org) Received: (from markus@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD1DSK5058283; Mon, 13 Nov 2006 01:13:28 GMT (envelope-from markus) Message-Id: <200611130113.kAD1DSK5058283@repoman.freebsd.org> From: Markus Brueffer Date: Mon, 13 Nov 2006 01:13:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/bluetooth/rfcomm_pppd rfcomm_pppd.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 01:13:29 -0000 markus 2006-11-13 01:13:28 UTC FreeBSD src repository Modified files: usr.sbin/bluetooth/rfcomm_pppd rfcomm_pppd.8 Log: - Grammar fixes - Reword some sentences - Use .Cm for arguments - s/CAVEAT/CAVEATS/ Based on PR: docs/78174 Submitted by: Jeremy Chadwick Reviewed by: brueffer Approved by: emax (mentor) MFC after: 3 days Revision Changes Path 1.13 +74 -56 src/usr.sbin/bluetooth/rfcomm_pppd/rfcomm_pppd.8 From owner-cvs-src@FreeBSD.ORG Mon Nov 13 01:44:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5447F16A407; Mon, 13 Nov 2006 01:44:21 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D2F343D45; Mon, 13 Nov 2006 01:44:21 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD1iKAh063399; Mon, 13 Nov 2006 01:44:20 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD1iKmu063398; Mon, 13 Nov 2006 01:44:20 GMT (envelope-from bmah) Message-Id: <200611130144.kAD1iKmu063398@repoman.freebsd.org> From: "Bruce A. Mah" Date: Mon, 13 Nov 2006 01:44:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 01:44:21 -0000 bmah 2006-11-13 01:44:20 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release notes: ng_ether(4) MAC address behavior, tun(4) kqueue(2) support, fsdb(8) findblk. Modified release note: Fix an extra "the" in fsdb(8) btime note. [1] Submitted by: ceri [1] Revision Changes Path 1.987 +11 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 01:46:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF8BE16A40F; Mon, 13 Nov 2006 01:46:09 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76B3B43D45; Mon, 13 Nov 2006 01:46:09 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD1k9nd063497; Mon, 13 Nov 2006 01:46:09 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD1k9Lf063496; Mon, 13 Nov 2006 01:46:09 GMT (envelope-from bmah) Message-Id: <200611130146.kAD1k9Lf063496@repoman.freebsd.org> From: "Bruce A. Mah" Date: Mon, 13 Nov 2006 01:46:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 01:46:10 -0000 bmah 2006-11-13 01:46:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: ng_ether(4) MAC address behavior, tun(4) kqueue(2) support, fsdb(8) findblk. Also fix extra "the" in fsdb(8) btime note. [1] Submitted by: ceri [1] Approved by: re (implicitly) Revision Changes Path 1.883.2.51 +11 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 02:27:26 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9664416A403 for ; Mon, 13 Nov 2006 02:27:26 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A8CA43D69 for ; Mon, 13 Nov 2006 02:27:18 +0000 (GMT) (envelope-from kip.macy@gmail.com) Received: by nf-out-0910.google.com with SMTP id l23so319523nfc for ; Sun, 12 Nov 2006 18:27:17 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=jM4uWxnYvTZAazChhRsFUfHc7nmF/ZMaabIJ7A+i5Pdc9n4SOQ++IHD3bk6LM0BmYLIRUtmXmCmJRLUzQsK3yqySbwdWdC8KWm0DfEaoS+iKUNCxNQCJpf2HCEmHjxSR46T/xSAVt1TpXMk62ZKAhIPBPXnfZPUg30/Mm+vOqQU= Received: by 10.82.172.15 with SMTP id u15mr558113bue.1163384836683; Sun, 12 Nov 2006 18:27:16 -0800 (PST) Received: by 10.82.191.20 with HTTP; Sun, 12 Nov 2006 18:27:16 -0800 (PST) Message-ID: Date: Sun, 12 Nov 2006 18:27:16 -0800 From: "Kip Macy" To: "Alan Cox" In-Reply-To: <200611122148.kACLmYDV006108@repoman.freebsd.org> MIME-Version: 1.0 References: <200611122148.kACLmYDV006108@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/arm/arm pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c src/sys/powerpc/powerpc mmu_oea.c src/sys/sparc64/sparc64 pmap.c src/sys/sun4v/sun4v pmap.c src/sys/vm vm_fault.c vm_kern.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 02:27:26 -0000 Thanks Alan, this is a definite improvement. For the benefit of other readers: below I have the ten locks with longest max_wait (total time in microseconds spent waiting for the lock) during the compile phase of a "make -j32 buildkernel" on a T2000 (8 cores w/ 4 threads per core). The reduction in turnstile contention is a direct result of reducing contention on the page queue mutex. before: max total wait_total count avg wait_avg cnt_hold cnt_lock name 5 7266196 206805560 7522452 0 27 48266619 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/subr_turnstile.c:487 (turnstile chain) 457 528521 180592127 550284 0 328 1469872 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_fault.c:844 (vm page queue mutex) 15057461 1679582934 117520488 87978 19090 1335 0 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/ufs/ffs/ffs_vnops.c:366 (ufs) 214 1076256 112489341 559032 1 201 1520471 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_fault.c:902 (vm page queue mutex) 424 8250360 105249196 559031 14 188 1767340 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/sun4v/sun4v/pmap.c:956 (vm page queue mutex) 72563452121 218316084315 94216669 452713 482239 208 0 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/vfs_default.c:263 (nfs) 23 1349030 14049785 280685 4 50 923679 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/kern_idle.c:121 (sched lock) 73 214117 11078161 63944 3 173 2505 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/nfsclient/nfs_socket.c:1235 (Giant) 42 92768 10431233 40012 2 260 122966 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_fault.c:342 (vm page queue mutex) 6429 2155581 6645086 18297 117 363 105550 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_object.c:651 (vm page queue mutex) after: 15311133 1125368615 119287635 94194 11947 1266 0 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/ufs/ffs/ffs_vnops.c:366 (lockmgr:ufs) 546 4708767 93794515 326286 14 287 533239 713529 /usr/flatstor/shared/freebsd/kmacy/src/sys/sun4v/sun4v/pmap.c:955 (sleep mutex:vm page queue mutex) 36217304 520567907 53857789 243928 2134 220 0 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/vfs_default.c:263 (lockmgr:nfs) 210 590989 38380260 326286 1 117 335955 160913 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_fault.c:899 (sleep mutex:vm page queue mutex) 16 1702987 25490112 2068283 0 12 7329498 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/subr_turnstile.c:487 (spin mutex:turnstile chain) 22 962236 7498290 194839 4 38 665502 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/kern_idle.c:121 (spin mutex:sched lock) 9 28157 4130053 7242 3 570 9959 3040 /usr/flatstor/shared/freebsd/kmacy/src/sys/sun4v/sun4v/pmap.c:1162 (sleep mutex:vm page queue mutex) 39 44908 2629172 21967 2 119 21879 11174 /usr/flatstor/shared/freebsd/kmacy/src/sys/vm/vm_fault.c:342 (sleep mutex:vm page queue mutex) 4 20673 2265592 21708 0 104 88367 0 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/subr_trap.c:191 (spin mutex:sched lock) 31 11117 2231209 7243 1 308 7419 3023 /usr/flatstor/shared/freebsd/kmacy/src/sys/kern/sys_pipe.c:827 (sleep mutex:vm page queue mutex) On 11/12/06, Alan Cox wrote: > > alc 2006-11-12 21:48:34 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 pmap.c > sys/arm/arm pmap.c > sys/i386/i386 pmap.c > sys/ia64/ia64 pmap.c > sys/powerpc/powerpc mmu_oea.c > sys/sparc64/sparc64 pmap.c > sys/sun4v/sun4v pmap.c > sys/vm vm_fault.c vm_kern.c > Log: > Make pmap_enter() responsible for setting PG_WRITEABLE instead > of its caller. (As a beneficial side-effect, a high-contention > acquisition of the page queues lock in vm_fault() is eliminated.) > > Revision Changes Path > 1.573 +3 -1 src/sys/amd64/amd64/pmap.c > 1.73 +4 -1 src/sys/arm/arm/pmap.c > 1.577 +3 -1 src/sys/i386/i386/pmap.c > 1.180 +2 -0 src/sys/ia64/ia64/pmap.c > 1.112 +3 -2 src/sys/powerpc/powerpc/mmu_oea.c > 1.160 +4 -1 src/sys/sparc64/sparc64/pmap.c > 1.6 +3 -1 src/sys/sun4v/sun4v/pmap.c > 1.223 +2 -7 src/sys/vm/vm_fault.c > 1.124 +1 -1 src/sys/vm/vm_kern.c > From owner-cvs-src@FreeBSD.ORG Mon Nov 13 02:49:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A58E16A40F; Mon, 13 Nov 2006 02:49:27 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55CAC43D45; Mon, 13 Nov 2006 02:49:27 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD2nRvA075441; Mon, 13 Nov 2006 02:49:27 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD2nR0k075440; Mon, 13 Nov 2006 02:49:27 GMT (envelope-from delphij) Message-Id: <200611130249.kAD2nR0k075440@repoman.freebsd.org> From: Xin LI Date: Mon, 13 Nov 2006 02:49:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 02:49:27 -0000 delphij 2006-11-13 02:49:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: MFen 1.883.2.50 -> 1.883.2.51 Approved by: re (zh_CN.GB2312 relnotes blanket) Revision Changes Path 1.5.2.11 +9 -1 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 04:28:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F4F116A403; Mon, 13 Nov 2006 04:28:30 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A312043D4C; Mon, 13 Nov 2006 04:28:29 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD4STBC093716; Mon, 13 Nov 2006 04:28:29 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD4ST0U093715; Mon, 13 Nov 2006 04:28:29 GMT (envelope-from jkoshy) Message-Id: <200611130428.kAD4ST0U093715@repoman.freebsd.org> From: Joseph Koshy Date: Mon, 13 Nov 2006 04:28:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 04:28:30 -0000 jkoshy 2006-11-13 04:28:29 UTC FreeBSD src repository Modified files: include ar.h Log: Attempt to improve application portability by marking `struct ar_hdr' as `packed'. The C standard leaves the alignment of individual members of a C struct upto the implementation, so pedantically speaking portable code cannot assume that the layout of a `struct ar_hdr' in memory will match its layout in a file. Using a __packed attribute declaration forces file and memory layouts for this structure to match. Submitted by: ru Revision Changes Path 1.2 +5 -1 src/include/ar.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 04:38:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B862D16A412; Mon, 13 Nov 2006 04:38:57 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DC7E43D45; Mon, 13 Nov 2006 04:38:57 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD4cv6j096034; Mon, 13 Nov 2006 04:38:57 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD4cvkU096030; Mon, 13 Nov 2006 04:38:57 GMT (envelope-from csjp) Message-Id: <200611130438.kAD4cvkU096030@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Mon, 13 Nov 2006 04:38:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v trap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 04:38:57 -0000 csjp 2006-11-13 04:38:57 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v trap.c Log: Enable syscall auditing for sun4v the arch by implementing the AUDIT_SYSCALL_ENTER/EXIT macros. Discussed with: kmacy Revision Changes Path 1.4 +4 -0 src/sys/sun4v/sun4v/trap.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 05:41:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27DCB16A415; Mon, 13 Nov 2006 05:41:52 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BBA943D5E; Mon, 13 Nov 2006 05:41:51 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD5fpcp000795; Mon, 13 Nov 2006 05:41:51 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD5fk6c000792; Mon, 13 Nov 2006 05:41:46 GMT (envelope-from kmacy) Message-Id: <200611130541.kAD5fk6c000792@repoman.freebsd.org> From: Kip Macy Date: Mon, 13 Nov 2006 05:41:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys _lock.h lock.h lock_profile.h src/sys/kern kern_lock.c kern_mutex.c kern_rwlock.c kern_sx.c subr_lock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 05:41:52 -0000 kmacy 2006-11-13 05:41:46 UTC FreeBSD src repository Modified files: sys/sys _lock.h lock_profile.h lock.h sys/kern kern_lock.c kern_mutex.c kern_rwlock.c kern_sx.c subr_lock.c Log: track lock class name in a way that doesn't break WITNESS Revision Changes Path 1.103 +15 -7 src/sys/kern/kern_lock.c 1.178 +1 -1 src/sys/kern/kern_mutex.c 1.12 +1 -1 src/sys/kern/kern_rwlock.c 1.32 +1 -1 src/sys/kern/kern_sx.c 1.11 +4 -3 src/sys/kern/subr_lock.c 1.14 +6 -5 src/sys/sys/_lock.h 1.61 +1 -0 src/sys/sys/lock.h 1.6 +3 -2 src/sys/sys/lock_profile.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 05:43:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C52816A40F; Mon, 13 Nov 2006 05:43:42 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BEFF43D46; Mon, 13 Nov 2006 05:43:42 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD5hgRh000877; Mon, 13 Nov 2006 05:43:42 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD5hggK000875; Mon, 13 Nov 2006 05:43:42 GMT (envelope-from kmacy) Message-Id: <200611130543.kAD5hggK000875@repoman.freebsd.org> From: Kip Macy Date: Mon, 13 Nov 2006 05:43:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys lock.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 05:43:43 -0000 kmacy 2006-11-13 05:43:42 UTC FreeBSD src repository Modified files: sys/sys lock.h Log: Forced commit to append to previous log Approved by: scottl (standing in for mentor rwatson) Revision Changes Path 1.62 +0 -0 src/sys/sys/lock.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 05:51:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6707316A403; Mon, 13 Nov 2006 05:51:23 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30EBA43D4C; Mon, 13 Nov 2006 05:51:23 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD5pNI2001372; Mon, 13 Nov 2006 05:51:23 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD5pNIP001371; Mon, 13 Nov 2006 05:51:23 GMT (envelope-from kmacy) Message-Id: <200611130551.kAD5pNIP001371@repoman.freebsd.org> From: Kip Macy Date: Mon, 13 Nov 2006 05:51:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/coda coda_vnops.c coda_vnops.h src/sys/fs/nullfs null_vnops.c src/sys/kern vfs_default.c vfs_subr.c vfs_vnops.c vnode_if.src src/sys/sys vnode.h src/sys/ufs/ffs ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 05:51:23 -0000 kmacy 2006-11-13 05:51:22 UTC FreeBSD src repository Modified files: sys/coda coda_vnops.c coda_vnops.h sys/fs/nullfs null_vnops.c sys/kern vfs_default.c vfs_subr.c vfs_vnops.c vnode_if.src sys/sys vnode.h sys/ufs/ffs ffs_vnops.c Log: change vop_lock handling to allowing tracking of callers' file and line for acquisition of lockmgr locks Approved by: scottl (standing in for mentor rwatson) Revision Changes Path 1.69 +2 -2 src/sys/coda/coda_vnops.c 1.17 +1 -1 src/sys/coda/coda_vnops.h 1.92 +2 -2 src/sys/fs/nullfs/null_vnops.c 1.135 +5 -3 src/sys/kern/vfs_default.c 1.692 +3 -3 src/sys/kern/vfs_subr.c 1.247 +2 -5 src/sys/kern/vfs_vnops.c 1.84 +3 -1 src/sys/kern/vnode_if.src 1.318 +6 -2 src/sys/sys/vnode.h 1.163 +11 -9 src/sys/ufs/ffs/ffs_vnops.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 05:52:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0DE6516A492; Mon, 13 Nov 2006 05:52:12 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF5A043D46; Mon, 13 Nov 2006 05:52:11 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD5qB9Q001968; Mon, 13 Nov 2006 05:52:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD5qBDi001967; Mon, 13 Nov 2006 05:52:11 GMT (envelope-from ru) Message-Id: <200611130552.kAD5qBDi001967@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 05:52:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 05:52:12 -0000 ru 2006-11-13 05:52:11 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: There doesn't seem to be a real reason for include/ to be installed so early. Revision Changes Path 1.564 +9 -6 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Mon Nov 13 06:26:58 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 743FA16A40F; Mon, 13 Nov 2006 06:26:58 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8AF443D5E; Mon, 13 Nov 2006 06:26:57 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD6QvWB008554; Mon, 13 Nov 2006 06:26:57 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD6QvtS008553; Mon, 13 Nov 2006 06:26:57 GMT (envelope-from ru) Message-Id: <200611130626.kAD6QvtS008553@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 06:26:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/include pmap.h src/sys/arm/include pmap.h src/sys/i386/include pmap.h src/sys/ia64/include pmap.h src/sys/sun4v/include pmap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 06:26:58 -0000 ru 2006-11-13 06:26:57 UTC FreeBSD src repository Modified files: sys/amd64/include pmap.h sys/arm/include pmap.h sys/i386/include pmap.h sys/ia64/include pmap.h sys/sun4v/include pmap.h Log: Fix a comment. Revision Changes Path 1.135 +1 -1 src/sys/amd64/include/pmap.h 1.23 +1 -1 src/sys/arm/include/pmap.h 1.123 +1 -1 src/sys/i386/include/pmap.h 1.28 +1 -1 src/sys/ia64/include/pmap.h 1.2 +1 -1 src/sys/sun4v/include/pmap.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:10:07 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EB7416A7EB; Mon, 13 Nov 2006 09:10:07 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03D0B43D5D; Mon, 13 Nov 2006 09:10:07 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD8uh3w042192; Mon, 13 Nov 2006 08:56:43 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD8uhaG042191; Mon, 13 Nov 2006 08:56:43 GMT (envelope-from ru) Message-Id: <200611130856.kAD8uhaG042191@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 08:56:42 +0000 (UTC) To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 snd_spicds.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:10:07 -0000 ru 2006-11-13 08:56:42 UTC FreeBSD src repository Modified files: share/man/man4 snd_spicds.4 Log: Sort xrefs. Revision Changes Path 1.2 +2 -2 src/share/man/man4/snd_spicds.4 From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:12:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E37716ABB5; Mon, 13 Nov 2006 09:12:26 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C94E743D58; Mon, 13 Nov 2006 09:12:25 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD9CPRc045975; Mon, 13 Nov 2006 09:12:25 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD9CPDC045973; Mon, 13 Nov 2006 09:12:25 GMT (envelope-from ru) Message-Id: <200611130912.kAD9CPDC045973@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 09:12:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pccard/dumpcis dumpcis.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:12:26 -0000 ru 2006-11-13 09:12:25 UTC FreeBSD src repository Modified files: usr.sbin/pccard/dumpcis dumpcis.8 Log: The utility accepts multiple arguments. Revision Changes Path 1.2 +3 -3 src/usr.sbin/pccard/dumpcis/dumpcis.8 From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:26:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 77CBC16AEA4; Mon, 13 Nov 2006 09:26:12 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD64B43D5D; Mon, 13 Nov 2006 09:26:11 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 316BA32881D; Mon, 13 Nov 2006 19:30:14 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 84EE92740D; Mon, 13 Nov 2006 19:30:12 +1100 (EST) Date: Mon, 13 Nov 2006 19:30:11 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Joseph Koshy In-Reply-To: <200611130428.kAD4ST0U093715@repoman.freebsd.org> Message-ID: <20061113173927.Q75708@delplex.bde.org> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:26:12 -0000 On Mon, 13 Nov 2006, Joseph Koshy wrote: > jkoshy 2006-11-13 04:28:29 UTC > > FreeBSD src repository > > Modified files: > include ar.h > Log: > Attempt to improve application portability by marking `struct ar_hdr' > as `packed'. > > The C standard leaves the alignment of individual members of a C > struct upto the implementation, so pedantically speaking portable > code cannot assume that the layout of a `struct ar_hdr' in memory > will match its layout in a file. Using a __packed attribute > declaration forces file and memory layouts for this structure to > match. > > Submitted by: ru I don't see how this can be more portable. It uses an unportable extension, but packing is automatic on all compilers that are known to support this extension. On compilers that are not known to support this extension (all except gcc >= 2.7 and icc), using __packed gives a syntax error and thus changes code that is portable in practice into code that doesn't compile. On lints that known not to support this extension (FreeBSD lint), linting for portability is broken by not giving the syntax error. In , all struct members are char arrays so there will be no padding in practice. Most system headers depend on the padding being the same for all compilers, even when the struct member types are very varied. Many system headers use explicit manual padding to try to give a fixed layout. This works in practice, and the not-unused file system ffs and the not-unused networking component netinet depend on it working. Most file systems probably depend on it working across OS's for very varied struct types. One exception is msdosfs -- since msdosfs's disk data structures are poorly laid out even for an 8-bit system, they are almost perfectly misaligned even for a 16-bit system, so manual packing is not practical, and msdosfs declares most of the structures as byte arrays in much the same way as . It doesn't go as far as using a single array of bytes with fake struct members defined via offsets into the array, as might be required to be portable in theory. netinet uses __packed a bit, but this just gives unportability and pessimizations in practice. E.g., struct ip is manually packed and has a natural 4-byte alignment requirement, but declaring it as __packed reduces its alignment requirement to 1 byte; thus in internal structs like "struct x { int16_t x_foo; struct ip x_ip; };", the x_ip is normally misaligned on a 16-bit boundary and thus: - the layout of the internal struct is unportable in practice instead of unportable in theory - compilers for arches with strict alignment requirements have to generate extra instructions to access the 32-bit members in struct ip (just 2 in_addr_t's), so the accesses are pessimized and not atomic. gcc on i64's seems to do this correctly. The pessimization is by a factor of 14 according to the instruction count (a single 32-bit load instruction for an in_addr_t gets replaced by 4 8-bit load instructions and 10 more instructions to combine the bytes). - code like "struct x *xp; ... foo(&xp->x_ip.ip_src);" is broken on on arches with strict alignment requirements. After the address of the in_addr_t is passed to another function, the compiler can no longer easiliy see that it has to generate pessimal loads for accesses to the in_addr_t. A variant of this bug occurred in practice in rev.1.18 of . There, almost eveything is naturally aligned to a 16-bit boundary, and __packed is misused to give 8-bitr alignment as a bad side effect. Rev.1.18 added a 32-bit member in one of the structs contained in the __packed struct. This should have just broken binary compatibility and might not have mattered depending on how internal the __packed struct is. Instead, it gave misaligned 32-bit values instide the __packed struct, thus defeating the reason for existence of rev.1.18, since the reason was to add a union hack to allow accessing "char c_net[4];" as "u_int u_net;", but union hacks like this depend on not using __packed in any struct containing c/u_net (recursively). gcc -Wpacked can be used to find bugs like this. See gcc.info for more details. Passing the address of a non-char member in a packed struct should be an error, but gcc doesn't seem to diagnose this. was broken by adding __packed in the same commit that removed an unportable bitfield from it. The bitfield was the actual problem. Bitfields should never be used in structs that have to match an externally imposed layouts since they are unportable in practice. gcc's bitfields are especially unportable. E.g. "int:8" gives the same alignment requirement as int, and this is undocumented. In gcc, you have to use "char:8" or __packed to get 8-bit alignment of structs containing bitfields, but these are constraint and syntax errors in C. Using __packed in isn't as bad as in since struct ar has a natural 1-byte alignment requirement so using __packed is a no-op in practice. Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:35:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A62B116A69E; Mon, 13 Nov 2006 09:35:25 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30E0243D58; Mon, 13 Nov 2006 09:35:24 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 8D904170C5; Mon, 13 Nov 2006 09:35:23 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.8/8.13.8) with ESMTP id kAD9ZJto003802; Mon, 13 Nov 2006 09:35:23 GMT (envelope-from phk@critter.freebsd.dk) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 13 Nov 2006 19:30:11 +1100." <20061113173927.Q75708@delplex.bde.org> Date: Mon, 13 Nov 2006 09:35:19 +0000 Message-ID: <3801.1163410519@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Joseph Koshy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:35:25 -0000 In message <20061113173927.Q75708@delplex.bde.org>, Bruce Evans writes: >On Mon, 13 Nov 2006, Joseph Koshy wrote: > >> jkoshy 2006-11-13 04:28:29 UTC >> >> FreeBSD src repository >> >> Modified files: >> include ar.h >> Log: >> Attempt to improve application portability by marking `struct ar_hdr' >> as `packed'. >> >> The C standard leaves the alignment of individual members of a C >> struct upto the implementation, so pedantically speaking portable >> code cannot assume that the layout of a `struct ar_hdr' in memory >> will match its layout in a file. Using a __packed attribute >> declaration forces file and memory layouts for this structure to >> match. >> >> Submitted by: ru > >I don't see how this can be more portable. I agree with bruce that __packed is not the way to go. For things that represent communication protocols, even if they happen through files, I advocate using the functions in sys/endian.h to explicitly decode and encode fields into bytestrings. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:43:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 801B816A494; Mon, 13 Nov 2006 09:43:16 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep14-int.chello.at (viefep15-int.chello.at [213.46.255.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA19C43D45; Mon, 13 Nov 2006 09:43:14 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep14-int.chello.at (InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id <20061113094312.FSDQ7416.viefep14-int.chello.at@wombat.fafoe.narf.at>; Mon, 13 Nov 2006 10:43:12 +0100 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id B0E97BC87; Mon, 13 Nov 2006 10:43:11 +0100 (CET) Date: Mon, 13 Nov 2006 10:43:11 +0100 From: Stefan Farfeleder To: Bruce Evans Message-ID: <20061113094311.GC97460@wombat.fafoe.narf.at> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061113173927.Q75708@delplex.bde.org> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: Joseph Koshy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:43:16 -0000 On Mon, Nov 13, 2006 at 07:30:11PM +1100, Bruce Evans wrote: > On Mon, 13 Nov 2006, Joseph Koshy wrote: > > >jkoshy 2006-11-13 04:28:29 UTC > > > > FreeBSD src repository > > > > Modified files: > > include ar.h > > Log: > > Attempt to improve application portability by marking `struct ar_hdr' > > as `packed'. > > > > The C standard leaves the alignment of individual members of a C > > struct upto the implementation, so pedantically speaking portable > > code cannot assume that the layout of a `struct ar_hdr' in memory > > will match its layout in a file. Using a __packed attribute > > declaration forces file and memory layouts for this structure to > > match. > > > > Submitted by: ru > > I don't see how this can be more portable. It uses an unportable > extension, but packing is automatic on all compilers that are known > to support this extension. On compilers that are not known to support > this extension (all except gcc >= 2.7 and icc), using __packed gives > a syntax error and thus changes code that is portable in practice into > code that doesn't compile. On lints that known not to support this > extension (FreeBSD lint), linting for portability is broken by not > giving the syntax error. > > In , all struct members are char arrays so there will be no > padding in practice. You seem to have missed the discussion on -current. GCC pads "struct foo { char c; };" to 4 bytes on ARM. I agree on __packed not being portable. Stefan From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:46:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54EE616A494; Mon, 13 Nov 2006 09:46:17 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1982043D5A; Mon, 13 Nov 2006 09:46:17 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAD9kGXA051106; Mon, 13 Nov 2006 09:46:17 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAD9kGiw051105; Mon, 13 Nov 2006 09:46:16 GMT (envelope-from ru) Message-Id: <200611130946.kAD9kGiw051105@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 09:46:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libelf elf.3 elf_begin.3 elf_cntl.3 elf_end.3 elf_errmsg.3 elf_fill.3 elf_flagdata.3 elf_getarhdr.3 elf_getarsym.3 elf_getbase.3 elf_getdata.3 elf_getident.3 elf_getscn.3 elf_getshnum.3 elf_getshstrndx.3 elf_hash.3 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:46:18 -0000 ru 2006-11-13 09:46:16 UTC FreeBSD src repository Modified files: lib/libelf elf.3 elf_begin.3 elf_cntl.3 elf_end.3 elf_errmsg.3 elf_fill.3 elf_flagdata.3 elf_getarhdr.3 elf_getarsym.3 elf_getbase.3 elf_getdata.3 elf_getident.3 elf_getscn.3 elf_getshnum.3 elf_getshstrndx.3 elf_hash.3 elf_kind.3 elf_memory.3 elf_next.3 elf_rand.3 elf_rawfile.3 elf_strptr.3 elf_update.3 elf_version.3 gelf_checksum.3 gelf_fsize.3 gelf_getcap.3 gelf_getclass.3 gelf_getdyn.3 gelf_getehdr.3 gelf_getmove.3 gelf_getphdr.3 gelf_getrel.3 gelf_getrela.3 gelf_getshdr.3 gelf_getsym.3 gelf_getsyminfo.3 gelf_getsymshndx.3 gelf_newehdr.3 gelf_newphdr.3 gelf_update_ehdr.3 gelf_xlatetof.3 Log: Fix minor formatting issues: - make document title match filename; - remove hard sentence breaks, whitespace at EOL, and double whitespace; - sort SEE ALSO xrefs, adding missing section numbers; - fix a misspelled macro name. Revision Changes Path 1.2 +2 -1 src/lib/libelf/elf.3 1.2 +1 -1 src/lib/libelf/elf_begin.3 1.2 +1 -1 src/lib/libelf/elf_cntl.3 1.2 +1 -1 src/lib/libelf/elf_end.3 1.2 +1 -1 src/lib/libelf/elf_errmsg.3 1.2 +2 -2 src/lib/libelf/elf_fill.3 1.2 +3 -3 src/lib/libelf/elf_flagdata.3 1.2 +2 -2 src/lib/libelf/elf_getarhdr.3 1.2 +1 -1 src/lib/libelf/elf_getarsym.3 1.2 +2 -2 src/lib/libelf/elf_getbase.3 1.2 +2 -2 src/lib/libelf/elf_getdata.3 1.2 +3 -3 src/lib/libelf/elf_getident.3 1.2 +1 -1 src/lib/libelf/elf_getscn.3 1.2 +3 -3 src/lib/libelf/elf_getshnum.3 1.2 +3 -3 src/lib/libelf/elf_getshstrndx.3 1.2 +2 -2 src/lib/libelf/elf_hash.3 1.2 +3 -3 src/lib/libelf/elf_kind.3 1.2 +1 -1 src/lib/libelf/elf_memory.3 1.2 +1 -1 src/lib/libelf/elf_next.3 1.2 +1 -1 src/lib/libelf/elf_rand.3 1.2 +1 -1 src/lib/libelf/elf_rawfile.3 1.2 +4 -4 src/lib/libelf/elf_strptr.3 1.2 +11 -11 src/lib/libelf/elf_update.3 1.2 +1 -1 src/lib/libelf/elf_version.3 1.2 +2 -2 src/lib/libelf/gelf_checksum.3 1.2 +2 -2 src/lib/libelf/gelf_fsize.3 1.2 +1 -1 src/lib/libelf/gelf_getcap.3 1.2 +1 -1 src/lib/libelf/gelf_getclass.3 1.2 +1 -1 src/lib/libelf/gelf_getdyn.3 1.2 +3 -3 src/lib/libelf/gelf_getehdr.3 1.2 +1 -1 src/lib/libelf/gelf_getmove.3 1.2 +2 -2 src/lib/libelf/gelf_getphdr.3 1.2 +1 -1 src/lib/libelf/gelf_getrel.3 1.2 +1 -1 src/lib/libelf/gelf_getrela.3 1.2 +1 -1 src/lib/libelf/gelf_getshdr.3 1.2 +1 -1 src/lib/libelf/gelf_getsym.3 1.2 +1 -1 src/lib/libelf/gelf_getsyminfo.3 1.2 +1 -1 src/lib/libelf/gelf_getsymshndx.3 1.2 +3 -3 src/lib/libelf/gelf_newehdr.3 1.2 +2 -2 src/lib/libelf/gelf_newphdr.3 1.2 +1 -1 src/lib/libelf/gelf_update_ehdr.3 1.2 +1 -1 src/lib/libelf/gelf_xlatetof.3 From owner-cvs-src@FreeBSD.ORG Mon Nov 13 09:59:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 149ED16A4A0; Mon, 13 Nov 2006 09:59:22 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8472943D7E; Mon, 13 Nov 2006 09:59:05 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id 1519432819B; Mon, 13 Nov 2006 20:58:56 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 6D0968C0E; Mon, 13 Nov 2006 20:58:54 +1100 (EST) Date: Mon, 13 Nov 2006 20:58:53 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200611130717.03734.davidxu@freebsd.org> Message-ID: <20061113193924.L75708@delplex.bde.org> References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <200611120716.10773.davidxu@freebsd.org> <20061112170556.U71828@delplex.bde.org> <200611130717.03734.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 09:59:22 -0000 On Mon, 13 Nov 2006, David Xu wrote: > On Sunday 12 November 2006 14:26, Bruce Evans wrote: >> ... >> Testing showed that nothing much is fixed. Simple benchmarks like: >> ... >> %%% >> for i in 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 >> do >> nice -$i sh -c "while :; do echo -n;done" & >> done >> top -o time >> %%% >> >> still show that scheduling without KSE is very unfair. They can take >> several minutes to start the `top' process, and "killall sh" can take >> many seconds to start unless you have an rtprio shell to start the >> killall. >> >> With KSE, the top process starts soon enough and shows just the old >> 4BSD scheduler bug that too many cycles are given to niced programs, >> as in all versions of FreeBSD except 4.x. Since no one uses niced >> programs, this bug is unimportant. > > It might not be a bug of the NO_KSE, the problem is in sched_fork() and > sched_exit(), for process which quickly fork() a child and then the child > exits quickly, the parent's estcpu will be doubled quickly too, this fairness > is really unfair, That can't be the problem, since there are no exits in the above. > I think your examples is the scenario, however, I don't know > why KSE works better. this might be fixed by remembering the inherited > estcpu in child, and decay it every second. when the child exits, > it add really used estcpu to parent. code looks like this: > > in sched_fork(), we remember inherited estcpu: > td->td_inherited_estcpu = parent->td_estcpu; > in schedcpu(), we decay it every second (should be fixed in sched_wakeup > too): > td->td_inherited_estcpu = decaycpu(loadfac, td->td_inherited_cpu); > in sched_exit(); > parent->td_estcpu = ESTCPULIM(parent->td_estcpu, > childtd->td_estcpu - td->td_inherited_cpu); > > This should fix the quickly fork() and exit() problem for parent process. I've known about this bug since Peter Default told me about it in late 1999, and now use the code at the end of this mail to avoid it. However, I remembered it incorrectly and may have misdescribed it to you. I thought I remembered actual doubling, with estcpu soon reaching "infinity", but the ESTCPULIM() clamp prevents it getting preposterously high now, and I couldn't find any version that let it reach "infinity". Versions before late 1999 had a bogus limit of UCHAR_MAX and that may have been responsible for shells appearing to hang because it was a better approximation to "infinity". I now use the following: % Index: sched_4bsd.c % =================================================================== % RCS file: /home/ncvs/src/sys/kern/sched_4bsd.c,v % retrieving revision 1.41 % diff -u -2 -r1.41 sched_4bsd.c % --- sched_4bsd.c 21 Jun 2004 23:47:47 -0000 1.41 % +++ sched_4bsd.c 8 Dec 2005 11:11:52 -0000 % @@ -550,9 +641,20 @@ % % void % -sched_exit_ksegrp(struct ksegrp *kg, struct ksegrp *child) % +sched_exit_ksegrp(struct ksegrp *parent, struct ksegrp *child) % { % % mtx_assert(&sched_lock, MA_OWNED); % - kg->kg_estcpu = ESTCPULIM(kg->kg_estcpu + child->kg_estcpu); % + /* % + * XXX adding all of the child's cpu to the parent's like we used to % + * do would be wrong, since we duplicate the parent's cpu at fork % + * time so adding it all back would give exponential growth. In % + * practice, the growth would have been limited by ESTCPULIM, but that % + * would be wrong too since it is very nonlinear. Splitting the cpu % + * at fork time would be better, but adding it all back here would % + * still give nonlinearities since multiple processes tend to % + * accumulate more cpu than single ones. % + */ % + if (parent->kg_estcpu < child->kg_estcpu) % + parent->kg_estcpu = child->kg_estcpu; % } % This seems to work well enough in practice. It grows the parent's estcpu quite slowly if there are a lot of fork/exits. Previous versions did something different on fork too. Splitting or otherwise reducing estcpu on fork isn't such a good idea since it reduces the limit on the real resource hogs -- all the children, when there are lots of children that all want to run. When the children don't exit, hacking on the parent's estcpu doesn't help, and doubling the child's estpcu on fork and halving it on exit is closer to being correct than the reverse. At least one of Peter Dufault's versions removed all explicit accesses to p_estcpu on fork and exit. I think the change on fork is only cosmetic -- p_estcpu should have been automatically copied on fork. Anyway, this isn't the bug in non-KSE. I didn't look hard for the reasons. Top seemed to show the priorites of the hogs not decreasing (numerically increasing) fast enough. Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 11:00:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF46D16A415; Mon, 13 Nov 2006 11:00:26 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5239043D45; Mon, 13 Nov 2006 11:00:26 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 4753350913B; Mon, 13 Nov 2006 22:00:24 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 9A0858C06; Mon, 13 Nov 2006 22:00:23 +1100 (EST) Date: Mon, 13 Nov 2006 22:00:22 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Poul-Henning Kamp In-Reply-To: <3801.1163410519@critter.freebsd.dk> Message-ID: <20061113214928.P76443@delplex.bde.org> References: <3801.1163410519@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Joseph Koshy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 11:00:27 -0000 On Mon, 13 Nov 2006, Poul-Henning Kamp wrote: > In message <20061113173927.Q75708@delplex.bde.org>, Bruce Evans writes: >> On Mon, 13 Nov 2006, Joseph Koshy wrote: >> >>> jkoshy 2006-11-13 04:28:29 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> include ar.h >>> Log: >>> Attempt to improve application portability by marking `struct ar_hdr' >>> as `packed'. >>> ... > > I agree with bruce that __packed is not the way to go. > > For things that represent communication protocols, even if > they happen through files, I advocate using the functions > in sys/endian.h to explicitly decode and encode fields into > bytestrings. But already uses byte strings for everything. It just requires no padding between the byte strings (so that the offsets are constant), and no padding at the end (so that offsets are constant if the struct is contained in another struct that is at least as careful about padding an aligment). BTW, you are responsible for the __packed in . Please remove it. The __CTASSERT() is enough to detect if heroic packing is ever needed. The only danger is if something has grown to depend on __packed reducing alignment as a side effect. E.g., suppose we had a byte string containing a bytewise copy of a struct ip. If the copy might be misaligned, then it should be copied to an actual struct ip before accessing it as a struct, but code that accesses it directly using ((struct ip *)&bs[N]) would work now due to the reduced alignment. Places that really need __packed should probably use __aligned() to restore the natural alignment. Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 11:20:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D77F16A416; Mon, 13 Nov 2006 11:20:14 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 751CE43D72; Mon, 13 Nov 2006 11:19:33 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 7B16A6EA75; Mon, 13 Nov 2006 22:19:31 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id D7C972741C; Mon, 13 Nov 2006 22:19:30 +1100 (EST) Date: Mon, 13 Nov 2006 22:19:29 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Stefan Farfeleder In-Reply-To: <20061113094311.GC97460@wombat.fafoe.narf.at> Message-ID: <20061113220031.V76443@delplex.bde.org> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113094311.GC97460@wombat.fafoe.narf.at> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Joseph Koshy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 11:20:14 -0000 On Mon, 13 Nov 2006, Stefan Farfeleder wrote: > On Mon, Nov 13, 2006 at 07:30:11PM +1100, Bruce Evans wrote: >> On Mon, 13 Nov 2006, Joseph Koshy wrote: >> >>> jkoshy 2006-11-13 04:28:29 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> include ar.h >>> Log: >>> Attempt to improve application portability by marking `struct ar_hdr' >>> as `packed'. >>> ... >> I don't see how this can be more portable. It uses an unportable >> extension, but packing is automatic on all compilers that are known >> to support this extension. On compilers that are not known to support >> ... >> In , all struct members are char arrays so there will be no >> padding in practice. > > You seem to have missed the discussion on -current. GCC pads "struct foo > { char c; };" to 4 bytes on ARM. I agree on __packed not being > portable. I don't read -current. Peharps I shouldn't comment on it. I think it is a bug for ARM to do that. If __packed actually gives a size of 1, then the padding must be only an optimization for time. struct ar's natural size is 60, so __packed is unnecessary for ARM too (unless there is internal padding which would cause more problems). Apparently, struct ar was manually packed to a multiple of the word size back when the largest word size was 32 bits. It has already been changed at least once without leaving enough space for expansion. In V7 it was "char ar_name[14]; long ar_date; char ar_uid; ..." so it had bad packing starting at its second member and really bad packing starting at its third member. Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 12:41:43 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4362316A47B; Mon, 13 Nov 2006 12:41:43 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72BD743D62; Mon, 13 Nov 2006 12:41:34 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id AD1FB5D8F; Mon, 13 Nov 2006 15:41:33 +0300 (MSK) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 8A3D25D89; Mon, 13 Nov 2006 15:41:33 +0300 (MSK) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id kADCfbQK029310; Mon, 13 Nov 2006 15:41:38 +0300 (MSK) (envelope-from ru) Date: Mon, 13 Nov 2006 15:41:37 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20061113124137.GE25008@rambler-co.ru> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113094311.GC97460@wombat.fafoe.narf.at> <20061113220031.V76443@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline In-Reply-To: <20061113220031.V76443@delplex.bde.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: Joseph Koshy , Stefan Farfeleder , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 12:41:43 -0000 --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2006 at 10:19:29PM +1100, Bruce Evans wrote: > On Mon, 13 Nov 2006, Stefan Farfeleder wrote: [...] > >You seem to have missed the discussion on -current. GCC pads "struct foo > >{ char c; };" to 4 bytes on ARM. I agree on __packed not being > >portable. >=20 > I don't read -current. Peharps I shouldn't comment on it. >=20 > I think it is a bug for ARM to do that. If __packed actually gives a size > of 1, then the padding must be only an optimization for time. >=20 I thought so as well. Please see this email and emails surrounding it: http://lists.freebsd.org/pipermail/freebsd-arm/2006-November/000198.html > struct ar's natural size is 60, so __packed is unnecessary for ARM too > (unless there is internal padding which would cause more problems). >=20 Adding __packed didn't change sizeof(struct ar) on FreeBSD/arm but removed the 4-byte alignment requirement for it, which is what we were attacking. It now generates less optimal assembly (byte loads instead of 32-bit word loads), but a discussion on -arm suggested that it's ok for this struct to be packed. ISO C99 is clear that padding (except at the beginning) is compiler/machine dependent: : Within a structure object, the non-bit-field members and the units : in which bit-fields reside have addresses that increase in the order : in which they are declared. A pointer to a structure object, suitably : converted, points to its initial member (or if that member is a : bit-field, then to the unit in which it resides), and vice versa. : There may be unnamed padding within a structure object, but not at : its beginning. So there doesn't seem to be a portable way to "lay" structures on externally supplied data, e.g., data read from files. It means that we'd have to use bytestrings loads that Poul-Henning mentioned to be portable, but I think a common sense should win between imaginary portability and practical performance -- it's often not desirable to copy a data again, fully or in part, just for the sake of portability (e.g. in network code) if we know how our beloved compiler packs the data. And if we ever switch to a compiler with different packing rules (packing rules in GCC seems to be "natural" in your speak), a LOT of our programs will break. Again, we added __packed here only for its (documented) side effect to lower the alignment requirement, not packing. In practice, adding __packed on this structure (which is "all chars") and is already "naturally packed", doesn't have any effect on assembly on all platforms that don't REQUIRE an unnatural alignment (i.e., anything except ARM). And by using bytestring loading instead we'd loose performance on all architectures. This OTOH penalizes code on ARM, but I think that IN THIS PARTICULAR CASE of a structure of all chars it's okay. I agree that -Wpacked should probably be used to identify harmful instances of __packed. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFWGgBqRfpzJluFF4RAg7EAJ0SR2pyKQT2dWRqj/rgBAv/HvqZdwCfestn zQ6psjV1SD7uf6io6xqp0XU= =zqXy -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ-- From owner-cvs-src@FreeBSD.ORG Mon Nov 13 12:48:16 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id DC9C416A403; Mon, 13 Nov 2006 12:48:15 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Mon, 13 Nov 2006 20:48:07 +0800 User-Agent: KMail/1.8.2 References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <200611130717.03734.davidxu@freebsd.org> <20061113193924.L75708@delplex.bde.org> In-Reply-To: <20061113193924.L75708@delplex.bde.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200611132048.08180.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 12:48:16 -0000 On Monday 13 November 2006 17:58, Bruce Evans wrote: > > It might not be a bug of the NO_KSE, the problem is in sched_fork() and > > sched_exit(), for process which quickly fork() a child and then the child > > exits quickly, the parent's estcpu will be doubled quickly too, this > > fairness is really unfair, > > That can't be the problem, since there are no exits in the above. > I have tried the change I mentioned, and top runs quickly and the system does not have the problem as you described. > > I think your examples is the scenario, however, I don't know > > why KSE works better. this might be fixed by remembering the inherited > > estcpu in child, and decay it every second. when the child exits, > > it add really used estcpu to parent. code looks like this: > > > > in sched_fork(), we remember inherited estcpu: > > td->td_inherited_estcpu = parent->td_estcpu; > > in schedcpu(), we decay it every second (should be fixed in sched_wakeup > > too): > > td->td_inherited_estcpu = decaycpu(loadfac, td->td_inherited_cpu); > > in sched_exit(); > > parent->td_estcpu = ESTCPULIM(parent->td_estcpu, > > childtd->td_estcpu - td->td_inherited_cpu); > > > > This should fix the quickly fork() and exit() problem for parent process. > > I've known about this bug since Peter Default told me about it in late > 1999, and now use the code at the end of this mail to avoid it. However, > I remembered it incorrectly and may have misdescribed it to you. I > thought I remembered actual doubling, with estcpu soon reaching > "infinity", but the ESTCPULIM() clamp prevents it getting preposterously > high now, and I couldn't find any version that let it reach "infinity". > Versions before late 1999 had a bogus limit of UCHAR_MAX and that may > have been responsible for shells appearing to hang because it was a > better approximation to "infinity". > > I now use the following: > > % Index: sched_4bsd.c > % =================================================================== > % RCS file: /home/ncvs/src/sys/kern/sched_4bsd.c,v > % retrieving revision 1.41 > % diff -u -2 -r1.41 sched_4bsd.c > % --- sched_4bsd.c 21 Jun 2004 23:47:47 -0000 1.41 > % +++ sched_4bsd.c 8 Dec 2005 11:11:52 -0000 > % @@ -550,9 +641,20 @@ > % > % void > % -sched_exit_ksegrp(struct ksegrp *kg, struct ksegrp *child) > % +sched_exit_ksegrp(struct ksegrp *parent, struct ksegrp *child) > % { > % > % mtx_assert(&sched_lock, MA_OWNED); > % - kg->kg_estcpu = ESTCPULIM(kg->kg_estcpu + child->kg_estcpu); > % + /* > % + * XXX adding all of the child's cpu to the parent's like we used to > % + * do would be wrong, since we duplicate the parent's cpu at fork > % + * time so adding it all back would give exponential growth. In > % + * practice, the growth would have been limited by ESTCPULIM, but that > % + * would be wrong too since it is very nonlinear. Splitting the cpu > % + * at fork time would be better, but adding it all back here would > % + * still give nonlinearities since multiple processes tend to > % + * accumulate more cpu than single ones. > % + */ > % + if (parent->kg_estcpu < child->kg_estcpu) > % + parent->kg_estcpu = child->kg_estcpu; > % } > % > > This seems to work well enough in practice. It grows the parent's estcpu > quite slowly if there are a lot of fork/exits. > Yes, I knew there was the patch. > Previous versions did something different on fork too. Splitting or > otherwise reducing estcpu on fork isn't such a good idea since it > reduces the limit on the real resource hogs -- all the children, when > there are lots of children that all want to run. When the children > don't exit, hacking on the parent's estcpu doesn't help, and doubling > the child's estpcu on fork and halving it on exit is closer to being > correct than the reverse. > > At least one of Peter Dufault's versions removed all explicit accesses > to p_estcpu on fork and exit. I think the change on fork is only > cosmetic -- p_estcpu should have been automatically copied on fork. > > Anyway, this isn't the bug in non-KSE. I didn't look hard for the > reasons. Top seemed to show the priorites of the hogs not decreasing > (numerically increasing) fast enough. > I still can not find the bug although I have read all changes several times. > Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 15:22:49 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B51F16A500; Mon, 13 Nov 2006 15:22:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBF8D43E5C; Mon, 13 Nov 2006 15:11:39 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kADFBGLV013412; Mon, 13 Nov 2006 10:11:21 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kip Macy Date: Mon, 13 Nov 2006 10:11:10 -0500 User-Agent: KMail/1.9.1 References: <200611130541.kAD5fk6c000792@repoman.freebsd.org> In-Reply-To: <200611130541.kAD5fk6c000792@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611131011.11119.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 13 Nov 2006 10:11:21 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2190/Mon Nov 13 04:31:57 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys _lock.h lock.h lock_profile.h src/sys/kern kern_lock.c kern_mutex.c kern_rwlock.c kern_sx.c subr_lock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 15:22:49 -0000 On Monday 13 November 2006 00:41, Kip Macy wrote: > kmacy 2006-11-13 05:41:46 UTC > > FreeBSD src repository > > Modified files: > sys/sys _lock.h lock_profile.h lock.h > sys/kern kern_lock.c kern_mutex.c kern_rwlock.c > kern_sx.c subr_lock.c > Log: > track lock class name in a way that doesn't break WITNESS Is there any reason not to just make lockmgr call lock_init() and lock_destroy() and then do lock_profile_object_init() and lock_profile_object_destroy() from those? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Nov 13 15:23:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C8B116A65A; Mon, 13 Nov 2006 15:23:02 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A192E43FFA; Mon, 13 Nov 2006 15:13:08 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADFD52c017356; Mon, 13 Nov 2006 15:13:05 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADFD52n017355; Mon, 13 Nov 2006 15:13:05 GMT (envelope-from pjd) Message-Id: <200611131513.kADFD52n017355@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 13 Nov 2006 15:13:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/ggate/shared ggate.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 15:23:02 -0000 pjd 2006-11-13 15:13:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/ggate/shared ggate.c Log: MFC: sbin/ggate/shared/ggate.c 1.6 - Handle timeouts from recv(2) properly. - Increase timeout to 8 seconds (should be made configurable). Reported by: Kazuaki ODA Reported by: Ulrich Spoerlein Reported by: Christian Laursen PR: kern/104829 Approved by: re (bmah) Revision Changes Path 1.5.2.1 +6 -2 src/sbin/ggate/shared/ggate.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 15:25:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7537216A4EB for ; Mon, 13 Nov 2006 15:25:35 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8F6343F4D for ; Mon, 13 Nov 2006 15:20:42 +0000 (GMT) (envelope-from jkoshy.freebsd@gmail.com) Received: by wr-out-0506.google.com with SMTP id i3so88823wra for ; Mon, 13 Nov 2006 07:20:38 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=dcHY3nROniFKF5WJY3diNAPX0cCem8hF7a86Z8GYWReevXoUCj2Y8FA17gpRv9coUSKsSj4pDW/1QvzDDZhaAuncL6JQ2rvXnFVCuDcT4lU1cxyC0Tgbw7hpasEQT5X4XddFD2zAZCRB6xdL0rrw9N9bUC+zZY3kge48QDp95S0= Received: by 10.65.235.7 with SMTP id m7mr7537733qbr.1163431218155; Mon, 13 Nov 2006 07:20:18 -0800 (PST) Received: by 10.64.10.8 with HTTP; Mon, 13 Nov 2006 07:20:16 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2006 20:50:16 +0530 From: "Joseph Koshy" Sender: jkoshy.freebsd@gmail.com To: "Ruslan Ermilov" In-Reply-To: <200611130946.kAD9kGiw051105@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611130946.kAD9kGiw051105@repoman.freebsd.org> X-Google-Sender-Auth: 90edd39f2cb7084e Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libelf elf.3 elf_begin.3 elf_cntl.3 elf_end.3 elf_errmsg.3 elf_fill.3 elf_flagdata.3 elf_getarhdr.3 elf_getarsym.3 elf_getbase.3 elf_getdata.3 elf_getident.3 elf_getscn.3 elf_getshnum.3 elf_getshstrndx.3 elf_hash.3 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 15:25:35 -0000 > ru 2006-11-13 09:46:16 UTC > > FreeBSD src repository > > Modified files: > lib/libelf elf.3 elf_begin.3 elf_cntl.3 elf_end.3 > elf_errmsg.3 elf_fill.3 elf_flagdata.3 > elf_getarhdr.3 elf_getarsym.3 > elf_getbase.3 elf_getdata.3 > elf_getident.3 elf_getscn.3 > elf_getshnum.3 elf_getshstrndx.3 > elf_hash.3 elf_kind.3 elf_memory.3 > elf_next.3 elf_rand.3 elf_rawfile.3 > elf_strptr.3 elf_update.3 elf_version.3 > gelf_checksum.3 gelf_fsize.3 > gelf_getcap.3 gelf_getclass.3 > gelf_getdyn.3 gelf_getehdr.3 > gelf_getmove.3 gelf_getphdr.3 > gelf_getrel.3 gelf_getrela.3 > gelf_getshdr.3 gelf_getsym.3 > gelf_getsyminfo.3 gelf_getsymshndx.3 > gelf_newehdr.3 gelf_newphdr.3 > gelf_update_ehdr.3 gelf_xlatetof.3 > Log: > Fix minor formatting issues: > > - make document title match filename; > - remove hard sentence breaks, whitespace at EOL, and double whitespace; > - sort SEE ALSO xrefs, adding missing section numbers; > - fix a misspelled macro name. Thank you. Regards, Koshy From owner-cvs-src@FreeBSD.ORG Mon Nov 13 15:31:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CFEC16A4D0; Mon, 13 Nov 2006 15:31:02 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B52C43D7B; Mon, 13 Nov 2006 15:30:46 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 1D0E2487F3; Mon, 13 Nov 2006 16:30:44 +0100 (CET) Received: from localhost (dkr141.neoplus.adsl.tpnet.pl [83.24.21.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 136F945B26; Mon, 13 Nov 2006 16:30:35 +0100 (CET) Date: Mon, 13 Nov 2006 16:30:29 +0100 From: Pawel Jakub Dawidek To: Kip Macy Message-ID: <20061113153029.GC25940@garage.freebsd.pl> References: <200611130551.kAD5pNIP001371@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gr/z0/N6AeWAPJVB" Content-Disposition: inline In-Reply-To: <200611130551.kAD5pNIP001371@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: ** X-Spam-Status: No, score=2.6 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL,RCVD_IN_XBL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_vnops.c coda_vnops.h src/sys/fs/nullfs null_vnops.c src/sys/kern vfs_default.c vfs_subr.c vfs_vnops.c vnode_if.src src/sys/sys vnode.h src/sys/ufs/ffs ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 15:31:02 -0000 --gr/z0/N6AeWAPJVB Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2006 at 05:51:22AM +0000, Kip Macy wrote: > kmacy 2006-11-13 05:51:22 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/coda coda_vnops.c coda_vnops.h=20 > sys/fs/nullfs null_vnops.c=20 > sys/kern vfs_default.c vfs_subr.c vfs_vnops.c=20 > vnode_if.src=20 > sys/sys vnode.h=20 > sys/ufs/ffs ffs_vnops.c=20 > Log: > change vop_lock handling to allowing tracking of callers' file and line= for > acquisition of lockmgr locks [...] > --- src/sys/coda/coda_vnops.c 2006/02/01 00:25:24 1.68 > +++ src/sys/coda/coda_vnops.c 2006/11/13 05:51:21 1.69 [...] > .vop_reclaim =3D coda_reclaim, /* reclaim */ > - .vop_lock =3D coda_lock, /* lock */ > + ._vop_lock =3D coda_lock, /* lock */ > .vop_unlock =3D coda_unlock, /* unlock */ [...] > --- src/sys/fs/nullfs/null_vnops.c 2006/03/12 04:58:18 1.91 > +++ src/sys/fs/nullfs/null_vnops.c 2006/11/13 05:51:21 1.92 [...] > .vop_islocked =3D null_islocked, > - .vop_lock =3D null_lock, > + ._vop_lock =3D null_lock, > .vop_lookup =3D null_lookup, [...] > --- src/sys/kern/vfs_default.c 2006/09/20 00:27:02 1.134 > +++ src/sys/kern/vfs_default.c 2006/11/13 05:51:22 1.135 [...] > .vop_lease =3D VOP_NULL, > - .vop_lock =3D vop_stdlock, > + ._vop_lock =3D vop_stdlock, > .vop_lookup =3D vop_nolookup, [...] > --- src/sys/kern/vfs_subr.c 2006/11/07 19:45:05 1.691 > +++ src/sys/kern/vfs_subr.c 2006/11/13 05:51:22 1.692 [...] > .vop_reclaim =3D sync_reclaim, /* reclaim */ > - .vop_lock =3D vop_stdlock, /* lock */ > + ._vop_lock =3D vop_stdlock, /* lock */ > .vop_unlock =3D vop_stdunlock, /* unlock */ > --- src/sys/ufs/ffs/ffs_vnops.c 2006/11/06 13:42:09 1.162 > +++ src/sys/ufs/ffs/ffs_vnops.c 2006/11/13 05:51:22 1.163 [...] > .vop_getpages =3D ffs_getpages, > - .vop_lock =3D ffs_lock, > + ._vop_lock =3D ffs_lock, > .vop_read =3D ffs_read, [...] > .vop_getpages =3D ffs_getpages, > - .vop_lock =3D ffs_lock, > + ._vop_lock =3D ffs_lock, > .vop_read =3D ffs_read, [...] > .vop_fsync =3D ffs_fsync, > - .vop_lock =3D ffs_lock, > + ._vop_lock =3D ffs_lock, > .vop_reallocblks =3D ffs_reallocblks, Kip... This is so ugly... All the rest of vops don'y have this _ prefix. There is really no other way to implement it? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gr/z0/N6AeWAPJVB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFWI+VForvXbEpPzQRAhYpAJsEZh9gB6uhF6Dr9iviOCKbStj5zgCfVerh DBunR/N1qwadV8yyuSy6sSI= =AAuR -----END PGP SIGNATURE----- --gr/z0/N6AeWAPJVB-- From owner-cvs-src@FreeBSD.ORG Mon Nov 13 16:25:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3CFA16A501; Mon, 13 Nov 2006 16:25:37 +0000 (UTC) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D69543D60; Mon, 13 Nov 2006 16:25:29 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADGPEEt029934; Mon, 13 Nov 2006 16:25:14 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADGPEvN029933; Mon, 13 Nov 2006 16:25:14 GMT (envelope-from dwmalone) Message-Id: <200611131625.kADGPEvN029933@repoman.freebsd.org> From: David Malone Date: Mon, 13 Nov 2006 16:25:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/traceroute traceroute.8 traceroute.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 16:25:38 -0000 dwmalone 2006-11-13 16:25:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/traceroute traceroute.8 traceroute.c Log: Sync with -current: 1) Add -D flag to print diff of probe packet and ICMP quotation. 2) Make synopsis match usage better. Approved by: re Revision Changes Path 1.11.2.2 +19 -3 src/contrib/traceroute/traceroute.8 1.26.8.4 +55 -5 src/contrib/traceroute/traceroute.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 16:50:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0632916A4AB; Mon, 13 Nov 2006 16:50:19 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4E8E43D46; Mon, 13 Nov 2006 16:50:18 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADGoIV7042538; Mon, 13 Nov 2006 16:50:18 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADGoIBM042537; Mon, 13 Nov 2006 16:50:18 GMT (envelope-from kientzle) Message-Id: <200611131650.kADGoIBM042537@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 13 Nov 2006 16:50:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_read_support_format_tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 16:50:19 -0000 kientzle 2006-11-13 16:50:18 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_tar.c Log: No change in functionality, but fill in a missing error message when reading a truncated tar archive. Revision Changes Path 1.45 +6 -1 src/lib/libarchive/archive_read_support_format_tar.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 17:27:46 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADE9916A4D0; Mon, 13 Nov 2006 17:27:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18B6443DFD; Mon, 13 Nov 2006 17:19:00 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kADHHV05097604; Mon, 13 Nov 2006 10:17:33 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 13 Nov 2006 10:18:08 -0700 (MST) Message-Id: <20061113.101808.-1540392146.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061113173927.Q75708@delplex.bde.org> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 13 Nov 2006 10:17:33 -0700 (MST) Cc: jkoshy@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 17:27:46 -0000 In message: <20061113173927.Q75708@delplex.bde.org> Bruce Evans writes: : In , all struct members are char arrays so there will be no : padding in practice. Actually, that isn't the case at all. There are many systems that pad/align structs to 4 byte boundaries regardless. NetBSD has many of these places tagged with __packed since they run on more architectures than they can hand tweek for. : Most system headers depend on the padding being : the same for all compilers, even when the struct member types are very : varied. Many system headers use explicit manual padding to try to : give a fixed layout. This works in practice, and the not-unused file : system ffs and the not-unused networking component netinet depend on : it working. Most file systems probably depend on it working across : OS's for very varied struct types. One exception is msdosfs -- since : msdosfs's disk data structures are poorly laid out even for an 8-bit : system, they are almost perfectly misaligned even for a 16-bit system, : so manual packing is not practical, and msdosfs declares most of the : structures as byte arrays in much the same way as . It doesn't : go as far as using a single array of bytes with fake struct members : defined via offsets into the array, as might be required to be portable : in theory. "almost" "in theory". These are nice words, but don't match reality. On the arm, the __packed is absolutely required to not only compile, but produce correct code. : netinet uses __packed a bit, but this just gives unportability and : pessimizations in practice. E.g., struct ip is manually packed and : has a natural 4-byte alignment requirement, but declaring it as __packed : reduces its alignment requirement to 1 byte; thus in internal structs : like "struct x { int16_t x_foo; struct ip x_ip; };", the x_ip is : normally misaligned on a 16-bit boundary and thus: struct ip should be packed. It is the wire format of a data structure, and the compiler is free to add extra padding that you don't think is necessary. : - the layout of the internal struct is unportable in practice instead of : unportable in theory : - compilers for arches with strict alignment requirements have to : generate extra instructions to access the 32-bit members in struct : ip (just 2 in_addr_t's), so the accesses are pessimized and not : atomic. gcc on i64's seems to do this correctly. The pessimization : is by a factor of 14 according to the instruction count (a single : 32-bit load instruction for an in_addr_t gets replaced by 4 8-bit : load instructions and 10 more instructions to combine the bytes). : - code like "struct x *xp; ... foo(&xp->x_ip.ip_src);" is broken on : on arches with strict alignment requirements. After the address of : the in_addr_t is passed to another function, the compiler can no : longer easiliy see that it has to generate pessimal loads for accesses : to the in_addr_t. A variant of this bug occurred in practice in : rev.1.18 of . There, almost eveything is naturally : aligned to a 16-bit boundary, and __packed is misused to give 8-bitr : alignment as a bad side effect. Rev.1.18 added a 32-bit member in : one of the structs contained in the __packed struct. This should : have just broken binary compatibility and might not have mattered : depending on how internal the __packed struct is. Instead, it gave : misaligned 32-bit values instide the __packed struct, thus defeating : the reason for existence of rev.1.18, since the reason was to add a : union hack to allow accessing "char c_net[4];" as "u_int u_net;", but : union hacks like this depend on not using __packed in any struct : containing c/u_net (recursively). There's no guarantee that struct ip is 4 byte aligned from the drivers. In fact, there are several that require the packet to start on a 4 byte boundary and lack scatter gather, thus guaranteeing that struct ip is not 4 byte aligned. This works well for almost all the code in the tree (the one that it doesn't work for is in the nfs root code somewhere). : gcc -Wpacked can be used to find bugs like this. See gcc.info for more : details. Passing the address of a non-char member in a packed struct : should be an error, but gcc doesn't seem to diagnose this. Agreed. : was broken by adding __packed in the same commit that : removed an unportable bitfield from it. The bitfield was the actual : problem. Bitfields should never be used in structs that have to match : an externally imposed layouts since they are unportable in practice. : gcc's bitfields are especially unportable. E.g. "int:8" gives the : same alignment requirement as int, and this is undocumented. In gcc, : you have to use "char:8" or __packed to get 8-bit alignment of structs : containing bitfields, but these are constraint and syntax errors in : C. : : Using __packed in isn't as bad as in since struct : ar has a natural 1-byte alignment requirement so using __packed is a : no-op in practice. Except on the arm, where it is critically required for the generated code to be correct. Warner From owner-cvs-src@FreeBSD.ORG Mon Nov 13 17:27:49 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5434516A47B; Mon, 13 Nov 2006 17:27:49 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7835843F3C; Mon, 13 Nov 2006 17:19:17 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kADHIB0k097607; Mon, 13 Nov 2006 10:18:12 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 13 Nov 2006 10:18:48 -0700 (MST) Message-Id: <20061113.101848.-1558770561.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <3801.1163410519@critter.freebsd.dk> References: <20061113173927.Q75708@delplex.bde.org> <3801.1163410519@critter.freebsd.dk> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 13 Nov 2006 10:18:12 -0700 (MST) Cc: jkoshy@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, bde@zeta.org.au, cvs-src@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 17:27:49 -0000 In message: <3801.1163410519@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20061113173927.Q75708@delplex.bde.org>, Bruce Evans writes: : >On Mon, 13 Nov 2006, Joseph Koshy wrote: : > : >> jkoshy 2006-11-13 04:28:29 UTC : >> : >> FreeBSD src repository : >> : >> Modified files: : >> include ar.h : >> Log: : >> Attempt to improve application portability by marking `struct ar_hdr' : >> as `packed'. : >> : >> The C standard leaves the alignment of individual members of a C : >> struct upto the implementation, so pedantically speaking portable : >> code cannot assume that the layout of a `struct ar_hdr' in memory : >> will match its layout in a file. Using a __packed attribute : >> declaration forces file and memory layouts for this structure to : >> match. : >> : >> Submitted by: ru : > : >I don't see how this can be more portable. : : I agree with bruce that __packed is not the way to go. : : For things that represent communication protocols, even if : they happen through files, I advocate using the functions : in sys/endian.h to explicitly decode and encode fields into : bytestrings. Until that happens, __packed is the only way to get correct code on the arm. Warner From owner-cvs-src@FreeBSD.ORG Mon Nov 13 17:31:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F93416A523; Mon, 13 Nov 2006 17:31:23 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48DEE43EA2; Mon, 13 Nov 2006 17:22:22 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kADHJLTK097632; Mon, 13 Nov 2006 10:19:21 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 13 Nov 2006 10:19:58 -0700 (MST) Message-Id: <20061113.101958.-861030824.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061113214928.P76443@delplex.bde.org> References: <3801.1163410519@critter.freebsd.dk> <20061113214928.P76443@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 13 Nov 2006 10:19:21 -0700 (MST) Cc: jkoshy@FreeBSD.ORG, phk@phk.freebsd.dk, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 17:31:23 -0000 In message: <20061113214928.P76443@delplex.bde.org> Bruce Evans writes: : On Mon, 13 Nov 2006, Poul-Henning Kamp wrote: : : > In message <20061113173927.Q75708@delplex.bde.org>, Bruce Evans writes: : >> On Mon, 13 Nov 2006, Joseph Koshy wrote: : >> : >>> jkoshy 2006-11-13 04:28:29 UTC : >>> : >>> FreeBSD src repository : >>> : >>> Modified files: : >>> include ar.h : >>> Log: : >>> Attempt to improve application portability by marking `struct ar_hdr' : >>> as `packed'. : >>> ... : > : > I agree with bruce that __packed is not the way to go. : > : > For things that represent communication protocols, even if : > they happen through files, I advocate using the functions : > in sys/endian.h to explicitly decode and encode fields into : > bytestrings. : : But already uses byte strings for everything. It just requires : no padding between the byte strings (so that the offsets are constant), : and no padding at the end (so that offsets are constant if the struct : is contained in another struct that is at least as careful about padding : an aligment). : : BTW, you are responsible for the __packed in . Please remove : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. : The only danger is if something has grown to depend on __packed reducing : alignment as a side effect. E.g., suppose we had a byte string containing : a bytewise copy of a struct ip. If the copy might be misaligned, then it : should be copied to an actual struct ip before accessing it as a struct, : but code that accesses it directly using ((struct ip *)&bs[N]) would work : now due to the reduced alignment. Places that really need __packed should : probably use __aligned() to restore the natural alignment. DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. If you want to remove it, then you must make sure arm works right after it because I'll add it back. Warner From owner-cvs-src@FreeBSD.ORG Mon Nov 13 17:33:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF6F216A407; Mon, 13 Nov 2006 17:33:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B478944161; Mon, 13 Nov 2006 17:24:59 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADHOO6S049708; Mon, 13 Nov 2006 17:24:24 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADHOOrV049703; Mon, 13 Nov 2006 17:24:24 GMT (envelope-from marius) Message-Id: <200611131724.kADHOOrV049703@repoman.freebsd.org> From: Marius Strobl Date: Mon, 13 Nov 2006 17:24:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/pci if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 17:33:18 -0000 marius 2006-11-13 17:24:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_dc.c if_dcreg.h Log: MFC: sys/dev/dc/if_dc.c 1.185, 1.186 (partial); sys/dev/dc/if_dcreg.h 1.52 - Consistently use if_printf() only in interface methods: if_start(), if_watchdog, etc., or in functions used only in these methods. In all other functions in the driver use device_printf(). - Use __func__ instead of typing function name. - Wrap code optimized for architectures without alignment constraints in #ifdef __NO_STRICT_ALIGNMENT rather than #ifdef __i386__. This means that amd64 now also uses the optimized code. While at it, fix a nearby style(9) bug. - In dc_setcfg() suppress printing a warning when forcing the receiver and transceiver to idle state times out for chips where the status bits in question just never change (observed in detail with DM9102A) and therefore the warning would be highly likely false positive. - In dc_ifmedia_sts() add a missing DC_UNLOCK(). Approved by: re (kensmith) Revision Changes Path 1.160.2.12 +28 -16 src/sys/pci/if_dc.c 1.44.2.5 +1 -0 src/sys/pci/if_dcreg.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 17:42:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D830716A5E3 for ; Mon, 13 Nov 2006 17:42:01 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73AEC43DCF for ; Mon, 13 Nov 2006 17:37:34 +0000 (GMT) (envelope-from kip.macy@gmail.com) Received: by nf-out-0910.google.com with SMTP id l23so530190nfc for ; Mon, 13 Nov 2006 09:37:03 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MxOW/AuV2WDwhz9A3LhJAsuyCYQ844cVb+jX64l3zYH3V6R/qAzZH1aWWLPMNi6/81kNQMpZvrIkvUAZWini1+/iYkCddwn+QZFtnHwc1ZXWZ2+UQ5yjaQ3MdMsdcN+Md4AS8cpfsHU8mNBmG10BwwZeRUX4ACk/VwoYEiQ4QGc= Received: by 10.82.136.4 with SMTP id j4mr84418bud.1163439422809; Mon, 13 Nov 2006 09:37:02 -0800 (PST) Received: by 10.82.191.20 with HTTP; Mon, 13 Nov 2006 09:37:02 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2006 09:37:02 -0800 From: "Kip Macy" To: "Pawel Jakub Dawidek" , "Kip Macy" , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org In-Reply-To: <20061113153029.GC25940@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611130551.kAD5pNIP001371@repoman.freebsd.org> <20061113153029.GC25940@garage.freebsd.pl> Cc: Subject: Re: cvs commit: src/sys/coda coda_vnops.c coda_vnops.h src/sys/fs/nullfs null_vnops.c src/sys/kern vfs_default.c vfs_subr.c vfs_vnops.c vnode_if.src src/sys/sys vnode.h src/sys/ufs/ffs ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 17:42:02 -0000 We can call it something else, but fundamentally it has to be wrapped by a macro - this is the convention for locks. You can change it to vop_lock_internal if you like. I On 11/13/06, Pawel Jakub Dawidek wrote: > On Mon, Nov 13, 2006 at 05:51:22AM +0000, Kip Macy wrote: > > kmacy 2006-11-13 05:51:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/coda coda_vnops.c coda_vnops.h > > sys/fs/nullfs null_vnops.c > > sys/kern vfs_default.c vfs_subr.c vfs_vnops.c > > vnode_if.src > > sys/sys vnode.h > > sys/ufs/ffs ffs_vnops.c > > Log: > > change vop_lock handling to allowing tracking of callers' file and line > for > > acquisition of lockmgr locks > [...] > > --- src/sys/coda/coda_vnops.c 2006/02/01 00:25:24 1.68 > > +++ src/sys/coda/coda_vnops.c 2006/11/13 05:51:21 1.69 > [...] > > .vop_reclaim = coda_reclaim, /* reclaim */ > > - .vop_lock = coda_lock, /* lock */ > > + ._vop_lock = coda_lock, /* lock */ > > .vop_unlock = coda_unlock, /* unlock */ > [...] > > --- src/sys/fs/nullfs/null_vnops.c 2006/03/12 04:58:18 1.91 > > +++ src/sys/fs/nullfs/null_vnops.c 2006/11/13 05:51:21 1.92 > [...] > > .vop_islocked = null_islocked, > > - .vop_lock = null_lock, > > + ._vop_lock = null_lock, > > .vop_lookup = null_lookup, > [...] > > --- src/sys/kern/vfs_default.c 2006/09/20 00:27:02 1.134 > > +++ src/sys/kern/vfs_default.c 2006/11/13 05:51:22 1.135 > [...] > > .vop_lease = VOP_NULL, > > - .vop_lock = vop_stdlock, > > + ._vop_lock = vop_stdlock, > > .vop_lookup = vop_nolookup, > [...] > > --- src/sys/kern/vfs_subr.c 2006/11/07 19:45:05 1.691 > > +++ src/sys/kern/vfs_subr.c 2006/11/13 05:51:22 1.692 > [...] > > .vop_reclaim = sync_reclaim, /* reclaim */ > > - .vop_lock = vop_stdlock, /* lock */ > > + ._vop_lock = vop_stdlock, /* lock */ > > .vop_unlock = vop_stdunlock, /* unlock */ > > --- src/sys/ufs/ffs/ffs_vnops.c 2006/11/06 13:42:09 1.162 > > +++ src/sys/ufs/ffs/ffs_vnops.c 2006/11/13 05:51:22 1.163 > [...] > > .vop_getpages = ffs_getpages, > > - .vop_lock = ffs_lock, > > + ._vop_lock = ffs_lock, > > .vop_read = ffs_read, > [...] > > .vop_getpages = ffs_getpages, > > - .vop_lock = ffs_lock, > > + ._vop_lock = ffs_lock, > > .vop_read = ffs_read, > [...] > > .vop_fsync = ffs_fsync, > > - .vop_lock = ffs_lock, > > + ._vop_lock = ffs_lock, > > .vop_reallocblks = ffs_reallocblks, > > Kip... This is so ugly... All the rest of vops don'y have this _ prefix. > There is really no other way to implement it? > > -- > Pawel Jakub Dawidek http://www.wheel.pl > pjd@FreeBSD.org http://www.FreeBSD.org > FreeBSD committer Am I Evil? Yes, I Am! > > From owner-cvs-src@FreeBSD.ORG Mon Nov 13 19:06:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0B8316A49E; Mon, 13 Nov 2006 19:06:04 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (ns1.pittgoth.com [216.38.206.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0D7A43E32; Mon, 13 Nov 2006 19:04:24 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (ip70-177-190-239.dc.dc.cox.net [70.177.190.239]) (authenticated bits=0) by pittgoth.com (8.13.6/8.13.6) with ESMTP id kADJ3pV0018830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 13 Nov 2006 14:03:52 -0500 (EST) (envelope-from trhodes@FreeBSD.org) Date: Mon, 13 Nov 2006 14:03:49 -0500 From: Tom Rhodes To: "M. Warner Losh" Message-Id: <20061113140349.0acfd25b.trhodes@FreeBSD.org> In-Reply-To: <20061113.101808.-1540392146.imp@bsdimp.com> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113.101808.-1540392146.imp@bsdimp.com> Organization: The FreeBSD Project X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jkoshy@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, bde@zeta.org.au, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 19:06:05 -0000 On Mon, 13 Nov 2006 10:18:08 -0700 (MST) "M. Warner Losh" wrote: > In message: <20061113173927.Q75708@delplex.bde.org> > Bruce Evans writes: > : In , all struct members are char arrays so there will be no > : padding in practice. > > Actually, that isn't the case at all. There are many systems that > pad/align structs to 4 byte boundaries regardless. NetBSD has many of > these places tagged with __packed since they run on more architectures > than they can hand tweek for. > > : Most system headers depend on the padding being > : the same for all compilers, even when the struct member types are very > : varied. Many system headers use explicit manual padding to try to > : give a fixed layout. This works in practice, and the not-unused file > : system ffs and the not-unused networking component netinet depend on > : it working. Most file systems probably depend on it working across > : OS's for very varied struct types. One exception is msdosfs -- since > : msdosfs's disk data structures are poorly laid out even for an 8-bit > : system, they are almost perfectly misaligned even for a 16-bit system, > : so manual packing is not practical, and msdosfs declares most of the > : structures as byte arrays in much the same way as . It doesn't > : go as far as using a single array of bytes with fake struct members > : defined via offsets into the array, as might be required to be portable > : in theory. > > "almost" "in theory". These are nice words, but don't match reality. I think this is a fortune candidate. You are so quotesfiled Mr. Warner. ;) > On the arm, the __packed is absolutely required to not only compile, > but produce correct code. > This is a hardware thing correct? Admittedly so, I have no clue about ARM. -- Tom Rhodes From owner-cvs-src@FreeBSD.ORG Mon Nov 13 19:09:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD08C16A40F; Mon, 13 Nov 2006 19:09:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4FB943DA1; Mon, 13 Nov 2006 19:07:42 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADJ7XTB068492; Mon, 13 Nov 2006 19:07:33 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADJ7XSX068491; Mon, 13 Nov 2006 19:07:33 GMT (envelope-from bz) Message-Id: <200611131907.kADJ7XSX068491@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Mon, 13 Nov 2006 19:07:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 19:09:09 -0000 bz 2006-11-13 19:07:33 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Add SCTP as a known upper layer protocol over v6. We are not yet aware of the protocol internals but this way SCTP traffic over v6 will not be discarded. Reported by: Peter Lei via rrs Tested by: Peter Lei Revision Changes Path 1.154 +8 -0 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 19:15:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39B2216A4C8; Mon, 13 Nov 2006 19:15:49 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75C6743D79; Mon, 13 Nov 2006 19:13:47 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADJDdxI069885; Mon, 13 Nov 2006 19:13:39 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADJDdKR069884; Mon, 13 Nov 2006 19:13:39 GMT (envelope-from bmah) Message-Id: <200611131913.kADJDdKR069884@repoman.freebsd.org> From: "Bruce A. Mah" Date: Mon, 13 Nov 2006 19:13:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 19:15:49 -0000 bmah 2006-11-13 19:13:39 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: New release note: traceroute(8) -D (+MFC). Revision Changes Path 1.988 +5 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 19:17:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B610216A4B3; Mon, 13 Nov 2006 19:17:08 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3D6143DEF; Mon, 13 Nov 2006 19:15:46 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id E30621B66F8; Tue, 14 Nov 2006 06:15:44 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 6D85A8C05; Tue, 14 Nov 2006 06:15:43 +1100 (EST) Date: Tue, 14 Nov 2006 06:15:37 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20061113.101808.-1540392146.imp@bsdimp.com> Message-ID: <20061114050457.M77914@delplex.bde.org> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113.101808.-1540392146.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: jkoshy@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 19:17:09 -0000 On Mon, 13 Nov 2006, M. Warner Losh wrote: > In message: <20061113173927.Q75708@delplex.bde.org> > Bruce Evans writes: > : In , all struct members are char arrays so there will be no > : padding in practice. > > Actually, that isn't the case at all. There are many systems that > pad/align structs to 4 byte boundaries regardless. Only 1 broken one has turned up so far. Even it only pads at the end. > NetBSD has many of > these places tagged with __packed since they run on more architectures > than they can hand tweek for. This moves further from actually fixing the problem. > : Most system headers depend on the padding being > : the same for all compilers, even when the struct member types are very > : varied. Many system headers use explicit manual padding to try to > : give a fixed layout. This works in practice, and the not-unused file > : system ffs and the not-unused networking component netinet depend on > : it working. Most file systems probably depend on it working across > : ... > > "almost" "in theory". These are nice words, but don't match reality. > On the arm, the __packed is absolutely required to not only compile, > but produce correct code. I haven't seen any examples where it is more than a hack to make broken code compile. An unpacked struct ar is perfectly portable, but might not match the layout in the file. The broken code that started the thread in -current uses an invalid cast to convert &byte_array[offset] into a "struct ar *". This bug was detected accidentally because the ARM's struct ar has stricter alignment requirements than char. Non- broken code knows that byte-aligned data needs to be copied into structs using memcpy(). E.g., in ping/ping.c there are several such copies for things like network addresses and timevals. It would be very wrong to declare struct timeval as __packed, although it needs to be packed to work. Declaring it as both __packed and __aligned(max(sizeof(time_t), sizeof(long)) might work, but is too ugly for me. Strictly, all structs used in ABIs would have to be declared like this (after adding explicit padding where needed, and lots of ifdefs for the padding as in ) to prevent them depending on the compiler of the day. > : netinet uses __packed a bit, but this just gives unportability and > : pessimizations in practice. E.g., struct ip is manually packed and > : has a natural 4-byte alignment requirement, but declaring it as __packed > : reduces its alignment requirement to 1 byte; thus in internal structs > : like "struct x { int16_t x_foo; struct ip x_ip; };", the x_ip is > : normally misaligned on a 16-bit boundary and thus: > > struct ip should be packed. It is the wire format of a data > structure, and the compiler is free to add extra padding that you > don't think is necessary. It needs to be packed when sent to the wire, but not necessarily in memory. The copy in memory certainly shouldn't be just __packed, since __packed breaks its alignment. As above, declaring it as __packed and __aligned(4) might work, but is too ugly for me. > : - the layout of the internal struct is unportable in practice instead of > : unportable in theory > : - compilers for arches with strict alignment requirements have to > : generate extra instructions to access the 32-bit members in struct > : ip (just 2 in_addr_t's), so the accesses are pessimized and not > : atomic. gcc on i64's seems to do this correctly. The pessimization > : is by a factor of 14 according to the instruction count (a single > : 32-bit load instruction for an in_addr_t gets replaced by 4 8-bit > : load instructions and 10 more instructions to combine the bytes). > : - code like "struct x *xp; ... foo(&xp->x_ip.ip_src);" is broken on > : on arches with strict alignment requirements. After the address of > : the in_addr_t is passed to another function, the compiler can no > : longer easiliy see that it has to generate pessimal loads for accesses > : to the in_addr_t. A variant of this bug occurred in practice in > : rev.1.18 of . There, almost eveything is naturally > : aligned to a 16-bit boundary, and __packed is misused to give 8-bitr > : alignment as a bad side effect. Rev.1.18 added a 32-bit member in > : one of the structs contained in the __packed struct. This should > : have just broken binary compatibility and might not have mattered > : depending on how internal the __packed struct is. Instead, it gave > : misaligned 32-bit values instide the __packed struct, thus defeating > : the reason for existence of rev.1.18, since the reason was to add a > : union hack to allow accessing "char c_net[4];" as "u_int u_net;", but > : union hacks like this depend on not using __packed in any struct > : containing c/u_net (recursively). > > There's no guarantee that struct ip is 4 byte aligned from the > drivers. In fact, there are several that require the packet to start > on a 4 byte boundary and lack scatter gather, thus guaranteeing that > struct ip is not 4 byte aligned. This works well for almost all the > code in the tree (the one that it doesn't work for is in the nfs root > code somewhere). Yes there is. It contains some uint32_t's (in_addr_t's), so it is guaranteed to be 4-byte aligned if it is actually a struct. Declaring it as __packed without declaring it as __aligned(4) makes it a non-struct (sort of). Drivers need to copy it to and from the wire so that code all over the network stack isn't pessimized by misaligned accesses or extra instructions to avoid misaligned accesses. I think some drivers do this. It isn't declared as _packed in RELENG_4, so most drivers probably get this right. RELENG_4 has alpha so the alignment is not completely untested in it. > : was broken by adding __packed in the same commit that > : removed an unportable bitfield from it. The bitfield was the actual > : problem. Bitfields should never be used in structs that have to match > : an externally imposed layouts since they are unportable in practice. > : gcc's bitfields are especially unportable. E.g. "int:8" gives the > : same alignment requirement as int, and this is undocumented. In gcc, > : you have to use "char:8" or __packed to get 8-bit alignment of structs > : containing bitfields, but these are constraint and syntax errors in > : C. > : > : Using __packed in isn't as bad as in since struct > : ar has a natural 1-byte alignment requirement so using __packed is a > : no-op in practice. > > Except on the arm, where it is critically required for the generated > code to be correct. I doubt that it is needed for more than breaking the warning. You would have to be unlucky or shooting your feet for "(struct ar *)&byte_array[offset]" to give a pointer that is actually misaligned. Large arrays of chars are normally aligned to the word size even if they are on the stack, and the archive header is at offset 0 in files. Bruce From owner-cvs-src@FreeBSD.ORG Mon Nov 13 20:13:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23E1416A417; Mon, 13 Nov 2006 20:13:01 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F63844072; Mon, 13 Nov 2006 20:05:14 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 0F7CA1FFD38; Mon, 13 Nov 2006 21:05:12 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 428B51FFD71; Mon, 13 Nov 2006 21:05:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id EB7DF444889; Mon, 13 Nov 2006 20:02:29 +0000 (UTC) Date: Mon, 13 Nov 2006 20:02:29 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200611131907.kADJ7XSX068491@repoman.freebsd.org> Message-ID: <20061113195449.O54329@maildrop.int.zabbadoz.net> References: <200611131907.kADJ7XSX068491@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 20:13:01 -0000 On Mon, 13 Nov 2006, Bjoern A. Zeeb wrote: > bz 2006-11-13 19:07:33 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_fw2.c > Log: > Add SCTP as a known upper layer protocol over v6. There is another 'problem' the way things work at the moment. We have over 100 IPPROTO_* defined in in.h. We really do not want to permit any single one and add it to the switch in ip_fw2.c/ipfw_chk. Basically at that point we can have: 1 extension headers (we need to know about them to get to 2 or 3) 2 upper layer protocols we know about and want to do/allow more specific filtering (like tcp/udp/..) 3 upper layer protocols ipfw doesn't know about In case anyone has a good idea what to do with everything in cat 3 feel free to discuss/commit it;) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT From owner-cvs-src@FreeBSD.ORG Mon Nov 13 20:21:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 710CC16A4EF; Mon, 13 Nov 2006 20:21:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AF4A43E68; Mon, 13 Nov 2006 20:15:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kADKD7sM000142; Mon, 13 Nov 2006 13:13:07 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 13 Nov 2006 13:13:42 -0700 (MST) Message-Id: <20061113.131342.-1540392691.imp@bsdimp.com> To: trhodes@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20061113140349.0acfd25b.trhodes@FreeBSD.org> References: <20061113173927.Q75708@delplex.bde.org> <20061113.101808.-1540392146.imp@bsdimp.com> <20061113140349.0acfd25b.trhodes@FreeBSD.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 13 Nov 2006 13:13:09 -0700 (MST) Cc: jkoshy@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, bde@zeta.org.au, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 20:21:57 -0000 In message: <20061113140349.0acfd25b.trhodes@FreeBSD.org> Tom Rhodes writes: : > On the arm, the __packed is absolutely required to not only compile, : > but produce correct code. : : This is a hardware thing correct? Admittedly so, I have no clue : about ARM. Given the current ABI that we implement, yes. The ABI we implement is influenced by what is optimal for the ARM architecture. There's a newer ABI called EABI, iirc, that makes things look slightly more i386ish so that more software will run. Warner From owner-cvs-src@FreeBSD.ORG Mon Nov 13 20:40:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10C1A16A527; Mon, 13 Nov 2006 20:40:44 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6044843D8C; Mon, 13 Nov 2006 20:31:52 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADKVWg9083045; Mon, 13 Nov 2006 20:31:32 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADKVWL3083044; Mon, 13 Nov 2006 20:31:32 GMT (envelope-from bmah) Message-Id: <200611132031.kADKVWL3083044@repoman.freebsd.org> From: "Bruce A. Mah" Date: Mon, 13 Nov 2006 20:31:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 20:40:44 -0000 bmah 2006-11-13 20:31:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: traceroute(8) -D. Approved by: re (implicitly) Revision Changes Path 1.883.2.52 +5 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Nov 13 20:43:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2521E16A4D0; Mon, 13 Nov 2006 20:43:25 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3CDB44098; Mon, 13 Nov 2006 20:35:18 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADKXsJ6083714; Mon, 13 Nov 2006 20:33:54 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADKXsGC083713; Mon, 13 Nov 2006 20:33:54 GMT (envelope-from ru) Message-Id: <200611132033.kADKXsGC083713@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 13 Nov 2006 20:33:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include pmap.h src/sys/amd64/include pmap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 20:43:25 -0000 ru 2006-11-13 20:33:54 UTC FreeBSD src repository Modified files: sys/i386/include pmap.h sys/amd64/include pmap.h Log: Fix NKPT comments to match reality. Note that the current value of NKPT is no longer enough to run amd64 with 16G of RAM, as it doesn't have space for mapping a kernel (16M kernel would require additionally 8 page tables). Revision Changes Path 1.136 +3 -2 src/sys/amd64/include/pmap.h 1.124 +6 -3 src/sys/i386/include/pmap.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 21:44:46 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AE3B16A65A; Mon, 13 Nov 2006 21:44:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCC1D43F77; Mon, 13 Nov 2006 21:40:49 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADLEsDY099241; Mon, 13 Nov 2006 21:14:54 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADLEs07099240; Mon, 13 Nov 2006 21:14:54 GMT (envelope-from jhb) Message-Id: <200611132114.kADLEs07099240@repoman.freebsd.org> From: John Baldwin Date: Mon, 13 Nov 2006 21:14:54 +0000 (UTC) To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 db_disasm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 21:44:46 -0000 jhb 2006-11-13 21:14:54 UTC FreeBSD src repository Modified files: sys/amd64/amd64 db_disasm.c Log: Various fixes: - Remove an extra entry from the array for 0x0f prefixed instruction groups. This fixes decoding of instructions where the second opcode >= 0x80. - Add support for the 64-bit immediate mov instructions. - When short_addr is enabled, don't parse the modr/m byte for a 16-bit address, but as a 32-bit address. - Support %rip relative addressing. - Don't print a displacement of 0 if there is a base or index register. MFC after: 3 days Revision Changes Path 1.31 +60 -82 src/sys/amd64/amd64/db_disasm.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 21:48:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F1D616A501; Mon, 13 Nov 2006 21:48:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D519A43D6E; Mon, 13 Nov 2006 21:47:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADLlVs9006577; Mon, 13 Nov 2006 21:47:31 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADLlVok006575; Mon, 13 Nov 2006 21:47:31 GMT (envelope-from jhb) Message-Id: <200611132147.kADLlVok006575@repoman.freebsd.org> From: John Baldwin Date: Mon, 13 Nov 2006 21:47:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m pcib_private.h pcireg.h pcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 21:48:50 -0000 jhb 2006-11-13 21:47:30 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m pcib_private.h pcireg.h pcivar.h Log: First cut at MI support for PCI Message Signalled Interrupts (MSI): - Add 3 new functions to the pci_if interface along with suitable wrappers to provide the device driver visible API: - pci_alloc_msi(dev, int *count) backed by PCI_ALLOC_MSI(). '*count' here is an in and out parameter. The driver stores the desired number of messages in '*count' before calling the function. On success, '*count' holds the number of messages allocated to the device. Also on success, the driver can access the messages as SYS_RES_IRQ resources starting at rid 1. Note that the legacy INTx interrupt resource will not be available when using MSI. Note that this function will allocate either MSI or MSI-X messages depending on the devices capabilities and the 'hw.pci.enable_msix' and 'hw.pci.enable_msi' tunables. Also note that the driver should activate the memory resource that holds the MSI-X table and pending bit array (PBA) before calling this function if the device supports MSI-X. - pci_release_msi(dev) backed by PCI_RELEASE_MSI(). This function releases the messages allocated for this device. All of the SYS_RES_IRQ resources need to be released for this function to succeed. - pci_msi_count(dev) backed by PCI_MSI_COUNT(). This function returns the maximum number of MSI or MSI-X messages supported by this device. MSI-X is preferred if present, but this function will honor the 'hw.pci.enable_msix' and 'hw.pci.enable_msi' tunables. This function should return the largest value that pci_alloc_msi() can return (assuming the MD code is able to allocate sufficient backing resources for all of the messages). - Add default implementations for these 3 methods to the pci_driver generic PCI bus driver. (The various other PCI bus drivers such as for ACPI and OFW will inherit these default implementations.) This default implementation depends on 4 new pcib_if methods that bubble up through the PCI bridges to the MD code to allocate IRQ values and perform any needed MD setup code needed: - PCIB_ALLOC_MSI() attempts to allocate a group of MSI messages. - PCIB_RELEASE_MSI() releases a group of MSI messages. - PCIB_ALLOC_MSIX() attempts to allocate a single MSI-X message. - PCIB_RELEASE_MSIX() releases a single MSI-X message. - Add default implementations for these 4 methods that just pass the request up to the parent bus's parent bridge driver and use the default implementation in the various MI PCI bridge drivers. - Add MI functions for use by MD code when managing MSI and MSI-X interrupts: - pci_enable_msi(dev, address, data) programs the MSI capability address and data registers for a group of MSI messages - pci_enable_msix(dev, index, address, data) initializes a single MSI-X message in the MSI-X table - pci_mask_msix(dev, index) masks a single MSI-X message - pci_unmask_msix(dev, index) unmasks a single MSI-X message - pci_pending_msix(dev, index) returns true if the specified MSI-X message is currently pending - Save the MSI capability address and data registers in the pci_cfgreg block in a PCI devices ivars and restore the values when a device is resumed. Note that the MSI-X table is not currently restored during resume. - Add constants for MSI-X register offsets and fields. - Record interesting data about any MSI-X capability blocks we come across in the pci_cfgreg block in the ivars for PCI devices. Tested on: em (i386, MSI), bce (amd64/i386, MSI), mpt (amd64, MSI-X) Reviewed by: scottl, grehan, jfv MFC after: 2 months Revision Changes Path 1.51 +4 -0 src/sys/dev/acpica/acpi_pcib_acpi.c 1.15 +4 -0 src/sys/dev/acpica/acpi_pcib_pci.c 1.322 +421 -7 src/sys/dev/pci/pci.c 1.10 +25 -0 src/sys/dev/pci/pci_if.m 1.44 +45 -0 src/sys/dev/pci/pci_pci.c 1.20 +3 -0 src/sys/dev/pci/pci_private.h 1.9 +45 -0 src/sys/dev/pci/pcib_if.m 1.8 +4 -0 src/sys/dev/pci/pcib_private.h 1.53 +16 -0 src/sys/dev/pci/pcireg.h 1.73 +46 -1 src/sys/dev/pci/pcivar.h From owner-cvs-src@FreeBSD.ORG Mon Nov 13 22:16:02 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3B2A16A47C; Mon, 13 Nov 2006 22:16:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF25843E08; Mon, 13 Nov 2006 22:14:18 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kADME9Mu016323; Mon, 13 Nov 2006 17:14:10 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Mon, 13 Nov 2006 16:53:23 -0500 User-Agent: KMail/1.9.1 References: <200611132147.kADLlVok006575@repoman.freebsd.org> In-Reply-To: <200611132147.kADLlVok006575@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611131653.24403.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 13 Nov 2006 17:14:10 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2191/Mon Nov 13 13:37:53 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m pcib_private.h pcireg.h pcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 22:16:02 -0000 On Monday 13 November 2006 16:47, John Baldwin wrote: > jhb 2006-11-13 21:47:30 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c > sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h > pcib_if.m pcib_private.h pcireg.h > pcivar.h > Log: > First cut at MI support for PCI Message Signalled Interrupts (MSI): > - Add 3 new functions to the pci_if interface along with suitable wrappers > to provide the device driver visible API: The patches I used for em, bce, and mpt are available at http://www.freebsd.org/~jhb/patches/msi_dev.patch For devices that only support 1 message, the only change is to call pci_alloc_msi() and then use rid 1 instead of rid 0 for SYS_RES_IRQ. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Nov 13 22:24:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA23016A55F; Mon, 13 Nov 2006 22:24:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9372043DE9; Mon, 13 Nov 2006 22:23:34 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kADMNYjZ017935; Mon, 13 Nov 2006 22:23:34 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kADMNYk0017934; Mon, 13 Nov 2006 22:23:34 GMT (envelope-from jhb) Message-Id: <200611132223.kADMNYk0017934@repoman.freebsd.org> From: John Baldwin Date: Mon, 13 Nov 2006 22:23:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 local_apic.c mptable_pci.c msi.c nexus.c src/sys/amd64/include apicvar.h intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/conf files.amd64 files.i386 src/sys/i386/i386 local_apic.c mptable_pci.c msi.c nexus.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 22:24:06 -0000 jhb 2006-11-13 22:23:34 UTC FreeBSD src repository Modified files: sys/amd64/amd64 local_apic.c mptable_pci.c nexus.c sys/amd64/include apicvar.h intr_machdep.h sys/amd64/pci pci_bus.c sys/conf files.amd64 files.i386 sys/i386/i386 local_apic.c mptable_pci.c nexus.c sys/i386/include apicvar.h intr_machdep.h sys/i386/pci pci_bus.c Added files: sys/amd64/amd64 msi.c sys/i386/i386 msi.c Log: MD support for PCI Message Signalled Interrupts on amd64 and i386: - Add a new apic_alloc_vectors() method to the local APIC support code to allocate N contiguous IDT vectors (aligned on a M >= N boundary). This function is used to allocate IDT vectors for a group of MSI messages. - Add MSI and MSI-X PICs. The PIC code here provides methods to manage edge-triggered MSI messages as x86 interrupt sources. In addition to the PIC methods, msi.c also includes methods to allocate and release MSI and MSI-X messages. For x86, we allow for up to 128 different MSI IRQs starting at IRQ 256 (IRQs 0-15 are reserved for ISA IRQs, 16-254 for APIC PCI IRQs, and IRQ 255 is reserved). - Add pcib_(alloc|release)_msi[x]() methods to the MD x86 PCI bridge drivers to bubble the request up to the nexus driver. - Add pcib_(alloc|release)_msi[x]() methods to the x86 nexus drivers that ask the MSI PIC code to allocate resources and IDT vectors. MFC after: 2 months Revision Changes Path 1.33 +62 -0 src/sys/amd64/amd64/local_apic.c 1.5 +8 -0 src/sys/amd64/amd64/mptable_pci.c 1.1 +511 -0 src/sys/amd64/amd64/msi.c (new) 1.70 +53 -0 src/sys/amd64/amd64/nexus.c 1.20 +1 -0 src/sys/amd64/include/apicvar.h 1.12 +17 -4 src/sys/amd64/include/intr_machdep.h 1.118 +4 -0 src/sys/amd64/pci/pci_bus.c 1.99 +1 -0 src/sys/conf/files.amd64 1.571 +1 -0 src/sys/conf/files.i386 1.35 +62 -0 src/sys/i386/i386/local_apic.c 1.5 +8 -0 src/sys/i386/i386/mptable_pci.c 1.1 +511 -0 src/sys/i386/i386/msi.c (new) 1.65 +62 -0 src/sys/i386/i386/nexus.c 1.20 +1 -0 src/sys/i386/include/apicvar.h 1.14 +17 -4 src/sys/i386/include/intr_machdep.h 1.124 +8 -0 src/sys/i386/pci/pci_bus.c From owner-cvs-src@FreeBSD.ORG Mon Nov 13 22:37:11 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EB5F16A4E9 for ; Mon, 13 Nov 2006 22:37:11 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.180]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA56A43E7B for ; Mon, 13 Nov 2006 22:33:47 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by py-out-1112.google.com with SMTP id f31so790104pyh for ; Mon, 13 Nov 2006 14:33:36 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NCv9pnQZ6NjoRdDBaEiWzg26jfM2AbruWADBMtKK9QmzvjlDx7dGUoGdX2tsx53uYQYHnN04y0RZ6/j9x8ixXwrJe0l6rGkSEPbwTY8U2tV7rdGXTeXQQMpArcPzq77TggYsjHj3lCYx1f/uxCFuC0VE4qGTtNyyPkgO39NAqn8= Received: by 10.35.111.14 with SMTP id o14mr214110pym.1163457215802; Mon, 13 Nov 2006 14:33:35 -0800 (PST) Received: by 10.35.118.6 with HTTP; Mon, 13 Nov 2006 14:33:35 -0800 (PST) Message-ID: <2a41acea0611131433i5e4612eq55a8050775dce31c@mail.gmail.com> Date: Mon, 13 Nov 2006 14:33:35 -0800 From: "Jack Vogel" To: "John Baldwin" In-Reply-To: <200611132223.kADMNYk0017934@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611132223.kADMNYk0017934@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 local_apic.c mptable_pci.c msi.c nexus.c src/sys/amd64/include apicvar.h intr_machdep.h src/sys/amd64/pci pci_bus.c src/sys/conf files.amd64 files.i386 src/sys/i386/i386 local_apic.c mptable_pci.c msi.c nexus.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 22:37:11 -0000 WOOOOOT, awesome, thanks John. BTW, have this code up and running here also now, will be new features that build on it forthcoming. Jack On 11/13/06, John Baldwin wrote: > jhb 2006-11-13 22:23:34 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 local_apic.c mptable_pci.c nexus.c > sys/amd64/include apicvar.h intr_machdep.h > sys/amd64/pci pci_bus.c > sys/conf files.amd64 files.i386 > sys/i386/i386 local_apic.c mptable_pci.c nexus.c > sys/i386/include apicvar.h intr_machdep.h > sys/i386/pci pci_bus.c > Added files: > sys/amd64/amd64 msi.c > sys/i386/i386 msi.c > Log: > MD support for PCI Message Signalled Interrupts on amd64 and i386: > - Add a new apic_alloc_vectors() method to the local APIC support code > to allocate N contiguous IDT vectors (aligned on a M >= N boundary). > This function is used to allocate IDT vectors for a group of MSI > messages. > - Add MSI and MSI-X PICs. The PIC code here provides methods to manage > edge-triggered MSI messages as x86 interrupt sources. In addition to > the PIC methods, msi.c also includes methods to allocate and release > MSI and MSI-X messages. For x86, we allow for up to 128 different > MSI IRQs starting at IRQ 256 (IRQs 0-15 are reserved for ISA IRQs, > 16-254 for APIC PCI IRQs, and IRQ 255 is reserved). > - Add pcib_(alloc|release)_msi[x]() methods to the MD x86 PCI bridge > drivers to bubble the request up to the nexus driver. > - Add pcib_(alloc|release)_msi[x]() methods to the x86 nexus drivers that > ask the MSI PIC code to allocate resources and IDT vectors. > > MFC after: 2 months > > Revision Changes Path > 1.33 +62 -0 src/sys/amd64/amd64/local_apic.c > 1.5 +8 -0 src/sys/amd64/amd64/mptable_pci.c > 1.1 +511 -0 src/sys/amd64/amd64/msi.c (new) > 1.70 +53 -0 src/sys/amd64/amd64/nexus.c > 1.20 +1 -0 src/sys/amd64/include/apicvar.h > 1.12 +17 -4 src/sys/amd64/include/intr_machdep.h > 1.118 +4 -0 src/sys/amd64/pci/pci_bus.c > 1.99 +1 -0 src/sys/conf/files.amd64 > 1.571 +1 -0 src/sys/conf/files.i386 > 1.35 +62 -0 src/sys/i386/i386/local_apic.c > 1.5 +8 -0 src/sys/i386/i386/mptable_pci.c > 1.1 +511 -0 src/sys/i386/i386/msi.c (new) > 1.65 +62 -0 src/sys/i386/i386/nexus.c > 1.20 +1 -0 src/sys/i386/include/apicvar.h > 1.14 +17 -4 src/sys/i386/include/intr_machdep.h > 1.124 +8 -0 src/sys/i386/pci/pci_bus.c > From owner-cvs-src@FreeBSD.ORG Mon Nov 13 22:39:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A41D016A68C; Mon, 13 Nov 2006 22:39:23 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E257143E1D; Mon, 13 Nov 2006 22:36:34 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([165.236.175.187]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kADMa5bU085570; Mon, 13 Nov 2006 15:36:11 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <4558F34E.6090705@samsco.org> Date: Mon, 13 Nov 2006 15:35:58 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200611132147.kADLlVok006575@repoman.freebsd.org> <200611131653.24403.jhb@freebsd.org> In-Reply-To: <200611131653.24403.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m pcib_private.h pcireg.h pcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 22:39:23 -0000 John Baldwin wrote: > On Monday 13 November 2006 16:47, John Baldwin wrote: > >>jhb 2006-11-13 21:47:30 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c >> sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h >> pcib_if.m pcib_private.h pcireg.h >> pcivar.h >> Log: >> First cut at MI support for PCI Message Signalled Interrupts (MSI): >> - Add 3 new functions to the pci_if interface along with suitable wrappers >> to provide the device driver visible API: > > > The patches I used for em, bce, and mpt are available at > http://www.freebsd.org/~jhb/patches/msi_dev.patch > > For devices that only support 1 message, the only change is to call > pci_alloc_msi() and then use rid 1 instead of rid 0 for SYS_RES_IRQ. > And just so everyone else knows, BGE and MFI have also been prototyped and tested. BGE claims support for multiple messages, so I'll be experimenting with that at some point. MFI also supports multiple messages, but appears to only use one of them. Once the MD part of MSI is committed, I'll commit the changes to these drivers. That can then be used as a code pattern for other drivers. The advantages to MSI is that you virtually eliminate interrupt sharing, and on most devices you eliminate the need to do a PCI read in the interrupt handler. For the MFI driver, I recorded an approx 20% reduction in CPU time when I switched to MSI. Network drivers will likely benefit even more. Thanks a lot to John, Peter Grehan, and Jack Vogel for working on this. Scott From owner-cvs-src@FreeBSD.ORG Tue Nov 14 01:08:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0468216A403; Tue, 14 Nov 2006 01:08:54 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CE0A43DC9; Tue, 14 Nov 2006 01:07:43 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE17ham080677; Tue, 14 Nov 2006 01:07:43 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE17glx080676; Tue, 14 Nov 2006 01:07:42 GMT (envelope-from rodrigc) Message-Id: <200611140107.kAE17glx080676@repoman.freebsd.org> From: Craig Rodrigues Date: Tue, 14 Nov 2006 01:07:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 01:08:54 -0000 rodrigc 2006-11-14 01:07:42 UTC FreeBSD src repository Modified files: sbin/mount mount.c Log: Fix debugging output of '-d', to more accurately reflect if we exec an external mount program, or just call nmount() to mount a filesystem. Noticed by: kris Revision Changes Path 1.92 +4 -1 src/sbin/mount/mount.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 03:31:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DAAA16A412 for ; Tue, 14 Nov 2006 03:31:08 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id D29A843D46 for ; Tue, 14 Nov 2006 03:31:06 +0000 (GMT) (envelope-from jkoshy.freebsd@gmail.com) Received: by nz-out-0102.google.com with SMTP id i11so886108nzh for ; Mon, 13 Nov 2006 19:31:06 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=elT2VxKWiMRoFFD3ZA3mh0LVnhFgVyzv8CFLa5mPKWi+j9buk2Z84RLrSaveWJb2P8I7/pXdI+NHMDcg8KG0QlyrmXo3gwuKXdvyHWRhc9y/TlpDNFfvMLdqCIEQ4zVG80uIdc/GUWCdl1qyP9EuY5LbzvCYy1bU/2K2e6Y5j2M= Received: by 10.64.199.2 with SMTP id w2mr225729qbf.1163475066183; Mon, 13 Nov 2006 19:31:06 -0800 (PST) Received: by 10.64.10.8 with HTTP; Mon, 13 Nov 2006 19:31:06 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2006 09:01:06 +0530 From: "Joseph Koshy" Sender: jkoshy.freebsd@gmail.com To: "Bruce Evans" In-Reply-To: <20061114050457.M77914@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113.101808.-1540392146.imp@bsdimp.com> <20061114050457.M77914@delplex.bde.org> X-Google-Sender-Auth: 1166472d036d73d0 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 03:31:08 -0000 bde> Non-broken code knows that byte-aligned data needs to be copied bde> into structs using memcpy(). Do keep in mind that this is `struct ar_hdr' we are talking about, not something else. Having to use memcpy() to copy from a collection of ASCII strings (in file) to a collection of ASCII strings (in struct ar_hdr) to cope with alignment issues is odd. To be truly portable, code needs to memcpy() in each ASCII string member of `struct ar_hdr' separately since we cannot make assumptions about the file and memory layout being identical. Needless to say no code in our tree does this today. So we need to look at the original intent of why a `struct ar_hdr' was declared as a collection of fixed size ASCII strings. My guess is that it was written that way to be able to directly describe its file layout: ASCII for portability and fixed size char[] arrays to avoid issues with structure padding. Declaring it as __packed informs today's compilers of this intent. It also brings down the alignment requirements for `struct ar_hdr' on the ARM to match that of other platforms as a side-effect. bde> I doubt that it is needed for more than breaking the warning. You bde> would have to be unlucky or shooting your feet for bde> "(struct ar *)&byte_array[offset]" to give a pointer that is actually bde> misaligned. Large arrays of chars are normally aligned to the word bde> size even if they are on the stack, and the archive header is at offset bde> 0 in files. In an ar(1) archive, there is a `struct ar_hdr' before each archive member. The only 'alignment' expected for this structure is that of falling on even offsets in the file. This is only enforced programmatically though. Regards, Koshy From owner-cvs-src@FreeBSD.ORG Tue Nov 14 05:48:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9FEA16A40F; Tue, 14 Nov 2006 05:48:30 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8675D43D80; Tue, 14 Nov 2006 05:48:28 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE5mSaY032581; Tue, 14 Nov 2006 05:48:28 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE5mSIY032580; Tue, 14 Nov 2006 05:48:28 GMT (envelope-from davidxu) Message-Id: <200611140548.kAE5mSIY032580@repoman.freebsd.org> From: David Xu Date: Tue, 14 Nov 2006 05:48:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 05:48:31 -0000 davidxu 2006-11-14 05:48:27 UTC FreeBSD src repository Modified files: sys/kern sched_4bsd.c Log: Fix a copy-paste bug in NON-KSE case. Revision Changes Path 1.90 +12 -12 src/sys/kern/sched_4bsd.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 05:54:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A4B416A403; Tue, 14 Nov 2006 05:54:17 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7F2543D53; Tue, 14 Nov 2006 05:54:16 +0000 (GMT) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE5sG0H033671; Tue, 14 Nov 2006 05:54:16 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE5sGwk033670; Tue, 14 Nov 2006 05:54:16 GMT (envelope-from delphij) Message-Id: <200611140554.kAE5sGwk033670@repoman.freebsd.org> From: Xin LI Date: Tue, 14 Nov 2006 05:54:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/zh_CN.GB2312/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 05:54:17 -0000 delphij 2006-11-14 05:54:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: MFen 1.883.2.51 -> 1.883.2.52 Approved by: re (zh_CN.GB2312 relnotes blanket) Revision Changes Path 1.5.2.12 +4 -1 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Tue Nov 14 07:57:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8F7D16A416; Tue, 14 Nov 2006 07:57:35 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 445B543D8B; Tue, 14 Nov 2006 07:57:20 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE7vK1b054445; Tue, 14 Nov 2006 07:57:20 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE7vJKR054444; Tue, 14 Nov 2006 07:57:19 GMT (envelope-from kmacy) Message-Id: <200611140757.kAE7vJKR054444@repoman.freebsd.org> From: Kip Macy Date: Tue, 14 Nov 2006 07:57:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys lock_profile.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 07:57:35 -0000 kmacy 2006-11-14 07:57:19 UTC FreeBSD src repository Modified files: sys/sys lock_profile.h Log: Add Kris Kennaway to reflect his performance improvements to the lock profiling code Revision Changes Path 1.7 +1 -0 src/sys/sys/lock_profile.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 08:09:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CAB316A407; Tue, 14 Nov 2006 08:09:27 +0000 (UTC) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B470643D68; Tue, 14 Nov 2006 08:09:26 +0000 (GMT) (envelope-from harti@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE89QP7057325; Tue, 14 Nov 2006 08:09:26 GMT (envelope-from harti@repoman.freebsd.org) Received: (from harti@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE89QDJ057320; Tue, 14 Nov 2006 08:09:26 GMT (envelope-from harti) Message-Id: <200611140809.kAE89QDJ057320@repoman.freebsd.org> From: Hartmut Brandt Date: Tue, 14 Nov 2006 08:09:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc snmpd.config X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 08:09:27 -0000 harti 2006-11-14 08:09:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc snmpd.config Log: MFC Rev. 1.2. Add a (commented out) line that loads the snmp_hostres(3) module. Approved by: re (bmah) Suggested by: Ulrich Spoerlein Revision Changes Path 1.1.4.3 +6 -0 src/etc/snmpd.config From owner-cvs-src@FreeBSD.ORG Tue Nov 14 08:45:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 139C916A407; Tue, 14 Nov 2006 08:45:50 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D61CE43D68; Tue, 14 Nov 2006 08:45:49 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAE8jn8J068886; Tue, 14 Nov 2006 08:45:49 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAE8jnYY068885; Tue, 14 Nov 2006 08:45:49 GMT (envelope-from mjacob) Message-Id: <200611140845.kAE8jnYY068885@repoman.freebsd.org> From: Matt Jacob Date: Tue, 14 Nov 2006 08:45:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_library.c isp_library.h isp_pci.c isp_stds.h ispvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 08:45:50 -0000 mjacob 2006-11-14 08:45:49 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c isp_freebsd.c isp_freebsd.h isp_library.c isp_library.h isp_pci.c isp_stds.h ispvar.h Log: Push things closer to path failover by implementing loop down and gone device timers and zombie state entries. There are tunables that can be used to select a number of parameters. loop_down_limit - how long to wait for loop to come back up before declaring all devices dead (default 300 seconds) gone_device_time- how long to wait for a device that has appeared to leave the loop or fabric to reappear (default 30 seconds) Internal tunables include (which should be externalized): quick_boot_time- how long to wait when booting for loop to come up change_is_bad- whether or not to accept devices with the same WWNN/WWPN that reappear at a different PortID as being the 'same' device. Keen students of some of the subtle issues here will ask how one can keep devices from being re-accepted at all (the answer is to set a gone_device_time to zero- that effectively would be the same thing). Revision Changes Path 1.129 +246 -226 src/sys/dev/isp/isp.c 1.127 +531 -152 src/sys/dev/isp/isp_freebsd.c 1.95 +34 -104 src/sys/dev/isp/isp_freebsd.h 1.7 +53 -6 src/sys/dev/isp/isp_library.c 1.4 +1 -0 src/sys/dev/isp/isp_library.h 1.125 +25 -3 src/sys/dev/isp/isp_pci.c 1.2 +14 -1 src/sys/dev/isp/isp_stds.h 1.79 +38 -5 src/sys/dev/isp/ispvar.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 11:16:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF8D116A403; Tue, 14 Nov 2006 11:16:35 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5EE443D53; Tue, 14 Nov 2006 11:16:34 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEBGY8o005169; Tue, 14 Nov 2006 11:16:34 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEBGYcg005168; Tue, 14 Nov 2006 11:16:34 GMT (envelope-from bz) Message-Id: <200611141116.kAEBGYcg005168@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Tue, 14 Nov 2006 11:16:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys mbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 11:16:35 -0000 bz 2006-11-14 11:16:34 UTC FreeBSD src repository Modified files: sys/sys mbuf.h Log: Correct a typo. Revision Changes Path 1.200 +1 -1 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 11:19:27 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 0C48016A416; Tue, 14 Nov 2006 11:19:27 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: Bruce Evans Date: Tue, 14 Nov 2006 19:19:16 +0800 User-Agent: KMail/1.8.2 References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <200611130717.03734.davidxu@freebsd.org> <20061113193924.L75708@delplex.bde.org> In-Reply-To: <20061113193924.L75708@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611141919.17084.davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 11:19:27 -0000 On Monday 13 November 2006 17:58, Bruce Evans wrote: > Anyway, this isn't the bug in non-KSE. I didn't look hard for the > reasons. Top seemed to show the priorites of the hogs not decreasing > (numerically increasing) fast enough. > > Bruce I think I have just fixed it now in revision 1.90 of sched_4bsd.c. From owner-cvs-src@FreeBSD.ORG Tue Nov 14 11:27:58 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20C2416A494; Tue, 14 Nov 2006 11:27:58 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8014643D55; Tue, 14 Nov 2006 11:27:57 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 19632329A9B; Tue, 14 Nov 2006 22:27:54 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 332992740A; Tue, 14 Nov 2006 22:27:52 +1100 (EST) Date: Tue, 14 Nov 2006 22:27:49 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Joseph Koshy In-Reply-To: Message-ID: <20061114210148.F1966@delplex.bde.org> References: <200611130428.kAD4ST0U093715@repoman.freebsd.org> <20061113173927.Q75708@delplex.bde.org> <20061113.101808.-1540392146.imp@bsdimp.com> <20061114050457.M77914@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 11:27:58 -0000 On Tue, 14 Nov 2006, Joseph Koshy wrote: > bde> Non-broken code knows that byte-aligned data needs to be copied > bde> into structs using memcpy(). > > Do keep in mind that this is `struct ar_hdr' we are talking about, not > something else. > > Having to use memcpy() to copy from a collection of ASCII strings (in file) > to a collection of ASCII strings (in struct ar_hdr) to cope with alignment > issues is odd. I almost didn't reply because this seemed to make the change have no effect except to break ar.h for unsupported compilers. It turned into an argument about __packed in general and struct ip in particular. > To be truly portable, code needs to memcpy() in each ASCII string member > of `struct ar_hdr' separately since we cannot make assumptions about > the file and memory layout being identical. More than that :-). The code needs to do something magic to fill the holes, it any. Kernel code is supposed to prezero using memcpy or malloc(..., M_ZERO) to avoid copying out insecurities in the holes. > Needless to say no code in our tree does this today. > > So we need to look at the original intent of why a `struct ar_hdr' was > declared as a collection of fixed size ASCII strings. My guess is that it > was written that way to be able to directly describe its file layout: ASCII > for portability and fixed size char[] arrays to avoid issues with structure > padding. Declaring it as __packed informs today's compilers of this > intent. It also brings down the alignment requirements for `struct ar_hdr' > on the ARM to match that of other platforms as a side-effect. The alignment requirement is actually the crtical one. This should be explicit (if the packing requirement is). > bde> I doubt that it is needed for more than breaking the warning. You > bde> would have to be unlucky or shooting your feet for > bde> "(struct ar *)&byte_array[offset]" to give a pointer that is actually > bde> misaligned. Large arrays of chars are normally aligned to the word > bde> size even if they are on the stack, and the archive header is at offset > bde> 0 in files. > > In an ar(1) archive, there is a `struct ar_hdr' before each archive member. > The only 'alignment' expected for this structure is that of falling on > even offsets in the file. This is only enforced programmatically though. Oops, I grepped for ARMAGIC instead of ARFMAGIC, so I didn't find any file headers. Further testing showed: (1) When __packed breaks the alignment as in struct ip, the compiler doesn't report lost of alignment on taking addresses, but on an ia64 machine in the FreeBSD cluster, the broken alignment doesn't cause problems and in fact is faster: struct foo { char c; int i; } __packed; struct foo foo; int access_int(int *ip) { return (*ip); } int main(void) { #ifdef BROKEN return (access_int(&foo.i)); #else return (foo.i); #endif } In the !BROKEN case, gcc on ia64 generates large code to load foo.i a byte at a time. In the BROKEN case the code just passes a misaligned pointer to access_int(). This should be an error, since &foo.i has the alignment of a char and the cast that changes its alignment to that of an int is only implicit, but I can't find even a warning flag for this. However, on the FreeBSD cluster machine, the misaligned access doesn't trap, and doing the access in a loop shows that the misaligned access is much faster than the correct code that does the access a byte at a time, much the same as on an i386. (2) gcc still has alignment bugs even on i386's. Even i386's things should be aligned for efficiency, and the compiler shouldn't generate any misaligned access for portable code, since if it does then it is generating inefficient code which breaks detection of user misalignment via the i486 alignment check feature. I tried using this feature when i486's first came out, but it didn't work because gcc generates misaligned code for struct copies: struct { uint8_t x; struct { uint8_t y[15]; } ssc; uint32_t z; } x, y; int main(void) { x.ssc = y.ssc; return (0); } Here the uint32_t and no __packed forces the struct to be 4-byte aligned, so ssc is known to be perfectly misaligned to an address equal to 1 mod 4. The struct copy of ssc is done inline and should consist of copying the first byte, then a 2-byte word, then 3 4-byte words. Instead, it is done by copying 3 perfectly misaligned 4-byte words, then 1 misaligned 2-byte word, then the last byte. Thus the struct copy is inefficient and always causes alignment check traps if the alignment check flag is set. The code generated by gcc for this hasn't changed much since i486's first came out. There is one helpful change: gcc now calls memcpy() if the struct size is larger than about 64, but when i486's came out it generated the misaligned inline copy for much larger structs (IIRC, for any size). gcc on i386's also generates inline copies 4 bytes at a time starting at the first byte, for structs that might only be 1-byte aligned: struct { struct { uint8_t y[60]; } nnssc; } x, y; Now the alignment cannot be known for sure, but 4-byte alignment can usually be arranged at little cost for non-small structs, so without alignment checking the best copying method for medium-sized structs is to assume that they are 4-byte aligned and use 4-byte accesses. With alignment checking, this is only best if there is a trap handler to fix up the alignement and the alignment traps rarely occur, Bruce From owner-cvs-src@FreeBSD.ORG Tue Nov 14 11:40:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E98F16A49E; Tue, 14 Nov 2006 11:40:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AC3643D5E; Tue, 14 Nov 2006 11:40:45 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEBejxw008561; Tue, 14 Nov 2006 11:40:45 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEBejSO008559; Tue, 14 Nov 2006 11:40:45 GMT (envelope-from pjd) Message-Id: <200611141140.kAEBejSO008559@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 14 Nov 2006 11:40:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys mbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 11:40:46 -0000 pjd 2006-11-14 11:40:45 UTC FreeBSD src repository Modified files: sys/sys mbuf.h Log: Use tabs instead of spaces. Revision Changes Path 1.201 +1 -1 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 12:01:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BFC516A40F; Tue, 14 Nov 2006 12:01:22 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E4F743D55; Tue, 14 Nov 2006 12:01:21 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 8ACC06EFD2; Tue, 14 Nov 2006 23:01:19 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 3D73127413; Tue, 14 Nov 2006 23:01:19 +1100 (EST) Date: Tue, 14 Nov 2006 23:01:18 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: David Xu In-Reply-To: <200611141919.17084.davidxu@freebsd.org> Message-ID: <20061114230046.P2306@delplex.bde.org> References: <200611111311.kABDBVNH042993@repoman.freebsd.org> <200611130717.03734.davidxu@freebsd.org> <20061113193924.L75708@delplex.bde.org> <200611141919.17084.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 12:01:22 -0000 On Tue, 14 Nov 2006, David Xu wrote: > On Monday 13 November 2006 17:58, Bruce Evans wrote: > >> Anyway, this isn't the bug in non-KSE. I didn't look hard for the >> reasons. Top seemed to show the priorites of the hogs not decreasing >> (numerically increasing) fast enough. >> >> Bruce > > I think I have just fixed it now in revision 1.90 of sched_4bsd.c. Thanks. I will test it soon and send some cleanups in private mail. Bruce From owner-cvs-src@FreeBSD.ORG Tue Nov 14 12:05:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 941DF16A4B3; Tue, 14 Nov 2006 12:05:57 +0000 (UTC) (envelope-from lesi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A944D43D58; Tue, 14 Nov 2006 12:05:55 +0000 (GMT) (envelope-from lesi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEC5sb6014658; Tue, 14 Nov 2006 12:05:54 GMT (envelope-from lesi@repoman.freebsd.org) Received: (from lesi@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEC5stI014655; Tue, 14 Nov 2006 12:05:54 GMT (envelope-from lesi) Message-Id: <200611141205.kAEC5stI014655@repoman.freebsd.org> From: Dejan Lesjak Date: Tue, 14 Nov 2006 12:05:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/mk sys.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 12:05:57 -0000 lesi 2006-11-14 12:05:54 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_6) share/mk sys.mk Log: MFC 1.88: Remove X11BASE from here. Approved by: re (hrs) Revision Changes Path 1.86.2.2 +0 -2 src/share/mk/sys.mk From owner-cvs-src@FreeBSD.ORG Tue Nov 14 12:10:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D47116A415; Tue, 14 Nov 2006 12:10:44 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E470843D7B; Tue, 14 Nov 2006 12:10:39 +0000 (GMT) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAECAdgP015105; Tue, 14 Nov 2006 12:10:39 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAECAd3g015104; Tue, 14 Nov 2006 12:10:39 GMT (envelope-from jkoshy) Message-Id: <200611141210.kAECAd3g015104@repoman.freebsd.org> From: Joseph Koshy Date: Tue, 14 Nov 2006 12:10:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys elf_common.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 12:10:44 -0000 jkoshy 2006-11-14 12:10:39 UTC FreeBSD src repository Modified files: sys/sys elf_common.h Log: Add `PN_XNUM', for supporting ELF objects with a large number of program header table entries. Revision Changes Path 1.21 +3 -0 src/sys/sys/elf_common.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 12:54:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0271A16A416; Tue, 14 Nov 2006 12:54:55 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B29F643D6A; Tue, 14 Nov 2006 12:54:39 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAECsdTG031343; Tue, 14 Nov 2006 12:54:39 GMT (envelope-from flz@repoman.freebsd.org) Received: (from flz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAECsd8i031342; Tue, 14 Nov 2006 12:54:39 GMT (envelope-from flz) Message-Id: <200611141254.kAECsd8i031342@repoman.freebsd.org> From: Florent Thoumie Date: Tue, 14 Nov 2006 12:54:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 aue.4 kue.4 ural.4 uscanner.4 src/sys/dev/usb if_aue.c if_cdce.c if_kue.c if_ural.c umass.c usb_quirks.c usbdevs uscanner.c src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 12:54:55 -0000 flz 2006-11-14 12:54:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 aue.4 uscanner.4 ural.4 kue.4 sys/dev/usb if_aue.c usbdevs if_cdce.c umass.c usb_quirks.c uscanner.c if_kue.c if_ural.c sys/cam/scsi scsi_da.c Log: MFC: Add support for Epson USB Scanners (3590 [1] and 4990 [2]). Add entries in the uscanner.4 man page (along with missing 3500). Add quirk for Logitech iFeel MouseMan USB mouse. [3] Add support for Familiar Linux powered iPaq handhelds to cdce(4). [4] Add a quirk for the Belkin FC6550-AVR UPS. [5] Add support for Netgear FA101 ethernet USB NIC. [6] Add support for Psion Gold Port Ethernet USB NIC. [7] Add support for Epson Stylus CX4200 in uscanner(4). [8] Add support for Novatech NV902 wireless NIC in ural(4). [9] Add SCSI da(4) quirk for the iRiver H10. [10] Add a SCSI da(4) quirk for Rekam USB Camera. [11] Add a USB quirk for Motorola A41x/V32x USB phones. [12] Add a USB quirk for CMOTECH CDMA USB modem. [13] Add a USB umass(4) quirk for Panasonic KXL-840AN CD-R drive. [14] src/share/man/man4/aue.4: rev 1.24 -> 1.25 src/sys/dev/usb/if_aue.c: rev 1.99 -> 1.100 src/sys/dev/usb/usbdevs: rev 1.264 -> 1.275 src/sys/dev/usb/if_cdce.c: rev 1.15 -> 1.16 src/sys/dev/usb/umass.c: rev 1.137 -> 1.138 src/share/man/man4/uscanner.4: rev 1.27 -> 1.29 src/share/man/man4/ural.4: rev 1.10 -> 1.11 src/sys/dev/usb/usb_quirks.c: rev 1.50 -> 1.54 src/sys/dev/usb/uscanner.c: rev 1.74 -> 1.76 src/sys/cam/scsi/scsi_da.c: rev 1.192 -> 1.194 src/sys/dev/usb/if_kue.c: rev 1.70 -> 1.71 src/share/man/man4/kue.4: rev 1.23 -> 1.24 src/sys/dev/usb/if_ural.c: rev 1.45 -> 1.46 PR: usb/100957 [1], usb/100992 [2], usb/101066 [3], usb/103865 [4], usb/102260 [5], usb/102286 [6], usb/102296 [7], usb/102851 [8], usb/102852 [9], usb/102547 [10], usb/98713 [11], usb/97512 [12], usb/97948 [13], usb/81073 [14] Submitted by: Jim Teresco [1], Walter C. Pelissero [2], Heiko Przybyl [3], Alexey Roslyakov [4], David Grochowski [5], Volker [6,7], Jonathan Fosburgh [8,9], Sven Esbjerg [10], Alex [11], Mark Diekhans [12], Alexei Volkov [13], James E. Flemer [14] Approved by: re (kensmith) Revision Changes Path 1.21.2.3 +3 -1 src/share/man/man4/aue.4 1.20.2.3 +3 -1 src/share/man/man4/kue.4 1.3.2.5 +2 -1 src/share/man/man4/ural.4 1.18.2.5 +9 -1 src/share/man/man4/uscanner.4 1.180.2.9 +16 -0 src/sys/cam/scsi/scsi_da.c 1.90.2.6 +1 -0 src/sys/dev/usb/if_aue.c 1.7.2.7 +1 -0 src/sys/dev/usb/if_cdce.c 1.64.2.4 +1 -0 src/sys/dev/usb/if_kue.c 1.10.2.9 +1 -0 src/sys/dev/usb/if_ural.c 1.122.2.11 +4 -0 src/sys/dev/usb/umass.c 1.41.2.5 +6 -0 src/sys/dev/usb/usb_quirks.c 1.232.2.17 +21 -1 src/sys/dev/usb/usbdevs 1.63.2.5 +3 -0 src/sys/dev/usb/uscanner.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 13:08:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64F0016A403; Tue, 14 Nov 2006 13:08:12 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E7B843D5E; Tue, 14 Nov 2006 13:08:12 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAED8B5V034661; Tue, 14 Nov 2006 13:08:11 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAED8Bia034660; Tue, 14 Nov 2006 13:08:11 GMT (envelope-from ariff) Message-Id: <200611141308.kAED8Bia034660@repoman.freebsd.org> From: Ariff Abdullah Date: Tue, 14 Nov 2006 13:08:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sound/pci atiixp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 13:08:12 -0000 ariff 2006-11-14 13:08:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sound/pci atiixp.c Log: MFC: DMA alignment fixup. Approved by: re (kensmith) Revision Changes Path 1.2.2.5 +1 -1 src/sys/dev/sound/pci/atiixp.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 14:22:55 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A0AE16A407; Tue, 14 Nov 2006 14:22:55 +0000 (UTC) (envelope-from avatar@mmlab.cse.yzu.edu.tw) Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw [140.138.150.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC81143D55; Tue, 14 Nov 2006 14:22:54 +0000 (GMT) (envelope-from avatar@mmlab.cse.yzu.edu.tw) Received: by www.mmlab.cse.yzu.edu.tw (qmail, from userid 1000) id 700518CA072; Tue, 14 Nov 2006 22:22:43 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by www.mmlab.cse.yzu.edu.tw (qmail) with ESMTP id 5730A8CA04A; Tue, 14 Nov 2006 22:22:43 +0800 (CST) Date: Tue, 14 Nov 2006 22:22:43 +0800 (CST) From: Tai-hwa Liang To: Giorgos Keramidas In-Reply-To: <20061019000424.GA1262@gothmog.pc> Message-ID: <0611142157336.5368@www.mmlab.cse.yzu.edu.tw> References: <200610132049.k9DKnObw045731@repoman.freebsd.org> <20061015091459.V72308@godot.imp.ch> <20061018234916.GA1711@gothmog.pc> <20061019000424.GA1262@gothmog.pc> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Tor Egge , cvs-src@freebsd.org, Martin Blapp , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_conf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 14:22:55 -0000 On Thu, 19 Oct 2006, Giorgos Keramidas wrote: > FWIW, reverting revision 1.199 of kern_conf.c locally fixes the > unkillable xterms, stuck in "devdrn", problem. With rev 1.199, modules that do destroy_dev() in their d_close() will hang in "devdrn" state upon device closing. For example, netsmb and snp: # mount_smbfs -I server //server/share /mnt Password: [hang] # watch Snoop started. Enter device name []:^C [hang] It turns out that devfs_close() does a dev_refthread() before invoking device specific d_close(), which makes subsequent destroy_dev() being blocked in the "devdrn" loop. Before someone teaches these drivers not doing destroy_dev() in their d_close(), following bandaid can workaround this hanging problem: Index: sys/netsmb/smb_dev.c =================================================================== RCS file: /home/ncvs/src/sys/netsmb/smb_dev.c,v retrieving revision 1.29 diff -u -p -u -r1.29 smb_dev.c --- sys/netsmb/smb_dev.c 22 Nov 2005 02:15:46 -0000 1.29 +++ sys/netsmb/smb_dev.c 14 Nov 2006 13:49:37 -0000 @@ -175,6 +175,7 @@ nsmb_dev_close(struct cdev *dev, int fla */ dev->si_drv1 = NULL; free(sdp, M_NSMBDEV); + dev_relthread(dev); /* XXX dealing with si_threadcount */ destroy_dev(dev); splx(s); return 0; Index: sys/dev/snp/snp.c =================================================================== RCS file: /home/ncvs/src/sys/dev/snp/snp.c,v retrieving revision 1.102 diff -u -p -u -r1.102 snp.c --- sys/dev/snp/snp.c 19 Sep 2005 13:48:45 -0000 1.102 +++ sys/dev/snp/snp.c 14 Nov 2006 13:49:37 -0000 @@ -489,6 +489,7 @@ snpclose(dev, flags, fmt, td) free(snp->snp_buf, M_SNP); snp->snp_flags &= ~SNOOP_OPEN; dev->si_drv1 = NULL; + dev_relthread(dev); /* XXX dealing with si_threadcount */ destroy_dev(dev); return (snp_detach(snp)); On the other hand, si_threadcount could be negative with aforementioned patch... :( > On 2006-10-19 02:49, Giorgos Keramidas wrote: >> >> Maybe it's not related, but all xterm's seem unkillable and blocked >> forever in "devdrn" here, in a build from 2006.10.18.15.56.11. >> >> An earlier sync from 2006.10.13.12.45.54 didn't exhibit this behavior, >> so I guess there's something mildly buggy with this change? >> >> On 2006-10-15 09:15, Martin Blapp wrote: >>> >>> Cool, thank you ! >>> >>> Martin >>> >>> Martin Blapp, >>> ------------------------------------------------------------------ >>> ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH >>> Phone: +41 61 826 93 00 Fax: +41 61 826 93 01 >>> PGP: >>> PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E >>> ------------------------------------------------------------------ >>> >>> On Fri, 13 Oct 2006, Tor Egge wrote: >>> >>>> tegge 2006-10-13 20:49:24 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/kern kern_conf.c >>>> Log: >>>> Wait for thread count to reach zero in destroy_devl() even when no purge >>>> method is defined, to avoid memory being modified after free. >>>> >>>> Temporarily increase refcount in destroy_devl() to avoid a double free >>>> if dev_rel() is called while waiting for thread count to reach zero. >>>> >>>> Revision Changes Path >>>> 1.199 +6 -0 src/sys/kern/kern_conf.c -- Cheers, Tai-hwa Liang From owner-cvs-src@FreeBSD.ORG Tue Nov 14 14:28:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD6E416A417; Tue, 14 Nov 2006 14:28:13 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DE2243D77; Tue, 14 Nov 2006 14:28:10 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEESAk6049503; Tue, 14 Nov 2006 14:28:10 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEESA7U049502; Tue, 14 Nov 2006 14:28:10 GMT (envelope-from ru) Message-Id: <200611141428.kAEESA7U049502@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 14 Nov 2006 14:28:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files.pc98 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 14:28:13 -0000 ru 2006-11-14 14:28:10 UTC FreeBSD src repository Modified files: sys/conf files.pc98 Log: Unbreak pc98. Revision Changes Path 1.350 +1 -0 src/sys/conf/files.pc98 From owner-cvs-src@FreeBSD.ORG Tue Nov 14 16:21:12 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8ECD816A776; Tue, 14 Nov 2006 16:21:12 +0000 (UTC) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 535F6442CB; Tue, 14 Nov 2006 16:14:44 +0000 (GMT) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEGEiVi073890; Tue, 14 Nov 2006 16:14:44 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEGEidD073889; Tue, 14 Nov 2006 16:14:44 GMT (envelope-from grehan) Message-Id: <200611141614.kAEGEidD073889@repoman.freebsd.org> From: Peter Grehan Date: Tue, 14 Nov 2006 16:14:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/powerpc/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 16:21:13 -0000 grehan 2006-11-14 16:14:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/powerpc/conf GENERIC Log: Unbreak ppc kernel build by removing zs driver. Approved by: re (Ken Smith) Revision Changes Path 1.48.2.5 +0 -1 src/sys/powerpc/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Tue Nov 14 16:48:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D58E16A403; Tue, 14 Nov 2006 16:48:01 +0000 (UTC) (envelope-from ambrisko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCEB843D4C; Tue, 14 Nov 2006 16:48:00 +0000 (GMT) (envelope-from ambrisko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEGm0Sq087000; Tue, 14 Nov 2006 16:48:00 GMT (envelope-from ambrisko@repoman.freebsd.org) Received: (from ambrisko@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEGm02M086999; Tue, 14 Nov 2006 16:48:00 GMT (envelope-from ambrisko) Message-Id: <200611141648.kAEGm02M086999@repoman.freebsd.org> From: Doug Ambrisko Date: Tue, 14 Nov 2006 16:48:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mfi mfi.c mfi_ioctl.h mfi_linux.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 16:48:01 -0000 ambrisko 2006-11-14 16:48:00 UTC FreeBSD src repository Modified files: sys/dev/mfi mfi.c mfi_ioctl.h mfi_linux.c Log: - Add in FreeBSD native ioctl that models the Linux version. - Add a translation so the Linux ioctl's don't conflict with the FreeBSD definition. - Assume Linux 32bit emulation on amd64. This was tested on i386 and amd64 with the 32bit Linux MegaCli. Eventually we should do a 32bit native FreeBSD translation app. Revision Changes Path 1.22 +145 -6 src/sys/dev/mfi/mfi.c 1.3 +47 -0 src/sys/dev/mfi/mfi_ioctl.h 1.2 +14 -1 src/sys/dev/mfi/mfi_linux.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 17:54:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4323C16A47B; Tue, 14 Nov 2006 17:54:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0F3543D46; Tue, 14 Nov 2006 17:54:55 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEHstU0099251; Tue, 14 Nov 2006 17:54:55 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEHst1Y099250; Tue, 14 Nov 2006 17:54:55 GMT (envelope-from jhb) Message-Id: <200611141754.kAEHst1Y099250@repoman.freebsd.org> From: John Baldwin Date: Tue, 14 Nov 2006 17:54:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pcivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 17:54:56 -0000 jhb 2006-11-14 17:54:55 UTC FreeBSD src repository Modified files: sys/dev/pci pcivar.h Log: Fix a couple of comment typos. Reported by: ru Revision Changes Path 1.74 +2 -2 src/sys/dev/pci/pcivar.h From owner-cvs-src@FreeBSD.ORG Tue Nov 14 18:54:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 572A616A501; Tue, 14 Nov 2006 18:54:35 +0000 (UTC) (envelope-from rink@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1F1F43D55; Tue, 14 Nov 2006 18:54:31 +0000 (GMT) (envelope-from rink@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEIsVZL013074; Tue, 14 Nov 2006 18:54:31 GMT (envelope-from rink@repoman.freebsd.org) Received: (from rink@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEIsVN3013073; Tue, 14 Nov 2006 18:54:31 GMT (envelope-from rink) Message-Id: <200611141854.kAEIsVN3013073@repoman.freebsd.org> From: Rink Springer Date: Tue, 14 Nov 2006 18:54:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 18:54:35 -0000 rink 2006-11-14 18:54:31 UTC FreeBSD src repository Modified files: sys/dev/fxp if_fxp.c Log: Added yet another extra fxp(4) PCI ID. PR: kern/104896 Submitted by: Yoshihiko Sarumaru Reviewed by: imp (mentor), jfv Approved by: imp (mentor) MFC after: 3 days Revision Changes Path 1.260 +1 -0 src/sys/dev/fxp/if_fxp.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 18:56:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 354DB16A412; Tue, 14 Nov 2006 18:56:03 +0000 (UTC) (envelope-from xi@borderworlds.dk) Received: from ferengi.borderworlds.dk (ferengi.borderworlds.dk [80.166.152.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D4D643D4C; Tue, 14 Nov 2006 18:56:02 +0000 (GMT) (envelope-from xi@borderworlds.dk) Received: from dominion.borderworlds.dk (dominion.borderworlds.dk [10.1.0.10]) by ferengi.borderworlds.dk (Postfix) with ESMTP id 2C514B870; Tue, 14 Nov 2006 19:56:00 +0100 (CET) Received: by dominion.borderworlds.dk (Postfix, from userid 2000) id A83008C8; Tue, 14 Nov 2006 19:55:59 +0100 (CET) To: Pawel Jakub Dawidek References: <200611131513.kADFD52n017355@repoman.freebsd.org> From: Christian Laursen Date: Tue, 14 Nov 2006 19:55:59 +0100 In-Reply-To: <200611131513.kADFD52n017355@repoman.freebsd.org> (Pawel Jakub Dawidek's message of "Mon, 13 Nov 2006 15:13:05 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ggate/shared ggate.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 18:56:03 -0000 Pawel Jakub Dawidek writes: > pjd 2006-11-13 15:13:05 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sbin/ggate/shared ggate.c > Log: > MFC: sbin/ggate/shared/ggate.c 1.6 > > - Handle timeouts from recv(2) properly. > - Increase timeout to 8 seconds (should be made configurable). Thanks. I can confirm that this fixes the problem for me. -- Christian Laursen From owner-cvs-src@FreeBSD.ORG Tue Nov 14 19:28:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89B4116A407; Tue, 14 Nov 2006 19:28:43 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA48F43D7C; Tue, 14 Nov 2006 19:28:39 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEJSbVK021062; Tue, 14 Nov 2006 19:28:37 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEJSbS8021061; Tue, 14 Nov 2006 19:28:37 GMT (envelope-from trhodes) Message-Id: <200611141928.kAEJSbS8021061@repoman.freebsd.org> From: Tom Rhodes Date: Tue, 14 Nov 2006 19:28:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern sys_process.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 19:28:43 -0000 trhodes 2006-11-14 19:28:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern sys_process.c Log: MFC 1.139: Close a race condition where num can be larger than tmp, giving the user too large of a boundary. Reported by: Ilja Van Sprundel Approved by: re (kensmith) Revision Changes Path 1.131.2.7 +1 -1 src/sys/kern/sys_process.c From owner-cvs-src@FreeBSD.ORG Tue Nov 14 20:48:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D895D16A4A0; Tue, 14 Nov 2006 20:48:39 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8D4E43DBE; Tue, 14 Nov 2006 20:42:40 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAEKgeDI050221; Tue, 14 Nov 2006 20:42:40 GMT (envelope-from trhodes@repoman.freebsd.org) Received: (from trhodes@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAEKgeSJ050215; Tue, 14 Nov 2006 20:42:40 GMT (envelope-from trhodes) Message-Id: <200611142042.kAEKgeSJ050215@repoman.freebsd.org> From: Tom Rhodes Date: Tue, 14 Nov 2006 20:42:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/ntfs ntfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2006 20:48:40 -0000 trhodes 2006-11-14 20:42:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/ntfs ntfs_vnops.c Log: MFC 1.58: Fake the link count until we have no choice but to load data from the MFT. PR: 86965 Submitted by: Lowell Gilbert Approved by: re (kensmith) Revision Changes Path 1.55.2.3 +1 -1 src/sys/fs/ntfs/ntfs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 03:16:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FBF616A403; Wed, 15 Nov 2006 03:16:31 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CFD943D46; Wed, 15 Nov 2006 03:16:31 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF3GVsx046977; Wed, 15 Nov 2006 03:16:31 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF3GVq1046976; Wed, 15 Nov 2006 03:16:31 GMT (envelope-from kmacy) Message-Id: <200611150316.kAF3GVq1046976@repoman.freebsd.org> From: Kip Macy Date: Wed, 15 Nov 2006 03:16:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v exception.S interrupt.S src/sys/sun4v/include asmacros.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 03:16:31 -0000 kmacy 2006-11-15 03:16:30 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v interrupt.S exception.S sys/sun4v/include asmacros.h Log: add trap tracing to cpu mondo handler and tsb miss handler Revision Changes Path 1.2 +31 -0 src/sys/sun4v/include/asmacros.h 1.4 +6 -2 src/sys/sun4v/sun4v/exception.S 1.3 +12 -1 src/sys/sun4v/sun4v/interrupt.S From owner-cvs-src@FreeBSD.ORG Wed Nov 15 03:20:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CCED16A407; Wed, 15 Nov 2006 03:20:13 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BA8F43D53; Wed, 15 Nov 2006 03:20:13 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF3KDiM047176; Wed, 15 Nov 2006 03:20:13 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF3KCxc047174; Wed, 15 Nov 2006 03:20:12 GMT (envelope-from kmacy) Message-Id: <200611150320.kAF3KCxc047174@repoman.freebsd.org> From: Kip Macy Date: Wed, 15 Nov 2006 03:20:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v interrupt.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 03:20:13 -0000 kmacy 2006-11-15 03:20:12 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v interrupt.S Log: add trap tracing to dev_mondo Revision Changes Path 1.4 +10 -0 src/sys/sun4v/sun4v/interrupt.S From owner-cvs-src@FreeBSD.ORG Wed Nov 15 03:53:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D5FB16A40F; Wed, 15 Nov 2006 03:53:28 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06D1A43D5A; Wed, 15 Nov 2006 03:53:28 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF3rR8p053225; Wed, 15 Nov 2006 03:53:27 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF3rRcP053223; Wed, 15 Nov 2006 03:53:27 GMT (envelope-from kmacy) Message-Id: <200611150353.kAF3rRcP053223@repoman.freebsd.org> From: Kip Macy Date: Wed, 15 Nov 2006 03:53:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v exception.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 03:53:28 -0000 kmacy 2006-11-15 03:53:27 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v exception.S Log: add trap trace to tl1 trap Revision Changes Path 1.5 +9 -0 src/sys/sun4v/sun4v/exception.S From owner-cvs-src@FreeBSD.ORG Wed Nov 15 05:14:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC7FE16A412; Wed, 15 Nov 2006 05:14:20 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A93D343D58; Wed, 15 Nov 2006 05:14:20 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF5EKC6076587; Wed, 15 Nov 2006 05:14:20 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF5EK7o076586; Wed, 15 Nov 2006 05:14:20 GMT (envelope-from kientzle) Message-Id: <200611150514.kAF5EK7o076586@repoman.freebsd.org> From: Tim Kientzle Date: Wed, 15 Nov 2006 05:14:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_private.h archive_write.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_shar.c archive_write_set_format_ustar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 05:14:21 -0000 kientzle 2006-11-15 05:14:20 UTC FreeBSD src repository Modified files: lib/libarchive archive_private.h archive_write.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_shar.c archive_write_set_format_ustar.c Log: Change the internal API for writing data to an entry; make the internal format-specific functions return the same as the public function, so that the public API layer doesn't have to guess the correct return value. This addresses an obscure problem that occurs when someone tries to write more data than the size of the entry (as indicated in the entry header). In this case, the return value from archive_write_data() was incorrect, reflecting the requested write rather than the amount actually written. MFC after: 15 days Revision Changes Path 1.24 +1 -1 src/lib/libarchive/archive_private.h 1.21 +1 -3 src/lib/libarchive/archive_write.c 1.8 +6 -3 src/lib/libarchive/archive_write_set_format_cpio.c 1.36 +6 -3 src/lib/libarchive/archive_write_set_format_pax.c 1.13 +9 -6 src/lib/libarchive/archive_write_set_format_shar.c 1.16 +5 -3 src/lib/libarchive/archive_write_set_format_ustar.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 05:20:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0F9C16A403; Wed, 15 Nov 2006 05:20:14 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E33043D45; Wed, 15 Nov 2006 05:20:14 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF5KERg076884; Wed, 15 Nov 2006 05:20:14 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF5KE91076883; Wed, 15 Nov 2006 05:20:14 GMT (envelope-from kientzle) Message-Id: <200611150520.kAF5KE91076883@repoman.freebsd.org> From: Tim Kientzle Date: Wed, 15 Nov 2006 05:20:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive_write_set_format_shar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 05:20:15 -0000 kientzle 2006-11-15 05:20:14 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_set_format_shar.c Log: Style: Use the correct type for a sizeof() variable. Revision Changes Path 1.14 +1 -1 src/lib/libarchive/archive_write_set_format_shar.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 05:33:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D98E916A407; Wed, 15 Nov 2006 05:33:39 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BBA543D5C; Wed, 15 Nov 2006 05:33:39 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF5Xdlu079938; Wed, 15 Nov 2006 05:33:39 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF5Xdh8079937; Wed, 15 Nov 2006 05:33:39 GMT (envelope-from kientzle) Message-Id: <200611150533.kAF5Xdh8079937@repoman.freebsd.org> From: Tim Kientzle Date: Wed, 15 Nov 2006 05:33:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libarchive archive.h.in archive_read_open_file.c archive_write_open_file.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 05:33:40 -0000 kientzle 2006-11-15 05:33:38 UTC FreeBSD src repository Modified files: lib/libarchive archive.h.in archive_read_open_file.c archive_write_open_file.c Log: Add archive_write_open_filename()/archive_read_open_filename() as synonyms for archive_write_open_file()/archive_read_open_file(). The new names are much clearer. Revision Changes Path 1.32 +15 -8 src/lib/libarchive/archive.h.in 1.15 +7 -0 src/lib/libarchive/archive_read_open_file.c 1.15 +6 -0 src/lib/libarchive/archive_write_open_file.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 06:12:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F88816A407; Wed, 15 Nov 2006 06:12:27 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 254A343D58; Wed, 15 Nov 2006 06:12:27 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF6CRGh087304; Wed, 15 Nov 2006 06:12:27 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF6CQSn087302; Wed, 15 Nov 2006 06:12:26 GMT (envelope-from jb) Message-Id: <200611150612.kAF6CQSn087302@repoman.freebsd.org> From: John Birrell Date: Wed, 15 Nov 2006 06:12:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/sun4v boot_crunch.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 06:12:27 -0000 jb 2006-11-15 06:12:26 UTC FreeBSD src repository Added files: release/sun4v boot_crunch.conf Log: Add a copy of the sparc64 boot crunch configuration as a starting point for sun4v. With this commit, the 'make release' works on sun4v and boots. I still have to check that it actually installs to disk. Revision Changes Path 1.1 +44 -0 src/release/sun4v/boot_crunch.conf (new) From owner-cvs-src@FreeBSD.ORG Wed Nov 15 06:29:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F14BB16A40F; Wed, 15 Nov 2006 06:29:52 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACD7443D4C; Wed, 15 Nov 2006 06:29:52 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF6TqI0089379; Wed, 15 Nov 2006 06:29:52 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF6TqlM089378; Wed, 15 Nov 2006 06:29:52 GMT (envelope-from kmacy) Message-Id: <200611150629.kAF6TqlM089378@repoman.freebsd.org> From: Kip Macy Date: Wed, 15 Nov 2006 06:29:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/include tte_hash.h src/sys/sun4v/sun4v tte_hash.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 06:29:53 -0000 kmacy 2006-11-15 06:29:52 UTC FreeBSD src repository Modified files: sys/sun4v/include tte_hash.h sys/sun4v/sun4v tte_hash.c Log: Heavily re-factor tte_hash to remove redundant code Add hash resizing support - doesn't quite work yet Revision Changes Path 1.2 +3 -0 src/sys/sun4v/include/tte_hash.h 1.2 +180 -56 src/sys/sun4v/sun4v/tte_hash.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 09:13:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C42116A407; Wed, 15 Nov 2006 09:13:42 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3640B43D80; Wed, 15 Nov 2006 09:13:27 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAF9DQ4u026824; Wed, 15 Nov 2006 09:13:26 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAF9DQkZ026823; Wed, 15 Nov 2006 09:13:26 GMT (envelope-from maxim) Message-Id: <200611150913.kAF9DQkZ026823@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 15 Nov 2006 09:13:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 Makefile uark.4 src/sys/conf NOTES files src/sys/dev/usb uark.c usbdevs src/sys/modules Makefile src/sys/modules/uark Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 09:13:42 -0000 maxim 2006-11-15 09:13:25 UTC FreeBSD src repository Modified files: share/man/man4 Makefile sys/conf NOTES files sys/dev/usb usbdevs sys/modules Makefile Added files: share/man/man4 uark.4 sys/dev/usb uark.c sys/modules/uark Makefile Log: o Add uark(4), a driver for Arkmicro Technologies ARK3116 based serial adapters. Submitted by: Alex Rodin Obtained from: OpenBSD Reviewed by: -usb MFC after: 6 weeks Revision Changes Path 1.366 +1 -0 src/share/man/man4/Makefile 1.1 +69 -0 src/share/man/man4/uark.4 (new) 1.1400 +2 -0 src/sys/conf/NOTES 1.1162 +1 -0 src/sys/conf/files 1.1 +367 -0 src/sys/dev/usb/uark.c (new) 1.278 +4 -0 src/sys/dev/usb/usbdevs 1.512 +1 -0 src/sys/modules/Makefile 1.1 +8 -0 src/sys/modules/uark/Makefile (new) From owner-cvs-src@FreeBSD.ORG Wed Nov 15 10:01:14 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A1C816A415; Wed, 15 Nov 2006 10:01:14 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F43543D8B; Wed, 15 Nov 2006 10:01:07 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFA17jm031107; Wed, 15 Nov 2006 10:01:07 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFA179Z031106; Wed, 15 Nov 2006 10:01:07 GMT (envelope-from kib) Message-Id: <200611151001.kAFA179Z031106@repoman.freebsd.org> From: Konstantin Belousov Date: Wed, 15 Nov 2006 10:01:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 10:01:14 -0000 kib 2006-11-15 10:01:06 UTC FreeBSD src repository Modified files: sys/compat/linux linux_misc.c Log: In rev 1.188 of linux_misc.c the added check for valid options ommited __WCLONE. This fixes it thus fixing skype/teamspeak to not keep zombies after exit. Submitted by: rdivacky Reported by: Bakul Shah (bakul at bitblocks com) Revision Changes Path 1.194 +1 -1 src/sys/compat/linux/linux_misc.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 11:04:38 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CE7C16A403; Wed, 15 Nov 2006 11:04:38 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7ECC43D45; Wed, 15 Nov 2006 11:04:37 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFB4bx9040088; Wed, 15 Nov 2006 11:04:37 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFB4bHV040087; Wed, 15 Nov 2006 11:04:37 GMT (envelope-from kib) Message-Id: <200611151104.kAFB4bHV040087@repoman.freebsd.org> From: Konstantin Belousov Date: Wed, 15 Nov 2006 11:04:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_emul.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 11:04:38 -0000 kib 2006-11-15 11:04:37 UTC FreeBSD src repository Modified files: sys/compat/linux linux_emul.c Log: Group pid and parent are shared in a case of CLONE_THREAD not CLONE_VM. This fix lets clone02 LTP test pass with 2.6 emulation. In reality 99% of the cases are that CLONE_VM and CLONE_THREAD are both set so it seemed to work. Submitted by: rdivacky Revision Changes Path 1.9 +3 -3 src/sys/compat/linux/linux_emul.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 12:45:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF78116A4E7; Wed, 15 Nov 2006 12:45:00 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AEA2F448D7; Wed, 15 Nov 2006 12:43:46 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFChk4Y051893; Wed, 15 Nov 2006 12:43:46 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFChkwr051892; Wed, 15 Nov 2006 12:43:46 GMT (envelope-from rwatson) Message-Id: <200611151243.kAFChkwr051892@repoman.freebsd.org> From: Robert Watson Date: Wed, 15 Nov 2006 12:43:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sockets/unix_sendtorace Makefile unix_sendtorace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 12:45:01 -0000 rwatson 2006-11-15 12:43:46 UTC FreeBSD src repository Added files: tools/regression/sockets/unix_sendtorace Makefile unix_sendtorace.c Log: Add a short regression test to try to exercise races in the non-atomic nature of implied connect via sendto(). Oddly, uipc_usrreq.c implements this for stream sockets, but doesn't set the flag in its protocol definition so that it can actually be used. As such, the stream test is implemented but doesn't run for now. Revision Changes Path 1.1 +7 -0 src/tools/regression/sockets/unix_sendtorace/Makefile (new) 1.1 +212 -0 src/tools/regression/sockets/unix_sendtorace/unix_sendtorace.c (new) From owner-cvs-src@FreeBSD.ORG Wed Nov 15 14:58:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6928F16A407; Wed, 15 Nov 2006 14:58:02 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52E0143DA4; Wed, 15 Nov 2006 14:57:09 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFEv5CU076517; Wed, 15 Nov 2006 14:57:06 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFEv5cA076516; Wed, 15 Nov 2006 14:57:05 GMT (envelope-from yar) Message-Id: <200611151457.kAFEv5cA076516@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 15 Nov 2006 14:57:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 14:58:02 -0000 yar 2006-11-15 14:57:05 UTC FreeBSD src repository Modified files: usr.sbin Makefile Log: Building faithd(8) has no sense if WITHOUT_INET6 is set. PR: bin/100805 (audit-trail) Noticed by: Alex Kozlov Revision Changes Path 1.364 +2 -1 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Wed Nov 15 16:59:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5897616A4C9; Wed, 15 Nov 2006 16:59:16 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1349443D4C; Wed, 15 Nov 2006 16:59:16 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFGxFF1007302; Wed, 15 Nov 2006 16:59:15 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFGxFbt007301; Wed, 15 Nov 2006 16:59:15 GMT (envelope-from brueffer) Message-Id: <200611151659.kAFGxFbt007301@repoman.freebsd.org> From: Christian Brueffer Date: Wed, 15 Nov 2006 16:59:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 uark.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 16:59:16 -0000 brueffer 2006-11-15 16:59:15 UTC FreeBSD src repository Modified files: share/man/man4 uark.4 Log: - Use our standard section 4 SYNOPSIS - Add a HARDWARE section - Mention the first release to include this driver Revision Changes Path 1.2 +20 -4 src/share/man/man4/uark.4 From owner-cvs-src@FreeBSD.ORG Wed Nov 15 17:30:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6C3E16A4AB; Wed, 15 Nov 2006 17:30:22 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E070944040; Wed, 15 Nov 2006 17:27:29 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFHRPgx011877; Wed, 15 Nov 2006 17:27:25 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFHRP1Q011876; Wed, 15 Nov 2006 17:27:25 GMT (envelope-from kensmith) Message-Id: <200611151727.kAFHRP1Q011876@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 17:27:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT approvers X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 17:30:23 -0000 kensmith 2006-11-15 17:27:25 UTC FreeBSD src repository Modified files: . approvers Log: Prepare for RELENG_6_2, it will begin life in code freeze requiring re@ approval. Approved by: core (implicit) Revision Changes Path 1.37 +1 -0 CVSROOT/approvers From owner-cvs-src@FreeBSD.ORG Wed Nov 15 18:41:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8A1516A412; Wed, 15 Nov 2006 18:41:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D683743DFC; Wed, 15 Nov 2006 18:40:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFIe1E4034671; Wed, 15 Nov 2006 18:40:01 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFIe1Q3034670; Wed, 15 Nov 2006 18:40:01 GMT (envelope-from jhb) Message-Id: <200611151840.kAFIe1Q3034670@repoman.freebsd.org> From: John Baldwin Date: Wed, 15 Nov 2006 18:40:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 msi.c src/sys/i386/i386 msi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 18:41:28 -0000 jhb 2006-11-15 18:40:00 UTC FreeBSD src repository Modified files: sys/amd64/amd64 msi.c sys/i386/i386 msi.c Log: Fix a typo that broke MSI (MSI-X worked fine) in the later revisions of the MSI patches. Revision Changes Path 1.2 +1 -1 src/sys/amd64/amd64/msi.c 1.2 +1 -1 src/sys/i386/i386/msi.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 19:05:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A18116A515; Wed, 15 Nov 2006 19:05:52 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 073DB43D5E; Wed, 15 Nov 2006 19:05:52 +0000 (GMT) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFJ5paI039037; Wed, 15 Nov 2006 19:05:51 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFJ5pWS039036; Wed, 15 Nov 2006 19:05:51 GMT (envelope-from matteo) Message-Id: <200611151905.kAFJ5pWS039036@repoman.freebsd.org> From: Matteo Riondato Date: Wed, 15 Nov 2006 19:05:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 19:05:52 -0000 matteo 2006-11-15 19:05:51 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add a BIND-4 related obsolete files Submitted by: Riccardo Torrini vic@gufi.org MFC after: 1 week Revision Changes Path 1.60 +2 -0 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Wed Nov 15 19:53:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 145DA16A40F; Wed, 15 Nov 2006 19:53:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF79C43D49; Wed, 15 Nov 2006 19:53:49 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFJrngV056276; Wed, 15 Nov 2006 19:53:49 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFJrnuQ056275; Wed, 15 Nov 2006 19:53:49 GMT (envelope-from jhb) Message-Id: <200611151953.kAFJrnuQ056275@repoman.freebsd.org> From: John Baldwin Date: Wed, 15 Nov 2006 19:53:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 db_trace.c machdep.c src/sys/amd64/include reg.h src/sys/i386/i386 db_trace.c machdep.c src/sys/i386/include reg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 19:53:50 -0000 jhb 2006-11-15 19:53:49 UTC FreeBSD src repository Modified files: sys/amd64/amd64 db_trace.c machdep.c sys/amd64/include reg.h sys/i386/i386 db_trace.c machdep.c sys/i386/include reg.h Log: Various whitespace and style fixes. Revision Changes Path 1.77 +35 -36 src/sys/amd64/amd64/db_trace.c 1.661 +2 -3 src/sys/amd64/amd64/machdep.c 1.36 +7 -5 src/sys/amd64/include/reg.h 1.76 +35 -36 src/sys/i386/i386/db_trace.c 1.641 +2 -3 src/sys/i386/i386/machdep.c 1.32 +5 -5 src/sys/i386/include/reg.h From owner-cvs-src@FreeBSD.ORG Wed Nov 15 20:02:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FC7B16A412; Wed, 15 Nov 2006 20:02:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D43C943D69; Wed, 15 Nov 2006 20:02:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFK2MWY057346; Wed, 15 Nov 2006 20:02:22 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFK2MIs057345; Wed, 15 Nov 2006 20:02:22 GMT (envelope-from jhb) Message-Id: <200611152002.kAFK2MIs057345@repoman.freebsd.org> From: John Baldwin Date: Wed, 15 Nov 2006 20:02:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 20:02:28 -0000 jhb 2006-11-15 20:02:21 UTC FreeBSD src repository Modified files: . UPDATING Log: Add a note about the MSI support with details on how to turn MSI off if things break. Revision Changes Path 1.464 +8 -0 src/UPDATING From owner-cvs-src@FreeBSD.ORG Wed Nov 15 20:04:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9E4116A407; Wed, 15 Nov 2006 20:04:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E2CF43D72; Wed, 15 Nov 2006 20:04:57 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFK4vHA058984; Wed, 15 Nov 2006 20:04:57 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFK4vfe058983; Wed, 15 Nov 2006 20:04:57 GMT (envelope-from jhb) Message-Id: <200611152004.kAFK4vfe058983@repoman.freebsd.org> From: John Baldwin Date: Wed, 15 Nov 2006 20:04:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 20:04:58 -0000 jhb 2006-11-15 20:04:57 UTC FreeBSD src repository Modified files: sys/dev/bce if_bce.c sys/dev/em if_em.c if_em.h sys/dev/mpt mpt.h mpt_pci.c Log: Add MSI support to em(4), bce(4), and mpt(4). For now, we only support devices that support a maximum of 1 message, and we use that 1 message instead of the INTx rid 0 IRQ with the same interrupt handler, etc. Revision Changes Path 1.19 +11 -3 src/sys/dev/bce/if_bce.c 1.164 +11 -2 src/sys/dev/em/if_em.c 1.56 +1 -0 src/sys/dev/em/if_em.h 1.31 +1 -0 src/sys/dev/mpt/mpt.h 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 20:18:10 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A607B16A417; Wed, 15 Nov 2006 20:18:10 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9249C43D7E; Wed, 15 Nov 2006 20:18:09 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFKI9KM061679; Wed, 15 Nov 2006 20:18:09 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFKI9A3061678; Wed, 15 Nov 2006 20:18:09 GMT (envelope-from mjacob) Message-Id: <200611152018.kAFKI9A3061678@repoman.freebsd.org> From: Matt Jacob Date: Wed, 15 Nov 2006 20:18:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 20:18:10 -0000 mjacob 2006-11-15 20:18:09 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: Turn off MSI until some testing is done. Revision Changes Path 1.40 +2 -0 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 20:44:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A28CD16A416; Wed, 15 Nov 2006 20:44:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B37E243DBF; Wed, 15 Nov 2006 20:44:07 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFKi7EN066714; Wed, 15 Nov 2006 20:44:07 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFKi7Qi066713; Wed, 15 Nov 2006 20:44:07 GMT (envelope-from jhb) Message-Id: <200611152044.kAFKi7Qi066713@repoman.freebsd.org> From: John Baldwin Date: Wed, 15 Nov 2006 20:44:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 20:44:23 -0000 jhb 2006-11-15 20:44:07 UTC FreeBSD src repository Modified files: sys/kern kern_synch.c Log: Adjust assertions to allow for magical properties of the 'lbolt' wait channel for tsleep(): - Allow tsleep() on &lbolt without Giant with a timeout 0 since &lbolt has an implied timeout. - If &lbolt is used with msleep() pass NULL to sleepq_add() for the lock object. Unlike other sleepq channels, &lbolt doesn't have an associated owning lock. Revision Changes Path 1.283 +3 -3 src/sys/kern/kern_synch.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:22:38 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFF3E16A54D; Wed, 15 Nov 2006 21:22:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51E9243D5A; Wed, 15 Nov 2006 21:22:28 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAFLMGMP034454; Wed, 15 Nov 2006 16:22:22 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Matt Jacob Date: Wed, 15 Nov 2006 16:17:22 -0500 User-Agent: KMail/1.9.1 References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> In-Reply-To: <200611152018.kAFKI9A3061678@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611151617.23125.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 15 Nov 2006 16:22:22 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2197/Wed Nov 15 15:23:52 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:22:38 -0000 On Wednesday 15 November 2006 15:18, Matt Jacob wrote: > mjacob 2006-11-15 20:18:09 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mpt mpt_pci.c > Log: > Turn off MSI until some testing is done. > > Revision Changes Path > 1.40 +2 -0 src/sys/dev/mpt/mpt_pci.c Works great here on the box I tested it on with both MSI and MSI-X, so it wasn't untested. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:23:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E6AA16A4E6; Wed, 15 Nov 2006 21:23:28 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75FE243D5E; Wed, 15 Nov 2006 21:23:22 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLNLl8084311; Wed, 15 Nov 2006 21:23:21 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLNLn7084310; Wed, 15 Nov 2006 21:23:21 GMT (envelope-from kensmith) Message-Id: <200611152123.kAFLNLn7084310@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:23:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:23:28 -0000 kensmith 2006-11-15 21:23:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) . Makefile.inc1 Log: Adjust the branch tag used for 'make update'. Approved by: re (implicit) Revision Changes Path 1.499.2.14.2.1 +1 -1 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:30:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7831616A403; Wed, 15 Nov 2006 21:30:13 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C518043D5C; Wed, 15 Nov 2006 21:30:10 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLUAO7085007; Wed, 15 Nov 2006 21:30:10 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLUAMu085005; Wed, 15 Nov 2006 21:30:10 GMT (envelope-from kensmith) Message-Id: <200611152130.kAFLUAMu085005@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:30:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/share/examples Makefile.relnotesng X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:30:13 -0000 kensmith 2006-11-15 21:30:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/share/examples Makefile.relnotesng Log: Update for this being the 6.2-RELEASE branch. Approved by: re (implicit) Revision Changes Path 1.11.2.1.6.1 +1 -1 src/release/doc/share/examples/Makefile.relnotesng From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:33:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A27EC16A403; Wed, 15 Nov 2006 21:33:28 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91EF543D45; Wed, 15 Nov 2006 21:33:25 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLXPqT086127; Wed, 15 Nov 2006 21:33:25 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLXP0g086125; Wed, 15 Nov 2006 21:33:25 GMT (envelope-from kensmith) Message-Id: <200611152133.kAFLXP0g086125@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:33:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/share/sgml release.ent X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:33:28 -0000 kensmith 2006-11-15 21:33:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/share/sgml release.ent Log: Updates for this being the 6.2-RELEASE branch. Approved by: re (implicit) Revision Changes Path 1.24.2.5.2.1 +3 -3 src/release/doc/share/sgml/release.ent From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:35:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73D4916A403; Wed, 15 Nov 2006 21:35:51 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CAD043D6E; Wed, 15 Nov 2006 21:35:51 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLZpMV086669; Wed, 15 Nov 2006 21:35:51 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLZpJ0086668; Wed, 15 Nov 2006 21:35:51 GMT (envelope-from kensmith) Message-Id: <200611152135.kAFLZpJ0086668@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:35:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/share/examples/cvsup standard-supfile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:35:51 -0000 kensmith 2006-11-15 21:35:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) share/examples/cvsup standard-supfile Log: Update the branch tag cvsup will use. Approved by: re (implicit) Revision Changes Path 1.23.4.2.4.1 +1 -1 src/share/examples/cvsup/standard-supfile From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:37:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F48F16A403; Wed, 15 Nov 2006 21:37:52 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23BD943D53; Wed, 15 Nov 2006 21:37:52 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLbqPV086755; Wed, 15 Nov 2006 21:37:52 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLbpJp086754; Wed, 15 Nov 2006 21:37:51 GMT (envelope-from kensmith) Message-Id: <200611152137.kAFLbpJp086754@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:37:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:37:52 -0000 kensmith 2006-11-15 21:37:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) sys/sys param.h Log: Adjust __FreeBSD_version for this being a release branch. Approved by: re (implicit) Revision Changes Path 1.244.2.17.2.1 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:40:07 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 838D516A403; Wed, 15 Nov 2006 21:40:07 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9B6D43D73; Wed, 15 Nov 2006 21:40:06 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLe6Y9086856; Wed, 15 Nov 2006 21:40:06 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLe6kP086854; Wed, 15 Nov 2006 21:40:06 GMT (envelope-from kensmith) Message-Id: <200611152140.kAFLe6kP086854@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 21:40:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:40:07 -0000 kensmith 2006-11-15 21:40:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) sys/conf newvers.sh Log: Get ready for RC1 builds. Approved by: re (implicit) Revision Changes Path 1.69.2.13.2.1 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:42:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D13DE16A47B; Wed, 15 Nov 2006 21:42:00 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7026B43D66; Wed, 15 Nov 2006 21:42:00 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLg0uC087641; Wed, 15 Nov 2006 21:42:00 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLg0jM087639; Wed, 15 Nov 2006 21:42:00 GMT (envelope-from jb) Message-Id: <200611152142.kAFLg0jM087639@repoman.freebsd.org> From: John Birrell Date: Wed, 15 Nov 2006 21:42:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:42:00 -0000 jb 2006-11-15 21:42:00 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: Get the parent dma tag if one exists. This is required on sun4v. Other arches will default to NULL if they have no parent. Reviewed by: mjacob Revision Changes Path 1.41 +2 -2 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:46:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01A6216A407; Wed, 15 Nov 2006 21:46:41 +0000 (UTC) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3A7843D8F; Wed, 15 Nov 2006 21:46:37 +0000 (GMT) (envelope-from jb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFLkbcJ088402; Wed, 15 Nov 2006 21:46:37 GMT (envelope-from jb@repoman.freebsd.org) Received: (from jb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFLkbMj088401; Wed, 15 Nov 2006 21:46:37 GMT (envelope-from jb) Message-Id: <200611152146.kAFLkbMj088401@repoman.freebsd.org> From: John Birrell Date: Wed, 15 Nov 2006 21:46:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt.c mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:46:41 -0000 jb 2006-11-15 21:46:37 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.c mpt_cam.c Log: Add big endian support. Submitted by: scottl Reviewed by: mjacob Revision Changes Path 1.36 +23 -14 src/sys/dev/mpt/mpt.c 1.38 +62 -47 src/sys/dev/mpt/mpt_cam.c From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:51:44 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01F6116A412; Wed, 15 Nov 2006 21:51:44 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52AE043DC2; Wed, 15 Nov 2006 21:50:56 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAFLokEH001707; Wed, 15 Nov 2006 13:50:56 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAFLokqZ001704; Wed, 15 Nov 2006 13:50:46 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 13:50:46 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: John Baldwin In-Reply-To: <200611151617.23125.jhb@freebsd.org> Message-ID: <20061115134949.T1700@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:51:44 -0000 Sorry- should have said "broader testing", which would include FC 4Gb cards. > On Wednesday 15 November 2006 15:18, Matt Jacob wrote: >> mjacob 2006-11-15 20:18:09 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/mpt mpt_pci.c >> Log: >> Turn off MSI until some testing is done. >> >> Revision Changes Path >> 1.40 +2 -0 src/sys/dev/mpt/mpt_pci.c > > Works great here on the box I tested it on with both MSI and MSI-X, so it > wasn't untested. > > -- > John Baldwin > From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:52:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17BFB16A4A0; Wed, 15 Nov 2006 21:52:23 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 912A743DE8; Wed, 15 Nov 2006 21:51:20 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 200E85FEF; Thu, 16 Nov 2006 00:51:18 +0300 (MSK) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id F28545F70; Thu, 16 Nov 2006 00:51:17 +0300 (MSK) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id kAFLpJiS074763; Thu, 16 Nov 2006 00:51:19 +0300 (MSK) (envelope-from ru) Date: Thu, 16 Nov 2006 00:51:19 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20061115215119.GA74745@rambler-co.ru> References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <200611152004.kAFK4vfe058983@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:52:23 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > jhb 2006-11-15 20:04:57 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/bce if_bce.c=20 > sys/dev/em if_em.c if_em.h=20 > sys/dev/mpt mpt.h mpt_pci.c=20 > Log: > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > devices that support a maximum of 1 message, and we use that 1 message > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > =20 > Revision Changes Path > 1.19 +11 -3 src/sys/dev/bce/if_bce.c > 1.164 +11 -2 src/sys/dev/em/if_em.c > 1.56 +1 -0 src/sys/dev/em/if_em.h > 1.31 +1 -0 src/sys/dev/mpt/mpt.h > 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c >=20 How will the "vmstat -i" output look like for MSI-enabled devices? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFW4vXqRfpzJluFF4RAt8QAJ4hEPrNbo7uXgwTeYFdV8I1nURtjACggLIu EdZQWu4LKgeNPYtkNo5FY5o= =9G0F -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- From owner-cvs-src@FreeBSD.ORG Wed Nov 15 21:52:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28E9616A4D4; Wed, 15 Nov 2006 21:52:33 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D85243D97; Wed, 15 Nov 2006 21:51:42 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id E37505E11; Thu, 16 Nov 2006 00:51:41 +0300 (MSK) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id C0C235D63; Thu, 16 Nov 2006 00:51:41 +0300 (MSK) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id kAFLphK5074787; Thu, 16 Nov 2006 00:51:43 +0300 (MSK) (envelope-from ru) Date: Thu, 16 Nov 2006 00:51:43 +0300 From: Ruslan Ermilov To: John Baldwin Message-ID: <20061115215142.GB74745@rambler-co.ru> References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <20061115215119.GA74745@rambler-co.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="R3G7APHDIzY6R/pk" Content-Disposition: inline In-Reply-To: <20061115215119.GA74745@rambler-co.ru> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 21:52:33 -0000 --R3G7APHDIzY6R/pk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > > jhb 2006-11-15 20:04:57 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/dev/bce if_bce.c=20 > > sys/dev/em if_em.c if_em.h=20 > > sys/dev/mpt mpt.h mpt_pci.c=20 > > Log: > > Add MSI support to em(4), bce(4), and mpt(4). For now, we only suppo= rt > > devices that support a maximum of 1 message, and we use that 1 message > > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > > =20 > > Revision Changes Path > > 1.19 +11 -3 src/sys/dev/bce/if_bce.c > > 1.164 +11 -2 src/sys/dev/em/if_em.c > > 1.56 +1 -0 src/sys/dev/em/if_em.h > > 1.31 +1 -0 src/sys/dev/mpt/mpt.h > > 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > >=20 > How will the "vmstat -i" output look like for MSI-enabled devices? >=20 irqXXXX, where XXXX>=3D1024? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --R3G7APHDIzY6R/pk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFW4vuqRfpzJluFF4RApxaAJ4hUB0GifdQ+OhxsF7dApoUK8iudACePF0I rf71XlgoNdIDjjXXFA0dFbo= =Ugz3 -----END PGP SIGNATURE----- --R3G7APHDIzY6R/pk-- From owner-cvs-src@FreeBSD.ORG Wed Nov 15 22:19:20 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1780C16A4EA; Wed, 15 Nov 2006 22:19:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id E147C43D5E; Wed, 15 Nov 2006 22:19:01 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAFMIwWj034803; Wed, 15 Nov 2006 17:18:58 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ruslan Ermilov Date: Wed, 15 Nov 2006 17:18:55 -0500 User-Agent: KMail/1.9.1 References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <20061115215119.GA74745@rambler-co.ru> <20061115215142.GB74745@rambler-co.ru> In-Reply-To: <20061115215142.GB74745@rambler-co.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611151718.56506.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 15 Nov 2006 17:18:58 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2197/Wed Nov 15 15:23:52 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:19:20 -0000 On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: > On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > > On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > > > jhb 2006-11-15 20:04:57 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/bce if_bce.c > > > sys/dev/em if_em.c if_em.h > > > sys/dev/mpt mpt.h mpt_pci.c > > > Log: > > > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > > > devices that support a maximum of 1 message, and we use that 1 message > > > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > > > > > > Revision Changes Path > > > 1.19 +11 -3 src/sys/dev/bce/if_bce.c > > > 1.164 +11 -2 src/sys/dev/em/if_em.c > > > 1.56 +1 -0 src/sys/dev/em/if_em.h > > > 1.31 +1 -0 src/sys/dev/mpt/mpt.h > > > 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > > > > > How will the "vmstat -i" output look like for MSI-enabled devices? > > > irqXXXX, where XXXX>=1024? s/1024/256/ -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Nov 15 22:21:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E09916A492; Wed, 15 Nov 2006 22:21:53 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11FB543D88; Wed, 15 Nov 2006 22:20:59 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAFMKxi0094927; Wed, 15 Nov 2006 22:20:59 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAFMKxf4094926; Wed, 15 Nov 2006 22:20:59 GMT (envelope-from kensmith) Message-Id: <200611152220.kAFMKxf4094926@repoman.freebsd.org> From: Ken Smith Date: Wed, 15 Nov 2006 22:20:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/share/sgml release.ent X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:21:53 -0000 kensmith 2006-11-15 22:20:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/share/sgml release.ent Log: Missed a piece that needs to be adjusted when shifting from a development branch to a release branch. Poked by: bmah Approved by: re (implicit) Revision Changes Path 1.24.2.5.2.2 +2 -3 src/release/doc/share/sgml/release.ent From owner-cvs-src@FreeBSD.ORG Wed Nov 15 22:36:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98BD316A4E6; Wed, 15 Nov 2006 22:36:11 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EA8743D72; Wed, 15 Nov 2006 22:35:49 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAFMZdon007537; Wed, 15 Nov 2006 15:35:44 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455B963A.4050200@samsco.org> Date: Wed, 15 Nov 2006 15:35:38 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: John Baldwin References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <20061115215119.GA74745@rambler-co.ru> <20061115215142.GB74745@rambler-co.ru> <200611151718.56506.jhb@freebsd.org> In-Reply-To: <200611151718.56506.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:36:11 -0000 John Baldwin wrote: > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: >>>> jhb 2006-11-15 20:04:57 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/bce if_bce.c >>>> sys/dev/em if_em.c if_em.h >>>> sys/dev/mpt mpt.h mpt_pci.c >>>> Log: >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > support >>>> devices that support a maximum of 1 message, and we use that 1 message >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. >>>> >>>> Revision Changes Path >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c >>>> >>> How will the "vmstat -i" output look like for MSI-enabled devices? >>> >> irqXXXX, where XXXX>=1024? > > s/1024/256/ > There is a problem here, though. Newbus prints out the IRQ number after a successful device probe phase. It has no knowledge of MSI at that point, so it just prints out the traditional IRQ value. At some point, this needs to be fixed. Having the driver tell newbus about its MSI intentions in the probe routine is unrealistic, so there is no quick fix there. Probably need to delay printing the device message until later in the attach routine, once the driver has set up all of the resources. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 15 22:51:44 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4A2416A40F; Wed, 15 Nov 2006 22:51:44 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 497B643D60; Wed, 15 Nov 2006 22:51:44 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAFMp4Rn054195; Wed, 15 Nov 2006 15:51:04 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 15 Nov 2006 15:51:43 -0700 (MST) Message-Id: <20061115.155143.1021575615.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <455B963A.4050200@samsco.org> References: <20061115215142.GB74745@rambler-co.ru> <200611151718.56506.jhb@freebsd.org> <455B963A.4050200@samsco.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 15 Nov 2006 15:51:05 -0700 (MST) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, jhb@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:51:44 -0000 In message: <455B963A.4050200@samsco.org> Scott Long writes: : John Baldwin wrote: : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: : >>>> jhb 2006-11-15 20:04:57 UTC : >>>> : >>>> FreeBSD src repository : >>>> : >>>> Modified files: : >>>> sys/dev/bce if_bce.c : >>>> sys/dev/em if_em.c if_em.h : >>>> sys/dev/mpt mpt.h mpt_pci.c : >>>> Log: : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only : > support : >>>> devices that support a maximum of 1 message, and we use that 1 message : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. : >>>> : >>>> Revision Changes Path : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c : >>>> : >>> How will the "vmstat -i" output look like for MSI-enabled devices? : >>> : >> irqXXXX, where XXXX>=1024? : > : > s/1024/256/ : > : : There is a problem here, though. Newbus prints out the IRQ number after : a successful device probe phase. It has no knowledge of MSI at that : point, so it just prints out the traditional IRQ value. At some point, : this needs to be fixed. Having the driver tell newbus about its MSI : intentions in the probe routine is unrealistic, so there is no quick : fix there. Probably need to delay printing the device message until : later in the attach routine, once the driver has set up all of the : resources. I've been wanting to move the printing of the attach string from post-probe, pre-attach to post-attach for some time now. We would then report the resources assigned to the device. I'm not sure if I'd print all the resources assigned, or only those the driver activates. Both sides of the argument have merit, imho. On the pro side, resources are used, and printing them will help highlight conflicts. On the con side, people think it clutters things up too much and might lead to false expectations. When I've mentioned this desire at various developer summits, I was told basically "go for it, but only at freebsd X.0 since people have dmesg parsers" by many people (maybe even including Scott). Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 15 22:56:47 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8C8716A415; Wed, 15 Nov 2006 22:56:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0540043D6A; Wed, 15 Nov 2006 22:56:46 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAFMub0O035027; Wed, 15 Nov 2006 17:56:38 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Wed, 15 Nov 2006 17:56:30 -0500 User-Agent: KMail/1.9.1 References: <20061115215142.GB74745@rambler-co.ru> <455B963A.4050200@samsco.org> <20061115.155143.1021575615.imp@bsdimp.com> In-Reply-To: <20061115.155143.1021575615.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611151756.31047.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 15 Nov 2006 17:56:38 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2197/Wed Nov 15 15:23:52 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, scottl@samsco.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:56:47 -0000 On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: > In message: <455B963A.4050200@samsco.org> > Scott Long writes: > : John Baldwin wrote: > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > : >>>> jhb 2006-11-15 20:04:57 UTC > : >>>> > : >>>> FreeBSD src repository > : >>>> > : >>>> Modified files: > : >>>> sys/dev/bce if_bce.c > : >>>> sys/dev/em if_em.c if_em.h > : >>>> sys/dev/mpt mpt.h mpt_pci.c > : >>>> Log: > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > : > support > : >>>> devices that support a maximum of 1 message, and we use that 1 message > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > : >>>> > : >>>> Revision Changes Path > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > : >>>> > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? > : >>> > : >> irqXXXX, where XXXX>=1024? > : > > : > s/1024/256/ > : > > : > : There is a problem here, though. Newbus prints out the IRQ number after > : a successful device probe phase. It has no knowledge of MSI at that > : point, so it just prints out the traditional IRQ value. At some point, > : this needs to be fixed. Having the driver tell newbus about its MSI > : intentions in the probe routine is unrealistic, so there is no quick > : fix there. Probably need to delay printing the device message until > : later in the attach routine, once the driver has set up all of the > : resources. > > I've been wanting to move the printing of the attach string from > post-probe, pre-attach to post-attach for some time now. We would > then report the resources assigned to the device. I'm not sure if I'd > print all the resources assigned, or only those the driver activates. > Both sides of the argument have merit, imho. On the pro side, > resources are used, and printing them will help highlight conflicts. > On the con side, people think it clutters things up too much and might > lead to false expectations. > > When I've mentioned this desire at various developer summits, I was > told basically "go for it, but only at freebsd X.0 since people have > dmesg parsers" by many people (maybe even including Scott). Also, the way it works now, if attach fails and the routine prints out error messages, you get to see line for the device first with the initial resources and then you see the error message from the driver. If you move the printf down, then all you get is an error message from the driver. At the very least this would break POLA for a lot of our users. I'm still undecided. I could add a printf when a device ends up succesfully allocating MSI or MSI-X IRQs if people desired. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:05:46 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFCC216A415; Wed, 15 Nov 2006 23:05:45 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4ECF443D55; Wed, 15 Nov 2006 23:05:45 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAFN5ae9007707; Wed, 15 Nov 2006 16:05:41 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455B9D3F.5010703@samsco.org> Date: Wed, 15 Nov 2006 16:05:35 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: John Baldwin References: <20061115215142.GB74745@rambler-co.ru> <455B963A.4050200@samsco.org> <20061115.155143.1021575615.imp@bsdimp.com> <200611151756.31047.jhb@freebsd.org> In-Reply-To: <200611151756.31047.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:05:46 -0000 John Baldwin wrote: > On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: >> In message: <455B963A.4050200@samsco.org> >> Scott Long writes: >> : John Baldwin wrote: >> : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: >> : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: >> : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: >> : >>>> jhb 2006-11-15 20:04:57 UTC >> : >>>> >> : >>>> FreeBSD src repository >> : >>>> >> : >>>> Modified files: >> : >>>> sys/dev/bce if_bce.c >> : >>>> sys/dev/em if_em.c if_em.h >> : >>>> sys/dev/mpt mpt.h mpt_pci.c >> : >>>> Log: >> : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only >> : > support >> : >>>> devices that support a maximum of 1 message, and we use that 1 > message >> : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. >> : >>>> >> : >>>> Revision Changes Path >> : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c >> : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c >> : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h >> : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h >> : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c >> : >>>> >> : >>> How will the "vmstat -i" output look like for MSI-enabled devices? >> : >>> >> : >> irqXXXX, where XXXX>=1024? >> : > >> : > s/1024/256/ >> : > >> : >> : There is a problem here, though. Newbus prints out the IRQ number after >> : a successful device probe phase. It has no knowledge of MSI at that >> : point, so it just prints out the traditional IRQ value. At some point, >> : this needs to be fixed. Having the driver tell newbus about its MSI >> : intentions in the probe routine is unrealistic, so there is no quick >> : fix there. Probably need to delay printing the device message until >> : later in the attach routine, once the driver has set up all of the >> : resources. >> >> I've been wanting to move the printing of the attach string from >> post-probe, pre-attach to post-attach for some time now. We would >> then report the resources assigned to the device. I'm not sure if I'd >> print all the resources assigned, or only those the driver activates. >> Both sides of the argument have merit, imho. On the pro side, >> resources are used, and printing them will help highlight conflicts. >> On the con side, people think it clutters things up too much and might >> lead to false expectations. >> >> When I've mentioned this desire at various developer summits, I was >> told basically "go for it, but only at freebsd X.0 since people have >> dmesg parsers" by many people (maybe even including Scott). > > Also, the way it works now, if attach fails and the routine prints out error > messages, you get to see line for the device first with the initial resources > and then you see the error message from the driver. If you move the printf > down, then all you get is an error message from the driver. At the very > least this would break POLA for a lot of our users. I'm still undecided. > I could add a printf when a device ends up succesfully allocating MSI or MSI-X > IRQs if people desired. > As unpleasant as this is, I think it needs to be up to the driver to print the line, since John is correct about having informational and error messages come after the device message instead of before. This means changing every driver to intentionally call a method to do the printf. Ugly. An alternative might be to add magic to device_printf() so that anything printed through it gets buffered and delayed until after the attach routine completes (successfully or not). Once it completes, the device info line gets printed out with the actual resources (subject to what Warner is saying), and then all of the buffered device_printfs get dumped out. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:09:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8518E16A407; Wed, 15 Nov 2006 23:09:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CDC243D5C; Wed, 15 Nov 2006 23:09:40 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAFN7gEO054472; Wed, 15 Nov 2006 16:07:43 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 15 Nov 2006 16:08:21 -0700 (MST) Message-Id: <20061115.160821.1973602865.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200611151756.31047.jhb@freebsd.org> References: <455B963A.4050200@samsco.org> <20061115.155143.1021575615.imp@bsdimp.com> <200611151756.31047.jhb@freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 15 Nov 2006 16:07:44 -0700 (MST) Cc: cvs-src@freebsd.org, scottl@samsco.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:09:40 -0000 In message: <200611151756.31047.jhb@freebsd.org> John Baldwin writes: : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: : > In message: <455B963A.4050200@samsco.org> : > Scott Long writes: : > : John Baldwin wrote: : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: : > : >>>> jhb 2006-11-15 20:04:57 UTC : > : >>>> : > : >>>> FreeBSD src repository : > : >>>> : > : >>>> Modified files: : > : >>>> sys/dev/bce if_bce.c : > : >>>> sys/dev/em if_em.c if_em.h : > : >>>> sys/dev/mpt mpt.h mpt_pci.c : > : >>>> Log: : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only : > : > support : > : >>>> devices that support a maximum of 1 message, and we use that 1 : message : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. : > : >>>> : > : >>>> Revision Changes Path : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c : > : >>>> : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? : > : >>> : > : >> irqXXXX, where XXXX>=1024? : > : > : > : > s/1024/256/ : > : > : > : : > : There is a problem here, though. Newbus prints out the IRQ number after : > : a successful device probe phase. It has no knowledge of MSI at that : > : point, so it just prints out the traditional IRQ value. At some point, : > : this needs to be fixed. Having the driver tell newbus about its MSI : > : intentions in the probe routine is unrealistic, so there is no quick : > : fix there. Probably need to delay printing the device message until : > : later in the attach routine, once the driver has set up all of the : > : resources. : > : > I've been wanting to move the printing of the attach string from : > post-probe, pre-attach to post-attach for some time now. We would : > then report the resources assigned to the device. I'm not sure if I'd : > print all the resources assigned, or only those the driver activates. : > Both sides of the argument have merit, imho. On the pro side, : > resources are used, and printing them will help highlight conflicts. : > On the con side, people think it clutters things up too much and might : > lead to false expectations. : > : > When I've mentioned this desire at various developer summits, I was : > told basically "go for it, but only at freebsd X.0 since people have : > dmesg parsers" by many people (maybe even including Scott). : : Also, the way it works now, if attach fails and the routine prints out error : messages, you get to see line for the device first with the initial resources : and then you see the error message from the driver. If you move the printf : down, then all you get is an error message from the driver. At the very : least this would break POLA for a lot of our users. I'm still undecided. : I could add a printf when a device ends up succesfully allocating MSI or MSI-X : IRQs if people desired. I'd prefer those be under bootverbose. I think the real answer may be to get devinfo output to be real... Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:15:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D30016A40F; Wed, 15 Nov 2006 23:15:32 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3A7243D4C; Wed, 15 Nov 2006 23:15:30 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAFNE6hY054564; Wed, 15 Nov 2006 16:14:07 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 15 Nov 2006 16:14:45 -0700 (MST) Message-Id: <20061115.161445.43008442.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <455B9D3F.5010703@samsco.org> References: <20061115.155143.1021575615.imp@bsdimp.com> <200611151756.31047.jhb@freebsd.org> <455B9D3F.5010703@samsco.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 15 Nov 2006 16:14:09 -0700 (MST) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, ru@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:15:32 -0000 In message: <455B9D3F.5010703@samsco.org> Scott Long writes: : John Baldwin wrote: : > On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: : >> In message: <455B963A.4050200@samsco.org> : >> Scott Long writes: : >> : John Baldwin wrote: : >> : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: : >> : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: : >> : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: : >> : >>>> jhb 2006-11-15 20:04:57 UTC : >> : >>>> : >> : >>>> FreeBSD src repository : >> : >>>> : >> : >>>> Modified files: : >> : >>>> sys/dev/bce if_bce.c : >> : >>>> sys/dev/em if_em.c if_em.h : >> : >>>> sys/dev/mpt mpt.h mpt_pci.c : >> : >>>> Log: : >> : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only : >> : > support : >> : >>>> devices that support a maximum of 1 message, and we use that 1 : > message : >> : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. : >> : >>>> : >> : >>>> Revision Changes Path : >> : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c : >> : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c : >> : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h : >> : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h : >> : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c : >> : >>>> : >> : >>> How will the "vmstat -i" output look like for MSI-enabled devices? : >> : >>> : >> : >> irqXXXX, where XXXX>=1024? : >> : > : >> : > s/1024/256/ : >> : > : >> : : >> : There is a problem here, though. Newbus prints out the IRQ number after : >> : a successful device probe phase. It has no knowledge of MSI at that : >> : point, so it just prints out the traditional IRQ value. At some point, : >> : this needs to be fixed. Having the driver tell newbus about its MSI : >> : intentions in the probe routine is unrealistic, so there is no quick : >> : fix there. Probably need to delay printing the device message until : >> : later in the attach routine, once the driver has set up all of the : >> : resources. : >> : >> I've been wanting to move the printing of the attach string from : >> post-probe, pre-attach to post-attach for some time now. We would : >> then report the resources assigned to the device. I'm not sure if I'd : >> print all the resources assigned, or only those the driver activates. : >> Both sides of the argument have merit, imho. On the pro side, : >> resources are used, and printing them will help highlight conflicts. : >> On the con side, people think it clutters things up too much and might : >> lead to false expectations. : >> : >> When I've mentioned this desire at various developer summits, I was : >> told basically "go for it, but only at freebsd X.0 since people have : >> dmesg parsers" by many people (maybe even including Scott). : > : > Also, the way it works now, if attach fails and the routine prints out error : > messages, you get to see line for the device first with the initial resources : > and then you see the error message from the driver. If you move the printf : > down, then all you get is an error message from the driver. At the very : > least this would break POLA for a lot of our users. I'm still undecided. : > I could add a printf when a device ends up succesfully allocating MSI or MSI-X : > IRQs if people desired. : > : : As unpleasant as this is, I think it needs to be up to the driver to : print the line, since John is correct about having informational and : error messages come after the device message instead of before. This : means changing every driver to intentionally call a method to do the : printf. Ugly. I think that's too ugly to contemplate... One of the main reasons it is done in the parent bus now is that too many drivers got it wrong, or had different notions of what they thought "right" output should be. : An alternative might be to add magic to device_printf() so that anything : printed through it gets buffered and delayed until after the attach : routine completes (successfully or not). Once it completes, the : device info line gets printed out with the actual resources (subject to : what Warner is saying), and then all of the buffered device_printfs get : dumped out. I'm not sure this is much better. Another problem with doing after rather than before is hangs. Right now if the fxp driver is wedging my system on attach, I get to see the fxp driver's dmesg line as the last thing before the wedge. If we move to after, or driver prints, this line wouldn't appear. Another option would be to omit resources entirely and go to a two line dmesg. First line would be location, second line would be resources (maybe hidden under bootverbose). Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:20:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5AB0E16A403; Wed, 15 Nov 2006 23:20:40 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7826943D86; Wed, 15 Nov 2006 23:20:32 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAFNKNHX007779; Wed, 15 Nov 2006 16:20:29 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BA0B6.1000109@samsco.org> Date: Wed, 15 Nov 2006 16:20:22 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: "M. Warner Losh" References: <455B963A.4050200@samsco.org> <20061115.155143.1021575615.imp@bsdimp.com> <200611151756.31047.jhb@freebsd.org> <20061115.160821.1973602865.imp@bsdimp.com> In-Reply-To: <20061115.160821.1973602865.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, jhb@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:20:40 -0000 M. Warner Losh wrote: > In message: <200611151756.31047.jhb@freebsd.org> > John Baldwin writes: > : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: > : > In message: <455B963A.4050200@samsco.org> > : > Scott Long writes: > : > : John Baldwin wrote: > : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: > : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > : > : >>>> jhb 2006-11-15 20:04:57 UTC > : > : >>>> > : > : >>>> FreeBSD src repository > : > : >>>> > : > : >>>> Modified files: > : > : >>>> sys/dev/bce if_bce.c > : > : >>>> sys/dev/em if_em.c if_em.h > : > : >>>> sys/dev/mpt mpt.h mpt_pci.c > : > : >>>> Log: > : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > : > : > support > : > : >>>> devices that support a maximum of 1 message, and we use that 1 > : message > : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > : > : >>>> > : > : >>>> Revision Changes Path > : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c > : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c > : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h > : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h > : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > : > : >>>> > : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? > : > : >>> > : > : >> irqXXXX, where XXXX>=1024? > : > : > > : > : > s/1024/256/ > : > : > > : > : > : > : There is a problem here, though. Newbus prints out the IRQ number after > : > : a successful device probe phase. It has no knowledge of MSI at that > : > : point, so it just prints out the traditional IRQ value. At some point, > : > : this needs to be fixed. Having the driver tell newbus about its MSI > : > : intentions in the probe routine is unrealistic, so there is no quick > : > : fix there. Probably need to delay printing the device message until > : > : later in the attach routine, once the driver has set up all of the > : > : resources. > : > > : > I've been wanting to move the printing of the attach string from > : > post-probe, pre-attach to post-attach for some time now. We would > : > then report the resources assigned to the device. I'm not sure if I'd > : > print all the resources assigned, or only those the driver activates. > : > Both sides of the argument have merit, imho. On the pro side, > : > resources are used, and printing them will help highlight conflicts. > : > On the con side, people think it clutters things up too much and might > : > lead to false expectations. > : > > : > When I've mentioned this desire at various developer summits, I was > : > told basically "go for it, but only at freebsd X.0 since people have > : > dmesg parsers" by many people (maybe even including Scott). > : > : Also, the way it works now, if attach fails and the routine prints out error > : messages, you get to see line for the device first with the initial resources > : and then you see the error message from the driver. If you move the printf > : down, then all you get is an error message from the driver. At the very > : least this would break POLA for a lot of our users. I'm still undecided. > : I could add a printf when a device ends up succesfully allocating MSI or MSI-X > : IRQs if people desired. > > I'd prefer those be under bootverbose. > > I think the real answer may be to get devinfo output to be real... > > Warner Yeah, the resource info really is superfluous during boot. It looks cool in the old-school unix way, but that's about it. Maybe it's time to change newbus to only print the driver name and driver-supplied description after the probe phase, like you hint at. newbus could then print resource info as the driver activates it, if bootverbose is set. I'd support something like this for 7.0, even if devinfo doesn't get fully fixed. If MSI gets merged to RELENG_6, then we'll just have to live with the incorrect newbus prints. So for example, I would change this: atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 31.2 on pci0 into: atapci0: at device 31.2 on pci0 Calls to bus_activate_resouce/bus_alloc_resource(RF_ACTIVE) could then print the various resources, contingent on bootverbose being set. This would make the ugly [GIANT_LOCKED] and [FAST] messages that get printed right now have a chance of being more consistent. Scott From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:51:31 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3DE516A417; Wed, 15 Nov 2006 23:51:31 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22A6943D4C; Wed, 15 Nov 2006 23:51:30 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAFNoIk2054945; Wed, 15 Nov 2006 16:50:19 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 15 Nov 2006 16:50:57 -0700 (MST) Message-Id: <20061115.165057.-1632628388.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <455BA0B6.1000109@samsco.org> References: <200611151756.31047.jhb@freebsd.org> <20061115.160821.1973602865.imp@bsdimp.com> <455BA0B6.1000109@samsco.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 15 Nov 2006 16:50:20 -0700 (MST) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, jhb@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:51:31 -0000 In message: <455BA0B6.1000109@samsco.org> Scott Long writes: : M. Warner Losh wrote: : > In message: <200611151756.31047.jhb@freebsd.org> : > John Baldwin writes: : > : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: : > : > In message: <455B963A.4050200@samsco.org> : > : > Scott Long writes: : > : > : John Baldwin wrote: : > : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: : > : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: : > : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: : > : > : >>>> jhb 2006-11-15 20:04:57 UTC : > : > : >>>> : > : > : >>>> FreeBSD src repository : > : > : >>>> : > : > : >>>> Modified files: : > : > : >>>> sys/dev/bce if_bce.c : > : > : >>>> sys/dev/em if_em.c if_em.h : > : > : >>>> sys/dev/mpt mpt.h mpt_pci.c : > : > : >>>> Log: : > : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only : > : > : > support : > : > : >>>> devices that support a maximum of 1 message, and we use that 1 : > : message : > : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. : > : > : >>>> : > : > : >>>> Revision Changes Path : > : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c : > : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c : > : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h : > : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h : > : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c : > : > : >>>> : > : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? : > : > : >>> : > : > : >> irqXXXX, where XXXX>=1024? : > : > : > : > : > : > s/1024/256/ : > : > : > : > : > : : > : > : There is a problem here, though. Newbus prints out the IRQ number after : > : > : a successful device probe phase. It has no knowledge of MSI at that : > : > : point, so it just prints out the traditional IRQ value. At some point, : > : > : this needs to be fixed. Having the driver tell newbus about its MSI : > : > : intentions in the probe routine is unrealistic, so there is no quick : > : > : fix there. Probably need to delay printing the device message until : > : > : later in the attach routine, once the driver has set up all of the : > : > : resources. : > : > : > : > I've been wanting to move the printing of the attach string from : > : > post-probe, pre-attach to post-attach for some time now. We would : > : > then report the resources assigned to the device. I'm not sure if I'd : > : > print all the resources assigned, or only those the driver activates. : > : > Both sides of the argument have merit, imho. On the pro side, : > : > resources are used, and printing them will help highlight conflicts. : > : > On the con side, people think it clutters things up too much and might : > : > lead to false expectations. : > : > : > : > When I've mentioned this desire at various developer summits, I was : > : > told basically "go for it, but only at freebsd X.0 since people have : > : > dmesg parsers" by many people (maybe even including Scott). : > : : > : Also, the way it works now, if attach fails and the routine prints out error : > : messages, you get to see line for the device first with the initial resources : > : and then you see the error message from the driver. If you move the printf : > : down, then all you get is an error message from the driver. At the very : > : least this would break POLA for a lot of our users. I'm still undecided. : > : I could add a printf when a device ends up succesfully allocating MSI or MSI-X : > : IRQs if people desired. : > : > I'd prefer those be under bootverbose. : > : > I think the real answer may be to get devinfo output to be real... : > : > Warner : : Yeah, the resource info really is superfluous during boot. It looks : cool in the old-school unix way, but that's about it. Maybe it's time : to change newbus to only print the driver name and driver-supplied : description after the probe phase, like you hint at. newbus could then : print resource info as the driver activates it, if bootverbose is set. : I'd support something like this for 7.0, even if devinfo doesn't get : fully fixed. If MSI gets merged to RELENG_6, then we'll just have to : live with the incorrect newbus prints. : : So for example, I would change this: : : atapci0: port : 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 31.2 on pci0 : : into: : : atapci0: at device 31.2 on pci0 That's exactly what I'm thinking too. Glad to see we're on the same page. : Calls to bus_activate_resouce/bus_alloc_resource(RF_ACTIVE) could then : print the various resources, contingent on bootverbose being set. This : would make the ugly [GIANT_LOCKED] and [FAST] messages that get printed : right now have a chance of being more consistent. I was thinking that if we printed things last, we could potentially eliminate them from normal use and just print them as part of the resources (optionally?): atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f irq 23 [FAST] or something similar... Warner From owner-cvs-src@FreeBSD.ORG Wed Nov 15 23:56:14 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE96316A407; Wed, 15 Nov 2006 23:56:14 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50C9643D55; Wed, 15 Nov 2006 23:56:14 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAFNu5rs008011; Wed, 15 Nov 2006 16:56:11 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BA914.7010602@samsco.org> Date: Wed, 15 Nov 2006 16:56:04 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: "M. Warner Losh" References: <200611151756.31047.jhb@freebsd.org> <20061115.160821.1973602865.imp@bsdimp.com> <455BA0B6.1000109@samsco.org> <20061115.165057.-1632628388.imp@bsdimp.com> In-Reply-To: <20061115.165057.-1632628388.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org, jhb@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 23:56:14 -0000 M. Warner Losh wrote: > In message: <455BA0B6.1000109@samsco.org> > Scott Long writes: > : M. Warner Losh wrote: > : > In message: <200611151756.31047.jhb@freebsd.org> > : > John Baldwin writes: > : > : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: > : > : > In message: <455B963A.4050200@samsco.org> > : > : > Scott Long writes: > : > : > : John Baldwin wrote: > : > : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: > : > : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > : > : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > : > : > : >>>> jhb 2006-11-15 20:04:57 UTC > : > : > : >>>> > : > : > : >>>> FreeBSD src repository > : > : > : >>>> > : > : > : >>>> Modified files: > : > : > : >>>> sys/dev/bce if_bce.c > : > : > : >>>> sys/dev/em if_em.c if_em.h > : > : > : >>>> sys/dev/mpt mpt.h mpt_pci.c > : > : > : >>>> Log: > : > : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > : > : > : > support > : > : > : >>>> devices that support a maximum of 1 message, and we use that 1 > : > : message > : > : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > : > : > : >>>> > : > : > : >>>> Revision Changes Path > : > : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c > : > : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c > : > : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h > : > : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h > : > : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > : > : > : >>>> > : > : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? > : > : > : >>> > : > : > : >> irqXXXX, where XXXX>=1024? > : > : > : > > : > : > : > s/1024/256/ > : > : > : > > : > : > : > : > : > : There is a problem here, though. Newbus prints out the IRQ number after > : > : > : a successful device probe phase. It has no knowledge of MSI at that > : > : > : point, so it just prints out the traditional IRQ value. At some point, > : > : > : this needs to be fixed. Having the driver tell newbus about its MSI > : > : > : intentions in the probe routine is unrealistic, so there is no quick > : > : > : fix there. Probably need to delay printing the device message until > : > : > : later in the attach routine, once the driver has set up all of the > : > : > : resources. > : > : > > : > : > I've been wanting to move the printing of the attach string from > : > : > post-probe, pre-attach to post-attach for some time now. We would > : > : > then report the resources assigned to the device. I'm not sure if I'd > : > : > print all the resources assigned, or only those the driver activates. > : > : > Both sides of the argument have merit, imho. On the pro side, > : > : > resources are used, and printing them will help highlight conflicts. > : > : > On the con side, people think it clutters things up too much and might > : > : > lead to false expectations. > : > : > > : > : > When I've mentioned this desire at various developer summits, I was > : > : > told basically "go for it, but only at freebsd X.0 since people have > : > : > dmesg parsers" by many people (maybe even including Scott). > : > : > : > : Also, the way it works now, if attach fails and the routine prints out error > : > : messages, you get to see line for the device first with the initial resources > : > : and then you see the error message from the driver. If you move the printf > : > : down, then all you get is an error message from the driver. At the very > : > : least this would break POLA for a lot of our users. I'm still undecided. > : > : I could add a printf when a device ends up succesfully allocating MSI or MSI-X > : > : IRQs if people desired. > : > > : > I'd prefer those be under bootverbose. > : > > : > I think the real answer may be to get devinfo output to be real... > : > > : > Warner > : > : Yeah, the resource info really is superfluous during boot. It looks > : cool in the old-school unix way, but that's about it. Maybe it's time > : to change newbus to only print the driver name and driver-supplied > : description after the probe phase, like you hint at. newbus could then > : print resource info as the driver activates it, if bootverbose is set. > : I'd support something like this for 7.0, even if devinfo doesn't get > : fully fixed. If MSI gets merged to RELENG_6, then we'll just have to > : live with the incorrect newbus prints. > : > : So for example, I would change this: > : > : atapci0: port > : 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 31.2 on pci0 > : > : into: > : > : atapci0: at device 31.2 on pci0 > > That's exactly what I'm thinking too. Glad to see we're on the same > page. > > : Calls to bus_activate_resouce/bus_alloc_resource(RF_ACTIVE) could then > : print the various resources, contingent on bootverbose being set. This > : would make the ugly [GIANT_LOCKED] and [FAST] messages that get printed > : right now have a chance of being more consistent. > > I was thinking that if we printed things last, we could potentially > eliminate them from normal use and just print them as part of the > resources (optionally?): > > atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f irq 23 [FAST] > > or something similar... > > Warner Sounds good. Beware that MSI makes it possible to have as many as 64 interrupts per device, though it's more common to have anywhere from 1 to 8. I'd probably split up your above line into 2 lines, one for memory resources and one for interrupt resources. Scott From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:31:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94CB116A403; Thu, 16 Nov 2006 00:31:47 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2969D43D55; Thu, 16 Nov 2006 00:31:47 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0VlPP019118; Thu, 16 Nov 2006 00:31:47 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0VlZj019117; Thu, 16 Nov 2006 00:31:47 GMT (envelope-from mjacob) Message-Id: <200611160031.kAG0VlZj019117@repoman.freebsd.org> From: Matt Jacob Date: Thu, 16 Nov 2006 00:31:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_library.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:31:47 -0000 mjacob 2006-11-16 00:31:46 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c isp_library.c Log: minor change to reduce some diff noise Revision Changes Path 1.130 +2 -1 src/sys/dev/isp/isp.c 1.8 +1 -1 src/sys/dev/isp/isp_library.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:40:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D74C416A412; Thu, 16 Nov 2006 00:40:01 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFF5743D5E; Thu, 16 Nov 2006 00:39:56 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0dupA020064; Thu, 16 Nov 2006 00:39:56 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0duDR020063; Thu, 16 Nov 2006 00:39:56 GMT (envelope-from mjacob) Message-Id: <200611160039.kAG0duDR020063@repoman.freebsd.org> From: Matt Jacob Date: Thu, 16 Nov 2006 00:39:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp.c isp_library.c ispmbox.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:40:01 -0000 mjacob 2006-11-16 00:39:56 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c isp_library.c ispmbox.h Log: Increase the timeout for some SAN commands. Only complain about FC Reponse errors if they're nonzero. Shorten some PortID printouts for local loop. Add an internal isp_xcmd_t data structure which we'll use for some CT-Passthru support as part of adding SMI-S. Revision Changes Path 1.131 +14 -8 src/sys/dev/isp/isp.c 1.9 +3 -3 src/sys/dev/isp/isp_library.c 1.54 +26 -0 src/sys/dev/isp/ispmbox.h From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:47:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36D4F16A403; Thu, 16 Nov 2006 00:47:32 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FD1943D53; Thu, 16 Nov 2006 00:47:31 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0lV42029604; Thu, 16 Nov 2006 00:47:31 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0lVQU029603; Thu, 16 Nov 2006 00:47:31 GMT (envelope-from imp) Message-Id: <200611160047.kAG0lVQU029603@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:47:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/boot2 boot2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:47:32 -0000 imp 2006-11-16 00:47:31 UTC FreeBSD src repository Modified files: sys/boot/arm/at91/boot2 boot2.c Log: Mfp4: We no longer need ee.h included here. Revision Changes Path 1.3 +0 -1 src/sys/boot/arm/at91/boot2/boot2.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:48:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CA1316A500; Thu, 16 Nov 2006 00:48:05 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08DBD43D5A; Thu, 16 Nov 2006 00:48:05 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0m4ZC029653; Thu, 16 Nov 2006 00:48:04 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0m4OU029652; Thu, 16 Nov 2006 00:48:04 GMT (envelope-from imp) Message-Id: <200611160048.kAG0m4OU029652@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:48:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/boot2 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:48:05 -0000 imp 2006-11-16 00:48:04 UTC FreeBSD src repository Modified files: sys/boot/arm/at91/boot2 Makefile Log: Tweaks for better boot flavor support. Revision Changes Path 1.3 +2 -5 src/sys/boot/arm/at91/boot2/Makefile From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:48:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E10516A407; Thu, 16 Nov 2006 00:48:54 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E268243D46; Thu, 16 Nov 2006 00:48:53 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0mrY9029706; Thu, 16 Nov 2006 00:48:53 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0mrFD029705; Thu, 16 Nov 2006 00:48:53 GMT (envelope-from imp) Message-Id: <200611160048.kAG0mrFD029705@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:48:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/boot0spi main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:48:54 -0000 imp 2006-11-16 00:48:53 UTC FreeBSD src repository Modified files: sys/boot/arm/at91/boot0spi main.c Log: MFp4: Improvements, including the ability to download to an arbitrary part of the spi flash. Revision Changes Path 1.4 +8 -5 src/sys/boot/arm/at91/boot0spi/main.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:49:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FECB16A4C9; Thu, 16 Nov 2006 00:49:51 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CD5343D5F; Thu, 16 Nov 2006 00:49:51 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0npiS029746; Thu, 16 Nov 2006 00:49:51 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0npHm029745; Thu, 16 Nov 2006 00:49:51 GMT (envelope-from imp) Message-Id: <200611160049.kAG0npHm029745@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:49:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/boot0iic main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:49:51 -0000 imp 2006-11-16 00:49:51 UTC FreeBSD src repository Modified files: sys/boot/arm/at91/boot0iic main.c Log: MFp4: Don't fix the size at 8k, and some minor cleanups. andre@ contributed to fixing this problem. Revision Changes Path 1.4 +11 -4 src/sys/boot/arm/at91/boot0iic/main.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:53:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C5FAE16A403; Thu, 16 Nov 2006 00:53:28 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E5E243D45; Thu, 16 Nov 2006 00:53:28 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0rSEL030975; Thu, 16 Nov 2006 00:53:28 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0rSP8030974; Thu, 16 Nov 2006 00:53:28 GMT (envelope-from imp) Message-Id: <200611160053.kAG0rSP8030974@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:53:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/boot0 Makefile arm_init.s src/sys/boot/arm/at91/boot0iic Makefile src/sys/boot/arm/at91/boot0spi Makefile src/sys/boot/arm/at91/bootiic Makefile arm_init.S src/sys/boot/arm/at91/bootspi Makefile arm_init.S ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:53:28 -0000 imp 2006-11-16 00:53:28 UTC FreeBSD src repository Modified files: sys/boot/arm/at91/boot0 Makefile sys/boot/arm/at91/boot0iic Makefile sys/boot/arm/at91/boot0spi Makefile sys/boot/arm/at91/bootiic Makefile sys/boot/arm/at91/bootspi Makefile Added files: sys/boot/arm/at91/libat91 arm_init.S Removed files: sys/boot/arm/at91/boot0 arm_init.s sys/boot/arm/at91/bootiic arm_init.S sys/boot/arm/at91/bootspi arm_init.S Log: Move to using a common arm_init.S. These things are more similar than different at this point. Revision Changes Path 1.5 +4 -1 src/sys/boot/arm/at91/boot0/Makefile 1.2 +0 -105 src/sys/boot/arm/at91/boot0/arm_init.s (dead) 1.3 +4 -2 src/sys/boot/arm/at91/boot0iic/Makefile 1.3 +3 -2 src/sys/boot/arm/at91/boot0spi/Makefile 1.5 +2 -2 src/sys/boot/arm/at91/bootiic/Makefile 1.3 +0 -120 src/sys/boot/arm/at91/bootiic/arm_init.S (dead) 1.6 +2 -1 src/sys/boot/arm/at91/bootspi/Makefile 1.4 +0 -129 src/sys/boot/arm/at91/bootspi/arm_init.S (dead) 1.1 +125 -0 src/sys/boot/arm/at91/libat91/arm_init.S (new) From owner-cvs-src@FreeBSD.ORG Thu Nov 16 00:55:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9020C16A403; Thu, 16 Nov 2006 00:55:36 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D7A643D79; Thu, 16 Nov 2006 00:55:27 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG0tOov031385; Thu, 16 Nov 2006 00:55:24 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG0tOQM031384; Thu, 16 Nov 2006 00:55:24 GMT (envelope-from imp) Message-Id: <200611160055.kAG0tOQM031384@repoman.freebsd.org> From: Warner Losh Date: Thu, 16 Nov 2006 00:55:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/arm/at91/libat91 mci_device.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 00:55:36 -0000 imp 2006-11-16 00:55:24 UTC FreeBSD src repository Removed files: sys/boot/arm/at91/libat91 mci_device.c Log: Mfp4: Remove mci_device.c. It should have been removed when it was merged ito sd-card.c, but this is an imperfect world. Revision Changes Path 1.3 +0 -575 src/sys/boot/arm/at91/libat91/mci_device.c (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 16 01:02:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13AF716A412; Thu, 16 Nov 2006 01:02:02 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0D6043D5D; Thu, 16 Nov 2006 01:02:00 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG120dI032468; Thu, 16 Nov 2006 01:02:00 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG120Ui032465; Thu, 16 Nov 2006 01:02:00 GMT (envelope-from pjd) Message-Id: <200611160102.kAG120Ui032465@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 16 Nov 2006 01:02:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_condvar.c kern_synch.c subr_sleepqueue.c src/sys/sys sleepqueue.h src/share/man/man9 sleepqueue.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 01:02:02 -0000 pjd 2006-11-16 01:02:00 UTC FreeBSD src repository Modified files: sys/kern kern_condvar.c kern_synch.c subr_sleepqueue.c sys/sys sleepqueue.h share/man/man9 sleepqueue.9 Log: Change sleepq_add(9) argument from 'struct mtx *' to 'struct lock_object *', which allows to use it with different kinds of locks. For example it allows to implement Solaris conditions variables which will be used in ZFS port on top of sx(9) locks. Reviewed by: jhb Revision Changes Path 1.13 +3 -3 src/share/man/man9/sleepqueue.9 1.56 +4 -4 src/sys/kern/kern_condvar.c 1.284 +3 -2 src/sys/kern/kern_synch.c 1.30 +3 -3 src/sys/kern/subr_sleepqueue.c 1.8 +2 -2 src/sys/sys/sleepqueue.h From owner-cvs-src@FreeBSD.ORG Thu Nov 16 02:40:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C1B816A407; Thu, 16 Nov 2006 02:40:19 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DED3543D49; Thu, 16 Nov 2006 02:40:18 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG2eIp6050175; Thu, 16 Nov 2006 02:40:18 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG2eID0050174; Thu, 16 Nov 2006 02:40:18 GMT (envelope-from mjacob) Message-Id: <200611160240.kAG2eID0050174@repoman.freebsd.org> From: Matt Jacob Date: Thu, 16 Nov 2006 02:40:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 02:40:19 -0000 mjacob 2006-11-16 02:40:18 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_pci.c Log: After tests on 2 different AMD platforms with several different cards (SAS, 4Gb FC), MSI seems to work with the cards. This was of some concern because some PCI cards claim to work with MSI but don't. Revision Changes Path 1.42 +0 -2 src/sys/dev/mpt/mpt_pci.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 03:30:44 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED77B16A412; Thu, 16 Nov 2006 03:30:44 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BB8243D46; Thu, 16 Nov 2006 03:30:44 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAG3UY5x007278; Wed, 15 Nov 2006 19:30:44 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAG3UYw7007275; Wed, 15 Nov 2006 19:30:34 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 19:30:34 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: John Baldwin In-Reply-To: <20061115134949.T1700@ns1.feral.com> Message-ID: <20061115192354.D7197@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 03:30:45 -0000 MSI/MSI-X seemed work with MPT for SAS, 4Gb FibreChannel on one system (SuperMicro Xeon) and 2Gb FibreChannel on another (4xdual core Opteron), but failed for onboard MPT on that system (dual core Opteron) mpt3: request 0xffffffff80e75050:96 timed out for ccb 0xffffff01433ec400 (req->ccb 0xffffff01433ec400) mpt3: completing timedout/aborted req 0xffffffff80e75050:96 mpt3: Timedout requests already complete. Interrupts may not be functioning. mpt2: request 0xffffffff80e67050:96 timed out for ccb 0xffffff0141c75c00 (req->ccb 0xffffff0141c75c00) mpt2: completing timedout/aborted req 0xffffffff80e67050:96 mpt2: Timedout requests already complete. Interrupts may not be functioning. MSI/MSI-X failed to work for the onboard em on the SuperMicro system. Given the (unselective) failure rate for me and the relatively small sample, but with two pretty widely used system types I'd like to suggest that you reconsider making the MSI and MSI-X being 'on' as the default. -matt > > > Sorry- should have said "broader testing", which would include FC 4Gb cards. > >> On Wednesday 15 November 2006 15:18, Matt Jacob wrote: >>> mjacob 2006-11-15 20:18:09 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/mpt mpt_pci.c >>> Log: >>> Turn off MSI until some testing is done. >>> >>> Revision Changes Path >>> 1.40 +2 -0 src/sys/dev/mpt/mpt_pci.c >> >> Works great here on the box I tested it on with both MSI and MSI-X, so it >> wasn't untested. >> >> -- >> John Baldwin >> > From owner-cvs-src@FreeBSD.ORG Thu Nov 16 03:35:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6D1916A4CA; Thu, 16 Nov 2006 03:35:39 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7629A43D8D; Thu, 16 Nov 2006 03:35:11 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAG3Z5HY010087; Wed, 15 Nov 2006 20:35:10 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BDC68.2080603@samsco.org> Date: Wed, 15 Nov 2006 20:35:04 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: mjacob@FreeBSD.org References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> In-Reply-To: <20061115192354.D7197@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 03:35:40 -0000 Could you please send the bootverbose output from these problem systems? Scott mjacob@FreeBSD.org wrote: > > > MSI/MSI-X seemed work with MPT for SAS, 4Gb FibreChannel on one system > (SuperMicro Xeon) and 2Gb FibreChannel on another (4xdual core Opteron), > but failed for onboard MPT on that system (dual core Opteron) > > mpt3: request 0xffffffff80e75050:96 timed out for ccb 0xffffff01433ec400 > (req->ccb 0xffffff01433ec400) > mpt3: completing timedout/aborted req 0xffffffff80e75050:96 > mpt3: Timedout requests already complete. Interrupts may not be > functioning. > mpt2: request 0xffffffff80e67050:96 timed out for ccb 0xffffff0141c75c00 > (req->ccb 0xffffff0141c75c00) > mpt2: completing timedout/aborted req 0xffffffff80e67050:96 > mpt2: Timedout requests already complete. Interrupts may not be > functioning. > > > MSI/MSI-X failed to work for the onboard em on the SuperMicro system. > > Given the (unselective) failure rate for me and the relatively small > sample, but with two pretty widely used system types I'd like to suggest > that you reconsider making the MSI and MSI-X being 'on' as the default. > > -matt > > >> >> >> Sorry- should have said "broader testing", which would include FC 4Gb >> cards. >> >>> On Wednesday 15 November 2006 15:18, Matt Jacob wrote: >>>> mjacob 2006-11-15 20:18:09 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/mpt mpt_pci.c >>>> Log: >>>> Turn off MSI until some testing is done. >>>> >>>> Revision Changes Path >>>> 1.40 +2 -0 src/sys/dev/mpt/mpt_pci.c >>> >>> Works great here on the box I tested it on with both MSI and MSI-X, >>> so it >>> wasn't untested. >>> >>> -- >>> John Baldwin >>> >> From owner-cvs-src@FreeBSD.ORG Thu Nov 16 03:45:59 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31A8416A416; Thu, 16 Nov 2006 03:45:59 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E37A343D7C; Thu, 16 Nov 2006 03:45:55 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAG3jja8007391; Wed, 15 Nov 2006 19:45:55 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAG3jjhs007388; Wed, 15 Nov 2006 19:45:45 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 19:45:45 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Scott Long In-Reply-To: <455BDC68.2080603@samsco.org> Message-ID: <20061115194305.M7355@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 03:45:59 -0000 > Could you please send the bootverbose output from these problem systems? Sure- I'll put the info up in http://people.freebsd.org/~mjacob shortly. Look- MSI is look a lot of other h/w features. It's been available in the h/w years before software has taken advantage of it, so the likelihood of older h/w just plain not working when s/w finally turns it on is pretty high. From owner-cvs-src@FreeBSD.ORG Thu Nov 16 03:49:20 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45DB716A40F; Thu, 16 Nov 2006 03:49:20 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4FBA043D45; Thu, 16 Nov 2006 03:49:19 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAG3nD42010207; Wed, 15 Nov 2006 20:49:18 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BDFB7.9040303@samsco.org> Date: Wed, 15 Nov 2006 20:49:11 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: mjacob@freebsd.org References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> In-Reply-To: <20061115194305.M7355@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 03:49:20 -0000 mjacob@freebsd.org wrote: > > >> Could you please send the bootverbose output from these problem systems? > > Sure- I'll put the info up in http://people.freebsd.org/~mjacob shortly. > > Look- MSI is look a lot of other h/w features. It's been available in > the h/w years before software has taken advantage of it, so the > likelihood of older h/w just plain not working when s/w finally turns it > on is pretty high. Agreed, just want to rule out software bugs first. Scott From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:01:57 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 432C816A415; Thu, 16 Nov 2006 04:01:57 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9909743D53; Thu, 16 Nov 2006 04:01:56 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAG41kVo007500; Wed, 15 Nov 2006 20:01:56 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAG41kx1007497; Wed, 15 Nov 2006 20:01:46 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 20:01:46 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Scott Long In-Reply-To: <455BDFB7.9040303@samsco.org> Message-ID: <20061115200109.U7495@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:01:57 -0000 see http://people.freebsd.org/~mjacob for 2 bootverbose files. From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:04:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C96816A403; Thu, 16 Nov 2006 04:04:08 +0000 (UTC) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C01B43D55; Thu, 16 Nov 2006 04:04:08 +0000 (GMT) (envelope-from jdp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG447pg066619; Thu, 16 Nov 2006 04:04:07 GMT (envelope-from jdp@repoman.freebsd.org) Received: (from jdp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG447gi066614; Thu, 16 Nov 2006 04:04:07 GMT (envelope-from jdp) Message-Id: <200611160404.kAG447gi066614@repoman.freebsd.org> From: John Polstra Date: Thu, 16 Nov 2006 04:04:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:04:08 -0000 jdp 2006-11-16 04:04:07 UTC FreeBSD src repository Modified files: sys/dev/bce if_bce.c Log: In bce_start_locked, check the used_tx_bd count rather than the descriptor's mbuf pointer to see if the transmit ring is full. The mbuf pointer is set only in the last descriptor of a multi-descriptor packet. By relying on the mbuf pointers of the earlier descriptors, the driver would sometimes overwrite a descriptor belonging to a packet that wasn't completed yet. Also, tx_chain_prod wasn't updated inside the loop, causing the wrong descriptor to be checked after the first iteration. The upshot of all this was the loss of some transmitted packets at medium to high packet rates. In bce_tx_encap, remove a couple of old statements that shuffled around the tx_mbuf_map pointers. These now correspond 1-to-1 with the transmit descriptors, and they are not supposed to be changed. Correct a couple of inaccurate comments. MFC after: 1 month Revision Changes Path 1.20 +8 -8 src/sys/dev/bce/if_bce.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:19:51 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64C1B16A407; Thu, 16 Nov 2006 04:19:51 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id D22DB43D4C; Thu, 16 Nov 2006 04:19:50 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAG4JinV010549; Wed, 15 Nov 2006 21:19:49 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BE6DF.4090907@samsco.org> Date: Wed, 15 Nov 2006 21:19:43 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: mjacob@freebsd.org References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> <20061115200109.U7495@ns1.feral.com> In-Reply-To: <20061115200109.U7495@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:19:51 -0000 mjacob@freebsd.org wrote: > > see http://people.freebsd.org/~mjacob for 2 bootverbose files. > > Ah, it looks like the MPT chips support 8 messages. I think that John's patch assumes only 1 message for it. For some devices, requesting 1 message when N are available will work, but it really is undefined behaviour and is dependent on the device to DTRT. So in your case, some of the MPT chips handled it well, some did not. Just out of curiosity, do you have any MPT docs that describe its MSI capabilities? In any case, it should probably be disabled in the MPT driver until we have a better understanding of how it works there. For your if_em problem, I'm not seeing what the problem is. It looks like em0 was successful at getting an IP address over DHCP, so I would assume that interrupts are working on it. Scott From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:24:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EDEE16A47C; Thu, 16 Nov 2006 04:24:59 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF6EA43D45; Thu, 16 Nov 2006 04:24:58 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG4Ow4F069945; Thu, 16 Nov 2006 04:24:58 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG4OwAP069944; Thu, 16 Nov 2006 04:24:58 GMT (envelope-from bmah) Message-Id: <200611160424.kAG4OwAP069944@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 16 Nov 2006 04:24:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/share/sgml release.ent X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:24:59 -0000 bmah 2006-11-16 04:24:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/share/sgml release.ent Log: Unbreak release notes build, caused by me giving incorrect information to kensmith@. The entities indicating the type of release are different between RELENG_5 and RELENG_6, although (in a moral sense) they should be the same. Approved by: re (implicitly) Pointy hat to: bmah Revision Changes Path 1.24.2.5.2.3 +1 -0 src/release/doc/share/sgml/release.ent From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:29:21 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC91E16A403; Thu, 16 Nov 2006 04:29:21 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 675E443D55; Thu, 16 Nov 2006 04:29:21 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAG4TBXM007736; Wed, 15 Nov 2006 20:29:21 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAG4TBeX007733; Wed, 15 Nov 2006 20:29:11 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 20:29:11 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Scott Long In-Reply-To: <455BE6DF.4090907@samsco.org> Message-ID: <20061115202136.K7698@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> <20061115200109.U7495@ns1.feral.com> <455BE6DF.4090907@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:29:22 -0000 On Wed, 15 Nov 2006, Scott Long wrote: > mjacob@freebsd.org wrote: >> >> see http://people.freebsd.org/~mjacob for 2 bootverbose files. >> >> > > Ah, it looks like the MPT chips support 8 messages. I think that > John's patch assumes only 1 message for it. No, John's patch will only enable MSI for a count of one. The PCI cards I have that support MSI are: AMD: QLogic 6312 (MSI 8) LSI-Logic 1030 (MSI 1) LSI-Logic 1030 (MSI 1) [ STUPID ME- The FC929 doesn't have MSI ] Broadcom NetXtreme (MSI 8) Broadcom NetXtreme (MSI 8) SuperMicro LSI-Logic 4Gb (MSI-1 MSI-X 1) LSI-Logic 4Gb (MSI-1 MSI-X 1) LSI-Logic SAS (MSI-1 MSI-X 1) QLogic 2422 4Gb (MSI 8) QLogic 2422 4Gb (MSI 8) em (MSI 1) I would guess you were looking at the one of the other devs. > For some devices, > requesting 1 message when N are available will work, but it really is > undefined behaviour and is dependent on the device to DTRT. So in your > case, some of the MPT chips handled it well, some did not. Just out of > curiosity, do you have any MPT docs that describe its MSI capabilities? > In any case, it should probably be disabled in the MPT driver until we > have a better understanding of how it works there. > > For your if_em problem, I'm not seeing what the problem is. It looks > like em0 was successful at getting an IP address over DHCP, so I would > assume that interrupts are working on it. Nope. That's why I included the change to disable msi in the boot verbose (there are two boot sessions there). You can have a *mostly* functional ethernet w/o interrupts functioning- you just get watchdog resets. From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:54:50 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52D4F16A47C; Thu, 16 Nov 2006 04:54:50 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id B04AD43D55; Thu, 16 Nov 2006 04:54:49 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAG4sddu007923; Wed, 15 Nov 2006 20:54:49 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAG4sbSj007920; Wed, 15 Nov 2006 20:54:39 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 15 Nov 2006 20:54:37 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: Scott Long In-Reply-To: <20061115202136.K7698@ns1.feral.com> Message-ID: <20061115205323.E7698@ns1.feral.com> References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> <20061115200109.U7495@ns1.feral.com> <455BE6DF.4090907@samsco.org> <20061115202136.K7698@ns1.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:54:50 -0000 Just to increase the population, I've included Dell 2850 (both i386 and amd64 instantiations) as a 'success' bootverbose logs with 5 distinct MPT devices each with MSI-1. -matt From owner-cvs-src@FreeBSD.ORG Thu Nov 16 04:58:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14EBE16A407; Thu, 16 Nov 2006 04:58:01 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F1A543D45; Thu, 16 Nov 2006 04:58:00 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAG4vrSn010778; Wed, 15 Nov 2006 21:57:59 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455BEFCF.5040606@samsco.org> Date: Wed, 15 Nov 2006 21:57:51 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: mjacob@freebsd.org References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> <20061115200109.U7495@ns1.feral.com> <455BE6DF.4090907@samsco.org> <20061115202136.K7698@ns1.feral.com> <20061115205323.E7698@ns1.feral.com> In-Reply-To: <20061115205323.E7698@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Scott Long , cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 04:58:01 -0000 mjacob@freebsd.org wrote: > > Just to increase the population, I've included Dell 2850 (both i386 and > amd64 instantiations) as a 'success' bootverbose logs with 5 distinct > MPT devices each with MSI-1. > > -matt > Thanks. The the bce and mfi devices on the Dell 2950 also work. The if_em device on my Intel 7520BD2 system also works. I haven't tested mpt on it yet, though. Scott From owner-cvs-src@FreeBSD.ORG Thu Nov 16 05:05:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D42CF16A407; Thu, 16 Nov 2006 05:05:44 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC7A443D88; Thu, 16 Nov 2006 05:05:35 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAG52rBi000972; Wed, 15 Nov 2006 22:02:53 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 15 Nov 2006 22:03:31 -0700 (MST) Message-Id: <20061115.220331.-957833409.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <455BA914.7010602@samsco.org> References: <455BA0B6.1000109@samsco.org> <20061115.165057.-1632628388.imp@bsdimp.com> <455BA914.7010602@samsco.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 15 Nov 2006 22:02:53 -0700 (MST) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, ru@FreeBSD.ORG, cvs-all@FreeBSD.ORG, jhb@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 05:05:44 -0000 In message: <455BA914.7010602@samsco.org> Scott Long writes: : M. Warner Losh wrote: : > In message: <455BA0B6.1000109@samsco.org> : > Scott Long writes: : > : M. Warner Losh wrote: : > : > In message: <200611151756.31047.jhb@freebsd.org> : > : > John Baldwin writes: : > : > : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: : > : > : > In message: <455B963A.4050200@samsco.org> : > : > : > Scott Long writes: : > : > : > : John Baldwin wrote: : > : > : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: : > : > : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: : > : > : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: : > : > : > : >>>> jhb 2006-11-15 20:04:57 UTC : > : > : > : >>>> : > : > : > : >>>> FreeBSD src repository : > : > : > : >>>> : > : > : > : >>>> Modified files: : > : > : > : >>>> sys/dev/bce if_bce.c : > : > : > : >>>> sys/dev/em if_em.c if_em.h : > : > : > : >>>> sys/dev/mpt mpt.h mpt_pci.c : > : > : > : >>>> Log: : > : > : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only : > : > : > : > support : > : > : > : >>>> devices that support a maximum of 1 message, and we use that 1 : > : > : message : > : > : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. : > : > : > : >>>> : > : > : > : >>>> Revision Changes Path : > : > : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c : > : > : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c : > : > : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h : > : > : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h : > : > : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c : > : > : > : >>>> : > : > : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? : > : > : > : >>> : > : > : > : >> irqXXXX, where XXXX>=1024? : > : > : > : > : > : > : > : > s/1024/256/ : > : > : > : > : > : > : > : : > : > : > : There is a problem here, though. Newbus prints out the IRQ number after : > : > : > : a successful device probe phase. It has no knowledge of MSI at that : > : > : > : point, so it just prints out the traditional IRQ value. At some point, : > : > : > : this needs to be fixed. Having the driver tell newbus about its MSI : > : > : > : intentions in the probe routine is unrealistic, so there is no quick : > : > : > : fix there. Probably need to delay printing the device message until : > : > : > : later in the attach routine, once the driver has set up all of the : > : > : > : resources. : > : > : > : > : > : > I've been wanting to move the printing of the attach string from : > : > : > post-probe, pre-attach to post-attach for some time now. We would : > : > : > then report the resources assigned to the device. I'm not sure if I'd : > : > : > print all the resources assigned, or only those the driver activates. : > : > : > Both sides of the argument have merit, imho. On the pro side, : > : > : > resources are used, and printing them will help highlight conflicts. : > : > : > On the con side, people think it clutters things up too much and might : > : > : > lead to false expectations. : > : > : > : > : > : > When I've mentioned this desire at various developer summits, I was : > : > : > told basically "go for it, but only at freebsd X.0 since people have : > : > : > dmesg parsers" by many people (maybe even including Scott). : > : > : : > : > : Also, the way it works now, if attach fails and the routine prints out error : > : > : messages, you get to see line for the device first with the initial resources : > : > : and then you see the error message from the driver. If you move the printf : > : > : down, then all you get is an error message from the driver. At the very : > : > : least this would break POLA for a lot of our users. I'm still undecided. : > : > : I could add a printf when a device ends up succesfully allocating MSI or MSI-X : > : > : IRQs if people desired. : > : > : > : > I'd prefer those be under bootverbose. : > : > : > : > I think the real answer may be to get devinfo output to be real... : > : > : > : > Warner : > : : > : Yeah, the resource info really is superfluous during boot. It looks : > : cool in the old-school unix way, but that's about it. Maybe it's time : > : to change newbus to only print the driver name and driver-supplied : > : description after the probe phase, like you hint at. newbus could then : > : print resource info as the driver activates it, if bootverbose is set. : > : I'd support something like this for 7.0, even if devinfo doesn't get : > : fully fixed. If MSI gets merged to RELENG_6, then we'll just have to : > : live with the incorrect newbus prints. : > : : > : So for example, I would change this: : > : : > : atapci0: port : > : 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 31.2 on pci0 : > : : > : into: : > : : > : atapci0: at device 31.2 on pci0 : > : > That's exactly what I'm thinking too. Glad to see we're on the same : > page. : > : > : Calls to bus_activate_resouce/bus_alloc_resource(RF_ACTIVE) could then : > : print the various resources, contingent on bootverbose being set. This : > : would make the ugly [GIANT_LOCKED] and [FAST] messages that get printed : > : right now have a chance of being more consistent. : > : > I was thinking that if we printed things last, we could potentially : > eliminate them from normal use and just print them as part of the : > resources (optionally?): : > : > atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f irq 23 [FAST] : > : > or something similar... : > : > Warner : : Sounds good. Beware that MSI makes it possible to have as many as 64 : interrupts per device, though it's more common to have anywhere from 1 : to 8. I'd probably split up your above line into 2 lines, one for : memory resources and one for interrupt resources. Is there some convention for MSI naming? Or are the resources basically anonymous? Warner From owner-cvs-src@FreeBSD.ORG Thu Nov 16 06:28:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AE7316A407; Thu, 16 Nov 2006 06:28:55 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3246A43D46; Thu, 16 Nov 2006 06:28:55 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG6Ssq6099245; Thu, 16 Nov 2006 06:28:54 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG6SsLT099244; Thu, 16 Nov 2006 06:28:54 GMT (envelope-from scottl) Message-Id: <200611160628.kAG6SsLT099244@repoman.freebsd.org> From: Scott Long Date: Thu, 16 Nov 2006 06:28:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 06:28:55 -0000 scottl 2006-11-16 06:28:54 UTC FreeBSD src repository Modified files: sys/dev/bce if_bce.c if_bcereg.h Log: Due to an incorrect macro, it appears that this driver has always been accidentally truncating off the VLAN tag field in the TX descriptor. Fix this by splitting up the vlan_tag and flags fields into separate fields, and handling them appropriately. Sponsored by: Ironport MFC After: 3 days Revision Changes Path 1.21 +16 -13 src/sys/dev/bce/if_bce.c 1.10 +2 -1 src/sys/dev/bce/if_bcereg.h From owner-cvs-src@FreeBSD.ORG Thu Nov 16 07:50:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 873A216A40F; Thu, 16 Nov 2006 07:50:34 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41DF443D45; Thu, 16 Nov 2006 07:50:34 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG7oYMg015644; Thu, 16 Nov 2006 07:50:34 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG7oYlJ015643; Thu, 16 Nov 2006 07:50:34 GMT (envelope-from kmacy) Message-Id: <200611160750.kAG7oYlJ015643@repoman.freebsd.org> From: Kip Macy Date: Thu, 16 Nov 2006 07:50:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v pmap.c tte_hash.c src/sys/sun4v/include tte_hash.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 07:50:34 -0000 kmacy 2006-11-16 07:50:33 UTC FreeBSD src repository Modified files: sys/sun4v/sun4v tte_hash.c pmap.c sys/sun4v/include tte_hash.h Log: Resize the hash table upwards if the number of collision entries is greater than 1/4 of the total it is possible that the resize threshold should be revised upwards Approved by: scottl (standing in for mentor rwatson) Revision Changes Path 1.3 +2 -2 src/sys/sun4v/include/tte_hash.h 1.7 +38 -19 src/sys/sun4v/sun4v/pmap.c 1.3 +78 -41 src/sys/sun4v/sun4v/tte_hash.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 08:04:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88DF716A403; Thu, 16 Nov 2006 08:04:30 +0000 (UTC) (envelope-from benno@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26ECA43D55; Thu, 16 Nov 2006 08:04:30 +0000 (GMT) (envelope-from benno@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAG84Uts020786; Thu, 16 Nov 2006 08:04:30 GMT (envelope-from benno@repoman.freebsd.org) Received: (from benno@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAG84T7F020785; Thu, 16 Nov 2006 08:04:29 GMT (envelope-from benno) Message-Id: <200611160804.kAG84T7F020785@repoman.freebsd.org> From: Benno Rice Date: Thu, 16 Nov 2006 08:04:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/nanobsd FlashDevice.sub X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 08:04:30 -0000 benno 2006-11-16 08:04:29 UTC FreeBSD src repository Modified files: tools/tools/nanobsd FlashDevice.sub Log: Add the Transcend 2GB card specs. Revision Changes Path 1.8 +5 -0 src/tools/tools/nanobsd/FlashDevice.sub From owner-cvs-src@FreeBSD.ORG Thu Nov 16 09:04:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B3C116A403; Thu, 16 Nov 2006 09:04:26 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE75943D95; Thu, 16 Nov 2006 09:04:24 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id kAG94KOl038416; Thu, 16 Nov 2006 12:04:20 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id kAG94CoH038412; Thu, 16 Nov 2006 12:04:12 +0300 (MSK) (envelope-from yar) Date: Thu, 16 Nov 2006 12:04:12 +0300 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20061116090412.GB37133@comp.chem.msu.su> References: <3801.1163410519@critter.freebsd.dk> <20061113214928.P76443@delplex.bde.org> <20061113.101958.-861030824.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061113.101958.-861030824.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.org, bde@zeta.org.au, jkoshy@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 09:04:26 -0000 On Mon, Nov 13, 2006 at 10:19:58AM -0700, M. Warner Losh wrote: > : > : BTW, you are responsible for the __packed in . Please remove > : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. > : The only danger is if something has grown to depend on __packed reducing > : alignment as a side effect. E.g., suppose we had a byte string containing > : a bytewise copy of a struct ip. If the copy might be misaligned, then it > : should be copied to an actual struct ip before accessing it as a struct, > : but code that accesses it directly using ((struct ip *)&bs[N]) would work > : now due to the reduced alignment. Places that really need __packed should > : probably use __aligned() to restore the natural alignment. > > DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. > If you want to remove it, then you must make sure arm works right > after it because I'll add it back. Many years ago I was taught that comments in code could help to avoid such clashes in software development. Is this true no more? ;-) -- Yar From owner-cvs-src@FreeBSD.ORG Thu Nov 16 11:46:50 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3426116A416; Thu, 16 Nov 2006 11:46:50 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4F9143D95; Thu, 16 Nov 2006 11:46:33 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGBkQe3067140; Thu, 16 Nov 2006 11:46:26 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGBkP4R067131; Thu, 16 Nov 2006 11:46:25 GMT (envelope-from maxim) Message-Id: <200611161146.kAGBkP4R067131@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 16 Nov 2006 11:46:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 11:46:50 -0000 maxim 2006-11-16 11:46:24 UTC FreeBSD src repository Modified files: sys/i386/i386 pmap.c Log: o Make pv_maxchunks no less than maxproc. This helps to survive a forkbomb explosion. Reviewed by: alc Security: local DoS X-MFC atfer: RELENG_6 is not affected due to a different pv_entry allocation code. Revision Changes Path 1.578 +1 -1 src/sys/i386/i386/pmap.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 12:27:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A43E16A412; Thu, 16 Nov 2006 12:27:52 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F0C8843D5E; Thu, 16 Nov 2006 12:27:51 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGCRp4J074425; Thu, 16 Nov 2006 12:27:51 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGCRpYw074424; Thu, 16 Nov 2006 12:27:51 GMT (envelope-from ru) Message-Id: <200611161227.kAGCRpYw074424@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 16 Nov 2006 12:27:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/syscons syscons.c src/usr.sbin/kbdcontrol kbdcontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 12:27:52 -0000 ru 2006-11-16 12:27:51 UTC FreeBSD src repository Modified files: sys/dev/syscons syscons.c usr.sbin/kbdcontrol kbdcontrol.c Log: Replace magic numbers for console bell types with defines. Revision Changes Path 1.450 +2 -2 src/sys/dev/syscons/syscons.c 1.51 +3 -3 src/usr.sbin/kbdcontrol/kbdcontrol.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 12:39:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 872AE16A526; Thu, 16 Nov 2006 12:39:51 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8114743DCD; Thu, 16 Nov 2006 12:38:05 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGCbZ47076005; Thu, 16 Nov 2006 12:37:35 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGCbZFc076004; Thu, 16 Nov 2006 12:37:35 GMT (envelope-from ru) Message-Id: <200611161237.kAGCbZFc076004@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 16 Nov 2006 12:37:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 12:39:51 -0000 ru 2006-11-16 12:37:35 UTC FreeBSD src repository Modified files: usr.sbin/kbdcontrol kbdcontrol.1 Log: Document that visual bell is the global setting, while other bell types can be set individually for each vty. Revision Changes Path 1.41 +5 -1 src/usr.sbin/kbdcontrol/kbdcontrol.1 From owner-cvs-src@FreeBSD.ORG Thu Nov 16 13:32:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62B9516A47C; Thu, 16 Nov 2006 13:32:32 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAD5443D4C; Thu, 16 Nov 2006 13:32:31 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGDWVRx093563; Thu, 16 Nov 2006 13:32:31 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGDWVWo093562; Thu, 16 Nov 2006 13:32:31 GMT (envelope-from ru) Message-Id: <200611161332.kAGDWVWo093562@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 16 Nov 2006 13:32:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/i386/loader main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 13:32:32 -0000 ru 2006-11-16 13:32:31 UTC FreeBSD src repository Modified files: sys/boot/i386/loader main.c Log: Remove an unused variable. Revision Changes Path 1.39 +1 -2 src/sys/boot/i386/loader/main.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 13:43:06 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAC3416A403; Thu, 16 Nov 2006 13:43:06 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4304A43D5E; Thu, 16 Nov 2006 13:43:06 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGDh6XM095288; Thu, 16 Nov 2006 13:43:06 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGDh6Z8095287; Thu, 16 Nov 2006 13:43:06 GMT (envelope-from ru) Message-Id: <200611161343.kAGDh6Z8095287@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 16 Nov 2006 13:43:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 13:43:06 -0000 ru 2006-11-16 13:43:05 UTC FreeBSD src repository Modified files: usr.sbin/kbdcontrol kbdcontrol.1 Log: Grammar fix from Ceri. Revision Changes Path 1.42 +1 -1 src/usr.sbin/kbdcontrol/kbdcontrol.1 From owner-cvs-src@FreeBSD.ORG Thu Nov 16 16:07:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 776D716A40F; Thu, 16 Nov 2006 16:07:17 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6590C43D76; Thu, 16 Nov 2006 16:07:16 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGG7Gdh023838; Thu, 16 Nov 2006 16:07:16 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGG7GaL023837; Thu, 16 Nov 2006 16:07:16 GMT (envelope-from keramida) Message-Id: <200611161607.kAGG7GaL023837@repoman.freebsd.org> From: Giorgos Keramidas Date: Thu, 16 Nov 2006 16:07:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 16:07:17 -0000 keramida 2006-11-16 16:07:16 UTC FreeBSD src repository (doc committer) Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Document the new -P option of sockstat(1) in the release notes. Reviewed by: bmah Revision Changes Path 1.989 +5 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Thu Nov 16 16:09:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F28F516A589; Thu, 16 Nov 2006 16:09:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABF6943D6D; Thu, 16 Nov 2006 16:09:33 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAGG9ODa041483; Thu, 16 Nov 2006 11:09:25 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: mjacob@freebsd.org Date: Thu, 16 Nov 2006 11:09:21 -0500 User-Agent: KMail/1.9.1 References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> In-Reply-To: <20061115192354.D7197@ns1.feral.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611161109.21895.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 16 Nov 2006 11:09:25 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2200/Thu Nov 16 09:10:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 16:09:35 -0000 On Wednesday 15 November 2006 22:30, mjacob@freebsd.org wrote: > > MSI/MSI-X seemed work with MPT for SAS, 4Gb FibreChannel on one system > (SuperMicro Xeon) and 2Gb FibreChannel on another (4xdual core Opteron), > but failed for onboard MPT on that system (dual core Opteron) > > mpt3: request 0xffffffff80e75050:96 timed out for ccb 0xffffff01433ec400 > (req->ccb 0xffffff01433ec400) > mpt3: completing timedout/aborted req 0xffffffff80e75050:96 > mpt3: Timedout requests already complete. Interrupts may not be > functioning. > mpt2: request 0xffffffff80e67050:96 timed out for ccb 0xffffff0141c75c00 > (req->ccb 0xffffff0141c75c00) > mpt2: completing timedout/aborted req 0xffffffff80e67050:96 > mpt2: Timedout requests already complete. Interrupts may not be > functioning. > > > MSI/MSI-X failed to work for the onboard em on the SuperMicro system. > > Given the (unselective) failure rate for me and the relatively small > sample, but with two pretty widely used system types I'd like to suggest > that you reconsider making the MSI and MSI-X being 'on' as the default. It is current, so I think having it on is ok. When I put it in 6.x it will be off by default (eventually the defualt in 6.x may change after broader testing). If you have chipsets that don't work, we can certainly blacklist those. However, we aren't likely to find them if no one tries MSI on them. Also, in your case it looks like you might have an HT bridge that needs the MSI window turned on. I haven't committed that patch as I haven't been able to get it tested yet. Please try http://www.freebsd.org/~jhb/patches/msi_ht.patch -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Nov 16 17:25:09 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A53F916A40F; Thu, 16 Nov 2006 17:25:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 165AB43D46; Thu, 16 Nov 2006 17:25:08 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAGHP1vL041974; Thu, 16 Nov 2006 12:25:01 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Thu, 16 Nov 2006 11:14:41 -0500 User-Agent: KMail/1.9.1 References: <455BA0B6.1000109@samsco.org> <455BA914.7010602@samsco.org> <20061115.220331.-957833409.imp@bsdimp.com> In-Reply-To: <20061115.220331.-957833409.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611161114.42297.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 16 Nov 2006 12:25:02 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2200/Thu Nov 16 09:10:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, scottl@samsco.org, src-committers@freebsd.org, ru@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 17:25:09 -0000 On Thursday 16 November 2006 00:03, M. Warner Losh wrote: > In message: <455BA914.7010602@samsco.org> > Scott Long writes: > : M. Warner Losh wrote: > : > In message: <455BA0B6.1000109@samsco.org> > : > Scott Long writes: > : > : M. Warner Losh wrote: > : > : > In message: <200611151756.31047.jhb@freebsd.org> > : > : > John Baldwin writes: > : > : > : On Wednesday 15 November 2006 17:51, M. Warner Losh wrote: > : > : > : > In message: <455B963A.4050200@samsco.org> > : > : > : > Scott Long writes: > : > : > : > : John Baldwin wrote: > : > : > : > : > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: > : > : > : > : >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: > : > : > : > : >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: > : > : > : > : >>>> jhb 2006-11-15 20:04:57 UTC > : > : > : > : >>>> > : > : > : > : >>>> FreeBSD src repository > : > : > : > : >>>> > : > : > : > : >>>> Modified files: > : > : > : > : >>>> sys/dev/bce if_bce.c > : > : > : > : >>>> sys/dev/em if_em.c if_em.h > : > : > : > : >>>> sys/dev/mpt mpt.h mpt_pci.c > : > : > : > : >>>> Log: > : > : > : > : >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > : > : > : > : > support > : > : > : > : >>>> devices that support a maximum of 1 message, and we use that 1 > : > : > : message > : > : > : > : >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > : > : > : > : >>>> > : > : > : > : >>>> Revision Changes Path > : > : > : > : >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c > : > : > : > : >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c > : > : > : > : >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h > : > : > : > : >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h > : > : > : > : >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > : > : > : > : >>>> > : > : > : > : >>> How will the "vmstat -i" output look like for MSI-enabled devices? > : > : > : > : >>> > : > : > : > : >> irqXXXX, where XXXX>=1024? > : > : > : > : > > : > : > : > : > s/1024/256/ > : > : > : > : > > : > : > : > : > : > : > : > : There is a problem here, though. Newbus prints out the IRQ number after > : > : > : > : a successful device probe phase. It has no knowledge of MSI at that > : > : > : > : point, so it just prints out the traditional IRQ value. At some point, > : > : > : > : this needs to be fixed. Having the driver tell newbus about its MSI > : > : > : > : intentions in the probe routine is unrealistic, so there is no quick > : > : > : > : fix there. Probably need to delay printing the device message until > : > : > : > : later in the attach routine, once the driver has set up all of the > : > : > : > : resources. > : > : > : > > : > : > : > I've been wanting to move the printing of the attach string from > : > : > : > post-probe, pre-attach to post-attach for some time now. We would > : > : > : > then report the resources assigned to the device. I'm not sure if I'd > : > : > : > print all the resources assigned, or only those the driver activates. > : > : > : > Both sides of the argument have merit, imho. On the pro side, > : > : > : > resources are used, and printing them will help highlight conflicts. > : > : > : > On the con side, people think it clutters things up too much and might > : > : > : > lead to false expectations. > : > : > : > > : > : > : > When I've mentioned this desire at various developer summits, I was > : > : > : > told basically "go for it, but only at freebsd X.0 since people have > : > : > : > dmesg parsers" by many people (maybe even including Scott). > : > : > : > : > : > : Also, the way it works now, if attach fails and the routine prints out error > : > : > : messages, you get to see line for the device first with the initial resources > : > : > : and then you see the error message from the driver. If you move the printf > : > : > : down, then all you get is an error message from the driver. At the very > : > : > : least this would break POLA for a lot of our users. I'm still undecided. > : > : > : I could add a printf when a device ends up succesfully allocating MSI or MSI-X > : > : > : IRQs if people desired. > : > : > > : > : > I'd prefer those be under bootverbose. > : > : > > : > : > I think the real answer may be to get devinfo output to be real... > : > : > > : > : > Warner > : > : > : > : Yeah, the resource info really is superfluous during boot. It looks > : > : cool in the old-school unix way, but that's about it. Maybe it's time > : > : to change newbus to only print the driver name and driver-supplied > : > : description after the probe phase, like you hint at. newbus could then > : > : print resource info as the driver activates it, if bootverbose is set. > : > : I'd support something like this for 7.0, even if devinfo doesn't get > : > : fully fixed. If MSI gets merged to RELENG_6, then we'll just have to > : > : live with the incorrect newbus prints. > : > : > : > : So for example, I would change this: > : > : > : > : atapci0: port > : > : 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f at device 31.2 on pci0 > : > : > : > : into: > : > : > : > : atapci0: at device 31.2 on pci0 > : > > : > That's exactly what I'm thinking too. Glad to see we're on the same > : > page. Yeah, I think I could go for this to. > : > : Calls to bus_activate_resouce/bus_alloc_resource(RF_ACTIVE) could then > : > : print the various resources, contingent on bootverbose being set. This > : > : would make the ugly [GIANT_LOCKED] and [FAST] messages that get printed > : > : right now have a chance of being more consistent. > : > > : > I was thinking that if we printed things last, we could potentially > : > eliminate them from normal use and just print them as part of the > : > resources (optionally?): > : > > : > atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xfc00-0xfc0f irq 23 [FAST] This works for me, too. This also affects ISA devices added via hints. Right now you just see the hint values which show a start port, but not the whole range. > : > > : > or something similar... > : > > : > Warner > : > : Sounds good. Beware that MSI makes it possible to have as many as 64 > : interrupts per device, though it's more common to have anywhere from 1 > : to 8. I'd probably split up your above line into 2 lines, one for > : memory resources and one for interrupt resources. > > Is there some convention for MSI naming? Or are the resources > basically anonymous? They are just IRQ values. On x86 they will be >= 256, but that may not be true on other platforms. Other busses might also support multiple IRQs per device (if you had HT peripherals I think they could do this). In general IRQs are just cookies anyway. On x86 they index into the interrupt_sources[] array. On other platforms they can have other meanings. It would almost be better if SYS_RES_IRQ was just SYS_RES_INTR. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Nov 16 17:31:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F411116A412; Thu, 16 Nov 2006 17:31:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B48C843D46; Thu, 16 Nov 2006 17:31:33 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGHVX5Q046381; Thu, 16 Nov 2006 17:31:33 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGHVXpo046377; Thu, 16 Nov 2006 17:31:33 GMT (envelope-from jhb) Message-Id: <200611161731.kAGHVXpo046377@repoman.freebsd.org> From: John Baldwin Date: Thu, 16 Nov 2006 17:31:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 17:31:34 -0000 jhb 2006-11-16 17:31:33 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c Log: Look for capabilities in PCI-PCI bridges using the same CAP PTR register as for type 0 devices. Submitted by: grehan MFC after: 1 week Revision Changes Path 1.323 +2 -0 src/sys/dev/pci/pci.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 17:32:05 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 661DB16A494; Thu, 16 Nov 2006 17:32:05 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0B6643D55; Thu, 16 Nov 2006 17:32:04 +0000 (GMT) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id kAGHVsts009768; Thu, 16 Nov 2006 09:32:04 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id kAGHVsdQ009765; Thu, 16 Nov 2006 09:31:54 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Thu, 16 Nov 2006 09:31:54 -0800 (PST) From: mjacob@freebsd.org X-X-Sender: mjacob@ns1.feral.com To: John Baldwin In-Reply-To: <200611161114.42297.jhb@freebsd.org> Message-ID: <20061116092809.O9739@ns1.feral.com> References: <455BA0B6.1000109@samsco.org> <455BA914.7010602@samsco.org> <20061115.220331.-957833409.imp@bsdimp.com> <200611161114.42297.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, ru@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 17:32:05 -0000 >> >> Is there some convention for MSI naming? Or are the resources >> basically anonymous? > > They are just IRQ values. On x86 they will be >= 256, but that may not be > true on other platforms. Other busses might also support multiple IRQs per > device (if you had HT peripherals I think they could do this). In general > IRQs are just cookies anyway. On x86 they index into the interrupt_sources[] > array. On other platforms they can have other meanings. It would almost be > better if SYS_RES_IRQ was just SYS_RES_INTR. > Let me put back on my very very dusty Solaris DDI team hat and point out that you either coerce the naming of interrupts to an architected number space (as did Digital Unix and does Linux and more or less does FreeBSD) or leave the naming of interrupts to the bus nexus it has meaning to. From owner-cvs-src@FreeBSD.ORG Thu Nov 16 18:36:33 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 460C816A417 for ; Thu, 16 Nov 2006 18:36:33 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id E373443D46 for ; Thu, 16 Nov 2006 18:36:30 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so471552uge for ; Thu, 16 Nov 2006 10:36:29 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ql+gTC06FzmQNQlscoOuSz7TjGEBp+F8ZpZ7GyUBVDKceFMF/vddyNgNQ53xgFoOk+QPW2YdTjsN/vd9yWTt3iHFDpt9v959XlG5WxNSWdI6Wub6OwhLTUNa+5YNxhtyji+hX0L7Y0NkHAs8DSiR6F0Y4PwzLUIKbefTdeAsWus= Received: by 10.82.118.2 with SMTP id q2mr107840buc.1163702189413; Thu, 16 Nov 2006 10:36:29 -0800 (PST) Received: by 10.82.112.7 with HTTP; Thu, 16 Nov 2006 10:36:28 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2006 19:36:28 +0100 From: "Pawel Worach" To: "John Baldwin" In-Reply-To: <200611152004.kAFK4vfe058983@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 18:36:33 -0000 On 11/15/06, John Baldwin wrote: > jhb 2006-11-15 20:04:57 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bce if_bce.c > sys/dev/em if_em.c if_em.h > sys/dev/mpt mpt.h mpt_pci.c > Log: > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > devices that support a maximum of 1 message, and we use that 1 message > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > Hi John, This seems to cause an NMI here on a IBM x345 box, boot -v below. (It's frozen for about 1-2 seconds before the NMI fires) OK boot -v /boot/kernel/acpi.ko text=0x4d134 data=0x2540+0x1010 syms=[0x4+0x7cb0+0x4+0xaa13] GDB: no debug ports present KDB: debugger backends: ddb KDB: current backend: ddb SMAP type=01 base=0000000000000000 len=000000000009d400 SMAP type=02 base=000000000009d400 len=0000000000002c00 SMAP type=02 base=00000000000e0000 len=0000000000020000 SMAP type=01 base=0000000000100000 len=000000003fedb2c0 SMAP type=02 base=000000003ffe0000 len=0000000000020000 SMAP type=03 base=000000003ffdb2c0 len=0000000000004d40 SMAP type=02 base=00000000fec00000 len=0000000001400000 Copyright (c) 1992-2006 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD is a registered trademark of The FreeBSD Foundation. FreeBSD 7.0-CURRENT #0: Thu Nov 16 14:42:47 CET 2006 root@zero:/usr/obj/usr/src/sys/ZERO Using 16 colors for the VM-PQ tuning (512, 8) Preloaded elf kernel "/boot/kernel/kernel" at 0xc08e2000. Preloaded elf module "/boot/kernel/acpi.ko" at 0xc08e216c. MP Configuration Table version 1.4 found at 0xc009e2a0 Table 'FACP' at 0x3ffdff00 Table 'APIC' at 0x3ffdfe40 MADT: Found table at 0x3ffdfe40 APIC: Using the MADT enumerator. MADT: Found CPU APIC ID 0 ACPI ID 0: enabled SMP: Added CPU 0 (AP) MADT: Found CPU APIC ID 6 ACPI ID 1: enabled SMP: Added CPU 6 (AP) MADT: Found CPU APIC ID 1 ACPI ID 2: enabled SMP: Added CPU 1 (AP) MADT: Found CPU APIC ID 7 ACPI ID 3: enabled SMP: Added CPU 7 (AP) INTR: Adding local APIC 0 as a target ACPI APIC Table: Calibrating clock(s) ... i8254 clock: 1193166 Hz CLK_USE_I8254_CALIBRATION not specified - using default frequency Timecounter "i8254" frequency 1193182 Hz quality 0 Calibrating TSC clock ... TSC clock: 2793899688 Hz CPU: Intel(R) Xeon(TM) CPU 2.80GHz (2793.90-MHz 686-class CPU) Origin = "GenuineIntel" Id = 0xf29 Stepping = 9 Features=0xbfebfbff Features2=0x4400 Logical CPUs per core: 2 Instruction TLB: 4 KB, 2 MB or 4 MB pages, fully associative, 64 entries Data TLB: 4 KB or 4 MB pages, fully associative, 64 entries 1st-level data cache: 8 KB, 4-way set associative, sectored cache, 64 byte line size Trace cache: 12K-uops, 8-way set associative 2nd-level cache: 512 KB, 8-way set associative, sectored cache, 64 byte line size real memory = 1073590272 (1023 MB) Physical memory chunk(s): 0x0000000000001000 - 0x000000000009cfff, 638976 bytes (156 pages) 0x0000000000100000 - 0x00000000003fffff, 3145728 bytes (768 pages) 0x0000000000c28000 - 0x000000003ed92fff, 1041674240 bytes (254315 pages) avail memory = 1041301504 (993 MB) INTR: Adding local APIC 6 as a target FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 cpu2 (AP): APIC ID: 6 cpu3 (AP): APIC ID: 7 bios32: Found BIOS32 Service Directory header at 0xc00fd790 bios32: Entry = 0xfd7a1 (c00fd7a1) Rev = 0 Len = 1 pcibios: PCI BIOS entry at 0xf0000+0xd7dc pnpbios: Found PnP BIOS data at 0xc00fdf90 pnpbios: Entry = f0000:440f Rev = 1.0 Other BIOS signatures found: APIC: CPU 0 has ACPI ID 0 APIC: CPU 1 has ACPI ID 2 APIC: CPU 2 has ACPI ID 1 APIC: CPU 3 has ACPI ID 3 Security auditing service present BSM auditing present MADT: Found IO APIC ID 14, Interrupt 0 at 0xfec00000 ioapic0: Routing external 8259A's -> intpin 0 ioapic0: intpin 0 -> ExtINT (edge, high) ioapic0: intpin 1 -> ISA IRQ 1 (edge, high) ioapic0: intpin 2 -> ISA IRQ 2 (edge, high) ioapic0: intpin 3 -> ISA IRQ 3 (edge, high) ioapic0: intpin 4 -> ISA IRQ 4 (edge, high) ioapic0: intpin 5 -> ISA IRQ 5 (edge, high) ioapic0: intpin 6 -> ISA IRQ 6 (edge, high) ioapic0: intpin 7 -> ISA IRQ 7 (edge, high) ioapic0: intpin 8 -> ISA IRQ 8 (edge, high) ioapic0: intpin 9 -> ISA IRQ 9 (edge, high) ioapic0: intpin 10 -> ISA IRQ 10 (edge, high) ioapic0: intpin 11 -> ISA IRQ 11 (edge, high) ioapic0: intpin 12 -> ISA IRQ 12 (edge, high) ioapic0: intpin 13 -> ISA IRQ 13 (edge, high) ioapic0: intpin 14 -> ISA IRQ 14 (edge, high) ioapic0: intpin 15 -> ISA IRQ 15 (edge, high) MADT: Found IO APIC ID 13, Interrupt 16 at 0xfec01000 ioapic1: intpin 0 -> PCI IRQ 16 (level, low) ioapic1: intpin 1 -> PCI IRQ 17 (level, low) ioapic1: intpin 2 -> PCI IRQ 18 (level, low) ioapic1: intpin 3 -> PCI IRQ 19 (level, low) ioapic1: intpin 4 -> PCI IRQ 20 (level, low) ioapic1: intpin 5 -> PCI IRQ 21 (level, low) ioapic1: intpin 6 -> PCI IRQ 22 (level, low) ioapic1: intpin 7 -> PCI IRQ 23 (level, low) ioapic1: intpin 8 -> PCI IRQ 24 (level, low) ioapic1: intpin 9 -> PCI IRQ 25 (level, low) ioapic1: intpin 10 -> PCI IRQ 26 (level, low) ioapic1: intpin 11 -> PCI IRQ 27 (level, low) ioapic1: intpin 12 -> PCI IRQ 28 (level, low) ioapic1: intpin 13 -> PCI IRQ 29 (level, low) ioapic1: intpin 14 -> PCI IRQ 30 (level, low) ioapic1: intpin 15 -> PCI IRQ 31 (level, low) MADT: Found IO APIC ID 12, Interrupt 32 at 0xfec02000 ioapic2: intpin 0 -> PCI IRQ 32 (level, low) ioapic2: intpin 1 -> PCI IRQ 33 (level, low) ioapic2: intpin 2 -> PCI IRQ 34 (level, low) ioapic2: intpin 3 -> PCI IRQ 35 (level, low) ioapic2: intpin 4 -> PCI IRQ 36 (level, low) ioapic2: intpin 5 -> PCI IRQ 37 (level, low) ioapic2: intpin 6 -> PCI IRQ 38 (level, low) ioapic2: intpin 7 -> PCI IRQ 39 (level, low) ioapic2: intpin 8 -> PCI IRQ 40 (level, low) ioapic2: intpin 9 -> PCI IRQ 41 (level, low) ioapic2: intpin 10 -> PCI IRQ 42 (level, low) ioapic2: intpin 11 -> PCI IRQ 43 (level, low) ioapic2: intpin 12 -> PCI IRQ 44 (level, low) ioapic2: intpin 13 -> PCI IRQ 45 (level, low) ioapic2: intpin 14 -> PCI IRQ 46 (level, low) ioapic2: intpin 15 -> PCI IRQ 47 (level, low) MADT: Interrupt override: source 0, irq 2 ioapic0: Routing IRQ 0 -> intpin 2 ioapic0: intpin 2 trigger: edge ioapic0: intpin 2 polarity: high lapic0: Routing NMI -> LINT1 MADT: Ignoring local NMI routed to ACPI CPU 6 lapic6: Routing NMI -> LINT1 MADT: Ignoring local NMI routed to ACPI CPU 7 MADT: Forcing active-low polarity and level trigger for SCI ioapic0: intpin 3 polarity: low ioapic0: intpin 3 trigger: level ioapic2 irqs 32-47 on motherboard ioapic1 irqs 16-31 on motherboard ioapic0 irqs 0-15 on motherboard cpu0 BSP: ID: 0x00000000 VER: 0x00050014 LDR: 0x00000000 DFR: 0xffffffff lint0: 0x00010700 lint1: 0x00000400 TPR: 0x00000000 SVR: 0x000001ff timer: 0x000100ef therm: 0x00010000 err: 0x00010000 pcm: 0x00010000 null: random: mem: Pentium Pro MTRR support enabled io: npx0: INT 16 interface acpi0: on motherboard ioapic0: routing intpin 3 (ISA IRQ 3) to vector 48 acpi0: [MPSAFE] pci_open(1): mode 1 addr port (0x0cf8) is 0x80002800 pci_open(1a): mode1res=0x80000000 (0x80000000) pci_cfgcheck: device 0 [class=060000] [hdr=80] is there (id=00141166) pcibios: BIOS version 2.10 AcpiOsDerivePciId: bus 0 dev 15 func 2 acpi0: Power Button (fixed) acpi0: wakeup code va 0xd73cb000 pa 0x9c000 AcpiOsDerivePciId: bus 0 dev 0 func 0 AcpiOsDerivePciId: bus 0 dev 16 func 0 AcpiOsDerivePciId: bus 0 dev 16 func 2 AcpiOsDerivePciId: bus 0 dev 17 func 0 AcpiOsDerivePciId: bus 0 dev 17 func 2 acpi0: reservation of 460, 2 (4) failed ACPI timer: 1/2 0/3 1/2 1/2 0/3 1/2 1/2 1/2 0/3 1/2 -> 7 Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000 acpi_timer0: <32-bit timer at 3.579545MHz> port 0x488-0x48b on acpi0 pci_link0: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link1: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link2: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link3: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link4: Index IRQ Rtd Ref IRQs Initial Probe 0 10 N 0 10 Validation 0 10 N 0 10 After Disable 0 255 N 0 10 pci_link5: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link6: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link7: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link8: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link9: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link10: Index IRQ Rtd Ref IRQs Initial Probe 0 10 N 0 10 Validation 0 10 N 0 10 After Disable 0 255 N 0 10 pci_link11: Index IRQ Rtd Ref IRQs Initial Probe 0 9 N 0 9 Validation 0 9 N 0 9 After Disable 0 255 N 0 9 pci_link12: Index IRQ Rtd Ref IRQs Initial Probe 0 9 N 0 9 Validation 0 9 N 0 9 After Disable 0 255 N 0 9 pci_link13: Index IRQ Rtd Ref IRQs Initial Probe 0 11 N 0 11 Validation 0 11 N 0 11 After Disable 0 255 N 0 11 pci_link14: Index IRQ Rtd Ref IRQs Initial Probe 0 3 N 0 3 Validation 0 3 N 0 3 After Disable 0 255 N 0 3 pci_link15: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link16: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link17: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link18: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link19: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link20: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link21: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link22: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link23: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link24: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link25: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link26: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link27: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link28: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link29: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link30: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link31: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link32: Index IRQ Rtd Ref IRQs Initial Probe 0 11 N 0 11 Validation 0 11 N 0 11 After Disable 0 255 N 0 11 cpu0: on acpi0 cpu1: on acpi0 cpu2: on acpi0 cpu3: on acpi0 pcib0: on acpi0 ACPI: Found matching pin for 0.15.INTA at func 2: 11 pci0: on pcib0 pci0: physical bus=0 found-> vendor=0x1166, dev=0x0014, revid=0x33 bus=0, slot=0, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0014, revid=0x00 bus=0, slot=0, func=1 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0014, revid=0x00 bus=0, slot=0, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1002, dev=0x4752, revid=0x27 bus=0, slot=6, func=0 class=03-00-00, hdrtype=0x00, mfdev=0 cmdreg=0x0087, statreg=0x0290, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x00 (0 ns) intpin=a, irq=10 powerspec 2 supports D0 D1 D2 D3 current D0 map[10]: type 1, range 32, base 0xfd000000, size 24, enabled map[14]: type 4, range 32, base 0x2400, size 8, enabled map[18]: type 1, range 32, base 0xfebff000, size 12, enabled pcib0: matched entry for 0.6.INTA pcib0: slot 6 INTA hardwired to IRQ 26 found-> vendor=0x1166, dev=0x0201, revid=0x93 bus=0, slot=15, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0147, statreg=0x2200, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0212, revid=0x93 bus=0, slot=15, func=1 class=01-01-82, hdrtype=0x00, mfdev=1 cmdreg=0x0155, statreg=0x0200, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) map[20]: type 4, range 32, base 0x700, size 4, enabled found-> vendor=0x1166, dev=0x0220, revid=0x05 bus=0, slot=15, func=2 class=0c-03-10, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0280, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x50 (20000 ns) intpin=a, irq=11 map[10]: type 1, range 32, base 0xfebfe000, size 12, enabled pcib0: matched entry for 0.15.INTA (src \LPUS:0) ioapic0: Changing trigger for pin 11 to level ioapic0: Changing polarity for pin 11 to low pcib0: slot 15 INTA routed to irq 11 via \LPUS found-> vendor=0x1166, dev=0x0225, revid=0x00 bus=0, slot=15, func=3 class=06-01-00, hdrtype=0x00, mfdev=1 cmdreg=0x0144, statreg=0x0200, cachelnsz=0 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=16, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x22b0, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=16, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=17, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=17, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) vgapci0: port 0x2400-0x24ff mem 0xfd000000-0xfdffffff,0xfebff000-0xfebfffff irq 26 at device 6.0 on pci0 atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0x700-0x70f at device 15.1 on pci0 atapci0: Reserved 0x10 bytes for rid 0x20 type 4 at 0x700 ata0: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 atapci0: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 ata0: reset tp1 mask=03 ostat0=50 ostat1=00 ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata0: stat1=0x00 err=0x04 lsb=0x00 msb=0x00 ata0: reset tp2 stat0=00 stat1=00 devices=0x4 ioapic0: routing intpin 14 (ISA IRQ 14) to vector 49 ata0: [MPSAFE] ata1: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 atapci0: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 ata1: reset tp1 mask=00 ostat0=ff ostat1=ff ioapic0: routing intpin 15 (ISA IRQ 15) to vector 50 ata1: [MPSAFE] pci0: at device 15.2 (no driver attached) isab0: at device 15.3 on pci0 isa0: on isab0 pcib1: on acpi0 pci2: on pcib1 pci2: physical bus=2 found-> vendor=0x8086, dev=0x1229, revid=0x0c bus=2, slot=3, func=0 class=02-00-00, hdrtype=0x00, mfdev=0 cmdreg=0x0157, statreg=0x0290, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x38 (14000 ns) intpin=a, irq=10 powerspec 2 supports D0 D1 D2 D3 current D0 map[10]: type 1, range 32, base 0xfbfff000, size 12, enabled map[14]: type 4, range 32, base 0x2500, size 6, enabled map[18]: type 1, range 32, base 0xfbfc0000, size 17, enabled pcib1: matched entry for 2.3.INTA pcib1: slot 3 INTA hardwired to IRQ 20 fxp0: port 0x2500-0x253f mem 0xfbfff000-0xfbffffff,0xfbfc0000-0xfbfdffff irq 20 at device 3.0 on pci2 fxp0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xfbfff000 fxp0: using memory space register mapping fxp0: PCI IDs: 8086 1229 1014 01f1 000c fxp0: Dynamic Standby mode is disabled miibus0: on fxp0 inphy0: on miibus0 inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto fxp0: bpf attached fxp0: Ethernet address: 00:0e:0c:2e:98:88 ioapic1: routing intpin 4 (PCI IRQ 20) to vector 51 fxp0: [MPSAFE] pcib2: on acpi0 pci4: on pcib2 pci4: physical bus=4 pcib3: on acpi0 pci6: on pcib3 pci6: physical bus=6 found-> vendor=0x8086, dev=0x1010, revid=0x01 bus=6, slot=8, func=0 class=02-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) intpin=a, irq=11 powerspec 2 supports D0 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 1, range 64, base 0xf9fe0000, size 17, enabled map[20]: type 4, range 32, base 0x2540, size 6, enabled pcib3: matched entry for 6.8.INTA pcib3: slot 8 INTA hardwired to IRQ 29 found-> vendor=0x8086, dev=0x1010, revid=0x01 bus=6, slot=8, func=1 class=02-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) intpin=b, irq=3 powerspec 2 supports D0 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 1, range 64, base 0xf9fc0000, size 17, enabled map[20]: type 4, range 32, base 0x2580, size 6, enabled pcib3: matched entry for 6.8.INTB pcib3: slot 8 INTB hardwired to IRQ 30 em0: port 0x2540-0x257f mem 0xf9fe0000-0xf9ffffff irq 29 at device 8.0 on pci6 em0: Reserved 0x20000 bytes for rid 0x10 type 3 at 0xf9fe0000 em0: Reserved 0x40 bytes for rid 0x20 type 4 at 0x2540 em0: bpf attached em0: Ethernet address: 00:0d:60:1a:4f:c6 NMI ISA 34, EISA 0 NMI ... going to debugger [thread pid 0 tid 0 ] Stopped at em_clear_hw_cntrs+0xc6: movl %eax,-0x4(%ebp) db> bt Tracing pid 0 tid 0 td 0xc07c8f50 em_clear_hw_cntrs(c34d0004,c34d0000,c34d0298,1,64,...) at em_clear_hw_cntrs+0xc6 em_attach(c34f5680,c34ab04c,c0785ef8,c34f5680,c34f5680,...) at em_attach+0x5c2 device_attach(c34f5680,c34f5680,c3475740,1,c34f5680,...) at device_attach+0x6a device_probe_and_attach(c34f5680,c34eea00,c0c20b2c,c08af5ed,c34f5600,...) at device_probe_and_attach+0xf1 bus_generic_attach(c34f5600,c3475740,1,c08af240,c34f5600,...) at bus_generic_attach+0x28 acpi_pci_attach(c34f5600,c34f5600,c347ea80,c34f5600,c34f5600,...) at acpi_pci_attach+0x11d device_attach(c34f5600,c34f5600,c34eea00,c08af670,c34f5600,...) at device_attach+0x6a device_probe_and_attach(c34f5600,c34e1600,c0c20bb0,c08af84c,c34eea00,...) at device_probe_and_attach+0xf1 bus_generic_attach(c34eea00,c08c73dd,6,c0c20ba0,6,...) at bus_generic_attach+0x28 acpi_pcib_attach(c34eea00,c3526754,6,c0c20bd8,c0c20be8,...) at acpi_pcib_attach+0xec acpi_pcib_acpi_attach(c34eea00,c34eea00,c347f240,c34eea00,c34eea00,...) at acpi_pcib_acpi_attach+0xf9 device_attach(c34eea00,c34eea00,c0785d08,c34ee180,c34eea00,...) at device_attach+0x6a device_probe_and_attach(c34eea00,ffffffff,c0c20cac,c08acdd4,c34e1600,...) at device_probe_and_attach+0xf1 bus_generic_attach(c34e1600,fec00000,ffffffff,c34e6c28,fec00000,...) at bus_generic_attach+0x28 acpi_attach(c34e1600,c34aa04c,c0785ef8,c34e1600,c34e1600,...) at acpi_attach+0xa54 device_attach(c34e1600,c34e1600,c08cb7d8,c0c20d00,c34e1600,...) at device_attach+0x6a device_probe_and_attach(c34e1600,c3482400,c0c20d10,c07249ca,c3482400,...) at device_probe_and_attach+0xf1 bus_generic_attach(c3482400,c3482400,c0c20d30,c056daaa,c3482400,...) at bus_generic_attach+0x28 nexus_attach(c3482400,c349e84c,c0785ef8,c3482400,c3482400,...) at nexus_attach+0x1a device_attach(c3482400,c3482400,1,c057d160,c3482400,...) at device_attach+0x6a device_probe_and_attach(c3482400,c3413794,c0c20d70,c070d59c,c075a74e,...) at device_probe_and_attach+0xf1 root_bus_configure(c075a74e,c0c20d88,c050ed95,0,c1e000,...) at root_bus_configure+0x28 configure(0,c1e000,c1ec00,c1e000,0,...) at configure+0xc mi_startup() at mi_startup+0xb5 begin() at begin+0x2c db> (kgdb) l *em_clear_hw_cntrs+0xc6 0xc04ab6d6 is in em_clear_hw_cntrs (bus.h:241). 236 bus.h: No such file or directory. in bus.h (kgdb) l *em_attach+0x5c2 0xc049c452 is in em_attach (/usr/src/sys/dev/em/if_em.c:580). 575 576 em_allocate_intr(adapter); 577 578 /* Initialize statistics */ 579 em_clear_hw_cntrs(&adapter->hw); 580 em_update_stats_counters(adapter); 581 adapter->hw.get_link_status = 1; 582 em_update_link_status(adapter); 583 584 /* Indicate SOL/IDER usage */ /usr/src/sys/dev/em/if_em.c: $FreeBSD: src/sys/dev/em/if_em.c,v 1.164 2006/11/15 20:04:56 jhb Exp $ -- Pawel From owner-cvs-src@FreeBSD.ORG Thu Nov 16 19:03:05 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D3A216A4C2; Thu, 16 Nov 2006 19:03:05 +0000 (UTC) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0997D43D46; Thu, 16 Nov 2006 19:03:05 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGJ34m5062919; Thu, 16 Nov 2006 19:03:04 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGJ346j062918; Thu, 16 Nov 2006 19:03:04 GMT (envelope-from suz) Message-Id: <200611161903.kAGJ346j062918@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Thu, 16 Nov 2006 19:03:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/route6d route6d.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 19:03:05 -0000 suz 2006-11-16 19:03:04 UTC FreeBSD src repository Modified files: usr.sbin/route6d route6d.c Log: implemented more validation checks about incoming responses per RFC2080, and one additional heuristic check for safer operation. Obtained from: KAME MFC after: 1 week Revision Changes Path 1.35 +78 -4 src/usr.sbin/route6d/route6d.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 19:08:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0682616A416; Thu, 16 Nov 2006 19:08:29 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F230543D58; Thu, 16 Nov 2006 19:08:27 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGJ8RqF064766; Thu, 16 Nov 2006 19:08:27 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGJ8RPf064765; Thu, 16 Nov 2006 19:08:27 GMT (envelope-from kensmith) Message-Id: <200611161908.kAGJ8RPf064765@repoman.freebsd.org> From: Ken Smith Date: Thu, 16 Nov 2006 19:08:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/scripts package-split.py X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 19:08:29 -0000 kensmith 2006-11-16 19:08:27 UTC FreeBSD src repository Modified files: release/scripts package-split.py Log: Switch to emulators/linux_base-fc4 since that's the new default Linux emulator. MFC after: 3 days Revision Changes Path 1.14 +1 -1 src/release/scripts/package-split.py From owner-cvs-src@FreeBSD.ORG Thu Nov 16 19:09:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AD2216A47B; Thu, 16 Nov 2006 19:09:44 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A929843D68; Thu, 16 Nov 2006 19:09:41 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGJ9f2O064827; Thu, 16 Nov 2006 19:09:41 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGJ9fu2064826; Thu, 16 Nov 2006 19:09:41 GMT (envelope-from kensmith) Message-Id: <200611161909.kAGJ9fu2064826@repoman.freebsd.org> From: Ken Smith Date: Thu, 16 Nov 2006 19:09:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 19:09:44 -0000 kensmith 2006-11-16 19:09:41 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall config.c Log: Switch to linux_base-fc4 for the Linux emulation package. MFC after: 3 days Revision Changes Path 1.239 +1 -1 src/usr.sbin/sysinstall/config.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 19:22:53 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACDDE16A403; Thu, 16 Nov 2006 19:22:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 395B343D46; Thu, 16 Nov 2006 19:22:52 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAGJMf5x042640; Thu, 16 Nov 2006 14:22:47 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Pawel Worach" Date: Thu, 16 Nov 2006 14:01:08 -0500 User-Agent: KMail/1.9.1 References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611161401.09543.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 16 Nov 2006 14:22:48 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2200/Thu Nov 16 09:10:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 19:22:53 -0000 On Thursday 16 November 2006 13:36, Pawel Worach wrote: > On 11/15/06, John Baldwin wrote: > > jhb 2006-11-15 20:04:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bce if_bce.c > > sys/dev/em if_em.c if_em.h > > sys/dev/mpt mpt.h mpt_pci.c > > Log: > > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > > devices that support a maximum of 1 message, and we use that 1 message > > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > > > > Hi John, > > This seems to cause an NMI here on a IBM x345 box, boot -v below. > (It's frozen for about 1-2 seconds before the NMI fires) > > OK boot -v > /boot/kernel/acpi.ko text=0x4d134 data=0x2540+0x1010 > syms=[0x4+0x7cb0+0x4+0xaa13] > GDB: no debug ports present > KDB: debugger backends: ddb > KDB: current backend: ddb > SMAP type=01 base=0000000000000000 len=000000000009d400 > SMAP type=02 base=000000000009d400 len=0000000000002c00 > SMAP type=02 base=00000000000e0000 len=0000000000020000 > SMAP type=01 base=0000000000100000 len=000000003fedb2c0 > SMAP type=02 base=000000003ffe0000 len=0000000000020000 > SMAP type=03 base=000000003ffdb2c0 len=0000000000004d40 > SMAP type=02 base=00000000fec00000 len=0000000001400000 > Copyright (c) 1992-2006 The FreeBSD Project. > Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 > The Regents of the University of California. All rights reserved. > FreeBSD is a registered trademark of The FreeBSD Foundation. > FreeBSD 7.0-CURRENT #0: Thu Nov 16 14:42:47 CET 2006 > root@zero:/usr/obj/usr/src/sys/ZERO > Using 16 colors for the VM-PQ tuning (512, 8) > Preloaded elf kernel "/boot/kernel/kernel" at 0xc08e2000. > Preloaded elf module "/boot/kernel/acpi.ko" at 0xc08e216c. > MP Configuration Table version 1.4 found at 0xc009e2a0 > Table 'FACP' at 0x3ffdff00 > Table 'APIC' at 0x3ffdfe40 > MADT: Found table at 0x3ffdfe40 > APIC: Using the MADT enumerator. > MADT: Found CPU APIC ID 0 ACPI ID 0: enabled > SMP: Added CPU 0 (AP) > MADT: Found CPU APIC ID 6 ACPI ID 1: enabled > SMP: Added CPU 6 (AP) > MADT: Found CPU APIC ID 1 ACPI ID 2: enabled > SMP: Added CPU 1 (AP) > MADT: Found CPU APIC ID 7 ACPI ID 3: enabled > SMP: Added CPU 7 (AP) > INTR: Adding local APIC 0 as a target > ACPI APIC Table: > Calibrating clock(s) ... i8254 clock: 1193166 Hz > CLK_USE_I8254_CALIBRATION not specified - using default frequency > Timecounter "i8254" frequency 1193182 Hz quality 0 > Calibrating TSC clock ... TSC clock: 2793899688 Hz > CPU: Intel(R) Xeon(TM) CPU 2.80GHz (2793.90-MHz 686-class CPU) > Origin = "GenuineIntel" Id = 0xf29 Stepping = 9 > Features=0xbfebfbff > Features2=0x4400 > Logical CPUs per core: 2 > > Instruction TLB: 4 KB, 2 MB or 4 MB pages, fully associative, 64 entries > Data TLB: 4 KB or 4 MB pages, fully associative, 64 entries > 1st-level data cache: 8 KB, 4-way set associative, sectored cache, 64 > byte line size > Trace cache: 12K-uops, 8-way set associative > 2nd-level cache: 512 KB, 8-way set associative, sectored cache, 64 > byte line size > real memory = 1073590272 (1023 MB) > Physical memory chunk(s): > 0x0000000000001000 - 0x000000000009cfff, 638976 bytes (156 pages) > 0x0000000000100000 - 0x00000000003fffff, 3145728 bytes (768 pages) > 0x0000000000c28000 - 0x000000003ed92fff, 1041674240 bytes (254315 pages) > avail memory = 1041301504 (993 MB) > INTR: Adding local APIC 6 as a target > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > cpu2 (AP): APIC ID: 6 > cpu3 (AP): APIC ID: 7 > bios32: Found BIOS32 Service Directory header at 0xc00fd790 > bios32: Entry = 0xfd7a1 (c00fd7a1) Rev = 0 Len = 1 > pcibios: PCI BIOS entry at 0xf0000+0xd7dc > pnpbios: Found PnP BIOS data at 0xc00fdf90 > pnpbios: Entry = f0000:440f Rev = 1.0 > Other BIOS signatures found: > APIC: CPU 0 has ACPI ID 0 > APIC: CPU 1 has ACPI ID 2 > APIC: CPU 2 has ACPI ID 1 > APIC: CPU 3 has ACPI ID 3 > Security auditing service present > BSM auditing present > MADT: Found IO APIC ID 14, Interrupt 0 at 0xfec00000 > ioapic0: Routing external 8259A's -> intpin 0 > ioapic0: intpin 0 -> ExtINT (edge, high) > ioapic0: intpin 1 -> ISA IRQ 1 (edge, high) > ioapic0: intpin 2 -> ISA IRQ 2 (edge, high) > ioapic0: intpin 3 -> ISA IRQ 3 (edge, high) > ioapic0: intpin 4 -> ISA IRQ 4 (edge, high) > ioapic0: intpin 5 -> ISA IRQ 5 (edge, high) > ioapic0: intpin 6 -> ISA IRQ 6 (edge, high) > ioapic0: intpin 7 -> ISA IRQ 7 (edge, high) > ioapic0: intpin 8 -> ISA IRQ 8 (edge, high) > ioapic0: intpin 9 -> ISA IRQ 9 (edge, high) > ioapic0: intpin 10 -> ISA IRQ 10 (edge, high) > ioapic0: intpin 11 -> ISA IRQ 11 (edge, high) > ioapic0: intpin 12 -> ISA IRQ 12 (edge, high) > ioapic0: intpin 13 -> ISA IRQ 13 (edge, high) > ioapic0: intpin 14 -> ISA IRQ 14 (edge, high) > ioapic0: intpin 15 -> ISA IRQ 15 (edge, high) > MADT: Found IO APIC ID 13, Interrupt 16 at 0xfec01000 > ioapic1: intpin 0 -> PCI IRQ 16 (level, low) > ioapic1: intpin 1 -> PCI IRQ 17 (level, low) > ioapic1: intpin 2 -> PCI IRQ 18 (level, low) > ioapic1: intpin 3 -> PCI IRQ 19 (level, low) > ioapic1: intpin 4 -> PCI IRQ 20 (level, low) > ioapic1: intpin 5 -> PCI IRQ 21 (level, low) > ioapic1: intpin 6 -> PCI IRQ 22 (level, low) > ioapic1: intpin 7 -> PCI IRQ 23 (level, low) > ioapic1: intpin 8 -> PCI IRQ 24 (level, low) > ioapic1: intpin 9 -> PCI IRQ 25 (level, low) > ioapic1: intpin 10 -> PCI IRQ 26 (level, low) > ioapic1: intpin 11 -> PCI IRQ 27 (level, low) > ioapic1: intpin 12 -> PCI IRQ 28 (level, low) > ioapic1: intpin 13 -> PCI IRQ 29 (level, low) > ioapic1: intpin 14 -> PCI IRQ 30 (level, low) > ioapic1: intpin 15 -> PCI IRQ 31 (level, low) > MADT: Found IO APIC ID 12, Interrupt 32 at 0xfec02000 > ioapic2: intpin 0 -> PCI IRQ 32 (level, low) > ioapic2: intpin 1 -> PCI IRQ 33 (level, low) > ioapic2: intpin 2 -> PCI IRQ 34 (level, low) > ioapic2: intpin 3 -> PCI IRQ 35 (level, low) > ioapic2: intpin 4 -> PCI IRQ 36 (level, low) > ioapic2: intpin 5 -> PCI IRQ 37 (level, low) > ioapic2: intpin 6 -> PCI IRQ 38 (level, low) > ioapic2: intpin 7 -> PCI IRQ 39 (level, low) > ioapic2: intpin 8 -> PCI IRQ 40 (level, low) > ioapic2: intpin 9 -> PCI IRQ 41 (level, low) > ioapic2: intpin 10 -> PCI IRQ 42 (level, low) > ioapic2: intpin 11 -> PCI IRQ 43 (level, low) > ioapic2: intpin 12 -> PCI IRQ 44 (level, low) > ioapic2: intpin 13 -> PCI IRQ 45 (level, low) > ioapic2: intpin 14 -> PCI IRQ 46 (level, low) > ioapic2: intpin 15 -> PCI IRQ 47 (level, low) > MADT: Interrupt override: source 0, irq 2 > ioapic0: Routing IRQ 0 -> intpin 2 > ioapic0: intpin 2 trigger: edge > ioapic0: intpin 2 polarity: high > lapic0: Routing NMI -> LINT1 > MADT: Ignoring local NMI routed to ACPI CPU 6 > lapic6: Routing NMI -> LINT1 > MADT: Ignoring local NMI routed to ACPI CPU 7 > MADT: Forcing active-low polarity and level trigger for SCI > ioapic0: intpin 3 polarity: low > ioapic0: intpin 3 trigger: level > ioapic2 irqs 32-47 on motherboard > ioapic1 irqs 16-31 on motherboard > ioapic0 irqs 0-15 on motherboard > cpu0 BSP: > ID: 0x00000000 VER: 0x00050014 LDR: 0x00000000 DFR: 0xffffffff > lint0: 0x00010700 lint1: 0x00000400 TPR: 0x00000000 SVR: 0x000001ff > timer: 0x000100ef therm: 0x00010000 err: 0x00010000 pcm: 0x00010000 > null: > random: > mem: > Pentium Pro MTRR support enabled > io: > npx0: INT 16 interface > acpi0: on motherboard > ioapic0: routing intpin 3 (ISA IRQ 3) to vector 48 > acpi0: [MPSAFE] > pci_open(1): mode 1 addr port (0x0cf8) is 0x80002800 > pci_open(1a): mode1res=0x80000000 (0x80000000) > pci_cfgcheck: device 0 [class=060000] [hdr=80] is there (id=00141166) > pcibios: BIOS version 2.10 > AcpiOsDerivePciId: bus 0 dev 15 func 2 > acpi0: Power Button (fixed) > acpi0: wakeup code va 0xd73cb000 pa 0x9c000 > AcpiOsDerivePciId: bus 0 dev 0 func 0 > AcpiOsDerivePciId: bus 0 dev 16 func 0 > AcpiOsDerivePciId: bus 0 dev 16 func 2 > AcpiOsDerivePciId: bus 0 dev 17 func 0 > AcpiOsDerivePciId: bus 0 dev 17 func 2 > acpi0: reservation of 460, 2 (4) failed > ACPI timer: 1/2 0/3 1/2 1/2 0/3 1/2 1/2 1/2 0/3 1/2 -> 7 > Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000 > acpi_timer0: <32-bit timer at 3.579545MHz> port 0x488-0x48b on acpi0 > pci_link0: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link1: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link2: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link3: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link4: Index IRQ Rtd Ref IRQs > Initial Probe 0 10 N 0 10 > Validation 0 10 N 0 10 > After Disable 0 255 N 0 10 > pci_link5: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link6: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link7: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link8: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link9: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link10: Index IRQ Rtd Ref IRQs > Initial Probe 0 10 N 0 10 > Validation 0 10 N 0 10 > After Disable 0 255 N 0 10 > pci_link11: Index IRQ Rtd Ref IRQs > Initial Probe 0 9 N 0 9 > Validation 0 9 N 0 9 > After Disable 0 255 N 0 9 > pci_link12: Index IRQ Rtd Ref IRQs > Initial Probe 0 9 N 0 9 > Validation 0 9 N 0 9 > After Disable 0 255 N 0 9 > pci_link13: Index IRQ Rtd Ref IRQs > Initial Probe 0 11 N 0 11 > Validation 0 11 N 0 11 > After Disable 0 255 N 0 11 > pci_link14: Index IRQ Rtd Ref IRQs > Initial Probe 0 3 N 0 3 > Validation 0 3 N 0 3 > After Disable 0 255 N 0 3 > pci_link15: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link16: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link17: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link18: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link19: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link20: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link21: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link22: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link23: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link24: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link25: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link26: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link27: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link28: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link29: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link30: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link31: Index IRQ Rtd Ref IRQs > Initial Probe 0 255 N 0 none > Validation 0 255 N 0 none > After Disable 0 255 N 0 none > pci_link32: Index IRQ Rtd Ref IRQs > Initial Probe 0 11 N 0 11 > Validation 0 11 N 0 11 > After Disable 0 255 N 0 11 > cpu0: on acpi0 > cpu1: on acpi0 > cpu2: on acpi0 > cpu3: on acpi0 > pcib0: on acpi0 > ACPI: Found matching pin for 0.15.INTA at func 2: 11 > pci0: on pcib0 > pci0: physical bus=0 > found-> vendor=0x1166, dev=0x0014, revid=0x33 > bus=0, slot=0, func=0 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0014, revid=0x00 > bus=0, slot=0, func=1 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0014, revid=0x00 > bus=0, slot=0, func=2 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1002, dev=0x4752, revid=0x27 > bus=0, slot=6, func=0 > class=03-00-00, hdrtype=0x00, mfdev=0 > cmdreg=0x0087, statreg=0x0290, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x00 (0 ns) > intpin=a, irq=10 > powerspec 2 supports D0 D1 D2 D3 current D0 > map[10]: type 1, range 32, base 0xfd000000, size 24, enabled > map[14]: type 4, range 32, base 0x2400, size 8, enabled > map[18]: type 1, range 32, base 0xfebff000, size 12, enabled > pcib0: matched entry for 0.6.INTA > pcib0: slot 6 INTA hardwired to IRQ 26 > found-> vendor=0x1166, dev=0x0201, revid=0x93 > bus=0, slot=15, func=0 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0147, statreg=0x2200, cachelnsz=0 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0212, revid=0x93 > bus=0, slot=15, func=1 > class=01-01-82, hdrtype=0x00, mfdev=1 > cmdreg=0x0155, statreg=0x0200, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > map[20]: type 4, range 32, base 0x700, size 4, enabled > found-> vendor=0x1166, dev=0x0220, revid=0x05 > bus=0, slot=15, func=2 > class=0c-03-10, hdrtype=0x00, mfdev=1 > cmdreg=0x0157, statreg=0x0280, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x50 (20000 ns) > intpin=a, irq=11 > map[10]: type 1, range 32, base 0xfebfe000, size 12, enabled > pcib0: matched entry for 0.15.INTA (src \LPUS:0) > ioapic0: Changing trigger for pin 11 to level > ioapic0: Changing polarity for pin 11 to low > pcib0: slot 15 INTA routed to irq 11 via \LPUS > found-> vendor=0x1166, dev=0x0225, revid=0x00 > bus=0, slot=15, func=3 > class=06-01-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0144, statreg=0x0200, cachelnsz=0 (dwords) > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0101, revid=0x05 > bus=0, slot=16, func=0 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0142, statreg=0x22b0, cachelnsz=0 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0101, revid=0x05 > bus=0, slot=16, func=2 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0101, revid=0x05 > bus=0, slot=17, func=0 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > found-> vendor=0x1166, dev=0x0101, revid=0x05 > bus=0, slot=17, func=2 > class=06-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > vgapci0: port 0x2400-0x24ff mem > 0xfd000000-0xfdffffff,0xfebff000-0xfebfffff irq 26 at device 6.0 on > pci0 > atapci0: port > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0x700-0x70f at device 15.1 on pci0 > atapci0: Reserved 0x10 bytes for rid 0x20 type 4 at 0x700 > ata0: on atapci0 > atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 > atapci0: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 > ata0: reset tp1 mask=03 ostat0=50 ostat1=00 > ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb > ata0: stat1=0x00 err=0x04 lsb=0x00 msb=0x00 > ata0: reset tp2 stat0=00 stat1=00 devices=0x4 > ioapic0: routing intpin 14 (ISA IRQ 14) to vector 49 > ata0: [MPSAFE] > ata1: on atapci0 > atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 > atapci0: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 > ata1: reset tp1 mask=00 ostat0=ff ostat1=ff > ioapic0: routing intpin 15 (ISA IRQ 15) to vector 50 > ata1: [MPSAFE] > pci0: at device 15.2 (no driver attached) > isab0: at device 15.3 on pci0 > isa0: on isab0 > pcib1: on acpi0 > pci2: on pcib1 > pci2: physical bus=2 > found-> vendor=0x8086, dev=0x1229, revid=0x0c > bus=2, slot=3, func=0 > class=02-00-00, hdrtype=0x00, mfdev=0 > cmdreg=0x0157, statreg=0x0290, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x38 (14000 ns) > intpin=a, irq=10 > powerspec 2 supports D0 D1 D2 D3 current D0 > map[10]: type 1, range 32, base 0xfbfff000, size 12, enabled > map[14]: type 4, range 32, base 0x2500, size 6, enabled > map[18]: type 1, range 32, base 0xfbfc0000, size 17, enabled > pcib1: matched entry for 2.3.INTA > pcib1: slot 3 INTA hardwired to IRQ 20 > fxp0: port 0x2500-0x253f mem > 0xfbfff000-0xfbffffff,0xfbfc0000-0xfbfdffff irq 20 at device 3.0 on > pci2 > fxp0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xfbfff000 > fxp0: using memory space register mapping > fxp0: PCI IDs: 8086 1229 1014 01f1 000c > fxp0: Dynamic Standby mode is disabled > miibus0: on fxp0 > inphy0: on miibus0 > inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto > fxp0: bpf attached > fxp0: Ethernet address: 00:0e:0c:2e:98:88 > ioapic1: routing intpin 4 (PCI IRQ 20) to vector 51 > fxp0: [MPSAFE] > pcib2: on acpi0 > pci4: on pcib2 > pci4: physical bus=4 > pcib3: on acpi0 > pci6: on pcib3 > pci6: physical bus=6 > found-> vendor=0x8086, dev=0x1010, revid=0x01 > bus=6, slot=8, func=0 > class=02-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) > intpin=a, irq=11 > powerspec 2 supports D0 D3 current D0 > MSI supports 1 message, 64 bit > map[10]: type 1, range 64, base 0xf9fe0000, size 17, enabled > map[20]: type 4, range 32, base 0x2540, size 6, enabled > pcib3: matched entry for 6.8.INTA > pcib3: slot 8 INTA hardwired to IRQ 29 > found-> vendor=0x8086, dev=0x1010, revid=0x01 > bus=6, slot=8, func=1 > class=02-00-00, hdrtype=0x00, mfdev=1 > cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) > lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) > intpin=b, irq=3 > powerspec 2 supports D0 D3 current D0 > MSI supports 1 message, 64 bit > map[10]: type 1, range 64, base 0xf9fc0000, size 17, enabled > map[20]: type 4, range 32, base 0x2580, size 6, enabled > pcib3: matched entry for 6.8.INTB > pcib3: slot 8 INTB hardwired to IRQ 30 > em0: port > 0x2540-0x257f mem 0xf9fe0000-0xf9ffffff irq 29 at device 8.0 on pci6 > em0: Reserved 0x20000 bytes for rid 0x10 type 3 at 0xf9fe0000 > em0: Reserved 0x40 bytes for rid 0x20 type 4 at 0x2540 > em0: bpf attached > em0: Ethernet address: 00:0d:60:1a:4f:c6 > NMI ISA 34, EISA 0 > NMI ... going to debugger > [thread pid 0 tid 0 ] > Stopped at em_clear_hw_cntrs+0xc6: movl %eax,-0x4(%ebp) So em triggered an interrupt and you got an NMI out of it instead. What does 'show lapic' show? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Nov 16 19:54:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02FD916A49E; Thu, 16 Nov 2006 19:54:02 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF2EB43F0E; Thu, 16 Nov 2006 19:51:26 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGJpAKH074662; Thu, 16 Nov 2006 19:51:10 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGJpABS074630; Thu, 16 Nov 2006 19:51:10 GMT (envelope-from jkim) Message-Id: <200611161951.kAGJpABS074630@repoman.freebsd.org> From: Jung-uk Kim Date: Thu, 16 Nov 2006 19:51:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/regression/sysvmsg msgtest.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 19:54:02 -0000 jkim 2006-11-16 19:51:10 UTC FreeBSD src repository Modified files: tools/regression/sysvmsg msgtest.c Log: Fix message size tests for msgsnd(3) and msgrcv(3). msgsz is the length of actual message and it should not include size of message type. Revision Changes Path 1.2 +12 -8 src/tools/regression/sysvmsg/msgtest.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 20:13:54 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D55E116A4CE; Thu, 16 Nov 2006 20:13:54 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0477743DAD; Thu, 16 Nov 2006 20:12:51 +0000 (GMT) (envelope-from grehan@freebsd.org) Received: from [10.33.24.110] (nat-198-95-226-228.netapp.com [198.95.226.228]) by dommail.onthenet.com.au (MOS 3.5.7-GR) with ESMTP id CIA13262 (AUTH peterg@ptree32.com.au); Fri, 17 Nov 2006 06:12:18 +1000 (EST) Message-ID: <455CC65F.7090801@freebsd.org> Date: Thu, 16 Nov 2006 12:13:19 -0800 From: Peter Grehan User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8b) Gecko/20051014 MIME-Version: 1.0 To: mjacob@freebsd.org References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <200611151617.23125.jhb@freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> <455BDC68.2080603@samsco.org> <20061115194305.M7355@ns1.feral.com> <455BDFB7.9040303@samsco.org> <20061115200109.U7495@ns1.feral.com> In-Reply-To: <20061115200109.U7495@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 20:13:55 -0000 mjacob@freebsd.org wrote: > > see http://people.freebsd.org/~mjacob for 2 bootverbose files. Looks like you have an AMD Quartet :) The AMD 8131 HT-PCIX bridge doesn't support MSI. The first blacklist candidate. later, Peter. From owner-cvs-src@FreeBSD.ORG Thu Nov 16 20:29:11 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D75D16A40F for ; Thu, 16 Nov 2006 20:29:11 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 778C143D7B for ; Thu, 16 Nov 2006 20:28:53 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: by nf-out-0910.google.com with SMTP id x37so741153nfc for ; Thu, 16 Nov 2006 12:28:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=nmz0zvPABif9MKUmZ27JWqpVRMjwv3ZuIPuAKs+3GnMa8pl3E2XiVsWHdNLK/pA+lygFFdN02sjjCuxLCI+Xe7mBPCvtp0ZnwKFHpZi6plW1JQSb4eEG336hjPOY9AEJ+gCz+gvcoisaJGMt+5pvkohVlegc9thf/nEuuUltXss= Received: by 10.82.153.5 with SMTP id a5mr126063bue.1163708926788; Thu, 16 Nov 2006 12:28:46 -0800 (PST) Received: by 10.82.112.7 with HTTP; Thu, 16 Nov 2006 12:28:46 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2006 21:28:46 +0100 From: "Pawel Worach" To: "John Baldwin" In-Reply-To: <200611161401.09543.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <200611161401.09543.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 20:29:11 -0000 On 11/16/06, John Baldwin wrote: > On Thursday 16 November 2006 13:36, Pawel Worach wrote: > > On 11/15/06, John Baldwin wrote: > > > jhb 2006-11-15 20:04:57 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/bce if_bce.c > > > sys/dev/em if_em.c if_em.h > > > sys/dev/mpt mpt.h mpt_pci.c > > > Log: > > > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > > > devices that support a maximum of 1 message, and we use that 1 message > > > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > > > > > > > Hi John, > > > > This seems to cause an NMI here on a IBM x345 box, boot -v below. > > (It's frozen for about 1-2 seconds before the NMI fires) > > > > OK boot -v > > /boot/kernel/acpi.ko text=0x4d134 data=0x2540+0x1010 > > syms=[0x4+0x7cb0+0x4+0xaa13] > > GDB: no debug ports present > > KDB: debugger backends: ddb > > KDB: current backend: ddb > > SMAP type=01 base=0000000000000000 len=000000000009d400 > > SMAP type=02 base=000000000009d400 len=0000000000002c00 > > SMAP type=02 base=00000000000e0000 len=0000000000020000 > > SMAP type=01 base=0000000000100000 len=000000003fedb2c0 > > SMAP type=02 base=000000003ffe0000 len=0000000000020000 > > SMAP type=03 base=000000003ffdb2c0 len=0000000000004d40 > > SMAP type=02 base=00000000fec00000 len=0000000001400000 > > Copyright (c) 1992-2006 The FreeBSD Project. > > Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 > > The Regents of the University of California. All rights reserved. > > FreeBSD is a registered trademark of The FreeBSD Foundation. > > FreeBSD 7.0-CURRENT #0: Thu Nov 16 14:42:47 CET 2006 > > root@zero:/usr/obj/usr/src/sys/ZERO > > Using 16 colors for the VM-PQ tuning (512, 8) > > Preloaded elf kernel "/boot/kernel/kernel" at 0xc08e2000. > > Preloaded elf module "/boot/kernel/acpi.ko" at 0xc08e216c. > > MP Configuration Table version 1.4 found at 0xc009e2a0 > > Table 'FACP' at 0x3ffdff00 > > Table 'APIC' at 0x3ffdfe40 > > MADT: Found table at 0x3ffdfe40 > > APIC: Using the MADT enumerator. > > MADT: Found CPU APIC ID 0 ACPI ID 0: enabled > > SMP: Added CPU 0 (AP) > > MADT: Found CPU APIC ID 6 ACPI ID 1: enabled > > SMP: Added CPU 6 (AP) > > MADT: Found CPU APIC ID 1 ACPI ID 2: enabled > > SMP: Added CPU 1 (AP) > > MADT: Found CPU APIC ID 7 ACPI ID 3: enabled > > SMP: Added CPU 7 (AP) > > INTR: Adding local APIC 0 as a target > > ACPI APIC Table: > > Calibrating clock(s) ... i8254 clock: 1193166 Hz > > CLK_USE_I8254_CALIBRATION not specified - using default frequency > > Timecounter "i8254" frequency 1193182 Hz quality 0 > > Calibrating TSC clock ... TSC clock: 2793899688 Hz > > CPU: Intel(R) Xeon(TM) CPU 2.80GHz (2793.90-MHz 686-class CPU) > > Origin = "GenuineIntel" Id = 0xf29 Stepping = 9 > > > Features=0xbfebfbff > > Features2=0x4400 > > Logical CPUs per core: 2 > > > > Instruction TLB: 4 KB, 2 MB or 4 MB pages, fully associative, 64 entries > > Data TLB: 4 KB or 4 MB pages, fully associative, 64 entries > > 1st-level data cache: 8 KB, 4-way set associative, sectored cache, 64 > > byte line size > > Trace cache: 12K-uops, 8-way set associative > > 2nd-level cache: 512 KB, 8-way set associative, sectored cache, 64 > > byte line size > > real memory = 1073590272 (1023 MB) > > Physical memory chunk(s): > > 0x0000000000001000 - 0x000000000009cfff, 638976 bytes (156 pages) > > 0x0000000000100000 - 0x00000000003fffff, 3145728 bytes (768 pages) > > 0x0000000000c28000 - 0x000000003ed92fff, 1041674240 bytes (254315 pages) > > avail memory = 1041301504 (993 MB) > > INTR: Adding local APIC 6 as a target > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > cpu0 (BSP): APIC ID: 0 > > cpu1 (AP): APIC ID: 1 > > cpu2 (AP): APIC ID: 6 > > cpu3 (AP): APIC ID: 7 > > bios32: Found BIOS32 Service Directory header at 0xc00fd790 > > bios32: Entry = 0xfd7a1 (c00fd7a1) Rev = 0 Len = 1 > > pcibios: PCI BIOS entry at 0xf0000+0xd7dc > > pnpbios: Found PnP BIOS data at 0xc00fdf90 > > pnpbios: Entry = f0000:440f Rev = 1.0 > > Other BIOS signatures found: > > APIC: CPU 0 has ACPI ID 0 > > APIC: CPU 1 has ACPI ID 2 > > APIC: CPU 2 has ACPI ID 1 > > APIC: CPU 3 has ACPI ID 3 > > Security auditing service present > > BSM auditing present > > MADT: Found IO APIC ID 14, Interrupt 0 at 0xfec00000 > > ioapic0: Routing external 8259A's -> intpin 0 > > ioapic0: intpin 0 -> ExtINT (edge, high) > > ioapic0: intpin 1 -> ISA IRQ 1 (edge, high) > > ioapic0: intpin 2 -> ISA IRQ 2 (edge, high) > > ioapic0: intpin 3 -> ISA IRQ 3 (edge, high) > > ioapic0: intpin 4 -> ISA IRQ 4 (edge, high) > > ioapic0: intpin 5 -> ISA IRQ 5 (edge, high) > > ioapic0: intpin 6 -> ISA IRQ 6 (edge, high) > > ioapic0: intpin 7 -> ISA IRQ 7 (edge, high) > > ioapic0: intpin 8 -> ISA IRQ 8 (edge, high) > > ioapic0: intpin 9 -> ISA IRQ 9 (edge, high) > > ioapic0: intpin 10 -> ISA IRQ 10 (edge, high) > > ioapic0: intpin 11 -> ISA IRQ 11 (edge, high) > > ioapic0: intpin 12 -> ISA IRQ 12 (edge, high) > > ioapic0: intpin 13 -> ISA IRQ 13 (edge, high) > > ioapic0: intpin 14 -> ISA IRQ 14 (edge, high) > > ioapic0: intpin 15 -> ISA IRQ 15 (edge, high) > > MADT: Found IO APIC ID 13, Interrupt 16 at 0xfec01000 > > ioapic1: intpin 0 -> PCI IRQ 16 (level, low) > > ioapic1: intpin 1 -> PCI IRQ 17 (level, low) > > ioapic1: intpin 2 -> PCI IRQ 18 (level, low) > > ioapic1: intpin 3 -> PCI IRQ 19 (level, low) > > ioapic1: intpin 4 -> PCI IRQ 20 (level, low) > > ioapic1: intpin 5 -> PCI IRQ 21 (level, low) > > ioapic1: intpin 6 -> PCI IRQ 22 (level, low) > > ioapic1: intpin 7 -> PCI IRQ 23 (level, low) > > ioapic1: intpin 8 -> PCI IRQ 24 (level, low) > > ioapic1: intpin 9 -> PCI IRQ 25 (level, low) > > ioapic1: intpin 10 -> PCI IRQ 26 (level, low) > > ioapic1: intpin 11 -> PCI IRQ 27 (level, low) > > ioapic1: intpin 12 -> PCI IRQ 28 (level, low) > > ioapic1: intpin 13 -> PCI IRQ 29 (level, low) > > ioapic1: intpin 14 -> PCI IRQ 30 (level, low) > > ioapic1: intpin 15 -> PCI IRQ 31 (level, low) > > MADT: Found IO APIC ID 12, Interrupt 32 at 0xfec02000 > > ioapic2: intpin 0 -> PCI IRQ 32 (level, low) > > ioapic2: intpin 1 -> PCI IRQ 33 (level, low) > > ioapic2: intpin 2 -> PCI IRQ 34 (level, low) > > ioapic2: intpin 3 -> PCI IRQ 35 (level, low) > > ioapic2: intpin 4 -> PCI IRQ 36 (level, low) > > ioapic2: intpin 5 -> PCI IRQ 37 (level, low) > > ioapic2: intpin 6 -> PCI IRQ 38 (level, low) > > ioapic2: intpin 7 -> PCI IRQ 39 (level, low) > > ioapic2: intpin 8 -> PCI IRQ 40 (level, low) > > ioapic2: intpin 9 -> PCI IRQ 41 (level, low) > > ioapic2: intpin 10 -> PCI IRQ 42 (level, low) > > ioapic2: intpin 11 -> PCI IRQ 43 (level, low) > > ioapic2: intpin 12 -> PCI IRQ 44 (level, low) > > ioapic2: intpin 13 -> PCI IRQ 45 (level, low) > > ioapic2: intpin 14 -> PCI IRQ 46 (level, low) > > ioapic2: intpin 15 -> PCI IRQ 47 (level, low) > > MADT: Interrupt override: source 0, irq 2 > > ioapic0: Routing IRQ 0 -> intpin 2 > > ioapic0: intpin 2 trigger: edge > > ioapic0: intpin 2 polarity: high > > lapic0: Routing NMI -> LINT1 > > MADT: Ignoring local NMI routed to ACPI CPU 6 > > lapic6: Routing NMI -> LINT1 > > MADT: Ignoring local NMI routed to ACPI CPU 7 > > MADT: Forcing active-low polarity and level trigger for SCI > > ioapic0: intpin 3 polarity: low > > ioapic0: intpin 3 trigger: level > > ioapic2 irqs 32-47 on motherboard > > ioapic1 irqs 16-31 on motherboard > > ioapic0 irqs 0-15 on motherboard > > cpu0 BSP: > > ID: 0x00000000 VER: 0x00050014 LDR: 0x00000000 DFR: 0xffffffff > > lint0: 0x00010700 lint1: 0x00000400 TPR: 0x00000000 SVR: 0x000001ff > > timer: 0x000100ef therm: 0x00010000 err: 0x00010000 pcm: 0x00010000 > > null: > > random: > > mem: > > Pentium Pro MTRR support enabled > > io: > > npx0: INT 16 interface > > acpi0: on motherboard > > ioapic0: routing intpin 3 (ISA IRQ 3) to vector 48 > > acpi0: [MPSAFE] > > pci_open(1): mode 1 addr port (0x0cf8) is 0x80002800 > > pci_open(1a): mode1res=0x80000000 (0x80000000) > > pci_cfgcheck: device 0 [class=060000] [hdr=80] is there (id=00141166) > > pcibios: BIOS version 2.10 > > AcpiOsDerivePciId: bus 0 dev 15 func 2 > > acpi0: Power Button (fixed) > > acpi0: wakeup code va 0xd73cb000 pa 0x9c000 > > AcpiOsDerivePciId: bus 0 dev 0 func 0 > > AcpiOsDerivePciId: bus 0 dev 16 func 0 > > AcpiOsDerivePciId: bus 0 dev 16 func 2 > > AcpiOsDerivePciId: bus 0 dev 17 func 0 > > AcpiOsDerivePciId: bus 0 dev 17 func 2 > > acpi0: reservation of 460, 2 (4) failed > > ACPI timer: 1/2 0/3 1/2 1/2 0/3 1/2 1/2 1/2 0/3 1/2 -> 7 > > Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000 > > acpi_timer0: <32-bit timer at 3.579545MHz> port 0x488-0x48b on acpi0 > > pci_link0: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link1: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link2: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link3: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link4: Index IRQ Rtd Ref IRQs > > Initial Probe 0 10 N 0 10 > > Validation 0 10 N 0 10 > > After Disable 0 255 N 0 10 > > pci_link5: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link6: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link7: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link8: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link9: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link10: Index IRQ Rtd Ref IRQs > > Initial Probe 0 10 N 0 10 > > Validation 0 10 N 0 10 > > After Disable 0 255 N 0 10 > > pci_link11: Index IRQ Rtd Ref IRQs > > Initial Probe 0 9 N 0 9 > > Validation 0 9 N 0 9 > > After Disable 0 255 N 0 9 > > pci_link12: Index IRQ Rtd Ref IRQs > > Initial Probe 0 9 N 0 9 > > Validation 0 9 N 0 9 > > After Disable 0 255 N 0 9 > > pci_link13: Index IRQ Rtd Ref IRQs > > Initial Probe 0 11 N 0 11 > > Validation 0 11 N 0 11 > > After Disable 0 255 N 0 11 > > pci_link14: Index IRQ Rtd Ref IRQs > > Initial Probe 0 3 N 0 3 > > Validation 0 3 N 0 3 > > After Disable 0 255 N 0 3 > > pci_link15: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link16: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link17: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link18: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link19: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link20: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link21: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link22: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link23: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link24: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link25: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link26: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link27: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link28: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link29: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link30: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link31: Index IRQ Rtd Ref IRQs > > Initial Probe 0 255 N 0 none > > Validation 0 255 N 0 none > > After Disable 0 255 N 0 none > > pci_link32: Index IRQ Rtd Ref IRQs > > Initial Probe 0 11 N 0 11 > > Validation 0 11 N 0 11 > > After Disable 0 255 N 0 11 > > cpu0: on acpi0 > > cpu1: on acpi0 > > cpu2: on acpi0 > > cpu3: on acpi0 > > pcib0: on acpi0 > > ACPI: Found matching pin for 0.15.INTA at func 2: 11 > > pci0: on pcib0 > > pci0: physical bus=0 > > found-> vendor=0x1166, dev=0x0014, revid=0x33 > > bus=0, slot=0, func=0 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0014, revid=0x00 > > bus=0, slot=0, func=1 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0014, revid=0x00 > > bus=0, slot=0, func=2 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1002, dev=0x4752, revid=0x27 > > bus=0, slot=6, func=0 > > class=03-00-00, hdrtype=0x00, mfdev=0 > > cmdreg=0x0087, statreg=0x0290, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x00 (0 ns) > > intpin=a, irq=10 > > powerspec 2 supports D0 D1 D2 D3 current D0 > > map[10]: type 1, range 32, base 0xfd000000, size 24, enabled > > map[14]: type 4, range 32, base 0x2400, size 8, enabled > > map[18]: type 1, range 32, base 0xfebff000, size 12, enabled > > pcib0: matched entry for 0.6.INTA > > pcib0: slot 6 INTA hardwired to IRQ 26 > > found-> vendor=0x1166, dev=0x0201, revid=0x93 > > bus=0, slot=15, func=0 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0147, statreg=0x2200, cachelnsz=0 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0212, revid=0x93 > > bus=0, slot=15, func=1 > > class=01-01-82, hdrtype=0x00, mfdev=1 > > cmdreg=0x0155, statreg=0x0200, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > map[20]: type 4, range 32, base 0x700, size 4, enabled > > found-> vendor=0x1166, dev=0x0220, revid=0x05 > > bus=0, slot=15, func=2 > > class=0c-03-10, hdrtype=0x00, mfdev=1 > > cmdreg=0x0157, statreg=0x0280, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x50 (20000 ns) > > intpin=a, irq=11 > > map[10]: type 1, range 32, base 0xfebfe000, size 12, enabled > > pcib0: matched entry for 0.15.INTA (src \LPUS:0) > > ioapic0: Changing trigger for pin 11 to level > > ioapic0: Changing polarity for pin 11 to low > > pcib0: slot 15 INTA routed to irq 11 via \LPUS > > found-> vendor=0x1166, dev=0x0225, revid=0x00 > > bus=0, slot=15, func=3 > > class=06-01-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0144, statreg=0x0200, cachelnsz=0 (dwords) > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0101, revid=0x05 > > bus=0, slot=16, func=0 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0142, statreg=0x22b0, cachelnsz=0 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0101, revid=0x05 > > bus=0, slot=16, func=2 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0101, revid=0x05 > > bus=0, slot=17, func=0 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > found-> vendor=0x1166, dev=0x0101, revid=0x05 > > bus=0, slot=17, func=2 > > class=06-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) > > vgapci0: port 0x2400-0x24ff mem > > 0xfd000000-0xfdffffff,0xfebff000-0xfebfffff irq 26 at device 6.0 on > > pci0 > > atapci0: port > > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0x700-0x70f at device 15.1 on pci0 > > atapci0: Reserved 0x10 bytes for rid 0x20 type 4 at 0x700 > > ata0: on atapci0 > > atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 > > atapci0: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 > > ata0: reset tp1 mask=03 ostat0=50 ostat1=00 > > ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb > > ata0: stat1=0x00 err=0x04 lsb=0x00 msb=0x00 > > ata0: reset tp2 stat0=00 stat1=00 devices=0x4 > > ioapic0: routing intpin 14 (ISA IRQ 14) to vector 49 > > ata0: [MPSAFE] > > ata1: on atapci0 > > atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 > > atapci0: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 > > ata1: reset tp1 mask=00 ostat0=ff ostat1=ff > > ioapic0: routing intpin 15 (ISA IRQ 15) to vector 50 > > ata1: [MPSAFE] > > pci0: at device 15.2 (no driver attached) > > isab0: at device 15.3 on pci0 > > isa0: on isab0 > > pcib1: on acpi0 > > pci2: on pcib1 > > pci2: physical bus=2 > > found-> vendor=0x8086, dev=0x1229, revid=0x0c > > bus=2, slot=3, func=0 > > class=02-00-00, hdrtype=0x00, mfdev=0 > > cmdreg=0x0157, statreg=0x0290, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x38 (14000 > ns) > > intpin=a, irq=10 > > powerspec 2 supports D0 D1 D2 D3 current D0 > > map[10]: type 1, range 32, base 0xfbfff000, size 12, enabled > > map[14]: type 4, range 32, base 0x2500, size 6, enabled > > map[18]: type 1, range 32, base 0xfbfc0000, size 17, enabled > > pcib1: matched entry for 2.3.INTA > > pcib1: slot 3 INTA hardwired to IRQ 20 > > fxp0: port 0x2500-0x253f mem > > 0xfbfff000-0xfbffffff,0xfbfc0000-0xfbfdffff irq 20 at device 3.0 on > > pci2 > > fxp0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xfbfff000 > > fxp0: using memory space register mapping > > fxp0: PCI IDs: 8086 1229 1014 01f1 000c > > fxp0: Dynamic Standby mode is disabled > > miibus0: on fxp0 > > inphy0: on miibus0 > > inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto > > fxp0: bpf attached > > fxp0: Ethernet address: 00:0e:0c:2e:98:88 > > ioapic1: routing intpin 4 (PCI IRQ 20) to vector 51 > > fxp0: [MPSAFE] > > pcib2: on acpi0 > > pci4: on pcib2 > > pci4: physical bus=4 > > pcib3: on acpi0 > > pci6: on pcib3 > > pci6: physical bus=6 > > found-> vendor=0x8086, dev=0x1010, revid=0x01 > > bus=6, slot=8, func=0 > > class=02-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) > > intpin=a, irq=11 > > powerspec 2 supports D0 D3 current D0 > > MSI supports 1 message, 64 bit > > map[10]: type 1, range 64, base 0xf9fe0000, size 17, enabled > > map[20]: type 4, range 32, base 0x2540, size 6, enabled > > pcib3: matched entry for 6.8.INTA > > pcib3: slot 8 INTA hardwired to IRQ 29 > > found-> vendor=0x8086, dev=0x1010, revid=0x01 > > bus=6, slot=8, func=1 > > class=02-00-00, hdrtype=0x00, mfdev=1 > > cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) > > lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) > > intpin=b, irq=3 > > powerspec 2 supports D0 D3 current D0 > > MSI supports 1 message, 64 bit > > map[10]: type 1, range 64, base 0xf9fc0000, size 17, enabled > > map[20]: type 4, range 32, base 0x2580, size 6, enabled > > pcib3: matched entry for 6.8.INTB > > pcib3: slot 8 INTB hardwired to IRQ 30 > > em0: port > > 0x2540-0x257f mem 0xf9fe0000-0xf9ffffff irq 29 at device 8.0 on pci6 > > em0: Reserved 0x20000 bytes for rid 0x10 type 3 at 0xf9fe0000 > > em0: Reserved 0x40 bytes for rid 0x20 type 4 at 0x2540 > > em0: bpf attached > > em0: Ethernet address: 00:0d:60:1a:4f:c6 > > NMI ISA 34, EISA 0 > > NMI ... going to debugger > > [thread pid 0 tid 0 ] > > Stopped at em_clear_hw_cntrs+0xc6: movl %eax,-0x4(%ebp) > > So em triggered an interrupt and you got an NMI out of it instead. What > does 'show lapic' show? > db> show lapic lapic ID = 0 version = 1.4 max LVT = 5 SVR = ff (enabled) TPR = 00 In-service Interrupts: TMR Interrupts: IRR Interrupts: -- Pawel From owner-cvs-src@FreeBSD.ORG Thu Nov 16 21:50:06 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E5DF16A407; Thu, 16 Nov 2006 21:50:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0674843D5D; Thu, 16 Nov 2006 21:50:05 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAGLnu9r043616; Thu, 16 Nov 2006 16:49:56 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Peter Grehan Date: Thu, 16 Nov 2006 16:44:36 -0500 User-Agent: KMail/1.9.1 References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <20061115200109.U7495@ns1.feral.com> <455CC65F.7090801@freebsd.org> In-Reply-To: <455CC65F.7090801@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611161644.37398.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 16 Nov 2006 16:49:59 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2200/Thu Nov 16 09:10:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 21:50:06 -0000 On Thursday 16 November 2006 15:13, Peter Grehan wrote: > mjacob@freebsd.org wrote: > > > > see http://people.freebsd.org/~mjacob for 2 bootverbose files. > > Looks like you have an AMD Quartet :) > > The AMD 8131 HT-PCIX bridge doesn't support MSI. The first blacklist > candidate. Is it at function 0.0.0 or is it a (virtual) PCI-PCI bridge? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Nov 16 22:32:31 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 225E516A407; Thu, 16 Nov 2006 22:32:31 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D91FC43D62; Thu, 16 Nov 2006 22:32:27 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGMWRHJ018537; Thu, 16 Nov 2006 22:32:27 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGMWRwb018536; Thu, 16 Nov 2006 22:32:27 GMT (envelope-from brueffer) Message-Id: <200611162232.kAGMWRwb018536@repoman.freebsd.org> From: Christian Brueffer Date: Thu, 16 Nov 2006 22:32:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 Makefile uhid.4 uhidev.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 22:32:31 -0000 brueffer 2006-11-16 22:32:27 UTC FreeBSD src repository Modified files: share/man/man4 Makefile uhid.4 Removed files: share/man/man4 uhidev.4 Log: Remove uhidev.4 and references to it, the corresponding code was never imported from NetBSD. Submitted by: markus MFC after: 1 week Revision Changes Path 1.367 +0 -1 src/share/man/man4/Makefile 1.6 +1 -2 src/share/man/man4/uhid.4 1.4 +0 -78 src/share/man/man4/uhidev.4 (dead) From owner-cvs-src@FreeBSD.ORG Thu Nov 16 22:34:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3066916A407; Thu, 16 Nov 2006 22:34:37 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF3A443DAD; Thu, 16 Nov 2006 22:34:17 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGMYHVq018945; Thu, 16 Nov 2006 22:34:17 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGMYHCc018943; Thu, 16 Nov 2006 22:34:17 GMT (envelope-from brueffer) Message-Id: <200611162234.kAGMYHCc018943@repoman.freebsd.org> From: Christian Brueffer Date: Thu, 16 Nov 2006 22:34:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 22:34:37 -0000 brueffer 2006-11-16 22:34:17 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Note uhidev.4 removal. Approved by: rwatson (mentor) MFC after: 1 week Revision Changes Path 1.61 +2 -0 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Thu Nov 16 23:02:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 259D016A49E; Thu, 16 Nov 2006 23:02:39 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F53143D5A; Thu, 16 Nov 2006 23:02:38 +0000 (GMT) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGN2cQU023251; Thu, 16 Nov 2006 23:02:38 GMT (envelope-from mohans@repoman.freebsd.org) Received: (from mohans@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGN2ccx023250; Thu, 16 Nov 2006 23:02:38 GMT (envelope-from mohans) Message-Id: <200611162302.kAGN2ccx023250@repoman.freebsd.org> From: Mohan Srinivasan Date: Thu, 16 Nov 2006 23:02:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:02:39 -0000 mohans 2006-11-16 23:02:38 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_vnops.c Log: Fix to readdir+ reply handling. When inserting an entry into the namecache, initialize the nfsnode's ctime. Otherwise a subsequent lookup purges the just entered namecache entry. Revision Changes Path 1.271 +2 -0 src/sys/nfsclient/nfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 23:03:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 356AF16A412; Thu, 16 Nov 2006 23:03:47 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E694543D6D; Thu, 16 Nov 2006 23:03:46 +0000 (GMT) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGN3kK5024745; Thu, 16 Nov 2006 23:03:46 GMT (envelope-from mohans@repoman.freebsd.org) Received: (from mohans@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGN3k0m024744; Thu, 16 Nov 2006 23:03:46 GMT (envelope-from mohans) Message-Id: <200611162303.kAGN3k0m024744@repoman.freebsd.org> From: Mohan Srinivasan Date: Thu, 16 Nov 2006 23:03:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_node.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:03:47 -0000 mohans 2006-11-16 23:03:46 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_node.c Log: vfs_hash_insert() vputs() the losing vnode before returning, in the event of a race where a duplicate vnode is entered into the vfs hash. nfs_nget() shouldn't be releasing the vnode in that case. Revision Changes Path 1.83 +1 -2 src/sys/nfsclient/nfs_node.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 23:09:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7056416A412; Thu, 16 Nov 2006 23:09:36 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB09443D64; Thu, 16 Nov 2006 23:09:35 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGN9Zal025335; Thu, 16 Nov 2006 23:09:35 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGN9ZRP025334; Thu, 16 Nov 2006 23:09:35 GMT (envelope-from kensmith) Message-Id: <200611162309.kAGN9ZRP025334@repoman.freebsd.org> From: Ken Smith Date: Thu, 16 Nov 2006 23:09:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:09:36 -0000 kensmith 2006-11-16 23:09:35 UTC FreeBSD src repository Modified files: release Makefile Log: Move the documentation to its own separate disc to make room for more packages on disc2. This will also let users decide if they want to have a CD of the docs at all - unless they're disconnected from the net they will probably find the Web site more useful. Reviewed by: ru MFC after: 3 days Revision Changes Path 1.918 +13 -2 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Nov 16 23:47:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6344816A416; Thu, 16 Nov 2006 23:47:21 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7867C43D6D; Thu, 16 Nov 2006 23:47:17 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAGNlHeA031367; Thu, 16 Nov 2006 23:47:17 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAGNlHQE031366; Thu, 16 Nov 2006 23:47:17 GMT (envelope-from mjacob) Message-Id: <200611162347.kAGNlHQE031366@repoman.freebsd.org> From: Matt Jacob Date: Thu, 16 Nov 2006 23:47:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:47:21 -0000 mjacob 2006-11-16 23:47:17 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_cam.c Log: Finally fix local command responses to set residual correctly. This allows us to play nicely on SANs when we have target mode enabled in f/w but have neither the scsi_targbh enabled or scsi_targ with a target enabled. Revision Changes Path 1.39 +35 -19 src/sys/dev/mpt/mpt_cam.c From owner-cvs-src@FreeBSD.ORG Thu Nov 16 23:53:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2A7D16A403; Thu, 16 Nov 2006 23:53:53 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA62B43D6B; Thu, 16 Nov 2006 23:53:48 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAGNpSur019031; Thu, 16 Nov 2006 16:51:29 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 16 Nov 2006 16:52:07 -0700 (MST) Message-Id: <20061116.165207.1661914048.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20061116090412.GB37133@comp.chem.msu.su> References: <20061113214928.P76443@delplex.bde.org> <20061113.101958.-861030824.imp@bsdimp.com> <20061116090412.GB37133@comp.chem.msu.su> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 16 Nov 2006 16:51:30 -0700 (MST) Cc: src-committers@FreeBSD.ORG, bde@zeta.org.au, jkoshy@FreeBSD.ORG, cvs-all@FreeBSD.ORG, phk@phk.freebsd.dk, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:53:53 -0000 In message: <20061116090412.GB37133@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Nov 13, 2006 at 10:19:58AM -0700, M. Warner Losh wrote: : > : : > : BTW, you are responsible for the __packed in . Please remove : > : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. : > : The only danger is if something has grown to depend on __packed reducing : > : alignment as a side effect. E.g., suppose we had a byte string containing : > : a bytewise copy of a struct ip. If the copy might be misaligned, then it : > : should be copied to an actual struct ip before accessing it as a struct, : > : but code that accesses it directly using ((struct ip *)&bs[N]) would work : > : now due to the reduced alignment. Places that really need __packed should : > : probably use __aligned() to restore the natural alignment. : > : > DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. : > If you want to remove it, then you must make sure arm works right : > after it because I'll add it back. : : Many years ago I was taught that comments in code could help to : avoid such clashes in software development. Is this true no more? ;-) You don't add comments like: i++; // Add one to i. This is a similar class. It is for any compiler that has differing alignment requirements than i386. Warner From owner-cvs-src@FreeBSD.ORG Fri Nov 17 00:19:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2C1916A403; Fri, 17 Nov 2006 00:19:57 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F95843D78; Fri, 17 Nov 2006 00:19:56 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAH0JtvB037533; Fri, 17 Nov 2006 00:19:55 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAH0JtMG037532; Fri, 17 Nov 2006 00:19:55 GMT (envelope-from mjacob) Message-Id: <200611170019.kAH0JtMG037532@repoman.freebsd.org> From: Matt Jacob Date: Fri, 17 Nov 2006 00:19:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 00:19:58 -0000 mjacob 2006-11-17 00:19:55 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_cam.c Log: *smack* - forgot to do i386 compile, so last commit broke things. Revision Changes Path 1.40 +2 -2 src/sys/dev/mpt/mpt_cam.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 00:32:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC57A16A407; Fri, 17 Nov 2006 00:32:54 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E8D543D58; Fri, 17 Nov 2006 00:32:54 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAH0WsT6040134; Fri, 17 Nov 2006 00:32:54 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAH0WsP9040133; Fri, 17 Nov 2006 00:32:54 GMT (envelope-from obrien) Message-Id: <200611170032.kAH0WsP9040133@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 17 Nov 2006 00:32:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys Makefile src/libexec/bootpd bootpd.c src/contrib/pf/authpf authpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 00:32:55 -0000 obrien 2006-11-17 00:32:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys Makefile libexec/bootpd bootpd.c contrib/pf/authpf authpf.c Log: Fix ARM build: 1. NO_FORTH needs to be defined 2. bootpd.c rev 1.24: make tv_sec a time_t 3. authpf.c rev 1.7: handle timeval.tv_sec change from long to time_t Approved by: re(BMAH) Revision Changes Path 1.6.2.1 +9 -1 src/contrib/pf/authpf/authpf.c 1.23.2.1 +3 -2 src/libexec/bootpd/bootpd.c 1.33.2.3 +4 -0 src/sys/Makefile From owner-cvs-src@FreeBSD.ORG Fri Nov 17 00:54:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBAD216A4D4; Fri, 17 Nov 2006 00:54:34 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CA1743D5D; Fri, 17 Nov 2006 00:53:47 +0000 (GMT) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAH0rdKF051570; Fri, 17 Nov 2006 00:53:39 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAH0rd6N051569; Fri, 17 Nov 2006 00:53:39 GMT (envelope-from kevlo) Message-Id: <200611170053.kAH0rd6N051569@repoman.freebsd.org> From: Kevin Lo Date: Fri, 17 Nov 2006 00:53:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 00:54:35 -0000 kevlo 2006-11-17 00:53:39 UTC FreeBSD src repository Modified files: sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c Log: Compile -- remove an unused global variable avail_end. Approved by: cognet Revision Changes Path 1.4 +0 -1 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.25 +0 -1 src/sys/arm/xscale/i80321/iq31244_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 02:25:25 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32FE116A412; Fri, 17 Nov 2006 02:25:25 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5A9043D4C; Fri, 17 Nov 2006 02:25:23 +0000 (GMT) (envelope-from grehan@freebsd.org) Received: from [10.33.24.110] (nat-198-95-226-228.netapp.com [198.95.226.228]) by dommail.onthenet.com.au (MOS 3.5.7-GR) with ESMTP id CIA69608 (AUTH peterg@ptree32.com.au); Fri, 17 Nov 2006 12:25:19 +1000 (EST) Message-ID: <455D1DCB.1080906@freebsd.org> Date: Thu, 16 Nov 2006 18:26:19 -0800 From: Peter Grehan User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8b) Gecko/20051014 MIME-Version: 1.0 To: John Baldwin References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <20061115200109.U7495@ns1.feral.com> <455CC65F.7090801@freebsd.org> <200611161644.37398.jhb@freebsd.org> In-Reply-To: <200611161644.37398.jhb@freebsd.org> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 02:25:25 -0000 >> The AMD 8131 HT-PCIX bridge doesn't support MSI. The first blacklist >>candidate. > > Is it at function 0.0.0 or is it a (virtual) PCI-PCI bridge? No - the relevant lines from Matt's log look like: found-> vendor=0x1022, dev=0x7450, revid=0x12 bus=8, slot=1, func=0 class=06-04-00, hdrtype=0x01, mfdev=1 cmdreg=0x0017, statreg=0x0230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x04 (1000 ns), maxlat=0x00 (0 ns) later, Peter. From owner-cvs-src@FreeBSD.ORG Fri Nov 17 04:24:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26EFA16A407; Fri, 17 Nov 2006 04:24:34 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D789343D46; Fri, 17 Nov 2006 04:24:33 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAH4OXrI095690; Fri, 17 Nov 2006 04:24:33 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAH4OXRd095688; Fri, 17 Nov 2006 04:24:33 GMT (envelope-from kensmith) Message-Id: <200611170424.kAH4OXRd095688@repoman.freebsd.org> From: Ken Smith Date: Fri, 17 Nov 2006 04:24:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/scripts package-split.py X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 04:24:34 -0000 kensmith 2006-11-17 04:24:33 UTC FreeBSD src repository Modified files: release/scripts package-split.py Log: Alpha no longer supported. Noticed by: ru@ Revision Changes Path 1.15 +1 -3 src/release/scripts/package-split.py From owner-cvs-src@FreeBSD.ORG Fri Nov 17 05:10:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EF9E16A4A7; Fri, 17 Nov 2006 05:10:42 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEE5F43D46; Fri, 17 Nov 2006 05:10:41 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAH5AffJ011507; Fri, 17 Nov 2006 05:10:41 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAH5AfBl011506; Fri, 17 Nov 2006 05:10:41 GMT (envelope-from kensmith) Message-Id: <200611170510.kAH5AfBl011506@repoman.freebsd.org> From: Ken Smith Date: Fri, 17 Nov 2006 05:10:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/scripts package-split.py X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 05:10:42 -0000 kensmith 2006-11-17 05:10:41 UTC FreeBSD src repository Modified files: release/scripts package-split.py Log: Shift to vim-lite package because vim package doesn't build at the moment. MFC after: 3 days Revision Changes Path 1.16 +1 -1 src/release/scripts/package-split.py From owner-cvs-src@FreeBSD.ORG Fri Nov 17 06:56:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6BE716A415; Fri, 17 Nov 2006 06:56:08 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22D8543D46; Fri, 17 Nov 2006 06:56:06 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id kAH6u2pg058694; Fri, 17 Nov 2006 09:56:03 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id kAH6ttmQ058691; Fri, 17 Nov 2006 09:55:55 +0300 (MSK) (envelope-from yar) Date: Fri, 17 Nov 2006 09:55:55 +0300 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20061117065555.GE49602@comp.chem.msu.su> References: <20061113214928.P76443@delplex.bde.org> <20061113.101958.-861030824.imp@bsdimp.com> <20061116090412.GB37133@comp.chem.msu.su> <20061116.165207.1661914048.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061116.165207.1661914048.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.ORG, bde@zeta.org.au, jkoshy@FreeBSD.ORG, cvs-all@FreeBSD.ORG, phk@phk.freebsd.dk, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 06:56:08 -0000 On Thu, Nov 16, 2006 at 04:52:07PM -0700, M. Warner Losh wrote: > In message: <20061116090412.GB37133@comp.chem.msu.su> > Yar Tikhiy writes: > : On Mon, Nov 13, 2006 at 10:19:58AM -0700, M. Warner Losh wrote: > : > : > : > : BTW, you are responsible for the __packed in . Please remove > : > : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. > : > : The only danger is if something has grown to depend on __packed reducing > : > : alignment as a side effect. E.g., suppose we had a byte string containing > : > : a bytewise copy of a struct ip. If the copy might be misaligned, then it > : > : should be copied to an actual struct ip before accessing it as a struct, > : > : but code that accesses it directly using ((struct ip *)&bs[N]) would work > : > : now due to the reduced alignment. Places that really need __packed should > : > : probably use __aligned() to restore the natural alignment. > : > > : > DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. > : > If you want to remove it, then you must make sure arm works right > : > after it because I'll add it back. > : > : Many years ago I was taught that comments in code could help to > : avoid such clashes in software development. Is this true no more? ;-) > > You don't add comments like: > > i++; // Add one to i. > > This is a similar class. It is for any compiler that has differing > alignment requirements than i386. This is an oversimplification of the case. If it were so simple, no doubts about it would be raised. That's why I suggested adding a comment explaining that historically struct ip was lucky to be packed/aligned properly, but that wasn't backed by the C standard in fact, and eventually architectures appeared, e.g., ARM, which broke the false assumption. It's a rather edifying case. Then you'll have a smaller chance of having to yell in capital letters again, "DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT." -- hopefully, not only regarding struct ip. -- Yar From owner-cvs-src@FreeBSD.ORG Fri Nov 17 08:33:16 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00DE416A47B; Fri, 17 Nov 2006 08:33:16 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7335A43D7D; Fri, 17 Nov 2006 08:33:09 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id DAD5B328060; Fri, 17 Nov 2006 19:33:07 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 6AA5B8C04; Fri, 17 Nov 2006 19:33:06 +1100 (EST) Date: Fri, 17 Nov 2006 19:33:01 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Yar Tikhiy In-Reply-To: <20061116090412.GB37133@comp.chem.msu.su> Message-ID: <20061117192049.H10708@delplex.bde.org> References: <3801.1163410519@critter.freebsd.dk> <20061113214928.P76443@delplex.bde.org> <20061113.101958.-861030824.imp@bsdimp.com> <20061116090412.GB37133@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jkoshy@freebsd.org, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 08:33:16 -0000 On Thu, 16 Nov 2006, Yar Tikhiy wrote: > On Mon, Nov 13, 2006 at 10:19:58AM -0700, M. Warner Losh wrote: >> : >> : BTW, you are responsible for the __packed in . Please remove >> : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. >> : The only danger is if something has grown to depend on __packed reducing >> : alignment as a side effect. E.g., suppose we had a byte string containing >> : a bytewise copy of a struct ip. If the copy might be misaligned, then it >> : should be copied to an actual struct ip before accessing it as a struct, >> : but code that accesses it directly using ((struct ip *)&bs[N]) would work >> : now due to the reduced alignment. Places that really need __packed should >> : probably use __aligned() to restore the natural alignment. >> >> DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. >> If you want to remove it, then you must make sure arm works right >> after it because I'll add it back. > > Many years ago I was taught that comments in code could help to > avoid such clashes in software development. Is this true no more? ;-) Apparently not. There has always been a relevant comment in : %%% /* * Mbuf adjust factor to force 32-bit alignment of IP header. * Drivers should do m_adj(m, ETHER_ALIGN) when setting up a * receive so the upper layers get the IP header properly aligned * past the 14-byte Ethernet header. */ #define ETHER_ALIGN 2 /* driver adjust for IP hdr alignment */ %%% Bruce From owner-cvs-src@FreeBSD.ORG Fri Nov 17 09:48:17 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFCB916A4F1; Fri, 17 Nov 2006 09:48:17 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5011343D5C; Fri, 17 Nov 2006 09:48:17 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 4A7E46E2AA; Fri, 17 Nov 2006 20:48:15 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 4A1FA8C1B; Fri, 17 Nov 2006 20:48:14 +1100 (EST) Date: Fri, 17 Nov 2006 20:48:13 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Yar Tikhiy In-Reply-To: <20061117065555.GE49602@comp.chem.msu.su> Message-ID: <20061117201432.X11101@delplex.bde.org> References: <20061113214928.P76443@delplex.bde.org> <20061113.101958.-861030824.imp@bsdimp.com> <20061116090412.GB37133@comp.chem.msu.su> <20061116.165207.1661914048.imp@bsdimp.com> <20061117065555.GE49602@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jkoshy@freebsd.org, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 09:48:18 -0000 On Fri, 17 Nov 2006, Yar Tikhiy wrote: > On Thu, Nov 16, 2006 at 04:52:07PM -0700, M. Warner Losh wrote: >> In message: <20061116090412.GB37133@comp.chem.msu.su> >> Yar Tikhiy writes: >> : Many years ago I was taught that comments in code could help to >> : avoid such clashes in software development. Is this true no more? ;-) >> >> You don't add comments like: >> >> i++; // Add one to i. >> >> This is a similar class. It is for any compiler that has differing >> alignment requirements than i386. But you do add comments like: i++; /* Don't add 1 to i (sic). */ when `i' is a const variable in magic device memory that needs to be used by read/add 1/write (where the non-atomicness of this doesn't matter for some reason). > This is an oversimplification of the case. If it were so simple, > no doubts about it would be raised. That's why I suggested adding > a comment explaining that historically struct ip was lucky to be > packed/aligned properly, but that wasn't backed by the C standard > in fact, and eventually architectures appeared, e.g., ARM, which > broke the false assumption. It's a rather edifying case. Then There is no luck about the alignment. Structs are always aligned, especially for arm, unless you break them using __packed. It never took much luck for the struct to be packed, since the struct has its largest members at the end so padding for alignment would affect most arches. It now doesn't take any luck to detect mispacking, since packing is now __CTASSERT()ed. Packing occurs naturally wthout using __packed for all arches supported by FreeBSD and Linux-2.6.10 (**), especially for arm since arm is on 32-bits so padding at the end to make the struct size a multiple of 64 bits would be weird. > you'll have a smaller chance of having to yell in capital letters > again, "DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO > WORK RIGHT." -- hopefully, not only regarding struct ip. For that the comment should be something like: __packed; /* Align (sic) to work around bugs on arm (*). */ but I doubt that arm is that broken. (*) See this thread for more details. (**) Linux-2.6.10 seems to have only struct iphdr, and has gratuitous unportabilities in that like the ones that were removed in FreeBSD in the commit that added __packed: it uses bitfields to unportabalize the header length and version, and endianness ifdefs to work around the unportabilities; in addition, it uses bitfields of type char to additionally unportabalize the header length and version. Bruce From owner-cvs-src@FreeBSD.ORG Fri Nov 17 11:14:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03E2E16A403; Fri, 17 Nov 2006 11:14:13 +0000 (UTC) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F26D643DC9; Fri, 17 Nov 2006 11:14:01 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHBDmjQ005285; Fri, 17 Nov 2006 11:13:48 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHBDm0J005284; Fri, 17 Nov 2006 11:13:48 GMT (envelope-from sos) Message-Id: <200611171113.kAHBDm0J005284@repoman.freebsd.org> From: Søren Schmidt Date: Fri, 17 Nov 2006 11:13:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata ata-all.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 11:14:13 -0000 sos 2006-11-17 11:13:47 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c Log: Deal more generically with the byteswap needed on !littleendian HW. Account for the odd layout on ARM bigendian HW. Revision Changes Path 1.275 +2 -2 src/sys/dev/ata/ata-all.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 11:56:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 469EB16A40F; Fri, 17 Nov 2006 11:56:57 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03A4A43D60; Fri, 17 Nov 2006 11:56:57 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHBuudv009844; Fri, 17 Nov 2006 11:56:56 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHBuuUc009843; Fri, 17 Nov 2006 11:56:56 GMT (envelope-from cognet) Message-Id: <200611171156.kAHBuuUc009843@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 17 Nov 2006 11:56:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm nexus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 11:56:57 -0000 cognet 2006-11-17 11:56:56 UTC FreeBSD src repository Modified files: sys/arm/arm nexus.c Log: Erm we really want to mask all interrupts in the range, just not the first one. Submitted by: ru Revision Changes Path 1.10 +1 -1 src/sys/arm/arm/nexus.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 14:52:42 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4954816A415; Fri, 17 Nov 2006 14:52:42 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2065943D49; Fri, 17 Nov 2006 14:52:39 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHEqduG052470; Fri, 17 Nov 2006 14:52:39 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHEqchQ052469; Fri, 17 Nov 2006 14:52:39 GMT (envelope-from kib) Message-Id: <200611171452.kAHEqchQ052469@repoman.freebsd.org> From: Konstantin Belousov Date: Fri, 17 Nov 2006 14:52:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/procfs procfs_ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 14:52:42 -0000 kib 2006-11-17 14:52:38 UTC FreeBSD src repository Modified files: sys/fs/procfs procfs_ioctl.c Log: Wake up PIOCWAIT handler on the process exit in addition to the stop events. &p->p_stype is explicitely woken up on process exit for us. Now, truss /nonexistent exits with error instead of waiting until killed by signal. Reported by: Nikos Vassiliadis nvass at teledomenet gr Reviewed by: jhb MFC after: 1 week Revision Changes Path 1.15 +2 -2 src/sys/fs/procfs/procfs_ioctl.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 16:37:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C45416A407; Fri, 17 Nov 2006 16:37:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08E0243D58; Fri, 17 Nov 2006 16:37:36 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHGbZLJ073764; Fri, 17 Nov 2006 16:37:35 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHGbZJd073763; Fri, 17 Nov 2006 16:37:35 GMT (envelope-from jhb) Message-Id: <200611171637.kAHGbZJd073763@repoman.freebsd.org> From: John Baldwin Date: Fri, 17 Nov 2006 16:37:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 db_trace.c src/sys/i386/i386 db_trace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 16:37:36 -0000 jhb 2006-11-17 16:37:35 UTC FreeBSD src repository Modified files: sys/amd64/amd64 db_trace.c sys/i386/i386 db_trace.c Log: A few more style fixes. Revision Changes Path 1.78 +3 -4 src/sys/amd64/amd64/db_trace.c 1.77 +4 -5 src/sys/i386/i386/db_trace.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 16:41:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD00E16A407; Fri, 17 Nov 2006 16:41:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A4C043D53; Fri, 17 Nov 2006 16:41:04 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHGf3Xp074089; Fri, 17 Nov 2006 16:41:03 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHGf3Wt074086; Fri, 17 Nov 2006 16:41:03 GMT (envelope-from jhb) Message-Id: <200611171641.kAHGf3Wt074086@repoman.freebsd.org> From: John Baldwin Date: Fri, 17 Nov 2006 16:41:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c io_apic.c src/sys/i386/i386 intr_machdep.c io_apic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 16:41:04 -0000 jhb 2006-11-17 16:41:03 UTC FreeBSD src repository Modified files: sys/amd64/amd64 intr_machdep.c io_apic.c sys/i386/i386 intr_machdep.c io_apic.c Log: Trim some noise from bootverbose: - Drop the printf in intr_machdep.c when we assign an interrupt souce to a CPU. Each source already has a more detailed printf. - Don't output a line for each ioapic pin showing its initial state, this has outlived its usefulness. - When an APIC enumerator sets the bus, polarity, or trigger mode of an ioapic pin, just return success without printing anything if the new value matches the current one. MFC after: 2 weeks Revision Changes Path 1.26 +1 -5 src/sys/amd64/amd64/intr_machdep.c 1.26 +13 -10 src/sys/amd64/amd64/io_apic.c 1.21 +1 -5 src/sys/i386/i386/intr_machdep.c 1.30 +12 -9 src/sys/i386/i386/io_apic.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 16:41:57 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B473E16A403; Fri, 17 Nov 2006 16:41:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C438343D45; Fri, 17 Nov 2006 16:41:56 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHGfuFG074705; Fri, 17 Nov 2006 16:41:56 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHGfu0Q074704; Fri, 17 Nov 2006 16:41:56 GMT (envelope-from jhb) Message-Id: <200611171641.kAHGfu0Q074704@repoman.freebsd.org> From: John Baldwin Date: Fri, 17 Nov 2006 16:41:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ddb db_watch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 16:41:57 -0000 jhb 2006-11-17 16:41:56 UTC FreeBSD src repository Modified files: sys/ddb db_watch.c Log: Fix the output format of MI ddb watches in 'show watch' on 64-bit platforms. Revision Changes Path 1.28 +8 -0 src/sys/ddb/db_watch.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 16:49:41 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A10216A403; Fri, 17 Nov 2006 16:49:41 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8549943D70; Fri, 17 Nov 2006 16:49:40 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHGneM9083737; Fri, 17 Nov 2006 16:49:40 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHGneCO083735; Fri, 17 Nov 2006 16:49:40 GMT (envelope-from obrien) Message-Id: <200611171649.kAHGneCO083735@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 17 Nov 2006 16:49:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/nfe if_nfe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 16:49:41 -0000 obrien 2006-11-17 16:49:40 UTC FreeBSD src repository Modified files: sys/dev/nfe if_nfe.c Log: Missed two nits in rev 1.7. Revision Changes Path 1.8 +2 -2 src/sys/dev/nfe/if_nfe.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 17:32:43 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0B0F16A403; Fri, 17 Nov 2006 17:32:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E47043D46; Fri, 17 Nov 2006 17:32:43 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAHHUIMT080755; Fri, 17 Nov 2006 10:30:20 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 17 Nov 2006 10:30:58 -0700 (MST) Message-Id: <20061117.103058.-165354141.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20061117065555.GE49602@comp.chem.msu.su> References: <20061116090412.GB37133@comp.chem.msu.su> <20061116.165207.1661914048.imp@bsdimp.com> <20061117065555.GE49602@comp.chem.msu.su> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 17 Nov 2006 10:30:22 -0700 (MST) Cc: src-committers@FreeBSD.ORG, bde@zeta.org.au, jkoshy@FreeBSD.ORG, cvs-all@FreeBSD.ORG, phk@phk.freebsd.dk, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 17:32:43 -0000 In message: <20061117065555.GE49602@comp.chem.msu.su> Yar Tikhiy writes: : On Thu, Nov 16, 2006 at 04:52:07PM -0700, M. Warner Losh wrote: : > In message: <20061116090412.GB37133@comp.chem.msu.su> : > Yar Tikhiy writes: : > : On Mon, Nov 13, 2006 at 10:19:58AM -0700, M. Warner Losh wrote: : > : > : : > : > : BTW, you are responsible for the __packed in . Please remove : > : > : it. The __CTASSERT() is enough to detect if heroic packing is ever needed. : > : > : The only danger is if something has grown to depend on __packed reducing : > : > : alignment as a side effect. E.g., suppose we had a byte string containing : > : > : a bytewise copy of a struct ip. If the copy might be misaligned, then it : > : > : should be copied to an actual struct ip before accessing it as a struct, : > : > : but code that accesses it directly using ((struct ip *)&bs[N]) would work : > : > : now due to the reduced alignment. Places that really need __packed should : > : > : probably use __aligned() to restore the natural alignment. : > : > : > : > DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO WORK RIGHT. : > : > If you want to remove it, then you must make sure arm works right : > : > after it because I'll add it back. : > : : > : Many years ago I was taught that comments in code could help to : > : avoid such clashes in software development. Is this true no more? ;-) : > > : > You don't add comments like: : > : > i++; // Add one to i. : > : > This is a similar class. It is for any compiler that has differing : > alignment requirements than i386. : : This is an oversimplification of the case. If it were so simple, : no doubts about it would be raised. That's why I suggested adding : a comment explaining that historically struct ip was lucky to be : packed/aligned properly, but that wasn't backed by the C standard : in fact, and eventually architectures appeared, e.g., ARM, which : broke the false assumption. It's a rather edifying case. Then : you'll have a smaller chance of having to yell in capital letters : again, "DO NOT REMOVE IT. IT IS ABSOLUTELY REQUIRED FOR ARM TO : WORK RIGHT." -- hopefully, not only regarding struct ip. The point I'm trying to make is that there are likely to be many of these instances in the tree. And there may be architectures other than ARM that have this alignment issue. You can't put a larage number of them into the tree without it looking odd or quaint. A few years from now, comments like this will look odd too. NetBSD, for example, has these all over the place. Warner From owner-cvs-src@FreeBSD.ORG Fri Nov 17 17:32:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA44F16A407; Fri, 17 Nov 2006 17:32:45 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 918C743D46; Fri, 17 Nov 2006 17:32:45 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHHWjZu003627; Fri, 17 Nov 2006 17:32:45 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHHWjth003626; Fri, 17 Nov 2006 17:32:45 GMT (envelope-from mjacob) Message-Id: <200611171732.kAHHWjth003626@repoman.freebsd.org> From: Matt Jacob Date: Fri, 17 Nov 2006 17:32:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 17:32:46 -0000 mjacob 2006-11-17 17:32:45 UTC FreeBSD src repository Modified files: sys/dev/isp isp_pci.c Log: Disable code to set max read byte count on the 2400. It caused a panic in writing the config register on a system. Turn it off until we take the time to understand it. Reported by and Testing by: Anton Revision Changes Path 1.126 +6 -0 src/sys/dev/isp/isp_pci.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 17:54:03 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E66A16A403; Fri, 17 Nov 2006 17:54:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBDD143D4C; Fri, 17 Nov 2006 17:54:02 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAHHqN8K068288; Fri, 17 Nov 2006 10:52:24 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 17 Nov 2006 10:53:04 -0700 (MST) Message-Id: <20061117.105304.1769993002.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061117201432.X11101@delplex.bde.org> References: <20061116.165207.1661914048.imp@bsdimp.com> <20061117065555.GE49602@comp.chem.msu.su> <20061117201432.X11101@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 17 Nov 2006 10:52:25 -0700 (MST) Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 17:54:03 -0000 In message: <20061117201432.X11101@delplex.bde.org> Bruce Evans writes: : For that the comment should be something like: : : __packed; /* Align (sic) to work around bugs on arm (*). */ : : but I doubt that arm is that broken. : : (*) See this thread for more details. But they aren't bugs. Warner From owner-cvs-src@FreeBSD.ORG Fri Nov 17 19:20:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 576ED16A412; Fri, 17 Nov 2006 19:20:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11F0D43D49; Fri, 17 Nov 2006 19:20:33 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHJKWip034308; Fri, 17 Nov 2006 19:20:32 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHJKWaq034307; Fri, 17 Nov 2006 19:20:32 GMT (envelope-from jhb) Message-Id: <200611171920.kAHJKWaq034307@repoman.freebsd.org> From: John Baldwin Date: Fri, 17 Nov 2006 19:20:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 db_trace.c machdep.c src/sys/amd64/include reg.h src/sys/i386/i386 db_trace.c machdep.c src/sys/i386/include reg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 19:20:33 -0000 jhb 2006-11-17 19:20:32 UTC FreeBSD src repository Modified files: sys/amd64/amd64 db_trace.c machdep.c sys/amd64/include reg.h sys/i386/i386 db_trace.c machdep.c sys/i386/include reg.h Log: - Add macro constants for the various fields in %dr7 and use them in place of various scattered magic values. - Pretty print the address of hardware watchpoints in 'show watch' rather than just displaying hex. - Expand address field width on amd64 for 64-bit pointers. Revision Changes Path 1.79 +33 -30 src/sys/amd64/amd64/db_trace.c 1.662 +9 -8 src/sys/amd64/amd64/machdep.c 1.37 +12 -0 src/sys/amd64/include/reg.h 1.78 +31 -28 src/sys/i386/i386/db_trace.c 1.642 +9 -8 src/sys/i386/i386/machdep.c 1.33 +12 -0 src/sys/i386/include/reg.h From owner-cvs-src@FreeBSD.ORG Fri Nov 17 19:38:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA3AC16A417; Fri, 17 Nov 2006 19:38:53 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0665E43D67; Fri, 17 Nov 2006 19:38:51 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHJcpF2037886; Fri, 17 Nov 2006 19:38:51 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHJcpYM037885; Fri, 17 Nov 2006 19:38:51 GMT (envelope-from sam) Message-Id: <200611171938.kAHJcpYM037885@repoman.freebsd.org> From: Sam Leffler Date: Fri, 17 Nov 2006 19:38:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/wpa Makefile src/usr.sbin/wpa/wpa_passphrase Makefile wpa_passphrase.8 src/usr.sbin/wpa/wpa_supplicant wpa_supplicant.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 19:38:53 -0000 sam 2006-11-17 19:38:51 UTC FreeBSD src repository Modified files: usr.sbin/wpa Makefile usr.sbin/wpa/wpa_supplicant wpa_supplicant.conf.5 Added files: usr.sbin/wpa/wpa_passphrase Makefile wpa_passphrase.8 Log: add wpa_passphrase utility to the build PR: bin/104457 Submitted by: Henrik Brix Andersen MFC after: 1 week Revision Changes Path 1.4 +3 -1 src/usr.sbin/wpa/Makefile 1.1 +11 -0 src/usr.sbin/wpa/wpa_passphrase/Makefile (new) 1.1 +66 -0 src/usr.sbin/wpa/wpa_passphrase/wpa_passphrase.8 (new) 1.8 +7 -1 src/usr.sbin/wpa/wpa_supplicant/wpa_supplicant.conf.5 From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:15:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC90516A415; Fri, 17 Nov 2006 20:15:26 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6808F43D45; Fri, 17 Nov 2006 20:15:26 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKFQaE045952; Fri, 17 Nov 2006 20:15:26 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKFQWH045951; Fri, 17 Nov 2006 20:15:26 GMT (envelope-from bmah) Message-Id: <200611172015.kAHKFQWH045951@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 17 Nov 2006 20:15:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:15:26 -0000 bmah 2006-11-17 20:15:26 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Modified release note: Mention move of GNOME-related ports from /usr/X11R6 to /usr/local. Suggested by: kensmith Revision Changes Path 1.990 +5 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:27:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9E4716A417; Fri, 17 Nov 2006 20:27:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94B9543D53; Fri, 17 Nov 2006 20:27:01 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKR1R3047818; Fri, 17 Nov 2006 20:27:01 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKR12E047817; Fri, 17 Nov 2006 20:27:01 GMT (envelope-from jhb) Message-Id: <200611172027.kAHKR12E047817@repoman.freebsd.org> From: John Baldwin Date: Fri, 17 Nov 2006 20:27:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 db_trace.c machdep.c src/sys/amd64/include reg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:27:02 -0000 jhb 2006-11-17 20:27:01 UTC FreeBSD src repository Modified files: sys/amd64/amd64 db_trace.c machdep.c sys/amd64/include reg.h Log: Add support for 8 byte hardware watches in long mode. Kernel hardware watches support 8 byte watches. For userland, we disallow 8 byte watches for 32-bit tasks. Revision Changes Path 1.80 +14 -4 src/sys/amd64/amd64/db_trace.c 1.663 +2 -1 src/sys/amd64/amd64/machdep.c 1.38 +1 -0 src/sys/amd64/include/reg.h From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:28:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2BD116A4A7; Fri, 17 Nov 2006 20:28:32 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E446E43DA4; Fri, 17 Nov 2006 20:28:13 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKS8TE047912; Fri, 17 Nov 2006 20:28:08 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKS8gG047911; Fri, 17 Nov 2006 20:28:08 GMT (envelope-from bmah) Message-Id: <200611172028.kAHKS8gG047911@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 17 Nov 2006 20:28:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:28:32 -0000 bmah 2006-11-17 20:28:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/en_US.ISO8859-1/errata article.sgml Log: Trim errata file for 6.2-RELEASE. Submitted by: delphij Approved by: re (implicitly) Revision Changes Path 1.73.2.34.2.1 +2 -183 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:38:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF3E316A40F; Fri, 17 Nov 2006 20:38:15 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89E1D43D45; Fri, 17 Nov 2006 20:38:15 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKcF2c049697; Fri, 17 Nov 2006 20:38:15 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKcFKE049696; Fri, 17 Nov 2006 20:38:15 GMT (envelope-from bmah) Message-Id: <200611172038.kAHKcFKE049696@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 17 Nov 2006 20:38:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:38:15 -0000 bmah 2006-11-17 20:38:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: Move of GNOME-related programs. New release notes (direct commit to this codeline): tty(4) fixes, devfs(5) fixes. Approved by: re (implicitly) Revision Changes Path 1.883.2.52.2.1 +13 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:43:02 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1131E16A403; Fri, 17 Nov 2006 20:43:02 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79D4B43D70; Fri, 17 Nov 2006 20:43:01 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKh1d5050975; Fri, 17 Nov 2006 20:43:01 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKh1b2050974; Fri, 17 Nov 2006 20:43:01 GMT (envelope-from jkim) Message-Id: <200611172043.kAHKh1b2050974@repoman.freebsd.org> From: Jung-uk Kim Date: Fri, 17 Nov 2006 20:43:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sysv_msg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:43:02 -0000 jkim 2006-11-17 20:43:01 UTC FreeBSD src repository Modified files: sys/kern sysv_msg.c Log: Fix msgsnd(3)/msgrcv(3) deadlock under heavy resource pressure by timing out msgsnd and rechecking resources. This problem was found while I was running Linux Test Project test suite (test cases: msgctl08, msgctl09). Change `msgwait' to `msgsnd' and `msgrcv' to distinguish its sleeping conditions. Few cosmetic changes to debugging messages. Revision Changes Path 1.65 +9 -5 src/sys/kern/sysv_msg.c From owner-cvs-src@FreeBSD.ORG Fri Nov 17 20:44:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCE4716A417; Fri, 17 Nov 2006 20:44:04 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B404A43D72; Fri, 17 Nov 2006 20:44:03 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAHKi3nJ051321; Fri, 17 Nov 2006 20:44:03 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAHKi3RC051320; Fri, 17 Nov 2006 20:44:03 GMT (envelope-from bmah) Message-Id: <200611172044.kAHKi3RC051320@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 17 Nov 2006 20:44:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/share/sgml release.ent X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 20:44:04 -0000 bmah 2006-11-17 20:44:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/share/sgml release.ent Log: Update manpath for 6.2-RELEASE manpages. Approved by: re (implictly) Revision Changes Path 1.24.2.5.2.4 +1 -1 src/release/doc/share/sgml/release.ent From owner-cvs-src@FreeBSD.ORG Sat Nov 18 07:28:48 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5CAB316A40F; Sat, 18 Nov 2006 07:28:48 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79A2147D38; Sat, 18 Nov 2006 07:28:46 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAI7SlU5083166; Sat, 18 Nov 2006 07:28:47 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAI7SlF2083165; Sat, 18 Nov 2006 07:28:47 GMT (envelope-from kmacy) Message-Id: <200611180728.kAI7SlF2083165@repoman.freebsd.org> From: Kip Macy Date: Sat, 18 Nov 2006 07:28:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/sun4v iommu.c tlb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 07:28:48 -0000 kmacy 2006-11-18 07:28:47 UTC FreeBSD src repository Removed files: sys/sun4v/sun4v iommu.c tlb.c Log: Remove two completely unused files Reviewed by: jb (mentor rwatson) Revision Changes Path 1.2 +0 -1276 src/sys/sun4v/sun4v/iommu.c (dead) 1.2 +0 -74 src/sys/sun4v/sun4v/tlb.c (dead) From owner-cvs-src@FreeBSD.ORG Sat Nov 18 07:33:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2345716A415; Sat, 18 Nov 2006 07:33:54 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 241D147D33; Sat, 18 Nov 2006 07:33:52 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAI7Xr0t085123; Sat, 18 Nov 2006 07:33:53 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAI7Xrll085122; Sat, 18 Nov 2006 07:33:53 GMT (envelope-from scottl) Message-Id: <200611180733.kAI7Xrll085122@repoman.freebsd.org> From: Scott Long Date: Sat, 18 Nov 2006 07:33:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mfi mfi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 07:33:54 -0000 scottl 2006-11-18 07:33:53 UTC FreeBSD src repository Modified files: sys/dev/mfi mfi.c Log: Change the internal API for polled commands. Calling mfi_polled_command after calling mfi_mapcmd is no longer needed, so long as the MFI_CMD_POLLED flag is set. This change eliminates the possibility of a polled command getting posted twice to the driver. This is turn fixes panics on shutdown when INVARIANTS is set. Sponsored by: Ironport Revision Changes Path 1.23 +39 -83 src/sys/dev/mfi/mfi.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 07:36:54 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6998216A50E; Sat, 18 Nov 2006 07:36:54 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D54047936; Sat, 18 Nov 2006 07:10:51 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAI7AqtL075642; Sat, 18 Nov 2006 07:10:52 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAI7AqIb075641; Sat, 18 Nov 2006 07:10:52 GMT (envelope-from kmacy) Message-Id: <200611180710.kAI7AqIb075641@repoman.freebsd.org> From: Kip Macy Date: Sat, 18 Nov 2006 07:10:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files.sun4v src/sys/sparc64/sparc64 autoconf.c identcpu.c mem.c src/sys/sun4v/include cache.h src/sys/sun4v/sun4v autoconf.c clock.c eeprom.c elf_machdep.c gdb_machdep.c identcpu.c in_cksum.c mem.c ofw_bus.c ofw_machdep.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 07:36:54 -0000 kmacy 2006-11-18 07:10:52 UTC FreeBSD src repository Modified files: sys/conf files.sun4v sys/sparc64/sparc64 autoconf.c identcpu.c mem.c sys/sun4v/include cache.h Removed files: sys/sun4v/sun4v autoconf.c clock.c eeprom.c elf_machdep.c gdb_machdep.c identcpu.c in_cksum.c mem.c ofw_bus.c ofw_machdep.c prof_machdep.c rwindow.c sys_machdep.c Log: remove 13 (largely) redundant files and switch to the sparc64/sparc64 version Reviewed by: jb (mentor rwatson) Revision Changes Path 1.5 +12 -14 src/sys/conf/files.sun4v 1.14 +4 -0 src/sys/sparc64/sparc64/autoconf.c 1.16 +8 -1 src/sys/sparc64/sparc64/identcpu.c 1.17 +9 -4 src/sys/sparc64/sparc64/mem.c 1.2 +8 -0 src/sys/sun4v/include/cache.h 1.2 +0 -83 src/sys/sun4v/sun4v/autoconf.c (dead) 1.2 +0 -67 src/sys/sun4v/sun4v/clock.c (dead) 1.2 +0 -192 src/sys/sun4v/sun4v/eeprom.c (dead) 1.2 +0 -361 src/sys/sun4v/sun4v/elf_machdep.c (dead) 1.2 +0 -70 src/sys/sun4v/sun4v/gdb_machdep.c (dead) 1.2 +0 -106 src/sys/sun4v/sun4v/identcpu.c (dead) 1.2 +0 -249 src/sys/sun4v/sun4v/in_cksum.c (dead) 1.2 +0 -183 src/sys/sun4v/sun4v/mem.c (dead) 1.2 +0 -198 src/sys/sun4v/sun4v/ofw_bus.c (dead) 1.2 +0 -267 src/sys/sun4v/sun4v/ofw_machdep.c (dead) 1.2 +0 -83 src/sys/sun4v/sun4v/prof_machdep.c (dead) 1.2 +0 -110 src/sys/sun4v/sun4v/rwindow.c (dead) 1.2 +0 -130 src/sys/sun4v/sun4v/sys_machdep.c (dead) From owner-cvs-src@FreeBSD.ORG Sat Nov 18 07:49:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5280816A4FD; Sat, 18 Nov 2006 07:49:25 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id B950F47E0D; Sat, 18 Nov 2006 07:24:55 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAI7OvC3080856; Sat, 18 Nov 2006 07:24:57 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAI7Ov7U080854; Sat, 18 Nov 2006 07:24:57 GMT (envelope-from kmacy) Message-Id: <200611180724.kAI7Ov7U080854@repoman.freebsd.org> From: Kip Macy Date: Sat, 18 Nov 2006 07:24:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/conf files.sun4v src/sys/sun4v/sun4v counter.c db_disasm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 07:49:25 -0000 kmacy 2006-11-18 07:24:57 UTC FreeBSD src repository Modified files: sys/conf files.sun4v Removed files: sys/sun4v/sun4v counter.c db_disasm.c Log: Remove two more duplicated files Reviewed by: jb (mentor is rwatson) Revision Changes Path 1.6 +2 -2 src/sys/conf/files.sun4v 1.2 +0 -110 src/sys/sun4v/sun4v/counter.c (dead) 1.2 +0 -1031 src/sys/sun4v/sun4v/db_disasm.c (dead) From owner-cvs-src@FreeBSD.ORG Sat Nov 18 08:07:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A425616A63C; Sat, 18 Nov 2006 08:07:44 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE2D543D5A; Sat, 18 Nov 2006 08:07:41 +0000 (GMT) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAI87h1K091818; Sat, 18 Nov 2006 08:07:43 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAI87hlU091817; Sat, 18 Nov 2006 08:07:43 GMT (envelope-from brueffer) Message-Id: <200611180807.kAI87hlU091817@repoman.freebsd.org> From: Christian Brueffer Date: Sat, 18 Nov 2006 08:07:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ucom.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 08:07:44 -0000 brueffer 2006-11-18 08:07:43 UTC FreeBSD src repository Modified files: share/man/man4 ucom.4 Log: - Use a standard section 4 SYNOPSIS - Xref uark(4) MFC after: 3 days Revision Changes Path 1.7 +14 -1 src/share/man/man4/ucom.4 From owner-cvs-src@FreeBSD.ORG Sat Nov 18 10:12:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E5FD016A47B; Sat, 18 Nov 2006 10:12:45 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7B0243D72; Sat, 18 Nov 2006 10:12:41 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIACh34031272; Sat, 18 Nov 2006 10:12:43 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIAChf1031271; Sat, 18 Nov 2006 10:12:43 GMT (envelope-from kib) Message-Id: <200611181012.kAIAChf1031271@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 10:12:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 10:12:46 -0000 kib 2006-11-18 10:12:43 UTC FreeBSD src repository Modified files: sys/compat/linux linux_misc.c Log: Remove unecessary locking of process in linux_getpid. Suggested by: jhb Submitted by: rdivacky Revision Changes Path 1.195 +0 -2 src/sys/compat/linux/linux_misc.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 10:47:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AF64116A412; Sat, 18 Nov 2006 10:47:16 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1-3.pacific.net.au [61.8.2.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA78243D46; Sat, 18 Nov 2006 10:47:13 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id AD6945A7CB7; Sat, 18 Nov 2006 21:47:15 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 695968C04; Sat, 18 Nov 2006 21:47:14 +1100 (EST) Date: Sat, 18 Nov 2006 21:47:13 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20061117.105304.1769993002.imp@bsdimp.com> Message-ID: <20061118214618.U15111@delplex.bde.org> References: <20061116.165207.1661914048.imp@bsdimp.com> <20061117065555.GE49602@comp.chem.msu.su> <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@FreeBSD.org, yar@comp.chem.msu.su, jkoshy@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 10:47:16 -0000 On Fri, 17 Nov 2006, M. Warner Losh wrote: > In message: <20061117201432.X11101@delplex.bde.org> > Bruce Evans writes: > : For that the comment should be something like: > : > : __packed; /* Align (sic) to work around bugs on arm (*). */ > : > : but I doubt that arm is that broken. > : > : (*) See this thread for more details. > > But they aren't bugs. Er, this thread gived the details of why they are bugs. Bruce From owner-cvs-src@FreeBSD.ORG Sat Nov 18 13:01:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 227D516A415; Sat, 18 Nov 2006 13:01:00 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id C12B543D49; Sat, 18 Nov 2006 13:00:56 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAID0x7A070332; Sat, 18 Nov 2006 13:00:59 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAID0xpv070330; Sat, 18 Nov 2006 13:00:59 GMT (envelope-from kib) Message-Id: <200611181300.kAID0xpv070330@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 13:00:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 13:01:00 -0000 kib 2006-11-18 13:00:59 UTC FreeBSD src repository Modified files: sys/compat/linux linux_misc.c Log: Add debuging printfs to syscalls that do not contain it yet. In sethostname do not print the hostname because it would require to copyin the string. Sethostname is not very frequently used. Submitted by: rdivacky Revision Changes Path 1.196 +36 -0 src/sys/compat/linux/linux_misc.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 13:31:04 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 75C9716A40F; Sat, 18 Nov 2006 13:31:04 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1D3A43D4C; Sat, 18 Nov 2006 13:31:00 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIDV4n5076817; Sat, 18 Nov 2006 13:31:04 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIDV4Uh076816; Sat, 18 Nov 2006 13:31:04 GMT (envelope-from kib) Message-Id: <200611181331.kAIDV4Uh076816@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 13:31:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_getcwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 13:31:04 -0000 kib 2006-11-18 13:31:03 UTC FreeBSD src repository Modified files: sys/compat/linux linux_getcwd.c Log: Use standard debugging facilities in linux_getcwd(). Submitted by: rdivacky Revision Changes Path 1.26 +2 -2 src/sys/compat/linux/linux_getcwd.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 14:17:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AF2C516A415; Sat, 18 Nov 2006 14:17:34 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D23B743D46; Sat, 18 Nov 2006 14:17:30 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAIEFhn2010373; Sat, 18 Nov 2006 07:15:44 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 18 Nov 2006 07:16:25 -0700 (MST) Message-Id: <20061118.071625.-432825382.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061118214618.U15111@delplex.bde.org> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 18 Nov 2006 07:15:46 -0700 (MST) Cc: src-committers@FreeBSD.org, yar@comp.chem.msu.su, jkoshy@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 14:17:34 -0000 In message: <20061118214618.U15111@delplex.bde.org> Bruce Evans writes: : On Fri, 17 Nov 2006, M. Warner Losh wrote: : : > In message: <20061117201432.X11101@delplex.bde.org> : > Bruce Evans writes: : > : For that the comment should be something like: : > : : > : __packed; /* Align (sic) to work around bugs on arm (*). */ : > : : > : but I doubt that arm is that broken. : > : : > : (*) See this thread for more details. : > : > But they aren't bugs. : : Er, this thread gived the details of why they are bugs. I read the thread. They gave reasons why this broke the assumptions we've made til now. These assumptions weren't allowed by the standard. Hence my contention that they aren't bugs. Warner From owner-cvs-src@FreeBSD.ORG Sat Nov 18 14:37:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4573916A412; Sat, 18 Nov 2006 14:37:55 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6094743D53; Sat, 18 Nov 2006 14:37:51 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIEbsXK089945; Sat, 18 Nov 2006 14:37:54 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIEbs5l089944; Sat, 18 Nov 2006 14:37:54 GMT (envelope-from kib) Message-Id: <200611181437.kAIEbs5l089944@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 14:37:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_misc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 14:37:55 -0000 kib 2006-11-18 14:37:54 UTC FreeBSD src repository Modified files: sys/compat/linux linux_misc.c Log: Sync struct sysinfo with real one from linux. Submitted by: rdivacky Revision Changes Path 1.197 +2 -1 src/sys/compat/linux/linux_misc.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 15:07:47 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CBA9B16A47C for ; Sat, 18 Nov 2006 15:07:47 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F39443D58 for ; Sat, 18 Nov 2006 15:07:41 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so803487uge for ; Sat, 18 Nov 2006 07:07:43 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=leJYwDIOS9EKNPdaHZaAvzYXZhEeHQCVH8ueCDJmKYqBNnKNi0bh4HJihYwMaqBjJOYxGBoNstCVWx5LsytvWHMeNiUi6EfKVFx36VBGhJqeX1Fq04YACWqQMDMi5TPDaYAwbRe8oZCB2L79t9C6+8oSVj7rxzCIuablrBZe/DI= Received: by 10.66.240.12 with SMTP id n12mr4100689ugh.1163862463528; Sat, 18 Nov 2006 07:07:43 -0800 (PST) Received: from ?192.168.1.200? ( [80.217.194.157]) by mx.google.com with ESMTP id 20sm5109675uga.2006.11.18.07.07.42; Sat, 18 Nov 2006 07:07:43 -0800 (PST) Message-ID: <455F21BC.1010208@gmail.com> Date: Sat, 18 Nov 2006 16:07:40 +0100 From: Pawel Worach User-Agent: Thunderbird 1.5.0.8 (X11/20061118) MIME-Version: 1.0 To: John Baldwin References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <200611161401.09543.jhb@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 15:07:47 -0000 Pawel Worach wrote: >> So em triggered an interrupt and you got an NMI out of it instead. What >> does 'show lapic' show? >> > > db> show lapic > lapic ID = 0 > version = 1.4 > max LVT = 5 > SVR = ff (enabled) > TPR = 00 > In-service Interrupts: > TMR Interrupts: > IRR Interrupts: > I reverted MSI support from em(4) just to see what would happen to mpt(4), no NMI fires but mpt hardware seems to go off to la-la land. OK boot -v /boot/kernel/acpi.ko text=0x4d134 data=0x2540+0x1010 syms=[0x4+0x7cb0+0x4+0xaa13] GDB: no debug ports present KDB: debugger backends: ddb KDB: current backend: ddb SMAP type=01 base=0000000000000000 len=000000000009d400 SMAP type=02 base=000000000009d400 len=0000000000002c00 SMAP type=02 base=00000000000e0000 len=0000000000020000 SMAP type=01 base=0000000000100000 len=000000003fedb2c0 SMAP type=02 base=000000003ffe0000 len=0000000000020000 SMAP type=03 base=000000003ffdb2c0 len=0000000000004d40 SMAP type=02 base=00000000fec00000 len=0000000001400000 Copyright (c) 1992-2006 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD is a registered trademark of The FreeBSD Foundation. FreeBSD 7.0-CURRENT #0: Sat Nov 18 15:53:48 CET 2006 root@zero:/usr/obj/usr/src/sys/ZERO Using 16 colors for the VM-PQ tuning (512, 8) Preloaded elf kernel "/boot/kernel/kernel" at 0xc08e2000. Preloaded elf module "/boot/kernel/acpi.ko" at 0xc08e216c. MP Configuration Table version 1.4 found at 0xc009e2a0 Table 'FACP' at 0x3ffdff00 Table 'APIC' at 0x3ffdfe40 MADT: Found table at 0x3ffdfe40 APIC: Using the MADT enumerator. MADT: Found CPU APIC ID 0 ACPI ID 0: enabled SMP: Added CPU 0 (AP) MADT: Found CPU APIC ID 6 ACPI ID 1: enabled SMP: Added CPU 6 (AP) MADT: Found CPU APIC ID 1 ACPI ID 2: enabled SMP: Added CPU 1 (AP) MADT: Found CPU APIC ID 7 ACPI ID 3: enabled SMP: Added CPU 7 (AP) INTR: Adding local APIC 0 as a target ACPI APIC Table: Calibrating clock(s) ... i8254 clock: 1193163 Hz CLK_USE_I8254_CALIBRATION not specified - using default frequency Timecounter "i8254" frequency 1193182 Hz quality 0 Calibrating TSC clock ... TSC clock: 2793892316 Hz CPU: Intel(R) Xeon(TM) CPU 2.80GHz (2793.89-MHz 686-class CPU) Origin = "GenuineIntel" Id = 0xf29 Stepping = 9 Features=0xbfebfbff Features2=0x4400 Logical CPUs per core: 2 Instruction TLB: 4 KB, 2 MB or 4 MB pages, fully associative, 64 entries Data TLB: 4 KB or 4 MB pages, fully associative, 64 entries 1st-level data cache: 8 KB, 4-way set associative, sectored cache, 64 byte line size Trace cache: 12K-uops, 8-way set associative 2nd-level cache: 512 KB, 8-way set associative, sectored cache, 64 byte line size real memory = 1073590272 (1023 MB) Physical memory chunk(s): 0x0000000000001000 - 0x000000000009cfff, 638976 bytes (156 pages) 0x0000000000100000 - 0x00000000003fffff, 3145728 bytes (768 pages) 0x0000000000c28000 - 0x000000003ed92fff, 1041674240 bytes (254315 pages) avail memory = 1041293312 (993 MB) INTR: Adding local APIC 6 as a target FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs cpu0 (BSP): APIC ID: 0 cpu1 (AP): APIC ID: 1 cpu2 (AP): APIC ID: 6 cpu3 (AP): APIC ID: 7 bios32: Found BIOS32 Service Directory header at 0xc00fd790 bios32: Entry = 0xfd7a1 (c00fd7a1) Rev = 0 Len = 1 pcibios: PCI BIOS entry at 0xf0000+0xd7dc pnpbios: Found PnP BIOS data at 0xc00fdf90 pnpbios: Entry = f0000:440f Rev = 1.0 Other BIOS signatures found: APIC: CPU 0 has ACPI ID 0 APIC: CPU 1 has ACPI ID 2 APIC: CPU 2 has ACPI ID 1 APIC: CPU 3 has ACPI ID 3 Security auditing service present BSM auditing present MADT: Found IO APIC ID 14, Interrupt 0 at 0xfec00000 ioapic0: Routing external 8259A's -> intpin 0 MADT: Found IO APIC ID 13, Interrupt 16 at 0xfec01000 MADT: Found IO APIC ID 12, Interrupt 32 at 0xfec02000 MADT: Interrupt override: source 0, irq 2 ioapic0: Routing IRQ 0 -> intpin 2 lapic0: Routing NMI -> LINT1 MADT: Ignoring local NMI routed to ACPI CPU 6 lapic6: Routing NMI -> LINT1 MADT: Ignoring local NMI routed to ACPI CPU 7 MADT: Forcing active-low polarity and level trigger for SCI ioapic0: intpin 3 polarity: low ioapic0: intpin 3 trigger: level ioapic2 irqs 32-47 on motherboard ioapic1 irqs 16-31 on motherboard ioapic0 irqs 0-15 on motherboard cpu0 BSP: ID: 0x00000000 VER: 0x00050014 LDR: 0x00000000 DFR: 0xffffffff lint0: 0x00010700 lint1: 0x00000400 TPR: 0x00000000 SVR: 0x000001ff timer: 0x000100ef therm: 0x00010000 err: 0x00010000 pcm: 0x00010000 null: random: mem: Pentium Pro MTRR support enabled io: npx0: INT 16 interface acpi0: on motherboard ioapic0: routing intpin 3 (ISA IRQ 3) to vector 48 acpi0: [MPSAFE] pci_open(1): mode 1 addr port (0x0cf8) is 0x80002800 pci_open(1a): mode1res=0x80000000 (0x80000000) pci_cfgcheck: device 0 [class=060000] [hdr=80] is there (id=00141166) pcibios: BIOS version 2.10 AcpiOsDerivePciId: bus 0 dev 15 func 2 acpi0: Power Button (fixed) acpi0: wakeup code va 0xd7a92000 pa 0x9c000 AcpiOsDerivePciId: bus 0 dev 0 func 0 AcpiOsDerivePciId: bus 0 dev 16 func 0 AcpiOsDerivePciId: bus 0 dev 16 func 2 AcpiOsDerivePciId: bus 0 dev 17 func 0 AcpiOsDerivePciId: bus 0 dev 17 func 2 acpi0: reservation of 460, 2 (4) failed ACPI timer: 1/2 0/3 1/2 1/2 0/3 1/2 1/2 1/2 1/2 1/2 -> 8 Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000 acpi_timer0: <32-bit timer at 3.579545MHz> port 0x488-0x48b on acpi0 pci_link0: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link1: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link2: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link3: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link4: Index IRQ Rtd Ref IRQs Initial Probe 0 10 N 0 10 Validation 0 10 N 0 10 After Disable 0 255 N 0 10 pci_link5: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link6: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link7: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link8: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link9: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link10: Index IRQ Rtd Ref IRQs Initial Probe 0 10 N 0 10 Validation 0 10 N 0 10 After Disable 0 255 N 0 10 pci_link11: Index IRQ Rtd Ref IRQs Initial Probe 0 9 N 0 9 Validation 0 9 N 0 9 After Disable 0 255 N 0 9 pci_link12: Index IRQ Rtd Ref IRQs Initial Probe 0 9 N 0 9 Validation 0 9 N 0 9 After Disable 0 255 N 0 9 pci_link13: Index IRQ Rtd Ref IRQs Initial Probe 0 11 N 0 11 Validation 0 11 N 0 11 After Disable 0 255 N 0 11 pci_link14: Index IRQ Rtd Ref IRQs Initial Probe 0 3 N 0 3 Validation 0 3 N 0 3 After Disable 0 255 N 0 3 pci_link15: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link16: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link17: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link18: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link19: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link20: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link21: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link22: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link23: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link24: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link25: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link26: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link27: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link28: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link29: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link30: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link31: Index IRQ Rtd Ref IRQs Initial Probe 0 255 N 0 none Validation 0 255 N 0 none After Disable 0 255 N 0 none pci_link32: Index IRQ Rtd Ref IRQs Initial Probe 0 11 N 0 11 Validation 0 11 N 0 11 After Disable 0 255 N 0 11 cpu0: on acpi0 cpu1: on acpi0 cpu2: on acpi0 cpu3: on acpi0 pcib0: on acpi0 ACPI: Found matching pin for 0.15.INTA at func 2: 11 pci0: on pcib0 pci0: physical bus=0 found-> vendor=0x1166, dev=0x0014, revid=0x33 bus=0, slot=0, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0014, revid=0x00 bus=0, slot=0, func=1 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0014, revid=0x00 bus=0, slot=0, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0000, statreg=0x0000, cachelnsz=16 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1002, dev=0x4752, revid=0x27 bus=0, slot=6, func=0 class=03-00-00, hdrtype=0x00, mfdev=0 cmdreg=0x0087, statreg=0x0290, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x00 (0 ns) intpin=a, irq=10 powerspec 2 supports D0 D1 D2 D3 current D0 map[10]: type 1, range 32, base 0xfd000000, size 24, enabled map[14]: type 4, range 32, base 0x2400, size 8, enabled map[18]: type 1, range 32, base 0xfebff000, size 12, enabled pcib0: matched entry for 0.6.INTA pcib0: slot 6 INTA hardwired to IRQ 26 found-> vendor=0x1166, dev=0x0201, revid=0x93 bus=0, slot=15, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0147, statreg=0x2200, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0212, revid=0x93 bus=0, slot=15, func=1 class=01-01-82, hdrtype=0x00, mfdev=1 cmdreg=0x0155, statreg=0x0200, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) map[20]: type 4, range 32, base 0x700, size 4, enabled found-> vendor=0x1166, dev=0x0220, revid=0x05 bus=0, slot=15, func=2 class=0c-03-10, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0280, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x50 (20000 ns) intpin=a, irq=11 map[10]: type 1, range 32, base 0xfebfe000, size 12, enabled pcib0: matched entry for 0.15.INTA (src \LPUS:0) ioapic0: Changing trigger for pin 11 to level ioapic0: Changing polarity for pin 11 to low pcib0: slot 15 INTA routed to irq 11 via \LPUS found-> vendor=0x1166, dev=0x0225, revid=0x00 bus=0, slot=15, func=3 class=06-01-00, hdrtype=0x00, mfdev=1 cmdreg=0x0144, statreg=0x0200, cachelnsz=0 (dwords) lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=16, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x22b0, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=16, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=17, func=0 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) found-> vendor=0x1166, dev=0x0101, revid=0x05 bus=0, slot=17, func=2 class=06-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0142, statreg=0x2230, cachelnsz=0 (dwords) lattimer=0x40 (1920 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns) vgapci0: port 0x2400-0x24ff mem 0xfd000000-0xfdffffff,0xfebff000-0xfebfffff irq 26 at device 6.0 on pci0 atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0x700-0x70f at device 15.1 on pci0 atapci0: Reserved 0x10 bytes for rid 0x20 type 4 at 0x700 ata0: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 atapci0: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 ata0: reset tp1 mask=03 ostat0=50 ostat1=00 ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata0: stat1=0x00 err=0x04 lsb=0x00 msb=0x00 ata0: reset tp2 stat0=00 stat1=00 devices=0x4 ioapic0: routing intpin 14 (ISA IRQ 14) to vector 49 ata0: [MPSAFE] ata1: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 atapci0: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 ata1: reset tp1 mask=00 ostat0=ff ostat1=ff ioapic0: routing intpin 15 (ISA IRQ 15) to vector 50 ata1: [MPSAFE] pci0: at device 15.2 (no driver attached) isab0: at device 15.3 on pci0 isa0: on isab0 pcib1: on acpi0 pci2: on pcib1 pci2: physical bus=2 found-> vendor=0x8086, dev=0x1229, revid=0x0c bus=2, slot=3, func=0 class=02-00-00, hdrtype=0x00, mfdev=0 cmdreg=0x0157, statreg=0x0290, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0x08 (2000 ns), maxlat=0x38 (14000 ns) intpin=a, irq=10 powerspec 2 supports D0 D1 D2 D3 current D0 map[10]: type 1, range 32, base 0xfbfff000, size 12, enabled map[14]: type 4, range 32, base 0x2500, size 6, enabled map[18]: type 1, range 32, base 0xfbfc0000, size 17, enabled pcib1: matched entry for 2.3.INTA pcib1: slot 3 INTA hardwired to IRQ 20 fxp0: port 0x2500-0x253f mem 0xfbfff000-0xfbffffff,0xfbfc0000-0xfbfdffff irq 20 at device 3.0 on pci2 fxp0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xfbfff000 fxp0: using memory space register mapping fxp0: PCI IDs: 8086 1229 1014 01f1 000c fxp0: Dynamic Standby mode is disabled miibus0: on fxp0 inphy0: on miibus0 inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto fxp0: bpf attached fxp0: Ethernet address: 00:0e:0c:2e:98:88 ioapic1: routing intpin 4 (PCI IRQ 20) to vector 51 fxp0: [MPSAFE] pcib2: on acpi0 pci4: on pcib2 pci4: physical bus=4 pcib3: on acpi0 pci6: on pcib3 pci6: physical bus=6 found-> vendor=0x8086, dev=0x1010, revid=0x01 bus=6, slot=8, func=0 class=02-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) intpin=a, irq=11 powerspec 2 supports D0 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 1, range 64, base 0xf9fe0000, size 17, enabled map[20]: type 4, range 32, base 0x2540, size 6, enabled pcib3: matched entry for 6.8.INTA pcib3: slot 8 INTA hardwired to IRQ 29 found-> vendor=0x8086, dev=0x1010, revid=0x01 bus=6, slot=8, func=1 class=02-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x40 (1920 ns), mingnt=0xff (63750 ns), maxlat=0x00 (0 ns) intpin=b, irq=3 powerspec 2 supports D0 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 1, range 64, base 0xf9fc0000, size 17, enabled map[20]: type 4, range 32, base 0x2580, size 6, enabled pcib3: matched entry for 6.8.INTB pcib3: slot 8 INTB hardwired to IRQ 30 em0: port 0x2540-0x257f mem 0xf9fe0000-0xf9ffffff irq 29 at device 8.0 on pci6 em0: Reserved 0x20000 bytes for rid 0x10 type 3 at 0xf9fe0000 em0: Reserved 0x40 bytes for rid 0x20 type 4 at 0x2540 em0: bpf attached em0: Ethernet address: 00:0d:60:1a:4f:c6 ioapic1: routing intpin 13 (PCI IRQ 29) to vector 52 em0: [FAST] em1: port 0x2580-0x25bf mem 0xf9fc0000-0xf9fdffff irq 30 at device 8.1 on pci6 em1: Reserved 0x20000 bytes for rid 0x10 type 3 at 0xf9fc0000 em1: Reserved 0x40 bytes for rid 0x20 type 4 at 0x2580 em1: bpf attached em1: Ethernet address: 00:0d:60:1a:4f:c7 ioapic1: routing intpin 14 (PCI IRQ 30) to vector 53 em1: [FAST] pcib4: on acpi0 pci8: on pcib4 pci8: physical bus=8 found-> vendor=0x1000, dev=0x0030, revid=0x07 bus=8, slot=7, func=0 class=01-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x48 (2160 ns), mingnt=0x11 (4250 ns), maxlat=0x12 (4500 ns) intpin=a, irq=9 powerspec 2 supports D0 D1 D2 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 4, range 32, base 0x2600, size 8, enabled map[14]: type 1, range 64, base 0xf7ff0000, size 16, enabled map[1c]: type 1, range 64, base 0xf7fe0000, size 16, enabled pcib4: matched entry for 8.7.INTA pcib4: slot 7 INTA hardwired to IRQ 27 found-> vendor=0x1000, dev=0x0030, revid=0x07 bus=8, slot=7, func=1 class=01-00-00, hdrtype=0x00, mfdev=1 cmdreg=0x0157, statreg=0x0230, cachelnsz=8 (dwords) lattimer=0x48 (2160 ns), mingnt=0x11 (4250 ns), maxlat=0x12 (4500 ns) intpin=b, irq=9 powerspec 2 supports D0 D1 D2 D3 current D0 MSI supports 1 message, 64 bit map[10]: type 4, range 32, base 0x2700, size 8, enabled map[14]: type 1, range 64, base 0xf7fd0000, size 16, enabled map[1c]: type 1, range 64, base 0xf7fc0000, size 16, enabled pcib4: matched entry for 8.7.INTB pcib4: slot 7 INTB hardwired to IRQ 28 mpt0: port 0x2600-0x26ff mem 0xf7ff0000-0xf7ffffff,0xf7fe0000-0xf7feffff irq 27 at device 7.0 on pci8 mpt0: Reserved 0x100 bytes for rid 0x10 type 4 at 0x2600 mpt0: Reserved 0x10000 bytes for rid 0x14 type 3 at 0xf7ff0000 mpt0: [GIANT-LOCKED] mpt0: MPI Version=1.2.15.0 mpt0: Capabilities: ( RAID-1 SAFTE ) mpt0: 1 Active Volume (1 Max) mpt0: 2 Hidden Drive Members (6 Max) mpt0: Device not running mpt mailbox: (0x40008112) State Fault WhoInit No One mpt0: mpt_wait_req(4) timed out mpt0: read_cfg_header timed out mpt0: personality mpt_cam attached but would not enable (5) mpt1: port 0x2700-0x27ff mem 0xf7fd0000-0xf7fdffff,0xf7fc0000-0xf7fcffff irq 28 at device 7.1 on pci8 mpt1: Reserved 0x100 bytes for rid 0x10 type 4 at 0x2700 mpt1: Reserved 0x10000 bytes for rid 0x14 type 3 at 0xf7fd0000 mpt1: [GIANT-LOCKED] mpt1: soft reset failed: ack timeout mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (0:0) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (0:1) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (0:2) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (0:3) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (0:4) mpt1: soft reset failed: device not running mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (1:0) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (1:1) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. mpt1: mpt_reset: failed hard reset (1:2) mpt1: WARNING - Failed hard reset! Trying to initialize anyway. ... -- Pawel From owner-cvs-src@FreeBSD.ORG Sat Nov 18 15:50:23 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E32B16A4FB; Sat, 18 Nov 2006 15:50:23 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DDC643D83; Sat, 18 Nov 2006 15:50:16 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 94FDE10A3BD; Sun, 19 Nov 2006 02:50:17 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 75A178C03; Sun, 19 Nov 2006 02:50:16 +1100 (EST) Date: Sun, 19 Nov 2006 02:50:15 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20061118.071625.-432825382.imp@bsdimp.com> Message-ID: <20061119014447.N16088@delplex.bde.org> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> <20061118.071625.-432825382.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 15:50:23 -0000 On Sat, 18 Nov 2006, M. Warner Losh wrote: > In message: <20061118214618.U15111@delplex.bde.org> > Bruce Evans writes: > : On Fri, 17 Nov 2006, M. Warner Losh wrote: > : > : > In message: <20061117201432.X11101@delplex.bde.org> > : > Bruce Evans writes: > : > : For that the comment should be something like: > : > : > : > : __packed; /* Align (sic) to work around bugs on arm (*). */ > : > : > : > : but I doubt that arm is that broken. > : > : > : > : (*) See this thread for more details. > : > > : > But they aren't bugs. > : > : Er, this thread gived the details of why they are bugs. > > I read the thread. They gave reasons why this broke the assumptions > we've made til now. These assumptions weren't allowed by the > standard. Hence my contention that they aren't bugs. You seem to have missed the main details. No assumptions about alignment were made for struct ip. It is just required to be aligned. Quoting again: %%% /* * Mbuf adjust factor to force 32-bit alignment of IP header. * Drivers should do m_adj(m, ETHER_ALIGN) when setting up a * receive so the upper layers get the IP header properly aligned * past the 14-byte Ethernet header. */ #define ETHER_ALIGN 2 /* driver adjust for IP hdr alignment */ %%% This needs to assume things about packing and alignment to work, but these assumptions are satisfied by all supported arches, and are made for much more that struct ip. Some assumptions about packing were made for struct ip. These are satisfied for all supported arches. Declaring struct ip as __packed without also declaring it as __aligned(4): o bogotifies the above documenation. o punishes all non-broken drivers that do the adjustment. o rewards all broken drivers that don't do the adjustment. o inhibit detection of regressions from non-broken to broken. o gives slow accesses to struct ip on all arches with strict alignment requirements. On other arches, the accesses are only pessimized for cases where an instance of struct ip is actually misaligned, since the compiler doesn't generate extra instructions to access words a byte at a time. Whether a struct ip is aligned depends on how it was generated. If it was generated by a non-broken driver then it is sure to be aligned; if it was generated by a broken driver then it is sure to be misaligned; if it is a local variable then its alignment depends on the compiler's strategy for packing objects that don't need alignment. Misaligned struct ip's are especially bogus for arm, since arm wants extra alignment for chars so as to reduce the number of 1-byte accesses, even for chars, but using __packed increases the number of 1-byte accesses even for non-chars. o breaks all multi-byte accesses to struct ip of the for foo(&ip->mem). This is a compiler bug. When this is fixed, the __packed kludge will become less expedient since either foo()'s API will have to be changed to accept packed objects or ip->mem will have to be laboriously copied to and from a non-packed object just like it should have been all along to be correct and inefficient. Declaring struct ip as both __packed and __aligned(4) would mainly fix all of the above (until m_adj()'s packing and alignment assumptions break) and expose broken drivers and/or ethernet infrastructure. I doubt that there are many such drivers, but note that my favourite etherernet driver (fxp) doesn't have a single reference to either of m_adj() or ETHER_ALIGN. em and bge have several such references, and doing the alignment is apparently a large performance penalty so they have ifdefs on __NO_STRICT_ALIGNMENT to give the pessimized case for arches with strict alignment requirements. __NO_STRICT_ALIGNMENT is only defined for amd64 and i386 and only used in the following drivers in /sys/dev: bge, dc, em, stge. Bruce From owner-cvs-src@FreeBSD.ORG Sat Nov 18 15:50:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D9EC816A5B7; Sat, 18 Nov 2006 15:50:30 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40C5243D66; Sat, 18 Nov 2006 15:50:21 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIFoOsO004051; Sat, 18 Nov 2006 15:50:24 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIFoObT004050; Sat, 18 Nov 2006 15:50:24 GMT (envelope-from sam) Message-Id: <200611181550.kAIFoObT004050@repoman.freebsd.org> From: Sam Leffler Date: Sat, 18 Nov 2006 15:50:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ethernet.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 15:50:31 -0000 sam 2006-11-18 15:50:24 UTC FreeBSD src repository Modified files: sys/net ethernet.h Log: mark struct ether_header packed so gcc honors alignment constratins on arm; this fixes bridging when packets are rx'd so ip headers are 32-bit aligned Reviewed by: imp (and discussed elsewhere) MFC after: 2 weeks Revision Changes Path 1.25 +1 -1 src/sys/net/ethernet.h From owner-cvs-src@FreeBSD.ORG Sat Nov 18 17:16:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0DF6A16A407; Sat, 18 Nov 2006 17:16:09 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 23EA743D8C; Sat, 18 Nov 2006 17:15:59 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIHG3B3029875; Sat, 18 Nov 2006 17:16:03 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIHG3Sw029874; Sat, 18 Nov 2006 17:16:03 GMT (envelope-from kmacy) Message-Id: <200611181716.kAIHG3Sw029874@repoman.freebsd.org> From: Kip Macy Date: Sat, 18 Nov 2006 17:16:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 17:16:09 -0000 kmacy 2006-11-18 17:16:03 UTC FreeBSD src repository Modified files: sys/sun4v/conf NOTES Log: eeprom has been removed from sun4v - remove from NOTES Revision Changes Path 1.8 +1 -1 src/sys/sun4v/conf/NOTES From owner-cvs-src@FreeBSD.ORG Sat Nov 18 17:28:33 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AFD0016A40F; Sat, 18 Nov 2006 17:28:33 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5490D43D67; Sat, 18 Nov 2006 17:27:35 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIHRdlh031783; Sat, 18 Nov 2006 17:27:39 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIHRd1K031782; Sat, 18 Nov 2006 17:27:39 GMT (envelope-from kib) Message-Id: <200611181727.kAIHRd1K031782@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 17:27:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/linux linux_getcwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 17:28:33 -0000 kib 2006-11-18 17:27:39 UTC FreeBSD src repository Modified files: sys/compat/linux linux_getcwd.c Log: Add missed ")". Fix the build. Pointy hat to: kib Revision Changes Path 1.27 +1 -1 src/sys/compat/linux/linux_getcwd.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 18:13:30 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 134BF16A416; Sat, 18 Nov 2006 18:13:30 +0000 (UTC) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8380D43D8D; Sat, 18 Nov 2006 17:57:18 +0000 (GMT) (envelope-from ceri@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIHuxCn037079; Sat, 18 Nov 2006 17:56:59 GMT (envelope-from ceri@repoman.freebsd.org) Received: (from ceri@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIHuxHr037078; Sat, 18 Nov 2006 17:56:59 GMT (envelope-from ceri) Message-Id: <200611181756.kAIHuxHr037078@repoman.freebsd.org> From: Ceri Davies Date: Sat, 18 Nov 2006 17:56:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 p_candebug.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 18:13:30 -0000 ceri 2006-11-18 17:56:59 UTC FreeBSD src repository Modified files: share/man/man9 p_candebug.9 Log: Have the synopsis compile. Pointed out by: ru Revision Changes Path 1.4 +2 -1 src/share/man/man9/p_candebug.9 From owner-cvs-src@FreeBSD.ORG Sat Nov 18 18:14:59 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8033816A59B; Sat, 18 Nov 2006 18:14:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7ACB44271; Sat, 18 Nov 2006 18:05:39 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAII30ah012683; Sat, 18 Nov 2006 11:03:01 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 18 Nov 2006 11:03:43 -0700 (MST) Message-Id: <20061118.110343.58444366.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061118214618.U15111@delplex.bde.org> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 18 Nov 2006 11:03:04 -0700 (MST) Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 18:14:59 -0000 In message: <20061118214618.U15111@delplex.bde.org> Bruce Evans writes: : On Fri, 17 Nov 2006, M. Warner Losh wrote: : : > In message: <20061117201432.X11101@delplex.bde.org> : > Bruce Evans writes: : > : For that the comment should be something like: : > : : > : __packed; /* Align (sic) to work around bugs on arm (*). */ : > : : > : but I doubt that arm is that broken. : > : : > : (*) See this thread for more details. : > : > But they aren't bugs. : : Er, this thread gived the details of why they are bugs. Wait, is this the ar or the struct ip thing.. Ar is clearly needed, but I was going to test the packedness on struct ip... I've just had my first son and am operating on too little sleep :-(. Warner From owner-cvs-src@FreeBSD.ORG Sat Nov 18 18:22:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4308016A4A0; Sat, 18 Nov 2006 18:22:17 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0DB643D49; Sat, 18 Nov 2006 18:22:07 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIIMCue042824; Sat, 18 Nov 2006 18:22:12 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIIMCG0042822; Sat, 18 Nov 2006 18:22:12 GMT (envelope-from rodrigc) Message-Id: <200611181822.kAIIMCG0042822@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 18 Nov 2006 18:22:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/ext2fs ext2_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 18:22:17 -0000 rodrigc 2006-11-18 18:22:11 UTC FreeBSD src repository Modified files: sys/gnu/fs/ext2fs ext2_vfsops.c Log: Previously, the mount_ext2fs binary listed the acceptable mount options for ext2fs. Now that we use nmount() directly from the mount binary to access ext2fs filesystems, add the list of acceptable mount options to ext2_ops, so that vfs_filteropts() will accept options like "noatime" for ext2fs. PR: 105483 Noticed by: Dr. Markus Waldeck MFC after: 1 month Revision Changes Path 1.160 +4 -1 src/sys/gnu/fs/ext2fs/ext2_vfsops.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 18:51:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EDCF516A416; Sat, 18 Nov 2006 18:51:01 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC66A43D76; Sat, 18 Nov 2006 18:48:10 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 7D4D910D177; Sun, 19 Nov 2006 05:47:42 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id BB0048C09; Sun, 19 Nov 2006 05:47:41 +1100 (EST) Date: Sun, 19 Nov 2006 05:47:40 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20061118.110343.58444366.imp@bsdimp.com> Message-ID: <20061119052526.S16985@delplex.bde.org> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> <20061118.110343.58444366.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 18:51:02 -0000 On Sat, 18 Nov 2006, M. Warner Losh wrote: > In message: <20061118214618.U15111@delplex.bde.org> > Bruce Evans writes: > : On Fri, 17 Nov 2006, M. Warner Losh wrote: > : > : > In message: <20061117201432.X11101@delplex.bde.org> > : > Bruce Evans writes: > : > : For that the comment should be something like: > : > : > : > : __packed; /* Align (sic) to work around bugs on arm (*). */ > : > : > : > : but I doubt that arm is that broken. > : > : > : > : (*) See this thread for more details. > : > > : > But they aren't bugs. > : > : Er, this thread gived the details of why they are bugs. > > Wait, is this the ar or the struct ip thing.. Ar is clearly needed, > but I was going to test the packedness on struct ip... I've just had > my first son and am operating on too little sleep :-(. I was mostly talking about struct ip. Something is needed for struct ar_hdr, since although it has size a multiple of 4 applications expect it to have alignment 1 but arm gives it alignment 4. Something is needed for struct ether_header (which sam recently packed), since it wants to have size 14 and alignment 2, but arm gives it size 16 and alignment 4. Nothing shoulded be need for struct ip, since it wants to have size 20 and alignment 4, and arm gives it that. struct ether header now has alignment 1. I don't like that... Immediately after struct ether_header in , there is struct ether_addr. This wants to have size 6 and alignment 1 (it wants to be just 6 octets), but is still unpacked so it has size 8 and alignment 4 on arm. It's surprising that anything in ethernet works on arm. Bruce From owner-cvs-src@FreeBSD.ORG Sat Nov 18 19:02:10 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D185016A407; Sat, 18 Nov 2006 19:02:10 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FB1E43DAC; Sat, 18 Nov 2006 19:00:13 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAIInUMT013054; Sat, 18 Nov 2006 11:49:30 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 18 Nov 2006 11:50:13 -0700 (MST) Message-Id: <20061118.115013.-782815408.imp@bsdimp.com> To: bde@zeta.org.au From: "M. Warner Losh" In-Reply-To: <20061119014447.N16088@delplex.bde.org> References: <20061118214618.U15111@delplex.bde.org> <20061118.071625.-432825382.imp@bsdimp.com> <20061119014447.N16088@delplex.bde.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 18 Nov 2006 11:49:31 -0700 (MST) Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 19:02:11 -0000 In message: <20061119014447.N16088@delplex.bde.org> Bruce Evans writes: : You seem to have missed the main details. Ah, I did get confused. Sorry to be so grumpy.. Warner From owner-cvs-src@FreeBSD.ORG Sat Nov 18 19:27:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1377B16A4FD; Sat, 18 Nov 2006 19:27:28 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id A5CF643F68; Sat, 18 Nov 2006 19:23:35 +0000 (GMT) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIJNbqF055023; Sat, 18 Nov 2006 19:23:37 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIJNbD3055021; Sat, 18 Nov 2006 19:23:37 GMT (envelope-from kmacy) Message-Id: <200611181923.kAIJNbD3055021@repoman.freebsd.org> From: Kip Macy Date: Sat, 18 Nov 2006 19:23:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sun4v/include pcpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 19:27:28 -0000 kmacy 2006-11-18 19:23:37 UTC FreeBSD src repository Modified files: sys/sun4v/include pcpu.h Log: remove unused fields Approved by: scottl (standing in for mentor rwatson) Revision Changes Path 1.2 +1 -3 src/sys/sun4v/include/pcpu.h From owner-cvs-src@FreeBSD.ORG Sat Nov 18 20:06:18 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6691416A40F; Sat, 18 Nov 2006 20:06:18 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 291A643D66; Sat, 18 Nov 2006 20:06:11 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIK6F4k063774; Sat, 18 Nov 2006 20:06:16 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIK6FBn063773; Sat, 18 Nov 2006 20:06:15 GMT (envelope-from kensmith) Message-Id: <200611182006.kAIK6FBn063773@repoman.freebsd.org> From: Ken Smith Date: Sat, 18 Nov 2006 20:06:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT approvers X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 20:06:18 -0000 kensmith 2006-11-18 20:06:15 UTC FreeBSD src repository Modified files: . approvers Log: Release RELENG_6 from code freeze. Approved by: core (implicit) Revision Changes Path 1.38 +1 -1 CVSROOT/approvers From owner-cvs-src@FreeBSD.ORG Sat Nov 18 20:21:37 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9756216A412; Sat, 18 Nov 2006 20:21:37 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FF7443D64; Sat, 18 Nov 2006 20:21:30 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id kAIKLWwY085580; Sat, 18 Nov 2006 23:21:32 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id kAIKLPwY085576; Sat, 18 Nov 2006 23:21:25 +0300 (MSK) (envelope-from yar) Date: Sat, 18 Nov 2006 23:21:25 +0300 From: Yar Tikhiy To: Bruce Evans Message-ID: <20061118202125.GD80527@comp.chem.msu.su> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> <20061118.110343.58444366.imp@bsdimp.com> <20061119052526.S16985@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061119052526.S16985@delplex.bde.org> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, jkoshy@freebsd.org, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 20:21:37 -0000 On Sun, Nov 19, 2006 at 05:47:40AM +1100, Bruce Evans wrote: > On Sat, 18 Nov 2006, M. Warner Losh wrote: > > >In message: <20061118214618.U15111@delplex.bde.org> > > Bruce Evans writes: > >: On Fri, 17 Nov 2006, M. Warner Losh wrote: > >: > >: > In message: <20061117201432.X11101@delplex.bde.org> > >: > Bruce Evans writes: > >: > : For that the comment should be something like: > >: > : > >: > : __packed; /* Align (sic) to work around bugs on arm > >(*). */ > >: > : > >: > : but I doubt that arm is that broken. > >: > : > >: > : (*) See this thread for more details. > >: > > >: > But they aren't bugs. > >: > >: Er, this thread gived the details of why they are bugs. > > > >Wait, is this the ar or the struct ip thing.. Ar is clearly needed, > >but I was going to test the packedness on struct ip... I've just had > >my first son and am operating on too little sleep :-(. > > I was mostly talking about struct ip. Something is needed for struct > ar_hdr, since although it has size a multiple of 4 applications expect > it to have alignment 1 but arm gives it alignment 4. Something is needed > for struct ether_header (which sam recently packed), since it wants to > have size 14 and alignment 2, but arm gives it size 16 and alignment 4. > Nothing shoulded be need for struct ip, since it wants to have size 20 and > alignment 4, and arm gives it that. The C standard provides no clues as to how structures are packed or aligned. The only thing it says is that objects have alignment and it can be the same or not the same for different objects. That is, a future C compiler is allowed to put holes in struct ip, and in any struct it wants, unless we use the unportable __packed hack -- or abandon the structs in favor of byte-level access to seamless data such as hardware or network packets. That's what I meant by struct ip being historically lucky. We still want to use __packed and __align, but IMHO we should realize that we just pay the price of non-portability for using convenient things such as struct in low-level programming. Perhaps we're just getting even with the C standard authors, who sacrificed the ability to use struct in that way for the sake of the language's own portability. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Sat Nov 18 20:59:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82C5516A407; Sat, 18 Nov 2006 20:59:52 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EE8843D6B; Sat, 18 Nov 2006 20:59:46 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIKxpgu080541; Sat, 18 Nov 2006 20:59:51 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIKxpBG080540; Sat, 18 Nov 2006 20:59:51 GMT (envelope-from kib) Message-Id: <200611182059.kAIKxpBG080540@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 20:59:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/security/audit audit_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 20:59:52 -0000 kib 2006-11-18 20:59:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/security/audit audit_syscalls.c Log: On RELENG_6, vn_open() will drop Giant aquired for calls into non-MP-safe filesystem if fdx == -1, assuming the in-kernel callers are not MP-safe. On HEAD, vn_open() after rev. 1.240 of sys/kern/vfs_vnops.c would keep the Giant locked when the MPSAFE flag is given. The difference in the API caused the auditctl() syscall code to try to unlock non-locked Giant for non-MP-safe filesystems, for instance, UFS when QUOTA is compiled in. This is direct commit to RELENG_6 to accomodate for RELENG_6' vn_open(). Reported by: Steve Wills (steve at stevenwills com) Reviewed by: rwatson Approved by: re (bmah) X-MFC to RELENG_6_2 after: 3 days Revision Changes Path 1.1.2.5 +2 -2 src/sys/security/audit/audit_syscalls.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:06:04 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79AD516A417; Sat, 18 Nov 2006 21:06:04 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4EFF943D81; Sat, 18 Nov 2006 21:05:55 +0000 (GMT) (envelope-from xcllnt@mac.com) Received: from mac.com (smtpin07-en2 [10.13.10.152]) by smtpout.mac.com (Xserve/8.12.11/smtpout05/MantshX 4.0) with ESMTP id kAIL5Oxb023189; Sat, 18 Nov 2006 13:05:24 -0800 (PST) Received: from [192.168.1.3] (c-67-164-11-148.hsd1.ca.comcast.net [67.164.11.148]) (authenticated bits=0) by mac.com (Xserve/smtpin07/MantshX 4.0) with ESMTP id kAIL5KEI025206 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sat, 18 Nov 2006 13:05:21 -0800 (PST) In-Reply-To: <20061118202125.GD80527@comp.chem.msu.su> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> <20061118.110343.58444366.imp@bsdimp.com> <20061119052526.S16985@delplex.bde.org> <20061118202125.GD80527@comp.chem.msu.su> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <1F361437-69AC-4823-8FF8-506EA450ED2F@mac.com> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Sat, 18 Nov 2006 13:05:15 -0800 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.3) X-Brightmail-Tracker: AAAAAA== X-Brightmail-scanned: yes Cc: src-committers@freebsd.org, Bruce Evans , jkoshy@freebsd.org, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:06:04 -0000 On Nov 18, 2006, at 12:21 PM, Yar Tikhiy wrote: > On Sun, Nov 19, 2006 at 05:47:40AM +1100, Bruce Evans wrote: >> On Sat, 18 Nov 2006, M. Warner Losh wrote: >> >>> In message: <20061118214618.U15111@delplex.bde.org> >>> Bruce Evans writes: >>> : On Fri, 17 Nov 2006, M. Warner Losh wrote: >>> : >>> : > In message: <20061117201432.X11101@delplex.bde.org> >>> : > Bruce Evans writes: >>> : > : For that the comment should be something like: >>> : > : >>> : > : __packed; /* Align (sic) to work around bugs on arm >>> (*). */ >>> : > : >>> : > : but I doubt that arm is that broken. >>> : > : >>> : > : (*) See this thread for more details. >>> : > >>> : > But they aren't bugs. >>> : >>> : Er, this thread gived the details of why they are bugs. >>> >>> Wait, is this the ar or the struct ip thing.. Ar is clearly needed, >>> but I was going to test the packedness on struct ip... I've just >>> had >>> my first son and am operating on too little sleep :-(. >> >> I was mostly talking about struct ip. Something is needed for struct >> ar_hdr, since although it has size a multiple of 4 applications >> expect >> it to have alignment 1 but arm gives it alignment 4. Something is >> needed >> for struct ether_header (which sam recently packed), since it >> wants to >> have size 14 and alignment 2, but arm gives it size 16 and >> alignment 4. >> Nothing shoulded be need for struct ip, since it wants to have >> size 20 and >> alignment 4, and arm gives it that. > > The C standard provides no clues as to how structures are packed > or aligned. The only thing it says is that objects have alignment > and it can be the same or not the same for different objects. That > is, a future C compiler is allowed to put holes in struct ip, and > in any struct it wants, unless we use the unportable __packed hack > -- or abandon the structs in favor of byte-level access to seamless > data such as hardware or network packets. That's what I meant by > struct ip being historically lucky. Just my $0.02 and I'm in no way claiming to know anything about the C standard, ... (wait for it) ... but ... My interpretation of the use of padding is nothing more than holes that are the result of alignment requirements of adjacent fields. The interpretation that it means that the compiler can gratuitously inject bytes between fields is extreme and pessimistic and borders on insanity :-) Also, since this discussion is the result of ARM aligning structures on 4-byte boundaries, I think that the use of __packed to compensate for excessive alignment is just plain wrong. We have __aligned(x) to inform the compiler about what the alignment of an object should be and that's the tool we should use to tell the compiler on ARM that we in fact want 1-byte alignment. take for example, the following structure: struct { uint8_t a; uint16_t b; }; If we depend on 16-bit alignment, then __aligned(2) will *NOT* pessimize structure access on architectures that use 16-bit alignment by default and it tells the ARM compiler that we don't want it aligned on a 4-byte boundary. The use of __packed will tell the compiler on *ANY* architecture that it cannot assume any alignment and as such will use byte-wise accesses. If the compiler on ARM doesn't respect __aligned(x), then that compiler is broken and should be fixed. The fact that structures are aligned on a 4-byte boundary is something I cannot cal a bug, but it's certainly against POLA. That's all I intend to say... -- Marcel Moolenaar xcllnt@mac.com From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:18:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A7C0616A403; Sat, 18 Nov 2006 21:18:15 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB0FF43DA2; Sat, 18 Nov 2006 21:16:57 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILGtGW085075; Sat, 18 Nov 2006 21:16:55 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILGtMY085074; Sat, 18 Nov 2006 21:16:55 GMT (envelope-from ache) Message-Id: <200611182116.kAILGtMY085074@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sat, 18 Nov 2006 21:16:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/stdio freopen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:18:15 -0000 ache 2006-11-18 21:16:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/stdio freopen.c Log: MFC: 1.14-1.17 (position bugfixes) Revision Changes Path 1.13.8.1 +18 -10 src/lib/libc/stdio/freopen.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:29:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D023316A403; Sat, 18 Nov 2006 21:29:09 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74CAA43D80; Sat, 18 Nov 2006 21:28:37 +0000 (GMT) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILSgTL087041; Sat, 18 Nov 2006 21:28:42 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILSgCv087040; Sat, 18 Nov 2006 21:28:42 GMT (envelope-from bmah) Message-Id: <200611182128.kAILSgCv087040@repoman.freebsd.org> From: "Bruce A. Mah" Date: Sat, 18 Nov 2006 21:28:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:29:09 -0000 bmah 2006-11-18 21:28:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) release/doc/en_US.ISO8859-1/errata article.sgml Log: Update FreeBSD version to which this document applies. Pointed out by: delphij Approved by: re (implicitly) Revision Changes Path 1.73.2.34.2.2 +1 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:36:03 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EF52F16A505; Sat, 18 Nov 2006 21:36:03 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E22543D97; Sat, 18 Nov 2006 21:35:08 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILZDeE088803; Sat, 18 Nov 2006 21:35:13 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILZDAY088802; Sat, 18 Nov 2006 21:35:13 GMT (envelope-from ache) Message-Id: <200611182135.kAILZDAY088802@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sat, 18 Nov 2006 21:35:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/gen arc4random.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:36:04 -0000 ache 2006-11-18 21:35:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/gen arc4random.c Log: MFC: 1.11 (automatically re-stir) Revision Changes Path 1.10.8.1 +4 -2 src/lib/libc/gen/arc4random.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:48:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B9BA116A403; Sat, 18 Nov 2006 21:48:13 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15E0E43D46; Sat, 18 Nov 2006 21:48:08 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILmD7i090603; Sat, 18 Nov 2006 21:48:13 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILmDsn090601; Sat, 18 Nov 2006 21:48:13 GMT (envelope-from marcel) Message-Id: <200611182148.kAILmDsn090601@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 18 Nov 2006 21:48:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 genassym.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:48:13 -0000 marcel 2006-11-18 21:48:13 UTC FreeBSD src repository Modified files: sys/ia64/ia64 genassym.c Log: Revert previous commit. PC_CONS_BUFR is not used nor needed by assembly. Revision Changes Path 1.44 +0 -1 src/sys/ia64/ia64/genassym.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:52:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4628416A403; Sat, 18 Nov 2006 21:52:27 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EC3C43D72; Sat, 18 Nov 2006 21:52:21 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILqQwc091616; Sat, 18 Nov 2006 21:52:26 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILqQWt091613; Sat, 18 Nov 2006 21:52:26 GMT (envelope-from marcel) Message-Id: <200611182152.kAILqQWt091613@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 18 Nov 2006 21:52:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 interrupt.c machdep.c mp_machdep.c src/sys/ia64/include kdb.h pcpu.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:52:27 -0000 marcel 2006-11-18 21:52:26 UTC FreeBSD src repository Modified files: sys/ia64/ia64 interrupt.c machdep.c mp_machdep.c sys/ia64/include kdb.h pcpu.h Log: Now that printf() needs the PCPU, set it up before we call printf(). Change the pc_pcb field from a pointer to struct pcb to struct pcb so that sizeof(struct pcb) includes the PCB we use for IPI_STOP. Statically declare early_pcb so that we don't have to allocate the PCB for thread0. This way we can setup the PCPU before cninit() and thus before we use printf(). Revision Changes Path 1.56 +1 -1 src/sys/ia64/ia64/interrupt.c 1.211 +8 -20 src/sys/ia64/ia64/machdep.c 1.62 +2 -2 src/sys/ia64/ia64/mp_machdep.c 1.4 +1 -1 src/sys/ia64/include/kdb.h 1.18 +4 -2 src/sys/ia64/include/pcpu.h From owner-cvs-src@FreeBSD.ORG Sat Nov 18 21:55:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B88C16A407; Sat, 18 Nov 2006 21:55:34 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id C331443D49; Sat, 18 Nov 2006 21:55:28 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAILtYlf092337; Sat, 18 Nov 2006 21:55:34 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAILtYGY092336; Sat, 18 Nov 2006 21:55:34 GMT (envelope-from maxim) Message-Id: <200611182155.kAILtYGY092336@repoman.freebsd.org> From: Maxim Konovalov Date: Sat, 18 Nov 2006 21:55:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/misc bsd-family-tree X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 21:55:34 -0000 maxim 2006-11-18 21:55:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/misc bsd-family-tree Log: MFC revs. 1.107 - 1.109: OpenBSD 4.0, NetBSD 3.0.2, NetBSD 3.1, cosmetic. Revision Changes Path 1.95.2.7 +14 -7 src/share/misc/bsd-family-tree From owner-cvs-src@FreeBSD.ORG Sat Nov 18 22:00:09 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9878E16A403; Sat, 18 Nov 2006 22:00:09 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id A867D43D58; Sat, 18 Nov 2006 22:00:03 +0000 (GMT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.13.8/8.13.8) with ESMTP id kAILtAIW073261; Sat, 18 Nov 2006 13:55:10 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.13.8/8.13.8/Submit) id kAILtAE8073260; Sat, 18 Nov 2006 13:55:10 -0800 (PST) (envelope-from sgk) Date: Sat, 18 Nov 2006 13:55:10 -0800 From: Steve Kargl To: "Andrey A. Chernov" Message-ID: <20061118215510.GA73144@troutmask.apl.washington.edu> References: <200611182116.kAILGtMY085074@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611182116.kAILGtMY085074@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdio freopen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 22:00:10 -0000 On Sat, Nov 18, 2006 at 09:16:55PM +0000, Andrey A. Chernov wrote: > ache 2006-11-18 21:16:55 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > lib/libc/stdio freopen.c > Log: > MFC: 1.14-1.17 (position bugfixes) > Isn't RELENG_6 frozen? I was expecting to see "Approved by: RE" -- Steve From owner-cvs-src@FreeBSD.ORG Sat Nov 18 22:10:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 68B4616A4A7; Sat, 18 Nov 2006 22:10:18 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1070D43DFD; Sat, 18 Nov 2006 22:06:48 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.8/8.13.8) with ESMTP id kAIM7e0U055466; Sat, 18 Nov 2006 17:07:40 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Steve Kargl In-Reply-To: <20061118215510.GA73144@troutmask.apl.washington.edu> References: <200611182116.kAILGtMY085074@repoman.freebsd.org> <20061118215510.GA73144@troutmask.apl.washington.edu> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-dyuv7DcCfT9Zx2t2wc5u" Organization: MarcusCom, Inc. Date: Sat, 18 Nov 2006 17:06:37 -0500 Message-Id: <1163887597.6902.15.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1.1 FreeBSD GNOME Team Port Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Andrey A. Chernov" , cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdio freopen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 22:10:18 -0000 --=-dyuv7DcCfT9Zx2t2wc5u Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2006-11-18 at 13:55 -0800, Steve Kargl wrote: > On Sat, Nov 18, 2006 at 09:16:55PM +0000, Andrey A. Chernov wrote: > > ache 2006-11-18 21:16:55 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: (Branch: RELENG_6) > > lib/libc/stdio freopen.c=20 > > Log: > > MFC: 1.14-1.17 (position bugfixes) > > =20 >=20 > Isn't RELENG_6 frozen? >=20 > I was expecting to see "Approved by: RE" It was opened a few hours ago. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-dyuv7DcCfT9Zx2t2wc5u Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQBFX4Ptb2iPiv4Uz4cRAj5sAJ9juUyCFvMst4jxzk+uYY9IcAI2uACcD0XD YwCUbQw/vmn6cGBAa58PYS8= =FtrG -----END PGP SIGNATURE----- --=-dyuv7DcCfT9Zx2t2wc5u-- From owner-cvs-src@FreeBSD.ORG Sat Nov 18 22:43:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AEB7C16A415; Sat, 18 Nov 2006 22:43:23 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BA8243D8B; Sat, 18 Nov 2006 22:43:16 +0000 (GMT) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIMhLAv002365; Sat, 18 Nov 2006 22:43:21 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIMhLOE002364; Sat, 18 Nov 2006 22:43:21 GMT (envelope-from rodrigc) Message-Id: <200611182243.kAIMhLOE002364@repoman.freebsd.org> From: Craig Rodrigues Date: Sat, 18 Nov 2006 22:43:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/mountd mountd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 22:43:23 -0000 rodrigc 2006-11-18 22:43:21 UTC FreeBSD src repository Modified files: usr.sbin/mountd mountd.c Log: Ignore SIGPIPE, instead of terminating process. PR: 81230 Submitted by: Dmitrij Tejblum MFC after: 1 month Revision Changes Path 1.91 +1 -0 src/usr.sbin/mountd/mountd.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 23:15:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 003C416A403; Sat, 18 Nov 2006 23:15:25 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id D118E43D49; Sat, 18 Nov 2006 23:15:19 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAINFP8h010284; Sat, 18 Nov 2006 23:15:25 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAINFPlU010282; Sat, 18 Nov 2006 23:15:25 GMT (envelope-from marcel) Message-Id: <200611182315.kAINFPlU010282@repoman.freebsd.org> From: Marcel Moolenaar Date: Sat, 18 Nov 2006 23:15:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 23:15:26 -0000 marcel 2006-11-18 23:15:25 UTC FreeBSD src repository Modified files: sys/ia64/ia64 machdep.c Log: Since printf also has at least one critical section, we need to initialize pc_curthread. While here, rename early_pcpu to pcpu0 to be conistent (compare thread0 and proc0). Revision Changes Path 1.212 +7 -5 src/sys/ia64/ia64/machdep.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 23:17:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 86AAE16A403; Sat, 18 Nov 2006 23:17:23 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E12343D49; Sat, 18 Nov 2006 23:17:17 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAINHMtT010432; Sat, 18 Nov 2006 23:17:22 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAINHMLB010431; Sat, 18 Nov 2006 23:17:22 GMT (envelope-from csjp) Message-Id: <200611182317.kAINHMLB010431@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 18 Nov 2006 23:17:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ethernet.h if_ethersubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 23:17:23 -0000 csjp 2006-11-18 23:17:22 UTC FreeBSD src repository Modified files: sys/net ethernet.h if_ethersubr.c Log: Currently, drivers that support hardware offload of VLAN tag processing are forced to toggle this functionality when the card is put in and out of promiscuous mode. The main reason for this is because the hardware strips the VLAN tag, making it impossible for the tag information to show up in network diagnostic tools like tcpdump(1). This change introduces ether_vlan_mtap(), which is called if the mbuf has M_VLANTAG set. VLAN information is extracted from the mbuf and inserted into a stack allocated ether vlan header which is then inserted through the bpf machinery via bpf_mtap2(). The original mbuf's data pointer and lengths are temporarily adjusted to eliminate the original Ethernet header for the duration of the tap operation. This should have no long term effects on the mbuf. Also, define a new macro, ETHER_BPF_MTAP which should be used by drivers which support hardware offload of VLAN tag processing. The fixes for the relevant drivers will follow shortly. Discussed with: rwatson, andre, jhb (and others) Much feedback from: sam, ru MFC after: 1 month [1] [1] The version that is eventually MFCed will be somewhat different then this, as there has been significant work done to the VLAN code in HEAD. Revision Changes Path 1.26 +19 -0 src/sys/net/ethernet.h 1.220 +40 -0 src/sys/net/if_ethersubr.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 23:18:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 512B016A4A7; Sat, 18 Nov 2006 23:18:44 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4122443D6D; Sat, 18 Nov 2006 23:18:38 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAINIh0G010537; Sat, 18 Nov 2006 23:18:43 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAINIhvv010536; Sat, 18 Nov 2006 23:18:43 GMT (envelope-from csjp) Message-Id: <200611182318.kAINIhvv010536@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 18 Nov 2006 23:18:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 23:18:44 -0000 csjp 2006-11-18 23:18:43 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Implement new ETHER_BPF_MTAP macro. Roll back the various changes made to accommodate the chip being in promiscuous mode while offloading VLAN tag processing to the hardware. We can now properly handle the absence of VLAN tags from hardware stripping. Reviewed by: rwatson, andre MFC after: 1 month Revision Changes Path 1.165 +3 -70 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Sat Nov 18 23:38:37 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7FD1E16A417; Sat, 18 Nov 2006 23:38:37 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E77043D49; Sat, 18 Nov 2006 23:38:25 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAINcV4N014265; Sat, 18 Nov 2006 23:38:31 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAINcVJ8014264; Sat, 18 Nov 2006 23:38:31 GMT (envelope-from csjp) Message-Id: <200611182338.kAINcVJ8014264@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 18 Nov 2006 23:38:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ethernet.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 23:38:37 -0000 csjp 2006-11-18 23:38:31 UTC FreeBSD src repository Modified files: sys/net ethernet.h Log: Fix typo in comment Pointed out by: ru Revision Changes Path 1.27 +1 -1 src/sys/net/ethernet.h