From owner-freebsd-arch@FreeBSD.ORG Sun Apr 16 13:11:23 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CDA516A402 for ; Sun, 16 Apr 2006 13:11:23 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA20D43D4C for ; Sun, 16 Apr 2006 13:11:21 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5EF85.dip.t-dialin.net [84.165.239.133]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.1) with ESMTP id k3GD6thZ026914; Sun, 16 Apr 2006 15:06:55 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k3GDBFFW073570; Sun, 16 Apr 2006 15:11:16 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Date: Sun, 16 Apr 2006 15:11:28 +0200 From: Alexander Leidinger To: Steve Kargl Message-ID: <20060416151128.5959ce56@Magellan.Leidinger.net> In-Reply-To: <20060415182413.GA8729@troutmask.apl.washington.edu> References: <20060415182413.GA8729@troutmask.apl.washington.edu> X-Mailer: Sylpheed-Claws 2.1.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: freebsd-arch@freebsd.org Subject: Re: Google's summer of code topics? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Apr 2006 13:11:23 -0000 Am Sat, 15 Apr 2006 11:24:13 -0700 schrieb Steve Kargl : > Is anyone collecting topics for submission to Google's > Summer of Code that have potential impact on the *BSDs. > > Over the past 2 years, I've submitted various missing > C99 math functions for inclusion in libm. Unfortunately, > most complex and long double are still missing and I > doubt that I'll ever have sufficient time to work on > all of them. > > Improvements to libm seems to be a good topic. Feel free to submit an entry for http://www.freebsd.org/projects/ideas/ (plain text is enough). It should be similar to the existing entries there. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 WL http://www.amazon.de/exec/obidos/registry/1FZ4DTHQE9PQ8/ref=wl_em_to/ From owner-freebsd-arch@FreeBSD.ORG Tue Apr 18 03:25:28 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6C7016A404; Tue, 18 Apr 2006 03:25:28 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB09A43D67; Tue, 18 Apr 2006 03:25:21 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (rfne9ecv13afc4kh@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3I3PLCc029193; Mon, 17 Apr 2006 20:25:21 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3I3PKws029192; Mon, 17 Apr 2006 20:25:20 -0700 (PDT) (envelope-from jmg) Date: Mon, 17 Apr 2006 20:25:20 -0700 From: John-Mark Gurney To: multimedia@FreeBSD.org Message-ID: <20060418032520.GG38619@funkthat.com> Mail-Followup-To: multimedia@FreeBSD.org, arch@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: arch@FreeBSD.org Subject: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 03:25:29 -0000 Well, I noticed that we have a few extra snd_'s in front of most (all?) of our sound drives.. I believe this used to be necessary due to lack of kldxref which couldn't find modules w/ different names than the modules.. Now that this has been fixed, I feel that we should drop these so we don't have issues w/ name mismatches, such as introduced w/ gusc and sbc.. Anyone object to the patch: http://people.freebsd.org/~jmg/snd.drop.patch -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-arch@FreeBSD.ORG Tue Apr 18 03:33:15 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F98A16A403; Tue, 18 Apr 2006 03:33:15 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4629C43D46; Tue, 18 Apr 2006 03:33:15 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (orets4p3culp89ce@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3I3XE63029419; Mon, 17 Apr 2006 20:33:15 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3I3XEKO029418; Mon, 17 Apr 2006 20:33:14 -0700 (PDT) (envelope-from jmg) Date: Mon, 17 Apr 2006 20:33:14 -0700 From: John-Mark Gurney To: multimedia@FreeBSD.org, arch@FreeBSD.org Message-ID: <20060418033314.GH38619@funkthat.com> Mail-Followup-To: multimedia@FreeBSD.org, arch@FreeBSD.org References: <20060418032520.GG38619@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060418032520.GG38619@funkthat.com> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: Subject: Re: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 03:33:17 -0000 John-Mark Gurney wrote this message on Mon, Apr 17, 2006 at 20:25 -0700: > Well, I noticed that we have a few extra snd_'s in front of most (all?) > of our sound drives.. I believe this used to be necessary due to lack of > kldxref which couldn't find modules w/ different names than the modules.. > Now that this has been fixed, I feel that we should drop these so we > don't have issues w/ name mismatches, such as introduced w/ gusc and sbc.. > > Anyone object to the patch: > http://people.freebsd.org/~jmg/snd.drop.patch Oh, forgot to mention that I've tested this w/ via82c686.. I haven't tested it w/ anything else.. snd_via82c868_enable="YES" works, along w/ kldload snd_via82c686... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-arch@FreeBSD.ORG Tue Apr 18 19:48:33 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDF4216A404 for ; Tue, 18 Apr 2006 19:48:33 +0000 (UTC) (envelope-from pfgshield-freebsd@yahoo.com) Received: from web32715.mail.mud.yahoo.com (web32715.mail.mud.yahoo.com [68.142.206.28]) by mx1.FreeBSD.org (Postfix) with SMTP id 1688843D49 for ; Tue, 18 Apr 2006 19:48:33 +0000 (GMT) (envelope-from pfgshield-freebsd@yahoo.com) Received: (qmail 725 invoked by uid 60001); 18 Apr 2006 19:48:32 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type; b=luA3x/eOk+uQkHGMAjGb0LmgdM/OnRqjAAXqqtOFIKGHoTQTNvPm0DtTIRB3ApWgmEBJlvY9E2JGyWFp1YRayT+egPX1U4ckJcBCRFZ2oZdAa8JtCQkK4uDBMvjqVezALC8hWBipANlml+C5jUlmFW/5k+d+uoZ0tQozR7K5EZs= ; Message-ID: <20060418194832.723.qmail@web32715.mail.mud.yahoo.com> Received: from [69.79.51.65] by web32715.mail.mud.yahoo.com via HTTP; Tue, 18 Apr 2006 21:48:32 CEST Date: Tue, 18 Apr 2006 21:48:32 +0200 (CEST) From: To: freebsd-arch@freebsd.org, nsouchu@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Cc: Subject: Re: Google's summer of code topics? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pfgshield-freebsd@yahoo.com List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 19:48:34 -0000 >From my personal wishlist: - A port of NetBSD's wscons. - more KGI4BSD. I don't know who could be a technical contact, well.. Nicholas for KGI, I guess. cheers, Pedro. --- Pedro F. Giffuni M. Sc. Industrial Eng. University of Pittsburgh Mech. Eng. Universidad Nacional de Colombia --- Yahoo is powered by FreeBSD http://www.FreeBSD.org/ ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it From owner-freebsd-arch@FreeBSD.ORG Tue Apr 18 23:40:57 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E62CA16A404 for ; Tue, 18 Apr 2006 23:40:57 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [192.147.25.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9224843D5C for ; Tue, 18 Apr 2006 23:40:57 +0000 (GMT) (envelope-from ler@lerctr.org) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lerami; d=lerctr.org; b=cz3b7dV7Aby3rPcAFiek+S3OTSj9bKAEWnkLVVf3ImQ3JLE1L5UgxkScDq23oLqY1QJT2v2bS0/IaTehn+V5MBkQX8EvbduCgfkBpEwcXlX4G80Hf83IY3tyUuuoaassIP/zy9ZpKSLdjdvNiMVq4nFMe6u3gdjS9f/RXEdsPPY=; Received: from adsl-67-67-196-192.dsl.austtx.swbell.net ([67.67.196.192]:56321 helo=[192.168.200.101]) by thebighonker.lerctr.org with esmtpa (Exim 4.61 (FreeBSD)) (envelope-from ) id 1FVzoV-000Pws-PZ for arch@freebsd.org; Tue, 18 Apr 2006 18:40:57 -0500 Mime-Version: 1.0 (Apple Message framework v749.3) Content-Transfer-Encoding: 7bit Message-Id: Content-Type: text/plain; charset=US-ASCII; format=flowed To: arch@freebsd.org From: Larry Rosenman Date: Tue, 18 Apr 2006 18:40:42 -0500 X-Mailer: Apple Mail (2.749.3) X-Spam-Score: -4.4 (----) X-LERCTR-Spam-Score: -4.4 (----) X-Spam-Report: (-4.4 points, 5.0 required) ALL_TRUSTED=-1.8 BAYES_00=-2.599 DK_POLICY_SIGNALL=0.001 X-LERCTR-Spam-Report: (-4.4 points, 5.0 required) ALL_TRUSTED=-1.8 BAYES_00=-2.599 DK_POLICY_SIGNALL=0.001 DomainKey-Status: no signature Cc: Subject: Pointer to a (minor) PR X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 23:40:58 -0000 Can I get comments on misc/96015? It's a nit, but cost me some time this weekend. Thanks! LER -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 512-248-2683 E-Mail: ler@lerctr.org US Mail: 430 Valona Loop, Round Rock, TX 78681-3893 From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 07:49:16 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1976616A405; Wed, 19 Apr 2006 07:49:16 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E64443D45; Wed, 19 Apr 2006 07:49:15 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5F24F.dip.t-dialin.net [84.165.242.79]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.1) with ESMTP id k3J7iFpB054948; Wed, 19 Apr 2006 09:44:16 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k3J7n93e049789; Wed, 19 Apr 2006 09:49:09 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 19 Apr 2006 09:49:09 +0200 Message-ID: <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> X-Priority: 3 (Normal) Date: Wed, 19 Apr 2006 09:49:09 +0200 From: Alexander Leidinger To: John-Mark Gurney References: <20060418032520.GG38619@funkthat.com> In-Reply-To: <20060418032520.GG38619@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: arch@freebsd.org, multimedia@freebsd.org Subject: Re: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 07:49:16 -0000 Quoting John-Mark Gurney (from Mon, 17 =20 Apr 2006 20:25:20 -0700): > Well, I noticed that we have a few extra snd_'s in front of most (all?) If it's not in front of all drivers for sound chips (!=3D all modules =20 which make up the sound system), it's an inconsistency which should be =20 fixed. > of our sound drives.. I believe this used to be necessary due to lack of > kldxref which couldn't find modules w/ different names than the modules.. > Now that this has been fixed, I feel that we should drop these so we > don't have issues w/ name mismatches, such as introduced w/ gusc and sbc.. What are the benefits of this patch? Why should we commit it? What's =20 wrong with the current way of naming? How is this patch an improvement? I don't object to the patch (haven't tested it), but what are the benefits? Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Q:=09How many people from New Jersey does it take to change a light =09=09bulb? A:=09Three. One to do it, one to watch, and the third to shoot the =09=09witness. From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 07:53:14 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DD7316A402 for ; Wed, 19 Apr 2006 07:53:14 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 266A343D5F; Wed, 19 Apr 2006 07:53:10 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5F24F.dip.t-dialin.net [84.165.242.79]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.1) with ESMTP id k3J7mCu6054960; Wed, 19 Apr 2006 09:48:12 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k3J7r5xA050379; Wed, 19 Apr 2006 09:53:05 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 19 Apr 2006 09:53:05 +0200 Message-ID: <20060419095305.99ilp36g0kwswgsk@netchild.homeip.net> X-Priority: 3 (Normal) Date: Wed, 19 Apr 2006 09:53:05 +0200 From: Alexander Leidinger To: pfgshield-freebsd@yahoo.com References: <20060418194832.723.qmail@web32715.mail.mud.yahoo.com> In-Reply-To: <20060418194832.723.qmail@web32715.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: nsouchu@freebsd.org, freebsd-arch@freebsd.org Subject: Re: Google's summer of code topics? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 07:53:14 -0000 Quoting pfgshield-freebsd@yahoo.com (from Tue, 18 Apr 2006 21:48:32 +0200 (CEST)): >> From my personal wishlist: > > - A port of NetBSD's wscons. > - more KGI4BSD. > > I don't know who could be a technical contact, well.. Nicholas for KGI, I > guess. Not related to the SoC directly, but everyone is free to submit (plain text) entries for the ideas list at http://www.freebsd.org/projects/ideas/. They will be added if they look sane and comply mostly to the style of the already existing entries (we may try to improve submissions, and we may point out deficiencies in them, so it doesn't needs to be perfect the first time). Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Observe yon plumed biped fine. To activate its captivation, Deposit on its termination, A quantity of particles saline. From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 08:27:21 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EB5516A400; Wed, 19 Apr 2006 08:27:21 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id B569343D49; Wed, 19 Apr 2006 08:27:20 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (6zbp0rk13drgdohd@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3J8RJIm069700; Wed, 19 Apr 2006 01:27:19 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3J8RHIp069699; Wed, 19 Apr 2006 01:27:17 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Apr 2006 01:27:17 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20060419082716.GJ38619@funkthat.com> Mail-Followup-To: Alexander Leidinger , multimedia@freebsd.org, arch@freebsd.org References: <20060418032520.GG38619@funkthat.com> <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: arch@freebsd.org, multimedia@freebsd.org Subject: Re: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 08:27:21 -0000 Alexander Leidinger wrote this message on Wed, Apr 19, 2006 at 09:49 +0200: > Quoting John-Mark Gurney (from Mon, 17 > Apr 2006 20:25:20 -0700): > > >Well, I noticed that we have a few extra snd_'s in front of most (all?) > > If it's not in front of all drivers for sound chips (!= all modules > which make up the sound system), it's an inconsistency which should be > fixed. > > >of our sound drives.. I believe this used to be necessary due to lack of > >kldxref which couldn't find modules w/ different names than the modules.. > >Now that this has been fixed, I feel that we should drop these so we > >don't have issues w/ name mismatches, such as introduced w/ gusc and sbc.. > > What are the benefits of this patch? Why should we commit it? What's > wrong with the current way of naming? How is this patch an improvement? > > I don't object to the patch (haven't tested it), but what are the benefits? The benifits are more consistant naming of our modules... Only three ethernet modules have if_ in front, and the rest are the raw device names.. It also means that the module names matches more closely to the driver that implemented by them (though this is a bit complicated w/ the fact that pcm is the real driver behind these modules and pcm isn't it's own device node)... It also makes my driver/module dependancy script do the correct thing wrt to gusc and sbc.. (The graph can be seen at: http://people.FreeBSD.org/~jmg/driver.pdf )... With out this change gusc and sbc would be their own sub-graphs not connected to anything besides their children... Though I do realize that sound module names are special since they can (and do) end in numbers which none of our other drivers do... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 09:01:33 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 858F016A402; Wed, 19 Apr 2006 09:01:33 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id C105243D48; Wed, 19 Apr 2006 09:01:32 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5F24F.dip.t-dialin.net [84.165.242.79]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.4/8.13.1) with ESMTP id k3J8uWcH055187; Wed, 19 Apr 2006 10:56:33 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.4/8.13.3) with ESMTP id k3J91QLU060266; Wed, 19 Apr 2006 11:01:26 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 19 Apr 2006 11:01:26 +0200 Message-ID: <20060419110126.4iz4bj0x5wo4wwgk@netchild.homeip.net> X-Priority: 3 (Normal) Date: Wed, 19 Apr 2006 11:01:26 +0200 From: Alexander Leidinger To: John-Mark Gurney References: <20060418032520.GG38619@funkthat.com> <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> <20060419082716.GJ38619@funkthat.com> In-Reply-To: <20060419082716.GJ38619@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: arch@freebsd.org, multimedia@freebsd.org Subject: Re: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 09:01:33 -0000 Quoting John-Mark Gurney (from Wed, 19 =20 Apr 2006 01:27:17 -0700): > Alexander Leidinger wrote this message on Wed, Apr 19, 2006 at 09:49 +0200= : >> What are the benefits of this patch? Why should we commit it? What's >> wrong with the current way of naming? How is this patch an improvement? >> >> I don't object to the patch (haven't tested it), but what are the benefit= s? > > The benifits are more consistant naming of our modules... Only three > ethernet modules have if_ in front, and the rest are the raw device > names.. It also means that the module names matches more closely to If no problem shows up (see below), this reason is good enough for me =20 to not object to such a change. > the driver that implemented by them (though this is a bit complicated > w/ the fact that pcm is the real driver behind these modules and pcm > isn't it's own device node)... It also makes my driver/module dependancy Do you suggest to make pcm it's own device node, and if you do, what =20 are the benefits/...? > script do the correct thing wrt to gusc and sbc.. (The graph can be > seen at: http://people.FreeBSD.org/~jmg/driver.pdf )... With out this > change gusc and sbc would be their own sub-graphs not connected to > anything besides their children... And we can't change gusc and sbc in a way to make your script work as =20 intended? I don't suggest doing this instead of your proposal, I just =20 want to know what options we have. > Though I do realize that sound module names are special since they > can (and do) end in numbers which none of our other drivers do... Is this a problem? And if yes, why is this not a problem with the =20 current snd_ prefix? Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Slang is language that takes off its coat, spits on its hands, and goes to work. From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 17:03:36 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0DEDB16A406 for ; Wed, 19 Apr 2006 17:03:36 +0000 (UTC) (envelope-from designrg@free.fr) Received: from perso0.free.fr (perso0.free.fr [212.27.63.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AE9543D45 for ; Wed, 19 Apr 2006 17:03:33 +0000 (GMT) (envelope-from designrg@free.fr) Received: from localhost.localdomain (localhost [127.0.0.1]) by perso0.free.fr (Postfix) with ESMTP id 764591165C2 for ; Wed, 19 Apr 2006 19:03:32 +0200 (MEST) XPARM: designrg.free.fr XPARAM2: 82.255.245.178 Date: Wed, 19 Apr 2006 19:03:32 +0200 From: L'Equipe Designrg Message-ID: X-Priority: 3 X-Mailer: PHPMailer [version 1.72] Content-Transfer-Encoding: 8bit To: freebsd-arch@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Newslettre d'avril 2006 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 17:03:36 -0000 [1]Version Anglaise .. Bonjour,à la recherche d'aide L'Equipe DesignRG sur [2]Designrg.free.fr est là pour vous gratuitement Un forum d'aide gratuit et rapide est à votre disposition [3]Accès Forum APPRENDRE Vous souhaitez apprendre gratuitement le: Php / Mysql Html Svcd Convertir Divx to dvd Convertir Divx to dvd (ver 2) Comment Débloquer Smartphone Partager une connexion adsl pour vos pc Lutter contre RIAA [4]Vous devez venir pour vous enrichir gratuitement Mercredi 19 Avril 2006 DES OUTILS POUR WEBMASTER Générateur de balise Vérifier vos méta tag Référencement Référencement (V2) Scripts PHP Scripts JAVASCRIPTS Mercredi 19 Avril 2006 DES TELECHARGEMENTS Télécharger des fichiers en français et exclusif et toujours gratuit, vous pouvez aussi ajouter vos propres fichiers [5]Accès au téléchargement Mercredi 19 Avril 2006 D'AUTRES MENU UTILES - DES PROBLEMES D ERREUR NOUS AVONS LES SOLUTIONS - VOUS SOUHAITEZ CONFIGURER ET OPTIMISER VOS LOGICIELS VENEZ VITE !! - DES PHOTOS PANORAMIQUES OU INTERACTIVES & VIDEOS EXCLUSIVES Mercredi 19 Avril 2006 On vous attend sur notre site, http://designrg.free.fr A Bientôt Pour vous désinscrire : [6]http://designrg.free.fr/Newsletter/subscription.php?list_id=1&op=le ave&email_addr=freebsd-arch%40freebsd.org References 1. http://translate.google.com/translate?u=http%3A//Designrg.free.fr/Newslettre/lettre/lettretypeavril.htm&langpair=fr|en&hl=en&ie=UTF-8&oe=UTF-8&prev=/language_tools 2. http://designrg.free.Fr/ 3. http://designrg.free.fr/lightforum 4. http://designrg.free.fr/ 5. http://designrg.free.fr/telecharger.php 6. http://designrg.free.fr/Newsletter/subscription.php?list_id=1&op=leave&email_addr=freebsd-arch@freebsd.org From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 20:39:56 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15D9B16A400 for ; Wed, 19 Apr 2006 20:39:56 +0000 (UTC) (envelope-from dpkirchner@gmail.com) Received: from uproxy.gmail.com (uproxy.gmail.com [66.249.92.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E6F343D5A for ; Wed, 19 Apr 2006 20:39:53 +0000 (GMT) (envelope-from dpkirchner@gmail.com) Received: by uproxy.gmail.com with SMTP id m3so955002ugc for ; Wed, 19 Apr 2006 13:39:52 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:mime-version:content-type; b=A/XFFO5vZMIYhMB//0GdbVxIgENjTnY7tEn9VTs+zXL3Xwwfucw7sqEMveke/hKPNZILzEIlAkIjjef/tN3jh6aUwQfWLxgRT7i4yqGLcD6bB9Apjidhg5GN8DafyZW2+XTQDbqNgdvn6JD2BdeNfUyhhulkSU8quj6m71AMoTA= Received: by 10.78.45.13 with SMTP id s13mr92659hus; Wed, 19 Apr 2006 13:39:52 -0700 (PDT) Received: by 10.78.13.2 with HTTP; Wed, 19 Apr 2006 13:39:52 -0700 (PDT) Message-ID: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> Date: Wed, 19 Apr 2006 13:39:52 -0700 From: "David Kirchner" Sender: dpkirchner@gmail.com To: arch@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_14898_9999084.1145479192476" Cc: Subject: Add some more information in the ktrace(1)/kdump(1) output X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 20:39:56 -0000 ------=_Part_14898_9999084.1145479192476 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Please Cc: me on replies as I am not a member of this list. I'm working with Alexander Leidinger on the ktrace project mentioned on the ideas page. I've attached a patch, made against 6.1-RC (and should work against -CURRENT). The patch modifies kdump output to use strings instead of numbers for every(I believe) relevant syscall. For example, the output before: 32229 telnet CALL mmap(0,0x8000,0x3,0x1002,0xffffffff,0,0,0) 32229 telnet CALL open(0x2807bc28,0,0x1b6) 32229 telnet CALL socket(0x2,0x2,0) is now: 32229 telnet CALL=20 mmap(0,0x8000,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANON,0xffffffff,0,0,0) 32229 telnet CALL open(0x2807bc28,O_RDONLY,0x1b6) 32229 telnet CALL socket(PF_INET,SOCK_DGRAM,0) I'd appreciate any feedback you may have. This is just one half of the project; the other half will involve updating the kernel to include more data in the dump output. I'm thinking, specifically, adding KTR_STAT for stat() results and KTR_SOCKADDR for connect(), bind() arguments, and accept() results. ------=_Part_14898_9999084.1145479192476 Content-Type: text/x-patch; name="kdump.20060419.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kdump.20060419.patch" X-Attachment-Id: f_em84qbwt ZGlmZiAtdXJOIGtkdW1wLm9yaWcvTWFrZWZpbGUga2R1bXAvTWFrZWZpbGUKLS0tIGtkdW1wLm9y aWcvTWFrZWZpbGUJVHVlIEp1bCAyMyAwMjoxNTo0NSAyMDAyCisrKyBrZHVtcC9NYWtlZmlsZQlU dWUgQXByIDE4IDE0OjE1OjI5IDIwMDYKQEAgLTQsMTIgKzQsMTUgQEAKIC5QQVRIOiAkey5DVVJE SVJ9Ly4uL2t0cmFjZQogCiBQUk9HPQkJa2R1bXAKLVNSQ1M9CQlrZHVtcC5jIGlvY3RsLmMgc3Vi ci5jCi1DRkxBR1MrPQktSSR7LkNVUkRJUn0vLi4va3RyYWNlIC1JJHsuQ1VSRElSfS8uLi8uLgor U1JDUz0JCWtkdW1wLmMgaW9jdGwuYyBrZHVtcF9zdWJyLmMgc3Vici5jCitDRkxBR1MrPQktSSR7 LkNVUkRJUn0vLi4va3RyYWNlIC1JJHsuQ1VSRElSfSAtSSR7LkNVUkRJUn0vLi4vLi4KIAotQ0xF QU5GSUxFUz0JaW9jdGwuYworQ0xFQU5GSUxFUz0JaW9jdGwuYyBrZHVtcF9zdWJyLmMKIAogaW9j dGwuYzogbWtpb2N0bHMKIAlzaCAkey5DVVJESVJ9L21raW9jdGxzICR7REVTVERJUn0vdXNyL2lu Y2x1ZGUgPiAkey5UQVJHRVR9CisKK2tkdW1wX3N1YnIuYzogbWtzdWJyCisJc2ggJHsuQ1VSRElS fS9ta3N1YnIgJHtERVNURElSfS91c3IvaW5jbHVkZSA+ICR7LlRBUkdFVH0KIAogLmluY2x1ZGUg PGJzZC5wcm9nLm1rPgpkaWZmIC11ck4ga2R1bXAub3JpZy9rZHVtcC5jIGtkdW1wL2tkdW1wLmMK LS0tIGtkdW1wLm9yaWcva2R1bXAuYwlNb24gRmViIDEzIDE5OjI4OjMxIDIwMDYKKysrIGtkdW1w L2tkdW1wLmMJVHVlIEFwciAxOCAxNDowNjoyNiAyMDA2CkBAIC02Niw2ICs2Niw3IEBACiAjaW5j bHVkZSA8dW5pc3RkLmg+CiAjaW5jbHVkZSA8dmlzLmg+CiAjaW5jbHVkZSAia3RyYWNlLmgiCisj aW5jbHVkZSAia2R1bXBfc3Vici5oIgogCiBpbnQgZnJlYWRfdGFpbCh2b2lkICosIGludCwgaW50 KTsKIHZvaWQgZHVtcGhlYWRlcihzdHJ1Y3Qga3RyX2hlYWRlciAqKTsKQEAgLTMyMCwxNCArMzIx LDIwIEBACiAJaWYgKG5hcmcpIHsKIAkJY2hhciBjID0gJygnOwogCQlpZiAoZmFuY3kpIHsKKwor I2RlZmluZSBwcmludF9udW1iZXIoaSxuLGMpIGRvIHsgICAgICAgICAgICAgICAgICAgICAgXAor CWlmIChkZWNpbWFsKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisJCSh2b2lk KXByaW50ZigiJWMlbGQiLCBjLCAobG9uZykqaSk7ICAgXAorCWVsc2UgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcCisJCSh2b2lkKXByaW50ZigiJWMlI2x4IiwgYywg KGxvbmcpKmkpOyAgXAorCWkrKzsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCisJbi0tOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwK KwljID0gJywnOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorCX0gd2hp bGUgKDApOworCiAJCQlpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfaW9jdGwpIHsKIAkJCQljb25z dCBjaGFyICpjcDsKLQkJCQlpZiAoZGVjaW1hbCkKLQkJCQkJKHZvaWQpcHJpbnRmKCIoJWxkIiwg KGxvbmcpKmlwKTsKLQkJCQllbHNlCi0JCQkJCSh2b2lkKXByaW50ZigiKCUjbHgiLCAobG9uZykq aXApOwotCQkJCWlwKys7Ci0JCQkJbmFyZy0tOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMp OwogCQkJCWlmICgoY3AgPSBpb2N0bG5hbWUoKmlwKSkgIT0gTlVMTCkKIAkJCQkJKHZvaWQpcHJp bnRmKCIsJXMiLCBjcCk7CiAJCQkJZWxzZSB7CkBAIC0zNzIsMTYgKzM3OSwzODQgQEAKIAkJCQlj ID0gJywnOwogCQkJCWlwKys7CiAJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9j b2RlID09IFNZU19hY2Nlc3MgfHwKKwkJCQkgICBrdHItPmt0cl9jb2RlID09IFNZU19lYWNjZXNz KSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcp OworCQkJCWFjY2Vzc21vZGVuYW1lICgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07 CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX29wZW4pIHsKKwkJCQlpbnQJZmxh Z3M7CisJCQkJaW50CW1vZGU7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJZmxh Z3MgPSAqaXA7CisJCQkJbW9kZSA9ICorK2lwOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJ CQlmbGFnc2FuZG1vZGVuYW1lIChmbGFncywgbW9kZSwgZGVjaW1hbCk7CisJCQkJaXArKzsKKwkJ CQluYXJnLT0yOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU193YWl0NCkgewor CQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMp OworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQl3YWl0NG9wdG5hbWUgKChpbnQpKmlwKTsK KwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBT WVNfY2htb2QgfHwKKwkJCQkgICBrdHItPmt0cl9jb2RlID09IFNZU19mY2htb2QgfHwKKwkJCQkg ICBrdHItPmt0cl9jb2RlID09IFNZU19sY2htb2QpIHsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFy ZyxjKTsKKwkJCQkodm9pZClwdXRjaGFyKCcsJyk7CisJCQkJbW9kZW5hbWUgKChpbnQpKmlwKTsK KwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBT WVNfbWtub2QpIHsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQkodm9pZClwdXRj aGFyKCcsJyk7CisJCQkJbW9kZW5hbWUgKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmct LTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfZ2V0ZnNzdGF0KSB7CisJCQkJ cHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJ CQkJKHZvaWQpcHV0Y2hhcignLCcpOworCQkJCWdldGZzc3RhdGZsYWdzbmFtZSAoKGludCkqaXAp OworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09 IFNZU19tb3VudCkgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251 bWJlcihpcCxuYXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQltb3VudGZsYWdz bmFtZSAoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChr dHItPmt0cl9jb2RlID09IFNZU191bm1vdW50KSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcs Yyk7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcpOworCQkJCW1vdW50ZmxhZ3NuYW1lICgoaW50KSpp cCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUg PT0gU1lTX3JlY3Ztc2cgfHwKKwkJCQkgICBrdHItPmt0cl9jb2RlID09IFNZU19zZW5kbXNnKSB7 CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcs Yyk7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcpOworCQkJCXNlbmRyZWN2ZmxhZ3NuYW1lICgoaW50 KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2Nv ZGUgPT0gU1lTX3JlY3Zmcm9tIHx8CisJCQkJICAga3RyLT5rdHJfY29kZSA9PSBTWVNfc2VuZHRv KSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5h cmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJKHZvaWQpcHV0Y2hhcign LCcpOworCQkJCXNlbmRyZWN2ZmxhZ3NuYW1lICgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQlu YXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX2NoZmxhZ3MgfHwKKwkJ CQkgICBrdHItPmt0cl9jb2RlID09IFNZU19mY2hmbGFncyB8fAorCQkJCSAgIGt0ci0+a3RyX2Nv ZGUgPT0gU1lTX2xjaGZsYWdzKSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJ KHZvaWQpcHV0Y2hhcignLCcpOworCQkJCW1vZGVuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOwor CQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfa2lsbCkgewor CQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJ CQlzaWduYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBp ZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfcmVib290KSB7CisJCQkJKHZvaWQpcHV0Y2hhcignKCcp OworCQkJCXJlYm9vdG9wdG5hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOwor CQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU191bWFzaykgeworCQkJCSh2b2lkKXB1 dGNoYXIoJygnKTsKKwkJCQltb2RlbmFtZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJn LS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX21zeW5jKSB7CisJCQkJcHJp bnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJ KHZvaWQpcHV0Y2hhcignLCcpOworCQkJCW1zeW5jZmxhZ3NuYW1lKChpbnQpKmlwKTsKKwkJCQlp cCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfbW1h cCkgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxu YXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQltbWFwcHJvdG5hbWUgKChpbnQp KmlwKTsKKwkJCQkodm9pZClwdXRjaGFyKCcsJyk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJ CQkJbW1hcGZsYWdzbmFtZSAoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJ fSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19tcHJvdGVjdCkgeworCQkJCXByaW50X251 bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCSh2b2lk KXB1dGNoYXIoJywnKTsKKwkJCQltbWFwcHJvdG5hbWUgKChpbnQpKmlwKTsKKwkJCQlpcCsrOwor CQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfbWFkdmlzZSkg eworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJn LGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQltYWR2aXNlYmVoYXZuYW1lKChpbnQp KmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29k ZSA9PSBTWVNfc2V0cHJpb3JpdHkpIHsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJ CQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQkodm9pZClwdXRjaGFyKCcsJyk7CisJCQkJ cHJpb25hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlm IChrdHItPmt0cl9jb2RlID09IFNZU19mY250bCkgeworCQkJCWludCBjbWQ7CisJCQkJaW50IGFy ZzsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQljbWQgPSAqaXA7CisJCQkJYXJn ID0gKisraXA7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcpOworCQkJCWZjbnRsY21kbmFtZShjbWQs IGFyZywgZGVjaW1hbCk7CisJCQkJaXArKzsKKwkJCQluYXJnLT0yOworCQkJfSBlbHNlIGlmIChr dHItPmt0cl9jb2RlID09IFNZU19zb2NrZXQpIHsKKwkJCQkodm9pZClwdXRjaGFyKCcoJyk7CisJ CQkJc29ja2RvbWFpbm5hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJ CSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQlzb2NrdHlwZW5hbWUoKGludCkqaXApOworCQkJCWlw Kys7CisJCQkJbmFyZy0tOworCQkJCWMgPSAnLCc7CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2Nv ZGUgPT0gU1lTX3NldHNvY2tvcHQgfHwKKwkJCQkgICBrdHItPmt0cl9jb2RlID09IFNZU19nZXRz b2Nrb3B0KSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJKHZvaWQpcHV0Y2hh cignLCcpOworCQkJCXNvY2tvcHRsZXZlbG5hbWUoKGludCkqaXAsIGRlY2ltYWwpOworCQkJCWlw Kys7CisJCQkJbmFyZy0tOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQlzb2Nrb3B0bmFt ZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+ a3RyX2NvZGUgPT0gU1lTX2xzZWVrKSB7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJ CQkJLyogSGlkZGVuICdwYWQnIGFyZ3VtZW50LCBub3QgaW4gbHNlZWsoMikgKi8KKwkJCQlwcmlu dF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQko dm9pZClwdXRjaGFyKCcsJyk7CisJCQkJd2hlbmNlbmFtZSAoKGludCkqaXApOworCQkJCWlwKys7 CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19mbG9jaykg eworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsK KwkJCQlmbG9ja25hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBl bHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19ta2ZpZm8gfHwKKwkJCQkgICBrdHItPmt0cl9j b2RlID09IFNZU19ta2RpcikgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCSh2 b2lkKXB1dGNoYXIoJywnKTsKKwkJCQltb2RlbmFtZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJ CQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3NodXRkb3duKSB7 CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcpOwor CQkJCXNodXRkb3duaG93bmFtZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJ CQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3NvY2tldHBhaXIpIHsKKwkJCQkodm9p ZClwdXRjaGFyKCcoJyk7CisJCQkJc29ja2RvbWFpbm5hbWUoKGludCkqaXApOworCQkJCWlwKys7 CisJCQkJbmFyZy0tOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQlzb2NrdHlwZW5hbWUo KGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJCWMgPSAnLCc7CisJCQl9IGVs c2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX2dldHJsaW1pdCB8fAorCQkJCSAgIGt0ci0+a3Ry X2NvZGUgPT0gU1lTX3NldHJsaW1pdCkgeworCQkJCSh2b2lkKXB1dGNoYXIoJygnKTsKKwkJCQly bGltaXRuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCQljID0gJywn OworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19xdW90YWN0bCkgeworCQkJCXBy aW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXF1b3RhY3RsbmFtZSgoaW50KSppcCk7CisJCQkJ aXArKzsKKwkJCQluYXJnLS07CisJCQkJYyA9ICcsJzsKKwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJf Y29kZSA9PSBTWVNfbmZzc3ZjKSB7CisJCQkJKHZvaWQpcHV0Y2hhcignKCcpOworCQkJCW5mc3N2 Y25hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJCWMgPSAnLCc7CisJ CQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3J0cHJpbykgeworCQkJCSh2b2lkKXB1 dGNoYXIoJygnKTsKKwkJCQlydHByaW9uYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5h cmctLTsKKwkJCQljID0gJywnOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19f X3NlbWN0bCkgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJl cihpcCxuYXJnLGMpOworCQkJCXNlbWN0bG5hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJ bmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19zZW1nZXQpIHsKKwkJ CQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsK KwkJCQlzZW1nZXRuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0g ZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfbXNnY3RsKSB7CisJCQkJcHJpbnRfbnVtYmVy KGlwLG5hcmcsYyk7CisJCQkJc2htY3RsbmFtZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQlu YXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3NobWF0KSB7CisJCQkJ cHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJ CQkJc2htYXRuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxz ZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfc2htY3RsKSB7CisJCQkJcHJpbnRfbnVtYmVyKGlw LG5hcmcsYyk7CisJCQkJc2htY3RsbmFtZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJn LS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX21pbmhlcml0KSB7CisJCQkJ cHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJ CQkJbWluaGVyaXRuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0g ZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfcmZvcmspIHsKKwkJCQkodm9pZClwdXRjaGFy KCcoJyk7CisJCQkJcmZvcmtuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsK KwkJCQljID0gJywnOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19saW9fbGlz dGlvKSB7CisJCQkJKHZvaWQpcHV0Y2hhcignKCcpOworCQkJCWxpb19saXN0aW9uYW1lKChpbnQp KmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCQljID0gJywnOworCQkJfSBlbHNlIGlm IChrdHItPmt0cl9jb2RlID09IFNZU19tbG9ja2FsbCkgeworCQkJCSh2b2lkKXB1dGNoYXIoJygn KTsKKwkJCQltbG9ja2FsbG5hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOwor CQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19zY2hlZF9zZXRzY2hlZHVsZXIpIHsK KwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQlzY2hlZHBvbGljeW5hbWUoKGludCkq aXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2Rl ID09IFNZU19zY2hlZF9nZXRfcHJpb3JpdHlfbWF4IHx8CisJCQkJICAga3RyLT5rdHJfY29kZSA9 PSBTWVNfc2NoZWRfZ2V0X3ByaW9yaXR5X21pbikgeworCQkJCSh2b2lkKXB1dGNoYXIoJygnKTsK KwkJCQlzY2hlZHBvbGljeW5hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOwor CQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU19zZW5kZmlsZSkgeworCQkJCXByaW50 X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXBy aW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJ CXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOwor CQkJCXNlbmRmaWxlZmxhZ3NuYW1lKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsK KwkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfa2xkc3ltKSB7CisJCQkJcHJpbnRf bnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJa2xkc3ltY21kbmFtZSgoaW50KSppcCk7CisJCQkJaXAr KzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3NpZ3By b2NtYXNrKSB7CisJCQkJKHZvaWQpcHV0Y2hhcignKCcpOworCQkJCXNpZ3Byb2NtYXNraG93bmFt ZSgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJCQkJYyA9ICcsJzsKKwkJCX0g ZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfX19hY2xfZ2V0X2ZpbGUgfHwKKwkJCQkgICBr dHItPmt0cl9jb2RlID09IFNZU19fX2FjbF9zZXRfZmlsZSB8fAorCQkJCSAgIGt0ci0+a3RyX2Nv ZGUgPT0gU1lTX19fYWNsX2dldF9mZCB8fAorCQkJCSAgIGt0ci0+a3RyX2NvZGUgPT0gU1lTX19f YWNsX3NldF9mZCB8fAorCQkJCSAgIGt0ci0+a3RyX2NvZGUgPT0gU1lTX19fYWNsX2RlbGV0ZV9m aWxlIHx8CisJCQkJICAga3RyLT5rdHJfY29kZSA9PSBTWVNfX19hY2xfZGVsZXRlX2ZkIHx8CisJ CQkJICAga3RyLT5rdHJfY29kZSA9PSBTWVNfX19hY2xfYWNsY2hlY2tfZmlsZSB8fAorCQkJCSAg IGt0ci0+a3RyX2NvZGUgPT0gU1lTX19fYWNsX2FjbGNoZWNrX2ZkIHx8CisJCQkJICAga3RyLT5r dHJfY29kZSA9PSBTWVNfX19hY2xfZ2V0X2xpbmsgfHwKKwkJCQkgICBrdHItPmt0cl9jb2RlID09 IFNZU19fX2FjbF9zZXRfbGluayB8fAorCQkJCSAgIGt0ci0+a3RyX2NvZGUgPT0gU1lTX19fYWNs X2RlbGV0ZV9saW5rIHx8CisJCQkJICAga3RyLT5rdHJfY29kZSA9PSBTWVNfX19hY2xfYWNsY2hl Y2tfbGluaykgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCWFjbHR5cGVuYW1l KChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3RyLT5r dHJfY29kZSA9PSBTWVNfc2lnYWN0aW9uKSB7CisJCQkJKHZvaWQpcHV0Y2hhcignKCcpOworCQkJ CXNpZ25hbWUoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJCWMgPSAnLCc7 CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX2V4dGF0dHJjdGwpIHsKKwkJCQlw cmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQlleHRhdHRyY3RsbmFtZSgoaW50KSppcCk7CisJ CQkJaXArKzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lT X25tb3VudCkgeworCQkJCXByaW50X251bWJlcihpcCxuYXJnLGMpOworCQkJCXByaW50X251bWJl cihpcCxuYXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQltb3VudGZsYWdzbmFt ZSAoKGludCkqaXApOworCQkJCWlwKys7CisJCQkJbmFyZy0tOworCQkJfSBlbHNlIGlmIChrdHIt Pmt0cl9jb2RlID09IFNZU19rc2VfdGhyX2ludGVycnVwdCkgeworCQkJCXByaW50X251bWJlcihp cCxuYXJnLGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQlrc2V0aHJjbWRuYW1lICgo aW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CisJCQl9IGVsc2UgaWYgKGt0ci0+a3Ry X2NvZGUgPT0gU1lTX3Rocl9jcmVhdGUpIHsKKwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsK KwkJCQlwcmludF9udW1iZXIoaXAsbmFyZyxjKTsKKwkJCQkodm9pZClwdXRjaGFyKCcsJyk7CisJ CQkJdGhyY3JlYXRlZmxhZ3NuYW1lICgoaW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07 CisJCQl9IGVsc2UgaWYgKGt0ci0+a3RyX2NvZGUgPT0gU1lTX3Rocl9raWxsKSB7CisJCQkJcHJp bnRfbnVtYmVyKGlwLG5hcmcsYyk7CisJCQkJKHZvaWQpcHV0Y2hhcignLCcpOworCQkJCXNpZ25h bWUgKChpbnQpKmlwKTsKKwkJCQlpcCsrOworCQkJCW5hcmctLTsKKwkJCX0gZWxzZSBpZiAoa3Ry LT5rdHJfY29kZSA9PSBTWVNfa2xkdW5sb2FkZikgeworCQkJCXByaW50X251bWJlcihpcCxuYXJn LGMpOworCQkJCSh2b2lkKXB1dGNoYXIoJywnKTsKKwkJCQlrbGR1bmxvYWRmZmxhZ3NuYW1lICgo aW50KSppcCk7CisJCQkJaXArKzsKKwkJCQluYXJnLS07CiAJCQl9CiAJCX0KIAkJd2hpbGUgKG5h cmcpIHsKLQkJCWlmIChkZWNpbWFsKQotCQkJCSh2b2lkKXByaW50ZigiJWMlbGQiLCBjLCAobG9u ZykqaXApOwotCQkJZWxzZQotCQkJCSh2b2lkKXByaW50ZigiJWMlI2x4IiwgYywgKGxvbmcpKmlw KTsKLQkJCWMgPSAnLCc7Ci0JCQlpcCsrOwotCQkJbmFyZy0tOworCQkJcHJpbnRfbnVtYmVyKGlw LG5hcmcsYyk7CiAJCX0KIAkJKHZvaWQpcHV0Y2hhcignKScpOwogCX0KZGlmZiAtdXJOIGtkdW1w Lm9yaWcva2R1bXBfc3Vici5oIGtkdW1wL2tkdW1wX3N1YnIuaAotLS0ga2R1bXAub3JpZy9rZHVt cF9zdWJyLmgJV2VkIERlYyAzMSAxNjowMDowMCAxOTY5CisrKyBrZHVtcC9rZHVtcF9zdWJyLmgJ VHVlIEFwciAxOCAxNDowMjoxNSAyMDA2CkBAIC0wLDAgKzEsNDYgQEAKKy8qICRGcmVlQlNEJCAq LworCit2b2lkIHNpZ25hbWUgKGludCk7Cit2b2lkIHNlbWN0bG5hbWUgKGludCk7Cit2b2lkIHNo bWN0bG5hbWUgKGludCk7Cit2b2lkIHNlbWdldG5hbWUgKGludCk7Cit2b2lkIGZjbnRsY21kbmFt ZSAoaW50LCBpbnQsIGludCk7Cit2b2lkIHJ0cHJpb25hbWUgKGludCk7Cit2b2lkIG1vZGVuYW1l IChpbnQpOwordm9pZCBmbGFnc25hbWUgKGludCk7Cit2b2lkIGZsYWdzYW5kbW9kZW5hbWUgKGlu dCwgaW50LCBpbnQpOwordm9pZCBhY2Nlc3Ntb2RlbmFtZSAoaW50KTsKK3ZvaWQgbW1hcHByb3Ru YW1lIChpbnQpOwordm9pZCBtbWFwZmxhZ3NuYW1lIChpbnQpOwordm9pZCB3YWl0NG9wdG5hbWUg KGludCk7Cit2b2lkIHNlbmRyZWN2ZmxhZ3NuYW1lIChpbnQpOwordm9pZCBnZXRmc3N0YXRmbGFn c25hbWUgKGludCk7Cit2b2lkIG1vdW50ZmxhZ3NuYW1lIChpbnQpOwordm9pZCByZWJvb3RvcHRu YW1lIChpbnQpOwordm9pZCBmbG9ja25hbWUgKGludCk7Cit2b2lkIHNvY2tvcHRuYW1lIChpbnQp Owordm9pZCBzb2Nrb3B0bGV2ZWxuYW1lIChpbnQsIGludCk7Cit2b2lkIHNvY2tkb21haW5uYW1l IChpbnQpOwordm9pZCBzb2NrdHlwZW5hbWUgKGludCk7Cit2b2lkIHRocmNyZWF0ZWZsYWdzbmFt ZSAoaW50KTsKK3ZvaWQgbWxvY2thbGxuYW1lIChpbnQpOwordm9pZCBzaG1hdG5hbWUgKGludCk7 Cit2b2lkIHJmb3JrbmFtZSAoaW50KTsKK3ZvaWQgbmZzc3ZjbmFtZSAoaW50KTsKK3ZvaWQgd2hl bmNlbmFtZSAoaW50KTsKK3ZvaWQgcmxpbWl0bmFtZSAoaW50KTsKK3ZvaWQgc2h1dGRvd25ob3du YW1lIChpbnQpOwordm9pZCBwcmlvbmFtZSAoaW50KTsKK3ZvaWQgbWFkdmlzZWJlaGF2bmFtZSAo aW50KTsKK3ZvaWQgbXN5bmNmbGFnc25hbWUgKGludCk7Cit2b2lkIHNjaGVkcG9saWN5bmFtZSAo aW50KTsKK3ZvaWQga2xkdW5sb2FkZmZsYWdzbmFtZSAoaW50KTsKK3ZvaWQga3NldGhyY21kbmFt ZSAoaW50KTsKK3ZvaWQgZXh0YXR0cmN0bG5hbWUgKGludCk7Cit2b2lkIGtsZHN5bWNtZG5hbWUg KGludCk7Cit2b2lkIHNlbmRmaWxlZmxhZ3NuYW1lIChpbnQpOwordm9pZCBhY2x0eXBlbmFtZSAo aW50KTsKK3ZvaWQgc2lncHJvY21hc2tob3duYW1lIChpbnQpOwordm9pZCBsaW9fbGlzdGlvbmFt ZSAoaW50KTsKK3ZvaWQgbWluaGVyaXRuYW1lIChpbnQpOwordm9pZCBxdW90YWN0bG5hbWUgKGlu dCk7CmRpZmYgLXVyTiBrZHVtcC5vcmlnL21rc3ViciBrZHVtcC9ta3N1YnIKLS0tIGtkdW1wLm9y aWcvbWtzdWJyCVdlZCBEZWMgMzEgMTY6MDA6MDAgMTk2OQorKysga2R1bXAvbWtzdWJyCVR1ZSBB cHIgMTggMTQ6MTM6NTEgMjAwNgpAQCAtMCwwICsxLDQwNyBAQAorc2V0IC1lCisKKyMgR2VuZXJh dGVzIGtkdW1wX3N1YnIuYworIyBta2lvY3RscyBpcyBhIHNwZWNpYWwtcHVycG9zZSBzY3JpcHQs IGFuZCB3b3JrcyBmaW5lIGFzIGl0IGlzCisjIG5vdywgc28gaXQgcmVtYWlucyBpbmRlcGVuZGVu dC4gVGhlIGlkZWEgYmVoaW5kIGhvdyBpdCBnZW5lcmF0ZXMKKyMgaXRzIGxpc3Qgd2FzIGhlYXZp bHkgYm9ycm93ZWQgaGVyZS4KKyMKKyMgU29tZSBmdW5jdGlvbnMgaGVyZSBhcmUgYXV0b21hdGlj YWxseSBnZW5lcmF0ZWQuIFRoaXMgY2FuIG1lYW4KKyMgdGhlIHVzZXIgd2lsbCBzZWUgdW51c3Vh bCBrZHVtcCBvdXRwdXQgb3IgZXJyb3JzIHdoaWxlIGJ1aWxkaW5nCisjIGlmIHRoZSB1bmRlcmx5 aW5nIC5oIGZpbGVzIGFyZSBjaGFuZ2VkIHNpZ25pZmljYW50bHkuCisjCisjIEtleToKKyMgQVVU TzogQ29tcGxldGVseSBhdXRvLWdlbmVyYXRlZCB3aXRoIGVpdGhlciB0aGUgIm9yIiBvciB0aGUg InN3aXRjaCIKKyMgbWV0aG9kLgorIyBBVVRPIC0gU3BlY2lhbDogR2VuZXJhdGVkIGF1dG9tYXRp Y2FsbHksIGJ1dCB3aXRoIHNvbWUgZXh0cmEgY29tbWFuZHMKKyMgdGhhdCB0aGUgYXV0b18qX3R5 cGUoKSBmdW5jdGlvbnMgYXJlIGluYXBwcm9wcmlhdGUgZm9yLgorIyBNQU5VQUw6IE1hbnVhbGx5 IGVudGVyZWQgYW5kIG11c3QgdGhlcmVmb3JlIGJlIG1hbnVhbGx5IHVwZGF0ZWQuCisKKyMgJEZy ZWVCU0QkCisKK0xDX0FMTD1DOyBleHBvcnQgTENfQUxMCisKK2lmIFsgLXogIiQxIiBdCit0aGVu CisJZWNobyAidXNhZ2U6IHNoICQwIGluY2x1ZGUtZGlyIgorCWV4aXQgMQorZmkKK2luY2x1ZGVf ZGlyPSQxCisKKyMKKyMgQXV0b21hdGljYWxseSBnZW5lcmF0ZXMgYSBDIGZ1bmN0aW9uIHRoYXQg d2lsbCBwcmludCBvdXQgdGhlCisjIG51bWVyaWMgaW5wdXQgYXMgYSBwaXBlLWRlbGltaXRlZCBz dHJpbmcgb2YgdGhlIGFwcHJvcHJpYXRlCisjICNkZWZpbmUga2V5cy4gZXg6CisjIFNfSVJVU1J8 U19JV1VTUnxTX0lSR1JQfFNfSVJPVEgKKyMgVGhlIFhPUiBpcyBuZWNlc3NhcnkgdG8gcHJldmVu dCBpbmNsdWRpbmcgdGhlICIwIi12YWx1ZSBpbiBldmVyeQorIyBsaW5lLgorIworYXV0b19vcl90 eXBlICgpIHsKKwlsb2NhbCBuYW1lIGdyZXAgZmlsZQorCW5hbWU9JDEKKwlncmVwPSQyCisJZmls ZT0kMworCisJY2F0IDw8X0VPRl8KKy8qIEFVVE8gKi8KK3ZvaWQKKyRuYW1lIChpbnQgYXJnKQor eworCWludAlvciA9IDA7CitfRU9GXworCWVncmVwICJeI1tbOnNwYWNlOl1dKmRlZmluZVtbOnNw YWNlOl1dKyIke2dyZXB9IltbOnNwYWNlOl1dKiIgXAorCQkkaW5jbHVkZV9kaXIvJGZpbGUgfCBc CisJYXdrICd7IGZvciAoaSA9IDE7IGkgPD0gTkY7IGkrKykgXAorCQlpZiAoJGkgfiAvZGVmaW5l LykgXAorCQkJYnJlYWs7IFwKKwkJKytpOyBcCisJCXByaW50ZiAiXHRpZighKChhcmc+MCleKCgl cyk+MCkpKVxuXHRcdGlmX3ByaW50X29yKGFyZywgJXMsIG9yKTtcbiIsICRpLCAkaSB9JworY2F0 IDw8X0VPRl8KKwlpZiAob3IgPT0gMCkKKwkJKHZvaWQpcHJpbnRmKCI8aW52YWxpZD4lbGQiLCAo bG9uZylhcmcpOworfQorCitfRU9GXworfQorCisjCisjIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVz IGEgQyBmdW5jdGlvbiB1c2VkIHdoZW4gdGhlIGFyZ3VtZW50CisjIG1hcHMgdG8gYSBzaW5nbGUs IHNwZWNpZmljICNkZWZpbml0aW9uCisjCithdXRvX3N3aXRjaF90eXBlICgpIHsKKwlsb2NhbCBu YW1lIGdyZXAgZmlsZQorCW5hbWU9JDEKKwlncmVwPSQyCisJZmlsZT0kMworCisJY2F0IDw8X0VP Rl8KKy8qIEFVVE8gKi8KK3ZvaWQKKyRuYW1lIChpbnQgYXJnKQoreworCXN3aXRjaCAoYXJnKSB7 CitfRU9GXworCWVncmVwICJeI1tbOnNwYWNlOl1dKmRlZmluZVtbOnNwYWNlOl1dKyIke2dyZXB9 IltbOnNwYWNlOl1dKiIgXAorCQkkaW5jbHVkZV9kaXIvJGZpbGUgfCBcCisJYXdrICd7IGZvciAo aSA9IDE7IGkgPD0gTkY7IGkrKykgXAorCQlpZiAoJGkgfiAvZGVmaW5lLykgXAorCQkJYnJlYWs7 IFwKKwkJKytpOyBcCisJCXByaW50ZiAiXHRjYXNlICVzOlxuXHRcdCh2b2lkKXByaW50ZihcIiVz XCIpO1xuXHRcdGJyZWFrO1xuIiwgJGksICRpIH0nCitjYXQgPDxfRU9GXworCWRlZmF1bHQ6IC8q IFNob3VsZCBub3QgcmVhY2ggKi8KKwkJKHZvaWQpcHJpbnRmKCI8aW52YWxpZD0lbGQ+IiwgKGxv bmcpYXJnKTsKKwl9Cit9CisKK19FT0ZfCit9CisKKyMgQyBzdGFydAorCitjYXQgPDxfRU9GXwor I2luY2x1ZGUgPHN0ZGlvLmg+CisjaW5jbHVkZSA8c3lzL2ZjbnRsLmg+CisjaW5jbHVkZSA8c3lz L3N0YXQuaD4KKyNpbmNsdWRlIDxzeXMvdW5pc3RkLmg+CisjaW5jbHVkZSA8c3lzL21tYW4uaD4K KyNpbmNsdWRlIDxzeXMvd2FpdC5oPgorI2RlZmluZSBfS0VSTkVMCisjaW5jbHVkZSA8c3lzL3Nv Y2tldC5oPgorI3VuZGVmIF9LRVJORUwKKyNpbmNsdWRlIDxzeXMvcGFyYW0uaD4KKyNpbmNsdWRl IDxzeXMvbW91bnQuaD4KKyNpbmNsdWRlIDxzeXMvcmVzb3VyY2UuaD4KKyNpbmNsdWRlIDxzeXMv cmVib290Lmg+CisjaW5jbHVkZSA8c2NoZWQuaD4KKyNpbmNsdWRlIDxzeXMvbGlua2VyLmg+Cisj ZGVmaW5lIF9LRVJORUwKKyNpbmNsdWRlIDxzeXMvdGhyLmg+CisjdW5kZWYgX0tFUk5FTAorI2lu Y2x1ZGUgPHN5cy9rc2UuaD4KKyNpbmNsdWRlIDxzeXMvZXh0YXR0ci5oPgorI2luY2x1ZGUgPHN5 cy9hY2wuaD4KKyNpbmNsdWRlIDxhaW8uaD4KKyNpbmNsdWRlIDxzeXMvc2VtLmg+CisjaW5jbHVk ZSA8c3lzL2lwYy5oPgorI2luY2x1ZGUgPHN5cy9ydHByaW8uaD4KKyNpbmNsdWRlIDxzeXMvc2ht Lmg+CisjaW5jbHVkZSA8bmZzc2VydmVyL25mcy5oPgorI2luY2x1ZGUgPHVmcy91ZnMvcXVvdGEu aD4KKworI2luY2x1ZGUgImtkdW1wX3N1YnIuaCIKKworLyoKKyAqIFRoZXNlIGFyZSBzaW1wbGUg c3VwcG9ydCBtYWNyb3MuIHByaW50X29yIHV0aWxpemVzIGEgdmFyaWFibGUKKyAqIGRlZmluZWQg aW4gdGhlIGNhbGxpbmcgZnVuY3Rpb24gdG8gdHJhY2sgd2hldGhlciBvciBub3QgaXQgc2hvdWxk CisgKiBwcmludCBhIGxvZ2ljYWwtT1IgY2hhcmFjdGVyICgnfCcpIGJlZm9yZSBhIHN0cmluZy4g aWZfcHJpbnRfb3IKKyAqIHNpbXBseSBoYW5kbGVzIHRoZSBuZWNlc3NhcnkgImlmIiBzdGF0ZW1l bnQgdXNlZCBpbiBtYW55IGxpbmVzCisgKiBvZiB0aGlzIGZpbGUuCisgKi8KKyNkZWZpbmUgcHJp bnRfb3Ioc3RyLG9yZmxhZykgZG8geyAgICAgICAgICAgICAgICAgIFxcCisJaWYgKG9yZmxhZykg cHV0Y2hhcignfCcpOyBlbHNlIG9yZmxhZyA9IDE7IFxcCisJcHJpbnRmIChzdHIpOyB9ICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFxcCisJd2hpbGUgKDApCisjZGVmaW5lIGlmX3ByaW50X29y KGksZmxhZyxvcmZsYWcpIGRvIHsgICAgICAgICAgICBcXAorCWlmICgoaSAmIGZsYWcpID09IGZs YWcpICAgICAgICAgICAgICAgICAgICBcXAorCXByaW50X29yKCNmbGFnLG9yZmxhZyk7IH0gICAg ICAgICAgICAgICAgICBcXAorCXdoaWxlICgwKQorCisvKiBNQU5VQUwgKi8KK2V4dGVybiBjaGFy ICpzaWduYW1lc1tdOyAvKiBmcm9tIGtkdW1wLmMgKi8KK3ZvaWQKK3NpZ25hbWUgKGludCBzaWcp Cit7CisJKHZvaWQpcHJpbnRmKCJTSUclcyIsc2lnbmFtZXNbc2lnXSk7Cit9CisKKy8qIE1BTlVB TCAqLwordm9pZAorc2VtY3RsbmFtZSAoaW50IGNtZCkKK3sKKwlzd2l0Y2ggKGNtZCkgeworCWNh c2UgR0VUTkNOVDoKKwkJKHZvaWQpcHJpbnRmKCJHRVROQ05UIik7CisJCWJyZWFrOworCWNhc2Ug R0VUUElEOgorCQkodm9pZClwcmludGYoIkdFVFBJRCIpOworCQlicmVhazsKKwljYXNlIEdFVFZB TDoKKwkJKHZvaWQpcHJpbnRmKCJHRVRWQUwiKTsKKwkJYnJlYWs7CisJY2FzZSBHRVRBTEw6CisJ CSh2b2lkKXByaW50ZigiR0VUQUxMIik7CisJCWJyZWFrOworCWNhc2UgR0VUWkNOVDoKKwkJKHZv aWQpcHJpbnRmKCJHRVRaQ05UIik7CisJCWJyZWFrOworCWNhc2UgU0VUVkFMOgorCQkodm9pZClw cmludGYoIlNFVFZBTCIpOworCQlicmVhazsKKwljYXNlIFNFVEFMTDoKKwkJKHZvaWQpcHJpbnRm KCJTRVRBTEwiKTsKKwkJYnJlYWs7CisJY2FzZSBJUENfUk1JRDoKKwkJKHZvaWQpcHJpbnRmKCJJ UENfUk1JRCIpOworCQlicmVhazsKKwljYXNlIElQQ19TRVQ6CisJCSh2b2lkKXByaW50ZigiSVBD X1NFVCIpOworCQlicmVhazsKKwljYXNlIElQQ19TVEFUOgorCQkodm9pZClwcmludGYoIklQQ19T VEFUIik7CisJCWJyZWFrOworCWRlZmF1bHQ6IC8qIFNob3VsZCBub3QgcmVhY2ggKi8KKwkJKHZv aWQpcHJpbnRmKCI8aW52YWxpZD0lbGQ+IiwgKGxvbmcpY21kKTsKKwl9Cit9CisKKy8qIE1BTlVB TCAqLwordm9pZAorc2htY3RsbmFtZSAoaW50IGNtZCkgeworCXN3aXRjaCAoY21kKSB7CisJY2Fz ZSBJUENfUk1JRDoKKwkJKHZvaWQpcHJpbnRmKCJJUENfUk1JRCIpOworCQlicmVhazsKKwljYXNl IElQQ19TRVQ6CisJCSh2b2lkKXByaW50ZigiSVBDX1NFVCIpOworCQlicmVhazsKKwljYXNlIElQ Q19TVEFUOgorCQkodm9pZClwcmludGYoIklQQ19TVEFUIik7CisJCWJyZWFrOworCWRlZmF1bHQ6 IC8qIFNob3VsZCBub3QgcmVhY2ggKi8KKwkJKHZvaWQpcHJpbnRmKCI8aW52YWxpZD0lbGQ+Iiwg KGxvbmcpY21kKTsKKwl9Cit9CisKKy8qIE1BTlVBTCAqLwordm9pZAorc2VtZ2V0bmFtZSAoaW50 IGZsYWcpIHsKKwlpbnQJb3IgPSAwOworCWlmX3ByaW50X29yKGZsYWcsIFNFTV9SLCBvcik7CisJ aWZfcHJpbnRfb3IoZmxhZywgU0VNX0EsIG9yKTsKKwlpZl9wcmludF9vcihmbGFnLCAoU0VNX1I+ PjMpLCBvcik7CisJaWZfcHJpbnRfb3IoZmxhZywgKFNFTV9BPj4zKSwgb3IpOworCWlmX3ByaW50 X29yKGZsYWcsIChTRU1fUj4+NiksIG9yKTsKKwlpZl9wcmludF9vcihmbGFnLCAoU0VNX0E+PjYp LCBvcik7Cit9CisKKy8qCisgKiBNQU5VQUwKKyAqCisgKiBPbmx5IHVzZWQgYnkgU1lTX29wZW4u IFVubGVzcyBPX0NSRUFUIGlzIHNldCBpbiBmbGFncywgdGhlCisgKiBtb2RlIGFyZ3VtZW50IGlz IHVudXNlZCAoYW5kIG9mdGVuIGJvZ3VzIGFuZCBtaXNsZWFkaW5nKS4KKyAqLwordm9pZAorZmxh Z3NhbmRtb2RlbmFtZSAoaW50IGZsYWdzLCBpbnQgbW9kZSwgaW50IGRlY2ltYWwpIHsKKwlmbGFn c25hbWUgKGZsYWdzKTsKKwkodm9pZClwdXRjaGFyKCcsJyk7CisJaWYgKChmbGFncyAmIE9fQ1JF QVQpID09IE9fQ1JFQVQpIHsKKwkJbW9kZW5hbWUgKG1vZGUpOworCX0gZWxzZSB7CisJCWlmIChk ZWNpbWFsKSB7CisJCQkodm9pZClwcmludGYoIjx1bnVzZWQ+JWxkIiwgKGxvbmcpbW9kZSk7CisJ CX0gZWxzZSB7CisJCQkodm9pZClwcmludGYoIjx1bnVzZWQ+JSNseCIsIChsb25nKW1vZGUpOwor CQl9CisJfQorfQorCisvKgorICogTUFOVUFMCisgKgorICogW2d8c11ldHNvY2tvcHQncyBsZXZl bCBhcmd1bWVudCBjYW4gZWl0aGVyIGJlIFNPTF9TT0NLRVQgb3IgYSB2YWx1ZQorICogcmVmZXJy aW5nIHRvIGEgbGluZSBpbiAvZXRjL3Byb3RvY29scyAuIEl0IG1pZ2h0IGJlIGFwcHJvcHJpYXRl CisgKiB0byB1c2UgZ2V0cHJvdG9lbnQoMykgaGVyZS4KKyAqLwordm9pZAorc29ja29wdGxldmVs bmFtZSAoaW50IGxldmVsLCBpbnQgZGVjaW1hbCkKK3sKKwlpZiAobGV2ZWwgPT0gU09MX1NPQ0tF VCkgeworCQkodm9pZClwcmludGYoIlNPTF9TT0NLRVQiKTsKKwl9IGVsc2UgeworCQlpZiAoZGVj aW1hbCkgeworCQkJKHZvaWQpcHJpbnRmKCIlbGQiLCAobG9uZylsZXZlbCk7CisJCX0gZWxzZSB7 CisJCQkodm9pZClwcmludGYoIiUjbHgiLCAobG9uZylsZXZlbCk7CisJCX0KKwl9Cit9CisKK19F T0ZfCisKK2F1dG9fb3JfdHlwZSAibW9kZW5hbWUiICJTX1tBLVpdK1tbOnNwYWNlOl1dK1swLTZd ezd9IiAic3lzL3N0YXQuaCIKK2F1dG9fb3JfdHlwZSAiZmxhZ3NuYW1lIiAiT19bQS1aXStbWzpz cGFjZTpdXSsweFswLTlBLUZhLWZdKyIgInN5cy9mY250bC5oIgorYXV0b19vcl90eXBlICJhY2Nl c3Ntb2RlbmFtZSIgIltBLVpdX09LW1s6c3BhY2U6XV0rMD94P1swLTlBLUZhLWZdKyIgInN5cy91 bmlzdGQuaCIKK2F1dG9fb3JfdHlwZSAibW1hcHByb3RuYW1lIiAiUFJPVF9bQS1aXStbWzpzcGFj ZTpdXSsweFswLTlBLUZhLWZdKyIgInN5cy9tbWFuLmgiCithdXRvX29yX3R5cGUgIm1tYXBmbGFn c25hbWUiICJNQVBfW0EtWl0rW1s6c3BhY2U6XV0rMHhbMC05QS1GYS1mXSsiICJzeXMvbW1hbi5o IgorYXV0b19vcl90eXBlICJ3YWl0NG9wdG5hbWUiICJXW0EtWl0rW1s6c3BhY2U6XV0rWzAtOV0r IiAic3lzL3dhaXQuaCIKK2F1dG9fb3JfdHlwZSAiZ2V0ZnNzdGF0ZmxhZ3NuYW1lIiAiTU5UX1tB LVpdK1tbOnNwYWNlOl1dK1sxLTldWzAtOV0qIiAic3lzL21vdW50LmgiCithdXRvX29yX3R5cGUg Im1vdW50ZmxhZ3NuYW1lIiAiTU5UX1tBLVpdK1tbOnNwYWNlOl1dKzB4WzAtOV0rIiAic3lzL21v dW50LmgiCithdXRvX29yX3R5cGUgInJlYm9vdG9wdG5hbWUiICJSQl9bQS1aXStbWzpzcGFjZTpd XSsweFswLTldKyIgInN5cy9yZWJvb3QuaCIKK2F1dG9fb3JfdHlwZSAiZmxvY2tuYW1lIiAiTE9D S19bQS1aXStbWzpzcGFjZTpdXSsweFswLTldKyIgInN5cy9mY250bC5oIgorYXV0b19vcl90eXBl ICJzb2Nrb3B0bmFtZSIgIlNPX1tBLVpdK1tbOnNwYWNlOl1dKzB4WzAtOV0rIiAic3lzL3NvY2tl dC5oIgorYXV0b19vcl90eXBlICJzb2NrZG9tYWlubmFtZSIgIlBGX1tBLVpdK1tbOnNwYWNlOl1d KyIgInN5cy9zb2NrZXQuaCIKK2F1dG9fb3JfdHlwZSAic29ja3R5cGVuYW1lIiAiU09DS19bQS1a XStbWzpzcGFjZTpdXStbMS05XStbMC05XSoiICJzeXMvc29ja2V0LmgiCithdXRvX29yX3R5cGUg InRocmNyZWF0ZWZsYWdzbmFtZSIgIlRIUl9bQS1aXStbWzpzcGFjZTpdXSsweFswLTldKyIgInN5 cy90aHIuaCIKK2F1dG9fb3JfdHlwZSAibWxvY2thbGxuYW1lIiAiTUNMX1tBLVpdK1tbOnNwYWNl Ol1dKzB4WzAtOV0rIiAic3lzL21tYW4uaCIKK2F1dG9fb3JfdHlwZSAic2htYXRuYW1lIiAiU0hN X1tBLVpdK1tbOnNwYWNlOl1dK1swLTldezZ9KyIgInN5cy9zaG0uaCIKK2F1dG9fb3JfdHlwZSAi cmZvcmtuYW1lIiAiUkZbQS1aXStbWzpzcGFjZTpdXStcKFswLTldKzw8WzAtOV0rXCkiICJzeXMv dW5pc3RkLmgiCithdXRvX29yX3R5cGUgIm5mc3N2Y25hbWUiICJORlNTVkNfW0EtWl0rW1s6c3Bh Y2U6XV0rMHhbMC05XSsiICJuZnNzZXJ2ZXIvbmZzLmgiCisKK2F1dG9fc3dpdGNoX3R5cGUgIndo ZW5jZW5hbWUiICJTRUVLX1tBLVpdK1tbOnNwYWNlOl1dK1swLTldKyIgInN5cy91bmlzdGQuaCIK K2F1dG9fc3dpdGNoX3R5cGUgInJsaW1pdG5hbWUiICJSTElNSVRfW0EtWl0rW1s6c3BhY2U6XV0r WzAtOV0rIiAic3lzL3Jlc291cmNlLmgiCithdXRvX3N3aXRjaF90eXBlICJzaHV0ZG93bmhvd25h bWUiICJTSFVUX1tBLVpdK1tbOnNwYWNlOl1dKzB4WzAtOV0rIiAic3lzL3NvY2tldC5oIgorYXV0 b19zd2l0Y2hfdHlwZSAicHJpb25hbWUiICJQUklPX1tBLVpdK1tbOnNwYWNlOl1dK1swLTldIiAi c3lzL3Jlc291cmNlLmgiCithdXRvX3N3aXRjaF90eXBlICJtYWR2aXNlYmVoYXZuYW1lIiAiXz9N QURWX1tBLVpdK1tbOnNwYWNlOl1dK1swLTldKyIgInN5cy9tbWFuLmgiCithdXRvX3N3aXRjaF90 eXBlICJtc3luY2ZsYWdzbmFtZSIgIk1TX1tBLVpdK1tbOnNwYWNlOl1dKzB4WzAtOV0rIiAic3lz L21tYW4uaCIKK2F1dG9fc3dpdGNoX3R5cGUgInNjaGVkcG9saWN5bmFtZSIgIlNDSEVEX1tBLVpd K1tbOnNwYWNlOl1dK1swLTldKyIgInNjaGVkLmgiCithdXRvX3N3aXRjaF90eXBlICJrbGR1bmxv YWRmZmxhZ3NuYW1lIiAiTElOS0VSX1VOTE9BRF9bQS1aXStbWzpzcGFjZTpdXStbMC05XSsiICJz eXMvbGlua2VyLmgiCithdXRvX3N3aXRjaF90eXBlICJrc2V0aHJjbWRuYW1lIiAiS1NFX0lOVFJf W0EtWl0rW1s6c3BhY2U6XV0rWzAtOV0rIiAic3lzL2tzZS5oIgorYXV0b19zd2l0Y2hfdHlwZSAi ZXh0YXR0cmN0bG5hbWUiICJFWFRBVFRSX05BTUVTUEFDRV9bQS1aXStbWzpzcGFjZTpdXSsweFsw LTldKyIgInN5cy9leHRhdHRyLmgiCithdXRvX3N3aXRjaF90eXBlICJrbGRzeW1jbWRuYW1lIiAi S0xEU1lNX1tBLVpdK1tbOnNwYWNlOl1dK1swLTldKyIgInN5cy9saW5rZXIuaCIKK2F1dG9fc3dp dGNoX3R5cGUgInNlbmRmaWxlZmxhZ3NuYW1lIiAiU0ZfW0EtWl0rW1s6c3BhY2U6XV0rWzAtOV0r IiAic3lzL3NvY2tldC5oIgorYXV0b19zd2l0Y2hfdHlwZSAiYWNsdHlwZW5hbWUiICJBQ0xfVFlQ RV9bQS1aXStbWzpzcGFjZTpdXSsweFswLTldKyIgInN5cy9hY2wuaCIKK2F1dG9fc3dpdGNoX3R5 cGUgInNpZ3Byb2NtYXNraG93bmFtZSIgIlNJR19bQS1aXStbWzpzcGFjZTpdXStbMC05XSsiICJz eXMvc2lnbmFsLmgiCithdXRvX3N3aXRjaF90eXBlICJsaW9fbGlzdGlvbmFtZSIgIkxJT18oTk8p P1dBSVRbWzpzcGFjZTpdXStbMC05XSsiICJhaW8uaCIKK2F1dG9fc3dpdGNoX3R5cGUgIm1pbmhl cml0bmFtZSIgIklOSEVSSVRfW0EtWl0rW1s6c3BhY2U6XV0rWzAtOV0rIiAic3lzL21tYW4uaCIK K2F1dG9fc3dpdGNoX3R5cGUgInF1b3RhY3RsbmFtZSIgIlFfW0EtWl0rW1s6c3BhY2U6XV0rMHhb MC05XSsiICJ1ZnMvdWZzL3F1b3RhLmgiCisKK2NhdCA8PF9FT0ZfCisvKgorICogQVVUTyAtIFNw ZWNpYWwKKyAqIEZfIGlzIHVzZWQgdG8gc3BlY2lmeSBmY250bCBjb21tYW5kcyBhcyB3ZWxsIGFz IGFyZ3VtZW50cy4gQm90aCBzZXRzIGFyZQorICogZ3JvdXBlZCBpbiBmY250bC5oLCBhbmQgdGhp cyBhd2sgc2NyaXB0IGdyYWJzIHRoZSBmaXJzdCBncm91cC4KKyAqLwordm9pZAorZmNudGxjbWRu YW1lIChpbnQgY21kLCBpbnQgYXJnLCBpbnQgZGVjaW1hbCkKK3sKKwlzd2l0Y2ggKGNtZCkgewor X0VPRl8KK2VncmVwICJeI1tbOnNwYWNlOl1dKmRlZmluZVtbOnNwYWNlOl1dK0ZfW0EtWl0rW1s6 c3BhY2U6XV0rWzAtOV0rW1s6c3BhY2U6XV0qIiBcCisJJGluY2x1ZGVfZGlyL3N5cy9mY250bC5o IHwgXAorCWF3ayAnQkVHSU4geyBvPTAgfSB7IGZvciAoaSA9IDE7IGkgPD0gTkY7IGkrKykgXAor CQlpZiAoJGkgfiAvZGVmaW5lLykgXAorCQkJYnJlYWs7IFwKKwkJKytpOyBcCisJCWlmIChvIDw9 ICQoaSsxKSkgXAorCQkJcHJpbnRmICJcdGNhc2UgJXM6XG5cdFx0KHZvaWQpcHJpbnRmKFwiJXNc Iik7XG5cdFx0YnJlYWs7XG4iLCAkaSwgJGk7IFwKKwkJZWxzZSBcCisJCQlleGl0OyBcCisJCW8g PSAkKGkrMSkgfScKK2NhdCA8PF9FT0ZfCisJZGVmYXVsdDogLyogU2hvdWxkIG5vdCByZWFjaCAq LworCQkodm9pZClwcmludGYoIjxpbnZhbGlkPSVsZD4iLCAobG9uZyljbWQpOworCX0KKwkodm9p ZClwdXRjaGFyKCcsJyk7CisJaWYgKGNtZCA9PSBGX0dFVEZEIHx8IGNtZCA9PSBGX1NFVEZEKSB7 CisJCWlmIChhcmcgPT0gRkRfQ0xPRVhFQykKKwkJCSh2b2lkKXByaW50ZigiRkRfQ0xPRVhFQyIp OworCQllbHNlIGlmIChhcmcgPT0gMCkKKwkJCSh2b2lkKXByaW50ZigiMCIpOworCQllbHNlIHsK KwkJCWlmIChkZWNpbWFsKQorCQkJCSh2b2lkKXByaW50ZigiPGludmFsaWQ+JWxkIiwgKGxvbmcp YXJnKTsKKwkJCWVsc2UKKwkJCQkodm9pZClwcmludGYoIjxpbnZhbGlkPiUjbHgiLCAobG9uZylh cmcpOworCQl9CisJfSBlbHNlIGlmIChjbWQgPT0gRl9TRVRGTCkgeworCQlmbGFnc25hbWUoYXJn KTsKKwl9IGVsc2UgeworCQlpZiAoZGVjaW1hbCkKKwkJCSh2b2lkKXByaW50ZigiJWxkIiwgKGxv bmcpYXJnKTsKKwkJZWxzZQorCQkJKHZvaWQpcHJpbnRmKCIlI2x4IiwgKGxvbmcpYXJnKTsKKwl9 Cit9CisKKy8qCisgKiBBVVRPIC0gU3BlY2lhbAorICoKKyAqIFRoZSBvbmx5IHJlYXNvbiB0aGlz IGlzIG5vdCBmdWxseSBhdXRvbWF0ZWQgaXMgZHVlIHRvIHRoZQorICogZ3JlcCAtdiBSVFBfUFJJ TyBzdGF0ZW1lbnQuIEEgYmV0dGVyIGVncmVwIGxpbmUgc2hvdWxkCisgKiBtYWtlIHRoaXMgY2Fw YWJsZSBvZiBiZWluZyBhIGF1dG9fc3dpdGNoX3R5cGUoKSBmdW5jdGlvbi4KKyAqLwordm9pZAor cnRwcmlvbmFtZSAoaW50IGZ1bmMpCit7CisJc3dpdGNoIChmdW5jKSB7CitfRU9GXworZWdyZXAg Il4jW1s6c3BhY2U6XV0qZGVmaW5lW1s6c3BhY2U6XV0rUlRQX1tBLVpdK1tbOnNwYWNlOl1dKzB4 WzAtOV0rW1s6c3BhY2U6XV0qIiBcCisJJGluY2x1ZGVfZGlyL3N5cy9ydHByaW8uaCB8IGdyZXAg LXYgUlRQX1BSSU8gfCBcCisJYXdrICd7IGZvciAoaSA9IDE7IGkgPD0gTkY7IGkrKykgXAorCQlp ZiAoJGkgfiAvZGVmaW5lLykgXAorCQkJYnJlYWs7IFwKKwkJKytpOyBcCisJCXByaW50ZiAiXHRj YXNlICVzOlxuXHRcdCh2b2lkKXByaW50ZihcIiVzXCIpO1xuXHRcdGJyZWFrO1xuIiwgJGksICRp IH0nCitjYXQgPDxfRU9GXworCWRlZmF1bHQ6IC8qIFNob3VsZCBub3QgcmVhY2ggKi8KKwkJKHZv aWQpcHJpbnRmKCI8aW52YWxpZD0lbGQ+IiwgKGxvbmcpZnVuYyk7CisJfQorfQorCisvKgorICog QVVUTyAtIFNwZWNpYWwKKyAqCisgKiBUaGUgc2VuZCBhbmQgcmVjdiBmdW5jdGlvbnMgaGF2ZSBh IGZsYWdzIGFyZ3VtZW50IHdoaWNoIGNhbiBiZQorICogc2V0IHRvIDAuIFRoZXJlIGlzIG5vIGNv cnJlc3BvbmRpbmcgI2RlZmluZS4gVGhlIGF1dG9fIGZ1bmN0aW9ucworICogZGV0ZWN0IHRoaXMg YXMgImludmFsaWQiLCB3aGljaCBpcyBpbmNvcnJlY3QgaGVyZS4KKyAqLwordm9pZAorc2VuZHJl Y3ZmbGFnc25hbWUgKGludCBmbGFncykKK3sKKwlpbnQJb3IgPSAwOworCQorCWlmIChmbGFncyA9 PSAwKSB7CisJCSh2b2lkKXByaW50ZigiMCIpOworCQlyZXR1cm47CisJfQorX0VPRl8KK2VncmVw ICJeI1tbOnNwYWNlOl1dKmRlZmluZVtbOnNwYWNlOl1dK01TR19bQS1aXStbWzpzcGFjZTpdXSsw eFswLTldK1tbOnNwYWNlOl1dKiIgJGluY2x1ZGVfZGlyL3N5cy9zb2NrZXQuaCB8IFwKKwlhd2sg J3sgZm9yIChpID0gMTsgaSA8PSBORjsgaSsrKSBcCisJCWlmICgkaSB+IC9kZWZpbmUvKSBcCisJ CQlicmVhazsgXAorCQkrK2k7IFwKKwkJcHJpbnRmICJcdGlmKCEoKGZsYWdzPjApXigoJXMpPjAp KSlcblx0XHRpZl9wcmludF9vcihmbGFncywgJXMsIG9yKTtcbiIsICRpLCAkaSB9JworY2F0IDw8 X0VPRl8KK30KKworX0VPRl8K ------=_Part_14898_9999084.1145479192476-- From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 21:14:53 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 083DE16A408 for ; Wed, 19 Apr 2006 21:14:53 +0000 (UTC) (envelope-from julian@elischer.org) Received: from a50.ironport.com (a50.ironport.com [63.251.108.112]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCB3B43D49 for ; Wed, 19 Apr 2006 21:14:52 +0000 (GMT) (envelope-from julian@elischer.org) Received: from unknown (HELO [10.251.19.131]) ([10.251.19.131]) by a50.ironport.com with ESMTP; 19 Apr 2006 14:14:53 -0700 Message-ID: <4446A84E.6060901@elischer.org> Date: Wed, 19 Apr 2006 14:14:54 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.12) Gecko/20050915 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Kirchner References: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> In-Reply-To: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: Add some more information in the ktrace(1)/kdump(1) output X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 21:14:53 -0000 David Kirchner wrote: >Please Cc: me on replies as I am not a member of this list. > >I'm working with Alexander Leidinger on the >ktrace project mentioned on the ideas page. I've attached a patch, >made against 6.1-RC (and should work against -CURRENT). The patch >modifies kdump output to use strings instead of numbers for every(I >believe) relevant syscall. > >For example, the output before: > > 32229 telnet CALL mmap(0,0x8000,0x3,0x1002,0xffffffff,0,0,0) > 32229 telnet CALL open(0x2807bc28,0,0x1b6) > 32229 telnet CALL socket(0x2,0x2,0) > >is now: > > 32229 telnet CALL >mmap(0,0x8000,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANON,0xffffffff,0,0,0) > 32229 telnet CALL open(0x2807bc28,O_RDONLY,0x1b6) > 32229 telnet CALL socket(PF_INET,SOCK_DGRAM,0) > >I'd appreciate any feedback you may have. This is just one half of the >project; the other half will involve updating the kernel to include >more data in the dump output. I'm thinking, specifically, adding >KTR_STAT for stat() results and KTR_SOCKADDR for connect(), bind() >arguments, and accept() results. > > bind/connect would be particularly nice ;-) don't forget linux_kdump :-) From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 22:01:49 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84B0D16A410 for ; Wed, 19 Apr 2006 22:01:49 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6846043D5E for ; Wed, 19 Apr 2006 22:01:47 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3JM02ak004855 for ; Wed, 19 Apr 2006 16:00:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 19 Apr 2006 16:00:02 -0600 (MDT) Message-Id: <20060419.160002.119566576.imp@bsdimp.com> To: arch@freebsd.org From: "M. Warner Losh" X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Subject: Review request X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 22:01:49 -0000 The following patches I think will properly set r_rid in struct resource_i *. Right now, these values are neither used nor set (apart from some code in my recently committed ARM support for the Atmel AT91RM9200). However, there's some desire for it to be valid. I believe that the following patches makes it valid. Please review these patches. I'd like to commit them soon: http://people.freebsd.org/~imp/set_rid.diff Warner P.S. I've sent this here because the other patch is to remove the set/get rid functionality. From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 22:04:26 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD15616A42C for ; Wed, 19 Apr 2006 22:04:26 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4196643D6B for ; Wed, 19 Apr 2006 22:04:02 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gqn537exnlm16obx@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3JM41lV089191 for ; Wed, 19 Apr 2006 15:04:01 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3JM416Z089190 for arch@FreeBSD.org; Wed, 19 Apr 2006 15:04:01 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Apr 2006 15:04:01 -0700 From: John-Mark Gurney To: arch@FreeBSD.org Message-ID: <20060419220401.GO38619@funkthat.com> Mail-Followup-To: arch@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: Subject: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 22:04:27 -0000 I was looking at our interface, and realized that since we now have rman_get_rid, that passing in a rid pointer to bus_alloc_resource is out dated... you can get the new updated rid directly from the resource returned... This will benifit bus_alloc_resources, as we can constify the _spec parameter, to make driver writing simpler... We can also reduce the use of the type parameter by including it as part of the resource, and then eliminate that parameter from the release, free cases... I have briefly discussed this w/ jhb, phk and imp, and they agree that this should be fixed... My new proposed prototypes: # this is the bus_if.m: static struct resource *bus_alloc_resource(device_t dev, device_t child, int type, int rid, u_long start, u_long end, u_long count, u_int flags) from bus.h: int bus_alloc_resources(device_t dev, const struct resource_spec *rs, struct resource **res); void bus_release_resources(device_t dev, const struct resource_spec *rs, struct resource **res); struct resource *bus_alloc_resource(device_t dev, int type, int rid, u_long start, u_long end, u_long count, u_int flags); int bus_activate_resource(device_t dev, struct resource *r); int bus_deactivate_resource(device_t dev, struct resource *r); int bus_release_resource(device_t dev, struct resource *r); int bus_free_resource(device_t dev, struct resource *r); we'll add a couple more functions: int rman_get_restype(struct resource *); void rman_set_restype(struct resource *, int); and of course add the appropriate field to resource_i... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 22:09:57 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95F6416A401 for ; Wed, 19 Apr 2006 22:09:57 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1416843D45 for ; Wed, 19 Apr 2006 22:09:57 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (fxpdsxwnubp1rdjk@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3JM9qhm089366; Wed, 19 Apr 2006 15:09:52 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3JM9pQa089365; Wed, 19 Apr 2006 15:09:51 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Apr 2006 15:09:51 -0700 From: John-Mark Gurney To: "M. Warner Losh" Message-ID: <20060419220951.GP38619@funkthat.com> Mail-Followup-To: "M. Warner Losh" , arch@freebsd.org References: <20060419.160002.119566576.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060419.160002.119566576.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: arch@freebsd.org Subject: Re: Review request X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 22:09:57 -0000 Warner Losh wrote this message on Wed, Apr 19, 2006 at 16:00 -0600: > The following patches I think will properly set r_rid in struct > resource_i *. Right now, these values are neither used nor set (apart > from some code in my recently committed ARM support for the Atmel > AT91RM9200). However, there's some desire for it to be valid. > > I believe that the following patches makes it valid. Please review > these patches. I'd like to commit them soon: > http://people.freebsd.org/~imp/set_rid.diff Did you mean to if 0 out some code in i386/i386/nexus.c? other than that, looks good... Note: This ties into the message I just posted Re: remove rid pointer (but not rid)... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 22:58:52 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE6D216A401 for ; Wed, 19 Apr 2006 22:58:52 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64E3A43D46 for ; Wed, 19 Apr 2006 22:58:52 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3JMv9tE005431; Wed, 19 Apr 2006 16:57:09 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 19 Apr 2006 16:57:09 -0600 (MDT) Message-Id: <20060419.165709.22017808.imp@bsdimp.com> To: gurney_j@resnet.uoregon.edu From: "M. Warner Losh" In-Reply-To: <20060419220401.GO38619@funkthat.com> References: <20060419220401.GO38619@funkthat.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 22:58:52 -0000 In message: <20060419220401.GO38619@funkthat.com> John-Mark Gurney writes: : I was looking at our interface, and realized that since we now have : rman_get_rid, that passing in a rid pointer to bus_alloc_resource is : out dated... you can get the new updated rid directly from the resource : returned... More precisely, you need to pass the rid into bus_alloc_resource. What is no longer needed is to get the modified rid value back. While in theory with the current API the rid could change, a quick audit of the tree I just did shows that no one currently changes the rid. : This will benifit bus_alloc_resources, as we can constify the _spec : parameter, to make driver writing simpler... This is good. : We can also reduce the use of the type parameter by including it as : part of the resource, and then eliminate that parameter from the : release, free cases... : : I have briefly discussed this w/ jhb, phk and imp, and they agree that : this should be fixed... : : My new proposed prototypes: : # this is the bus_if.m: : static struct resource *bus_alloc_resource(device_t dev, device_t child, : int type, int rid, u_long start, u_long end, u_long count, u_int flags) 'const int *rid' is another alternative here, that might be less invasive. : from bus.h: : int bus_alloc_resources(device_t dev, const struct resource_spec *rs, struct resource : **res); : void bus_release_resources(device_t dev, const struct resource_spec *rs, struct resource **res); : struct resource *bus_alloc_resource(device_t dev, int type, int rid, u_long start, u_long end, u_long count, u_int flags); : int bus_activate_resource(device_t dev, struct resource *r); : int bus_deactivate_resource(device_t dev, struct resource *r); : int bus_release_resource(device_t dev, struct resource *r); : int bus_free_resource(device_t dev, struct resource *r); : : we'll add a couple more functions: : int rman_get_restype(struct resource *); : void rman_set_restype(struct resource *, int); : : and of course add the appropriate field to resource_i... This will, of course, be a big undertaking in the tree. There are 1216 instances of the string 'alloc_resource' Every single one of them will need to change in some way. This will make porting to older versions of FreeBSD more difficult, since you'll need ifdefs for the passing of this parameter. Moreover, each of these changes isn't going to be mechanical. There's a number of drivers that assume that rid will be modified and carefully save it against future need (the release), so fixes in this area need to be done carefully. While most of those drivers could benefit from the newer bus_alloc_resources() API, testing becomes problematic. We should also make sure that all the override functions for bus_alloc_resource declare their functions as a bus_alloc_resource_t. Only the ones in sparc64-land do today. Warner From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 01:08:22 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E256B16A404 for ; Thu, 20 Apr 2006 01:08:22 +0000 (UTC) (envelope-from wollman@khavrinen.csail.mit.edu) Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu [128.30.28.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43BFD43D45 for ; Thu, 20 Apr 2006 01:08:22 +0000 (GMT) (envelope-from wollman@khavrinen.csail.mit.edu) Received: from khavrinen.csail.mit.edu (localhost.csail.mit.edu [127.0.0.1]) by khavrinen.csail.mit.edu (8.13.1/8.13.4) with ESMTP id k3K18IgP055302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK CN=khavrinen.csail.mit.edu issuer=Client+20CA); Wed, 19 Apr 2006 21:08:18 -0400 (EDT) (envelope-from wollman@khavrinen.csail.mit.edu) Received: (from wollman@localhost) by khavrinen.csail.mit.edu (8.13.1/8.13.4/Submit) id k3K18DwH055301; Wed, 19 Apr 2006 21:08:13 -0400 (EDT) (envelope-from wollman) Date: Wed, 19 Apr 2006 21:08:13 -0400 (EDT) From: Garrett Wollman Message-Id: <200604200108.k3K18DwH055301@khavrinen.csail.mit.edu> To: imp@bsdimp.com In-Reply-To: <20060419.165709.22017808.imp@bsdimp.com> References: <20060419220401.GO38619@funkthat.com> Organization: MIT Computer Science & Artificial Intelligence Lab X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-2.0.2 (khavrinen.csail.mit.edu [127.0.0.1]); Wed, 19 Apr 2006 21:08:18 -0400 (EDT) X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on khavrinen.csail.mit.edu Cc: , arch@freebsd.org Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 01:08:23 -0000 In article <20060419.165709.22017808.imp@bsdimp.com> you write: >in theory with the current API the rid could change, a quick audit of >the tree I just did shows that no one currently changes the rid. The perils of generalizing from zero examples. Mea culpa. I no longer have even the foggiest idea why I thought that might be useful. -GAWollman From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 03:14:11 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5ADB016A400 for ; Thu, 20 Apr 2006 03:14:11 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00AE143D45 for ; Thu, 20 Apr 2006 03:14:10 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3K3DiaC007988; Wed, 19 Apr 2006 21:13:44 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 19 Apr 2006 21:13:44 -0600 (MDT) Message-Id: <20060419.211344.74742694.imp@bsdimp.com> To: wollman@khavrinen.csail.mit.edu From: Warner Losh In-Reply-To: <200604200108.k3K18DwH055301@khavrinen.csail.mit.edu> References: <20060419220401.GO38619@funkthat.com> <20060419.165709.22017808.imp@bsdimp.com> <200604200108.k3K18DwH055301@khavrinen.csail.mit.edu> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 03:14:11 -0000 From: Garrett Wollman Subject: Re: remove rid pointer (but not rid)... Date: Wed, 19 Apr 2006 21:08:13 -0400 (EDT) > In article <20060419.165709.22017808.imp@bsdimp.com> you write: > > >in theory with the current API the rid could change, a quick audit of > >the tree I just did shows that no one currently changes the rid. > > The perils of generalizing from zero examples. Mea culpa. > > I no longer have even the foggiest idea why I thought that might be > useful. The rid stuff is in the bus_if.m layer, not in the rman layer. The r_rid was added later in an attempt to make it more convenient for the busif layer. Warner From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 06:12:41 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B49B716A401 for ; Thu, 20 Apr 2006 06:12:41 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B1B843D45 for ; Thu, 20 Apr 2006 06:12:41 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id F10241703F; Thu, 20 Apr 2006 06:12:38 +0000 (UTC) To: "M. Warner Losh" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 19 Apr 2006 16:57:09 MDT." <20060419.165709.22017808.imp@bsdimp.com> Date: Thu, 20 Apr 2006 08:12:38 +0200 Message-ID: <3731.1145513558@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: arch@freebsd.org, gurney_j@resnet.uoregon.edu Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 06:12:41 -0000 In message <20060419.165709.22017808.imp@bsdimp.com>, "M. Warner Losh" writes: >This will, of course, be a big undertaking in the tree. There are >1216 instances of the string 'alloc_resource' Every single one of >them will need to change in some way. Most of them could beneficially change to use bus_alloc_resources(), thereby improving the code (there are far too many bugs in the error handling) and at the same time cutting the 1216 in half or further down. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 09:15:49 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE3D116A405 for ; Thu, 20 Apr 2006 09:15:49 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail24.syd.optusnet.com.au (mail24.syd.optusnet.com.au [211.29.133.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id A698D43D53 for ; Thu, 20 Apr 2006 09:15:47 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail24.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k3K9FZSd007633 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 20 Apr 2006 19:15:37 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k3K9FZOl001018; Thu, 20 Apr 2006 19:15:35 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k3K9FYZx001017; Thu, 20 Apr 2006 19:15:34 +1000 (EST) (envelope-from peter) Date: Thu, 20 Apr 2006 19:15:34 +1000 From: Peter Jeremy To: David Kirchner Message-ID: <20060420091534.GA709@turion.vk2pj.dyndns.org> References: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: arch@freebsd.org Subject: Re: Add some more information in the ktrace(1)/kdump(1) output X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 09:15:49 -0000 On Wed, 2006-Apr-19 13:39:52 -0700, David Kirchner wrote: >For example, the output before: > > 32229 telnet CALL mmap(0,0x8000,0x3,0x1002,0xffffffff,0,0,0) > 32229 telnet CALL open(0x2807bc28,0,0x1b6) > 32229 telnet CALL socket(0x2,0x2,0) > >is now: > > 32229 telnet CALL >mmap(0,0x8000,PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANON,0xffffffff,0,0,0) > 32229 telnet CALL open(0x2807bc28,O_RDONLY,0x1b6) > 32229 telnet CALL socket(PF_INET,SOCK_DGRAM,0) Looks good. One improvement I'd suggest is to report both raw hex as well as decoded output - eg the way a printf(9) %b format looks. This would make the above look like: 32229 telnet CALL mmap(0,0x8000,0x3,0x1002,0xffffffff,0,0,0) 32229 telnet CALL open(0x2807bc28,0,0x1b6) 32229 telnet CALL socket(PF_INET,SOCK_DGRAM,0) >more data in the dump output. I'm thinking, specifically, adding >KTR_STAT for stat() results and KTR_SOCKADDR for connect(), bind() >arguments, and accept() results. Wonderful. IMHO, the lack of struct sockaddr decoding is the biggest drawback of ktrace (though I admit I've never been sufficiently annoyed at the lack of support to actually implement it). Some comments on the code approach (these are personal opinions - feel free to ignore them): - I find case statements easier to follow than very long "else if" clauses. - Have you considered a semi-interpreted approach to allow more generalised decoding (less special-cased code)? As an example of the following, the Tru64 alpha syscall trace code (see ftp://ftp.iastate.edu/pub/unix/osf1/trace/alpha-trace-1.34.tar.Z) has an array similar to /sys/kern/init_sysent.c:sysent[] which looks like: /*001*/ { SYS_exit , "exit(d)v" , 1 , printargs_gen , printret_gen } , /*002*/ { SYS_fork , "fork()d" , 0 , printargs_gen , printret_gen } , /*003*/ { SYS_read , "read(dpd)d" , 3 , printargs_read , printret_read } , /*004*/ { SYS_write , "write(dbd)d" , 3 , printargs_write , printret_write } , The string contains the syscall name, the argument types in parenthesis (b - buffer, d - signed decimal, p - pointer, o - octal etc) and a return type, the number of arguments and functions to print the arguments and return values. (The return handling wouldn't be relevant to ktrace). About 3/4 of the Tru64 syscalls can be handled using the generic printargs_gen(). Since ktrace doesn't need special handling for syscalls that have I/O buffers or various structures (they are passed via different KTR_xxx records), FreeBSD is even more amenable to generic argument processing. I suspect that virtually all of the FreeBSD syscalls could be handled in a similar manner if a %b option string and an enum decoding structure (or two) could be passed via a similar sort of table. -- Peter Jeremy From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 15:38:39 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE5DB16A428 for ; Thu, 20 Apr 2006 15:38:38 +0000 (UTC) (envelope-from dpkirchner@gmail.com) Received: from uproxy.gmail.com (uproxy.gmail.com [66.249.92.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E70143D69 for ; Thu, 20 Apr 2006 15:38:37 +0000 (GMT) (envelope-from dpkirchner@gmail.com) Received: by uproxy.gmail.com with SMTP id m3so163266ugc for ; Thu, 20 Apr 2006 08:38:36 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ZuiLVCkzuqqf8iL/PmK3UyOCMvitwDOq7QKp9PcPM7FwScxDz6leqVuQc6qlLqDjgrBIzc5aNLX1eYKSqsbsQLCa8kC/fM69joSdGRlJvrT3Or9aTnfKAdI1Qehg0Lb7BhHp/Wz2LuyOgdDCzUDwPAhXV/TfvAOKW5R+htriQH4= Received: by 10.78.32.14 with SMTP id f14mr35914huf; Thu, 20 Apr 2006 08:38:36 -0700 (PDT) Received: by 10.78.13.2 with HTTP; Thu, 20 Apr 2006 08:38:36 -0700 (PDT) Message-ID: <35c231bf0604200838w224c810cue82beace0d63f18b@mail.gmail.com> Date: Thu, 20 Apr 2006 08:38:36 -0700 From: "David Kirchner" Sender: dpkirchner@gmail.com To: "Peter Jeremy" In-Reply-To: <20060420091534.GA709@turion.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <35c231bf0604191339m598d9b7n6681421403d5d4e1@mail.gmail.com> <20060420091534.GA709@turion.vk2pj.dyndns.org> Cc: arch@freebsd.org Subject: Re: Add some more information in the ktrace(1)/kdump(1) output X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 15:38:39 -0000 On 4/20/06, Peter Jeremy wrote: > Looks good. One improvement I'd suggest is to report both raw hex as wel= l > as decoded output - eg the way a printf(9) %b format looks. This would > make the above look like: > > 32229 telnet CALL mmap(0,0x8000,0x3,0x1002,0xffffffff,0,0,0) > 32229 telnet CALL open(0x2807bc28,0,0x1b6) > 32229 telnet CALL socket(PF_INET,SOCK_DGRAM,0) Yeah, I could see a benefit to that. Easy to add. > >more data in the dump output. I'm thinking, specifically, adding > >KTR_STAT for stat() results and KTR_SOCKADDR for connect(), bind() > >arguments, and accept() results. > > Wonderful. IMHO, the lack of struct sockaddr decoding is the biggest > drawback of ktrace (though I admit I've never been sufficiently > annoyed at the lack of support to actually implement it). > > Some comments on the code approach (these are personal opinions - > feel free to ignore them): > - I find case statements easier to follow than very long "else if" > clauses. I do, too. I built on the existing if/else structure already there, but I wasn't sure of the best accepted style to use. > - Have you considered a semi-interpreted approach to allow more > generalised decoding (less special-cased code)? > [..] > /*004*/ { SYS_write , "write(dbd)d" , 3 , printargs_write , printret_writ= e } , > > The string contains the syscall name, the argument types in > parenthesis (b - buffer, d - signed decimal, p - pointer, o - octal > etc) and a return type, the number of arguments and functions to print > the arguments and return values. (The return handling wouldn't be > relevant to ktrace). About 3/4 of the Tru64 syscalls can be handled > using the generic printargs_gen(). That does look great. I'll give it a shot. I was definitely getting concerned over the number of different functions inside each if(...SYS_foo){} statement. It's easy to make a mistake there. > Since ktrace doesn't need special handling for syscalls that have I/O > buffers or various structures (they are passed via different KTR_xxx > records), FreeBSD is even more amenable to generic argument processing. > I suspect that virtually all of the FreeBSD syscalls could be handled > in a similar manner if a %b option string and an enum decoding > structure (or two) could be passed via a similar sort of table. Yeah. That sounds good. The original patch should probably not be committed then, since it'll just get changed again Real Soon Now(tm). From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 16:44:51 2006 Return-Path: X-Original-To: arch@FreeBSD.ORG Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60B2E16A404 for ; Thu, 20 Apr 2006 16:44:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4CDA43D6B for ; Thu, 20 Apr 2006 16:44:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3KGelRT024467; Thu, 20 Apr 2006 10:40:48 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 20 Apr 2006 10:40:48 -0600 (MDT) Message-Id: <20060420.104048.57443855.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <3731.1145513558@critter.freebsd.dk> References: <20060419.165709.22017808.imp@bsdimp.com> <3731.1145513558@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.ORG, gurney_j@resnet.uoregon.edu Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 16:44:51 -0000 In message: <3731.1145513558@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20060419.165709.22017808.imp@bsdimp.com>, "M. Warner Losh" writes: : : >This will, of course, be a big undertaking in the tree. There are : >1216 instances of the string 'alloc_resource' Every single one of : >them will need to change in some way. : : Most of them could beneficially change to use bus_alloc_resources(), : thereby improving the code (there are far too many bugs in the error : handling) and at the same time cutting the 1216 in half or further : down. Agreed. I think I made that point a little later in my post. The big difficulty here is testing the driver after the changes to make sure that no unintended bugs have been introduced. Warner From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 22:55:51 2006 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D64CB16A40F for ; Thu, 20 Apr 2006 22:55:51 +0000 (UTC) (envelope-from edgeci@tssusa.com) Received: from tssusa.com (72.Red-83-41-60.dynamicIP.rima-tde.net [83.41.60.72]) by mx1.FreeBSD.org (Postfix) with SMTP id 81A3943D7D for ; Thu, 20 Apr 2006 22:55:49 +0000 (GMT) (envelope-from edgeci@tssusa.com) Message-ID: <000001c664cd$7c8e4650$5944a8c0@pow45> From: "Sylvana Edgecomb" To: freebsd-arch@freebsd.org Date: Thu, 20 Apr 2006 18:55:14 -0400 MIME-Version: 1.0 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Re: nawov news X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sylvana Edgecomb List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 22:55:51 -0000 Dea r r Home Ow i ne q r ,=20 =20 Your c p red x it doesn't matter to us ! If you O y WN real e g st f at f e=20 and want I v MMED a IAT i E c y ash to sp k en f d ANY way you like, or simply wish=20 to L g OWER your monthly p z aym z ents by a third or more, here are the dea s ls=20 we have T t ODA u Y :=20 =20 $ 4 i 88 , 000 at a 3 , g 67% f z ixed - rat z e=20 $ 3 r 72 , 000 at a 3 , s 90% v p ariabl z e - rat l e=20 $ 49 w 2 , 000 at a 3 , 2 m 1% i c ntere b st - only=20 $ 2 r 48 , 000 at a 3 , a 36% fi z xed - rat d e=20 $ 1 i 98 , 000 at a 3 , a 55% v j ariable - ra d te=20 =20 Hurr i y, when these d x eaIs are gone, they are gone ! =20 Don't worry about app x rov o al, your c g red b it will not d o isqualif j y you !=20 =20 Vi m si u t our si h te =20 =20 Sincerely, Sylvana Edgecomb=20 =20 Ap z pro f val Manager