Date: Sat, 14 Jan 2006 21:13:12 -0700 (MST) From: Warner Losh <imp@bsdimp.com> To: sds@jazzie.com Cc: freebsd-drivers@freebsd.org Subject: Re: if_ed_isa.c change to support pnp on compaq lte dock Message-ID: <20060114.211312.74693697.imp@bsdimp.com> In-Reply-To: <43C98205.70002@jazzie.com> References: <43C98205.70002@jazzie.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> This is regarding 5.4-RELEASE-p9 running on a Compaq LTE (Pentium-based)
> laptop connected to a docking station. A patch for if_ed_isa.c is
> included below. The Compaq LTE docking station includes an
> ne2000-compatible ethernet interface, and using device.hints that match
> the port and irq configured in the bios works just fine when booting
> from a powered-off state.
OK.
> The system has a plug-n-play bios that knows about this device:
> PNP8160: adding irq mask 0x800
> PNP8160: adding io range 0x340-0x35f, size=0x20, align=0x20
> pnpbios: handle 21 device ID PNP8160 (6081d041)
> But the ed driver in 5.4-RELEASE doesn't attach to it automatically.
> I made the obvious change, adding the device id to the table:
>
> *** if_ed_isa.c 2006/01/13 19:23:23 1.1
> --- if_ed_isa.c 2006/01/13 19:25:18
> ***************
> *** 59,64 ****
> --- 59,65 ----
> { 0x0090252a, NULL }, /* JQE9000 */
> { 0x0020832e, NULL }, /* KTC2000 */
> { 0x4cf48906, NULL }, /* ATIf44c */
> + { 0x6081d041, NULL }, /* PNP8160 */
> { 0, NULL }
> };
>
> After removing the device.hints, the system now reports:
> ed0: <PNP8160> at port 0x340-0x35f irq 11 on isa0
> both on cold boots and warm restarts, and does not hang. Hurray!
>
> Was there a better way to accomplish this? If no, can the change to add
> this device id get incorporated into future FreeBSD releases?
Committed. This is the best way to add an ID.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060114.211312.74693697.imp>