From owner-cvs-src@FreeBSD.ORG Sun Aug 19 00:49:19 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36CEC16A420; Sun, 19 Aug 2007 00:49:19 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id CEDC313C458; Sun, 19 Aug 2007 00:49:18 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7J0n6k1009733; Sat, 18 Aug 2007 20:49:07 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sat, 18 Aug 2007 20:49:07 -0400 (EDT) Date: Sat, 18 Aug 2007 20:49:06 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Tijl Coosemans In-Reply-To: <200708182118.37998.tijl@ulyssis.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 00:49:19 -0000 On Sat, 18 Aug 2007, Tijl Coosemans wrote: > On Friday 17 August 2007 04:33:07 Daniel Eischen wrote: >> Yes, I know it's not needed by libthr :-) I would think you could >> use mq_open(), mq_notify() with sigev_notify = SIGEV_SIGNAL, etc. >> When the receiving process gets the signal, it reads the message >> queue to get the target thread id and the signal to send to it. >> >> It would be nice if we (FreeBSD) did have thread groups, and the >> ability to (soft) bind them to specific CPUs or CPU sets, ala Solaris >> processor_bind(), pset_bind(), etc. Once you have these, then I can >> perhaps see a thrgrp_signal() or something similar since the thread >> group would already be managable outside the context of a process. > > > To be honest, I'm not entirely fond of adding this syscall either, but > from an engineering point of view, it's really the easiest and cheapest > solution right now. That doesn't mean we should have added it. Our APIs that ship for 7.0 need to be maintained for compatibility, and this API is to satisfy just one application (Wine), and only for some of those applications that are run under it. > POSIX message queues aren't needed. Sigqueue() with sigval set to the > thread id would be enough. Then whichever thread receives the signal > can either handle it or dispatch it using thr_kill(). > > Sigqueue() doesn't exist in 6-STABLE though and as I understood will > never be MFC'd, because it involves too many other things (signal > queueing, ksiginfo,...), whereas thr_kill2() is entirely isolated and > trivial to merge. > > Perhaps it should be stressed in documentation that this syscall is > only meant for Wine and to be removed at some point when better > solutions become available. I want to test this sigqueue solution some > more, because the indirection in signal delivery causes trouble when a > thread signals itself. I guess this would have to be special-cased > somehow then. I would rather just use sigqueue in 7.0 if necessary and drop support for some set of applications run under Wine in 6.0. We shouldn't be adding hacks like this to suit just one application... -- DE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 00:52:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C16816A419; Sun, 19 Aug 2007 00:52:03 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 159BD13C469; Sun, 19 Aug 2007 00:52:02 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7J0pvaB010804; Sat, 18 Aug 2007 20:51:57 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sat, 18 Aug 2007 20:51:58 -0400 (EDT) Date: Sat, 18 Aug 2007 20:51:57 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Robert Watson In-Reply-To: <20070818204223.D1234@fledge.watson.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 00:52:03 -0000 On Sat, 18 Aug 2007, Robert Watson wrote: > > On Sat, 18 Aug 2007, Tijl Coosemans wrote: > >> Perhaps it should be stressed in documentation that this syscall is only >> meant for Wine and to be removed at some point when better solutions become >> available. I want to test this sigqueue solution some more, because the >> indirection in signal delivery causes trouble when a thread signals itself. >> I guess this would have to be special-cased somehow then. > > As a general rule, removing system calls is discouraged as it breaks backward > compatibility allowing newer kernels to run older applications, so I think we > should avoid adding a system call with the intent to remove it in mind at the > time it's added :-). While thr_kill2() is imperfect from several > perspectives, it is certainly a minimalist and logical construction that can > be easily understood, and that's pretty valuable. You can say that about a lot of APIs, but that doesn't mean we should add them. This is a bit of a hack to satisfy one application (Wine) when there are other (perhaps harder) ways to skin the cat. We certainly don't want anything else using this API, so I'd advocate removing it. -- DE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 01:21:40 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A21516A418; Sun, 19 Aug 2007 01:21:40 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from hub.org (hub.org [200.46.204.220]) by mx1.freebsd.org (Postfix) with ESMTP id 5A16E13C46E; Sun, 19 Aug 2007 01:21:40 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from localhost (maia-2.hub.org [200.46.204.187]) by hub.org (Postfix) with ESMTP id 70E33B4750C; Sat, 18 Aug 2007 22:04:34 -0300 (ADT) Received: from hub.org ([200.46.204.220]) by localhost (mx1.hub.org [200.46.204.187]) (amavisd-maia, port 10024) with ESMTP id 80376-07; Sat, 18 Aug 2007 22:04:25 -0300 (ADT) Received: from fserv.hub.org (blk-89-241-126.eastlink.ca [24.89.241.126]) by hub.org (Postfix) with ESMTP id E93F8B47248; Sat, 18 Aug 2007 22:04:30 -0300 (ADT) Received: from [192.168.1.2] (unknown [192.168.1.2]) by fserv.hub.org (Postfix) with ESMTP id 29D82E6330; Sat, 18 Aug 2007 22:04:46 -0300 (ADT) Date: Sat, 18 Aug 2007 22:04:20 -0300 From: "Marc G. Fournier" To: Daniel Eischen , Robert Watson Message-ID: <250D8A54B98F12158C71D8FE@ganymede.hub.org> In-Reply-To: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 01:21:40 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Saturday, August 18, 2007 20:51:57 -0400 Daniel Eischen wrote: > You can say that about a lot of APIs, but that doesn't mean we should add > them. This is a bit of a hack to satisfy one application (Wine) when there > are other (perhaps harder) ways to skin the cat. We certainly don't want > anything else using this API, so I'd advocate removing it. Stupid question, but ... why not? First off, do you know for a fact that Wine is the only app out there that needs the ability to kill off a thread in a seperate process, or has nobody in the past cared enough to see other apps ported from Linux -> FreeBSD to push for this sort of thing? - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGx5cU4QvfyHIvDvMRAnR/AKCZ2MpRWKxQ3WDtyp6l7W5GvToZ+ACcCbQI /LGG0jukEds5Lii82lhYdFs= =0wg7 -----END PGP SIGNATURE----- From owner-cvs-src@FreeBSD.ORG Sun Aug 19 02:26:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D04F816A417; Sun, 19 Aug 2007 02:26:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 5F7C913C428; Sun, 19 Aug 2007 02:26:17 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l7J2NXAO039318; Sat, 18 Aug 2007 20:23:34 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46C7A9A4.5090404@samsco.org> Date: Sat, 18 Aug 2007 20:23:32 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Daniel Eischen References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sat, 18 Aug 2007 20:23:34 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 02:26:17 -0000 Daniel Eischen wrote: > On Sat, 18 Aug 2007, Robert Watson wrote: > >> >> On Sat, 18 Aug 2007, Tijl Coosemans wrote: >> >>> Perhaps it should be stressed in documentation that this syscall is >>> only meant for Wine and to be removed at some point when better >>> solutions become available. I want to test this sigqueue solution >>> some more, because the indirection in signal delivery causes trouble >>> when a thread signals itself. I guess this would have to be >>> special-cased somehow then. >> >> As a general rule, removing system calls is discouraged as it breaks >> backward compatibility allowing newer kernels to run older >> applications, so I think we should avoid adding a system call with the >> intent to remove it in mind at the time it's added :-). While >> thr_kill2() is imperfect from several perspectives, it is certainly a >> minimalist and logical construction that can be easily understood, and >> that's pretty valuable. > > You can say that about a lot of APIs, but that doesn't mean we should add > them. This is a bit of a hack to satisfy one application (Wine) when there > are other (perhaps harder) ways to skin the cat. We certainly don't want > anything else using this API, so I'd advocate removing it. > I'm in strong agreement here. David? Scott From owner-cvs-src@FreeBSD.ORG Sun Aug 19 03:11:44 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C0FE16A41A; Sun, 19 Aug 2007 03:11:44 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 3926913C428; Sun, 19 Aug 2007 03:11:44 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7J3BbeA003344; Sat, 18 Aug 2007 23:11:37 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sat, 18 Aug 2007 23:11:37 -0400 (EDT) Date: Sat, 18 Aug 2007 23:11:37 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "Marc G. Fournier" In-Reply-To: <250D8A54B98F12158C71D8FE@ganymede.hub.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <250D8A54B98F12158C71D8FE@ganymede.hub.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 03:11:44 -0000 On Sat, 18 Aug 2007, Marc G. Fournier wrote: > - --On Saturday, August 18, 2007 20:51:57 -0400 Daniel Eischen > wrote: > >> You can say that about a lot of APIs, but that doesn't mean we should add >> them. This is a bit of a hack to satisfy one application (Wine) when there >> are other (perhaps harder) ways to skin the cat. We certainly don't want >> anything else using this API, so I'd advocate removing it. > > Stupid question, but ... why not? > > First off, do you know for a fact that Wine is the only app out there that > needs the ability to kill off a thread in a seperate process, or has nobody in > the past cared enough to see other apps ported from Linux -> FreeBSD to push > for this sort of thing? FreeBSD as well as Solaris and Linux (it looks like Linux only allows a thread group to be signaled) have gotten along without this API, and Wine seems to be the only target for this syscall. In general, a process shouldn't know about threads in another process and should use more well-defined and portable APIs for interprocess communication. There is no method (at least portable) of determining the threads in another process, so what API are you going to add to get this information? And once you do get it, how do you know if the thread id is still valid or even reused by the process (or even a different process). I could see adding this API or other APIs if they were for our own internal use (e.g., for use by libthr), but it's not. I guess there are more than a few syscalls like that (e.g., thr_*, kse_*). It'd be nice if we could keep them private for our own internal use. We sorta do this with the symbol mapping in libc, and perhaps by prepending some syscalls with "__" (__acl_*). But applications are free to use syscalls without going through libc. -- DE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 05:57:30 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71BF616A417; Sun, 19 Aug 2007 05:57:30 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 46A3113C428; Sun, 19 Aug 2007 05:57:30 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 2925C1A4D7C; Sat, 18 Aug 2007 22:55:47 -0700 (PDT) Date: Sat, 18 Aug 2007 22:55:47 -0700 From: Alfred Perlstein To: Daniel Eischen Message-ID: <20070819055547.GC87451@elvis.mu.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 05:57:30 -0000 * Daniel Eischen [070818 17:47] wrote: > > I would rather just use sigqueue in 7.0 if necessary and drop support > for some set of applications run under Wine in 6.0. We shouldn't be > adding hacks like this to suit just one application... not to pick on you specifically Daniel, but this is a really cool API for debugging, why not support it? I mean, perhaps we add a pid arg to it? But I mean, there's no generation count for kill(2) (which could take one) to protect things, so why is this such a horrible thing? I can someone give a real reason for not liking it other than 1) it came from linux. 2) we didn't think of it. 3) supporting it is annoying. (it's not) -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Sun Aug 19 08:13:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFEA516A52C; Sun, 19 Aug 2007 08:13:01 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A768113C45E; Sun, 19 Aug 2007 08:13:01 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7J8D1aT084880; Sun, 19 Aug 2007 08:13:01 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7J8D1PT084878; Sun, 19 Aug 2007 08:13:01 GMT (envelope-from kmacy) Message-Id: <200708190813.l7J8D1PT084878@repoman.freebsd.org> From: Kip Macy Date: Sun, 19 Aug 2007 08:13:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 08:13:01 -0000 kmacy 2007-08-19 08:13:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/cxgb cxgb_adapter.h cxgb_main.c Log: m_sanity and SA_LOCKED are not defined in RELENG6 - don't use Revision Changes Path 1.2.2.7 +9 -2 src/sys/dev/cxgb/cxgb_adapter.h 1.3.2.8 +1 -1 src/sys/dev/cxgb/cxgb_main.c From owner-cvs-src@FreeBSD.ORG Sun Aug 19 08:31:40 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D4AB16A421; Sun, 19 Aug 2007 08:31:40 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 23AFC13C474; Sun, 19 Aug 2007 08:31:40 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 7FCEA49201; Sun, 19 Aug 2007 04:31:39 -0400 (EDT) Date: Sun, 19 Aug 2007 09:31:39 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Daniel Eischen In-Reply-To: Message-ID: <20070819092923.X65240@fledge.watson.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <250D8A54B98F12158C71D8FE@ganymede.hub.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Marc G. Fournier" , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 08:31:40 -0000 On Sat, 18 Aug 2007, Daniel Eischen wrote: >> Stupid question, but ... why not? >> >> First off, do you know for a fact that Wine is the only app out there that >> needs the ability to kill off a thread in a seperate process, or has nobody >> in the past cared enough to see other apps ported from Linux -> FreeBSD to >> push for this sort of thing? > > FreeBSD as well as Solaris and Linux (it looks like Linux only allows a > thread group to be signaled) have gotten along without this API, and Wine > seems to be the only target for this syscall. While I'm not familiar with the newer pthread code on Linux, I can say with reasonable authority that the older implementation used the same ID space for pids and thread IDs, since threads were tasks, and therefore Linux has always supported directly signalling threads in other processes. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Sun Aug 19 09:13:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BD3216A417; Sun, 19 Aug 2007 09:13:40 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 065C013C45D; Sun, 19 Aug 2007 09:13:40 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 9F8FB48394; Sun, 19 Aug 2007 05:13:39 -0400 (EDT) Date: Sun, 19 Aug 2007 10:13:39 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <46C7A9A4.5090404@samsco.org> Message-ID: <20070819095302.D66918@fledge.watson.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 09:13:40 -0000 On Sat, 18 Aug 2007, Scott Long wrote: >> You can say that about a lot of APIs, but that doesn't mean we should add >> them. This is a bit of a hack to satisfy one application (Wine) when there >> are other (perhaps harder) ways to skin the cat. We certainly don't want >> anything else using this API, so I'd advocate removing it. > > I'm in strong agreement here. David? This work was done by Tijl at the request of the PC-BSD guys, who would like to be able to run windows applications out of the box on PC-BSD for their next release (impending). David then reviewed and committed the patch giving it his approval. The goal here was to avoid having the PC-BSD people have to run around with additional system call patches for the forseeable future, and to avoid requiring PC-BSD to fork the FreeBSD kernel to do that. Given that many systems do support sending signals to specific threads in other processes, it may be worth surveying how it's done. In Linux, historically it was done via kill(2) since processes were threads; the tgkill() interface has probably only been added because it represents a new grouping that doesn't fit the "negative pids are specific process groups, -1 is all other processes, 0 is the current process group, and positive pids are specific processes". In Mac OS X, signals can be delivered using a thread port, which is most easily done using the current process since the thread ports will be lying around anyway in the thread package, but also works for other processes as you can retrieve the thread ports of other processes using their task ports, which can be retrieved in turn using task_for_pid(). I'm not familiar with Solaris or Windows. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Sun Aug 19 10:51:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DA7516A419; Sun, 19 Aug 2007 10:51:04 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EA68B13C468; Sun, 19 Aug 2007 10:51:03 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7JAp3M4008101; Sun, 19 Aug 2007 10:51:03 GMT (envelope-from se@repoman.freebsd.org) Received: (from se@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7JAp3nq008100; Sun, 19 Aug 2007 10:51:03 GMT (envelope-from se) Message-Id: <200708191051.l7JAp3nq008100@repoman.freebsd.org> From: Stefan Esser Date: Sun, 19 Aug 2007 10:51:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sym sym_hipd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 10:51:04 -0000 se 2007-08-19 10:51:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sym sym_hipd.c Log: MFC of rev. 1.67: Fix sym driver on amd64. Revision Changes Path 1.55.2.1 +17 -12 src/sys/dev/sym/sym_hipd.c From owner-cvs-src@FreeBSD.ORG Sun Aug 19 08:15:38 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E081416A41A; Sun, 19 Aug 2007 08:15:38 +0000 (UTC) (envelope-from julliard@winehq.org) Received: from mail.codeweavers.com (mail.codeweavers.com [216.251.189.131]) by mx1.freebsd.org (Postfix) with ESMTP id A7AF413C469; Sun, 19 Aug 2007 08:15:38 +0000 (UTC) (envelope-from julliard@winehq.org) Received: from adsl-62-167-26-218.adslplus.ch ([62.167.26.218] helo=wine.dyndns.org) by mail.codeweavers.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IMfcg-0005Li-3Y; Sun, 19 Aug 2007 02:54:58 -0500 Received: by wine.dyndns.org (Postfix, from userid 1000) id B865D1E7170; Sun, 19 Aug 2007 09:54:55 +0200 (CEST) To: Daniel Eischen References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <250D8A54B98F12158C71D8FE@ganymede.hub.org> From: Alexandre Julliard Date: Sun, 19 Aug 2007 09:54:55 +0200 In-Reply-To: (Daniel Eischen's message of "Sat\, 18 Aug 2007 23\:11\:37 -0400 \(EDT\)") Message-ID: <87hcmwot68.fsf@wine.dyndns.org> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailman-Approved-At: Sun, 19 Aug 2007 11:26:45 +0000 Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Marc G. Fournier" , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 08:15:39 -0000 Daniel Eischen writes: > FreeBSD as well as Solaris and Linux (it looks like Linux only allows a > thread group to be signaled) have gotten along without this API, and > Wine seems to be the only target for this syscall. Actually, Linux, Solaris, and Mac OS X all export that functionality, and in all cases it was added before Wine requested it, probably because it's a fairly logical feature to have as part of a kernel threading mechanism. -- Alexandre Julliard julliard@winehq.org From owner-cvs-src@FreeBSD.ORG Sun Aug 19 14:44:18 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 823A216A417; Sun, 19 Aug 2007 14:44:18 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 20FDF13C483; Sun, 19 Aug 2007 14:44:18 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7JEi9VL013246; Sun, 19 Aug 2007 10:44:09 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sun, 19 Aug 2007 10:44:10 -0400 (EDT) Date: Sun, 19 Aug 2007 10:44:09 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Robert Watson In-Reply-To: <20070819092923.X65240@fledge.watson.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <250D8A54B98F12158C71D8FE@ganymede.hub.org> <20070819092923.X65240@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Marc G. Fournier" , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 14:44:18 -0000 On Sun, 19 Aug 2007, Robert Watson wrote: > On Sat, 18 Aug 2007, Daniel Eischen wrote: > >>> Stupid question, but ... why not? >>> >>> First off, do you know for a fact that Wine is the only app out there that >>> needs the ability to kill off a thread in a seperate process, or has >>> nobody in the past cared enough to see other apps ported from Linux -> >>> FreeBSD to push for this sort of thing? >> >> FreeBSD as well as Solaris and Linux (it looks like Linux only allows a >> thread group to be signaled) have gotten along without this API, and Wine >> seems to be the only target for this syscall. > > While I'm not familiar with the newer pthread code on Linux, I can say with > reasonable authority that the older implementation used the same ID space for > pids and thread IDs, since threads were tasks, and therefore Linux has always > supported directly signalling threads in other processes. Thread id's (as visible to an application) are not required to be something that is known by the kernel. They certainly are not in libkse and libc_r, and I don't think they are in libthr either. This API won't work with libkse (or libc_r if we care) and isn't guaranteed to work with any future libthreadX. POSIX has well defined behavior with regard to signaling, and this certainly bypasses that. If we want to add a more well thought out set of APIs for thread groups that can (in the future) support CPU binding and scheduling, then that's OK. But the API as committed is a hack that solves one particular problem that can be solved in other (more portable) ways. sigqueue() was mentioned as a possible solution earlier. -- DE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 14:53:20 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A09E316A419; Sun, 19 Aug 2007 14:53:20 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 57DC513C45E; Sun, 19 Aug 2007 14:53:20 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7JErDRS018278; Sun, 19 Aug 2007 10:53:14 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sun, 19 Aug 2007 10:53:14 -0400 (EDT) Date: Sun, 19 Aug 2007 10:53:13 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Alexandre Julliard In-Reply-To: <87hcmwot68.fsf@wine.dyndns.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <250D8A54B98F12158C71D8FE@ganymede.hub.org> <87hcmwot68.fsf@wine.dyndns.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Sun, 19 Aug 2007 15:06:09 +0000 Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Marc G. Fournier" , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 14:53:20 -0000 On Sun, 19 Aug 2007, Alexandre Julliard wrote: > Daniel Eischen writes: > >> FreeBSD as well as Solaris and Linux (it looks like Linux only allows a >> thread group to be signaled) have gotten along without this API, and >> Wine seems to be the only target for this syscall. > > Actually, Linux, Solaris, and Mac OS X all export that functionality, > and in all cases it was added before Wine requested it, probably > because it's a fairly logical feature to have as part of a kernel > threading mechanism. I do not see it in Solaris. All I can find is _lwp_kill(), which isn't meant to be used by applications and isn't suppose to work for LWPs outside the current process. -- DE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 15:51:59 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0D5416A417; Sun, 19 Aug 2007 15:51:59 +0000 (UTC) (envelope-from krismoore@comcast.net) Received: from alnrmhc13.comcast.net (alnrmhc13.comcast.net [204.127.225.93]) by mx1.freebsd.org (Postfix) with ESMTP id 5F6C613C465; Sun, 19 Aug 2007 15:51:59 +0000 (UTC) (envelope-from krismoore@comcast.net) Received: from [192.168.1.102] (c-67-170-130-86.hsd1.wa.comcast.net[67.170.130.86]) by comcast.net (alnrmhc13) with ESMTP id <20070819153732b1300ef3hke>; Sun, 19 Aug 2007 15:37:34 +0000 Message-ID: <46C863C5.6090906@comcast.net> Date: Sun, 19 Aug 2007 08:37:41 -0700 From: Kris Moore User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Robert Watson References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> In-Reply-To: <20070819095302.D66918@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 19 Aug 2007 16:06:06 +0000 Cc: wine-freebsd@hub.org, Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 15:51:59 -0000 Robert Watson wrote: > This work was done by Tijl at the request of the PC-BSD guys, who would > like to be able to run windows applications out of the box on PC-BSD for > their next release (impending). David then reviewed and committed the > patch giving it his approval. The goal here was to avoid having the > PC-BSD people have to run around with additional system call patches for > the forseeable future, and to avoid requiring PC-BSD to fork the FreeBSD > kernel to do that. Robert is correct here. Tijl has done a fantastic job with getting Wine up to spec on FreeBSD, and it will help us greatly in trying to pursue our goal of getting PC-BSD / FreeBSD on as many desktops as possible. Easily the two most requested features we get from users who want to switch over to BSD is working Wine support, and Flash 9 support. This patch is a HUGE step in the right direction, and allows our users to very easily run old legacy business apps or play the latest games, like WoW. As such I really can't underscore the importance of this enough for a viable desktop product. That being said, most of the technical details are a bit over my head, but I will add my $0.02 to this. Whatever the solution, there needs to be a working solution in the end. If there's a better, more portable way to do this, then by all means lets get it done. If nobody can or will write this solution, then lets not just drop the original patch. A fix is greatly needed either way, so I hope this is added in the very near future. Even if you decide to only add this new functionality to FreeBSD 7.x, that's fine with us. Our next release of PC-BSD will be our last based on FreeBSD 6.x before moving to 7. We're committed to shipping with the patch Tijl wrote, since the improvements to Wine with it are night and day. Of course if you roll this into the tree, all the better since I won't have to spend the next 6 months to a year reminding users that when they update world, they have to apply the Wine patch first ;-) -- Kris Moore PC-BSD Software From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:11:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3F1A16A41B for ; Sun, 19 Aug 2007 16:11:17 +0000 (UTC) (envelope-from lynx.ripe@gmail.com) Received: from hu-out-0506.google.com (hu-out-0506.google.com [72.14.214.236]) by mx1.freebsd.org (Postfix) with ESMTP id 726C513C45D for ; Sun, 19 Aug 2007 16:11:17 +0000 (UTC) (envelope-from lynx.ripe@gmail.com) Received: by hu-out-0506.google.com with SMTP id 28so1178983hub for ; Sun, 19 Aug 2007 09:11:16 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=L2mR7IFNK4F32LbtlfMqxF0OMMskN7+EQ04mHthuiSdrEcedgbELyWOKDdrKvS1MasI8zKQ10/yOK7NxsSofbDQv5lZ7MokbO4RJKSnEeuhJ6gWGdtWfUixGhzwY9APbLIxBpnRZaQTDEeUyDlYMgWcJmw0p1YiVRCe4Ny8oULs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Aex/FdIMwuLyatX7zcV3F13ybTdseFaflyn0E8LugdyJc7DtS+7x5RZPz6Y7zxvrWln89ZCessmRBhuLtelWGLHxgJ2CZvujzznkzkNOjNtqwU0MG7hKQnYNR7L2y2rBgpBRv+RHh6ni1s5u0N6Pvx1IpH/MenmiifhmaxlFxjI= Received: by 10.114.204.7 with SMTP id b7mr3145340wag.1187538891230; Sun, 19 Aug 2007 08:54:51 -0700 (PDT) Received: by 10.115.22.8 with HTTP; Sun, 19 Aug 2007 08:54:51 -0700 (PDT) Message-ID: <754a9c140708190854vde1ca31n8ec1e9c5fbc9cbb3@mail.gmail.com> Date: Sun, 19 Aug 2007 18:54:51 +0300 From: "Dmitry Pryanishnikov" To: "Christian S.J. Peron" In-Reply-To: <46C861BA.4000708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <46C861BA.4000708@gmail.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: FreeBSD Mail Archives X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:11:18 -0000 Hello! > Date: Sat, 4 Aug 2007 20:35:42 +0000 (UTC) > From: "Christian S.J. Peron" > To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org > Subject: cvs commit: src/sbin/ipfw ipfw.8 > Message-ID: <200708042035.l74KZg6K061244@repoman.freebsd.org> > csjp 2007-08-04 20:35:42 UTC > > FreeBSD src repository > > Modified files: > sbin/ipfw ipfw.8 > Log: > Remove references to mpsafenet. This option no longer exists. I think this commit may create false feeling that using ipfw features such as gid, jail, uid and dummynet for IPv6 are now available for general use. However, I don't see commit messages for the locking fixes which would make these options safe. If I don't miss anything here, removal of the debug.mpsafenet makes all these ipfw uses always dangerous, so this fact should be mentioned in BUGS section of the manpage (until someone actually fixes those uses). -- Sincerely, Dmitry nic-hdl: LYNX-RIPE From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:31:58 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4442A16A417; Sun, 19 Aug 2007 16:31:58 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.freebsd.org (Postfix) with ESMTP id C211C13C47E; Sun, 19 Aug 2007 16:31:57 +0000 (UTC) (envelope-from max@love2party.net) Received: from dslb-088-066-038-247.pools.arcor-ip.net [88.66.38.247] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis), id 0ML31I-1IMnUk1fFr-0001bP; Sun, 19 Aug 2007 18:19:19 +0200 From: Max Laier Organization: FreeBSD To: "Dmitry Pryanishnikov" Date: Sun, 19 Aug 2007 18:18:51 +0200 User-Agent: KMail/1.9.7 References: <46C861BA.4000708@gmail.com> <754a9c140708190854vde1ca31n8ec1e9c5fbc9cbb3@mail.gmail.com> In-Reply-To: <754a9c140708190854vde1ca31n8ec1e9c5fbc9cbb3@mail.gmail.com> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart47503197.B6qlqSAryW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200708191819.10716.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+u9XupsXeG97Vf/e7gpPBp/D4qKVDi3Sa3zWg MvH+GBgbMmTtkkdfexlQHj3jfvX9HEE31Tc4pcafIBftzCtRKC wrGKUelrh4mQhZ/6Ds+582L2PZyf3DdAKZxWEgK6Fk= Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Christian S.J. Peron" , cvs-all@freebsd.org Subject: Re: FreeBSD Mail Archives X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:31:58 -0000 --nextPart47503197.B6qlqSAryW Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 19 August 2007, Dmitry Pryanishnikov wrote: > Hello! > > > Date: Sat, 4 Aug 2007 20:35:42 +0000 (UTC) > > From: "Christian S.J. Peron" > > To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, > > cvs-all@FreeBSD.org Subject: cvs commit: src/sbin/ipfw ipfw.8 > > Message-ID: <200708042035.l74KZg6K061244@repoman.freebsd.org> > > csjp 2007-08-04 20:35:42 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/ipfw ipfw.8 > > Log: > > Remove references to mpsafenet. This option no longer exists. > > I think this commit may create false feeling that using ipfw features > such as gid, jail, uid and dummynet for IPv6 are now available for > general use. However, I don't see commit messages for the locking fixes > which would make these options safe. If I don't miss anything here, > removal of the debug.mpsafenet makes all these ipfw uses always > dangerous, so this fact should be mentioned in BUGS section of the > manpage (until someone actually fixes those uses). As discussed before the removal of mpsafenet, the LOR reported for uid,=20 gid and jail rules is a false positive! There is no danger (of deadlock)=20 from using these rules. I'd still discourage the use of these options as they don't always do what= =20 people expect. The right sollution is a MAC based filter in the socket=20 layer. Although it does !sometimes! make sense to drop/accept packets=20 early. Esp. with protocols like ftp or sip it can be helpful, but one=20 should still be aware of the implications. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart47503197.B6qlqSAryW Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBGyG1+XyyEoT62BG0RAliBAJ4vR1EOP4QnHBCTh2cyHchUqW9sbACeJUEx 3woywfOIS0XrLk8AHi6ZPec= =D/eF -----END PGP SIGNATURE----- --nextPart47503197.B6qlqSAryW-- From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:38:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71A4F16A418; Sun, 19 Aug 2007 16:38:03 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id 35D9C13C4A7; Sun, 19 Aug 2007 16:38:01 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from 204.27-245-81.adsl-dyn.isp.belgacom.be (HELO kalimero.kotnet.org) ([81.245.27.204]) by mailrelay005.isp.belgacom.be with ESMTP; 19 Aug 2007 18:38:00 +0200 Received: from localhost (localhost [127.0.0.1]) by kalimero.kotnet.org (8.14.1/8.14.1) with ESMTP id l7JGbuor062403; Sun, 19 Aug 2007 18:37:56 +0200 (CEST) (envelope-from tijl@ulyssis.org) From: Tijl Coosemans To: Daniel Eischen Date: Sun, 19 Aug 2007 18:37:55 +0200 User-Agent: KMail/1.9.7 References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <20070819092923.X65240@fledge.watson.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708191837.56412.tijl@ulyssis.org> Cc: wine-freebsd@hub.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Marc G. Fournier" , Robert Watson , David Xu , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:38:03 -0000 On Sunday 19 August 2007 16:44:09 Daniel Eischen wrote: > Thread id's (as visible to an application) are not required to be > something that is known by the kernel. They certainly are not in > libkse and libc_r, and I don't think they are in libthr either. > This API won't work with libkse (or libc_r if we care) and isn't > guaranteed to work with any future libthreadX. Right, but this is irrelevant. Wine wants all threads to be visible by the kernel (system scope), and uses the kernel thread id to send signals, but also with ptrace for instance. > POSIX has well defined behavior with regard to signaling, and > this certainly bypasses that. If we want to add a more well thought > out set of APIs for thread groups that can (in the future) support > CPU binding and scheduling, then that's OK. But the API as committed > is a hack that solves one particular problem that can be solved in > other (more portable) ways. sigqueue() was mentioned as a possible > solution earlier. There's one immense downside to the sigqueue method though. When you call kill(2) you know the signal has been queued when the call returns and you know the signal will be posted when the thread next crosses the kernel-to-user boundary. With the sigqueue method signal delivery becomes entirely asynchronous and that introduces timing issues. I also don't see this syscall as a hack. It isn't in any portable specification, but it is an understandable extension to kernel threads, which the patch clearly shows because it isn't adding anything new. It's basically only exporting functionality that was already there and will never go away either, because the kernel will always need to send signals to threads. From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:17:30 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F319A16A417; Sun, 19 Aug 2007 16:17:29 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from mailrelay001.isp.belgacom.be (mailrelay001.isp.belgacom.be [195.238.6.51]) by mx1.freebsd.org (Postfix) with ESMTP id B6E0813C457; Sun, 19 Aug 2007 16:17:28 +0000 (UTC) (envelope-from tijl@ulyssis.org) Received: from 204.27-245-81.adsl-dyn.isp.belgacom.be (HELO kalimero.kotnet.org) ([81.245.27.204]) by mailrelay001.isp.belgacom.be with ESMTP; 19 Aug 2007 18:17:27 +0200 Received: from localhost (localhost [127.0.0.1]) by kalimero.kotnet.org (8.14.1/8.14.1) with ESMTP id l7JGGucH062168; Sun, 19 Aug 2007 18:16:56 +0200 (CEST) (envelope-from tijl@ulyssis.org) From: Tijl Coosemans To: Daniel Eischen Date: Sun, 19 Aug 2007 18:16:52 +0200 User-Agent: KMail/1.9.7 References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <87hcmwot68.fsf@wine.dyndns.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708191816.55617.tijl@ulyssis.org> X-Mailman-Approved-At: Sun, 19 Aug 2007 17:32:40 +0000 Cc: wine-freebsd@hub.org, "Marc G. Fournier" , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Alexandre Julliard , Robert Watson , David Xu , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:17:30 -0000 On Sunday 19 August 2007 16:53:13 Daniel Eischen wrote: > On Sun, 19 Aug 2007, Alexandre Julliard wrote: >> Daniel Eischen writes: >>> FreeBSD as well as Solaris and Linux (it looks like Linux only >>> allows a thread group to be signaled) have gotten along without >>> this API, and Wine seems to be the only target for this syscall. >> >> Actually, Linux, Solaris, and Mac OS X all export that >> functionality, and in all cases it was added before Wine requested >> it, probably because it's a fairly logical feature to have as part >> of a kernel threading mechanism. > > I do not see it in Solaris. All I can find is _lwp_kill(), which > isn't meant to be used by applications and isn't suppose to work for > LWPs outside the current process. Solaris exposes LWPs via the /proc file system and allows sending signals to them that way. From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:21:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AEC616A418; Sun, 19 Aug 2007 16:21:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 0E77113C458; Sun, 19 Aug 2007 16:21:08 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l7JGJeOE047927; Sun, 19 Aug 2007 10:19:41 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46C86D9A.9050705@samsco.org> Date: Sun, 19 Aug 2007 10:19:38 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Kris Moore References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> In-Reply-To: <46C863C5.6090906@comcast.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sun, 19 Aug 2007 10:19:41 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org X-Mailman-Approved-At: Sun, 19 Aug 2007 17:32:40 +0000 Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:21:09 -0000 Kris Moore wrote: > Robert Watson wrote: >> This work was done by Tijl at the request of the PC-BSD guys, who >> would like to be able to run windows applications out of the box on >> PC-BSD for their next release (impending). David then reviewed and >> committed the patch giving it his approval. The goal here was to >> avoid having the PC-BSD people have to run around with additional >> system call patches for the forseeable future, and to avoid requiring >> PC-BSD to fork the FreeBSD kernel to do that. > > Robert is correct here. Tijl has done a fantastic job with getting Wine > up to spec on FreeBSD, and it will help us greatly in trying to pursue > our goal of getting PC-BSD / FreeBSD on as many desktops as possible. > Easily the two most requested features we get from users who want to > switch over to BSD is working Wine support, and Flash 9 support. This > patch is a HUGE step in the right direction, and allows our users to > very easily run old legacy business apps or play the latest games, like > WoW. As such I really can't underscore the importance of this enough for > a viable desktop product. > I certainly appreciate the work that the PC-BSD guys are doing, and I apologize if it seemed like I didn't. However, adding a new syscall is a very big deal; once it's in, it lives with the OS for a very, very long time. So, it's something that does discussion. > > That being said, most of the technical details are a bit over my head, > but I will add my $0.02 to this. Whatever the solution, there needs to > be a working solution in the end. If there's a better, more portable way > to do this, then by all means lets get it done. If nobody can or will > write this solution, then lets not just drop the original patch. A fix > is greatly needed either way, so I hope this is added in the very near > future. > > Even if you decide to only add this new functionality to FreeBSD 7.x, > that's fine with us. Our next release of PC-BSD will be our last based > on FreeBSD 6.x before moving to 7. We're committed to shipping with the > patch Tijl wrote, since the improvements to Wine with it are night and > day. Of course if you roll this into the tree, all the better since I > won't have to spend the next 6 months to a year reminding users that > when they update world, they have to apply the Wine patch first ;-) > > Robert's comparison to Linux is only half-valid. There's really no reason to hold linux's clone/vfork threads up as a model to emulate via a new first-class interface into the kernel. If you want to emulate it, compile your app against the linux-threads package and be done with it. The Linux developers are moving beyond that primitive "threads" package anyways and onto real threads and a complementary API to manage those threads. So tkill and tgkill are interesting things to look at, not just here but in the broader need to work with Linux both at a source and a binary level. I believe that Dan also suggested something along this line in his discussion about having Solaris-style (and thus linux-style) thread groups, so I'm not exactly sure who is disagreeing with whom in Robert's response. Thread groups do seem like a logical next step, but it's impossible to say at this point whether the syscall API to support them would at all be served by the syscall that was just added. If it isn't, then this syscall becomes a 1-off orphan and a long-term liability to both users and developers. That's what ultimately needs to be avoided. So, supporting Wine is definitely a good idea, and there's no doubt a good solution available. It just makes me nervous when syscalls are added with such little discussion and commitment. Scott From owner-cvs-src@FreeBSD.ORG Sun Aug 19 16:24:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0BC516A419; Sun, 19 Aug 2007 16:24:32 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 72C7A13C457; Sun, 19 Aug 2007 16:24:32 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0DC644AB3C; Sun, 19 Aug 2007 12:24:32 -0400 (EDT) Date: Sun, 19 Aug 2007 17:24:31 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Kris Moore In-Reply-To: <46C863C5.6090906@comcast.net> Message-ID: <20070819170957.H81759@fledge.watson.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Sun, 19 Aug 2007 17:32:40 +0000 Cc: wine-freebsd@hub.org, Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 16:24:32 -0000 On Sun, 19 Aug 2007, Kris Moore wrote: > That being said, most of the technical details are a bit over my head, but I > will add my $0.02 to this. Whatever the solution, there needs to be a > working solution in the end. If there's a better, more portable way to do > this, then by all means lets get it done. If nobody can or will write this > solution, then lets not just drop the original patch. A fix is greatly > needed either way, so I hope this is added in the very near future. Let me provide a bit more background for those who are just joining the conversation, as it has been going on since around March. (You can find fragments on the freebsd-threads list, etc). The underlying requirement here is for Wine to be able to suspend threads of the emulation process -- this is not a requirement I have any specific insight into, so can't justify it, but it seems a fairly reasonable thing to want to do. In Linux, suspending threads in a remote process is easy, because threads are processes, so signals can be delivered directly to specific threads in a target process using kill(2). This same functionality is available in Mac OS X via thread/task ports, and possibly in Solaris via procfs (I agree with Dan's reading that the _lwp_kill(2) system call in Solaris doesn't look like it can target remote process threads, but the debugging interfaces certainly can, and Wine is full of debugging interface use). As a more portable solution, sigqueue(2) can be used -- this is a POSIX realtime signaling interface that, among other things, allows a data value to be passed to the receiveing process. This would allow a proxy thread in the emulated process to "receive" the signal and then forward the signal to a specific thread within the same process. However, sigqueue(2) is available only in FreeBSD 7.x, and has been determined to be sufficiently complex to not be MFC'able. This leaves FreeBSD 6.x, which neither implement the richer signalling service, nor direct signal delivery to target threads. An obvious quick solution here is to add a system call to provide equivilent functionality to that in Linux, Mac OS X, Solaris, etc -- allow direct delivery of a signal to a specific target thread in a remote process. thr_kill2() does this in the expectedly straight forward way, but specific to libthr, as only libthr offers a 1:1 threading model in which the kernel is sufficiently aware of threads as to offer a useful way to signal them. You can imagine other schemes for forwarding signals to threads in a remote process that are only marginally more complicated than using sigqueue, such as having a proxy listening on an IPC pipe or the like. I can't really comment on the impact to Wine code of doing this. BTW, Wine already has to know a lot about the internals of operating systems and processes in order to do what it does -- how to lay out address spaces, using the ptrace interfaces to control and manage threads, etc. So I'm not sure I buy that we should expect Wine to conform to portable interfaces, or that portable interfaces should be able to express what Wine needs: it is doing something pretty inherrently non-portable. However, it could be that we could avoid introducing more non-portable interfaces through more Wine rewriting. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Sun Aug 19 17:58:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E876516A417; Sun, 19 Aug 2007 17:58:11 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id B4ED113C491; Sun, 19 Aug 2007 17:58:11 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id A72BF48DAE; Sun, 19 Aug 2007 13:58:10 -0400 (EDT) Date: Sun, 19 Aug 2007 18:58:10 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <46C86D9A.9050705@samsco.org> Message-ID: <20070819185019.M81759@fledge.watson.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> <46C86D9A.9050705@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Sun, 19 Aug 2007 18:06:20 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 17:58:12 -0000 On Sun, 19 Aug 2007, Scott Long wrote: > Robert's comparison to Linux is only half-valid. There's really no reason > to hold linux's clone/vfork threads up as a model to emulate via a new > first-class interface into the kernel. If you want to emulate it, compile > your app against the linux-threads package and be done with it. > > The Linux developers are moving beyond that primitive "threads" package > anyways and onto real threads and a complementary API to manage those > threads. So tkill and tgkill are interesting things to look at, not just > here but in the broader need to work with Linux both at a source and a > binary level. I believe that Dan also suggested something along this line > in his discussion about having Solaris-style (and thus linux-style) thread > groups, so I'm not exactly sure who is disagreeing with whom in Robert's > response. Thread groups do seem like a logical next step, but it's > impossible to say at this point whether the syscall API to support them > would at all be served by the syscall that was just added. If it isn't, > then this syscall becomes a 1-off orphan and a long-term liability to both > users and developers. That's what ultimately needs to be avoided. > > So, supporting Wine is definitely a good idea, and there's no doubt a good > solution available. It just makes me nervous when syscalls are added with > such little discussion and commitment. I think the misunderstanding here is in thinking that Wine is an application that can program to the pthreads API and behave in a normal way. Instead, think of it as including its own threads library implementing Windows threading behavior. On the whole, the existing thread calls meet the needs of Wine, and often it can access them via pthreads, but there are times when it needs to *know* how threading works, and in those cases, accessing threads via low-level system call like thr_kill2(2) or via ptrace(2) may be entirely appropriate. Tijl's example of having aligned thread IDs for use between ptrace(2) and the thr_*(2) system calls is a particularly good example of a case where the clean pthreads abstraction (which has no notion of how to interact with debuggers) isn't a good match. We have a plethora of low level threads system calls that applications generally shouldn't touch -- rfork(2), kse_*(2), thr_*(2), umtx_*(2), etc. Last time I checked, Valgrind on FreeBSD did something very similar, relying on low-level umtx(2) system calls. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Sun Aug 19 18:08:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 137FA16A417; Sun, 19 Aug 2007 18:08:18 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 8FB5D13C457; Sun, 19 Aug 2007 18:08:17 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 5DCC917382; Sun, 19 Aug 2007 18:08:15 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l7JI8BEC085124; Sun, 19 Aug 2007 18:08:11 GMT (envelope-from phk@critter.freebsd.dk) To: Robert Watson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 19 Aug 2007 18:58:10 +0100." <20070819185019.M81759@fledge.watson.org> Date: Sun, 19 Aug 2007 18:08:11 +0000 Message-ID: <85123.1187546891@critter.freebsd.dk> Sender: phk@critter.freebsd.dk X-Mailman-Approved-At: Sun, 19 Aug 2007 18:15:42 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 18:08:18 -0000 In message <20070819185019.M81759@fledge.watson.org>, Robert Watson writes: >Tijl's example of having aligned thread IDs for use between ptrace(2) and the >thr_*(2) system calls is a particularly good example of a case where the clean >pthreads abstraction (which has no notion of how to interact with debuggers) Calling "pthreads clean" is an act of spin that I find actionable. "Spartan", "rudimentary" or most precisely: "primitive" all describe pthreads much better than "clean". I say this as an old ass-hole who have done multiprogramming in various environments since 1980 and as somebody who has never been able to fathom how pthreads came to be without even basic development and debugging aids such as, for instance, a pthread_mutex_assert_held() function. I also fully agree that Wine isn't an application, it is an emulation framework for a alien API, and thus any argument based on pthreads, so called, purity is bollocks. If Wine needs this to work and we need Wine to work, then we need this. Remember: "FreeBSD: Tools, not politics" >Last time I checked, Valgrind on FreeBSD did something very >similar, relying on low-level umtx(2) system calls. Actually I'm helping peter on valgrind and I got it to handle a new thread started with thr_new() only yesterday. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun Aug 19 18:19:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B881A16A418; Sun, 19 Aug 2007 18:19:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 82A1913C4A3; Sun, 19 Aug 2007 18:19:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 661A54C73C; Sun, 19 Aug 2007 14:19:17 -0400 (EDT) Date: Sun, 19 Aug 2007 19:19:17 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <20070819185019.M81759@fledge.watson.org> Message-ID: <20070819191731.N81759@fledge.watson.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> <46C86D9A.9050705@samsco.org> <20070819185019.M81759@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Sun, 19 Aug 2007 18:31:03 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 18:19:18 -0000 On Sun, 19 Aug 2007, Robert Watson wrote: > I think the misunderstanding here is in thinking that Wine is an application > that can program to the pthreads API and behave in a normal way. Instead, > think of it as including its own threads library implementing Windows > threading behavior. On the whole, the existing thread calls meet the needs > of Wine, and often it can access them via pthreads, but there are times when > it needs to *know* how threading works, and in those cases, accessing > threads via low-level system call like thr_kill2(2) or via ptrace(2) may be > entirely appropriate. > > Tijl's example of having aligned thread IDs for use between ptrace(2) and > the thr_*(2) system calls is a particularly good example of a case where the > clean pthreads abstraction (which has no notion of how to interact with > debuggers) isn't a good match. We have a plethora of low level threads > system calls that applications generally shouldn't touch -- rfork(2), > kse_*(2), thr_*(2), umtx_*(2), etc. Last time I checked, Valgrind on > FreeBSD did something very similar, relying on low-level umtx(2) system > calls. Just to follow up on this point: as with the other kse(2), thr(2), umtx(2), etc, interfaces, I think we should heavily discourage programmers from using them -- they are internal interfaces used to implement threading, and not general purpose application programming interfaces. I think adding a libpthread-layer interface for killing threads in other processes would be a mistake for all the reasons that Daniel and others have pointed out. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Sun Aug 19 19:36:47 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72DFB16A417; Sun, 19 Aug 2007 19:36:47 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4DC3613C442; Sun, 19 Aug 2007 19:36:47 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7JJalTa079034; Sun, 19 Aug 2007 19:36:47 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7JJalSh079033; Sun, 19 Aug 2007 19:36:47 GMT (envelope-from mav) Message-Id: <200708191936.l7JJalSh079033@repoman.freebsd.org> From: Alexander Motin Date: Sun, 19 Aug 2007 19:36:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 19:36:47 -0000 mav 2007-08-19 19:36:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_base.c Log: MFC rev. 1.135 Add ng_send_fn() error handeling inside ng_con_nodes(). Without it some errors may left unnoticed and unhandeled that lead to hooks left in half-connected state. Revision Changes Path 1.102.2.11 +5 -2 src/sys/netgraph/ng_base.c From owner-cvs-src@FreeBSD.ORG Sun Aug 19 20:34:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 042EA16A46C; Sun, 19 Aug 2007 20:34:15 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D2A3313C458; Sun, 19 Aug 2007 20:34:14 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7JKYEaj091322; Sun, 19 Aug 2007 20:34:14 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7JKYEC0091321; Sun, 19 Aug 2007 20:34:14 GMT (envelope-from njl) Message-Id: <200708192034.l7JKYEC0091321@repoman.freebsd.org> From: Nate Lawson Date: Sun, 19 Aug 2007 20:34:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_cpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 20:34:15 -0000 njl 2007-08-19 20:34:14 UTC FreeBSD src repository Modified files: sys/kern kern_cpu.c Log: Use a different loop variable for the inner loop. This previous reuse could have caused a hang, but we got lucky with the available multi-CPU states on actual hardware. Submitted by: Bjorn Koenig Approved by: re MFC after: 3 days Revision Changes Path 1.26 +4 -4 src/sys/kern/kern_cpu.c From owner-cvs-src@FreeBSD.ORG Sun Aug 19 20:53:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B23116A418; Sun, 19 Aug 2007 20:53:51 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 552C313C458; Sun, 19 Aug 2007 20:53:51 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7JKrp87001208; Sun, 19 Aug 2007 20:53:51 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7JKrpqV001207; Sun, 19 Aug 2007 20:53:51 GMT (envelope-from ache) Message-Id: <200708192053.l7JKrpqV001207@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sun, 19 Aug 2007 20:53:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/gnu/lib/libdialog dialog.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 20:53:51 -0000 ache 2007-08-19 20:53:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/lib/libdialog dialog.h Log: Increase MAX_LEN to 4096 It fix core dump with latest ghostscript-gpl port (too many items) Revision Changes Path 1.22.14.1 +1 -1 src/gnu/lib/libdialog/dialog.h From owner-cvs-src@FreeBSD.ORG Sun Aug 19 21:22:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E652B16A418 for ; Sun, 19 Aug 2007 21:22:32 +0000 (UTC) (envelope-from miwi@FreeBSD.org) Received: from mail.unixfreunde.de (mail.unixfreunde.de [217.172.44.88]) by mx1.freebsd.org (Postfix) with ESMTP id A878D13C46E for ; Sun, 19 Aug 2007 21:22:32 +0000 (UTC) (envelope-from miwi@FreeBSD.org) Received: from mail.unixfreunde.de (mail.unixfreunde.de [217.172.44.88]) by mail.unixfreunde.de (Postfix) with SMTP id 011D2E66F1 for ; Sun, 19 Aug 2007 21:10:54 +0000 (UTC) Received: from miwi.homeunix.com (dslb-082-083-136-152.pools.arcor-ip.net [82.83.136.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.unixfreunde.de (Postfix) with ESMTP id 7CACDE602B for ; Sun, 19 Aug 2007 21:10:52 +0000 (UTC) Date: Sun, 19 Aug 2007 23:09:08 +0200 From: Martin Wilke To: cvs-src@freebsd.org In-Reply-To: <200708192053.l7JKrpqV001207@repoman.freebsd.org> References: <200708192053.l7JKrpqV001207@repoman.freebsd.org> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-portbld-freebsd7.0) User-Agent: miwi@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 Message-Id: <20070819211054.7CACDE602B@mail.unixfreunde.de> X-DSPAM-Result: Innocent X-DSPAM-Processed: Sun Aug 19 21:10:54 2007 X-DSPAM-Confidence: 1.0000 X-DSPAM-Probability: 0.0023 X-DSPAM-Signature: 84,46c8b1de13291644917644 Subject: Re: cvs commit: src/gnu/lib/libdialog dialog.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 21:22:33 -0000 LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpPbiBTdW4s IDE5IEF1ZyAyMDA3IDIwOjUzOjUxICswMDAwIChVVEMpDQoiQW5kcmV5IEEuIENoZXJub3YiIDxh Y2hlQEZyZWVCU0Qub3JnPiB3cm90ZToNCg0KfCAgTW9kaWZpZWQgZmlsZXM6ICAgICAgICAoQnJh bmNoOiBSRUxFTkdfNikNCnwgICAgZ251L2xpYi9saWJkaWFsb2cgICAgZGlhbG9nLmggDQp8ICBM b2c6DQp8ICBJbmNyZWFzZSBNQVhfTEVOIHRvIDQwOTYNCnwgIEl0IGZpeCBjb3JlIGR1bXAgd2l0 aCBsYXRlc3QgZ2hvc3RzY3JpcHQtZ3BsIHBvcnQgKHRvbyBtYW55IGl0ZW1zKQ0KDQpUaGFua3Mg Zm9yIHRoaXMgZml4Lg0KDQotIC0gTWFydGluDQoNCi0gLS0gDQpNYXJ0aW4gV2lsa2UJCXwgaXJj LnVuaXhmcmV1bmRlLmRlICNic2QgDQptaXdpQEZyZWVCU0Qub3JnCXwgbWl3aUB1bml4ZnJldW5k ZS5kZQ0KRnJlZUJTRCBDb21taXR0ZXIJfCBQb3dlciB0byBTZXJ2ZQ0KLS0tLS1CRUdJTiBQR1Ag U0lHTkFUVVJFLS0tLS0NClZlcnNpb246IEdudVBHIHYyLjAuNCAoRnJlZUJTRCkNCg0KaUQ4REJR Rkd5TEY0RndweWNBVm9JMU1SQXVYaEFKOWlMMVJCcEhkSzVkZ3lpOVRDcHFOVFUwTERtZ0NnaFBl Qw0KK2dZd1NZaVFmNVdOS3hEU24xdERYTmc9DQo9OGtiaA0KLS0tLS1FTkQgUEdQIFNJR05BVFVS RS0tLS0tDQo= From owner-cvs-src@FreeBSD.ORG Sun Aug 19 21:39:36 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 009E516A419 for ; Sun, 19 Aug 2007 21:39:36 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 9824913C478 for ; Sun, 19 Aug 2007 21:39:35 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 22119 invoked by uid 399); 19 Aug 2007 21:39:35 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 19 Aug 2007 21:39:35 -0000 X-Originating-IP: 127.0.0.1 Date: Sun, 19 Aug 2007 14:39:33 -0700 (PDT) From: Doug Barton To: cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=us-ascii Cc: Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys (fwd) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 21:39:36 -0000 On Sun, 19 Aug 2007, Robert Watson wrote: > The underlying requirement here is for Wine to be able to suspend threads of > the emulation process -- [ snip ] > As a more portable solution, sigqueue(2) can be used -- this is a POSIX > realtime signaling interface that, among other things, allows a data value to > be passed to the receiveing process. This would allow a proxy thread in the > emulated process to "receive" the signal and then forward the signal to a > specific thread within the same process. However, sigqueue(2) is available > only in FreeBSD 7.x, and has been determined to be sufficiently complex to > not be MFC'able. Given that Kris Moore has stated in this thread that he's not concerned (on behalf of pc-bsd) if this functionality doesn't get backported to RELENG_6, I'd be curious to hear how hard it would be to implement this same functionality with sigqueue(2). FWIW, I'm _all_ for improving our ability to run Wine (and any other functionality that will help us be a better desktop OS). If we can get Wine to the point where it's useful and reliable for day to day stuff, I'll be one of the people running it day to day myself. Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Sun Aug 19 21:37:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9ABFB16A41A for ; Sun, 19 Aug 2007 21:37:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 36AD213C4A5 for ; Sun, 19 Aug 2007 21:37:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 19999 invoked by uid 399); 19 Aug 2007 21:37:19 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 19 Aug 2007 21:37:19 -0000 X-Originating-IP: 127.0.0.1 Date: Sun, 19 Aug 2007 14:37:16 -0700 (PDT) From: Doug Barton To: Robert Watson In-Reply-To: <20070819170957.H81759@fledge.watson.org> Message-ID: References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> <20070819170957.H81759@fledge.watson.org> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii; format=flowed X-Mailman-Approved-At: Sun, 19 Aug 2007 21:56:12 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2007 21:37:22 -0000 On Sun, 19 Aug 2007, Robert Watson wrote: > The underlying requirement here is for Wine to be able to suspend threads of > the emulation process -- [ snip ] > As a more portable solution, sigqueue(2) can be used -- this is a POSIX > realtime signaling interface that, among other things, allows a data value to > be passed to the receiveing process. This would allow a proxy thread in the > emulated process to "receive" the signal and then forward the signal to a > specific thread within the same process. However, sigqueue(2) is available > only in FreeBSD 7.x, and has been determined to be sufficiently complex to > not be MFC'able. Given that Kris Moore has stated in this thread that he's not concerned (on behalf of pc-bsd) if this functionality doesn't get backported to RELENG_6, I'd be curious to hear how hard it would be to implement this same functionality with sigqueue(2). FWIW, I'm _all_ for improving our ability to run Wine (and any other functionality that will help us be a better desktop OS). If we can get Wine to the point where it's useful and reliable for day to day stuff, I'll be one of the people running it day to day myself. Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Mon Aug 20 06:28:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DBB016A41A; Mon, 20 Aug 2007 06:28:27 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 74B3113C428; Mon, 20 Aug 2007 06:28:27 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7K6SRqO065236; Mon, 20 Aug 2007 06:28:27 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7K6SRwL065235; Mon, 20 Aug 2007 06:28:27 GMT (envelope-from njl) Message-Id: <200708200628.l7K6SRwL065235@repoman.freebsd.org> From: Nate Lawson Date: Mon, 20 Aug 2007 06:28:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_cpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 06:28:27 -0000 njl 2007-08-20 06:28:26 UTC FreeBSD src repository Modified files: sys/kern kern_cpu.c Log: Always call sched_bind(), even if on the CPU in question. It is wrong to check if we're already on that cpu and skip the bind since the thread could be migrated off in the meantime. Suggested by: jeff Approved by: re Revision Changes Path 1.27 +15 -25 src/sys/kern/kern_cpu.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 06:34:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E892F16A420; Mon, 20 Aug 2007 06:34:20 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C022D13C468; Mon, 20 Aug 2007 06:34:20 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7K6YKID065715; Mon, 20 Aug 2007 06:34:20 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7K6YKsY065714; Mon, 20 Aug 2007 06:34:20 GMT (envelope-from jeff) Message-Id: <200708200634.l7K6YKsY065714@repoman.freebsd.org> From: Jeff Roberson Date: Mon, 20 Aug 2007 06:34:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 06:34:21 -0000 jeff 2007-08-20 06:34:20 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Set steal_thresh to log2(ncpus). This improves idle-time load balancing on 2cpu machines by reducing it to 1 by default. This improves loaded operation on 8cpu machines by increasing it to 3 where the extra idle time is not as critical. Approved by: re Revision Changes Path 1.205 +6 -0 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 06:36:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D99116A418; Mon, 20 Aug 2007 06:36:12 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7496A13C4D1; Mon, 20 Aug 2007 06:36:12 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7K6aC9b065821; Mon, 20 Aug 2007 06:36:12 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7K6aCCE065820; Mon, 20 Aug 2007 06:36:12 GMT (envelope-from jeff) Message-Id: <200708200636.l7K6aCCE065820@repoman.freebsd.org> From: Jeff Roberson Date: Mon, 20 Aug 2007 06:36:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 06:36:12 -0000 jeff 2007-08-20 06:36:12 UTC FreeBSD src repository Modified files: sys/kern kern_switch.c Log: - Improve runq_findbit_from() which is used by ULE's circular queue. Mask of the bits we want to ignore on the first pass rather than doing a linear scan. This puts us within a few instructions of the cost of runq_findbit() and removes this function from the top of profiling output for context switch heavy workloads. Approved by: re Revision Changes Path 1.134 +22 -32 src/sys/kern/kern_switch.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 09:31:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C7C516A417; Mon, 20 Aug 2007 09:31:57 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 7436013C45B; Mon, 20 Aug 2007 09:31:57 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 721331A4D7C; Mon, 20 Aug 2007 02:30:09 -0700 (PDT) Date: Mon, 20 Aug 2007 02:30:09 -0700 From: Alfred Perlstein To: Kris Moore Message-ID: <20070820093009.GE87451@elvis.mu.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C863C5.6090906@comcast.net> User-Agent: Mutt/1.4.2.3i X-Mailman-Approved-At: Mon, 20 Aug 2007 11:16:18 +0000 Cc: wine-freebsd@hub.org, Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 09:31:57 -0000 * Kris Moore [070819 08:50] wrote: > > Even if you decide to only add this new functionality to FreeBSD 7.x, > that's fine with us. Our next release of PC-BSD will be our last based > on FreeBSD 6.x before moving to 7. We're committed to shipping with the > patch Tijl wrote, since the improvements to Wine with it are night and > day. Of course if you roll this into the tree, all the better since I > won't have to spend the next 6 months to a year reminding users that > when they update world, they have to apply the Wine patch first ;-) Kris, I support the patch. That said, have you toyed with implementing this as a kld that you can ship with your code? -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Aug 20 11:53:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E1A116A418; Mon, 20 Aug 2007 11:53:28 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 26C0D13C48A; Mon, 20 Aug 2007 11:53:28 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KBrS6r047544; Mon, 20 Aug 2007 11:53:28 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KBrRCe047543; Mon, 20 Aug 2007 11:53:27 GMT (envelope-from kib) Message-Id: <200708201153.l7KBrRCe047543@repoman.freebsd.org> From: Konstantin Belousov Date: Mon, 20 Aug 2007 11:53:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_aio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 11:53:28 -0000 kib 2007-08-20 11:53:27 UTC FreeBSD src repository Modified files: sys/kern vfs_aio.c Log: Destroy the kaio_mtx on the freeing the struct kaioinfo in the aio_proc_rundown. Do not allow for zero-length read to be passed to the fo_read file method by aio. Reported and tested by: Peter Holm Approved by: re (kensmith) Revision Changes Path 1.233 +5 -1 src/sys/kern/vfs_aio.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 12:05:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E18B216A418; Mon, 20 Aug 2007 12:05:45 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B8C9C13C467; Mon, 20 Aug 2007 12:05:45 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KC5jve049701; Mon, 20 Aug 2007 12:05:45 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KC5jJr049700; Mon, 20 Aug 2007 12:05:45 GMT (envelope-from kib) Message-Id: <200708201205.l7KC5jJr049700@repoman.freebsd.org> From: Konstantin Belousov Date: Mon, 20 Aug 2007 12:05:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_map.c vm_map.h vm_mmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 12:05:46 -0000 kib 2007-08-20 12:05:45 UTC FreeBSD src repository Modified files: sys/vm vm_map.c vm_map.h vm_mmap.c Log: Do not drop vm_map lock between doing vm_map_remove() and vm_map_insert(). For this, introduce vm_map_fixed() that does that for MAP_FIXED case. Dropping the lock allowed for parallel thread to occupy the freed space. Reported by: Tijl Coosemans Reviewed by: alc Approved by: re (kensmith) MFC after: 2 weeks Revision Changes Path 1.387 +35 -16 src/sys/vm/vm_map.c 1.120 +1 -0 src/sys/vm/vm_map.h 1.213 +4 -2 src/sys/vm/vm_mmap.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 13:00:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CC1216A468; Mon, 20 Aug 2007 13:00:48 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7D13013C4CC; Mon, 20 Aug 2007 13:00:48 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KD0mlu079048; Mon, 20 Aug 2007 13:00:48 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KD0mkV079047; Mon, 20 Aug 2007 13:00:48 GMT (envelope-from truckman) Message-Id: <200708201300.l7KD0mkV079047@repoman.freebsd.org> From: Don Lewis Date: Mon, 20 Aug 2007 13:00:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/rpc.statd file.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 13:00:48 -0000 truckman 2007-08-20 13:00:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/rpc.statd file.c Log: MFC file.c 1.8 If the mmap() call in rpc.statd fails, rpc.statd prints a warning message and then dumps core because the subsequent code assumes that mmap() succeeded. Since rpc.statd does not have fallback code to implement the functionality needed to operate on the status file if it is not memory mapped, rpc.statd should use err() to force the process to exit if the mmap() call fails. PR: bin/115430 (mmap() failure previously fixed in statd.c 1.12.8.2) Revision Changes Path 1.7.10.1 +1 -1 src/usr.sbin/rpc.statd/file.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 13:04:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B53B16A417; Mon, 20 Aug 2007 13:04:05 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5BE8E13C4D0; Mon, 20 Aug 2007 13:04:05 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KD45Fu080771; Mon, 20 Aug 2007 13:04:05 GMT (envelope-from truckman@repoman.freebsd.org) Received: (from truckman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KD45I5080770; Mon, 20 Aug 2007 13:04:05 GMT (envelope-from truckman) Message-Id: <200708201304.l7KD45I5080770@repoman.freebsd.org> From: Don Lewis Date: Mon, 20 Aug 2007 13:04:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/usb ehci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 13:04:05 -0000 truckman 2007-08-20 13:04:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/usb ehci.c Log: MFC ehci.c 1.56 Replace three copies of the host controller reset sequence that differ in their details with calls to a new function, ehci_hcreset(), that performs the reset. The original sequences either had no delay or a 1ms delay between telling the controller to stop and asserting the controller reset bit. One instance of the original reset sequence waited for the controller to indicate that its reset was complete before continuing, but the other two immediately let the subsequent code execute. The latter is a problem on some hardware, because a read of the HCCPARAMS register returns an incorrect value while the reset is in progress, which triggers an infinite loop in ehci_pci_givecontroller(), which hangs the system on shutdown. The reset sequence in ehci_hcreset() starts with the most complete instance from the original code, which contains a loop to wait for the controller to indicate that its reset is complete. This appears to be the correct thing to do according to "Enhanced Host Controller Interface Specification for Universal Serial Bus" revision 1.0, section 2.3.1. Add another loop to wait for the controller to indicate that it has stopped before setting the HCRESET bit. This is required by the section 2.3.1 in the specification, which says that setting HCRESET before the controller has halted "will result in undefined behaviour". Revision Changes Path 1.36.2.4 +37 -18 src/sys/dev/usb/ehci.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 15:33:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 581D116A417; Mon, 20 Aug 2007 15:33:23 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 488E113C494; Mon, 20 Aug 2007 15:33:23 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KFXN9H095585; Mon, 20 Aug 2007 15:33:23 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KFXNn1095584; Mon, 20 Aug 2007 15:33:23 GMT (envelope-from cognet) Message-Id: <200708201533.l7KFXNn1095584@repoman.freebsd.org> From: Olivier Houchard Date: Mon, 20 Aug 2007 15:33:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 15:33:23 -0000 cognet 2007-08-20 15:33:23 UTC FreeBSD src repository Modified files: sys/gnu/fs/xfs/FreeBSD xfs_mountops.c Log: Some times ago, vfs_getopts() was changed, so that it would set error to ENOENT if the option wasn't provided, instead of setting it to 0. xfs however didn't catch up on this, so it assumed something went bad if vfs_getopts() sets the error to non-zero, and just returns the error. Unbreak xfs mount by just ignoring the error if vfs_getopts() sets the error to ENOENT, as we should have sane defaults. Reviewed by: kan Approved by: re (rwatson) Tested by: rpaulo Revision Changes Path 1.10 +6 -6 src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c From owner-cvs-src@FreeBSD.ORG Mon Aug 20 15:09:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D89316A418; Mon, 20 Aug 2007 15:09:52 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 1101013C45B; Mon, 20 Aug 2007 15:09:51 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l7KF8Lev055381; Mon, 20 Aug 2007 09:08:21 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46C9AE64.50705@samsco.org> Date: Mon, 20 Aug 2007 09:08:20 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Kris Moore References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net><20070820093009.GE87451@elvis.mu.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> In-Reply-To: <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 20 Aug 2007 09:08:22 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org X-Mailman-Approved-At: Mon, 20 Aug 2007 16:08:19 +0000 Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 15:09:52 -0000 Having it as a loadable module that is essentially private to PC-BSD (though open source, of course) will lead to questions of why Wine works in PC-BSD and not FreeBSD. That's fine if your intention is to create a fork of FreeBSD, but I don't know if that's what you really want. Scott Kris Moore wrote: > The thought of a KLD hadn't occured to me actually. We are very close to releasing 1.4RC1 though, so it may be a bit to close to work that out at the moment. Tijl would probably be the one to ask about that though, since he's the one making all this come together :) > > However we will ship with the sys source on our disk 2, patch included. We'll just have to ensure we let users know when they do a csup to re-apply the wine patches manually. > > Sent via BlackBerry by AT&T > > -----Original Message----- > From: Alfred Perlstein > > Date: Mon, 20 Aug 2007 02:30:09 > To:Kris Moore > Cc:Robert Watson , Scott Long ,Daniel Eischen ,Tijl Coosemans , David Xu ,wine-freebsd@hub.org, Xin LI ,src-committers@FreeBSD.org, cvs-src@FreeBSD.org,cvs-all@FreeBSD.org > Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys > > > * Kris Moore [070819 08:50] wrote: >> Even if you decide to only add this new functionality to FreeBSD 7.x, >> that's fine with us. Our next release of PC-BSD will be our last based >> on FreeBSD 6.x before moving to 7. We're committed to shipping with the >> patch Tijl wrote, since the improvements to Wine with it are night and >> day. Of course if you roll this into the tree, all the better since I >> won't have to spend the next 6 months to a year reminding users that >> when they update world, they have to apply the Wine patch first ;-) > > Kris, I support the patch. > > That said, have you toyed with implementing this as a kld that > you can ship with your code? > From owner-cvs-src@FreeBSD.ORG Mon Aug 20 16:20:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C401016A417; Mon, 20 Aug 2007 16:20:57 +0000 (UTC) (envelope-from krismoore@comcast.net) Received: from alnrmhc11.comcast.net (alnrmhc11.comcast.net [206.18.177.51]) by mx1.freebsd.org (Postfix) with ESMTP id 1271813C45E; Mon, 20 Aug 2007 16:20:57 +0000 (UTC) (envelope-from krismoore@comcast.net) Received: from [192.168.1.102] (c-67-170-130-86.hsd1.wa.comcast.net[67.170.130.86]) by comcast.net (alnrmhc11) with ESMTP id <20070820162041b1100r2p3ge>; Mon, 20 Aug 2007 16:20:56 +0000 Message-ID: <46C9BF66.101@comcast.net> Date: Mon, 20 Aug 2007 09:20:54 -0700 From: Kris Moore User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Scott Long References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net><20070820093009.GE87451@elvis.mu.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> In-Reply-To: <46C9AE64.50705@samsco.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 20 Aug 2007 16:25:39 +0000 Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 16:20:57 -0000 Scott Long wrote: > Having it as a loadable module that is essentially private to PC-BSD > (though open source, of course) will lead to questions of why Wine works > in PC-BSD and not FreeBSD. That's fine if your intention is to create > a fork of FreeBSD, but I don't know if that's what you really want. > > Scott > Scott, We have no intention or desire to have a fork of FreeBSD at all, which is why I would LOVE to see this patch go into 6-Stable before we release. Right now our testing ISO's are being built with the patch for Q/A purposes. and it works so well that I couldn't imagine not having our next release include it. Any way you guys can make that happen, would really help a TON of desktop users such as myself. -- Kris Moore PC-BSD Software From owner-cvs-src@FreeBSD.ORG Mon Aug 20 16:40:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F51E16A417; Mon, 20 Aug 2007 16:40:57 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id 8630613C49D; Mon, 20 Aug 2007 16:40:56 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 98CA2691061; Mon, 20 Aug 2007 17:44:32 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 53B3669106F; Mon, 20 Aug 2007 17:44:32 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DSBL, RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local (unknown [83.144.141.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by core.fnop.net (Postfix) with ESMTP id CB1C5691061; Mon, 20 Aug 2007 17:44:28 +0100 (WEST) Message-ID: <46C9C413.5020102@fnop.net> Date: Mon, 20 Aug 2007 17:40:51 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Olivier Houchard References: <200708201533.l7KFXNn1095584@repoman.freebsd.org> In-Reply-To: <200708201533.l7KFXNn1095584@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 16:40:57 -0000 Olivier Houchard wrote: > cognet 2007-08-20 15:33:23 UTC > > FreeBSD src repository > > Modified files: > sys/gnu/fs/xfs/FreeBSD xfs_mountops.c > Log: > Some times ago, vfs_getopts() was changed, so that it would set error to > ENOENT if the option wasn't provided, instead of setting it to 0. > xfs however didn't catch up on this, so it assumed something went bad if > vfs_getopts() sets the error to non-zero, and just returns the error. > Unbreak xfs mount by just ignoring the error if vfs_getopts() sets the > error to ENOENT, as we should have sane defaults. > > Reviewed by: kan > Approved by: re (rwatson) > Tested by: rpaulo Thanks! -- Rui Paulo From owner-cvs-src@FreeBSD.ORG Mon Aug 20 16:29:49 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B89BE16A418; Mon, 20 Aug 2007 16:29:49 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from hub.org (hub.org [200.46.204.220]) by mx1.freebsd.org (Postfix) with ESMTP id 428DB13C46C; Mon, 20 Aug 2007 16:29:49 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from localhost (maia-1.hub.org [200.46.204.191]) by hub.org (Postfix) with ESMTP id A818CB46FE5; Mon, 20 Aug 2007 13:29:48 -0300 (ADT) Received: from hub.org ([200.46.204.220]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-maia, port 10024) with ESMTP id 25084-01; Mon, 20 Aug 2007 13:29:38 -0300 (ADT) Received: from fserv.hub.org (blk-89-241-126.eastlink.ca [24.89.241.126]) by hub.org (Postfix) with ESMTP id 10095B46818; Mon, 20 Aug 2007 13:24:38 -0300 (ADT) Received: from [192.168.1.2] (unknown [192.168.1.2]) by fserv.hub.org (Postfix) with ESMTP id DE192E65FB; Mon, 20 Aug 2007 13:24:37 -0300 (ADT) Date: Mon, 20 Aug 2007 13:24:22 -0300 From: "Marc G. Fournier" To: Scott Long , Kris Moore Message-ID: <87BDE21001E9C907935CF6EB@ganymede.hub.org> In-Reply-To: <46C9AE64.50705@samsco.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net><20070820093009.GE87451@elvis.mu.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Mailman-Approved-At: Mon, 20 Aug 2007 16:51:52 +0000 Cc: wine-freebsd@hub.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 16:29:49 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Monday, August 20, 2007 09:08:20 -0600 Scott Long wrote: > Having it as a loadable module that is essentially private to PC-BSD (though > open source, of course) will lead to questions of why Wine works > in PC-BSD and not FreeBSD. That's fine if your intention is to create > a fork of FreeBSD, but I don't know if that's what you really want. Stupid question here, but wouldn't such a KLD work under both PC-BSD and FreeBSD? Something that we could put into ports and make a dependency *of* Wine? I kinda hate to see us do a whole whack of work on the Wine side when the problem is a deficiency on our part that Solaris, MacOS X and Linux have already seemed to dealt with :( > > Scott > > > Kris Moore wrote: >> The thought of a KLD hadn't occured to me actually. We are very close to >> releasing 1.4RC1 though, so it may be a bit to close to work that out at the >> moment. Tijl would probably be the one to ask about that though, since he's >> the one making all this come together :) >> >> However we will ship with the sys source on our disk 2, patch included. >> We'll just have to ensure we let users know when they do a csup to re-apply >> the wine patches manually. >> >> Sent via BlackBerry by AT&T >> >> -----Original Message----- >> From: Alfred Perlstein >> >> Date: Mon, 20 Aug 2007 02:30:09 >> To:Kris Moore >> Cc:Robert Watson , Scott Long >> ,Daniel Eischen ,Tijl Coosemans >> , David Xu ,wine-freebsd@hub.org, Xin >> LI ,src-committers@FreeBSD.org, >> cvs-src@FreeBSD.org,cvs-all@FreeBSD.org Subject: Re: cvs commit: >> src/sys/kern kern_thr.c syscalls.master src/sys/sys >> >> >> * Kris Moore [070819 08:50] wrote: >>> Even if you decide to only add this new functionality to FreeBSD 7.x, >>> that's fine with us. Our next release of PC-BSD will be our last based >>> on FreeBSD 6.x before moving to 7. We're committed to shipping with the >>> patch Tijl wrote, since the improvements to Wine with it are night and >>> day. Of course if you roll this into the tree, all the better since I >>> won't have to spend the next 6 months to a year reminding users that >>> when they update world, they have to apply the Wine patch first ;-) >> >> Kris, I support the patch. >> >> That said, have you toyed with implementing this as a kld that >> you can ship with your code? >> > - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGycA24QvfyHIvDvMRAgTWAKCtXFIsjCUyt1UPRM9JQSr+L/yexQCeJ56Q TDxTtLZy/up0aCz9xKYq0Wo= =4/Us -----END PGP SIGNATURE----- From owner-cvs-src@FreeBSD.ORG Mon Aug 20 16:32:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 426F616A41A; Mon, 20 Aug 2007 16:32:49 +0000 (UTC) Date: Mon, 20 Aug 2007 16:32:49 +0000 From: Alexey Dokuchaev To: Scott Long Message-ID: <20070820163249.GA28082@FreeBSD.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <46C9AE64.50705@samsco.org> User-Agent: Mutt/1.4.2.1i X-Mailman-Approved-At: Mon, 20 Aug 2007 16:51:52 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 16:32:49 -0000 On Mon, Aug 20, 2007 at 09:08:20AM -0600, Scott Long wrote: > Having it as a loadable module that is essentially private to PC-BSD > (though open source, of course) will lead to questions of why Wine works > in PC-BSD and not FreeBSD. Why not simply RUN_DEPEND on it in wine port? If that's not possible, I don't really see how having such module helps. ./danfe From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:21:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E72116A46C for ; Mon, 20 Aug 2007 18:21:57 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.234]) by mx1.freebsd.org (Postfix) with ESMTP id CED9013C46E for ; Mon, 20 Aug 2007 18:21:56 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so924418wra for ; Mon, 20 Aug 2007 11:21:56 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FrgwzzIYf9/KluhGUjYAQQjghx3B3uuiQJ+K6hp/Lf60+cPpNH5/85TC1T4rvs6GPDVaqrANVWAD8zIpaz+Qa+DM5U+9GZMV4JVLJJdeQJ89mzzsuli4iWpgN6OwVem5lbmf59my+2NNpSZtcIB42LMmyUgIdqocC40CCXAwcOM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k0OM4pCTIsE3B02TCA9Pfu/H1Sr8GeIJIC2ZqD9KYWahKuZXrRKLIuEPECP3KGuevUlnO1dpSG+x1n293tB2I190FlcyuA1Q2hcUn0G++SnnEN/+ge9i9ReoGYD1VTEm3Nej8A9gxuc5b+fK1LAKsGZM9xKTOuvWbmCaqDTh/5s= Received: by 10.90.34.3 with SMTP id h3mr10419957agh.1187632599192; Mon, 20 Aug 2007 10:56:39 -0700 (PDT) Received: by 10.100.122.7 with HTTP; Mon, 20 Aug 2007 10:56:39 -0700 (PDT) Message-ID: Date: Mon, 20 Aug 2007 10:56:39 -0700 From: "Matt Reimer" To: "Robert Watson" In-Reply-To: <20070819095302.D66918@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> X-Mailman-Approved-At: Mon, 20 Aug 2007 18:33:39 +0000 Cc: wine-freebsd@hub.org, Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys thr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:21:57 -0000 On 8/19/07, Robert Watson wrote: > > On Sat, 18 Aug 2007, Scott Long wrote: > > >> You can say that about a lot of APIs, but that doesn't mean we should add > >> them. This is a bit of a hack to satisfy one application (Wine) when there > >> are other (perhaps harder) ways to skin the cat. We certainly don't want > >> anything else using this API, so I'd advocate removing it. > > > > I'm in strong agreement here. David? > > This work was done by Tijl at the request of the PC-BSD guys, who would like > to be able to run windows applications out of the box on PC-BSD for their next > release (impending). David then reviewed and committed the patch giving it > his approval. The goal here was to avoid having the PC-BSD people have to run > around with additional system call patches for the forseeable future, and to > avoid requiring PC-BSD to fork the FreeBSD kernel to do that. In the meantime, how about implementing the syscall as a module that builds out of ports, using SYSCALL_MODULE() on the kernel side and modfind() on the userland side? That way the wine guys aren't blocked, but neither is code added to the kernel prematurely. Matt From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:31:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B1C416A41A; Mon, 20 Aug 2007 18:31:00 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 73EE813C478; Mon, 20 Aug 2007 18:30:55 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 807161A4D8D; Mon, 20 Aug 2007 11:29:05 -0700 (PDT) Date: Mon, 20 Aug 2007 11:29:05 -0700 From: Alfred Perlstein To: Scott Long Message-ID: <20070820182905.GH87451@elvis.mu.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C9AE64.50705@samsco.org> User-Agent: Mutt/1.4.2.3i X-Mailman-Approved-At: Mon, 20 Aug 2007 18:33:39 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:31:00 -0000 * Scott Long [070820 08:08] wrote: > Having it as a loadable module that is essentially private to PC-BSD > (though open source, of course) will lead to questions of why Wine works > in PC-BSD and not FreeBSD. That's fine if your intention is to create > a fork of FreeBSD, but I don't know if that's what you really want. > Honestly I think he wants to contribute to the project, but you won't to punish him for it... I don't know why, it's not like you but whatever. I gave him a way to get around all the bs and continue with life, no need to guilt trip him on it. -Alfred > Scott > > > Kris Moore wrote: > >The thought of a KLD hadn't occured to me actually. We are very close to > >releasing 1.4RC1 though, so it may be a bit to close to work that out at > >the moment. Tijl would probably be the one to ask about that though, since > >he's the one making all this come together :) > > > >However we will ship with the sys source on our disk 2, patch included. > >We'll just have to ensure we let users know when they do a csup to > >re-apply the wine patches manually. > >Sent via BlackBerry by AT&T > > > >-----Original Message----- > >From: Alfred Perlstein > > > >Date: Mon, 20 Aug 2007 02:30:09 > >To:Kris Moore > >Cc:Robert Watson , Scott Long > >,Daniel Eischen ,Tijl Coosemans > >, David Xu ,wine-freebsd@hub.org, > >Xin LI ,src-committers@FreeBSD.org, > >cvs-src@FreeBSD.org,cvs-all@FreeBSD.org > >Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master > >src/sys/sys > > > > > >* Kris Moore [070819 08:50] wrote: > >>Even if you decide to only add this new functionality to FreeBSD 7.x, > >>that's fine with us. Our next release of PC-BSD will be our last based > >>on FreeBSD 6.x before moving to 7. We're committed to shipping with the > >>patch Tijl wrote, since the improvements to Wine with it are night and > >>day. Of course if you roll this into the tree, all the better since I > >>won't have to spend the next 6 months to a year reminding users that > >>when they update world, they have to apply the Wine patch first ;-) > > > >Kris, I support the patch. > > > >That said, have you toyed with implementing this as a kld that > >you can ship with your code? > > -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:49:27 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACC6C16A476; Mon, 20 Aug 2007 18:49:27 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 88F1B13C461; Mon, 20 Aug 2007 18:49:27 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id D85D91A4D90; Mon, 20 Aug 2007 11:47:37 -0700 (PDT) Date: Mon, 20 Aug 2007 11:47:37 -0700 From: Alfred Perlstein To: Matthew Dillon Message-ID: <20070820184737.GJ87451@elvis.mu.org> References: <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> <200708201842.l7KIgAbd040030@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708201842.l7KIgAbd040030@apollo.backplane.com> User-Agent: Mutt/1.4.2.3i X-Mailman-Approved-At: Mon, 20 Aug 2007 18:52:23 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:49:27 -0000 * Matthew Dillon [070820 11:43] wrote: > We have a lwp_kill() system call that sends a signal to a thread within > a process. It turns out to be fairly necessary for any sort of heavily > integrated multi-threaded work. In our case we need it to be able to > issue IPIs (aka SIGUSR1) to cpus within a SMP virtual kernel. > > int lwp_kill(pid_t pid, lwpid_t tid, int sig); > > -Matt It's always bothered me that there wasn't a generation count included in the kill(2) interface. What do you think about that? It would be useful for pidfiles to ensure that a recycled pid doesn't get a program SIGwhatever'd. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:52:49 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F5D616A419; Mon, 20 Aug 2007 18:52:49 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 9179C13C481; Mon, 20 Aug 2007 18:52:48 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l7KIpKca056568; Mon, 20 Aug 2007 12:51:20 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46C9E2A7.8030202@samsco.org> Date: Mon, 20 Aug 2007 12:51:19 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Alfred Perlstein References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> In-Reply-To: <20070820182905.GH87451@elvis.mu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 20 Aug 2007 12:51:20 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org X-Mailman-Approved-At: Mon, 20 Aug 2007 18:56:23 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:52:49 -0000 Alfred Perlstein wrote: > * Scott Long [070820 08:08] wrote: >> Having it as a loadable module that is essentially private to PC-BSD >> (though open source, of course) will lead to questions of why Wine works >> in PC-BSD and not FreeBSD. That's fine if your intention is to create >> a fork of FreeBSD, but I don't know if that's what you really want. >> > > Honestly I think he wants to contribute to the project, but you > won't to punish him for it... I don't know why, it's not like you > but whatever. > > I gave him a way to get around all the bs and continue with life, > no need to guilt trip him on it. > > -Alfred > I'm official out of this discussion. For the record, I have a lot of respect for the PC-BSD guys and I'm very happy that they are doing this work, I was just trying to provide some guidance so that this doesn't turn into a bad hack that we regret years from now. But whatever, it's quite obvious that my input is unwelcome. The subtle and not so subtle attacks from you and Robert really aren't warranted at all. Please drop me from all future emails on this subject. Thanks. Scott From owner-cvs-src@FreeBSD.ORG Mon Aug 20 19:31:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B91D16A46D; Mon, 20 Aug 2007 19:31:21 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 72C0913C4EB; Mon, 20 Aug 2007 19:31:21 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 9E8171A4D8E; Mon, 20 Aug 2007 12:29:31 -0700 (PDT) Date: Mon, 20 Aug 2007 12:29:31 -0700 From: Alfred Perlstein To: "Marc G. Fournier" Message-ID: <20070820192931.GK87451@elvis.mu.org> References: <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> <46C9E2A7.8030202@samsco.org> <1639123F05401A4F2A1C3F33@ganymede.hub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1639123F05401A4F2A1C3F33@ganymede.hub.org> User-Agent: Mutt/1.4.2.3i Cc: wine-freebsd@hub.org, cvs-src@freebsd.org, src-committers@freebsd.org, Xin LI , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 19:31:21 -0000 * The Hermit Hacker [070820 11:59] wrote: > > Just for the record here, I think that Scott did bring up a very valid point in > what he had said ... Kris did mention 'PC-BSD including it even if FreeBSD > didn't' (or words to that effect), and Scott's response was only meant (at > least the way I had read it) to bring us back into focus that we are better to > come up with a BSD solution vs risking further forking of code ... > > Please note that in all of this dicussion, it is only been recent that someone > mentioned a 'kld solution', which I think would be cool ... > > I do think that the 'mud slinging' at Scott was quite out of place ... There was no mud being slung, threatening someone with a fork because they choose to go with a kld until the developers can accept a new call (that exists in just about every other OS)... whatever dude. I suggested the kld by the way. -Alfred From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:56:47 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 231E216A419; Mon, 20 Aug 2007 18:56:47 +0000 (UTC) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.freebsd.org (Postfix) with ESMTP id E6E6D13C4B6; Mon, 20 Aug 2007 18:56:46 +0000 (UTC) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.14.1/8.13.7) with ESMTP id l7KIgB8f040031; Mon, 20 Aug 2007 11:42:11 -0700 (PDT) Received: (from dillon@localhost) by apollo.backplane.com (8.14.1/8.13.4/Submit) id l7KIgAbd040030; Mon, 20 Aug 2007 11:42:10 -0700 (PDT) Date: Mon, 20 Aug 2007 11:42:10 -0700 (PDT) From: Matthew Dillon Message-Id: <200708201842.l7KIgAbd040030@apollo.backplane.com> To: Alfred Perlstein References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> X-Mailman-Approved-At: Mon, 20 Aug 2007 19:51:24 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:56:47 -0000 We have a lwp_kill() system call that sends a signal to a thread within a process. It turns out to be fairly necessary for any sort of heavily integrated multi-threaded work. In our case we need it to be able to issue IPIs (aka SIGUSR1) to cpus within a SMP virtual kernel. int lwp_kill(pid_t pid, lwpid_t tid, int sig); -Matt From owner-cvs-src@FreeBSD.ORG Mon Aug 20 18:57:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72D9516A420; Mon, 20 Aug 2007 18:57:55 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.freebsd.org (Postfix) with ESMTP id 2A1E813C4A8; Mon, 20 Aug 2007 18:57:54 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.0.61] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id l7KIuJpq069325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Aug 2007 11:56:20 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <46C9E39F.8010009@FreeBSD.org> Date: Mon, 20 Aug 2007 11:55:27 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Scott Long References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <46C863C5.6090906@comcast.net><20070820093009.GE87451@elvis.mu.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> In-Reply-To: <46C9AE64.50705@samsco.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 20 Aug 2007 19:51:24 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 18:57:55 -0000 Scott Long wrote: > Having it as a loadable module that is essentially private to PC-BSD > (though open source, of course) will lead to questions of why Wine works > in PC-BSD and not FreeBSD. That's fine if your intention is to create > a fork of FreeBSD, but I don't know if that's what you really want. There is no need for it to be private - we can just easily have it in the same port or in separate port (wine_kmod?) and get wine RUN_DEPEND on it. We have been using this scheme with VmWare for ages now and everybody seems to be happy. Indeed, as Robert has pointed out, wine is special in its needs to access some kernel internals to emulate sufficiently different threading model. Those internals are not and probably will never be exposed via POSIX layer, so that loadable module approach makes lot of sense. -Maxim From owner-cvs-src@FreeBSD.ORG Mon Aug 20 19:01:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D51616A417; Mon, 20 Aug 2007 19:01:31 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from hub.org (hub.org [200.46.204.220]) by mx1.freebsd.org (Postfix) with ESMTP id 1F17F13C4D3; Mon, 20 Aug 2007 19:01:31 +0000 (UTC) (envelope-from scrappy@hub.org) Received: from localhost (maia-3.hub.org [200.46.204.184]) by hub.org (Postfix) with ESMTP id B893DB4703D; Mon, 20 Aug 2007 16:01:30 -0300 (ADT) Received: from hub.org ([200.46.204.220]) by localhost (mx1.hub.org [200.46.204.184]) (amavisd-maia, port 10024) with ESMTP id 69386-10; Mon, 20 Aug 2007 16:01:22 -0300 (ADT) Received: from fserv.hub.org (blk-89-241-126.eastlink.ca [24.89.241.126]) by hub.org (Postfix) with ESMTP id B4C83B47032; Mon, 20 Aug 2007 16:01:25 -0300 (ADT) Received: from [192.168.1.2] (unknown [192.168.1.2]) by fserv.hub.org (Postfix) with ESMTP id 0DDB6E6651; Mon, 20 Aug 2007 16:01:27 -0300 (ADT) Date: Mon, 20 Aug 2007 16:01:09 -0300 From: "Marc G. Fournier" To: Scott Long , Alfred Perlstein Message-ID: <1639123F05401A4F2A1C3F33@ganymede.hub.org> In-Reply-To: <46C9E2A7.8030202@samsco.org> References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C4FD02.3090708@freebsd.org> <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> <46C9E2A7.8030202@samsco.org> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Mailman-Approved-At: Mon, 20 Aug 2007 19:51:24 +0000 Cc: wine-freebsd@hub.org, Kris Moore , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 19:01:31 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Monday, August 20, 2007 12:51:19 -0600 Scott Long wrote: > I'm official out of this discussion. For the record, I have a lot of respect > for the PC-BSD guys and I'm very happy that they are doing this > work, I was just trying to provide some guidance so that this doesn't > turn into a bad hack that we regret years from now. But whatever, it's > quite obvious that my input is unwelcome. The subtle and not so subtle > attacks from you and Robert really aren't warranted at all. Please drop > me from all future emails on this subject. Thanks. Just for the record here, I think that Scott did bring up a very valid point in what he had said ... Kris did mention 'PC-BSD including it even if FreeBSD didn't' (or words to that effect), and Scott's response was only meant (at least the way I had read it) to bring us back into focus that we are better to come up with a BSD solution vs risking further forking of code ... Please note that in all of this dicussion, it is only been recent that someone mentioned a 'kld solution', which I think would be cool ... I do think that the 'mud slinging' at Scott was quite out of place ... - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGyeT14QvfyHIvDvMRAtTfAJ0cZXBXk9QQaj0v04HKRr0+8qjygQCgogpi Zk5Vhl+4STblk/NaMZ8Vs4k= =tOSd -----END PGP SIGNATURE----- From owner-cvs-src@FreeBSD.ORG Mon Aug 20 19:39:04 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6262116A421; Mon, 20 Aug 2007 19:39:04 +0000 (UTC) (envelope-from matt@ixsystems.com) Received: from mail.iXsystems.com (newknight.ixsystems.net [206.40.55.70]) by mx1.freebsd.org (Postfix) with ESMTP id BA37D13C491; Mon, 20 Aug 2007 19:39:03 +0000 (UTC) (envelope-from matt@ixsystems.com) Received: from localhost (localhost [127.0.0.1]) by mail.iXsystems.com (Postfix) with ESMTP id 14C86BE63; Mon, 20 Aug 2007 12:07:38 -0700 (PDT) Received: from mail.iXsystems.com ([127.0.0.1]) by localhost (mail.ixsystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 92894-02; Mon, 20 Aug 2007 12:07:19 -0700 (PDT) Received: from client-173.nat.ixsystems.net (unknown [192.168.1.173]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTP id 8DEEEBDDE; Mon, 20 Aug 2007 12:07:19 -0700 (PDT) From: Matt Olander Organization: iXsystems To: "Marc G. Fournier" Date: Mon, 20 Aug 2007 12:07:18 -0700 User-Agent: KMail/1.9.5 References: <200708160526.l7G5Qg0b008022@repoman.freebsd.org> <46C9E2A7.8030202@samsco.org> <1639123F05401A4F2A1C3F33@ganymede.hub.org> In-Reply-To: <1639123F05401A4F2A1C3F33@ganymede.hub.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200708201207.19122.matt@ixsystems.com> X-Virus-Scanned: Maia Mailguard X-Mailman-Approved-At: Mon, 20 Aug 2007 19:51:24 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, Alfred Perlstein , cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 19:39:04 -0000 On Monday 20 August 2007 12:01 pm, Marc G. Fournier wrote: > --On Monday, August 20, 2007 12:51:19 -0600 Scott Long > > wrote: > > I'm official out of this discussion. For the record, I have a lot of > > respect for the PC-BSD guys and I'm very happy that they are doing this > > work, I was just trying to provide some guidance so that this doesn't > > turn into a bad hack that we regret years from now. But whatever, it's > > quite obvious that my input is unwelcome. The subtle and not so subtle > > attacks from you and Robert really aren't warranted at all. Please drop > > me from all future emails on this subject. Thanks. > > Just for the record here, I think that Scott did bring up a very valid > point in what he had said ... Kris did mention 'PC-BSD including it even = if > FreeBSD didn't' (or words to that effect), and Scott's response was only > meant (at least the way I had read it) to bring us back into focus that we > are better to come up with a BSD solution vs risking further forking of > code ... > > Please note that in all of this dicussion, it is only been recent that > someone mentioned a 'kld solution', which I think would be cool ... PC-BSD definitely doesn't want to fork. Kris just meant that he'd include t= he=20 patches until a better solution, such as a kld in -CURRENT, was found. =2Dmatt =2D-=20 Matt Olander CTO, iXsystems - "Servers for Open Source" =A0http://www.iXsystems.com Public Relations, The FreeBSD Project =A0 =A0 =A0 =A0 http://www.FreeBSD.org BSD on the Desktop! =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= http://www.pcbsd.org Phone: (408)943-4100 ext. 113 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Fax: = (408)943-4101 From owner-cvs-src@FreeBSD.ORG Mon Aug 20 21:47:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1132F16A419; Mon, 20 Aug 2007 21:47:50 +0000 (UTC) (envelope-from davidch@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0268C13C457; Mon, 20 Aug 2007 21:47:50 +0000 (UTC) (envelope-from davidch@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7KLln0v001504; Mon, 20 Aug 2007 21:47:49 GMT (envelope-from davidch@repoman.freebsd.org) Received: (from davidch@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7KLlnuH001503; Mon, 20 Aug 2007 21:47:49 GMT (envelope-from davidch) Message-Id: <200708202147.l7KLlnuH001503@repoman.freebsd.org> From: David Christensen Date: Mon, 20 Aug 2007 21:47:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 21:47:50 -0000 davidch 2007-08-20 21:47:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bce if_bce.c if_bcereg.h Log: - Fixed a problem that would cause kernel panics and "bce0: discard frame .." errors (especially when jumbo frames are enabled or in low memory systems) because the RX chain was corrupted when an mbuf was mapped to an unexpected number of buffers. - Fixed a problem that would cause kernel panics when an excessively fragmented TX mbuf couldn't be defragmented and was released by bce_tx_encap(). Revision Changes Path 1.2.2.20 +233 -115 src/sys/dev/bce/if_bce.c 1.1.2.8 +14 -1 src/sys/dev/bce/if_bcereg.h From owner-cvs-src@FreeBSD.ORG Tue Aug 21 04:59:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C424F16A417; Tue, 21 Aug 2007 04:59:34 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B7C2B13C457; Tue, 21 Aug 2007 04:59:34 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7L4xYAu053651; Tue, 21 Aug 2007 04:59:34 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7L4xYWe053650; Tue, 21 Aug 2007 04:59:34 GMT (envelope-from alc) Message-Id: <200708210459.l7L4xYWe053650@repoman.freebsd.org> From: Alan Cox Date: Tue, 21 Aug 2007 04:59:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 04:59:34 -0000 alc 2007-08-21 04:59:34 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: In general, when we map a page into the kernel's address space, we no longer create a pv entry for that mapping. (The two exceptions are mappings into the kernel's exec and pipe submaps.) Consequently, there is no reason for get_pv_entry() to dig deep into the free page queues, i.e., use VM_ALLOC_SYSTEM, by default. This revision changes get_pv_entry() to use VM_ALLOC_NORMAL by default, i.e., before calling pmap_collect() to reclaim pv entries. Approved by: re (kensmith) Revision Changes Path 1.590 +3 -4 src/sys/amd64/amd64/pmap.c 1.594 +3 -4 src/sys/i386/i386/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Aug 21 08:58:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 158D416A41A; Tue, 21 Aug 2007 08:58:23 +0000 (UTC) (envelope-from hm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E2C1213C47E; Tue, 21 Aug 2007 08:58:22 +0000 (UTC) (envelope-from hm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7L8wMww082823; Tue, 21 Aug 2007 08:58:22 GMT (envelope-from hm@repoman.freebsd.org) Received: (from hm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7L8wMU3082822; Tue, 21 Aug 2007 08:58:22 GMT (envelope-from hm) Message-Id: <200708210858.l7L8wMU3082822@repoman.freebsd.org> From: Hellmuth Michaelis Date: Tue, 21 Aug 2007 08:58:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/modules/if_tap Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 08:58:23 -0000 hm 2007-08-21 08:58:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/modules/if_tap Makefile Log: PR: kern/115414 Submitted by: Eugene Grosbein The fix for PR kern/111480 was incomplete, "make MODULES_WITH_WORLD=true buildworld" stopped with an error. Revision Changes Path 1.4.2.2 +4 -1 src/sys/modules/if_tap/Makefile From owner-cvs-src@FreeBSD.ORG Tue Aug 21 11:43:16 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A9B716A41A; Tue, 21 Aug 2007 11:43:16 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id AC79613C4DE; Tue, 21 Aug 2007 11:43:15 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 5377145CD9; Tue, 21 Aug 2007 13:43:13 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id BD4474569A; Tue, 21 Aug 2007 13:43:04 +0200 (CEST) Date: Tue, 21 Aug 2007 13:42:07 +0200 From: Pawel Jakub Dawidek To: Alfred Perlstein Message-ID: <20070821114207.GC1132@garage.freebsd.pl> References: <200708182118.37998.tijl@ulyssis.org> <20070818204223.D1234@fledge.watson.org> <46C7A9A4.5090404@samsco.org> <20070819095302.D66918@fledge.watson.org> <222044094-1187603330-cardhu_decombobulator_blackberry.rim.net-1638751523-@bxe027.bisx.prod.on.blackberry> <46C9AE64.50705@samsco.org> <20070820182905.GH87451@elvis.mu.org> <200708201842.l7KIgAbd040030@apollo.backplane.com> <20070820184737.GJ87451@elvis.mu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HG+GLK89HZ1zG0kk" Content-Disposition: inline In-Reply-To: <20070820184737.GJ87451@elvis.mu.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 X-Mailman-Approved-At: Tue, 21 Aug 2007 11:45:36 +0000 Cc: wine-freebsd@hub.org, Kris Moore , Matthew Dillon , src-committers@freebsd.org, cvs-src@freebsd.org, Scott Long , cvs-all@freebsd.org, Daniel Eischen , Robert Watson , David Xu , Tijl Coosemans , Xin LI Subject: Re: cvs commit: src/sys/kern kern_thr.c syscalls.master src/sys/sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 11:43:16 -0000 --HG+GLK89HZ1zG0kk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 20, 2007 at 11:47:37AM -0700, Alfred Perlstein wrote: > * Matthew Dillon [070820 11:43] wrote: > > We have a lwp_kill() system call that sends a signal to a thread wi= thin > > a process. It turns out to be fairly necessary for any sort of hea= vily > > integrated multi-threaded work. In our case we need it to be able = to > > issue IPIs (aka SIGUSR1) to cpus within a SMP virtual kernel. > >=20 > > int lwp_kill(pid_t pid, lwpid_t tid, int sig); > >=20 > > -Matt >=20 > It's always bothered me that there wasn't a generation count > included in the kill(2) interface. >=20 > What do you think about that? >=20 > It would be useful for pidfiles to ensure that a recycled pid > doesn't get a program SIGwhatever'd. I worked on process generation number when I was working on pidfile(3) API. We had discussion about this and consensus was (AFAIR) that we don't need that, because for purpose of pidfile(3) we can use flock(2), which is enough (modulo file systems that doesn't support it). The probably incomplete and never tested patch you can find here: http://people.freebsd.org/~pjd/patches/procbid.patch (I called it process born ID.) --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --HG+GLK89HZ1zG0kk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGys+PForvXbEpPzQRAht9AKCEmp66NkVksmlZI5AfidLufha5ZACggdmZ VpThYhiuJlnXyWeDPwDRihI= =teKn -----END PGP SIGNATURE----- --HG+GLK89HZ1zG0kk-- From owner-cvs-src@FreeBSD.ORG Tue Aug 21 12:53:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC67316A46E; Tue, 21 Aug 2007 12:53:02 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A830613C45D; Tue, 21 Aug 2007 12:53:02 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7LCqvVe012834; Tue, 21 Aug 2007 12:53:02 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7LCqvBg012831; Tue, 21 Aug 2007 12:52:57 GMT (envelope-from kib) Message-Id: <200708211252.l7LCqvBg012831@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 21 Aug 2007 12:52:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/drm i915_dma.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 12:53:03 -0000 kib 2007-08-21 12:52:57 UTC FreeBSD src repository Modified files: sys/dev/drm i915_dma.c Log: Properly initialize the dev_priv before calling the i915_dma_cleanup(). This fixes my rev. 1.5. Reviewed by: anholt Approved by: re (kensmith) MFC after: 2 weeks Revision Changes Path 1.6 +2 -3 src/sys/dev/drm/i915_dma.c From owner-cvs-src@FreeBSD.ORG Tue Aug 21 13:20:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 262C716A41B; Tue, 21 Aug 2007 13:20:14 +0000 (UTC) (envelope-from sanpei@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F1F3613C442; Tue, 21 Aug 2007 13:20:13 +0000 (UTC) (envelope-from sanpei@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7LDKDWT015846; Tue, 21 Aug 2007 13:20:13 GMT (envelope-from sanpei@repoman.freebsd.org) Received: (from sanpei@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7LDKDFF015845; Tue, 21 Aug 2007 13:20:13 GMT (envelope-from sanpei) Message-Id: <200708211320.l7LDKDFF015845@repoman.freebsd.org> From: MIHIRA Sanpei Yoshiro Date: Tue, 21 Aug 2007 13:20:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 umodem.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 13:20:14 -0000 sanpei 2007-08-21 13:20:13 UTC FreeBSD src repository Modified files: share/man/man4 umodem.4 Log: Add a HARDWARE section which lists supported devices. Kyocera AH-K3001V Mobile Phone(WILLCOM) Kyocera WX320K Mobile Phone(WILLCOM) Approved by: re (bmah) Revision Changes Path 1.10 +4 -0 src/share/man/man4/umodem.4 From owner-cvs-src@FreeBSD.ORG Tue Aug 21 16:33:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2304516A418; Tue, 21 Aug 2007 16:33:56 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EE5A913C480; Tue, 21 Aug 2007 16:33:55 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7LGXt7I050274; Tue, 21 Aug 2007 16:33:55 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7LGXtS2050273; Tue, 21 Aug 2007 16:33:55 GMT (envelope-from emaste) Message-Id: <200708211633.l7LGXtS2050273@repoman.freebsd.org> From: Ed Maste Date: Tue, 21 Aug 2007 16:33:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/aac aac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 16:33:56 -0000 emaste 2007-08-21 16:33:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/aac aac.c Log: MFC aac.c 1.119: The return value of aac_alloc_command() was misinterpreted in aac_ioctl_event(). Once triggered this would leak away all available commands and starve the rest of the driver. Revision Changes Path 1.109.2.6 +1 -1 src/sys/dev/aac/aac.c From owner-cvs-src@FreeBSD.ORG Tue Aug 21 20:31:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48DBB16A419; Tue, 21 Aug 2007 20:31:50 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 216BE13C46B; Tue, 21 Aug 2007 20:31:50 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7LKVoIq078781; Tue, 21 Aug 2007 20:31:50 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7LKVnvJ078780; Tue, 21 Aug 2007 20:31:49 GMT (envelope-from emaste) Message-Id: <200708212031.l7LKVnvJ078780@repoman.freebsd.org> From: Ed Maste Date: Tue, 21 Aug 2007 20:31:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/aac aac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 20:31:50 -0000 emaste 2007-08-21 20:31:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/aac aac.c Log: MFC aac.c 1.118: Rearrange locking in the alloc_commands and ioctl paths to avoid problems. Revision Changes Path 1.109.2.7 +9 -5 src/sys/dev/aac/aac.c From owner-cvs-src@FreeBSD.ORG Wed Aug 22 01:56:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91E8616A41A; Wed, 22 Aug 2007 01:56:36 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6C06A13C4A7; Wed, 22 Aug 2007 01:56:36 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7M1uama026003; Wed, 22 Aug 2007 01:56:36 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7M1uaEv026002; Wed, 22 Aug 2007 01:56:36 GMT (envelope-from davidxu) Message-Id: <200708220156.l7M1uaEv026002@repoman.freebsd.org> From: David Xu Date: Wed, 22 Aug 2007 01:56:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/sys Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 01:56:36 -0000 davidxu 2007-08-22 01:56:36 UTC FreeBSD src repository Modified files: lib/libc/sys Symbol.map Log: Add thr_kill2 syscall. Submitted by: Tijl Coosemans tijl at ulyssis dot org Approved by: re (kensmith) Revision Changes Path 1.9 +3 -0 src/lib/libc/sys/Symbol.map From owner-cvs-src@FreeBSD.ORG Wed Aug 22 04:26:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF32116A417; Wed, 22 Aug 2007 04:26:08 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 88A1E13C457; Wed, 22 Aug 2007 04:26:08 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7M4Q8LX038848; Wed, 22 Aug 2007 04:26:08 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7M4Q8mZ038847; Wed, 22 Aug 2007 04:26:08 GMT (envelope-from jkoshy) Message-Id: <200708220426.l7M4Q8mZ038847@repoman.freebsd.org> From: Joseph Koshy Date: Wed, 22 Aug 2007 04:26:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/include asm.h asmacros.h src/sys/amd64/include asm.h asmacros.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 04:26:08 -0000 jkoshy 2007-08-22 04:26:07 UTC FreeBSD src repository Modified files: sys/i386/include asm.h asmacros.h sys/amd64/include asm.h asmacros.h Log: Define an END() macro for use in i386 and amd64 assembly code, akin to the one available on the ia64, sparc64, and sun4v architectures. Approved by: re (kensmith) Revision Changes Path 1.18 +2 -0 src/sys/amd64/include/asm.h 1.33 +2 -0 src/sys/amd64/include/asmacros.h 1.14 +1 -0 src/sys/i386/include/asm.h 1.30 +2 -0 src/sys/i386/include/asmacros.h From owner-cvs-src@FreeBSD.ORG Wed Aug 22 04:55:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 105D516A41A; Wed, 22 Aug 2007 04:55:06 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DF50E13C459; Wed, 22 Aug 2007 04:55:05 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7M4t5Z0049018; Wed, 22 Aug 2007 04:55:05 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7M4t5SI049017; Wed, 22 Aug 2007 04:55:05 GMT (envelope-from njl) Message-Id: <200708220455.l7M4t5SI049017@repoman.freebsd.org> From: Nate Lawson Date: Wed, 22 Aug 2007 04:55:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_cpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 04:55:06 -0000 njl 2007-08-22 04:55:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_cpu.c Log: MFC 1.26 and 1.27: use proper loop variables and sched_bind() behavior Revision Changes Path 1.14.2.5 +19 -29 src/sys/kern/kern_cpu.c From owner-cvs-src@FreeBSD.ORG Wed Aug 22 05:06:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84DC916A417; Wed, 22 Aug 2007 05:06:15 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5E73C13C467; Wed, 22 Aug 2007 05:06:15 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7M56F4U050855; Wed, 22 Aug 2007 05:06:15 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7M56FBY050854; Wed, 22 Aug 2007 05:06:15 GMT (envelope-from jkoshy) Message-Id: <200708220506.l7M56FBY050854@repoman.freebsd.org> From: Joseph Koshy Date: Wed, 22 Aug 2007 05:06:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 support.s swtch.s src/sys/amd64/amd64 cpu_switch.S support.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 05:06:15 -0000 jkoshy 2007-08-22 05:06:15 UTC FreeBSD src repository Modified files: sys/i386/i386 support.s swtch.s sys/amd64/amd64 cpu_switch.S support.S Log: Assign sizes to assembly language support functions. Approved by: re (kensmith) Revision Changes Path 1.160 +4 -1 src/sys/amd64/amd64/cpu_switch.S 1.128 +30 -3 src/sys/amd64/amd64/support.S 1.119 +40 -4 src/sys/i386/i386/support.s 1.156 +3 -0 src/sys/i386/i386/swtch.s From owner-cvs-src@FreeBSD.ORG Wed Aug 22 13:22:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A46016A418; Wed, 22 Aug 2007 13:22:13 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3940E13C46E; Wed, 22 Aug 2007 13:22:13 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MDMD3b017230; Wed, 22 Aug 2007 13:22:13 GMT (envelope-from gallatin@repoman.freebsd.org) Received: (from gallatin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MDMDVr017229; Wed, 22 Aug 2007 13:22:13 GMT (envelope-from gallatin) Message-Id: <200708221322.l7MDMDVr017229@repoman.freebsd.org> From: Andrew Gallatin Date: Wed, 22 Aug 2007 13:22:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h if_mxge.c if_mxge_var.h mxge_mcp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 13:22:13 -0000 gallatin 2007-08-22 13:22:12 UTC FreeBSD src repository Modified files: sys/dev/mxge eth_z8e.h ethp_z8e.h if_mxge.c if_mxge_var.h mxge_mcp.h Log: - Fix a bug which could cause a panic when enabling LRO on an down mxge interface - Fix a bug where mxge reported the link state as active when it wasn't (after ifconfig down). - Prevent spurious watchdog resets when link partner is not consuming - Add support for CX4 and popular XFP media detection - Update the firmware and associated header files to 1.4.25 Approved by: re (kensmith) Revision Changes Path 1.2 +12731 -12338 src/sys/dev/mxge/eth_z8e.h 1.2 +12807 -12399 src/sys/dev/mxge/ethp_z8e.h 1.41 +174 -15 src/sys/dev/mxge/if_mxge.c 1.15 +10 -0 src/sys/dev/mxge/if_mxge_var.h 1.8 +91 -3 src/sys/dev/mxge/mxge_mcp.h From owner-cvs-src@FreeBSD.ORG Wed Aug 22 14:46:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D7D416A41A; Wed, 22 Aug 2007 14:46:29 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0363E13C467; Wed, 22 Aug 2007 14:46:29 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MEkSdM024135; Wed, 22 Aug 2007 14:46:28 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MEkSDT024133; Wed, 22 Aug 2007 14:46:28 GMT (envelope-from emaste) Message-Id: <200708221446.l7MEkSDT024133@repoman.freebsd.org> From: Ed Maste Date: Wed, 22 Aug 2007 14:46:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/aac aac_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 14:46:29 -0000 emaste 2007-08-22 14:46:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/aac aac_cam.c Log: MFC aac_cam.c 1.26: Add a missing mutex unlock to an error path. Submitted by: Yuxiang Luo PR: 107943 Revision Changes Path 1.20.2.4 +1 -0 src/sys/dev/aac/aac_cam.c From owner-cvs-src@FreeBSD.ORG Wed Aug 22 18:02:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6E5616A41A; Wed, 22 Aug 2007 18:02:01 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9CC0D13C465; Wed, 22 Aug 2007 18:02:01 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MI21xn050847; Wed, 22 Aug 2007 18:02:01 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MI21t4050846; Wed, 22 Aug 2007 18:02:01 GMT (envelope-from gabor) Message-Id: <200708221802.l7MI21t4050846@repoman.freebsd.org> From: Gabor Kovesdan Date: Wed, 22 Aug 2007 18:02:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 nfe.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 18:02:01 -0000 gabor 2007-08-22 18:02:01 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 nfe.4 Log: - Fix a copy-paste bug in the list of supported chips PR: docs/115151 Submitted by: O. Hartmann Approved by: re (bmah), keramida (mentor) Revision Changes Path 1.8 +2 -2 src/share/man/man4/nfe.4 From owner-cvs-src@FreeBSD.ORG Wed Aug 22 18:04:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 382AC16A419; Wed, 22 Aug 2007 18:04:09 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0E8E113C46B; Wed, 22 Aug 2007 18:04:09 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MI48bY052168; Wed, 22 Aug 2007 18:04:08 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MI485k052167; Wed, 22 Aug 2007 18:04:08 GMT (envelope-from gabor) Message-Id: <200708221804.l7MI485k052167@repoman.freebsd.org> From: Gabor Kovesdan Date: Wed, 22 Aug 2007 18:04:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 msdosfs.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 18:04:09 -0000 gabor 2007-08-22 18:04:08 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man5 msdosfs.5 Log: - Use mount -t msdosfs instead of mount_msdosfs PR: docs/115571 Submitted by: rodrigc Approved by: re (bmah), keramida (mentor) MFC after: 1 week Revision Changes Path 1.6 +2 -2 src/share/man/man5/msdosfs.5 From owner-cvs-src@FreeBSD.ORG Wed Aug 22 18:07:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95B1C16A417; Wed, 22 Aug 2007 18:07:42 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6B30A13C45D; Wed, 22 Aug 2007 18:07:42 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MI7gF6052346; Wed, 22 Aug 2007 18:07:42 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MI7gZH052345; Wed, 22 Aug 2007 18:07:42 GMT (envelope-from gabor) Message-Id: <200708221807.l7MI7gZH052345@repoman.freebsd.org> From: Gabor Kovesdan Date: Wed, 22 Aug 2007 18:07:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man7 ports.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 18:07:42 -0000 gabor 2007-08-22 18:07:42 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man7 ports.7 Log: - Fix origin of the portcheckout port as we have it in the port-mgmt category now PR: docs/115193 Submitted by: Tomas Mozes Approved by: re (bmah), keramida (mentor) MFC after: 0 days Revision Changes Path 1.61 +2 -2 src/share/man/man7/ports.7 From owner-cvs-src@FreeBSD.ORG Wed Aug 22 18:11:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EAA9916A417; Wed, 22 Aug 2007 18:11:26 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C131613C46C; Wed, 22 Aug 2007 18:11:26 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MIBQ9x052686; Wed, 22 Aug 2007 18:11:26 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MIBQNp052685; Wed, 22 Aug 2007 18:11:26 GMT (envelope-from gabor) Message-Id: <200708221811.l7MIBQNp052685@repoman.freebsd.org> From: Gabor Kovesdan Date: Wed, 22 Aug 2007 18:11:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man7 ports.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 18:11:27 -0000 gabor 2007-08-22 18:11:26 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man7 ports.7 Log: MFC: r1.61 Approved by: keramida (mentor) Revision Changes Path 1.50.2.6 +3 -5 src/share/man/man7/ports.7 From owner-cvs-src@FreeBSD.ORG Wed Aug 22 18:45:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55BFA16A418; Wed, 22 Aug 2007 18:45:01 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3E47D13C46A; Wed, 22 Aug 2007 18:45:01 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MIj1bp057294; Wed, 22 Aug 2007 18:45:01 GMT (envelope-from remko@repoman.freebsd.org) Received: (from remko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MIj19b057279; Wed, 22 Aug 2007 18:45:01 GMT (envelope-from remko) Message-Id: <200708221845.l7MIj19b057279@repoman.freebsd.org> From: Remko Lodder Date: Wed, 22 Aug 2007 18:45:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/tinybsd tinybsd src/tools/tools/tinybsd/conf/bridge TINYBSD src/tools/tools/tinybsd/conf/default TINYBSD src/tools/tools/tinybsd/conf/firewall TINYBSD src/tools/tools/tinybsd/conf/minimal TINYBSD src/tools/tools/tinybsd/conf/vpn TINYBSD ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 18:45:01 -0000 remko 2007-08-22 18:45:00 UTC FreeBSD src repository Modified files: tools/tools/tinybsd tinybsd tools/tools/tinybsd/conf/bridge TINYBSD tools/tools/tinybsd/conf/default TINYBSD tools/tools/tinybsd/conf/firewall TINYBSD tools/tools/tinybsd/conf/minimal TINYBSD tools/tools/tinybsd/conf/vpn TINYBSD tools/tools/tinybsd/conf/wireless TINYBSD tools/tools/tinybsd/conf/wrap TINYBSD Log: Bring in two fixes for TinyBSD: - Add the bind mtree to the TinyBSD build so that files can be installed there (else the build fails) - Change GEOM_GPT to GEOM_PART_GPT since that had been renamed in current. The kernel configuration provided by TinyBSD will not build without these changes. PR: misc/115484 PR: misc/115405 Submitted by: Richard Arends Approved by: re (bmah) Approved by: imp (mentor) Revision Changes Path 1.3 +1 -1 src/tools/tools/tinybsd/conf/bridge/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/default/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/firewall/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/minimal/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/vpn/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/wireless/TINYBSD 1.3 +1 -1 src/tools/tools/tinybsd/conf/wrap/TINYBSD 1.7 +1 -0 src/tools/tools/tinybsd/tinybsd From owner-cvs-src@FreeBSD.ORG Wed Aug 22 20:28:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA9B316A418; Wed, 22 Aug 2007 20:28:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C291D13C45B; Wed, 22 Aug 2007 20:28:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MKSE6t069958; Wed, 22 Aug 2007 20:28:14 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MKSENA069957; Wed, 22 Aug 2007 20:28:14 GMT (envelope-from jhb) Message-Id: <200708222028.l7MKSENA069957@repoman.freebsd.org> From: John Baldwin Date: Wed, 22 Aug 2007 20:28:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_amd64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 20:28:15 -0000 jhb 2007-08-22 20:28:14 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb trgt_amd64.c Log: NMIs now come from 'nmi_calltrap' rather than 'calltrap', so teach 'kgdb' to treat the frame under 'nmi_calltrap' as a trapframe. MFC after: 3 days Approved by: re (bmah) Revision Changes Path 1.8 +1 -0 src/gnu/usr.bin/gdb/kgdb/trgt_amd64.c From owner-cvs-src@FreeBSD.ORG Wed Aug 22 21:08:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E69E416A418; Wed, 22 Aug 2007 21:08:30 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BE4C213C459; Wed, 22 Aug 2007 21:08:30 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ML8UHo082229; Wed, 22 Aug 2007 21:08:30 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ML8UKY082228; Wed, 22 Aug 2007 21:08:30 GMT (envelope-from emaste) Message-Id: <200708222108.l7ML8UKY082228@repoman.freebsd.org> From: Ed Maste Date: Wed, 22 Aug 2007 21:08:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/crypto/sha2 sha2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 21:08:31 -0000 emaste 2007-08-22 21:08:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/crypto/sha2 sha2.c Log: MFC elimination of compiler warnings: sha2.c 1.8: GCC 3.4.6 gets confused on this file and produces bogus warning. Shut it up. sha2.c 1.9: Initialize T1 to silent gcc warning. Revision Changes Path 1.7.4.1 +1 -1 src/sys/crypto/sha2/sha2.c From owner-cvs-src@FreeBSD.ORG Wed Aug 22 21:17:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FB0116A419; Wed, 22 Aug 2007 21:17:45 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DBFF713C457; Wed, 22 Aug 2007 21:17:44 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7MLHiYC082842; Wed, 22 Aug 2007 21:17:44 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7MLHiPR082841; Wed, 22 Aug 2007 21:17:44 GMT (envelope-from emaste) Message-Id: <200708222117.l7MLHiPR082841@repoman.freebsd.org> From: Ed Maste Date: Wed, 22 Aug 2007 21:17:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/crypto/sha2 sha2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 21:17:45 -0000 emaste 2007-08-22 21:17:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/crypto/sha2 sha2.c Log: MFC sha2.c 1.9: Initialize T1 to silent gcc warning. Revision Changes Path 1.7.10.2 +1 -1 src/sys/crypto/sha2/sha2.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 05:09:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3574B16A41B; Thu, 23 Aug 2007 05:09:32 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0EF6313C46A; Thu, 23 Aug 2007 05:09:32 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N59V2F048342; Thu, 23 Aug 2007 05:09:31 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N59VCi048341; Thu, 23 Aug 2007 05:09:31 GMT (envelope-from yar) Message-Id: <200708230509.l7N59VCi048341@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 23 Aug 2007 05:09:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 05:09:32 -0000 yar 2007-08-23 05:09:31 UTC FreeBSD src repository Modified files: lib/libc/gen fts-compat.c fts-compat.h Log: Forced commit to note repo-copy: These files have been repo-copied from src/include/fts.h and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD compatible versions of fts(3) functions to be preserved through libc symbol versioning while the default versions undergo ABI-breaking extension to support big file trees. Approved by: re (kensmith) Revision Changes Path 1.29 +0 -0 src/lib/libc/gen/fts-compat.c 1.12 +0 -0 src/lib/libc/gen/fts-compat.h From owner-cvs-src@FreeBSD.ORG Thu Aug 23 08:19:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C19416A41A; Thu, 23 Aug 2007 08:19:10 +0000 (UTC) (envelope-from syrinx@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5A4A413C465; Thu, 23 Aug 2007 08:19:10 +0000 (UTC) (envelope-from syrinx@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N8JASJ063217; Thu, 23 Aug 2007 08:19:10 GMT (envelope-from syrinx@repoman.freebsd.org) Received: (from syrinx@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N8JAQZ063216; Thu, 23 Aug 2007 08:19:10 GMT (envelope-from syrinx) Message-Id: <200708230819.l7N8JAQZ063216@repoman.freebsd.org> From: Shteryana Shopova Date: Thu, 23 Aug 2007 08:19:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/bsnmpd/modules/snmp_bridge BEGEMOT-BRIDGE-MIB.txt bridge_port.c bridge_snmp.h bridge_sys.c bridge_tree.def snmp_bridge.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 08:19:10 -0000 syrinx 2007-08-23 08:19:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/bsnmpd/modules/snmp_bridge BEGEMOT-BRIDGE-MIB.txt bridge_port.c bridge_snmp.h bridge_sys.c bridge_tree.def snmp_bridge.3 Log: MFC: src/usr.sbin/bsnmpd/modules/snmp_bridge/BEGEMOT-BRIDGE-MIB.txt, Revision 1.3 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_port.c, Revision 1.6 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_snmp.h, Revision 1.5 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_sys.c, Revision 1.7 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_tree.def, Revision 1.3 src/usr.sbin/bsnmpd/modules/snmp_bridge/snmp_bridge.3, Revision 1.4 Keep the snmp_bridge(3) module up to date with if_bridge(4) and add an object to control the value of the new 'PRIVATE' bridge members' flag. While here, remove stale '__unused' compiler directives. Reviewed by: bz Approved by: bz (mentor) Revision Changes Path 1.2.2.2 +18 -2 src/usr.sbin/bsnmpd/modules/snmp_bridge/BEGEMOT-BRIDGE-MIB.txt 1.5.2.2 +23 -0 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_port.c 1.4.2.2 +5 -0 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_snmp.h 1.6.2.2 +57 -8 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_sys.c 1.2.2.2 +1 -0 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_tree.def 1.2.2.2 +5 -2 src/usr.sbin/bsnmpd/modules/snmp_bridge/snmp_bridge.3 From owner-cvs-src@FreeBSD.ORG Thu Aug 23 09:30:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE35F16A417; Thu, 23 Aug 2007 09:30:58 +0000 (UTC) (envelope-from dhartmei@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DD5FC13C459; Thu, 23 Aug 2007 09:30:58 +0000 (UTC) (envelope-from dhartmei@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N9Uww1078622; Thu, 23 Aug 2007 09:30:58 GMT (envelope-from dhartmei@repoman.freebsd.org) Received: (from dhartmei@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N9Uwqk078621; Thu, 23 Aug 2007 09:30:58 GMT (envelope-from dhartmei) Message-Id: <200708230930.l7N9Uwqk078621@repoman.freebsd.org> From: Daniel Hartmeier Date: Thu, 23 Aug 2007 09:30:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/pf/net pf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 09:30:59 -0000 dhartmei 2007-08-23 09:30:58 UTC FreeBSD src repository Modified files: sys/contrib/pf/net pf.c Log: When checking the sequence number of a TCP header embedded in an ICMP error message, do not access th_flags. The field is beyond the first eight bytes of the header that are required to be present and were pulled up in the mbuf. A random value of th_flags can have TH_SYN set, which made the sequence number comparison not apply the window scaling factor, which led to legitimate ICMP(v6) packets getting blocked with "BAD ICMP" debug log messages (if enabled with pfctl -xm), thus breaking PMTU discovery. Triggering the bug requires TCP window scaling to be enabled (sysctl net.inet.tcp.rfc1323, enabled by default) on both end- points of the TCP connection. Large scaling factors increase the probability of triggering the bug. PR: kern/115413: [ipv6] ipv6 pmtu not working Tested by: Jacek Zapala Reviewed by: mlaier Approved by: re (kensmith) Revision Changes Path 1.46 +1 -2 src/sys/contrib/pf/net/pf.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 09:38:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4086E16A417; Thu, 23 Aug 2007 09:38:15 +0000 (UTC) (envelope-from dhartmei@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 174A613C46C; Thu, 23 Aug 2007 09:38:15 +0000 (UTC) (envelope-from dhartmei@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N9cEkN079097; Thu, 23 Aug 2007 09:38:14 GMT (envelope-from dhartmei@repoman.freebsd.org) Received: (from dhartmei@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N9cEu5079096; Thu, 23 Aug 2007 09:38:14 GMT (envelope-from dhartmei) Message-Id: <200708230938.l7N9cEu5079096@repoman.freebsd.org> From: Daniel Hartmeier Date: Thu, 23 Aug 2007 09:38:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/contrib/pf/net pf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 09:38:15 -0000 dhartmei 2007-08-23 09:38:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/contrib/pf/net pf.c Log: MFC: r1.46 Revision Changes Path 1.34.2.6 +2 -3 src/sys/contrib/pf/net/pf.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 09:38:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BD6B16A41B; Thu, 23 Aug 2007 09:38:26 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5276F13C457; Thu, 23 Aug 2007 09:38:26 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N9cQEj079136; Thu, 23 Aug 2007 09:38:26 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N9cQIw079135; Thu, 23 Aug 2007 09:38:26 GMT (envelope-from delphij) Message-Id: <200708230938.l7N9cQIw079135@repoman.freebsd.org> From: Xin LI Date: Thu, 23 Aug 2007 09:38:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/rpcgen rpc_main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 09:38:26 -0000 delphij 2007-08-23 09:38:26 UTC FreeBSD src repository Modified files: usr.bin/rpcgen rpc_main.c Log: sysent.h is installed as sys/sysent.h, so reflect it. Approved by: re (kensmith) Spotted by: Changming Sun Sponsored by: SINA Corporation Revision Changes Path 1.33 +1 -1 src/usr.bin/rpcgen/rpc_main.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 09:39:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC9CA16A417; Thu, 23 Aug 2007 09:39:41 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B3AA313C467; Thu, 23 Aug 2007 09:39:41 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7N9dfos079175; Thu, 23 Aug 2007 09:39:41 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7N9dfrY079174; Thu, 23 Aug 2007 09:39:41 GMT (envelope-from delphij) Message-Id: <200708230939.l7N9dfrY079174@repoman.freebsd.org> From: Xin LI Date: Thu, 23 Aug 2007 09:39:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/rpcgen rpc_svcout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 09:39:42 -0000 delphij 2007-08-23 09:39:40 UTC FreeBSD src repository Modified files: usr.bin/rpcgen rpc_svcout.c Log: Use POSIX mutex instead of Solaris ones. This makes generation of threaded RPC servers to work out of the box. Spotted by: Changming Sun Sponsored by: SINA Corporation Approved by: re (kensmith) Revision Changes Path 1.25 +8 -8 src/usr.bin/rpcgen/rpc_svcout.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 10:53:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2DDB16A418; Thu, 23 Aug 2007 10:53:03 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C98DC13C491; Thu, 23 Aug 2007 10:53:03 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NAr3f1088161; Thu, 23 Aug 2007 10:53:03 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NAr3Pc088160; Thu, 23 Aug 2007 10:53:03 GMT (envelope-from des) Message-Id: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Thu, 23 Aug 2007 10:53:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 10:53:04 -0000 des 2007-08-23 10:53:03 UTC FreeBSD src repository Modified files: sys/dev/coretemp coretemp.c Log: Style nits + more reliable Tj(max) detection + improved reporting of critical temperature + sched_unbind() after rdmsr + initialize sc_dev. Submitted by: Rui Paulo , cnst Approved by: re (kensmith) Revision Changes Path 1.2 +42 -34 src/sys/dev/coretemp/coretemp.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 10:56:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEB4A16A417; Thu, 23 Aug 2007 10:56:33 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 9735B13C458; Thu, 23 Aug 2007 10:56:33 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 1F2F220B0; Thu, 23 Aug 2007 12:56:29 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 05475208A; Thu, 23 Aug 2007 12:56:29 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id D94BD84479; Thu, 23 Aug 2007 12:56:28 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: src-committers@FreeBSD.org References: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> Date: Thu, 23 Aug 2007 12:56:28 +0200 In-Reply-To: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> (Dag-Erling Smorgrav's message of "Thu\, 23 Aug 2007 10\:53\:03 +0000 \(UTC\)") Message-ID: <86zm0izfhf.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 10:56:34 -0000 Dag-Erling Smorgrav writes: > Log: > Style nits + more reliable Tj(max) detection + improved reporting of > critical temperature + sched_unbind() after rdmsr + initialize sc_dev. I should note that the driver currently only checks for (and reports) a critical temperature when you read the sysctl; if you want to use devd to react to a critical temperature, you need to set up a cron job to poll dev.cpu.N.temperature. Hopefully, a future version of the driver will install an interrupt handler and activate the temperature threshold interrupts. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Thu Aug 23 13:05:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C075E16A418; Thu, 23 Aug 2007 13:05:13 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 96DF913C45D; Thu, 23 Aug 2007 13:05:13 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ND5BNW010102; Thu, 23 Aug 2007 13:05:11 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ND5BTv010097; Thu, 23 Aug 2007 13:05:11 GMT (envelope-from krion) Message-Id: <200708231305.l7ND5BTv010097@repoman.freebsd.org> From: Kirill Ponomarew Date: Thu, 23 Aug 2007 13:05:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pkg_install/add extract.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 13:05:13 -0000 krion 2007-08-23 13:05:11 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/add extract.c Log: Fix pkg_add behaviour to preserve pathnames. PR: bin/93915 bin/109134 Submitted by: Jason Heiss , Constantin Stefanov Approved by: re@ (kensmith) MFC after: 7 days Revision Changes Path 1.45 +1 -1 src/usr.sbin/pkg_install/add/extract.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 15:23:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9A0916A420 for ; Thu, 23 Aug 2007 15:23:30 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 79FAB13C442 for ; Thu, 23 Aug 2007 15:23:30 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 79770 invoked from network); 23 Aug 2007 15:23:28 -0000 Received: from ppp-71-139-1-224.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.1.224) by root.org with ESMTPA; 23 Aug 2007 15:23:28 -0000 Message-ID: <46CDA669.8080601@root.org> Date: Thu, 23 Aug 2007 08:23:21 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.6 (X11/20070806) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> <86zm0izfhf.fsf@ds4.des.no> In-Reply-To: <86zm0izfhf.fsf@ds4.des.no> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 15:23:30 -0000 Dag-Erling Smørgrav wrote: > Dag-Erling Smorgrav writes: >> Log: >> Style nits + more reliable Tj(max) detection + improved reporting of >> critical temperature + sched_unbind() after rdmsr + initialize sc_dev. > > I should note that the driver currently only checks for (and reports) a > critical temperature when you read the sysctl; if you want to use devd > to react to a critical temperature, you need to set up a cron job to > poll dev.cpu.N.temperature. Hopefully, a future version of the driver > will install an interrupt handler and activate the temperature threshold > interrupts. > > DES You could also create a polling thread that runs every 10 seconds. We have that for acpi_thermal currently. -Nate From owner-cvs-src@FreeBSD.ORG Thu Aug 23 15:44:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E259816A417; Thu, 23 Aug 2007 15:44:45 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BA08913C428; Thu, 23 Aug 2007 15:44:45 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NFijBo023075; Thu, 23 Aug 2007 15:44:45 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NFijhG023074; Thu, 23 Aug 2007 15:44:45 GMT (envelope-from bmah) Message-Id: <200708231544.l7NFijhG023074@repoman.freebsd.org> From: "Bruce A. Mah" Date: Thu, 23 Aug 2007 15:44:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/share/misc dev.archlist.txt X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 15:44:46 -0000 bmah 2007-08-23 15:44:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/share/misc dev.archlist.txt Log: MFC (sort of): Autogenerate hardware notes entities for ath(4) for all platforms on which it's included in the GENERIC kernel. The change is not an exact MFC because the set of platforms is different between HEAD and RELENG_6. dev.archlist.txt 1.95 -> 1.96 PR: 115403 Revision Changes Path 1.62.2.17 +1 -1 src/release/doc/share/misc/dev.archlist.txt From owner-cvs-src@FreeBSD.ORG Thu Aug 23 15:57:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A484916A4A1; Thu, 23 Aug 2007 15:57:14 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7C85013C46E; Thu, 23 Aug 2007 15:57:14 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NFvENV023792; Thu, 23 Aug 2007 15:57:14 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NFvE4Y023791; Thu, 23 Aug 2007 15:57:14 GMT (envelope-from jkim) Message-Id: <200708231557.l7NFvE4Y023791@repoman.freebsd.org> From: Jung-uk Kim Date: Thu, 23 Aug 2007 15:57:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 15:57:14 -0000 jkim 2007-08-23 15:57:14 UTC FreeBSD src repository Modified files: sys/dev/isp isp_freebsd.c Log: Export 4Gbps Fibre Channel link speed correctly with inquiry commands. Approved by: re (kensmith) MFC after: 3 days Revision Changes Path 1.146 +8 -9 src/sys/dev/isp/isp_freebsd.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 16:55:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 564D516A417; Thu, 23 Aug 2007 16:55:23 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2EC4B13C469; Thu, 23 Aug 2007 16:55:23 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NGtMO3036990; Thu, 23 Aug 2007 16:55:22 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NGtMjA036989; Thu, 23 Aug 2007 16:55:22 GMT (envelope-from emax) Message-Id: <200708231655.l7NGtMjA036989@repoman.freebsd.org> From: Maksim Yevmenkin Date: Thu, 23 Aug 2007 16:55:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph/bluetooth/socket ng_btsocket_l2cap.c ng_btsocket_rfcomm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 16:55:23 -0000 emax 2007-08-23 16:55:22 UTC FreeBSD src repository Modified files: sys/netgraph/bluetooth/socket ng_btsocket_l2cap.c ng_btsocket_rfcomm.c Log: Return EADDRNOTAVAIL instead of EDESTADDRREQ error when listen(2) is called on improperly bound socket. Suggested by: Iain Hibbert Approved by: re (kensmith) MFC after: 3 days Revision Changes Path 1.24 +1 -1 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.26 +1 -1 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 18:17:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F0B916A417; Thu, 23 Aug 2007 18:17:09 +0000 (UTC) (envelope-from jinmei@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3810513C4A5; Thu, 23 Aug 2007 18:17:09 +0000 (UTC) (envelope-from jinmei@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NIH9NS044173; Thu, 23 Aug 2007 18:17:09 GMT (envelope-from jinmei@repoman.freebsd.org) Received: (from jinmei@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NIH9Ot044172; Thu, 23 Aug 2007 18:17:09 GMT (envelope-from jinmei) Message-Id: <200708231817.l7NIH9Ot044172@repoman.freebsd.org> From: JINMEI Tatuya Date: Thu, 23 Aug 2007 18:17:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 18:17:09 -0000 jinmei 2007-08-23 18:17:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern uipc_socket.c Log: MFC: Fix a kernel panic based on receiving an ICMPv6 Packet too Big message. (MFC was planned but has been missed) PR: 99779 Submitted by: Jinmei Tatuya Reviewed by: clement, rwatson Approved by: gnn (mentor) src/sys/kern/uipc_socket.c: 1.280 Revision Changes Path 1.242.2.10 +2 -2 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 20:05:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79CD816A417; Thu, 23 Aug 2007 20:05:10 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5170113C483; Thu, 23 Aug 2007 20:05:10 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NK5AIn057651; Thu, 23 Aug 2007 20:05:10 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NK5AaZ057650; Thu, 23 Aug 2007 20:05:10 GMT (envelope-from des) Message-Id: <200708232005.l7NK5AaZ057650@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Thu, 23 Aug 2007 20:05:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 Makefile coretemp.4 ichwd.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 20:05:10 -0000 des 2007-08-23 20:05:10 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Added files: share/man/man4 coretemp.4 ichwd.4 Log: Add man pages for coretemp(4) and ichwd(4). Approved by: re (bmah) Revision Changes Path 1.392 +4 -0 src/share/man/man4/Makefile 1.1 +74 -0 src/share/man/man4/coretemp.4 (new) 1.1 +72 -0 src/share/man/man4/ichwd.4 (new) From owner-cvs-src@FreeBSD.ORG Thu Aug 23 20:12:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 283EB16A418; Thu, 23 Aug 2007 20:12:41 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0018D13C46A; Thu, 23 Aug 2007 20:12:40 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NKCeVN061026; Thu, 23 Aug 2007 20:12:40 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NKCeLp061025; Thu, 23 Aug 2007 20:12:40 GMT (envelope-from emaste) Message-Id: <200708232012.l7NKCeLp061025@repoman.freebsd.org> From: Ed Maste Date: Thu, 23 Aug 2007 20:12:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/aac aac_pci.c src/share/man/man4 aac.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 20:12:41 -0000 emaste 2007-08-23 20:12:40 UTC FreeBSD src repository Modified files: sys/dev/aac aac_pci.c share/man/man4 aac.4 Log: Add PCI IDs for two cards: - Adaptec RAID 3405 - Adaptec RAID 3805 Approved by: re (bmah) Submitted by: John Marra jmarra at nmu dot edu MFC After: 1 week Revision Changes Path 1.36 +5 -1 src/share/man/man4/aac.4 1.62 +4 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Thu Aug 23 20:43:44 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3257416A421; Thu, 23 Aug 2007 20:43:44 +0000 (UTC) (envelope-from mail@frank-behrens.de) Received: from post.frank-behrens.de (post.frank-behrens.de [82.139.255.138]) by mx1.freebsd.org (Postfix) with ESMTP id 8225713C48D; Thu, 23 Aug 2007 20:43:43 +0000 (UTC) (envelope-from mail@frank-behrens.de) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=frank-behrens.de; h=from:to:date:mime-version:subject:cc:in-reply-to:content-type:content-transfer-encoding:content-description; q=dns/txt; s=sel1; bh=KHvq/jhjKx3n323dPQeAR9xIeaA=; b=dDNMRGGiHHzhH2ZVPGkiW9PEDcuXgoAAPahI1WErgNED9E1Lgf1Rc4RTZXBh3BwmDWwlJauoO36S43yVTLcZQQ== Received: from [192.168.20.32] (sun.behrens [192.168.20.32]) by post.frank-behrens.de (8.14.1/8.14.1) with ESMTP-MSA id l7NKVb5T072335 (version=TLSv1/SSLv3 cipher=DES-CBC3-SHA bits=168 verify=NO); Thu, 23 Aug 2007 22:31:45 +0200 (CEST) (envelope-from mail@frank-behrens.de) Message-Id: <200708232031.l7NKVb5T072335@post.frank-behrens.de> From: "Frank Behrens" To: JINMEI Tatuya Date: Thu, 23 Aug 2007 22:31:34 +0200 MIME-Version: 1.0 Priority: normal In-reply-to: <200708231817.l7NIH9Ot044172@repoman.freebsd.org> X-mailer: Pegasus Mail for Windows (4.31, DE v4.31 R1) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body X-Hashcash: 1:24:070823:cvs-all@freebsd.org::I/oEJkYipPiA8Bzu:LGw0 X-Hashcash: 1:24:070823:cvs-src@freebsd.org::MqrL7PYkPvJr7M6F:cgxd X-Hashcash: 1:24:070823:src-committers@freebsd.org::1/QEAcpYYE4jqXvo:00000002Hjhz X-Hashcash: 1:24:070823:jinmei@freebsd.org::iggltGZ4cGEfLdc3:Js8R Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 20:43:44 -0000 JINMEI Tatuya wrote on 23 Aug 2007 18:17: > jinmei 2007-08-23 18:17:08 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/kern uipc_socket.c > Log: > MFC: > Fix a kernel panic based on receiving an ICMPv6 Packet too Big message. > (MFC was planned but has been missed) > > PR: 99779 > Submitted by: Jinmei Tatuya > Reviewed by: clement, rwatson > Approved by: gnn (mentor) > > src/sys/kern/uipc_socket.c: 1.280 I assume that this fixes my reported panic, too. If that's true you may close http://www.freebsd.org/cgi/query-pr.cgi?pr=113359 Regards, Frank -- Frank Behrens, Osterwieck, Germany PGP-key 0x5B7C47ED on public servers available. From owner-cvs-src@FreeBSD.ORG Thu Aug 23 21:51:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1C5E16A41B; Thu, 23 Aug 2007 21:51:35 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id AC9D013C48A; Thu, 23 Aug 2007 21:51:35 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id B7631444B9; Thu, 23 Aug 2007 23:51:34 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id A7A434425B; Thu, 23 Aug 2007 23:51:34 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id DC0529B497; Thu, 23 Aug 2007 21:51:08 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id CC2D1405B; Thu, 23 Aug 2007 23:51:08 +0200 (CEST) Date: Thu, 23 Aug 2007 23:51:08 +0200 From: Jeremie Le Hen To: Alexey Dokuchaev Message-ID: <20070823215108.GB50852@obiwan.tataz.chchile.org> References: <200708012048.l71KmKjg080201@repoman.freebsd.org> <20070802084423.GA93647@FreeBSD.org> <20070802084755.GA2797@tirith.brixandersen.dk> <20070803152914.GB33159@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070803152914.GB33159@FreeBSD.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src UPDATING src/contrib/bind9/bin/named client.c src/contrib/bind9/lib/dns dispatch.c src/contrib/bind9/lib/dns/include/dns dispatch.h src/contrib/tcpdump print-bgp.c src/etc/rc.d jail src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 21:51:36 -0000 Hi Alexey, On Fri, Aug 03, 2007 at 03:29:14PM +0000, Alexey Dokuchaev wrote: > On Thu, Aug 02, 2007 at 10:47:56AM +0200, Henrik Brix Andersen wrote: > > On Thu, Aug 02, 2007 at 08:44:23AM +0000, Alexey Dokuchaev wrote: > > > What about RELENG_4, is it going to be fixed, or these bugs are not > > > applicable to it? It was not quite clear from the SA. > > > > RELENG_4 reached EOL on January 31st, 2007. > > It is still very popular branch. Given my recent experience with > RELENG_6, it's still the best one either. :-( FWIW, freebsd-eol@FreeBSD.org mailing-list aims to provide a peer to peer support for branches that reached their EOL. There hasn't been much traffic for now, but this thread might be a good opportunity to stir it up a bit :). Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From owner-cvs-src@FreeBSD.ORG Thu Aug 23 22:30:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE92416A418; Thu, 23 Aug 2007 22:30:15 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C613413C4A5; Thu, 23 Aug 2007 22:30:15 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7NMUF84079682; Thu, 23 Aug 2007 22:30:15 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7NMUFcR079681; Thu, 23 Aug 2007 22:30:15 GMT (envelope-from obrien) Message-Id: <200708232230.l7NMUFcR079681@repoman.freebsd.org> From: "David E. O'Brien" Date: Thu, 23 Aug 2007 22:30:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2007 22:30:16 -0000 obrien 2007-08-23 22:30:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files Log: MFC: rev 1.1034: add warnings for additional GPL infecting sub-systems. Revision Changes Path 1.1031.2.67 +6 -3 src/sys/conf/files From owner-cvs-src@FreeBSD.ORG Fri Aug 24 00:35:19 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61D7016A417; Fri, 24 Aug 2007 00:35:19 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 38B2A13C458; Fri, 24 Aug 2007 00:35:19 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7O0ZJxO089549; Fri, 24 Aug 2007 00:35:19 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7O0ZJSY089548; Fri, 24 Aug 2007 00:35:19 GMT (envelope-from rrs) Message-Id: <200708240035.l7O0ZJSY089548@repoman.freebsd.org> From: Randall Stewart Date: Fri, 24 Aug 2007 00:35:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat sctp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 00:35:19 -0000 rrs 2007-08-24 00:35:18 UTC FreeBSD src repository Modified files: usr.bin/netstat sctp.c Log: - Fix typo in netstat's display of Nagle algorithm - refer to the RFC. Submitted by: bruce@cran.org.uk Approved by: re@freebsd.org (Bruce Mah) Revision Changes Path 1.6 +2 -2 src/usr.bin/netstat/sctp.c From owner-cvs-src@FreeBSD.ORG Fri Aug 24 00:53:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB92B16A419; Fri, 24 Aug 2007 00:53:53 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B722F13C45B; Fri, 24 Aug 2007 00:53:53 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7O0rrhV099179; Fri, 24 Aug 2007 00:53:53 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7O0rrEl099178; Fri, 24 Aug 2007 00:53:53 GMT (envelope-from rrs) Message-Id: <200708240053.l7O0rrEl099178@repoman.freebsd.org> From: Randall Stewart Date: Fri, 24 Aug 2007 00:53:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp.h sctp_asconf.c sctp_auth.c sctp_constants.h sctp_header.h sctp_indata.c sctp_input.c sctp_os.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_structs.h sctp_sysctl.c sctp_sysctl.h ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 00:53:53 -0000 rrs 2007-08-24 00:53:53 UTC FreeBSD src repository Modified files: sys/netinet sctp.h sctp_asconf.c sctp_auth.c sctp_constants.h sctp_header.h sctp_indata.c sctp_input.c sctp_os.h sctp_os_bsd.h sctp_output.c sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_structs.h sctp_sysctl.c sctp_sysctl.h sctp_timer.c sctp_usrreq.c sctp_var.h sctputil.c sctputil.h sys/netinet6 sctp6_usrreq.c sys/sys mbuf.h Log: - Fix address add handling to clear cached routes and source addresses when peer acks the add in case the routing table changes. - Fix sctp_lower_sosend to send shutdown chunk for mbuf send case when sndlen = 0 and sinfoflag = SCTP_EOF - Fix sctp_lower_sosend for SCTP_ABORT mbuf send case with null data, So that it does not send the "null" data mbuf out and cause it to get freed twice. - Fix so auto-asconf sysctl actually effect the socket's asconf state. - Do not allow SCTP_AUTO_ASCONF option to be used on subset bound sockets. - Memset bug in sctp_output.c (arguments were reversed) submitted found and reported by Dave Jones (davej@codemonkey.org.uk). - PD-API point needs to be invoked >= not just > to conform to socket api draft this fixes sctp_indata.c in the two places need to be >=. - move M_NOTIFICATION to use M_PROTO5. - PEER_ADDR_PARAMS did not fail properly if you specify an address that is not in the association with a valid assoc_id. This meant you got or set the stcb level values instead of the destination you thought you were going to get/set. Now validate if the stcb is non-null and the net is NULL that the sa_family is set and the address is unspecified otherwise return an error. - The thread based iterator could crash if associations were freed at the exact time it was running. rework the worker thread to use the increment/decrement to prevent this and no longer use the markers that the timer based iterator uses. - Fix the memleak in sctp_add_addr_to_vrf() for the case when it is detected that ifa is already pointing to a ifn. - Fix it so that if someone is so insane that they drop the send window below the minimal add mark, they still can send. - Changed all state for associations to use mask safe macro. - During front states in association freeing in sctp_inpcbfree, we had a locking problem where locks were not in place where they should have been. - Free association calls were not testing the return value in sctp_inpcb_free() properly... others should be cast void returns where we don't care about the return value. - If a reference count is held on an assoc, even from the "force free" we should not do the actual free.. but instead let the timer free it. - When we enter sctp_input(), if the SCTP_ASOC_ABOUT_TO_BE_FREED flag is set, we must NOT process the packet but handle it like ootb. This is because while freeing an assoc we release the locks to get all the higher order locks so we can purge all the hash tables. This leaves a hole if a packet comes in just at that point. Now sctp_common_input_processing() will call the ootb code in such a case. - Change MBUF M_NOTIFICATION to use M_PROTO5 (per Sam L). This makes it so we don't have a conflict (I think this is a covertity change). We made this change AFTER some conversation and looking to make sure that M_PROTO5 does not have a problem between SCTP and the 802.11 stuff (which is the only other place its used). - Fixed lock order reversal and missing atomic protection around locked_tcb during association lookup and the 1-2-1 model. - Added debug to source address selection. - V6 output must always do checksum even for loopback. - Remove more locks around inp that are not needed for an atomically added/subtracted ref count. - slight optimization in the way we zero the array in sctp_sack_check() - It was possible to respond to a ABORT() with bad checksum with a PKT-DROP. This lead to a PKT-DROP/ABORT war. Add code to NOT send a PKT-DROP to any ABORT(). - Add an option for local logging (useful for macintosh or when you need better performing during debugging). Note no commands are here to get the log info, you must just use kgdb. - The timer code needs to be aware of if it needs to call sctp_sack_check() to slide the maps and adjust the cum-ack. This is because it may be out of sync cum-ack wise. - Added threshold managment logging. - If the user picked just the right size, that just filled the send window minus one mtu, we would enter a forever loop not copying and at the same time not blocking. Change from < to <= solves this. - Sysctl added to control the fragment interleave level which defaults to 1. - My rwnd control was not being used to control the rwnd properly (we did not add and subtract to it :-() this is now fixed so we handle small messages (1 byte etc) better to bring our rwnd down more slowly. Approved by: re@freebsd.org (Bruce Mah) Revision Changes Path 1.18 +2 -0 src/sys/netinet/sctp.h 1.25 +13 -1 src/sys/netinet/sctp_asconf.c 1.16 +1 -1 src/sys/netinet/sctp_auth.c 1.26 +12 -1 src/sys/netinet/sctp_constants.h 1.6 +0 -1 src/sys/netinet/sctp_header.h 1.40 +36 -22 src/sys/netinet/sctp_indata.c 1.57 +120 -47 src/sys/netinet/sctp_input.c 1.9 +1 -0 src/sys/netinet/sctp_os.h 1.31 +19 -2 src/sys/netinet/sctp_os_bsd.h 1.50 +196 -67 src/sys/netinet/sctp_output.c 1.53 +97 -22 src/sys/netinet/sctp_pcb.c 1.28 +1 -0 src/sys/netinet/sctp_pcb.h 1.14 +13 -3 src/sys/netinet/sctp_peeloff.c 1.23 +3 -3 src/sys/netinet/sctp_structs.h 1.13 +8 -0 src/sys/netinet/sctp_sysctl.c 1.9 +15 -3 src/sys/netinet/sctp_sysctl.h 1.27 +15 -1 src/sys/netinet/sctp_timer.c 1.43 +241 -30 src/sys/netinet/sctp_usrreq.c 1.17 +3 -10 src/sys/netinet/sctp_var.h 1.56 +124 -40 src/sys/netinet/sctputil.c 1.27 +5 -0 src/sys/netinet/sctputil.h 1.37 +53 -14 src/sys/netinet6/sctp6_usrreq.c 1.215 +1 -1 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 10:34:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84FD416A419; Fri, 24 Aug 2007 10:34:31 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3F78013C45E; Fri, 24 Aug 2007 10:34:31 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OAYVIr065552; Fri, 24 Aug 2007 10:34:31 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OAYVkv065551; Fri, 24 Aug 2007 10:34:31 GMT (envelope-from thompsa) Message-Id: <200708241034.l7OAYVkv065551@repoman.freebsd.org> From: Andrew Thompson Date: Fri, 24 Aug 2007 10:34:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/net bridgestp.c bridgestp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 10:34:31 -0000 thompsa 2007-08-24 10:34:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net bridgestp.c bridgestp.h Log: MFC r1.38,1.39 - Ensure the path cost does not exceed 65535 in legacy STP mode. - If the path cost is calculated when the link is down, set a pending flag so it is calculated again when it comes back up. - To not use 00:00:00:00:00:00 as the bridge id, all interfaces are scanned and the lowest number wins. All zeros is too low. - If the STP state machine is stopped then clear the bridge-id and root-id. Revision Changes Path 1.3.2.13 +41 -8 src/sys/net/bridgestp.c 1.12.2.3 +1 -0 src/sys/net/bridgestp.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 12:21:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7255D16A468; Fri, 24 Aug 2007 12:21:32 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id DE43E13C442; Fri, 24 Aug 2007 12:21:31 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id C9957691005; Fri, 24 Aug 2007 13:24:46 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 85848691015; Fri, 24 Aug 2007 13:24:46 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,RCVD_IN_XBL autolearn=no version=3.1.7 Received: from epsilon.mshome.net (62.169.100.218.rev.optimus.pt [62.169.100.218]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by core.fnop.net (Postfix) with ESMTP id 1E797691005; Fri, 24 Aug 2007 13:24:41 +0100 (WEST) Message-ID: <46CECD3E.1040302@fnop.net> Date: Fri, 24 Aug 2007 13:21:18 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Nate Lawson References: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> <86zm0izfhf.fsf@ds4.des.no> <46CDA669.8080601@root.org> In-Reply-To: <46CDA669.8080601@root.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 12:21:32 -0000 Nate Lawson wrote: > Dag-Erling Smørgrav wrote: >> Dag-Erling Smorgrav writes: >>> Log: >>> Style nits + more reliable Tj(max) detection + improved reporting of >>> critical temperature + sched_unbind() after rdmsr + initialize sc_dev. >> I should note that the driver currently only checks for (and reports) a >> critical temperature when you read the sysctl; if you want to use devd >> to react to a critical temperature, you need to set up a cron job to >> poll dev.cpu.N.temperature. Hopefully, a future version of the driver >> will install an interrupt handler and activate the temperature threshold >> interrupts. >> >> DES > > You could also create a polling thread that runs every 10 seconds. We > have that for acpi_thermal currently. Will do that when I find time. Regards. -- Rui Paulo From owner-cvs-src@FreeBSD.ORG Fri Aug 24 13:27:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 791E916A41A; Fri, 24 Aug 2007 13:27:28 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 688B313C45E; Fri, 24 Aug 2007 13:27:28 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ODRS5G087882; Fri, 24 Aug 2007 13:27:28 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ODRSDf087879; Fri, 24 Aug 2007 13:27:28 GMT (envelope-from edwin) Message-Id: <200708241327.l7ODRSDf087879@repoman.freebsd.org> From: Edwin Groothuis Date: Fri, 24 Aug 2007 13:27:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: ADO Cc: Subject: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 13:27:28 -0000 edwin 2007-08-24 13:27:27 UTC FreeBSD src repository src/share/zoneinfo - Imported sources Update of /home/ncvs/src/share/zoneinfo In directory repoman.freebsd.org:/tmp/cvs-serv87348 Log Message: Import of timezone database from Arthur Olson et al. Timezone data changes in the following locations: - Egypt - Australia (new DST rules for 2008 and following) - Perry County, Indiana - America/Indiana/Tell_City - Pike County, Indiana Also: - City coordinates corrected. - Layout of leapseconds is updated PR: conf/115706 Approved by: re (bmah@) Status: Vendor Tag: ADO Release Tags: tzdata2007g C src/share/zoneinfo/africa U src/share/zoneinfo/antarctica U src/share/zoneinfo/asia C src/share/zoneinfo/australasia C src/share/zoneinfo/europe C src/share/zoneinfo/northamerica U src/share/zoneinfo/southamerica U src/share/zoneinfo/pacificnew U src/share/zoneinfo/etcetera U src/share/zoneinfo/factory U src/share/zoneinfo/backward U src/share/zoneinfo/systemv U src/share/zoneinfo/solar87 U src/share/zoneinfo/solar88 U src/share/zoneinfo/solar89 U src/share/zoneinfo/iso3166.tab C src/share/zoneinfo/zone.tab C src/share/zoneinfo/leapseconds U src/share/zoneinfo/yearistype.sh 6 conflicts created by this import. Use the following command to help the merge: cvs checkout -jADO:yesterday -jADO src/share/zoneinfo From owner-cvs-src@FreeBSD.ORG Fri Aug 24 13:36:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E06B716A41B; Fri, 24 Aug 2007 13:36:20 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D295413C46C; Fri, 24 Aug 2007 13:36:20 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ODaKZw088586; Fri, 24 Aug 2007 13:36:20 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ODaKfF088585; Fri, 24 Aug 2007 13:36:20 GMT (envelope-from edwin) Message-Id: <200708241336.l7ODaKfF088585@repoman.freebsd.org> From: Edwin Groothuis Date: Fri, 24 Aug 2007 13:36:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/zoneinfo africa australasia europe leapseconds northamerica zone.tab X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 13:36:21 -0000 edwin 2007-08-24 13:36:20 UTC FreeBSD src repository Modified files: share/zoneinfo africa australasia europe leapseconds northamerica zone.tab Log: MFV: tzdata2007g PR: conf/115706 Submitted by: edwin@ Approved by: re (bmah@) Obtained from: ftp://elsie.nci.nih.gov/pub/ MFC after: 1 week Revision Changes Path 1.20 +10 -2 src/share/zoneinfo/africa 1.32 +52 -39 src/share/zoneinfo/australasia 1.35 +10 -3 src/share/zoneinfo/europe 1.19 +26 -27 src/share/zoneinfo/leapseconds 1.33 +36 -14 src/share/zoneinfo/northamerica 1.22 +9 -8 src/share/zoneinfo/zone.tab From owner-cvs-src@FreeBSD.ORG Fri Aug 24 13:57:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C298D16A417; Fri, 24 Aug 2007 13:57:58 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail5out.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) by mx1.freebsd.org (Postfix) with ESMTP id 765AC13C461; Fri, 24 Aug 2007 13:57:58 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by mail5out.barnet.com.au (Postfix, from userid 1001) id 763E42219D0B; Fri, 24 Aug 2007 23:40:01 +1000 (EST) X-Viruscan-Id: <46CEDFB100012FE0774549@BarNet> Received: from mail5auth.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail5.barnet.com.au (Postfix) with ESMTP id 0CC8A21B28EF; Fri, 24 Aug 2007 23:40:01 +1000 (EST) Received: from k7.mavetju (k7.mavetju.org [10.251.1.18]) by mail5auth.barnet.com.au (Postfix) with ESMTP id 5CDBA2219D10; Fri, 24 Aug 2007 23:39:59 +1000 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 196E016C; Fri, 24 Aug 2007 23:39:56 +1000 (EST) Date: Fri, 24 Aug 2007 23:39:56 +1000 From: Edwin Groothuis To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070824133956.GC1384@k7.mavetju> References: <200708241336.l7ODaKfF088585@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708241336.l7ODaKfF088585@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: Subject: Re: cvs commit: src/share/zoneinfo africa australasia europe leapseconds northamerica zone.tab X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 13:57:58 -0000 On Fri, Aug 24, 2007 at 01:36:20PM +0000, Edwin Groothuis wrote: > PR: conf/115706 > Submitted by: edwin@ > Approved by: re (bmah@) Also approved by: greg@ (mentor) > Obtained from: ftp://elsie.nci.nih.gov/pub/ > MFC after: 1 week Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From owner-cvs-src@FreeBSD.ORG Fri Aug 24 13:57:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C875816A419; Fri, 24 Aug 2007 13:57:58 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail5out.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) by mx1.freebsd.org (Postfix) with ESMTP id 7681913C468; Fri, 24 Aug 2007 13:57:58 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by mail5out.barnet.com.au (Postfix, from userid 1001) id DFA102219D1D; Fri, 24 Aug 2007 23:39:38 +1000 (EST) X-Viruscan-Id: <46CEDF9A00012F70CD85B9@BarNet> Received: from mail5auth.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail5.barnet.com.au (Postfix) with ESMTP id A2C0321B2A0D; Fri, 24 Aug 2007 23:39:38 +1000 (EST) Received: from k7.mavetju (k7.mavetju.org [10.251.1.18]) by mail5auth.barnet.com.au (Postfix) with ESMTP id 4E6562219D0B; Fri, 24 Aug 2007 23:39:38 +1000 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id E9A1F35C; Fri, 24 Aug 2007 23:39:39 +1000 (EST) Date: Fri, 24 Aug 2007 23:39:39 +1000 From: Edwin Groothuis To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070824133939.GB1384@k7.mavetju> References: <200708241327.l7ODRSDf087879@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708241327.l7ODRSDf087879@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: Subject: Re: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 13:57:59 -0000 On Fri, Aug 24, 2007 at 01:27:27PM +0000, Edwin Groothuis wrote: > PR: conf/115706 > Approved by: re (bmah@) Also approved by: greg@ (mentor) Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From owner-cvs-src@FreeBSD.ORG Fri Aug 24 15:03:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6E9C16A420; Fri, 24 Aug 2007 15:03:14 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 66DD513C481; Fri, 24 Aug 2007 15:03:13 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7OF3C6L000179; Fri, 24 Aug 2007 11:03:12 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Fri, 24 Aug 2007 11:03:12 -0400 (EDT) Date: Fri, 24 Aug 2007 11:03:12 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <200708230509.l7N59VCi048341@repoman.freebsd.org> Message-ID: References: <200708230509.l7N59VCi048341@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 15:03:14 -0000 On Thu, 23 Aug 2007, Yar Tikhiy wrote: > yar 2007-08-23 05:09:31 UTC > > FreeBSD src repository > > Modified files: > lib/libc/gen fts-compat.c fts-compat.h > Log: > Forced commit to note repo-copy: > > These files have been repo-copied from src/include/fts.h > and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD > compatible versions of fts(3) functions to be preserved > through libc symbol versioning while the default versions > undergo ABI-breaking extension to support big file trees. When are you going to break the ABI? After 7.0 is tagged and released? If you break the ABI before, you don't need or want to have the compat versions; the libraries have already been bumped in prep for release. I don't think we want to use symbol versioning as a crutch for -current users; the version definitions are meant for public releases only. -- DE From owner-cvs-src@FreeBSD.ORG Fri Aug 24 15:18:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4104416A41A; Fri, 24 Aug 2007 15:18:43 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1AC8613C48D; Fri, 24 Aug 2007 15:18:43 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OFIggL097201; Fri, 24 Aug 2007 15:18:43 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OFIgH3097200; Fri, 24 Aug 2007 15:18:42 GMT (envelope-from bmah) Message-Id: <200708241518.l7OFIgH3097200@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 24 Aug 2007 15:18:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 15:18:43 -0000 bmah 2007-08-24 15:18:42 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release note: coretemp(4). Updated release note: tzdata2007g [1]. [1] Technically I should remove the &merged; entity here but the commit has a one-week MFC-after so I figure I can leave it this way for now. Approved by: re (implicitly) Revision Changes Path 1.1061 +5 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Fri Aug 24 15:44:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36B9016A417; Fri, 24 Aug 2007 15:44:28 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1176613C483; Fri, 24 Aug 2007 15:44:28 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OFiRek099110; Fri, 24 Aug 2007 15:44:27 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OFiRU9099109; Fri, 24 Aug 2007 15:44:27 GMT (envelope-from sam) Message-Id: <200708241544.l7OFiRU9099109@repoman.freebsd.org> From: Sam Leffler Date: Fri, 24 Aug 2007 15:44:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net80211 ieee80211_output.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 15:44:28 -0000 sam 2007-08-24 15:44:27 UTC FreeBSD src repository Modified files: sys/net80211 ieee80211_output.c Log: drop frames marked for encryption when no key is available Reviewed by: avatar Approved by: re (kensmith) Obtained from: madwifi Revision Changes Path 1.51 +1 -0 src/sys/net80211/ieee80211_output.c From owner-cvs-src@FreeBSD.ORG Fri Aug 24 16:26:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0959A16A41A; Fri, 24 Aug 2007 16:26:25 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D842413C457; Fri, 24 Aug 2007 16:26:24 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OGQObb003212; Fri, 24 Aug 2007 16:26:24 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OGQOE1003211; Fri, 24 Aug 2007 16:26:24 GMT (envelope-from ache) Message-Id: <200708241626.l7OGQOE1003211@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Fri, 24 Aug 2007 16:26:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/lib/libdialog dialog.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 16:26:25 -0000 ache 2007-08-24 16:26:24 UTC FreeBSD src repository Modified files: gnu/lib/libdialog dialog.h Log: Fix stack overflow with too many items return list in 'dialog' program. (Noticed in ghostscript-gpl core dump) Approved by: re@ (bmah) Revision Changes Path 1.23 +1 -1 src/gnu/lib/libdialog/dialog.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 17:29:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD54316A419; Fri, 24 Aug 2007 17:29:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A67A513C457; Fri, 24 Aug 2007 17:29:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OHTI6L016782; Fri, 24 Aug 2007 17:29:18 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OHTI0e016781; Fri, 24 Aug 2007 17:29:18 GMT (envelope-from jhb) Message-Id: <200708241729.l7OHTI0e016781@repoman.freebsd.org> From: John Baldwin Date: Fri, 24 Aug 2007 17:29:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 mfi.4 src/sys/dev/mfi mfi.c mfi_disk.c mfi_pci.c mfireg.h mfivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 17:29:18 -0000 jhb 2007-08-24 17:29:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 mfi.4 sys/dev/mfi mfi.c mfi_disk.c mfi_pci.c mfireg.h mfivar.h Log: MFC: Teach the mfi(4) driver to handle requests from userland management applications to add and remove volumes. Revision Changes Path 1.4.2.3 +14 -0 src/share/man/man4/mfi.4 1.3.2.8 +163 -24 src/sys/dev/mfi/mfi.c 1.2.2.6 +45 -5 src/sys/dev/mfi/mfi_disk.c 1.1.2.6 +7 -2 src/sys/dev/mfi/mfi_pci.c 1.1.2.7 +1 -0 src/sys/dev/mfi/mfireg.h 1.1.2.7 +10 -0 src/sys/dev/mfi/mfivar.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 18:43:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF55D16A41B; Fri, 24 Aug 2007 18:43:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9920513C494; Fri, 24 Aug 2007 18:43:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OIh0Q0022593; Fri, 24 Aug 2007 18:43:00 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OIh00l022592; Fri, 24 Aug 2007 18:43:00 GMT (envelope-from jhb) Message-Id: <200708241843.l7OIh00l022592@repoman.freebsd.org> From: John Baldwin Date: Fri, 24 Aug 2007 18:43:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/atacontrol atacontrol.c src/sys/dev/ata ata-raid.c src/sys/sys ata.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 18:43:00 -0000 jhb 2007-08-24 18:43:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/atacontrol atacontrol.c sys/dev/ata ata-raid.c sys/sys ata.h Log: MFC: Expand the data structure returned by the ATA RAID status ioctl to include detailed status on each of the backing subdisks. A binary compat shim is provided for the original status ioctl. Approved by: sos Revision Changes Path 1.36.2.6 +31 -19 src/sbin/atacontrol/atacontrol.c 1.98.2.10 +49 -14 src/sys/dev/ata/ata-raid.c 1.26.2.7 +18 -1 src/sys/sys/ata.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 19:08:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D80316A417; Fri, 24 Aug 2007 19:08:57 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 8500313C49D; Fri, 24 Aug 2007 19:08:55 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7OIaVb4007699; Fri, 24 Aug 2007 22:36:31 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7OIaUct007698; Fri, 24 Aug 2007 22:36:30 +0400 (MSD) (envelope-from yar) Date: Fri, 24 Aug 2007 22:36:30 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070824183630.GA99474@comp.chem.msu.su> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 19:08:57 -0000 On Fri, Aug 24, 2007 at 11:03:12AM -0400, Daniel Eischen wrote: > On Thu, 23 Aug 2007, Yar Tikhiy wrote: > > >yar 2007-08-23 05:09:31 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libc/gen fts-compat.c fts-compat.h > > Log: > > Forced commit to note repo-copy: > > > > These files have been repo-copied from src/include/fts.h > > and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD > > compatible versions of fts(3) functions to be preserved > > through libc symbol versioning while the default versions > > undergo ABI-breaking extension to support big file trees. > > When are you going to break the ABI? After 7.0 is tagged > and released? If you break the ABI before, you don't need > or want to have the compat versions; the libraries have already > been bumped in prep for release. I don't think we want to > use symbol versioning as a crutch for -current users; the > version definitions are meant for public releases only. The reason for exercising symbol versions right now is that "make installworld" is sensitive to the fts(3) ABI. If the ABI is just broken w/o special measures, "make installworld" will fail in the middle and leave you with a botched system. It goes as follows: - "make installworld" copies the old /usr/bin/find and some other tools to /tmp/install.xxx for use during the install - libc is overwritten by its new instance, with new fts(3) ABI - the old find(1) is run by installworld and dumps core immediately. Earlier the problem was to be avoided by bumping libc version so that the old libc is kept, and now I chose symbol versioning to get around it. Do you think there is a different way? -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 24 19:15:08 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0932C16A418; Fri, 24 Aug 2007 19:15:08 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id A422813C459; Fri, 24 Aug 2007 19:15:07 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7OJErXQ011883; Fri, 24 Aug 2007 15:14:53 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Fri, 24 Aug 2007 15:14:54 -0400 (EDT) Date: Fri, 24 Aug 2007 15:14:53 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070824183630.GA99474@comp.chem.msu.su> Message-ID: References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 19:15:08 -0000 On Fri, 24 Aug 2007, Yar Tikhiy wrote: > On Fri, Aug 24, 2007 at 11:03:12AM -0400, Daniel Eischen wrote: >> On Thu, 23 Aug 2007, Yar Tikhiy wrote: >> >>> yar 2007-08-23 05:09:31 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> lib/libc/gen fts-compat.c fts-compat.h >>> Log: >>> Forced commit to note repo-copy: >>> >>> These files have been repo-copied from src/include/fts.h >>> and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD >>> compatible versions of fts(3) functions to be preserved >>> through libc symbol versioning while the default versions >>> undergo ABI-breaking extension to support big file trees. >> >> When are you going to break the ABI? After 7.0 is tagged >> and released? If you break the ABI before, you don't need >> or want to have the compat versions; the libraries have already >> been bumped in prep for release. I don't think we want to >> use symbol versioning as a crutch for -current users; the >> version definitions are meant for public releases only. > > The reason for exercising symbol versions right now is that "make > installworld" is sensitive to the fts(3) ABI. If the ABI is just > broken w/o special measures, "make installworld" will fail in the > middle and leave you with a botched system. It goes as follows: > > - "make installworld" copies the old /usr/bin/find and some other > tools to /tmp/install.xxx for use during the install > - libc is overwritten by its new instance, with new fts(3) ABI > - the old find(1) is run by installworld and dumps core immediately. Why don't you make find and the install tools static. > Earlier the problem was to be avoided by bumping libc version so > that the old libc is kept, and now I chose symbol versioning to get > around it. Do you think there is a different way? Yes, you wait until after release to do this. Look at it this way: if there wasn't symbol versioning and libc was already bumped, how would you solve the problem? You wouldn't bump libc again, right? -- DE From owner-cvs-src@FreeBSD.ORG Fri Aug 24 20:25:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFF4B16A419; Fri, 24 Aug 2007 20:25:52 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9A9A013C48A; Fri, 24 Aug 2007 20:25:52 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OKPqbB030846; Fri, 24 Aug 2007 20:25:52 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OKPqkJ030845; Fri, 24 Aug 2007 20:25:52 GMT (envelope-from bms) Message-Id: <200708242025.l7OKPqkJ030845@repoman.freebsd.org> From: Bruce M Simpson Date: Fri, 24 Aug 2007 20:25:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include/arpa inet.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 20:25:52 -0000 bms 2007-08-24 20:25:52 UTC FreeBSD src repository Modified files: include/arpa inet.h Log: Remove old prototypes for addr2ascii() and ascii2addr(), functions which no longer exist in libc. Requested by: Craig Rodrigues Approved by: re (kensmith) Revision Changes Path 1.30 +0 -2 src/include/arpa/inet.h From owner-cvs-src@FreeBSD.ORG Fri Aug 24 20:37:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD03616A468; Fri, 24 Aug 2007 20:37:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 4D5B213C457; Fri, 24 Aug 2007 20:37:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k) with ESMTP id 205121704-1834499 for multiple; Fri, 24 Aug 2007 16:37:30 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7OKbFWB031698; Fri, 24 Aug 2007 16:37:18 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Fri, 24 Aug 2007 16:37:09 -0400 User-Agent: KMail/1.9.6 References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708241637.09962.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 24 Aug 2007 16:37:18 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4054/Fri Aug 24 12:55:59 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Yar Tikhiy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 20:37:34 -0000 On Friday 24 August 2007 03:14:53 pm Daniel Eischen wrote: > On Fri, 24 Aug 2007, Yar Tikhiy wrote: > > The reason for exercising symbol versions right now is that "make > > installworld" is sensitive to the fts(3) ABI. If the ABI is just > > broken w/o special measures, "make installworld" will fail in the > > middle and leave you with a botched system. It goes as follows: > > > > - "make installworld" copies the old /usr/bin/find and some other > > tools to /tmp/install.xxx for use during the install > > - libc is overwritten by its new instance, with new fts(3) ABI > > - the old find(1) is run by installworld and dumps core immediately. > > Why don't you make find and the install tools static. Because they aren't built during buildworld, these are the existing binaries on the existing system that are used just before they are overwritten. However, per my other e-mail, I think -current users should just deal, or use a temporary hack to get over the hurdle. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 24 20:38:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 134B816A418; Fri, 24 Aug 2007 20:38:10 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E0A5613C458; Fri, 24 Aug 2007 20:38:09 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7OKc9gd031562; Fri, 24 Aug 2007 20:38:09 GMT (envelope-from danger@repoman.freebsd.org) Received: (from danger@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7OKc96G031561; Fri, 24 Aug 2007 20:38:09 GMT (envelope-from danger) Message-Id: <200708242038.l7OKc96G031561@repoman.freebsd.org> From: Daniel Gerzo Date: Fri, 24 Aug 2007 20:38:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/sysctl sysctl.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 20:38:10 -0000 danger 2007-08-24 20:38:09 UTC FreeBSD src repository (doc committer) Modified files: sbin/sysctl sysctl.8 Log: document hw.realmem Submitted by: cnst@ (Constantine A. Murenin) Sponsored by: Google Summer of Code 2007 Approved by: re@ (bmah) MFC after: 1 week Revision Changes Path 1.61 +1 -0 src/sbin/sysctl/sysctl.8 From owner-cvs-src@FreeBSD.ORG Fri Aug 24 20:38:19 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F07516A46D; Fri, 24 Aug 2007 20:38:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id E25EA13C46A; Fri, 24 Aug 2007 20:38:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k) with ESMTP id 205121697-1834499 for multiple; Fri, 24 Aug 2007 16:37:27 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7OKbFWA031698; Fri, 24 Aug 2007 16:37:16 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Fri, 24 Aug 2007 16:35:34 -0400 User-Agent: KMail/1.9.6 References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> In-Reply-To: <20070824183630.GA99474@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708241635.36266.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 24 Aug 2007 16:37:16 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4054/Fri Aug 24 12:55:59 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Daniel Eischen , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 20:38:19 -0000 On Friday 24 August 2007 02:36:30 pm Yar Tikhiy wrote: > On Fri, Aug 24, 2007 at 11:03:12AM -0400, Daniel Eischen wrote: > > On Thu, 23 Aug 2007, Yar Tikhiy wrote: > > > > >yar 2007-08-23 05:09:31 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libc/gen fts-compat.c fts-compat.h > > > Log: > > > Forced commit to note repo-copy: > > > > > > These files have been repo-copied from src/include/fts.h > > > and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD > > > compatible versions of fts(3) functions to be preserved > > > through libc symbol versioning while the default versions > > > undergo ABI-breaking extension to support big file trees. > > > > When are you going to break the ABI? After 7.0 is tagged > > and released? If you break the ABI before, you don't need > > or want to have the compat versions; the libraries have already > > been bumped in prep for release. I don't think we want to > > use symbol versioning as a crutch for -current users; the > > version definitions are meant for public releases only. > > The reason for exercising symbol versions right now is that "make > installworld" is sensitive to the fts(3) ABI. If the ABI is just > broken w/o special measures, "make installworld" will fail in the > middle and leave you with a botched system. It goes as follows: > > - "make installworld" copies the old /usr/bin/find and some other > tools to /tmp/install.xxx for use during the install > - libc is overwritten by its new instance, with new fts(3) ABI > - the old find(1) is run by installworld and dumps core immediately. > > Earlier the problem was to be avoided by bumping libc version so > that the old libc is kept, and now I chose symbol versioning to get > around it. Do you think there is a different way? 6.x users upgrading to 7.0 will have a 6.x /usr/bin/find, so they will be ok. It's only old -current users who already have a libc.so.7 that will be inconvenienced, and that's part of running -current. Maybe you could use a hack where for 7.x osreldate's you copy tools out of /rescue instead for a few weeks to give people on -current a chance to upgrade. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 24 21:09:55 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A285B16A418; Fri, 24 Aug 2007 21:09:55 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from alnrmhc15.comcast.net (alnrmhc15.comcast.net [204.127.225.95]) by mx1.freebsd.org (Postfix) with ESMTP id 474D713C442; Fri, 24 Aug 2007 21:09:55 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from discordia (c-75-69-212-227.hsd1.nh.comcast.net[75.69.212.227]) by comcast.net (alnrmhc15) with ESMTP id <20070824205720b1500a3p95e>; Fri, 24 Aug 2007 20:57:20 +0000 Received: by discordia (Postfix, from userid 103) id 204E835A578; Fri, 24 Aug 2007 16:57:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 3182735A577; Fri, 24 Aug 2007 16:57:09 -0400 (EDT) Message-ID: <46CF45F8.9060405@FreeBSD.org> Date: Fri, 24 Aug 2007 16:56:24 -0400 From: Coleman Kane Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.6 (X11/20070813) MIME-Version: 1.0 To: John Baldwin References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> <200708241635.36266.jhb@freebsd.org> In-Reply-To: <200708241635.36266.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Daniel Eischen , Yar Tikhiy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 21:09:55 -0000 John Baldwin wrote: > On Friday 24 August 2007 02:36:30 pm Yar Tikhiy wrote: > >> On Fri, Aug 24, 2007 at 11:03:12AM -0400, Daniel Eischen wrote: >> >>> On Thu, 23 Aug 2007, Yar Tikhiy wrote: >>> >>> >>>> yar 2007-08-23 05:09:31 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> lib/libc/gen fts-compat.c fts-compat.h >>>> Log: >>>> Forced commit to note repo-copy: >>>> >>>> These files have been repo-copied from src/include/fts.h >>>> and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD >>>> compatible versions of fts(3) functions to be preserved >>>> through libc symbol versioning while the default versions >>>> undergo ABI-breaking extension to support big file trees. >>>> >>> When are you going to break the ABI? After 7.0 is tagged >>> and released? If you break the ABI before, you don't need >>> or want to have the compat versions; the libraries have already >>> been bumped in prep for release. I don't think we want to >>> use symbol versioning as a crutch for -current users; the >>> version definitions are meant for public releases only. >>> >> The reason for exercising symbol versions right now is that "make >> installworld" is sensitive to the fts(3) ABI. If the ABI is just >> broken w/o special measures, "make installworld" will fail in the >> middle and leave you with a botched system. It goes as follows: >> >> - "make installworld" copies the old /usr/bin/find and some other >> tools to /tmp/install.xxx for use during the install >> - libc is overwritten by its new instance, with new fts(3) ABI >> - the old find(1) is run by installworld and dumps core immediately. >> >> Earlier the problem was to be avoided by bumping libc version so >> that the old libc is kept, and now I chose symbol versioning to get >> around it. Do you think there is a different way? >> > > 6.x users upgrading to 7.0 will have a 6.x /usr/bin/find, so they will > be ok. It's only old -current users who already have a libc.so.7 that > will be inconvenienced, and that's part of running -current. Maybe > you could use a hack where for 7.x osreldate's you copy tools out of > /rescue instead for a few weeks to give people on -current a chance to > upgrade. > Whatever the solution turns out to be, don't forget to drop it into UPGRADING... -- Coleman Kane From owner-cvs-src@FreeBSD.ORG Fri Aug 24 21:44:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A23516A46B; Fri, 24 Aug 2007 21:44:34 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 3167B13C467; Fri, 24 Aug 2007 21:44:32 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7OLiUss010934; Sat, 25 Aug 2007 01:44:30 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7OLiUhC010933; Sat, 25 Aug 2007 01:44:30 +0400 (MSD) (envelope-from yar) Date: Sat, 25 Aug 2007 01:44:29 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070824214429.GB99474@comp.chem.msu.su> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 21:44:34 -0000 On Fri, Aug 24, 2007 at 03:14:53PM -0400, Daniel Eischen wrote: > On Fri, 24 Aug 2007, Yar Tikhiy wrote: > > >On Fri, Aug 24, 2007 at 11:03:12AM -0400, Daniel Eischen wrote: > >>On Thu, 23 Aug 2007, Yar Tikhiy wrote: > >> > >>>yar 2007-08-23 05:09:31 UTC > >>> > >>>FreeBSD src repository > >>> > >>>Modified files: > >>> lib/libc/gen fts-compat.c fts-compat.h > >>>Log: > >>>Forced commit to note repo-copy: > >>> > >>>These files have been repo-copied from src/include/fts.h > >>>and src/lib/libc/gen/fts.c to serve as a base for 4.4BSD > >>>compatible versions of fts(3) functions to be preserved > >>>through libc symbol versioning while the default versions > >>>undergo ABI-breaking extension to support big file trees. > >> > >>When are you going to break the ABI? After 7.0 is tagged > >>and released? If you break the ABI before, you don't need > >>or want to have the compat versions; the libraries have already > >>been bumped in prep for release. I don't think we want to > >>use symbol versioning as a crutch for -current users; the > >>version definitions are meant for public releases only. > > > >The reason for exercising symbol versions right now is that "make > >installworld" is sensitive to the fts(3) ABI. If the ABI is just > >broken w/o special measures, "make installworld" will fail in the > >middle and leave you with a botched system. It goes as follows: > > > >- "make installworld" copies the old /usr/bin/find and some other > > tools to /tmp/install.xxx for use during the install > >- libc is overwritten by its new instance, with new fts(3) ABI > >- the old find(1) is run by installworld and dumps core immediately. > > Why don't you make find and the install tools static. They are just copied from /usr/bin and friends before the actual install process starts. I had the idea of using newly built tools with LD_LIBRARY_PATH set to ${WORLDTMP}/{lib,usr/lib} for that purpose, but its discussion with ru@ didn't end up in a definite conclusion whether it was feasible. I haven't had time to experiment with my idea yet. > >Earlier the problem was to be avoided by bumping libc version so > >that the old libc is kept, and now I chose symbol versioning to get > >around it. Do you think there is a different way? > > Yes, you wait until after release to do this. Look at it Excuse me, but I don't want to have the bug I'm trying to fix (bin/104458) in 7.0-RELEASE. I'm certain we'll work out a way to have the bug fixed, with or without symbol versioning. > this way: if there wasn't symbol versioning and libc was > already bumped, how would you solve the problem? You > wouldn't bump libc again, right? I've believed that symbol versioning should help us to fix bugs, not prevent us from doing so. Not having to bump the libc version each time was the main reason to have symbol versioning, wasn't it? -- Yar From owner-cvs-src@FreeBSD.ORG Fri Aug 24 21:55:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A5C416A417; Fri, 24 Aug 2007 21:55:52 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mx1.freebsd.org (Postfix) with ESMTP id 990D213C48E; Fri, 24 Aug 2007 21:55:51 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l7OLtFqa016290; Sat, 25 Aug 2007 07:55:15 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l7OLtFOZ016289; Sat, 25 Aug 2007 07:55:15 +1000 (EST) (envelope-from peter) Date: Sat, 25 Aug 2007 07:55:15 +1000 From: Peter Jeremy To: Yar Tikhiy Message-ID: <20070824215515.GF16131@turion.vk2pj.dyndns.org> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <20070824183630.GA99474@comp.chem.msu.su> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 21:55:52 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-Aug-24 22:36:30 +0400, Yar Tikhiy wrote: >The reason for exercising symbol versions right now is that "make >installworld" is sensitive to the fts(3) ABI. If the ABI is just >broken w/o special measures, "make installworld" will fail in the >middle and leave you with a botched system. It goes as follows: > >- "make installworld" copies the old /usr/bin/find and some other > tools to /tmp/install.xxx for use during the install >- libc is overwritten by its new instance, with new fts(3) ABI >- the old find(1) is run by installworld and dumps core immediately. The other option is to update the "copy old executables" part of installworld to also copy relevant old shared libraries and force their use for the "make reinstall" via LD_LIBRARY_PATH. --=20 Peter Jeremy --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGz1PD/opHv/APuIcRAnVtAKCYUMUkyNin/HkhhayMAizp+4cGngCfd6LB G9cX+8OOVbbkqTW/rDpyi8s= =+jnx -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- From owner-cvs-src@FreeBSD.ORG Fri Aug 24 22:04:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8959B16A419; Fri, 24 Aug 2007 22:04:52 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 7595213C46E; Fri, 24 Aug 2007 22:04:52 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id B95561A4D8D; Fri, 24 Aug 2007 15:02:44 -0700 (PDT) Date: Fri, 24 Aug 2007 15:02:44 -0700 From: Alfred Perlstein To: Peter Jeremy Message-ID: <20070824220244.GH87451@elvis.mu.org> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> <20070824215515.GF16131@turion.vk2pj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070824215515.GF16131@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.4.2.3i Cc: Yar Tikhiy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 22:04:52 -0000 Not to pick on anyone here but Yar did something that works, why exactly are we not allowing him to use the tools provided for this exact purpose and instead making him do convoluted workarounds? I mean seriously, so we have a versioned symbol that could possibly be avoided by a lot of hard work and magic which will probably fail for a bunch of users.... ...so why not just use what works? -Alfred * Peter Jeremy [070824 14:53] wrote: > On 2007-Aug-24 22:36:30 +0400, Yar Tikhiy wrote: > >The reason for exercising symbol versions right now is that "make > >installworld" is sensitive to the fts(3) ABI. If the ABI is just > >broken w/o special measures, "make installworld" will fail in the > >middle and leave you with a botched system. It goes as follows: > > > >- "make installworld" copies the old /usr/bin/find and some other > > tools to /tmp/install.xxx for use during the install > >- libc is overwritten by its new instance, with new fts(3) ABI > >- the old find(1) is run by installworld and dumps core immediately. > > The other option is to update the "copy old executables" part of > installworld to also copy relevant old shared libraries and force > their use for the "make reinstall" via LD_LIBRARY_PATH. > > -- > Peter Jeremy -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Fri Aug 24 22:21:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63D2716A417; Fri, 24 Aug 2007 22:21:57 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 245DE13C461; Fri, 24 Aug 2007 22:21:56 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7OM3Zxr003868; Fri, 24 Aug 2007 18:03:35 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Fri, 24 Aug 2007 18:03:35 -0400 (EDT) Date: Fri, 24 Aug 2007 18:03:35 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070824214429.GB99474@comp.chem.msu.su> Message-ID: References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> <20070824214429.GB99474@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 22:21:57 -0000 On Sat, 25 Aug 2007, Yar Tikhiy wrote: > On Fri, Aug 24, 2007 at 03:14:53PM -0400, Daniel Eischen wrote: > >> this way: if there wasn't symbol versioning and libc was >> already bumped, how would you solve the problem? You >> wouldn't bump libc again, right? > > I've believed that symbol versioning should help us to fix bugs, not > prevent us from doing so. Not having to bump the libc version each > time was the main reason to have symbol versioning, wasn't it? The version defs and symbol versioning are for releases, and not meant for use to solve -current upgrade problems. You wouldn't see Sun bump their public version definitions to work around interim ABI changes in their development tree. We will always have issues like this for those running and developing in -current, and we shouldn't be using public version definitions to work around our own internal build problems. -- DE From owner-cvs-src@FreeBSD.ORG Fri Aug 24 22:25:33 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C0DE16A417; Fri, 24 Aug 2007 22:25:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 284D613C45A; Fri, 24 Aug 2007 22:25:28 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7OMPH3h016514; Fri, 24 Aug 2007 18:25:17 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Fri, 24 Aug 2007 18:25:18 -0400 (EDT) Date: Fri, 24 Aug 2007 18:25:17 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Alfred Perlstein In-Reply-To: <20070824220244.GH87451@elvis.mu.org> Message-ID: References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Yar Tikhiy Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 22:25:33 -0000 On Fri, 24 Aug 2007, Alfred Perlstein wrote: > Not to pick on anyone here but Yar did something that works, > why exactly are we not allowing him to use the tools provided > for this exact purpose and instead making him do convoluted > workarounds? > > I mean seriously, so we have a versioned symbol that could > possibly be avoided by a lot of hard work and magic which will > probably fail for a bunch of users.... > > ...so why not just use what works? Please, enough of this "it works, so why not?". We didn't always have symbol versioning, and we have solved these problems before without it. There seems to be an inherent problem with our build system, and the LD_LIBRARY_PATH trick seems to make sense to me, or building and installing the install tools as static to avoid problems like this. I never added symbol versioning to libc in order to solve -current upgrade problems. Sure, you're free to use it that way, but it would not make me very happy ;-) -- DE From owner-cvs-src@FreeBSD.ORG Fri Aug 24 22:31:06 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE80F16A469 for ; Fri, 24 Aug 2007 22:31:06 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.226]) by mx1.freebsd.org (Postfix) with ESMTP id 46CA813C46C for ; Fri, 24 Aug 2007 22:31:06 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so703975wra for ; Fri, 24 Aug 2007 15:31:05 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=k9PoNwaGRNCd2qASOmo2+FZUX5M9s5bd5h+UV2qpUv9EzLBO5aonT8VNj5+AddWtSTHGzG1AewyJJ+Y1iwvXV41ToelbYAs1uDkKZT10UTUl1/SDaioivS5zhlwiJdm0CO6gGH87x/BjPmcEI1ULP6jpjFtAa0BNdOpeiCiN+8w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=LBfnASvgvKB0fMalhVoFR40ola4Vw1Koo1mtCBhfnEdPSRXGyi4aKoqZwmPOvY7Fwz5Qug8lzSidW6+H7h/8XB/RlcE37G8Fcb9+8ILH2sKkawTBFihzdBEcfu8cELvOBuUZQZWGrmNd+2rMMzgPDecyHB+g0M6YvJSFx/r4X0Y= Received: by 10.90.101.19 with SMTP id y19mr9769360agb.1187994665285; Fri, 24 Aug 2007 15:31:05 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Fri, 24 Aug 2007 15:31:05 -0700 (PDT) Message-ID: Date: Fri, 24 Aug 2007 18:31:05 -0400 From: "Constantine A. Murenin" Sender: mureninc@gmail.com To: "Nate Lawson" In-Reply-To: <46CDA669.8080601@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200708231053.l7NAr3Pc088160@repoman.freebsd.org> <86zm0izfhf.fsf@ds4.des.no> <46CDA669.8080601@root.org> X-Google-Sender-Auth: eb02adbb614bc472 Cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= , src-committers@freebsd.org, "Constantine A. Murenin" , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 22:31:06 -0000 On 23/08/07, Nate Lawson wrote: > Dag-Erling Sm=F8rgrav wrote: > > Dag-Erling Smorgrav writes: > >> Log: > >> Style nits + more reliable Tj(max) detection + improved reporting of > >> critical temperature + sched_unbind() after rdmsr + initialize sc_de= v. > > > > I should note that the driver currently only checks for (and reports) a > > critical temperature when you read the sysctl; if you want to use devd > > to react to a critical temperature, you need to set up a cron job to > > poll dev.cpu.N.temperature. Hopefully, a future version of the driver > > will install an interrupt handler and activate the temperature threshol= d > > interrupts. > > > > DES > > You could also create a polling thread that runs every 10 seconds. We > have that for acpi_thermal currently. Actually, this is what coretemp(4) does in my cnst-sensors p4 branch, using a sensor_task, people are welcome to test it. ;) C. From owner-cvs-src@FreeBSD.ORG Fri Aug 24 23:25:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63F2016A418; Fri, 24 Aug 2007 23:25:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 009DE13C428; Fri, 24 Aug 2007 23:25:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7ONMCtV053762; Fri, 24 Aug 2007 17:22:12 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 24 Aug 2007 17:22:12 -0600 (MDT) Message-Id: <20070824.172212.74696955.imp@bsdimp.com> To: deischen@FreeBSD.org From: Warner Losh In-Reply-To: References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 24 Aug 2007 17:22:13 -0600 (MDT) Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2007 23:25:29 -0000 From: Daniel Eischen Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h Date: Fri, 24 Aug 2007 18:25:17 -0400 (EDT) > On Fri, 24 Aug 2007, Alfred Perlstein wrote: > > > Not to pick on anyone here but Yar did something that works, > > why exactly are we not allowing him to use the tools provided > > for this exact purpose and instead making him do convoluted > > workarounds? > > > > I mean seriously, so we have a versioned symbol that could > > possibly be avoided by a lot of hard work and magic which will > > probably fail for a bunch of users.... > > > > ...so why not just use what works? > > Please, enough of this "it works, so why not?". We didn't always > have symbol versioning, and we have solved these problems before > without it. There seems to be an inherent problem with our > build system, and the LD_LIBRARY_PATH trick seems to make sense > to me, or building and installing the install tools as static > to avoid problems like this. The other problem, once you get past the build tools, is now all your ports binaries do not work. While people running current are big boys and girls, it is a pain to have to frequently rebuild them. > I never added symbol versioning to libc in order to solve > -current upgrade problems. Sure, you're free to use it that > way, but it would not make me very happy ;-) So who cares if we find new uses for tools? I never thought devd would be used for network state transition... What's the overhead of having the transition crutch around for a while? The benefit is that people are less likely to screw up their systems at a time when we want to encourage people to upgrade so they can test the latest/greatest version. If it were 9 months after RELENG_6 was branched, and a long time to a release, then I'd be much more inclined to agree with the 'current is hard, so why spend engineering effort on making it easy' crowd than I would now that more of the world is watching and using it since we're in the glide path to beta1. I don't see why we can't put the versioned symbols in, let everybody upgrade and then remove the old symbols after a big enough window has passed. It isn't like they are hurting anything by being there, is it? If there is some actual harm here, it hasn't been clearly articulated and needs to be if that's the case. I'm certainly open to this possibility. Just my humble opinion. Warner From owner-cvs-src@FreeBSD.ORG Sat Aug 25 00:19:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 010C916A417; Sat, 25 Aug 2007 00:19:18 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CF44913C45A; Sat, 25 Aug 2007 00:19:17 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P0JHCD057930; Sat, 25 Aug 2007 00:19:17 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P0JHxK057929; Sat, 25 Aug 2007 00:19:17 GMT (envelope-from matteo) Message-Id: <200708250019.l7P0JHxK057929@repoman.freebsd.org> From: Matteo Riondato Date: Sat, 25 Aug 2007 00:19:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d mdconfig X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 00:19:18 -0000 matteo 2007-08-25 00:19:17 UTC FreeBSD src repository Modified files: etc/rc.d mdconfig Log: sleep 2 seconds after having loaded g_uzip.ko. We need this because otherwise the /dev/mdX.uzip won't be created immediately, which is needed because we issue a mount right afterwards. Approved by: re@ (bmah@) MFC after: 2 days Revision Changes Path 1.5 +2 -0 src/etc/rc.d/mdconfig From owner-cvs-src@FreeBSD.ORG Sat Aug 25 00:28:59 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75D0016A419; Sat, 25 Aug 2007 00:28:59 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc14.comcast.net (rwcrmhc14.comcast.net [204.127.192.84]) by mx1.freebsd.org (Postfix) with ESMTP id 5E22313C457; Sat, 25 Aug 2007 00:28:59 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from _hostname_ (c-66-31-37-31.hsd1.ma.comcast.net[66.31.37.31]) by comcast.net (rwcrmhc14) with SMTP id <20070825002858m1400khnv9e>; Sat, 25 Aug 2007 00:28:58 +0000 Received: by _HOSTNAME_ (sSMTP sendmail emulation); Fri, 24 Aug 2007 20:28:57 -0400 From: "Craig Rodrigues" Date: Fri, 24 Aug 2007 20:28:57 -0400 To: Bruce M Simpson Message-ID: <20070825002857.GA12650@crodrigues.org> References: <200708242025.l7OKPqkJ030845@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708242025.l7OKPqkJ030845@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include/arpa inet.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 00:28:59 -0000 On Fri, Aug 24, 2007 at 08:25:52PM +0000, Bruce M Simpson wrote: > bms 2007-08-24 20:25:52 UTC > > FreeBSD src repository > > Modified files: > include/arpa inet.h > Log: > Remove old prototypes for addr2ascii() and ascii2addr(), functions which no > longer exist in libc. > > Requested by: Craig Rodrigues > Approved by: re (kensmith) > > Revision Changes Path > 1.30 +0 -2 src/include/arpa/inet.h Thanks!! -- Craig Rodrigues rodrigc@crodrigues.org From owner-cvs-src@FreeBSD.ORG Sat Aug 25 03:08:13 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C021316A418; Sat, 25 Aug 2007 03:08:13 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 7972B13C442; Sat, 25 Aug 2007 03:08:13 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7P381d3029227; Fri, 24 Aug 2007 23:08:01 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Fri, 24 Aug 2007 23:08:01 -0400 (EDT) Date: Fri, 24 Aug 2007 23:08:01 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Warner Losh In-Reply-To: <20070824.172212.74696955.imp@bsdimp.com> Message-ID: References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> <20070824.172212.74696955.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 03:08:14 -0000 On Fri, 24 Aug 2007, Warner Losh wrote: > From: Daniel Eischen > Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h > Date: Fri, 24 Aug 2007 18:25:17 -0400 (EDT) > > The other problem, once you get past the build tools, is now all your > ports binaries do not work. While people running current are big boys > and girls, it is a pain to have to frequently rebuild them. I guess the build system should be more tolerant of this, but there are bound to be problems regardless. I don't see why the install tools can't also either have their own set of libraries (utilizing LD_LIBRARY_PATH) or be built static. >> I never added symbol versioning to libc in order to solve >> -current upgrade problems. Sure, you're free to use it that >> way, but it would not make me very happy ;-) > > So who cares if we find new uses for tools? I never thought devd > would be used for network state transition... > > What's the overhead of having the transition crutch around for a > while? The benefit is that people are less likely to screw up their > systems at a time when we want to encourage people to upgrade so they > can test the latest/greatest version. If it were 9 months after > RELENG_6 was branched, and a long time to a release, then I'd be much > more inclined to agree with the 'current is hard, so why spend > engineering effort on making it easy' crowd than I would now that more > of the world is watching and using it since we're in the glide path to > beta1. > > I don't see why we can't put the versioned symbols in, let everybody > upgrade and then remove the old symbols after a big enough window has > passed. It isn't like they are hurting anything by being there, is > it? If you are going to remove the interim versioned symbols, that's OK with me, but what are you going to do for the people that miss the transistion period (after the interim symbols are removed)? Shouldn't the build system work regardless? If I understand correctly, I think the more general problem is that the install tools are dependent on working with new libraries. > If there is some actual harm here, it hasn't been clearly articulated > and needs to be if that's the case. I'm certainly open to this > possibility. It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, etc. The versioned symbol namespace is mostly to aid the release engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 are interim versions and FBSD_1.5 is release 7.1, that isn't good. Again, I highly doubt you would have Sun or even Linux have interim versions that are made public. If you want to have interim versions and then remove them at a later point before a release, that is a different story, but it doesn't solve the problem for someone missing the transition period, whereas a more general solution would. -- DE From owner-cvs-src@FreeBSD.ORG Sat Aug 25 03:37:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FF3716A418; Sat, 25 Aug 2007 03:37:31 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3C88013C483; Sat, 25 Aug 2007 03:37:31 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7P3aCcT055309; Fri, 24 Aug 2007 21:36:12 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 24 Aug 2007 21:36:15 -0600 (MDT) Message-Id: <20070824.213615.146406398.imp@bsdimp.com> To: deischen@freebsd.org From: "M. Warner Losh" In-Reply-To: References: <20070824.172212.74696955.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 24 Aug 2007 21:36:12 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 03:37:31 -0000 In message: Daniel Eischen writes: : On Fri, 24 Aug 2007, Warner Losh wrote: : : > From: Daniel Eischen : > Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h : > Date: Fri, 24 Aug 2007 18:25:17 -0400 (EDT) : > : > The other problem, once you get past the build tools, is now all your : > ports binaries do not work. While people running current are big boys : > and girls, it is a pain to have to frequently rebuild them. : : I guess the build system should be more tolerant of this, but : there are bound to be problems regardless. I don't see why : the install tools can't also either have their own set of : libraries (utilizing LD_LIBRARY_PATH) or be built static. There's much resistance to building everything that the build system might be used being build static. It adds too much time and complexity to the build system, the opponents say. : >> I never added symbol versioning to libc in order to solve : >> -current upgrade problems. Sure, you're free to use it that : >> way, but it would not make me very happy ;-) : > : > So who cares if we find new uses for tools? I never thought devd : > would be used for network state transition... : > : > What's the overhead of having the transition crutch around for a : > while? The benefit is that people are less likely to screw up their : > systems at a time when we want to encourage people to upgrade so they : > can test the latest/greatest version. If it were 9 months after : > RELENG_6 was branched, and a long time to a release, then I'd be much : > more inclined to agree with the 'current is hard, so why spend : > engineering effort on making it easy' crowd than I would now that more : > of the world is watching and using it since we're in the glide path to : > beta1. : > : > I don't see why we can't put the versioned symbols in, let everybody : > upgrade and then remove the old symbols after a big enough window has : > passed. It isn't like they are hurting anything by being there, is : > it? : : If you are going to remove the interim versioned symbols, that's : OK with me, but what are you going to do for the people that miss the : transistion period (after the interim symbols are removed)? Shouldn't : the build system work regardless? If I understand correctly, I think : the more general problem is that the install tools are dependent on : working with new libraries. Should? Yes. However, it never has. There has always been the possibility that an incompatible change to libc would take out the build tools. People have been good enough to not change base ABIs to prevent this from happening, for the most part. : > If there is some actual harm here, it hasn't been clearly articulated : > and needs to be if that's the case. I'm certainly open to this : > possibility. : : It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, : etc. The versioned symbol namespace is mostly to aid the release : engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 : are interim versions and FBSD_1.5 is release 7.1, that isn't good. But FBSD_0.9 could be used, no? : Again, I highly doubt you would have Sun or even Linux have interim : versions that are made public. If you want to have interim versions : and then remove them at a later point before a release, that is a : different story, but it doesn't solve the problem for someone missing : the transition period, whereas a more general solution would. I was thinking of leaving it in, undocumented, for the release. We're in a period of transition to the symbol versioning anyway. If there's one or two bumps as we do so, then so be it. In the past, we've only supported upgrading across major releases (eg, 5.x -> 6.0 but not 6.1). And having a robust build system still doesn't solve the ports problem I alluded to. All of them would still need to be rebuilt. I'm surprised that we're not looking at this as a dry-run for symbol versioning to see how well it helps in a well controlled case and to learn from something we can make a mistake on without huge consequences. Warner From owner-cvs-src@FreeBSD.ORG Sat Aug 25 03:49:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3BD516A418; Sat, 25 Aug 2007 03:49:12 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ADF4413C428; Sat, 25 Aug 2007 03:49:12 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P3nC0o083354; Sat, 25 Aug 2007 03:49:12 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P3nCGP083353; Sat, 25 Aug 2007 03:49:12 GMT (envelope-from kientzle) Message-Id: <200708250349.l7P3nCGP083353@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 03:49:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libarchive Makefile archive_read_support_format_tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 03:49:12 -0000 kientzle 2007-08-25 03:49:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libarchive Makefile archive_read_support_format_tar.c Log: MFC archive_read_support_format_tar.c 1.61 This updates the support for GNU tar --posix --sparse archive entries to be compatible with GNU tar 1.17. Revision Changes Path 1.36.2.10 +1 -1 src/lib/libarchive/Makefile 1.32.2.8 +63 -47 src/lib/libarchive/archive_read_support_format_tar.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 03:58:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 163E916A419; Sat, 25 Aug 2007 03:58:26 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E4A9C13C468; Sat, 25 Aug 2007 03:58:25 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P3wP69084203; Sat, 25 Aug 2007 03:58:25 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P3wPfr084202; Sat, 25 Aug 2007 03:58:25 GMT (envelope-from kientzle) Message-Id: <200708250358.l7P3wPfr084202@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 03:58:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar Makefile bsdtar_platform.h config_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 03:58:26 -0000 kientzle 2007-08-25 03:58:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar Makefile bsdtar_platform.h Added files: (Branch: RELENG_6) usr.bin/tar config_freebsd.h Log: MFC refactored platform configuration. Separate platform-specific config into config_freebsd.h. Changes to Makefile and bsdtar_platform.h to use this instead of coding the FreeBSD configuration into bsdtar_platform.h Revision Changes Path 1.24.2.2 +1 -0 src/usr.bin/tar/Makefile 1.15.2.9 +5 -74 src/usr.bin/tar/bsdtar_platform.h 1.1.2.1 +105 -0 src/usr.bin/tar/config_freebsd.h (new) From owner-cvs-src@FreeBSD.ORG Sat Aug 25 03:59:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D44CC16A418; Sat, 25 Aug 2007 03:59:52 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ADB2213C468; Sat, 25 Aug 2007 03:59:52 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P3xqRJ084270; Sat, 25 Aug 2007 03:59:52 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P3xq9w084269; Sat, 25 Aug 2007 03:59:52 GMT (envelope-from kientzle) Message-Id: <200708250359.l7P3xq9w084269@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 03:59:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar bsdtar_platform.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 03:59:52 -0000 kientzle 2007-08-25 03:59:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar bsdtar_platform.h Log: MFC whitespace fixes. Revision Changes Path 1.15.2.10 +2 -2 src/usr.bin/tar/bsdtar_platform.h From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:08:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D3E516A419; Sat, 25 Aug 2007 04:08:46 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 57C9C13C45B; Sat, 25 Aug 2007 04:08:46 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P48ki0086186; Sat, 25 Aug 2007 04:08:46 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P48kmF086185; Sat, 25 Aug 2007 04:08:46 GMT (envelope-from kientzle) Message-Id: <200708250408.l7P48kmF086185@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:08:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:08:46 -0000 kientzle 2007-08-25 04:08:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar write.c Log: MFC refactored code to copy entry from one archive to another. This is the code that implements the @ interpolation feature. Revision Changes Path 1.41.2.9 +65 -30 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:11:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95E8B16A41A; Sat, 25 Aug 2007 04:11:48 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7029013C459; Sat, 25 Aug 2007 04:11:48 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4BmTV086542; Sat, 25 Aug 2007 04:11:48 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4Bmt2086541; Sat, 25 Aug 2007 04:11:48 GMT (envelope-from kientzle) Message-Id: <200708250411.l7P4Bmt2086541@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:11:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:11:48 -0000 kientzle 2007-08-25 04:11:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar read.c Log: MFC some miscellaneous casts to correct printing of numerical UIDs, GIDs, and device numbers in tar -tv output.a Revision Changes Path 1.23.2.5 +5 -5 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:14:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E5F216A417; Sat, 25 Aug 2007 04:14:29 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 08BE913C45A; Sat, 25 Aug 2007 04:14:29 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4ESPL086721; Sat, 25 Aug 2007 04:14:28 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4ESTJ086720; Sat, 25 Aug 2007 04:14:28 GMT (envelope-from kientzle) Message-Id: <200708250414.l7P4ESTJ086720@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:14:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:14:29 -0000 kientzle 2007-08-25 04:14:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar read.c Log: MFC corrected error handling on extraction. Revision Changes Path 1.23.2.6 +13 -15 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:19:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C613216A419; Sat, 25 Aug 2007 04:19:56 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A027613C469; Sat, 25 Aug 2007 04:19:56 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4JuQH086942; Sat, 25 Aug 2007 04:19:56 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4JuMM086941; Sat, 25 Aug 2007 04:19:56 GMT (envelope-from kientzle) Message-Id: <200708250419.l7P4JuMM086941@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:19:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar bsdtar.h util.c write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:19:57 -0000 kientzle 2007-08-25 04:19:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar bsdtar.h util.c write.c Log: MFC generic path comparisons. There was some old code to ignore leading "./" that was there to allow us to compare path names with strcmp(). Comparing pathnames syntactically is a bit more complex than that, so encapsulate it in a new utility function and use that instead. Revision Changes Path 1.23.2.4 +1 -0 src/usr.bin/tar/bsdtar.h 1.13.2.3 +39 -4 src/usr.bin/tar/util.c 1.41.2.10 +1 -4 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:21:19 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0136916A418; Sat, 25 Aug 2007 04:21:19 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CFA3613C461; Sat, 25 Aug 2007 04:21:18 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4LIwS087157; Sat, 25 Aug 2007 04:21:18 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4LIkG087156; Sat, 25 Aug 2007 04:21:18 GMT (envelope-from kientzle) Message-Id: <200708250421.l7P4LIkG087156@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:21:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar util.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:21:19 -0000 kientzle 2007-08-25 04:21:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar util.c Log: MFC include guards. Revision Changes Path 1.13.2.4 +12 -0 src/usr.bin/tar/util.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:24:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BAA316A41B; Sat, 25 Aug 2007 04:24:53 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2591813C45D; Sat, 25 Aug 2007 04:24:53 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4OrID087402; Sat, 25 Aug 2007 04:24:53 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4Oqjs087401; Sat, 25 Aug 2007 04:24:52 GMT (envelope-from kientzle) Message-Id: <200708250424.l7P4Oqjs087401@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:24:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar bsdtar.1 bsdtar.c bsdtar.h read.c write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:24:53 -0000 kientzle 2007-08-25 04:24:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar bsdtar.1 bsdtar.c bsdtar.h read.c write.c Log: MFC --use-compress-program support. Revision Changes Path 1.29.2.4 +4 -0 src/usr.bin/tar/bsdtar.1 1.63.2.10 +6 -0 src/usr.bin/tar/bsdtar.c 1.23.2.5 +1 -0 src/usr.bin/tar/bsdtar.h 1.23.2.7 +4 -1 src/usr.bin/tar/read.c 1.41.2.11 +18 -13 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:26:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A42A916A419; Sat, 25 Aug 2007 04:26:00 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7EF6F13C428; Sat, 25 Aug 2007 04:26:00 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4Q0nF087504; Sat, 25 Aug 2007 04:26:00 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4Q09L087503; Sat, 25 Aug 2007 04:26:00 GMT (envelope-from kientzle) Message-Id: <200708250426.l7P4Q09L087503@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:26:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar bsdtar.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:26:00 -0000 kientzle 2007-08-25 04:26:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar bsdtar.1 Log: MFC additional manpage comments to more widely publicize some of bsdtar's key features. Revision Changes Path 1.29.2.5 +6 -0 src/usr.bin/tar/bsdtar.1 From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:27:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1114B16A419; Sat, 25 Aug 2007 04:27:42 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DD62913C467; Sat, 25 Aug 2007 04:27:41 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4RfeS087588; Sat, 25 Aug 2007 04:27:41 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4RfuF087586; Sat, 25 Aug 2007 04:27:41 GMT (envelope-from kientzle) Message-Id: <200708250427.l7P4RfuF087586@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:27:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:27:42 -0000 kientzle 2007-08-25 04:27:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar write.c Log: MFC: Don't try to store file body if there was a fatal error writing the header. Revision Changes Path 1.41.2.12 +1 -1 src/usr.bin/tar/write.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:28:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88B4116A475; Sat, 25 Aug 2007 04:28:05 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6267213C4B5; Sat, 25 Aug 2007 04:28:04 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4S4oJ087647; Sat, 25 Aug 2007 04:28:04 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4S4qU087646; Sat, 25 Aug 2007 04:28:04 GMT (envelope-from kientzle) Message-Id: <200708250428.l7P4S4qU087646@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:28:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar util.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:28:05 -0000 kientzle 2007-08-25 04:28:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar util.c Log: MFC a comment. Revision Changes Path 1.13.2.5 +2 -0 src/usr.bin/tar/util.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:33:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A98016A41A; Sat, 25 Aug 2007 04:33:14 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 74BB813C474; Sat, 25 Aug 2007 04:33:14 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4XE0e088083; Sat, 25 Aug 2007 04:33:14 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4XE6a088082; Sat, 25 Aug 2007 04:33:14 GMT (envelope-from kientzle) Message-Id: <200708250433.l7P4XE6a088082@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:33:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar bsdtar.c read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:33:14 -0000 kientzle 2007-08-25 04:33:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar bsdtar.c read.c Log: MFC: Use libarchive's new security checks (which are much faster) instead of implementing them in bsdtar. Revision Changes Path 1.63.2.11 +9 -0 src/usr.bin/tar/bsdtar.c 1.23.2.8 +0 -137 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:35:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9631216A41A; Sat, 25 Aug 2007 04:35:22 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6FF4A13C481; Sat, 25 Aug 2007 04:35:22 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4ZM0m088226; Sat, 25 Aug 2007 04:35:22 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4ZM45088225; Sat, 25 Aug 2007 04:35:22 GMT (envelope-from kientzle) Message-Id: <200708250435.l7P4ZM45088225@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:35:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:35:22 -0000 kientzle 2007-08-25 04:35:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar Makefile Log: Update bsdtar version to 1.9 to match libarchive. At this point, bsdtar is identical to that in 7-CURRENT except for one small behavioral change that I'm debating. Revision Changes Path 1.24.2.3 +1 -1 src/usr.bin/tar/Makefile From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:38:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC7D716A419; Sat, 25 Aug 2007 04:38:44 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8628D13C459; Sat, 25 Aug 2007 04:38:44 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4ci39088389; Sat, 25 Aug 2007 04:38:44 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4ciYs088388; Sat, 25 Aug 2007 04:38:44 GMT (envelope-from kientzle) Message-Id: <200708250438.l7P4ciYs088388@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:38:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/tar Makefile bsdtar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:38:44 -0000 kientzle 2007-08-25 04:38:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/tar Makefile bsdtar.c Log: MFC: Enable -p by default for root, which seems to be what most people expect. Revision Changes Path 1.24.2.4 +1 -1 src/usr.bin/tar/Makefile 1.63.2.12 +9 -6 src/usr.bin/tar/bsdtar.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 04:42:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 074AC16A417; Sat, 25 Aug 2007 04:42:02 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D51AD13C457; Sat, 25 Aug 2007 04:42:01 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P4g1Aj088711; Sat, 25 Aug 2007 04:42:01 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P4g10C088710; Sat, 25 Aug 2007 04:42:01 GMT (envelope-from kientzle) Message-Id: <200708250442.l7P4g10C088710@repoman.freebsd.org> From: Tim Kientzle Date: Sat, 25 Aug 2007 04:42:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libarchive archive_write_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 04:42:02 -0000 kientzle 2007-08-25 04:42:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libarchive archive_write_disk.c Log: MFC: Opportunistic SUID/SGID restore. If owner restore wasn't requested, then SUID/SGID restore failures caused by owner/group mismatch won't be reported. Revision Changes Path 1.12.2.3 +22 -6 src/lib/libarchive/archive_write_disk.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 05:06:41 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C6F716A417; Sat, 25 Aug 2007 05:06:41 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 98BD413C46E; Sat, 25 Aug 2007 05:06:40 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7P56ca6014915; Sat, 25 Aug 2007 09:06:38 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7P56cev014914; Sat, 25 Aug 2007 09:06:38 +0400 (MSD) (envelope-from yar) Date: Sat, 25 Aug 2007 09:06:37 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070825050637.GF99474@comp.chem.msu.su> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070824183630.GA99474@comp.chem.msu.su> <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: Peter Jeremy , Alfred Perlstein , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 05:06:41 -0000 On Fri, Aug 24, 2007 at 06:25:17PM -0400, Daniel Eischen wrote: > On Fri, 24 Aug 2007, Alfred Perlstein wrote: > > >Not to pick on anyone here but Yar did something that works, > >why exactly are we not allowing him to use the tools provided > >for this exact purpose and instead making him do convoluted > >workarounds? > > > >I mean seriously, so we have a versioned symbol that could > >possibly be avoided by a lot of hard work and magic which will > >probably fail for a bunch of users.... > > > >...so why not just use what works? > > Please, enough of this "it works, so why not?". We didn't always > have symbol versioning, and we have solved these problems before > without it. Before the latex condom came into wide use, people had had to resort to rather funny things for birth control and protection. > There seems to be an inherent problem with our > build system, and the LD_LIBRARY_PATH trick seems to make sense > to me, or building and installing the install tools as static > to avoid problems like this. No doubt our build system is far from ideal, but, according to various discussions, there are more reasons for that than just developers' being lazy and prefering quick'n'dirty fixes. > I never added symbol versioning to libc in order to solve > -current upgrade problems. Sure, you're free to use it that > way, but it would not make me very happy ;-) You put it as though symbol versioning is your area of interest and you just don't want any intruders to tamper with it. It wouldn't have seemed so if there had been a well-defined policy on symbol versioning usage somewhere on www.freebsd.org. -- Yar From owner-cvs-src@FreeBSD.ORG Sat Aug 25 05:10:33 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C1F116A417; Sat, 25 Aug 2007 05:10:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5CF3E13C428; Sat, 25 Aug 2007 05:10:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7P5AMMu016870; Sat, 25 Aug 2007 01:10:22 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sat, 25 Aug 2007 01:10:23 -0400 (EDT) Date: Sat, 25 Aug 2007 01:10:22 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070824.213615.146406398.imp@bsdimp.com> Message-ID: References: <20070824.172212.74696955.imp@bsdimp.com> <20070824.213615.146406398.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 05:10:33 -0000 On Fri, 24 Aug 2007, M. Warner Losh wrote: > There's much resistance to building everything that the build system > might be used being build static. It adds too much time and > complexity to the build system, the opponents say. So install libc and use LD_LIBRARY_PATH so the build use it instead of /lib/libc.so. > : If you are going to remove the interim versioned symbols, that's > : OK with me, but what are you going to do for the people that miss the > : transistion period (after the interim symbols are removed)? Shouldn't > : the build system work regardless? If I understand correctly, I think > : the more general problem is that the install tools are dependent on > : working with new libraries. > > Should? Yes. However, it never has. There has always been the > possibility that an incompatible change to libc would take out the > build tools. People have been good enough to not change base ABIs to > prevent this from happening, for the most part. Install the old libc and let the build tools use it... > : > If there is some actual harm here, it hasn't been clearly articulated > : > and needs to be if that's the case. I'm certainly open to this > : > possibility. > : > : It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, > : etc. The versioned symbol namespace is mostly to aid the release > : engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 > : are interim versions and FBSD_1.5 is release 7.1, that isn't good. > > But FBSD_0.9 could be used, no? Or FBSD_0.hack I suppose too ;-) > : Again, I highly doubt you would have Sun or even Linux have interim > : versions that are made public. If you want to have interim versions > : and then remove them at a later point before a release, that is a > : different story, but it doesn't solve the problem for someone missing > : the transition period, whereas a more general solution would. > > I was thinking of leaving it in, undocumented, for the release. Please don't do that. > And having a robust build system still doesn't solve the ports problem > I alluded to. All of them would still need to be rebuilt. Yes, but this is -current and we've always dealt with it. After the first release with symbol versioning, it shouldn't matter anyways unless you change the ABI of the same thing more than once in a version def. Consider: FBSD_1.0 { global: ... fts_open; fts_read; fts_children; ... local: *; }; After 7.0 release (with FBSD_1.0 as the version), you decide to change the ABI for fts_open: FBSD_1.0 { global: ... fts_open; fts_read; fts_children; ... }; FBSD_1.1 { global: fts_open; local: *; } FBSD_1.0; Now you decide to change the ABI for fts_read: FBSD_1.0 { global: fts_open; fts_read; fts_children; ... }; FBSD_1.1 { global: fts_open; fts_read; local *; } FBSD_1.0; You can change the ABI as many times as you want without adding a new version definition, as long as you don't change the _same_ ABI. If you change the same ABI more than once, then yes, you have to rebuild all your ports and perhaps deal with build problems. The fts change should either deal with the upgrade problems or wait until after release when it won't be a problem. -- DE From owner-cvs-src@FreeBSD.ORG Sat Aug 25 05:33:08 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CE0C16A41A; Sat, 25 Aug 2007 05:33:08 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id C089A13C461; Sat, 25 Aug 2007 05:33:07 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7P5X311015135; Sat, 25 Aug 2007 09:33:03 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7P5X3na015128; Sat, 25 Aug 2007 09:33:03 +0400 (MSD) (envelope-from yar) Date: Sat, 25 Aug 2007 09:33:03 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070825053302.GG99474@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> <20070824.172212.74696955.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 05:33:08 -0000 On Fri, Aug 24, 2007 at 11:08:01PM -0400, Daniel Eischen wrote: > > It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, > etc. The versioned symbol namespace is mostly to aid the release > engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 > are interim versions and FBSD_1.5 is release 7.1, that isn't good. I've been sure until this thread that symbol versioning removes the whole need to bump versions artificially before each major release in favor of natural versioning, when a symbol proceeds along the version scale only if its properties actually change. Old versions can be removed, e.g., one major release later if needed, but ABIs change not too often and it may be reasonable to keep old versions of symbols and forget about separate compat libraries. That's how I imagined the benefits from symbol versioning. Was I totally wrong? In addition, symbol versions are mere text labels with no special meaning to ld(1), so we can format them to allow for version changes between major releases. > Again, I highly doubt you would have Sun or even Linux have interim > versions that are made public. If you want to have interim versions > and then remove them at a later point before a release, that is a > different story, but it doesn't solve the problem for someone missing > the transition period, whereas a more general solution would. Not that I'm pressing you to accept my POV, but it's not the first time I get into an argument regarding our symbol versioning implementation and usage, and receive only vague references to Sun and Linux "not doing this way". It seems high time to define clearly what _we_ (not Sun, Linux, you, or I) want from that symbol versioning thing and document it. -- Yar From owner-cvs-src@FreeBSD.ORG Sat Aug 25 05:47:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D80F16A418; Sat, 25 Aug 2007 05:47:55 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1697E13C45D; Sat, 25 Aug 2007 05:47:55 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7P5lsdk003908; Sat, 25 Aug 2007 05:47:54 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7P5li7Z003905; Sat, 25 Aug 2007 05:47:44 GMT (envelope-from alc) Message-Id: <200708250547.l7P5li7Z003905@repoman.freebsd.org> From: Alan Cox Date: Sat, 25 Aug 2007 05:47:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm vm_fault.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 05:47:55 -0000 alc 2007-08-25 05:47:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vm_fault.c Log: MFC revision 1.233 When a cached page is reactivated in vm_fault(), update the counter that tracks the total number of reactivated pages. (We have not been counting reactivations by vm_fault() since revision 1.46.) Correct a comment in vm_fault_additional_pages(). Revision Changes Path 1.205.2.6 +10 -7 src/sys/vm/vm_fault.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 15:40:16 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FA3316A41A; Sat, 25 Aug 2007 15:40:16 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id EC2D813C46C; Sat, 25 Aug 2007 15:40:15 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7PFdLmw070424; Sat, 25 Aug 2007 09:39:22 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 25 Aug 2007 09:39:25 -0600 (MDT) Message-Id: <20070825.093925.43008968.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20070825053302.GG99474@comp.chem.msu.su> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 25 Aug 2007 09:39:22 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 15:40:16 -0000 In message: <20070825053302.GG99474@comp.chem.msu.su> Yar Tikhiy writes: : On Fri, Aug 24, 2007 at 11:08:01PM -0400, Daniel Eischen wrote: : > : > It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, : > etc. The versioned symbol namespace is mostly to aid the release : > engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 : > are interim versions and FBSD_1.5 is release 7.1, that isn't good. : : I've been sure until this thread that symbol versioning removes the : whole need to bump versions artificially before each major release : in favor of natural versioning, when a symbol proceeds along the : version scale only if its properties actually change. That was my understanding as well. The artificial version bump is way lame, but is one of the less bad alternatives. : Old versions : can be removed, e.g., one major release later if needed, but ABIs : change not too often and it may be reasonable to keep old versions : of symbols and forget about separate compat libraries. That's how : I imagined the benefits from symbol versioning. Was I totally wrong? That was my understanding of the promise of symbol versioning. The hard part would be forcing people to make compatible changes all the time to all the libraries that did versioning. : In addition, symbol versions are mere text labels with no special : meaning to ld(1), so we can format them to allow for version changes : between major releases. Agreed. : > Again, I highly doubt you would have Sun or even Linux have interim : > versions that are made public. If you want to have interim versions : > and then remove them at a later point before a release, that is a : > different story, but it doesn't solve the problem for someone missing : > the transition period, whereas a more general solution would. : : Not that I'm pressing you to accept my POV, but it's not the first : time I get into an argument regarding our symbol versioning : implementation and usage, and receive only vague references to Sun : and Linux "not doing this way". It seems high time to define clearly : what _we_ (not Sun, Linux, you, or I) want from that symbol versioning : thing and document it. Also agreed. We're FreeBSD. We are tool users. We should use tools in a way that makes sense for us. Solaris' and Linux's experiences with versioning should inform our policies, there is no doubt, but since I don't think I've seen either written down in exacting detail that we can just import, there does need to be at least some effort to write up what the party line is. Warner From owner-cvs-src@FreeBSD.ORG Sat Aug 25 18:43:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B849D16A417; Sat, 25 Aug 2007 18:43:16 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A2EE613C442; Sat, 25 Aug 2007 18:43:16 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PIhG7U094016; Sat, 25 Aug 2007 18:43:16 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PIhGNx094015; Sat, 25 Aug 2007 18:43:16 GMT (envelope-from alc) Message-Id: <200708251843.l7PIhGNx094015@repoman.freebsd.org> From: Alan Cox Date: Sat, 25 Aug 2007 18:43:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm vm_fault.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 18:43:16 -0000 alc 2007-08-25 18:43:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vm_fault.c Log: MFC revision 1.234 Eliminate the special case handling of OBJT_DEVICE objects in vm_fault_additional_pages() that was introduced in revision 1.47. Then as now, it is unnecessary because dev_pager_haspage() returns zero for both the number of pages to read ahead and read behind, producing the same exact behavior by vm_fault_additional_pages() as the special case handling. MFC revision 1.235 Two changes to vm_fault_additional_pages(): 1. Rewrite the backward scan. Specifically, reverse the order in which pages are allocated so that upon failure it is never necessary to free pages that were just allocated. Moreover, any allocated pages can be put to use. This makes the backward scan behave just like the forward scan. 2. Eliminate an explicit, unsynchronized check for low memory before calling vm_page_alloc(). It serves no useful purpose. It is, in effect, optimizing the uncommon case at the expense of the common case. Revision Changes Path 1.205.2.7 +11 -28 src/sys/vm/vm_fault.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 19:14:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0ADD916A419; Sat, 25 Aug 2007 19:14:31 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E76C113C459; Sat, 25 Aug 2007 19:14:30 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PJEUk2097138; Sat, 25 Aug 2007 19:14:30 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PJEUTZ097136; Sat, 25 Aug 2007 19:14:30 GMT (envelope-from alc) Message-Id: <200708251914.l7PJEUTZ097136@repoman.freebsd.org> From: Alan Cox Date: Sat, 25 Aug 2007 19:14:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 19:14:31 -0000 alc 2007-08-25 19:14:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vnode_pager.c Log: MFC revision 1.231 Change vnode_pager_addr() such that on returning it distinguishes between an error returned by VOP_BMAP() and a hole in the file. Change the callers to vnode_pager_addr() such that they return VM_PAGER_ERROR when VOP_BMAP fails instead of a zero-filled page. MFC revision 1.232 Long ago, revision 1.22 of vm/vm_pager.h introduced a bug. Specifically, it introduced a check after the call to file system's get pages method that assumes that the get pages method does not change the array of pages that is passed to it. In the case of vnode_pager_generic_getpages(), this assumption has been incorrect. The contents of the array of pages may be shifted by vnode_pager_generic_getpages(). Likely, the problem has been hidden by vnode_pager_haspage() limiting the set of pages that are passed to vnode_pager_generic_getpages() such that a shift never occurs. The fix implemented herein is to adjust the pointer to the array of pages rather than shifting the pages within the array. Revision Changes Path 1.221.2.8 +25 -22 src/sys/vm/vnode_pager.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 19:41:03 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F269F16A418; Sat, 25 Aug 2007 19:41:02 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C53D713C458; Sat, 25 Aug 2007 19:41:02 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PJf2HA098964; Sat, 25 Aug 2007 19:41:02 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PJf2kq098963; Sat, 25 Aug 2007 19:41:02 GMT (envelope-from simon) Message-Id: <200708251941.l7PJf2kq098963@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Sat, 25 Aug 2007 19:41:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/yp yplib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 19:41:03 -0000 simon 2007-08-25 19:41:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/yp yplib.c Log: MFC rev 1.51: Set timeout for all NIS RPC requests to 1 second and not just for yp_next as revision 1.50 did. This should fix, or at least very much reduce the risk of, NIS timing out due to UDP packet loss for NIS functions. See also revision 1.50 for more details about the general problem. Revision Changes Path 1.49.2.2 +8 -8 src/lib/libc/yp/yplib.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 19:42:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F68E16A41A; Sat, 25 Aug 2007 19:42:30 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 22DA913C4B5; Sat, 25 Aug 2007 19:42:30 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PJgUnk099168; Sat, 25 Aug 2007 19:42:30 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PJgTYi099167; Sat, 25 Aug 2007 19:42:29 GMT (envelope-from alc) Message-Id: <200708251942.l7PJgTYi099167@repoman.freebsd.org> From: Alan Cox Date: Sat, 25 Aug 2007 19:42:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 19:42:30 -0000 alc 2007-08-25 19:42:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm swap_pager.c Log: MFC revision 1.294 Eliminate GIANT_REQUIRED from swap_pager_putpages(). Revision Changes Path 1.273.2.6 +0 -1 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 20:22:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 343B916A46B; Sat, 25 Aug 2007 20:22:39 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from phoebe.cse.buffalo.edu (phoebe.cse.Buffalo.EDU [128.205.32.89]) by mx1.freebsd.org (Postfix) with ESMTP id E08A413C45A; Sat, 25 Aug 2007 20:22:38 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from [192.168.1.101] (cpe-74-77-179-53.buffalo.res.rr.com [74.77.179.53]) (authenticated bits=0) by phoebe.cse.buffalo.edu (8.14.1/8.13.7) with ESMTP id l7PJsXTX027957 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 25 Aug 2007 15:54:35 -0400 (EDT) (envelope-from kensmith@cse.buffalo.edu) From: Ken Smith To: "M. Warner Losh" In-Reply-To: <20070825.093925.43008968.imp@bsdimp.com> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hO+zUR6QMwcq2xPozEaa" Date: Sat, 25 Aug 2007 15:55:52 -0400 Message-Id: <1188071752.1853.44.camel@neo.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 FreeBSD GNOME Team Port X-DCC-Buffalo.EDU-Metrics: phoebe.cse.buffalo.edu 1029; Body=0 Fuz1=0 Fuz2=0 X-Spam-Status: No, score=0.1 required=5.0 tests=RDNS_DYNAMIC autolearn=no version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on phoebe.cse.buffalo.edu Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@FreeBSD.org, cvs-all@FreeBSD.org, deischen@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 20:22:39 -0000 --=-hO+zUR6QMwcq2xPozEaa Content-Type: text/plain Content-Transfer-Encoding: quoted-printable [ Not bothering to include references for the entire thread, go back and read them if you really want to... ] I want Yar's work to proceed as planned please. My reasons are: 1) He is following the exact procedure we will be using from now on when an incompatible change to a library function is made for the first time in HEAD between releases. If, after making this change, he was to decide that some other minor change needed to be made and we hadn't done a release yet it could be argued he shouldn't repeat this process and that's just "Life using -current". The arguments against him doing this now have been based on "we already bumped libc's version number so it's dealt with". That's based on our old way of doing things. On can argue we begin the new way of doing things after 7.0 is out the door but one can argue equally well that it started at the point we turned on symbol versioning. 2) His timing with the fts(3) change was total coincidence but I was happy to see it come along. Symbol versioning is a new thing for 7.0. I'M HAPPY WE'RE HAVING A LIVE TEST OF IT BEFORE WE DO THE RELEASE. Even if Yar wasn't following the procedures we'll normally be following post symbol versioning being enabled (which I feel he is) I'm willing to defend what he's doing now as a special case in the interests of doing this live test of a new feature. That said I'm with Warner and Yar (and I believe Alfred was in there too). Unless I'm drastically mistaken about what the "promises" of symbol versioning had been Yar is currently following the exact procedure someone doing this sort of change should be doing in HEAD now that symbol versioning is enabled. And as I said with my re@ hat on I'm happy this is getting a "live test" before 7.0 gets released. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-hO+zUR6QMwcq2xPozEaa Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBG0IlI/G14VSmup/YRAqeLAJ9b3RTOAk6IprCz1PjucVGPqcJDPACdEm/g xjVWU4FgTpwM/EVJ6uNj+Jg= =cMJA -----END PGP SIGNATURE----- --=-hO+zUR6QMwcq2xPozEaa-- From owner-cvs-src@FreeBSD.ORG Sat Aug 25 21:06:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C6DF16A468; Sat, 25 Aug 2007 21:06:27 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id AFBC413C457; Sat, 25 Aug 2007 21:06:26 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7PL68HP021743; Sat, 25 Aug 2007 17:06:08 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Sat, 25 Aug 2007 17:06:08 -0400 (EDT) Date: Sat, 25 Aug 2007 17:06:08 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Ken Smith In-Reply-To: <1188071752.1853.44.camel@neo.cse.buffalo.edu> Message-ID: References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> <1188071752.1853.44.camel@neo.cse.buffalo.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 21:06:27 -0000 On Sat, 25 Aug 2007, Ken Smith wrote: > > [ Not bothering to include references for the entire thread, go back and > read them if you really want to... ] > > I want Yar's work to proceed as planned please. My reasons are: No offense, but some things have been going in without being discussed an -arch or -current. Approval for committing still has to go through re@, but that doesn't mean that changes shouldn't be vetted elsewhere prior to being sent to re@ approval. -- DE From owner-cvs-src@FreeBSD.ORG Sat Aug 25 21:07:37 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C63B716A41A; Sat, 25 Aug 2007 21:07:37 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B421213C428; Sat, 25 Aug 2007 21:07:37 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PL7bFk015815; Sat, 25 Aug 2007 21:07:37 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PL7bGl015814; Sat, 25 Aug 2007 21:07:37 GMT (envelope-from kmacy) Message-Id: <200708252107.l7PL7bGl015814@repoman.freebsd.org> From: Kip Macy Date: Sat, 25 Aug 2007 21:07:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_lro.c cxgb_main.c cxgb_sge.c src/sys/dev/cxgb/common cxgb_vsc8211.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 21:07:37 -0000 kmacy 2007-08-25 21:07:37 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_lro.c cxgb_main.c cxgb_sge.c sys/dev/cxgb/common cxgb_vsc8211.c Log: Fixes for 4 port and small packet optimization - remove cpl->iff panic - we can't know the port number from the rspq on the 4-port - pick the ifnet based on the interface in the CPL header - switch to using qset 0 for egress on the 4-port for now - may change when we start using RSS - move ether_ifdetach to before the port lock gets deinitialized to avoid hang in the case where there are BPF peers (cxgb_ioctl is called indirectly when BPF peers are present) - don't call t3_mac_reset if multiport is set, this was causing tx errors by misconfiguring the MAC on the 4-port - change V_TXPKT_INTF to use txpkt_intf as the interfaces are not contiguous - free the mbuf immediately in the case where the payload is small enough to be copied into the rspq - only update the coalesce timer if for a queue if packets were taken off of it - add in missed 20ms DELAY in initializaton vsc8211 - prompt MFC as this only applies to the 4-port which is currently completely broken - OK'd by kensmith Supported by: Chelsio Approved by: re (blanket) MFC after: 0 days Revision Changes Path 1.3 +1 -0 src/sys/dev/cxgb/common/cxgb_vsc8211.c 1.17 +6 -3 src/sys/dev/cxgb/cxgb_adapter.h 1.8 +6 -7 src/sys/dev/cxgb/cxgb_lro.c 1.32 +80 -29 src/sys/dev/cxgb/cxgb_main.c 1.28 +32 -37 src/sys/dev/cxgb/cxgb_sge.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 21:32:19 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33B1016A41A; Sat, 25 Aug 2007 21:32:19 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from phoebe.cse.buffalo.edu (phoebe.cse.Buffalo.EDU [128.205.32.89]) by mx1.freebsd.org (Postfix) with ESMTP id E36E913C45D; Sat, 25 Aug 2007 21:32:18 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from [192.168.1.101] (cpe-74-77-179-53.buffalo.res.rr.com [74.77.179.53]) (authenticated bits=0) by phoebe.cse.buffalo.edu (8.14.1/8.13.7) with ESMTP id l7PLVuLD028196 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 25 Aug 2007 17:31:57 -0400 (EDT) (envelope-from kensmith@cse.buffalo.edu) From: Ken Smith To: Daniel Eischen In-Reply-To: References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> <1188071752.1853.44.camel@neo.cse.buffalo.edu> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-a56JNptRYwiau/fyS8mC" Date: Sat, 25 Aug 2007 17:33:16 -0400 Message-Id: <1188077596.1853.55.camel@neo.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 FreeBSD GNOME Team Port X-DCC-Buffalo.EDU-Metrics: phoebe.cse.buffalo.edu 1029; Body=0 Fuz1=0 Fuz2=0 X-Spam-Status: No, score=0.1 required=5.0 tests=RDNS_DYNAMIC autolearn=no version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on phoebe.cse.buffalo.edu Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 21:32:19 -0000 --=-a56JNptRYwiau/fyS8mC Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2007-08-25 at 17:06 -0400, Daniel Eischen wrote: > On Sat, 25 Aug 2007, Ken Smith wrote: >=20 > > > > [ Not bothering to include references for the entire thread, go back an= d > > read them if you really want to... ] > > > > I want Yar's work to proceed as planned please. My reasons are: >=20 > No offense, but some things have been going in without being discussed > an -arch or -current. Approval for committing still has to go through > re@, but that doesn't mean that changes shouldn't be vetted elsewhere > prior to being sent to re@ approval. >=20 If that's the case then it's been my negligence and I apologize. I'll try to be more mindful of that moving forward. That said, I'm still confused about what aspect of this has not been discussed. We have symbol versioning in place. Yar had a compatibility-breaking change to make to fts(3). He followed exactly the procedures I was led to believe are to be followed now that symbol versioning is in place. That was why I approved it. What aspect of that is wrong? Is it just that 7.0 isn't out the door quite yet or is there more to it than that? I have read the thread and still can only see arguments against it based on what I believe to be pre-symbol versioning thinking. This is the first use of symbol versioning but to me when Yar requested it I didn't think it needed a wider review because I thought it followed the procedures we want to have in place from this point forward and I didn't think going forward every time new library symbols get phased in for particular things we'd be needing to do that sort of large scale review. In retrospect I think I overstepped things with the addition of the tkill stuff and that should have gotten wider review. If I'm mistaken about us having settled on the exact mechanics of symbol versioning then I overstepped things again but I thought that had been settled and that this case followed what had been settled on. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-a56JNptRYwiau/fyS8mC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBG0KAc/G14VSmup/YRAjftAKCISrFl9Z56rNzWFRP/QUh97HtLxACfXyBe NWp9PJgfSxpMfH1kcDxnAmY= =AQnY -----END PGP SIGNATURE----- --=-a56JNptRYwiau/fyS8mC-- From owner-cvs-src@FreeBSD.ORG Sat Aug 25 21:52:37 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ECC6E16A419; Sat, 25 Aug 2007 21:52:37 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id A669413C45B; Sat, 25 Aug 2007 21:52:37 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7PLpYc8074105; Sat, 25 Aug 2007 15:51:34 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 25 Aug 2007 15:51:38 -0600 (MDT) Message-Id: <20070825.155138.-1548240116.imp@bsdimp.com> To: eischen@vigrid.com From: "M. Warner Losh" In-Reply-To: References: <20070825.093925.43008968.imp@bsdimp.com> <1188071752.1853.44.camel@neo.cse.buffalo.edu> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 25 Aug 2007 15:51:34 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.Buffalo.EDU Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 21:52:38 -0000 In message: Daniel Eischen writes: : On Sat, 25 Aug 2007, Ken Smith wrote: : : > : > [ Not bothering to include references for the entire thread, go back and : > read them if you really want to... ] : > : > I want Yar's work to proceed as planned please. My reasons are: : : No offense, but some things have been going in without being discussed : an -arch or -current. Approval for committing still has to go through : re@, but that doesn't mean that changes shouldn't be vetted elsewhere : prior to being sent to re@ approval. Can you be specific? Also, we shouldn't be making it this hard to use versioned symbols. The last thing we want is for it to be perceived as a fight to get one into the tree. If that's the perception, then people are less likely to do the right thing in the future. We should instead embrace the change, document the right thing to do and use it as a dry-run to work out the kinks in the process. Yar's change fell into a grey area. Reasonable people could differ as to the time that the ABI became 'official'. Is it with the release? Or is it when symbol versioning was turned on? Or maybe when the code freeze happened. Clearly it wasn't before symbol versioning was enabled, and it can't be after the release. Why not now? Why not let the RE@ make the call when he reasonably believes the right time is? We delegated the release process to him and his team so the whole community doesn't micromanage it to death, introduce changes at a bad time, etc, etc, etc. Why can't we let him decide the exact boundaries and make this grey area less grey? Warner From owner-cvs-src@FreeBSD.ORG Sat Aug 25 22:10:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1A7716A419; Sat, 25 Aug 2007 22:10:12 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.freebsd.org (Postfix) with ESMTP id A773613C469; Sat, 25 Aug 2007 22:10:12 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 50EF42F70; Sat, 25 Aug 2007 17:10:09 -0500 (CDT) Date: Sat, 25 Aug 2007 17:10:09 -0500 To: Daniel Eischen Message-ID: <20070825221009.GC32000@soaustin.net> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> <1188071752.1853.44.camel@neo.cse.buffalo.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i From: linimon@lonesome.com (Mark Linimon) Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Ken Smith , "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 22:10:12 -0000 On Sat, Aug 25, 2007 at 05:06:08PM -0400, Daniel Eischen wrote: > No offense, but some things have been going in without being discussed > an -arch or -current. -arch has been pretty quiet recently and could use some more traffic. I'd rather see discussions like this go on there rather than -current, which is pretty noisy. mcl From owner-cvs-src@FreeBSD.ORG Sat Aug 25 23:55:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C94D16A41A; Sat, 25 Aug 2007 23:55:22 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DF17213C481; Sat, 25 Aug 2007 23:55:21 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PNtLTI029775; Sat, 25 Aug 2007 23:55:21 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PNtLLD029774; Sat, 25 Aug 2007 23:55:21 GMT (envelope-from kmacy) Message-Id: <200708252355.l7PNtLLD029774@repoman.freebsd.org> From: Kip Macy Date: Sat, 25 Aug 2007 23:55:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_lro.c cxgb_main.c cxgb_sge.c src/sys/dev/cxgb/common cxgb_vsc8211.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 23:55:22 -0000 kmacy 2007-08-25 23:55:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/cxgb cxgb_adapter.h cxgb_lro.c cxgb_main.c cxgb_sge.c sys/dev/cxgb/common cxgb_vsc8211.c Log: MFC: Fixes for 4 port and small packet optimization - remove cpl->iff panic - we can't know the port number from the rspq on the 4-port - pick the ifnet based on the interface in the CPL header - switch to using qset 0 for egress on the 4-port for now - may change when we start using RSS - move ether_ifdetach to before the port lock gets deinitialized to avoid hang in the case where there are BPF peers (cxgb_ioctl is called indirectly when BPF peers are present) - don't call t3_mac_reset if multiport is set, this was causing tx errors by misconfiguring the MAC on the 4-port - change V_TXPKT_INTF to use txpkt_intf as the interfaces are not contiguous - free the mbuf immediately in the case where the payload is small enough to be copied into the rspq - only update the coalesce timer if for a queue if packets were taken off of it - add in missed 20ms DELAY in initializaton vsc8211 - prompt MFC as this only applies to the 4-port which is currently completely broken - OK'd by kensmith Supported by: Chelsio Revision Changes Path 1.1.2.3 +1 -0 src/sys/dev/cxgb/common/cxgb_vsc8211.c 1.2.2.8 +8 -5 src/sys/dev/cxgb/cxgb_adapter.h 1.1.2.4 +7 -7 src/sys/dev/cxgb/cxgb_lro.c 1.3.2.9 +81 -45 src/sys/dev/cxgb/cxgb_main.c 1.2.2.8 +28 -35 src/sys/dev/cxgb/cxgb_sge.c From owner-cvs-src@FreeBSD.ORG Sat Aug 25 23:58:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A7BB16A41A; Sat, 25 Aug 2007 23:58:46 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 11DBF13C478; Sat, 25 Aug 2007 23:58:46 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7PNwj09029932; Sat, 25 Aug 2007 23:58:45 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7PNwjDP029931; Sat, 25 Aug 2007 23:58:45 GMT (envelope-from scottl) Message-Id: <200708252358.l7PNwjDP029931@repoman.freebsd.org> From: Scott Long Date: Sat, 25 Aug 2007 23:58:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mfi mfi.c mfi_pci.c mfireg.h mfivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 23:58:46 -0000 scottl 2007-08-25 23:58:45 UTC FreeBSD src repository Modified files: sys/dev/mfi mfi.c mfi_pci.c mfireg.h mfivar.h Log: Update the MFI driver to support new "1078" series of hardware. This includes the upcoming Dell PERC6 series. Many thanks to LSI for contributing this code. Submitted by: LSI Approved by: re Revision Changes Path 1.33 +120 -21 src/sys/dev/mfi/mfi.c 1.9 +30 -3 src/sys/dev/mfi/mfi_pci.c 1.10 +37 -0 src/sys/dev/mfi/mfireg.h 1.11 +34 -0 src/sys/dev/mfi/mfivar.h