From owner-freebsd-net@FreeBSD.ORG Sun Dec 30 10:11:10 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E707716A41B for ; Sun, 30 Dec 2007 10:11:10 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.188]) by mx1.freebsd.org (Postfix) with ESMTP id 846BD13C459 for ; Sun, 30 Dec 2007 10:11:10 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: by fk-out-0910.google.com with SMTP id b27so6422956fka.11 for ; Sun, 30 Dec 2007 02:11:09 -0800 (PST) Received: by 10.78.165.16 with SMTP id n16mr13591119hue.63.1199008024381; Sun, 30 Dec 2007 01:47:04 -0800 (PST) Received: from ?192.168.1.5? ( [81.21.81.41]) by mx.google.com with ESMTPS id 36sm4990991huc.12.2007.12.30.01.47.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 30 Dec 2007 01:47:03 -0800 (PST) Message-ID: <4777690B.1030403@freebsd.az> Date: Sun, 30 Dec 2007 13:46:51 +0400 From: Tofig Suleymanov User-Agent: Thunderbird 1.5.0.8 (X11/20061113) MIME-Version: 1.0 To: freebsd-net@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: if_start running deferred for Giant X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2007 10:11:11 -0000 Hello list, I am writing a driver for Kyocera USB modem for FreeBSD and there are a few questions that I am not able to solve alone. I would be grateful if someone could point me into the right direction.Here is the first one: Inside the USB_ATTACH() function I initialise the ifnet(9) structure and return USB_ATTACH_SUCCESS_RETURN. Everything seems to be fine so far (I can see the interface in ifconfig output) except the following error notice spit to the console: xxxxxx kernel: ib0: if_start running deferred for Giant I am not sure what does this exactly mean. Any help would be appreciated. Thanks, Tofig Suleymanov From owner-freebsd-net@FreeBSD.ORG Sun Dec 30 17:11:17 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB6B816A419 for ; Sun, 30 Dec 2007 17:11:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 89FB913C4CE for ; Sun, 30 Dec 2007 17:11:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 8B35C47125; Sun, 30 Dec 2007 12:11:16 -0500 (EST) Date: Sun, 30 Dec 2007 17:11:16 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Tofig Suleymanov In-Reply-To: <4777690B.1030403@freebsd.az> Message-ID: <20071230170217.T6382@fledge.watson.org> References: <4777690B.1030403@freebsd.az> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org Subject: Re: if_start running deferred for Giant X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2007 17:11:17 -0000 On Sun, 30 Dec 2007, Tofig Suleymanov wrote: > I am writing a driver for Kyocera USB modem for FreeBSD and there are a few > questions that I am not able to solve alone. I would be grateful if someone > could point me into the right direction.Here is the first one: > > Inside the USB_ATTACH() function I initialise the ifnet(9) structure and > return USB_ATTACH_SUCCESS_RETURN. Everything seems to be fine so far (I can > see the interface in ifconfig output) except the following error notice spit > to the console: > > xxxxxx kernel: ib0: if_start running deferred for Giant > > I am not sure what does this exactly mean. > > Any help would be appreciated. This occurs when a network device driver has declared itself IFF_NEEDSGIANT -- that is, has declared that it requires the Giant lock in order to operate. As this is considered an undesirable state of affairs for a device driver, a warning is printed. However, in the case of a USB device driver, it is currently required as the USB framework is not MPSAFE, so requires Giant. Robert N M Watson Computer Laboratory University of Cambridge From owner-freebsd-net@FreeBSD.ORG Sun Dec 30 17:49:35 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B29316A46C; Sun, 30 Dec 2007 17:49:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0685913C448; Sun, 30 Dec 2007 17:49:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id EB74F4763B; Sun, 30 Dec 2007 12:49:33 -0500 (EST) Date: Sun, 30 Dec 2007 17:49:33 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Tiffany Snyder In-Reply-To: Message-ID: <20071230172808.J7115@fledge.watson.org> References: <43B45EEF.6060800@x-trader.de> <43B47CB5.3C0F1632@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org, Andre Oppermann Subject: Re: Routing SMP benefit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2007 17:49:35 -0000 On Fri, 28 Dec 2007, Tiffany Snyder wrote: > What piqued my attention was the note that our forwarding performance > doesn't scale with multiple CPUs. Which means there's a lot of work to be > done :-) Have we taken a look at OpenSolaris' Surya > (http://www.opensolaris.org/os/community/networking/surya-design.pdf) > project? They allow multiple readers/single writer on the radix_node_head > (and not a mutex as we do) and we may be able to do the same to gain some > parallelism. There are other things in Surya that exploit multiple CPUs. > It's definitely worth a read. DragonFlyBSD seems to achieve parallelism by > classifying packet as flows and then redirecting the flows to different > CPUs. OpenSolaris also does something similar. We can definitely think along > those lines. > > NOTE: 1) I said multiple instead of dual CPUs on purpose. 2) I mentioned > OpenSolaris and DragonFlyBSD as examples and to acknowledge the work they > are doing and to show that FreeBSD is far behind and is losing it's lustre > on continuing to be the networking platform of choice. Thanks for your kind comments, we always appreciate it when people tell us we've lost our lustre and are far behind. A few more substantive comments-- Kip Macy has been floating a patch to move to reader-writer locking on the routing code, but I'm not sure how mature it is. Certainly, we are aware that routing lock contention is a key issue we need to look at for forwarding performance. If he doesn't follow up to this thread, give him a ping for a copy of the patch. I have a prototype work dispatch system for TCP/IP on FreeBSD based on packet flow classification, such as the ones you point at, which can be found in the FreeBSD perforce server. However, life is a bit more complicated than just identifying flows and assigning them to CPUs. In FreeBSD 7, we perform direct dispatch of the network stack from the interrupt thread in order to avoid context switch overhead, which mean there isn't a natural deferal point, such as the netisr dispatch. In practice, for high performance devices, this is both highly desirable in order to avoid dispatch overheads, but also because 10gbps cards almost always support in-hardware dispatch to multiple input queues. This is much preferable pulling packet headers to a single CPU in one interrupt thread, and then bouncing the cache lines for the packets to other CPUs for actual processing. Our Chelsio 10gbps driver, for example, supports work dispatch to multiple input threads today, so you will already see parallel processing of input flows from that hardware via multiple ithreads. For other devices, where either the hardware or device driver doesn't support the in-hardware demux, having software processing is a good idea, but in order for that to pay off, routing lock granularity and TCP input lock granularity both need attention. Per the FreeBSD 8 TCP projects page, I've begun work on TCP locking and affinity, but I won't have too much substantive progress to show for a couple of months. I can provide netisr parallel dispatch patches, a bit dated but probably not hard to update, on request. So, suffice to say, we are aware that we have more work to do in the area of parallel work distribution, and by implication, lock granularity in some of our network stack subsystems. However, I think we're quite well placed to do it, as we already ship the OS with parallel input queue processing due to direct dispatch, and have a solid and generally fairly granular locking implementation. Robert N M Watson Computer Laboratory University of Cambridge > > Thanks, > > Tiffany. > > > On 12/29/05, Andre Oppermann wrote: > >> Markus Oestreicher wrote: >>> >>> Currently running a few routers on 5-STABLE I have read the >>> recent changes in the network stack with interest. >> >> You should run 6.0R. It contains many improvements over 5-STABLE. >> >>> A few questions come to my mind: >>> >>> - Can a machine that mainly routes packets between two em(4) >>> interfaces benefit from a second CPU and SMP kernel? Can both >>> CPUs process packets from the same interface in parallel? >> >> My testing has shown that a machine can benefit from it but not >> much in the forwarding performance. The main benefit is the >> prevention of lifelock if you have very high packet loads. The >> second CPU on SMP keeps on doing all userland tasks and running >> routing protocols. Otherwise your BGP sessions or OSPF hellos >> would stop and remove you from the routing cloud. >> >>> - From reading the lists it appears that net.isr.direct >>> and net.ip.fastforwarding are doing similar things. Should >>> they be used together or rather not? >> >> net.inet.ip.fastforwarding has precedence over net.isr.direct and >> enabling both at the same doesn't gain you anything. Fastforwarding >> is about 30% faster than all other methods available, including >> polling. On my test machine with two em(4) and an AMD Opteron 852 >> (2.6GHz) I can route 580'000 pps with zero packet loss on -CURRENT. >> An upcoming optimization that will go into -CURRENT in the next >> few days pushes that to 714'000 pps. Futher optimizations are >> underway to make a stock kernel do close to or above 1'000'000 pps >> on the same hardware. >> >> -- >> Andre >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to " freebsd-net-unsubscribe@freebsd.org" >> > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Sun Dec 30 21:26:11 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A9F316A417 for ; Sun, 30 Dec 2007 21:26:11 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: from hu-out-0506.google.com (hu-out-0506.google.com [72.14.214.225]) by mx1.freebsd.org (Postfix) with ESMTP id A536413C4E5 for ; Sun, 30 Dec 2007 21:26:10 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: by hu-out-0506.google.com with SMTP id 28so412159hub.8 for ; Sun, 30 Dec 2007 13:26:09 -0800 (PST) Received: by 10.78.184.2 with SMTP id h2mr14374224huf.27.1199049968816; Sun, 30 Dec 2007 13:26:08 -0800 (PST) Received: from ?192.168.1.7? ( [81.21.81.41]) by mx.google.com with ESMTPS id 39sm5221908hui.5.2007.12.30.13.26.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 30 Dec 2007 13:26:06 -0800 (PST) Message-ID: <47780CE4.3000302@freebsd.az> Date: Mon, 31 Dec 2007 01:25:56 +0400 From: Tofig Suleymanov User-Agent: Thunderbird 1.5.0.8 (X11/20061113) MIME-Version: 1.0 To: Robert Watson References: <4777690B.1030403@freebsd.az> <20071230170217.T6382@fledge.watson.org> In-Reply-To: <20071230170217.T6382@fledge.watson.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org Subject: Re: if_start running deferred for Giant X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2007 21:26:11 -0000 Robert Watson wrote: > > On Sun, 30 Dec 2007, Tofig Suleymanov wrote: > >> I am writing a driver for Kyocera USB modem for FreeBSD and there are >> a few questions that I am not able to solve alone. I would be >> grateful if someone could point me into the right direction.Here is >> the first one: >> >> Inside the USB_ATTACH() function I initialise the ifnet(9) structure >> and return USB_ATTACH_SUCCESS_RETURN. Everything seems to be fine so >> far (I can see the interface in ifconfig output) except the following >> error notice spit to the console: >> >> xxxxxx kernel: ib0: if_start running deferred for Giant >> >> I am not sure what does this exactly mean. >> >> Any help would be appreciated. > > This occurs when a network device driver has declared itself > IFF_NEEDSGIANT -- that is, has declared that it requires the Giant > lock in order to operate. As this is considered an undesirable state > of affairs for a device driver, a warning is printed. However, in the > case of a USB device driver, it is currently required as the USB > framework is not MPSAFE, so requires Giant. > > Robert N M Watson > Computer Laboratory > University of Cambridge > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" Thanks for clarification. Does it mean that I can ignore this notice when dealing with USB framework ? From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 00:29:49 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F5AA16A421 for ; Mon, 31 Dec 2007 00:29:49 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1E82A13C4EC for ; Mon, 31 Dec 2007 00:29:48 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0A9B147A8F; Sun, 30 Dec 2007 19:29:48 -0500 (EST) Date: Mon, 31 Dec 2007 00:29:47 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Tofig Suleymanov In-Reply-To: <47780CE4.3000302@freebsd.az> Message-ID: <20071231002840.N21364@fledge.watson.org> References: <4777690B.1030403@freebsd.az> <20071230170217.T6382@fledge.watson.org> <47780CE4.3000302@freebsd.az> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org Subject: Re: if_start running deferred for Giant X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 00:29:49 -0000 On Mon, 31 Dec 2007, Tofig Suleymanov wrote: >>> xxxxxx kernel: ib0: if_start running deferred for Giant >>> >>> I am not sure what does this exactly mean. >>> >>> Any help would be appreciated. >> >> This occurs when a network device driver has declared itself IFF_NEEDSGIANT >> -- that is, has declared that it requires the Giant lock in order to >> operate. As this is considered an undesirable state of affairs for a device >> driver, a warning is printed. However, in the case of a USB device driver, >> it is currently required as the USB framework is not MPSAFE, so requires >> Giant. > > Thanks for clarification. Does it mean that I can ignore this notice when > dealing with USB framework ? For now, yes. When, at some point, the USB framework is MPSAFE, we'll need to remove IFF_NEEDSGIANT, and I'd make sure that your device driver is as ready as it can be to operate Giant-free once that's done. Robert N M Watson Computer Laboratory University of Cambridge From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 07:09:01 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C6C516A417 for ; Mon, 31 Dec 2007 07:09:01 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.186]) by mx1.freebsd.org (Postfix) with ESMTP id 6A00113C43E for ; Mon, 31 Dec 2007 07:09:01 +0000 (UTC) (envelope-from tofig@freebsd.az) Received: by rv-out-0910.google.com with SMTP id l15so4874658rvb.43 for ; Sun, 30 Dec 2007 23:09:00 -0800 (PST) Received: by 10.141.22.1 with SMTP id z1mr245622rvi.277.1199084940444; Sun, 30 Dec 2007 23:09:00 -0800 (PST) Received: by 10.140.142.6 with HTTP; Sun, 30 Dec 2007 23:09:00 -0800 (PST) Message-ID: <342414370712302309i2fbaff2ex4888d51d51eaa99c@mail.gmail.com> Date: Mon, 31 Dec 2007 11:09:00 +0400 From: "Tofig Suleymanov" To: "Robert Watson" In-Reply-To: <20071231002840.N21364@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4777690B.1030403@freebsd.az> <20071230170217.T6382@fledge.watson.org> <47780CE4.3000302@freebsd.az> <20071231002840.N21364@fledge.watson.org> Cc: freebsd-net@freebsd.org Subject: Re: if_start running deferred for Giant X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 07:09:01 -0000 On 12/31/07, Robert Watson wrote: > > On Mon, 31 Dec 2007, Tofig Suleymanov wrote: > > >>> xxxxxx kernel: ib0: if_start running deferred for Giant > >>> > >>> I am not sure what does this exactly mean. > >>> > >>> Any help would be appreciated. > >> > >> This occurs when a network device driver has declared itself IFF_NEEDSGIANT > >> -- that is, has declared that it requires the Giant lock in order to > >> operate. As this is considered an undesirable state of affairs for a device > >> driver, a warning is printed. However, in the case of a USB device driver, > >> it is currently required as the USB framework is not MPSAFE, so requires > >> Giant. > > > > Thanks for clarification. Does it mean that I can ignore this notice when > > dealing with USB framework ? > > For now, yes. When, at some point, the USB framework is MPSAFE, we'll need to > remove IFF_NEEDSGIANT, and I'd make sure that your device driver is as ready > as it can be to operate Giant-free once that's done. > > Robert N M Watson > Computer Laboratory > University of Cambridge > Now it is clear to me. Thanks for your help. From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 11:07:02 2007 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EAE416A4C6 for ; Mon, 31 Dec 2007 11:07:02 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1CE8F13C4DB for ; Mon, 31 Dec 2007 11:07:02 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBVB72l0037414 for ; Mon, 31 Dec 2007 11:07:02 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBVB71MK037410 for freebsd-net@FreeBSD.org; Mon, 31 Dec 2007 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 31 Dec 2007 11:07:01 GMT Message-Id: <200712311107.lBVB71MK037410@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-net@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 11:07:02 -0000 Current FreeBSD problem reports Critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- f kern/115360 net [ipv6] IPv6 address and if_bridge don't play well toge 1 problem total. Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- a kern/38554 net changing interface ipaddress doesn't seem to work s kern/39937 net ipstealth issue f kern/62374 net panic: free: multiple frees s kern/81147 net [net] [patch] em0 reinitialization while adding aliase o kern/92552 net A serious bug in most network drivers from 5.X to 6.X s kern/95665 net [if_tun] "ping: sendto: No buffer space available" wit s kern/105943 net Network stack may modify read-only mbuf chain copies o kern/106316 net [dummynet] dummynet with multipass ipfw drops packets o kern/108542 net [bce]: Huge network latencies with 6.2-RELEASE / STABL o kern/110959 net [ipsec] Filtering incoming packets with enc0 does not o kern/112528 net [nfs] NFS over TCP under load hangs with "impossible p o kern/112686 net [patm] patm driver freezes System (FreeBSD 6.2-p4) i38 o kern/112722 net IP v4 udp fragmented packet reject o kern/113457 net [ipv6] deadlock occurs if a tunnel goes down while the o kern/113842 net [ipv6] PF_INET6 proto domain state can't be cleared wi o kern/114714 net [gre][patch] gre(4) is not MPSAFE and does not support o kern/114839 net [fxp] fxp looses ability to speak with traffic o kern/115239 net [ipnat] panic with 'kmem_map too small' using ipnat o kern/116077 net 6.2-STABLE panic during use of multi-cast networking c o kern/116172 net Network / ipv6 recursive mutex panic o kern/116185 net if_iwi driver leads system to reboot o kern/116328 net [bge]: Solid hang with bge interface o kern/116747 net [ndis] FreeBSD 7.0-CURRENT crash with Dell TrueMobile o kern/116837 net ifconfig tunX destroy: panic o kern/117271 net [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap o kern/117423 net Duplicate IP on different interfaces o bin/117448 net [carp] 6.2 kernel crash o kern/118880 net [ipv6] IP_RECVDSTADDR & IP_SENDSRCADDR not implemented 28 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/23063 net [PATCH] for static ARP tables in rc.network s bin/41647 net ifconfig(8) doesn't accept lladdr along with inet addr o kern/54383 net [nfs] [patch] NFS root configurations without dynamic s kern/60293 net FreeBSD arp poison patch o kern/95267 net packet drops periodically appear f kern/95277 net [netinet] [patch] IP Encapsulation mask_match() return o kern/100519 net [netisr] suggestion to fix suboptimal network polling o kern/102035 net [plip] plip networking disables parallel port printing o conf/102502 net [patch] ifconfig name does't rename netgraph node in n o conf/107035 net [patch] bridge interface given in rc.conf not taking a o kern/112654 net [pcn] Kernel panic upon if_pcn module load on a Netfin o kern/114915 net [patch] [pcn] pcn (sys/pci/if_pcn.c) ethernet driver f o bin/116643 net [patch] fstat(1): add INET/INET6 socket details as in o bin/117339 net [patch] route(8): loading routing management commands o kern/118722 net [tcp] Many old TCP connections in SYN_RCVD state o kern/118727 net [ng] [patch] add new ng_pf module a kern/118879 net [bge] [patch] bge has checksum problems on the 5703 ch o kern/118975 net [bge] [patch] Broadcom 5906 not handled by FreeBSD o bin/118987 net ifconfig -l [address_family] does not work correct on 19 problems total. From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 11:35:39 2007 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CECC516A420; Mon, 31 Dec 2007 11:35:39 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A565613C45A; Mon, 31 Dec 2007 11:35:39 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from freefall.freebsd.org (bz@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBVBZdHj001968; Mon, 31 Dec 2007 11:35:39 GMT (envelope-from bz@freefall.freebsd.org) Received: (from bz@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBVBZdhC001964; Mon, 31 Dec 2007 11:35:39 GMT (envelope-from bz) Date: Mon, 31 Dec 2007 11:35:39 GMT Message-Id: <200712311135.lBVBZdhC001964@freefall.freebsd.org> To: Andre.Albsmeier@siemens.com, bz@FreeBSD.org, freebsd-net@FreeBSD.org, bz@FreeBSD.org From: bz@FreeBSD.org Cc: Subject: Re: kern/110959: [ipsec] Filtering incoming packets with enc0 does not work with GIF-based IPSec setups X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 11:35:39 -0000 Synopsis: [ipsec] Filtering incoming packets with enc0 does not work with GIF-based IPSec setups State-Changed-From-To: open->feedback State-Changed-By: bz State-Changed-When: Mon Dec 31 11:34:10 UTC 2007 State-Changed-Why: There are patches in HEAD already - asked for feedback if they are doing the right thing. Responsible-Changed-From-To: freebsd-net->bz Responsible-Changed-By: bz Responsible-Changed-When: Mon Dec 31 11:34:10 UTC 2007 Responsible-Changed-Why: I have been touching enc(4) lately so let's see if that helped or we need to fix that. http://www.freebsd.org/cgi/query-pr.cgi?pr=110959 From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 22:13:02 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86CA916A421 for ; Mon, 31 Dec 2007 22:13:02 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outS.internet-mail-service.net (outS.internet-mail-service.net [216.240.47.242]) by mx1.freebsd.org (Postfix) with ESMTP id 725DC13C4E7 for ; Mon, 31 Dec 2007 22:13:02 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Mon, 31 Dec 2007 14:13:01 -0800 Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 2147D126DD5 for ; Mon, 31 Dec 2007 14:13:01 -0800 (PST) Message-ID: <4779697A.4050806@elischer.org> Date: Mon, 31 Dec 2007 14:13:14 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: FreeBSD Net Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: m_freem() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 22:13:02 -0000 m_freem() would be a perfect candidate for an inline function. (or even macro). in the case where m is null, no function call would even be made... The whole function is only 2 lines, and it gets called once for every packet :-) BUT it's a part of the ABI to have it as a function for RELENG_7 and earlier... 1/ can we change it in -current/RELENG_8 2/ if not is there such a thing as an inline that has a function version too? (I have vague memories of that being possible...)