From owner-p4-projects@FreeBSD.ORG Sun Oct 28 00:28:58 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5615A16A41B; Sun, 28 Oct 2007 00:28:58 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08C4216A419 for ; Sun, 28 Oct 2007 00:28:58 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EBDDD13C4BD for ; Sun, 28 Oct 2007 00:28:57 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9S0SvUk081551 for ; Sun, 28 Oct 2007 00:28:57 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9S0SvXU081548 for perforce@freebsd.org; Sun, 28 Oct 2007 00:28:57 GMT (envelope-from jb@freebsd.org) Date: Sun, 28 Oct 2007 00:28:57 GMT Message-Id: <200710280028.l9S0SvXU081548@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 128216 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2007 00:28:58 -0000 http://perforce.freebsd.org/chv.cgi?CH=128216 Change 128216 by jb@jb_freebsd1 on 2007/10/28 00:28:14 The comment "Solaris defines _LITTLE_ENDIAN or _BIG_ENDIAN, but never both and decides which architecture it is based on which thing is defined." is true, but undefining _LITTLE_ENDIAN or _BIG_ENDIAN breaks lots of FreeBSD header files which all assume that both _LITTLE_ENDIAN and _BIG_ENDIAN are defined and that BYTE_ORDER is set to the one that matches the host. This was a hack to get ZFS working on FreeBSD, but it prevents DTrace code from using FreeBSD headers which include _BIG_ENDIAN and _LITTLE_ENDIAN. ZFS (and other Solaris) code will _have _to be changed to do what FreeBSD does: e.g. if BYTE_ORDER == _LITTLE_ENDIAN rather than ifdef _LITTLE_ENDIAN. Without this change, I can't share the OpenSolaris compatibility headers that pjd@ has created. Affected files ... .. //depot/projects/dtrace/src/sys/compat/opensolaris/machine/endian.h#2 delete Differences ...