From owner-freebsd-afs@FreeBSD.ORG Sun Feb 24 22:56:16 2008 Return-Path: Delivered-To: afs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09F3816A405; Sun, 24 Feb 2008 22:56:16 +0000 (UTC) (envelope-from tol@stacken.kth.se) Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by mx1.freebsd.org (Postfix) with ESMTP id AF5D413C46E; Sun, 24 Feb 2008 22:56:15 +0000 (UTC) (envelope-from tol@stacken.kth.se) Received: from localhost (localhost [127.0.0.1]) by smtp-2.sys.kth.se (Postfix) with ESMTP id D977014DC99; Sun, 24 Feb 2008 23:55:43 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([127.0.0.1]) by localhost (smtp-2.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fEPxUEDAja86; Sun, 24 Feb 2008 23:55:41 +0100 (CET) Received: from [213.89.103.79] (c213-89-103-79.bredband.comhem.se [213.89.103.79]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 6B10814DC95; Sun, 24 Feb 2008 23:55:40 +0100 (CET) From: Tomas Olsson To: Alec Kloss In-Reply-To: <1203788012.4065.10.camel@hippo.t.nxs.se> References: <20080216035658.W93919@fledge.watson.org> <1203286882.16414.3.camel@heterodyne.kaj> <20080218012608.V96329@fledge.watson.org> <20080222125207.GD38141@hamlet.setfilepointer.com> <20080223092516.O23969@fledge.watson.org> <20080223102922.GF38141@hamlet.setfilepointer.com> <20080223110549.GG38141@hamlet.setfilepointer.com> <20080223161249.GH38141@hamlet.setfilepointer.com> <1203788012.4065.10.camel@hippo.t.nxs.se> Content-Type: text/plain Date: Sun, 24 Feb 2008 23:58:30 +0100 Message-Id: <1203893910.4068.14.camel@hippo.t.nxs.se> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Cc: afs@FreeBSD.org, Robert Watson , arla-drinkers@stacken.kth.se Subject: Re: Patches to get Arla running on FreeBSD 8-CURRENT X-BeenThere: freebsd-afs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: The Andrew File System and FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2008 22:56:16 -0000 I wrote: > On Sat, 2008-02-23 at 10:12 -0600, Alec Kloss wrote: > > All of the heavy lifting is done in the big patch at > > > > http://setfilepointer.com/pub/arla/20080223-arla.diff > [...] > > Can anyone from Arla comment on the chances for incorporating > > these patches into Arla itself? It'd be nice to have these changes > > in Arla itself prior to submitting the port to FreeBSD. > > > Chances are good. If it looks ok it goes in. > Looks mostly ok, but I do have some questions. 1) appl/fs/fs_local.h: would that break `fs nnpfsdeb all`? 2) cf/try-compile-kernel.m4: why do we need /usr/include? It sounds scary given that we may want to compile using random kernel trees. Same goes for nnpfs/freebsd/FreeBSD-Makefile. I don't know much about kernel build magic. 3) cf/bsd-vop-unlock.m4: do we need it? I don't care about older versions of FreeBSD than 6.x; traditionally we try to support latest stable OS-release plus -CURRENT but maybe that's a bit limiting. Perphaps nnpfs_vfs_unlock solves part of the problem? thanks /t