From owner-freebsd-arm@FreeBSD.ORG Mon Jul 21 21:45:27 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C5C6106567E; Mon, 21 Jul 2008 21:45:27 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id E35608FC34; Mon, 21 Jul 2008 21:45:26 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 084DA3F633F; Mon, 21 Jul 2008 23:45:25 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id B90F13F633E; Mon, 21 Jul 2008 23:45:24 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id A47119B497; Mon, 21 Jul 2008 21:39:51 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 984964089; Mon, 21 Jul 2008 23:39:51 +0200 (CEST) Date: Mon, 21 Jul 2008 23:39:51 +0200 From: Jeremie Le Hen To: ticso@cicely.de Message-ID: <20080721213951.GN39074@obiwan.tataz.chchile.org> References: <200806252138.m5PLcajG067917@repoman.freebsd.org> <20080707155017.6850f3a5.stas@FreeBSD.org> <20080711211909.GB33517@obiwan.tataz.chchile.org> <20080714234809.32cb8042.stas@FreeBSD.org> <20080715210512.GK35340@cicely7.cicely.de> <20080716021322.52f895c9.stas@FreeBSD.org> <20080715225443.GM35340@cicely7.cicely.de> <20080717140905.GX35340@cicely7.cicely.de> <20080718114058.GB35340@cicely7.cicely.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080718114058.GB35340@cicely7.cicely.de> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Bernd Walter , cvs-all@freebsd.org, arm@freebsd.org Subject: Re: cvs commit: src Makefile.inc1 src/gnu/lib Makefile src/gnu/lib/csu Makefile src/gnu/lib/libssp Makefile src/lib/csu Makefile.inc src/lib/libc Makefile src/lib/libstand Makefile src/lib/libthr Makefile src/libexec/rtld-elf Makefile src/release Makefile ... X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2008 21:45:27 -0000 Hi Bernd, Again, sorry for the late reply, I'm abroad this week once again for work, so I have very little time for my personal stuff. On Fri, Jul 18, 2008 at 01:40:59PM +0200, Bernd Walter wrote: > No change - with SSP all dynamic linked binaries fail the same as the > 7-stable did. > Without SSP only some binaries fail, but those are the same. > And of course since my 7-stable binaries were failing as well this > sounds like a kernel thing and not a userland one. > > What comes to mind after reading the original commit when reading the > compiler options used: > cc -mlittle-endian -c -O2 -pipe -fno-strict-aliasing -mcpu=arm9 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mcpu=arm9 -ffreestanding -fstack-protector -Werror ../../../arm/at91/at91_twi.c > The original message says that -fstack-protector shouldn't be used for > the kernel. > So why it is there? > I never explicitly enabled it anywhere. Actually, there was one patch to enable SSP for userland and another one for kernel, but they have been committed together and their commitlog has been concatenated. If you read it further, you will see the kernel part commitlog. Concerning the automatic activation, this is intended so as to give SSP more exposure. We'll need to reach a consensus for the release about whether it should be opt-in or opt-out. For now, you can disable it for both userland and kernel using the WITHOUT_SPP knob in src.conf(5). If you only want to disable it for kernel build, simply use "make -DWITHOUT_SSP buildkernel". I'm keen to hear about any clue you will gather about the problem. Thanks. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 00:40:47 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E4FA1065674; Tue, 22 Jul 2008 00:40:47 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id E0FBD8FC0A; Tue, 22 Jul 2008 00:40:46 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id m6M0ejTh066947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Jul 2008 02:40:45 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (cicely7.cicely.de [10.1.1.9]) by cicely5.cicely.de (8.14.2/8.14.2) with ESMTP id m6M0efUh087601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2008 02:40:41 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (localhost [127.0.0.1]) by cicely7.cicely.de (8.14.2/8.14.2) with ESMTP id m6M0eesg059759; Tue, 22 Jul 2008 02:40:40 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: (from ticso@localhost) by cicely7.cicely.de (8.14.2/8.14.2/Submit) id m6M0eeFB059758; Tue, 22 Jul 2008 02:40:40 +0200 (CEST) (envelope-from ticso) Date: Tue, 22 Jul 2008 02:40:40 +0200 From: Bernd Walter To: Jeremie Le Hen Message-ID: <20080722004040.GG58113@cicely7.cicely.de> References: <200806252138.m5PLcajG067917@repoman.freebsd.org> <20080707155017.6850f3a5.stas@FreeBSD.org> <20080711211909.GB33517@obiwan.tataz.chchile.org> <20080714234809.32cb8042.stas@FreeBSD.org> <20080715210512.GK35340@cicely7.cicely.de> <20080716021322.52f895c9.stas@FreeBSD.org> <20080715225443.GM35340@cicely7.cicely.de> <20080717140905.GX35340@cicely7.cicely.de> <20080718114058.GB35340@cicely7.cicely.de> <20080721213951.GN39074@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080721213951.GN39074@obiwan.tataz.chchile.org> X-Operating-System: FreeBSD cicely7.cicely.de 7.0-STABLE i386 User-Agent: Mutt/1.5.11 X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.142, BAYES_00=-2.599 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on spamd.cicely.de Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Bernd Walter , cvs-all@freebsd.org, arm@freebsd.org, ticso@cicely.de Subject: Re: cvs commit: src Makefile.inc1 src/gnu/lib Makefile src/gnu/lib/csu Makefile src/gnu/lib/libssp Makefile src/lib/csu Makefile.inc src/lib/libc Makefile src/lib/libstand Makefile src/lib/libthr Makefile src/libexec/rtld-elf Makefile src/release Makefile ... X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 00:40:47 -0000 On Mon, Jul 21, 2008 at 11:39:51PM +0200, Jeremie Le Hen wrote: > Hi Bernd, > > Again, sorry for the late reply, I'm abroad this week once again for > work, so I have very little time for my personal stuff. > > On Fri, Jul 18, 2008 at 01:40:59PM +0200, Bernd Walter wrote: > > No change - with SSP all dynamic linked binaries fail the same as the > > 7-stable did. > > Without SSP only some binaries fail, but those are the same. > > And of course since my 7-stable binaries were failing as well this > > sounds like a kernel thing and not a userland one. > > > > What comes to mind after reading the original commit when reading the > > compiler options used: > > cc -mlittle-endian -c -O2 -pipe -fno-strict-aliasing -mcpu=arm9 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mcpu=arm9 -ffreestanding -fstack-protector -Werror ../../../arm/at91/at91_twi.c > > The original message says that -fstack-protector shouldn't be used for > > the kernel. > > So why it is there? > > I never explicitly enabled it anywhere. > > Actually, there was one patch to enable SSP for userland and another one > for kernel, but they have been committed together and their commitlog > has been concatenated. If you read it further, you will see the > kernel part commitlog. Yes - I saw later that those were different compiler options. > Concerning the automatic activation, this is intended so as to give SSP > more exposure. We'll need to reach a consensus for the release about > whether it should be opt-in or opt-out. For now, you can disable it for > both userland and kernel using the WITHOUT_SPP knob in src.conf(5). If > you only want to disable it for kernel build, simply use "make > -DWITHOUT_SSP buildkernel". > > I'm keen to hear about any clue you will gather about the problem. Well Olivier Houchard went in and disabled SSP support on arm. He mentioned in his commit log a compiler bug, but you should ask him about the details. Unfortunately he missed one file, but after disabling this as well and recompiling the kernel, my problems were gone. -- B.Walter http://www.bwct.de Modbus/TCP Ethernet I/O Baugruppen, ARM basierte FreeBSD Rechner uvm. From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 01:03:27 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C537D106566C for ; Tue, 22 Jul 2008 01:03:27 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id 4580E8FC16 for ; Tue, 22 Jul 2008 01:03:27 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id m6M0aKC6066857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Jul 2008 02:36:20 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (cicely7.cicely.de [10.1.1.9]) by cicely5.cicely.de (8.14.2/8.14.2) with ESMTP id m6M0aFJN087553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Jul 2008 02:36:16 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (localhost [127.0.0.1]) by cicely7.cicely.de (8.14.2/8.14.2) with ESMTP id m6M0aExA059749; Tue, 22 Jul 2008 02:36:14 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: (from ticso@localhost) by cicely7.cicely.de (8.14.2/8.14.2/Submit) id m6M0aCXn059748; Tue, 22 Jul 2008 02:36:12 +0200 (CEST) (envelope-from ticso) Date: Tue, 22 Jul 2008 02:36:12 +0200 From: Bernd Walter To: John Hay Message-ID: <20080722003612.GF58113@cicely7.cicely.de> References: <20080117105854.GA44923@zibbi.meraka.csir.co.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080117105854.GA44923@zibbi.meraka.csir.co.za> X-Operating-System: FreeBSD cicely7.cicely.de 7.0-STABLE i386 User-Agent: Mutt/1.5.11 X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.143, BAYES_00=-2.599 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on spamd.cicely.de Cc: freebsd-arm@freebsd.org Subject: Re: sshd broken on arm? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 01:03:27 -0000 On Thu, Jan 17, 2008 at 12:58:54PM +0200, John Hay wrote: > Hi Guys, > > I just did a new build using RELENG_7 for the arm (Avila boards) and then > found that I cannot ssh into them. The sshd crash with a bus error just > after you entered your username and password. My build of mid November > did not do it. Anybody got ideas? > > The last part of "sshd -Dddd" on the arm board looks like this: > > debug1: server_input_channel_req: channel 0 request pty-req reply 0 > debug1: session_by_channel: session 0 channel 0 > debug1: session_input_channel_req: session 0 req pty-req > debug1: Allocating pty. > debug3: mm_request_send entering: type 25 > debug3: monitor_read: checking request 25 > debug3: mm_answer_pty entering > debug1: session_new: init > debug1: session_new: session 0 > debug3: mm_pty_allocate: waiting for MONITOR_ANS_PTY > debug3: mm_request_receive_expect entering: type 26 > debug3: mm_request_receive entering > debug3: mm_request_send entering: type 26 > ssh_mm_receive_fd: recvmsg: expected received 1 got 0 > debug1: do_cleanup > debug1: PAM: cleanup > Bus error (core dumped) > debug3: PAM: sshpam_thread_cleanup entering Have we dropped the ball on fixing this? With a recent -current I see excatly the same symptoms. -- B.Walter http://www.bwct.de Modbus/TCP Ethernet I/O Baugruppen, ARM basierte FreeBSD Rechner uvm. From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 04:06:07 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9CDA106566B for ; Tue, 22 Jul 2008 04:06:07 +0000 (UTC) (envelope-from jhay@meraka.csir.co.za) Received: from zibbi.meraka.csir.co.za (zibbi.meraka.csir.co.za [IPv6:2001:4200:7000:2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 0BF158FC0C for ; Tue, 22 Jul 2008 04:06:06 +0000 (UTC) (envelope-from jhay@meraka.csir.co.za) Received: by zibbi.meraka.csir.co.za (Postfix, from userid 3973) id 6323A33CDA; Tue, 22 Jul 2008 06:06:03 +0200 (SAST) Date: Tue, 22 Jul 2008 06:06:03 +0200 From: John Hay To: ticso@cicely.de Message-ID: <20080722040603.GA8241@zibbi.meraka.csir.co.za> References: <20080117105854.GA44923@zibbi.meraka.csir.co.za> <20080722003612.GF58113@cicely7.cicely.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080722003612.GF58113@cicely7.cicely.de> User-Agent: Mutt/1.4.2.1i Cc: freebsd-arm@freebsd.org Subject: Re: sshd broken on arm? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 04:06:08 -0000 On Tue, Jul 22, 2008 at 02:36:12AM +0200, Bernd Walter wrote: > On Thu, Jan 17, 2008 at 12:58:54PM +0200, John Hay wrote: > > Hi Guys, > > > > I just did a new build using RELENG_7 for the arm (Avila boards) and then > > found that I cannot ssh into them. The sshd crash with a bus error just > > after you entered your username and password. My build of mid November > > did not do it. Anybody got ideas? > > > > The last part of "sshd -Dddd" on the arm board looks like this: > > > > debug1: server_input_channel_req: channel 0 request pty-req reply 0 > > debug1: session_by_channel: session 0 channel 0 > > debug1: session_input_channel_req: session 0 req pty-req > > debug1: Allocating pty. > > debug3: mm_request_send entering: type 25 > > debug3: monitor_read: checking request 25 > > debug3: mm_answer_pty entering > > debug1: session_new: init > > debug1: session_new: session 0 > > debug3: mm_pty_allocate: waiting for MONITOR_ANS_PTY > > debug3: mm_request_receive_expect entering: type 26 > > debug3: mm_request_receive entering > > debug3: mm_request_send entering: type 26 > > ssh_mm_receive_fd: recvmsg: expected received 1 got 0 > > debug1: do_cleanup > > debug1: PAM: cleanup > > Bus error (core dumped) > > debug3: PAM: sshpam_thread_cleanup entering > > Have we dropped the ball on fixing this? > With a recent -current I see excatly the same symptoms. I did report it to openssh-unix-dev@mindrot.org, but then got busy with other things. I don't remember any response from them. John -- John Hay -- John.Hay@meraka.csir.co.za / jhay@FreeBSD.org From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 04:15:24 2008 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF98D106566C for ; Tue, 22 Jul 2008 04:15:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 80D148FC0A for ; Tue, 22 Jul 2008 04:15:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m6M4CFJH083656; Mon, 21 Jul 2008 22:12:15 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 21 Jul 2008 22:12:26 -0600 (MDT) Message-Id: <20080721.221226.-890724651.imp@bsdimp.com> To: ticso@cicely.de, ticso@cicely7.cicely.de From: "M. Warner Losh" In-Reply-To: <20080722003612.GF58113@cicely7.cicely.de> References: <20080117105854.GA44923@zibbi.meraka.csir.co.za> <20080722003612.GF58113@cicely7.cicely.de> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org Subject: Re: sshd broken on arm? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 04:15:24 -0000 In message: <20080722003612.GF58113@cicely7.cicely.de> Bernd Walter writes: : On Thu, Jan 17, 2008 at 12:58:54PM +0200, John Hay wrote: : > Hi Guys, : > : > I just did a new build using RELENG_7 for the arm (Avila boards) and then : > found that I cannot ssh into them. The sshd crash with a bus error just : > after you entered your username and password. My build of mid November : > did not do it. Anybody got ideas? : > : > The last part of "sshd -Dddd" on the arm board looks like this: : > : > debug1: server_input_channel_req: channel 0 request pty-req reply 0 : > debug1: session_by_channel: session 0 channel 0 : > debug1: session_input_channel_req: session 0 req pty-req : > debug1: Allocating pty. : > debug3: mm_request_send entering: type 25 : > debug3: monitor_read: checking request 25 : > debug3: mm_answer_pty entering : > debug1: session_new: init : > debug1: session_new: session 0 : > debug3: mm_pty_allocate: waiting for MONITOR_ANS_PTY : > debug3: mm_request_receive_expect entering: type 26 : > debug3: mm_request_receive entering : > debug3: mm_request_send entering: type 26 : > ssh_mm_receive_fd: recvmsg: expected received 1 got 0 : > debug1: do_cleanup : > debug1: PAM: cleanup : > Bus error (core dumped) : > debug3: PAM: sshpam_thread_cleanup entering : : Have we dropped the ball on fixing this? : With a recent -current I see excatly the same symptoms. Yes! We have... Warner From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 21:01:24 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B8C3106564A for ; Tue, 22 Jul 2008 21:01:24 +0000 (UTC) (envelope-from mjl@luckie.org.nz) Received: from mailfilter12.ihug.co.nz (mailfilter12.ihug.co.nz [203.109.136.12]) by mx1.freebsd.org (Postfix) with ESMTP id 33D6B8FC18 for ; Tue, 22 Jul 2008 21:01:24 +0000 (UTC) (envelope-from mjl@luckie.org.nz) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGPghUh2XQ69/2dsb2JhbACBWrAAgXw X-IronPort-AV: E=Sophos;i="4.31,233,1215345600"; d="scan'208";a="102236551" Received: from 118-93-14-189.dsl.dyn.ihug.co.nz (HELO spandex.luckie.org.nz) ([118.93.14.189]) by smtp.mailfilter4.ihug.co.nz with ESMTP/TLS/DHE-RSA-AES256-SHA; 23 Jul 2008 08:31:43 +1200 Received: from mjl by spandex.luckie.org.nz with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1KLOWM-0002yq-M9; Wed, 23 Jul 2008 08:31:42 +1200 Date: Wed, 23 Jul 2008 08:31:42 +1200 From: Matthew Luckie To: John Hay Message-ID: <20080722203142.GA11425@spandex.luckie.org.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080722040603.GA8241@zibbi.meraka.csir.co.za> User-Agent: Mutt/1.4.2.3i Cc: freebsd-arm@freebsd.org Subject: Re: sshd broken on arm? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 21:01:24 -0000 > > Have we dropped the ball on fixing this? > > With a recent -current I see excatly the same symptoms. > > I did report it to openssh-unix-dev@mindrot.org, but then got busy with > other things. I don't remember any response from them. your patch was committed. i'm running openssh from ports on my arm board and it works fine. i figured it would be fixed in base when the next openssh import is done. From owner-freebsd-arm@FreeBSD.ORG Tue Jul 22 22:03:03 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6A53106566C for ; Tue, 22 Jul 2008 22:03:03 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id 66F478FC25 for ; Tue, 22 Jul 2008 22:03:02 +0000 (UTC) (envelope-from ticso@cicely7.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id m6MM2x8Y025401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Jul 2008 00:03:00 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (cicely7.cicely.de [10.1.1.9]) by cicely5.cicely.de (8.14.2/8.14.2) with ESMTP id m6MM2trl071764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Jul 2008 00:02:55 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: from cicely7.cicely.de (localhost [127.0.0.1]) by cicely7.cicely.de (8.14.2/8.14.2) with ESMTP id m6MM2tr9062834; Wed, 23 Jul 2008 00:02:55 +0200 (CEST) (envelope-from ticso@cicely7.cicely.de) Received: (from ticso@localhost) by cicely7.cicely.de (8.14.2/8.14.2/Submit) id m6MM2pZY062833; Wed, 23 Jul 2008 00:02:51 +0200 (CEST) (envelope-from ticso) Date: Wed, 23 Jul 2008 00:02:51 +0200 From: Bernd Walter To: Matthew Luckie , des@freebsd.org Message-ID: <20080722220250.GP58113@cicely7.cicely.de> References: <20080722040603.GA8241@zibbi.meraka.csir.co.za> <20080722203142.GA11425@spandex.luckie.org.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080722203142.GA11425@spandex.luckie.org.nz> X-Operating-System: FreeBSD cicely7.cicely.de 7.0-STABLE i386 User-Agent: Mutt/1.5.11 X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.146, BAYES_00=-2.599 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on spamd.cicely.de Cc: freebsd-arm@freebsd.org Subject: Re: sshd broken on arm? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 22:03:03 -0000 On Wed, Jul 23, 2008 at 08:31:42AM +1200, Matthew Luckie wrote: > > > Have we dropped the ball on fixing this? > > > With a recent -current I see excatly the same symptoms. > > > > I did report it to openssh-unix-dev@mindrot.org, but then got busy with > > other things. I don't remember any response from them. > > your patch was committed. i'm running openssh from ports on my arm board > and it works fine. > > i figured it would be fixed in base when the next openssh import is done. That's great to hear. -- B.Walter http://www.bwct.de Modbus/TCP Ethernet I/O Baugruppen, ARM basierte FreeBSD Rechner uvm. From owner-freebsd-arm@FreeBSD.ORG Wed Jul 23 14:11:28 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A17FA1065671 for ; Wed, 23 Jul 2008 14:11:28 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from smarthost1.sentex.ca (smarthost1.sentex.ca [64.7.153.18]) by mx1.freebsd.org (Postfix) with ESMTP id 622F98FC20 for ; Wed, 23 Jul 2008 14:11:28 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from smtp1.sentex.ca (smtp1c.sentex.ca [64.7.153.10]) by smarthost1.sentex.ca (8.14.2/8.14.2) with ESMTP id m6NDd5QW075555; Wed, 23 Jul 2008 09:39:06 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by smtp1.sentex.ca (8.14.2/8.14.2) with ESMTP id m6NDd5CK045504; Wed, 23 Jul 2008 09:39:05 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: by freebsd-current.sentex.ca (Postfix, from userid 666) id B8F8773039; Wed, 23 Jul 2008 09:39:05 -0400 (EDT) Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Precedence: bulk Message-Id: <20080723133905.B8F8773039@freebsd-current.sentex.ca> Date: Wed, 23 Jul 2008 09:39:05 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.93, clamav-milter version 0.93 on clamscanner1 X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.64 on 64.7.153.18 Cc: Subject: [head tinderbox] failure on arm/arm X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 14:11:28 -0000 TB --- 2008-07-23 13:05:00 - tinderbox 2.3 running on freebsd-current.sentex.ca TB --- 2008-07-23 13:05:00 - starting HEAD tinderbox run for arm/arm TB --- 2008-07-23 13:05:00 - cleaning the object tree TB --- 2008-07-23 13:05:28 - cvsupping the source tree TB --- 2008-07-23 13:05:28 - /usr/bin/csup -r 3 -g -L 1 -h localhost -s /tinderbox/HEAD/arm/arm/supfile TB --- 2008-07-23 13:05:35 - building world (CFLAGS=-O -pipe) TB --- 2008-07-23 13:05:35 - cd /src TB --- 2008-07-23 13:05:35 - /usr/bin/make -B buildworld >>> World build started on Wed Jul 23 13:05:37 UTC 2008 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies [...] In file included from /obj/arm/src/tmp/usr/include/machine/cpufunc.h:50, from /src/sbin/ipf/ipresend/../../../sys/sys/systm.h:42, from /src/sbin/ipf/ipresend/../../../sys/sys/refcount.h:36, from /src/sbin/ipf/ipresend/../../../sys/sys/file.h:42, from /src/sbin/ipf/ipresend/../../../contrib/ipfilter/ipsend/sock.c:42: /obj/arm/src/tmp/usr/include/machine/cpuconf.h:94:2: error: #error ARM_NARCH is 0 /obj/arm/src/tmp/usr/include/machine/cpuconf.h:152:2: error: #error ARM_NMMUS is 0 mkdep: compile failed *** Error code 1 Stop in /src/sbin/ipf/ipresend. *** Error code 1 Stop in /src/sbin/ipf. *** Error code 1 Stop in /src/sbin. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2008-07-23 13:39:05 - WARNING: /usr/bin/make returned exit code 1 TB --- 2008-07-23 13:39:05 - ERROR: failed to build world TB --- 2008-07-23 13:39:05 - tinderbox aborted TB --- 1479.30 user 214.05 system 2044.59 real http://tinderbox.des.no/tinderbox-head-HEAD-arm-arm.full From owner-freebsd-arm@FreeBSD.ORG Wed Jul 23 17:26:27 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 939911065671; Wed, 23 Jul 2008 17:26:27 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from smarthost1.sentex.ca (smarthost1.sentex.ca [64.7.153.18]) by mx1.freebsd.org (Postfix) with ESMTP id 50EE58FC1A; Wed, 23 Jul 2008 17:26:27 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from smtp1.sentex.ca (smtp1c.sentex.ca [64.7.153.10]) by smarthost1.sentex.ca (8.14.2/8.14.2) with ESMTP id m6NHQLlt031509; Wed, 23 Jul 2008 13:26:21 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by smtp1.sentex.ca (8.14.2/8.14.2) with ESMTP id m6NHQLQe014087; Wed, 23 Jul 2008 13:26:21 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: by freebsd-current.sentex.ca (Postfix, from userid 666) id 8F2D273039; Wed, 23 Jul 2008 13:26:21 -0400 (EDT) Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Precedence: bulk Message-Id: <20080723172621.8F2D273039@freebsd-current.sentex.ca> Date: Wed, 23 Jul 2008 13:26:21 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.93, clamav-milter version 0.93 on clamscanner1 X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.64 on 64.7.153.18 Cc: Subject: [head tinderbox] failure on arm/arm X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 17:26:27 -0000 TB --- 2008-07-23 16:30:00 - tinderbox 2.3 running on freebsd-current.sentex.ca TB --- 2008-07-23 16:30:00 - starting HEAD tinderbox run for arm/arm TB --- 2008-07-23 16:30:00 - cleaning the object tree TB --- 2008-07-23 16:30:11 - cvsupping the source tree TB --- 2008-07-23 16:30:11 - /usr/bin/csup -r 3 -g -L 1 -h localhost -s /tinderbox/HEAD/arm/arm/supfile TB --- 2008-07-23 16:30:20 - building world (CFLAGS=-O -pipe) TB --- 2008-07-23 16:30:20 - cd /src TB --- 2008-07-23 16:30:20 - /usr/bin/make -B buildworld >>> World build started on Wed Jul 23 16:30:21 UTC 2008 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything [...] cc -O -pipe -I/src/sbin/ipf/ipresend/../../../contrib/ipfilter -I/src/sbin/ipf/ipresend/../../../contrib/ipfilter/tools -I/src/sbin/ipf/ipresend/../../../sys -I/src/sbin/ipf/ipresend/../../../sys/contrib/ipfilter -DSTATETOP -D__UIO_EXPOSE -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /src/sbin/ipf/ipresend/../../../contrib/ipfilter/ipsend/sock.c cc1: warnings being treated as errors In file included from /src/sbin/ipf/ipresend/../../../sys/sys/file.h:42, from /src/sbin/ipf/ipresend/../../../contrib/ipfilter/ipsend/sock.c:42: /src/sbin/ipf/ipresend/../../../sys/sys/refcount.h: In function 'refcount_acquire': /src/sbin/ipf/ipresend/../../../sys/sys/refcount.h:46: warning: implicit declaration of function 'atomic_add_acq_int' /src/sbin/ipf/ipresend/../../../sys/sys/refcount.h: In function 'refcount_release': /src/sbin/ipf/ipresend/../../../sys/sys/refcount.h:53: warning: implicit declaration of function 'atomic_fetchadd_int' *** Error code 1 Stop in /src/sbin/ipf/ipresend. *** Error code 1 Stop in /src/sbin/ipf. *** Error code 1 Stop in /src/sbin. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2008-07-23 17:26:21 - WARNING: /usr/bin/make returned exit code 1 TB --- 2008-07-23 17:26:21 - ERROR: failed to build world TB --- 2008-07-23 17:26:21 - tinderbox aborted TB --- 2526.91 user 323.68 system 3380.94 real http://tinderbox.des.no/tinderbox-head-HEAD-arm-arm.full From owner-freebsd-arm@FreeBSD.ORG Fri Jul 25 18:37:01 2008 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 524C01065677 for ; Fri, 25 Jul 2008 18:37:01 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226]) by mx1.freebsd.org (Postfix) with ESMTP id 004268FC22 for ; Fri, 25 Jul 2008 18:37:00 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by pele.citylink.co.nz (Postfix) with ESMTP id 8A0142BDA7 for ; Sat, 26 Jul 2008 06:17:52 +1200 (NZST) X-Virus-Scanned: Debian amavisd-new at citylink.co.nz Received: from pele.citylink.co.nz ([127.0.0.1]) by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bcGeHN-8MK2R for ; Sat, 26 Jul 2008 06:17:51 +1200 (NZST) Received: from citylink.fud.org.nz (unknown [202.8.44.45]) by pele.citylink.co.nz (Postfix) with ESMTP for ; Sat, 26 Jul 2008 06:17:51 +1200 (NZST) Received: by citylink.fud.org.nz (Postfix, from userid 1001) id 3756911430; Sat, 26 Jul 2008 06:17:51 +1200 (NZST) Date: Fri, 25 Jul 2008 11:17:51 -0700 From: Andrew Thompson To: freebsd-arm@FreeBSD.org Message-ID: <20080725181751.GB13638@citylink.fud.org.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Subject: ARM mfc list X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 18:37:01 -0000 Hi, I would like to do a large merge of arm fixes to 7-stable, some bugfixes and many just to reduce diffs. In particular 174051+177457+177459 fix usb on the avila board. The commit logs and diffs can also be found at http://people.freebsd.org/~thompsa/arm-mfc/ Please review this list and let me know if anything shouldnt be merged (or if you would like to handle your own commits). r172568 (kevlo) Spelling fix for interupt -> interrupt r172613 (cognet) Define _ARM_ARCH_5E too, so that we know if pld/strd/ldrd are available. r172614 (cognet) Do not use __XSCALE__ to detect if pld/strd/ldrd is available, use_ARM_ARCH_5E instead. r172738 (imp) Merge support from p4 (from NetBSD) for arm9e and arm10, arm11 cores. r172739 (imp) correct guard variable names. r173155 (imp) kill commented out line of code. r173215 (kevlo) Don't define get_cachetype() for CPU_ARM9E unless it's going to be used. r173249 (kevlo) __CPU_XSCALE_PXA2XX -> CPU_XSCALE_PXA2X0 r173336 (cognet) Remove a staled comment, NPE-C should work fine. r173442 (cognet) Add entries for the L2 cache-related functions for armv5. r174051 (cognet) Correct the logic : we can just invalidate the cache lines, and notwrite-back them, only if PREWRITE is not set, and if the buffer iscache-line aligned. r174058 (cognet) Fixes for ARM9/ARM10 :Call uma_sel_align() there at well.Set CPU_CONTROL_VECRELOC if we're using the high vectors page. r174176 (cognet) Move the strongarm-specific files from conf/files.arm to sa11x0/files.sa11xO. r174700 (kevlo) Use M_NOWAIT instead of M_WAITOK to cause malloc() to return NULL r174781 (imp) Actually program the interrupt controller for priorities. As wesupport more AT91 platforms, we'll need to move this into someplatform init routine. r175120 (cognet) Add a missing \n. r176759 (kevlo) Convert to be a 2-clause bsd-only license. r177103 (raj) Improve ARM bus_dmamap_load_buffer() error handling. r177105 (raj) Respect RF_SHAREABLE flag in ARM nexus_setup_intr() r177457 (sam) Correct cache handling for xfer requests marked URQ_REQUEST: many (if notall uses) involve a read but usbd_start_transfer only does a PREWRITE; changethis to BUS_DMASYNC_PREREAD | BUS_DMASYNC_PREWRITE as I'm not sure if anyusers do write+read. r177459 (sam) Workaround design botch in usb: blindly mixing bus_dma with PIO does notwork on architectures with a write-back cache as the PIO writes end upin the cache which the sync(BUS_DMASYNC_POSTREAD) in usb_transfer_completethen discards; compensate in the xfer methods that do PIO by pushing thewrites out of the cache before usb_transfer_complete is called. r177505 (sam) Improve mac+phy configuration so that hints can be used to describelayouts different than the defaults:o hint.npe.0.mac="A", "B", etc. specifies the window for MAC register accesseso hint.npe.0.mii="A", "B", etc. specifies PHY registerso hint.npe.1.phy=%d specifies the PHY to map to a port r177874 (imp) KERNBASE + 0x00200000 is the same thing as KERNVIRTADDR on thisplatform, so use the latter in preference to the former. This makesthe fake_preload setup be the same between kb920x_machdep.c andavila_machdep.c.... r177883 (imp) Take the first baby step towards unifying and cleaning up arminit(): - Pull all the code to deal with the trampoline stuff into one centeralized place and use it from everywhere. - Some minor style tidiness r177886 (raj) Fix AVILA build. r177887 (raj) Refactor certain ARM bus space methods: instead of having multiple copies ofthe same code introduce sys/arm/arm/bus_space_generic.c for a shared set ofroutines. r177888 (raj) Now really add the bus_space_generic.c file... r177916 (raj) Make kernel.tramp build properly on ARM9E. r177943 (cognet) Add bus_space_generic.c for the i81342 as well. r177944 (cognet) Remove bus_space_generic.c from the per-plarform files. Having it in theper-cpu files should be enough. r178001 (kevlo) Remove some long-dead code r179375 (imp) Release the resources for the registers for the TWI device withSYS_RES_MEMORY to match how we allocate them... r179664 (kevlo) Remove sa1_cache_clean_addr r179693 (wkoszek) Since we create a DMA tag "mtag" for TX map with bus_dmamap_create(),we must synchronize such a map against "mtag" with bus_dmamap_sync(),not the tag designated for RX map. r179745 (kevlo) Fix a typo: i80321_pci_probe -> i81342_pci_probe r180486 (ticso) fix multicast hash register definition r180584 (alc) Eliminate unused global variables. (These global variables became fields ofstruct kva_md_info many years ago.) From owner-freebsd-arm@FreeBSD.ORG Fri Jul 25 20:16:51 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA3531065679; Fri, 25 Jul 2008 20:16:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 658FF8FC16; Fri, 25 Jul 2008 20:16:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m6PKGjtV073014; Fri, 25 Jul 2008 16:16:45 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: current@freebsd.org Date: Fri, 25 Jul 2008 16:16:30 -0400 User-Agent: KMail/1.9.7 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807251616.30249.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Fri, 25 Jul 2008 16:16:45 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7827/Fri Jul 25 14:13:59 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: arm@freebsd.org Subject: PATCH: iicbus(4) locking, please test X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 20:16:51 -0000 I have a first attempt at adding locking to iicbus(4). Originally my goal was to do this so if_ic(4) could be locked. However, if_ic(4) does evil things in its ioctl routine so I'm actually going to leave that alone unless someone says they want to test possible changes. Back to iicbus(4), this patch adds locking to the core of iicbus and the various related drivers. A few drivers (ixp_iic, lpbb, and bktr) just use Giant for their driver lock for now. It has been compiled on my laptop (i386) but not anything else yet. http://www.FreeBSD.org/~jhb/patches/iicbus.patch -- John Baldwin