From owner-freebsd-arm@FreeBSD.ORG Sun Nov 16 09:50:03 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0C9E1065691 for ; Sun, 16 Nov 2008 09:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CBF888FC0C for ; Sun, 16 Nov 2008 09:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAG9o3nP004165 for ; Sun, 16 Nov 2008 09:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAG9o3IR004164; Sun, 16 Nov 2008 09:50:03 GMT (envelope-from gnats) Date: Sun, 16 Nov 2008 09:50:03 GMT Message-Id: <200811160950.mAG9o3IR004164@freefall.freebsd.org> To: freebsd-arm@FreeBSD.org From: Stanislav Sedov Cc: Subject: Re: arm/128897: [PATCH] Failture to build arm kernel with "options KTR" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stanislav Sedov List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2008 09:50:04 -0000 The following reply was made to PR arm/128897; it has been noted by GNATS. From: Stanislav Sedov To: Pankov Pavel Cc: bug-followup@FreeBSD.org Subject: Re: arm/128897: [PATCH] Failture to build arm kernel with "options KTR" Date: Sun, 16 Nov 2008 12:33:05 +0300 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sat, 15 Nov 2008 21:02:46 GMT Pankov Pavel mentioned: > Building ktr(4)-enabled ARM kernel results in error because of use of undefined variable Maxmem in _bus_dmamap_count_pages function. Have you checked KTR works at all on ARM kernels? - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkkf6NYACgkQK/VZk+smlYEt2QCdEFc9tg8xyKxzN66RFg5xE+9G PCYAnRfyo4kWugPNaEEyCH6o9SweU2/a =6nZH -----END PGP SIGNATURE----- From owner-freebsd-arm@FreeBSD.ORG Sun Nov 16 10:50:33 2008 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6762E106564A; Sun, 16 Nov 2008 10:50:33 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from semihalf.com (semihalf.com [206.130.101.55]) by mx1.freebsd.org (Postfix) with ESMTP id 206DC8FC19; Sun, 16 Nov 2008 10:50:32 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from mail.semihalf.com (mail.semihalf.com [83.15.139.206]) by semihalf.com (8.13.1/8.13.1) with ESMTP id mAGAoVQj000531; Sun, 16 Nov 2008 03:50:31 -0700 Message-Id: <60E0BD1F-A4BF-4E22-BF6D-A0B953F7193B@semihalf.com> From: =?ISO-8859-2?Q?Rafa=B3_Jaworowski?= To: Stanislav Sedov In-Reply-To: <200811160950.mAG9o3IR004164@freefall.freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Date: Sun, 16 Nov 2008 11:50:23 +0100 References: <200811160950.mAG9o3IR004164@freefall.freebsd.org> X-Mailer: Apple Mail (2.929.2) Cc: freebsd-arm@FreeBSD.org Subject: Re: arm/128897: [PATCH] Failture to build arm kernel with "options KTR" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2008 10:50:33 -0000 On 2008-11-16, at 10:50, Stanislav Sedov wrote: > The following reply was made to PR arm/128897; it has been noted by > GNATS. > > From: Stanislav Sedov > To: Pankov Pavel > Cc: bug-followup@FreeBSD.org > Subject: Re: arm/128897: [PATCH] Failture to build arm kernel with > "options KTR" > Date: Sun, 16 Nov 2008 12:33:05 +0300 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Sat, 15 Nov 2008 21:02:46 GMT > Pankov Pavel mentioned: > >> Building ktr(4)-enabled ARM kernel results in error because of use >> of undefined variable Maxmem in _bus_dmamap_count_pages function. > > Have you checked KTR works at all on ARM kernels? > I can confirm that KTR works without problems on ARM. The Maxmem issue is probably a leftover from some copy/paste from other arch, the variable is not set and used by the ARM code currently, so this particular KTR entry can be removed safely. Rafal From owner-freebsd-arm@FreeBSD.ORG Mon Nov 17 02:57:33 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08BEB1065674; Mon, 17 Nov 2008 02:57:33 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D27348FC0A; Mon, 17 Nov 2008 02:57:32 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAH2vWR4077087; Mon, 17 Nov 2008 02:57:32 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAH2vWr5077083; Mon, 17 Nov 2008 02:57:32 GMT (envelope-from linimon) Date: Mon, 17 Nov 2008 02:57:32 GMT Message-Id: <200811170257.mAH2vWr5077083@freefall.freebsd.org> To: pankov_p@mail.ru, linimon@FreeBSD.org, gnats-admin@FreeBSD.org, freebsd-arm@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: arm/128906: Re: arm/128897: [PATCH] Failure to build arm kernel with "options KTR" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 02:57:33 -0000 Old Synopsis: =?koi8-r?Q?Re[2]=3A_arm/128897=3A_[PATCH]_Failture_to_build_arm_kernel_with=22options_KTR=22?= New Synopsis: Re: arm/128897: [PATCH] Failure to build arm kernel with "options KTR" State-Changed-From-To: open->closed State-Changed-By: linimon State-Changed-When: Mon Nov 17 02:53:17 UTC 2008 State-Changed-Why: Misfiled followup to arm/128897. Responsible-Changed-From-To: gnats-admin->freebsd-arm Responsible-Changed-By: linimon Responsible-Changed-When: Mon Nov 17 02:53:17 UTC 2008 Responsible-Changed-Why: http://www.freebsd.org/cgi/query-pr.cgi?pr=128906 From owner-freebsd-arm@FreeBSD.ORG Mon Nov 17 11:06:49 2008 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73BFB1065678 for ; Mon, 17 Nov 2008 11:06:49 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A02588FC20 for ; Mon, 17 Nov 2008 11:06:47 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAHB6lTO082469 for ; Mon, 17 Nov 2008 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAHB6l0b082465 for freebsd-arm@FreeBSD.org; Mon, 17 Nov 2008 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 17 Nov 2008 11:06:47 GMT Message-Id: <200811171106.mAHB6l0b082465@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-arm@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-arm@FreeBSD.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 11:06:49 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o arm/128897 arm [PATCH] Failture to build arm kernel with "options KTR o arm/128891 arm [PATCH] Fix for spelling error in arm machdep code 2 problems total. From owner-freebsd-arm@FreeBSD.ORG Tue Nov 18 11:30:02 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1101E1065679 for ; Tue, 18 Nov 2008 11:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E2A3C8FC20 for ; Tue, 18 Nov 2008 11:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAIBU1PB013713 for ; Tue, 18 Nov 2008 11:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAIBU1La013710; Tue, 18 Nov 2008 11:30:01 GMT (envelope-from gnats) Resent-Date: Tue, 18 Nov 2008 11:30:01 GMT Resent-Message-Id: <200811181130.mAIBU1La013710@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-arm@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Björn König Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91280106567A for ; Tue, 18 Nov 2008 11:26:41 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from mail.liberty-hosting.de (mail.smartterra.de [195.225.132.203]) by mx1.freebsd.org (Postfix) with ESMTP id 56CE48FC1E for ; Tue, 18 Nov 2008 11:26:41 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from home.alpha-tierchen.de (port-87-234-81-35.dynamic.qsc.de [87.234.81.35]) by mail.liberty-hosting.de (Postfix) with ESMTP id 955943E8F46 for ; Tue, 18 Nov 2008 12:20:18 +0100 (CET) Received: by home.alpha-tierchen.de (Postfix, from userid 2000) id 6724128A19; Tue, 18 Nov 2008 12:26:36 +0100 (CET) Message-Id: <20081118112636.6724128A19@home.alpha-tierchen.de> Date: Tue, 18 Nov 2008 12:26:36 +0100 (CET) From: Björn König To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: arm/128959: [patch] Fix broken code for AT91. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Björn König List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2008 11:30:02 -0000 >Number: 128959 >Category: arm >Synopsis: [patch] Fix broken code for AT91. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-arm >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Nov 18 11:30:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Björn König >Release: >Organization: >Environment: >Description: The AT91 code is broken, i.e. it doesn't build because of minor bugs. >How-To-Repeat: >Fix: --- src-sys-arm-at91.diff begins here --- diff --git a/src/sys/arm/at91/at91_mci.c b/src/sys/arm/at91/at91_mci.c index 1e8b4a4..678cb14 100644 --- a/src/sys/arm/at91/at91_mci.c +++ b/src/sys/arm/at91/at91_mci.c @@ -176,7 +176,7 @@ at91_mci_attach(device_t dev) * Allocate DMA tags and maps */ err = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0, - BUS_SPACE_MAXADDR_32BIT, US_SPACE_MAXADDR, NULL, NULL, MAXPHYS, 1, + BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, MAXPHYS, 1, MAXPHYS, BUS_DMA_ALLOCNOW, NULL, NULL, &sc->dmatag); if (err != 0) goto out; diff --git a/src/sys/arm/at91/uart_dev_at91usart.c b/src/sys/arm/at91/uart_dev_at91usart.c index 9c598a4..d5d13c6 100644 --- a/src/sys/arm/at91/uart_dev_at91usart.c +++ b/src/sys/arm/at91/uart_dev_at91usart.c @@ -350,7 +350,7 @@ at91_usart_bus_attach(struct uart_softc *sc) /* * Allocate DMA tags and maps */ - err = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0, + err = bus_dma_tag_create(bus_get_dma_tag(sc->sc_dev), 1, 0, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, USART_BUFFER_SIZE, 1, USART_BUFFER_SIZE, BUS_DMA_ALLOCNOW, NULL, NULL, &atsc->dmatag); --- src-sys-arm-at91.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-arm@FreeBSD.ORG Tue Nov 18 12:10:06 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7934A106564A for ; Tue, 18 Nov 2008 12:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 56A608FC20 for ; Tue, 18 Nov 2008 12:10:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAICA6bJ043678 for ; Tue, 18 Nov 2008 12:10:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAICA6sl043677; Tue, 18 Nov 2008 12:10:06 GMT (envelope-from gnats) Resent-Date: Tue, 18 Nov 2008 12:10:06 GMT Resent-Message-Id: <200811181210.mAICA6sl043677@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-arm@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Björn König Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11F661065670 for ; Tue, 18 Nov 2008 12:03:40 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from mail.liberty-hosting.de (mail.smartterra.de [195.225.132.203]) by mx1.freebsd.org (Postfix) with ESMTP id CB7868FC17 for ; Tue, 18 Nov 2008 12:03:39 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from home.alpha-tierchen.de (port-87-234-81-35.dynamic.qsc.de [87.234.81.35]) by mail.liberty-hosting.de (Postfix) with ESMTP id 63A4F3E9D1F for ; Tue, 18 Nov 2008 12:57:17 +0100 (CET) Received: by home.alpha-tierchen.de (Postfix, from userid 2000) id 363CE28A19; Tue, 18 Nov 2008 13:03:35 +0100 (CET) Message-Id: <20081118120335.363CE28A19@home.alpha-tierchen.de> Date: Tue, 18 Nov 2008 13:03:35 +0100 (CET) From: Björn König To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: arm/128961: [patch] Detect main clock frequency of AT91 controller. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Björn König List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2008 12:10:06 -0000 >Number: 128961 >Category: arm >Synopsis: [patch] Detect main clock frequency of AT91 controller. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-arm >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Nov 18 12:10:06 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Björn König >Release: >Organization: >Environment: >Description: The PMC of the AT91 controller provides a register where you can find an estimation of the main clock frequency. The patch below uses this register to sense the frequency of the oscillating crystal. Alternatively you can set the frequency explicitely in the kernel configuration file with options AT91C_MAIN_CLOCK=16000000 for example. >How-To-Repeat: >Fix: --- src-sys-arm-at91.diff begins here --- diff --git src/sys/arm/at91/at91_pmc.c src/sys/arm/at91/at91_pmc.c index 061e2bc..c2a97ab 100644 --- src/sys/arm/at91/at91_pmc.c +++ src/sys/arm/at91/at91_pmc.c @@ -144,6 +144,17 @@ static struct at91_pmc_clock *const clock_list[] = { &ohci_clk }; +#if !defined(AT91C_MAIN_CLOCK) +static const int at91_mainf_tbl[] = { + 3000000, 3276800, 3686400, 3840000, 4000000, + 4433619, 4915200, 5000000, 5242880, 6000000, + 6144000, 6400000, 6553600, 7159090, 7372800, + 7864320, 8000000, 9830400, 10000000, 11059200, + 12000000, 12288000, 13560000, 14318180, 14745600, + 16000000, 17344700, 18432000, 20000000, 0 +}; +#endif + static inline uint32_t RD4(struct at91_pmc_softc *sc, bus_size_t off) { @@ -383,6 +394,26 @@ at91_pmc_probe(device_t dev) return (0); } +#if !defined(AT91C_MAIN_CLOCK) +static int +at91_pmc_sense_mainf(struct at91_pmc_softc *sc) +{ + int ret = 0; + const int *p; + int mainf = (RD4(sc, CKGR_MCFR) & CKGR_MCFR_MAINF_MASK) << 11; + unsigned diff = (unsigned)-1; + + for (p = at91_mainf_tbl; *p != 0; p++) + if (abs(mainf - *p) < diff) + { + diff = abs(mainf - *p); + ret = *p; + } + + return (ret); +} +#endif + static int at91_pmc_attach(device_t dev) { @@ -392,10 +423,10 @@ at91_pmc_attach(device_t dev) pmc_softc->dev = dev; if ((err = at91_pmc_activate(dev)) != 0) return err; -#if defined(AT91_TSC) | defined (AT91_BWCT) - at91_pmc_init_clock(pmc_softc, 16000000); +#if defined(AT91C_MAIN_CLOCK) + at91_pmc_init_clock(pmc_softc, AT91C_MAIN_CLOCK); #else - at91_pmc_init_clock(pmc_softc, 10000000); + at91_pmc_init_clock(pmc_softc, at91_pmc_sense_mainf(pmc_softc)); #endif return (0); diff --git src/sys/conf/options.arm src/sys/conf/options.arm index 66b2575..56791a8 100644 --- src/sys/conf/options.arm +++ src/sys/conf/options.arm @@ -5,6 +5,7 @@ ARMFPE opt_global.h ARM_KERN_DIRECTMAP opt_vm.h ARM_USE_SMALL_ALLOC opt_global.h AT91C_MASTER_CLOCK opt_global.h +AT91C_MAIN_CLOCK opt_at91.h COUNTS_PER_SEC opt_timer.h CPU_SA1100 opt_global.h CPU_SA1110 opt_global.h --- src-sys-arm-at91.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-arm@FreeBSD.ORG Tue Nov 18 12:30:30 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65E0E1065670; Tue, 18 Nov 2008 12:30:30 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3F6618FC26; Tue, 18 Nov 2008 12:30:30 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from freefall.freebsd.org (stas@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAICUUgw063329; Tue, 18 Nov 2008 12:30:30 GMT (envelope-from stas@freefall.freebsd.org) Received: (from stas@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAICUU5M063321; Tue, 18 Nov 2008 12:30:30 GMT (envelope-from stas) Date: Tue, 18 Nov 2008 12:30:30 GMT Message-Id: <200811181230.mAICUU5M063321@freefall.freebsd.org> To: stas@FreeBSD.org, freebsd-arm@FreeBSD.org, stas@FreeBSD.org From: stas@FreeBSD.org Cc: Subject: Re: arm/128959: [patch] Fix broken code for AT91. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2008 12:30:30 -0000 Synopsis: [patch] Fix broken code for AT91. Responsible-Changed-From-To: freebsd-arm->stas Responsible-Changed-By: stas Responsible-Changed-When: Tue Nov 18 12:30:29 UTC 2008 Responsible-Changed-Why: I'll take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=128959 From owner-freebsd-arm@FreeBSD.ORG Tue Nov 18 12:31:18 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40E041065674; Tue, 18 Nov 2008 12:31:18 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1A9EC8FC14; Tue, 18 Nov 2008 12:31:18 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from freefall.freebsd.org (stas@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAICVHi2066700; Tue, 18 Nov 2008 12:31:17 GMT (envelope-from stas@freefall.freebsd.org) Received: (from stas@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAICVHOO066696; Tue, 18 Nov 2008 12:31:17 GMT (envelope-from stas) Date: Tue, 18 Nov 2008 12:31:17 GMT Message-Id: <200811181231.mAICVHOO066696@freefall.freebsd.org> To: stas@FreeBSD.org, freebsd-arm@FreeBSD.org, stas@FreeBSD.org From: stas@FreeBSD.org Cc: Subject: Re: arm/128961: [patch] Detect main clock frequency of AT91 controller. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2008 12:31:18 -0000 Synopsis: [patch] Detect main clock frequency of AT91 controller. Responsible-Changed-From-To: freebsd-arm->stas Responsible-Changed-By: stas Responsible-Changed-When: Tue Nov 18 12:31:17 UTC 2008 Responsible-Changed-Why: I'll take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=128961 From owner-freebsd-arm@FreeBSD.ORG Wed Nov 19 07:00:13 2008 Return-Path: Delivered-To: freebsd-arm@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C812C106567B for ; Wed, 19 Nov 2008 07:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A3F188FC1E for ; Wed, 19 Nov 2008 07:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAJ70Dov004144 for ; Wed, 19 Nov 2008 07:00:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAJ70Dp7004138; Wed, 19 Nov 2008 07:00:13 GMT (envelope-from gnats) Resent-Date: Wed, 19 Nov 2008 07:00:13 GMT Resent-Message-Id: <200811190700.mAJ70Dp7004138@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-arm@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Björn König Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B56E106564A for ; Wed, 19 Nov 2008 06:59:36 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from mail.liberty-hosting.de (mail.smartterra.de [195.225.132.203]) by mx1.freebsd.org (Postfix) with ESMTP id 1E9BF8FC08 for ; Wed, 19 Nov 2008 06:59:35 +0000 (UTC) (envelope-from bkoenig@alpha-tierchen.de) Received: from home.alpha-tierchen.de (port-87-234-81-35.dynamic.qsc.de [87.234.81.35]) by mail.liberty-hosting.de (Postfix) with ESMTP id 4A3E13E950A for ; Wed, 19 Nov 2008 07:53:12 +0100 (CET) Received: by home.alpha-tierchen.de (Postfix, from userid 2000) id 1E5B328A19; Wed, 19 Nov 2008 07:59:32 +0100 (CET) Message-Id: <20081119065932.1E5B328A19@home.alpha-tierchen.de> Date: Wed, 19 Nov 2008 07:59:32 +0100 (CET) From: Björn König To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: arm/128987: [patch] Fix at91_mci and use 1-bit mode. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Björn König List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2008 07:00:13 -0000 >Number: 128987 >Category: arm >Synopsis: [patch] Fix at91_mci and use 1-bit mode. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-arm >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 19 07:00:13 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Björn König >Release: >Organization: >Environment: >Description: Currently SD Cards doesn't work with the at91_mci driver for AT91RM9200. These changes will make them work: - The 4-bit mode of the never worked. Disable it for now. - Return 'caps' ivar. Probably the 4-bit mode works for other AT91 controllers. Therefore it's necessary to find a better solution. >How-To-Repeat: >Fix: --- src-sys-arm-at91-at91_mci.c.diff begins here --- diff --git src/sys/arm/at91/at91_mci.c src/sys/arm/at91/at91_mci.c index 07efc71..8e1cdeb 100644 --- src/sys/arm/at91/at91_mci.c +++ src/sys/arm/at91/at91_mci.c @@ -200,7 +200,8 @@ at91_mci_attach(device_t dev) sc->host.f_min = 375000; sc->host.f_max = 30000000; sc->host.host_ocr = MMC_OCR_320_330 | MMC_OCR_330_340; - sc->host.caps = MMC_CAP_4_BIT_DATA; +// sc->host.caps = MMC_CAP_4_BIT_DATA; + sc->host.caps = 0; child = device_add_child(dev, "mmc", 0); device_set_ivars(dev, &sc->host); err = bus_generic_attach(dev); @@ -615,6 +616,9 @@ at91_mci_read_ivar(device_t bus, device_t child, int which, u_char *result) case MMCBR_IVAR_BUS_WIDTH: *(int *)result = sc->host.ios.bus_width; break; + case MMCBR_IVAR_CAPS: + *(int *)result = sc->host.caps; + break; case MMCBR_IVAR_CHIP_SELECT: *(int *)result = sc->host.ios.chip_select; break; --- src-sys-arm-at91-at91_mci.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: