From owner-freebsd-firewire@FreeBSD.ORG Mon Nov 10 11:06:50 2008 Return-Path: Delivered-To: freebsd-firewire@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0188E10656AA for ; Mon, 10 Nov 2008 11:06:50 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C37398FC27 for ; Mon, 10 Nov 2008 11:06:49 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mAAB6nol049696 for ; Mon, 10 Nov 2008 11:06:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mAAB6nKM049692 for freebsd-firewire@FreeBSD.org; Mon, 10 Nov 2008 11:06:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 10 Nov 2008 11:06:49 GMT Message-Id: <200811101106.mAAB6nKM049692@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-firewire@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-firewire@FreeBSD.org X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2008 11:06:50 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/113785 firewire [firewire] dropouts when playing DV on firewire o kern/74238 firewire [firewire] fw_rcv: unknown response; firewire ad-hoc w 2 problems total. From owner-freebsd-firewire@FreeBSD.ORG Tue Nov 11 07:41:59 2008 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C1A71065679 for ; Tue, 11 Nov 2008 07:41:59 +0000 (UTC) (envelope-from freebsd@sopwith.solgatos.com) Received: from sopwith.solgatos.com (pool-71-182-69-106.ptldor.fios.verizon.net [71.182.69.106]) by mx1.freebsd.org (Postfix) with ESMTP id 2E2ED8FC1C for ; Tue, 11 Nov 2008 07:41:57 +0000 (UTC) (envelope-from freebsd@sopwith.solgatos.com) Received: by sopwith.solgatos.com (Postfix, from userid 66) id CE24D3F22; Mon, 10 Nov 2008 09:15:32 -0800 (PST) Received: from localhost by sopwith.solgatos.com (8.8.8/6.24) id RAA12234; Mon, 10 Nov 2008 17:17:59 GMT Message-Id: <200811101717.RAA12234@sopwith.solgatos.com> To: Sean Bruno In-reply-to: Your message of "Mon, 27 Oct 2008 09:37:14 PDT." <4905EE3A.1050506@miralink.com> Date: Mon, 10 Nov 2008 09:17:58 +0000 From: Dieter Cc: freebsd-firewire@freebsd.org Subject: Re: patch for fwcontrol X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2008 07:41:59 -0000 In message <4905EE3A.1050506@miralink.com>, Sean Bruno writes: > Dieter wrote: > > The patch below: > > > > Fixes several err() vs errx() errors > > Improves some range checks > > Improves some messages > > Supports NetBSD in addition to FreeBSD > > > Ok, slightly reworked patch. Seems to work fine for me. Comments? Sean, Sorry for the delay, my normal outgoing email is hosed at the moment due to some problems upstream, so I'm trying workarounds with varying success. Incoming email is fine. Your version of the patch looks fine, although leaving out the ".0" of the device name will keep it from working on NetBSD. What do you think of something like #if defined(__FreeBSD__) snprintf(devbase, sizeof(devbase), "%s%d", device_string, current_board); #elif defined(__NetBSD__) snprintf(devbase, sizeof(devbase), "%s%d.0", device_string, current_board); #else #warning "You need to add support for your OS" #endif This make the code a bit messier, and FreeBSD works fine with the extra ".0" which is why I just added the ".0". I still don't know what the ".0" was/is for. So I see three options: 1) Check your patch in as is. NetBSDers will have to modify something. 2) Add the ".0". Obviously you don't like this option. 3) Put in the #if stuff as above. I'd prefer #2 or #3, but if you prefer #1 that's ok. thanks, Dieter