From owner-freebsd-fs@FreeBSD.ORG Sun May 25 22:34:22 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E14A106576D; Sun, 25 May 2008 22:34:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206046210.chello.pl [87.206.46.210]) by mx1.freebsd.org (Postfix) with ESMTP id 877818FC18; Sun, 25 May 2008 22:34:18 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 16BEB45C9B; Mon, 26 May 2008 00:14:52 +0200 (CEST) Received: from localhost (chello087206046210.chello.pl [87.206.46.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id D4D86456B1; Mon, 26 May 2008 00:14:45 +0200 (CEST) Date: Mon, 26 May 2008 00:14:44 +0200 From: Pawel Jakub Dawidek To: Kris Kennaway Message-ID: <20080525221444.GA8103@garage.freebsd.pl> References: <48376AA3.6090205@delphij.net> <20080523171509.K954@desktop> <20080524085224.GL20868@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline In-Reply-To: <20080524085224.GL20868@hub.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org, d@delphij.net, Jeff Roberson , Jeff Roberson Subject: Re: vfs.lookup_shared X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 May 2008 22:34:22 -0000 --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 24, 2008 at 08:52:24AM +0000, Kris Kennaway wrote: >=20 > On Fri, May 23, 2008 at 05:16:16PM -1000, Jeff Roberson wrote: > > On Fri, 23 May 2008, Xin LI wrote: > >=20 > > >-----BEGIN PGP SIGNED MESSAGE----- > > >Hash: SHA1 > > > > > >Hi, > > > > > >Is there any reason behind we don't have vfs.lookup_shared enabled by > > >default? > >=20 > > We have discussed enabling it by default once the ffs shared lookup=20 > > support is complete. Unfortunately ffs is still not 100% reliable. I= =20 > > want to verify that it's an ffs problem and not a problem with the vfs= =20 > > generic code which would effect all filesystems before we enable it by= =20 > > default. >=20 > Also, until Attilio's recent lockmgr work, shared lockmgr locks were > starving exclusive lockmgr lock requests, leading to performance > problems on some workloads with the only filesystem that supported > shared locking (NFS). This is now fixed though. ZFS also supports shared locking and shared lookups. I've vfs.lookup_shared=3D1 on my ZFS-only laptop for more than a year now and never had a problem. Although it is only a laptop... --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --SUOF0GtieIMvvwua Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIOeTUForvXbEpPzQRAmwdAKDYSrfUaUXipjrjmxAy7ON0JCuvkACg4ygG M5ZqhmJiPxEJckyzjRzqu8g= =tPL2 -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua-- From owner-freebsd-fs@FreeBSD.ORG Mon May 26 11:06:47 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF390106566C for ; Mon, 26 May 2008 11:06:47 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB2068FC43 for ; Mon, 26 May 2008 11:06:47 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4QB6lcx064880 for ; Mon, 26 May 2008 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4QB6lOH064876 for freebsd-fs@FreeBSD.org; Mon, 26 May 2008 11:06:47 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 26 May 2008 11:06:47 GMT Message-Id: <200805261106.m4QB6lOH064876@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-fs@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2008 11:06:47 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/112658 fs [smbfs] [patch] smbfs and caching problems (resolves b o kern/114676 fs [ufs] snapshot creation panics: snapacct_ufs2: bad blo o kern/116170 fs [panic] Kernel panic when mounting /tmp o bin/121072 fs [smbfs] mount_smbfs(8) cannot normally convert the cha o bin/122172 fs [amd] [fs]: amd(8) automount daemon dies on 6.3-STABLE o kern/122888 fs [zfs] zfs hang w/ prefetch on, zil off while running t 6 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/113049 fs [patch] [request] make quot(8) use getopt(3) and show o bin/113838 fs [patch] [request] mount(8): add support for relative p o bin/114468 fs [patch] [request] add -d option to umount(8) to detach o kern/114847 fs [ntfs] [patch] [request] dirmask support for NTFS ala o kern/114955 fs [cd9660] [patch] [request] support for mask,dirmask,ui o bin/118249 fs mv(1): moving a directory changes its mtime 6 problems total. From owner-freebsd-fs@FreeBSD.ORG Thu May 29 06:46:36 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2722C1065676 for ; Thu, 29 May 2008 06:46:36 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by mx1.freebsd.org (Postfix) with ESMTP id 059508FC12 for ; Thu, 29 May 2008 06:46:35 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: by rv-out-0506.google.com with SMTP id l9so3944557rvb.1 for ; Wed, 28 May 2008 23:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; bh=5qwNGspqXNIWJsUzYaibq2k4nbWFbBFS0K8RTzAYb74=; b=Uh8qQGHqwO2WZlq9Z2Q38D77t85K6fj6RzRB0c1JvZuS46jsZhMi5/Wo11GKg8gtP8i3v3MlvawKG7+P5SqlA0ZvSrvJrpjQa3/uRESFRYx3z6QfY7NIKTBr61+5RCx1eKxQ1yxHRtZPnDjaB8a/yIl2RP6IE8taVoYpPRbnvag= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=qIBv7cM2bkAbHSfzWJ+AI9ELMhh1fKDvkjKhWfKrC+q1tbnno7fF8EycbGYSniuJA+sFPS8LlwQRbYWmExXKLddgWQHefTnuwgz612N3jSHjLr9Tt8EPfAQmbEom1/10tAoRd0aBhlS/5StF9JtbpCCONuZh+3MH+YfRRB0sR00= Received: by 10.141.193.1 with SMTP id v1mr1833227rvp.73.1212043595676; Wed, 28 May 2008 23:46:35 -0700 (PDT) Received: by 10.141.76.1 with HTTP; Wed, 28 May 2008 23:46:35 -0700 (PDT) Message-ID: Date: Fri, 30 May 2008 02:16:35 +1930 From: "Ighighi Ighighi" To: bug-followup@freebsd.org, freebsd-fs@freebsd.org. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_19656_29267160.1212043595698" Cc: Subject: Re: kern/122047: [ext2fs] incorrect handling of UF_IMMUTABLE / UF_APPEND flag on EXT2FS (maybe others) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2008 06:46:36 -0000 ------=_Part_19656_29267160.1212043595698 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline See attached patch. ------=_Part_19656_29267160.1212043595698 Content-Type: text/plain; name=ext2fs.patch.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fgszfnrm1 Content-Disposition: attachment; filename=ext2fs.patch.txt IwojICghYykgMjAwOCBieSBJZ2hpZ2hpCiMKIyBTZWUgaHR0cDovL3d3dy5mcmVlYnNkLm9yZy9j Z2kvcXVlcnktcHIuY2dpP3ByPWtlcm4vMTIyMDQ3CiMKIyBUaGlzIHBhdGNoIGFkZHMgYSAidmZz LmUyZnMudXNlcmZsYWdzIiBzeXNjdGwgdG8gcGVybWl0IHJlZ3VsYXIgdXNlcnMKIyB0byBzZXQv Y2xlYXIgdGhlIEFQUEVORC9JTU1VVEFCTEUgZmlsZXN5c3RlbSBmbGFncyBvbiBFWFQyIGZpbGVz eXN0ZW1zLgojIEFzIGEgYm9udXMsIGl0IGFsc28gc2V0cyBzdF9iaXJ0aHRpbWUgdG8gemVyby4K IwojIEJ1aWx0IGFuZCB0ZXN0ZWQgb24gRnJlZUJTRCA2LjMtU1RBQkxFIChSRUxFTkdfNikuCiMg S25vd24gdG8gcGF0Y2ggb24gLUNVUlJFTlQKIwojIFRvIGluc3RhbGwsIHJ1biBhcyByb290Ogoj ICAgL3NiaW4vdW1vdW50IC12IC10IGV4dDJmcyAtYQojICAgL3NiaW4va2xkdW5sb2FkIC12IGV4 dDJmcwojICAgL3Vzci9iaW4vcGF0Y2ggLWQgL3VzciA8IC9wYXRoL3RvL2V4dDJmcy5wYXRjaAoj ICAgY2QgL3N5cy9tb2R1bGVzL2V4dDJmcy8KIyAgIG1ha2UgY2xlYW4gb2JqIGRlcGVuZCAmJiBt YWtlICYmIG1ha2UgaW5zdGFsbAojICAgL3NiaW4va2xkbG9hZCAtdiBleHQyZnMKIyAgIC9zYmlu L3N5c2N0bCB2ZnMuZTJmcy51c2VyZmxhZ3M9MSAgIyAwIGlzIGRlZmF1bHQKIyAgIC9zYmluL21v dW50IC12IC10IGV4dDJmcyAtYQojCgotLS0gc3JjL3N5cy9nbnUvZnMvZXh0MmZzL2V4dDJfaW5v ZGVfY252LmMub3JpZwkyMDA1LTA2LTE0IDIyOjM2OjEwLjAwMDAwMDAwMCAtMDQwMAorKysgc3Jj L3N5cy9nbnUvZnMvZXh0MmZzL2V4dDJfaW5vZGVfY252LmMJMjAwOC0wNS0yOCAxNToxNToyNy41 MjczMTg4NTQgLTA0MzAKQEAgLTMwLDExICszMCwxOSBAQAogI2luY2x1ZGUgPHN5cy9sb2NrLmg+ CiAjaW5jbHVkZSA8c3lzL3N0YXQuaD4KICNpbmNsdWRlIDxzeXMvdm5vZGUuaD4KKyNpbmNsdWRl IDxzeXMva2VybmVsLmg+CisjaW5jbHVkZSA8c3lzL3N5c2N0bC5oPgogCiAjaW5jbHVkZSA8Z251 L2ZzL2V4dDJmcy9pbm9kZS5oPgogI2luY2x1ZGUgPGdudS9mcy9leHQyZnMvZXh0Ml9mcy5oPgog I2luY2x1ZGUgPGdudS9mcy9leHQyZnMvZXh0Ml9leHRlcm4uaD4KIAorU1lTQ1RMX0RFQ0woX3Zm c19lMmZzKTsKKworc3RhdGljIGludCB1c2VyZmxhZ3MgPSAwOworU1lTQ1RMX0lOVChfdmZzX2Uy ZnMsIE9JRF9BVVRPLCB1c2VyZmxhZ3MsIENUTEZMQUdfUlcsCisgICAgJnVzZXJmbGFncywgMCwg IlVzZXJzIG1heSBzZXQvY2xlYXIgZmlsZXN5c3RlbSBmbGFncyIpOworCiB2b2lkCiBleHQyX3By aW50X2lub2RlKCBpbiApCiAJc3RydWN0IGlub2RlICppbjsKQEAgLTgzLDggKzkxLDE3IEBAIGV4 dDJfZWkyaShlaSwgaXApCiAJaXAtPmlfbXRpbWUgPSBlaS0+aV9tdGltZTsKIAlpcC0+aV9jdGlt ZSA9IGVpLT5pX2N0aW1lOwogCWlwLT5pX2ZsYWdzID0gMDsKLQlpcC0+aV9mbGFncyB8PSAoZWkt PmlfZmxhZ3MgJiBFWFQyX0FQUEVORF9GTCkgPyBBUFBFTkQgOiAwOwotCWlwLT5pX2ZsYWdzIHw9 IChlaS0+aV9mbGFncyAmIEVYVDJfSU1NVVRBQkxFX0ZMKSA/IElNTVVUQUJMRSA6IDA7CisJaWYg KHVzZXJmbGFncykgeworCQlpZiAoZWktPmlfZmxhZ3MgJiBFWFQyX0FQUEVORF9GTCkKKwkJCWlw LT5pX2ZsYWdzIHw9IFVGX0FQUEVORDsKKwkJaWYgKGVpLT5pX2ZsYWdzICYgRVhUMl9JTU1VVEFC TEVfRkwpCisJCQlpcC0+aV9mbGFncyB8PSBVRl9JTU1VVEFCTEU7CisJfSBlbHNlIHsKKwkJaWYg KGVpLT5pX2ZsYWdzICYgRVhUMl9BUFBFTkRfRkwpCisJCQlpcC0+aV9mbGFncyB8PSBBUFBFTkQ7 CisJCWlmIChlaS0+aV9mbGFncyAmIEVYVDJfSU1NVVRBQkxFX0ZMKQorCQkJaXAtPmlfZmxhZ3Mg fD0gSU1NVVRBQkxFOworCX0KIAlpcC0+aV9ibG9ja3MgPSBlaS0+aV9ibG9ja3M7CiAJaXAtPmlf Z2VuID0gZWktPmlfZ2VuZXJhdGlvbjsKIAlpcC0+aV91aWQgPSBlaS0+aV91aWQ7Ci0tLSBzcmMv c3lzL2dudS9mcy9leHQyZnMvZXh0Ml9sb29rdXAuYy5vcmlnCTIwMDYtMDEtMDQgMTU6MzI6MDAu MDAwMDAwMDAwIC0wNDAwCisrKyBzcmMvc3lzL2dudS9mcy9leHQyZnMvZXh0Ml9sb29rdXAuYwky MDA4LTA1LTI4IDEzOjM1OjE2Ljg0MTM0OTI2OSAtMDQzMApAQCAtNjYsNyArNjYsNyBAQCBzdGF0 aWMgaW50IGRpcmNoayA9IDE7CiBzdGF0aWMgaW50IGRpcmNoayA9IDA7CiAjZW5kaWYKIAotc3Rh dGljIFNZU0NUTF9OT0RFKF92ZnMsIE9JRF9BVVRPLCBlMmZzLCBDVExGTEFHX1JELCAwLCAiRVhU MkZTIGZpbGVzeXN0ZW0iKTsKK1NZU0NUTF9OT0RFKF92ZnMsIE9JRF9BVVRPLCBlMmZzLCBDVExG TEFHX1JXLCAwLCAiRVhUMkZTIGZpbGVzeXN0ZW0iKTsKIFNZU0NUTF9JTlQoX3Zmc19lMmZzLCBP SURfQVVUTywgZGlyY2hlY2ssIENUTEZMQUdfUlcsICZkaXJjaGssIDAsICIiKTsKIAogLyoKLS0t IHNyYy9zeXMvZ251L2ZzL2V4dDJmcy9leHQyX3Zub3BzLmMub3JpZwkyMDA2LTAyLTE5IDIwOjUz OjE0LjAwMDAwMDAwMCAtMDQwMAorKysgc3JjL3N5cy9nbnUvZnMvZXh0MmZzL2V4dDJfdm5vcHMu YwkyMDA4LTA1LTI4IDA3OjU4OjAyLjE4OTE1NzQ0MSAtMDQzMApAQCAtMzU4LDYgKzM1OCw4IEBA IGV4dDJfZ2V0YXR0cihhcCkKIAl2YXAtPnZhX210aW1lLnR2X25zZWMgPSBpcC0+aV9tdGltZW5z ZWM7CiAJdmFwLT52YV9jdGltZS50dl9zZWMgPSBpcC0+aV9jdGltZTsKIAl2YXAtPnZhX2N0aW1l LnR2X25zZWMgPSBpcC0+aV9jdGltZW5zZWM7CisJdmFwLT52YV9iaXJ0aHRpbWUudHZfc2VjID0g MDsKKwl2YXAtPnZhX2JpcnRodGltZS50dl9uc2VjID0gMDsKIAl2YXAtPnZhX2ZsYWdzID0gaXAt PmlfZmxhZ3M7CiAJdmFwLT52YV9nZW4gPSBpcC0+aV9nZW47CiAJdmFwLT52YV9ibG9ja3NpemUg PSB2cC0+dl9tb3VudC0+bW50X3N0YXQuZl9pb3NpemU7Cg== ------=_Part_19656_29267160.1212043595698-- From owner-freebsd-fs@FreeBSD.ORG Thu May 29 06:56:37 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D25D1065674 for ; Thu, 29 May 2008 06:56:37 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.235]) by mx1.freebsd.org (Postfix) with ESMTP id 4DBA78FC13 for ; Thu, 29 May 2008 06:56:37 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so3970323rvf.43 for ; Wed, 28 May 2008 23:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=xNQJdkbuX+OkUJ97HqeIoQu9sW9q67McoqEsV8rv54g=; b=JyCfuqjJJt61/s858Zo8XEEZu2ukgBiMd4GQP8Kr4wBS8TwnZPE33gFNvwfeZwjEEL1MOzFEG1inJjnF4p8vTrlZ9oXAcrVm3WElQ/O591Tog7UC05a6LTuL94aXGF+EnKp87XbxDVRr5WvEU39OOJzajYGhr8T0zzaLQ5beTlU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=ERkexnkpt9eJvd+rhEb/P/6j9IIoo3Zrt9H2tHCXxhLeCDS5s2OW9h/Mi9a12TISklJbp2OIldGzApFM8iSb0G3PBBtMad5lRBmttsysfuaOzXOUH39tyaxumKDQj3/tGuuAgwyMpvIu5zeY0yTVSCf9c6RH5ITAVSh7FHsleLg= Received: by 10.141.21.6 with SMTP id y6mr1852666rvi.18.1212042609748; Wed, 28 May 2008 23:30:09 -0700 (PDT) Received: by 10.141.76.1 with HTTP; Wed, 28 May 2008 23:30:09 -0700 (PDT) Message-ID: Date: Fri, 30 May 2008 02:00:09 +1930 From: "Ighighi Ighighi" To: bug-followup@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: freebsd-fs@freebsd.org Subject: Re: kern/122047: [ext2fs] incorrect handling of UF_IMMUTABLE / UF_APPEND flag on EXT2FS (maybe others) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2008 06:56:37 -0000 See attached patch. From owner-freebsd-fs@FreeBSD.ORG Thu May 29 07:37:07 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A86E51065675 for ; Thu, 29 May 2008 07:37:07 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: from hs-out-0708.google.com (hs-out-0708.google.com [64.233.178.245]) by mx1.freebsd.org (Postfix) with ESMTP id 6411B8FC18 for ; Thu, 29 May 2008 07:37:07 +0000 (UTC) (envelope-from ighighi@gmail.com) Received: by hs-out-0708.google.com with SMTP id 4so2465348hsl.1 for ; Thu, 29 May 2008 00:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:content-type; bh=zGaMqIJUajmB7MJ1JHvsaJq9qyVdmKRD3aTN7ApBib8=; b=SKnBL93gmBSmSalLJnfr6MMoG3mX9gourRaYA9SjU6g+LxUbVXtnR5KZFCYnlu4ha59GlOs+n/ZfoptCe9OEGfGK5IpkZDW+6N50fqDjVFJHbB3TMWzl4bO8LMVZVuKvhgiIOTCdiz5+QXPgu8oVDAHVc7xh7sBunQ4zh36EHDM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:content-type; b=OR/k0fKCviS/93FrVTLLGG+ZFwBwc0MQHB+6+2jZybyVvlwmzFe79GpBA80spdQL0SduRnrmlh2thQ4v5wo6kjPYPLP7SFCKJrMuV6c0m2zNNZ1Ju4nSO6UTTFBwv4LYVPx3YHWMvcBUlU/ZKrvkWVwFyaqOKQYVwbXAdZvpWno= Received: by 10.90.102.8 with SMTP id z8mr4874056agb.53.1212046626503; Thu, 29 May 2008 00:37:06 -0700 (PDT) Received: from orion.nebula.mil ( [200.82.219.99]) by mx.google.com with ESMTPS id 34sm328583agc.9.2008.05.29.00.36.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 29 May 2008 00:37:04 -0700 (PDT) Message-ID: <483E5CFE.7030807@gmail.com> Date: Thu, 29 May 2008 03:06:30 -0430 From: Ighighi User-Agent: Thunderbird 2.0.0.14 (X11/20080504) MIME-Version: 1.0 To: bug-followup@freebsd.org Content-Type: multipart/mixed; boundary="------------010600060401000202060602" Cc: freebsd-fs@freebsd.org. Subject: Re: kern/122047: [ext2fs] incorrect handling of UF_IMMUTABLE / UF_APPEND flag on EXT2FS (maybe others) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2008 07:37:07 -0000 This is a multi-part message in MIME format. --------------010600060401000202060602 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit See attached patch. Gmail sucks at sending patches to GNATS =( --------------010600060401000202060602 Content-Type: text/plain; name="ext2fs.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ext2fs.patch.txt" # # (!c) 2008 by Ighighi # # See http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/122047 # # This patch adds a "vfs.e2fs.userflags" sysctl to permit regular users # to set/clear the APPEND/IMMUTABLE filesystem flags on EXT2 filesystems. # As a bonus, it also sets st_birthtime to zero. # # Built and tested on FreeBSD 6.3-STABLE (RELENG_6). # Known to patch on -CURRENT # # To install, run as root: # /sbin/umount -v -t ext2fs -a # /sbin/kldunload -v ext2fs # /usr/bin/patch -d /usr < /path/to/ext2fs.patch # cd /sys/modules/ext2fs/ # make clean obj depend && make && make install # /sbin/kldload -v ext2fs # /sbin/sysctl vfs.e2fs.userflags=1 # 0 is default # /sbin/mount -v -t ext2fs -a # --- src/sys/gnu/fs/ext2fs/ext2_inode_cnv.c.orig 2005-06-14 22:36:10.000000000 -0400 +++ src/sys/gnu/fs/ext2fs/ext2_inode_cnv.c 2008-05-28 15:15:27.527318854 -0430 @@ -30,11 +30,19 @@ #include #include #include +#include +#include #include #include #include +SYSCTL_DECL(_vfs_e2fs); + +static int userflags = 0; +SYSCTL_INT(_vfs_e2fs, OID_AUTO, userflags, CTLFLAG_RW, + &userflags, 0, "Users may set/clear filesystem flags"); + void ext2_print_inode( in ) struct inode *in; @@ -83,8 +91,17 @@ ext2_ei2i(ei, ip) ip->i_mtime = ei->i_mtime; ip->i_ctime = ei->i_ctime; ip->i_flags = 0; - ip->i_flags |= (ei->i_flags & EXT2_APPEND_FL) ? APPEND : 0; - ip->i_flags |= (ei->i_flags & EXT2_IMMUTABLE_FL) ? IMMUTABLE : 0; + if (userflags) { + if (ei->i_flags & EXT2_APPEND_FL) + ip->i_flags |= UF_APPEND; + if (ei->i_flags & EXT2_IMMUTABLE_FL) + ip->i_flags |= UF_IMMUTABLE; + } else { + if (ei->i_flags & EXT2_APPEND_FL) + ip->i_flags |= APPEND; + if (ei->i_flags & EXT2_IMMUTABLE_FL) + ip->i_flags |= IMMUTABLE; + } ip->i_blocks = ei->i_blocks; ip->i_gen = ei->i_generation; ip->i_uid = ei->i_uid; --- src/sys/gnu/fs/ext2fs/ext2_lookup.c.orig 2006-01-04 15:32:00.000000000 -0400 +++ src/sys/gnu/fs/ext2fs/ext2_lookup.c 2008-05-28 13:35:16.841349269 -0430 @@ -66,7 +66,7 @@ static int dirchk = 1; static int dirchk = 0; #endif -static SYSCTL_NODE(_vfs, OID_AUTO, e2fs, CTLFLAG_RD, 0, "EXT2FS filesystem"); +SYSCTL_NODE(_vfs, OID_AUTO, e2fs, CTLFLAG_RW, 0, "EXT2FS filesystem"); SYSCTL_INT(_vfs_e2fs, OID_AUTO, dircheck, CTLFLAG_RW, &dirchk, 0, ""); /* --- src/sys/gnu/fs/ext2fs/ext2_vnops.c.orig 2006-02-19 20:53:14.000000000 -0400 +++ src/sys/gnu/fs/ext2fs/ext2_vnops.c 2008-05-28 07:58:02.189157441 -0430 @@ -358,6 +358,8 @@ ext2_getattr(ap) vap->va_mtime.tv_nsec = ip->i_mtimensec; vap->va_ctime.tv_sec = ip->i_ctime; vap->va_ctime.tv_nsec = ip->i_ctimensec; + vap->va_birthtime.tv_sec = 0; + vap->va_birthtime.tv_nsec = 0; vap->va_flags = ip->i_flags; vap->va_gen = ip->i_gen; vap->va_blocksize = vp->v_mount->mnt_stat.f_iosize; --------------010600060401000202060602-- From owner-freebsd-fs@FreeBSD.ORG Fri May 30 06:48:59 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3202106566B; Fri, 30 May 2008 06:48:58 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206046210.chello.pl [87.206.46.210]) by mx1.freebsd.org (Postfix) with ESMTP id 5E80E8FC1B; Fri, 30 May 2008 06:48:58 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 5AB2045C8C; Fri, 30 May 2008 08:48:56 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 687C74569A; Fri, 30 May 2008 08:48:51 +0200 (CEST) Date: Fri, 30 May 2008 08:48:52 +0200 From: Pawel Jakub Dawidek To: Joe Peterson Message-ID: <20080530064851.GA3596@garage.freebsd.pl> References: <47ACD7D4.5050905@skyrush.com> <47ACDE82.1050100@skyrush.com> <20080208173517.rdtobnxqg4g004c4@www.wolves.k12.mo.us> <47ACF0AE.3040802@skyrush.com> <1202747953.27277.7.camel@buffy.york.ac.uk> <47B0A45C.4090909@skyrush.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <47B0A45C.4090909@skyrush.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org, freebsd-stable@freebsd.org, Gavin Atkinson Subject: Re: Analysis of disk file block with ZFS checksum error X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2008 06:48:59 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 11, 2008 at 12:39:08PM -0700, Joe Peterson wrote: > Gavin Atkinson wrote: > > Are the datestamps (Thu Jan 24 23:20:58 2008) found within the corrupt > > block before or after the datestamp of the file it was found within? > > i.e. was the corrupt block on the disk before or after the mp3 was > > written there? >=20 > Hi Gavin, those dated are later than the original copy (I do not have > the file timestamps to prove this, but according to my email record, I > am pretty sure of this). So the corrupt block is later than the > original write. >=20 > If this is the case, I assume that the block got written, by mistake, > into the middle of the mp3 file. Someone else suggested that it could > be caused by a bad transfer block number or bad drive command (corrupted > on the way to the drive, since these are not checksummed in the > hardware). If the block went to the wrong place, AND if it was a HW > glitch, I suppose the best ZFS could then do is retry the write (if its > failure was even detected - still not sure if ZFS does a re-check of the > disk data checksum after the disk write), not knowing until the later > scrub that the block had corrupted a file. ZFS doesn't verify checksum after write, it would be pointless for two reasons: 1. The read will come most likely from disk cache and not from the stable storage. 2. This would kill performance. ZFS test checksum only on read. What you observe is either a misdirected read/write (you asked to read/write sector X, but the data was read from or wrote to sector Y) or a phantom write (you asked to write, but the data never reach the disk, so you have old data there). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIP6NTForvXbEpPzQRAquWAKCV3zdQRV84Rgo2wOVqcTEpT+Sq+QCg5vsx dysO0Htb8e2R/zqPIzAJzGU= =GOYO -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q-- From owner-freebsd-fs@FreeBSD.ORG Fri May 30 06:54:44 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5973D106566B for ; Fri, 30 May 2008 06:54:44 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206046210.chello.pl [87.206.46.210]) by mx1.freebsd.org (Postfix) with ESMTP id BF5A68FC1B for ; Fri, 30 May 2008 06:54:43 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 6A99545C9F; Fri, 30 May 2008 08:54:42 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 945C44569A; Fri, 30 May 2008 08:54:38 +0200 (CEST) Date: Fri, 30 May 2008 08:54:39 +0200 From: Pawel Jakub Dawidek To: Niki Denev Message-ID: <20080530065439.GB3596@garage.freebsd.pl> References: <2e77fc10802120304n32fd1c42m52e6bc617ba07c35@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <2e77fc10802120304n32fd1c42m52e6bc617ba07c35@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS panic when changing zfs dataset mountpoint X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2008 06:54:44 -0000 --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 12, 2008 at 01:04:38PM +0200, Niki Denev wrote: > Hi, >=20 > I got the following panic when trying to set/change the mountpoint > property of a dataset. >=20 > I did : > # zfs set mountpoint=3D/usr/ports zfs2/ports > and the machine crashed. >=20 > The datased had one snapshot taken. >=20 > Here is what i was able to extract from the dump : [...] > #8 0xffffffff804800d5 in _sx_xlock (sx=3D0xa0, opts=3D0, > file=3D0xffffffff80c697f0 > "/usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs/zfs= _ctldir.c", > line=3D1069) at atomic.h:142 > #9 0xffffffff80c50b2a in zfsctl_umount_snapshots (vfsp=3DVariable > "vfsp" is not available. > ) at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs= /zfs_ctldir.c:1069 > #10 0xffffffff80c57978 in zfs_umount (vfsp=3D0xffffff00014f5650, > fflag=3D0, td=3D0xffffff001483b6a0) > at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/z= fs/zfs_vfsops.c:692 [...] I tried to reproduce your problem, but I can't. This is clearly related to unmounting snapshots. Was your snapshot mounted at the time of calling 'zfs set mountpoint=3D'? I tried both scenarious (having mounted and unmounted snapshot) and no panic. Is there anything else you did? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --l76fUT7nc3MelDdI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIP6SuForvXbEpPzQRAl4iAJ9ypW2a5yLlAATkO9iJ/X+mAmNjuwCcCj1Q BWoKpnxopLFFHDAMf92rXEc= =Nhw6 -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--