From owner-freebsd-fs@FreeBSD.ORG Sun Sep 21 10:25:49 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7014A106567A for ; Sun, 21 Sep 2008 10:25:49 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from smtp.ht-systems.ru (mr0.ht-systems.ru [78.110.50.55]) by mx1.freebsd.org (Postfix) with ESMTP id 0EF1D8FC17 for ; Sun, 21 Sep 2008 10:25:48 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from [85.21.245.235] (helo=orion.SpringDaemons.com) by smtp.ht-systems.ru with esmtpa (Exim 4.62) (envelope-from ) id 1KhLsl-0005VV-Fw; Sun, 21 Sep 2008 14:09:35 +0400 Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id DFD9239830; Sun, 21 Sep 2008 14:09:37 +0400 (MSD) Date: Sun, 21 Sep 2008 14:09:32 +0400 From: Stanislav Sedov To: Dmitry Morozovsky Message-Id: <20080921140932.adf51b5e.stas@FreeBSD.org> In-Reply-To: References: Organization: The FreeBSD Project X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.11; amd64-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Sun__21_Sep_2008_14_09_32_+0400_v1Sf4h3MKXbhjnTJ" Cc: freebsd-fs@FreeBSD.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2008 10:25:49 -0000 --Signature=_Sun__21_Sep_2008_14_09_32_+0400_v1Sf4h3MKXbhjnTJ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 17 Sep 2008 00:57:14 +0400 (MSD) Dmitry Morozovsky mentioned: > Dear colleagues, >=20 > is there a way to split existing GPT partition into two, like one can do = in=20 > bsdlabel case? >=20 > I found myself wanting to shrink swap to have an alternate root, but have= no=20 > luck in my experiments. >=20 > For the reference, I have >=20 > da0p1 boot > da0p2 bootdisk > da0p3 swap > da0p4 ZFS >=20 > and want to place two partitions in place of da0p3... >=20 You can simpy remove the da0p3 partition and add two new instead of it. --=20 Stanislav Sedov ST4096-RIPE --Signature=_Sun__21_Sep_2008_14_09_32_+0400_v1Sf4h3MKXbhjnTJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjWHWEACgkQK/VZk+smlYGH9ACdGOnl1QdoTxw7FZodsMl59K+K uxMAniqDpImkZHCFJXUJVUSI/8I2+3/v =VQav -----END PGP SIGNATURE----- --Signature=_Sun__21_Sep_2008_14_09_32_+0400_v1Sf4h3MKXbhjnTJ-- From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 11:06:52 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D378D1065673 for ; Mon, 22 Sep 2008 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C3FFD8FC16 for ; Mon, 22 Sep 2008 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m8MB6q8B015360 for ; Mon, 22 Sep 2008 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m8MB6qY4015355 for freebsd-fs@FreeBSD.org; Mon, 22 Sep 2008 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Sep 2008 11:06:52 GMT Message-Id: <200809221106.m8MB6qY4015355@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-fs@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 11:06:52 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/127420 fs [gjournal] [panic] Journal overflow on gmirrored gjour o kern/127213 fs [tmpfs] sendfile on tmpfs data corruption o kern/127029 fs [panic] mount(8): trying to mount a write protected zi o kern/126287 fs [ufs] [panic] Kernel panics while mounting an UFS file o kern/125536 fs [ext2fs] ext 2 mounts cleanly but fails on commands li o kern/124621 fs [ext3] Cannot mount ext2fs partition o kern/122888 fs [zfs] zfs hang w/ prefetch on, zil off while running t o bin/122172 fs [fs]: amd(8) automount daemon dies on 6.3-STABLE i386, o bin/121072 fs [smbfs] mount_smbfs(8) cannot normally convert the cha o bin/118249 fs mv(1): moving a directory changes its mtime o kern/116170 fs [panic] Kernel panic when mounting /tmp o kern/114955 fs [cd9660] [patch] [request] support for mask,dirmask,ui o kern/114847 fs [ntfs] [patch] [request] dirmask support for NTFS ala o kern/114676 fs [ufs] snapshot creation panics: snapacct_ufs2: bad blo o bin/114468 fs [patch] [request] add -d option to umount(8) to detach o bin/113838 fs [patch] [request] mount(8): add support for relative p o bin/113049 fs [patch] [request] make quot(8) use getopt(3) and show o kern/112658 fs [smbfs] [patch] smbfs and caching problems (resolves b o kern/93942 fs [vfs] [patch] panic: ufs_dirbad: bad dir (patch from D 19 problems total. From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 18:12:56 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E071E1065676; Mon, 22 Sep 2008 18:12:56 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 51D118FC19; Mon, 22 Sep 2008 18:12:56 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.2/8.14.2) with ESMTP id m8MICslf001834; Mon, 22 Sep 2008 22:12:54 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Mon, 22 Sep 2008 22:12:54 +0400 (MSD) From: Dmitry Morozovsky To: Stanislav Sedov In-Reply-To: <20080921140932.adf51b5e.stas@FreeBSD.org> Message-ID: References: <20080921140932.adf51b5e.stas@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (woozle.rinet.ru [0.0.0.0]); Mon, 22 Sep 2008 22:12:54 +0400 (MSD) Cc: freebsd-fs@FreeBSD.org, marcel@FreeBSD.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 18:12:57 -0000 On Sun, 21 Sep 2008, Stanislav Sedov wrote: SS> > is there a way to split existing GPT partition into two, like one can do in SS> > bsdlabel case? SS> > SS> > I found myself wanting to shrink swap to have an alternate root, but have no SS> > luck in my experiments. SS> > SS> > For the reference, I have SS> > SS> > da0p1 boot SS> > da0p2 bootdisk SS> > da0p3 swap SS> > da0p4 ZFS SS> > SS> > and want to place two partitions in place of da0p3... SS> SS> You can simpy remove the da0p3 partition and add two new instead of it. It does not seem gpart wants allow me to delete da0p3 while disk is active... gpt did the trick though, with sysctl kern.geom.debugflags=16 root@beaver:/# gpt remove -i 3 da0 da0p3 removed root@beaver:/# gpt show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 1048576 2 GPT part - FreeBSD UFS/UFS2 1048738 33554432 34603170 4359862077 4 GPT part - FreeBSD ZFS 4394465247 32 Sec GPT table 4394465279 1 Sec GPT header root@beaver:/# gpt add -s 1048576 -t ufs da0 root@beaver:/# gpt show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 1048576 2 GPT part - FreeBSD UFS/UFS2 1048738 1048576 3 GPT part - FreeBSD UFS/UFS2 2097314 32505856 34603170 4359862077 4 GPT part - FreeBSD ZFS 4394465247 32 Sec GPT table 4394465279 1 Sec GPT header root@beaver:/# gpt add -t swap da0 BUT - system missed part 5: root@beaver:/# gpt show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 1048576 2 GPT part - FreeBSD UFS/UFS2 1048738 1048576 3 GPT part - FreeBSD UFS/UFS2 2097314 32505856 5 GPT part - FreeBSD swap 34603170 4359862077 4 GPT part - FreeBSD ZFS 4394465247 32 Sec GPT table 4394465279 1 Sec GPT header root@beaver:/# gpart show => 34 4394465213 da0 GPT (2.2TB) 34 128 1 freebsd-boot (65.5KB) 162 1048576 2 freebsd-ufs (536.9MB) 1048738 33554432 3 freebsd-swap (17.2GB) 34603170 4359862077 4 freebsd-zfs (2.2TB) root@beaver:/# ls /dev/da0* /dev/da0 /dev/da0p1 /dev/da0p2 /dev/da0p3 /dev/da0p4 Marcel, can you please comment too? Thanks. Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 18:17:31 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BB301065671; Mon, 22 Sep 2008 18:17:31 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id EEB518FC1B; Mon, 22 Sep 2008 18:17:30 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.2/8.14.2) with ESMTP id m8MIHTHL001942; Mon, 22 Sep 2008 22:17:29 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Mon, 22 Sep 2008 22:17:29 +0400 (MSD) From: Dmitry Morozovsky To: Stanislav Sedov In-Reply-To: Message-ID: References: <20080921140932.adf51b5e.stas@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (woozle.rinet.ru [0.0.0.0]); Mon, 22 Sep 2008 22:17:29 +0400 (MSD) Cc: freebsd-fs@freebsd.org, marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 18:17:31 -0000 On Mon, 22 Sep 2008, Dmitry Morozovsky wrote: [snip] DM> BUT - DM> DM> system missed part 5: DM> DM> root@beaver:/# gpt show da0 DM> start size index contents DM> 0 1 PMBR DM> 1 1 Pri GPT header DM> 2 32 Pri GPT table DM> 34 128 1 GPT part - FreeBSD boot DM> 162 1048576 2 GPT part - FreeBSD UFS/UFS2 DM> 1048738 1048576 3 GPT part - FreeBSD UFS/UFS2 DM> 2097314 32505856 5 GPT part - FreeBSD swap DM> 34603170 4359862077 4 GPT part - FreeBSD ZFS DM> 4394465247 32 Sec GPT table DM> 4394465279 1 Sec GPT header DM> root@beaver:/# gpart show DM> => 34 4394465213 da0 GPT (2.2TB) DM> 34 128 1 freebsd-boot (65.5KB) DM> 162 1048576 2 freebsd-ufs (536.9MB) DM> 1048738 33554432 3 freebsd-swap (17.2GB) DM> 34603170 4359862077 4 freebsd-zfs (2.2TB) DM> DM> root@beaver:/# ls /dev/da0* DM> /dev/da0 /dev/da0p1 /dev/da0p2 /dev/da0p3 /dev/da0p4 Small followup: Reboot does fix the problem, surely: marck@beaver:~> gpt -r show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 1048576 2 GPT part - FreeBSD UFS/UFS2 1048738 1048576 3 GPT part - FreeBSD UFS/UFS2 2097314 32505856 5 GPT part - FreeBSD swap 34603170 4359862077 4 GPT part - FreeBSD ZFS 4394465247 32 Sec GPT table 4394465279 1 Sec GPT header marck@beaver:~> gpart show => 34 4394465213 da0 GPT (2.2TB) 34 128 1 freebsd-boot (65.5KB) 162 1048576 2 freebsd-ufs (536.9MB) 1048738 1048576 3 freebsd-ufs (536.9MB) 2097314 32505856 5 freebsd-swap (16.6GB) 34603170 4359862077 4 freebsd-zfs (2.2TB) Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 21:23:49 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 660FD106564A; Mon, 22 Sep 2008 21:23:49 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout011.mac.com (asmtpout011.mac.com [17.148.16.86]) by mx1.freebsd.org (Postfix) with ESMTP id 4F03F8FC1B; Mon, 22 Sep 2008 21:23:49 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from taolin-mbp.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp011.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K7M007HD5YTKE50@asmtp011.mac.com>; Mon, 22 Sep 2008 13:23:17 -0700 (PDT) Message-id: <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> From: Marcel Moolenaar To: Dmitry Morozovsky In-reply-to: Date: Mon, 22 Sep 2008 13:23:16 -0700 References: <20080921140932.adf51b5e.stas@FreeBSD.org> X-Mailer: Apple Mail (2.929.2) Cc: Stanislav Sedov , freebsd-fs@FreeBSD.org, marcel@FreeBSD.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 21:23:49 -0000 On Sep 22, 2008, at 11:12 AM, Dmitry Morozovsky wrote: > On Sun, 21 Sep 2008, Stanislav Sedov wrote: > > SS> > is there a way to split existing GPT partition into two, like > one can do in > SS> > bsdlabel case? > SS> > > SS> > I found myself wanting to shrink swap to have an alternate > root, but have no > SS> > luck in my experiments. > SS> > > SS> > For the reference, I have > SS> > > SS> > da0p1 boot > SS> > da0p2 bootdisk > SS> > da0p3 swap > SS> > da0p4 ZFS > SS> > > SS> > and want to place two partitions in place of da0p3... > SS> > SS> You can simpy remove the da0p3 partition and add two new instead > of it. > > It does not seem gpart wants allow me to delete da0p3 while disk is > active... You probably have swapon and/or dumpon to set to the partition. You can't remove a partition that is in use. Run "swapoff /dev/da0p3" and/or "dumpon off" first. FYI, -- Marcel Moolenaar xcllnt@mac.com From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 21:34:59 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B0961065672; Mon, 22 Sep 2008 21:34:59 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 079488FC14; Mon, 22 Sep 2008 21:34:58 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.2/8.14.2) with ESMTP id m8MLYush005890; Tue, 23 Sep 2008 01:34:56 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Tue, 23 Sep 2008 01:34:56 +0400 (MSD) From: Dmitry Morozovsky To: Marcel Moolenaar In-Reply-To: <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> Message-ID: References: <20080921140932.adf51b5e.stas@FreeBSD.org> <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (woozle.rinet.ru [0.0.0.0]); Tue, 23 Sep 2008 01:34:56 +0400 (MSD) Cc: freebsd-fs@freebsd.org, marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 21:34:59 -0000 On Mon, 22 Sep 2008, Marcel Moolenaar wrote: MM> > SS> > is there a way to split existing GPT partition into two, like one MM> > can do in MM> > SS> > bsdlabel case? MM> > SS> > MM> > SS> > I found myself wanting to shrink swap to have an alternate root, but MM> > have no MM> > SS> > luck in my experiments. MM> > SS> > MM> > SS> > For the reference, I have MM> > SS> > MM> > SS> > da0p1 boot MM> > SS> > da0p2 bootdisk MM> > SS> > da0p3 swap MM> > SS> > da0p4 ZFS MM> > SS> > MM> > SS> > and want to place two partitions in place of da0p3... MM> > SS> MM> > SS> You can simpy remove the da0p3 partition and add two new instead of MM> > it. MM> > MM> > It does not seem gpart wants allow me to delete da0p3 while disk is MM> > active... MM> MM> You probably have swapon and/or dumpon to set to the partition. MM> You can't remove a partition that is in use. MM> MM> Run "swapoff /dev/da0p3" and/or "dumpon off" first. Of course I did run swapoff; I'm not sure I did dumpoff, and unfortunately I did not run it under script(1). gpt (I did test under RELENG_7) does the trick, but -- However, we clearly have at least one bug: not creating da* device (for da0p5 in my case) Thanks. Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 21:49:41 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 586161065677; Mon, 22 Sep 2008 21:49:41 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from smtp.ht-systems.ru (mr0.ht-systems.ru [78.110.50.55]) by mx1.freebsd.org (Postfix) with ESMTP id 048808FC18; Mon, 22 Sep 2008 21:49:33 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from [85.21.245.235] (helo=orion.SpringDaemons.com) by smtp.ht-systems.ru with esmtpa (Exim 4.62) (envelope-from ) id 1KhtHe-0001Ke-8R; Tue, 23 Sep 2008 01:49:30 +0400 Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id A99C339830; Tue, 23 Sep 2008 01:49:36 +0400 (MSD) Date: Tue, 23 Sep 2008 01:49:27 +0400 From: Stanislav Sedov To: Dmitry Morozovsky Message-Id: <20080923014927.b9e9dc37.stas@FreeBSD.org> In-Reply-To: References: <20080921140932.adf51b5e.stas@FreeBSD.org> <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> Organization: The FreeBSD Project X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.11; amd64-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__23_Sep_2008_01_49_27_+0400_T9_oc22+2nCqxBAd" Cc: freebsd-fs@freebsd.org, Marcel Moolenaar , marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 21:49:41 -0000 --Signature=_Tue__23_Sep_2008_01_49_27_+0400_T9_oc22+2nCqxBAd Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 23 Sep 2008 01:34:56 +0400 (MSD) Dmitry Morozovsky mentioned: >=20 > However, we clearly have at least one bug: not creating da* device (for d= a0p5=20 > in my case) >=20 I believe that's why it was replaced by gpart, which does all required geom tricks right. --=20 Stanislav Sedov ST4096-RIPE --Signature=_Tue__23_Sep_2008_01_49_27_+0400_T9_oc22+2nCqxBAd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjYEvAACgkQK/VZk+smlYFYvQCdHJsNPZ/nONBsnLzY741SJUL7 eAUAnimscN1qSbmiZmEiUULXWcMyyz7n =AEik -----END PGP SIGNATURE----- --Signature=_Tue__23_Sep_2008_01_49_27_+0400_T9_oc22+2nCqxBAd-- From owner-freebsd-fs@FreeBSD.ORG Mon Sep 22 22:04:46 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F4CD1065769; Mon, 22 Sep 2008 22:04:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout020.mac.com (asmtpout020.mac.com [17.148.16.95]) by mx1.freebsd.org (Postfix) with ESMTP id 32F1E8FC14; Mon, 22 Sep 2008 22:04:46 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from taolin-mbp.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp020.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K7M00BC1ANW4J20@asmtp020.mac.com>; Mon, 22 Sep 2008 15:04:46 -0700 (PDT) Message-id: <10218E29-D89D-40BB-BACF-9DFB131974E7@mac.com> From: Marcel Moolenaar To: Dmitry Morozovsky In-reply-to: Date: Mon, 22 Sep 2008 15:04:44 -0700 References: <20080921140932.adf51b5e.stas@FreeBSD.org> <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> X-Mailer: Apple Mail (2.929.2) Cc: freebsd-fs@freebsd.org, marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 22:04:46 -0000 On Sep 22, 2008, at 2:34 PM, Dmitry Morozovsky wrote: > MM> > It does not seem gpart wants allow me to delete da0p3 while > disk is > MM> > active... > MM> > MM> You probably have swapon and/or dumpon to set to the partition. > MM> You can't remove a partition that is in use. > MM> > MM> Run "swapoff /dev/da0p3" and/or "dumpon off" first. > > Of course I did run swapoff; I'm not sure I did dumpoff, and > unfortunately I > did not run it under script(1). gpt (I did test under RELENG_7) does > the trick, > but -- > > However, we clearly have at least one bug: not creating da* device > (for da0p5 > in my case) You can't make that claim. You've forced the issue by setting debugflags and bypassing gpart. As such, gpart is unaware of the new partition (it wasn't involved in the creation) and it isn't being made aware, because the underlying geom isn't spoiled (which would trigger a retaste). -- Marcel Moolenaar xcllnt@mac.com From owner-freebsd-fs@FreeBSD.ORG Tue Sep 23 09:40:05 2008 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2450D1065674 for ; Tue, 23 Sep 2008 09:40:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 147E58FC29 for ; Tue, 23 Sep 2008 09:40:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m8N9e4hR012878 for ; Tue, 23 Sep 2008 09:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m8N9e4P2012877; Tue, 23 Sep 2008 09:40:04 GMT (envelope-from gnats) Date: Tue, 23 Sep 2008 09:40:04 GMT Message-Id: <200809230940.m8N9e4P2012877@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Ruben van Staveren Cc: Subject: Re: kern/127420: [gjournal] [panic] Journal overflow on gmirrored gjournal X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ruben van Staveren List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2008 09:40:05 -0000 The following reply was made to PR kern/127420; it has been noted by GNATS. From: Ruben van Staveren To: bug-followup@FreeBSD.org, ruben@verweg.com Cc: Subject: Re: kern/127420: [gjournal] [panic] Journal overflow on gmirrored gjournal Date: Tue, 23 Sep 2008 11:29:59 +0200 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-41--958136030 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Hi, I managed to trigger a new panic, still not able to get a proper dump but this is a capture from the serial console. I was running a couple of bonnie++'s before to "exercise" the system. At the time of the panic one bonnie and one nanobsd build was running. I had enabled geom mirror and journal debug sysctl's Some minutes before the actual panic there was a complaint made by fsync, and gjournal not being able to suspend a filesystem. http://ruben.is.verweg.com/stuff/gjournal-panic/gjournal-textdump-text-only.txt Regards, Ruben --Apple-Mail-41--958136030 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) iD8DBQFI2LcXZ88+mcQxRw0RAkkyAJ9VD9cCfWfPusPWCM8sawG/WnVtHQCfXOV8 5Ipf+qF7c1I4JgOPRCHp8rs= =Mm/k -----END PGP SIGNATURE----- --Apple-Mail-41--958136030-- From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 13:51:04 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BF241065676 for ; Wed, 24 Sep 2008 13:51:04 +0000 (UTC) (envelope-from dreamer.two@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.29]) by mx1.freebsd.org (Postfix) with ESMTP id 9CBE38FC0A for ; Wed, 24 Sep 2008 13:51:03 +0000 (UTC) (envelope-from dreamer.two@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so423629ywe.13 for ; Wed, 24 Sep 2008 06:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=2gvh02G775Xnx+xA9UWFDz27tHFNK+eHfDi/ba+53zA=; b=tJW/0GDcZSkgL9nh93906KzyzfVBrDVBXU+2jv/lHEwgr85i3EYZKtNRrnAwkiSwmd sYEqPd5WiVmWhFkWp69q/xt2Nhk5K5By5+v6Rqlc09IouJTA3akX35Bo0KSYuMu/g9Gs /lGZU1TBbJYLaKnlDLjaYkpTBI13ZCCBbA0k0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=n0o/FGfZ6MgFjnTYwM8geN1pgNDjHiZMV6CL/DlEygAINLOJL1Iozs940aibWuJh6v ZLQSFfXHYhYOHhHFePvxrnIxwS+zuUu/7Q22L30Go2L8TlNyChvYn7SmKGfTWy6tDM3Q EMB/xblEBUuuw2c9ug4pUjz76l2dCOQ9BB0jY= Received: by 10.150.206.11 with SMTP id d11mr5087155ybg.143.1222263027593; Wed, 24 Sep 2008 06:30:27 -0700 (PDT) Received: by 10.150.97.21 with HTTP; Wed, 24 Sep 2008 06:30:27 -0700 (PDT) Message-ID: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> Date: Wed, 24 Sep 2008 17:30:27 +0400 From: "Vitaly Dodonov" To: freebsd-fs@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: zfs and gpt partition X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 13:51:04 -0000 I have problem with zfs on gpt partition in RELENG_7 when zfs use whole drive or classic slices, all work well in any ata port, but changing device name with created on it gpt -t zfs partition broke zfs volume state - FAULTED ad8 UNAVAIL 0 0 0 corrupted data restore possible only with returning drive to it original port, where volume was created From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 14:39:13 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FC231065686 for ; Wed, 24 Sep 2008 14:39:13 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id 6743C8FC22 for ; Wed, 24 Sep 2008 14:39:13 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id 14BF471EE9F; Wed, 24 Sep 2008 10:20:33 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kMwfGYi3vlBO; Wed, 24 Sep 2008 10:20:32 -0400 (EDT) Received: from [35.9.44.65] (daemon.egr.msu.edu [35.9.44.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mcdouga9) by mx.egr.msu.edu (Postfix) with ESMTPSA id E771071EE98; Wed, 24 Sep 2008 10:20:32 -0400 (EDT) Message-ID: <48DA4CB0.4020401@egr.msu.edu> Date: Wed, 24 Sep 2008 10:20:32 -0400 From: Adam McDougall User-Agent: Thunderbird 2.0.0.16 (X11/20080727) MIME-Version: 1.0 To: Vitaly Dodonov References: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> In-Reply-To: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: zfs and gpt partition X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 14:39:13 -0000 Vitaly Dodonov wrote: > I have problem with zfs on gpt partition in RELENG_7 > > when zfs use whole drive or classic slices, all work well in any ata port, > but changing device name with created on it gpt -t zfs partition broke zfs > volume > state - FAULTED > ad8 UNAVAIL 0 0 0 corrupted data > > restore possible only with returning drive to it original port, where volume > was created > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > Please try looking at 'zpool export' and 'zpool import', it will probably correct the error if you export then import the pool. From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 15:08:15 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EFE01065672 for ; Wed, 24 Sep 2008 15:08:15 +0000 (UTC) (envelope-from dreamer.two@gmail.com) Received: from mail-gx0-f17.google.com (mail-gx0-f17.google.com [209.85.217.17]) by mx1.freebsd.org (Postfix) with ESMTP id 2305D8FC24 for ; Wed, 24 Sep 2008 15:08:15 +0000 (UTC) (envelope-from dreamer.two@gmail.com) Received: by gxk10 with SMTP id 10so5687461gxk.19 for ; Wed, 24 Sep 2008 08:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=Y4waoD7tXII0RtsKwV3Gq8sksapiW/X5X/3v+g07faE=; b=ZEvWHOadPN5ogQq/e9bFOq0/rzBPulMOsfogZAT3LXZxyqTjU+Husjz8zhdtGYSFti 3n+jByrFcsseF50Ie4QJNxK01nsXAOF1ZMj0jGLmMnw+Fn7mI9zjfqYOMCe807PzchjB CRV/YS33h1YBL6TNDS0ehmLsZWu6tS5uB7LfQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=dlmRwAvkeuiyxbZPaYbi1zSszvjQYEuUuITy/jFEgW4sUoqQEiIP78u2Ed/9m9t0mU 9KFG5plb5LtVzTQ9xTEXFJmI3c3PE22PkFY4tn9okvSC7SftKBwIu6cfDJbHG/eJIoVH GNjrw3sKVK2pzGBBMYvkD33DPQFrzL854F/R0= Received: by 10.150.203.8 with SMTP id a8mr11220396ybg.13.1222268892578; Wed, 24 Sep 2008 08:08:12 -0700 (PDT) Received: by 10.150.97.21 with HTTP; Wed, 24 Sep 2008 08:08:12 -0700 (PDT) Message-ID: <911337bf0809240808p69197a62qc5865634bc1a27dd@mail.gmail.com> Date: Wed, 24 Sep 2008 19:08:12 +0400 From: "Vitaly Dodonov" To: "Adam McDougall" , freebsd-fs@freebsd.org In-Reply-To: <48DA4CB0.4020401@egr.msu.edu> MIME-Version: 1.0 References: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> <48DA4CB0.4020401@egr.msu.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: zfs and gpt partition X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 15:08:15 -0000 On Wed, Sep 24, 2008 at 6:20 PM, Adam McDougall wrote: > Vitaly Dodonov wrote: > >> I have problem with zfs on gpt partition in RELENG_7 >> >> when zfs use whole drive or classic slices, all work well in any ata port, >> but changing device name with created on it gpt -t zfs partition broke zfs >> volume >> state - FAULTED >> ad8 UNAVAIL 0 0 0 corrupted data >> >> restore possible only with returning drive to it original port, where >> volume >> was created >> >> >> > Please try looking at 'zpool export' and 'zpool import', it will probably > correct the error if you export then import the pool. > yes, export/import working, but without gpt i don't need these operations, drives don't drop from pool on device name change From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 19:25:23 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE9A71065676; Wed, 24 Sep 2008 19:25:23 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 32FDC8FC0C; Wed, 24 Sep 2008 19:25:22 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.2/8.14.2) with ESMTP id m8OJPL0N009017; Wed, 24 Sep 2008 23:25:21 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Wed, 24 Sep 2008 23:25:21 +0400 (MSD) From: Dmitry Morozovsky To: Marcel Moolenaar In-Reply-To: <10218E29-D89D-40BB-BACF-9DFB131974E7@mac.com> Message-ID: References: <20080921140932.adf51b5e.stas@FreeBSD.org> <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> <10218E29-D89D-40BB-BACF-9DFB131974E7@mac.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (woozle.rinet.ru [0.0.0.0]); Wed, 24 Sep 2008 23:25:21 +0400 (MSD) Cc: freebsd-fs@freebsd.org, marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 19:25:25 -0000 On Mon, 22 Sep 2008, Marcel Moolenaar wrote: MM> > MM> > It does not seem gpart wants allow me to delete da0p3 while disk is MM> > MM> > active... MM> > MM> MM> > MM> You probably have swapon and/or dumpon to set to the partition. MM> > MM> You can't remove a partition that is in use. MM> > MM> MM> > MM> Run "swapoff /dev/da0p3" and/or "dumpon off" first. MM> > MM> > Of course I did run swapoff; I'm not sure I did dumpoff, and unfortunately MM> > I MM> > did not run it under script(1). gpt (I did test under RELENG_7) does the MM> > trick, MM> > but -- MM> > MM> > However, we clearly have at least one bug: not creating da* device (for MM> > da0p5 MM> > in my case) MM> MM> You can't make that claim. You've forced the issue MM> by setting debugflags and bypassing gpart. As such, MM> gpart is unaware of the new partition (it wasn't MM> involved in the creation) and it isn't being made MM> aware, because the underlying geom isn't spoiled MM> (which would trigger a retaste). I made a retest tonight, and found that gpart is actually doing things quite right (my fault in previous experiment seems to be that I did not check for filt system types, and gpart does not understand short types like 'ufs'). Also, gpart does not allow default values in add phase, which is a bit annoying, especially when you create last partition; but we can live with this I hope ;) Thank you. Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 19:38:52 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCE7E1065672; Wed, 24 Sep 2008 19:38:52 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout022.mac.com (asmtpout022.mac.com [17.148.16.97]) by mx1.freebsd.org (Postfix) with ESMTP id B1D698FC17; Wed, 24 Sep 2008 19:38:52 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from krussell-lt1.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp022.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K7P00B1ST8R8510@asmtp022.mac.com>; Wed, 24 Sep 2008 12:38:52 -0700 (PDT) Message-id: <8BB33576-5388-457A-9E5C-83442145EF7C@mac.com> From: Marcel Moolenaar To: Dmitry Morozovsky In-reply-to: Date: Wed, 24 Sep 2008 12:38:50 -0700 References: <20080921140932.adf51b5e.stas@FreeBSD.org> <10719B6B-1F3B-44C6-BAC0-D8C3F42F7F3F@mac.com> <10218E29-D89D-40BB-BACF-9DFB131974E7@mac.com> X-Mailer: Apple Mail (2.929.2) Cc: freebsd-fs@freebsd.org, marcel@freebsd.org Subject: Re: gpt in-place editing X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 19:38:52 -0000 On Sep 24, 2008, at 12:25 PM, Dmitry Morozovsky wrote: > I made a retest tonight, and found that gpart is actually doing > things quite > right (my fault in previous experiment seems to be that I did not > check for > filt system types, and gpart does not understand short types like > 'ufs'). gpart uses "freebsd-ufs" instead of "ufs", because there are incompatible UFS implementations. In particular, if you create a UFS file system on Mac OS X, FreeBSD will panic when you try to mount it. As such, I found it prudent to have more precise partition types so that you can have a "freebsd-ufs" partition alongside a "macosx-ufs" partition (the latter I just pulled out of the hat -- we don't actually support that type). > Also, gpart does not allow default values in add phase, which is a bit > annoying, especially when you create last partition; but we can live > with this > I hope ;) True. This is just a matter of enhancing the UI though and should not be difficult to do... FYI, -- Marcel Moolenaar xcllnt@mac.com From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 19:38:57 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4C16106566B for ; Wed, 24 Sep 2008 19:38:57 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [91.103.162.4]) by mx1.freebsd.org (Postfix) with ESMTP id 72EFF8FC14 for ; Wed, 24 Sep 2008 19:38:57 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from localhost (localhost.codelab.cz [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id EE22F19E02A; Wed, 24 Sep 2008 21:27:11 +0200 (CEST) Received: from [192.168.1.2] (r5bb235.net.upc.cz [86.49.61.235]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 30C6F19E027; Wed, 24 Sep 2008 21:27:09 +0200 (CEST) Message-ID: <48DA94AE.3070700@quip.cz> Date: Wed, 24 Sep 2008 21:27:42 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.12) Gecko/20050915 X-Accept-Language: cz, cs, en, en-us MIME-Version: 1.0 To: Vitaly Dodonov References: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> <48DA4CB0.4020401@egr.msu.edu> <911337bf0809240808p69197a62qc5865634bc1a27dd@mail.gmail.com> In-Reply-To: <911337bf0809240808p69197a62qc5865634bc1a27dd@mail.gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: zfs and gpt partition X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 19:38:57 -0000 Vitaly Dodonov wrote: > On Wed, Sep 24, 2008 at 6:20 PM, Adam McDougall wrote: > > >>Vitaly Dodonov wrote: >> >> >>> I have problem with zfs on gpt partition in RELENG_7 >>> >>>when zfs use whole drive or classic slices, all work well in any ata port, >>>but changing device name with created on it gpt -t zfs partition broke zfs >>>volume >>>state - FAULTED >>> ad8 UNAVAIL 0 0 0 corrupted data >>> >>>restore possible only with returning drive to it original port, where >>>volume >>>was created >>> >>> >>> >> >>Please try looking at 'zpool export' and 'zpool import', it will probably >>correct the error if you export then import the pool. >> > > > yes, export/import working, but without gpt i don't need these operations, > drives don't drop from pool on device name change glabel is next thing you can try - give a label to the device and create zpool on top of labels, not on adX etc. (I didn't try it, do it on your own risk) ;) Miroslav Lachman From owner-freebsd-fs@FreeBSD.ORG Wed Sep 24 21:50:36 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6BEA1065696 for ; Wed, 24 Sep 2008 21:50:36 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: from hyperion.scode.org (cl-1361.ams-04.nl.sixxs.net [IPv6:2001:960:2:550::2]) by mx1.freebsd.org (Postfix) with ESMTP id A3C438FC1A for ; Wed, 24 Sep 2008 21:50:36 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: by hyperion.scode.org (Postfix, from userid 1001) id 2D06523C4D4; Wed, 24 Sep 2008 23:50:34 +0200 (CEST) Date: Wed, 24 Sep 2008 23:50:34 +0200 From: Peter Schuller To: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <20080924215033.GA35628@hyperion.scode.org> References: <911337bf0809240630s1b8a3f15y3c224bd82c59306b@mail.gmail.com> <48DA4CB0.4020401@egr.msu.edu> <911337bf0809240808p69197a62qc5865634bc1a27dd@mail.gmail.com> <48DA94AE.3070700@quip.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <48DA94AE.3070700@quip.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-fs@freebsd.org Subject: Re: zfs and gpt partition X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 21:50:37 -0000 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > glabel is next thing you can try - give a label to the device and create= =20 > zpool on top of labels, not on adX etc. (I didn't try it, do it on your= =20 > own risk) ;) Not that I see a reason to believe it would be a problem to begin with, but FWIW I never do anything but use glabel for the constituent drives. IMO, when in doubt, glabel (with ZFS or otherwise). It almost never hurts, but can often help in unexpected situations. --=20 / Peter Schuller PGP userID: 0xE9758B7D or 'Peter Schuller ' Key retrieval: Send an E-Mail to getpgpkey@scode.org E-Mail: peter.schuller@infidyne.com Web: http://www.scode.org --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEUEARECAAYFAkjatikACgkQDNor2+l1i32TQgCXRt8tcuYbnvO168uztXdmETcK kACfdsT/fTC/cqRzvwJ/SxBnlF/J580= =SU4l -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt-- From owner-freebsd-fs@FreeBSD.ORG Fri Sep 26 11:45:08 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F5B11065678 for ; Fri, 26 Sep 2008 11:45:08 +0000 (UTC) (envelope-from david.cecil@nokia.com) Received: from mgw-fb01.nokia.com (mgw-fb01.nokia.com [192.100.122.235]) by mx1.freebsd.org (Postfix) with ESMTP id 9C0C28FC1A for ; Fri, 26 Sep 2008 11:45:07 +0000 (UTC) (envelope-from david.cecil@nokia.com) Received: from mgw-mx09.nokia.com ([192.100.105.134]) by mgw-fb01.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id m8QBLA9B022384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Sep 2008 14:21:12 +0300 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx09.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id m8QBKnL5013968 for ; Fri, 26 Sep 2008 06:21:08 -0500 Received: from vaebh102.NOE.Nokia.com ([10.160.244.23]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 14:20:38 +0300 Received: from siebe101.NOE.Nokia.com ([172.30.195.47]) by vaebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 14:20:37 +0300 Received: from [172.30.67.195] ([172.30.67.195]) by siebe101.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 19:20:34 +0800 Message-ID: <48DCC581.80009@nokia.com> Date: Fri, 26 Sep 2008 21:20:33 +1000 From: David Cecil User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: freebsd-fs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Sep 2008 11:20:34.0655 (UTC) FILETIME=[E4EF5EF0:01C91FC9] X-Nokia-AV: Clean Subject: panic in closef X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2008 11:45:08 -0000 Hi, I'm debugging a panic with the call trace below. This is from a 6.1-based kernel, but as far as I can tell there are no fixes for this problem in current, based on where I think the problem lies. It falls over in the call to VFS_LOCK_GIANT in closef, trying to dereference a NULL mount point. To me, the check in VFS_NEEDSGIANT looks flawed; it checks that MP isn't NULL, then dereferences it, but I'd expect the vnode interlock to be held (or similar), but it isn't based on what I see of the code. I looks to me like vgonel was probably running around the same time. It calls delmntque and NULLs v_mount. I can't see how these two threads are synchronised to prevent the race condition I describe, but maybe I'm missing something. Any ideas? Thanks, Dave Unread portion of the kernel message buffer: 2 panic: page fault cpuid = 0 KDB: stack backtrace: db_trace_self_wrapper(60794d20) at db_trace_self_wrapper+0x25 kdb_backtrace(f8d0eae8,100,67aeb640,28,f8d0eb64,...) at kdb_backtrace+0x29 panic(60774fbe,607bae69,0,fffff,681dc89b,...) at panic+0x230 trap_fatal(f8d0eb64,6f,67aeb640,0,c,...) at trap_fatal+0x2ce trap_pfault(f8d0eb64,0,6f) at trap_pfault+0x1ef trap(7ae70008,28,f8d00028,3,8236e104,...) at trap+0x36d calltrap() at calltrap+0x5 --- trap 0xc, eip = 0x60565e72, esp = 0xf8d0eba4, ebp = 0xf8d0ec00 --- closef(7d7f19cc,67aeb640) at closef+0x36 fdfree(67aeb640) at fdfree+0x5a7 exit1(67aeb640,100,f8d0ed30,6074c903,67aeb640,...) at exit1+0x4ee exit1(67aeb640,f8d0ed04) at exit1 syscall(5fbf003b,812003b,5fbf003b,0,0,...) at syscall+0x2b7 Xint0x80_syscall() at Xint0x80_syscall+0x1f From owner-freebsd-fs@FreeBSD.ORG Fri Sep 26 11:56:43 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 849301065686 for ; Fri, 26 Sep 2008 11:56:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 275C58FC0A for ; Fri, 26 Sep 2008 11:56:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtp (Exim 4.63 (FreeBSD)) (envelope-from ) id 1KjBw8-000Ip4-Bl; Fri, 26 Sep 2008 14:56:41 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m8QBuWiP052242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Sep 2008 14:56:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m8QBuWSF089377; Fri, 26 Sep 2008 14:56:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id m8QBuWVb089376; Fri, 26 Sep 2008 14:56:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 26 Sep 2008 14:56:31 +0300 From: Kostik Belousov To: David Cecil Message-ID: <20080926115631.GT47828@deviant.kiev.zoral.com.ua> References: <48DCC581.80009@nokia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z9LUXdM02iSxOrxu" Content-Disposition: inline In-Reply-To: <48DCC581.80009@nokia.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1KjBw8-000Ip4-Bl 7b054420a68c329cd6a2237d06c2f28a X-Terabit: YES Cc: freebsd-fs@freebsd.org Subject: Re: panic in closef X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2008 11:56:43 -0000 --z9LUXdM02iSxOrxu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 26, 2008 at 09:20:33PM +1000, David Cecil wrote: > Hi, >=20 > I'm debugging a panic with the call trace below. This is from a=20 > 6.1-based kernel, but as far as I can tell there are no fixes for this=20 > problem in current, based on where I think the problem lies. No, it should be fixed. See r168020 | kib | 2007-03-29 11:21:09 +0300 (Thu, 29 Mar 2007) | 7 lines Extend rev. 1.210 to avoid dereference NULL mp in VFS_NEEDSGIANT and VFS_ASSERT_GIANT. Stop using reserved namespace. and r158320 | tegge | 2006-05-05 22:32:35 +0300 (Fri, 05 May 2006) | 2 lines Avoid dereferencing NULL pointer. >=20 > It falls over in the call to VFS_LOCK_GIANT in closef, trying to=20 > dereference a NULL mount point. To me, the check in VFS_NEEDSGIANT=20 > looks flawed; it checks that MP isn't NULL, then dereferences it, but=20 > I'd expect the vnode interlock to be held (or similar), but it isn't=20 > based on what I see of the code. >=20 > I looks to me like vgonel was probably running around the same time. It= =20 > calls delmntque and NULLs v_mount. I can't see how these two threads=20 > are synchronised to prevent the race condition I describe, but maybe I'm= =20 > missing something. >=20 > Any ideas? >=20 > Thanks, > Dave >=20 > Unread portion of the kernel message buffer: > 2 > panic: page fault > cpuid =3D 0 > KDB: stack backtrace: > db_trace_self_wrapper(60794d20) at db_trace_self_wrapper+0x25 > kdb_backtrace(f8d0eae8,100,67aeb640,28,f8d0eb64,...) at kdb_backtrace+0x29 > panic(60774fbe,607bae69,0,fffff,681dc89b,...) at panic+0x230 > trap_fatal(f8d0eb64,6f,67aeb640,0,c,...) at trap_fatal+0x2ce > trap_pfault(f8d0eb64,0,6f) at trap_pfault+0x1ef > trap(7ae70008,28,f8d00028,3,8236e104,...) at trap+0x36d > calltrap() at calltrap+0x5 > --- trap 0xc, eip =3D 0x60565e72, esp =3D 0xf8d0eba4, ebp =3D 0xf8d0ec00 = --- > closef(7d7f19cc,67aeb640) at closef+0x36 > fdfree(67aeb640) at fdfree+0x5a7 > exit1(67aeb640,100,f8d0ed30,6074c903,67aeb640,...) at exit1+0x4ee > exit1(67aeb640,f8d0ed04) at exit1 > syscall(5fbf003b,812003b,5fbf003b,0,0,...) at syscall+0x2b7 > Xint0x80_syscall() at Xint0x80_syscall+0x1f >=20 >=20 > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" --z9LUXdM02iSxOrxu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkjcze4ACgkQC3+MBN1Mb4jiKwCfa3gSRFZ+0+58t9hyzq7lGVSE v9cAn3Bk0jAXDFbndo8ZtEfZaYJL4trg =A4zl -----END PGP SIGNATURE----- --z9LUXdM02iSxOrxu-- From owner-freebsd-fs@FreeBSD.ORG Fri Sep 26 12:48:14 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E0731065686 for ; Fri, 26 Sep 2008 12:48:14 +0000 (UTC) (envelope-from david.cecil@nokia.com) Received: from mgw-mx09.nokia.com (smtp.nokia.com [192.100.105.134]) by mx1.freebsd.org (Postfix) with ESMTP id 07FFB8FC1A for ; Fri, 26 Sep 2008 12:48:13 +0000 (UTC) (envelope-from david.cecil@nokia.com) Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx09.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id m8QCm8u7029898; Fri, 26 Sep 2008 07:48:12 -0500 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 15:48:08 +0300 Received: from siebe101.NOE.Nokia.com ([172.30.195.47]) by esebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 15:48:07 +0300 Received: from [172.30.67.195] ([172.30.67.195]) by siebe101.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 26 Sep 2008 20:48:04 +0800 Message-ID: <48DCDA03.60702@nokia.com> Date: Fri, 26 Sep 2008 22:48:03 +1000 From: David Cecil User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: ext Kostik Belousov References: <48DCC581.80009@nokia.com> <20080926115631.GT47828@deviant.kiev.zoral.com.ua> In-Reply-To: <20080926115631.GT47828@deviant.kiev.zoral.com.ua> X-OriginalArrivalTime: 26 Sep 2008 12:48:05.0113 (UTC) FILETIME=[1E73AE90:01C91FD6] X-Nokia-AV: Clean Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-fs@freebsd.org Subject: Re: panic in closef X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2008 12:48:14 -0000 Ah yes, thanks Kostik I looked at that change, it didn't immediately click. After you mentioned it the local variable made sense. Thanks for pointing it out. Dave ext Kostik Belousov wrote: > On Fri, Sep 26, 2008 at 09:20:33PM +1000, David Cecil wrote: > >> Hi, >> >> I'm debugging a panic with the call trace below. This is from a >> 6.1-based kernel, but as far as I can tell there are no fixes for this >> problem in current, based on where I think the problem lies. >> > No, it should be fixed. See > > r168020 | kib | 2007-03-29 11:21:09 +0300 (Thu, 29 Mar 2007) | 7 lines > Extend rev. 1.210 to avoid dereference NULL mp in VFS_NEEDSGIANT and > VFS_ASSERT_GIANT. Stop using reserved namespace. > > and > > r158320 | tegge | 2006-05-05 22:32:35 +0300 (Fri, 05 May 2006) | 2 lines > Avoid dereferencing NULL pointer. > > >> It falls over in the call to VFS_LOCK_GIANT in closef, trying to >> dereference a NULL mount point. To me, the check in VFS_NEEDSGIANT >> looks flawed; it checks that MP isn't NULL, then dereferences it, but >> I'd expect the vnode interlock to be held (or similar), but it isn't >> based on what I see of the code. >> >> I looks to me like vgonel was probably running around the same time. It >> calls delmntque and NULLs v_mount. I can't see how these two threads >> are synchronised to prevent the race condition I describe, but maybe I'm >> missing something. >> >> Any ideas? >> >> Thanks, >> Dave >> >> Unread portion of the kernel message buffer: >> 2 >> panic: page fault >> cpuid = 0 >> KDB: stack backtrace: >> db_trace_self_wrapper(60794d20) at db_trace_self_wrapper+0x25 >> kdb_backtrace(f8d0eae8,100,67aeb640,28,f8d0eb64,...) at kdb_backtrace+0x29 >> panic(60774fbe,607bae69,0,fffff,681dc89b,...) at panic+0x230 >> trap_fatal(f8d0eb64,6f,67aeb640,0,c,...) at trap_fatal+0x2ce >> trap_pfault(f8d0eb64,0,6f) at trap_pfault+0x1ef >> trap(7ae70008,28,f8d00028,3,8236e104,...) at trap+0x36d >> calltrap() at calltrap+0x5 >> --- trap 0xc, eip = 0x60565e72, esp = 0xf8d0eba4, ebp = 0xf8d0ec00 --- >> closef(7d7f19cc,67aeb640) at closef+0x36 >> fdfree(67aeb640) at fdfree+0x5a7 >> exit1(67aeb640,100,f8d0ed30,6074c903,67aeb640,...) at exit1+0x4ee >> exit1(67aeb640,f8d0ed04) at exit1 >> syscall(5fbf003b,812003b,5fbf003b,0,0,...) at syscall+0x2b7 >> Xint0x80_syscall() at Xint0x80_syscall+0x1f >> >> >> _______________________________________________ >> freebsd-fs@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-fs >> To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >>