From owner-freebsd-acpi@FreeBSD.ORG Sun Oct 11 14:23:00 2009 Return-Path: Delivered-To: acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73DE5106566B; Sun, 11 Oct 2009 14:23:00 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2]) by mx1.freebsd.org (Postfix) with ESMTP id 072E78FC1D; Sun, 11 Oct 2009 14:22:59 +0000 (UTC) Received: from roadrunner.spoerlein.net (e180138115.adsl.alicedsl.de [85.180.138.115]) by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9BEMvhY046166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 Oct 2009 16:22:58 +0200 (CEST) (envelope-from uqs@spoerlein.net) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9BEMuX0003809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Oct 2009 16:22:56 +0200 (CEST) (envelope-from uqs@spoerlein.net) Received: (from uqs@localhost) by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9BEMuXn003808; Sun, 11 Oct 2009 16:22:56 +0200 (CEST) (envelope-from uqs@spoerlein.net) Date: Sun, 11 Oct 2009 16:22:56 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: current@freebsd.org Message-ID: <20091011142256.GA3770@roadrunner.spoerlein.net> Mail-Followup-To: current@freebsd.org, acpi@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Cc: acpi@freebsd.org Subject: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Oct 2009 14:23:00 -0000 Just FYI, Dell Inspiron 8600c laptop, semi-recent CURRENT, latest BIOS (A14), machine is 5 years old and producing these warnings when inserting a battery (or booting with one inserted) ACPI Warning for \\_SB_.BAT0._BIF: Converted Buffer to expected String at index 9 (20090903/nsrepair-215) ACPI Warning for \\_SB_.BAT0._BIF: Converted Buffer to expected String at index 10 (20090903/nsrepair-215) ACPI Warning for \\_SB_.BAT0._BIF: Converted Buffer to expected String at index 11 (20090903/nsrepair-215) ACPI Warning for \\_SB_.BAT0._BIF: Converted Buffer to expected String at index 12 (20090903/nsrepair-215) Everything works just before the ACPI import, there's also another bunch of (harmless) errors during boot. acpi0: on motherboard acpi0: [ITHREAD] acpi0: reservation of 0, 9fc00 (3) failed acpi0: reservation of 100000, 3fef0000 (3) failed This is just for reference, perhaps someone wants to know. Cheers, Uli From owner-freebsd-acpi@FreeBSD.ORG Mon Oct 12 11:06:46 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B42BF1065698 for ; Mon, 12 Oct 2009 11:06:46 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 888068FC15 for ; Mon, 12 Oct 2009 11:06:46 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9CB6kPL036277 for ; Mon, 12 Oct 2009 11:06:46 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9CB6jBp036273 for freebsd-acpi@FreeBSD.org; Mon, 12 Oct 2009 11:06:45 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 12 Oct 2009 11:06:45 GMT Message-Id: <200910121106.n9CB6jBp036273@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-acpi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-acpi@FreeBSD.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 11:06:46 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/139088 acpi [acpi] ACPI Exception: AE_AML_INFINITE_LOOP error o amd64/138210 acpi [acpi] acer aspire 5536 ACPI problems (S3, brightness, o bin/137053 acpi [hang] FreeBSD 8.0 BETA2Compaq Mini 700 locks on boot o kern/137042 acpi [acpi] hp laptop's lcd not wakes up after suspend to r o kern/136808 acpi [acpi] panic when switching to s3 o i386/136008 acpi [acpi] Dell Vostro 1310 will not shutdown (Requires us o bin/135349 acpi [patch] teach acpidump(8) to disassemble arbitrary mem o kern/135070 acpi [acpi] [patch] BIOS resource allocation and FreeBSD AC o kern/132602 acpi [acpi] ACPI Problem with Intel SS4200: System does not o kern/130683 acpi [ACPI] shutdown hangs after syncing disks - ACPI race? o i386/129953 acpi [acpi] ACPI timeout (CDROM) with Shuttle X27D o kern/129618 acpi [acpi] Problem with ACPI on HP Pavilion DV2899 laptop o kern/129563 acpi [acpi] sleep broken on IBM/Lenovo T61 in amd64 mode f kern/128639 acpi [patch] [acpi_asus] acpi for ASUS A6F,A3E,A3F,A3N not f kern/128634 acpi [patch] fix acpi_asus(4) in asus a6f laptop o kern/127581 acpi [patch] [acpi_sony] Add support for more Sony features o kern/124744 acpi [acpi] [patch] incorrect _BST result validation for To o kern/124412 acpi [acpi] power off error on Toshiba M40 laptop o kern/123039 acpi [acpi] ACPI AML_BUFFER_LIMIT errors during boot o kern/121504 acpi [patch] Correctly set hw.acpi.osname on certain machin f kern/121454 acpi [pst] Promise SuperTrak SX6000 does not load during bo o amd64/121439 acpi [boot] Installation of FreeBSD 7.0 fails: ACPI problem o kern/121102 acpi [acpi_fujitsu] [patch] update acpi_fujitsu for the P80 o kern/120515 acpi [acpi] [patch] acpi_alloc_wakeup_handler: can't alloc o kern/119356 acpi [acpi]: i386 ACPI wakeup not work due resource exhaust o kern/119200 acpi [acpi] Lid close switch suspends CPU for 1 second on H o kern/118973 acpi [acpi]: Kernel panic with acpi boot o kern/117605 acpi [acpi] [request] add debug.cpufreq.highest o kern/116939 acpi [acpi] PCI-to-PCI misconfigured for bus three and can o i386/114562 acpi [acpi] cardbus is dead after s3 on Thinkpad T43 with a o kern/114165 acpi [acpi] Dell C810 - ACPI problem s kern/112544 acpi [acpi] [patch] Add High Precision Event Timer Driver f o kern/108954 acpi [acpi] 'sleep(1)' sleeps >1 seconds when speedstep (Cx o kern/108695 acpi [acpi]: Fatal trap 9: general protection fault when in o kern/108488 acpi [acpi] ACPI-1304: *** Error: Method execution failed o kern/108017 acpi [acpi]: Acer Aspire 5600 o kern/106924 acpi [acpi] ACPI resume returns g_vfs_done() errors and ker o kern/105537 acpi [acpi] problems in acpi on HP Compaq nc6320 o kern/104625 acpi ACPI on ASUS A8N-32 SLI/ASUS P4P800 does not show ther o kern/102252 acpi acpi thermal does not work on Abit AW8D (intel 975) o kern/97383 acpi Volume buttons on IBM Thinkpad crash system with ACPI s i386/91748 acpi acpi problem on Acer TravelMare 4652LMi (nvidia panic, s kern/91038 acpi [panic] [ata] [acpi] 6.0-RELEASE on Fujitsu Siemens Am s kern/90243 acpi Laptop fan doesn't turn off (ACPI enabled) (Packard Be o i386/83018 acpi [install] Installer will not boot on Asus P4S8X BIOS 1 f kern/81000 acpi [apic] Via 8235 sound card worked great with FreeBSD 5 o i386/79081 acpi ACPI suspend/resume not working on HP nx6110 o kern/76950 acpi ACPI wrongly blacklisted on Micron ClientPro 766Xi sys s kern/73823 acpi [request] acpi / power-on by timer support o i386/72566 acpi ACPI, FreeBSD disables fan on Compaq Armada 1750 o i386/69750 acpi Boot without ACPI failed on ASUS L5 o kern/56024 acpi ACPI suspend drains battery while in S3 o i386/55661 acpi ACPI suspend/resume problem on ARMADA M700 o i386/54756 acpi ACPI suspend/resume problem on CF-W2 laptop 54 problems total. From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 15:33:33 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id AF919106566B; Tue, 13 Oct 2009 15:33:33 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-acpi@FreeBSD.org Date: Tue, 13 Oct 2009 11:33:14 -0400 User-Agent: KMail/1.6.2 References: <20091011142256.GA3770@roadrunner.spoerlein.net> In-Reply-To: <20091011142256.GA3770@roadrunner.spoerlein.net> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <200910131133.16487.jkim@FreeBSD.org> Cc: Ulrich =?iso-8859-1?q?Sp=F6rlein?= , current@freebsd.org Subject: Re: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 15:33:33 -0000 On Sunday 11 October 2009 10:22 am, Ulrich Spörlein wrote: > Just FYI, > > Dell Inspiron 8600c laptop, semi-recent CURRENT, latest BIOS (A14), > machine is 5 years old and producing these warnings when inserting > a battery (or booting with one inserted) > > ACPI Warning for \\_SB_.BAT0._BIF: Converted Buffer to expected > String at index 9 (20090903/nsrepair-215) ACPI Warning for > \\_SB_.BAT0._BIF: Converted Buffer to expected String at index 10 > (20090903/nsrepair-215) ACPI Warning for \\_SB_.BAT0._BIF: > Converted Buffer to expected String at index 11 > (20090903/nsrepair-215) ACPI Warning for \\_SB_.BAT0._BIF: > Converted Buffer to expected String at index 12 > (20090903/nsrepair-215) These are just informational. FYI, new ACPICA checks predefined method/object types per spec. and tries to correct common DSDT errors. Previously these "quirks" were handled by OS layer case by case. The warning message is telling you that _BIF method (get battery information) returned Buffer object instead of String object and ACPICA corrected the errors. In fact, this is a very common mistake by laptop BIOS writers. Thus, it is automatically corrected by new ACPICA. However, if you see "ACPI Error", that's something to worry about, e.g., cannot convert predefined types. > Everything works just before the ACPI import, there's also another > bunch of (harmless) errors during boot. > > acpi0: on motherboard > acpi0: [ITHREAD] > acpi0: reservation of 0, 9fc00 (3) failed > acpi0: reservation of 100000, 3fef0000 (3) failed > > This is just for reference, perhaps someone wants to know. It is harmless. Jung-uk Kim From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 20:48:31 2009 Return-Path: Delivered-To: acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B31D81065672 for ; Tue, 13 Oct 2009 20:48:31 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.freebsd.org (Postfix) with ESMTP id 98C1A8FC13 for ; Tue, 13 Oct 2009 20:48:31 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Oct 2009 13:35:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,553,1249282800"; d="scan'208";a="502830640" Received: from orsmsx602.amr.corp.intel.com ([10.22.226.211]) by fmsmga002.fm.intel.com with ESMTP; 13 Oct 2009 13:39:57 -0700 Received: from orsmsx503.amr.corp.intel.com ([10.22.226.47]) by orsmsx602.amr.corp.intel.com ([10.22.226.211]) with mapi; Tue, 13 Oct 2009 13:48:14 -0700 From: "Moore, Robert" To: "Moore, Robert" Date: Tue, 13 Oct 2009 13:48:13 -0700 Thread-Topic: ACPICA version 20091013 released Thread-Index: AcpMRntuSz8V6hmPQ6e8CZzGQKdInw== Message-ID: <4911F71203A09E4D9981D27F9D8308583B31AFCB@orsmsx503.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 13 Oct 2009 20:49:12 +0000 Cc: Subject: ACPICA version 20091013 released X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 20:48:31 -0000 13 October 2009. Summary of changes for version 20091013: This release is available at www.acpica.org/downloads 1) ACPI CA Core Subsystem: Fixed a problem where an Operation Region _REG method could be executed mor= e than once. If a custom address space handler is installed by the host bef= ore the "initialize operation regions" phase of the ACPICA initialization, = any _REG methods for that address space could be executed twice. This chang= e fixes the problem. ACPICA BZ 427. Lin Ming. Fixed a possible memory leak for the Scope() ASL operator. When the exact i= nvocation of "Scope(\)" is executed (change scope to root), one internal op= erand object was leaked. Lin Ming. Implemented a run-time repair for the _MAT predefined method. If the _MAT r= eturn value is defined as a Field object in the AML, and the field size is less than or equal to the default width of an integer (32 or 64),_M= AT can incorrectly return an Integer instead of a Buffer. ACPICA now automa= tically repairs this problem. ACPICA BZ 810. Implemented a run-time repair for the _BIF and _BIX predefined methods. The= "OEM Information" field is often incorrectly returned as an Integer with v= alue zero if the field is not supported by the platform. This is due to an = ambiguity in the ACPI specification. The field should always be a string. A= CPICA now automatically repairs this problem by returning a NULL string wit= hin the returned Package. ACPICA BZ 807. Example Code and Data Size: These are the sizes for the OS-independent acpi= ca.lib produced by the Microsoft Visual C++ 6.0 32-bit compiler. The debug = version of the code includes the debug output trace mechanism and has a muc= h larger code and data size. Previous Release: Non-Debug Version: 85.6K Code, 18.0K Data, 103.6K Total Debug Version: 161.7K Code, 50.9K Data, 212.6K Total Current Release: Non-Debug Version: 85.8K Code, 18.0K Data, 103.8K Total Debug Version: 161.8K Code, 50.6K Data, 212.4K Total 2) iASL Compiler/Disassembler and Tools: Disassembler: Fixed a problem where references to external symbols that con= tained one or more parent-prefixes (carats) were not handled correctly, pos= sibly causing a fault. ACPICA BZ 806. Lin Ming. Disassembler: Restructured the code so that all functions that handle exter= nal symbols are in a single module. One new file is added, common/dmextern.= c. AML Debugger: Added a max count argument for the Batch command (which execu= tes multiple predefined methods within the namespace.) iASL: Updated the compiler documentation (User Reference.) Available at htt= p://www.acpica.org/documentation/. ACPICA BZ 750. AcpiXtract: Updated for Lint and other formatting changes. Close all open f= iles. From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 22:08:13 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A151C10656B2; Tue, 13 Oct 2009 22:08:13 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 2C68D8FC12; Tue, 13 Oct 2009 22:08:12 +0000 (UTC) Received: from lstewart-laptop.caia.swin.edu.au (216-239-45-4.google.com [216.239.45.4]) (authenticated bits=0) by lauren.room52.net (8.14.3/8.14.3) with ESMTP id n9DLoGHu052230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Oct 2009 08:50:18 +1100 (EST) (envelope-from lstewart@freebsd.org) Message-ID: <4AD4F611.6080504@freebsd.org> Date: Tue, 13 Oct 2009 14:50:09 -0700 From: Lawrence Stewart User-Agent: Thunderbird 2.0.0.23 (X11/20090909) MIME-Version: 1.0 To: Jung-uk Kim References: <20091011142256.GA3770@roadrunner.spoerlein.net> <200910131133.16487.jkim@FreeBSD.org> In-Reply-To: <200910131133.16487.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=disabled version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on lauren.room52.net Cc: freebsd-acpi@freebsd.org, current@freebsd.org Subject: Re: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 22:08:13 -0000 Jung-uk Kim wrote: [snip] > by new ACPICA. However, if you see "ACPI Error", that's something to > worry about, e.g., cannot convert predefined types. > So I should be worried about this line from my Toshiba R600 laptop's dmesg? ACPI Error: Package List length (0xC) larger than NumElements count (0x4), truncated Cheers, Lawrence From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 22:16:13 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 03D611065672; Tue, 13 Oct 2009 22:16:13 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-current@FreeBSD.org Date: Tue, 13 Oct 2009 18:15:40 -0400 User-Agent: KMail/1.6.2 References: <20091011142256.GA3770@roadrunner.spoerlein.net> <200910131133.16487.jkim@FreeBSD.org> <4AD4F611.6080504@freebsd.org> In-Reply-To: <4AD4F611.6080504@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200910131815.53053.jkim@FreeBSD.org> Cc: Lawrence Stewart , freebsd-acpi@freebsd.org Subject: Re: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 22:16:13 -0000 On Tuesday 13 October 2009 05:50 pm, Lawrence Stewart wrote: > Jung-uk Kim wrote: > > [snip] > > > by new ACPICA. However, if you see "ACPI Error", that's > > something to worry about, e.g., cannot convert predefined types. > > So I should be worried about this line from my Toshiba R600 > laptop's dmesg? > > ACPI Error: Package List length (0xC) larger than NumElements count > (0x4), truncated Strictly speaking, it is an error because ACPI specification says so (hence the error message). However, no exception is returned because of Windows compatibility according to the comments in the source. If everything is working fine, just ignore it. :-) Jung-uk Kim From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 22:21:37 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 741281065670; Tue, 13 Oct 2009 22:21:37 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx1.freebsd.org (Postfix) with ESMTP id 3196E8FC0A; Tue, 13 Oct 2009 22:21:36 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 13 Oct 2009 15:05:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,553,1249282800"; d="scan'208";a="457177756" Received: from orsmsx604.amr.corp.intel.com ([10.22.226.87]) by orsmga002.jf.intel.com with ESMTP; 13 Oct 2009 15:27:19 -0700 Received: from orsmsx503.amr.corp.intel.com ([10.22.226.47]) by orsmsx604.amr.corp.intel.com ([10.250.113.17]) with mapi; Tue, 13 Oct 2009 15:21:35 -0700 From: "Moore, Robert" To: Jung-uk Kim , "freebsd-current@FreeBSD.org" Date: Tue, 13 Oct 2009 15:21:35 -0700 Thread-Topic: ACPI Warning: Converted Buffer to expected String Thread-Index: AcpMUuduf35f3KlTS0mYY13PceygFwAAGP8w Message-ID: <4911F71203A09E4D9981D27F9D8308583B31B180@orsmsx503.amr.corp.intel.com> References: <20091011142256.GA3770@roadrunner.spoerlein.net> <200910131133.16487.jkim@FreeBSD.org> <4AD4F611.6080504@freebsd.org> <200910131815.53053.jkim@FreeBSD.org> In-Reply-To: <200910131815.53053.jkim@FreeBSD.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Lawrence Stewart , "freebsd-acpi@freebsd.org" Subject: RE: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 22:21:37 -0000 Probably should be dropped down to a warning. This is usually caused by the BIOS modifying the package length on the fly.= No ASL compiler would do this. >-----Original Message----- >From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >acpi@freebsd.org] On Behalf Of Jung-uk Kim >Sent: Tuesday, October 13, 2009 3:16 PM >To: freebsd-current@FreeBSD.org >Cc: Lawrence Stewart; freebsd-acpi@freebsd.org >Subject: Re: ACPI Warning: Converted Buffer to expected String > >On Tuesday 13 October 2009 05:50 pm, Lawrence Stewart wrote: >> Jung-uk Kim wrote: >> >> [snip] >> >> > by new ACPICA. However, if you see "ACPI Error", that's >> > something to worry about, e.g., cannot convert predefined types. >> >> So I should be worried about this line from my Toshiba R600 >> laptop's dmesg? >> >> ACPI Error: Package List length (0xC) larger than NumElements count >> (0x4), truncated > >Strictly speaking, it is an error because ACPI specification says so >(hence the error message). However, no exception is returned because >of Windows compatibility according to the comments in the source. > >If everything is working fine, just ignore it. :-) > >Jung-uk Kim >_______________________________________________ >freebsd-acpi@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 13 23:43:05 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A615A106566B; Tue, 13 Oct 2009 23:43:05 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 1B2108FC17; Tue, 13 Oct 2009 23:43:04 +0000 (UTC) Received: from lstewart-laptop.caia.swin.edu.au (216-239-45-4.google.com [216.239.45.4]) (authenticated bits=0) by lauren.room52.net (8.14.3/8.14.3) with ESMTP id n9DNgtmn055721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Oct 2009 10:42:57 +1100 (EST) (envelope-from lstewart@freebsd.org) Message-ID: <4AD51077.1030603@freebsd.org> Date: Tue, 13 Oct 2009 16:42:47 -0700 From: Lawrence Stewart User-Agent: Thunderbird 2.0.0.23 (X11/20090909) MIME-Version: 1.0 To: Jung-uk Kim References: <20091011142256.GA3770@roadrunner.spoerlein.net> <200910131133.16487.jkim@FreeBSD.org> <4AD4F611.6080504@freebsd.org> <200910131815.53053.jkim@FreeBSD.org> In-Reply-To: <200910131815.53053.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=disabled version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on lauren.room52.net Cc: freebsd-acpi@freebsd.org, freebsd-current@freebsd.org Subject: Re: ACPI Warning: Converted Buffer to expected String X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 23:43:05 -0000 Jung-uk Kim wrote: > On Tuesday 13 October 2009 05:50 pm, Lawrence Stewart wrote: >> Jung-uk Kim wrote: >> >> [snip] >> >>> by new ACPICA. However, if you see "ACPI Error", that's >>> something to worry about, e.g., cannot convert predefined types. >> So I should be worried about this line from my Toshiba R600 >> laptop's dmesg? >> >> ACPI Error: Package List length (0xC) larger than NumElements count >> (0x4), truncated > > Strictly speaking, it is an error because ACPI specification says so > (hence the error message). However, no exception is returned because > of Windows compatibility according to the comments in the source. > Ok thanks for explaining. > If everything is working fine, just ignore it. :-) When I boot this particular laptop into windows and then back into FreeBSD (even after a power down in between), I get a reproducible panic while the kernel is booting and probing devices which can only be fixed by going into the BIOS config screen and restoring to defaults. I suspect the Windows drivers are leaving the hardware in some fancy state the FreeBSD kernel doesn't like. I have a hunch it is ACPI related. Is there some way I can tell? The panic/backtrace is always the same as follows: Slab at 0xffffff00025d5b18, freei 3 = 0. panic: Duplicate free of item 0xffffff00025f8c00 from zone 0xffffff00b697d400(1024) Backtrace at the ddb prompt looks like this: db> bt kdb_enter()+0x3d panic()+0x17b uma_dbg_free()+0x171 uma_zfree_arg()+0x68 free()+0xbd device_set_driver()+0x8e device_attach()+0x19b bus_generic_attach()+0x1a acpi_pci_attach()+0x147 device_attach()+0x69 bus_generic_attach()+0x1a acpi_pcib_attach()+0x1a7 acpi_pcib_acpi_attach()+0x1a5 device_attach()+0x69 bus_generic_attach()+0x1a acpi_attach()+0x9e4 device_attach()+0x69 bus_generic_attach()+0x1a device_attach()+0x69 root_bus_configure()+0x28 configure()+0xa mi_startup()+0x59 btext()+0x2c Cheers, Lawrence From owner-freebsd-acpi@FreeBSD.ORG Wed Oct 14 17:12:33 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C16041065676; Wed, 14 Oct 2009 17:12:33 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BFC338FC19; Wed, 14 Oct 2009 17:12:32 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA07422; Wed, 14 Oct 2009 20:12:30 +0300 (EEST) (envelope-from avg@icyb.net.ua) Message-ID: <4AD6067E.2010503@icyb.net.ua> Date: Wed, 14 Oct 2009 20:12:30 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: freebsd-acpi@FreeBSD.org, freebsd-hackers@FreeBSD.org X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Subject: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 17:12:33 -0000 Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 I actually got around to implementing it (in initial/basic form): http://people.freebsd.org/~avg/heci.tgz Other drivers are: [Linux] http://www.openamt.org/ [OpenSolaris] http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/intel/io/heci/ An example of what functionality this driver could provide: http://article.gmane.org/gmane.linux.drivers.sensors/20398 This actually was my primary motivation for looking into this driver. Your hardware may be supported by this driver if pciconf -lv has something like the following: none0@pci0:0:3:0: class=0x078000 card=0x50448086 chip=0x29c48086 rev=0x02 hdr=0x00 vendor = 'Intel Corporation' device = '(Bearlake) HECI Controller' class = simple comms Here's how successful attachment of this driver looks on my system: heci0: mem 0xe0426100-0xe042610f irq 16 at device 3.0 on pci0 heci0: using MSI heci0: [ITHREAD] heci0: found ME client at address 0x03: heci0: status = 0x00 heci0: protocol_name(guid) = A12FF5CA-FACB-4CB4-A958-19A23B2E6881 heci0: found ME client at address 0x07: heci0: status = 0x00 heci0: protocol_name(guid) = 55213584-9A29-4916-BADF-0FB7ED682AEB heci0: found ME client at address 0x20: heci0: status = 0x00 heci0: protocol_name(guid) = 309DCDE8-CCB1-4062-8F78-600115A34327 heci0: found ME client at address 0x21: heci0: status = 0x00 heci0: protocol_name(guid) = 6B5205B9-8185-4519-B889-D98724B58607 The driver has many functional and programming shortcomings, but I still would like to ask for its review and testing. Please read the following warnings and notices: 1. right now the driver is provided only as a module. 2. the driver recognizes only PCI ID of 0x29c48086, which is what I tested it with; please see hecireg.h for a list of potentially supported IDs and add your ID to heci_probe(). 3. heciio.h does not get installed into /usr/include, so for time being you need to take an extra step to make it available to code that wishes to communicate to heci. 4. this driver has far less capabilities than Linux and OpenSolaris drivers, so don't expect every OpenAMT program to work with it (but it does reliably work for me for the QST thing). Now more details about the code: 1. the code contains some style violations like overly long lines, probably others; but I still would like to hear your comments on its style. 2. there are some bad design decisions like using the same mutex+condvar pair for signaling different events (reception of data from ME, emptying of user buffer); but I still would like to hear your comments about improving the design. 3. only a single connection is allowed for a host client 4. only a single connection is allowed to a ME client (if the client can support more). 5. quite an arbitrary timeout is used in all places where we wait for simething to happen. 6. no power management supported. 7. only messages of size less than 512 bytes are supported. 8. only complete messages are supported, multi-part messages are not. 9. userland is expected to read or write the whole message in one go. 10. poll/select functionality is not tested. 11. non-blocking reads/writes are not supported. 12. some (probably important) properties and statuses of ME clients are not interpreted. 13. no specific support for watchdog and PTHI, only simple HECI/MEI communications. 14. probably many more... I think that ultimately, if complete feature support is needed, it would be easier to port the driver from either OpenSolaris or Linux than to add all the features to the presented driver. This is because documentation/description for many features is severely lacking in public access. I guess that Intel developers that worked on the OpenAMT driver had much more detailed specifications to work with. But reverse-engineering some parts of OpenAMT code is very hard. You can see for yourself, if not for the hacker who decompiled a Windows DLL, there would be no way of obtaining even GUID of QST client from public sources. Thank you very much in advance for any feedback, comments, ideas! P.S. BTW, can/may I drop "alternatively GPL" wording from License block of the files I borrowed from Intel? I.e. can a dual BSD+GPL licensed file be turned into BSD-only? Some additional info. The files contain only some data structure/constants definitions. I guess those are not copyrightable at all? I added a bunch of comments to those file describing the constants and structs. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Wed Oct 14 21:25:41 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56D8E106568D; Wed, 14 Oct 2009 21:25:41 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 1A8908FC0C; Wed, 14 Oct 2009 21:25:40 +0000 (UTC) Received: from [192.168.1.4] (adsl-154-199-198.ard.bellsouth.net [72.154.199.198]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n9ELPc59026929 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 14 Oct 2009 17:25:38 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Andriy Gapon In-Reply-To: <4AD6067E.2010503@icyb.net.ua> References: <4AD6067E.2010503@icyb.net.ua> Content-Type: text/plain Organization: FreeBSD Date: Wed, 14 Oct 2009 16:25:32 -0500 Message-Id: <1255555532.95374.147.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 21:25:41 -0000 On Wed, 2009-10-14 at 20:12 +0300, Andriy Gapon wrote: > Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: > http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 > > I actually got around to implementing it (in initial/basic form): > http://people.freebsd.org/~avg/heci.tgz Your getting a WITNESS warning from malloc() while holding a lock at like 941 of heci.c mec = (struct me_client *)malloc(sizeof(*mec), M_HECI, M_NOWAIT | M_ZERO); fixes it. It also locked up the machine when I tried to kldunload, but haven't identified a root cause of that. robert. > Other drivers are: > [Linux] http://www.openamt.org/ > [OpenSolaris] > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/intel/io/heci/ > > An example of what functionality this driver could provide: > http://article.gmane.org/gmane.linux.drivers.sensors/20398 > This actually was my primary motivation for looking into this driver. > > Your hardware may be supported by this driver if pciconf -lv has something like > the following: > none0@pci0:0:3:0: class=0x078000 card=0x50448086 chip=0x29c48086 rev=0x02 > hdr=0x00 > vendor = 'Intel Corporation' > device = '(Bearlake) HECI Controller' > class = simple comms > > Here's how successful attachment of this driver looks on my system: > heci0: mem > 0xe0426100-0xe042610f irq 16 at device 3.0 on pci0 > heci0: using MSI > heci0: [ITHREAD] > heci0: found ME client at address 0x03: > heci0: status = 0x00 > heci0: protocol_name(guid) = A12FF5CA-FACB-4CB4-A958-19A23B2E6881 > heci0: found ME client at address 0x07: > heci0: status = 0x00 > heci0: protocol_name(guid) = 55213584-9A29-4916-BADF-0FB7ED682AEB > heci0: found ME client at address 0x20: > heci0: status = 0x00 > heci0: protocol_name(guid) = 309DCDE8-CCB1-4062-8F78-600115A34327 > heci0: found ME client at address 0x21: > heci0: status = 0x00 > heci0: protocol_name(guid) = 6B5205B9-8185-4519-B889-D98724B58607 > > The driver has many functional and programming shortcomings, but I still would > like to ask for its review and testing. > Please read the following warnings and notices: > 1. right now the driver is provided only as a module. > 2. the driver recognizes only PCI ID of 0x29c48086, which is what I tested it > with; please see hecireg.h for a list of potentially supported IDs and add your ID > to heci_probe(). > 3. heciio.h does not get installed into /usr/include, so for time being you need > to take an extra step to make it available to code that wishes to communicate to heci. > 4. this driver has far less capabilities than Linux and OpenSolaris drivers, so > don't expect every OpenAMT program to work with it (but it does reliably work for > me for the QST thing). > > Now more details about the code: > 1. the code contains some style violations like overly long lines, probably > others; but I still would like to hear your comments on its style. > 2. there are some bad design decisions like using the same mutex+condvar pair for > signaling different events (reception of data from ME, emptying of user buffer); > but I still would like to hear your comments about improving the design. > 3. only a single connection is allowed for a host client > 4. only a single connection is allowed to a ME client (if the client can support > more). > 5. quite an arbitrary timeout is used in all places where we wait for simething to > happen. > 6. no power management supported. > 7. only messages of size less than 512 bytes are supported. > 8. only complete messages are supported, multi-part messages are not. > 9. userland is expected to read or write the whole message in one go. > 10. poll/select functionality is not tested. > 11. non-blocking reads/writes are not supported. > 12. some (probably important) properties and statuses of ME clients are not > interpreted. > 13. no specific support for watchdog and PTHI, only simple HECI/MEI communications. > 14. probably many more... > > I think that ultimately, if complete feature support is needed, it would be easier > to port the driver from either OpenSolaris or Linux than to add all the features > to the presented driver. This is because documentation/description for many > features is severely lacking in public access. I guess that Intel developers that > worked on the OpenAMT driver had much more detailed specifications to work with. > But reverse-engineering some parts of OpenAMT code is very hard. > You can see for yourself, if not for the hacker who decompiled a Windows DLL, > there would be no way of obtaining even GUID of QST client from public sources. > > Thank you very much in advance for any feedback, comments, ideas! > > P.S. > BTW, can/may I drop "alternatively GPL" wording from License block of the files I > borrowed from Intel? I.e. can a dual BSD+GPL licensed file be turned into BSD-only? > Some additional info. The files contain only some data structure/constants > definitions. I guess those are not copyrightable at all? I added a bunch of > comments to those file describing the constants and structs. > -- Robert Noland FreeBSD From owner-freebsd-acpi@FreeBSD.ORG Wed Oct 14 23:14:42 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4D9A1065692 for ; Wed, 14 Oct 2009 23:14:42 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from mail-fx0-f222.google.com (mail-fx0-f222.google.com [209.85.220.222]) by mx1.freebsd.org (Postfix) with ESMTP id 6BC2B8FC2F for ; Wed, 14 Oct 2009 23:14:42 +0000 (UTC) Received: by fxm22 with SMTP id 22so379785fxm.36 for ; Wed, 14 Oct 2009 16:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=CVLsc62Kou1DBdImRiclWx1/iFncp9BsZtqRXVL68HA=; b=d9U525H/YxEfjkhGXOM5rHpCl5m9CqIJuOULUvRLyxgJgWjFuBjLNu/T1sXd/PGhAV OidgW605Uli/aTzCmHm4tDyeJXOcBXTanUV/GhvN2SOi0U4tC9ptMbKPvTtfCf5h3h4b Euy5DTIo6AXX0IljR02/GqCjx1rWSOGLfeugE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=dMofhw3v9DYeiJ+4m6S5Osrf+q6n3j/I6UdJCNW461RPXIBhXDrsAC5F3ODEuhYLt1 vHklfqOcIoPEmBtet7ZiNcQ4KuuDdmglny1zPMJL+H2lChJi4OK9Z3dfNwG3djN4/yg4 SMZosWsSxlFKeD7m3glmorTpp9t7DE1tE5SZA= MIME-Version: 1.0 Received: by 10.239.170.24 with SMTP id q24mr715173hbe.2.1255560380463; Wed, 14 Oct 2009 15:46:20 -0700 (PDT) In-Reply-To: <4AD6067E.2010503@icyb.net.ua> References: <4AD6067E.2010503@icyb.net.ua> Date: Wed, 14 Oct 2009 19:46:20 -0300 Message-ID: From: "Carlos A. M. dos Santos" To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org, freebsd-acpi@freebsd.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 23:14:42 -0000 On Wed, Oct 14, 2009 at 2:12 PM, Andriy Gapon wrote: > BTW, can/may I drop "alternatively GPL" wording from License block of the files I > borrowed from Intel? I.e. can a dual BSD+GPL licensed file be turned into BSD-only? If Intel is the copyright owner then you can not change the license without their permission. -- My preferred quotation of Robert Louis Stevenson is "You cannot make an omelette without breaking eggs". Not because I like the omelettes, but because I like the sound of eggs being broken. From owner-freebsd-acpi@FreeBSD.ORG Wed Oct 14 23:36:09 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8559D10656AB; Wed, 14 Oct 2009 23:36:09 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 49B6F8FC21; Wed, 14 Oct 2009 23:36:08 +0000 (UTC) Received: from [192.168.1.4] (adsl-154-199-198.ard.bellsouth.net [72.154.199.198]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n9ENa4Ji027991 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 14 Oct 2009 19:36:07 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Andriy Gapon In-Reply-To: <4AD6067E.2010503@icyb.net.ua> References: <4AD6067E.2010503@icyb.net.ua> Content-Type: text/plain Organization: FreeBSD Date: Wed, 14 Oct 2009 16:35:29 -0500 Message-Id: <1255556129.95374.160.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 23:36:09 -0000 On Wed, 2009-10-14 at 20:12 +0300, Andriy Gapon wrote: > Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: > http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 > > I actually got around to implementing it (in initial/basic form): > http://people.freebsd.org/~avg/heci.tgz > > Other drivers are: > [Linux] http://www.openamt.org/ > [OpenSolaris] > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/intel/io/heci/ > > An example of what functionality this driver could provide: > http://article.gmane.org/gmane.linux.drivers.sensors/20398 > This actually was my primary motivation for looking into this driver. Could you also post the client code in some form more readily accessible than trying to cut/paste from the web page? robert. > Your hardware may be supported by this driver if pciconf -lv has something like > the following: > none0@pci0:0:3:0: class=0x078000 card=0x50448086 chip=0x29c48086 rev=0x02 > hdr=0x00 > vendor = 'Intel Corporation' > device = '(Bearlake) HECI Controller' > class = simple comms > > Here's how successful attachment of this driver looks on my system: > heci0: mem > 0xe0426100-0xe042610f irq 16 at device 3.0 on pci0 > heci0: using MSI > heci0: [ITHREAD] > heci0: found ME client at address 0x03: > heci0: status = 0x00 > heci0: protocol_name(guid) = A12FF5CA-FACB-4CB4-A958-19A23B2E6881 > heci0: found ME client at address 0x07: > heci0: status = 0x00 > heci0: protocol_name(guid) = 55213584-9A29-4916-BADF-0FB7ED682AEB > heci0: found ME client at address 0x20: > heci0: status = 0x00 > heci0: protocol_name(guid) = 309DCDE8-CCB1-4062-8F78-600115A34327 > heci0: found ME client at address 0x21: > heci0: status = 0x00 > heci0: protocol_name(guid) = 6B5205B9-8185-4519-B889-D98724B58607 > > The driver has many functional and programming shortcomings, but I still would > like to ask for its review and testing. > Please read the following warnings and notices: > 1. right now the driver is provided only as a module. > 2. the driver recognizes only PCI ID of 0x29c48086, which is what I tested it > with; please see hecireg.h for a list of potentially supported IDs and add your ID > to heci_probe(). > 3. heciio.h does not get installed into /usr/include, so for time being you need > to take an extra step to make it available to code that wishes to communicate to heci. > 4. this driver has far less capabilities than Linux and OpenSolaris drivers, so > don't expect every OpenAMT program to work with it (but it does reliably work for > me for the QST thing). > > Now more details about the code: > 1. the code contains some style violations like overly long lines, probably > others; but I still would like to hear your comments on its style. > 2. there are some bad design decisions like using the same mutex+condvar pair for > signaling different events (reception of data from ME, emptying of user buffer); > but I still would like to hear your comments about improving the design. > 3. only a single connection is allowed for a host client > 4. only a single connection is allowed to a ME client (if the client can support > more). > 5. quite an arbitrary timeout is used in all places where we wait for simething to > happen. > 6. no power management supported. > 7. only messages of size less than 512 bytes are supported. > 8. only complete messages are supported, multi-part messages are not. > 9. userland is expected to read or write the whole message in one go. > 10. poll/select functionality is not tested. > 11. non-blocking reads/writes are not supported. > 12. some (probably important) properties and statuses of ME clients are not > interpreted. > 13. no specific support for watchdog and PTHI, only simple HECI/MEI communications. > 14. probably many more... > > I think that ultimately, if complete feature support is needed, it would be easier > to port the driver from either OpenSolaris or Linux than to add all the features > to the presented driver. This is because documentation/description for many > features is severely lacking in public access. I guess that Intel developers that > worked on the OpenAMT driver had much more detailed specifications to work with. > But reverse-engineering some parts of OpenAMT code is very hard. > You can see for yourself, if not for the hacker who decompiled a Windows DLL, > there would be no way of obtaining even GUID of QST client from public sources. > > Thank you very much in advance for any feedback, comments, ideas! > > P.S. > BTW, can/may I drop "alternatively GPL" wording from License block of the files I > borrowed from Intel? I.e. can a dual BSD+GPL licensed file be turned into BSD-only? > Some additional info. The files contain only some data structure/constants > definitions. I guess those are not copyrightable at all? I added a bunch of > comments to those file describing the constants and structs. > -- Robert Noland FreeBSD From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 15 05:23:54 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 679611065670; Thu, 15 Oct 2009 05:23:54 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 378728FC28; Thu, 15 Oct 2009 05:23:52 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA15955; Thu, 15 Oct 2009 08:23:50 +0300 (EEST) (envelope-from avg@icyb.net.ua) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1MyIoX-0002WK-7n; Thu, 15 Oct 2009 08:23:49 +0300 Message-ID: <4AD6B1D5.3010003@icyb.net.ua> Date: Thu, 15 Oct 2009 08:23:33 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.23 (X11/20090823) MIME-Version: 1.0 To: Robert Noland References: <4AD6067E.2010503@icyb.net.ua> <1255555532.95374.147.camel@balrog.2hip.net> In-Reply-To: <1255555532.95374.147.camel@balrog.2hip.net> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-U Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 05:23:54 -0000 on 15/10/2009 00:25 Robert Noland said the following: > On Wed, 2009-10-14 at 20:12 +0300, Andriy Gapon wrote: >> Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: >> http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 >> >> I actually got around to implementing it (in initial/basic form): >> http://people.freebsd.org/~avg/heci.tgz > > Your getting a WITNESS warning from malloc() while holding a lock at > like 941 of heci.c > > mec = (struct me_client *)malloc(sizeof(*mec), M_HECI, > M_NOWAIT | M_ZERO); > > fixes it. Shame on me! I have to admit that tested/used this module only on stable/7 (amd64) and without WITNESS/INVARIANTS. Thank you for catching this. I guess I should also add a check for malloc returning NULL. > It also locked up the machine when I tried to kldunload, but > haven't identified a root cause of that. Haven't seen it here. I will try to investigate. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 15 05:26:31 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A9D71065693; Thu, 15 Oct 2009 05:26:31 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E1D008FC1C; Thu, 15 Oct 2009 05:26:29 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA16013; Thu, 15 Oct 2009 08:26:28 +0300 (EEST) (envelope-from avg@icyb.net.ua) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1MyIr6-0002Wa-3k; Thu, 15 Oct 2009 08:26:28 +0300 Message-ID: <4AD6B274.5050906@icyb.net.ua> Date: Thu, 15 Oct 2009 08:26:12 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.23 (X11/20090823) MIME-Version: 1.0 To: Robert Noland References: <4AD6067E.2010503@icyb.net.ua> <1255556129.95374.160.camel@balrog.2hip.net> In-Reply-To: <1255556129.95374.160.camel@balrog.2hip.net> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-U Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 05:26:31 -0000 on 15/10/2009 00:35 Robert Noland said the following: > On Wed, 2009-10-14 at 20:12 +0300, Andriy Gapon wrote: >> Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: >> http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 >> >> I actually got around to implementing it (in initial/basic form): >> http://people.freebsd.org/~avg/heci.tgz >> >> Other drivers are: >> [Linux] http://www.openamt.org/ >> [OpenSolaris] >> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/intel/io/heci/ >> >> An example of what functionality this driver could provide: >> http://article.gmane.org/gmane.linux.drivers.sensors/20398 >> This actually was my primary motivation for looking into this driver. > > Could you also post the client code in some form more readily accessible > than trying to cut/paste from the web page? > > robert. Sure: http://people.freebsd.org/~avg/heci-qst.c Sorry for not doing this from the very start. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 15 10:41:07 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF6AA1065672 for ; Thu, 15 Oct 2009 10:41:07 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 955268FC1D for ; Thu, 15 Oct 2009 10:41:07 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 946386D41B; Thu, 15 Oct 2009 10:25:40 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 6267E84503; Thu, 15 Oct 2009 12:25:40 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Andriy Gapon References: <4AD6067E.2010503@icyb.net.ua> Date: Thu, 15 Oct 2009 12:25:40 +0200 In-Reply-To: <4AD6067E.2010503@icyb.net.ua> (Andriy Gapon's message of "Wed, 14 Oct 2009 20:12:30 +0300") Message-ID: <86iqehx8bf.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 10:41:07 -0000 Andriy Gapon writes: > BTW, can / may I drop "alternatively GPL" wording from License block > of the files I borrowed from Intel? I.e. can a dual BSD+GPL licensed > file be turned into BSD-only? No. Why would you want to? > Some additional info. The files contain only some data structure / > constants definitions. I guess those are not copyrightable at all? That's debatable. It is probably safe to assume that they aren't *if* they only describe the interface to another piece of software or to the hardware, but if they represent internal data structures used by the Linux driver, they are definitely copyrightable. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 15 14:17:04 2009 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 616831065679; Thu, 15 Oct 2009 14:17:04 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 261258FC12; Thu, 15 Oct 2009 14:17:04 +0000 (UTC) Received: from [192.168.1.4] (adsl-154-199-198.ard.bellsouth.net [72.154.199.198]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n9FEH0IV032165 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 15 Oct 2009 10:17:01 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Andriy Gapon In-Reply-To: <4AD6B1D5.3010003@icyb.net.ua> References: <4AD6067E.2010503@icyb.net.ua> <1255555532.95374.147.camel@balrog.2hip.net> <4AD6B1D5.3010003@icyb.net.ua> Content-Type: text/plain Organization: FreeBSD Date: Thu, 15 Oct 2009 09:16:54 -0500 Message-Id: <1255616214.2356.872.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-hackers@FreeBSD.org, freebsd-acpi@FreeBSD.org Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 14:17:04 -0000 On Thu, 2009-10-15 at 08:23 +0300, Andriy Gapon wrote: > on 15/10/2009 00:25 Robert Noland said the following: > > On Wed, 2009-10-14 at 20:12 +0300, Andriy Gapon wrote: > >> Some time ago I posted some ideas about HECI/MEI driver for FreeBSD: > >> http://docs.freebsd.org/cgi/mid.cgi?4968E9A1.3080006 > >> > >> I actually got around to implementing it (in initial/basic form): > >> http://people.freebsd.org/~avg/heci.tgz > > > > Your getting a WITNESS warning from malloc() while holding a lock at > > like 941 of heci.c > > > > mec = (struct me_client *)malloc(sizeof(*mec), M_HECI, > > M_NOWAIT | M_ZERO); > > > > fixes it. > > Shame on me! > I have to admit that tested/used this module only on stable/7 (amd64) and > without WITNESS/INVARIANTS. > Thank you for catching this. > I guess I should also add a check for malloc returning NULL. Yes, with M_NOWAIT you should. Here is the dmesg output. heci0: mem 0xd0526100-0xd052610f irq 16 at device 3.0 on pci0 heci0: using MSI heci0: [ITHREAD] heci0: found ME client at address 0x02: heci0: status = 0x00 heci0: protocol_name(guid) = BB875E12-CB58-4D14-AE93-8566183C66C7 heci0: found ME client at address 0x03: heci0: status = 0x00 heci0: protocol_name(guid) = A12FF5CA-FACB-4CB4-A958-19A23B2E6881 heci0: found ME client at address 0x06: heci0: status = 0x00 heci0: protocol_name(guid) = 9B27FD6D-EF72-4967-BCC2-471A32679620 heci0: found ME client at address 0x07: heci0: status = 0x00 heci0: protocol_name(guid) = 55213584-9A29-4916-BADF-0FB7ED682AEB heci0: found ME client at address 0x20: heci0: status = 0x00 heci0: protocol_name(guid) = 23F27E9B-9D26-4FCE-9227-DE06446E5B06 heci0: found ME client at address 0x21: heci0: status = 0x00 heci0: protocol_name(guid) = 309DCDE8-CCB1-4062-8F78-600115A34327 heci0: found ME client at address 0x22: heci0: status = 0x00 heci0: protocol_name(guid) = 6B5205B9-8185-4519-B889-D98724B58607 heci0: found ME client at address 0x23: heci0: status = 0x00 heci0: protocol_name(guid) = 9D9105BD-C8C6-41CA-AC28-84738E2CE9FD heci0: found ME client at address 0x24: heci0: status = 0x00 heci0: protocol_name(guid) = DC506909-7ADB-4A0D-B109-4E25E38C382C heci0: found ME client at address 0x25: heci0: status = 0x00 heci0: protocol_name(guid) = 6733A4DB-0476-4E7B-B3AF-BCFC29BEE7A7 heci0: found ME client at address 0x26: heci0: status = 0x00 heci0: protocol_name(guid) = 12F80028-B4B7-4B2D-ACA8-46E0FF65814C heci0: found ME client at address 0x27: heci0: status = 0x00 heci0: protocol_name(guid) = 05B79A6F-4628-4D7F-899D-A91514CB32AB robert. > > It also locked up the machine when I tried to kldunload, but > > haven't identified a root cause of that. > > Haven't seen it here. > I will try to investigate. > -- Robert Noland FreeBSD From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 15 15:01:51 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46A5F106568F; Thu, 15 Oct 2009 15:01:51 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from mail-vw0-f181.google.com (mail-vw0-f181.google.com [209.85.212.181]) by mx1.freebsd.org (Postfix) with ESMTP id D6D508FC21; Thu, 15 Oct 2009 15:01:50 +0000 (UTC) Received: by vws11 with SMTP id 11so496806vws.28 for ; Thu, 15 Oct 2009 08:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DT5CeRZdkDrkXXh7S84YHZnKh7D/CZgrDuR7Dl6lxNE=; b=mN97//tepsVrAI44FbgvdQlkuaC/BdoUb2/jkp1ZnfSm/cl2k8Qr8iAt8N2nk++jDO uy15d+VuO9SL7lkJ3MfCpacrNXPpaunT7FgYKYKtKU+e7A2sxLaBV846HSIgzKa6qFAo UhrLzEIbuukf4zBEE5PmxlJNKHtG8S41+YQBA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ItsJdRFBGv5FtTpP7PrLi7lXAnnlwzh3DWc5q4XA6vTqe57TrulLd2jfbcVobYdppP 8IdH/POnlRHWTYCTfsPv9v8/QWjIDbTH20D3MqOwF5p5lZOyWBOyuBrU7tXWc9NfwySN pWLzSbN5OucHJXRURHiRaShkQWzUM3CXC/xw0= MIME-Version: 1.0 Received: by 10.239.144.92 with SMTP id n28mr12356hba.181.1255618908917; Thu, 15 Oct 2009 08:01:48 -0700 (PDT) In-Reply-To: <20091014203428.7d84bf96@bhuda.mired.org> References: <4AD6067E.2010503@icyb.net.ua> <20091014203428.7d84bf96@bhuda.mired.org> Date: Thu, 15 Oct 2009 12:01:48 -0300 Message-ID: From: "Carlos A. M. dos Santos" To: Mike Meyer Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, freebsd-acpi@freebsd.org, Andriy Gapon Subject: Re: heci: a new driver for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 15:01:51 -0000 On Wed, Oct 14, 2009 at 9:34 PM, Mike Meyer wrote: > On Wed, 14 Oct 2009 19:46:20 -0300 > "Carlos A. M. dos Santos" wrote: > >> On Wed, Oct 14, 2009 at 2:12 PM, Andriy Gapon wrote: >> >> > BTW, can/may I drop "alternatively GPL" wording from License block of = the files I >> > borrowed from Intel? I.e. can a dual BSD+GPL licensed file be turned i= nto BSD-only? >> >> If Intel is the copyright owner then you can not change the license >> without their permission. > > True. But he *has* their permission. They list the requirements for > use and redistribution in the license block in question: > > =A0* Redistribution and use in source and binary forms, with or without > =A0* modification, are permitted provided that the following conditions > =A0* are met: > =A0* 1. Redistributions of source code must retain the above copyright > =A0* =A0 =A0notice, this list of conditions, and the following disclaimer= , > =A0* =A0 =A0without modification. > =A0* 2. Redistributions in binary form must reproduce at minimum a discla= imer > =A0* =A0 =A0substantially similar to the "NO WARRANTY" disclaimer below > =A0* =A0 =A0("Disclaimer") and any redistribution must be conditioned upo= n > =A0* =A0 =A0including a substantially similar Disclaimer requirement for = further > =A0* =A0 =A0binary redistribution. > =A0* 3. Neither the names of the above-listed copyright holders nor the n= ames > =A0* =A0 =A0of any contributors may be used to endorse or promote product= s derived > =A0* =A0 =A0from this software without specific prior written permission. > > I don't see anything there about retaining the ability to choose an > alternative license. The paragraph in question says that people can > *choose* to distribute it under the GPLv2, not that it *is* being > distributed under the GPLv2. Conversely, I don't see anything there explicitly *allowing* somebody to remove that paragraph so I'd keep it unless I had express clearance from Intel. Making assumptions can be dangerous, especially when dealing with large corporations. That's the main lesson I've learned after several years dealing with such matters. I don't want to make this discussion longer than necessary, so I stop here. --=20 My preferred quotation of Robert Louis Stevenson is "You cannot make an omelette without breaking eggs". Not because I like the omelettes, but because I like the sound of eggs being broken.