From owner-freebsd-arch@FreeBSD.ORG Sun Oct 25 14:00:08 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A5E1106566B for ; Sun, 25 Oct 2009 14:00:08 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id EA0948FC13 for ; Sun, 25 Oct 2009 14:00:07 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id C495741C6A7 for ; Sun, 25 Oct 2009 15:00:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id n3bFt5oG1onA for ; Sun, 25 Oct 2009 15:00:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id E543541C6A3; Sun, 25 Oct 2009 15:00:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 930ED4448E6 for ; Sun, 25 Oct 2009 13:56:59 +0000 (UTC) Date: Sun, 25 Oct 2009 13:56:59 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: arch@FreeBSD.org Message-ID: <20091025134226.Q91695@maildrop.int.zabbadoz.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: src/Makefile, universe, LINT, VIMAGE, .. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2009 14:00:08 -0000 Hi, since the advent of VIMAGE in FreeBSD HEAD we've had a way to compile the network stack in multiple ways. Unfortunately LINT can always only test one of the options. In addition I, for quite a while, had other combinations I tested like nooptions INET6 or nooptions INET nooptions INET6 etc. We need a solution to be able to test those things and make sure to not break those combinations (atm at least VIMAGE). Unfortunately our build system and kernel configurations are not there yet. I had been pondering whether to just commit a LINT-VIMAGE file that would include LINT and just fail if that wasn't there but then realized that this will not fix the real problem. Some archs do not even have a LINT file, btw. The information attached to the diff will tell you more about what I did. I am not yet convinced that the solution presented further down is the right thing to do (and would do the right thing in all cases though I tested the obvious ones). Thus I'd like to solicit feedback, comments, improved version, ..;) You can also fetch the diff temporary from: http://people.freebsd.org/~bz/20091025-01-make-LINT-VIMAGE.diff Thanks, /bz -- Bjoern A. Zeeb It will not break if you know what you are doing. ! ! In sys//conf/Makefile set TARGET to . That allows ! sys/conf/makeLINT.mk to only do certain things for certain ! architectures. ! ! Generate a second LINT configuration for i386 and amd64 in ! sys/conf/makeLINT.mk, which includes LINT and sets options VIMAGE ! so that we will have VIMAGE LINT builds[1]. ! ! To avoid hardcoding further kernel configuration names for ! make universe, split the logic into two parts: ! - 1st to build worlds and generate kernel configs like LINT. ! - 2nd to build kernels for a given TARGET architecture correctly ! finding all newly generated configs, not knowing anything about ! LINT anymore. (*) ! ! (*) If you know better/cleaner/... ways to do this, let me know. ! ! Annotation: this also allows one to add more such kernel configs ! like LINT-NOINET, LINT-NOINET6, .. that I have had for ages now ! to generate and maintain in a single place. ! ! ! Requested by: jhb [1] ! Discussed with: jhb, rwatson [1] ! Reviewed by: ! MFC After: ! Index: Makefile =================================================================== --- Makefile (revision 198467) +++ Makefile (working copy) @@ -297,10 +297,6 @@ rm -f ${FAILFILE} .endif .for target in ${TARGETS} -KERNCONFS!= cd ${.CURDIR}/sys/${target}/conf && \ - find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ - ! -name DEFAULTS ! -name LINT -KERNCONFS:= ${KERNCONFS:S/^NOTES$/LINT/} universe: universe_${target} .ORDER: universe_prologue universe_${target} universe_epilogue universe_${target}: @@ -320,15 +316,7 @@ (echo "${target} 'make LINT' failed," \ "check _.${target}.makeLINT for details"| ${MAKEFAIL})) .endif -.for kernel in ${KERNCONFS} - @(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \ - ${MAKE} ${JFLAG} buildkernel \ - TARGET=${target} \ - KERNCONF=${kernel} \ - > _.${target}.${kernel} 2>&1 || \ - (echo "${target} ${kernel} kernel failed," \ - "check _.${target}.${kernel} for details"| ${MAKEFAIL})) -.endfor + cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} TARGET=${target} universe_kernels @echo ">> ${target} completed on `LC_ALL=C date`" .endfor universe: universe_epilogue @@ -345,3 +333,18 @@ fi .endif .endif + +universe_kernels: universe_kernels_foo +TARGET?= ${BUILD_ARCH} +KERNCONFS!= cd ${.CURDIR}/sys/${TARGET}/conf && \ + find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ + ! -name DEFAULTS ! -name NOTES +KERNCONFS:= ${KERNCONFS} +universe_kernels_foo: +.for kernel in ${KERNCONFS} + @(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \ + ${MAKE} ${JFLAG} buildkernel TARGET=${TARGET} KERNCONF=${kernel} \ + > _.${TARGET}.${kernel} 2>&1 || \ + (echo "${TARGET} ${kernel} kernel failed," \ + "check _.${TARGET}.${kernel} for details"| ${MAKEFAIL})) +.endfor Index: sys/powerpc/conf/Makefile =================================================================== --- sys/powerpc/conf/Makefile (revision 198467) +++ sys/powerpc/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=powerpc + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/sparc64/conf/Makefile =================================================================== --- sys/sparc64/conf/Makefile (revision 198467) +++ sys/sparc64/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=sparc64 + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/conf/makeLINT.mk =================================================================== --- sys/conf/makeLINT.mk (revision 198467) +++ sys/conf/makeLINT.mk (working copy) @@ -5,7 +5,15 @@ clean: rm -f LINT +.if ${TARGET} == "amd64" || ${TARGET} == "i386" + rm -f LINT=VIMAGE +.endif NOTES= ../../conf/NOTES NOTES LINT: ${NOTES} ../../conf/makeLINT.sed cat ${NOTES} | sed -E -n -f ../../conf/makeLINT.sed > ${.TARGET} +.if ${TARGET} == "amd64" || ${TARGET} == "i386" + echo "include ${.TARGET}" > ${.TARGET}-VIMAGE + echo "ident ${.TARGET}-VIMAGE" >> ${.TARGET}-VIMAGE + echo "options VIMAGE" >> ${.TARGET}-VIMAGE +.endif Index: sys/ia64/conf/Makefile =================================================================== --- sys/ia64/conf/Makefile (revision 198467) +++ sys/ia64/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=ia64 + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/sun4v/conf/Makefile =================================================================== --- sys/sun4v/conf/Makefile (revision 198467) +++ sys/sun4v/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=sun4v + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/pc98/conf/Makefile =================================================================== --- sys/pc98/conf/Makefile (revision 198467) +++ sys/pc98/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=pc98 + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/i386/conf/Makefile =================================================================== --- sys/i386/conf/Makefile (revision 198467) +++ sys/i386/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=i386 + .include "${.CURDIR}/../../conf/makeLINT.mk" Index: sys/amd64/conf/Makefile =================================================================== --- sys/amd64/conf/Makefile (revision 198467) +++ sys/amd64/conf/Makefile (working copy) @@ -1,3 +1,5 @@ # $FreeBSD$ +TARGET=amd64 + .include "${.CURDIR}/../../conf/makeLINT.mk" From owner-freebsd-arch@FreeBSD.ORG Mon Oct 26 11:06:54 2009 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD088106568D for ; Mon, 26 Oct 2009 11:06:54 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 903BB8FC1E for ; Mon, 26 Oct 2009 11:06:54 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9QB6sLt043691 for ; Mon, 26 Oct 2009 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9QB6sIu043689 for freebsd-arch@FreeBSD.org; Mon, 26 Oct 2009 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 26 Oct 2009 11:06:54 GMT Message-Id: <200910261106.n9QB6sIu043689@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-arch@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 11:06:54 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/120749 arch [request] Suggest upping the default kern.ps_arg_cache 1 problem total. From owner-freebsd-arch@FreeBSD.ORG Mon Oct 26 15:45:17 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BAA5106568B for ; Mon, 26 Oct 2009 15:45:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4CAA28FC08 for ; Mon, 26 Oct 2009 15:45:17 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id DA6EA46B0C; Mon, 26 Oct 2009 11:45:16 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id ED5448A01D; Mon, 26 Oct 2009 11:45:15 -0400 (EDT) From: John Baldwin To: freebsd-arch@freebsd.org Date: Mon, 26 Oct 2009 08:30:24 -0400 User-Agent: KMail/1.9.7 References: <20091025134226.Q91695@maildrop.int.zabbadoz.net> In-Reply-To: <20091025134226.Q91695@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910260830.25168.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 26 Oct 2009 11:45:15 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: "Bjoern A. Zeeb" Subject: Re: src/Makefile, universe, LINT, VIMAGE, .. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 15:45:17 -0000 On Sunday 25 October 2009 9:56:59 am Bjoern A. Zeeb wrote: > Hi, > > since the advent of VIMAGE in FreeBSD HEAD we've had a way to compile > the network stack in multiple ways. Unfortunately LINT can always only > test one of the options. > > In addition I, for quite a while, had other combinations I tested like > nooptions INET6 > or > nooptions INET > nooptions INET6 > etc. > > > We need a solution to be able to test those things and make sure to not > break those combinations (atm at least VIMAGE). > > Unfortunately our build system and kernel configurations are not there > yet. I had been pondering whether to just commit a LINT-VIMAGE file > that would include LINT and just fail if that wasn't there but then > realized that this will not fix the real problem. Some archs do not > even have a LINT file, btw. > > The information attached to the diff will tell you more about what I > did. I am not yet convinced that the solution presented further > down is the right thing to do (and would do the right thing in all > cases though I tested the obvious ones). > > Thus I'd like to solicit feedback, comments, improved version, ..;) > > You can also fetch the diff temporary from: > http://people.freebsd.org/~bz/20091025-01-make-LINT-VIMAGE.diff > > Thanks, > /bz > > -- > Bjoern A. Zeeb It will not break if you know what you are doing. > > ! > ! In sys//conf/Makefile set TARGET to . That allows > ! sys/conf/makeLINT.mk to only do certain things for certain > ! architectures. > ! > ! Generate a second LINT configuration for i386 and amd64 in > ! sys/conf/makeLINT.mk, which includes LINT and sets options VIMAGE > ! so that we will have VIMAGE LINT builds[1]. > ! > ! To avoid hardcoding further kernel configuration names for > ! make universe, split the logic into two parts: > ! - 1st to build worlds and generate kernel configs like LINT. > ! - 2nd to build kernels for a given TARGET architecture correctly > ! finding all newly generated configs, not knowing anything about > ! LINT anymore. (*) > ! > ! (*) If you know better/cleaner/... ways to do this, let me know. > ! > ! Annotation: this also allows one to add more such kernel configs > ! like LINT-NOINET, LINT-NOINET6, .. that I have had for ages now > ! to generate and maintain in a single place. > ! > ! > ! Requested by: jhb [1] > ! Discussed with: jhb, rwatson [1] > ! Reviewed by: > ! MFC After: > ! > Index: Makefile > =================================================================== > --- Makefile (revision 198467) > +++ Makefile (working copy) > @@ -297,10 +297,6 @@ > rm -f ${FAILFILE} > .endif > .for target in ${TARGETS} > -KERNCONFS!= cd ${.CURDIR}/sys/${target}/conf && \ > - find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ > - ! -name DEFAULTS ! -name LINT > -KERNCONFS:= ${KERNCONFS:S/^NOTES$/LINT/} > universe: universe_${target} > .ORDER: universe_prologue universe_${target} universe_epilogue > universe_${target}: > @@ -320,15 +316,7 @@ > (echo "${target} 'make LINT' failed," \ > "check _.${target}.makeLINT for details"| ${MAKEFAIL})) > .endif > -.for kernel in ${KERNCONFS} > - @(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \ > - ${MAKE} ${JFLAG} buildkernel \ > - TARGET=${target} \ > - KERNCONF=${kernel} \ > - > _.${target}.${kernel} 2>&1 || \ > - (echo "${target} ${kernel} kernel failed," \ > - "check _.${target}.${kernel} for details"| ${MAKEFAIL})) > -.endfor > + cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} TARGET=${target} universe_kernels > @echo ">> ${target} completed on `LC_ALL=C date`" > .endfor > universe: universe_epilogue > @@ -345,3 +333,18 @@ > fi > .endif > .endif > + > +universe_kernels: universe_kernels_foo > +TARGET?= ${BUILD_ARCH} > +KERNCONFS!= cd ${.CURDIR}/sys/${TARGET}/conf && \ > + find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ > + ! -name DEFAULTS ! -name NOTES > +KERNCONFS:= ${KERNCONFS} > +universe_kernels_foo: > +.for kernel in ${KERNCONFS} > + @(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \ > + ${MAKE} ${JFLAG} buildkernel TARGET=${TARGET} KERNCONF=${kernel} \ > + > _.${TARGET}.${kernel} 2>&1 || \ > + (echo "${TARGET} ${kernel} kernel failed," \ > + "check _.${TARGET}.${kernel} for details"| ${MAKEFAIL})) > +.endfor Hmm, I'm not sure why you need a universe_kernels_foo target that universe_kernels depends on? Also, I would probably prefer to have universe_kernels come after universe_$target and before universe_epilogue. > Index: sys/conf/makeLINT.mk > =================================================================== > --- sys/conf/makeLINT.mk (revision 198467) > +++ sys/conf/makeLINT.mk (working copy) > @@ -5,7 +5,15 @@ > > clean: > rm -f LINT > +.if ${TARGET} == "amd64" || ${TARGET} == "i386" > + rm -f LINT=VIMAGE > +.endif s/=/-/ BTW, I'm not sure why you would only enable VIMAGE for these two archs rather than doing it for all archs that have a LINT? -- John Baldwin From owner-freebsd-arch@FreeBSD.ORG Mon Oct 26 19:25:04 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B99A106566C; Mon, 26 Oct 2009 19:25:04 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 52AFB8FC0A; Mon, 26 Oct 2009 19:25:04 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id CA66A41C70C; Mon, 26 Oct 2009 20:05:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id 9fEz-mZR9xr9; Mon, 26 Oct 2009 20:05:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 2F67E41C6EA; Mon, 26 Oct 2009 20:05:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id CB6F74448E6; Mon, 26 Oct 2009 19:00:22 +0000 (UTC) Date: Mon, 26 Oct 2009 19:00:22 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: John Baldwin In-Reply-To: <200910260830.25168.jhb@freebsd.org> Message-ID: <20091026185459.U91695@maildrop.int.zabbadoz.net> References: <20091025134226.Q91695@maildrop.int.zabbadoz.net> <200910260830.25168.jhb@freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-arch@freebsd.org Subject: Re: src/Makefile, universe, LINT, VIMAGE, .. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 19:25:04 -0000 On Mon, 26 Oct 2009, John Baldwin wrote: Hi, >> @@ -345,3 +333,18 @@ >> fi >> .endif >> .endif >> + >> +universe_kernels: universe_kernels_foo >> +TARGET?= ${BUILD_ARCH} >> +KERNCONFS!= cd ${.CURDIR}/sys/${TARGET}/conf && \ >> + find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \ >> + ! -name DEFAULTS ! -name NOTES >> +KERNCONFS:= ${KERNCONFS} >> +universe_kernels_foo: >> +.for kernel in ${KERNCONFS} >> + @(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \ >> + ${MAKE} ${JFLAG} buildkernel TARGET=${TARGET} KERNCONF=${kernel} \ >> + > _.${TARGET}.${kernel} 2>&1 || \ >> + (echo "${TARGET} ${kernel} kernel failed," \ >> + "check _.${TARGET}.${kernel} for details"| ${MAKEFAIL})) >> +.endfor > > Hmm, I'm not sure why you need a universe_kernels_foo target that > universe_kernels depends on? This is all about make and the variables after a target and within a target. Whatever else I tried: make complained. If you know the rightbetter solution that works I'll be happy to simplify this and update the patch. It shouldn't be named _foo though;) > Also, I would probably prefer to have > universe_kernels come after universe_$target and before universe_epilogue. I think that should be possible to sneak it in after the the .endfor. >> Index: sys/conf/makeLINT.mk >> =================================================================== >> --- sys/conf/makeLINT.mk (revision 198467) >> +++ sys/conf/makeLINT.mk (working copy) >> @@ -5,7 +5,15 @@ >> >> clean: >> rm -f LINT >> +.if ${TARGET} == "amd64" || ${TARGET} == "i386" >> + rm -f LINT=VIMAGE >> +.endif > > s/=/-/ Yeah, everyone notics that one; it should be fixed in the patch at the URL originally referenced. > BTW, I'm not sure why you would only enable VIMAGE for these two archs rather > than doing it for all archs that have a LINT? Because it'll usually simply not make any sense to build a VIMAGE kernel for embedded platforms like arm, ... Also make universe time increases significantly with any platform; indeed amd64 is the worst now (again). We can talk about the proper set and I had thought of sparc64 as well. Obviously just building it everywhere simplifies things. /bz -- Bjoern A. Zeeb It will not break if you know what you are doing. From owner-freebsd-arch@FreeBSD.ORG Fri Oct 30 19:58:00 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A5091065670 for ; Fri, 30 Oct 2009 19:58:00 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from core.tav.kiev.ua (tavex.colocall.com [62.149.10.42]) by mx1.freebsd.org (Postfix) with ESMTP id 040768FC08 for ; Fri, 30 Oct 2009 19:57:59 +0000 (UTC) Received: from [76.77.86.2] (helo=[10.80.5.136]) by core.tav.kiev.ua with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.52 (FreeBSD)) id 1N3x5P-0007C3-SX for arch@freebsd.org; Fri, 30 Oct 2009 21:24:36 +0200 Message-ID: <4AEB3D63.4080608@bluezbox.com> Date: Fri, 30 Oct 2009 12:24:19 -0700 From: Oleksandr Tymoshenko User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: arch@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Core-Spam-Level: / X-Core-Spam-Report: Spam detection software, running on the system "core.tav.kiev.ua", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Trying to build kld for MIPS I stumbled upon some controversy with LDFLAGS: Through all share/mk/bsd.*.mk files it is consistently used with CC, but in sys/conf/kmod.mk it's used directly with LD and in cobination with flags like -Wl, -foo it causes errors. So is usage of LDFLAGS in sys/conf/kmod.mk correct? [...] Content analysis details: (-0.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.5954] 1.2 AWL AWL: From: address is in the auto white-list Cc: Subject: LDFLAGS usage X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2009 19:58:00 -0000 Trying to build kld for MIPS I stumbled upon some controversy with LDFLAGS: Through all share/mk/bsd.*.mk files it is consistently used with CC, but in sys/conf/kmod.mk it's used directly with LD and in cobination with flags like -Wl,-foo it causes errors. So is usage of LDFLAGS in sys/conf/kmod.mk correct?