Date: Mon, 5 Oct 2009 00:30:35 +0200 From: Olivier Houchard <cognet@ci0.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: freebsd-arm@FreeBSD.org Subject: Re: [patch] Compilation problems in sys/arm/arm/pmap.c when PMAP_DEBUG is defined. Message-ID: <20091004223035.GA72827@ci0.org> In-Reply-To: <20091002155600.2c2f615d.stas@FreeBSD.org> References: <4AC599FC.1070304@tomjudge.com> <20091002155600.2c2f615d.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 02, 2009 at 03:56:00PM +0400, Stanislav Sedov wrote: > On Fri, 02 Oct 2009 06:13:16 +0000 > Tom Judge <tom@tomjudge.com> mentioned: > > > Hi, > > > > I ran into some issues this evening while I was building some kernels > > with PMAP_DEBUG defined. > > > > I have attached a patch that addresses the problems with the DPRINTF > > sections. (The first 2 hunks should probably be ignored). > > > > However there are 2 warnings about unused functions when PMAP_INLINE is > > defined as "". I did not know what the correct fix for this was so I > > defined PMAP_INLINE to __inline even when PMAP_DEBUG was set, which > > seemed to hide the problem again. > > > > Actually, these two functions with PMAP_INLINE prefixes are unused. I > believe we can drop them. > > Olivier, what do you think about the following patch? > Hi Stanislav, Removing pmap_use_l1() is fine, but please just comment pmap_dcache_wbinv_all() for now, and keep pmap_clean_page(), it's here to remember we still write back/invalidate the whole cache in pmap_copy_page() which is suboptimal. Regards, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091004223035.GA72827>