From owner-freebsd-arm@FreeBSD.ORG Mon Dec 28 11:06:55 2009 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 551D31065672 for ; Mon, 28 Dec 2009 11:06:55 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 44AE58FC1B for ; Mon, 28 Dec 2009 11:06:55 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nBSB6tpr079419 for ; Mon, 28 Dec 2009 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nBSB6sVX079417 for freebsd-arm@FreeBSD.org; Mon, 28 Dec 2009 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 28 Dec 2009 11:06:54 GMT Message-Id: <200912281106.nBSB6sVX079417@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-arm@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-arm@FreeBSD.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2009 11:06:55 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o arm/134368 arm [patch] nslu2_led driver for the LEDs on the NSLU2 o arm/134338 arm [patch] Lock GPIO accesses on ixp425 o arm/134092 arm [patch] NSLU.hints contains wrong hints for on board n 3 problems total. From owner-freebsd-arm@FreeBSD.ORG Tue Dec 29 13:53:38 2009 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D534E1065696 for ; Tue, 29 Dec 2009 13:53:38 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com [209.85.220.227]) by mx1.freebsd.org (Postfix) with ESMTP id 657638FC18 for ; Tue, 29 Dec 2009 13:53:38 +0000 (UTC) Received: by fxm27 with SMTP id 27so10807992fxm.3 for ; Tue, 29 Dec 2009 05:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=hyT+gr5VTqijzWfDMUjqT2WnY+li+/k5lZ7EqDjE1XI=; b=ifExq6sqvf4ZlJmWqBl2Y+tWeBbRWVW+ttmPuCxvO+jfrND55rg6WP3PssorQM9ukp noP3h8BE1Jgdr16zdwlFhgYt0oZ+ighXRb06DVS8NVWuZuFuMDoGzUGDeXYaQg3Fx7kA kbFa1d+0r/uTxiX3Av7BEFNgmLULWVv4IaOkk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=IoXLS2b5GOhCjBTDV3o39jXoNNMx8sRUddMroLpIvpREq7lS8T8OXnuelBEx8QE4el fpCZs671buUybXnYumh+lTKGjlKYMlQmhzp6/RgDNY1JX+vL4D6NTfW9PM1lbdChFYce bKKMucGXKj6MMhRl5Ge09b70mrWwfZyxPiGFU= Received: by 10.223.144.195 with SMTP id a3mr10500749fav.103.1262094813851; Tue, 29 Dec 2009 05:53:33 -0800 (PST) Received: from ?10.0.10.2? (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id 13sm4294888fxm.9.2009.12.29.05.53.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 29 Dec 2009 05:53:33 -0800 (PST) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <260bb65e0912250948w6f714367w672a1ebf037fb7f7@mail.gmail.com> Date: Tue, 29 Dec 2009 13:53:31 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <260bb65e0912110627o6b67b399vabaae57477b91023@mail.gmail.com> <260bb65e0912250948w6f714367w672a1ebf037fb7f7@mail.gmail.com> To: Yohanes Nugroho X-Mailer: Apple Mail (2.1077) Cc: freebsd-arm@freebsd.org Subject: Re: CNS11XX FreeBSD port completed X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2009 13:53:39 -0000 Hi, On 25 Dec 2009, at 17:48, Yohanes Nugroho wrote: > Hi, >=20 > To make it easy for others to read the changes I have made, attached > is the diff version against SVN head. There is one change that may be > should not be commited. In vfs_mount.c, I added >=20 > pause("WAIT", hz * 10); >=20 > That line can be removed if the patch from this: >=20 > = http://lists.freebsd.org/pipermail/freebsd-current/2009-October/012361.htm= l >=20 > is applied Some comments: * please read style(9) and try to follow these guidelines on your code * did you forget to add a kernel config file for this board? * I would like for you to reconsider the code that's under C++ comments. = Either remove it or please use ANSI-style /* */ C comments. This is a = style issue. * please add your email to all the files you are adding (like you do on = if_ecereg.h, for example) * econa_machdep.c is a 4-claus BSD license. Can you check if we already = include "This product includes software developed by Brini." on our = documentation/marketing material? * there are some lines that go beyond 80 columns. Can you fix them? * in if_ece.c::poweron(), can't you use bus_read_4 instead of using a = volatile and pointing it to some specific memory address? * please avoid doing in-code variable declarations like "for (int i =3D = 0 ..." * what about the #if 0's ? * do you have the specs of the ethernet controller ? stuff like = "mac_port_config |=3D ((0x1 << 18));" would be better if "18" was a = define with an indication of what the bit actually does. Something like = "mac_port_config |=3D ((0x1 << MAC_PORT_0_DISABLE));" * there are many white lines that you can remove * defines should be like "#define...". This is especially visible = in econa_reg.h The rest looks fine. Thanks! -- Rui Paulo From owner-freebsd-arm@FreeBSD.ORG Tue Dec 29 20:46:50 2009 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF2C51065695 for ; Tue, 29 Dec 2009 20:46:50 +0000 (UTC) (envelope-from tinguely@casselton.net) Received: from casselton.net (casselton.net [63.165.140.2]) by mx1.freebsd.org (Postfix) with ESMTP id 7D0998FC16 for ; Tue, 29 Dec 2009 20:46:50 +0000 (UTC) Received: from casselton.net (localhost [127.0.0.1]) by casselton.net (8.14.3/8.14.3) with ESMTP id nBTKknr5076661 for ; Tue, 29 Dec 2009 14:46:49 -0600 (CST) (envelope-from tinguely@casselton.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=casselton.net; s=ccnMail; t=1262119609; bh=Tcue6lC1htJMmuObILjc42Ww9jn+PswXq8F8gPEr5N4=; h=Date:From:Message-Id:To:Subject; b=WhgjLE+vuesRD6QFMRsaxOiJWwkch1E17xkxHdEquh2xymPbOxCzK5kVsUdCnHAq7 yE8Mu8xsVUPM2BsFlk2fsLXSm3YXYTPvTawvxzaXdw27dQyU1c2x3JmaLCv+xjpz71 2Yug5boDm2WEyYyU6GZFWduoRfP46EgV5DSYeuGA= Received: (from tinguely@localhost) by casselton.net (8.14.3/8.14.2/Submit) id nBTKknjI076659 for freebsd-arm@freebsd.org; Tue, 29 Dec 2009 14:46:49 -0600 (CST) (envelope-from tinguely) Date: Tue, 29 Dec 2009 14:46:49 -0600 (CST) From: Mark Tinguely Message-Id: <200912292046.nBTKknjI076659@casselton.net> To: freebsd-arm@freebsd.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.2 (casselton.net [127.0.0.1]); Tue, 29 Dec 2009 14:46:49 -0600 (CST) Subject: cpu_throw()/cpu_switch() and L2 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2009 20:46:50 -0000 FYI esp Sheeva users with corruption issues: I was looking at my new swtch.S routine and noticed that cpu_throw() and cpu_switch() do not wbinv the level 2 cache. For the majority of the ARMv5 processors this does not do anything. This could effect the Sheeva. Looking at the Sheeva "setttb" routine, wbinv both level 1 and level 2 caches, which it needs to to if the level 2 cache is virtually indexed. In my opinion, we should remove the l2 cache operation calls because if an architecture uses a virtual indexed level 2 caches, then the level cache will need to wb/inv everytime the level 1 cache is wb/inv; It makes more sense to me to do them together. One advantage is we would not miss cache flushing situation like the ones above. The caches in the newer architectures are PIPT, and don't need to be flushed for context changes, and pages sharing, etc. --Mark. From owner-freebsd-arm@FreeBSD.ORG Wed Dec 30 11:03:51 2009 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D4EB106566C; Wed, 30 Dec 2009 11:03:51 +0000 (UTC) (envelope-from gary.jennejohn@freenet.de) Received: from mout1.freenet.de (mout1.freenet.de [IPv6:2001:748:100:40::2:3]) by mx1.freebsd.org (Postfix) with ESMTP id 2270E8FC18; Wed, 30 Dec 2009 11:03:51 +0000 (UTC) Received: from [195.4.92.13] (helo=3.mx.freenet.de) by mout1.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.70 #1) id 1NPwLF-0004kN-VE; Wed, 30 Dec 2009 12:03:49 +0100 Received: from p57ae2cef.dip0.t-ipconnect.de ([87.174.44.239]:43051 helo=ernst.jennejohn.org) by 3.mx.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.69 #94) id 1NPwLF-00017k-HB; Wed, 30 Dec 2009 12:03:49 +0100 Date: Wed, 30 Dec 2009 12:03:47 +0100 From: Gary Jennejohn To: Rui Paulo Message-ID: <20091230120347.6472bd09@ernst.jennejohn.org> In-Reply-To: References: <260bb65e0912110627o6b67b399vabaae57477b91023@mail.gmail.com> <260bb65e0912250948w6f714367w672a1ebf037fb7f7@mail.gmail.com> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.2; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-arm@freebsd.org Subject: Re: CNS11XX FreeBSD port completed X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gary.jennejohn@freenet.de List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2009 11:03:51 -0000 On Tue, 29 Dec 2009 13:53:31 +0000 Rui Paulo wrote: > * I would like for you to reconsider the code that's under C++ comments. Either remove it or please use ANSI-style /* */ C comments. This is a style issue. > There are unfortunately already thousands of lines of code in the kernel which use // for comments :( --- Gary Jennejohn From owner-freebsd-arm@FreeBSD.ORG Wed Dec 30 14:32:26 2009 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91D6B1065670 for ; Wed, 30 Dec 2009 14:32:26 +0000 (UTC) (envelope-from tinguely@casselton.net) Received: from casselton.net (casselton.net [63.165.140.2]) by mx1.freebsd.org (Postfix) with ESMTP id 500718FC0A for ; Wed, 30 Dec 2009 14:32:26 +0000 (UTC) Received: from casselton.net (localhost [127.0.0.1]) by casselton.net (8.14.3/8.14.3) with ESMTP id nBUEWPoO021255 for ; Wed, 30 Dec 2009 08:32:25 -0600 (CST) (envelope-from tinguely@casselton.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=casselton.net; s=ccnMail; t=1262183545; bh=U5ZVRw5CqfskK4OcWBk2eHaZXVOJUDZ7oGwGJrrOF4k=; h=Date:From:Message-Id:To:Subject:In-Reply-To; b=WCxI3bx82soJQXXFwtkF0Kq9DpOgboWFbXWcH45q80FJMRbJ4ogJWoxeI/7hKNs93 ikQoDydcVg+ZL+6qcBPyY59IWCTnD28ftVJSvTpGTLUxLRd8t1sbCT6yhu7uqt47fY ww8nqBSebcxfhBoJEGfcPhdZ618VPVojcrXnSBMM= Received: (from tinguely@localhost) by casselton.net (8.14.3/8.14.2/Submit) id nBUEWPVu021254 for freebsd-arm@freebsd.org; Wed, 30 Dec 2009 08:32:25 -0600 (CST) (envelope-from tinguely) Date: Wed, 30 Dec 2009 08:32:25 -0600 (CST) From: Mark Tinguely Message-Id: <200912301432.nBUEWPVu021254@casselton.net> To: freebsd-arm@freebsd.org In-Reply-To: <200912292046.nBTKknjI076659@casselton.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.2 (casselton.net [127.0.0.1]); Wed, 30 Dec 2009 08:32:25 -0600 (CST) Subject: Re: cpu_throw()/cpu_switch() and L2 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2009 14:32:26 -0000 > FYI esp Sheeva users with corruption issues: > > I was looking at my new swtch.S routine and noticed that cpu_throw() > and cpu_switch() do not wbinv the level 2 cache. For the majority of > the ARMv5 processors this does not do anything. This could effect the > Sheeva. Looking at the Sheeva "setttb" routine, wbinv both level 1 and > level 2 caches, which it needs to to if the level 2 cache is virtually > indexed. Sorry, it was purposely removed in Oct 2008 with Revision 18395. --Mark.