From owner-freebsd-bluetooth@FreeBSD.ORG Mon Oct 26 17:43:36 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 024951065679 for ; Mon, 26 Oct 2009 17:43:36 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from mail-px0-f190.google.com (mail-px0-f190.google.com [209.85.216.190]) by mx1.freebsd.org (Postfix) with ESMTP id C87378FC12 for ; Mon, 26 Oct 2009 17:43:35 +0000 (UTC) Received: by pxi28 with SMTP id 28so3308012pxi.7 for ; Mon, 26 Oct 2009 10:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=VupxLr5Rf5H0FK6EXfzlvDneH2p95BXnSB9WDHXbzvA=; b=ZukKtCjxOYpE7JJqVCQZTnLOlxinu/wNRbIiFdgwIglyHuF3ioNekZ/2XM5JSJ3wvP D9UBn+ObzMUs7ulenBnJtZaGZfESg8s4N5Q147fZMOf4taq5qClIbXgwDqfcXGJuu8Or jiLEejoGt+aVza/NaSoz2I6NngmzgvZtM4p54= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=lNoiW68gRMC/z+Xu//BVAANlKwKQhDRdA0lr51v6TUCR3ARKURCCm/Bxivv/TU0waL R5Zh+/sABOLdu1UeQgJfwby52TK+zCR41awvBnD53sdBILl6CxlzrrlOBGMRCT0ZVgwE E7CrXvbdrDhh/OK0iSBA+Y1Q92UDMUVaQmp00= MIME-Version: 1.0 Received: by 10.114.165.36 with SMTP id n36mr19914166wae.116.1256579015527; Mon, 26 Oct 2009 10:43:35 -0700 (PDT) In-Reply-To: References: <1254763597.419838.805.nullmailer@galant.ukfsn.org> Date: Mon, 26 Oct 2009 10:43:35 -0700 Message-ID: From: Maksim Yevmenkin To: Masoom Shaikh Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 17:43:36 -0000 On Tue, Oct 6, 2009 at 8:48 AM, Masoom Shaikh wrote: > > > On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert wrote: >> >> On Mon, 5 Oct 2009, Masoom Shaikh wrote: >> >> > what i am requesting is just variable name change ;-) my tree is at >> > revision 197571, thus the patch i am presenting is also generated >> > against it reject this if you want patch against latest revision >> > >> > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for >> > device filter to maintain uniformity renamed third argument from 'old' >> > to 'dfold'. >> >> style(9) mentions that for kernel include files exposed to userland >> (technically, this is always in userland but perhaps the same rules apply) >> the prototype tag arguments should be made safe, eg starting with a _ >> perhaps for much this reason.. >> >> so, my suggestion would be to use _new and _old etc.. >> >> iain >> >> (or, just don't use them, they are not especially required :) >> > so this shall work > i just renamed bt_devfilter() variable names, because it was the one which > caused trouble > will someone commit this ? i just committed fix for this. thanks max