From owner-freebsd-geom@FreeBSD.ORG Sun Jul 19 13:00:19 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 199F31065696 for ; Sun, 19 Jul 2009 13:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CB17D8FC23 for ; Sun, 19 Jul 2009 13:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6JD0FP7035903 for ; Sun, 19 Jul 2009 13:00:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6JD0FL4035902; Sun, 19 Jul 2009 13:00:15 GMT (envelope-from gnats) Date: Sun, 19 Jul 2009 13:00:15 GMT Message-Id: <200907191300.n6JD0FL4035902@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/135874: commit references a PR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2009 13:00:23 -0000 The following reply was made to PR kern/135874; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/135874: commit references a PR Date: Sun, 19 Jul 2009 12:57:22 +0000 (UTC) Author: lulf Date: Sun Jul 19 12:57:10 2009 New Revision: 195759 URL: http://svn.freebsd.org/changeset/base/195759 Log: MFC r194924: - Apply the same naming rules of LVM names as done in the LVM code itself. PR: kern/135874 Modified: stable/7/sys/ (props changed) stable/7/sys/contrib/pf/ (props changed) stable/7/sys/geom/linux_lvm/g_linux_lvm.c Modified: stable/7/sys/geom/linux_lvm/g_linux_lvm.c ============================================================================== --- stable/7/sys/geom/linux_lvm/g_linux_lvm.c Sat Jul 18 21:50:53 2009 (r195758) +++ stable/7/sys/geom/linux_lvm/g_linux_lvm.c Sun Jul 19 12:57:10 2009 (r195759) @@ -826,14 +826,6 @@ llvm_md_decode(const u_char *data, struc return (0); } -#define GRAB_NAME(tok, name, len) \ - len = 0; \ - while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len])) && \ - len < G_LLVM_NAMELEN - 1) \ - len++; \ - bcopy(tok, name, len); \ - name[len] = '\0'; - #define GRAB_INT(key, tok1, tok2, v) \ if (tok1 && tok2 && strncmp(tok1, key, sizeof(key)) == 0) { \ v = strtol(tok2, &tok1, 10); \ @@ -864,6 +856,27 @@ llvm_md_decode(const u_char *data, struc break; \ } +static size_t +llvm_grab_name(char *name, const char *tok) +{ + size_t len; + + len = 0; + if (tok == NULL) + return (0); + if (tok[0] == '-') + return (0); + if (strcmp(tok, ".") == 0 || strcmp(tok, "..") == 0) + return (0); + while (tok[len] && (isalpha(tok[len]) || isdigit(tok[len]) || + tok[len] == '.' || tok[len] == '_' || tok[len] == '-' || + tok[len] == '+') && len < G_LLVM_NAMELEN - 1) + len++; + bcopy(tok, name, len); + name[len] = '\0'; + return (len); +} + static int llvm_textconf_decode(u_char *data, int buflen, struct g_llvm_metadata *md) { @@ -872,7 +885,7 @@ llvm_textconf_decode(u_char *data, int b char *tok, *v; char name[G_LLVM_NAMELEN]; char uuid[G_LLVM_UUIDLEN]; - int len; + size_t len; if (buf == NULL || *buf == '\0') return (EINVAL); @@ -880,7 +893,7 @@ llvm_textconf_decode(u_char *data, int b tok = strsep(&buf, "\n"); if (tok == NULL) return (EINVAL); - GRAB_NAME(tok, name, len); + len = llvm_grab_name(name, tok); if (len == 0) return (EINVAL); @@ -970,7 +983,7 @@ llvm_textconf_decode_pv(char **buf, char { struct g_llvm_pv *pv; char *v; - int len; + size_t len; if (*buf == NULL || **buf == '\0') return (EINVAL); @@ -983,7 +996,7 @@ llvm_textconf_decode_pv(char **buf, char len = 0; if (tok == NULL) goto bad; - GRAB_NAME(tok, pv->pv_name, len); + len = llvm_grab_name(pv->pv_name, tok); if (len == 0) goto bad; @@ -1024,7 +1037,7 @@ llvm_textconf_decode_lv(char **buf, char struct g_llvm_lv *lv; struct g_llvm_segment *sg; char *v; - int len; + size_t len; if (*buf == NULL || **buf == '\0') return (EINVAL); @@ -1036,10 +1049,9 @@ llvm_textconf_decode_lv(char **buf, char lv->lv_vg = vg; LIST_INIT(&lv->lv_segs); - len = 0; if (tok == NULL) goto bad; - GRAB_NAME(tok, lv->lv_name, len); + len = llvm_grab_name(lv->lv_name, tok); if (len == 0) goto bad; @@ -1162,7 +1174,6 @@ bad: free(sg, M_GLLVM); return (-1); } -#undef GRAB_NAME #undef GRAB_INT #undef GRAB_STR #undef SPLIT _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-geom@FreeBSD.ORG Mon Jul 20 11:06:55 2009 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F6F81065672 for ; Mon, 20 Jul 2009 11:06:55 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8D27F8FC28 for ; Mon, 20 Jul 2009 11:06:55 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6KB6tpn002280 for ; Mon, 20 Jul 2009 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6KB6sFY002276 for freebsd-geom@FreeBSD.org; Mon, 20 Jul 2009 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 20 Jul 2009 11:06:54 GMT Message-Id: <200907201106.n6KB6sFY002276@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2009 11:06:56 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/136467 geom [geom] glabel(8) destroys access to GEOM tree if volum o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/135874 geom [geom] [patch] geom_linux_lvm misses newer fedora defa o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/134044 geom [geom] gmirror(8) overwrites fs with stale data from r o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/132273 geom glabel(8): [patch] failing on journaled partition o kern/132242 geom [gmirror] gmirror.ko fails to fully initialize o kern/131353 geom [geom] gjournal(8) kernel lock o kern/131037 geom [geli] Unable to create disklabel on .eli-Device p docs/130548 geom [patch] gjournal(8) man page is missing sysctls o kern/130528 geom gjournal fsck during boot o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/126902 geom [geom] geom_label: kernel panic during install boot o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/124294 geom [geom] gmirror(8) have inappropriate logic when workin o kern/124130 geom [gmirror] [usb] gmirror fails to start usb devices tha o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123630 geom [patch] [gmirror] gmirror doesnt allow the original dr o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de f kern/122415 geom [geom] UFS labels are being constantly created and rem o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121559 geom [patch] [geom] geom label class allows to create inacc o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120231 geom [geom] GEOM_CONCAT error adding second drive o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/120044 geom [msdosfs] [geom] incorrect MSDOSFS label fries adminis o kern/120021 geom [geom] [panic] net-p2p/qbittorrent crashes system when o kern/119743 geom [geom] geom label for cds is keeped after dismount and o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile o kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113885 geom [gmirror] [patch] improved gmirror balance algorithm o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back p bin/110705 geom gmirror(8) control utility does not exit with correct o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/104389 geom [geom] [patch] sys/geom/geom_dump.c doesn't encode XML o kern/98034 geom [geom] dereference of NULL pointer in acd_geom_detach o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry a kern/89660 geom [vinum] [patch] [panic] due to g_malloc returning null o kern/89546 geom [geom] GEOM error o kern/88601 geom [geli] geli cause kernel panic under heavy disk usage o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. s kern/73177 geom kldload geom_* causes panic due to memory exhaustion 59 problems total. From owner-freebsd-geom@FreeBSD.ORG Tue Jul 21 07:50:09 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0AEC010656AC for ; Tue, 21 Jul 2009 07:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D7F478FC12 for ; Tue, 21 Jul 2009 07:50:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6L7o7F0000584 for ; Tue, 21 Jul 2009 07:50:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6L7o7MC000583; Tue, 21 Jul 2009 07:50:07 GMT (envelope-from gnats) Date: Tue, 21 Jul 2009 07:50:07 GMT Message-Id: <200907210750.n6L7o7MC000583@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: freebsdpr Cc: Subject: Re: kern/113885: [gmirror] [patch] improved gmirror balance algorithm X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsdpr List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 07:50:19 -0000 The following reply was made to PR kern/113885; it has been noted by GNATS. From: freebsdpr To: bug-followup@FreeBSD.org Cc: freebsdpr Subject: Re: kern/113885: [gmirror] [patch] improved gmirror balance algorithm Date: Tue, 21 Jul 2009 17:45:37 +1000 (EST) I was also surprised to discover that gmirror, regardless of the algorithm used, does not seem to offer either random or sequential read performance any better than a single drive. I have a new SATA backplane which shows individual drive activity indicators - with these you can easily see that the "load" algorithm seems to be selecting (and staying on) only a single drive at a time, for anywhere between 0.1 - 1 seconds. Some simple testing confirmed that there's no discernable read performance benefit between 1 or >1 drives - so much for my 4 drive RAID1 idea! In comparison, a 5 drive graid3 array offers a sequential read speed of nearly 4 times a single drive... with read verify ON. ---- Onto the "load" patch above - it doesn't seem to work for me. I thought it may have been because I had 4 drives in the array, but even after dropping back to 2 it still only reads from a *single* drive. Any ideas? I'm using 7.1R-amd64. Geom name: db0 State: COMPLETE Components: 2 Balance: load <--- *** From owner-freebsd-geom@FreeBSD.ORG Tue Jul 21 19:30:56 2009 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32F6F106564A for ; Tue, 21 Jul 2009 19:30:56 +0000 (UTC) (envelope-from naeem_jarral@yahoo.com) Received: from web81102.mail.mud.yahoo.com (web81102.mail.mud.yahoo.com [68.142.199.94]) by mx1.freebsd.org (Postfix) with SMTP id E50948FC1F for ; Tue, 21 Jul 2009 19:30:55 +0000 (UTC) (envelope-from naeem_jarral@yahoo.com) Received: (qmail 79526 invoked by uid 60001); 21 Jul 2009 19:04:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1248203054; bh=wlqWe9S/zSkoml7PeLCxU+tey2w4DMHdEh83dhP7tkk=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=ARKrY7qs4vA0j9C4daRM/Eq+GtK5C8/6oCSfweQGpPP4XGsBNoddsEu39VI1P2vgXRsK8CxKASRspla2XZDrufquZUwEpd4YjxxVwkppKsKP3e16YtIxa9I2283Qu2gpJG2+3WKiXzHYOYxl7P0W7dUEMJ1LMvAmCQUDavLEFh8= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=bqb4Tv13F7VDLjbA9LEgVxv1/Qpc3HLhjyN14TdYfDGcebP72Ei5LyfCsBdUs0O4Pymx/d3iW8njQmm6qiPzIvrJJjqcfPk8mQggh2HVVgrJTugBUafI2dim8mRi4faXd6+NA0Pn9OmOfKx6ijMdCis4R9qv1hVtAuyuIgj0VrQ=; Message-ID: <937396.78922.qm@web81102.mail.mud.yahoo.com> X-YMail-OSG: GjTlT_gVM1nHUcYV4p6koVFnMaWDOUhgsb1kjrk2flzb6VEEcOPmT98xj.xwUVIwjfWm30HiBCRyjduJ3KcND8jJlWloUmJy68a.FVzcDy0DoULcfkvVniLYfgsq2cl_8hDK1oDjJRVTu93w8yxTMxPa8keKrXI6OyLLxl26NsXG_F5kL8T1Nm1G0rJlSrdrcOKOTz5p3zPKZ7NazlbYFm32JRk.Ribpr8YAgYgJCo5IsHna8DLwcEnIq1tT2IgxH4BGpOB_7thgyY3Ad57QUM1LpG8LqEOM6pgjpMbqL79gzURu0fdV3cqbML0YUA2FHMHxdg-- Received: from [134.134.139.71] by web81102.mail.mud.yahoo.com via HTTP; Tue, 21 Jul 2009 12:04:14 PDT X-Mailer: YahooMailRC/1357.22 YahooMailWebService/0.7.289.10 Date: Tue, 21 Jul 2009 12:04:14 -0700 (PDT) From: Naeem Afzal To: freebsd-geom@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: taking account of bio_resid when b_maxsize is greater than bio_length X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 19:30:56 -0000 Hi, I am writing a disk driver which can only read maximum of 0x1000 bytes at a time, so d_maxsize = 0x1000. If the application tries to read more than that say 0x3000 and current bio_offset pointer is set to say 0xe00, driver can write only 0x200 (to stay within 0x1000 window), that means it will set the bio_resid=0xe00 as the request from OS will be 0x1000 (d_maxsize). Now subsequent OS request shuold be at 0x1000, but it was returning 0x1e00 as it does not count for bio_resid and assumes that maximum write happened. Could someone explain if my assumption is correct that it needs to take care of bio_resid? regards naeem (FreeBSD 7.1) /usr/src/sys/geom/geom_disk.c static void g_disk_start(struct bio *bp) { struct bio *bp2, *bp3; struct disk *dp; int error; off_t off; .... /* fall-through */ case BIO_READ: case BIO_WRITE: off = 0; bp3 = NULL; bp2 = g_clone_bio(bp); if (bp2 == NULL) { error = ENOMEM; break; } do { bp2->bio_offset += off; bp2->bio_length -= off; bp2->bio_data += off; if (bp2->bio_length > dp->d_maxsize) { /* * XXX: If we have a stripesize we should really * use it here. */ bp2->bio_length = dp->d_maxsize; off += dp->d_maxsize; /* * To avoid a race, we need to grab the next bio * before we schedule this one. See "notes". */ bp3 = g_clone_bio(bp); if (bp3 == NULL) bp->bio_error = ENOMEM; } bp2->bio_done = g_disk_done; bp2->bio_pblkno = bp2->bio_offset / dp->d_sectorsize; bp2->bio_bcount = bp2->bio_length; bp2->bio_disk = dp; devstat_start_transaction_bio(dp->d_devstat, bp2); g_disk_lock_giant(dp); dp->d_strategy(bp2); g_disk_unlock_giant(dp); #if 1 // I belive this line is needed to account for bio_resid?? off -= bp2->bio_resid; #endif From owner-freebsd-geom@FreeBSD.ORG Wed Jul 22 18:05:33 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC6D51065719; Wed, 22 Jul 2009 18:05:33 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 91D9E8FC15; Wed, 22 Jul 2009 18:05:33 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from freefall.freebsd.org (lulf@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6MI5Xq2090462; Wed, 22 Jul 2009 18:05:33 GMT (envelope-from lulf@freefall.freebsd.org) Received: (from lulf@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6MI5Xmv090458; Wed, 22 Jul 2009 18:05:33 GMT (envelope-from lulf) Date: Wed, 22 Jul 2009 18:05:33 GMT Message-Id: <200907221805.n6MI5Xmv090458@freefall.freebsd.org> To: pete@altadena.net, lulf@FreeBSD.org, freebsd-geom@FreeBSD.org From: lulf@FreeBSD.org Cc: Subject: Re: kern/135874: [geom] [patch] geom_linux_lvm misses newer fedora defaults X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 18:05:34 -0000 Synopsis: [geom] [patch] geom_linux_lvm misses newer fedora defaults State-Changed-From-To: open->closed State-Changed-By: lulf State-Changed-When: Wed Jul 22 18:05:09 UTC 2009 State-Changed-Why: - Fixed in both HEAD and RELENG_7. http://www.freebsd.org/cgi/query-pr.cgi?pr=135874 From owner-freebsd-geom@FreeBSD.ORG Thu Jul 23 09:50:03 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D790106564A for ; Thu, 23 Jul 2009 09:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3027C8FC0A for ; Thu, 23 Jul 2009 09:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6N9o22P062828 for ; Thu, 23 Jul 2009 09:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6N9o2Pd062827; Thu, 23 Jul 2009 09:50:02 GMT (envelope-from gnats) Date: Thu, 23 Jul 2009 09:50:02 GMT Message-Id: <200907230950.n6N9o2Pd062827@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Ralf Wenk Cc: Subject: Re: kern/136467: [geom] glabel(8) destroys access to GEOM tree if volume label contains non ASCII characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ralf Wenk List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 09:50:03 -0000 The following reply was made to PR kern/136467; it has been noted by GNATS. From: Ralf Wenk To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/136467: [geom] glabel(8) destroys access to GEOM tree if volume label contains non ASCII characters Date: Thu, 23 Jul 2009 10:24:44 +0200 > Would you be happy with a sysctl knob that controls whether to interpret > all labels as UTF-8 or to strip out all 8-bit characters, which would by > default be set to "interpret as UTF-8"? Yes, that would be a nice solution. From owner-freebsd-geom@FreeBSD.ORG Thu Jul 23 11:30:03 2009 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93039106568C for ; Thu, 23 Jul 2009 11:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 803DB8FC17 for ; Thu, 23 Jul 2009 11:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6NBU3Bc045069 for ; Thu, 23 Jul 2009 11:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6NBU3dB045066; Thu, 23 Jul 2009 11:30:03 GMT (envelope-from gnats) Date: Thu, 23 Jul 2009 11:30:03 GMT Message-Id: <200907231130.n6NBU3dB045066@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Jaakko Heinonen Cc: Subject: Re: kern/136467: [geom] glabel(8) destroys access to GEOM tree if volume label contains non ASCII characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jaakko Heinonen List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 11:30:04 -0000 The following reply was made to PR kern/136467; it has been noted by GNATS. From: Jaakko Heinonen To: Ivan Voras Cc: bug-followup@freebsd.org, IZ-FreeBSD0902@hs-karlsruhe.de Subject: Re: kern/136467: [geom] glabel(8) destroys access to GEOM tree if volume label contains non ASCII characters Date: Thu, 23 Jul 2009 14:26:16 +0300 Hi, This PR is a duplicate of kern/104389 and kern/120044. On 2009-07-09, Ivan Voras wrote: > Would you be happy with a sysctl knob that controls whether to interpret > all labels as UTF-8 or to strip out all 8-bit characters, which would by > default be set to "interpret as UTF-8"? You may already know this but it's not enough to strip 8-bit characters but all characters unsafe for XML output need to be handled. There are more details in kern/104389. -- Jaakko