From owner-freebsd-rc@FreeBSD.ORG Sun Jul 26 12:00:07 2009 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D29410656C8 for ; Sun, 26 Jul 2009 12:00:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6CF4B8FC16 for ; Sun, 26 Jul 2009 12:00:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6QC07PQ014512 for ; Sun, 26 Jul 2009 12:00:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6QC07fd014511; Sun, 26 Jul 2009 12:00:07 GMT (envelope-from gnats) Date: Sun, 26 Jul 2009 12:00:07 GMT Message-Id: <200907261200.n6QC07fd014511@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Thomas Backman Cc: Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Thomas Backman List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 12:00:07 -0000 The following reply was made to PR conf/120194; it has been noted by GNATS. From: Thomas Backman To: bug-followup@FreeBSD.org, freebsd-rc@freebsd.org Cc: Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Date: Sun, 26 Jul 2009 13:49:42 +0200 This bug is still relevant and unfixed as of 8.0-BETA2, although I ran into it by being unable to mount ZVOLs using fstab, since /dev/zvol is populated after mountcritlocal runs. My fix was to move ZFS to before mountcritlocal, since the root is already mounted R/W, but I suppose this fix is even better since it solves the fsck problem as well, which I haven't ran in to yet. It would be nice to see this easy fix implemented! Regards, Thomas From owner-freebsd-rc@FreeBSD.ORG Sun Jul 26 12:07:18 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92A56106567C for ; Sun, 26 Jul 2009 12:07:18 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 512818FC1F for ; Sun, 26 Jul 2009 12:07:17 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from c83-253-252-234.bredband.comhem.se ([83.253.252.234]:47926 helo=mx.exscape.org) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1MV2Ec-0006MI-5C; Sun, 26 Jul 2009 13:49:48 +0200 Received: from [192.168.1.5] (macbookpro [192.168.1.5]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx.exscape.org (Postfix) with ESMTPSA id B3CDA446D5; Sun, 26 Jul 2009 13:49:44 +0200 (CEST) Message-Id: From: Thomas Backman To: bug-followup@FreeBSD.org, freebsd-rc@freebsd.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sun, 26 Jul 2009 13:49:42 +0200 X-Mailer: Apple Mail (2.935.3) X-Originating-IP: 83.253.252.234 X-Scan-Result: No virus found in message 1MV2Ec-0006MI-5C. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1MV2Ec-0006MI-5C 94fb537d907369e7ac856dffb02f0d70 Cc: Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 12:07:19 -0000 This bug is still relevant and unfixed as of 8.0-BETA2, although I ran into it by being unable to mount ZVOLs using fstab, since /dev/zvol is populated after mountcritlocal runs. My fix was to move ZFS to before mountcritlocal, since the root is already mounted R/W, but I suppose this fix is even better since it solves the fsck problem as well, which I haven't ran in to yet. It would be nice to see this easy fix implemented! Regards, Thomas From owner-freebsd-rc@FreeBSD.ORG Mon Jul 27 11:07:01 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D58741065673 for ; Mon, 27 Jul 2009 11:07:01 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B8F418FC13 for ; Mon, 27 Jul 2009 11:07:01 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6RB71u9019083 for ; Mon, 27 Jul 2009 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6RB71h5019079 for freebsd-rc@FreeBSD.org; Mon, 27 Jul 2009 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 27 Jul 2009 11:07:01 GMT Message-Id: <200907271107.n6RB71h5019079@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2009 11:07:02 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 59 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Jul 27 14:47:19 2009 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9452B1065673; Mon, 27 Jul 2009 14:47:19 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6A0128FC2E; Mon, 27 Jul 2009 14:47:19 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from freefall.freebsd.org (pjd@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6RElJ8c094676; Mon, 27 Jul 2009 14:47:19 GMT (envelope-from pjd@freefall.freebsd.org) Received: (from pjd@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6RElJV7094672; Mon, 27 Jul 2009 14:47:19 GMT (envelope-from pjd) Date: Mon, 27 Jul 2009 14:47:19 GMT Message-Id: <200907271447.n6RElJV7094672@freefall.freebsd.org> To: pjd@FreeBSD.org, freebsd-rc@FreeBSD.org, pjd@FreeBSD.org From: pjd@FreeBSD.org Cc: Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2009 14:47:19 -0000 Synopsis: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Responsible-Changed-From-To: freebsd-rc->pjd Responsible-Changed-By: pjd Responsible-Changed-When: pon 27 lip 14:46:39 2009 UTC Responsible-Changed-Why: I'll take this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=120194 From owner-freebsd-rc@FreeBSD.ORG Mon Jul 27 15:17:26 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E9C2106564A for ; Mon, 27 Jul 2009 15:17:26 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id A890B8FC18 for ; Mon, 27 Jul 2009 15:17:25 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 6D5CD45D8D; Mon, 27 Jul 2009 16:49:18 +0200 (CEST) Received: from localhost (pjd-w.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 7FC7745CAC; Mon, 27 Jul 2009 16:49:13 +0200 (CEST) Date: Mon, 27 Jul 2009 16:49:38 +0200 From: Pawel Jakub Dawidek To: Thomas Backman Message-ID: <20090727144938.GK3144@garage.freebsd.pl> References: <200907261200.n6QC07fd014511@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X0cz4bGbQuRbxrVl" Content-Disposition: inline In-Reply-To: <200907261200.n6QC07fd014511@freefall.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-rc@FreeBSD.org Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2009 15:17:26 -0000 --X0cz4bGbQuRbxrVl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 26, 2009 at 12:00:07PM +0000, Thomas Backman wrote: > The following reply was made to PR conf/120194; it has been noted by GNAT= S. >=20 > From: Thomas Backman > To: bug-followup@FreeBSD.org, > freebsd-rc@freebsd.org > Cc: =20 > Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd a= t boot > Date: Sun, 26 Jul 2009 13:49:42 +0200 >=20 > This bug is still relevant and unfixed as of 8.0-BETA2, although I ran = =20 > into it by being unable to mount ZVOLs using fstab, since /dev/zvol is = =20 > populated after mountcritlocal runs. > My fix was to move ZFS to before mountcritlocal, since the root is =20 > already mounted R/W, but I suppose this fix is even better since it =20 > solves the fsck problem as well, which I haven't ran in to yet. > It would be nice to see this easy fix implemented! The problem with proposed patch is that it moves hostid script to before root is mounted read-write and hostid can create /etc/hostid file. Try this patch instead: http://people.freebsd.org/~pjd/patches/zvol_fsck.patch It splits hostid generation from storing it. Now ZVOLs can be initialized before fsck runs. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --X0cz4bGbQuRbxrVl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKbb6CForvXbEpPzQRAsOdAKC2qbhRZNpaEgUlQLoRVhFDHFLqogCfc3sp QXkoKnohZTd8xvyRrRs3FNM= =tpP9 -----END PGP SIGNATURE----- --X0cz4bGbQuRbxrVl-- From owner-freebsd-rc@FreeBSD.ORG Tue Jul 28 13:29:21 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4E3F106566C for ; Tue, 28 Jul 2009 13:29:21 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 13D9A8FC12 for ; Tue, 28 Jul 2009 13:29:20 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 87D2745C8C; Tue, 28 Jul 2009 15:29:18 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id A5FFC45685 for ; Tue, 28 Jul 2009 15:29:13 +0200 (CEST) Date: Tue, 28 Jul 2009 15:29:38 +0200 From: Pawel Jakub Dawidek To: freebsd-rc@FreeBSD.org Message-ID: <20090728132938.GG1690@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gvF4niNJ+uBMJnEh" Content-Disposition: inline User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Subject: Review request. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 13:29:22 -0000 --gvF4niNJ+uBMJnEh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi. I'm looking for a review of the following: Currently there is a problem with fscking UFS file systems created on top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot find devfs entry and aborts. We cannot simply move rc.d/zfs before rc.d/fsck, because we first want kern.hostid to be configured (by rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks which are in use by different systems (eg. in SAN/NAS environment). We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on first system start stores generated kern.hostuuid in /etc/hostid file, so it needs root file system to be mounted read-write. =20 My fix is to split rc.d/hostid so that rc.d/hostid (which will now run before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't touch root file system and rc.d/hostid_save (which is run after rc.d/root) and only creates /etc/hostid file. =20 With that in place, I can move ZVOL initialization to dedicated rc.d/zvol script which runs before rc.d/fsck. The patch is here: http://people.freebsd.org/~pjd/patches/zvol_fsck.patch =20 --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gvF4niNJ+uBMJnEh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKbv1CForvXbEpPzQRAryyAKDcRduXC+oXt0wIrYnlIOQyMZdMnQCgszeH Qe+W1c2Kf9JTIS5A0UX7hgg= =1xuL -----END PGP SIGNATURE----- --gvF4niNJ+uBMJnEh-- From owner-freebsd-rc@FreeBSD.ORG Tue Jul 28 15:35:49 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69B231065673; Tue, 28 Jul 2009 15:35:49 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (cl-162.ewr-01.us.sixxs.net [IPv6:2001:4830:1200:a1::2]) by mx1.freebsd.org (Postfix) with ESMTP id CBED08FC23; Tue, 28 Jul 2009 15:35:48 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.3/8.14.3) with ESMTP id n6SFZxJ9073604; Tue, 28 Jul 2009 10:35:59 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.3/8.14.3/Submit) id n6SFZxdF073603; Tue, 28 Jul 2009 10:35:59 -0500 (CDT) (envelope-from brooks) Date: Tue, 28 Jul 2009 10:35:59 -0500 From: Brooks Davis To: Pawel Jakub Dawidek Message-ID: <20090728153559.GB72994@lor.one-eyed-alien.net> References: <20090728132938.GG1690@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <20090728132938.GG1690@garage.freebsd.pl> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Tue, 28 Jul 2009 10:35:59 -0500 (CDT) Cc: freebsd-rc@freebsd.org Subject: Re: Review request. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 15:35:49 -0000 --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 28, 2009 at 03:29:38PM +0200, Pawel Jakub Dawidek wrote: > Hi. >=20 > I'm looking for a review of the following: >=20 > Currently there is a problem with fscking UFS file systems created on > top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The > latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot > find devfs entry and aborts. We cannot simply move rc.d/zfs before > rc.d/fsck, because we first want kern.hostid to be configured (by > rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks > which are in use by different systems (eg. in SAN/NAS environment). > We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on > first system start stores generated kern.hostuuid in /etc/hostid file, > so it needs root file system to be mounted read-write. > =20 > My fix is to split rc.d/hostid so that rc.d/hostid (which will now run > before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't > touch root file system and rc.d/hostid_save (which is run after > rc.d/root) and only creates /etc/hostid file. > =20 > With that in place, I can move ZVOL initialization to dedicated > rc.d/zvol script which runs before rc.d/fsck. >=20 > The patch is here: >=20 > http://people.freebsd.org/~pjd/patches/zvol_fsck.patch This looks fine to me and seems like a good solution to this problem. -- Brooks --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKbxreXY6L6fI4GtQRAuTnAKCy09a3wJd+KB/i0qzF24U/sWxkVwCeMyQm 5rLlYD0HyI8g7R//wouRNxU= =5ozU -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--