From owner-freebsd-rc@FreeBSD.ORG Sun Oct 11 20:54:37 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AD161065676 for ; Sun, 11 Oct 2009 20:54:37 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id C7D418FC08 for ; Sun, 11 Oct 2009 20:54:36 +0000 (UTC) Received: (qmail 28634 invoked by uid 399); 11 Oct 2009 20:54:35 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 11 Oct 2009 20:54:35 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD2460A.3000902@FreeBSD.org> Date: Sun, 11 Oct 2009 13:54:34 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: freebsd-rc@freebsd.org X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Oct 2009 20:54:37 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 After giving this a more thorough look I realized that there were quite a few places where $rc_quiet was being used directly in an rc.d script (16 scripts total). I've already committed this to HEAD in order to try and make the MFC deadline to potentially get it into 8.0, but I do want to give y'all a chance to review this change as well. If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has other comments or suggestions please speak up ASAP. Doug PS, please pardon the line wrap below ... - -------- Original Message -------- Subject: svn commit: r197947 - in head/etc: . rc.d Date: Sat, 10 Oct 2009 22:17:03 +0000 (UTC) Author: dougb Date: Sat Oct 10 22:17:03 2009 New Revision: 197947 URL: http://svn.freebsd.org/changeset/base/197947 Log: In regards to the "Starting foo:" type messages at boot time, create and employ a more generic solution, and use it in the individual rc.d scripts that also have an $rc_quiet test: 1. Add check_startmsgs() to rc.subr. 2. In the rc.d scripts that use rc_quiet (and rc.subr) substitute variations of [ -z "$rc_quiet" ] with check_startmsgs 3. In savecore add a trailing '.' to the end of the message to make it more consistent with other scripts. 4. In newsyslog remove a : before the terminal '.' since we do not expect there to be anything printed out in between to make it more consistent. 5. In the following scripts change "quotes" to 'quotes' where no variables exist in the message: savecore pf newsyslog 6. In the following scripts substitute if/then/fi for the simpler (and more consistent) check_startmsgs &&: faith stf 7. In the following scripts separate the "Starting foo:" from the terminal '.' to make them more consistent: moused hostname pf 8. In nfsclient move the message to its own line to avoid a style bug 9. In pf rc_quiet does not apply to the _stop method, so remove the test there. 10. In motd add 'quotes' around the terminal '.' for consistency Modified: head/etc/rc.d/bgfsck head/etc/rc.d/cleartmp head/etc/rc.d/faith head/etc/rc.d/fsck head/etc/rc.d/hostid head/etc/rc.d/hostname head/etc/rc.d/ldconfig head/etc/rc.d/motd head/etc/rc.d/mountcritlocal head/etc/rc.d/moused head/etc/rc.d/netif head/etc/rc.d/newsyslog head/etc/rc.d/nfsclient head/etc/rc.d/pf head/etc/rc.d/savecore head/etc/rc.d/stf head/etc/rc.subr Modified: head/etc/rc.d/bgfsck ============================================================================== - --- head/etc/rc.d/bgfsck Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/bgfsck Sat Oct 10 22:17:03 2009 (r197947) @@ -31,7 +31,7 @@ bgfsck_start () bgfsck_msg="${bgfsck_msg} in ${background_fsck_delay} seconds" fi if [ -z "${rc_force}" ]; then - - [ -z "${rc_quiet}" ] && echo "${bgfsck_msg}." + check_startmsgs && echo "${bgfsck_msg}." fi (sleep ${background_fsck_delay}; nice -4 fsck -B -p) 2>&1 | \ Modified: head/etc/rc.d/cleartmp ============================================================================== - --- head/etc/rc.d/cleartmp Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/cleartmp Sat Oct 10 22:17:03 2009 (r197947) @@ -25,7 +25,7 @@ cleartmp_start() ${tmp}/.ICE-unix ${tmp}/.font-unix" if checkyesno ${rcvar1}; then - - [ -z "${rc_quiet}" ] && echo "Clearing ${tmp}." + check_startmsgs && echo "Clearing ${tmp}." # This is not needed for mfs, but doesn't hurt anything. # Things to note: @@ -44,7 +44,7 @@ cleartmp_start() elif checkyesno clear_tmp_X; then # Remove X lock files, since they will prevent you from # restarting X. Remove other X related directories. - - [ -z "${rc_quiet}" ] && echo "Clearing ${tmp} (X related)." + check_startmsgs && echo "Clearing ${tmp} (X related)." rm -rf ${tmp}/.X[0-9]-lock ${x11_socket_dirs} fi if checkyesno clear_tmp_X; then Modified: head/etc/rc.d/faith ============================================================================== - --- head/etc/rc.d/faith Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/faith Sat Oct 10 22:17:03 2009 (r197947) @@ -39,9 +39,7 @@ faith_up() route change -inet6 ${prefix} -prefixlen ${prefixlen} \ -ifp faith0 done - - if [ -z "${rc_quiet}" ]; then - - ifconfig faith0 - - fi + check_startmsgs && ifconfig faith0 ;; esac } Modified: head/etc/rc.d/fsck ============================================================================== - --- head/etc/rc.d/fsck Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/fsck Sat Oct 10 22:17:03 2009 (r197947) @@ -23,7 +23,7 @@ fsck_start() # During fsck ignore SIGQUIT trap : 3 - - [ -z "${rc_quiet}" ] && echo "Starting file system checks:" + check_startmsgs && echo "Starting file system checks:" if checkyesno background_fsck; then fsck -F -p else Modified: head/etc/rc.d/hostid ============================================================================== - --- head/etc/rc.d/hostid Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/hostid Sat Oct 10 22:17:03 2009 (r197947) @@ -49,9 +49,9 @@ hostid_set() # Set both kern.hostuuid and kern.hostid. # - - [ -z "${rc_quiet}" ] && echo "Setting hostuuid: ${uuid}." + check_startmsgs && echo "Setting hostuuid: ${uuid}." ${SYSCTL_W} kern.hostuuid="${uuid}" >/dev/null - - [ -z "${rc_quiet}" ] && echo "Setting hostid: ${id}." + check_startmsgs && echo "Setting hostid: ${id}." ${SYSCTL_W} kern.hostid=${id} >/dev/null } Modified: head/etc/rc.d/hostname ============================================================================== - --- head/etc/rc.d/hostname Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/hostname Sat Oct 10 22:17:03 2009 (r197947) @@ -72,8 +72,9 @@ hostname_start() # All right, it is safe to invoke hostname(1) now. # - - [ -z "${rc_quiet}" ] && echo "Setting hostname: ${hostname}." + check_startmsgs && echo -n "Setting hostname: ${hostname}" /bin/hostname "${hostname}" + check_startmsgs && echo '.' } load_rc_config $name Modified: head/etc/rc.d/ldconfig ============================================================================== - --- head/etc/rc.d/ldconfig Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/ldconfig Sat Oct 10 22:17:03 2009 (r197947) @@ -36,7 +36,7 @@ ldconfig_start() _LDC="${_LDC} ${i}" fi done - - [ -z "${rc_quiet}" ] && echo 'ELF ldconfig path:' ${_LDC} + check_startmsgs && echo 'ELF ldconfig path:' ${_LDC} ${ldconfig} -elf ${_ins} ${_LDC} case `sysctl -n hw.machine_arch` in @@ -55,7 +55,7 @@ ldconfig_start() _LDC="${_LDC} ${i}" fi done - - [ -z "${rc_quiet}" ] && + check_startmsgs && echo '32-bit compatibility ldconfig path:' ${_LDC} ${ldconfig} -32 -m ${_ins} ${_LDC} ;; @@ -72,8 +72,7 @@ ldconfig_start() _LDC="${_LDC} ${i}" fi done - - [ -z "${rc_quiet}" ] && - - echo 'a.out ldconfig path:' ${_LDC} + check_startmsgs && echo 'a.out ldconfig path:' ${_LDC} ${ldconfig} -aout ${_ins} ${_LDC} ;; esac Modified: head/etc/rc.d/motd ============================================================================== - --- head/etc/rc.d/motd Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/motd Sat Oct 10 22:17:03 2009 (r197947) @@ -22,7 +22,7 @@ motd_start() # Must be done *before* interactive logins are possible # to prevent possible race conditions. # - - [ -z "${rc_quiet}" ] && echo -n 'Updating motd:' + check_startmsgs && echo -n 'Updating motd:' if [ ! -f /etc/motd ]; then install -c -o root -g wheel -m ${PERMS} /dev/null /etc/motd fi @@ -42,7 +42,7 @@ motd_start() } rm -f $T - - [ -z "${rc_quiet}" ] && echo . + check_startmsgs && echo '.' } load_rc_config $name Modified: head/etc/rc.d/mountcritlocal ============================================================================== - --- head/etc/rc.d/mountcritlocal Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/mountcritlocal Sat Oct 10 22:17:03 2009 (r197947) @@ -28,7 +28,7 @@ mountcritlocal_start() esac # Mount everything except nfs filesystems. - - [ -z "${rc_quiet}" ] && echo -n 'Mounting local file systems:' + check_startmsgs && echo -n 'Mounting local file systems:' mount_excludes='no' for i in ${netfs_types}; do fstype=${i%:*} @@ -37,7 +37,7 @@ mountcritlocal_start() mount_excludes=${mount_excludes%,} mount -a -t ${mount_excludes} err=$? - - [ -z "${rc_quiet}" ] && echo '.' + check_startmsgs && echo '.' case ${err} in 0) Modified: head/etc/rc.d/moused ============================================================================== - --- head/etc/rc.d/moused Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/moused Sat Oct 10 22:17:03 2009 (r197947) @@ -51,8 +51,9 @@ moused_start() mytype="$moused_type" fi - - [ -z "${rc_quiet}" ] && echo -n "Starting ${ms} moused." + check_startmsgs && echo -n "Starting ${ms} moused" /usr/sbin/moused ${myflags} -p ${myport} -t ${mytype} ${pidarg} + check_startmsgs && echo '.' mousechar_arg= case ${mousechar_start} in Modified: head/etc/rc.d/netif ============================================================================== - --- head/etc/rc.d/netif Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/netif Sat Oct 10 22:17:03 2009 (r197947) @@ -143,7 +143,7 @@ network_common() ;; esac echo "${_str} Network:${_ok}." - - if [ -z "${rc_quiet}" ]; then + if check_startmsgs; then for ifn in ${_ok}; do /sbin/ifconfig ${ifn} done Modified: head/etc/rc.d/newsyslog ============================================================================== - --- head/etc/rc.d/newsyslog Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/newsyslog Sat Oct 10 22:17:03 2009 (r197947) @@ -17,9 +17,9 @@ stop_cmd=":" newsyslog_start() { - - [ -z "${rc_quiet}" ] && echo -n "Creating and/or trimming log files:" + check_startmsgs && echo -n 'Creating and/or trimming log files' ${command} ${rc_flags} - - [ -z "${rc_quiet}" ] && echo "." + check_startmsgs && echo '.' } load_rc_config $name Modified: head/etc/rc.d/nfsclient ============================================================================== - --- head/etc/rc.d/nfsclient Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/nfsclient Sat Oct 10 22:17:03 2009 (r197947) @@ -22,7 +22,8 @@ nfsclient_start() # if [ -n "${nfs_access_cache}" ]; then - - [ -z "${rc_quiet}" ] && echo "NFS access cache time=${nfs_access_cache}" + check_startmsgs && + echo "NFS access cache time=${nfs_access_cache}" if ! sysctl vfs.nfs.access_cache_timeout=${nfs_access_cache} >/dev/null; then warn "failed to set access cache timeout" fi Modified: head/etc/rc.d/pf ============================================================================== - --- head/etc/rc.d/pf Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/pf Sat Oct 10 22:17:03 2009 (r197947) @@ -25,19 +25,21 @@ required_modules="pf" pf_start() { - - [ -z "${rc_quiet}" ] && echo "Enabling pf." + check_startmsgs && echo -n 'Enabling pf' $pf_program -F all > /dev/null 2>&1 $pf_program -f "$pf_rules" $pf_flags if ! $pf_program -s info | grep -q "Enabled" ; then $pf_program -e fi + check_startmsgs && echo '.' } pf_stop() { if $pf_program -s info | grep -q "Enabled" ; then - - [ -z "${rc_quiet}" ] && echo "Disabling pf." + echo -n 'Disabling pf' $pf_program -d + echo '.' fi } Modified: head/etc/rc.d/savecore ============================================================================== - --- head/etc/rc.d/savecore Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/savecore Sat Oct 10 22:17:03 2009 (r197947) @@ -69,7 +69,7 @@ savecore_start() ${crashinfo_program} -d ${dumpdir} fi else - - [ -z "${rc_quiet}" ] && echo "No core dumps found" + check_startmsgs && echo 'No core dumps found.' fi } Modified: head/etc/rc.d/stf ============================================================================== - --- head/etc/rc.d/stf Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.d/stf Sat Oct 10 22:17:03 2009 (r197947) @@ -53,9 +53,8 @@ stf_up() ifconfig stf0 create >/dev/null 2>&1 ifconfig stf0 inet6 2002:${ipv4_in_hexformat}:${stf_interface_ipv6_slaid:-0}:${stf_interface_ipv6_ifid} \ prefixlen ${stf_prefixlen} - - if [ -z "${rc_quiet}" ]; then - - /sbin/ifconfig stf0 - - fi + check_startmsgs && /sbin/ifconfig stf0 + # disallow packets to malicious 6to4 prefix route add -inet6 2002:e000:: -prefixlen 20 ::1 -reject route add -inet6 2002:7f00:: -prefixlen 24 ::1 -reject Modified: head/etc/rc.subr ============================================================================== - --- head/etc/rc.subr Sat Oct 10 21:56:39 2009 (r197946) +++ head/etc/rc.subr Sat Oct 10 22:17:03 2009 (r197947) @@ -398,6 +398,20 @@ wait_for_pids() } # +# check_startmsgs +# If rc_quiet is set (usually as a result of using faststart at +# boot time) check if rc_startmsgs is enabled. +# +check_startmsgs() +{ + if [ -n "$rc_quiet" ]; then + checkyesno rc_startmsgs + else + return 0 + fi +} + +# # run_rc_command argument # Search for argument in the list of supported commands, which is: # "start stop restart rcvar status poll ${extra_commands}" @@ -708,13 +722,7 @@ run_rc_command() # setup the full command to run # - - _show_startmsgs=1 - - if [ -n "${rc_quiet}" ]; then - - if ! checkyesno rc_startmsgs; then - - unset _show_startmsgs - - fi - - fi - - [ -n "$_show_startmsgs" ] && echo "Starting ${name}." + check_startmsgs && echo "Starting ${name}." if [ -n "$_chroot" ]; then _doit="\ ${_nice:+nice -n $_nice }\ - -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEAREDAAYFAkrSRgoACgkQyIakK9Wy8PuW5QCfcsYuCcsgQP6FYvNCXkGjg5Wg fnMAoL4JRVKCsrHX3zWqdyvYeQi9IT5d =pTmG -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Mon Oct 12 11:07:00 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E970F106568F for ; Mon, 12 Oct 2009 11:07:00 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D6EDD8FC14 for ; Mon, 12 Oct 2009 11:07:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9CB70if036532 for ; Mon, 12 Oct 2009 11:07:00 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9CB70US036528 for freebsd-rc@FreeBSD.org; Mon, 12 Oct 2009 11:07:00 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 12 Oct 2009 11:07:00 GMT Message-Id: <200910121107.n9CB70US036528@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 11:07:01 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 60 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Oct 12 22:01:08 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE9E91065692 for ; Mon, 12 Oct 2009 22:01:08 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 9970D8FC18 for ; Mon, 12 Oct 2009 22:01:08 +0000 (UTC) Received: (qmail 8270 invoked by uid 399); 12 Oct 2009 22:01:07 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Oct 2009 22:01:07 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD3A722.9060401@FreeBSD.org> Date: Mon, 12 Oct 2009 15:01:06 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Hiroki Sato References: <200910052011.n95KBXdS024044@svn.freebsd.org> In-Reply-To: <200910052011.n95KBXdS024044@svn.freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Mark Murray , freebsd-rc@freebsd.org Subject: Re: svn commit: r197790 - head/etc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 22:01:09 -0000 I think this is the wrong solution to the problem. In at least two cases (routed and route6d) where $command is not defined in the rc.d scripts this change is resulting in $command not being defined at all. If you look at the definition of the + parameter substitution this makes sense: ${parameter:+word} Use Alternate Value. If parameter is unset or null, null is substituted; otherwise, the expansion of word is substituted. I think that what you really wanted to do was: Index: rc.subr =================================================================== --- rc.subr (revision 198000) +++ rc.subr (working copy) @@ -616,7 +616,7 @@ esac eval _override_command=\$${name}_program - command=${command:+${_override_command:-$command}} + command=${_override_command:-$command} _keywords="start stop restart rcvar $extra_commands" rc_pid= That actually makes more sense anyway, at least to me since it allows the user to override the definition of command in rc.conf, which seems consistent with how we override other things. Mark, can you revert the band-aids that I supplied previously and try this instead? Anyone else have a comment on this idea? Doug Hiroki Sato wrote: > Author: hrs > Date: Mon Oct 5 20:11:33 2009 > New Revision: 197790 > URL: http://svn.freebsd.org/changeset/base/197790 > > Log: > Fix a case when both ${name}_program and ${command} are defined. > > Spotted by: Michio "Karl" Jinbo > > Modified: > head/etc/rc.subr > > Modified: head/etc/rc.subr > ============================================================================== > --- head/etc/rc.subr Mon Oct 5 19:56:56 2009 (r197789) > +++ head/etc/rc.subr Mon Oct 5 20:11:33 2009 (r197790) > @@ -602,7 +602,7 @@ run_rc_command() > esac > > eval _override_command=\$${name}_program > - command=${command:-${_override_command}} > + command=${command:+${_override_command:-$command}} > > _keywords="start stop restart rcvar $extra_commands" > rc_pid= > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Wed Oct 14 03:55:50 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7BF2106566C for ; Wed, 14 Oct 2009 03:55:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 3C82B8FC0A for ; Wed, 14 Oct 2009 03:55:49 +0000 (UTC) Received: (qmail 31407 invoked by uid 399); 14 Oct 2009 03:55:48 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Oct 2009 03:55:48 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD54BBD.4020704@FreeBSD.org> Date: Tue, 13 Oct 2009 20:55:41 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <4AD2460A.3000902@FreeBSD.org> In-Reply-To: <4AD2460A.3000902@FreeBSD.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 03:55:50 -0000 Doug Barton wrote: > After giving this a more thorough look I realized that there were > quite a few places where $rc_quiet was being used directly in an rc.d > script (16 scripts total). > > I've already committed this to HEAD in order to try and make the MFC > deadline to potentially get it into 8.0, but I do want to give y'all a > chance to review this change as well. > > If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has > other comments or suggestions please speak up ASAP. I haven't heard any comments about this, so I've requested permission to MFC it to RELENG_8. If you have any concerns speak up now. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Wed Oct 14 09:45:41 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A53E106566B; Wed, 14 Oct 2009 09:45:41 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 231C08FC12; Wed, 14 Oct 2009 09:45:41 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:c0:e792:953e:5a9] (unknown [IPv6:2001:7b8:3a7:0:c0:e792:953e:5a9]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E11F05C59; Wed, 14 Oct 2009 11:45:39 +0200 (CEST) Message-ID: <4AD59DCC.9000008@andric.com> Date: Wed, 14 Oct 2009 11:45:48 +0200 From: Dimitry Andric User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.4pre) Gecko/20091003 Shredder/3.0pre MIME-Version: 1.0 To: Doug Barton References: <4AD2460A.3000902@FreeBSD.org> In-Reply-To: <4AD2460A.3000902@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 09:45:41 -0000 On 2009-10-11 22:54, Doug Barton wrote: > After giving this a more thorough look I realized that there were > quite a few places where $rc_quiet was being used directly in an rc.d > script (16 scripts total). > > I've already committed this to HEAD in order to try and make the MFC > deadline to potentially get it into 8.0, but I do want to give y'all a > chance to review this change as well. > > If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has > other comments or suggestions please speak up ASAP. I see no problems with MFC'ing, this is a nice way of cleaning up. That said, there are still quite a number of scripts in rc.d that don't check rc_quiet at all, and just echo whatever they like. Therefore, couldn't all those "check_startmsgs && echo foo" constructs, plus the other echo's be replaced with, say, a spam() function from /etc/rc.subr? This function can then check in one central location for rc_startmsgs and decide whether to spam the console or not. One could even start implementing some verbosity level using this... :) From owner-freebsd-rc@FreeBSD.ORG Wed Oct 14 18:02:25 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 078191065676 for ; Wed, 14 Oct 2009 18:02:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8904F8FC18 for ; Wed, 14 Oct 2009 18:02:23 +0000 (UTC) Received: (qmail 1068 invoked by uid 399); 14 Oct 2009 18:02:23 -0000 Received: from localhost (HELO ?192.168.0.102?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Oct 2009 18:02:23 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD6122F.3090407@FreeBSD.org> Date: Wed, 14 Oct 2009 11:02:23 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Dimitry Andric References: <4AD2460A.3000902@FreeBSD.org> <4AD59DCC.9000008@andric.com> In-Reply-To: <4AD59DCC.9000008@andric.com> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 18:02:25 -0000 Dimitry Andric wrote: > On 2009-10-11 22:54, Doug Barton wrote: >> After giving this a more thorough look I realized that there were >> quite a few places where $rc_quiet was being used directly in an rc.d >> script (16 scripts total). >> >> I've already committed this to HEAD in order to try and make the MFC >> deadline to potentially get it into 8.0, but I do want to give y'all a >> chance to review this change as well. >> >> If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has >> other comments or suggestions please speak up ASAP. > > I see no problems with MFC'ing, this is a nice way of cleaning up. Thanks. > That said, there are still quite a number of scripts in rc.d that don't > check rc_quiet at all, and just echo whatever they like. > > Therefore, couldn't all those "check_startmsgs && echo foo" constructs, > plus the other echo's be replaced with, say, a spam() function from > /etc/rc.subr? This function can then check in one central location for > rc_startmsgs and decide whether to spam the console or not. > > One could even start implementing some verbosity level using this... :) My intention was to give users the option to get back to where things were before they were fiddled with in time for the release. I actually gave some thought along similar lines when I was working on this patch since there are some things that I restored that I personally don't care about seeing. I look forward to reviewing your patches. :) Doug From owner-freebsd-rc@FreeBSD.ORG Thu Oct 15 07:20:23 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C06A1065670; Thu, 15 Oct 2009 07:20:23 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id CC20F8FC17; Thu, 15 Oct 2009 07:20:22 +0000 (UTC) Received: from delta.allbsd.org (p2046-ipbf1608funabasi.chiba.ocn.ne.jp [123.225.211.46]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n9F7K989087210; Thu, 15 Oct 2009 16:20:21 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n9F7K5T8090604; Thu, 15 Oct 2009 16:20:07 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Thu, 15 Oct 2009 16:19:39 +0900 (JST) Message-Id: <20091015.161939.200967153.hrs@allbsd.org> To: dougb@FreeBSD.org From: Hiroki Sato In-Reply-To: <4AD3A722.9060401@FreeBSD.org> References: <200910052011.n95KBXdS024044@svn.freebsd.org> <4AD3A722.9060401@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.2.52 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Thu_Oct_15_16_19_39_2009_433)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.95.2 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Thu, 15 Oct 2009 16:20:21 +0900 (JST) Cc: markm@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r197790 - head/etc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 07:20:23 -0000 ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Doug, Doug Barton wrote in <4AD3A722.9060401@FreeBSD.org>: do> I think this is the wrong solution to the problem. In at least two do> cases (routed and route6d) where $command is not defined in the rc.d do> scripts this change is resulting in $command not being defined at all. do> do> If you look at the definition of the + parameter substitution this do> makes sense: do> do> ${parameter:+word} do> Use Alternate Value. If parameter is unset or null, null do> is substituted; otherwise, the expansion of word is do> substituted. do> do> I think that what you really wanted to do was: I am sorry for the delay. Your patch is reasonable to me. This problem was there for a while, so it should be fixed asap. I noticed there was something wrong about ${name}_program but it seems I mistakenly changed it (sorry...). Then I received a report "it does not work" so I just reverted it. IMO defining $command in rc.d scripts is not a good practice. "Always use ${name}_program and let load_rc_config() set the $command" would be consistent and useful to avoid this sort of problems. -- Hiroki ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkrWzQsACgkQTyzT2CeTzy29/wCgv1dMPJJswx6WCfaLMyQbw8jI EVwAoJPQ0IC03SMxZ5QnZJEHXWPFoXzI =+z5p -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)---- From owner-freebsd-rc@FreeBSD.ORG Fri Oct 16 00:06:21 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5FB971065670 for ; Fri, 16 Oct 2009 00:06:21 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id E336F8FC13 for ; Fri, 16 Oct 2009 00:06:20 +0000 (UTC) Received: (qmail 21946 invoked by uid 399); 16 Oct 2009 00:06:19 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 16 Oct 2009 00:06:19 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD7B8FA.7020703@FreeBSD.org> Date: Thu, 15 Oct 2009 17:06:18 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Hiroki Sato References: <200910052011.n95KBXdS024044@svn.freebsd.org> <4AD3A722.9060401@FreeBSD.org> <20091015.161939.200967153.hrs@allbsd.org> In-Reply-To: <20091015.161939.200967153.hrs@allbsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: markm@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r197790 - head/etc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 00:06:21 -0000 Hiroki Sato wrote: > Hi Doug, > > Doug Barton wrote > in <4AD3A722.9060401@FreeBSD.org>: > > do> I think this is the wrong solution to the problem. In at least two > do> cases (routed and route6d) where $command is not defined in the rc.d > do> scripts this change is resulting in $command not being defined at all. > do> > do> If you look at the definition of the + parameter substitution this > do> makes sense: > do> > do> ${parameter:+word} > do> Use Alternate Value. If parameter is unset or null, null > do> is substituted; otherwise, the expansion of word is > do> substituted. > do> > do> I think that what you really wanted to do was: > > I am sorry for the delay. Your patch is reasonable to me. This > problem was there for a while, so it should be fixed asap. Ok, I've committed the fix, thanks for getting back to me. > I noticed there was something wrong about ${name}_program but it > seems I mistakenly changed it (sorry...). Then I received a report > "it does not work" so I just reverted it. Understood. I am sure you realize that it's always Ok to ask for help here on -rc. The rc.d system is not life-threateningly complex but it does have a lot of "behind the scenes" interactions that are not always obvious. I certainly don't hesitate to ask for review on changes myself and I encourage others to do so (as you have done in the past). FWIW, what I do object to about your changes in r197144 and r197790 are that in the first case you neglected to mention that you were changing that part of the code, and in the second you neglected to mention that you were changing it back to what it was before you changed it. That made debugging this problem more difficult for me than (I think) it should have been. You also did not mention that you were removing $command in your changes to route[6]d, which made debugging Mark's original complaint harder, but only for about 30 seconds or so. :) The two most important things about VCS logs are WHAT you did (should be brief, but thorough) and WHY you did it. My logs are often obnoxiously long, but you can generally find at least that information in them. Please think about what people who read the logs years from now will need to know. Of course, I realize that this is difficult to do, especially when you are just wrapping up a project and all of the information is fresh in your head and seems painfully obvious. > IMO defining $command in rc.d scripts is not a good practice. > "Always use ${name}_program and let load_rc_config() set the > $command" would be consistent and useful to avoid this sort of > problems. In the past since there was not a reliable mechanism to allow ${name}_program to override $command, and because rc.subr needs to have $command defined to work properly (see the description in the run_rc_command comments in rc.subr) it was necessary to set command in each script. When yar introduced the current version of the override code almost 4 years ago he also went through and set command explicitly in all the scripts that didn't have it, so the situation that was created here never came up until now. (FYI, the previous code that he replaced had the same effect as what I just changed it to but was slightly more complex.) I'm sort of ambivalent about whether we need to continue encouraging people to use command in the script or not. As long as what's in the script matches what's in /etc/defaults/rc.conf we're not hurting anything, although we are duplicating effort. My preference at this point is to let the change that I just made settle for a while, mostly to see if it has any negative interactions with scripts from ports, then MFC it after 8.0-RELEASE along with the changes you've made to the IPv6 stuff. After that we can start talking about ripping command= out of the individual rc.d scripts if people think that's a good idea. Doug PS, Mark you're a slacker for not getting back to me. :) -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Oct 17 17:51:31 2009 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81D86106566B; Sat, 17 Oct 2009 17:51:31 +0000 (UTC) (envelope-from freebsd@levsha.org.ua) Received: from expo.ukrweb.net (mail.univua.net [91.202.128.78]) by mx1.freebsd.org (Postfix) with ESMTP id 392918FC0C; Sat, 17 Oct 2009 17:51:31 +0000 (UTC) Received: from levsha by expo.ukrweb.net with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1MzCvd-000OFT-H8; Sat, 17 Oct 2009 20:18:53 +0300 Date: Sat, 17 Oct 2009 20:18:53 +0300 From: Mykola Dzham To: hrs@freebsd.org Message-ID: <20091017171853.GA29771@expo.ukrweb.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD/7.0-STABLE (i386) User-Agent: Mutt/1.5.18 (2008-05-17) Cc: rc@freebsd.org Subject: Circular dependency in rc.d after r197527 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 17:51:31 -0000 Hi! After r197527 circular dependency found in rc.d scripts: stf and faith conatins # REQUIRE: netif routing and after r197527 routing contains # REQUIRE: faith netif ppp stf I think tath deleting "routing" from REQUIRE list on stf and faith required. -- Mykola Dzham, LEFT-(UANIC|RIPE) JID: levsha@jabber.net.ua From owner-freebsd-rc@FreeBSD.ORG Sat Oct 17 20:19:14 2009 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB143106566B for ; Sat, 17 Oct 2009 20:19:14 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 5BAAF8FC16 for ; Sat, 17 Oct 2009 20:19:14 +0000 (UTC) Received: (qmail 13995 invoked by uid 399); 17 Oct 2009 19:52:33 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 17 Oct 2009 19:52:33 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4ADA2080.6060502@FreeBSD.org> Date: Sat, 17 Oct 2009 12:52:32 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Mykola Dzham References: <20091017171853.GA29771@expo.ukrweb.net> In-Reply-To: <20091017171853.GA29771@expo.ukrweb.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: rc@freebsd.org Subject: Re: Circular dependency in rc.d after r197527 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 20:19:14 -0000 Mykola Dzham wrote: > Hi! > After r197527 circular dependency found in rc.d scripts: stf and faith > conatins > # REQUIRE: netif routing > and after r197527 routing contains > # REQUIRE: faith netif ppp stf > > I think tath deleting "routing" from REQUIRE list on stf and faith > required. Agreed. hrs, any objections? Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Oct 17 20:52:12 2009 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8A49106566C; Sat, 17 Oct 2009 20:52:12 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5FD358FC0C; Sat, 17 Oct 2009 20:52:12 +0000 (UTC) Received: from delta.allbsd.org (p1064-ipbf416funabasi.chiba.ocn.ne.jp [123.225.90.64]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n9HKpxa8065737; Sun, 18 Oct 2009 05:52:10 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n9HKpt3C094211; Sun, 18 Oct 2009 05:51:55 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 18 Oct 2009 05:49:29 +0900 (JST) Message-Id: <20091018.054929.261416476.hrs@allbsd.org> To: dougb@FreeBSD.org From: Hiroki Sato In-Reply-To: <4ADA2080.6060502@FreeBSD.org> References: <20091017171853.GA29771@expo.ukrweb.net> <4ADA2080.6060502@FreeBSD.org> X-Mailer: Mew version 6.2.52 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart0(Sun_Oct_18_05_49_29_2009_259)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.95.2 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Sun, 18 Oct 2009 05:52:10 +0900 (JST) Cc: rc@FreeBSD.org Subject: Re: Circular dependency in rc.d after r197527 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 20:52:12 -0000 ----Security_Multipart0(Sun_Oct_18_05_49_29_2009_259)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Oct_18_05_49_29_2009_285)--" Content-Transfer-Encoding: 7bit ----Next_Part(Sun_Oct_18_05_49_29_2009_285)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Doug Barton wrote in <4ADA2080.6060502@FreeBSD.org>: do> Mykola Dzham wrote: do> > Hi! do> > After r197527 circular dependency found in rc.d scripts: stf and faith do> > conatins do> > # REQUIRE: netif routing do> > and after r197527 routing contains do> > # REQUIRE: faith netif ppp stf do> > do> > I think tath deleting "routing" from REQUIRE list on stf and faith do> > required. do> do> Agreed. hrs, any objections? Thank you for pointing out it. No objection from me. The attached patch should fix it. -- Hiroki ----Next_Part(Sun_Oct_18_05_49_29_2009_285)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rc_d.diff" Index: faith =================================================================== --- faith (revision 198189) +++ faith (working copy) @@ -3,7 +3,7 @@ # # PROVIDE: faith -# REQUIRE: netif routing +# REQUIRE: netif # KEYWORD: nojail . /etc/rc.subr Index: stf =================================================================== --- stf (revision 198189) +++ stf (working copy) @@ -3,7 +3,7 @@ # # PROVIDE: stf -# REQUIRE: netif routing +# REQUIRE: netif # KEYWORD: nojail . /etc/rc.subr ----Next_Part(Sun_Oct_18_05_49_29_2009_285)---- ----Security_Multipart0(Sun_Oct_18_05_49_29_2009_259)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkraLdkACgkQTyzT2CeTzy3YQQCfe5HeYpLwiqoHsHoWTk8dZ+19 o0gAnictb0HALVsf/oUhKDWo7Yz4X3JZ =jy2c -----END PGP SIGNATURE----- ----Security_Multipart0(Sun_Oct_18_05_49_29_2009_259)---- From owner-freebsd-rc@FreeBSD.ORG Sat Oct 17 21:10:17 2009 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23EFD1065697 for ; Sat, 17 Oct 2009 21:10:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A816A8FC12 for ; Sat, 17 Oct 2009 21:10:16 +0000 (UTC) Received: (qmail 7056 invoked by uid 399); 17 Oct 2009 21:10:15 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 17 Oct 2009 21:10:15 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4ADA32B5.5030304@FreeBSD.org> Date: Sat, 17 Oct 2009 14:10:13 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Hiroki Sato References: <20091017171853.GA29771@expo.ukrweb.net> <4ADA2080.6060502@FreeBSD.org> <20091018.054929.261416476.hrs@allbsd.org> In-Reply-To: <20091018.054929.261416476.hrs@allbsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: rc@FreeBSD.org Subject: Re: Circular dependency in rc.d after r197527 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 21:10:17 -0000 Hiroki Sato wrote: > Thank you for pointing out it. No objection from me. The attached > patch should fix it. Ok, done. Thanks for the quick reply. :) Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/