From owner-freebsd-acpi@FreeBSD.ORG Mon Nov 8 11:06:52 2010 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05B0D1065675 for ; Mon, 8 Nov 2010 11:06:52 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CC9E38FC23 for ; Mon, 8 Nov 2010 11:06:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA8B6pEo088011 for ; Mon, 8 Nov 2010 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA8B6pA3088009 for freebsd-acpi@FreeBSD.org; Mon, 8 Nov 2010 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 8 Nov 2010 11:06:51 GMT Message-Id: <201011081106.oA8B6pA3088009@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-acpi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-acpi@FreeBSD.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2010 11:06:52 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o i386/146715 acpi [acpi] Suspend works, resume not on a HP Probook 4510s o kern/145306 acpi [acpi]: Can't change brightness on HP ProBook 4510s o amd64/144551 acpi [acpi] ACPI issues on SuperMicro X7SPA-H o i386/144045 acpi [acpi] [panic] kernel trap with acpi enabled o i386/143798 acpi [acpi] shutdown problem with SiS K7S5A o kern/143420 acpi [acpi] ACPI issues with Toshiba o kern/142263 acpi [acpi] ACPI regression on Asus K8N7-E deluxe motherboa o kern/142009 acpi [acpi] [panic] Panic in AcpiNsGetAttachedObject o amd64/140751 acpi [acpi] BIOS resource allocation and FreeBSD ACPI in TO o kern/139088 acpi [acpi] ACPI Exception: AE_AML_INFINITE_LOOP error o amd64/138210 acpi [acpi] acer aspire 5536 ACPI problems (S3, brightness, o bin/137053 acpi [hang] FreeBSD 8.0 BETA2Compaq Mini 700 locks on boot o kern/137042 acpi [acpi] hp laptop's lcd not wakes up after suspend to r o i386/136008 acpi [acpi] Dell Vostro 1310 will not shutdown (Requires us o bin/135349 acpi [patch] teach acpidump(8) to disassemble arbitrary mem o kern/135070 acpi [acpi] [patch] BIOS resource allocation and FreeBSD AC o kern/132602 acpi [acpi] ACPI Problem with Intel SS4200: System does not o kern/130683 acpi [ACPI] shutdown hangs after syncing disks - ACPI race? o i386/129953 acpi [acpi] ACPI timeout (CDROM) with Shuttle X27D o kern/129618 acpi [acpi] Problem with ACPI on HP Pavilion DV2899 laptop o kern/129563 acpi [acpi] sleep broken on IBM/Lenovo T61 in amd64 mode p kern/128634 acpi [patch] fix acpi_asus(4) in asus a6f laptop o kern/124744 acpi [acpi] [patch] incorrect _BST result validation for To o kern/124412 acpi [acpi] power off error on Toshiba M40 laptop o kern/123039 acpi [acpi] ACPI AML_BUFFER_LIMIT errors during boot o kern/121504 acpi [patch] Correctly set hw.acpi.osname on certain machin o amd64/121439 acpi [boot] Installation of FreeBSD 7.0 fails: ACPI problem o kern/121102 acpi [acpi_fujitsu] [patch] update acpi_fujitsu for the P80 o kern/120515 acpi [acpi] [patch] acpi_alloc_wakeup_handler: can't alloc o kern/119356 acpi [acpi]: i386 ACPI wakeup not work due resource exhaust o kern/119200 acpi [acpi] Lid close switch suspends CPU for 1 second on H o kern/118973 acpi [acpi]: Kernel panic with acpi boot o kern/116939 acpi [acpi] PCI-to-PCI misconfigured for bus three and can o i386/114562 acpi [acpi] cardbus is dead after s3 on Thinkpad T43 with a o kern/114165 acpi [acpi] Dell C810 - ACPI problem s kern/112544 acpi [acpi] [patch] Add High Precision Event Timer Driver f o kern/108954 acpi [acpi] 'sleep(1)' sleeps >1 seconds when speedstep (Cx o kern/108695 acpi [acpi]: Fatal trap 9: general protection fault when in o kern/108488 acpi [acpi] ACPI-1304: *** Error: Method execution failed o kern/108017 acpi [acpi]: Acer Aspire 5600 o kern/106924 acpi [acpi] ACPI resume returns g_vfs_done() errors and ker o kern/105537 acpi [acpi] problems in acpi on HP Compaq nc6320 o kern/104625 acpi ACPI on ASUS A8N-32 SLI/ASUS P4P800 does not show ther o kern/102252 acpi acpi thermal does not work on Abit AW8D (intel 975) o kern/97383 acpi Volume buttons on IBM Thinkpad crash system with ACPI s i386/91748 acpi acpi problem on Acer TravelMare 4652LMi (nvidia panic, s kern/91038 acpi [panic] [ata] [acpi] 6.0-RELEASE on Fujitsu Siemens Am s kern/90243 acpi Laptop fan doesn't turn off (ACPI enabled) (Packard Be o i386/83018 acpi [install] Installer will not boot on Asus P4S8X BIOS 1 o i386/79081 acpi ACPI suspend/resume not working on HP nx6110 o kern/76950 acpi ACPI wrongly blacklisted on Micron ClientPro 766Xi sys o kern/73823 acpi [request] acpi / power-on by timer support o i386/72566 acpi ACPI, FreeBSD disables fan on Compaq Armada 1750 o i386/69750 acpi Boot without ACPI failed on ASUS L5 o kern/56024 acpi ACPI suspend drains battery while in S3 o i386/55661 acpi ACPI suspend/resume problem on ARMADA M700 56 problems total. From owner-freebsd-acpi@FreeBSD.ORG Wed Nov 10 14:33:53 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0A5F106564A for ; Wed, 10 Nov 2010 14:33:53 +0000 (UTC) (envelope-from Mathias.Picker@gmx.de) Received: from mail.gmx.net (mailout-de.gmx.net [213.165.64.22]) by mx1.freebsd.org (Postfix) with SMTP id 4B8908FC24 for ; Wed, 10 Nov 2010 14:33:52 +0000 (UTC) Received: (qmail invoked by alias); 10 Nov 2010 14:07:11 -0000 Received: from dslb-084-056-030-254.pools.arcor-ip.net (EHLO [192.168.178.33]) [84.56.30.254] by mail.gmx.net (mp064) with SMTP; 10 Nov 2010 15:07:12 +0100 X-Authenticated: #23891974 X-Provags-ID: V01U2FsdGVkX18cqwhmLwYcI8Ue3lT8TU6BMOHRxrF/yUC3yPndRH T9wL9x/uXtV+dn From: Mathias Picker To: freebsd-acpi@freebsd.org Content-Type: text/plain; charset="UTF-8" Date: Wed, 10 Nov 2010 15:07:10 +0100 Message-ID: <1289398030.1762.17.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 Subject: Acer 5553g / Mobile Phenom N930 C-States X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 14:33:54 -0000 Hi, my N930 reports C1 as lowest cpu state: mp% sysctl -a|grep cx_supp dev.cpu.0.cx_supported: C1/0 dev.cpu.1.cx_supported: C1/0 dev.cpu.2.cx_supported: C1/0 dev.cpu.3.cx_supported: C1/0 I searched the net, but I can't tell if that's correct. The system runs rather loud with FreeBSD (fan running full speed, cpu temp around 59°C). I can't switch off the second graphics card, one of my last ideas of getting it any cooler would be c2/c3. I've followed every other tip from TuningPowerConsumption and need still around 3315 mA. Thanks for any help, Mathias boot -v output: http://pastebin.com/VWYifahu acpidump -dt: http://pastebin.com/V82SuzrW cpufreq scaling works fine: dev.cpu.0.%desc: ACPI CPU dev.cpu.0.%driver: cpu dev.cpu.0.%location: handle=\_PR_.C000 dev.cpu.0.%pnpinfo: _HID=none _UID=0 dev.cpu.0.%parent: acpi0 dev.cpu.0.freq: 800 dev.cpu.0.freq_levels: 2000/7632 1700/5945 1400/4582 1100/3422 800/2328 dev.cpu.0.temperature: 59,1C dev.cpu.0.cx_supported: C1/0 dev.cpu.0.cx_lowest: C1 dev.cpu.0.cx_usage: 100.00% last 2038us dev.cpu.1.%desc: ACPI CPU From owner-freebsd-acpi@FreeBSD.ORG Wed Nov 10 15:23:26 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E9DD1065698 for ; Wed, 10 Nov 2010 15:23:26 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B5C418FC13 for ; Wed, 10 Nov 2010 15:23:25 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA22645; Wed, 10 Nov 2010 17:23:22 +0200 (EET) (envelope-from avg@icyb.net.ua) Message-ID: <4CDAB8E9.4050707@icyb.net.ua> Date: Wed, 10 Nov 2010 17:23:21 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.11) Gecko/20101021 Lightning/1.0b2 Thunderbird/3.1.5 MIME-Version: 1.0 To: Mathias Picker References: <1289398030.1762.17.camel@localhost> In-Reply-To: <1289398030.1762.17.camel@localhost> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: freebsd-acpi@freebsd.org Subject: Re: Acer 5553g / Mobile Phenom N930 C-States X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 15:23:26 -0000 on 10/11/2010 16:07 Mathias Picker said the following: > Hi, > > my N930 reports C1 as lowest cpu state: > > mp% sysctl -a|grep cx_supp > dev.cpu.0.cx_supported: C1/0 > dev.cpu.1.cx_supported: C1/0 > dev.cpu.2.cx_supported: C1/0 > dev.cpu.3.cx_supported: C1/0 > > I searched the net, but I can't tell if that's correct. > > The system runs rather loud with FreeBSD (fan running full speed, cpu > temp around 59°C). > > I can't switch off the second graphics card, one of my last ideas of > getting it any cooler would be c2/c3. I've followed every other tip from > TuningPowerConsumption and need still around 3315 mA. Your ACPI tables say that there is no C-state beyond C1. Try installing and booting recent head/CURRENT kernel on that machine. And enable C1E in BIOS. > boot -v output: http://pastebin.com/VWYifahu > acpidump -dt: http://pastebin.com/V82SuzrW > > cpufreq scaling works fine: > > dev.cpu.0.%desc: ACPI CPU > dev.cpu.0.%driver: cpu > dev.cpu.0.%location: handle=\_PR_.C000 > dev.cpu.0.%pnpinfo: _HID=none _UID=0 > dev.cpu.0.%parent: acpi0 > dev.cpu.0.freq: 800 > dev.cpu.0.freq_levels: 2000/7632 1700/5945 1400/4582 1100/3422 800/2328 > dev.cpu.0.temperature: 59,1C > dev.cpu.0.cx_supported: C1/0 > dev.cpu.0.cx_lowest: C1 > dev.cpu.0.cx_usage: 100.00% last 2038us > dev.cpu.1.%desc: ACPI CPU -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 17:20:53 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 910ED106564A for ; Thu, 11 Nov 2010 17:20:53 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id D9AE98FC0C for ; Thu, 11 Nov 2010 17:20:52 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA15988 for ; Thu, 11 Nov 2010 19:20:51 +0200 (EET) (envelope-from avg@freebsd.org) Message-ID: <4CDC25F2.6080409@freebsd.org> Date: Thu, 11 Nov 2010 19:20:50 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: freebsd-acpi@freebsd.org X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 17:20:53 -0000 Dear fellow FreeBSD ACPI hackers, what is your opinion about the following patch? The idea is to add a C1 state to available states if a bugggy BIOS supplies us with _CST that has states with C2, C3, etc types, but no state with C1 type. Thanks! diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c index 3c675df..6c771d9 100644 --- a/sys/dev/acpica/acpi_cpu.c +++ b/sys/dev/acpica/acpi_cpu.c @@ -724,8 +724,21 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) sc->cpu_cx_count++; } } - AcpiOsFree(buf.Pointer); + if (sc->cpu_cx_count > 0 && sc->cpu_cx_states[0].type != ACPI_STATE_C1) { + memmove(&sc->cpu_cx_states[1], &sc->cpu_cx_states[0], + sc->cpu_cx_count * sizeof(sc->cpu_cx_states[0])); + sc->cpu_cx_states[0].type = ACPI_STATE_C1; + sc->cpu_cx_states[0].trans_lat = 0; + sc->cpu_cx_states[0].power = 0; + sc->cpu_cx_states[0].p_lvlx = NULL; + sc->cpu_cx_states[0].res_type = 0; + sc->cpu_cx_count++; + if (sc->cpu_cx_states[1].type <= ACPI_STATE_C2) + sc->cpu_non_c3++; + } + + AcpiOsFree(buf.Pointer); return (0); } -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 18:50:24 2010 Return-Path: Delivered-To: freebsd-acpi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD7411065674; Thu, 11 Nov 2010 18:50:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A40108FC1B; Thu, 11 Nov 2010 18:50:24 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oABIoOYT058296; Thu, 11 Nov 2010 18:50:24 GMT (envelope-from avg@freefall.freebsd.org) Received: (from avg@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oABIoORN058243; Thu, 11 Nov 2010 18:50:24 GMT (envelope-from avg) Date: Thu, 11 Nov 2010 18:50:24 GMT Message-Id: <201011111850.oABIoORN058243@freefall.freebsd.org> To: huntting@hunkular.glarp.com, avg@FreeBSD.org, freebsd-acpi@FreeBSD.org From: avg@FreeBSD.org Cc: Subject: Re: kern/108954: [acpi] 'sleep(1)' sleeps >1 seconds when speedstep (Cx) is in economy mode X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 18:50:24 -0000 Synopsis: [acpi] 'sleep(1)' sleeps >1 seconds when speedstep (Cx) is in economy mode State-Changed-From-To: open->closed State-Changed-By: avg State-Changed-When: Thu Nov 11 18:48:53 UTC 2010 State-Changed-Why: The issue is well understood, the problem should not occur with head code and could be easily worked around in other supported versions of FreeBSD. http://www.freebsd.org/cgi/query-pr.cgi?pr=108954 From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 19:00:22 2010 Return-Path: Delivered-To: freebsd-acpi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC052106566C for ; Thu, 11 Nov 2010 19:00:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B08A98FC17 for ; Thu, 11 Nov 2010 19:00:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oABJ0MqJ066514 for ; Thu, 11 Nov 2010 19:00:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oABJ0M2V066485; Thu, 11 Nov 2010 19:00:22 GMT (envelope-from gnats) Date: Thu, 11 Nov 2010 19:00:22 GMT Message-Id: <201011111900.oABJ0M2V066485@freefall.freebsd.org> To: freebsd-acpi@FreeBSD.org From: Andriy Gapon Cc: Subject: Re: kern/108954: [acpi] 'sleep(1)' sleeps > 1 seconds when speedstep (Cx) is in economy mode X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andriy Gapon List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 19:00:22 -0000 The following reply was made to PR kern/108954; it has been noted by GNATS. From: Andriy Gapon To: bug-followup@FreeBSD.org, huntting@hunkular.glarp.com Cc: Subject: Re: kern/108954: [acpi] 'sleep(1)' sleeps >1 seconds when speedstep (Cx) is in economy mode Date: Thu, 11 Nov 2010 20:47:52 +0200 Can this PR now be closed then? -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 20:20:11 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 187901065670; Thu, 11 Nov 2010 20:20:11 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx1.freebsd.org (Postfix) with ESMTP id E9DFD8FC19; Thu, 11 Nov 2010 20:20:10 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 11 Nov 2010 12:20:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,184,1288594800"; d="scan'208";a="856627660" Received: from orsmsx604.amr.corp.intel.com ([10.22.226.87]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2010 12:20:10 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.226.213) by orsmsx604.amr.corp.intel.com (10.22.226.87) with Microsoft SMTP Server (TLS) id 8.2.254.0; Thu, 11 Nov 2010 12:20:09 -0800 Received: from orsmsx503.amr.corp.intel.com ([10.22.226.47]) by orsmsx601.amr.corp.intel.com ([10.22.226.213]) with mapi; Thu, 11 Nov 2010 12:20:09 -0800 From: "Moore, Robert" To: Andriy Gapon , "freebsd-acpi@freebsd.org" Date: Thu, 11 Nov 2010 12:20:07 -0800 Thread-Topic: fixup for missing C1 in _CST Thread-Index: AcuBxORz1LAEMgu/Q8egzVsasMHDiQAGFrEw Message-ID: <4911F71203A09E4D9981D27F9D830858BC5E94D3@orsmsx503.amr.corp.intel.com> References: <4CDC25F2.6080409@freebsd.org> In-Reply-To: <4CDC25F2.6080409@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Lin, Ming M" Subject: RE: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 20:20:11 -0000 It's not clear to me from reading the ACPI spec that the Cstate sub-package= s are required to be in any specific order. This means that sc->cpu_cx_states[0] Does not necessarily have to be of type ACPI_STATE_C1, if ACPI_STATE_C1 is = present on the machine. (unless the driver has sorted the list already.) This looks like an area where ACPICA could sort the packages by type before= handing off the _CST package to the driver. Bob >-----Original Message----- >From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >acpi@freebsd.org] On Behalf Of Andriy Gapon >Sent: Thursday, November 11, 2010 9:21 AM >To: freebsd-acpi@freebsd.org >Subject: fixup for missing C1 in _CST > > >Dear fellow FreeBSD ACPI hackers, >what is your opinion about the following patch? > >The idea is to add a C1 state to available states if a bugggy BIOS supplie= s >us >with _CST that has states with C2, C3, etc types, but no state with C1 >type. > >Thanks! > >diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c >index 3c675df..6c771d9 100644 >--- a/sys/dev/acpica/acpi_cpu.c >+++ b/sys/dev/acpica/acpi_cpu.c >@@ -724,8 +724,21 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) > sc->cpu_cx_count++; > } > } >- AcpiOsFree(buf.Pointer); > >+ if (sc->cpu_cx_count > 0 && sc->cpu_cx_states[0].type !=3D >ACPI_STATE_C1) { >+ memmove(&sc->cpu_cx_states[1], &sc->cpu_cx_states[0], >+ sc->cpu_cx_count * sizeof(sc->cpu_cx_states[0])); >+ sc->cpu_cx_states[0].type =3D ACPI_STATE_C1; >+ sc->cpu_cx_states[0].trans_lat =3D 0; >+ sc->cpu_cx_states[0].power =3D 0; >+ sc->cpu_cx_states[0].p_lvlx =3D NULL; >+ sc->cpu_cx_states[0].res_type =3D 0; >+ sc->cpu_cx_count++; >+ if (sc->cpu_cx_states[1].type <=3D ACPI_STATE_C2) >+ sc->cpu_non_c3++; >+ } >+ >+ AcpiOsFree(buf.Pointer); > return (0); > } > > >-- >Andriy Gapon >_______________________________________________ >freebsd-acpi@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 20:39:37 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94CB2106564A; Thu, 11 Nov 2010 20:39:37 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.freebsd.org (Postfix) with ESMTP id 6FFD48FC15; Thu, 11 Nov 2010 20:39:37 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 11 Nov 2010 12:39:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,184,1288594800"; d="scan'208";a="856632024" Received: from orsmsx604.amr.corp.intel.com ([10.22.226.87]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2010 12:39:36 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.226.10) by orsmsx604.amr.corp.intel.com (10.22.226.87) with Microsoft SMTP Server (TLS) id 8.2.254.0; Thu, 11 Nov 2010 12:39:36 -0800 Received: from orsmsx503.amr.corp.intel.com ([10.22.226.47]) by orsmsx605.amr.corp.intel.com ([10.22.226.10]) with mapi; Thu, 11 Nov 2010 12:39:36 -0800 From: "Moore, Robert" To: Andriy Gapon , "freebsd-acpi@freebsd.org" Date: Thu, 11 Nov 2010 12:39:35 -0800 Thread-Topic: fixup for missing C1 in _CST Thread-Index: AcuBxORz1LAEMgu/Q8egzVsasMHDiQAGFrEwAADJlaA= Message-ID: <4911F71203A09E4D9981D27F9D830858BC5E9503@orsmsx503.amr.corp.intel.com> References: <4CDC25F2.6080409@freebsd.org> <4911F71203A09E4D9981D27F9D830858BC5E94D3@orsmsx503.amr.corp.intel.com> In-Reply-To: <4911F71203A09E4D9981D27F9D830858BC5E94D3@orsmsx503.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Lin, Ming M" Subject: RE: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 20:39:37 -0000 Oops, missed it. "_CST defines ascending C-states..." Could it be that the problem is that the platform is returning a _CST packa= ge that is not sorted or even is sorted descending? Bob >-----Original Message----- >From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >acpi@freebsd.org] On Behalf Of Moore, Robert >Sent: Thursday, November 11, 2010 12:20 PM >To: Andriy Gapon; freebsd-acpi@freebsd.org >Cc: Lin, Ming M >Subject: RE: fixup for missing C1 in _CST > >It's not clear to me from reading the ACPI spec that the Cstate sub- >packages are required to be in any specific order. > >This means that > >sc->cpu_cx_states[0] > >Does not necessarily have to be of type ACPI_STATE_C1, if ACPI_STATE_C1 is >present on the machine. (unless the driver has sorted the list already.) > >This looks like an area where ACPICA could sort the packages by type befor= e >handing off the _CST package to the driver. > >Bob > > >>-----Original Message----- >>From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >>acpi@freebsd.org] On Behalf Of Andriy Gapon >>Sent: Thursday, November 11, 2010 9:21 AM >>To: freebsd-acpi@freebsd.org >>Subject: fixup for missing C1 in _CST >> >> >>Dear fellow FreeBSD ACPI hackers, >>what is your opinion about the following patch? >> >>The idea is to add a C1 state to available states if a bugggy BIOS >supplies >>us >>with _CST that has states with C2, C3, etc types, but no state with C1 >>type. >> >>Thanks! >> >>diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c >>index 3c675df..6c771d9 100644 >>--- a/sys/dev/acpica/acpi_cpu.c >>+++ b/sys/dev/acpica/acpi_cpu.c >>@@ -724,8 +724,21 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) >> sc->cpu_cx_count++; >> } >> } >>- AcpiOsFree(buf.Pointer); >> >>+ if (sc->cpu_cx_count > 0 && sc->cpu_cx_states[0].type !=3D >>ACPI_STATE_C1) { >>+ memmove(&sc->cpu_cx_states[1], &sc->cpu_cx_states[0], >>+ sc->cpu_cx_count * sizeof(sc->cpu_cx_states[0])); >>+ sc->cpu_cx_states[0].type =3D ACPI_STATE_C1; >>+ sc->cpu_cx_states[0].trans_lat =3D 0; >>+ sc->cpu_cx_states[0].power =3D 0; >>+ sc->cpu_cx_states[0].p_lvlx =3D NULL; >>+ sc->cpu_cx_states[0].res_type =3D 0; >>+ sc->cpu_cx_count++; >>+ if (sc->cpu_cx_states[1].type <=3D ACPI_STATE_C2) >>+ sc->cpu_non_c3++; >>+ } >>+ >>+ AcpiOsFree(buf.Pointer); >> return (0); >> } >> >> >>-- >>Andriy Gapon >>_______________________________________________ >>freebsd-acpi@freebsd.org mailing list >>http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >>To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" >_______________________________________________ >freebsd-acpi@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org" From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 22:17:09 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 472F71065672 for ; Thu, 11 Nov 2010 22:17:09 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 877CD8FC08 for ; Thu, 11 Nov 2010 22:17:08 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA19552; Fri, 12 Nov 2010 00:17:03 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PGfS3-000FRz-GB; Fri, 12 Nov 2010 00:17:03 +0200 Message-ID: <4CDC6B0E.4090507@freebsd.org> Date: Fri, 12 Nov 2010 00:15:42 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: "Moore, Robert" References: <4CDC25F2.6080409@freebsd.org> <4911F71203A09E4D9981D27F9D830858BC5E94D3@orsmsx503.amr.corp.intel.com> <4911F71203A09E4D9981D27F9D830858BC5E9503@orsmsx503.amr.corp.intel.com> In-Reply-To: <4911F71203A09E4D9981D27F9D830858BC5E9503@orsmsx503.amr.corp.intel.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "freebsd-acpi@freebsd.org" , "Lin, Ming M" Subject: Re: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 22:17:09 -0000 on 11/11/2010 22:39 Moore, Robert said the following: > Oops, missed it. > > "_CST defines ascending C-states..." > > Could it be that the problem is that the platform is returning a _CST package that is not sorted or even is sorted descending? In the particular case that I wanted to address _CST returned just one entry with C2 type. I guess that it's hard to enumerate all possible BIOS/vendor bugs :-) -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Thu Nov 11 22:37:39 2010 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 88DB3106564A; Thu, 11 Nov 2010 22:37:39 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-acpi@FreeBSD.org Date: Thu, 11 Nov 2010 17:37:28 -0500 User-Agent: KMail/1.6.2 References: <4CDC25F2.6080409@freebsd.org> In-Reply-To: <4CDC25F2.6080409@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Multipart/Mixed; boundary="Boundary-00=_sAH3MdBLPPS3Zg/" Message-Id: <201011111737.32399.jkim@FreeBSD.org> Cc: Andriy Gapon Subject: Re: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 22:37:39 -0000 --Boundary-00=_sAH3MdBLPPS3Zg/ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thursday 11 November 2010 12:20 pm, Andriy Gapon wrote: > Dear fellow FreeBSD ACPI hackers, > what is your opinion about the following patch? > > The idea is to add a C1 state to available states if a bugggy BIOS > supplies us with _CST that has states with C2, C3, etc types, but > no state with C1 type. Can you please try the attached patch instead? Thanks, Jung-uk Kim --Boundary-00=_sAH3MdBLPPS3Zg/ Content-Type: text/plain; charset="iso-8859-1"; name="acpi_cpu.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="acpi_cpu.diff" Index: sys/dev/acpica/acpi_cpu.c =================================================================== --- sys/dev/acpica/acpi_cpu.c (revision 215135) +++ sys/dev/acpica/acpi_cpu.c (working copy) @@ -635,12 +635,13 @@ acpi_cpu_generic_cx_probe(struct acpi_cpu_softc *s static int acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) { + static const struct acpi_cx def_c1 = { .type = ACPI_STATE_C1 }; struct acpi_cx *cx_ptr; ACPI_STATUS status; ACPI_BUFFER buf; ACPI_OBJECT *top; ACPI_OBJECT *pkg; - uint32_t count; + uint32_t count, power, trans_lat, type; int i; ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); @@ -671,23 +672,29 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) /* Set up all valid states. */ sc->cpu_cx_count = 0; cx_ptr = sc->cpu_cx_states; + *cx_ptr = def_c1; + sc->cpu_non_c3 = 0; + if ((AcpiGbl_FADT.Flags & ACPI_FADT_C1_SUPPORTED) != 0) + sc->cpu_cx_count++; + cx_ptr++; for (i = 0; i < count; i++) { pkg = &top->Package.Elements[i + 1]; if (!ACPI_PKG_VALID(pkg, 4) || - acpi_PkgInt32(pkg, 1, &cx_ptr->type) != 0 || - acpi_PkgInt32(pkg, 2, &cx_ptr->trans_lat) != 0 || - acpi_PkgInt32(pkg, 3, &cx_ptr->power) != 0) { + acpi_PkgInt32(pkg, 1, &type) != 0 || + acpi_PkgInt32(pkg, 2, &trans_lat) != 0 || + acpi_PkgInt32(pkg, 3, &power) != 0) { device_printf(sc->cpu_dev, "skipping invalid Cx state package\n"); continue; } /* Validate the state to see if we should use it. */ - switch (cx_ptr->type) { + switch (type) { case ACPI_STATE_C1: - sc->cpu_non_c3 = i; - cx_ptr++; - sc->cpu_cx_count++; + sc->cpu_cx_states[0].trans_lat = trans_lat; + sc->cpu_cx_states[0].power = power; + if ((AcpiGbl_FADT.Flags & ACPI_FADT_C1_SUPPORTED) == 0) + sc->cpu_cx_count++; continue; case ACPI_STATE_C2: sc->cpu_non_c3 = i; @@ -716,6 +723,9 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) &cx_ptr->p_lvlx, RF_SHAREABLE); if (cx_ptr->p_lvlx) { sc->cpu_rid++; + cx_ptr->type = type; + cx_ptr->trans_lat = trans_lat; + cx_ptr->power = power; ACPI_DEBUG_PRINT((ACPI_DB_INFO, "acpi_cpu%d: Got C%d - %d latency\n", device_get_unit(sc->cpu_dev), cx_ptr->type, --Boundary-00=_sAH3MdBLPPS3Zg/-- From owner-freebsd-acpi@FreeBSD.ORG Fri Nov 12 01:48:39 2010 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 124591065672; Fri, 12 Nov 2010 01:48:39 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-acpi@FreeBSD.org Date: Thu, 11 Nov 2010 20:48:28 -0500 User-Agent: KMail/1.6.2 References: <4CDC25F2.6080409@freebsd.org> <201011111737.32399.jkim@FreeBSD.org> In-Reply-To: <201011111737.32399.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Multipart/Mixed; boundary="Boundary-00=_vzJ3MiMq5bzGAN1" Message-Id: <201011112048.31127.jkim@FreeBSD.org> Cc: Andriy Gapon Subject: Re: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2010 01:48:39 -0000 --Boundary-00=_vzJ3MiMq5bzGAN1 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thursday 11 November 2010 05:37 pm, Jung-uk Kim wrote: > On Thursday 11 November 2010 12:20 pm, Andriy Gapon wrote: > > Dear fellow FreeBSD ACPI hackers, > > what is your opinion about the following patch? > > > > The idea is to add a C1 state to available states if a bugggy > > BIOS supplies us with _CST that has states with C2, C3, etc > > types, but no state with C1 type. > > Can you please try the attached patch instead? It seems C1 state became mandatory years ago. Please ignore the previous patches and try this instead. Thanks! Jung-uk Kim --Boundary-00=_vzJ3MiMq5bzGAN1 Content-Type: text/plain; charset="iso-8859-1"; name="acpi_cpu3.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="acpi_cpu3.diff" Index: sys/dev/acpica/acpi_cpu.c =================================================================== --- sys/dev/acpica/acpi_cpu.c (revision 215135) +++ sys/dev/acpica/acpi_cpu.c (working copy) @@ -668,9 +668,19 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) count = MAX_CX_STATES; } - /* Set up all valid states. */ + sc->cpu_non_c3 = 0; sc->cpu_cx_count = 0; cx_ptr = sc->cpu_cx_states; + + /* + * C1 has been required since just after ACPI 1.0. + * Reserve the first slot for it. + */ + cx_ptr->type = ACPI_STATE_C0; + cx_ptr++; + sc->cpu_cx_count++; + + /* Set up all valid states. */ for (i = 0; i < count; i++) { pkg = &top->Package.Elements[i + 1]; if (!ACPI_PKG_VALID(pkg, 4) || @@ -685,9 +695,14 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) /* Validate the state to see if we should use it. */ switch (cx_ptr->type) { case ACPI_STATE_C1: - sc->cpu_non_c3 = i; - cx_ptr++; - sc->cpu_cx_count++; + if (sc->cpu_cx_states[0].type == ACPI_STATE_C0) { + /* This is the first C1 state. Use the reserved slot. */ + sc->cpu_cx_states[0] = *cx_ptr; + } else { + sc->cpu_non_c3 = i; + cx_ptr++; + sc->cpu_cx_count++; + } continue; case ACPI_STATE_C2: sc->cpu_non_c3 = i; @@ -726,6 +741,13 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc) } AcpiOsFree(buf.Pointer); + /* If C1 state was not found, we need one now. */ + cx_ptr = sc->cpu_cx_states; + if (cx_ptr->type == ACPI_STATE_C0) { + cx_ptr->type = ACPI_STATE_C1; + cx_ptr->trans_lat = 0; + } + return (0); } --Boundary-00=_vzJ3MiMq5bzGAN1-- From owner-freebsd-acpi@FreeBSD.ORG Fri Nov 12 06:44:19 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 596561065673; Fri, 12 Nov 2010 06:44:19 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 70CA68FC15; Fri, 12 Nov 2010 06:44:18 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA24079; Fri, 12 Nov 2010 08:44:16 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PGnMu-000I7r-J6; Fri, 12 Nov 2010 08:44:16 +0200 Message-ID: <4CDCE1F0.9010806@freebsd.org> Date: Fri, 12 Nov 2010 08:42:56 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Jung-uk Kim References: <4CDC25F2.6080409@freebsd.org> <201011111737.32399.jkim@FreeBSD.org> <201011112048.31127.jkim@FreeBSD.org> In-Reply-To: <201011112048.31127.jkim@FreeBSD.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2010 06:44:19 -0000 on 12/11/2010 03:48 Jung-uk Kim said the following: > On Thursday 11 November 2010 05:37 pm, Jung-uk Kim wrote: >> On Thursday 11 November 2010 12:20 pm, Andriy Gapon wrote: >>> Dear fellow FreeBSD ACPI hackers, >>> what is your opinion about the following patch? >>> >>> The idea is to add a C1 state to available states if a bugggy >>> BIOS supplies us with _CST that has states with C2, C3, etc >>> types, but no state with C1 type. >> >> Can you please try the attached patch instead? > > It seems C1 state became mandatory years ago. Please ignore the > previous patches and try this instead. > The patch looks OK to me. -- Andriy Gapon From owner-freebsd-acpi@FreeBSD.ORG Fri Nov 12 17:12:00 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id AA84B106566C; Fri, 12 Nov 2010 17:11:59 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Andriy Gapon Date: Fri, 12 Nov 2010 12:11:44 -0500 User-Agent: KMail/1.6.2 References: <4CDC25F2.6080409@freebsd.org> <201011112048.31127.jkim@FreeBSD.org> <4CDCE1F0.9010806@freebsd.org> In-Reply-To: <4CDCE1F0.9010806@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011121211.46833.jkim@FreeBSD.org> Cc: freebsd-acpi@freebsd.org Subject: Re: fixup for missing C1 in _CST X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2010 17:12:00 -0000 On Friday 12 November 2010 01:42 am, Andriy Gapon wrote: > on 12/11/2010 03:48 Jung-uk Kim said the following: > > On Thursday 11 November 2010 05:37 pm, Jung-uk Kim wrote: > >> On Thursday 11 November 2010 12:20 pm, Andriy Gapon wrote: > >>> Dear fellow FreeBSD ACPI hackers, > >>> what is your opinion about the following patch? > >>> > >>> The idea is to add a C1 state to available states if a bugggy > >>> BIOS supplies us with _CST that has states with C2, C3, etc > >>> types, but no state with C1 type. > >> > >> Can you please try the attached patch instead? > > > > It seems C1 state became mandatory years ago. Please ignore the > > previous patches and try this instead. > > The patch looks OK to me. Committed as r215188. Thanks! Jung-uk Kim