From owner-freebsd-gnome@FreeBSD.ORG Sun Aug 29 09:29:44 2010 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BF4E10656A8; Sun, 29 Aug 2010 09:29:44 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B27D38FC19; Sun, 29 Aug 2010 09:29:43 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA17228; Sun, 29 Aug 2010 12:29:42 +0300 (EEST) (envelope-from avg@icyb.net.ua) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1OpeCr-000Atm-T4; Sun, 29 Aug 2010 12:29:41 +0300 Message-ID: <4C7A2885.9000306@icyb.net.ua> Date: Sun, 29 Aug 2010 12:29:41 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.8) Gecko/20100822 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Joe Marcus Clarke References: <20100827001412.C8B381CC3A@ptavv.es.net> <4C79635A.7030101@freebsd.org> <4C796B4E.8020704@icyb.net.ua> <4C798B36.3040300@freebsd.org> In-Reply-To: <4C798B36.3040300@freebsd.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: ports/149134: x11/gnome2 unable to unmount UFS file system X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2010 09:29:44 -0000 on 29/08/2010 01:18 Joe Marcus Clarke said the following: > On 8/28/10 4:02 PM, Andriy Gapon wrote: >> on 28/08/2010 22:28 Joe Marcus Clarke said the following: >>> >>> Try http://www.marcuscom.com/downloads/patch-hald_hf-storage.c >> >> Just wondering aloud... Would the same strange things (mentioned in the comment >> in the patch) happen with labels for other filesystems like msdos/ cd9660/ ? >> Or it's something specific to UFS? >> > > Yeah, it could happen for other labels, I suppose. The problem is that > the labels that appear dynamically depending oh whether or not a device > is mounted confuses hal. If someone mounts /dev/cd0, unmounts it, then > sees /dev/cd9660/FREEBSD appear, that will cause hal to think a new > device was inserted. > > That said, I've only seen this happen with UFS. BTW, there seems to be an exclamation mark missing in the following part of the patch (hope you use monospaced font): + ! strcmp(fields[1], "PART")) && + ! (strncmp(fields[2], "ufsid/", strlen("ufsid/")) || Here----------^ + ! strncmp(fields[2], "ufs/", strlen("ufs/")))) -- Andriy Gapon