From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 08:04:56 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06C43106564A; Mon, 19 Dec 2011 08:04:56 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D0F6C8FC0A; Mon, 19 Dec 2011 08:04:55 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBJ84tnL039826; Mon, 19 Dec 2011 08:04:55 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBJ84tKu039822; Mon, 19 Dec 2011 08:04:55 GMT (envelope-from linimon) Date: Mon, 19 Dec 2011 08:04:55 GMT Message-Id: <201112190804.pBJ84tKu039822@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/163321: [rc.conf] [patch] allow _fib syntax in rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2011 08:04:56 -0000 Old Synopsis: allow _fib syntax in rc.conf New Synopsis: [rc.conf] [patch] allow _fib syntax in rc.conf Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Mon Dec 19 08:04:27 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=163321 From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 11:07:13 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 709AC1065670 for ; Mon, 19 Dec 2011 11:07:13 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5D5C58FC0C for ; Mon, 19 Dec 2011 11:07:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBJB7DV2011050 for ; Mon, 19 Dec 2011 11:07:13 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBJB7CJu011048 for freebsd-rc@FreeBSD.org; Mon, 19 Dec 2011 11:07:12 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 19 Dec 2011 11:07:12 GMT Message-Id: <201112191107.pBJB7CJu011048@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2011 11:07:13 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/109272 rc [request] increase default rc shutdown timeout o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 92 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 13:05:09 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07F081065672; Mon, 19 Dec 2011 13:05:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 25FE38FC0C; Mon, 19 Dec 2011 13:05:07 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA06356; Mon, 19 Dec 2011 15:05:06 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Rcctt-000FzC-KI; Mon, 19 Dec 2011 15:05:05 +0200 Message-ID: <4EEF3680.8010601@FreeBSD.org> Date: Mon, 19 Dec 2011 15:05:04 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111206 Thunderbird/8.0 MIME-Version: 1.0 To: Doug Barton References: <4ED2378B.2080601@FreeBSD.org> <4ED2983B.5050800@FreeBSD.org> In-Reply-To: <4ED2983B.5050800@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: rc.d/watchdogd: a suggestion X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2011 13:05:09 -0000 on 27/11/2011 22:06 Doug Barton said the following: > On 11/27/2011 5:13 AM, Andriy Gapon wrote: >> >> I have a suggestion to start watchdogd a little bit earlier than it is done now, >> and correspondingly to stop it a little bit later during shutdown: > > I have no particular opinion on changing the timing, but you haven't > said why you want to do it. > >> @@ -28,7 +28,8 @@ >> # >> >> # PROVIDE: watchdogd >> -# REQUIRE: DAEMON cleanvar >> +# REQUIRE: FILESYSTEMS syslogd cleanvar >> +# BEFORE: SERVERS > > Ideally base scripts should not use BEFORE. Change REQUIRE in SERVERS > instead. BTW, etc/rc.d/syslogd is a counter-example to this rule for some reason. -- Andriy Gapon From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 23:20:29 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 0284C106568D; Mon, 19 Dec 2011 23:20:29 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id B3BC6163730; Mon, 19 Dec 2011 23:20:28 +0000 (UTC) Message-ID: <4EEFC6BC.3070903@FreeBSD.org> Date: Mon, 19 Dec 2011 15:20:28 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Andriy Gapon References: <4ED2378B.2080601@FreeBSD.org> <4ED2983B.5050800@FreeBSD.org> <4EEF3680.8010601@FreeBSD.org> In-Reply-To: <4EEF3680.8010601@FreeBSD.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: rc.d/watchdogd: a suggestion X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2011 23:20:29 -0000 On 12/19/2011 05:05, Andriy Gapon wrote: > on 27/11/2011 22:06 Doug Barton said the following: >> On 11/27/2011 5:13 AM, Andriy Gapon wrote: >>> >>> I have a suggestion to start watchdogd a little bit earlier than it is done now, >>> and correspondingly to stop it a little bit later during shutdown: >> >> I have no particular opinion on changing the timing, but you haven't >> said why you want to do it. >> >>> @@ -28,7 +28,8 @@ >>> # >>> >>> # PROVIDE: watchdogd >>> -# REQUIRE: DAEMON cleanvar >>> +# REQUIRE: FILESYSTEMS syslogd cleanvar >>> +# BEFORE: SERVERS >> >> Ideally base scripts should not use BEFORE. Change REQUIRE in SERVERS >> instead. > > BTW, etc/rc.d/syslogd is a counter-example to this rule for some reason. Yes, there are a few of those for hysterical raisins. $SOMEDAY I'll get around to changing them. :) Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Dec 23 14:42:21 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7275A1065670; Fri, 23 Dec 2011 14:42:21 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id EE39F8FC0A; Fri, 23 Dec 2011 14:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=PrxaH39J0KZ+x9VdDLb+FFSxRqDeNW3iKPkODvmkYYc=; b=jIwtIR5wMSj65oqcElHMgZ1Rgew91KhHVXl3gyyF5aA/Zcipur12+4dvFqPz9neDXhG8L9qadgAIioVXRdUjsWJmmashw2ln8uLN3++F8fTYzXP6OsMls5oR5LqEN9vtk28cjnnq7tUIo8ma9vZU5GBdZtFgfaCW5i1+esSfZDNDrNknADV1yXP3NiwKRgmMs/z/MfGhUGO/qC4JhdhZB4pX1nq4sRLTBM4qniQrUKyW6YrKuPqBPGcnFAsHqatuRpV4cZ1DAzlJ8eZJrYdgL1GdBYqrV0p289mBQJ6LsMcGEBa3IVbEvjeRP6M3c17fiSdxRNEmE+wjnqhNpoAGfQ==; Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1Re6KA-000Hvn-Lw; Fri, 23 Dec 2011 17:42:18 +0300 Date: Fri, 23 Dec 2011 18:42:15 +0400 From: Eygene Ryabinkin To: Mike Telahun Makonnen Message-ID: References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p2pkNiL1PnZBJ6Nr" Content-Disposition: inline In-Reply-To: Sender: rea@codelabs.ru Cc: Pyun Yong-Hyeon , Doug Barton , freebsd-rc@freebsd.org, Garrett Cooper , Gleb Smirnoff , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 14:42:21 -0000 --p2pkNiL1PnZBJ6Nr Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Resurrecting this old thread I abandoned due to the ENOTIME and adding to CC all people who were expressed interest in fixing the annoyances =66rom the devd caused by r226879. Sun, Nov 20, 2011 at 12:41:22PM +0300, Mike Telahun Makonnen wrote: > > I would say that my (ab)use of it in the patch perfectly fits the > > cited usage. =9AThat's not an excuse if the semantics of rc_quiet will > > be different from its current usage, but since we have no > > well-documented semantics apart from "Don't output some diagnostics" > > inside /etc/rc.subr, may be we can just extend this explanation based > > on the current usage and the common sense, add that to the manual page > > of rc.subr and go on? > > > > Any thoughts on this? >=20 > The rc_quiet knob was introduced to prevent devd spamming the console > when starting services that weren't enabled in rc.conf. It was also > overloaded to prevent unnecessary boot time clutter on the console. > The rationale was that if you set a service to start during boot you > don't want a gazillion "bar started" messages to cause the one "Error: > foo not started" message that you would really be interested in seeing > to scroll out of the screen buffer. It was used for this purpose in > several scripts in rc.d, but it caused quite a ruckus at the time (and > I was too distracted by other work to continue working on it) so its > use was mostly removed from the scripts under /etc/rc.d. OK, what about the following patch that documents the current usage of the "quiet" prefix and enables dhclient to recognize this modifier? Diff is available from http://codelabs.ru/fbsd/patches/dhclient/dhclient-respect-quiet-mode.diff Since the current rc.subr script has the following snippet, {{{ if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" -a "$rc_arg" != =3D "stop" ] || [ -n "${rcvar}" -a "$rc_arg" =3D "stop" -a -z "${rc_pid= }" ]; then if ! checkyesno ${rcvar}; then if [ -n "${rc_quiet}" ]; then return 0 fi echo -n "Cannot '${rc_arg}' $name. Set ${rc= var} to " echo -n "YES in /etc/rc.conf or use 'one${r= c_arg}' " echo "instead of '${rc_arg}'." return 0 fi fi }}} I think that error message about non-DHCP-enabled interface falls into the same category -- we have no "dhcp" modifier inside rc.conf, so we will fail loudly, unless we were asked to be quiet, just as in the above code. > It was not intended to mask "error" or "debug" messages. It is not my intention as well: I care about masking only certain classes of error and informational messages with rc_quiet; my patch to rc.subr.8 documents all current cases where it is appropriate. > As far as I can tell this discussion affects two groups of people: > 1. You didn't configure dhcp on an interface > 2. You *thought* you configured an interface for dhcp but it's not > getting an address and there is no feedback > if you're in group 1 you *don't* want to see a message that says the > interface is not configured for dhcp. > If you're in group 2 you *do" want to know. >=20 > So, is it more annoying for those in group 1 to get a message about > dhcp not being set every time an interface is started or for those in > group 2 to try to start an interface and not get any feedback when > dhcp is not enabled? The problem with the first group of people is a bit different, because people who didn't configured DHCP are getting notifications only from devd, because it reacts on every "interface up" event by invoking dhclient rc.d script on the interface. But here we have the "quiet" prefix handy. The second group's problem is the one you pronounced. And I think that people should have diagnostics in this case no matter what. It is the internal problem of the devd that spams the first group of people, but it shouldn't be fixed by not letting the second group of people to see the real error message and scratching their heads. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --p2pkNiL1PnZBJ6Nr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk70k0cACgkQFq+eroFS7PuaFwEAlF9kMsvnDEO9mVxbIxd5uDwI vcIXltnwXjAzKPAqdxAA/RA+JwuOpePhDsVO5MRiidjtuGLjk6EgRnjO0QeDfILx =iSrQ -----END PGP SIGNATURE----- --p2pkNiL1PnZBJ6Nr-- From owner-freebsd-rc@FreeBSD.ORG Fri Dec 23 17:17:18 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 378C21065689 for ; Fri, 23 Dec 2011 17:17:18 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id EFD318FC24 for ; Fri, 23 Dec 2011 17:17:17 +0000 (UTC) Received: from pps.filterd (ltcfislmsgpa06 [127.0.0.1]) by ltcfislmsgpa06.fnfis.com (8.14.4/8.14.4) with SMTP id pBNGT94p016760 for ; Fri, 23 Dec 2011 11:17:16 -0600 Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa06.fnfis.com with ESMTP id 11vvtk89hp-5 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Fri, 23 Dec 2011 11:17:16 -0600 Received: from [10.0.0.103] (10.14.152.38) by smtp.fisglobal.com (10.132.206.17) with Microsoft SMTP Server (TLS) id 14.1.323.3; Fri, 23 Dec 2011 11:17:15 -0600 From: Devin Teske Content-Type: multipart/mixed; boundary="Apple-Mail-38-608566932" Date: Fri, 23 Dec 2011 09:17:14 -0800 Message-ID: To: FreeBSD RC MIME-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) X-Originating-IP: [10.14.152.38] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-23_05:2011-12-23, 2011-12-23, 1970-01-01 signatures=0 Cc: Dave Robison Subject: rc.d/named default pidfile X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 17:17:18 -0000 --Apple-Mail-38-608566932 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Working on named(8) with a co-worker yesterday, we were surprised to see wh= at appears to be a typo in the rc.d script in FreeBSD-8.1. Please find attached a patch for HEAD (not FreeBSD-8.1; the typo still exis= ts in HEAD). _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. --Apple-Mail-38-608566932 Content-Disposition: attachment; filename="named.patch" Content-Type: application/octet-stream; name="named.patch" Content-Transfer-Encoding: 7bit --- HEAD/src/etc/rc.d/named.orig Sun May 15 20:25:41 2011 +++ HEAD/src/etc/rc.d/named Fri Dec 23 08:50:17 2011 @@ -117,7 +117,7 @@ find_pidfile() if get_pidfile_from_conf pid-file $named_conf; then pidfile="$_pidfile_from_conf" else - pidfile="/var/run/named/pid" + pidfile="/var/run/named.pid" fi } --Apple-Mail-38-608566932 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Details/History: In FreeBSD-8.1, the rc.d script declares named(8) isn't running when = it-is because the default pidfile is incorrectly "/var/run/named/pid" = when the program itself writes "/var/run/named.pid" (notice the trailing = ".pid" versus "/pid"). In SVN rev 220962 the rc.d script was changed by dougb to dynamically = determine the pidfile location from the configuration file. When this = patch was applied, the rc.d script started working again w/respect to = "status" (accurately reported when named(8) was/wasn't running). = Unfortunately, the typo still exists (see patch for HEAD). I would like to request that this patch be made against HEAD, and the = changes be MFC'd to stable/8, ultimately to be ready for the release/8.3 = branch when copied (we're planning on skipping 8.2 and jumping to 8.3 as = our next release; currently being on 8.1). Aside: On FreeBSD-8.1, if someone wants to make the appropriate fix, the change = must be made in two places. src/etc/rc.d/named and = src/etc/defaults/rc.conf Work-around in FreeBSD-8.1 and older (not sure about 8.2, but RELENG_8 = appears to have received SVN rev 220962 so named_pidfile no longer has = any effect): Add named_pidfile=3D"/var/run/named.pid" to your rc.conf(5) --=20 Devin= --Apple-Mail-38-608566932-- From owner-freebsd-rc@FreeBSD.ORG Fri Dec 23 21:14:48 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id A4EE3106564A; Fri, 23 Dec 2011 21:14:48 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 4BABE14EE47; Fri, 23 Dec 2011 21:14:48 +0000 (UTC) Message-ID: <4EF4EF48.9010503@FreeBSD.org> Date: Fri, 23 Dec 2011 13:14:48 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Pyun Yong-Hyeon , freebsd-rc@freebsd.org, Garrett Cooper , Gleb Smirnoff , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 21:14:48 -0000 Short version, my opinion has not changed, there is no bug. On 12/23/2011 06:42, Eygene Ryabinkin wrote: > Resurrecting this old thread I abandoned due to the ENOTIME and adding > to CC all people who were expressed interest in fixing the annoyances > from the devd caused by r226879. > > Sun, Nov 20, 2011 at 12:41:22PM +0300, Mike Telahun Makonnen wrote: >>> I would say that my (ab)use of it in the patch perfectly fits the >>> cited usage. That's not an excuse if the semantics of rc_quiet will >>> be different from its current usage, but since we have no >>> well-documented semantics apart from "Don't output some diagnostics" >>> inside /etc/rc.subr, may be we can just extend this explanation based >>> on the current usage and the common sense, add that to the manual page >>> of rc.subr and go on? >>> >>> Any thoughts on this? >> >> The rc_quiet knob was introduced to prevent devd spamming the console >> when starting services that weren't enabled in rc.conf. It was also >> overloaded to prevent unnecessary boot time clutter on the console. >> The rationale was that if you set a service to start during boot you >> don't want a gazillion "bar started" messages to cause the one "Error: >> foo not started" message that you would really be interested in seeing >> to scroll out of the screen buffer. It was used for this purpose in >> several scripts in rc.d, but it caused quite a ruckus at the time (and >> I was too distracted by other work to continue working on it) so its >> use was mostly removed from the scripts under /etc/rc.d. > > OK, what about the following patch that documents the current usage of > the "quiet" prefix and enables dhclient to recognize this modifier? > Diff is available from > http://codelabs.ru/fbsd/patches/dhclient/dhclient-respect-quiet-mode.diff > > Since the current rc.subr script has the following snippet, > {{{ > if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" -a "$rc_arg" != "stop" ] || > [ -n "${rcvar}" -a "$rc_arg" = "stop" -a -z "${rc_pid}" ]; then > if ! checkyesno ${rcvar}; then > if [ -n "${rc_quiet}" ]; then > return 0 > fi > echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > echo "instead of '${rc_arg}'." > return 0 > fi > fi > }}} You're misunderstanding the purpose of the above code. It's there so that you can do 'service foo stop' even if foo_enable is not set. > I think that error message about non-DHCP-enabled interface falls into the > same category It does not. > -- we have no "dhcp" modifier inside rc.conf, so we will fail > loudly, unless we were asked to be quiet, just as in the above code. > >> It was not intended to mask "error" or "debug" messages. > > It is not my intention as well: I care about masking only certain classes > of error and informational messages with rc_quiet; my patch to rc.subr.8 > documents all current cases where it is appropriate. Our opinions differ on this point. > It is the > internal problem of the devd that spams the first group of people So adjust devd.conf. -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Dec 23 23:47:30 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 2F011106564A for ; Fri, 23 Dec 2011 23:47:30 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id AD5A6150EC4; Fri, 23 Dec 2011 23:47:29 +0000 (UTC) Message-ID: <4EF51311.5040503@FreeBSD.org> Date: Fri, 23 Dec 2011 15:47:29 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Devin Teske References: In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD RC , Dave Robison Subject: Re: rc.d/named default pidfile X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 23:47:30 -0000 On 12/23/2011 09:17, Devin Teske wrote: > Working on named(8) with a co-worker yesterday, we were surprised to see what appears to be a typo in the rc.d script in FreeBSD-8.1. It's not a typo. The default location in FreeBSD, as specified in the default named.conf for a very long time, is /var/run/named/pid. If you choose to deviate from that you need to put the pidfile location in your named.conf file (as you pointed out in your message, and which you should be doing anyway). hth, Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 01:12:14 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6332A106564A; Sat, 24 Dec 2011 01:12:14 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 122348FC14; Sat, 24 Dec 2011 01:12:13 +0000 (UTC) Received: from pps.filterd (ltcfislmsgpa04 [127.0.0.1]) by ltcfislmsgpa04.fnfis.com (8.14.4/8.14.4) with SMTP id pBO0QmtJ014648; Fri, 23 Dec 2011 19:12:13 -0600 Received: from smtp.fisglobal.com ([10.132.206.31]) by ltcfislmsgpa04.fnfis.com with ESMTP id 11w1y80er0-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 23 Dec 2011 19:12:13 -0600 Received: from [10.0.0.102] (10.14.152.38) by smtp.fisglobal.com (10.132.206.31) with Microsoft SMTP Server (TLS) id 14.1.323.3; Fri, 23 Dec 2011 19:12:11 -0600 References: <4EF51311.5040503@FreeBSD.org> In-Reply-To: <4EF51311.5040503@FreeBSD.org> MIME-Version: 1.0 (iPad Mail 8J2) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Message-ID: <0100C84A-4EF2-4D88-B361-1D50EB16E33B@fisglobal.com> X-Mailer: iPad Mail (8J2) From: Devin Teske Date: Fri, 23 Dec 2011 17:13:58 -0800 To: Doug Barton X-Originating-IP: [10.14.152.38] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-23_08:2011-12-23, 2011-12-23, 1970-01-01 signatures=0 Cc: FreeBSD RC , Dave Robison Subject: * Re: rc.d/named default pidfile X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 01:12:14 -0000 On Dec 23, 2011, at 3:47 PM, Doug Barton wrote: > On 12/23/2011 09:17, Devin Teske wrote: >> Working on named(8) with a co-worker yesterday, we were surprised to see= what appears to be a typo in the rc.d script in FreeBSD-8.1. >=20 > It's not a typo. You're right. Someone that came before us had customized the value. Thanks Doug. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 02:00:17 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E7FF1065670; Sat, 24 Dec 2011 02:00:17 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D25D38FC0C; Sat, 24 Dec 2011 02:00:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBO20GJu048748; Sat, 24 Dec 2011 02:00:16 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBO20GlD048744; Sat, 24 Dec 2011 02:00:16 GMT (envelope-from linimon) Date: Sat, 24 Dec 2011 02:00:16 GMT Message-Id: <201112240200.pBO20GlD048744@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 02:00:17 -0000 Old Synopsis: [patch] Add "enable" and "disable" commands to rc.subr New Synopsis: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Sat Dec 24 01:59:19 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=163508 From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 02:02:49 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0E56106566C; Sat, 24 Dec 2011 02:02:49 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AE62F8FC0A; Sat, 24 Dec 2011 02:02:49 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBO22n2O057105; Sat, 24 Dec 2011 02:02:49 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBO22n9Z057101; Sat, 24 Dec 2011 02:02:49 GMT (envelope-from linimon) Date: Sat, 24 Dec 2011 02:02:49 GMT Message-Id: <201112240202.pBO22n9Z057101@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/163488: Confusing explanation in defaults/rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 02:02:50 -0000 Synopsis: Confusing explanation in defaults/rc.conf Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Sat Dec 24 02:02:42 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=163488 From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 02:20:11 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88C6E106564A for ; Sat, 24 Dec 2011 02:20:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 77F2E8FC0A for ; Sat, 24 Dec 2011 02:20:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBO2KB0p067718 for ; Sat, 24 Dec 2011 02:20:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBO2KBvP067717; Sat, 24 Dec 2011 02:20:11 GMT (envelope-from gnats) Date: Sat, 24 Dec 2011 02:20:11 GMT Message-Id: <201112240220.pBO2KBvP067717@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Doug Barton Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Doug Barton List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 02:20:11 -0000 The following reply was made to PR conf/163508; it has been noted by GNATS. From: Doug Barton To: bug-followup@FreeBSD.org, gelraen.ua@gmail.com Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Date: Fri, 23 Dec 2011 18:15:24 -0800 This idea has been considered before and rejected because it's too difficult to catch all the corner cases, and actually editing a config file is not really all that hard of a thing to do. Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 02:50:12 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F5C4106566C for ; Sat, 24 Dec 2011 02:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 135DC8FC13 for ; Sat, 24 Dec 2011 02:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBO2oBAT095461 for ; Sat, 24 Dec 2011 02:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBO2oBHa095460; Sat, 24 Dec 2011 02:50:11 GMT (envelope-from gnats) Date: Sat, 24 Dec 2011 02:50:11 GMT Message-Id: <201112240250.pBO2oBHa095460@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Devin Teske Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Devin Teske List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 02:50:12 -0000 The following reply was made to PR conf/163508; it has been noted by GNATS. From: Devin Teske To: , Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Date: Fri, 23 Dec 2011 18:34:45 -0800 --Apple-Mail-39-642018807 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii" I agree with dougb that this is out of scope. If you want though, check out the following to solve your needs: http://druidbsd.sourceforge.net/download/sysrc.txt A utility with sysctl(8)-like syntax that operates on rc.conf(5). -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. --Apple-Mail-39-642018807 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset="us-ascii"
I agree with dougb that this is out of scope.

If you want though, check out the following to solve your needs:


A utility with sysctl(8)-like syntax that operates on rc.conf(5).
-- 
Devin
_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
--Apple-Mail-39-642018807-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 08:06:20 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E398F106564A; Sat, 24 Dec 2011 08:06:20 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 5B0378FC0A; Sat, 24 Dec 2011 08:06:20 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id pBO86Irr005871; Sat, 24 Dec 2011 12:06:18 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id pBO86Iuu005870; Sat, 24 Dec 2011 12:06:18 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 24 Dec 2011 12:06:18 +0400 From: Gleb Smirnoff To: Doug Barton Message-ID: <20111224080617.GM80057@glebius.int.ru> References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> <4EF4EF48.9010503@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4EF4EF48.9010503@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Pyun Yong-Hyeon , freebsd-rc@FreeBSD.org, Garrett Cooper , Eygene Ryabinkin , d@delphij.net, Mike Telahun Makonnen Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 08:06:21 -0000 On Fri, Dec 23, 2011 at 01:14:48PM -0800, Doug Barton wrote: D> > It is the D> > internal problem of the devd that spams the first group of people D> D> So adjust devd.conf. Do you suggest to adjust devd.conf in svn, or do you think that zillions of server FreeBSD installations should modify the default devd.conf to get rid of this spamming? The latter isn't a good idea. As well as disabling a nice feature for notebooks in devd.conf. I see Eygene's patch a good compromise for both kinds of installation, both work, and don't have message spamming. -- Totus tuus, Glebius. From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 08:14:23 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id E17B2106564A; Sat, 24 Dec 2011 08:14:23 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6D3271506F5; Sat, 24 Dec 2011 08:14:23 +0000 (UTC) Message-ID: <4EF589DF.9060606@FreeBSD.org> Date: Sat, 24 Dec 2011 00:14:23 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Gleb Smirnoff References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> <4EF4EF48.9010503@FreeBSD.org> <20111224080617.GM80057@glebius.int.ru> In-Reply-To: <20111224080617.GM80057@glebius.int.ru> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Pyun Yong-Hyeon , freebsd-rc@FreeBSD.org, Garrett Cooper , Eygene Ryabinkin , d@delphij.net, Mike Telahun Makonnen Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 08:14:24 -0000 On 12/24/2011 00:06, Gleb Smirnoff wrote: > Do you suggest to adjust devd.conf in svn, or do you think that > zillions of server FreeBSD installations should modify the default > devd.conf to get rid of this spamming? There are zillions of FreeBSD servers with wlan interfaces? -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 11:21:18 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5C39106564A; Sat, 24 Dec 2011 11:21:18 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 6E1FC8FC1F; Sat, 24 Dec 2011 11:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=mJVqS+HSWFnMewxgd4QyUJ/fYHhKTMF5/1/kzUxuH6w=; b=Kx8eIc+7QspRYyeMGPIaxyMS1XNhh7ElNMOnzih1mIApPs1XrGXI07ACZxmK7Bh26zwwkcgbCL071GOq4acSMedbkk9388x4jRSUMRQqaYJXR/HRQgbwQNotJphgoq+uCeL2Qda+4nXzM3ypTwsYRxubvhL71sBsroUJkucLmpBfxOE82hSbRJewmLPgII7YzAf+fKvD8fTqkqW2mzmDfuMTQ2+KHkOCewc6XpRRhkMHWYT1CM6Y/pKc5NrYcsl13o9oh3OQlXLtlYr4Rx9F9BKVEkTJnm8TPz2Z9UhpFfhsWae1t/TfesKmGbFuT5AM3ziVXNWglt5pw4ybjYnmQg==; Received: from shadow.codelabs.ru (ppp91-77-164-86.pppoe.mtu-net.ru [91.77.164.86]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RePfA-000J12-NQ; Sat, 24 Dec 2011 14:21:17 +0300 Date: Sat, 24 Dec 2011 15:21:11 +0400 From: Eygene Ryabinkin To: Doug Barton Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <4EF589DF.9060606@FreeBSD.org> <4EF4EF48.9010503@FreeBSD.org> Sender: rea@codelabs.ru Cc: Pyun Yong-Hyeon , freebsd-rc@freebsd.org, Garrett Cooper , Gleb Smirnoff , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 11:21:19 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Doug, *, good day. Fri, Dec 23, 2011 at 01:14:48PM -0800, Doug Barton wrote: > > Since the current rc.subr script has the following snippet, > > {{{ > > if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" -a "$rc_ar= g" !=3D "stop" ] || > > [ -n "${rcvar}" -a "$rc_arg" =3D "stop" -a -z "${rc= _pid}" ]; then > > if ! checkyesno ${rcvar}; then > > if [ -n "${rc_quiet}" ]; then > > return 0 > > fi > > echo -n "Cannot '${rc_arg}' $name. Set = ${rcvar} to " > > echo -n "YES in /etc/rc.conf or use 'on= e${rc_arg}' " > > echo "instead of '${rc_arg}'." > > return 0 > > fi > > fi > > }}} >=20 > You're misunderstanding the purpose of the above code. It's there so > that you can do 'service foo stop' even if foo_enable is not set. Huh? OK, let's translate this code snippet to the human language. Here we go: - if 'rcvar' is not empty and the command is not 'rcvar' (that just shows the current and default status of the corresponding rc.conf variable) and the command is not 'stop' OR - if 'rcvar' is not empty and the command is 'stop' and ("but" in the human language) we have no PID for the daemon then we will bail out silently if rc_quiet is set or will print an error message and bail out. Soo, yes -- it allows us to do the 'stop' even if the service is disabled, but only if we really have the daemon running. But I am not talking about the purpose of the condition, I am talking about the semantics of the rc_quiet. And to talk about the semantics we should invert you assertion (that more-or-less correctly states when the code inside the outer 'if' clause is not executed and rc.d script will continue its operations) and to count the cases when we will enter the body of the outer 'if' statement. And it boils to every other case, but the ones cited above. In most cases, rc_quiet in this snippet will be consulted when the service won't be enabled in rc.conf; I think you won't be telling that I am wrong here? Moreover, as Mike (mtm@) explained, the "quiet" keyword was invented precisely to keep devd stuff to be silent: {{{ The rc_quiet knob was introduced to prevent devd spamming the console when starting services that weren't enabled in rc.conf. It was also overloaded to prevent unnecessary boot time clutter on the console. }}} > > I think that error message about non-DHCP-enabled interface falls > > into the same category=20 >=20 > It does not. Please, explain your point here. (*) > >> It was not intended to mask "error" or "debug" messages. > >=20 > > It is not my intention as well: I care about masking only certain class= es > > of error and informational messages with rc_quiet; my patch to rc.subr.8 > > documents all current cases where it is appropriate. >=20 > Our opinions differ on this point. I think that our opinions differ at the word "appropriate", but not on the whole assertion of mine. Am I correct? > > It is the internal problem of the devd that spams the first group > > of people >=20 > So adjust devd.conf. Well, as the initial rationale of having the 'quiet' prefix was to quieten the devd stuff (and it is really quiet -- if you will glance over /etc/devd.conf, you will see that is just starts/stops the stuff upon events and doesn't care if the corresponding service is enabled; the dhclient culprit was just in additional rc.conf item -- "dhcp" in the interface configuration, if we would talk only about dhclient_enabled variable, there will be no current thread -- the case when it is not enabled _already_ handled by the /etc/rc.subr. So, in my view, you should either explain me the point where I have the faulty logics (as I had asked in this email, 5 paragraphs above, marked as '(*)') or the rc.subr snipped we're talking about should be freed from the check of rc_quiet status and the error message must be printed every time. Please, note, I am using "should" not to oblige you to do what I am saying, but just to express my thoughts about this semantical problem. Sat, Dec 24, 2011 at 12:14:23AM -0800, Doug Barton wrote: > On 12/24/2011 00:06, Gleb Smirnoff wrote: > > Do you suggest to adjust devd.conf in svn, or do you think that > > zillions of server FreeBSD installations should modify the default > > devd.conf to get rid of this spamming?=20 >=20 > There are zillions of FreeBSD servers with wlan interfaces? Excuse me, but you seem to hadn't glanced over the /etc/devd.conf. Dhclient is called on all appropriate interface types, not only for 802.11 ones: {{{ # # Try to start dhclient on Ethernet-like interfaces when the link comes # up. Only devices that are configured to support DHCP will actually # run it. No link down rule exists because dhclient automatically exits # when the link goes down. # notify 0 { match "system" "IFNET"; match "type" "LINK_UP"; media-type "ethernet"; action "/etc/rc.d/dhclient quietstart $subsystem"; }; notify 0 { match "system" "IFNET"; match "type" "LINK_UP"; media-type "802.11"; action "/etc/rc.d/dhclient quietstart $subsystem"; }; }}} And, I bet, there are zillions of FreeBSD servers with Ethernet interfaces for some sane definition of "zillion" as applied to the FreeBSD community. In other words, the majority of FreeBSD servers are running Ethernet interfaces and every 'ifup' event will result in the spam from the devd(8). --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --17pEHd4RhPHOinZp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk71tacACgkQFq+eroFS7PuzGAD9GdYd3ZWMCu9u3Lx5jcyAhKBW lA6cBIm402bs2CpmuFEBAJadWen9zD1lmkcha2CiBgS/3RzLiGr/cyk3oqXjWAje =G/tC -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 12:30:15 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CA74106566B for ; Sat, 24 Dec 2011 12:30:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 45AFA8FC0C for ; Sat, 24 Dec 2011 12:30:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBOCUF8C064101 for ; Sat, 24 Dec 2011 12:30:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBOCUF3h064098; Sat, 24 Dec 2011 12:30:15 GMT (envelope-from gnats) Date: Sat, 24 Dec 2011 12:30:15 GMT Message-Id: <201112241230.pBOCUF3h064098@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Maxim Ignatenko Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Maxim Ignatenko List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 12:30:15 -0000 The following reply was made to PR conf/163508; it has been noted by GNATS. From: Maxim Ignatenko To: Doug Barton Cc: bug-followup@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Date: Sat, 24 Dec 2011 14:20:19 +0200 On 24 December 2011 04:15, Doug Barton wrote: > This idea has been considered before and rejected because it's too > difficult to catch all the corner cases, and actually editing a config > file is not really all that hard of a thing to do. > The idea was to make enabling/disabling services less error-prone. It don't need to catch _all_ corner cases, because if administrator do something unusual with startup configuration he should be able to manipulate it in proper way, or even have tools that do something similar. Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of cases. Doing `service someserive enable` is much faster and less error-prone that `service someservice rcvar ; echo someservicercvar_enable=YES >> /etc/rc.conf` From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 13:15:55 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D133106566B for ; Sat, 24 Dec 2011 13:15:55 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 23B658FC0C for ; Sat, 24 Dec 2011 13:15:55 +0000 (UTC) Received: by iadj38 with SMTP id j38so19203195iad.13 for ; Sat, 24 Dec 2011 05:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=6pGtG4f7DzaCMysI4vnVc8bJwJAKDg8eox87hvx6ynU=; b=ZUt1fwIEirvpWPD7Qjukxe+6BxQ4U7Xbi2+LDOGzBXqsGpAmM0+IX9TedCy5qaTJ93 ufVvxtDi+0Yvig8HbYbLwMOuo+nr+Vf8KDkTXZdvY/WQ2txjfWUphG3lRKvRAshedFH3 Ouustbv61Dl9ImTTlSwbLqvlfcFCfsS3blEGw= Received: by 10.43.51.69 with SMTP id vh5mr21232988icb.32.1324732554280; Sat, 24 Dec 2011 05:15:54 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.30.70 with HTTP; Sat, 24 Dec 2011 05:15:23 -0800 (PST) In-Reply-To: <201112241230.pBOCUF3h064098@freefall.freebsd.org> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> From: Chris Rees Date: Sat, 24 Dec 2011 13:15:23 +0000 X-Google-Sender-Auth: OIM2dsmOtuOo9AZNUZwO5wd7LR4 Message-ID: To: Maxim Ignatenko Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 13:15:55 -0000 On 24 December 2011 12:30, Maxim Ignatenko wrote: > The following reply was made to PR conf/163508; it has been noted by GNAT= S. > > From: Maxim Ignatenko > To: Doug Barton > Cc: bug-followup@freebsd.org > Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and > =A0"disable" commands to rc.subr > Date: Sat, 24 Dec 2011 14:20:19 +0200 > > =A0On 24 December 2011 04:15, Doug Barton wrote: > =A0> This idea has been considered before and rejected because it's too > =A0> difficult to catch all the corner cases, and actually editing a conf= ig > =A0> file is not really all that hard of a thing to do. > =A0> > > =A0The idea was to make enabling/disabling services less error-prone. It > =A0don't need to catch _all_ corner cases, because if administrator do > =A0something unusual with startup configuration he should be able to > =A0manipulate it in proper way, or even have tools that do something > =A0similar. > =A0Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > =A0/etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > =A0cases. > =A0Doing `service someserive enable` is much faster and less error-prone > =A0that `service someservice rcvar ; echo someservicercvar_enable=3DYES >= > > =A0/etc/rc.conf` Disagree, sorry. If we're going to implement these ideas we should do it properly, not for 95% of cases. Chris From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 13:29:26 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7037B1065673; Sat, 24 Dec 2011 13:29:26 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id DB58E8FC1E; Sat, 24 Dec 2011 13:29:25 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id pBODTO3B007059; Sat, 24 Dec 2011 17:29:24 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id pBODTO5W007058; Sat, 24 Dec 2011 17:29:24 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 24 Dec 2011 17:29:24 +0400 From: Gleb Smirnoff To: Doug Barton Message-ID: <20111224132924.GN80057@glebius.int.ru> References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> <4EF4EF48.9010503@FreeBSD.org> <20111224080617.GM80057@glebius.int.ru> <4EF589DF.9060606@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4EF589DF.9060606@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Pyun Yong-Hyeon , freebsd-rc@FreeBSD.org, Garrett Cooper , Eygene Ryabinkin , d@delphij.net, Mike Telahun Makonnen Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 13:29:26 -0000 On Sat, Dec 24, 2011 at 12:14:23AM -0800, Doug Barton wrote: D> On 12/24/2011 00:06, Gleb Smirnoff wrote: D> > Do you suggest to adjust devd.conf in svn, or do you think that D> > zillions of server FreeBSD installations should modify the default D> > devd.conf to get rid of this spamming? D> D> There are zillions of FreeBSD servers with wlan interfaces? Current code spams console for any interfaces. -- Totus tuus, Glebius. From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 15:22:19 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EFE3106564A for ; Sat, 24 Dec 2011 15:22:19 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 026428FC14 for ; Sat, 24 Dec 2011 15:22:18 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so13888054vcb.13 for ; Sat, 24 Dec 2011 07:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=KTQJzHGPdzKqdpoaN0khtyCRsudRRyW+BHUI2aQXZzw=; b=JebHmSWD+T9wkJHge8/caeI7w0EAqMTOkrEWnyz4pIPXiOhLGQh9khPfwz8Eabx+cd 3AGGpxjLjfjGLJO3ZcEn8izvJDfAAkOxNNHJ+e95ZIbqeH9sepco1KmUt0twS1gob9LG 03zSF0caHxMkdbeOFCxAMXZa542oto2Uvqhbw= Received: by 10.221.13.196 with SMTP id pn4mr12189558vcb.74.1324738423189; Sat, 24 Dec 2011 06:53:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.29.225 with HTTP; Sat, 24 Dec 2011 06:53:22 -0800 (PST) In-Reply-To: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> From: Maxim Ignatenko Date: Sat, 24 Dec 2011 16:53:22 +0200 Message-ID: To: Chris Rees Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 15:22:19 -0000 On 24 December 2011 15:15, Chris Rees wrote: > On 24 December 2011 12:30, Maxim Ignatenko wrote: >> The following reply was made to PR conf/163508; it has been noted by GNA= TS. >> >> From: Maxim Ignatenko >> To: Doug Barton >> Cc: bug-followup@freebsd.org >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and >> =C2=A0"disable" commands to rc.subr >> Date: Sat, 24 Dec 2011 14:20:19 +0200 >> >> =C2=A0On 24 December 2011 04:15, Doug Barton wrote: >> =C2=A0> This idea has been considered before and rejected because it's t= oo >> =C2=A0> difficult to catch all the corner cases, and actually editing a = config >> =C2=A0> file is not really all that hard of a thing to do. >> =C2=A0> >> >> =C2=A0The idea was to make enabling/disabling services less error-prone.= It >> =C2=A0don't need to catch _all_ corner cases, because if administrator d= o >> =C2=A0something unusual with startup configuration he should be able to >> =C2=A0manipulate it in proper way, or even have tools that do something >> =C2=A0similar. >> =C2=A0Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and >> =C2=A0/etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95%= of >> =C2=A0cases. >> =C2=A0Doing `service someserive enable` is much faster and less error-pr= one >> =C2=A0that `service someservice rcvar ; echo someservicercvar_enable=3DY= ES >> >> =C2=A0/etc/rc.conf` > > Disagree, sorry. > > If we're going to implement these ideas we should do it properly, not > for 95% of cases. > It's impossible to handle all cases. For example, how this can be detected and properly altered without bloating code: for c in n a m e d _ e n a b l e; do var=3D${var}${c} done for c in y e s; do val=3D${val}${c} done eval ${var}=3D\$${val} Since proposed patch adds variable to last included file, it will not actually work only if user changed /etc/rc.subr to include one more file after /etc/rc.conf.d/${name}. So, while /etc/rc.subr is unmdified, it will do the job. From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 16:47:33 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 250C71065670 for ; Sat, 24 Dec 2011 16:47:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D132C8FC08 for ; Sat, 24 Dec 2011 16:47:32 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBOGkjH4012311 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 09:46:45 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201112241230.pBOCUF3h064098@freefall.freebsd.org> Date: Sat, 24 Dec 2011 09:46:45 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> To: Maxim Ignatenko X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 09:46:45 -0700 (MST) Cc: freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 16:47:33 -0000 On Dec 24, 2011, at 5:30 AM, Maxim Ignatenko wrote: > On 24 December 2011 04:15, Doug Barton wrote: >> This idea has been considered before and rejected because it's too >> difficult to catch all the corner cases, and actually editing a = config >> file is not really all that hard of a thing to do. >>=20 >=20 > The idea was to make enabling/disabling services less error-prone. It > don't need to catch _all_ corner cases, because if administrator do > something unusual with startup configuration he should be able to > manipulate it in proper way, or even have tools that do something > similar. > Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > cases. > Doing `service someserive enable` is much faster and less error-prone > that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> > /etc/rc.conf` Also, let's not reject it before it is done. Let's reject it when it = actually doesn't handle the cases that are interesting. No sense in = cutting off a good feature because of some theoretical problem. It is a = problem we have sometimes in the project...=20 Warner From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 16:53:22 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC2AF1065679; Sat, 24 Dec 2011 16:53:22 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 7414D8FC0C; Sat, 24 Dec 2011 16:53:22 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBOGmcLE012313 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 09:48:38 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Sat, 24 Dec 2011 09:48:37 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> To: Chris Rees X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 09:48:38 -0700 (MST) Cc: Maxim Ignatenko , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 16:53:22 -0000 On Dec 24, 2011, at 6:15 AM, Chris Rees wrote: > On 24 December 2011 12:30, Maxim Ignatenko = wrote: >> The following reply was made to PR conf/163508; it has been noted by = GNATS. >>=20 >> From: Maxim Ignatenko >> To: Doug Barton >> Cc: bug-followup@freebsd.org >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" = and >> "disable" commands to rc.subr >> Date: Sat, 24 Dec 2011 14:20:19 +0200 >>=20 >> On 24 December 2011 04:15, Doug Barton wrote: >> > This idea has been considered before and rejected because it's too >> > difficult to catch all the corner cases, and actually editing a = config >> > file is not really all that hard of a thing to do. >> > >>=20 >> The idea was to make enabling/disabling services less error-prone. = It >> don't need to catch _all_ corner cases, because if administrator do >> something unusual with startup configuration he should be able to >> manipulate it in proper way, or even have tools that do something >> similar. >> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and >> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% = of >> cases. >> Doing `service someserive enable` is much faster and less = error-prone >> that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> >> /etc/rc.conf` >=20 > Disagree, sorry. >=20 > If we're going to implement these ideas we should do it properly, not > for 95% of cases. A lot depends on what those 5% of the cases are. Absent an = implementation to throw stones at, such criticism is premature. If the = 5% of cases are when someone has done something complicated to the = rc.conf file, then I don't care: they won't use this interface and we = can detect this case and do nothing. If the 5% of the cases are when = someone has enabled ntpd, then that would be a non-starter. Warner= From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 16:57:26 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 690501065672; Sat, 24 Dec 2011 16:57:26 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) by mx1.freebsd.org (Postfix) with ESMTP id B0F348FC0A; Sat, 24 Dec 2011 16:57:25 +0000 (UTC) Received: from mail.0x20.net (mail.0x20.net [217.69.76.211]) by mail.0x20.net (Postfix) with ESMTP id 01F166A61CD; Sat, 24 Dec 2011 17:57:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.0x20.net Received: from mail.0x20.net ([217.69.76.211]) by mail.0x20.net (mail.0x20.net [217.69.76.211]) (amavisd-new, port 10024) with ESMTP id XrHXA7Fd-b2Q; Sat, 24 Dec 2011 17:57:24 +0100 (CET) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id B59DE6A61CB; Sat, 24 Dec 2011 17:57:24 +0100 (CET) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.4/8.14.4) with ESMTP id pBOGvOhb093313; Sat, 24 Dec 2011 17:57:24 +0100 (CET) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.4/8.14.4/Submit) id pBOGvLaW092756; Sat, 24 Dec 2011 17:57:21 +0100 (CET) (envelope-from lars) Date: Sat, 24 Dec 2011 17:57:21 +0100 From: Lars Engels To: Warner Losh Message-ID: <20111224165721.GZ13272@e-new.0x20.net> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nktOf83SvqltY3iw" Content-Disposition: inline In-Reply-To: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> X-Editor: VIM - Vi IMproved 7.3 X-Operation-System: FreeBSD 8.2-RELEASE-p3 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Chris Rees , Maxim Ignatenko , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 16:57:26 -0000 --nktOf83SvqltY3iw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 24, 2011 at 09:48:37AM -0700, Warner Losh wrote: >=20 > On Dec 24, 2011, at 6:15 AM, Chris Rees wrote: >=20 > > On 24 December 2011 12:30, Maxim Ignatenko wrote: > >> The following reply was made to PR conf/163508; it has been noted by G= NATS. > >>=20 > >> From: Maxim Ignatenko > >> To: Doug Barton > >> Cc: bug-followup@freebsd.org > >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and > >> "disable" commands to rc.subr > >> Date: Sat, 24 Dec 2011 14:20:19 +0200 > >>=20 > >> On 24 December 2011 04:15, Doug Barton wrote: > >> > This idea has been considered before and rejected because it's too > >> > difficult to catch all the corner cases, and actually editing a con= fig > >> > file is not really all that hard of a thing to do. > >> > > >>=20 > >> The idea was to make enabling/disabling services less error-prone. It > >> don't need to catch _all_ corner cases, because if administrator do > >> something unusual with startup configuration he should be able to > >> manipulate it in proper way, or even have tools that do something > >> similar. > >> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > >> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > >> cases. > >> Doing `service someserive enable` is much faster and less error-prone > >> that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> > >> /etc/rc.conf` > >=20 > > Disagree, sorry. > >=20 > > If we're going to implement these ideas we should do it properly, not > > for 95% of cases. >=20 > A lot depends on what those 5% of the cases are. Absent an > implementation to throw stones at, such criticism is premature. If > the 5% of cases are when someone has done something complicated to the > rc.conf file, then I don't care: they won't use this interface and we > can detect this case and do nothing. If the 5% of the cases are when > someone has enabled ntpd, then that would be a non-starter. Yup, let's better fix the 5% of special cases where the new features doesn't work. I know and like the "enable / disable" arguments to "svcadm" from Solaris and miss it on FreeBSD. --nktOf83SvqltY3iw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk72BHEACgkQKc512sD3afiRSwCgu/6K5RF2XKkjGA8Q9+io2Cr2 vToAoKPSMX0sQkD8Zm3kWYY1j8R0ezM4 =Nvau -----END PGP SIGNATURE----- --nktOf83SvqltY3iw-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 17:29:46 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 856C3106566B; Sat, 24 Dec 2011 17:29:46 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1D1338FC0C; Sat, 24 Dec 2011 17:29:45 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so14038007vbb.13 for ; Sat, 24 Dec 2011 09:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=VdKG6w15ndfHp656W4G6tFU/xpyc9SmYwOecmRbtVIo=; b=i+J0FlPgZefiXfiBbuvRRMP8h2sLdPHoiJYzHBo+yCCXc4xhmlVVd8CxnLGYgShPle f06EbJf/Er+j+0zdf/oRNDDrzGCMxm+tST90USrTdVxY9CoOaqqzorZWWWAfaWke7baq 0C0EoFad9TjUS38Gh/9rBmLedMgtprUWlBvNg= Received: by 10.52.177.38 with SMTP id cn6mr9549137vdc.8.1324747785320; Sat, 24 Dec 2011 09:29:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.29.225 with HTTP; Sat, 24 Dec 2011 09:29:24 -0800 (PST) In-Reply-To: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> From: Maxim Ignatenko Date: Sat, 24 Dec 2011 19:29:24 +0200 Message-ID: To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 17:29:46 -0000 >=C2=A0If the 5% of cases are when someone has done something complicated t= o the rc.conf file, then I don't care: they won't use this interface and we= can detect this case and do nothing. Now I don't see how to distinguish cases when ${rcvar} set to default value in rc-script and when it's set in other file in some not obvious way. From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 17:54:26 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D87531065670; Sat, 24 Dec 2011 17:54:26 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 8E1DC8FC08; Sat, 24 Dec 2011 17:54:26 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBOHpX4b012740 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 10:51:34 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Sat, 24 Dec 2011 10:51:33 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> To: Maxim Ignatenko X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 10:51:34 -0700 (MST) Cc: Chris Rees , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 17:54:26 -0000 On Dec 24, 2011, at 10:29 AM, Maxim Ignatenko wrote: >> If the 5% of cases are when someone has done something complicated = to the rc.conf file, then I don't care: they won't use this interface = and we can detect this case and do nothing. >=20 > Now I don't see how to distinguish cases when ${rcvar} set to default > value in rc-script and when it's set in other file in some not obvious > way. What does that matter? Warner From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 18:05:04 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B900106566B; Sat, 24 Dec 2011 18:05:04 +0000 (UTC) (envelope-from gelraen.ua@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id C68598FC08; Sat, 24 Dec 2011 18:05:02 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so13964317vcb.13 for ; Sat, 24 Dec 2011 10:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=zEA18dDHZSmdJ1SMZp2nuAFiS8d8bZc1m8znmJCblMQ=; b=jPiz2hdxHU4NOM6tDAiSU34sghM+wxUDm5hil9bxX8Aedx6iRlGdrhi5X3QNRilgFY gAHLm1DbxhzyZSbN85AJsBKeckLyHkqoUQSHKR8N5Oeg0cSNs+mrnTTBpYWb4TQFYGEb iiOA2DsHV/Ou80XwOdTev6RmzK5wq15C3NnW4= Received: by 10.220.205.194 with SMTP id fr2mr12466693vcb.44.1324749902196; Sat, 24 Dec 2011 10:05:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.29.225 with HTTP; Sat, 24 Dec 2011 10:04:41 -0800 (PST) In-Reply-To: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> From: Maxim Ignatenko Date: Sat, 24 Dec 2011 20:04:41 +0200 Message-ID: To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 18:05:04 -0000 On 24 December 2011 19:51, Warner Losh wrote: > > On Dec 24, 2011, at 10:29 AM, Maxim Ignatenko wrote: > >>> =C2=A0If the 5% of cases are when someone has done something complicate= d to the rc.conf file, then I don't care: they won't use this interface and= we can detect this case and do nothing. >> >> Now I don't see how to distinguish cases when ${rcvar} set to default >> value in rc-script and when it's set in other file in some not obvious >> way. > > What does that matter? > In second case it should say something like "Unable to find where ${rcvar} was set". Now it adds ${rcvar}=3DYES to last included file in both cases. This still should correctly enable or disable some service unless /etc/rc.subr was modified to include some another file later, but, as I understood, this is what was meant by "corner case handling". From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 18:53:11 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29AF8106566B; Sat, 24 Dec 2011 18:53:11 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id D7FEA8FC13; Sat, 24 Dec 2011 18:53:10 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so8841877obb.13 for ; Sat, 24 Dec 2011 10:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=CCZR6FWQLlfS36sk3HunLMTIltsv2bEBSXz6l1S4qJM=; b=tdGoobmx6b2tiuO1EKxHZGdi9Jq8mJu31eT1gj09cITOe8LENdS2NP9cSZ10y2AWXo B14sE5ycmx8HcFw4eMPmkHkriME99ojb7f7A6hjv82XfBlWGTL6Amfkdc/7xHq8rlebo ap253V9gQe9i4dtX46Nc7JrgiWfhNKZoP0ah8= MIME-Version: 1.0 Received: by 10.182.51.37 with SMTP id h5mr16832544obo.51.1324752790276; Sat, 24 Dec 2011 10:53:10 -0800 (PST) Received: by 10.182.152.6 with HTTP; Sat, 24 Dec 2011 10:53:10 -0800 (PST) In-Reply-To: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> Date: Sat, 24 Dec 2011 10:53:10 -0800 Message-ID: From: Garrett Cooper To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Maxim Ignatenko , freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 18:53:11 -0000 On Sat, Dec 24, 2011 at 9:51 AM, Warner Losh wrote: > > On Dec 24, 2011, at 10:29 AM, Maxim Ignatenko wrote: > >>> =A0If the 5% of cases are when someone has done something complicated t= o the rc.conf file, then I don't care: they won't use this interface and we= can detect this case and do nothing. >> >> Now I don't see how to distinguish cases when ${rcvar} set to default >> value in rc-script and when it's set in other file in some not obvious >> way. > > What does that matter? This is annoying (like samba) because it's a broken script s.t. I can't issue forcestop and expect it to stop properly in all cases. Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 19:02:18 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 665BD106568E; Sat, 24 Dec 2011 19:02:18 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E93738FC1E; Sat, 24 Dec 2011 19:02:17 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so8845508obb.13 for ; Sat, 24 Dec 2011 11:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3xzQG8F2ZohHIoMUpE5zKJf6WDzHPvxjTrDm6q2KcAI=; b=ZAh5e7wmEduflnEH5maISzUgQWtLBa2xX5s79E/ZgE98PoLJNLiDjf6oP3FJEh9FMu /xDpb+PGH49WYJTkNZ3JCM4womSucc0NNxac5WarfwqAw+VeBbVRGWuzYAHyT9o94Wj6 EwuWD+HFHQKRz4FvSzjS5KkfmI8qbDln1Dgm4= MIME-Version: 1.0 Received: by 10.182.2.136 with SMTP id 8mr16978319obu.71.1324753337383; Sat, 24 Dec 2011 11:02:17 -0800 (PST) Received: by 10.182.152.6 with HTTP; Sat, 24 Dec 2011 11:02:17 -0800 (PST) In-Reply-To: <20111224132924.GN80057@glebius.int.ru> References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> <4EF4EF48.9010503@FreeBSD.org> <20111224080617.GM80057@glebius.int.ru> <4EF589DF.9060606@FreeBSD.org> <20111224132924.GN80057@glebius.int.ru> Date: Sat, 24 Dec 2011 11:02:17 -0800 Message-ID: From: Garrett Cooper To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: Pyun Yong-Hyeon , Doug Barton , freebsd-rc@freebsd.org, Eygene Ryabinkin , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 19:02:18 -0000 2011/12/24 Gleb Smirnoff : > On Sat, Dec 24, 2011 at 12:14:23AM -0800, Doug Barton wrote: > D> On 12/24/2011 00:06, Gleb Smirnoff wrote: > D> > Do you suggest to adjust devd.conf in svn, or do you think that > D> > zillions of server FreeBSD installations should modify the default > D> > devd.conf to get rid of this spamming? > D> > D> There are zillions of FreeBSD servers with wlan interfaces? > > Current code spams console for any interfaces. Is that because of... console.info /var/log/console.log :)? Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 21:00:31 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B857106564A for ; Sat, 24 Dec 2011 21:00:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D4CD48FC15 for ; Sat, 24 Dec 2011 21:00:30 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBOL0UNM029498 for ; Sat, 24 Dec 2011 21:00:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBOL0Ujr029497; Sat, 24 Dec 2011 21:00:30 GMT (envelope-from gnats) Date: Sat, 24 Dec 2011 21:00:30 GMT Message-Id: <201112242100.pBOL0Ujr029497@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Doug Barton Cc: Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Doug Barton List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 21:00:31 -0000 The following reply was made to PR conf/163508; it has been noted by GNATS. From: Doug Barton To: Maxim Ignatenko Cc: bug-followup@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Date: Sat, 24 Dec 2011 12:59:44 -0800 On 12/24/2011 04:20, Maxim Ignatenko wrote: > The idea was to make enabling/disabling services less error-prone. How is adding foo_enable=1 to rc.conf error-prone? -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 21:11:59 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 2DE811065675; Sat, 24 Dec 2011 21:11:59 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id C076B14FC85; Sat, 24 Dec 2011 21:11:58 +0000 (UTC) Message-ID: <4EF6401E.3080902@FreeBSD.org> Date: Sat, 24 Dec 2011 13:11:58 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Eygene Ryabinkin References: In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Pyun Yong-Hyeon , freebsd-rc@freebsd.org, Garrett Cooper , Gleb Smirnoff , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 21:11:59 -0000 On 12/24/2011 03:21, Eygene Ryabinkin wrote: > Please, explain your point here. (*) I have, several times now, and I'm getting tired of explaining it again. We seem to have lost sight of what "asking for feedback" entails around here. Namely that sometimes the feedback is, "That's a bad idea, please don't do it." I've tried to say it politely, and I've tried to explain the reasoning behind why what you're proposing is a bad idea, but you don't agree with my reasoning. It's Ok that you don't agree, it's even Ok for you to naively assume that the reason I don't agree is that I don't understand the issues/code/etc. as well as you do. But that doesn't change the fact that what you're proposing is a bad idea. For the record: It's more important for users to see error messages for interfaces that *should* be configured, but don't succeed; than it is to hide occasional spam for interfaces where configuration is attempted spuriously. If *you* don't want to see that spam then *you* have it in your power, through various configuration knobs, to make it stop. If you don't care to do that, that's your choice as well. At this point we've already expended way more energy on this topic than it was ever worth. Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 21:50:14 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 45A7E106564A for ; Sat, 24 Dec 2011 21:50:14 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 0C4EE14F3DE; Sat, 24 Dec 2011 21:50:14 +0000 (UTC) Message-ID: <4EF64915.4030006@FreeBSD.org> Date: Sat, 24 Dec 2011 13:50:13 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Warner Losh References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Maxim Ignatenko , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 21:50:14 -0000 On 12/24/2011 08:46, Warner Losh wrote: > Also, let's not reject it before it is done. Let's reject it when it actually doesn't handle the cases that are interesting. No sense in cutting off a good feature because of some theoretical problem. It is a problem we have sometimes in the project... Warner, You seemed to have missed the bit where I said, "We've already been down this path once before, and it turns out to be way harder to do this right than it looks at first glance." Just as an example of potential problems, imagine a scenario where the user has foo_enable=NO in rc.conf, but the service keeps starting up anyway. For better or worse rc.d offers a lot of flexibility in how services are enabled. We've already heard from users who use those various mechanisms, and don't want them removed/broken. Absent an overhaul of the underlying structure of configuration files (which would violate one or both of remove/break existing functionality) there is no way to add this feature in a thorough manner. Adding it in a less-than-thorough manner will cause more problems than it solves. Which returns me to my original point, how hard is it to edit rc.conf anyway? Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 21:56:51 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 148731065675; Sat, 24 Dec 2011 21:56:51 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) by mx1.freebsd.org (Postfix) with ESMTP id 9C20C8FC12; Sat, 24 Dec 2011 21:56:50 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 784D41DD415; Sat, 24 Dec 2011 22:56:49 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id 51C2228468; Sat, 24 Dec 2011 22:56:49 +0100 (CET) Date: Sat, 24 Dec 2011 22:56:49 +0100 From: Jilles Tjoelker To: Doug Barton Message-ID: <20111224215649.GA12789@stack.nl> References: <4EF6401E.3080902@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EF6401E.3080902@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Pyun Yong-Hyeon , d@delphij.net, Garrett Cooper , Eygene Ryabinkin , Gleb Smirnoff , freebsd-rc@freebsd.org Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 21:56:51 -0000 On Sat, Dec 24, 2011 at 01:11:58PM -0800, Doug Barton wrote: > On 12/24/2011 03:21, Eygene Ryabinkin wrote: > > Please, explain your point here. (*) > I have, several times now, and I'm getting tired of explaining it again. > We seem to have lost sight of what "asking for feedback" entails around > here. Namely that sometimes the feedback is, "That's a bad idea, please > don't do it." I've tried to say it politely, and I've tried to explain > the reasoning behind why what you're proposing is a bad idea, but you > don't agree with my reasoning. It's Ok that you don't agree, it's even > Ok for you to naively assume that the reason I don't agree is that I > don't understand the issues/code/etc. as well as you do. But that > doesn't change the fact that what you're proposing is a bad idea. > For the record: It's more important for users to see error messages for > interfaces that *should* be configured, but don't succeed; than it is to > hide occasional spam for interfaces where configuration is attempted > spuriously. And rea@'s patch does this: service dhclient start IF generates error messages if IF is not enabled for DHCP in rc.conf, while service dhclient quietstart IF does not. This works the same way as service food start/quietstart when food is not enabled in rc.conf. Therefore I do not see what is wrong with rea@'s patch. > If *you* don't want to see that spam then *you* have it in your power, > through various configuration knobs, to make it stop. If you don't care > to do that, that's your choice as well. At this point we've already > expended way more energy on this topic than it was ever worth. In general, I think the defaults should be set up like a user would want them. This is because people want to edit the configuration files as little as possible and also as few of them as possible, so upgrading is as easy as possible. On a server, /etc/devd.conf rarely needs any changes, so for the purpose of this issue assume that it will not be modified and there will be error messages needlessly confusing people. Even more so because the change to devd.conf would duplicate information that is already in rc.conf. -- Jilles Tjoelker From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 23:00:08 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB229106566B; Sat, 24 Dec 2011 23:00:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6D21F8FC12; Sat, 24 Dec 2011 23:00:07 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBON01dc014175 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 16:00:01 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Sat, 24 Dec 2011 16:00:01 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> To: Maxim Ignatenko X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 16:00:02 -0700 (MST) Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 23:00:08 -0000 On Dec 24, 2011, at 11:04 AM, Maxim Ignatenko wrote: > On 24 December 2011 19:51, Warner Losh wrote: >>=20 >> On Dec 24, 2011, at 10:29 AM, Maxim Ignatenko wrote: >>=20 >>>> If the 5% of cases are when someone has done something complicated = to the rc.conf file, then I don't care: they won't use this interface = and we can detect this case and do nothing. >>>=20 >>> Now I don't see how to distinguish cases when ${rcvar} set to = default >>> value in rc-script and when it's set in other file in some not = obvious >>> way. >>=20 >> What does that matter? >>=20 >=20 > In second case it should say something like "Unable to find where > ${rcvar} was set". Now it adds ${rcvar}=3DYES to last included file in > both cases. This still should correctly enable or disable some service > unless /etc/rc.subr was modified to include some another file later, > but, as I understood, this is what was meant by "corner case > handling". I don't see that as a problem. If you're turning it on, then the fact = that 'on' is default isn't really germane. You've set it to 'on'. To = detect if it is set or not, you can look at the user file vs user file + = defaults. I'm not seeing what I'd call a hard problem here at all. Warner From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 23:05:10 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A682106564A; Sat, 24 Dec 2011 23:05:10 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 459D48FC13; Sat, 24 Dec 2011 23:05:10 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBON1su9014179 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 16:01:54 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201112242100.pBOL0Ujr029497@freefall.freebsd.org> Date: Sat, 24 Dec 2011 16:01:54 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <8398C9B0-4B59-46EA-B455-20BB813B65BA@bsdimp.com> References: <201112242100.pBOL0Ujr029497@freefall.freebsd.org> To: Doug Barton X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 16:01:54 -0700 (MST) Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 23:05:10 -0000 On Dec 24, 2011, at 2:00 PM, Doug Barton wrote: > The following reply was made to PR conf/163508; it has been noted by = GNATS. >=20 > From: Doug Barton > To: Maxim Ignatenko > Cc: bug-followup@freebsd.org > Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and = "disable" > commands to rc.subr > Date: Sat, 24 Dec 2011 12:59:44 -0800 >=20 > On 12/24/2011 04:20, Maxim Ignatenko wrote: >> The idea was to make enabling/disabling services less error-prone. >=20 > How is adding foo_enable=3D1 to rc.conf error-prone? Some people like editing files, others like command line interfaces. = For some, the latter is easier and less prone to errors. For others, = the former is such. This utility would cater to the latter case of people, and would have no = impact on the former. Warner From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 23:11:23 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 544CA106564A; Sat, 24 Dec 2011 23:11:23 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E63628FC14; Sat, 24 Dec 2011 23:11:22 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBON8rUp014204 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 16:08:53 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <4EF64915.4030006@FreeBSD.org> Date: Sat, 24 Dec 2011 16:08:52 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <4EF64915.4030006@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 16:08:53 -0700 (MST) Cc: Maxim Ignatenko , freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 23:11:23 -0000 On Dec 24, 2011, at 2:50 PM, Doug Barton wrote: > On 12/24/2011 08:46, Warner Losh wrote: >> Also, let's not reject it before it is done. Let's reject it when = it actually doesn't handle the cases that are interesting. No sense in = cutting off a good feature because of some theoretical problem. It is a = problem we have sometimes in the project...=20 >=20 > Warner, >=20 > You seemed to have missed the bit where I said, "We've already been = down > this path once before, and it turns out to be way harder to do this > right than it looks at first glance." No, I get that totally. I just don't care. The fact that others have = failed shouldn't mean we should discourage others from trying. We = shouldn't be shooting arrows at people before they are given a chance to = produce something good or bad, or when they do shooting them without = evaluating their work. > Just as an example of potential problems, imagine a scenario where the > user has foo_enable=3DNO in rc.conf, but the service keeps starting up > anyway. Most people call that a bug, or at least POLA. The few cases in the = tree where bar_enable=3Dyes forces foo_enable=3Dyes can be dealt with. > For better or worse rc.d offers a lot of flexibility in how services = are > enabled. We've already heard from users who use those various > mechanisms, and don't want them removed/broken. Absent an overhaul of > the underlying structure of configuration files (which would violate = one > or both of remove/break existing functionality) there is no way to add > this feature in a thorough manner. Adding it in a less-than-thorough > manner will cause more problems than it solves. We should encourage others solving the problem completely. > Which returns me to my original point, how hard is it to edit rc.conf > anyway? Scripts would greatly benefit from having a robust way to do things = without humans in the loop. Some folks also would find it easier. Basically, we shouldn't get in the way here by telling people it can't = be done. Then we get nothing. Telling people to try is better. Worst thing that happens is that this = effort fails. Best outcome is that they fix the issues to make it = robust. Warner