From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 18:55:10 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id C8C941065672; Thu, 7 Apr 2011 18:55:10 +0000 (UTC) Date: Thu, 7 Apr 2011 18:55:10 +0000 From: Alexander Best To: freebsd-current@freebsd.org Message-ID: <20110407185510.GA94830@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline Cc: freebsd-toolchain@freebsd.org Subject: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 18:55:10 -0000 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline hi there, i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let tinderbox fail, if any new kernel code was committed with (a) broken include dir(s). i ran a test via make toolchains make MAKE_JUST_KERNELS=yes tinderbox and nothing seemed to go wrong with the extra warning enabled. i even found a missing include dir, which should be fixed by the attached patch. opinions? so far i've only tested this with gcc. i think someone on #freebsd-clang told me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). cheers. alex -- a13x --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ccatm.diff" diff --git a/sys/modules/netgraph/atm/ccatm/Makefile b/sys/modules/netgraph/atm/ccatm/Makefile index 5626536..8bf741d 100644 --- a/sys/modules/netgraph/atm/ccatm/Makefile +++ b/sys/modules/netgraph/atm/ccatm/Makefile @@ -12,6 +12,6 @@ KMOD= ng_ccatm SRCS= ng_ccatm.c cc_conn.c cc_data.c cc_dump.c cc_port.c cc_sig.c \ cc_user.c unisap.c -CFLAGS+= -I${LIBBASE} -I${LIBBASE}/netnatm/ccatm -DCCATM_DEBUG +CFLAGS+= -I${LIBBASE} -DCCATM_DEBUG .include --r5Pyd7+fXNt84Ff3-- From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 21:21:22 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05034106566C for ; Thu, 7 Apr 2011 21:21:22 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id D1A2A8FC21 for ; Thu, 7 Apr 2011 21:21:21 +0000 (UTC) Received: by pvg11 with SMTP id 11so1312562pvg.13 for ; Thu, 07 Apr 2011 14:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=krk2NTcrV5M1I13nMnbOjE/MrvI1uJN8ymhZz/isayU=; b=VBXEsLu5UyOTBxKCsKy/BJAY9Ary2NbqlMkg5ip9d9wMqeNpLDSwenSQuwRYyArRU0 sAhnh3WA2jO0/kEoydyK29a+UZWtE+JK0oBGxy+L0qs1q0DtO8g4pJ+IudZhOANUIj1G B3XxKUkx/3qjWGVsf8WhO/olV731eNRv+J/q4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Xh9i0bvlY0nPs8nJi02zSn3StsQC4Zb13hTKN+PjjYhJNyuw3FmA7lmrxJmW7OeoSk i2G3KQVNoL/VUjCz76IrQGlB24ZWvz7dAWvtGyUOpGkG5WwiKZe2nUo/judSbL8DG68M +h8Rq9hMvfuTlhGgkFkSzK36wK2XsX5MZ9cTU= MIME-Version: 1.0 Received: by 10.142.152.3 with SMTP id z3mr1010884wfd.398.1302209596981; Thu, 07 Apr 2011 13:53:16 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 13:53:16 -0700 (PDT) In-Reply-To: <20110407185510.GA94830@freebsd.org> References: <20110407185510.GA94830@freebsd.org> Date: Thu, 7 Apr 2011 13:53:16 -0700 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 21:21:22 -0000 On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wrote: > hi there, > > i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let > tinderbox fail, if any new kernel code was committed with (a) broken include > dir(s). > > i ran a test via > > make toolchains > make MAKE_JUST_KERNELS=yes tinderbox > > and nothing seemed to go wrong with the extra warning enabled. i even found a > missing include dir, which should be fixed by the attached patch. > > opinions? > > so far i've only tested this with gcc. i think someone on #freebsd-clang told > me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf -VMODULES_OVERRIDE say... (tinderbox should also really ignore these files, but it doesn't currently)? Thanks, -Garrett From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 21:21:51 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A7E8106566C for ; Thu, 7 Apr 2011 21:21:51 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-px0-f172.google.com (mail-px0-f172.google.com [209.85.212.172]) by mx1.freebsd.org (Postfix) with ESMTP id 0FDD48FC0C for ; Thu, 7 Apr 2011 21:21:50 +0000 (UTC) Received: by pxi6 with SMTP id 6so2714259pxi.17 for ; Thu, 07 Apr 2011 14:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=agrjJ6GUNGo2kuf28fWJpwfUMzF8D0AaiqE9p3tshag=; b=f6JPgs6XxqmYMKCcTb1r0llJYgsxlF8m2bamh0MxlrKo/ijlBVfu2v9TzudK3j8eMY RY1D0Ua3KorhveMKAnITDcDdMBrCHFJvOlOJ5Eue4ZH74NzapbxdVIhDx0frEk1dsV5M 3Hk+rJUbgjdf5d65nx/5TTjOmacxzo6hKBpEE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=B2pkT9a5UDpfao8HvihQ3g38kl9FmpwVEUHxKssEJFTFmE23LYytZLcLzT8WHCJ+pv b8QEv3H3gVCLO34NwI1U8LBudLkVNabO0QWpue1Uo4n7dwMhlQKQy9bfwkZdBz1cHDac 7vArGWLy12i+hon6tByBDoA2fLhZKel4tzqsg= MIME-Version: 1.0 Received: by 10.142.136.18 with SMTP id j18mr974943wfd.284.1302209616772; Thu, 07 Apr 2011 13:53:36 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 13:53:36 -0700 (PDT) In-Reply-To: References: <20110407185510.GA94830@freebsd.org> Date: Thu, 7 Apr 2011 13:53:36 -0700 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 21:21:51 -0000 On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrote: > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wro= te: >> hi there, >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this wi= ll let >> tinderbox fail, if any new kernel code was committed with (a) broken inc= lude >> dir(s). >> >> i ran a test via >> >> make toolchains >> make MAKE_JUST_KERNELS=3Dyes tinderbox >> >> and nothing seemed to go wrong with the extra warning enabled. i even fo= und a >> missing include dir, which should be fixed by the attached patch. >> >> opinions? >> >> so far i've only tested this with gcc. i think someone on #freebsd-clang= told >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons= ). > > =A0 =A0make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these > files, but it doesn't currently)? Sorry. Second invocation should have been make.conf, not src.conf. From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 21:22:25 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id B48B2106566C; Thu, 7 Apr 2011 21:22:25 +0000 (UTC) Date: Thu, 7 Apr 2011 21:22:25 +0000 From: Alexander Best To: Garrett Cooper Message-ID: <20110407212225.GA17091@freebsd.org> References: <20110407185510.GA94830@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 21:22:25 -0000 On Thu Apr 7 11, Garrett Cooper wrote: > On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrote: > > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wrote: > >> hi there, > >> > >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let > >> tinderbox fail, if any new kernel code was committed with (a) broken include > >> dir(s). > >> > >> i ran a test via > >> > >> make toolchains > >> make MAKE_JUST_KERNELS=yes tinderbox > >> > >> and nothing seemed to go wrong with the extra warning enabled. i even found a > >> missing include dir, which should be fixed by the attached patch. > >> > >> opinions? > >> > >> so far i've only tested this with gcc. i think someone on #freebsd-clang told > >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). > > > >    make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf > > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these > > files, but it doesn't currently)? otaku% make -f /etc/src.conf -VMODULES_OVERRIDE netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock otaku% make -f /etc/make.conf -VMODULES_OVERRIDE netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock ...however i checked and tinderbox *does* ignore src.conf and make.conf. the _.* log files show that modules were being build which are not returned by the commands above. i think having this flag would be very useful, because it would force people to make sure their include dirs are correct. > > Sorry. Second invocation should have been make.conf, not src.conf. -- a13x From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 7 21:58:03 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD02A106566B; Thu, 7 Apr 2011 21:58:03 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 734248FC16; Thu, 7 Apr 2011 21:58:03 +0000 (UTC) Received: by pvg11 with SMTP id 11so1326039pvg.13 for ; Thu, 07 Apr 2011 14:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=x2JWrkVPYGpTkqlkWFSmRT0BF8szLnlNnVZbl6uNpG8=; b=jeFR98Ys+gAr2rrZkgeuFQENs/YpOnEsPDUrFcksDkqRtAHSz/wtCDPpu69guAMDbp yZmRotAqvS1MGkxeU6vhcSBNv9pnccXqbdhLcJyuvHQnhQ+ABAscFI+Rr8HUp+tOZ1eH ajCE5CDbElRrCBO//jeOSd4SoHq3dLWWqKP6Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=L8nqe6ZXt8UDK8jncuTCmC56gjc38P7k5mPUifWY8D1mNeN6p0wcd4BohCYIFUkQHd tX8vRkZ5I8Fr94flaI6xPZg7uUazUAG1F3taoHkVsIQFRnVn8PECqT1EOVjfjjiTZ0Rh c4FDxwAKMuCqm28nZY5o5AJQYCTEXGdMoAUCI= MIME-Version: 1.0 Received: by 10.142.152.3 with SMTP id z3mr1063382wfd.398.1302213483013; Thu, 07 Apr 2011 14:58:03 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Thu, 7 Apr 2011 14:58:02 -0700 (PDT) In-Reply-To: <20110407212225.GA17091@freebsd.org> References: <20110407185510.GA94830@freebsd.org> <20110407212225.GA17091@freebsd.org> Date: Thu, 7 Apr 2011 14:58:02 -0700 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 21:58:03 -0000 On Thu, Apr 7, 2011 at 2:22 PM, Alexander Best wrote: > On Thu Apr =A07 11, Garrett Cooper wrote: >> On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrot= e: >> > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best = wrote: >> >> hi there, >> >> >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this= will let >> >> tinderbox fail, if any new kernel code was committed with (a) broken = include >> >> dir(s). >> >> >> >> i ran a test via >> >> >> >> make toolchains >> >> make MAKE_JUST_KERNELS=3Dyes tinderbox >> >> >> >> and nothing seemed to go wrong with the extra warning enabled. i even= found a >> >> missing include dir, which should be fixed by the attached patch. >> >> >> >> opinions? >> >> >> >> so far i've only tested this with gcc. i think someone on #freebsd-cl= ang told >> >> me that -Wmissing-include-dirs is a noop for clang (for whatever reas= ons). >> > >> > =A0 =A0make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.c= onf >> > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these >> > files, but it doesn't currently)? > > otaku% make -f /etc/src.conf -VMODULES_OVERRIDE > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth =A0netgrap= h/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket =A0netgr= aph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid =A0procfs pse= udofs linux linprocfs linsysfs lindev usb/quirk geom =A0opensolaris dtrace = cyclic nfsclient krpc nfs_common nfslock > otaku% make -f /etc/make.conf -VMODULES_OVERRIDE > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth =A0netgrap= h/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket =A0netgr= aph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid =A0procfs pse= udofs linux linprocfs linsysfs lindev usb/quirk geom =A0opensolaris dtrace = cyclic nfsclient krpc nfs_common nfslock > > ...however i checked and tinderbox *does* ignore src.conf and make.conf. = the > _.* log files show that modules were being build which are not returned b= y > the commands above. > > i think having this flag would be very useful, because it would force peo= ple to > make sure their include dirs are correct. > >> >> Sorry. Second invocation should have been make.conf, not src.conf. Ok then. I stand corrected for not having tested out my claim beforehand. Yes, I agree that adding this flag in the default set is a good idea. Thanks, -Garrett From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 8 12:45:13 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 83975106566C; Fri, 8 Apr 2011 12:45:13 +0000 (UTC) Date: Fri, 8 Apr 2011 12:45:13 +0000 From: Alexander Best To: Garrett Cooper Message-ID: <20110408124513.GA22745@freebsd.org> References: <20110407185510.GA94830@freebsd.org> <20110407212225.GA17091@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2011 12:45:13 -0000 On Thu Apr 7 11, Garrett Cooper wrote: > On Thu, Apr 7, 2011 at 2:22 PM, Alexander Best wrote: > > On Thu Apr  7 11, Garrett Cooper wrote: > >> On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper wrote: > >> > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best wrote: > >> >> hi there, > >> >> > >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let > >> >> tinderbox fail, if any new kernel code was committed with (a) broken include > >> >> dir(s). > >> >> > >> >> i ran a test via > >> >> > >> >> make toolchains > >> >> make MAKE_JUST_KERNELS=yes tinderbox > >> >> > >> >> and nothing seemed to go wrong with the extra warning enabled. i even found a > >> >> missing include dir, which should be fixed by the attached patch. > >> >> > >> >> opinions? > >> >> > >> >> so far i've only tested this with gcc. i think someone on #freebsd-clang told > >> >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons). > >> > > >> >    make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf > >> > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these > >> > files, but it doesn't currently)? > > > > otaku% make -f /etc/src.conf -VMODULES_OVERRIDE > > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock > > otaku% make -f /etc/make.conf -VMODULES_OVERRIDE > > netgraph/netgraph netgraph/socket netgraph/bluetooth/bluetooth  netgraph/bluetooth/hci netgraph/bluetooth/l2cap netgraph/bluetooth/socket  netgraph/bluetooth/ubt tmpfs sound/sound sound/driver/hda usb/uhid  procfs pseudofs linux linprocfs linsysfs lindev usb/quirk geom  opensolaris dtrace cyclic nfsclient krpc nfs_common nfslock > > > > ...however i checked and tinderbox *does* ignore src.conf and make.conf. the > > _.* log files show that modules were being build which are not returned by > > the commands above. > > > > i think having this flag would be very useful, because it would force people to > > make sure their include dirs are correct. > > > >> > >> Sorry. Second invocation should have been make.conf, not src.conf. > > Ok then. I stand corrected for not having tested out my claim beforehand. > > Yes, I agree that adding this flag in the default set is a good idea. cool. so now we need somebody to make the commit. ;) > > Thanks, > -Garrett -- a13x