From owner-freebsd-toolchain@FreeBSD.ORG Thu May 12 16:26:59 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1CA1106564A; Thu, 12 May 2011 16:26:59 +0000 (UTC) (envelope-from rakaur@malkier.net) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5AE0F8FC12; Thu, 12 May 2011 16:26:59 +0000 (UTC) Received: by ywf7 with SMTP id 7so735251ywf.13 for ; Thu, 12 May 2011 09:26:58 -0700 (PDT) Received: by 10.236.77.71 with SMTP id c47mr414399yhe.335.1305216148153; Thu, 12 May 2011 09:02:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.147.98.17 with HTTP; Thu, 12 May 2011 09:02:08 -0700 (PDT) From: Eric Will Date: Thu, 12 May 2011 12:02:08 -0400 Message-ID: To: freebsd-current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-toolchain@freebsd.org Subject: llvm port does not allow REQUIRES_RTTI X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2011 16:26:59 -0000 The current Makefile for devel/llvm doesn't allow you to use REQUIRES_RTTI. It's a pretty common option, and is even enabled by default in devel/llvm-devel. I emailed the maintainer months ago and haven't had a response or seen any changes. I've never done anything with ports before, but my best stab at it is below. Thanks, -- Eric Will --- /usr/ports/devel/llvm/Makefile 2011-04-29 11:04:29.000000000 -0400 +++ Makefile 2011-05-12 11:52:59.000000000 -0400 @@ -40,6 +40,7 @@ CONFIGURE_ARGS+= --enable-bindings=none OPTIONS= ASSERTS "Enable assertions (thread unsafe)" off +OPTIONS+= REQUIRES_RTTI "Enable run-time type IDs (RTTI)" on .if defined(NOPORTDOCS) CONFIGURE_ARGS+= --disable-docs @@ -70,6 +71,10 @@ .else CONFIGURE_ARGS+= --disable-assertions .endif +.ifdef(WITH_REQUIRES_RTTI) +CONFIGURE_ENV+=REQUIRES_RTTI=1 +MAKE_ENV+=REQUIRES_RTTI=1 +.endif post-patch: ${REINPLACE_CMD} -e 's|\(PROJ_docsdir.*:=\).*$$|\1${DOCSDIR}|g' \ From owner-freebsd-toolchain@FreeBSD.ORG Thu May 12 21:18:15 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91F221065670; Thu, 12 May 2011 21:18:15 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 2C14C8FC18; Thu, 12 May 2011 21:18:13 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.4/8.14.4) with ESMTP id p4CDdXlY038365; Thu, 12 May 2011 08:39:34 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.4/8.14.4/Submit) id p4CDdXhE038364; Thu, 12 May 2011 08:39:33 -0500 (CDT) (envelope-from brooks) Date: Thu, 12 May 2011 08:39:33 -0500 From: Brooks Davis To: Eric Will Message-ID: <20110512133933.GB37874@lor.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.6 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 12 May 2011 08:39:34 -0500 (CDT) Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: llvm port does not allow REQUIRES_RTTI X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2011 21:18:15 -0000 --gj572EiMnwbLXET9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 12, 2011 at 12:02:08PM -0400, Eric Will wrote: > The current Makefile for devel/llvm doesn't allow you to use > REQUIRES_RTTI. It's a pretty common option, and is even enabled by > default in devel/llvm-devel. I emailed the maintainer months ago and > haven't had a response or seen any changes. I've never done anything > with ports before, but my best stab at it is below. Sorry for dropping the ball on this. I'll try to get it done soon. The best way to submit this sort of change is via the PR system. -- Brooks >=20 > Thanks, >=20 > -- Eric Will >=20 > --- /usr/ports/devel/llvm/Makefile 2011-04-29 11:04:29.000000000 -04= 00 > +++ Makefile 2011-05-12 11:52:59.000000000 -0400 > @@ -40,6 +40,7 @@ > CONFIGURE_ARGS+=3D --enable-bindings=3Dnone >=20 > OPTIONS=3D ASSERTS "Enable assertions (thread unsafe)" off > +OPTIONS+=3D REQUIRES_RTTI "Enable run-time type IDs (RTTI)" on >=20 > .if defined(NOPORTDOCS) > CONFIGURE_ARGS+=3D --disable-docs > @@ -70,6 +71,10 @@ > .else > CONFIGURE_ARGS+=3D --disable-assertions > .endif > +.ifdef(WITH_REQUIRES_RTTI) > +CONFIGURE_ENV+=3DREQUIRES_RTTI=3D1 > +MAKE_ENV+=3DREQUIRES_RTTI=3D1 > +.endif >=20 > post-patch: > ${REINPLACE_CMD} -e 's|\(PROJ_docsdir.*:=3D\).*$$|\1${DOCSDIR}|g'= \ > _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to "freebsd-toolchain-unsubscribe@freebsd.o= rg" >=20 --gj572EiMnwbLXET9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFNy+MVXY6L6fI4GtQRAkuxAKDC/u1fUR8CUaPO59al8GjqupLcGACgyTsp 0vnsIiz5qrxxYJlCZc/k0xo= =Nt4K -----END PGP SIGNATURE----- --gj572EiMnwbLXET9--