From owner-freebsd-rc@FreeBSD.ORG Sun Jan 1 00:40:32 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC1DF106566C; Sun, 1 Jan 2012 00:40:31 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id A0CCE8FC15; Sun, 1 Jan 2012 00:40:31 +0000 (UTC) Received: from pps.filterd (ltcfislmsgpa03 [127.0.0.1]) by ltcfislmsgpa03.fnfis.com (8.14.4/8.14.4) with SMTP id q010W59W017537; Sat, 31 Dec 2011 18:40:30 -0600 Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa03.fnfis.com with ESMTP id 122a3urc0b-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 31 Dec 2011 18:40:30 -0600 Received: from [10.0.0.103] (10.14.152.30) by smtp.fisglobal.com (10.132.206.17) with Microsoft SMTP Server (TLS) id 14.1.323.3; Sat, 31 Dec 2011 18:40:29 -0600 MIME-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset="us-ascii" From: Devin Teske In-Reply-To: <4EFF9911.5020603@FreeBSD.org> Date: Sat, 31 Dec 2011 16:40:27 -0800 Content-Transfer-Encoding: quoted-printable Message-ID: References: <201112310758.pBV7webJ074390@freefall.freebsd.org> <8F16E728-1A94-4ECD-9D83-4A854AD7A702@fisglobal.com> <4EFF9911.5020603@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1084) X-Originating-IP: [10.14.152.30] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-31_06:2011-12-30, 2011-12-31, 1970-01-01 signatures=0 Cc: Devin, FreeBSD RC Subject: Re: The mountlate rc.d boot script cannot be disabled X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jan 2012 00:40:32 -0000 First, let me prefix my inline responses with stating that: Due to the addition of the "failok" mount(8) option, it is highly likely th= at this may solve our problems. However, since the "failok" addition is currently not available in any -REL= EASE, we cannot test it for production deployment (maybe in 6-months). With that being said, we look forward to when FreeBSD 8.3-RELEASE will be m= ade available (as I've confirmed that "failok" is tagged for RELENG_8, the = source for what should be 8.3 when created). On Dec 31, 2011, at 3:21 PM, Doug Barton wrote: > On 12/31/2011 8:34 AM, Chris Rees wrote: >> Doug, is there a reason that the patch is harmful? >=20 > 1. An unlimited number of knobs is not a virtue, it just leads to more > user confusion. >=20 > 2. The harm caused by a user accidentally flipping this is much greater > than any possible benefit that it could provide. I've been thinking about it and the patch does have the following two negat= ives: 1. disabling mountlate means the administrator needs to memorize that whils= t looking at fstab(5) that "late" filesystems could be neutered (good or ba= d, requires modification of man-pages, re-training to learn new axioms, etc= .) 2. mountlate is metaphorically the "enforcer" of mountcritremote. Disabling= mountlate means mountcritremote doesn't really make remote mounts critical. So, up until this point, we'd not been aware of the new "failok" option (wh= y would we? it's not really available yet) and now that we know about it, w= e look forward to checking it out in a future release. But at this time, ne= ither 8.1 nor 8.2 support it. Until we can upgrade, we'll have to resort to= modifying the system in some way. > I think Jilles had a good point, it's likely that the best actual change > to be made here is better documentation of the failok knob for fstab. >=20 Gcooper raised docs/163742 to address the lacking documentation. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 11:07:10 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C875F106566C for ; Mon, 2 Jan 2012 11:07:10 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB95A8FC15 for ; Mon, 2 Jan 2012 11:07:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q02B7AHf005226 for ; Mon, 2 Jan 2012 11:07:10 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q02B79Bi005222 for freebsd-rc@FreeBSD.org; Mon, 2 Jan 2012 11:07:09 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Jan 2012 11:07:09 GMT Message-Id: <201201021107.q02B79Bi005222@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 11:07:10 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/109272 rc [request] increase default rc shutdown timeout o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 94 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 12:06:00 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1611C106566B for ; Mon, 2 Jan 2012 12:06:00 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id DA6568FC16 for ; Mon, 2 Jan 2012 12:05:59 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so17478636obb.13 for ; Mon, 02 Jan 2012 04:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=o+uhXCMA6BOQsfcZqVZ7GYSmmdnjwyCteIGA9pxWQ7g=; b=wxHo21MGpvznTJkT0dJRF21dHAx0wCoVFCZdHaoSBhHzl3H0JDMj1URyLY/CgkgW0z UCDP9qm3/kFHlHCtUGv6inGyWlBtcW0MJ5moqt3PPhDfcvBBXxNgsL9N9EYwiQZQsDXl mEFW/T6+cWoxLrTw22n88v10Sx9tibyw3HpJ0= MIME-Version: 1.0 Received: by 10.182.2.136 with SMTP id 8mr41554124obu.71.1325505959322; Mon, 02 Jan 2012 04:05:59 -0800 (PST) Received: by 10.182.152.6 with HTTP; Mon, 2 Jan 2012 04:05:59 -0800 (PST) Date: Mon, 2 Jan 2012 04:05:59 -0800 Message-ID: From: Garrett Cooper To: "freebsd-rc@FreeBSD.org" Content-Type: text/plain; charset=ISO-8859-1 Subject: conf/122477 review/commit please? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 12:06:00 -0000 Hi, conf/122477 has been sitting in the PR queue for some time now. I was wondering whether or not someone had the time to review the patch and maybe commit it to CURRENT? It would also resolve the following 2 -rc PRs: conf/140261 docs/144537 . Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 12:10:13 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6300106566C for ; Mon, 2 Jan 2012 12:10:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7B56F8FC08 for ; Mon, 2 Jan 2012 12:10:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q02CADfG065700 for ; Mon, 2 Jan 2012 12:10:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q02CAD2Y065699; Mon, 2 Jan 2012 12:10:13 GMT (envelope-from gnats) Date: Mon, 2 Jan 2012 12:10:13 GMT Message-Id: <201201021210.q02CAD2Y065699@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/140261: [patch] Improve flexibility of mdconfig2 startup script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 12:10:13 -0000 The following reply was made to PR conf/140261; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, brian@bunyatech.com.au Cc: Subject: Re: conf/140261: [patch] Improve flexibility of mdconfig2 startup script Date: Mon, 2 Jan 2012 04:02:48 -0800 Please refer to conf/122477 for a patch that does what you want. Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 12:20:12 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD716106564A for ; Mon, 2 Jan 2012 12:20:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB9B18FC14 for ; Mon, 2 Jan 2012 12:20:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q02CKC66075756 for ; Mon, 2 Jan 2012 12:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q02CKCqI075755; Mon, 2 Jan 2012 12:20:12 GMT (envelope-from gnats) Date: Mon, 2 Jan 2012 12:20:12 GMT Message-Id: <201201021220.q02CKCqI075755@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/142304: rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack examples in /etc/defaults/rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 12:20:12 -0000 The following reply was made to PR conf/142304; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, freebsd@jdc.parodius.com Cc: Subject: Re: conf/142304: rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack examples in /etc/defaults/rc.conf Date: Mon, 2 Jan 2012 04:15:40 -0800 (PST) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --967339439-1118209983-1325506546=:90583 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Here are some working examples of how to use mdconfig_* (the only use-case I omitted is the _populate one). Cheers, -Garrett --967339439-1118209983-1325506546=:90583 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=document-mdconfig-usage-etc-defaults-rc.conf.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=document-mdconfig-usage-etc-defaults-rc.conf.patch SW5kZXg6IGV0Yy9kZWZhdWx0cy9yYy5jb25mDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQotLS0gZXRjL2RlZmF1bHRzL3JjLmNvbmYJKHJldmlzaW9uIDIy OTI3MSkNCisrKyBldGMvZGVmYXVsdHMvcmMuY29uZgkod29ya2luZyBjb3B5 KQ0KQEAgLTcwMCw2ICs3MDAsMjIgQEANCiAjamFpbF9leGFtcGxlX2ZzdGFi PSIiCQkJCSMgZnN0YWIoNSkgZm9yIG1vdW50L3Vtb3VudA0KICNqYWlsX2V4 YW1wbGVfZmxhZ3M9Ii1sIC1VIHJvb3QiCQkjIGZsYWdzIGZvciBqYWlsKDgp DQogDQorIyBFeGFtcGxlcyBvZiBob3cgdG8gdXNlIHRoZSBtZGNvbmZpZyBy YyBzY3JpcHRzIHRvLi4uDQorIyAxKSBjcmVhdGUgYSAxR0IgbWFsbG9jIGJh Y2tlZCBTVSBkaXNrLCBvd25lZCBieSByb290OndoZWVsLCBhbmQNCisjICAg IGNobW9kJ2VkIDA3NzAuDQorIyAyKSBtb3VudCBhbiBleGlzdGluZyB1emlw IGRpc2sgaW1hZ2Ugd2l0aCAvbWQudXppcC4NCisjIDMpIHBvcHVsYXRlIGEg MTBNQiBtZW1vcnkgZGlzayB3aXRoIGZpbGVzIGZyb20gL2NvbmYvYmFzZS9l dGMgLg0KKyMNCisjbWRjb25maWdfbWQwPSItdCBtYWxsb2MgLXMgMWciDQor I21kY29uZmlnX21kMF9vd25lcj0icm9vdDp3aGVlbCINCisjbWRjb25maWdf bWQwX3Blcm1zPSIwNzcwIg0KKyNtZGNvbmZpZ19tZDBfbmV3ZnM9Ii1VIg0K KyNtZGNvbmZpZ19tZDE9Ii10IHZub2RlIC1mIC9tZC51emlwIg0KKyNtZGNv bmZpZ19tZDI9Ii10IG1hbGxvYyAtcyAxMG0iDQorI21kY29uZmlnX21kMl9m aWxlcz0iL2NvbmYvYmFzZS9ldGMiDQorIw0KKyMgUGxlYXNlIG5vdGUgdGhh dCB0aGUgYWJvdmUgZXhhbXBsZXMgcmVxdWlyZSBmc3RhYiBlbnRyaWVzIGlu IG9yZGVyIHRvIHdvcmshDQorDQogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMNCiAjIyMg RGVmaW5lIHNvdXJjZV9yY19jb25mcywgdGhlIG1lY2hhbmlzbSB1c2VkIGJ5 IC9ldGMvcmMuKiAjIw0KICMjIyBzY3JpcHRzIHRvIHNvdXJjZSByY19jb25m X2ZpbGVzIG92ZXJyaWRlcyBzYWZlbHkuCSAgICAjIw0K --967339439-1118209983-1325506546=:90583-- From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 19:50:12 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AF6B106566C for ; Mon, 2 Jan 2012 19:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2ABAB8FC0C for ; Mon, 2 Jan 2012 19:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q02JoB3a091471 for ; Mon, 2 Jan 2012 19:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q02JoBbW091470; Mon, 2 Jan 2012 19:50:11 GMT (envelope-from gnats) Date: Mon, 2 Jan 2012 19:50:11 GMT Message-Id: <201201021950.q02JoBbW091470@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/137470: [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameters for _mdconfig2_list over the value in rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 19:50:12 -0000 The following reply was made to PR conf/137470; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, kagesenshi.87@gmail.com Cc: Subject: Re: conf/137470: [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameters for _mdconfig2_list over the value in rc.conf Date: Mon, 2 Jan 2012 11:45:08 -0800 Please refer to conf/122477 for a patch that does what you want. Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Mon Jan 2 20:00:32 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D55C8106566C for ; Mon, 2 Jan 2012 20:00:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B3FC28FC12 for ; Mon, 2 Jan 2012 20:00:32 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q02K0Wa2099774 for ; Mon, 2 Jan 2012 20:00:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q02K0Wm3099773; Mon, 2 Jan 2012 20:00:32 GMT (envelope-from gnats) Date: Mon, 2 Jan 2012 20:00:32 GMT Message-Id: <201201022000.q02K0Wm3099773@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/122477: [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring additional parameter in some cases X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 20:00:33 -0000 The following reply was made to PR conf/122477; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, j.unger@jpru.de Cc: Subject: Re: conf/122477: [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring additional parameter in some cases Date: Mon, 2 Jan 2012 11:53:15 -0800 (PST) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --967339439-1040549868-1325533997=:90583 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII The following patch is an updated copy of the prior version to stable/9 // head. It might be needed for stable/8 as well. Thanks, -Garrett --967339439-1040549868-1325533997=:90583 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=conf-122477-stable_9.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=conf-122477-stable_9.patch SW5kZXg6IGV0Yy9yYy5kL21kY29uZmlnDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQotLS0gZXRjL3JjLmQvbWRjb25maWcJKHJldmlzaW9uIDIyOTMwNykN CisrKyBldGMvcmMuZC9tZGNvbmZpZwkod29ya2luZyBjb3B5KQ0KQEAgLTE3 NCwxMCArMTc0LDExIEBADQogfQ0KIA0KIF9tZGNvbmZpZ19jbWQ9IiQxIg0K K2V2YWwgX21kY29uZmlnX2xpc3Q9XCRtZGNvbmZpZ191bml0cw0KIGlmIFsg JCMgLWd0IDAgXTsgdGhlbg0KICAgICAgICAgc2hpZnQNCiBmaQ0KLVsgLW4g IiQqIiBdICYmIF9tZGNvbmZpZ19saXN0PSIkKiINCitbIC16ICIkX21kY29u ZmlnX2xpc3QiIC1hIC1uICIkKiIgXSAmJiBfbWRjb25maWdfbGlzdD0iJCoi DQogDQogbG9hZF9yY19jb25maWcgJG5hbWUNCiANCkluZGV4OiBldGMvcmMu ZC9tZGNvbmZpZzINCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBldGMv cmMuZC9tZGNvbmZpZzIJKHJldmlzaW9uIDIyOTMwNykNCisrKyBldGMvcmMu ZC9tZGNvbmZpZzIJKHdvcmtpbmcgY29weSkNCkBAIC0yMDQsMTAgKzIwNCwx MSBAQA0KIH0NCiANCiBfbWRjb25maWcyX2NtZD0iJDEiDQorZXZhbCBfbWRj b25maWcyX2xpc3Q9XCRtZGNvbmZpZ191bml0cw0KIGlmIFsgJCMgLWd0IDAg XTsgdGhlbg0KICAgICAgICAgc2hpZnQNCiBmaQ0KLVsgLW4gIiQqIiBdICYm IF9tZGNvbmZpZzJfbGlzdD0iJCoiDQorWyAteiAiJF9tZGNvbmZpZzJfbGlz dCIgLWEgLW4gIiQqIiBdICYmIF9tZGNvbmZpZzJfbGlzdD0iJCoiDQogDQog bG9hZF9yY19jb25maWcgJG5hbWUNCiANCkluZGV4OiBzaGFyZS9tYW4vbWFu NS9yYy5jb25mLjUNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBzaGFy ZS9tYW4vbWFuNS9yYy5jb25mLjUJKHJldmlzaW9uIDIyOTMwNykNCisrKyBz aGFyZS9tYW4vbWFuNS9yYy5jb25mLjUJKHdvcmtpbmcgY29weSkNCkBAIC00 MjAzLDYgKzQyMDMsMjMgQEANCiB3aGljaCBjYXVzZXMgbG9nIGZpbGVzIGZs YWdnZWQgd2l0aCBhDQogLkNtIEMNCiB0byBiZSBjcmVhdGVkLg0KKy5JdCBW YSBtZGNvbmZpZ191bml0cw0KKy5QcSBWdCBzdHINCitBIGxpc3Qgb2Ygb25l IG9yIG1vcmUNCisuWHIgbWQgNA0KK3VuaXRzIHRvIGNvbmZpZ3VyZSB3aXRo DQorLlhyIG1kY29uZmlnIDgNCithbmQNCisuWHIgbmV3ZnMgOA0KK2luIHRp bWUgdG8gYmUgbW91bnRlZCB3aXRoDQorLlhyIGZzdGFiIDUgLg0KK0lmIHVu c3BlY2lmaWVkLCB0aGUNCisuVmEgbWRjb25maWdfbWQgTnMgQXEgQXIgWA0K K3ZhcmlhYmxlcyBhcmUgZXZhbHVhdGVkIGluIGNvbnNlY3V0aXZlIG9yZGVy IGZyb20gbWQwLCB1bnRpbCBvbmUgdmFyaWFibGUgaXMNCit1bnNldCBvciBu dWxsLg0KK1NlZSB0aGUNCisuVmEgbWRjb25maWdfbWQgTnMgQXEgQXIgWA0K K3ZhcmlhYmxlIGRlc2NyaXB0aW9ucyBiZWxvdyBmb3IgbW9yZSBkZXRhaWxz Lg0KIC5JdCBWYSBtZGNvbmZpZ19tZCBOcyBBcSBBciBYDQogLlBxIFZ0IHN0 cg0KIEFyZ3VtZW50cyB0bw0KQEAgLTQyMjEsMTAgKzQyMzgsMTIgQEANCiAu RmwgZiBBciBmaWxlDQogZm9yIHZub2RlIGJhY2tlZA0KIC5YciBtZCA0DQot ZGV2aWNlcy4NCi1Ob3RlIHRoYXQNCitkZXZpY2VzLiBFYWNoDQogLlZhIG1k Y29uZmlnX21kIE5zIEFxIEFyIFgNCi12YXJpYWJsZXMgYXJlIGV2YWx1YXRl ZCB1bnRpbCBvbmUgdmFyaWFibGUgaXMgdW5zZXQgb3IgbnVsbC4NCitlbnRy eSBsaXN0ZWQgaW4NCisuVmEgbWRjb25maWdfdW5pdHMNCittdXN0IGJlIGRl ZmluZWQgaW4NCisuWHIgZnN0YWIgNSAuDQogLkl0IFZhIG1kY29uZmlnX21k IE5zIEFvIEFyIFggQWMgTnMgVmEgX25ld2ZzDQogLlBxIFZ0IHN0cg0KIE9w dGlvbmFsIGFyZ3VtZW50cyBwYXNzZWQgdG8NCg== --967339439-1040549868-1325533997=:90583-- From owner-freebsd-rc@FreeBSD.ORG Tue Jan 3 21:05:42 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB0FF106564A for ; Tue, 3 Jan 2012 21:05:42 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id D16E18FC16 for ; Tue, 3 Jan 2012 21:05:42 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id B1D7017160; Tue, 3 Jan 2012 13:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1325624742; bh=BfmoXr+hte+VbydXyANtJMaFtB1wLvAPsc4PkXZNI8A=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: Content-Type; b=rsvUQves12SWauLOLd6v/OoxvC3IbD7SITC0LyauT4lzMEf+UWRjaBp0zkys15Q9d fCkoVSUY87GosdIhUypTzxQE+F0ud7LiHdqdBWBiMRplEud/TBIDZ9GfOWaBaF8eUA nFjYy3tOwbRZC75EOTXYDcBUknKZxwQ1LzJEiinM= Message-ID: <4F036DA5.7040907@delphij.net> Date: Tue, 03 Jan 2012 13:05:41 -0800 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: freebsd-rc@FreeBSD.org X-Enigmail-Version: undefined Content-Type: multipart/mixed; boundary="------------060803010208010909020901" Cc: d@delphij.net Subject: [review] Move slapd to 'DAEMON' stage X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2012 21:05:43 -0000 This is a multi-part message in MIME format. --------------060803010208010909020901 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, A user have asked for this in ports/163799. I _think_ I should move slapd to 'DAEMON' stage by adding a BEFORE: line? (Or, is that the right place to start (database) backend service for authentication services?) Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8DbaUACgkQOfuToMruuMDi2gCfZKpW5fhNiteucgZ+gcodHPiF 2wkAniCGBmEhM5eeklzGGiXXY5cksmD7 =Zv95 -----END PGP SIGNATURE----- --------------060803010208010909020901 Content-Type: text/plain; name="slapd.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="slapd.diff" Index: files/slapd.sh.in =================================================================== RCS file: /home/ncvs/ports/net/openldap24-server/files/slapd.sh.in,v retrieving revision 1.13 diff -u -p -r1.13 slapd.sh.in --- files/slapd.sh.in 15 May 2011 02:49:10 -0000 1.13 +++ files/slapd.sh.in 3 Jan 2012 20:59:49 -0000 @@ -4,8 +4,8 @@ # # PROVIDE: slapd -# REQUIRE: NETWORKING SERVERS -# BEFORE: securelevel +# REQUIRE: NETWORKING +# BEFORE: DAEMON # KEYWORD: shutdown # --------------060803010208010909020901-- From owner-freebsd-rc@FreeBSD.ORG Wed Jan 4 00:00:22 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id F06E61065687; Wed, 4 Jan 2012 00:00:22 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 568881562AC; Wed, 4 Jan 2012 00:00:21 +0000 (UTC) Message-ID: <4F039694.4010801@FreeBSD.org> Date: Tue, 03 Jan 2012 16:00:20 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: d@delphij.net References: <4F036DA5.7040907@delphij.net> In-Reply-To: <4F036DA5.7040907@delphij.net> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: multipart/mixed; boundary="------------070508030002080304050304" Cc: freebsd-rc@FreeBSD.org, Xin Li , mm@FreeBSD.org Subject: Re: [review] Move slapd to 'DAEMON' stage X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2012 00:00:23 -0000 This is a multi-part message in MIME format. --------------070508030002080304050304 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 01/03/2012 13:05, Xin Li wrote: > Hi, > > A user have asked for this in ports/163799. I _think_ I should move > slapd to 'DAEMON' stage by adding a BEFORE: line? (Or, is that the > right place to start (database) backend service for authentication > services?) The general rule is that ports rc.d scripts should REQUIRE: LOGIN unless there is a good reason not to. Based on the description in the PR, this sounds like a good reason. I would think that a combination of: REQUIRE: DAEMON BEFORE: LOGIN would do it for you. You might also consider adding a comment explaining why it's necessary to deviate from the norm, since the pattern above is one that was originally used for a lot of ports' rc.d scripts, even though it was meaningless to start with, and then pathological after I incorporated them into the base rcorder. Since the originator of the PR mentioned proftpd explicitly, I'll take the opportunity to once again point out that its rc.d script should be fixed to use only 'REQUIRE: LOGIN' rather then the 2 options listed above. This issue is a good reason why. :) It could also benefit from using get_pidfile_from_conf. The attached version has those updates, plus a bug fix, etc. It also adds the ability to specify the configuration file. Martin if you could respond that'd be great. :) Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ --------------070508030002080304050304 Content-Type: text/plain; name="proftpd.in" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="proftpd.in" #!/bin/sh # $FreeBSD: ports/ftp/proftpd/files/proftpd.in,v 1.2 2010/03/27 00:13:01 dougb Exp $ # # PROVIDE: proftpd # REQUIRE: LOGIN # KEYWORD: shutdown # # Add the following lines to /etc/rc.conf to enable proftpd: # # proftpd_enable="YES" # proftpd_flags="" # # See proftpd(8) for flags . /etc/rc.subr name=proftpd rcvar=`set_rcvar` load_rc_config $name proftpd_enable=${proftpd_enable:-"NO"} required_files=${proftpd_conf:-"%%PREFIX%%/etc/proftpd.conf"} command=%%PREFIX%%/sbin/proftpd extra_commands="reload" start_precmd=find_pidfile stop_precmd=find_pidfile stop_postcmd="rm -f $pidfile" find_pidfile() { if type get_pidfile_from_conf >/dev/null 2>&1 && get_pidfile_from_conf PidFile $required_files ; then pidfile="$_pidfile_from_conf" else pidfile=$(grep PidFile $required_files) pidfile=${pidfile##*[ ]} fi : ${pidfile:="/var/run/${name}.pid"} } run_rc_command "$1" --------------070508030002080304050304-- From owner-freebsd-rc@FreeBSD.ORG Fri Jan 6 14:30:10 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CDE8106566B for ; Fri, 6 Jan 2012 14:30:10 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id D792E8FC1F for ; Fri, 6 Jan 2012 14:30:09 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 934814A8 for ; Fri, 6 Jan 2012 15:14:11 +0100 (CET) Date: Fri, 6 Jan 2012 15:13:03 +0100 From: Pawel Jakub Dawidek To: freebsd-rc@FreeBSD.org Message-ID: <20120106141301.GE1693@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XStn23h1fwudRqtG" Content-Disposition: inline X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Subject: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 14:30:10 -0000 --XStn23h1fwudRqtG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Any objections? http://people.freebsd.org/~pjd/patches/set_rcvar.patch This patch only changes scripts where set_rcvar can be used with no arguments. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --XStn23h1fwudRqtG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8HAWwACgkQForvXbEpPzTH3ACgvZCvUVhrZ0kO5yu+EbqOHLNQ adUAn1LpMcy+alNgdgLnwIpEgDNcyUOw =QFj8 -----END PGP SIGNATURE----- --XStn23h1fwudRqtG-- From owner-freebsd-rc@FreeBSD.ORG Fri Jan 6 15:17:42 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 775EE106566B; Fri, 6 Jan 2012 15:17:42 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) by mx1.freebsd.org (Postfix) with ESMTP id 0B32F8FC08; Fri, 6 Jan 2012 15:17:42 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id E452B1DD630; Fri, 6 Jan 2012 16:17:40 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id C9F6928468; Fri, 6 Jan 2012 16:17:40 +0100 (CET) Date: Fri, 6 Jan 2012 16:17:40 +0100 From: Jilles Tjoelker To: Pawel Jakub Dawidek Message-ID: <20120106151740.GA75037@stack.nl> References: <20120106141301.GE1693@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120106141301.GE1693@garage.freebsd.pl> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 15:17:42 -0000 On Fri, Jan 06, 2012 at 03:13:03PM +0100, Pawel Jakub Dawidek wrote: > Any objections? > http://people.freebsd.org/~pjd/patches/set_rcvar.patch > This patch only changes scripts where set_rcvar can be used with no > arguments. While this makes the scripts cleaner, it will lead to extra forks with the current implementation of sh which will slow down boot to some extent. The effect is small on x86 but may be large on embedded platforms. If I could change history, I would have forbidden calling a function from a command substitution like that in the template. Instead, the function should be called normally and should set the variable itself. However, I think that cannot be changed anymore. I have a fairly small patch to sh to eliminate the fork when expanding $(set_rcvar). However, one could object that this does not add true new capabilities but only a new notation to the part of the language that executes without forks (because the function could write into a variable instead of being command-substituted). -- Jilles Tjoelker From owner-freebsd-rc@FreeBSD.ORG Fri Jan 6 15:26:40 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EE0C106566B for ; Fri, 6 Jan 2012 15:26:40 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id C25C68FC0A for ; Fri, 6 Jan 2012 15:26:39 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 16406500; Fri, 6 Jan 2012 16:26:38 +0100 (CET) Date: Fri, 6 Jan 2012 16:25:29 +0100 From: Pawel Jakub Dawidek To: Jilles Tjoelker Message-ID: <20120106152529.GF1693@garage.freebsd.pl> References: <20120106141301.GE1693@garage.freebsd.pl> <20120106151740.GA75037@stack.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3607uds81ZQvwCD0" Content-Disposition: inline In-Reply-To: <20120106151740.GA75037@stack.nl> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 15:26:40 -0000 --3607uds81ZQvwCD0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2012 at 04:17:40PM +0100, Jilles Tjoelker wrote: > On Fri, Jan 06, 2012 at 03:13:03PM +0100, Pawel Jakub Dawidek wrote: > > Any objections? >=20 > > http://people.freebsd.org/~pjd/patches/set_rcvar.patch >=20 > > This patch only changes scripts where set_rcvar can be used with no > > arguments. >=20 > While this makes the scripts cleaner, it will lead to extra forks with > the current implementation of sh which will slow down boot to some > extent. The effect is small on x86 but may be large on embedded > platforms. That was my concern as well, but I was under impression that using set_rcvar is preferred. I'm fine either way, but would like it to be consistent across system startup scripts. I like using set_rcvar as it eliminates typing name in one more place. Very handy when you create your own script by changing existing one. > If I could change history, I would have forbidden calling a function > from a command substitution like that in the template. Instead, the > function should be called normally and should set the variable itself. > However, I think that cannot be changed anymore. >=20 > I have a fairly small patch to sh to eliminate the fork when expanding > $(set_rcvar). However, one could object that this does not add true new > capabilities but only a new notation to the part of the language that > executes without forks (because the function could write into a variable > instead of being command-substituted). Wouldn't it be helpful to define name before loading rc.subr? This would make the scripts less pretty, though. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --3607uds81ZQvwCD0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8HEmQACgkQForvXbEpPzSibQCglOnSuF52h1R17bzWDMSLN+sC igMAoMaCxMxjb27qH1TROvviCqC5PNFo =4iZc -----END PGP SIGNATURE----- --3607uds81ZQvwCD0-- From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 01:06:00 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 72D981065670; Sat, 7 Jan 2012 01:06:00 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 76DE114F80F; Sat, 7 Jan 2012 01:05:59 +0000 (UTC) Message-ID: <4F079A76.3030306@FreeBSD.org> Date: Fri, 06 Jan 2012 17:05:58 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <20120106141301.GE1693@garage.freebsd.pl> In-Reply-To: <20120106141301.GE1693@garage.freebsd.pl> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 01:06:00 -0000 On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > Any objections? > > http://people.freebsd.org/~pjd/patches/set_rcvar.patch > > This patch only changes scripts where set_rcvar can be used with no > arguments. Please don't do this. Jilles already pointed out the important reason, it adds pointless forks. I suggested a long time ago that we remove set_rcvar altogether but I got a lot of resistance to it, and never pursued it. Perhaps it's time to revisit that. In regards to your concern about not having to type the name of the script when copying to create a new one, you can't really be serious about that? If so, let me introduce you to this revolutionary thing called "search and replace." If you really need to make this simpler for copy/paste purposes in http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html I recommend using: rcvar=${name}_enable The microsecond it takes to dereference that is an acceptable cost to making the copy/paste issue more palatable. This is particularly important in the ports area since there is so much copy/paste that goes on in that sphere. Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 11:26:46 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57F59106566B for ; Sat, 7 Jan 2012 11:26:46 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id F11138FC0C for ; Sat, 7 Jan 2012 11:26:45 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 6DEE01A2; Sat, 7 Jan 2012 12:26:44 +0100 (CET) Date: Sat, 7 Jan 2012 12:25:38 +0100 From: Pawel Jakub Dawidek To: Doug Barton Message-ID: <20120107112538.GC1696@garage.freebsd.pl> References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qrgsu6vtpU/OV/zm" Content-Disposition: inline In-Reply-To: <4F079A76.3030306@FreeBSD.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 11:26:46 -0000 --Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: > On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > > Any objections? > >=20 > > http://people.freebsd.org/~pjd/patches/set_rcvar.patch > >=20 > > This patch only changes scripts where set_rcvar can be used with no > > arguments. >=20 > Please don't do this. >=20 > Jilles already pointed out the important reason, it adds pointless > forks. I suggested a long time ago that we remove set_rcvar altogether > but I got a lot of resistance to it, and never pursued it. Perhaps it's > time to revisit that. It is a total mess now then and it is definiately not intuitive when there are much more bad examples than good ones: % grep -r ^rcvar /usr/src/etc/rc.d | grep set_rcvar | wc -l 66 % grep -r ^rcvar /usr/src/etc/rc.d | grep -v set_rcvar | wc -l 34 > In regards to your concern about not having to type the name of the > script when copying to create a new one, you can't really be serious > about that? If so, let me introduce you to this revolutionary thing > called "search and replace." Do you really expect me to comment this? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --Qrgsu6vtpU/OV/zm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8IK7EACgkQForvXbEpPzTqTwCcCcKfXAnfbgCCJYkqZzKTEmlY vakAniEZ3Xoduq+14Wwe710WaXlPtBOn =KnoQ -----END PGP SIGNATURE----- --Qrgsu6vtpU/OV/zm-- From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 22:39:04 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 3BEEB1065670; Sat, 7 Jan 2012 22:39:04 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id B055A15803A; Sat, 7 Jan 2012 22:38:30 +0000 (UTC) Message-ID: <4F08C95F.6040808@FreeBSD.org> Date: Sat, 07 Jan 2012 14:38:23 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org> <20120107112538.GC1696@garage.freebsd.pl> In-Reply-To: <20120107112538.GC1696@garage.freebsd.pl> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 22:39:04 -0000 On 01/07/2012 03:25, Pawel Jakub Dawidek wrote: > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: >>> Any objections? >>> >>> http://people.freebsd.org/~pjd/patches/set_rcvar.patch >>> >>> This patch only changes scripts where set_rcvar can be used with no >>> arguments. >> >> Please don't do this. >> >> Jilles already pointed out the important reason, it adds pointless >> forks. I suggested a long time ago that we remove set_rcvar altogether >> but I got a lot of resistance to it, and never pursued it. Perhaps it's >> time to revisit that. > > It is a total mess now then and it is definiately not intuitive when > there are much more bad examples than good ones: I agree, which is why I previously proposed assigning them all directly when possible (which is in almost all cases). If no one speaks up opposing this idea in the next few days I'm still prepared to proceed. >> In regards to your concern about not having to type the name of the >> script when copying to create a new one, you can't really be serious >> about that? If so, let me introduce you to this revolutionary thing >> called "search and replace." > > Do you really expect me to comment this? Well I don't know, I thought you were being funny in your post, so I was trying to respond in kind. Sorry if the humor missed the mark. Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 22:42:26 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92583106566B; Sat, 7 Jan 2012 22:42:26 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 422728FC13; Sat, 7 Jan 2012 22:42:26 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 61E38348; Sat, 7 Jan 2012 23:42:24 +0100 (CET) Date: Sat, 7 Jan 2012 23:41:17 +0100 From: Pawel Jakub Dawidek To: Doug Barton Message-ID: <20120107224116.GB1674@garage.freebsd.pl> References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org> <20120107112538.GC1696@garage.freebsd.pl> <4F08C95F.6040808@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JP+T4n/bALQSJXh8" Content-Disposition: inline In-Reply-To: <4F08C95F.6040808@FreeBSD.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 22:42:26 -0000 --JP+T4n/bALQSJXh8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 07, 2012 at 02:38:23PM -0800, Doug Barton wrote: > On 01/07/2012 03:25, Pawel Jakub Dawidek wrote: > > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: > >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > >>> Any objections? > >>> > >>> http://people.freebsd.org/~pjd/patches/set_rcvar.patch > >>> > >>> This patch only changes scripts where set_rcvar can be used with no > >>> arguments. > >> > >> Please don't do this. > >> > >> Jilles already pointed out the important reason, it adds pointless > >> forks. I suggested a long time ago that we remove set_rcvar altogether > >> but I got a lot of resistance to it, and never pursued it. Perhaps it's > >> time to revisit that. > >=20 > > It is a total mess now then and it is definiately not intuitive when > > there are much more bad examples than good ones: >=20 > I agree, which is why I previously proposed assigning them all directly > when possible (which is in almost all cases). If no one speaks up > opposing this idea in the next few days I'm still prepared to proceed. Don't forget to update documentation (rc(8)). --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --JP+T4n/bALQSJXh8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8IygwACgkQForvXbEpPzSbWACfasMixEirDarFsJWARZvgNGNf VosAn2BP+IZDHHl0/7Mu7A69mlWTm8oD =/w1p -----END PGP SIGNATURE----- --JP+T4n/bALQSJXh8-- From owner-freebsd-rc@FreeBSD.ORG Sat Jan 7 23:12:32 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58561106566C; Sat, 7 Jan 2012 23:12:32 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4EB228FC0C; Sat, 7 Jan 2012 23:12:31 +0000 (UTC) Received: from alph.allbsd.org ([IPv6:2001:2f0:104:e010:862b:2bff:febc:8956]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.4) with ESMTP id q07NCJlQ000955; Sun, 8 Jan 2012 08:12:29 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id q07NCIXR075248; Sun, 8 Jan 2012 08:12:18 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 08 Jan 2012 08:12:16 +0900 (JST) Message-Id: <20120108.081216.1547061187942402256.hrs@allbsd.org> To: dougb@FreeBSD.org From: Hiroki Sato In-Reply-To: <4F08C95F.6040808@FreeBSD.org> References: <4F079A76.3030306@FreeBSD.org> <20120107112538.GC1696@garage.freebsd.pl> <4F08C95F.6040808@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3.51 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Jan__8_08_12_16_2012_123)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [IPv6:2001:2f0:104:e001::32]); Sun, 08 Jan 2012 08:12:29 +0900 (JST) X-Spam-Status: No, score=-104.6 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT, RDNS_NONE, SPF_SOFTFAIL, USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org, pjd@FreeBSD.org Subject: Re: Making use of set_rcvar. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 23:12:32 -0000 ----Security_Multipart(Sun_Jan__8_08_12_16_2012_123)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Doug Barton wrote in <4F08C95F.6040808@FreeBSD.org>: do> On 01/07/2012 03:25, Pawel Jakub Dawidek wrote: do> > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: do> >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: do> >>> Any objections? do> >>> do> >>> http://people.freebsd.org/~pjd/patches/set_rcvar.patch do> >>> do> >>> This patch only changes scripts where set_rcvar can be used with no do> >>> arguments. do> >> do> >> Please don't do this. do> >> do> >> Jilles already pointed out the important reason, it adds pointless do> >> forks. I suggested a long time ago that we remove set_rcvar altogether do> >> but I got a lot of resistance to it, and never pursued it. Perhaps it's do> >> time to revisit that. do> > do> > It is a total mess now then and it is definiately not intuitive when do> > there are much more bad examples than good ones: do> do> I agree, which is why I previously proposed assigning them all directly do> when possible (which is in almost all cases). If no one speaks up do> opposing this idea in the next few days I'm still prepared to proceed. I am always wondering if defining $rcvar as "${name}_enable" at the end of load_rc_config() when $rcvar is undefined is bad idea. Is there any problem with removing rcvar=... in individual rc.d scripts except for non-standard ones (empty or different from ${name}_enable)? It looks simpler than writing the same line "rcvar=${name}_enable" many times in various places. -- Hiroki ----Security_Multipart(Sun_Jan__8_08_12_16_2012_123)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk8I0VAACgkQTyzT2CeTzy2YggCdGmUN56/wPERmgYOs+pA+UdV7 dFoAoM7SxvTzBe7QsN8SuHXXA/RlmkGK =LirW -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Jan__8_08_12_16_2012_123)----