From owner-p4-projects@FreeBSD.ORG Sun Nov 4 05:17:29 2012 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 91895603; Sun, 4 Nov 2012 05:17:28 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 43553601 for ; Sun, 4 Nov 2012 05:17:28 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 2852D8FC0C for ; Sun, 4 Nov 2012 05:17:28 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id qA45HRkq016700 for ; Sun, 4 Nov 2012 05:17:27 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id qA45HRTo016697 for perforce@freebsd.org; Sun, 4 Nov 2012 05:17:27 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Sun, 4 Nov 2012 05:17:27 GMT Message-Id: <201211040517.qA45HRTo016697@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson Subject: PERFORCE change 219543 for review To: Perforce Change Reviews Precedence: bulk X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.14 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2012 05:17:29 -0000 http://p4web.freebsd.org/@@219543?ac=10 Change 219543 by rwatson@rwatson_svr_ctsrd_mipsbuild on 2012/11/04 05:16:43 Until the CheriBSD kernel's bcopy()/memcpy() become capability-oblivious, use an explicit capability-aware context initialisation function when copying saved register files during fork(). Affected files ... .. //depot/projects/ctsrd/cheribsd/src/sys/mips/mips/vm_machdep.c#5 edit Differences ... ==== //depot/projects/ctsrd/cheribsd/src/sys/mips/mips/vm_machdep.c#5 (text+ko) ==== @@ -59,6 +59,9 @@ #include #include +#ifdef CPU_CHERI +#include +#endif #include #include #include @@ -129,6 +132,16 @@ */ bcopy(td1->td_pcb, pcb2, sizeof(*pcb2)); +#ifdef CPU_CHERI + /* + * XXXRW: We're copying this memory twice -- once in the bcopy() + * above, and once here using capabilities. Once bcopy() is + * capability-oblivious, we can lose this. + */ + cheri_context_copy(&pcb2->pcb_cheriframe, + &td1->td_pcb->pcb_cheriframe); +#endif + /* Point mdproc and then copy over td1's contents * md_proc is empty for MIPS */