From owner-freebsd-arch@FreeBSD.ORG Tue Apr 23 16:39:09 2013 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E89785D7; Tue, 23 Apr 2013 16:39:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by mx1.freebsd.org (Postfix) with ESMTP id BF9331FDD; Tue, 23 Apr 2013 16:39:09 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id kp14so606793pab.36 for ; Tue, 23 Apr 2013 09:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:x-mailer:from:subject:date :to; bh=R7LoHx2D1x2qwhZ7P84bXgBVcp/A6S41glS8KEketLI=; b=hvaRr3VjhZSNgnbVySqENWh8ga6NZm+CzAXgF2tsFkbuXMERud6PhJRNBZ0U14uMWe Dc4bEgKt4VyaVpOzUVMZy3mW+8GHzg+jsZbpWcP6WD7mJOJdIKSWW4jZVJJz89oyviev 2JWOZAoZM9UTkNPsGelONzAdY88QkTuSjsopNp1epdIh4k6B60oxRySNCSeE5fWJ3C9N zWRYWrRs8M/Zl7n9JztiFgGJFZ1YieCdrtA7TLLDyqc99Z05dwuvnmwUQaosymn230WA DOuFQzuRrNfNiqZSYpMqFZHzsuN6lNN4mj9uOP6Cys31zsa3qNXO03ULWQisF/iRdvGS AKWQ== X-Received: by 10.66.232.230 with SMTP id tr6mr31698083pac.83.1366735149147; Tue, 23 Apr 2013 09:39:09 -0700 (PDT) Received: from [10.43.238.124] (mobile-166-147-080-091.mycingular.net. [166.147.80.91]) by mx.google.com with ESMTPS id ak1sm30188765pbc.10.2013.04.23.09.39.06 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 09:39:08 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (10B329) From: Garrett Cooper Subject: Re: [RFC] [Optionally] build tests with buildworld Date: Tue, 23 Apr 2013 09:39:03 -0700 To: "arch@FreeBSD.org" , "toolchain@FreeBSD.org" Cc: "Simon J. Gerraty" , Marcel Moolenaar X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 16:39:10 -0000 On Apr 19, 2013, at 11:17 PM, Garrett Cooper wrote: > Hi arch@ and toolchain@, > One of the items that I'm proposing be added to Makefile.inc1 in > order to make building and installing tests on CURRENT (ATF and > otherwise) is a build knob called TESTS_WITH_WORLD (the name can be > modified), which allows me to build and install various tests on my > git branch like the example ATF tests I produced, pjdfstest, some of > the prove tests from tools/regression, etc (there are other > outstanding changes, but this was the key one that I need feedback on > just to be safe). > The effective change is attached (Gmail will no doubt mangle it, > so please let me know if you want another copy). I made the change to > Makefile.inc1 in order to ensure that the change was self-contained > and because it was the simplest, cleanest way to do things without > introducing a lot of unwanted complexity. > I'm asking for feedback on the following items: > 1. Does the change make functional sense? If not, why? > 2. Do the semantics (variable names, whether or not they're > defined) need to be modified to match MK_* semantics or be made more > consistent in any particular way? If so, why? > 3. Will anyone have serious heartburn (already have a similar > change implemented, think it's done in a backwards manner) if this > change is implemented? If so, why? > Thanks! > -Garrett >=20 > PS Please CC me on all replies as I'm not subscribed to the list. > Ping? If no one replies in a week I'll consider it implicit agreement :)= .. Thanks, -Garrett=