From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr 21 03:40:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 6B1DDDB7
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sun, 21 Apr 2013 03:40:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 390AC1C2
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sun, 21 Apr 2013 03:40:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3L3e125090399
 for <freebsd-bugs@freefall.freebsd.org>; Sun, 21 Apr 2013 03:40:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3L3e1i6090398;
 Sun, 21 Apr 2013 03:40:01 GMT (envelope-from gnats)
Resent-Date: Sun, 21 Apr 2013 03:40:01 GMT
Resent-Message-Id: <201304210340.r3L3e1i6090398@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Adam Nowacki <nowak@tepeserwery.pl>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C6947D2F
 for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Apr 2013 03:35:59 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id B80B1171
 for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Apr 2013 03:35:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3L3ZwOQ062534
 for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Apr 2013 03:35:58 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r3L3Zwo6062533;
 Sun, 21 Apr 2013 03:35:58 GMT (envelope-from nobody)
Message-Id: <201304210335.r3L3Zwo6062533@red.freebsd.org>
Date: Sun, 21 Apr 2013 03:35:58 GMT
From: Adam Nowacki <nowak@tepeserwery.pl>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: misc/178016: nfsserver readdir panic, missing vnode type check
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Apr 2013 03:40:01 -0000


>Number:         178016
>Category:       misc
>Synopsis:       nfsserver readdir panic, missing vnode type check
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 21 03:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Adam Nowacki
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD storage 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Sat Feb 23 15:51:26 UTC 2013     root@storage:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
New nfs server will process READDIR on non-directories. Kernel panic is almost certain if readdir is executed on regular file.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/fs/nfsserver/nfs_nfsdport.c
===================================================================
--- sys/fs/nfsserver/nfs_nfsdport.c	(revision 249437)
+++ sys/fs/nfsserver/nfs_nfsdport.c	(working copy)
@@ -1575,6 +1575,8 @@
 			nd->nd_repstat = NFSERR_BAD_COOKIE;
 #endif
 	}
+	if (!nd->nd_repstat && vp->v_type != VDIR)
+		nd->nd_repstat = NFSERR_NOTDIR;
 	if (nd->nd_repstat == 0 && cnt == 0) {
 		if (nd->nd_flag & ND_NFSV2)
 			/* NFSv2 does not have NFSERR_TOOSMALL */


>Release-Note:
>Audit-Trail:
>Unformatted: