From owner-freebsd-drivers@FreeBSD.ORG Thu Oct 3 07:14:06 2013 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2025013A for ; Thu, 3 Oct 2013 07:14:06 +0000 (UTC) (envelope-from paul-a.patience@polymtl.ca) Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by mx1.freebsd.org (Postfix) with ESMTP id E251F288A for ; Thu, 3 Oct 2013 07:14:05 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjoIABK/CFFFpcPK/2dsb2JhbABErF0BikSEE4NZF3OCTBMccgFKP4gJoAuhIo1hgykDn1yGfIMT X-IPAS-Result: AjoIABK/CFFFpcPK/2dsb2JhbABErF0BikSEE4NZF3OCTBMccgFKP4gJoAuhIo1hgykDn1yGfIMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="34650426" Received: from 69-165-195-202.cable.teksavvy.com (HELO d530.9front) ([69.165.195.202]) by ironport2-out.teksavvy.com with ESMTP; 03 Oct 2013 03:10:36 -0400 Message-ID: <64bad99f27cc6c5cafd063e2d3232e68@yourdomain.dom> Date: Thu, 3 Oct 2013 03:13:58 -0400 From: Paul A. Patience To: freebsd-drivers@freebsd.org Subject: [patch] sys/dev/nfe/if_nfe.c MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Oct 2013 07:14:06 -0000 Hello, I _may_ have found another bug in nfe(4). If the goal in nfe_stats_clear() is to read all the stats registers, then it is doing it wrong. It currently reads every fourth register. Here is a patch to fix this behaviour: --- if_nfe.c.original Thu Oct 3 03:10:11 2013 +++ if_nfe.c Thu Oct 3 03:11:10 2013 @@ -3205,8 +3205,8 @@ else return; - for (i = 0; i < mib_cnt; i += sizeof(uint32_t)) - NFE_READ(sc, NFE_TX_OCTET + i); + for (i = 0; i < mib_cnt; i++) + NFE_READ(sc, NFE_TX_OCTET + i*sizeof(uint32_t)); if ((sc->nfe_flags & NFE_MIB_V3) != 0) { NFE_READ(sc, NFE_TX_UNICAST); -- pap From owner-freebsd-drivers@FreeBSD.ORG Fri Oct 4 02:27:16 2013 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B13E4CCE for ; Fri, 4 Oct 2013 02:27:16 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pd0-x22a.google.com (mail-pd0-x22a.google.com [IPv6:2607:f8b0:400e:c02::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8A1902E31 for ; Fri, 4 Oct 2013 02:27:16 +0000 (UTC) Received: by mail-pd0-f170.google.com with SMTP id x10so3324000pdj.15 for ; Thu, 03 Oct 2013 19:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=/nlFLEJwPKWu7+C8NN5wUgDht4LIt+W8kmRftE6Is5M=; b=UWDXNwCSYpjh8f40Zso87MfXSnQU3lFMSsYu17HXcUgvUmYm/LDBP5itw+U4H1xSPp DUUo4IQyXKMoZgNB1Toqm6Lgv9x2F44+oSV3y6rTbkC6uNBk/KJm7HL16dYu4A/29WGy a0jfbl4qlh73h4G/sRjqrT2LWdYsVHYKAakoWw3HZtoWUPddEnilr2GIx0fe4BphWpHD /NofJkwKFROJIKdeEz5P1zx5t+az9UVSLWEYFfZBeDE9jYUvtxXbfw7w/Im2W0cNEFC3 j6C2cKWbPiM9I0j4IKAb2HQKoOZZtIuLX4FMXDugi4HDy1/6msu45IDsh+sR6ZgIKdvm 8/EQ== X-Received: by 10.68.219.194 with SMTP id pq2mr11798721pbc.52.1380853636268; Thu, 03 Oct 2013 19:27:16 -0700 (PDT) Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249]) by mx.google.com with ESMTPSA id ab4sm11238351pbc.43.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 03 Oct 2013 19:27:15 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 04 Oct 2013 11:27:12 +0900 From: Yonghyeon PYUN Date: Fri, 4 Oct 2013 11:27:12 +0900 To: "Paul A. Patience" Subject: Re: [patch] sys/dev/nfe/if_nfe.c Message-ID: <20131004022712.GB3091@michelle.cdnetworks.com> References: <64bad99f27cc6c5cafd063e2d3232e68@yourdomain.dom> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64bad99f27cc6c5cafd063e2d3232e68@yourdomain.dom> User-Agent: Mutt/1.4.2.3i Cc: freebsd-drivers@freebsd.org X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 02:27:16 -0000 On Thu, Oct 03, 2013 at 03:13:58AM -0400, Paul A. Patience wrote: > Hello, > > I _may_ have found another bug in nfe(4). > If the goal in nfe_stats_clear() is to read all > the stats registers, then it is doing it wrong. > It currently reads every fourth register. > Here is a patch to fix this behaviour: > > --- if_nfe.c.original Thu Oct 3 03:10:11 2013 > +++ if_nfe.c Thu Oct 3 03:11:10 2013 > @@ -3205,8 +3205,8 @@ > else > return; > > - for (i = 0; i < mib_cnt; i += sizeof(uint32_t)) > - NFE_READ(sc, NFE_TX_OCTET + i); > + for (i = 0; i < mib_cnt; i++) > + NFE_READ(sc, NFE_TX_OCTET + i*sizeof(uint32_t)); > > if ((sc->nfe_flags & NFE_MIB_V3) != 0) { > NFE_READ(sc, NFE_TX_UNICAST); Committed in r256038. Thanks a lot for the fix! From owner-freebsd-drivers@FreeBSD.ORG Fri Oct 4 14:34:10 2013 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B0D372B0; Fri, 4 Oct 2013 14:34:10 +0000 (UTC) (envelope-from varanasisai@gmail.com) Received: from mail-vb0-x231.google.com (mail-vb0-x231.google.com [IPv6:2607:f8b0:400c:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4F174211F; Fri, 4 Oct 2013 14:34:10 +0000 (UTC) Received: by mail-vb0-f49.google.com with SMTP id w16so2277891vbb.8 for ; Fri, 04 Oct 2013 07:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=mhXtRfBP2DNqw48TywrkxtAVWHwVbQkPtf5e4Cw/eWw=; b=HUUN/SBIPS4A84u4t6BxDO+PHz9BPVS3zXmsWLiXU+u9kMijcg2OnKbPhDqFeOvUMP KKM9iX/FFsRJzMenvPFECk3KYgeUNbbyXe1jkajYDlNzBao29YRgheBPUHxj1rb2Y1xS ps0ypDciYc3CdYBVWslsnhfHczicmyzCeVKZRUv51IKso7SFMrQjx5VGhmWEwIZoQbx1 gtF0cwLVEgOQ0f5HbC5hD0WqFjAjEUpFgVo4fiM5hiXK0TtcoP5CrQqWTgds4yuEVf/s 7IMbWCKuYD+Zc364GuR9Nu2BDvHjL/PWMdcqJuDmPqQyP22ieVR/aP8H1xy6n7g0yLOn zKGg== MIME-Version: 1.0 X-Received: by 10.58.196.148 with SMTP id im20mr352677vec.28.1380897249461; Fri, 04 Oct 2013 07:34:09 -0700 (PDT) Received: by 10.52.30.75 with HTTP; Fri, 4 Oct 2013 07:34:09 -0700 (PDT) Date: Fri, 4 Oct 2013 20:04:09 +0530 Message-ID: Subject: gptid's in fstab while installing FreeBSD using ISO From: varanasi sainath To: freebsd-drivers@freebsd.org, freebsd-fs@freebsd.org, freebsd-questions@freebsd.org, abgupta@microsoft.com Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 14:34:10 -0000 Hi All, How do I get gptid's as default in fstab while installing using FreeBSD iso file (Virtual,machine installation) ? Is this possible currently? if not how do I achieve this? I use guided partitioning while installing - If I were to tweak in to the source code which files or drivers I should be focusing on? which drivers write the contents of fstab? PS: any reason why we use device names in the place of gptid's as default in fstab. Thanks, Sainath.